{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/46705792","id":46705792,"diff_hunk":"@@ -468,6 +467,11 @@ struct sock_conn *sock_ep_connect(struct sock_ep *ep, fi_addr_t index)\n \tif (!do_retry)\n \t\tgoto err;\n \n+\tif (conn_fd > 0) {\n+\t\tclose(conn_fd);\n+\t\tconn_fd = 0;","path":"prov/sockets/src/sock_conn.c","position":51,"original_position":51,"commit_id":"edf3c2b8b30e9c25b05497690006b8eb7f2d8dcf","original_commit_id":"edf3c2b8b30e9c25b05497690006b8eb7f2d8dcf","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars.githubusercontent.com/u/3967608?v=3","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"you probably want -1 here","created_at":"2015-12-04T17:11:59Z","updated_at":"2015-12-04T17:11:59Z","html_url":"https://github.com/ofiwg/libfabric/pull/1527#discussion_r46705792","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/46705792"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1527#discussion_r46705792"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527"}}},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527","id":52693378,"html_url":"https://github.com/ofiwg/libfabric/pull/1527","diff_url":"https://github.com/ofiwg/libfabric/pull/1527.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/1527.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1527","number":1527,"state":"open","locked":false,"title":"prov/sockets: coverity scan fixes","user":{"login":"jithinjosepkl","id":6690627,"avatar_url":"https://avatars.githubusercontent.com/u/6690627?v=3","gravatar_id":"","url":"https://api.github.com/users/jithinjosepkl","html_url":"https://github.com/jithinjosepkl","followers_url":"https://api.github.com/users/jithinjosepkl/followers","following_url":"https://api.github.com/users/jithinjosepkl/following{/other_user}","gists_url":"https://api.github.com/users/jithinjosepkl/gists{/gist_id}","starred_url":"https://api.github.com/users/jithinjosepkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithinjosepkl/subscriptions","organizations_url":"https://api.github.com/users/jithinjosepkl/orgs","repos_url":"https://api.github.com/users/jithinjosepkl/repos","events_url":"https://api.github.com/users/jithinjosepkl/events{/privacy}","received_events_url":"https://api.github.com/users/jithinjosepkl/received_events","type":"User","site_admin":false},"body":"Coverity scan fixes\r\n","created_at":"2015-12-04T16:53:56Z","updated_at":"2015-12-04T17:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d4f19adb3ac77c1155f4b874e4b60f7671e6572","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/1527/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/edf3c2b8b30e9c25b05497690006b8eb7f2d8dcf","head":{"label":"jithinjosepkl:master","ref":"master","sha":"edf3c2b8b30e9c25b05497690006b8eb7f2d8dcf","user":{"login":"jithinjosepkl","id":6690627,"avatar_url":"https://avatars.githubusercontent.com/u/6690627?v=3","gravatar_id":"","url":"https://api.github.com/users/jithinjosepkl","html_url":"https://github.com/jithinjosepkl","followers_url":"https://api.github.com/users/jithinjosepkl/followers","following_url":"https://api.github.com/users/jithinjosepkl/following{/other_user}","gists_url":"https://api.github.com/users/jithinjosepkl/gists{/gist_id}","starred_url":"https://api.github.com/users/jithinjosepkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithinjosepkl/subscriptions","organizations_url":"https://api.github.com/users/jithinjosepkl/orgs","repos_url":"https://api.github.com/users/jithinjosepkl/repos","events_url":"https://api.github.com/users/jithinjosepkl/events{/privacy}","received_events_url":"https://api.github.com/users/jithinjosepkl/received_events","type":"User","site_admin":false},"repo":{"id":25373287,"name":"libfabric","full_name":"jithinjosepkl/libfabric","owner":{"login":"jithinjosepkl","id":6690627,"avatar_url":"https://avatars.githubusercontent.com/u/6690627?v=3","gravatar_id":"","url":"https://api.github.com/users/jithinjosepkl","html_url":"https://github.com/jithinjosepkl","followers_url":"https://api.github.com/users/jithinjosepkl/followers","following_url":"https://api.github.com/users/jithinjosepkl/following{/other_user}","gists_url":"https://api.github.com/users/jithinjosepkl/gists{/gist_id}","starred_url":"https://api.github.com/users/jithinjosepkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jithinjosepkl/subscriptions","organizations_url":"https://api.github.com/users/jithinjosepkl/orgs","repos_url":"https://api.github.com/users/jithinjosepkl/repos","events_url":"https://api.github.com/users/jithinjosepkl/events{/privacy}","received_events_url":"https://api.github.com/users/jithinjosepkl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jithinjosepkl/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/jithinjosepkl/libfabric","forks_url":"https://api.github.com/repos/jithinjosepkl/libfabric/forks","keys_url":"https://api.github.com/repos/jithinjosepkl/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jithinjosepkl/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jithinjosepkl/libfabric/teams","hooks_url":"https://api.github.com/repos/jithinjosepkl/libfabric/hooks","issue_events_url":"https://api.github.com/repos/jithinjosepkl/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/jithinjosepkl/libfabric/events","assignees_url":"https://api.github.com/repos/jithinjosepkl/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/jithinjosepkl/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/jithinjosepkl/libfabric/tags","blobs_url":"https://api.github.com/repos/jithinjosepkl/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jithinjosepkl/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jithinjosepkl/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/jithinjosepkl/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jithinjosepkl/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/jithinjosepkl/libfabric/languages","stargazers_url":"https://api.github.com/repos/jithinjosepkl/libfabric/stargazers","contributors_url":"https://api.github.com/repos/jithinjosepkl/libfabric/contributors","subscribers_url":"https://api.github.com/repos/jithinjosepkl/libfabric/subscribers","subscription_url":"https://api.github.com/repos/jithinjosepkl/libfabric/subscription","commits_url":"https://api.github.com/repos/jithinjosepkl/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/jithinjosepkl/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/jithinjosepkl/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/jithinjosepkl/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/jithinjosepkl/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/jithinjosepkl/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jithinjosepkl/libfabric/merges","archive_url":"https://api.github.com/repos/jithinjosepkl/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jithinjosepkl/libfabric/downloads","issues_url":"https://api.github.com/repos/jithinjosepkl/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/jithinjosepkl/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/jithinjosepkl/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/jithinjosepkl/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jithinjosepkl/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/jithinjosepkl/libfabric/releases{/id}","created_at":"2014-10-17T19:16:22Z","updated_at":"2015-04-11T16:17:09Z","pushed_at":"2015-12-04T16:51:07Z","git_url":"git://github.com/jithinjosepkl/libfabric.git","ssh_url":"git@github.com:jithinjosepkl/libfabric.git","clone_url":"https://github.com/jithinjosepkl/libfabric.git","svn_url":"https://github.com/jithinjosepkl/libfabric","homepage":null,"size":7849,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"d0b25673f889521ddb363fdcb1dd5313ab7250c3","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars.githubusercontent.com/u/8459445?v=3","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","created_at":"2014-08-15T16:45:53Z","updated_at":"2015-11-25T21:01:42Z","pushed_at":"2015-12-04T16:53:56Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://ofiwg.github.io/libfabric/","size":9379,"stargazers_count":53,"watchers_count":53,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":61,"forks":53,"open_issues":61,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/1527"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1527"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/1527/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/1527/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/edf3c2b8b30e9c25b05497690006b8eb7f2d8dcf"}}}}