{"action":"opened","number":180,"pull_request":{"url":"https://api.github.com/repos/emacs-ess/ESS/pulls/180","id":35956784,"html_url":"https://github.com/emacs-ess/ESS/pull/180","diff_url":"https://github.com/emacs-ess/ESS/pull/180.diff","patch_url":"https://github.com/emacs-ess/ESS/pull/180.patch","issue_url":"https://api.github.com/repos/emacs-ess/ESS/issues/180","number":180,"state":"open","locked":false,"title":"Fix various indentation bugs introduced in code refactor","user":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"body":"I think all examples in `R-ESS-bugs.R` work fine now and I spotted a few more bugs related to block indentation. But we still have the issue mentioned in the other PR. I copy it here to pursue the discussion:\r\n\r\n\r\nI think we have a dilemma here. Before we had\r\n```r\r\n    my.long.Expression <- expression(\r\n        x[a[j]] == exp(theta[1] + theta[2]^2),\r\n        x[b[i]] == sin(theta[3] ~~ theta[4])\r\n        )\r\n```\r\nbut now with `ess-offset-arguments-newline` set to `t` we have:\r\n```r\r\n    my.long.Expression <- expression(\r\n                              x[a[j]] == exp(theta[1] + theta[2]^2),\r\n                              x[b[i]] == sin(theta[3] ~~ theta[4])\r\n                          )\r\n```\r\n\r\nOne way out would be to implement an idea that I had for the future, which is to allow different styles depending on the depth of embeddedness of expressions. For example we could decide to have `'(t)` at level 0 and `t` beyond. This way we'd have:\r\n```r\r\nobject <- fun_call(\r\n  arg1,\r\n  arg2\r\n)\r\n```\r\nand\r\n```r\r\nobject <- fun_call(\r\n  arg1, other_call(\r\n          arg2,\r\n          arg3\r\n        ),\r\n  arg4)\r\n```\r\nUnder this scheme we'd solve the problem above. What do you think?","created_at":"2015-05-21T17:18:12Z","updated_at":"2015-05-21T17:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/180/commits","review_comments_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/180/comments","review_comment_url":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/issues/180/comments","statuses_url":"https://api.github.com/repos/emacs-ess/ESS/statuses/3fa04d93683b3adb61731db8528afdd2ce5dc549","head":{"label":"lionel-:indent-fix","ref":"indent-fix","sha":"3fa04d93683b3adb61731db8528afdd2ce5dc549","user":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"repo":{"id":34910721,"name":"ESS","full_name":"lionel-/ESS","owner":{"login":"lionel-","id":4465050,"avatar_url":"https://avatars.githubusercontent.com/u/4465050?v=3","gravatar_id":"","url":"https://api.github.com/users/lionel-","html_url":"https://github.com/lionel-","followers_url":"https://api.github.com/users/lionel-/followers","following_url":"https://api.github.com/users/lionel-/following{/other_user}","gists_url":"https://api.github.com/users/lionel-/gists{/gist_id}","starred_url":"https://api.github.com/users/lionel-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lionel-/subscriptions","organizations_url":"https://api.github.com/users/lionel-/orgs","repos_url":"https://api.github.com/users/lionel-/repos","events_url":"https://api.github.com/users/lionel-/events{/privacy}","received_events_url":"https://api.github.com/users/lionel-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lionel-/ESS","description":"Git development branch","fork":true,"url":"https://api.github.com/repos/lionel-/ESS","forks_url":"https://api.github.com/repos/lionel-/ESS/forks","keys_url":"https://api.github.com/repos/lionel-/ESS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lionel-/ESS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lionel-/ESS/teams","hooks_url":"https://api.github.com/repos/lionel-/ESS/hooks","issue_events_url":"https://api.github.com/repos/lionel-/ESS/issues/events{/number}","events_url":"https://api.github.com/repos/lionel-/ESS/events","assignees_url":"https://api.github.com/repos/lionel-/ESS/assignees{/user}","branches_url":"https://api.github.com/repos/lionel-/ESS/branches{/branch}","tags_url":"https://api.github.com/repos/lionel-/ESS/tags","blobs_url":"https://api.github.com/repos/lionel-/ESS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lionel-/ESS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lionel-/ESS/git/refs{/sha}","trees_url":"https://api.github.com/repos/lionel-/ESS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lionel-/ESS/statuses/{sha}","languages_url":"https://api.github.com/repos/lionel-/ESS/languages","stargazers_url":"https://api.github.com/repos/lionel-/ESS/stargazers","contributors_url":"https://api.github.com/repos/lionel-/ESS/contributors","subscribers_url":"https://api.github.com/repos/lionel-/ESS/subscribers","subscription_url":"https://api.github.com/repos/lionel-/ESS/subscription","commits_url":"https://api.github.com/repos/lionel-/ESS/commits{/sha}","git_commits_url":"https://api.github.com/repos/lionel-/ESS/git/commits{/sha}","comments_url":"https://api.github.com/repos/lionel-/ESS/comments{/number}","issue_comment_url":"https://api.github.com/repos/lionel-/ESS/issues/comments{/number}","contents_url":"https://api.github.com/repos/lionel-/ESS/contents/{+path}","compare_url":"https://api.github.com/repos/lionel-/ESS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lionel-/ESS/merges","archive_url":"https://api.github.com/repos/lionel-/ESS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lionel-/ESS/downloads","issues_url":"https://api.github.com/repos/lionel-/ESS/issues{/number}","pulls_url":"https://api.github.com/repos/lionel-/ESS/pulls{/number}","milestones_url":"https://api.github.com/repos/lionel-/ESS/milestones{/number}","notifications_url":"https://api.github.com/repos/lionel-/ESS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lionel-/ESS/labels{/name}","releases_url":"https://api.github.com/repos/lionel-/ESS/releases{/id}","created_at":"2015-05-01T15:59:38Z","updated_at":"2015-05-01T15:59:40Z","pushed_at":"2015-05-21T17:14:32Z","git_url":"git://github.com/lionel-/ESS.git","ssh_url":"git@github.com:lionel-/ESS.git","clone_url":"https://github.com/lionel-/ESS.git","svn_url":"https://github.com/lionel-/ESS","homepage":"http://ess.r-project.org/","size":20251,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"emacs-ess:master","ref":"master","sha":"9ca0ecfe4b2fe951e4a6618a429cb148d0c0237d","user":{"login":"emacs-ess","id":1433218,"avatar_url":"https://avatars.githubusercontent.com/u/1433218?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-ess","html_url":"https://github.com/emacs-ess","followers_url":"https://api.github.com/users/emacs-ess/followers","following_url":"https://api.github.com/users/emacs-ess/following{/other_user}","gists_url":"https://api.github.com/users/emacs-ess/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-ess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-ess/subscriptions","organizations_url":"https://api.github.com/users/emacs-ess/orgs","repos_url":"https://api.github.com/users/emacs-ess/repos","events_url":"https://api.github.com/users/emacs-ess/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-ess/received_events","type":"Organization","site_admin":false},"repo":{"id":3585447,"name":"ESS","full_name":"emacs-ess/ESS","owner":{"login":"emacs-ess","id":1433218,"avatar_url":"https://avatars.githubusercontent.com/u/1433218?v=3","gravatar_id":"","url":"https://api.github.com/users/emacs-ess","html_url":"https://github.com/emacs-ess","followers_url":"https://api.github.com/users/emacs-ess/followers","following_url":"https://api.github.com/users/emacs-ess/following{/other_user}","gists_url":"https://api.github.com/users/emacs-ess/gists{/gist_id}","starred_url":"https://api.github.com/users/emacs-ess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emacs-ess/subscriptions","organizations_url":"https://api.github.com/users/emacs-ess/orgs","repos_url":"https://api.github.com/users/emacs-ess/repos","events_url":"https://api.github.com/users/emacs-ess/events{/privacy}","received_events_url":"https://api.github.com/users/emacs-ess/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/emacs-ess/ESS","description":"Git development branch","fork":false,"url":"https://api.github.com/repos/emacs-ess/ESS","forks_url":"https://api.github.com/repos/emacs-ess/ESS/forks","keys_url":"https://api.github.com/repos/emacs-ess/ESS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emacs-ess/ESS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emacs-ess/ESS/teams","hooks_url":"https://api.github.com/repos/emacs-ess/ESS/hooks","issue_events_url":"https://api.github.com/repos/emacs-ess/ESS/issues/events{/number}","events_url":"https://api.github.com/repos/emacs-ess/ESS/events","assignees_url":"https://api.github.com/repos/emacs-ess/ESS/assignees{/user}","branches_url":"https://api.github.com/repos/emacs-ess/ESS/branches{/branch}","tags_url":"https://api.github.com/repos/emacs-ess/ESS/tags","blobs_url":"https://api.github.com/repos/emacs-ess/ESS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emacs-ess/ESS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emacs-ess/ESS/git/refs{/sha}","trees_url":"https://api.github.com/repos/emacs-ess/ESS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emacs-ess/ESS/statuses/{sha}","languages_url":"https://api.github.com/repos/emacs-ess/ESS/languages","stargazers_url":"https://api.github.com/repos/emacs-ess/ESS/stargazers","contributors_url":"https://api.github.com/repos/emacs-ess/ESS/contributors","subscribers_url":"https://api.github.com/repos/emacs-ess/ESS/subscribers","subscription_url":"https://api.github.com/repos/emacs-ess/ESS/subscription","commits_url":"https://api.github.com/repos/emacs-ess/ESS/commits{/sha}","git_commits_url":"https://api.github.com/repos/emacs-ess/ESS/git/commits{/sha}","comments_url":"https://api.github.com/repos/emacs-ess/ESS/comments{/number}","issue_comment_url":"https://api.github.com/repos/emacs-ess/ESS/issues/comments{/number}","contents_url":"https://api.github.com/repos/emacs-ess/ESS/contents/{+path}","compare_url":"https://api.github.com/repos/emacs-ess/ESS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emacs-ess/ESS/merges","archive_url":"https://api.github.com/repos/emacs-ess/ESS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emacs-ess/ESS/downloads","issues_url":"https://api.github.com/repos/emacs-ess/ESS/issues{/number}","pulls_url":"https://api.github.com/repos/emacs-ess/ESS/pulls{/number}","milestones_url":"https://api.github.com/repos/emacs-ess/ESS/milestones{/number}","notifications_url":"https://api.github.com/repos/emacs-ess/ESS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emacs-ess/ESS/labels{/name}","releases_url":"https://api.github.com/repos/emacs-ess/ESS/releases{/id}","created_at":"2012-02-29T20:13:38Z","updated_at":"2015-05-19T15:40:15Z","pushed_at":"2015-05-21T14:02:47Z","git_url":"git://github.com/emacs-ess/ESS.git","ssh_url":"git@github.com:emacs-ess/ESS.git","clone_url":"https://github.com/emacs-ess/ESS.git","svn_url":"https://github.com/emacs-ess/ESS","homepage":"http://ess.r-project.org/","size":22244,"stargazers_count":186,"watchers_count":186,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":42,"forks":55,"open_issues":42,"watchers":186,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/180"},"html":{"href":"https://github.com/emacs-ess/ESS/pull/180"},"issue":{"href":"https://api.github.com/repos/emacs-ess/ESS/issues/180"},"comments":{"href":"https://api.github.com/repos/emacs-ess/ESS/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/emacs-ess/ESS/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/emacs-ess/ESS/statuses/3fa04d93683b3adb61731db8528afdd2ce5dc549"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1552,"deletions":395,"changed_files":8}}