{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/35447409","id":35447409,"diff_hunk":"@@ -101,61 +99,74 @@\n         get :show, :name => \"testing\", :format => \"json\"\n         json = JSON.parse(response.body)\n \n-        json[\"name\"].should be_a(String)\n-        json[\"name\"].should eql(\"testing.crowbar.com\")\n+        expect(json[\"name\"]).to eq(\"testing.crowbar.com\")\n       end\n \n       it \"works with fqdn\" do\n         get :show, :name => \"testing.crowbar.com\", :format => \"json\"\n         json = JSON.parse(response.body)\n \n-        json[\"name\"].should be_a(String)\n-        json[\"name\"].should eql(\"testing.crowbar.com\")\n+        expect(json[\"name\"]).to eq(\"testing.crowbar.com\")\n       end\n     end\n \n     context \"for non-existent node\" do\n       it \"renders 404\" do\n         get :show, :name => \"nonexistent\", :format => \"json\"\n-        response.should be_not_found\n+        expect(response).to have_http_status(:not_found)\n       end\n     end\n   end\n \n+  describe \"POST role\" do\n+    context \"for existent node\" do\n+      it \"assignes role compute\" do\n+        NodeObject.any_instance.expects(:intended_role=).with(\"compute\").once\n+\n+        post :role, :name => \"testing\", :role => \"compute\", :format => \"json\"","path":"crowbar_framework/spec/controllers/machines_controller_spec.rb","position":113,"original_position":113,"commit_id":"80222ea22da5d4217f83a70f0499ae7e776d4e13","original_commit_id":"80222ea22da5d4217f83a70f0499ae7e776d4e13","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Style/HashSyntax: Use the new Ruby 1.9 hash syntax.","created_at":"2015-07-24T17:49:26Z","updated_at":"2015-07-24T17:49:26Z","html_url":"https://github.com/crowbar/barclamp-crowbar/pull/1332#discussion_r35447409","pull_request_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332","_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments/35447409"},"html":{"href":"https://github.com/crowbar/barclamp-crowbar/pull/1332#discussion_r35447409"},"pull_request":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332","id":40679016,"html_url":"https://github.com/crowbar/barclamp-crowbar/pull/1332","diff_url":"https://github.com/crowbar/barclamp-crowbar/pull/1332.diff","patch_url":"https://github.com/crowbar/barclamp-crowbar/pull/1332.patch","issue_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1332","number":1332,"state":"open","locked":false,"title":"Return proper error codes in machines controller","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-23T14:39:51Z","updated_at":"2015-07-24T17:49:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7dcdbb8d3faeeaacc705315c276bfa66a3a77eb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332/commits","review_comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332/comments","review_comment_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1332/comments","statuses_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/80222ea22da5d4217f83a70f0499ae7e776d4e13","head":{"label":"rsalevsky:machines_controller","ref":"machines_controller","sha":"80222ea22da5d4217f83a70f0499ae7e776d4e13","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"repo":{"id":30867091,"name":"barclamp-crowbar","full_name":"rsalevsky/barclamp-crowbar","owner":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsalevsky/barclamp-crowbar","description":"Crowbar Core: Core Application","fork":true,"url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar","forks_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/forks","keys_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/teams","hooks_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/hooks","issue_events_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/events","assignees_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/tags","blobs_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/languages","stargazers_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/stargazers","contributors_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/contributors","subscribers_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/subscribers","subscription_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/subscription","commits_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/merges","archive_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/downloads","issues_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/rsalevsky/barclamp-crowbar/releases{/id}","created_at":"2015-02-16T12:21:01Z","updated_at":"2015-02-16T12:21:04Z","pushed_at":"2015-07-24T15:48:22Z","git_url":"git://github.com/rsalevsky/barclamp-crowbar.git","ssh_url":"git@github.com:rsalevsky/barclamp-crowbar.git","clone_url":"https://github.com/rsalevsky/barclamp-crowbar.git","svn_url":"https://github.com/rsalevsky/barclamp-crowbar","homepage":"https://github.com/crowbar/crowbar","size":34344,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"501e581e5728ec9716e350f35cd1befa4d2f14e0","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2351384,"name":"barclamp-crowbar","full_name":"crowbar/barclamp-crowbar","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/barclamp-crowbar","description":"Crowbar Core: Core Application","fork":false,"url":"https://api.github.com/repos/crowbar/barclamp-crowbar","forks_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/forks","keys_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/teams","hooks_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/hooks","issue_events_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/events","assignees_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/tags","blobs_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/languages","stargazers_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/stargazers","contributors_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/contributors","subscribers_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/subscribers","subscription_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/subscription","commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/merges","archive_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/downloads","issues_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/barclamp-crowbar/releases{/id}","created_at":"2011-09-08T20:47:56Z","updated_at":"2015-06-22T23:56:07Z","pushed_at":"2015-07-24T15:48:23Z","git_url":"git://github.com/crowbar/barclamp-crowbar.git","ssh_url":"git@github.com:crowbar/barclamp-crowbar.git","clone_url":"https://github.com/crowbar/barclamp-crowbar.git","svn_url":"https://github.com/crowbar/barclamp-crowbar","homepage":"https://github.com/crowbar/crowbar","size":41350,"stargazers_count":74,"watchers_count":74,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":190,"mirror_url":null,"open_issues_count":16,"forks":190,"open_issues":16,"watchers":74,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332"},"html":{"href":"https://github.com/crowbar/barclamp-crowbar/pull/1332"},"issue":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1332"},"comments":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/issues/1332/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/pulls/1332/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/barclamp-crowbar/statuses/80222ea22da5d4217f83a70f0499ae7e776d4e13"}}}}