{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/3737","labels_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3737/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3737/comments","events_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3737/events","html_url":"https://github.com/puppetlabs/puppet/pull/3737","id":62949004,"number":3737,"title":"(PUP-4201) Add support for structured logging","user":{"login":"thallgren","id":209495,"avatar_url":"https://avatars.githubusercontent.com/u/209495?v=3","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-19T10:30:27Z","updated_at":"2015-03-20T18:03:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet/pulls/3737","html_url":"https://github.com/puppetlabs/puppet/pull/3737","diff_url":"https://github.com/puppetlabs/puppet/pull/3737.diff","patch_url":"https://github.com/puppetlabs/puppet/pull/3737.patch"},"body":"The main objective for this commit is to retain backward compatility\r\nwith the 3.x stream. It only touches the logged messages that stems\r\nfrom the Puppet::Pops::IssueReporter.\r\n\r\nThe commit removes the responsibility for formatting the log messages\r\nfrom the IssueReporter. Instead it passes all details to the Log\r\ninstance that is created, either by direct logging och by raising an\r\nerror. A new class named ParseErrorWithIssue (a subclass of ParseError)\r\nthat keeps track of the basic message and the issue_code was needed to\r\naccomplish this. This class is also has the attributes 'environment'\r\nand 'node' that will be assigned in rescue blocks before the exception\r\nis re-thrown. Prior to this change, the rescue block would create a\r\nnew error instance with additional information in the actual message\r\nbut loose the detailed information.\r\n\r\nThe 'file' log destination was altered slightly so that if the path\r\nends with '.json', it will output each Log entry in JSON format. The\r\nlist of entries will be prefixed by a '[' (added when the file is\r\nfirst created) and delimited with ','. The file will contain almost\r\nvalid JSON at all times but the last ']' will be missing."},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppet/issues/comments/84089929","html_url":"https://github.com/puppetlabs/puppet/pull/3737#issuecomment-84089929","issue_url":"https://api.github.com/repos/puppetlabs/puppet/issues/3737","id":84089929,"user":{"login":"thallgren","id":209495,"avatar_url":"https://avatars.githubusercontent.com/u/209495?v=3","gravatar_id":"","url":"https://api.github.com/users/thallgren","html_url":"https://github.com/thallgren","followers_url":"https://api.github.com/users/thallgren/followers","following_url":"https://api.github.com/users/thallgren/following{/other_user}","gists_url":"https://api.github.com/users/thallgren/gists{/gist_id}","starred_url":"https://api.github.com/users/thallgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thallgren/subscriptions","organizations_url":"https://api.github.com/users/thallgren/orgs","repos_url":"https://api.github.com/users/thallgren/repos","events_url":"https://api.github.com/users/thallgren/events{/privacy}","received_events_url":"https://api.github.com/users/thallgren/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T18:03:22Z","updated_at":"2015-03-20T18:03:22Z","body":"@kylog I've noticed this too. In this particular case I'm 100% sure that I saw a travis build kick in shortly after I submitted the PR. Perhaps the problem is related to not reporting back once it's done?"}}