{"action":"closed","number":13879,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/13879","id":49750301,"html_url":"https://github.com/JuliaLang/julia/pull/13879","diff_url":"https://github.com/JuliaLang/julia/pull/13879.diff","patch_url":"https://github.com/JuliaLang/julia/pull/13879.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/13879","number":13879,"state":"closed","locked":false,"title":"RFC: Added documentation and tests for Pkg.setprotocol","user":{"login":"LachlanGunn","id":427759,"avatar_url":"https://avatars.githubusercontent.com/u/427759?v=3","gravatar_id":"","url":"https://api.github.com/users/LachlanGunn","html_url":"https://github.com/LachlanGunn","followers_url":"https://api.github.com/users/LachlanGunn/followers","following_url":"https://api.github.com/users/LachlanGunn/following{/other_user}","gists_url":"https://api.github.com/users/LachlanGunn/gists{/gist_id}","starred_url":"https://api.github.com/users/LachlanGunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LachlanGunn/subscriptions","organizations_url":"https://api.github.com/users/LachlanGunn/orgs","repos_url":"https://api.github.com/users/LachlanGunn/repos","events_url":"https://api.github.com/users/LachlanGunn/events{/privacy}","received_events_url":"https://api.github.com/users/LachlanGunn/received_events","type":"User","site_admin":false},"body":"As a followup to #11312, I have added documentation and a test for Pkg.setprotocol!()\r\n\r\nThe test is performed by setting the protocol to \"notarealprotocol\" before testing Pkg.add(), and trapping the error.  This seems the most straightforward way to see what is actually being passed to Git.\r\n\r\nThe protocol is then manually reset to \"https\" in order to continue testing Pkg,add().","created_at":"2015-11-04T21:46:42Z","updated_at":"2015-11-19T04:49:09Z","closed_at":"2015-11-19T04:49:09Z","merged_at":"2015-11-19T04:49:09Z","merge_commit_sha":"ff1e469b4fe7c806a2e8d6c5aeeced6d676c5fcc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13879/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/13879/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/13879/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/74ac25e0fa57c62b3193ca3a3630e55c01d215c8","head":{"label":"LachlanGunn:master","ref":"master","sha":"74ac25e0fa57c62b3193ca3a3630e55c01d215c8","user":{"login":"LachlanGunn","id":427759,"avatar_url":"https://avatars.githubusercontent.com/u/427759?v=3","gravatar_id":"","url":"https://api.github.com/users/LachlanGunn","html_url":"https://github.com/LachlanGunn","followers_url":"https://api.github.com/users/LachlanGunn/followers","following_url":"https://api.github.com/users/LachlanGunn/following{/other_user}","gists_url":"https://api.github.com/users/LachlanGunn/gists{/gist_id}","starred_url":"https://api.github.com/users/LachlanGunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LachlanGunn/subscriptions","organizations_url":"https://api.github.com/users/LachlanGunn/orgs","repos_url":"https://api.github.com/users/LachlanGunn/repos","events_url":"https://api.github.com/users/LachlanGunn/events{/privacy}","received_events_url":"https://api.github.com/users/LachlanGunn/received_events","type":"User","site_admin":false},"repo":{"id":35706758,"name":"julia","full_name":"LachlanGunn/julia","owner":{"login":"LachlanGunn","id":427759,"avatar_url":"https://avatars.githubusercontent.com/u/427759?v=3","gravatar_id":"","url":"https://api.github.com/users/LachlanGunn","html_url":"https://github.com/LachlanGunn","followers_url":"https://api.github.com/users/LachlanGunn/followers","following_url":"https://api.github.com/users/LachlanGunn/following{/other_user}","gists_url":"https://api.github.com/users/LachlanGunn/gists{/gist_id}","starred_url":"https://api.github.com/users/LachlanGunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LachlanGunn/subscriptions","organizations_url":"https://api.github.com/users/LachlanGunn/orgs","repos_url":"https://api.github.com/users/LachlanGunn/repos","events_url":"https://api.github.com/users/LachlanGunn/events{/privacy}","received_events_url":"https://api.github.com/users/LachlanGunn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LachlanGunn/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/LachlanGunn/julia","forks_url":"https://api.github.com/repos/LachlanGunn/julia/forks","keys_url":"https://api.github.com/repos/LachlanGunn/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LachlanGunn/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LachlanGunn/julia/teams","hooks_url":"https://api.github.com/repos/LachlanGunn/julia/hooks","issue_events_url":"https://api.github.com/repos/LachlanGunn/julia/issues/events{/number}","events_url":"https://api.github.com/repos/LachlanGunn/julia/events","assignees_url":"https://api.github.com/repos/LachlanGunn/julia/assignees{/user}","branches_url":"https://api.github.com/repos/LachlanGunn/julia/branches{/branch}","tags_url":"https://api.github.com/repos/LachlanGunn/julia/tags","blobs_url":"https://api.github.com/repos/LachlanGunn/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LachlanGunn/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LachlanGunn/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/LachlanGunn/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LachlanGunn/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/LachlanGunn/julia/languages","stargazers_url":"https://api.github.com/repos/LachlanGunn/julia/stargazers","contributors_url":"https://api.github.com/repos/LachlanGunn/julia/contributors","subscribers_url":"https://api.github.com/repos/LachlanGunn/julia/subscribers","subscription_url":"https://api.github.com/repos/LachlanGunn/julia/subscription","commits_url":"https://api.github.com/repos/LachlanGunn/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/LachlanGunn/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/LachlanGunn/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/LachlanGunn/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/LachlanGunn/julia/contents/{+path}","compare_url":"https://api.github.com/repos/LachlanGunn/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LachlanGunn/julia/merges","archive_url":"https://api.github.com/repos/LachlanGunn/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LachlanGunn/julia/downloads","issues_url":"https://api.github.com/repos/LachlanGunn/julia/issues{/number}","pulls_url":"https://api.github.com/repos/LachlanGunn/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/LachlanGunn/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/LachlanGunn/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LachlanGunn/julia/labels{/name}","releases_url":"https://api.github.com/repos/LachlanGunn/julia/releases{/id}","created_at":"2015-05-16T02:34:27Z","updated_at":"2015-05-16T02:34:32Z","pushed_at":"2015-11-04T23:55:21Z","git_url":"git://github.com/LachlanGunn/julia.git","ssh_url":"git@github.com:LachlanGunn/julia.git","clone_url":"https://github.com/LachlanGunn/julia.git","svn_url":"https://github.com/LachlanGunn/julia","homepage":"http://julialang.org/","size":88768,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"1d270c6869bd8e4c87a7aa4b879bed8921f5e866","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars.githubusercontent.com/u/743164?v=3","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","created_at":"2011-04-21T07:01:50Z","updated_at":"2015-11-19T02:08:25Z","pushed_at":"2015-11-19T04:49:10Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"http://julialang.org/","size":113648,"stargazers_count":6298,"watchers_count":6298,"language":"Julia","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1404,"mirror_url":null,"open_issues_count":1488,"forks":1404,"open_issues":1488,"watchers":6298,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13879"},"html":{"href":"https://github.com/JuliaLang/julia/pull/13879"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/13879"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/13879/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13879/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/13879/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/74ac25e0fa57c62b3193ca3a3630e55c01d215c8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"comments":30,"review_comments":3,"commits":1,"additions":35,"deletions":1,"changed_files":4}}