{"action":"created","comment":{"url":"https://api.github.com/repos/eslint/eslint/pulls/comments/36571738","id":36571738,"diff_hunk":"@@ -0,0 +1,30 @@\n+/**\n+ * global-require\n+ */\n+\n+'use strict';\n+\n+var ACCEPTABLE_PARENTS = [\n+    'AssignmentExpression',\n+    'VariableDeclarator',\n+    'MemberExpression',\n+    'ExpressionStatement',\n+    'Program',\n+    'VariableDeclaration'\n+];\n+\n+module.exports = function(context) {\n+    return {\n+        \"CallExpression\": function(node) {\n+            if (node.callee.name === \"require\") {\n+                var isGoodRequire = context.getAncestors().every(function(x) {\n+                    return ACCEPTABLE_PARENTS.indexOf(x.type) > -1;\n+                });\n+                 if (!isGoodRequire) {\n+                        context.report(node, \"Unexpected require() inside a block statement\");","path":"lib/rules/global-require.js","position":24,"original_position":24,"commit_id":"a10dab591f24db13391bb7941ced9489a0d029fc","original_commit_id":"a10dab591f24db13391bb7941ced9489a0d029fc","user":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"body":"Anyone have a better error message","created_at":"2015-08-08T00:14:48Z","updated_at":"2015-08-08T00:14:48Z","html_url":"https://github.com/eslint/eslint/pull/3326#discussion_r36571738","pull_request_url":"https://api.github.com/repos/eslint/eslint/pulls/3326","_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments/36571738"},"html":{"href":"https://github.com/eslint/eslint/pull/3326#discussion_r36571738"},"pull_request":{"href":"https://api.github.com/repos/eslint/eslint/pulls/3326"}}},"pull_request":{"url":"https://api.github.com/repos/eslint/eslint/pulls/3326","id":41944075,"html_url":"https://github.com/eslint/eslint/pull/3326","diff_url":"https://github.com/eslint/eslint/pull/3326.diff","patch_url":"https://github.com/eslint/eslint/pull/3326.patch","issue_url":"https://api.github.com/repos/eslint/eslint/issues/3326","number":3326,"state":"open","locked":false,"title":"New: global-require rule (fixes #2318)","user":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"body":"Still needs docs, but feel free to review the code :)","created_at":"2015-08-08T00:14:12Z","updated_at":"2015-08-08T00:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c688b30fdf4e003550b7e0cc262db1bbe2940439","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/eslint/eslint/pulls/3326/commits","review_comments_url":"https://api.github.com/repos/eslint/eslint/pulls/3326/comments","review_comment_url":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eslint/eslint/issues/3326/comments","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/a10dab591f24db13391bb7941ced9489a0d029fc","head":{"label":"xjamundx:global-require","ref":"global-require","sha":"a10dab591f24db13391bb7941ced9489a0d029fc","user":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"repo":{"id":11397529,"name":"eslint","full_name":"xjamundx/eslint","owner":{"login":"xjamundx","id":246143,"avatar_url":"https://avatars.githubusercontent.com/u/246143?v=3","gravatar_id":"","url":"https://api.github.com/users/xjamundx","html_url":"https://github.com/xjamundx","followers_url":"https://api.github.com/users/xjamundx/followers","following_url":"https://api.github.com/users/xjamundx/following{/other_user}","gists_url":"https://api.github.com/users/xjamundx/gists{/gist_id}","starred_url":"https://api.github.com/users/xjamundx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xjamundx/subscriptions","organizations_url":"https://api.github.com/users/xjamundx/orgs","repos_url":"https://api.github.com/users/xjamundx/repos","events_url":"https://api.github.com/users/xjamundx/events{/privacy}","received_events_url":"https://api.github.com/users/xjamundx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xjamundx/eslint","description":"A tool for identifying and reporting on patterns in JavaScript.","fork":true,"url":"https://api.github.com/repos/xjamundx/eslint","forks_url":"https://api.github.com/repos/xjamundx/eslint/forks","keys_url":"https://api.github.com/repos/xjamundx/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xjamundx/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xjamundx/eslint/teams","hooks_url":"https://api.github.com/repos/xjamundx/eslint/hooks","issue_events_url":"https://api.github.com/repos/xjamundx/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/xjamundx/eslint/events","assignees_url":"https://api.github.com/repos/xjamundx/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/xjamundx/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/xjamundx/eslint/tags","blobs_url":"https://api.github.com/repos/xjamundx/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xjamundx/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xjamundx/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/xjamundx/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xjamundx/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/xjamundx/eslint/languages","stargazers_url":"https://api.github.com/repos/xjamundx/eslint/stargazers","contributors_url":"https://api.github.com/repos/xjamundx/eslint/contributors","subscribers_url":"https://api.github.com/repos/xjamundx/eslint/subscribers","subscription_url":"https://api.github.com/repos/xjamundx/eslint/subscription","commits_url":"https://api.github.com/repos/xjamundx/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/xjamundx/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/xjamundx/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/xjamundx/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/xjamundx/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/xjamundx/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xjamundx/eslint/merges","archive_url":"https://api.github.com/repos/xjamundx/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xjamundx/eslint/downloads","issues_url":"https://api.github.com/repos/xjamundx/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/xjamundx/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/xjamundx/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/xjamundx/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xjamundx/eslint/labels{/name}","releases_url":"https://api.github.com/repos/xjamundx/eslint/releases{/id}","created_at":"2013-07-14T02:55:37Z","updated_at":"2014-03-27T15:48:24Z","pushed_at":"2015-08-08T00:13:50Z","git_url":"git://github.com/xjamundx/eslint.git","ssh_url":"git@github.com:xjamundx/eslint.git","clone_url":"https://github.com/xjamundx/eslint.git","svn_url":"https://github.com/xjamundx/eslint","homepage":null,"size":6438,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eslint:master","ref":"master","sha":"a222f544f527fa1aa462850e8ba559f8e5dec33d","user":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"repo":{"id":11061773,"name":"eslint","full_name":"eslint/eslint","owner":{"login":"eslint","id":6019716,"avatar_url":"https://avatars.githubusercontent.com/u/6019716?v=3","gravatar_id":"","url":"https://api.github.com/users/eslint","html_url":"https://github.com/eslint","followers_url":"https://api.github.com/users/eslint/followers","following_url":"https://api.github.com/users/eslint/following{/other_user}","gists_url":"https://api.github.com/users/eslint/gists{/gist_id}","starred_url":"https://api.github.com/users/eslint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eslint/subscriptions","organizations_url":"https://api.github.com/users/eslint/orgs","repos_url":"https://api.github.com/users/eslint/repos","events_url":"https://api.github.com/users/eslint/events{/privacy}","received_events_url":"https://api.github.com/users/eslint/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eslint/eslint","description":"A fully pluggable tool for identifying and reporting on patterns in JavaScript.","fork":false,"url":"https://api.github.com/repos/eslint/eslint","forks_url":"https://api.github.com/repos/eslint/eslint/forks","keys_url":"https://api.github.com/repos/eslint/eslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eslint/eslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eslint/eslint/teams","hooks_url":"https://api.github.com/repos/eslint/eslint/hooks","issue_events_url":"https://api.github.com/repos/eslint/eslint/issues/events{/number}","events_url":"https://api.github.com/repos/eslint/eslint/events","assignees_url":"https://api.github.com/repos/eslint/eslint/assignees{/user}","branches_url":"https://api.github.com/repos/eslint/eslint/branches{/branch}","tags_url":"https://api.github.com/repos/eslint/eslint/tags","blobs_url":"https://api.github.com/repos/eslint/eslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eslint/eslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eslint/eslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/eslint/eslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eslint/eslint/statuses/{sha}","languages_url":"https://api.github.com/repos/eslint/eslint/languages","stargazers_url":"https://api.github.com/repos/eslint/eslint/stargazers","contributors_url":"https://api.github.com/repos/eslint/eslint/contributors","subscribers_url":"https://api.github.com/repos/eslint/eslint/subscribers","subscription_url":"https://api.github.com/repos/eslint/eslint/subscription","commits_url":"https://api.github.com/repos/eslint/eslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/eslint/eslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/eslint/eslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/eslint/eslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/eslint/eslint/contents/{+path}","compare_url":"https://api.github.com/repos/eslint/eslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eslint/eslint/merges","archive_url":"https://api.github.com/repos/eslint/eslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eslint/eslint/downloads","issues_url":"https://api.github.com/repos/eslint/eslint/issues{/number}","pulls_url":"https://api.github.com/repos/eslint/eslint/pulls{/number}","milestones_url":"https://api.github.com/repos/eslint/eslint/milestones{/number}","notifications_url":"https://api.github.com/repos/eslint/eslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eslint/eslint/labels{/name}","releases_url":"https://api.github.com/repos/eslint/eslint/releases{/id}","created_at":"2013-06-29T23:59:48Z","updated_at":"2015-08-07T20:37:45Z","pushed_at":"2015-08-08T00:14:13Z","git_url":"git://github.com/eslint/eslint.git","ssh_url":"git@github.com:eslint/eslint.git","clone_url":"https://github.com/eslint/eslint.git","svn_url":"https://github.com/eslint/eslint","homepage":"http://eslint.org","size":18874,"stargazers_count":2665,"watchers_count":2665,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":500,"mirror_url":null,"open_issues_count":155,"forks":500,"open_issues":155,"watchers":2665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eslint/eslint/pulls/3326"},"html":{"href":"https://github.com/eslint/eslint/pull/3326"},"issue":{"href":"https://api.github.com/repos/eslint/eslint/issues/3326"},"comments":{"href":"https://api.github.com/repos/eslint/eslint/issues/3326/comments"},"review_comments":{"href":"https://api.github.com/repos/eslint/eslint/pulls/3326/comments"},"review_comment":{"href":"https://api.github.com/repos/eslint/eslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eslint/eslint/pulls/3326/commits"},"statuses":{"href":"https://api.github.com/repos/eslint/eslint/statuses/a10dab591f24db13391bb7941ced9489a0d029fc"}}}}