{"action":"created","comment":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/34612989","id":34612989,"diff_hunk":"@@ -3,23 +3,34 @@ class NameCollisionError < RuntimeError; end\n class Robot\n   attr_accessor :name\n \n-  @@registry\n-\n   def initialize(args = {})\n-    @@registry ||= []\n+    @registry ||= []\n     @name_generator = args[:name_generator]\n \n-    if @name_generator\n-      @name = @name_generator.call\n-    else\n-      generate_char = -> { ('A'..'Z').to_a.sample }\n-      generate_num = -> { rand(10) }\n+    @name_generator ? @name = @name_generator.call : generate_name\n+    @registry << @name if valid_name?\n+  end\n+\n+  def generate_name\n+    generate_char = -> { ('A'..'Z').to_a.sample }\n+    generate_num = -> { rand(10) }","path":"robot_name/robot_name.rb","position":22,"original_position":22,"commit_id":"a72dea24afcb34391b41f90257424096e8255690","original_commit_id":"a72dea24afcb34391b41f90257424096e8255690","user":{"login":"djkotowski","id":2326295,"avatar_url":"https://avatars.githubusercontent.com/u/2326295?v=3","gravatar_id":"","url":"https://api.github.com/users/djkotowski","html_url":"https://github.com/djkotowski","followers_url":"https://api.github.com/users/djkotowski/followers","following_url":"https://api.github.com/users/djkotowski/following{/other_user}","gists_url":"https://api.github.com/users/djkotowski/gists{/gist_id}","starred_url":"https://api.github.com/users/djkotowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djkotowski/subscriptions","organizations_url":"https://api.github.com/users/djkotowski/orgs","repos_url":"https://api.github.com/users/djkotowski/repos","events_url":"https://api.github.com/users/djkotowski/events{/privacy}","received_events_url":"https://api.github.com/users/djkotowski/received_events","type":"User","site_admin":false},"body":"The two procs above could be made into methods for clarity.","created_at":"2015-07-14T20:07:26Z","updated_at":"2015-07-14T20:07:26Z","html_url":"https://github.com/jmmastey/level_up_exercises/pull/800#discussion_r34612989","pull_request_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800","_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments/34612989"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/800#discussion_r34612989"},"pull_request":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800"}}},"pull_request":{"url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800","id":39808649,"html_url":"https://github.com/jmmastey/level_up_exercises/pull/800","diff_url":"https://github.com/jmmastey/level_up_exercises/pull/800.diff","patch_url":"https://github.com/jmmastey/level_up_exercises/pull/800.patch","issue_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/800","number":800,"state":"open","locked":false,"title":"Fixed robot file, ready to check","user":{"login":"oharace","id":3776680,"avatar_url":"https://avatars.githubusercontent.com/u/3776680?v=3","gravatar_id":"","url":"https://api.github.com/users/oharace","html_url":"https://github.com/oharace","followers_url":"https://api.github.com/users/oharace/followers","following_url":"https://api.github.com/users/oharace/following{/other_user}","gists_url":"https://api.github.com/users/oharace/gists{/gist_id}","starred_url":"https://api.github.com/users/oharace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oharace/subscriptions","organizations_url":"https://api.github.com/users/oharace/orgs","repos_url":"https://api.github.com/users/oharace/repos","events_url":"https://api.github.com/users/oharace/events{/privacy}","received_events_url":"https://api.github.com/users/oharace/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-13T12:59:33Z","updated_at":"2015-07-14T20:07:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c00eb914ed2b7647e7c379e9ac23a49f257fda1e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800/commits","review_comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800/comments","review_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/800/comments","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/a72dea24afcb34391b41f90257424096e8255690","head":{"label":"oharace:robot","ref":"robot","sha":"a72dea24afcb34391b41f90257424096e8255690","user":{"login":"oharace","id":3776680,"avatar_url":"https://avatars.githubusercontent.com/u/3776680?v=3","gravatar_id":"","url":"https://api.github.com/users/oharace","html_url":"https://github.com/oharace","followers_url":"https://api.github.com/users/oharace/followers","following_url":"https://api.github.com/users/oharace/following{/other_user}","gists_url":"https://api.github.com/users/oharace/gists{/gist_id}","starred_url":"https://api.github.com/users/oharace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oharace/subscriptions","organizations_url":"https://api.github.com/users/oharace/orgs","repos_url":"https://api.github.com/users/oharace/repos","events_url":"https://api.github.com/users/oharace/events{/privacy}","received_events_url":"https://api.github.com/users/oharace/received_events","type":"User","site_admin":false},"repo":{"id":38769756,"name":"level_up_exercises","full_name":"oharace/level_up_exercises","owner":{"login":"oharace","id":3776680,"avatar_url":"https://avatars.githubusercontent.com/u/3776680?v=3","gravatar_id":"","url":"https://api.github.com/users/oharace","html_url":"https://github.com/oharace","followers_url":"https://api.github.com/users/oharace/followers","following_url":"https://api.github.com/users/oharace/following{/other_user}","gists_url":"https://api.github.com/users/oharace/gists{/gist_id}","starred_url":"https://api.github.com/users/oharace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oharace/subscriptions","organizations_url":"https://api.github.com/users/oharace/orgs","repos_url":"https://api.github.com/users/oharace/repos","events_url":"https://api.github.com/users/oharace/events{/privacy}","received_events_url":"https://api.github.com/users/oharace/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oharace/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":true,"url":"https://api.github.com/repos/oharace/level_up_exercises","forks_url":"https://api.github.com/repos/oharace/level_up_exercises/forks","keys_url":"https://api.github.com/repos/oharace/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oharace/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oharace/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/oharace/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/oharace/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/oharace/level_up_exercises/events","assignees_url":"https://api.github.com/repos/oharace/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/oharace/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/oharace/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/oharace/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oharace/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oharace/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/oharace/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oharace/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/oharace/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/oharace/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/oharace/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/oharace/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/oharace/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/oharace/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/oharace/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/oharace/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/oharace/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/oharace/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/oharace/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oharace/level_up_exercises/merges","archive_url":"https://api.github.com/repos/oharace/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oharace/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/oharace/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/oharace/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/oharace/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/oharace/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oharace/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/oharace/level_up_exercises/releases{/id}","created_at":"2015-07-08T17:40:35Z","updated_at":"2015-07-08T17:40:35Z","pushed_at":"2015-07-13T13:10:07Z","git_url":"git://github.com/oharace/level_up_exercises.git","ssh_url":"git@github.com:oharace/level_up_exercises.git","clone_url":"https://github.com/oharace/level_up_exercises.git","svn_url":"https://github.com/oharace/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":326,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jmmastey:master","ref":"master","sha":"057b4969214f82f6a79748501b269e1dc296f49b","user":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"repo":{"id":20705648,"name":"level_up_exercises","full_name":"jmmastey/level_up_exercises","owner":{"login":"jmmastey","id":302011,"avatar_url":"https://avatars.githubusercontent.com/u/302011?v=3","gravatar_id":"","url":"https://api.github.com/users/jmmastey","html_url":"https://github.com/jmmastey","followers_url":"https://api.github.com/users/jmmastey/followers","following_url":"https://api.github.com/users/jmmastey/following{/other_user}","gists_url":"https://api.github.com/users/jmmastey/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmastey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmastey/subscriptions","organizations_url":"https://api.github.com/users/jmmastey/orgs","repos_url":"https://api.github.com/users/jmmastey/repos","events_url":"https://api.github.com/users/jmmastey/events{/privacy}","received_events_url":"https://api.github.com/users/jmmastey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmastey/level_up_exercises","description":"A series of code-related assignments to challenge starting engineers","fork":false,"url":"https://api.github.com/repos/jmmastey/level_up_exercises","forks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/forks","keys_url":"https://api.github.com/repos/jmmastey/level_up_exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmastey/level_up_exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmastey/level_up_exercises/teams","hooks_url":"https://api.github.com/repos/jmmastey/level_up_exercises/hooks","issue_events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/events{/number}","events_url":"https://api.github.com/repos/jmmastey/level_up_exercises/events","assignees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/assignees{/user}","branches_url":"https://api.github.com/repos/jmmastey/level_up_exercises/branches{/branch}","tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/tags","blobs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmastey/level_up_exercises/languages","stargazers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/stargazers","contributors_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contributors","subscribers_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscribers","subscription_url":"https://api.github.com/repos/jmmastey/level_up_exercises/subscription","commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmastey/level_up_exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmastey/level_up_exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmastey/level_up_exercises/contents/{+path}","compare_url":"https://api.github.com/repos/jmmastey/level_up_exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmastey/level_up_exercises/merges","archive_url":"https://api.github.com/repos/jmmastey/level_up_exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmastey/level_up_exercises/downloads","issues_url":"https://api.github.com/repos/jmmastey/level_up_exercises/issues{/number}","pulls_url":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmastey/level_up_exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmastey/level_up_exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmastey/level_up_exercises/labels{/name}","releases_url":"https://api.github.com/repos/jmmastey/level_up_exercises/releases{/id}","created_at":"2014-06-10T23:42:24Z","updated_at":"2015-07-09T21:47:15Z","pushed_at":"2015-07-14T19:32:43Z","git_url":"git://github.com/jmmastey/level_up_exercises.git","ssh_url":"git@github.com:jmmastey/level_up_exercises.git","clone_url":"https://github.com/jmmastey/level_up_exercises.git","svn_url":"https://github.com/jmmastey/level_up_exercises","homepage":"http://leveluprails.herokuapp.com","size":160360,"stargazers_count":27,"watchers_count":27,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":19,"forks":121,"open_issues":19,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800"},"html":{"href":"https://github.com/jmmastey/level_up_exercises/pull/800"},"issue":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/800"},"comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/issues/800/comments"},"review_comments":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800/comments"},"review_comment":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/pulls/800/commits"},"statuses":{"href":"https://api.github.com/repos/jmmastey/level_up_exercises/statuses/a72dea24afcb34391b41f90257424096e8255690"}}}}