{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31337798","id":31337798,"diff_hunk":"@@ -111,6 +111,11 @@ func isDefaultRegistryMatch(image string) bool {\n \t\treturn true\n \t}\n \n+\tif parts[0] == \"docker.io\" || parts[0] == \"index.docker.io\" {","path":"pkg/credentialprovider/keyring.go","position":4,"original_position":4,"commit_id":"e1495679919b370326561b3de19fc916a383e2ee","original_commit_id":"e1495679919b370326561b3de19fc916a383e2ee","user":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"body":"could parts be a zero length slice at this point?","created_at":"2015-05-29T15:58:06Z","updated_at":"2015-05-29T15:58:06Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8863#discussion_r31337798","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/31337798"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8863#discussion_r31337798"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863","id":36307237,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8863","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8863.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8863.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8863","number":8863,"state":"open","locked":false,"title":"Add 'docker.io' and 'index.docker.io' to default registry matcher","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Michal Fojtik <mfojtik@redhat.com>","created_at":"2015-05-27T14:07:46Z","updated_at":"2015-05-29T15:58:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b42ee1dbca54e3611eab43855fde0d1d74a7ae6f","assignee":{"login":"erictune","id":8105590,"avatar_url":"https://avatars.githubusercontent.com/u/8105590?v=3","gravatar_id":"","url":"https://api.github.com/users/erictune","html_url":"https://github.com/erictune","followers_url":"https://api.github.com/users/erictune/followers","following_url":"https://api.github.com/users/erictune/following{/other_user}","gists_url":"https://api.github.com/users/erictune/gists{/gist_id}","starred_url":"https://api.github.com/users/erictune/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erictune/subscriptions","organizations_url":"https://api.github.com/users/erictune/orgs","repos_url":"https://api.github.com/users/erictune/repos","events_url":"https://api.github.com/users/erictune/events{/privacy}","received_events_url":"https://api.github.com/users/erictune/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8863/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/e1495679919b370326561b3de19fc916a383e2ee","head":{"label":"mfojtik:fix-default-registry-matcher","ref":"fix-default-registry-matcher","sha":"e1495679919b370326561b3de19fc916a383e2ee","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22151842,"name":"kubernetes","full_name":"mfojtik/kubernetes","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/mfojtik/kubernetes","forks_url":"https://api.github.com/repos/mfojtik/kubernetes/forks","keys_url":"https://api.github.com/repos/mfojtik/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/kubernetes/teams","hooks_url":"https://api.github.com/repos/mfojtik/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/kubernetes/events","assignees_url":"https://api.github.com/repos/mfojtik/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/kubernetes/tags","blobs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/kubernetes/languages","stargazers_url":"https://api.github.com/repos/mfojtik/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/kubernetes/subscription","commits_url":"https://api.github.com/repos/mfojtik/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/kubernetes/merges","archive_url":"https://api.github.com/repos/mfojtik/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/kubernetes/downloads","issues_url":"https://api.github.com/repos/mfojtik/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/kubernetes/releases{/id}","created_at":"2014-07-23T14:06:52Z","updated_at":"2015-05-07T09:05:00Z","pushed_at":"2015-05-29T07:48:42Z","git_url":"git://github.com/mfojtik/kubernetes.git","ssh_url":"git@github.com:mfojtik/kubernetes.git","clone_url":"https://github.com/mfojtik/kubernetes.git","svn_url":"https://github.com/mfojtik/kubernetes","homepage":null,"size":60571,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f015a2102662d983abb981ed3202210400b9aafe","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-05-29T15:07:02Z","pushed_at":"2015-05-29T15:52:35Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":296344,"stargazers_count":7983,"watchers_count":7983,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1673,"mirror_url":null,"open_issues_count":1255,"forks":1673,"open_issues":1255,"watchers":7983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/8863"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8863"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/8863/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/8863/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/e1495679919b370326561b3de19fc916a383e2ee"}}}}