{"action":"created","comment":{"url":"https://api.github.com/repos/HDFGroup/h5serv/pulls/comments/29734921","id":29734921,"diff_hunk":"@@ -366,29 +366,28 @@ def createBaseDataType(typeItem):\n         if not shape:\n             raise KeyError(\"'shape' must be provided for array types\")\n         if 'base' not in typeItem:\n-            raise KeyError(\"'base' not provided\") \n-        baseType = getNumpyTypename(typeItem['base'])\n-        if type(baseType) not in  (str, unicode):\n+            raise KeyError(\"'base' not provided\")\n+        baseType = getNumpyTypename(typeItem['base']['base'])","path":"server/hdf5dtype.py","position":300,"original_position":300,"commit_id":"74949af0be6ef2f40d369dc42ffd8e97ea5fafbb","original_commit_id":"74949af0be6ef2f40d369dc42ffd8e97ea5fafbb","user":{"login":"ajelenak-thg","id":7944846,"avatar_url":"https://avatars.githubusercontent.com/u/7944846?v=3","gravatar_id":"","url":"https://api.github.com/users/ajelenak-thg","html_url":"https://github.com/ajelenak-thg","followers_url":"https://api.github.com/users/ajelenak-thg/followers","following_url":"https://api.github.com/users/ajelenak-thg/following{/other_user}","gists_url":"https://api.github.com/users/ajelenak-thg/gists{/gist_id}","starred_url":"https://api.github.com/users/ajelenak-thg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajelenak-thg/subscriptions","organizations_url":"https://api.github.com/users/ajelenak-thg/orgs","repos_url":"https://api.github.com/users/ajelenak-thg/repos","events_url":"https://api.github.com/users/ajelenak-thg/events{/privacy}","received_events_url":"https://api.github.com/users/ajelenak-thg/received_events","type":"User","site_admin":false},"body":"One more ``['base']`` required to pull out H5T_ARRAY base's base datatype.","created_at":"2015-05-06T05:16:02Z","updated_at":"2015-05-06T05:16:02Z","html_url":"https://github.com/HDFGroup/h5serv/pull/47#discussion_r29734921","pull_request_url":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47","_links":{"self":{"href":"https://api.github.com/repos/HDFGroup/h5serv/pulls/comments/29734921"},"html":{"href":"https://github.com/HDFGroup/h5serv/pull/47#discussion_r29734921"},"pull_request":{"href":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47"}}},"pull_request":{"url":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47","id":34789160,"html_url":"https://github.com/HDFGroup/h5serv/pull/47","diff_url":"https://github.com/HDFGroup/h5serv/pull/47.diff","patch_url":"https://github.com/HDFGroup/h5serv/pull/47.patch","issue_url":"https://api.github.com/repos/HDFGroup/h5serv/issues/47","number":47,"state":"open","locked":false,"title":"Correctly process H5T_ARRAY datatype in a compound","user":{"login":"ajelenak-thg","id":7944846,"avatar_url":"https://avatars.githubusercontent.com/u/7944846?v=3","gravatar_id":"","url":"https://api.github.com/users/ajelenak-thg","html_url":"https://github.com/ajelenak-thg","followers_url":"https://api.github.com/users/ajelenak-thg/followers","following_url":"https://api.github.com/users/ajelenak-thg/following{/other_user}","gists_url":"https://api.github.com/users/ajelenak-thg/gists{/gist_id}","starred_url":"https://api.github.com/users/ajelenak-thg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajelenak-thg/subscriptions","organizations_url":"https://api.github.com/users/ajelenak-thg/orgs","repos_url":"https://api.github.com/users/ajelenak-thg/repos","events_url":"https://api.github.com/users/ajelenak-thg/events{/privacy}","received_events_url":"https://api.github.com/users/ajelenak-thg/received_events","type":"User","site_admin":false},"body":"Fixes \"[Errno 22] Unable to create type: 'shape' must be provided for array types\" error. See: HDFGroup/hpd-ws#27","created_at":"2015-05-06T05:10:05Z","updated_at":"2015-05-06T05:16:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"39d5927edd8f45173f3b8f8514c738eaefaab3e8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47/commits","review_comments_url":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47/comments","review_comment_url":"https://api.github.com/repos/HDFGroup/h5serv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HDFGroup/h5serv/issues/47/comments","statuses_url":"https://api.github.com/repos/HDFGroup/h5serv/statuses/74949af0be6ef2f40d369dc42ffd8e97ea5fafbb","head":{"label":"HDFGroup:compound-h5tarray","ref":"compound-h5tarray","sha":"74949af0be6ef2f40d369dc42ffd8e97ea5fafbb","user":{"login":"HDFGroup","id":8572050,"avatar_url":"https://avatars.githubusercontent.com/u/8572050?v=3","gravatar_id":"","url":"https://api.github.com/users/HDFGroup","html_url":"https://github.com/HDFGroup","followers_url":"https://api.github.com/users/HDFGroup/followers","following_url":"https://api.github.com/users/HDFGroup/following{/other_user}","gists_url":"https://api.github.com/users/HDFGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/HDFGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HDFGroup/subscriptions","organizations_url":"https://api.github.com/users/HDFGroup/orgs","repos_url":"https://api.github.com/users/HDFGroup/repos","events_url":"https://api.github.com/users/HDFGroup/events{/privacy}","received_events_url":"https://api.github.com/users/HDFGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":23676062,"name":"h5serv","full_name":"HDFGroup/h5serv","owner":{"login":"HDFGroup","id":8572050,"avatar_url":"https://avatars.githubusercontent.com/u/8572050?v=3","gravatar_id":"","url":"https://api.github.com/users/HDFGroup","html_url":"https://github.com/HDFGroup","followers_url":"https://api.github.com/users/HDFGroup/followers","following_url":"https://api.github.com/users/HDFGroup/following{/other_user}","gists_url":"https://api.github.com/users/HDFGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/HDFGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HDFGroup/subscriptions","organizations_url":"https://api.github.com/users/HDFGroup/orgs","repos_url":"https://api.github.com/users/HDFGroup/repos","events_url":"https://api.github.com/users/HDFGroup/events{/privacy}","received_events_url":"https://api.github.com/users/HDFGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HDFGroup/h5serv","description":"Reference service implementation of the HDF5 REST API","fork":false,"url":"https://api.github.com/repos/HDFGroup/h5serv","forks_url":"https://api.github.com/repos/HDFGroup/h5serv/forks","keys_url":"https://api.github.com/repos/HDFGroup/h5serv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HDFGroup/h5serv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HDFGroup/h5serv/teams","hooks_url":"https://api.github.com/repos/HDFGroup/h5serv/hooks","issue_events_url":"https://api.github.com/repos/HDFGroup/h5serv/issues/events{/number}","events_url":"https://api.github.com/repos/HDFGroup/h5serv/events","assignees_url":"https://api.github.com/repos/HDFGroup/h5serv/assignees{/user}","branches_url":"https://api.github.com/repos/HDFGroup/h5serv/branches{/branch}","tags_url":"https://api.github.com/repos/HDFGroup/h5serv/tags","blobs_url":"https://api.github.com/repos/HDFGroup/h5serv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HDFGroup/h5serv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HDFGroup/h5serv/git/refs{/sha}","trees_url":"https://api.github.com/repos/HDFGroup/h5serv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HDFGroup/h5serv/statuses/{sha}","languages_url":"https://api.github.com/repos/HDFGroup/h5serv/languages","stargazers_url":"https://api.github.com/repos/HDFGroup/h5serv/stargazers","contributors_url":"https://api.github.com/repos/HDFGroup/h5serv/contributors","subscribers_url":"https://api.github.com/repos/HDFGroup/h5serv/subscribers","subscription_url":"https://api.github.com/repos/HDFGroup/h5serv/subscription","commits_url":"https://api.github.com/repos/HDFGroup/h5serv/commits{/sha}","git_commits_url":"https://api.github.com/repos/HDFGroup/h5serv/git/commits{/sha}","comments_url":"https://api.github.com/repos/HDFGroup/h5serv/comments{/number}","issue_comment_url":"https://api.github.com/repos/HDFGroup/h5serv/issues/comments{/number}","contents_url":"https://api.github.com/repos/HDFGroup/h5serv/contents/{+path}","compare_url":"https://api.github.com/repos/HDFGroup/h5serv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HDFGroup/h5serv/merges","archive_url":"https://api.github.com/repos/HDFGroup/h5serv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HDFGroup/h5serv/downloads","issues_url":"https://api.github.com/repos/HDFGroup/h5serv/issues{/number}","pulls_url":"https://api.github.com/repos/HDFGroup/h5serv/pulls{/number}","milestones_url":"https://api.github.com/repos/HDFGroup/h5serv/milestones{/number}","notifications_url":"https://api.github.com/repos/HDFGroup/h5serv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HDFGroup/h5serv/labels{/name}","releases_url":"https://api.github.com/repos/HDFGroup/h5serv/releases{/id}","created_at":"2014-09-04T19:21:38Z","updated_at":"2015-04-25T17:10:37Z","pushed_at":"2015-05-06T05:10:05Z","git_url":"git://github.com/HDFGroup/h5serv.git","ssh_url":"git@github.com:HDFGroup/h5serv.git","clone_url":"https://github.com/HDFGroup/h5serv.git","svn_url":"https://github.com/HDFGroup/h5serv","homepage":null,"size":1984,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":8,"default_branch":"master"}},"base":{"label":"HDFGroup:master","ref":"master","sha":"8d7487718fd65f4a5321a6ebd6b4a1711e01110b","user":{"login":"HDFGroup","id":8572050,"avatar_url":"https://avatars.githubusercontent.com/u/8572050?v=3","gravatar_id":"","url":"https://api.github.com/users/HDFGroup","html_url":"https://github.com/HDFGroup","followers_url":"https://api.github.com/users/HDFGroup/followers","following_url":"https://api.github.com/users/HDFGroup/following{/other_user}","gists_url":"https://api.github.com/users/HDFGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/HDFGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HDFGroup/subscriptions","organizations_url":"https://api.github.com/users/HDFGroup/orgs","repos_url":"https://api.github.com/users/HDFGroup/repos","events_url":"https://api.github.com/users/HDFGroup/events{/privacy}","received_events_url":"https://api.github.com/users/HDFGroup/received_events","type":"Organization","site_admin":false},"repo":{"id":23676062,"name":"h5serv","full_name":"HDFGroup/h5serv","owner":{"login":"HDFGroup","id":8572050,"avatar_url":"https://avatars.githubusercontent.com/u/8572050?v=3","gravatar_id":"","url":"https://api.github.com/users/HDFGroup","html_url":"https://github.com/HDFGroup","followers_url":"https://api.github.com/users/HDFGroup/followers","following_url":"https://api.github.com/users/HDFGroup/following{/other_user}","gists_url":"https://api.github.com/users/HDFGroup/gists{/gist_id}","starred_url":"https://api.github.com/users/HDFGroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HDFGroup/subscriptions","organizations_url":"https://api.github.com/users/HDFGroup/orgs","repos_url":"https://api.github.com/users/HDFGroup/repos","events_url":"https://api.github.com/users/HDFGroup/events{/privacy}","received_events_url":"https://api.github.com/users/HDFGroup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HDFGroup/h5serv","description":"Reference service implementation of the HDF5 REST API","fork":false,"url":"https://api.github.com/repos/HDFGroup/h5serv","forks_url":"https://api.github.com/repos/HDFGroup/h5serv/forks","keys_url":"https://api.github.com/repos/HDFGroup/h5serv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HDFGroup/h5serv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HDFGroup/h5serv/teams","hooks_url":"https://api.github.com/repos/HDFGroup/h5serv/hooks","issue_events_url":"https://api.github.com/repos/HDFGroup/h5serv/issues/events{/number}","events_url":"https://api.github.com/repos/HDFGroup/h5serv/events","assignees_url":"https://api.github.com/repos/HDFGroup/h5serv/assignees{/user}","branches_url":"https://api.github.com/repos/HDFGroup/h5serv/branches{/branch}","tags_url":"https://api.github.com/repos/HDFGroup/h5serv/tags","blobs_url":"https://api.github.com/repos/HDFGroup/h5serv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HDFGroup/h5serv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HDFGroup/h5serv/git/refs{/sha}","trees_url":"https://api.github.com/repos/HDFGroup/h5serv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HDFGroup/h5serv/statuses/{sha}","languages_url":"https://api.github.com/repos/HDFGroup/h5serv/languages","stargazers_url":"https://api.github.com/repos/HDFGroup/h5serv/stargazers","contributors_url":"https://api.github.com/repos/HDFGroup/h5serv/contributors","subscribers_url":"https://api.github.com/repos/HDFGroup/h5serv/subscribers","subscription_url":"https://api.github.com/repos/HDFGroup/h5serv/subscription","commits_url":"https://api.github.com/repos/HDFGroup/h5serv/commits{/sha}","git_commits_url":"https://api.github.com/repos/HDFGroup/h5serv/git/commits{/sha}","comments_url":"https://api.github.com/repos/HDFGroup/h5serv/comments{/number}","issue_comment_url":"https://api.github.com/repos/HDFGroup/h5serv/issues/comments{/number}","contents_url":"https://api.github.com/repos/HDFGroup/h5serv/contents/{+path}","compare_url":"https://api.github.com/repos/HDFGroup/h5serv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HDFGroup/h5serv/merges","archive_url":"https://api.github.com/repos/HDFGroup/h5serv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HDFGroup/h5serv/downloads","issues_url":"https://api.github.com/repos/HDFGroup/h5serv/issues{/number}","pulls_url":"https://api.github.com/repos/HDFGroup/h5serv/pulls{/number}","milestones_url":"https://api.github.com/repos/HDFGroup/h5serv/milestones{/number}","notifications_url":"https://api.github.com/repos/HDFGroup/h5serv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HDFGroup/h5serv/labels{/name}","releases_url":"https://api.github.com/repos/HDFGroup/h5serv/releases{/id}","created_at":"2014-09-04T19:21:38Z","updated_at":"2015-04-25T17:10:37Z","pushed_at":"2015-05-06T05:10:05Z","git_url":"git://github.com/HDFGroup/h5serv.git","ssh_url":"git@github.com:HDFGroup/h5serv.git","clone_url":"https://github.com/HDFGroup/h5serv.git","svn_url":"https://github.com/HDFGroup/h5serv","homepage":null,"size":1984,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":16,"forks":2,"open_issues":16,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47"},"html":{"href":"https://github.com/HDFGroup/h5serv/pull/47"},"issue":{"href":"https://api.github.com/repos/HDFGroup/h5serv/issues/47"},"comments":{"href":"https://api.github.com/repos/HDFGroup/h5serv/issues/47/comments"},"review_comments":{"href":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47/comments"},"review_comment":{"href":"https://api.github.com/repos/HDFGroup/h5serv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HDFGroup/h5serv/pulls/47/commits"},"statuses":{"href":"https://api.github.com/repos/HDFGroup/h5serv/statuses/74949af0be6ef2f40d369dc42ffd8e97ea5fafbb"}}}}