{"action":"created","comment":{"url":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/22981806","id":22981806,"diff_hunk":"@@ -80,7 +80,6 @@ public void flush() throws IOException {\n   @Override\n   public void sync() throws IOException {\n     flush();\n-    Hadoop.FSDataOutputStream.hsync.invoke(out);","path":"kite-data/kite-data-core/src/main/java/org/kitesdk/data/spi/filesystem/AvroAppender.java","position":4,"original_position":4,"commit_id":"e614639397d77a7c409d3df78011144518f71e2f","original_commit_id":"e614639397d77a7c409d3df78011144518f71e2f","user":{"login":"joey","id":249392,"avatar_url":"https://avatars.githubusercontent.com/u/249392?v=3","gravatar_id":"","url":"https://api.github.com/users/joey","html_url":"https://github.com/joey","followers_url":"https://api.github.com/users/joey/followers","following_url":"https://api.github.com/users/joey/following{/other_user}","gists_url":"https://api.github.com/users/joey/gists{/gist_id}","starred_url":"https://api.github.com/users/joey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joey/subscriptions","organizations_url":"https://api.github.com/users/joey/orgs","repos_url":"https://api.github.com/users/joey/repos","events_url":"https://api.github.com/users/joey/events{/privacy}","received_events_url":"https://api.github.com/users/joey/received_events","type":"User","site_admin":false},"body":"Why are we removing the call to `hsync()`?\r\n\r\n`hflush()` doesn't guarantee that data has been written to stable storage.","created_at":"2015-01-15T00:06:50Z","updated_at":"2015-01-15T00:06:50Z","html_url":"https://github.com/kite-sdk/kite/pull/283#discussion_r22981806","pull_request_url":"https://api.github.com/repos/kite-sdk/kite/pulls/283","_links":{"self":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/22981806"},"html":{"href":"https://github.com/kite-sdk/kite/pull/283#discussion_r22981806"},"pull_request":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/283"}}},"pull_request":{"url":"https://api.github.com/repos/kite-sdk/kite/pulls/283","id":26739301,"html_url":"https://github.com/kite-sdk/kite/pull/283","diff_url":"https://github.com/kite-sdk/kite/pull/283.diff","patch_url":"https://github.com/kite-sdk/kite/pull/283.patch","issue_url":"https://api.github.com/repos/kite-sdk/kite/issues/283","number":283,"state":"open","locked":false,"title":"CDK-863: Deprecate DatasetWriter flush/sync, add Flushable.","user":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"body":"This deprecates the DatasetWriter#flush and #sync methods, which are\r\nreplaced by Flushable#flush. Sync needed to call flush to guarantee the\r\nrecords were durable, but flush was still exposed, requiring callers to\r\nflush and sync, with sync calling flush immediately afterwards. Instead,\r\nthe new Flushable interface carries a stronger guarantee that records\r\nhave not only been flushed to the underlying buffer, but that they are\r\npersisted to disk also.","created_at":"2015-01-01T00:49:04Z","updated_at":"2015-01-15T00:06:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"969445bc8fdf969e407d3c7cbb86c9368fc02cee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kite-sdk/kite/pulls/283/commits","review_comments_url":"https://api.github.com/repos/kite-sdk/kite/pulls/283/comments","review_comment_url":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/kite-sdk/kite/issues/283/comments","statuses_url":"https://api.github.com/repos/kite-sdk/kite/statuses/e614639397d77a7c409d3df78011144518f71e2f","head":{"label":"rdblue:CDK-863-deprecate-flush-and-sync","ref":"CDK-863-deprecate-flush-and-sync","sha":"e614639397d77a7c409d3df78011144518f71e2f","user":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"repo":{"id":14991487,"name":"kite","full_name":"rdblue/kite","owner":{"login":"rdblue","id":87915,"avatar_url":"https://avatars.githubusercontent.com/u/87915?v=3","gravatar_id":"","url":"https://api.github.com/users/rdblue","html_url":"https://github.com/rdblue","followers_url":"https://api.github.com/users/rdblue/followers","following_url":"https://api.github.com/users/rdblue/following{/other_user}","gists_url":"https://api.github.com/users/rdblue/gists{/gist_id}","starred_url":"https://api.github.com/users/rdblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rdblue/subscriptions","organizations_url":"https://api.github.com/users/rdblue/orgs","repos_url":"https://api.github.com/users/rdblue/repos","events_url":"https://api.github.com/users/rdblue/events{/privacy}","received_events_url":"https://api.github.com/users/rdblue/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rdblue/kite","description":"Kite SDK","fork":true,"url":"https://api.github.com/repos/rdblue/kite","forks_url":"https://api.github.com/repos/rdblue/kite/forks","keys_url":"https://api.github.com/repos/rdblue/kite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rdblue/kite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rdblue/kite/teams","hooks_url":"https://api.github.com/repos/rdblue/kite/hooks","issue_events_url":"https://api.github.com/repos/rdblue/kite/issues/events{/number}","events_url":"https://api.github.com/repos/rdblue/kite/events","assignees_url":"https://api.github.com/repos/rdblue/kite/assignees{/user}","branches_url":"https://api.github.com/repos/rdblue/kite/branches{/branch}","tags_url":"https://api.github.com/repos/rdblue/kite/tags","blobs_url":"https://api.github.com/repos/rdblue/kite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rdblue/kite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rdblue/kite/git/refs{/sha}","trees_url":"https://api.github.com/repos/rdblue/kite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rdblue/kite/statuses/{sha}","languages_url":"https://api.github.com/repos/rdblue/kite/languages","stargazers_url":"https://api.github.com/repos/rdblue/kite/stargazers","contributors_url":"https://api.github.com/repos/rdblue/kite/contributors","subscribers_url":"https://api.github.com/repos/rdblue/kite/subscribers","subscription_url":"https://api.github.com/repos/rdblue/kite/subscription","commits_url":"https://api.github.com/repos/rdblue/kite/commits{/sha}","git_commits_url":"https://api.github.com/repos/rdblue/kite/git/commits{/sha}","comments_url":"https://api.github.com/repos/rdblue/kite/comments{/number}","issue_comment_url":"https://api.github.com/repos/rdblue/kite/issues/comments/{number}","contents_url":"https://api.github.com/repos/rdblue/kite/contents/{+path}","compare_url":"https://api.github.com/repos/rdblue/kite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rdblue/kite/merges","archive_url":"https://api.github.com/repos/rdblue/kite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rdblue/kite/downloads","issues_url":"https://api.github.com/repos/rdblue/kite/issues{/number}","pulls_url":"https://api.github.com/repos/rdblue/kite/pulls{/number}","milestones_url":"https://api.github.com/repos/rdblue/kite/milestones{/number}","notifications_url":"https://api.github.com/repos/rdblue/kite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rdblue/kite/labels{/name}","releases_url":"https://api.github.com/repos/rdblue/kite/releases{/id}","created_at":"2013-12-06T19:33:16Z","updated_at":"2014-12-18T18:53:30Z","pushed_at":"2015-01-14T21:09:46Z","git_url":"git://github.com/rdblue/kite.git","ssh_url":"git@github.com:rdblue/kite.git","clone_url":"https://github.com/rdblue/kite.git","svn_url":"https://github.com/rdblue/kite","homepage":null,"size":26648,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kite-sdk:master","ref":"master","sha":"f5add835747d08e7e37d11c650f3f728b6d84d5f","user":{"login":"kite-sdk","id":5732728,"avatar_url":"https://avatars.githubusercontent.com/u/5732728?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-sdk","html_url":"https://github.com/kite-sdk","followers_url":"https://api.github.com/users/kite-sdk/followers","following_url":"https://api.github.com/users/kite-sdk/following{/other_user}","gists_url":"https://api.github.com/users/kite-sdk/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-sdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-sdk/subscriptions","organizations_url":"https://api.github.com/users/kite-sdk/orgs","repos_url":"https://api.github.com/users/kite-sdk/repos","events_url":"https://api.github.com/users/kite-sdk/events{/privacy}","received_events_url":"https://api.github.com/users/kite-sdk/received_events","type":"Organization","site_admin":false},"repo":{"id":14829187,"name":"kite","full_name":"kite-sdk/kite","owner":{"login":"kite-sdk","id":5732728,"avatar_url":"https://avatars.githubusercontent.com/u/5732728?v=3","gravatar_id":"","url":"https://api.github.com/users/kite-sdk","html_url":"https://github.com/kite-sdk","followers_url":"https://api.github.com/users/kite-sdk/followers","following_url":"https://api.github.com/users/kite-sdk/following{/other_user}","gists_url":"https://api.github.com/users/kite-sdk/gists{/gist_id}","starred_url":"https://api.github.com/users/kite-sdk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kite-sdk/subscriptions","organizations_url":"https://api.github.com/users/kite-sdk/orgs","repos_url":"https://api.github.com/users/kite-sdk/repos","events_url":"https://api.github.com/users/kite-sdk/events{/privacy}","received_events_url":"https://api.github.com/users/kite-sdk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kite-sdk/kite","description":"Kite SDK","fork":false,"url":"https://api.github.com/repos/kite-sdk/kite","forks_url":"https://api.github.com/repos/kite-sdk/kite/forks","keys_url":"https://api.github.com/repos/kite-sdk/kite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kite-sdk/kite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kite-sdk/kite/teams","hooks_url":"https://api.github.com/repos/kite-sdk/kite/hooks","issue_events_url":"https://api.github.com/repos/kite-sdk/kite/issues/events{/number}","events_url":"https://api.github.com/repos/kite-sdk/kite/events","assignees_url":"https://api.github.com/repos/kite-sdk/kite/assignees{/user}","branches_url":"https://api.github.com/repos/kite-sdk/kite/branches{/branch}","tags_url":"https://api.github.com/repos/kite-sdk/kite/tags","blobs_url":"https://api.github.com/repos/kite-sdk/kite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kite-sdk/kite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kite-sdk/kite/git/refs{/sha}","trees_url":"https://api.github.com/repos/kite-sdk/kite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kite-sdk/kite/statuses/{sha}","languages_url":"https://api.github.com/repos/kite-sdk/kite/languages","stargazers_url":"https://api.github.com/repos/kite-sdk/kite/stargazers","contributors_url":"https://api.github.com/repos/kite-sdk/kite/contributors","subscribers_url":"https://api.github.com/repos/kite-sdk/kite/subscribers","subscription_url":"https://api.github.com/repos/kite-sdk/kite/subscription","commits_url":"https://api.github.com/repos/kite-sdk/kite/commits{/sha}","git_commits_url":"https://api.github.com/repos/kite-sdk/kite/git/commits{/sha}","comments_url":"https://api.github.com/repos/kite-sdk/kite/comments{/number}","issue_comment_url":"https://api.github.com/repos/kite-sdk/kite/issues/comments/{number}","contents_url":"https://api.github.com/repos/kite-sdk/kite/contents/{+path}","compare_url":"https://api.github.com/repos/kite-sdk/kite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kite-sdk/kite/merges","archive_url":"https://api.github.com/repos/kite-sdk/kite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kite-sdk/kite/downloads","issues_url":"https://api.github.com/repos/kite-sdk/kite/issues{/number}","pulls_url":"https://api.github.com/repos/kite-sdk/kite/pulls{/number}","milestones_url":"https://api.github.com/repos/kite-sdk/kite/milestones{/number}","notifications_url":"https://api.github.com/repos/kite-sdk/kite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kite-sdk/kite/labels{/name}","releases_url":"https://api.github.com/repos/kite-sdk/kite/releases{/id}","created_at":"2013-11-30T22:06:02Z","updated_at":"2015-01-14T21:10:06Z","pushed_at":"2015-01-14T21:10:05Z","git_url":"git://github.com/kite-sdk/kite.git","ssh_url":"git@github.com:kite-sdk/kite.git","clone_url":"https://github.com/kite-sdk/kite.git","svn_url":"https://github.com/kite-sdk/kite","homepage":"http://kitesdk.org/docs/current/","size":72582,"stargazers_count":97,"watchers_count":97,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"open_issues_count":12,"forks":78,"open_issues":12,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/283"},"html":{"href":"https://github.com/kite-sdk/kite/pull/283"},"issue":{"href":"https://api.github.com/repos/kite-sdk/kite/issues/283"},"comments":{"href":"https://api.github.com/repos/kite-sdk/kite/issues/283/comments"},"review_comments":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/283/comments"},"review_comment":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/kite-sdk/kite/pulls/283/commits"},"statuses":{"href":"https://api.github.com/repos/kite-sdk/kite/statuses/e614639397d77a7c409d3df78011144518f71e2f"}}}}