{"action":"closed","number":11782,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11782","id":47627197,"html_url":"https://github.com/cms-sw/cmssw/pull/11782","diff_url":"https://github.com/cms-sw/cmssw/pull/11782.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11782.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11782","number":11782,"state":"closed","locked":false,"title":"Removed inappropriate use of SerialTaskQueue from ClusterShapeLazyGetter","user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"body":"A SerialTaskQueue was added to ClusterShapeLazyGetter in an attempt\r\nto make it thread safe. Unfortunately, the implementation was not safe\r\nsince the internals of SiPixelClusterShapeCache could be changed\r\nwhile another thread was reading the data outside of the queue.\r\nIn addition, performance measurements done using VTune showed\r\nthe fequent calls to SerialTaskQueue were causing a heavy CPU load\r\nwhen run with 8 threads.\r\nThe thread safety of SiPixelClusterShapeCache will have to be handled\r\nin a different way in the future once we start using more than one\r\nthread per Event.\r\n\r\nThis was backported from CMSSW_7_6 since it improves thread efficiency with no change in behavior.","created_at":"2015-10-14T07:47:52Z","updated_at":"2015-10-24T17:51:27Z","closed_at":"2015-10-24T17:51:27Z","merged_at":"2015-10-24T17:51:27Z","merge_commit_sha":"62ed6d3be1c9be2084d757e99a974647b8bc1e81","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":113,"closed_issues":1002,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-10-24T17:51:27Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11782/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11782/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11782/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/331305abf5e6f55327b3c38531e77abc8edf478b","head":{"label":"Dr15Jones:removeThreadInefficientClusterShapeLazyGetter_7_4","ref":"removeThreadInefficientClusterShapeLazyGetter_7_4","sha":"331305abf5e6f55327b3c38531e77abc8edf478b","user":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"repo":{"id":10974606,"name":"cmssw","full_name":"Dr15Jones/cmssw","owner":{"login":"Dr15Jones","id":3757616,"avatar_url":"https://avatars.githubusercontent.com/u/3757616?v=3","gravatar_id":"","url":"https://api.github.com/users/Dr15Jones","html_url":"https://github.com/Dr15Jones","followers_url":"https://api.github.com/users/Dr15Jones/followers","following_url":"https://api.github.com/users/Dr15Jones/following{/other_user}","gists_url":"https://api.github.com/users/Dr15Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/Dr15Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dr15Jones/subscriptions","organizations_url":"https://api.github.com/users/Dr15Jones/orgs","repos_url":"https://api.github.com/users/Dr15Jones/repos","events_url":"https://api.github.com/users/Dr15Jones/events{/privacy}","received_events_url":"https://api.github.com/users/Dr15Jones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dr15Jones/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/Dr15Jones/cmssw","forks_url":"https://api.github.com/repos/Dr15Jones/cmssw/forks","keys_url":"https://api.github.com/repos/Dr15Jones/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dr15Jones/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dr15Jones/cmssw/teams","hooks_url":"https://api.github.com/repos/Dr15Jones/cmssw/hooks","issue_events_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/Dr15Jones/cmssw/events","assignees_url":"https://api.github.com/repos/Dr15Jones/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/Dr15Jones/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/Dr15Jones/cmssw/tags","blobs_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dr15Jones/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/Dr15Jones/cmssw/languages","stargazers_url":"https://api.github.com/repos/Dr15Jones/cmssw/stargazers","contributors_url":"https://api.github.com/repos/Dr15Jones/cmssw/contributors","subscribers_url":"https://api.github.com/repos/Dr15Jones/cmssw/subscribers","subscription_url":"https://api.github.com/repos/Dr15Jones/cmssw/subscription","commits_url":"https://api.github.com/repos/Dr15Jones/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dr15Jones/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dr15Jones/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dr15Jones/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/Dr15Jones/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dr15Jones/cmssw/merges","archive_url":"https://api.github.com/repos/Dr15Jones/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dr15Jones/cmssw/downloads","issues_url":"https://api.github.com/repos/Dr15Jones/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/Dr15Jones/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/Dr15Jones/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/Dr15Jones/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dr15Jones/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/Dr15Jones/cmssw/releases{/id}","created_at":"2013-06-26T17:40:38Z","updated_at":"2015-04-07T20:01:44Z","pushed_at":"2015-10-21T21:11:51Z","git_url":"git://github.com/Dr15Jones/cmssw.git","ssh_url":"git@github.com:Dr15Jones/cmssw.git","clone_url":"https://github.com/Dr15Jones/cmssw.git","svn_url":"https://github.com/Dr15Jones/cmssw","homepage":null,"size":722941,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"CMSSW_7_6_X"}},"base":{"label":"cms-sw:CMSSW_7_4_X","ref":"CMSSW_7_4_X","sha":"b4b632c43dbfcd0f452b43e0f97b4f55587988a6","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-10-22T15:37:24Z","pushed_at":"2015-10-24T17:51:27Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1314874,"stargazers_count":266,"watchers_count":266,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1596,"mirror_url":null,"open_issues_count":320,"forks":1596,"open_issues":320,"watchers":266,"default_branch":"CMSSW_8_0_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11782"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11782"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11782"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11782/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11782/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11782/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/331305abf5e6f55327b3c38531e77abc8edf478b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"davidlange6","id":5042883,"avatar_url":"https://avatars.githubusercontent.com/u/5042883?v=3","gravatar_id":"","url":"https://api.github.com/users/davidlange6","html_url":"https://github.com/davidlange6","followers_url":"https://api.github.com/users/davidlange6/followers","following_url":"https://api.github.com/users/davidlange6/following{/other_user}","gists_url":"https://api.github.com/users/davidlange6/gists{/gist_id}","starred_url":"https://api.github.com/users/davidlange6/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidlange6/subscriptions","organizations_url":"https://api.github.com/users/davidlange6/orgs","repos_url":"https://api.github.com/users/davidlange6/repos","events_url":"https://api.github.com/users/davidlange6/events{/privacy}","received_events_url":"https://api.github.com/users/davidlange6/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":1,"additions":6,"deletions":10,"changed_files":1}}