{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48554609","id":48554609,"diff_hunk":"@@ -120,39 +122,35 @@ def heatmaps\n     node_ids = @ems.container_nodes if @ems\n     metrics = MetricRollup.latest_rollups(ContainerNode.name, node_ids)\n \n-    {\n-      :nodeCpuUsage => metrics.collect { |m|\n-        avg_cpu = m.cpu_usage_rate_average.round(2)\n-        {\n-          :id      => m.resource_id,\n-          :tooltip => \"#{m.resource.name} - #{avg_cpu}%\",\n-          :value   => avg_cpu / 100.0 # 1% should be 0.01\n-        }\n-      },\n-      :nodeMemoryUsage => metrics.collect { |m|\n-        avg_mem = m.mem_usage_absolute_average.round(2)\n-        {\n-          :id      => m.resource_id,\n-          :tooltip => \"#{m.resource.name} - #{avg_mem}%\",\n-          :value   => avg_mem / 100.0 # 1% should be 0.01\n+    if metrics.any?\n+      {\n+        :nodeCpuUsage => metrics.collect { |m|\n+          avg_cpu = m.cpu_usage_rate_average.round(2)\n+          {\n+            :id      => m.resource_id,\n+            :tooltip => \"#{m.resource.name} - #{avg_cpu}%\",\n+            :value   => avg_cpu / 100.0 # 1% should be 0.01","path":"app/services/container_dashboard_service.rb","position":47,"original_position":47,"commit_id":"0d4ff6055c1cb8df6ee05585f9c3a03a5d1cf6ea","original_commit_id":"0d4ff6055c1cb8df6ee05585f9c3a03a5d1cf6ea","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"body":"> @zeari can you add the reason why 0.01 should be returned? Is it the java-script side that requires that? I am worried that what you're trying to calculate here may not be correct and I want to double check.\r\n\r\nYour comments are correct and this part completely changes in #6001.\r\nin this patch it was only important that this function returns ```nil``` if theres no data.","created_at":"2015-12-29T17:14:13Z","updated_at":"2015-12-29T17:14:13Z","html_url":"https://github.com/ManageIQ/manageiq/pull/5938#discussion_r48554609","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/48554609"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5938#discussion_r48554609"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938","id":54271679,"html_url":"https://github.com/ManageIQ/manageiq/pull/5938","diff_url":"https://github.com/ManageIQ/manageiq/pull/5938.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5938.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5938","number":5938,"state":"open","locked":false,"title":"Add dashboard network trends","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"body":"~~Depends on #5648~~(Merged)\r\n![dashbaord_network](https://cloud.githubusercontent.com/assets/11256940/11934662/3aef3a5a-a80c-11e5-933e-718d02fc1c41.png)\r\n\r\n@abonas @himdel Please review","created_at":"2015-12-21T15:58:27Z","updated_at":"2015-12-29T17:14:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d847d0150521150aefaa91fcc03895d2b711120","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5938/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/0d4ff6055c1cb8df6ee05585f9c3a03a5d1cf6ea","head":{"label":"zeari:add_dashboard_network_trends","ref":"add_dashboard_network_trends","sha":"0d4ff6055c1cb8df6ee05585f9c3a03a5d1cf6ea","user":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"repo":{"id":32809554,"name":"manageiq","full_name":"zeari/manageiq","owner":{"login":"zeari","id":11256940,"avatar_url":"https://avatars.githubusercontent.com/u/11256940?v=3","gravatar_id":"","url":"https://api.github.com/users/zeari","html_url":"https://github.com/zeari","followers_url":"https://api.github.com/users/zeari/followers","following_url":"https://api.github.com/users/zeari/following{/other_user}","gists_url":"https://api.github.com/users/zeari/gists{/gist_id}","starred_url":"https://api.github.com/users/zeari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeari/subscriptions","organizations_url":"https://api.github.com/users/zeari/orgs","repos_url":"https://api.github.com/users/zeari/repos","events_url":"https://api.github.com/users/zeari/events{/privacy}","received_events_url":"https://api.github.com/users/zeari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zeari/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/zeari/manageiq","forks_url":"https://api.github.com/repos/zeari/manageiq/forks","keys_url":"https://api.github.com/repos/zeari/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeari/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeari/manageiq/teams","hooks_url":"https://api.github.com/repos/zeari/manageiq/hooks","issue_events_url":"https://api.github.com/repos/zeari/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/zeari/manageiq/events","assignees_url":"https://api.github.com/repos/zeari/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/zeari/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/zeari/manageiq/tags","blobs_url":"https://api.github.com/repos/zeari/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeari/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeari/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeari/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeari/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeari/manageiq/languages","stargazers_url":"https://api.github.com/repos/zeari/manageiq/stargazers","contributors_url":"https://api.github.com/repos/zeari/manageiq/contributors","subscribers_url":"https://api.github.com/repos/zeari/manageiq/subscribers","subscription_url":"https://api.github.com/repos/zeari/manageiq/subscription","commits_url":"https://api.github.com/repos/zeari/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeari/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeari/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeari/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeari/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/zeari/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeari/manageiq/merges","archive_url":"https://api.github.com/repos/zeari/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeari/manageiq/downloads","issues_url":"https://api.github.com/repos/zeari/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/zeari/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeari/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeari/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeari/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/zeari/manageiq/releases{/id}","created_at":"2015-03-24T16:05:33Z","updated_at":"2015-04-19T08:03:20Z","pushed_at":"2015-12-29T16:28:13Z","git_url":"git://github.com/zeari/manageiq.git","ssh_url":"git@github.com:zeari/manageiq.git","clone_url":"https://github.com/zeari/manageiq.git","svn_url":"https://github.com/zeari/manageiq","homepage":"manageiq.org","size":99451,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"83871151c8191ddc88f7a13b705d3ce9f2c4a414","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-12-29T05:40:56Z","pushed_at":"2015-12-29T16:28:13Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":134309,"stargazers_count":185,"watchers_count":185,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":197,"mirror_url":null,"open_issues_count":492,"forks":197,"open_issues":492,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5938"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5938"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5938/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5938/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/0d4ff6055c1cb8df6ee05585f9c3a03a5d1cf6ea"}}}}