{"comment":{"url":"https://api.github.com/repos/spawnproc/cr/comments/10202465","html_url":"https://github.com/spawnproc/cr/commit/d7ccb9755d91d5e1d6a1071bdda30aaabf08e58d#commitcomment-10202465","id":10202465,"user":{"login":"sumerman","id":222471,"avatar_url":"https://avatars.githubusercontent.com/u/222471?v=3","gravatar_id":"","url":"https://api.github.com/users/sumerman","html_url":"https://github.com/sumerman","followers_url":"https://api.github.com/users/sumerman/followers","following_url":"https://api.github.com/users/sumerman/following{/other_user}","gists_url":"https://api.github.com/users/sumerman/gists{/gist_id}","starred_url":"https://api.github.com/users/sumerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumerman/subscriptions","organizations_url":"https://api.github.com/users/sumerman/orgs","repos_url":"https://api.github.com/users/sumerman/repos","events_url":"https://api.github.com/users/sumerman/events{/privacy}","received_events_url":"https://api.github.com/users/sumerman/received_events","type":"User","site_admin":false},"position":1,"line":1,"path":"src/protocols/cr_ping.erl","commit_id":"d7ccb9755d91d5e1d6a1071bdda30aaabf08e58d","created_at":"2015-03-15T11:57:49Z","updated_at":"2015-03-15T11:57:49Z","body":"Distinct ping protocol is a bad idea, both client and interconnect protocols should have their own ping functionality. Otherwise there is no (robust) way to tell if a particular connection is still alive. It may take a huge amount of time (AFAIK default keepalive time on Linux is usually set to 2 hours or so) for underlying TCP protocol to detect some kind of network failures."}}