{"action":"created","issue":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/347","labels_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/347/labels{/name}","comments_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/347/comments","events_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/347/events","html_url":"https://github.com/madebymany/sir-trevor-js/pull/347","id":86542380,"number":347,"title":"RegEx fixes for videos","user":{"login":"SgtOddball","id":9439545,"avatar_url":"https://avatars.githubusercontent.com/u/9439545?v=3","gravatar_id":"","url":"https://api.github.com/users/SgtOddball","html_url":"https://github.com/SgtOddball","followers_url":"https://api.github.com/users/SgtOddball/followers","following_url":"https://api.github.com/users/SgtOddball/following{/other_user}","gists_url":"https://api.github.com/users/SgtOddball/gists{/gist_id}","starred_url":"https://api.github.com/users/SgtOddball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SgtOddball/subscriptions","organizations_url":"https://api.github.com/users/SgtOddball/orgs","repos_url":"https://api.github.com/users/SgtOddball/repos","events_url":"https://api.github.com/users/SgtOddball/events{/privacy}","received_events_url":"https://api.github.com/users/SgtOddball/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-09T10:21:16Z","updated_at":"2015-07-13T09:21:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/pulls/347","html_url":"https://github.com/madebymany/sir-trevor-js/pull/347","diff_url":"https://github.com/madebymany/sir-trevor-js/pull/347.diff","patch_url":"https://github.com/madebymany/sir-trevor-js/pull/347.patch"},"body":"Found that the youtube and vimeo RegEx checks can bug out in certian circumstances. \r\n\r\nYouTube could fail oddly and only return the first character of the match, now fixed along with handling for both youtu.be and youtube.com addresses to be added) \r\n\r\nVimeo would bug out if video id wasn't the first and only part of the path. \r\n(for example https://vimeo.com/channels/staffpicks/128544536 is a valid link but so is https://vimeo.com/128544536 but only the second link would get picked up. Now changed so that it finds the last forward slash after the vimeo web address.) "},"comment":{"url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/comments/120865755","html_url":"https://github.com/madebymany/sir-trevor-js/pull/347#issuecomment-120865755","issue_url":"https://api.github.com/repos/madebymany/sir-trevor-js/issues/347","id":120865755,"user":{"login":"lukaszsagol","id":264335,"avatar_url":"https://avatars.githubusercontent.com/u/264335?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaszsagol","html_url":"https://github.com/lukaszsagol","followers_url":"https://api.github.com/users/lukaszsagol/followers","following_url":"https://api.github.com/users/lukaszsagol/following{/other_user}","gists_url":"https://api.github.com/users/lukaszsagol/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszsagol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszsagol/subscriptions","organizations_url":"https://api.github.com/users/lukaszsagol/orgs","repos_url":"https://api.github.com/users/lukaszsagol/repos","events_url":"https://api.github.com/users/lukaszsagol/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszsagol/received_events","type":"User","site_admin":false},"created_at":"2015-07-13T09:21:32Z","updated_at":"2015-07-13T09:21:32Z","body":"@SgtOddball Just verify that we test against all the important URLs in the test file I linked"}}