{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/43219687","id":43219687,"diff_hunk":"@@ -819,12 +819,7 @@ YUI.add('environment-change-set', function(Y) {\n       // new React configuration system the modified values is determined\n       // in the view and set in the service model so we can faithfully\n       // take what it says to set as correct.\n-      var changedFields;\n-      if (!window.flags || !window.flags.react) {\n-        changedFields = utils.getChangedConfigOptions(config, serviceConfig);","path":"jujugui/static/gui/src/app/utils/environment-change-set.js","position":6,"original_position":6,"commit_id":"de5ef70c184f91927dc11bb5d5816c0dced9917a","original_commit_id":"de5ef70c184f91927dc11bb5d5816c0dced9917a","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?v=3","gravatar_id":"","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"I don't think that the `getChangedConfigOptions` method is used anywhere else.","created_at":"2015-10-28T05:35:33Z","updated_at":"2015-10-28T05:35:33Z","html_url":"https://github.com/juju/juju-gui/pull/946#discussion_r43219687","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/946","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/43219687"},"html":{"href":"https://github.com/juju/juju-gui/pull/946#discussion_r43219687"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/946"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/946","id":48961853,"html_url":"https://github.com/juju/juju-gui/pull/946","diff_url":"https://github.com/juju/juju-gui/pull/946.diff","patch_url":"https://github.com/juju/juju-gui/pull/946.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/946","number":946,"state":"open","locked":false,"title":"Remove inspector flag","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"body":"Remove the remaining flags for the inspector, charmbrowser and env switcher. There will be a followup to actually remove the old code.","created_at":"2015-10-28T03:45:44Z","updated_at":"2015-10-28T05:35:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a6a2a5d6241242843bd93bf89393d2cbf2c3a71","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/946/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/946/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/946/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/de5ef70c184f91927dc11bb5d5816c0dced9917a","head":{"label":"huwshimi:remove-inspector-flag","ref":"remove-inspector-flag","sha":"de5ef70c184f91927dc11bb5d5816c0dced9917a","user":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"repo":{"id":15032585,"name":"juju-gui","full_name":"huwshimi/juju-gui","owner":{"login":"huwshimi","id":361637,"avatar_url":"https://avatars.githubusercontent.com/u/361637?v=3","gravatar_id":"","url":"https://api.github.com/users/huwshimi","html_url":"https://github.com/huwshimi","followers_url":"https://api.github.com/users/huwshimi/followers","following_url":"https://api.github.com/users/huwshimi/following{/other_user}","gists_url":"https://api.github.com/users/huwshimi/gists{/gist_id}","starred_url":"https://api.github.com/users/huwshimi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huwshimi/subscriptions","organizations_url":"https://api.github.com/users/huwshimi/orgs","repos_url":"https://api.github.com/users/huwshimi/repos","events_url":"https://api.github.com/users/huwshimi/events{/privacy}","received_events_url":"https://api.github.com/users/huwshimi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huwshimi/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/huwshimi/juju-gui","forks_url":"https://api.github.com/repos/huwshimi/juju-gui/forks","keys_url":"https://api.github.com/repos/huwshimi/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huwshimi/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huwshimi/juju-gui/teams","hooks_url":"https://api.github.com/repos/huwshimi/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/huwshimi/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/huwshimi/juju-gui/events","assignees_url":"https://api.github.com/repos/huwshimi/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/huwshimi/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/huwshimi/juju-gui/tags","blobs_url":"https://api.github.com/repos/huwshimi/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huwshimi/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huwshimi/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/huwshimi/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huwshimi/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/huwshimi/juju-gui/languages","stargazers_url":"https://api.github.com/repos/huwshimi/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/huwshimi/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/huwshimi/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/huwshimi/juju-gui/subscription","commits_url":"https://api.github.com/repos/huwshimi/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/huwshimi/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/huwshimi/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/huwshimi/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/huwshimi/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/huwshimi/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huwshimi/juju-gui/merges","archive_url":"https://api.github.com/repos/huwshimi/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huwshimi/juju-gui/downloads","issues_url":"https://api.github.com/repos/huwshimi/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/huwshimi/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/huwshimi/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/huwshimi/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huwshimi/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/huwshimi/juju-gui/releases{/id}","created_at":"2013-12-08T22:20:08Z","updated_at":"2014-06-25T06:57:23Z","pushed_at":"2015-10-28T03:44:11Z","git_url":"git://github.com/huwshimi/juju-gui.git","ssh_url":"git@github.com:huwshimi/juju-gui.git","clone_url":"https://github.com/huwshimi/juju-gui.git","svn_url":"https://github.com/huwshimi/juju-gui","homepage":null,"size":112657,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:pyramid-fork","ref":"pyramid-fork","sha":"6012d1896f65c76db5303ea635b1dd10bc6d2136","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2015-10-26T18:08:06Z","pushed_at":"2015-10-28T03:45:44Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":117244,"stargazers_count":55,"watchers_count":55,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":3,"forks":45,"open_issues":3,"watchers":55,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/946"},"html":{"href":"https://github.com/juju/juju-gui/pull/946"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/946"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/946/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/946/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/946/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/de5ef70c184f91927dc11bb5d5816c0dced9917a"}}}}