{"action":"created","issue":{"url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/222","labels_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/222/labels{/name}","comments_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/222/comments","events_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/222/events","html_url":"https://github.com/jhedstrom/drupalextension/pull/222","id":116147125,"number":222,"title":"Fix comparisons in tests; ","user":{"login":"greg-1-anderson","id":612191,"avatar_url":"https://avatars.githubusercontent.com/u/612191?v=3","gravatar_id":"","url":"https://api.github.com/users/greg-1-anderson","html_url":"https://github.com/greg-1-anderson","followers_url":"https://api.github.com/users/greg-1-anderson/followers","following_url":"https://api.github.com/users/greg-1-anderson/following{/other_user}","gists_url":"https://api.github.com/users/greg-1-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-1-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-1-anderson/subscriptions","organizations_url":"https://api.github.com/users/greg-1-anderson/orgs","repos_url":"https://api.github.com/users/greg-1-anderson/repos","events_url":"https://api.github.com/users/greg-1-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/greg-1-anderson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/jhedstrom/drupalextension/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/jhedstrom/drupalextension/milestones/3","html_url":"https://github.com/jhedstrom/drupalextension/milestones/3.2.0%20release","labels_url":"https://api.github.com/repos/jhedstrom/drupalextension/milestones/3/labels","id":1287366,"number":3,"title":"3.2.0 release","description":"","creator":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2015-09-02T22:37:41Z","updated_at":"2015-11-10T22:25:15Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-11-10T16:41:24Z","updated_at":"2015-11-10T22:25:39Z","closed_at":"2015-11-10T22:25:15Z","pull_request":{"url":"https://api.github.com/repos/jhedstrom/drupalextension/pulls/222","html_url":"https://github.com/jhedstrom/drupalextension/pull/222","diff_url":"https://github.com/jhedstrom/drupalextension/pull/222.diff","patch_url":"https://github.com/jhedstrom/drupalextension/pull/222.patch"},"body":"Former logic did not correctly set $? after test failures, so failing builds were mistakenly marked as passing.\r\n\r\nWe had:\r\n\r\ntest $v -eq 7 && behat || true\r\n\r\nSo, if $v was NOT 7, then the test returns false, and we need the `|| true` clause to prevent a spurious failure for the skipped test.  However, if $v IS 7, then the `|| true` clause runs regardless of the outcome of the behat test, so $? is always 0.\r\n\r\nI changed this to:\r\n\r\ntest \\! $v -eq 7 || behat\r\n\r\nNow, if $v is NOT 7, then the test returns true, and processing stops, correctly skipping the test without marking it as an error.  If $v IS 7, then test returns false, and behat runs.  $? is set based on the outcome of the test.\r\n\r\nRight now, the drupalextension tests are failing (my fault), but are being marked as successful due to this logic error.  So, if this PR is working correctly, then the test should correctly FAIL, and you should merge it.\r\n\r\nOnce this is right, I will submit a PR to fix the tests I broke.  I think it will need to go in the DrupalDriver, though."},"comment":{"url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/comments/155587486","html_url":"https://github.com/jhedstrom/drupalextension/pull/222#issuecomment-155587486","issue_url":"https://api.github.com/repos/jhedstrom/drupalextension/issues/222","id":155587486,"user":{"login":"jhedstrom","id":76833,"avatar_url":"https://avatars.githubusercontent.com/u/76833?v=3","gravatar_id":"","url":"https://api.github.com/users/jhedstrom","html_url":"https://github.com/jhedstrom","followers_url":"https://api.github.com/users/jhedstrom/followers","following_url":"https://api.github.com/users/jhedstrom/following{/other_user}","gists_url":"https://api.github.com/users/jhedstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/jhedstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhedstrom/subscriptions","organizations_url":"https://api.github.com/users/jhedstrom/orgs","repos_url":"https://api.github.com/users/jhedstrom/repos","events_url":"https://api.github.com/users/jhedstrom/events{/privacy}","received_events_url":"https://api.github.com/users/jhedstrom/received_events","type":"User","site_admin":false},"created_at":"2015-11-10T22:25:39Z","updated_at":"2015-11-10T22:25:39Z","body":"Thanks! Merging the other one now."}}