{"action":"created","issue":{"url":"https://api.github.com/repos/HotelsDotCom/plunger/issues/8","labels_url":"https://api.github.com/repos/HotelsDotCom/plunger/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/HotelsDotCom/plunger/issues/8/comments","events_url":"https://api.github.com/repos/HotelsDotCom/plunger/issues/8/events","html_url":"https://github.com/HotelsDotCom/plunger/pull/8","id":83061365,"number":8,"title":"make TupleListTap constructor public","user":{"login":"methylene","id":2026203,"avatar_url":"https://avatars.githubusercontent.com/u/2026203?v=3","gravatar_id":"","url":"https://api.github.com/users/methylene","html_url":"https://github.com/methylene","followers_url":"https://api.github.com/users/methylene/followers","following_url":"https://api.github.com/users/methylene/following{/other_user}","gists_url":"https://api.github.com/users/methylene/gists{/gist_id}","starred_url":"https://api.github.com/users/methylene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/methylene/subscriptions","organizations_url":"https://api.github.com/users/methylene/orgs","repos_url":"https://api.github.com/users/methylene/repos","events_url":"https://api.github.com/users/methylene/events{/privacy}","received_events_url":"https://api.github.com/users/methylene/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-31T10:45:10Z","updated_at":"2015-05-31T13:30:51Z","closed_at":"2015-05-31T13:30:51Z","pull_request":{"url":"https://api.github.com/repos/HotelsDotCom/plunger/pulls/8","html_url":"https://github.com/HotelsDotCom/plunger/pull/8","diff_url":"https://github.com/HotelsDotCom/plunger/pull/8.diff","patch_url":"https://github.com/HotelsDotCom/plunger/pull/8.patch"},"body":"This change allows a TupleListTap to be used with cascading 3.0.\r\n\r\nThe following code fails when using `3.0.0-wip-121`:\r\n\r\n````java\r\n    Fields revenueFields = Fields.join(new Fields(\"revenue\", Double.TYPE), new Fields(\"currency\", String.class));\r\n    TupleListTap revenue = new DataBuilder(revenueFields)\r\n        .addTuple(12.0d, \"USD\")\r\n        .addTuple(10.0d, \"GBP\")\r\n        .addTuple(11.99d, \"EUR\")\r\n        .addTuple(4.0d, \"EUR\").toTap();\r\n````\r\n\r\nWe get the following error:\r\n\r\n````\r\njava.lang.NoSuchMethodError: cascading.tuple.Tuples.coerce(Lcascading/tuple/Tuple;[Ljava/lang/Class;)Lcascading/tuple/Tuple;\r\n\tat com.hotels.plunger.DataBuilder.flushTupleEntry(DataBuilder.java:185)\r\n\tat com.hotels.plunger.DataBuilder.newTuple(DataBuilder.java:69)\r\n\tat com.hotels.plunger.DataBuilder.addTuple(DataBuilder.java:76)\r\n````\r\n\r\nIf the TupleListTap constructor is public, the following is equivalent and works:\r\n\r\n````java\r\n    TupleListTap revenue = new TupleListTap(revenueFields, ImmutableList.<Tuple>builder()\r\n        .add(new Tuple(12.0d, \"USD\"))\r\n        .add(new Tuple(10.0d, \"GBP\"))\r\n        .add(new Tuple(11.99d, \"EUR\"))\r\n        .build());\r\n```` \r\n"},"comment":{"url":"https://api.github.com/repos/HotelsDotCom/plunger/issues/comments/107180039","html_url":"https://github.com/HotelsDotCom/plunger/pull/8#issuecomment-107180039","issue_url":"https://api.github.com/repos/HotelsDotCom/plunger/issues/8","id":107180039,"user":{"login":"teabot","id":228950,"avatar_url":"https://avatars.githubusercontent.com/u/228950?v=3","gravatar_id":"","url":"https://api.github.com/users/teabot","html_url":"https://github.com/teabot","followers_url":"https://api.github.com/users/teabot/followers","following_url":"https://api.github.com/users/teabot/following{/other_user}","gists_url":"https://api.github.com/users/teabot/gists{/gist_id}","starred_url":"https://api.github.com/users/teabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teabot/subscriptions","organizations_url":"https://api.github.com/users/teabot/orgs","repos_url":"https://api.github.com/users/teabot/repos","events_url":"https://api.github.com/users/teabot/events{/privacy}","received_events_url":"https://api.github.com/users/teabot/received_events","type":"User","site_admin":false},"created_at":"2015-05-31T13:30:51Z","updated_at":"2015-05-31T13:30:51Z","body":"Thanks for the PR. I'd rather we fix the underlying issue within `DataBuilder.newTuple()` (which is used in other scenarios) and continue to provide only one way of specifying data: i.e. with `DataBuilder` and not also with a `List`."}}