{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/28062439","id":28062439,"diff_hunk":"@@ -103,7 +103,7 @@ def divide(x1, x2, out=None, dtype=None):\n except TypeError:\n     # Compat where astype accepted no copy argument","path":"sklearn/utils/fixes.py","position":2,"original_position":2,"commit_id":"91fac5a329fc1a9d0acf7408db5071e86a94063c","original_commit_id":"91fac5a329fc1a9d0acf7408db5071e86a94063c","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"I think so. I don't have a numpy 1.6.1 at hand right now to quickly check.","created_at":"2015-04-09T13:50:08Z","updated_at":"2015-04-09T13:50:08Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/4555#discussion_r28062439","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/28062439"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4555#discussion_r28062439"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555"}}},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555","id":32949836,"html_url":"https://github.com/scikit-learn/scikit-learn/pull/4555","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/4555.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/4555.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4555","number":4555,"state":"open","locked":false,"title":"[MRG] Fix the behavior of astype copy=true","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"body":"The astype backport should copy memory by default to be consistent with the default behavior of recent numpy.","created_at":"2015-04-09T12:13:50Z","updated_at":"2015-04-09T13:50:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5552ce1b29e18c870b3b7e458a66502341f0427","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4555/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/91fac5a329fc1a9d0acf7408db5071e86a94063c","head":{"label":"ogrisel:fix-astype-copy-true","ref":"fix-astype-copy-true","sha":"91fac5a329fc1a9d0acf7408db5071e86a94063c","user":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"repo":{"id":843501,"name":"scikit-learn","full_name":"ogrisel/scikit-learn","owner":{"login":"ogrisel","id":89061,"avatar_url":"https://avatars.githubusercontent.com/u/89061?v=3","gravatar_id":"","url":"https://api.github.com/users/ogrisel","html_url":"https://github.com/ogrisel","followers_url":"https://api.github.com/users/ogrisel/followers","following_url":"https://api.github.com/users/ogrisel/following{/other_user}","gists_url":"https://api.github.com/users/ogrisel/gists{/gist_id}","starred_url":"https://api.github.com/users/ogrisel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogrisel/subscriptions","organizations_url":"https://api.github.com/users/ogrisel/orgs","repos_url":"https://api.github.com/users/ogrisel/repos","events_url":"https://api.github.com/users/ogrisel/events{/privacy}","received_events_url":"https://api.github.com/users/ogrisel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ogrisel/scikit-learn","description":"scikit-learn repo for ogrisel's work in progress contributions","fork":true,"url":"https://api.github.com/repos/ogrisel/scikit-learn","forks_url":"https://api.github.com/repos/ogrisel/scikit-learn/forks","keys_url":"https://api.github.com/repos/ogrisel/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ogrisel/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ogrisel/scikit-learn/teams","hooks_url":"https://api.github.com/repos/ogrisel/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/ogrisel/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/ogrisel/scikit-learn/events","assignees_url":"https://api.github.com/repos/ogrisel/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/ogrisel/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/ogrisel/scikit-learn/tags","blobs_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ogrisel/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/ogrisel/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/ogrisel/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/ogrisel/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/ogrisel/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/ogrisel/scikit-learn/subscription","commits_url":"https://api.github.com/repos/ogrisel/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/ogrisel/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/ogrisel/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/ogrisel/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/ogrisel/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/ogrisel/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ogrisel/scikit-learn/merges","archive_url":"https://api.github.com/repos/ogrisel/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ogrisel/scikit-learn/downloads","issues_url":"https://api.github.com/repos/ogrisel/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/ogrisel/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/ogrisel/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/ogrisel/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ogrisel/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/ogrisel/scikit-learn/releases{/id}","created_at":"2010-08-17T12:40:43Z","updated_at":"2015-02-26T22:21:46Z","pushed_at":"2015-04-09T12:12:30Z","git_url":"git://github.com/ogrisel/scikit-learn.git","ssh_url":"git@github.com:ogrisel/scikit-learn.git","clone_url":"https://github.com/ogrisel/scikit-learn.git","svn_url":"https://github.com/ogrisel/scikit-learn","homepage":"http://scikit-learn.org","size":63767,"stargazers_count":17,"watchers_count":17,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":17,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"46aacd3be265563cfc949e330b022ffe90430fc8","user":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"avatar_url":"https://avatars.githubusercontent.com/u/365630?v=3","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","created_at":"2010-08-17T09:43:38Z","updated_at":"2015-04-09T13:10:50Z","pushed_at":"2015-04-09T12:13:51Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":121020,"stargazers_count":5536,"watchers_count":5536,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3305,"mirror_url":null,"open_issues_count":631,"forks":3305,"open_issues":631,"watchers":5536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/4555"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4555"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/4555/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/4555/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/91fac5a329fc1a9d0acf7408db5071e86a94063c"}}}}