{"action":"created","comment":{"url":"https://api.github.com/repos/dahuapp/dahu/pulls/comments/31903278","id":31903278,"diff_hunk":"@@ -5,19 +5,63 @@\n define([\n     'handlebars',\n     'backbone.marionette',\n+    // views\n+    'views/workspace/actions/action',\n     // templates\n     'text!templates/views/workspace/actions/move.html'\n ], function(\n     Handlebars,\n     Marionette,\n+    // views\n+    ActionView,\n     // templates\n     moveTemplate\n ) {\n-    \n+\n+    var ExtraParamView = Marionette.ItemView.extend({\n+\n+        template: Handlebars.default.compile(moveTemplate),\n+\n+        initialize: function (model) {\n+            this.model = model;\n+        },\n+\n+        triggers: {\n+            \"change .trXChoice\": \"move:trx:change\",\n+            \"change .trYChoice\": \"move:try:change\"\n+        }\n+    });\n+\n     /**\n      * Move action view\n      */\n-    return Marionette.ItemView.extend({\n-        template: Handlebars.default.compile(moveTemplate)\n+    return ActionView.extend({\n+\n+        onChildviewMoveTrxChange: function () {\n+            var id = \"#trXChoice_\" + this.model.id;\n+            var value = parseInt($(id).val());\n+            if (!_.isNaN(value)){\n+                this.model.set('trX', value);\n+            }\n+            else {\n+                throw new Exception.IOError(\"Translation X input is NaN\");\n+            }\n+        },\n+\n+        onChildviewMoveTryChange: function () {\n+            var id = \"#trYChoice_\" + this.model.id;\n+            var value = parseInt($(id).val());\n+            if (!_.isNaN(value)){\n+                this.model.set('trY',value);\n+            }\n+            else {\n+                throw new Exceptions.IOError(\"Translation Y input is NaN\");\n+            }\n+        },\n+\n+        onRender: function () {","path":"dahu/core/app/scripts/views/workspace/actions/move.js","position":61,"original_position":61,"commit_id":"58c0ea27ed839c57473bde1cc5467d7659b571bd","original_commit_id":"58c0ea27ed839c57473bde1cc5467d7659b571bd","user":{"login":"obzota","id":12509277,"avatar_url":"https://avatars.githubusercontent.com/u/12509277?v=3","gravatar_id":"","url":"https://api.github.com/users/obzota","html_url":"https://github.com/obzota","followers_url":"https://api.github.com/users/obzota/followers","following_url":"https://api.github.com/users/obzota/following{/other_user}","gists_url":"https://api.github.com/users/obzota/gists{/gist_id}","starred_url":"https://api.github.com/users/obzota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obzota/subscriptions","organizations_url":"https://api.github.com/users/obzota/orgs","repos_url":"https://api.github.com/users/obzota/repos","events_url":"https://api.github.com/users/obzota/events{/privacy}","received_events_url":"https://api.github.com/users/obzota/received_events","type":"User","site_admin":false},"body":"@barraq Doesnt work with 'onShow' neither with 'onBeforeShow'.\r\n'onBeforeShow' will never display extra settings\r\n'onShow' will not display settings on refresh (for trigger change)","created_at":"2015-06-08T10:51:27Z","updated_at":"2015-06-08T10:51:27Z","html_url":"https://github.com/dahuapp/dahu/pull/175#discussion_r31903278","pull_request_url":"https://api.github.com/repos/dahuapp/dahu/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/dahuapp/dahu/pulls/comments/31903278"},"html":{"href":"https://github.com/dahuapp/dahu/pull/175#discussion_r31903278"},"pull_request":{"href":"https://api.github.com/repos/dahuapp/dahu/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/dahuapp/dahu/pulls/175","id":37007341,"html_url":"https://github.com/dahuapp/dahu/pull/175","diff_url":"https://github.com/dahuapp/dahu/pull/175.diff","patch_url":"https://github.com/dahuapp/dahu/pull/175.patch","issue_url":"https://api.github.com/repos/dahuapp/dahu/issues/175","number":175,"state":"open","locked":false,"title":"Introduce animation edition","user":{"login":"obzota","id":12509277,"avatar_url":"https://avatars.githubusercontent.com/u/12509277?v=3","gravatar_id":"","url":"https://api.github.com/users/obzota","html_url":"https://github.com/obzota","followers_url":"https://api.github.com/users/obzota/followers","following_url":"https://api.github.com/users/obzota/following{/other_user}","gists_url":"https://api.github.com/users/obzota/gists{/gist_id}","starred_url":"https://api.github.com/users/obzota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obzota/subscriptions","organizations_url":"https://api.github.com/users/obzota/orgs","repos_url":"https://api.github.com/users/obzota/repos","events_url":"https://api.github.com/users/obzota/events{/privacy}","received_events_url":"https://api.github.com/users/obzota/received_events","type":"User","site_admin":false},"body":"Display the different actions with an alternative menu when clicked.\r\nUser can select the parameters via select lists and number inputs.\r\n\r\nAdd :\r\n- Layoutview mechanism for Actionview settings\r\n- Templating to change views in a dynamic way (toggle on/off settings)\r\n- inheritance between the views to control the templating and minimize\r\nthe code redundancie\r\n- subview in MoveView to control the region extra-settings\r\n- new set of events triggered by user actions in 'action' view. Associated\r\ncallbacks for (re)rendering and model updates.\r\n- attributes in actions models to match the parameters used in preview\r\n\r\nDelete :\r\n- unused template appear and disappear.","created_at":"2015-06-05T07:34:48Z","updated_at":"2015-06-08T10:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dae6fab18bbce4f6aff7de226bdaaa01515dd68b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dahuapp/dahu/pulls/175/commits","review_comments_url":"https://api.github.com/repos/dahuapp/dahu/pulls/175/comments","review_comment_url":"https://api.github.com/repos/dahuapp/dahu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dahuapp/dahu/issues/175/comments","statuses_url":"https://api.github.com/repos/dahuapp/dahu/statuses/58c0ea27ed839c57473bde1cc5467d7659b571bd","head":{"label":"obzota:pull-request-action-editor-settings","ref":"pull-request-action-editor-settings","sha":"58c0ea27ed839c57473bde1cc5467d7659b571bd","user":{"login":"obzota","id":12509277,"avatar_url":"https://avatars.githubusercontent.com/u/12509277?v=3","gravatar_id":"","url":"https://api.github.com/users/obzota","html_url":"https://github.com/obzota","followers_url":"https://api.github.com/users/obzota/followers","following_url":"https://api.github.com/users/obzota/following{/other_user}","gists_url":"https://api.github.com/users/obzota/gists{/gist_id}","starred_url":"https://api.github.com/users/obzota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obzota/subscriptions","organizations_url":"https://api.github.com/users/obzota/orgs","repos_url":"https://api.github.com/users/obzota/repos","events_url":"https://api.github.com/users/obzota/events{/privacy}","received_events_url":"https://api.github.com/users/obzota/received_events","type":"User","site_admin":false},"repo":{"id":35999719,"name":"dahu","full_name":"obzota/dahu","owner":{"login":"obzota","id":12509277,"avatar_url":"https://avatars.githubusercontent.com/u/12509277?v=3","gravatar_id":"","url":"https://api.github.com/users/obzota","html_url":"https://github.com/obzota","followers_url":"https://api.github.com/users/obzota/followers","following_url":"https://api.github.com/users/obzota/following{/other_user}","gists_url":"https://api.github.com/users/obzota/gists{/gist_id}","starred_url":"https://api.github.com/users/obzota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/obzota/subscriptions","organizations_url":"https://api.github.com/users/obzota/orgs","repos_url":"https://api.github.com/users/obzota/repos","events_url":"https://api.github.com/users/obzota/events{/privacy}","received_events_url":"https://api.github.com/users/obzota/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/obzota/dahu","description":"The objective of this project is to develop a \"real\" alternative to existing screencasting software. Even if there is a wide variety of software that offers to make screencasts, none of these programs do offer effective solutions combining the features / properties that we could expect of this kind of tool.","fork":true,"url":"https://api.github.com/repos/obzota/dahu","forks_url":"https://api.github.com/repos/obzota/dahu/forks","keys_url":"https://api.github.com/repos/obzota/dahu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/obzota/dahu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/obzota/dahu/teams","hooks_url":"https://api.github.com/repos/obzota/dahu/hooks","issue_events_url":"https://api.github.com/repos/obzota/dahu/issues/events{/number}","events_url":"https://api.github.com/repos/obzota/dahu/events","assignees_url":"https://api.github.com/repos/obzota/dahu/assignees{/user}","branches_url":"https://api.github.com/repos/obzota/dahu/branches{/branch}","tags_url":"https://api.github.com/repos/obzota/dahu/tags","blobs_url":"https://api.github.com/repos/obzota/dahu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/obzota/dahu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/obzota/dahu/git/refs{/sha}","trees_url":"https://api.github.com/repos/obzota/dahu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/obzota/dahu/statuses/{sha}","languages_url":"https://api.github.com/repos/obzota/dahu/languages","stargazers_url":"https://api.github.com/repos/obzota/dahu/stargazers","contributors_url":"https://api.github.com/repos/obzota/dahu/contributors","subscribers_url":"https://api.github.com/repos/obzota/dahu/subscribers","subscription_url":"https://api.github.com/repos/obzota/dahu/subscription","commits_url":"https://api.github.com/repos/obzota/dahu/commits{/sha}","git_commits_url":"https://api.github.com/repos/obzota/dahu/git/commits{/sha}","comments_url":"https://api.github.com/repos/obzota/dahu/comments{/number}","issue_comment_url":"https://api.github.com/repos/obzota/dahu/issues/comments{/number}","contents_url":"https://api.github.com/repos/obzota/dahu/contents/{+path}","compare_url":"https://api.github.com/repos/obzota/dahu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/obzota/dahu/merges","archive_url":"https://api.github.com/repos/obzota/dahu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/obzota/dahu/downloads","issues_url":"https://api.github.com/repos/obzota/dahu/issues{/number}","pulls_url":"https://api.github.com/repos/obzota/dahu/pulls{/number}","milestones_url":"https://api.github.com/repos/obzota/dahu/milestones{/number}","notifications_url":"https://api.github.com/repos/obzota/dahu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/obzota/dahu/labels{/name}","releases_url":"https://api.github.com/repos/obzota/dahu/releases{/id}","created_at":"2015-05-21T08:06:59Z","updated_at":"2015-05-21T08:07:00Z","pushed_at":"2015-06-08T10:44:43Z","git_url":"git://github.com/obzota/dahu.git","ssh_url":"git@github.com:obzota/dahu.git","clone_url":"https://github.com/obzota/dahu.git","svn_url":"https://github.com/obzota/dahu","homepage":"","size":3572,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"dahuapp:next-feature-animation-editor","ref":"next-feature-animation-editor","sha":"887742e129752464ca6ca55377ba61e08237b7fc","user":{"login":"dahuapp","id":4487168,"avatar_url":"https://avatars.githubusercontent.com/u/4487168?v=3","gravatar_id":"","url":"https://api.github.com/users/dahuapp","html_url":"https://github.com/dahuapp","followers_url":"https://api.github.com/users/dahuapp/followers","following_url":"https://api.github.com/users/dahuapp/following{/other_user}","gists_url":"https://api.github.com/users/dahuapp/gists{/gist_id}","starred_url":"https://api.github.com/users/dahuapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahuapp/subscriptions","organizations_url":"https://api.github.com/users/dahuapp/orgs","repos_url":"https://api.github.com/users/dahuapp/repos","events_url":"https://api.github.com/users/dahuapp/events{/privacy}","received_events_url":"https://api.github.com/users/dahuapp/received_events","type":"Organization","site_admin":false},"repo":{"id":10477298,"name":"dahu","full_name":"dahuapp/dahu","owner":{"login":"dahuapp","id":4487168,"avatar_url":"https://avatars.githubusercontent.com/u/4487168?v=3","gravatar_id":"","url":"https://api.github.com/users/dahuapp","html_url":"https://github.com/dahuapp","followers_url":"https://api.github.com/users/dahuapp/followers","following_url":"https://api.github.com/users/dahuapp/following{/other_user}","gists_url":"https://api.github.com/users/dahuapp/gists{/gist_id}","starred_url":"https://api.github.com/users/dahuapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dahuapp/subscriptions","organizations_url":"https://api.github.com/users/dahuapp/orgs","repos_url":"https://api.github.com/users/dahuapp/repos","events_url":"https://api.github.com/users/dahuapp/events{/privacy}","received_events_url":"https://api.github.com/users/dahuapp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dahuapp/dahu","description":"The objective of this project is to develop a \"real\" alternative to existing screencasting software. Even if there is a wide variety of software that offers to make screencasts, none of these programs do offer effective solutions combining the features / properties that we could expect of this kind of tool.","fork":false,"url":"https://api.github.com/repos/dahuapp/dahu","forks_url":"https://api.github.com/repos/dahuapp/dahu/forks","keys_url":"https://api.github.com/repos/dahuapp/dahu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dahuapp/dahu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dahuapp/dahu/teams","hooks_url":"https://api.github.com/repos/dahuapp/dahu/hooks","issue_events_url":"https://api.github.com/repos/dahuapp/dahu/issues/events{/number}","events_url":"https://api.github.com/repos/dahuapp/dahu/events","assignees_url":"https://api.github.com/repos/dahuapp/dahu/assignees{/user}","branches_url":"https://api.github.com/repos/dahuapp/dahu/branches{/branch}","tags_url":"https://api.github.com/repos/dahuapp/dahu/tags","blobs_url":"https://api.github.com/repos/dahuapp/dahu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dahuapp/dahu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dahuapp/dahu/git/refs{/sha}","trees_url":"https://api.github.com/repos/dahuapp/dahu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dahuapp/dahu/statuses/{sha}","languages_url":"https://api.github.com/repos/dahuapp/dahu/languages","stargazers_url":"https://api.github.com/repos/dahuapp/dahu/stargazers","contributors_url":"https://api.github.com/repos/dahuapp/dahu/contributors","subscribers_url":"https://api.github.com/repos/dahuapp/dahu/subscribers","subscription_url":"https://api.github.com/repos/dahuapp/dahu/subscription","commits_url":"https://api.github.com/repos/dahuapp/dahu/commits{/sha}","git_commits_url":"https://api.github.com/repos/dahuapp/dahu/git/commits{/sha}","comments_url":"https://api.github.com/repos/dahuapp/dahu/comments{/number}","issue_comment_url":"https://api.github.com/repos/dahuapp/dahu/issues/comments{/number}","contents_url":"https://api.github.com/repos/dahuapp/dahu/contents/{+path}","compare_url":"https://api.github.com/repos/dahuapp/dahu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dahuapp/dahu/merges","archive_url":"https://api.github.com/repos/dahuapp/dahu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dahuapp/dahu/downloads","issues_url":"https://api.github.com/repos/dahuapp/dahu/issues{/number}","pulls_url":"https://api.github.com/repos/dahuapp/dahu/pulls{/number}","milestones_url":"https://api.github.com/repos/dahuapp/dahu/milestones{/number}","notifications_url":"https://api.github.com/repos/dahuapp/dahu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dahuapp/dahu/labels{/name}","releases_url":"https://api.github.com/repos/dahuapp/dahu/releases{/id}","created_at":"2013-06-04T11:40:36Z","updated_at":"2015-05-20T09:02:50Z","pushed_at":"2015-06-08T10:44:43Z","git_url":"git://github.com/dahuapp/dahu.git","ssh_url":"git@github.com:dahuapp/dahu.git","clone_url":"https://github.com/dahuapp/dahu.git","svn_url":"https://github.com/dahuapp/dahu","homepage":"","size":5380,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":46,"forks":15,"open_issues":46,"watchers":44,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/dahuapp/dahu/pulls/175"},"html":{"href":"https://github.com/dahuapp/dahu/pull/175"},"issue":{"href":"https://api.github.com/repos/dahuapp/dahu/issues/175"},"comments":{"href":"https://api.github.com/repos/dahuapp/dahu/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/dahuapp/dahu/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/dahuapp/dahu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dahuapp/dahu/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/dahuapp/dahu/statuses/58c0ea27ed839c57473bde1cc5467d7659b571bd"}}}}