{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/1755","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/1755/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/1755/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/1755/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/1755","id":96076493,"number":1755,"title":"add sshpass support for `synchronize`","user":{"login":"elvis-macak","id":5038564,"avatar_url":"https://avatars.githubusercontent.com/u/5038564?v=3","gravatar_id":"","url":"https://api.github.com/users/elvis-macak","html_url":"https://github.com/elvis-macak","followers_url":"https://api.github.com/users/elvis-macak/followers","following_url":"https://api.github.com/users/elvis-macak/following{/other_user}","gists_url":"https://api.github.com/users/elvis-macak/gists{/gist_id}","starred_url":"https://api.github.com/users/elvis-macak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elvis-macak/subscriptions","organizations_url":"https://api.github.com/users/elvis-macak/orgs","repos_url":"https://api.github.com/users/elvis-macak/repos","events_url":"https://api.github.com/users/elvis-macak/events{/privacy}","received_events_url":"https://api.github.com/users/elvis-macak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/feature_pull_request","name":"feature_pull_request","color":"009800"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/needs_rebase","name":"needs_rebase","color":"eb6420"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/needs_revision","name":"needs_revision","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":18,"created_at":"2015-07-20T14:28:19Z","updated_at":"2015-10-12T07:49:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/1755","html_url":"https://github.com/ansible/ansible-modules-core/pull/1755","diff_url":"https://github.com/ansible/ansible-modules-core/pull/1755.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/1755.patch"},"body":"add sshpass support for rsync\r\nwork together with https://github.com/ansible/ansible/pull/11657"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/147316680","html_url":"https://github.com/ansible/ansible-modules-core/pull/1755#issuecomment-147316680","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/1755","id":147316680,"user":{"login":"ritzk","id":7668569,"avatar_url":"https://avatars.githubusercontent.com/u/7668569?v=3","gravatar_id":"","url":"https://api.github.com/users/ritzk","html_url":"https://github.com/ritzk","followers_url":"https://api.github.com/users/ritzk/followers","following_url":"https://api.github.com/users/ritzk/following{/other_user}","gists_url":"https://api.github.com/users/ritzk/gists{/gist_id}","starred_url":"https://api.github.com/users/ritzk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ritzk/subscriptions","organizations_url":"https://api.github.com/users/ritzk/orgs","repos_url":"https://api.github.com/users/ritzk/repos","events_url":"https://api.github.com/users/ritzk/events{/privacy}","received_events_url":"https://api.github.com/users/ritzk/received_events","type":"User","site_admin":false},"created_at":"2015-10-12T07:49:48Z","updated_at":"2015-10-12T07:49:48Z","body":"##### Security consideration \r\n- These are only readable by owner, or root. root can read almost everything based on selinux/security policies (including /proc/kcore)\r\n- ssh client tends to strip out env variables, SSHPASS should not be seen by client process (SendENv bit)\r\n\r\n##### reasons to opt for env var \r\n- module.run_command does not support passing an fd to command module. \r\n- ssh and sshpass do not support reading password from stdin pipe ( data arg of run_command)\r\n- adding support for setting up env was the least invasive and reliable change\r\n"}}