{"action":"created","issue":{"url":"https://api.github.com/repos/ddeboer/vatin/issues/11","labels_url":"https://api.github.com/repos/ddeboer/vatin/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/ddeboer/vatin/issues/11/comments","events_url":"https://api.github.com/repos/ddeboer/vatin/issues/11/events","html_url":"https://github.com/ddeboer/vatin/pull/11","id":55630197,"number":11,"title":"Optionally catch WSDL client exceptions","user":{"login":"alanpearce","id":850317,"avatar_url":"https://avatars.githubusercontent.com/u/850317?v=3","gravatar_id":"","url":"https://api.github.com/users/alanpearce","html_url":"https://github.com/alanpearce","followers_url":"https://api.github.com/users/alanpearce/followers","following_url":"https://api.github.com/users/alanpearce/following{/other_user}","gists_url":"https://api.github.com/users/alanpearce/gists{/gist_id}","starred_url":"https://api.github.com/users/alanpearce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanpearce/subscriptions","organizations_url":"https://api.github.com/users/alanpearce/orgs","repos_url":"https://api.github.com/users/alanpearce/repos","events_url":"https://api.github.com/users/alanpearce/events{/privacy}","received_events_url":"https://api.github.com/users/alanpearce/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-27T15:16:06Z","updated_at":"2015-05-12T05:34:19Z","closed_at":"2015-05-11T14:32:38Z","pull_request":{"url":"https://api.github.com/repos/ddeboer/vatin/pulls/11","html_url":"https://github.com/ddeboer/vatin/pull/11","diff_url":"https://github.com/ddeboer/vatin/pull/11.diff","patch_url":"https://github.com/ddeboer/vatin/pull/11.patch"},"body":"This fixes #9 and #10 if a third parameter is passed to `Validator::isValid`.\r\n\r\nWhen there is an error with the service, the third parameter becomes the return value, so set it to `true` to assume a valid number or `false` to assume an invalid number.\r\n\r\nI'm not too sure whether it makes sense to have the default/null handled as it is currently, but I wanted to make sure that `testWrongConnectionThrowsException` passed. Any thoughts?"},"comment":{"url":"https://api.github.com/repos/ddeboer/vatin/issues/comments/101138886","html_url":"https://github.com/ddeboer/vatin/pull/11#issuecomment-101138886","issue_url":"https://api.github.com/repos/ddeboer/vatin/issues/11","id":101138886,"user":{"login":"ddeboer","id":89267,"avatar_url":"https://avatars.githubusercontent.com/u/89267?v=3","gravatar_id":"","url":"https://api.github.com/users/ddeboer","html_url":"https://github.com/ddeboer","followers_url":"https://api.github.com/users/ddeboer/followers","following_url":"https://api.github.com/users/ddeboer/following{/other_user}","gists_url":"https://api.github.com/users/ddeboer/gists{/gist_id}","starred_url":"https://api.github.com/users/ddeboer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ddeboer/subscriptions","organizations_url":"https://api.github.com/users/ddeboer/orgs","repos_url":"https://api.github.com/users/ddeboer/repos","events_url":"https://api.github.com/users/ddeboer/events{/privacy}","received_events_url":"https://api.github.com/users/ddeboer/received_events","type":"User","site_admin":false},"created_at":"2015-05-12T05:34:19Z","updated_at":"2015-05-12T05:34:19Z","body":"> and there is a soap fault, will it simply now throw the SoapFault exception?\r\n\r\nYes.\r\n\r\n> Do I have to write my own custom validator to handle this?\r\n\r\nNo."}}