{"action":"created","issue":{"url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/issues/7","labels_url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/issues/7/comments","events_url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/issues/7/events","html_url":"https://github.com/markitx/dynamo-backup-to-s3/pull/7","id":89379904,"number":7,"title":"Various improvements","user":{"login":"adambiggs","id":857229,"avatar_url":"https://avatars.githubusercontent.com/u/857229?v=3","gravatar_id":"","url":"https://api.github.com/users/adambiggs","html_url":"https://github.com/adambiggs","followers_url":"https://api.github.com/users/adambiggs/followers","following_url":"https://api.github.com/users/adambiggs/following{/other_user}","gists_url":"https://api.github.com/users/adambiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/adambiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambiggs/subscriptions","organizations_url":"https://api.github.com/users/adambiggs/orgs","repos_url":"https://api.github.com/users/adambiggs/repos","events_url":"https://api.github.com/users/adambiggs/events{/privacy}","received_events_url":"https://api.github.com/users/adambiggs/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"benblair","id":770114,"avatar_url":"https://avatars.githubusercontent.com/u/770114?v=3","gravatar_id":"","url":"https://api.github.com/users/benblair","html_url":"https://github.com/benblair","followers_url":"https://api.github.com/users/benblair/followers","following_url":"https://api.github.com/users/benblair/following{/other_user}","gists_url":"https://api.github.com/users/benblair/gists{/gist_id}","starred_url":"https://api.github.com/users/benblair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benblair/subscriptions","organizations_url":"https://api.github.com/users/benblair/orgs","repos_url":"https://api.github.com/users/benblair/repos","events_url":"https://api.github.com/users/benblair/events{/privacy}","received_events_url":"https://api.github.com/users/benblair/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-06-18T19:41:10Z","updated_at":"2015-12-07T23:30:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/pulls/7","html_url":"https://github.com/markitx/dynamo-backup-to-s3/pull/7","diff_url":"https://github.com/markitx/dynamo-backup-to-s3/pull/7.diff","patch_url":"https://github.com/markitx/dynamo-backup-to-s3/pull/7.patch"},"body":"Nice work, this is a really helpful module!\r\n\r\nI needed to make some changes to get this working for our app, and made some improvements along the way:\r\n\r\n- `.json` files are stored as valid JSON - Objects are now stored in a comma-separated JSON array\r\n- Updated to latest version of `s3-streaming-upload` module, which uses newer AWS APIs for uploading\r\n- Switched from Underscore to Lodash\r\n- Updated to latest version of all other dependencies\r\n- Changed minimum Node version to `0.10.0`\r\n- Pass start/end/duration timing data into `start-backup` and `end-backup` event callbacks\r\n- Use UTC timezone for backup timestamps\r\n- Fixed a bug with `stopOnFailure` option\r\n- Added a `debug` option (forwarded to `s3-streaming-upload` module)\r\n- Added an `indentJSON` option to store backup JSON with tab indentation\r\n\r\nStuff missing from this PR:\r\n- Docs\r\n- Tests (unit tests don't seem to be set up yet)"},"comment":{"url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/issues/comments/162704762","html_url":"https://github.com/markitx/dynamo-backup-to-s3/pull/7#issuecomment-162704762","issue_url":"https://api.github.com/repos/markitx/dynamo-backup-to-s3/issues/7","id":162704762,"user":{"login":"adambiggs","id":857229,"avatar_url":"https://avatars.githubusercontent.com/u/857229?v=3","gravatar_id":"","url":"https://api.github.com/users/adambiggs","html_url":"https://github.com/adambiggs","followers_url":"https://api.github.com/users/adambiggs/followers","following_url":"https://api.github.com/users/adambiggs/following{/other_user}","gists_url":"https://api.github.com/users/adambiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/adambiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adambiggs/subscriptions","organizations_url":"https://api.github.com/users/adambiggs/orgs","repos_url":"https://api.github.com/users/adambiggs/repos","events_url":"https://api.github.com/users/adambiggs/events{/privacy}","received_events_url":"https://api.github.com/users/adambiggs/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T23:30:55Z","updated_at":"2015-12-07T23:30:55Z","body":"@dylanlingelbach I rebased this PR, removing the JSON formatting stuff and updating NPM packages to current latest versions.\r\n\r\nI'm wondering though, do you have a separate library for restoring the backups created by this one? I want to make sure we have a solid plan in case we ever need to do a restore."}}