{"action":"closed","number":67,"pull_request":{"url":"https://api.github.com/repos/davvil/pdfpc/pulls/67","id":9942270,"html_url":"https://github.com/davvil/pdfpc/pull/67","diff_url":"https://github.com/davvil/pdfpc/pull/67.diff","patch_url":"https://github.com/davvil/pdfpc/pull/67.patch","issue_url":"https://api.github.com/repos/davvil/pdfpc/issues/67","number":67,"state":"closed","locked":false,"title":"Fix timer divergence problem","user":{"login":"wentasah","id":140542,"avatar_url":"https://avatars.githubusercontent.com/u/140542?v=3","gravatar_id":"","url":"https://api.github.com/users/wentasah","html_url":"https://github.com/wentasah","followers_url":"https://api.github.com/users/wentasah/followers","following_url":"https://api.github.com/users/wentasah/following{/other_user}","gists_url":"https://api.github.com/users/wentasah/gists{/gist_id}","starred_url":"https://api.github.com/users/wentasah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wentasah/subscriptions","organizations_url":"https://api.github.com/users/wentasah/orgs","repos_url":"https://api.github.com/users/wentasah/repos","events_url":"https://api.github.com/users/wentasah/events{/privacy}","received_events_url":"https://api.github.com/users/wentasah/received_events","type":"User","site_admin":false},"body":"The problem was that the value shown by the timer diverged from real\r\ntime. The reason was that the time was calculated from a counter that\r\nwas increased in a timer callback called approximately every second.\r\nBecause the timer period is not guaranteed to be precise, the counter\r\naccumulated the small errors resulting in the time shown not to be\r\nprecise and diverging over time.\r\n\r\nThis is fixed by always calculating the time to show by subtracting\r\ncurrent time from the presentation start time. All timer modes (count\r\nup, end time, duration, pre-talk) were checked to work properly after\r\nthis change.","created_at":"2013-11-13T22:51:20Z","updated_at":"2015-05-18T21:46:48Z","closed_at":"2015-05-18T21:46:48Z","merged_at":null,"merge_commit_sha":"fb4268529b251084d0e97705fc42009d1ba44e9b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/davvil/pdfpc/pulls/67/commits","review_comments_url":"https://api.github.com/repos/davvil/pdfpc/pulls/67/comments","review_comment_url":"https://api.github.com/repos/davvil/pdfpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/davvil/pdfpc/issues/67/comments","statuses_url":"https://api.github.com/repos/davvil/pdfpc/statuses/99581c4ac0c3a3eacac178b457741c92304a4394","head":{"label":"wentasah:timer-fixes","ref":"timer-fixes","sha":"99581c4ac0c3a3eacac178b457741c92304a4394","user":{"login":"wentasah","id":140542,"avatar_url":"https://avatars.githubusercontent.com/u/140542?v=3","gravatar_id":"","url":"https://api.github.com/users/wentasah","html_url":"https://github.com/wentasah","followers_url":"https://api.github.com/users/wentasah/followers","following_url":"https://api.github.com/users/wentasah/following{/other_user}","gists_url":"https://api.github.com/users/wentasah/gists{/gist_id}","starred_url":"https://api.github.com/users/wentasah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wentasah/subscriptions","organizations_url":"https://api.github.com/users/wentasah/orgs","repos_url":"https://api.github.com/users/wentasah/repos","events_url":"https://api.github.com/users/wentasah/events{/privacy}","received_events_url":"https://api.github.com/users/wentasah/received_events","type":"User","site_admin":false},"repo":{"id":14378745,"name":"pdfpc","full_name":"wentasah/pdfpc","owner":{"login":"wentasah","id":140542,"avatar_url":"https://avatars.githubusercontent.com/u/140542?v=3","gravatar_id":"","url":"https://api.github.com/users/wentasah","html_url":"https://github.com/wentasah","followers_url":"https://api.github.com/users/wentasah/followers","following_url":"https://api.github.com/users/wentasah/following{/other_user}","gists_url":"https://api.github.com/users/wentasah/gists{/gist_id}","starred_url":"https://api.github.com/users/wentasah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wentasah/subscriptions","organizations_url":"https://api.github.com/users/wentasah/orgs","repos_url":"https://api.github.com/users/wentasah/repos","events_url":"https://api.github.com/users/wentasah/events{/privacy}","received_events_url":"https://api.github.com/users/wentasah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wentasah/pdfpc","description":"A presenter console with multi-monitor support for PDF files.","fork":true,"url":"https://api.github.com/repos/wentasah/pdfpc","forks_url":"https://api.github.com/repos/wentasah/pdfpc/forks","keys_url":"https://api.github.com/repos/wentasah/pdfpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wentasah/pdfpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wentasah/pdfpc/teams","hooks_url":"https://api.github.com/repos/wentasah/pdfpc/hooks","issue_events_url":"https://api.github.com/repos/wentasah/pdfpc/issues/events{/number}","events_url":"https://api.github.com/repos/wentasah/pdfpc/events","assignees_url":"https://api.github.com/repos/wentasah/pdfpc/assignees{/user}","branches_url":"https://api.github.com/repos/wentasah/pdfpc/branches{/branch}","tags_url":"https://api.github.com/repos/wentasah/pdfpc/tags","blobs_url":"https://api.github.com/repos/wentasah/pdfpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wentasah/pdfpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wentasah/pdfpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/wentasah/pdfpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wentasah/pdfpc/statuses/{sha}","languages_url":"https://api.github.com/repos/wentasah/pdfpc/languages","stargazers_url":"https://api.github.com/repos/wentasah/pdfpc/stargazers","contributors_url":"https://api.github.com/repos/wentasah/pdfpc/contributors","subscribers_url":"https://api.github.com/repos/wentasah/pdfpc/subscribers","subscription_url":"https://api.github.com/repos/wentasah/pdfpc/subscription","commits_url":"https://api.github.com/repos/wentasah/pdfpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/wentasah/pdfpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/wentasah/pdfpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/wentasah/pdfpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/wentasah/pdfpc/contents/{+path}","compare_url":"https://api.github.com/repos/wentasah/pdfpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wentasah/pdfpc/merges","archive_url":"https://api.github.com/repos/wentasah/pdfpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wentasah/pdfpc/downloads","issues_url":"https://api.github.com/repos/wentasah/pdfpc/issues{/number}","pulls_url":"https://api.github.com/repos/wentasah/pdfpc/pulls{/number}","milestones_url":"https://api.github.com/repos/wentasah/pdfpc/milestones{/number}","notifications_url":"https://api.github.com/repos/wentasah/pdfpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wentasah/pdfpc/labels{/name}","releases_url":"https://api.github.com/repos/wentasah/pdfpc/releases{/id}","created_at":"2013-11-13T22:48:04Z","updated_at":"2013-11-13T22:51:20Z","pushed_at":"2015-05-18T21:42:59Z","git_url":"git://github.com/wentasah/pdfpc.git","ssh_url":"git@github.com:wentasah/pdfpc.git","clone_url":"https://github.com/wentasah/pdfpc.git","svn_url":"https://github.com/wentasah/pdfpc","homepage":"http://davvil.github.com/pdfpc/","size":2156,"stargazers_count":0,"watchers_count":0,"language":"Vala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"davvil:master","ref":"master","sha":"3ab8499fc8880eb834fb4fe86472f1faabb4543c","user":{"login":"davvil","id":683589,"avatar_url":"https://avatars.githubusercontent.com/u/683589?v=3","gravatar_id":"","url":"https://api.github.com/users/davvil","html_url":"https://github.com/davvil","followers_url":"https://api.github.com/users/davvil/followers","following_url":"https://api.github.com/users/davvil/following{/other_user}","gists_url":"https://api.github.com/users/davvil/gists{/gist_id}","starred_url":"https://api.github.com/users/davvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davvil/subscriptions","organizations_url":"https://api.github.com/users/davvil/orgs","repos_url":"https://api.github.com/users/davvil/repos","events_url":"https://api.github.com/users/davvil/events{/privacy}","received_events_url":"https://api.github.com/users/davvil/received_events","type":"User","site_admin":false},"repo":{"id":2834258,"name":"pdfpc","full_name":"davvil/pdfpc","owner":{"login":"davvil","id":683589,"avatar_url":"https://avatars.githubusercontent.com/u/683589?v=3","gravatar_id":"","url":"https://api.github.com/users/davvil","html_url":"https://github.com/davvil","followers_url":"https://api.github.com/users/davvil/followers","following_url":"https://api.github.com/users/davvil/following{/other_user}","gists_url":"https://api.github.com/users/davvil/gists{/gist_id}","starred_url":"https://api.github.com/users/davvil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davvil/subscriptions","organizations_url":"https://api.github.com/users/davvil/orgs","repos_url":"https://api.github.com/users/davvil/repos","events_url":"https://api.github.com/users/davvil/events{/privacy}","received_events_url":"https://api.github.com/users/davvil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davvil/pdfpc","description":"A presenter console with multi-monitor support for PDF files.","fork":true,"url":"https://api.github.com/repos/davvil/pdfpc","forks_url":"https://api.github.com/repos/davvil/pdfpc/forks","keys_url":"https://api.github.com/repos/davvil/pdfpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davvil/pdfpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davvil/pdfpc/teams","hooks_url":"https://api.github.com/repos/davvil/pdfpc/hooks","issue_events_url":"https://api.github.com/repos/davvil/pdfpc/issues/events{/number}","events_url":"https://api.github.com/repos/davvil/pdfpc/events","assignees_url":"https://api.github.com/repos/davvil/pdfpc/assignees{/user}","branches_url":"https://api.github.com/repos/davvil/pdfpc/branches{/branch}","tags_url":"https://api.github.com/repos/davvil/pdfpc/tags","blobs_url":"https://api.github.com/repos/davvil/pdfpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davvil/pdfpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davvil/pdfpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/davvil/pdfpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davvil/pdfpc/statuses/{sha}","languages_url":"https://api.github.com/repos/davvil/pdfpc/languages","stargazers_url":"https://api.github.com/repos/davvil/pdfpc/stargazers","contributors_url":"https://api.github.com/repos/davvil/pdfpc/contributors","subscribers_url":"https://api.github.com/repos/davvil/pdfpc/subscribers","subscription_url":"https://api.github.com/repos/davvil/pdfpc/subscription","commits_url":"https://api.github.com/repos/davvil/pdfpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/davvil/pdfpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/davvil/pdfpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/davvil/pdfpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/davvil/pdfpc/contents/{+path}","compare_url":"https://api.github.com/repos/davvil/pdfpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davvil/pdfpc/merges","archive_url":"https://api.github.com/repos/davvil/pdfpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davvil/pdfpc/downloads","issues_url":"https://api.github.com/repos/davvil/pdfpc/issues{/number}","pulls_url":"https://api.github.com/repos/davvil/pdfpc/pulls{/number}","milestones_url":"https://api.github.com/repos/davvil/pdfpc/milestones{/number}","notifications_url":"https://api.github.com/repos/davvil/pdfpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davvil/pdfpc/labels{/name}","releases_url":"https://api.github.com/repos/davvil/pdfpc/releases{/id}","created_at":"2011-11-23T08:27:56Z","updated_at":"2015-05-14T22:31:03Z","pushed_at":"2015-05-18T21:43:00Z","git_url":"git://github.com/davvil/pdfpc.git","ssh_url":"git@github.com:davvil/pdfpc.git","clone_url":"https://github.com/davvil/pdfpc.git","svn_url":"https://github.com/davvil/pdfpc","homepage":"http://davvil.github.com/pdfpc/","size":2592,"stargazers_count":191,"watchers_count":191,"language":"Vala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":24,"mirror_url":null,"open_issues_count":56,"forks":24,"open_issues":56,"watchers":191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/davvil/pdfpc/pulls/67"},"html":{"href":"https://github.com/davvil/pdfpc/pull/67"},"issue":{"href":"https://api.github.com/repos/davvil/pdfpc/issues/67"},"comments":{"href":"https://api.github.com/repos/davvil/pdfpc/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/davvil/pdfpc/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/davvil/pdfpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/davvil/pdfpc/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/davvil/pdfpc/statuses/99581c4ac0c3a3eacac178b457741c92304a4394"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":56,"additions":1240,"deletions":1796,"changed_files":42}}