{"action":"created","issue":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/274","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/274/comments","events_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/274/events","html_url":"https://github.com/stormpath/stormpath-sdk-java/pull/274","id":105117426,"number":274,"title":"Added TwoAppTenant annotation along with test.","user":{"login":"dogeared","id":364562,"avatar_url":"https://avatars.githubusercontent.com/u/364562?v=3","gravatar_id":"","url":"https://api.github.com/users/dogeared","html_url":"https://github.com/dogeared","followers_url":"https://api.github.com/users/dogeared/followers","following_url":"https://api.github.com/users/dogeared/following{/other_user}","gists_url":"https://api.github.com/users/dogeared/gists{/gist_id}","starred_url":"https://api.github.com/users/dogeared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogeared/subscriptions","organizations_url":"https://api.github.com/users/dogeared/orgs","repos_url":"https://api.github.com/users/dogeared/repos","events_url":"https://api.github.com/users/dogeared/events{/privacy}","received_events_url":"https://api.github.com/users/dogeared/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dogeared","id":364562,"avatar_url":"https://avatars.githubusercontent.com/u/364562?v=3","gravatar_id":"","url":"https://api.github.com/users/dogeared","html_url":"https://github.com/dogeared","followers_url":"https://api.github.com/users/dogeared/followers","following_url":"https://api.github.com/users/dogeared/following{/other_user}","gists_url":"https://api.github.com/users/dogeared/gists{/gist_id}","starred_url":"https://api.github.com/users/dogeared/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogeared/subscriptions","organizations_url":"https://api.github.com/users/dogeared/orgs","repos_url":"https://api.github.com/users/dogeared/repos","events_url":"https://api.github.com/users/dogeared/events{/privacy}","received_events_url":"https://api.github.com/users/dogeared/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/milestones/22","html_url":"https://github.com/stormpath/stormpath-sdk-java/milestones/1.0.RC4.6","labels_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/milestones/22/labels","id":1206198,"number":22,"title":"1.0.RC4.6","description":"","creator":{"login":"mrioan","id":717498,"avatar_url":"https://avatars.githubusercontent.com/u/717498?v=3","gravatar_id":"","url":"https://api.github.com/users/mrioan","html_url":"https://github.com/mrioan","followers_url":"https://api.github.com/users/mrioan/followers","following_url":"https://api.github.com/users/mrioan/following{/other_user}","gists_url":"https://api.github.com/users/mrioan/gists{/gist_id}","starred_url":"https://api.github.com/users/mrioan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrioan/subscriptions","organizations_url":"https://api.github.com/users/mrioan/orgs","repos_url":"https://api.github.com/users/mrioan/repos","events_url":"https://api.github.com/users/mrioan/events{/privacy}","received_events_url":"https://api.github.com/users/mrioan/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":9,"state":"open","created_at":"2015-07-14T01:21:41Z","updated_at":"2015-09-06T21:15:18Z","due_on":null,"closed_at":null},"comments":8,"created_at":"2015-09-06T21:15:18Z","updated_at":"2015-09-08T13:08:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/pulls/274","html_url":"https://github.com/stormpath/stormpath-sdk-java/pull/274","diff_url":"https://github.com/stormpath/stormpath-sdk-java/pull/274.diff","patch_url":"https://github.com/stormpath/stormpath-sdk-java/pull/274.patch"},"body":"This fulfills on being able to specify a two-app tenant for certain tests as defined here: https://stormpath.atlassian.net/wiki/display/SDKS/Testing+Environments.\r\n\r\nIt also removes a bunch of semicolons to make the tests more idiomatic groovy.\r\n\r\nTo ensure that a test uses the two-app tenant, this PR introduces the: `@TwoAppTenant` annotation. \r\n\r\nThe annotation is processed in `ClientIT` and therefor any integration test that extends `ClientIT` can make use of it.\r\n\r\nNote: Right now, the re-organized spring boot spring security code is in a different branch. The Spring tests do not use ClientIT at all. Check out this [branch](https://github.com/stormpath/stormpath-sdk-java/compare/spring_security_extension...spring_security_extension_two_app) that addresses the Spring side of things.\r\n\r\nAlso note that in this PR, no actual tests use the `@TwoAppTenant` annotation except a test that simply exercises the annotation itself.\r\n\r\nThe next step is to identify those tests that require using a two-app tenant."},"comment":{"url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/comments/138554483","html_url":"https://github.com/stormpath/stormpath-sdk-java/pull/274#issuecomment-138554483","issue_url":"https://api.github.com/repos/stormpath/stormpath-sdk-java/issues/274","id":138554483,"user":{"login":"mrioan","id":717498,"avatar_url":"https://avatars.githubusercontent.com/u/717498?v=3","gravatar_id":"","url":"https://api.github.com/users/mrioan","html_url":"https://github.com/mrioan","followers_url":"https://api.github.com/users/mrioan/followers","following_url":"https://api.github.com/users/mrioan/following{/other_user}","gists_url":"https://api.github.com/users/mrioan/gists{/gist_id}","starred_url":"https://api.github.com/users/mrioan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrioan/subscriptions","organizations_url":"https://api.github.com/users/mrioan/orgs","repos_url":"https://api.github.com/users/mrioan/repos","events_url":"https://api.github.com/users/mrioan/events{/privacy}","received_events_url":"https://api.github.com/users/mrioan/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T13:08:25Z","updated_at":"2015-09-08T13:08:25Z","body":"WRT:\r\n`TwoAppTenantAnnotationIT` is a concrete test that exercises the behavior of this (test only) feature\r\n\r\nMy Comment:\r\nYes, it verifies that the functionality is working, not problem with that test. But we are lacking an actual test that validates that the Annotation is in fact solving the problem it needs to solve: having Spring tests using it"}}