{"action":"created","comment":{"url":"https://api.github.com/repos/ijiraq/yapsfm/pulls/comments/31580325","id":31580325,"diff_hunk":"@@ -83,10 +108,10 @@ def save(self, name=None):\n \n         if name is None:","path":"modules.py","position":64,"original_position":64,"commit_id":"340bb204a7db68cc74566332bb7839973e22062f","original_commit_id":"340bb204a7db68cc74566332bb7839973e22062f","user":{"login":"ijiraq","id":1132123,"avatar_url":"https://avatars.githubusercontent.com/u/1132123?v=3","gravatar_id":"","url":"https://api.github.com/users/ijiraq","html_url":"https://github.com/ijiraq","followers_url":"https://api.github.com/users/ijiraq/followers","following_url":"https://api.github.com/users/ijiraq/following{/other_user}","gists_url":"https://api.github.com/users/ijiraq/gists{/gist_id}","starred_url":"https://api.github.com/users/ijiraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijiraq/subscriptions","organizations_url":"https://api.github.com/users/ijiraq/orgs","repos_url":"https://api.github.com/users/ijiraq/repos","events_url":"https://api.github.com/users/ijiraq/events{/privacy}","received_events_url":"https://api.github.com/users/ijiraq/received_events","type":"User","site_admin":false},"body":"This code structure could be simplified by a line like:\r\n\r\nname = \"{}.fits\".format(name is not None and name or self.name)\r\nhdu.writeto('name, clobber=True)\r\nprint >> sys.stdout, 'Saving {}'.format(name)\r\n\r\n\r\nand then just one 'save' chunk is needed.  The above line sets the value of the variable 'name' to the value of the variable 'name' if the current value of 'name' is not None other-wise name=self.name and then","created_at":"2015-06-02T23:02:41Z","updated_at":"2015-06-02T23:02:41Z","html_url":"https://github.com/ijiraq/yapsfm/pull/6#discussion_r31580325","pull_request_url":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/ijiraq/yapsfm/pulls/comments/31580325"},"html":{"href":"https://github.com/ijiraq/yapsfm/pull/6#discussion_r31580325"},"pull_request":{"href":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6","id":36782692,"html_url":"https://github.com/ijiraq/yapsfm/pull/6","diff_url":"https://github.com/ijiraq/yapsfm/pull/6.diff","patch_url":"https://github.com/ijiraq/yapsfm/pull/6.patch","issue_url":"https://api.github.com/repos/ijiraq/yapsfm/issues/6","number":6,"state":"open","locked":false,"title":"Data-cube ready to use","user":{"login":"floglass","id":3474893,"avatar_url":"https://avatars.githubusercontent.com/u/3474893?v=3","gravatar_id":"","url":"https://api.github.com/users/floglass","html_url":"https://github.com/floglass","followers_url":"https://api.github.com/users/floglass/followers","following_url":"https://api.github.com/users/floglass/following{/other_user}","gists_url":"https://api.github.com/users/floglass/gists{/gist_id}","starred_url":"https://api.github.com/users/floglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floglass/subscriptions","organizations_url":"https://api.github.com/users/floglass/orgs","repos_url":"https://api.github.com/users/floglass/repos","events_url":"https://api.github.com/users/floglass/events{/privacy}","received_events_url":"https://api.github.com/users/floglass/received_events","type":"User","site_admin":false},"body":"Working fine if aperture size < 1000, otherwise *very* slow.\r\nI personally use apertures of 101 pixels.\r\n\r\nThe output data-cube contains 11 layers, the first one is the polychromatic psf, and then each of the wavelengths used to create the polychrome.\r\nIf no aperture.fits file in the directory, the code will generate a 101x101 pixels HST-like aperture.\r\n\r\n5 verbose levels added. Accessible with the option -v when calling the code. The verbose levels are: debug, info, warning, error, critical.\r\nThe default level is info. If no information is wanted, I suggest using -v critical.","created_at":"2015-06-02T22:46:27Z","updated_at":"2015-06-02T23:02:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"74ca404aa50a8bc85feef6837069a0293693489c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6/commits","review_comments_url":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6/comments","review_comment_url":"https://api.github.com/repos/ijiraq/yapsfm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ijiraq/yapsfm/issues/6/comments","statuses_url":"https://api.github.com/repos/ijiraq/yapsfm/statuses/340bb204a7db68cc74566332bb7839973e22062f","head":{"label":"floglass:master","ref":"master","sha":"340bb204a7db68cc74566332bb7839973e22062f","user":{"login":"floglass","id":3474893,"avatar_url":"https://avatars.githubusercontent.com/u/3474893?v=3","gravatar_id":"","url":"https://api.github.com/users/floglass","html_url":"https://github.com/floglass","followers_url":"https://api.github.com/users/floglass/followers","following_url":"https://api.github.com/users/floglass/following{/other_user}","gists_url":"https://api.github.com/users/floglass/gists{/gist_id}","starred_url":"https://api.github.com/users/floglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floglass/subscriptions","organizations_url":"https://api.github.com/users/floglass/orgs","repos_url":"https://api.github.com/users/floglass/repos","events_url":"https://api.github.com/users/floglass/events{/privacy}","received_events_url":"https://api.github.com/users/floglass/received_events","type":"User","site_admin":false},"repo":{"id":33336202,"name":"yapsfm","full_name":"floglass/yapsfm","owner":{"login":"floglass","id":3474893,"avatar_url":"https://avatars.githubusercontent.com/u/3474893?v=3","gravatar_id":"","url":"https://api.github.com/users/floglass","html_url":"https://github.com/floglass","followers_url":"https://api.github.com/users/floglass/followers","following_url":"https://api.github.com/users/floglass/following{/other_user}","gists_url":"https://api.github.com/users/floglass/gists{/gist_id}","starred_url":"https://api.github.com/users/floglass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/floglass/subscriptions","organizations_url":"https://api.github.com/users/floglass/orgs","repos_url":"https://api.github.com/users/floglass/repos","events_url":"https://api.github.com/users/floglass/events{/privacy}","received_events_url":"https://api.github.com/users/floglass/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/floglass/yapsfm","description":"Yet Another PSF Model","fork":true,"url":"https://api.github.com/repos/floglass/yapsfm","forks_url":"https://api.github.com/repos/floglass/yapsfm/forks","keys_url":"https://api.github.com/repos/floglass/yapsfm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/floglass/yapsfm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/floglass/yapsfm/teams","hooks_url":"https://api.github.com/repos/floglass/yapsfm/hooks","issue_events_url":"https://api.github.com/repos/floglass/yapsfm/issues/events{/number}","events_url":"https://api.github.com/repos/floglass/yapsfm/events","assignees_url":"https://api.github.com/repos/floglass/yapsfm/assignees{/user}","branches_url":"https://api.github.com/repos/floglass/yapsfm/branches{/branch}","tags_url":"https://api.github.com/repos/floglass/yapsfm/tags","blobs_url":"https://api.github.com/repos/floglass/yapsfm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/floglass/yapsfm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/floglass/yapsfm/git/refs{/sha}","trees_url":"https://api.github.com/repos/floglass/yapsfm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/floglass/yapsfm/statuses/{sha}","languages_url":"https://api.github.com/repos/floglass/yapsfm/languages","stargazers_url":"https://api.github.com/repos/floglass/yapsfm/stargazers","contributors_url":"https://api.github.com/repos/floglass/yapsfm/contributors","subscribers_url":"https://api.github.com/repos/floglass/yapsfm/subscribers","subscription_url":"https://api.github.com/repos/floglass/yapsfm/subscription","commits_url":"https://api.github.com/repos/floglass/yapsfm/commits{/sha}","git_commits_url":"https://api.github.com/repos/floglass/yapsfm/git/commits{/sha}","comments_url":"https://api.github.com/repos/floglass/yapsfm/comments{/number}","issue_comment_url":"https://api.github.com/repos/floglass/yapsfm/issues/comments{/number}","contents_url":"https://api.github.com/repos/floglass/yapsfm/contents/{+path}","compare_url":"https://api.github.com/repos/floglass/yapsfm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/floglass/yapsfm/merges","archive_url":"https://api.github.com/repos/floglass/yapsfm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/floglass/yapsfm/downloads","issues_url":"https://api.github.com/repos/floglass/yapsfm/issues{/number}","pulls_url":"https://api.github.com/repos/floglass/yapsfm/pulls{/number}","milestones_url":"https://api.github.com/repos/floglass/yapsfm/milestones{/number}","notifications_url":"https://api.github.com/repos/floglass/yapsfm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/floglass/yapsfm/labels{/name}","releases_url":"https://api.github.com/repos/floglass/yapsfm/releases{/id}","created_at":"2015-04-02T23:08:27Z","updated_at":"2015-04-28T19:45:23Z","pushed_at":"2015-06-02T22:43:10Z","git_url":"git://github.com/floglass/yapsfm.git","ssh_url":"git@github.com:floglass/yapsfm.git","clone_url":"https://github.com/floglass/yapsfm.git","svn_url":"https://github.com/floglass/yapsfm","homepage":null,"size":254,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ijiraq:master","ref":"master","sha":"0fcc1f0b27391017dab2d73e9f4daee731a00bd9","user":{"login":"ijiraq","id":1132123,"avatar_url":"https://avatars.githubusercontent.com/u/1132123?v=3","gravatar_id":"","url":"https://api.github.com/users/ijiraq","html_url":"https://github.com/ijiraq","followers_url":"https://api.github.com/users/ijiraq/followers","following_url":"https://api.github.com/users/ijiraq/following{/other_user}","gists_url":"https://api.github.com/users/ijiraq/gists{/gist_id}","starred_url":"https://api.github.com/users/ijiraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijiraq/subscriptions","organizations_url":"https://api.github.com/users/ijiraq/orgs","repos_url":"https://api.github.com/users/ijiraq/repos","events_url":"https://api.github.com/users/ijiraq/events{/privacy}","received_events_url":"https://api.github.com/users/ijiraq/received_events","type":"User","site_admin":false},"repo":{"id":33335959,"name":"yapsfm","full_name":"ijiraq/yapsfm","owner":{"login":"ijiraq","id":1132123,"avatar_url":"https://avatars.githubusercontent.com/u/1132123?v=3","gravatar_id":"","url":"https://api.github.com/users/ijiraq","html_url":"https://github.com/ijiraq","followers_url":"https://api.github.com/users/ijiraq/followers","following_url":"https://api.github.com/users/ijiraq/following{/other_user}","gists_url":"https://api.github.com/users/ijiraq/gists{/gist_id}","starred_url":"https://api.github.com/users/ijiraq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijiraq/subscriptions","organizations_url":"https://api.github.com/users/ijiraq/orgs","repos_url":"https://api.github.com/users/ijiraq/repos","events_url":"https://api.github.com/users/ijiraq/events{/privacy}","received_events_url":"https://api.github.com/users/ijiraq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ijiraq/yapsfm","description":"Yet Another PSF Model","fork":false,"url":"https://api.github.com/repos/ijiraq/yapsfm","forks_url":"https://api.github.com/repos/ijiraq/yapsfm/forks","keys_url":"https://api.github.com/repos/ijiraq/yapsfm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ijiraq/yapsfm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ijiraq/yapsfm/teams","hooks_url":"https://api.github.com/repos/ijiraq/yapsfm/hooks","issue_events_url":"https://api.github.com/repos/ijiraq/yapsfm/issues/events{/number}","events_url":"https://api.github.com/repos/ijiraq/yapsfm/events","assignees_url":"https://api.github.com/repos/ijiraq/yapsfm/assignees{/user}","branches_url":"https://api.github.com/repos/ijiraq/yapsfm/branches{/branch}","tags_url":"https://api.github.com/repos/ijiraq/yapsfm/tags","blobs_url":"https://api.github.com/repos/ijiraq/yapsfm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ijiraq/yapsfm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ijiraq/yapsfm/git/refs{/sha}","trees_url":"https://api.github.com/repos/ijiraq/yapsfm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ijiraq/yapsfm/statuses/{sha}","languages_url":"https://api.github.com/repos/ijiraq/yapsfm/languages","stargazers_url":"https://api.github.com/repos/ijiraq/yapsfm/stargazers","contributors_url":"https://api.github.com/repos/ijiraq/yapsfm/contributors","subscribers_url":"https://api.github.com/repos/ijiraq/yapsfm/subscribers","subscription_url":"https://api.github.com/repos/ijiraq/yapsfm/subscription","commits_url":"https://api.github.com/repos/ijiraq/yapsfm/commits{/sha}","git_commits_url":"https://api.github.com/repos/ijiraq/yapsfm/git/commits{/sha}","comments_url":"https://api.github.com/repos/ijiraq/yapsfm/comments{/number}","issue_comment_url":"https://api.github.com/repos/ijiraq/yapsfm/issues/comments{/number}","contents_url":"https://api.github.com/repos/ijiraq/yapsfm/contents/{+path}","compare_url":"https://api.github.com/repos/ijiraq/yapsfm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ijiraq/yapsfm/merges","archive_url":"https://api.github.com/repos/ijiraq/yapsfm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ijiraq/yapsfm/downloads","issues_url":"https://api.github.com/repos/ijiraq/yapsfm/issues{/number}","pulls_url":"https://api.github.com/repos/ijiraq/yapsfm/pulls{/number}","milestones_url":"https://api.github.com/repos/ijiraq/yapsfm/milestones{/number}","notifications_url":"https://api.github.com/repos/ijiraq/yapsfm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ijiraq/yapsfm/labels{/name}","releases_url":"https://api.github.com/repos/ijiraq/yapsfm/releases{/id}","created_at":"2015-04-02T23:00:58Z","updated_at":"2015-04-28T19:13:04Z","pushed_at":"2015-06-02T22:46:27Z","git_url":"git://github.com/ijiraq/yapsfm.git","ssh_url":"git@github.com:ijiraq/yapsfm.git","clone_url":"https://github.com/ijiraq/yapsfm.git","svn_url":"https://github.com/ijiraq/yapsfm","homepage":null,"size":249,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6"},"html":{"href":"https://github.com/ijiraq/yapsfm/pull/6"},"issue":{"href":"https://api.github.com/repos/ijiraq/yapsfm/issues/6"},"comments":{"href":"https://api.github.com/repos/ijiraq/yapsfm/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/ijiraq/yapsfm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ijiraq/yapsfm/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/ijiraq/yapsfm/statuses/340bb204a7db68cc74566332bb7839973e22062f"}}}}