{"action":"created","comment":{"url":"https://api.github.com/repos/apache/kafka/pulls/comments/44787080","id":44787080,"diff_hunk":"@@ -46,6 +46,10 @@ import java.util.concurrent.{CountDownLatch, TimeUnit}\n \n import com.yammer.metrics.core.Gauge\n \n+\n+case class DelayedStore(messageSet: Map[TopicAndPartition, MessageSet],\n+                         callback: Map[TopicAndPartition, ProducerResponseStatus] => Unit)","path":"core/src/main/scala/kafka/coordinator/GroupMetadataManager.scala","position":6,"original_position":6,"commit_id":"ef8cb6f2ff4085970f8e5c61e38c0b12442412f7","original_commit_id":"ef8cb6f2ff4085970f8e5c61e38c0b12442412f7","user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"body":"I think we normally align the parameters in cases such as this.","created_at":"2015-11-13T14:29:27Z","updated_at":"2015-11-13T14:29:27Z","html_url":"https://github.com/apache/kafka/pull/519#discussion_r44787080","pull_request_url":"https://api.github.com/repos/apache/kafka/pulls/519","_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments/44787080"},"html":{"href":"https://github.com/apache/kafka/pull/519#discussion_r44787080"},"pull_request":{"href":"https://api.github.com/repos/apache/kafka/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/519","id":50582314,"html_url":"https://github.com/apache/kafka/pull/519","diff_url":"https://github.com/apache/kafka/pull/519.diff","patch_url":"https://github.com/apache/kafka/pull/519.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/519","number":519,"state":"open","locked":false,"title":"KAFKA-2821: fix deadlock in group metadata write callback","user":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars.githubusercontent.com/u/12502538?v=3","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-12T23:10:41Z","updated_at":"2015-11-13T14:29:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ddf431eff4ea4b75dcafc8963a69e2821c7023f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/519/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/519/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/519/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/ef8cb6f2ff4085970f8e5c61e38c0b12442412f7","head":{"label":"hachikuji:KAFKA-2821","ref":"KAFKA-2821","sha":"ef8cb6f2ff4085970f8e5c61e38c0b12442412f7","user":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars.githubusercontent.com/u/12502538?v=3","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"repo":{"id":35842084,"name":"kafka","full_name":"hachikuji/kafka","owner":{"login":"hachikuji","id":12502538,"avatar_url":"https://avatars.githubusercontent.com/u/12502538?v=3","gravatar_id":"","url":"https://api.github.com/users/hachikuji","html_url":"https://github.com/hachikuji","followers_url":"https://api.github.com/users/hachikuji/followers","following_url":"https://api.github.com/users/hachikuji/following{/other_user}","gists_url":"https://api.github.com/users/hachikuji/gists{/gist_id}","starred_url":"https://api.github.com/users/hachikuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hachikuji/subscriptions","organizations_url":"https://api.github.com/users/hachikuji/orgs","repos_url":"https://api.github.com/users/hachikuji/repos","events_url":"https://api.github.com/users/hachikuji/events{/privacy}","received_events_url":"https://api.github.com/users/hachikuji/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hachikuji/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/hachikuji/kafka","forks_url":"https://api.github.com/repos/hachikuji/kafka/forks","keys_url":"https://api.github.com/repos/hachikuji/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hachikuji/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hachikuji/kafka/teams","hooks_url":"https://api.github.com/repos/hachikuji/kafka/hooks","issue_events_url":"https://api.github.com/repos/hachikuji/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/hachikuji/kafka/events","assignees_url":"https://api.github.com/repos/hachikuji/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/hachikuji/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/hachikuji/kafka/tags","blobs_url":"https://api.github.com/repos/hachikuji/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hachikuji/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hachikuji/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/hachikuji/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hachikuji/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/hachikuji/kafka/languages","stargazers_url":"https://api.github.com/repos/hachikuji/kafka/stargazers","contributors_url":"https://api.github.com/repos/hachikuji/kafka/contributors","subscribers_url":"https://api.github.com/repos/hachikuji/kafka/subscribers","subscription_url":"https://api.github.com/repos/hachikuji/kafka/subscription","commits_url":"https://api.github.com/repos/hachikuji/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/hachikuji/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/hachikuji/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/hachikuji/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/hachikuji/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/hachikuji/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hachikuji/kafka/merges","archive_url":"https://api.github.com/repos/hachikuji/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hachikuji/kafka/downloads","issues_url":"https://api.github.com/repos/hachikuji/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/hachikuji/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/hachikuji/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/hachikuji/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hachikuji/kafka/labels{/name}","releases_url":"https://api.github.com/repos/hachikuji/kafka/releases{/id}","created_at":"2015-05-18T20:54:26Z","updated_at":"2015-05-18T20:54:28Z","pushed_at":"2015-11-13T06:18:57Z","git_url":"git://github.com/hachikuji/kafka.git","ssh_url":"git@github.com:hachikuji/kafka.git","clone_url":"https://github.com/hachikuji/kafka.git","svn_url":"https://github.com/hachikuji/kafka","homepage":null,"size":25348,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.8.2"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"2991c9865d87a715717dbc1bae431a4d39631d9e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","created_at":"2011-08-15T18:06:16Z","updated_at":"2015-11-13T12:09:20Z","pushed_at":"2015-11-13T11:49:36Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":43404,"stargazers_count":2204,"watchers_count":2204,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1299,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":104,"forks":1299,"open_issues":104,"watchers":2204,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/519"},"html":{"href":"https://github.com/apache/kafka/pull/519"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/519"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/ef8cb6f2ff4085970f8e5c61e38c0b12442412f7"}}}}