{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/48033991","id":48033991,"diff_hunk":"@@ -35,32 +34,36 @@ namespace XBMCAddon\n \n     class RenderCapture : public AddonClass\n     {\n-      CRenderCapture* m_capture;\n+      unsigned int m_captureId;","path":"xbmc/interfaces/legacy/RenderCapture.h","position":13,"original_position":13,"commit_id":"c22cb4be85ae78add14c80705260930745c2767f","original_commit_id":"c22cb4be85ae78add14c80705260930745c2767f","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"@Memphiz if all goes right an addon should not care. It is set in the capture(), line 112. what error message do you get?","created_at":"2015-12-18T15:14:58Z","updated_at":"2015-12-18T15:14:58Z","html_url":"https://github.com/xbmc/xbmc/pull/8613#discussion_r48033991","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8613","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/48033991"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8613#discussion_r48033991"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8613"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8613","id":54007651,"html_url":"https://github.com/xbmc/xbmc/pull/8613","diff_url":"https://github.com/xbmc/xbmc/pull/8613.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8613.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8613","number":8613,"state":"open","locked":false,"title":"rework RenderCapture","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"body":"@Memphiz @MartijnKaijser \r\n\r\nI don't have a setup to test this. Means there might be some things left to fix. The old code did expose an unprotected buffer to the interface. That leaves me speechless ... ","created_at":"2015-12-17T17:39:57Z","updated_at":"2015-12-18T15:14:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ecfaf55cf29ac55390107fa64a4078da0e10e64","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8613/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/8613/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8613/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/c22cb4be85ae78add14c80705260930745c2767f","head":{"label":"FernetMenta:capture","ref":"capture","sha":"c22cb4be85ae78add14c80705260930745c2767f","user":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"repo":{"id":1278128,"name":"xbmc","full_name":"FernetMenta/xbmc","owner":{"login":"FernetMenta","id":576009,"avatar_url":"https://avatars.githubusercontent.com/u/576009?v=3","gravatar_id":"","url":"https://api.github.com/users/FernetMenta","html_url":"https://github.com/FernetMenta","followers_url":"https://api.github.com/users/FernetMenta/followers","following_url":"https://api.github.com/users/FernetMenta/following{/other_user}","gists_url":"https://api.github.com/users/FernetMenta/gists{/gist_id}","starred_url":"https://api.github.com/users/FernetMenta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FernetMenta/subscriptions","organizations_url":"https://api.github.com/users/FernetMenta/orgs","repos_url":"https://api.github.com/users/FernetMenta/repos","events_url":"https://api.github.com/users/FernetMenta/events{/privacy}","received_events_url":"https://api.github.com/users/FernetMenta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FernetMenta/xbmc","description":"Fork of  XBMC Main PVR Development Repository.","fork":true,"url":"https://api.github.com/repos/FernetMenta/xbmc","forks_url":"https://api.github.com/repos/FernetMenta/xbmc/forks","keys_url":"https://api.github.com/repos/FernetMenta/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FernetMenta/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FernetMenta/xbmc/teams","hooks_url":"https://api.github.com/repos/FernetMenta/xbmc/hooks","issue_events_url":"https://api.github.com/repos/FernetMenta/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/FernetMenta/xbmc/events","assignees_url":"https://api.github.com/repos/FernetMenta/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/FernetMenta/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/FernetMenta/xbmc/tags","blobs_url":"https://api.github.com/repos/FernetMenta/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FernetMenta/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FernetMenta/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/FernetMenta/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FernetMenta/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/FernetMenta/xbmc/languages","stargazers_url":"https://api.github.com/repos/FernetMenta/xbmc/stargazers","contributors_url":"https://api.github.com/repos/FernetMenta/xbmc/contributors","subscribers_url":"https://api.github.com/repos/FernetMenta/xbmc/subscribers","subscription_url":"https://api.github.com/repos/FernetMenta/xbmc/subscription","commits_url":"https://api.github.com/repos/FernetMenta/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/FernetMenta/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/FernetMenta/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/FernetMenta/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/FernetMenta/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/FernetMenta/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FernetMenta/xbmc/merges","archive_url":"https://api.github.com/repos/FernetMenta/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FernetMenta/xbmc/downloads","issues_url":"https://api.github.com/repos/FernetMenta/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/FernetMenta/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/FernetMenta/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/FernetMenta/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FernetMenta/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/FernetMenta/xbmc/releases{/id}","created_at":"2011-01-21T11:28:28Z","updated_at":"2015-12-06T20:39:41Z","pushed_at":"2015-12-18T14:39:17Z","git_url":"git://github.com/FernetMenta/xbmc.git","ssh_url":"git@github.com:FernetMenta/xbmc.git","clone_url":"https://github.com/FernetMenta/xbmc.git","svn_url":"https://github.com/FernetMenta/xbmc","homepage":"http://xbmc.org","size":562396,"stargazers_count":59,"watchers_count":59,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":14,"forks":20,"open_issues":14,"watchers":59,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"b8e2d5957ab0dfcd6565e98d4ab191c066c9ac4b","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-12-18T13:29:51Z","pushed_at":"2015-12-18T14:39:24Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1721850,"stargazers_count":4341,"watchers_count":4341,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3192,"mirror_url":null,"open_issues_count":228,"forks":3192,"open_issues":228,"watchers":4341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8613"},"html":{"href":"https://github.com/xbmc/xbmc/pull/8613"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8613"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/8613/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8613/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/8613/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/c22cb4be85ae78add14c80705260930745c2767f"}}}}