{"action":"created","comment":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/42631276","id":42631276,"diff_hunk":"@@ -0,0 +1,444 @@\n+# Licensed under a 3-clause BSD style license - see LICENSE.rst\n+\"\"\"Provide a Feldman Cousins algorithm.\"\"\"\n+from __future__ import (absolute_import, division, print_function,\n+                        unicode_literals)\n+import numpy as np\n+from astropy.extern.six.moves import range\n+from astropy.extern.six import iteritems\n+\n+import logging\n+log = logging.getLogger(__name__)\n+\n+__all__ = ['fc_find_acceptance_region_gauss',","path":"gammapy/stats/feldman_cousins.py","position":12,"original_position":12,"commit_id":"f8583b65d818ead85812ecc01e42d7536815f0a1","original_commit_id":"606c5b89723dbe7f0525f883c340d5effc9f10b6","user":{"login":"dlennarz","id":13599741,"avatar_url":"https://avatars.githubusercontent.com/u/13599741?v=3","gravatar_id":"","url":"https://api.github.com/users/dlennarz","html_url":"https://github.com/dlennarz","followers_url":"https://api.github.com/users/dlennarz/followers","following_url":"https://api.github.com/users/dlennarz/following{/other_user}","gists_url":"https://api.github.com/users/dlennarz/gists{/gist_id}","starred_url":"https://api.github.com/users/dlennarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlennarz/subscriptions","organizations_url":"https://api.github.com/users/dlennarz/orgs","repos_url":"https://api.github.com/users/dlennarz/repos","events_url":"https://api.github.com/users/dlennarz/events{/privacy}","received_events_url":"https://api.github.com/users/dlennarz/received_events","type":"User","site_admin":false},"body":"I replaced all the \"acceptance_region\" with \"acceptance_interval\" (which is also what is used in the FC paper.\r\n\r\nI already explained this in an earlier comment: fc_find_acceptance_interval_poisson does not give you an confidence interval, but an acceptance_interval. So I think the function names are fine.","created_at":"2015-10-21T14:35:51Z","updated_at":"2015-10-21T14:35:51Z","html_url":"https://github.com/gammapy/gammapy/pull/367#discussion_r42631276","pull_request_url":"https://api.github.com/repos/gammapy/gammapy/pulls/367","_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments/42631276"},"html":{"href":"https://github.com/gammapy/gammapy/pull/367#discussion_r42631276"},"pull_request":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/367"}}},"pull_request":{"url":"https://api.github.com/repos/gammapy/gammapy/pulls/367","id":47375412,"html_url":"https://github.com/gammapy/gammapy/pull/367","diff_url":"https://github.com/gammapy/gammapy/pull/367.diff","patch_url":"https://github.com/gammapy/gammapy/pull/367.patch","issue_url":"https://api.github.com/repos/gammapy/gammapy/issues/367","number":367,"state":"open","locked":false,"title":"Add Feldman Cousins algorithm","user":{"login":"dlennarz","id":13599741,"avatar_url":"https://avatars.githubusercontent.com/u/13599741?v=3","gravatar_id":"","url":"https://api.github.com/users/dlennarz","html_url":"https://github.com/dlennarz","followers_url":"https://api.github.com/users/dlennarz/followers","following_url":"https://api.github.com/users/dlennarz/following{/other_user}","gists_url":"https://api.github.com/users/dlennarz/gists{/gist_id}","starred_url":"https://api.github.com/users/dlennarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlennarz/subscriptions","organizations_url":"https://api.github.com/users/dlennarz/orgs","repos_url":"https://api.github.com/users/dlennarz/repos","events_url":"https://api.github.com/users/dlennarz/events{/privacy}","received_events_url":"https://api.github.com/users/dlennarz/received_events","type":"User","site_admin":false},"body":"Adding Feldman Cousins to gammapy.\r\n\r\nStatus: Done working on it, unless there are new comments / requests.\r\n\r\nThere was a previous pull request (#311), but I messed up that branch when trying to merge changes from the master. That's why I deleted that branch and recreated it.","created_at":"2015-10-11T21:04:27Z","updated_at":"2015-10-21T14:35:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"544fcd91402d867c35c1ac70dcc40e135c84b82e","assignee":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/gammapy/gammapy/milestones/5","html_url":"https://github.com/gammapy/gammapy/milestones/0.4","labels_url":"https://api.github.com/repos/gammapy/gammapy/milestones/5/labels","id":1058090,"number":5,"title":"0.4","description":"","creator":{"login":"cdeil","id":852409,"avatar_url":"https://avatars.githubusercontent.com/u/852409?v=3","gravatar_id":"","url":"https://api.github.com/users/cdeil","html_url":"https://github.com/cdeil","followers_url":"https://api.github.com/users/cdeil/followers","following_url":"https://api.github.com/users/cdeil/following{/other_user}","gists_url":"https://api.github.com/users/cdeil/gists{/gist_id}","starred_url":"https://api.github.com/users/cdeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdeil/subscriptions","organizations_url":"https://api.github.com/users/cdeil/orgs","repos_url":"https://api.github.com/users/cdeil/repos","events_url":"https://api.github.com/users/cdeil/events{/privacy}","received_events_url":"https://api.github.com/users/cdeil/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":26,"state":"open","created_at":"2015-04-08T11:51:53Z","updated_at":"2015-10-21T11:50:55Z","due_on":"2015-10-13T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/gammapy/gammapy/pulls/367/commits","review_comments_url":"https://api.github.com/repos/gammapy/gammapy/pulls/367/comments","review_comment_url":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gammapy/gammapy/issues/367/comments","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/f8583b65d818ead85812ecc01e42d7536815f0a1","head":{"label":"dlennarz:fc","ref":"fc","sha":"f8583b65d818ead85812ecc01e42d7536815f0a1","user":{"login":"dlennarz","id":13599741,"avatar_url":"https://avatars.githubusercontent.com/u/13599741?v=3","gravatar_id":"","url":"https://api.github.com/users/dlennarz","html_url":"https://github.com/dlennarz","followers_url":"https://api.github.com/users/dlennarz/followers","following_url":"https://api.github.com/users/dlennarz/following{/other_user}","gists_url":"https://api.github.com/users/dlennarz/gists{/gist_id}","starred_url":"https://api.github.com/users/dlennarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlennarz/subscriptions","organizations_url":"https://api.github.com/users/dlennarz/orgs","repos_url":"https://api.github.com/users/dlennarz/repos","events_url":"https://api.github.com/users/dlennarz/events{/privacy}","received_events_url":"https://api.github.com/users/dlennarz/received_events","type":"User","site_admin":false},"repo":{"id":40043940,"name":"gammapy","full_name":"dlennarz/gammapy","owner":{"login":"dlennarz","id":13599741,"avatar_url":"https://avatars.githubusercontent.com/u/13599741?v=3","gravatar_id":"","url":"https://api.github.com/users/dlennarz","html_url":"https://github.com/dlennarz","followers_url":"https://api.github.com/users/dlennarz/followers","following_url":"https://api.github.com/users/dlennarz/following{/other_user}","gists_url":"https://api.github.com/users/dlennarz/gists{/gist_id}","starred_url":"https://api.github.com/users/dlennarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlennarz/subscriptions","organizations_url":"https://api.github.com/users/dlennarz/orgs","repos_url":"https://api.github.com/users/dlennarz/repos","events_url":"https://api.github.com/users/dlennarz/events{/privacy}","received_events_url":"https://api.github.com/users/dlennarz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dlennarz/gammapy","description":"A Python package for gamma-ray astronomy","fork":true,"url":"https://api.github.com/repos/dlennarz/gammapy","forks_url":"https://api.github.com/repos/dlennarz/gammapy/forks","keys_url":"https://api.github.com/repos/dlennarz/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlennarz/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlennarz/gammapy/teams","hooks_url":"https://api.github.com/repos/dlennarz/gammapy/hooks","issue_events_url":"https://api.github.com/repos/dlennarz/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/dlennarz/gammapy/events","assignees_url":"https://api.github.com/repos/dlennarz/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/dlennarz/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/dlennarz/gammapy/tags","blobs_url":"https://api.github.com/repos/dlennarz/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlennarz/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlennarz/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlennarz/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlennarz/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/dlennarz/gammapy/languages","stargazers_url":"https://api.github.com/repos/dlennarz/gammapy/stargazers","contributors_url":"https://api.github.com/repos/dlennarz/gammapy/contributors","subscribers_url":"https://api.github.com/repos/dlennarz/gammapy/subscribers","subscription_url":"https://api.github.com/repos/dlennarz/gammapy/subscription","commits_url":"https://api.github.com/repos/dlennarz/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlennarz/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlennarz/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlennarz/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlennarz/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/dlennarz/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlennarz/gammapy/merges","archive_url":"https://api.github.com/repos/dlennarz/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlennarz/gammapy/downloads","issues_url":"https://api.github.com/repos/dlennarz/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/dlennarz/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/dlennarz/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/dlennarz/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlennarz/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/dlennarz/gammapy/releases{/id}","created_at":"2015-08-01T10:59:02Z","updated_at":"2015-08-01T10:59:04Z","pushed_at":"2015-10-21T13:48:18Z","git_url":"git://github.com/dlennarz/gammapy.git","ssh_url":"git@github.com:dlennarz/gammapy.git","clone_url":"https://github.com/dlennarz/gammapy.git","svn_url":"https://github.com/dlennarz/gammapy","homepage":"https://gammapy.readthedocs.org/","size":4164,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gammapy:master","ref":"master","sha":"8ced36d7882e907799cb75524f6cf641602a22f6","user":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"repo":{"id":10073640,"name":"gammapy","full_name":"gammapy/gammapy","owner":{"login":"gammapy","id":852764,"avatar_url":"https://avatars.githubusercontent.com/u/852764?v=3","gravatar_id":"","url":"https://api.github.com/users/gammapy","html_url":"https://github.com/gammapy","followers_url":"https://api.github.com/users/gammapy/followers","following_url":"https://api.github.com/users/gammapy/following{/other_user}","gists_url":"https://api.github.com/users/gammapy/gists{/gist_id}","starred_url":"https://api.github.com/users/gammapy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gammapy/subscriptions","organizations_url":"https://api.github.com/users/gammapy/orgs","repos_url":"https://api.github.com/users/gammapy/repos","events_url":"https://api.github.com/users/gammapy/events{/privacy}","received_events_url":"https://api.github.com/users/gammapy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gammapy/gammapy","description":"A Python package for gamma-ray astronomy","fork":false,"url":"https://api.github.com/repos/gammapy/gammapy","forks_url":"https://api.github.com/repos/gammapy/gammapy/forks","keys_url":"https://api.github.com/repos/gammapy/gammapy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gammapy/gammapy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gammapy/gammapy/teams","hooks_url":"https://api.github.com/repos/gammapy/gammapy/hooks","issue_events_url":"https://api.github.com/repos/gammapy/gammapy/issues/events{/number}","events_url":"https://api.github.com/repos/gammapy/gammapy/events","assignees_url":"https://api.github.com/repos/gammapy/gammapy/assignees{/user}","branches_url":"https://api.github.com/repos/gammapy/gammapy/branches{/branch}","tags_url":"https://api.github.com/repos/gammapy/gammapy/tags","blobs_url":"https://api.github.com/repos/gammapy/gammapy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gammapy/gammapy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gammapy/gammapy/git/refs{/sha}","trees_url":"https://api.github.com/repos/gammapy/gammapy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gammapy/gammapy/statuses/{sha}","languages_url":"https://api.github.com/repos/gammapy/gammapy/languages","stargazers_url":"https://api.github.com/repos/gammapy/gammapy/stargazers","contributors_url":"https://api.github.com/repos/gammapy/gammapy/contributors","subscribers_url":"https://api.github.com/repos/gammapy/gammapy/subscribers","subscription_url":"https://api.github.com/repos/gammapy/gammapy/subscription","commits_url":"https://api.github.com/repos/gammapy/gammapy/commits{/sha}","git_commits_url":"https://api.github.com/repos/gammapy/gammapy/git/commits{/sha}","comments_url":"https://api.github.com/repos/gammapy/gammapy/comments{/number}","issue_comment_url":"https://api.github.com/repos/gammapy/gammapy/issues/comments{/number}","contents_url":"https://api.github.com/repos/gammapy/gammapy/contents/{+path}","compare_url":"https://api.github.com/repos/gammapy/gammapy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gammapy/gammapy/merges","archive_url":"https://api.github.com/repos/gammapy/gammapy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gammapy/gammapy/downloads","issues_url":"https://api.github.com/repos/gammapy/gammapy/issues{/number}","pulls_url":"https://api.github.com/repos/gammapy/gammapy/pulls{/number}","milestones_url":"https://api.github.com/repos/gammapy/gammapy/milestones{/number}","notifications_url":"https://api.github.com/repos/gammapy/gammapy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gammapy/gammapy/labels{/name}","releases_url":"https://api.github.com/repos/gammapy/gammapy/releases{/id}","created_at":"2013-05-15T07:50:40Z","updated_at":"2015-10-07T23:38:31Z","pushed_at":"2015-10-21T14:03:40Z","git_url":"git://github.com/gammapy/gammapy.git","ssh_url":"git@github.com:gammapy/gammapy.git","clone_url":"https://github.com/gammapy/gammapy.git","svn_url":"https://github.com/gammapy/gammapy","homepage":"https://gammapy.readthedocs.org/","size":7171,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":115,"forks":22,"open_issues":115,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/367"},"html":{"href":"https://github.com/gammapy/gammapy/pull/367"},"issue":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/367"},"comments":{"href":"https://api.github.com/repos/gammapy/gammapy/issues/367/comments"},"review_comments":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/367/comments"},"review_comment":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gammapy/gammapy/pulls/367/commits"},"statuses":{"href":"https://api.github.com/repos/gammapy/gammapy/statuses/f8583b65d818ead85812ecc01e42d7536815f0a1"}}}}