{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394/events","html_url":"https://github.com/joomla/joomla-cms/pull/7394","id":94090186,"number":7394,"title":"Multilanguage: making Protostar logo link multilang aware","user":{"login":"infograf768","id":869724,"avatar_url":"https://avatars.githubusercontent.com/u/869724?v=3","gravatar_id":"","url":"https://api.github.com/users/infograf768","html_url":"https://github.com/infograf768","followers_url":"https://api.github.com/users/infograf768/followers","following_url":"https://api.github.com/users/infograf768/following{/other_user}","gists_url":"https://api.github.com/users/infograf768/gists{/gist_id}","starred_url":"https://api.github.com/users/infograf768/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infograf768/subscriptions","organizations_url":"https://api.github.com/users/infograf768/orgs","repos_url":"https://api.github.com/users/infograf768/repos","events_url":"https://api.github.com/users/infograf768/events{/privacy}","received_events_url":"https://api.github.com/users/infograf768/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"},{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/RTC","name":"RTC","color":"009800"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/joomla/joomla-cms/milestones/10","html_url":"https://github.com/joomla/joomla-cms/milestones/Joomla!%203.4.4","labels_url":"https://api.github.com/repos/joomla/joomla-cms/milestones/10/labels","id":1190334,"number":10,"title":"Joomla! 3.4.4","description":"","creator":{"login":"zero-24","id":2596554,"avatar_url":"https://avatars.githubusercontent.com/u/2596554?v=3","gravatar_id":"","url":"https://api.github.com/users/zero-24","html_url":"https://github.com/zero-24","followers_url":"https://api.github.com/users/zero-24/followers","following_url":"https://api.github.com/users/zero-24/following{/other_user}","gists_url":"https://api.github.com/users/zero-24/gists{/gist_id}","starred_url":"https://api.github.com/users/zero-24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zero-24/subscriptions","organizations_url":"https://api.github.com/users/zero-24/orgs","repos_url":"https://api.github.com/users/zero-24/repos","events_url":"https://api.github.com/users/zero-24/events{/privacy}","received_events_url":"https://api.github.com/users/zero-24/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":64,"state":"open","created_at":"2015-07-02T09:44:31Z","updated_at":"2015-07-10T19:58:32Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2015-07-09T16:13:05Z","updated_at":"2015-07-11T10:59:18Z","closed_at":"2015-07-10T10:20:18Z","pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/7394","html_url":"https://github.com/joomla/joomla-cms/pull/7394","diff_url":"https://github.com/joomla/joomla-cms/pull/7394.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/7394.patch"},"body":"In Protostar, the link used for the logo header is always a direct link to the home page.\r\nCode is \r\n```\r\n<a class=\"brand pull-left\" href=\"<?php echo $this->baseurl; ?>/\">\r\n```\r\nThis means that we get an url of the type `http://mysite.com/`\r\n\r\nIn a multilanguage site it means the url will display the site default language or browser default language home page (depending on \"Language Selection for new visitors\") when sef is off \r\n\r\nThis patch, depending if sef is on or off, creates the good url.\r\n\r\n1. Test sef on, \"Remove URL Language code\" set to Yes and with \"Use URL Rewriting\" set to Yes or No\r\n2. Test sef on, \"Remove URL Language code\" set to No and with \"Use URL Rewriting\" set to Yes or No \r\n3. Test with sef off \r\n\r\nIn each case, clicking on the logo will display the site home page in the language in use."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/120603847","html_url":"https://github.com/joomla/joomla-cms/pull/7394#issuecomment-120603847","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/7394","id":120603847,"user":{"login":"smz","id":552475,"avatar_url":"https://avatars.githubusercontent.com/u/552475?v=3","gravatar_id":"","url":"https://api.github.com/users/smz","html_url":"https://github.com/smz","followers_url":"https://api.github.com/users/smz/followers","following_url":"https://api.github.com/users/smz/following{/other_user}","gists_url":"https://api.github.com/users/smz/gists{/gist_id}","starred_url":"https://api.github.com/users/smz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smz/subscriptions","organizations_url":"https://api.github.com/users/smz/orgs","repos_url":"https://api.github.com/users/smz/repos","events_url":"https://api.github.com/users/smz/events{/privacy}","received_events_url":"https://api.github.com/users/smz/received_events","type":"User","site_admin":false},"created_at":"2015-07-11T10:59:18Z","updated_at":"2015-07-11T10:59:18Z","body":"@Hackwar \r\n> ... If that is what is currently happening, the routing code is broken.\r\n\r\nFor crying out loud, Hannes, **try it**...\r\n\r\n@infograf768 \r\n> But I remind you that this is exactly the same behavior when sef is off for a monolanguage site...\r\n\r\nExactly: mono/multi-lingual doesn't matter here...\r\n\r\nGuys, with this patch having been merged, our (non-SEF) sites will not have a back-link to home page (`/`), not even in the frigging logo... I'm afraid Google will have a bit of hard time figuring out which is the home page..."}}