{"action":"created","comment":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/23696059","id":23696059,"diff_hunk":"@@ -100,23 +100,40 @@ class range_segment_iterator\n             Reference\n         >\n {\n+private:\n+    static bool has_less_than_two_elements(Range const& r)\n+    {\n+        iterator_type first = range_iterator_begin<Range>::apply(r);\n+        iterator_type last = range_iterator_end<Range>::apply(r);\n+\n+        return first == last || ++first == last;\n+    }\n+\n public:\n     typedef typename range_iterator_type<Range>::type iterator_type;\n \n     // default constructor\n     range_segment_iterator()\n-        : m_it()\n+        : m_it(), m_has_less_than_two_elements()","path":"include/boost/geometry/iterators/detail/segment_iterator/range_segment_iterator.hpp","position":19,"original_position":19,"commit_id":"3763829be3071f676abb77e82b2e3a5b43ee4657","original_commit_id":"3c443862d4d994410f5c53635cfcc342b4f11eeb","user":{"login":"awulkiew","id":1226951,"avatar_url":"https://avatars.githubusercontent.com/u/1226951?v=3","gravatar_id":"","url":"https://api.github.com/users/awulkiew","html_url":"https://github.com/awulkiew","followers_url":"https://api.github.com/users/awulkiew/followers","following_url":"https://api.github.com/users/awulkiew/following{/other_user}","gists_url":"https://api.github.com/users/awulkiew/gists{/gist_id}","starred_url":"https://api.github.com/users/awulkiew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awulkiew/subscriptions","organizations_url":"https://api.github.com/users/awulkiew/orgs","repos_url":"https://api.github.com/users/awulkiew/repos","events_url":"https://api.github.com/users/awulkiew/events{/privacy}","received_events_url":"https://api.github.com/users/awulkiew/received_events","type":"User","site_admin":false},"body":"Why not explicitly initialize it with false?\r\nConsider the initialization of a pointer with NULL.\r\nI see it in various places in BG code, so it's a more general problem...","created_at":"2015-01-28T15:49:56Z","updated_at":"2015-01-28T15:49:56Z","html_url":"https://github.com/boostorg/geometry/pull/197#discussion_r23696059","pull_request_url":"https://api.github.com/repos/boostorg/geometry/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/23696059"},"html":{"href":"https://github.com/boostorg/geometry/pull/197#discussion_r23696059"},"pull_request":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/boostorg/geometry/pulls/197","id":27856491,"html_url":"https://github.com/boostorg/geometry/pull/197","diff_url":"https://github.com/boostorg/geometry/pull/197.diff","patch_url":"https://github.com/boostorg/geometry/pull/197.patch","issue_url":"https://api.github.com/repos/boostorg/geometry/issues/197","number":197,"state":"open","locked":false,"title":"Feature/support for one point geometries","user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"body":"In this PR I modify the `range_segment_iterator` class to support ranges with less than two elements.\r\nWith this modification of the `range_segment_iterator` class, the `segment_iterator` can support (invalid) geometries that contain ranges with less than two points.\r\n\r\nA consequence of this PR is that `bg::distance` can now compute the distance for (invalid) geometries that contain ranges of less than two points (e.g., one-point linestrings, non-empty closed rings with less than four points, non-empty open rings with less than three points, non-empty multilinestrings that contain one-point linestrings (or even empty linestrings), one-point polygons, etc.)\r\n\r\nThe unit tests in this PR rely on the fix proposed in PR #196, so PR #196 should be merged first.","created_at":"2015-01-22T16:37:17Z","updated_at":"2015-01-28T15:49:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"134104a906c7bcc49988df3c7381c8a85f8720a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/boostorg/geometry/pulls/197/commits","review_comments_url":"https://api.github.com/repos/boostorg/geometry/pulls/197/comments","review_comment_url":"https://api.github.com/repos/boostorg/geometry/pulls/comments/{number}","comments_url":"https://api.github.com/repos/boostorg/geometry/issues/197/comments","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/3763829be3071f676abb77e82b2e3a5b43ee4657","head":{"label":"mkaravel:feature/support_for_one_point_geometries","ref":"feature/support_for_one_point_geometries","sha":"3763829be3071f676abb77e82b2e3a5b43ee4657","user":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"repo":{"id":15894753,"name":"geometry","full_name":"mkaravel/geometry","owner":{"login":"mkaravel","id":6397014,"avatar_url":"https://avatars.githubusercontent.com/u/6397014?v=3","gravatar_id":"","url":"https://api.github.com/users/mkaravel","html_url":"https://github.com/mkaravel","followers_url":"https://api.github.com/users/mkaravel/followers","following_url":"https://api.github.com/users/mkaravel/following{/other_user}","gists_url":"https://api.github.com/users/mkaravel/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaravel/subscriptions","organizations_url":"https://api.github.com/users/mkaravel/orgs","repos_url":"https://api.github.com/users/mkaravel/repos","events_url":"https://api.github.com/users/mkaravel/events{/privacy}","received_events_url":"https://api.github.com/users/mkaravel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkaravel/geometry","description":"Boost.org geometry module","fork":true,"url":"https://api.github.com/repos/mkaravel/geometry","forks_url":"https://api.github.com/repos/mkaravel/geometry/forks","keys_url":"https://api.github.com/repos/mkaravel/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkaravel/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkaravel/geometry/teams","hooks_url":"https://api.github.com/repos/mkaravel/geometry/hooks","issue_events_url":"https://api.github.com/repos/mkaravel/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/mkaravel/geometry/events","assignees_url":"https://api.github.com/repos/mkaravel/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/mkaravel/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/mkaravel/geometry/tags","blobs_url":"https://api.github.com/repos/mkaravel/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkaravel/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkaravel/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkaravel/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkaravel/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/mkaravel/geometry/languages","stargazers_url":"https://api.github.com/repos/mkaravel/geometry/stargazers","contributors_url":"https://api.github.com/repos/mkaravel/geometry/contributors","subscribers_url":"https://api.github.com/repos/mkaravel/geometry/subscribers","subscription_url":"https://api.github.com/repos/mkaravel/geometry/subscription","commits_url":"https://api.github.com/repos/mkaravel/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkaravel/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkaravel/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkaravel/geometry/issues/comments/{number}","contents_url":"https://api.github.com/repos/mkaravel/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/mkaravel/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkaravel/geometry/merges","archive_url":"https://api.github.com/repos/mkaravel/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkaravel/geometry/downloads","issues_url":"https://api.github.com/repos/mkaravel/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/mkaravel/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/mkaravel/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/mkaravel/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkaravel/geometry/labels{/name}","releases_url":"https://api.github.com/repos/mkaravel/geometry/releases{/id}","created_at":"2014-01-14T07:16:18Z","updated_at":"2014-10-22T07:10:01Z","pushed_at":"2015-01-28T15:39:54Z","git_url":"git://github.com/mkaravel/geometry.git","ssh_url":"git@github.com:mkaravel/geometry.git","clone_url":"https://github.com/mkaravel/geometry.git","svn_url":"https://github.com/mkaravel/geometry","homepage":"http://boost.org/libs/geometry","size":35026,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"boostorg:develop","ref":"develop","sha":"bc45a199090657b0fdab866daa1aacae6546598c","user":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"repo":{"id":7590021,"name":"geometry","full_name":"boostorg/geometry","owner":{"login":"boostorg","id":3170529,"avatar_url":"https://avatars.githubusercontent.com/u/3170529?v=3","gravatar_id":"","url":"https://api.github.com/users/boostorg","html_url":"https://github.com/boostorg","followers_url":"https://api.github.com/users/boostorg/followers","following_url":"https://api.github.com/users/boostorg/following{/other_user}","gists_url":"https://api.github.com/users/boostorg/gists{/gist_id}","starred_url":"https://api.github.com/users/boostorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boostorg/subscriptions","organizations_url":"https://api.github.com/users/boostorg/orgs","repos_url":"https://api.github.com/users/boostorg/repos","events_url":"https://api.github.com/users/boostorg/events{/privacy}","received_events_url":"https://api.github.com/users/boostorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/boostorg/geometry","description":"Boost.org geometry module","fork":false,"url":"https://api.github.com/repos/boostorg/geometry","forks_url":"https://api.github.com/repos/boostorg/geometry/forks","keys_url":"https://api.github.com/repos/boostorg/geometry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boostorg/geometry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boostorg/geometry/teams","hooks_url":"https://api.github.com/repos/boostorg/geometry/hooks","issue_events_url":"https://api.github.com/repos/boostorg/geometry/issues/events{/number}","events_url":"https://api.github.com/repos/boostorg/geometry/events","assignees_url":"https://api.github.com/repos/boostorg/geometry/assignees{/user}","branches_url":"https://api.github.com/repos/boostorg/geometry/branches{/branch}","tags_url":"https://api.github.com/repos/boostorg/geometry/tags","blobs_url":"https://api.github.com/repos/boostorg/geometry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boostorg/geometry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boostorg/geometry/git/refs{/sha}","trees_url":"https://api.github.com/repos/boostorg/geometry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boostorg/geometry/statuses/{sha}","languages_url":"https://api.github.com/repos/boostorg/geometry/languages","stargazers_url":"https://api.github.com/repos/boostorg/geometry/stargazers","contributors_url":"https://api.github.com/repos/boostorg/geometry/contributors","subscribers_url":"https://api.github.com/repos/boostorg/geometry/subscribers","subscription_url":"https://api.github.com/repos/boostorg/geometry/subscription","commits_url":"https://api.github.com/repos/boostorg/geometry/commits{/sha}","git_commits_url":"https://api.github.com/repos/boostorg/geometry/git/commits{/sha}","comments_url":"https://api.github.com/repos/boostorg/geometry/comments{/number}","issue_comment_url":"https://api.github.com/repos/boostorg/geometry/issues/comments/{number}","contents_url":"https://api.github.com/repos/boostorg/geometry/contents/{+path}","compare_url":"https://api.github.com/repos/boostorg/geometry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boostorg/geometry/merges","archive_url":"https://api.github.com/repos/boostorg/geometry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boostorg/geometry/downloads","issues_url":"https://api.github.com/repos/boostorg/geometry/issues{/number}","pulls_url":"https://api.github.com/repos/boostorg/geometry/pulls{/number}","milestones_url":"https://api.github.com/repos/boostorg/geometry/milestones{/number}","notifications_url":"https://api.github.com/repos/boostorg/geometry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boostorg/geometry/labels{/name}","releases_url":"https://api.github.com/repos/boostorg/geometry/releases{/id}","created_at":"2013-01-13T15:59:29Z","updated_at":"2014-12-22T17:37:49Z","pushed_at":"2015-01-28T12:38:26Z","git_url":"git://github.com/boostorg/geometry.git","ssh_url":"git@github.com:boostorg/geometry.git","clone_url":"https://github.com/boostorg/geometry.git","svn_url":"https://github.com/boostorg/geometry","homepage":"http://boost.org/libs/geometry","size":45374,"stargazers_count":40,"watchers_count":40,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":5,"forks":25,"open_issues":5,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/197"},"html":{"href":"https://github.com/boostorg/geometry/pull/197"},"issue":{"href":"https://api.github.com/repos/boostorg/geometry/issues/197"},"comments":{"href":"https://api.github.com/repos/boostorg/geometry/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/boostorg/geometry/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/boostorg/geometry/statuses/3763829be3071f676abb77e82b2e3a5b43ee4657"}}}}