{"action":"created","comment":{"url":"https://api.github.com/repos/n3-charts/line-chart/pulls/comments/41146398","id":41146398,"diff_hunk":"@@ -184,6 +182,99 @@ describe('n3Charts.Utils.Options', () => {\n \n       expect(testing).to.equal(expected);\n     });\n+\n+    it('should assume the axis is linear by default', () => {\n+      var testing = axes[AxisOptions.SIDE.Y].type;\n+      var expected = 'linear';\n+\n+      expect(testing).to.equal(expected);\n+    });\n+  });\n+\n+  describe('sanitizeAxes - numeric extrema', () => {","path":"test/spec/utils/Options.spec.ts","position":24,"original_position":24,"commit_id":"4e4e0558deb053ff81efcb774dd080177bd219ce","original_commit_id":"4e4e0558deb053ff81efcb774dd080177bd219ce","user":{"login":"chaosmail","id":2969388,"avatar_url":"https://avatars.githubusercontent.com/u/2969388?v=3","gravatar_id":"","url":"https://api.github.com/users/chaosmail","html_url":"https://github.com/chaosmail","followers_url":"https://api.github.com/users/chaosmail/followers","following_url":"https://api.github.com/users/chaosmail/following{/other_user}","gists_url":"https://api.github.com/users/chaosmail/gists{/gist_id}","starred_url":"https://api.github.com/users/chaosmail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chaosmail/subscriptions","organizations_url":"https://api.github.com/users/chaosmail/orgs","repos_url":"https://api.github.com/users/chaosmail/repos","events_url":"https://api.github.com/users/chaosmail/events{/privacy}","received_events_url":"https://api.github.com/users/chaosmail/received_events","type":"User","site_admin":false},"body":"I would love to make 2 describe blocks:\r\n```js\r\n describe('sanitizeAxes', () => {\r\n  describe('compute numeric extrema', () => {\r\n    // here we go\r\n    it('should do sth', () => { ... })\r\n  });\r\n});\r\n```","created_at":"2015-10-05T14:01:07Z","updated_at":"2015-10-05T14:01:07Z","html_url":"https://github.com/n3-charts/line-chart/pull/346#discussion_r41146398","pull_request_url":"https://api.github.com/repos/n3-charts/line-chart/pulls/346","_links":{"self":{"href":"https://api.github.com/repos/n3-charts/line-chart/pulls/comments/41146398"},"html":{"href":"https://github.com/n3-charts/line-chart/pull/346#discussion_r41146398"},"pull_request":{"href":"https://api.github.com/repos/n3-charts/line-chart/pulls/346"}}},"pull_request":{"url":"https://api.github.com/repos/n3-charts/line-chart/pulls/346","id":46777841,"html_url":"https://github.com/n3-charts/line-chart/pull/346","diff_url":"https://github.com/n3-charts/line-chart/pull/346.diff","patch_url":"https://github.com/n3-charts/line-chart/pull/346.patch","issue_url":"https://api.github.com/repos/n3-charts/line-chart/issues/346","number":346,"state":"open","locked":false,"title":"Added extrema to axes","user":{"login":"lorem--ipsum","id":1224709,"avatar_url":"https://avatars.githubusercontent.com/u/1224709?v=3","gravatar_id":"","url":"https://api.github.com/users/lorem--ipsum","html_url":"https://github.com/lorem--ipsum","followers_url":"https://api.github.com/users/lorem--ipsum/followers","following_url":"https://api.github.com/users/lorem--ipsum/following{/other_user}","gists_url":"https://api.github.com/users/lorem--ipsum/gists{/gist_id}","starred_url":"https://api.github.com/users/lorem--ipsum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorem--ipsum/subscriptions","organizations_url":"https://api.github.com/users/lorem--ipsum/orgs","repos_url":"https://api.github.com/users/lorem--ipsum/repos","events_url":"https://api.github.com/users/lorem--ipsum/events{/privacy}","received_events_url":"https://api.github.com/users/lorem--ipsum/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-05T13:05:27Z","updated_at":"2015-10-05T14:01:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5e1c48e3e97b5a1d2720d1f23884a5485a75654","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/n3-charts/line-chart/pulls/346/commits","review_comments_url":"https://api.github.com/repos/n3-charts/line-chart/pulls/346/comments","review_comment_url":"https://api.github.com/repos/n3-charts/line-chart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/n3-charts/line-chart/issues/346/comments","statuses_url":"https://api.github.com/repos/n3-charts/line-chart/statuses/4e4e0558deb053ff81efcb774dd080177bd219ce","head":{"label":"n3-charts:feat/extrema","ref":"feat/extrema","sha":"4e4e0558deb053ff81efcb774dd080177bd219ce","user":{"login":"n3-charts","id":4318902,"avatar_url":"https://avatars.githubusercontent.com/u/4318902?v=3","gravatar_id":"","url":"https://api.github.com/users/n3-charts","html_url":"https://github.com/n3-charts","followers_url":"https://api.github.com/users/n3-charts/followers","following_url":"https://api.github.com/users/n3-charts/following{/other_user}","gists_url":"https://api.github.com/users/n3-charts/gists{/gist_id}","starred_url":"https://api.github.com/users/n3-charts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3-charts/subscriptions","organizations_url":"https://api.github.com/users/n3-charts/orgs","repos_url":"https://api.github.com/users/n3-charts/repos","events_url":"https://api.github.com/users/n3-charts/events{/privacy}","received_events_url":"https://api.github.com/users/n3-charts/received_events","type":"Organization","site_admin":false},"repo":{"id":9873034,"name":"line-chart","full_name":"n3-charts/line-chart","owner":{"login":"n3-charts","id":4318902,"avatar_url":"https://avatars.githubusercontent.com/u/4318902?v=3","gravatar_id":"","url":"https://api.github.com/users/n3-charts","html_url":"https://github.com/n3-charts","followers_url":"https://api.github.com/users/n3-charts/followers","following_url":"https://api.github.com/users/n3-charts/following{/other_user}","gists_url":"https://api.github.com/users/n3-charts/gists{/gist_id}","starred_url":"https://api.github.com/users/n3-charts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3-charts/subscriptions","organizations_url":"https://api.github.com/users/n3-charts/orgs","repos_url":"https://api.github.com/users/n3-charts/repos","events_url":"https://api.github.com/users/n3-charts/events{/privacy}","received_events_url":"https://api.github.com/users/n3-charts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/n3-charts/line-chart","description":"Awesome charts for AngularJS.","fork":false,"url":"https://api.github.com/repos/n3-charts/line-chart","forks_url":"https://api.github.com/repos/n3-charts/line-chart/forks","keys_url":"https://api.github.com/repos/n3-charts/line-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n3-charts/line-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n3-charts/line-chart/teams","hooks_url":"https://api.github.com/repos/n3-charts/line-chart/hooks","issue_events_url":"https://api.github.com/repos/n3-charts/line-chart/issues/events{/number}","events_url":"https://api.github.com/repos/n3-charts/line-chart/events","assignees_url":"https://api.github.com/repos/n3-charts/line-chart/assignees{/user}","branches_url":"https://api.github.com/repos/n3-charts/line-chart/branches{/branch}","tags_url":"https://api.github.com/repos/n3-charts/line-chart/tags","blobs_url":"https://api.github.com/repos/n3-charts/line-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n3-charts/line-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n3-charts/line-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/n3-charts/line-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n3-charts/line-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/n3-charts/line-chart/languages","stargazers_url":"https://api.github.com/repos/n3-charts/line-chart/stargazers","contributors_url":"https://api.github.com/repos/n3-charts/line-chart/contributors","subscribers_url":"https://api.github.com/repos/n3-charts/line-chart/subscribers","subscription_url":"https://api.github.com/repos/n3-charts/line-chart/subscription","commits_url":"https://api.github.com/repos/n3-charts/line-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/n3-charts/line-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/n3-charts/line-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/n3-charts/line-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/n3-charts/line-chart/contents/{+path}","compare_url":"https://api.github.com/repos/n3-charts/line-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n3-charts/line-chart/merges","archive_url":"https://api.github.com/repos/n3-charts/line-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n3-charts/line-chart/downloads","issues_url":"https://api.github.com/repos/n3-charts/line-chart/issues{/number}","pulls_url":"https://api.github.com/repos/n3-charts/line-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/n3-charts/line-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/n3-charts/line-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n3-charts/line-chart/labels{/name}","releases_url":"https://api.github.com/repos/n3-charts/line-chart/releases{/id}","created_at":"2013-05-05T19:01:04Z","updated_at":"2015-09-30T22:18:35Z","pushed_at":"2015-10-05T13:05:28Z","git_url":"git://github.com/n3-charts/line-chart.git","ssh_url":"git@github.com:n3-charts/line-chart.git","clone_url":"https://github.com/n3-charts/line-chart.git","svn_url":"https://github.com/n3-charts/line-chart","homepage":"http://n3-charts.github.io/line-chart/","size":16098,"stargazers_count":1004,"watchers_count":1004,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":148,"mirror_url":null,"open_issues_count":36,"forks":148,"open_issues":36,"watchers":1004,"default_branch":"master"}},"base":{"label":"n3-charts:dev","ref":"dev","sha":"d05485e758e06b93d1214334dadad8de6d6fdd54","user":{"login":"n3-charts","id":4318902,"avatar_url":"https://avatars.githubusercontent.com/u/4318902?v=3","gravatar_id":"","url":"https://api.github.com/users/n3-charts","html_url":"https://github.com/n3-charts","followers_url":"https://api.github.com/users/n3-charts/followers","following_url":"https://api.github.com/users/n3-charts/following{/other_user}","gists_url":"https://api.github.com/users/n3-charts/gists{/gist_id}","starred_url":"https://api.github.com/users/n3-charts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3-charts/subscriptions","organizations_url":"https://api.github.com/users/n3-charts/orgs","repos_url":"https://api.github.com/users/n3-charts/repos","events_url":"https://api.github.com/users/n3-charts/events{/privacy}","received_events_url":"https://api.github.com/users/n3-charts/received_events","type":"Organization","site_admin":false},"repo":{"id":9873034,"name":"line-chart","full_name":"n3-charts/line-chart","owner":{"login":"n3-charts","id":4318902,"avatar_url":"https://avatars.githubusercontent.com/u/4318902?v=3","gravatar_id":"","url":"https://api.github.com/users/n3-charts","html_url":"https://github.com/n3-charts","followers_url":"https://api.github.com/users/n3-charts/followers","following_url":"https://api.github.com/users/n3-charts/following{/other_user}","gists_url":"https://api.github.com/users/n3-charts/gists{/gist_id}","starred_url":"https://api.github.com/users/n3-charts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n3-charts/subscriptions","organizations_url":"https://api.github.com/users/n3-charts/orgs","repos_url":"https://api.github.com/users/n3-charts/repos","events_url":"https://api.github.com/users/n3-charts/events{/privacy}","received_events_url":"https://api.github.com/users/n3-charts/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/n3-charts/line-chart","description":"Awesome charts for AngularJS.","fork":false,"url":"https://api.github.com/repos/n3-charts/line-chart","forks_url":"https://api.github.com/repos/n3-charts/line-chart/forks","keys_url":"https://api.github.com/repos/n3-charts/line-chart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n3-charts/line-chart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n3-charts/line-chart/teams","hooks_url":"https://api.github.com/repos/n3-charts/line-chart/hooks","issue_events_url":"https://api.github.com/repos/n3-charts/line-chart/issues/events{/number}","events_url":"https://api.github.com/repos/n3-charts/line-chart/events","assignees_url":"https://api.github.com/repos/n3-charts/line-chart/assignees{/user}","branches_url":"https://api.github.com/repos/n3-charts/line-chart/branches{/branch}","tags_url":"https://api.github.com/repos/n3-charts/line-chart/tags","blobs_url":"https://api.github.com/repos/n3-charts/line-chart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n3-charts/line-chart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n3-charts/line-chart/git/refs{/sha}","trees_url":"https://api.github.com/repos/n3-charts/line-chart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n3-charts/line-chart/statuses/{sha}","languages_url":"https://api.github.com/repos/n3-charts/line-chart/languages","stargazers_url":"https://api.github.com/repos/n3-charts/line-chart/stargazers","contributors_url":"https://api.github.com/repos/n3-charts/line-chart/contributors","subscribers_url":"https://api.github.com/repos/n3-charts/line-chart/subscribers","subscription_url":"https://api.github.com/repos/n3-charts/line-chart/subscription","commits_url":"https://api.github.com/repos/n3-charts/line-chart/commits{/sha}","git_commits_url":"https://api.github.com/repos/n3-charts/line-chart/git/commits{/sha}","comments_url":"https://api.github.com/repos/n3-charts/line-chart/comments{/number}","issue_comment_url":"https://api.github.com/repos/n3-charts/line-chart/issues/comments{/number}","contents_url":"https://api.github.com/repos/n3-charts/line-chart/contents/{+path}","compare_url":"https://api.github.com/repos/n3-charts/line-chart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n3-charts/line-chart/merges","archive_url":"https://api.github.com/repos/n3-charts/line-chart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n3-charts/line-chart/downloads","issues_url":"https://api.github.com/repos/n3-charts/line-chart/issues{/number}","pulls_url":"https://api.github.com/repos/n3-charts/line-chart/pulls{/number}","milestones_url":"https://api.github.com/repos/n3-charts/line-chart/milestones{/number}","notifications_url":"https://api.github.com/repos/n3-charts/line-chart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n3-charts/line-chart/labels{/name}","releases_url":"https://api.github.com/repos/n3-charts/line-chart/releases{/id}","created_at":"2013-05-05T19:01:04Z","updated_at":"2015-09-30T22:18:35Z","pushed_at":"2015-10-05T13:05:28Z","git_url":"git://github.com/n3-charts/line-chart.git","ssh_url":"git@github.com:n3-charts/line-chart.git","clone_url":"https://github.com/n3-charts/line-chart.git","svn_url":"https://github.com/n3-charts/line-chart","homepage":"http://n3-charts.github.io/line-chart/","size":16098,"stargazers_count":1004,"watchers_count":1004,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":148,"mirror_url":null,"open_issues_count":36,"forks":148,"open_issues":36,"watchers":1004,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/n3-charts/line-chart/pulls/346"},"html":{"href":"https://github.com/n3-charts/line-chart/pull/346"},"issue":{"href":"https://api.github.com/repos/n3-charts/line-chart/issues/346"},"comments":{"href":"https://api.github.com/repos/n3-charts/line-chart/issues/346/comments"},"review_comments":{"href":"https://api.github.com/repos/n3-charts/line-chart/pulls/346/comments"},"review_comment":{"href":"https://api.github.com/repos/n3-charts/line-chart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/n3-charts/line-chart/pulls/346/commits"},"statuses":{"href":"https://api.github.com/repos/n3-charts/line-chart/statuses/4e4e0558deb053ff81efcb774dd080177bd219ce"}}}}