{"action":"created","issue":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/issues/1260","labels_url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/issues/1260/labels{/name}","comments_url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/issues/1260/comments","events_url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/issues/1260/events","html_url":"https://github.com/elasticsearch/elasticsearch-net/pull/1260","id":58878062,"number":1260,"title":"expose SetTcpKeepAlive() on ConnectionSettings ","user":{"login":"Mpdreamz","id":245275,"avatar_url":"https://avatars.githubusercontent.com/u/245275?v=3","gravatar_id":"","url":"https://api.github.com/users/Mpdreamz","html_url":"https://github.com/Mpdreamz","followers_url":"https://api.github.com/users/Mpdreamz/followers","following_url":"https://api.github.com/users/Mpdreamz/following{/other_user}","gists_url":"https://api.github.com/users/Mpdreamz/gists{/gist_id}","starred_url":"https://api.github.com/users/Mpdreamz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mpdreamz/subscriptions","organizations_url":"https://api.github.com/users/Mpdreamz/orgs","repos_url":"https://api.github.com/users/Mpdreamz/repos","events_url":"https://api.github.com/users/Mpdreamz/events{/privacy}","received_events_url":"https://api.github.com/users/Mpdreamz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-25T10:05:01Z","updated_at":"2015-02-25T15:00:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/pulls/1260","html_url":"https://github.com/elasticsearch/elasticsearch-net/pull/1260","diff_url":"https://github.com/elasticsearch/elasticsearch-net/pull/1260.diff","patch_url":"https://github.com/elasticsearch/elasticsearch-net/pull/1260.patch"},"body":"so you do not need to subclass HttpConnection and override `AlterServicePoint()` to set it.\r\n\r\nSidenote:\r\n\r\nI also added an Obsolete on `HttpClientConnection` indicating its not as well tested as `HttpConnection` and as a heads up that with Elasticsearch.NET/NEST 2.0 we'll be moving the default `HttpConnection` over to `HttpClient` anyway. \r\n\r\nIm still not totally sure about moving over to `HttpClient` though, yes its a nicer interface, but there is a real benefit of having a **true** synchronous code path without the overhead of async dispatching even if that happens on IOCP threads. Calling `.Result` on a task is not really equivalent.\r\n\r\nWe might endup ifdeffing `HttpConnection` specifically for `aspnetcore50`, still lots to research and measure :)\r\n"},"comment":{"url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/issues/comments/75974562","html_url":"https://github.com/elasticsearch/elasticsearch-net/pull/1260#issuecomment-75974562","issue_url":"https://api.github.com/repos/elasticsearch/elasticsearch-net/issues/1260","id":75974562,"user":{"login":"gmarz","id":1594777,"avatar_url":"https://avatars.githubusercontent.com/u/1594777?v=3","gravatar_id":"","url":"https://api.github.com/users/gmarz","html_url":"https://github.com/gmarz","followers_url":"https://api.github.com/users/gmarz/followers","following_url":"https://api.github.com/users/gmarz/following{/other_user}","gists_url":"https://api.github.com/users/gmarz/gists{/gist_id}","starred_url":"https://api.github.com/users/gmarz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmarz/subscriptions","organizations_url":"https://api.github.com/users/gmarz/orgs","repos_url":"https://api.github.com/users/gmarz/repos","events_url":"https://api.github.com/users/gmarz/events{/privacy}","received_events_url":"https://api.github.com/users/gmarz/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T15:00:23Z","updated_at":"2015-02-25T15:00:23Z","body":"LGTM :+1: "}}