{"action":"created","issue":{"url":"https://api.github.com/repos/apache/incubator-tinkerpop/issues/113","labels_url":"https://api.github.com/repos/apache/incubator-tinkerpop/issues/113/labels{/name}","comments_url":"https://api.github.com/repos/apache/incubator-tinkerpop/issues/113/comments","events_url":"https://api.github.com/repos/apache/incubator-tinkerpop/issues/113/events","html_url":"https://github.com/apache/incubator-tinkerpop/pull/113","id":112364989,"number":113,"title":"TINKERPOP3-885 Made Transaction.onReadWrite() a ThreadLocal setting","user":{"login":"PommeVerte","id":1415875,"avatar_url":"https://avatars.githubusercontent.com/u/1415875?v=3","gravatar_id":"","url":"https://api.github.com/users/PommeVerte","html_url":"https://github.com/PommeVerte","followers_url":"https://api.github.com/users/PommeVerte/followers","following_url":"https://api.github.com/users/PommeVerte/following{/other_user}","gists_url":"https://api.github.com/users/PommeVerte/gists{/gist_id}","starred_url":"https://api.github.com/users/PommeVerte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PommeVerte/subscriptions","organizations_url":"https://api.github.com/users/PommeVerte/orgs","repos_url":"https://api.github.com/users/PommeVerte/repos","events_url":"https://api.github.com/users/PommeVerte/events{/privacy}","received_events_url":"https://api.github.com/users/PommeVerte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-10-20T13:09:28Z","updated_at":"2015-10-21T12:33:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/incubator-tinkerpop/pulls/113","html_url":"https://github.com/apache/incubator-tinkerpop/pull/113","diff_url":"https://github.com/apache/incubator-tinkerpop/pull/113.diff","patch_url":"https://github.com/apache/incubator-tinkerpop/pull/113.patch"},"body":"JIRA issue : https://issues.apache.org/jira/browse/TINKERPOP3-885\r\n\r\nBoth transaction consumers have been made `ThreadLocal` settings.\r\n\r\nSince this is a breaking change I've made some additions to the upgrade document. It's worth noting that I didn't put anything in there for graph providers as I wasn't sure what to put. Feel free to change/remove/add to this. (or tell me and I'll be more than happy to add to it myself)\r\n\r\nI've also only added the initial failing test we had found. If you can think of anymore let me know.\r\n\r\nPS: I've tried testing the full suit but for some reason my computer isn't cooperating and it's just taking too much time (and ressources) so I had to stop it. If any of you could give it a go I'd be grateful. Tests passed for gremlin-server, gremlin-core, gremlin-groovy(-test), tinkergraph-gremlin from what I've seen. Not sure about the others.\r\nI'll try and get some stable testing plateform up sometime soon."},"comment":{"url":"https://api.github.com/repos/apache/incubator-tinkerpop/issues/comments/149878701","html_url":"https://github.com/apache/incubator-tinkerpop/pull/113#issuecomment-149878701","issue_url":"https://api.github.com/repos/apache/incubator-tinkerpop/issues/113","id":149878701,"user":{"login":"PommeVerte","id":1415875,"avatar_url":"https://avatars.githubusercontent.com/u/1415875?v=3","gravatar_id":"","url":"https://api.github.com/users/PommeVerte","html_url":"https://github.com/PommeVerte","followers_url":"https://api.github.com/users/PommeVerte/followers","following_url":"https://api.github.com/users/PommeVerte/following{/other_user}","gists_url":"https://api.github.com/users/PommeVerte/gists{/gist_id}","starred_url":"https://api.github.com/users/PommeVerte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PommeVerte/subscriptions","organizations_url":"https://api.github.com/users/PommeVerte/orgs","repos_url":"https://api.github.com/users/PommeVerte/repos","events_url":"https://api.github.com/users/PommeVerte/events{/privacy}","received_events_url":"https://api.github.com/users/PommeVerte/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T12:33:05Z","updated_at":"2015-10-21T12:33:05Z","body":"Done, it was a conflict with the upgrade documentation"}}