{"action":"closed","number":24598,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/24598","id":33616683,"html_url":"https://github.com/rust-lang/rust/pull/24598","diff_url":"https://github.com/rust-lang/rust/pull/24598.diff","patch_url":"https://github.com/rust-lang/rust/pull/24598.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/24598","number":24598,"state":"closed","locked":false,"title":"Implement Debug for File","user":{"login":"lfairy","id":1572323,"avatar_url":"https://avatars.githubusercontent.com/u/1572323?v=3","gravatar_id":"","url":"https://api.github.com/users/lfairy","html_url":"https://github.com/lfairy","followers_url":"https://api.github.com/users/lfairy/followers","following_url":"https://api.github.com/users/lfairy/following{/other_user}","gists_url":"https://api.github.com/users/lfairy/gists{/gist_id}","starred_url":"https://api.github.com/users/lfairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfairy/subscriptions","organizations_url":"https://api.github.com/users/lfairy/orgs","repos_url":"https://api.github.com/users/lfairy/repos","events_url":"https://api.github.com/users/lfairy/events{/privacy}","received_events_url":"https://api.github.com/users/lfairy/received_events","type":"User","site_admin":false},"body":"This patch adds a `Debug` impl for `std::fs::File`.\r\n\r\nOn all platforms (Unix and Windows) it shows the file descriptor.\r\n\r\nOn Linux, it displays the path and access mode as well.\r\n\r\nIdeally we should show the path/mode for all platforms, not just Linux,\r\nbut this will do for now.\r\n\r\ncc #24570","created_at":"2015-04-19T10:29:43Z","updated_at":"2015-04-21T13:51:24Z","closed_at":"2015-04-21T13:51:24Z","merged_at":"2015-04-21T13:51:24Z","merge_commit_sha":"665c0ab3362f4ba7651e4784be3d389d3f7b7eb2","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars.githubusercontent.com/u/155238?v=3","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/24598/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/24598/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/24598/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/1131bc0a0f9d4ce920f239dccbd0fcfe1c940548","head":{"label":"lfairy:impl-debug-for-file","ref":"impl-debug-for-file","sha":"1131bc0a0f9d4ce920f239dccbd0fcfe1c940548","user":{"login":"lfairy","id":1572323,"avatar_url":"https://avatars.githubusercontent.com/u/1572323?v=3","gravatar_id":"","url":"https://api.github.com/users/lfairy","html_url":"https://github.com/lfairy","followers_url":"https://api.github.com/users/lfairy/followers","following_url":"https://api.github.com/users/lfairy/following{/other_user}","gists_url":"https://api.github.com/users/lfairy/gists{/gist_id}","starred_url":"https://api.github.com/users/lfairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfairy/subscriptions","organizations_url":"https://api.github.com/users/lfairy/orgs","repos_url":"https://api.github.com/users/lfairy/repos","events_url":"https://api.github.com/users/lfairy/events{/privacy}","received_events_url":"https://api.github.com/users/lfairy/received_events","type":"User","site_admin":false},"repo":{"id":27859766,"name":"rust","full_name":"lfairy/rust","owner":{"login":"lfairy","id":1572323,"avatar_url":"https://avatars.githubusercontent.com/u/1572323?v=3","gravatar_id":"","url":"https://api.github.com/users/lfairy","html_url":"https://github.com/lfairy","followers_url":"https://api.github.com/users/lfairy/followers","following_url":"https://api.github.com/users/lfairy/following{/other_user}","gists_url":"https://api.github.com/users/lfairy/gists{/gist_id}","starred_url":"https://api.github.com/users/lfairy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lfairy/subscriptions","organizations_url":"https://api.github.com/users/lfairy/orgs","repos_url":"https://api.github.com/users/lfairy/repos","events_url":"https://api.github.com/users/lfairy/events{/privacy}","received_events_url":"https://api.github.com/users/lfairy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lfairy/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/lfairy/rust","forks_url":"https://api.github.com/repos/lfairy/rust/forks","keys_url":"https://api.github.com/repos/lfairy/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lfairy/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lfairy/rust/teams","hooks_url":"https://api.github.com/repos/lfairy/rust/hooks","issue_events_url":"https://api.github.com/repos/lfairy/rust/issues/events{/number}","events_url":"https://api.github.com/repos/lfairy/rust/events","assignees_url":"https://api.github.com/repos/lfairy/rust/assignees{/user}","branches_url":"https://api.github.com/repos/lfairy/rust/branches{/branch}","tags_url":"https://api.github.com/repos/lfairy/rust/tags","blobs_url":"https://api.github.com/repos/lfairy/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lfairy/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lfairy/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/lfairy/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lfairy/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/lfairy/rust/languages","stargazers_url":"https://api.github.com/repos/lfairy/rust/stargazers","contributors_url":"https://api.github.com/repos/lfairy/rust/contributors","subscribers_url":"https://api.github.com/repos/lfairy/rust/subscribers","subscription_url":"https://api.github.com/repos/lfairy/rust/subscription","commits_url":"https://api.github.com/repos/lfairy/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/lfairy/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/lfairy/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/lfairy/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/lfairy/rust/contents/{+path}","compare_url":"https://api.github.com/repos/lfairy/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lfairy/rust/merges","archive_url":"https://api.github.com/repos/lfairy/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lfairy/rust/downloads","issues_url":"https://api.github.com/repos/lfairy/rust/issues{/number}","pulls_url":"https://api.github.com/repos/lfairy/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/lfairy/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/lfairy/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lfairy/rust/labels{/name}","releases_url":"https://api.github.com/repos/lfairy/rust/releases{/id}","created_at":"2014-12-11T07:39:43Z","updated_at":"2015-04-19T05:15:02Z","pushed_at":"2015-04-21T05:18:18Z","git_url":"git://github.com/lfairy/rust.git","ssh_url":"git@github.com:lfairy/rust.git","clone_url":"https://github.com/lfairy/rust.git","svn_url":"https://github.com/lfairy/rust","homepage":"http://www.rust-lang.org","size":275380,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"21c48c3e823ed21266e96779d700946db957a965","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-04-21T13:51:19Z","pushed_at":"2015-04-21T13:51:19Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":563254,"stargazers_count":10397,"watchers_count":10397,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2006,"mirror_url":null,"open_issues_count":2007,"forks":2006,"open_issues":2007,"watchers":10397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24598"},"html":{"href":"https://github.com/rust-lang/rust/pull/24598"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24598"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/24598/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24598/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/24598/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/1131bc0a0f9d4ce920f239dccbd0fcfe1c940548"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":8,"review_comments":0,"commits":1,"additions":68,"deletions":0,"changed_files":4}}