{"action":"created","comment":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/comments/46436064","id":46436064,"diff_hunk":"@@ -108,11 +108,7 @@\n     </adapters>\n     <adapters key=\"com.cloud.agent.manager.allocator.StorageAllocator\">\n       <adapter name=\"Storage\"\n-        class=\"com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator\">","path":"server/test/async-job-component.xml","position":4,"original_position":4,"commit_id":"49f5a6b02ef786260db6d965538fa5b09f0cf7d1","original_commit_id":"49f5a6b02ef786260db6d965538fa5b09f0cf7d1","user":{"login":"bhaisaab","id":95203,"avatar_url":"https://avatars.githubusercontent.com/u/95203?v=3","gravatar_id":"","url":"https://api.github.com/users/bhaisaab","html_url":"https://github.com/bhaisaab","followers_url":"https://api.github.com/users/bhaisaab/followers","following_url":"https://api.github.com/users/bhaisaab/following{/other_user}","gists_url":"https://api.github.com/users/bhaisaab/gists{/gist_id}","starred_url":"https://api.github.com/users/bhaisaab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhaisaab/subscriptions","organizations_url":"https://api.github.com/users/bhaisaab/orgs","repos_url":"https://api.github.com/users/bhaisaab/repos","events_url":"https://api.github.com/users/bhaisaab/events{/privacy}","received_events_url":"https://api.github.com/users/bhaisaab/received_events","type":"User","site_admin":false},"body":"Not sure about this, anyone using this?","created_at":"2015-12-02T16:22:46Z","updated_at":"2015-12-02T16:22:46Z","html_url":"https://github.com/apache/cloudstack/pull/943#discussion_r46436064","pull_request_url":"https://api.github.com/repos/apache/cloudstack/pulls/943","_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments/46436064"},"html":{"href":"https://github.com/apache/cloudstack/pull/943#discussion_r46436064"},"pull_request":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/943"}}},"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/943","id":47994396,"html_url":"https://github.com/apache/cloudstack/pull/943","diff_url":"https://github.com/apache/cloudstack/pull/943.diff","patch_url":"https://github.com/apache/cloudstack/pull/943.patch","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/943","number":943,"state":"open","locked":false,"title":"CLOUDSTACK-8988: Removed unused adapters from async-job-component.xml.","user":{"login":"rodrigo93","id":9914896,"avatar_url":"https://avatars.githubusercontent.com/u/9914896?v=3","gravatar_id":"","url":"https://api.github.com/users/rodrigo93","html_url":"https://github.com/rodrigo93","followers_url":"https://api.github.com/users/rodrigo93/followers","following_url":"https://api.github.com/users/rodrigo93/following{/other_user}","gists_url":"https://api.github.com/users/rodrigo93/gists{/gist_id}","starred_url":"https://api.github.com/users/rodrigo93/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rodrigo93/subscriptions","organizations_url":"https://api.github.com/users/rodrigo93/orgs","repos_url":"https://api.github.com/users/rodrigo93/repos","events_url":"https://api.github.com/users/rodrigo93/events{/privacy}","received_events_url":"https://api.github.com/users/rodrigo93/received_events","type":"User","site_admin":false},"body":"I was looking the file /cloud-server/test/async-job-component.xml, and I found an adapter configuration that seems to have no use. The reason for that is explained as follows.\r\n\r\nThe adapter configuration is the following:\r\n<*adapters key=\"com.cloud.agent.manager.allocator.StorageAllocator\"*>\r\n      <*adapter name=\"Storage\"\r\n        class=\"com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator\"*>\r\n        <*param name=\"storage.overprovisioning.factor\"*>2<*/param*>\r\n      <*/adapter*>\r\n      <*adapter name=\"\r\n        class=\"com.cloud.agent.manager.allocator.impl.RandomStoragePoolAllocator\"*>\r\n        <*param name=\"storage.overprovisioning.factor\"*>2<*/param*>\r\n      <*/adapter*>\r\n<*/adapters*>\r\n\r\n•\tclass=\"com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator\"\r\n\r\nThe class \"com.cloud.agent.manager.allocator.impl.FirstFitStorageAllocator\" does not exist. The only reference for it is found in the following file:\r\n          -\t/cloud-server/test/async-job-component.xml\r\nTherefore, we can conclude that there is no need for this line at that file.\r\n\r\n•\tclass=\"com.cloud.agent.manager.allocator.impl.RandomStoragePoolAllocator\"\r\n\r\nAdditionally, the class RandomStoragePoolAllocator.java is never used. The only reference is found in the following file:\r\n-\t/cloud-server/test/async-job-component.xml\r\n\r\nI found a project called “cloud-plugin-storage-allocator-random”. This project has only one package that contains only one class, which is the RandomStoragePoolAllocator.java. Despite the names that are the same, the class in “cloud-plugin-storage-allocator-random”  project and the class referenced in -\t/cloud-server/test/async-job-component.xml have different packages. Therefore, I removed that configuration from async-job-component.xml and the project that contains only the RandomStoragePoolAllocator class that is never used.\r\nConsequently, I had to remove the following lines from the */cloud-client-ui/pom.xml*:\r\n    <*dependency*>\r\n      <*groupId*>org.apache.cloudstack<*/groupId*>\r\n      <*artifactId*>cloud-plugin-storage-allocator-random<*/artifactId*>\r\n      <*version*>${project.version}<*/version*>\r\n    <*/dependency*>\r\n\r\nFurthermore, after I removed that configuration I noticed that there is no such class StorageAllocator.java. However, it appears that exists test for it, like the following classes: \r\n-\tStorageAllocatorTestConfiguration.java\r\n-\tStorageAllocatorTest.java. \r\n\r\nI am not sure if these classes are tests for the class StorageAllocator.java and for the possible configuration I have just removed. If they are, we can remove both classes. Can someone help me on checking that? \r\n\r\n","created_at":"2015-10-17T20:16:54Z","updated_at":"2015-12-02T16:22:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c1d12b5251aa9a7cf764766281ffb0fe3df8e5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/cloudstack/pulls/943/commits","review_comments_url":"https://api.github.com/repos/apache/cloudstack/pulls/943/comments","review_comment_url":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/943/comments","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/49f5a6b02ef786260db6d965538fa5b09f0cf7d1","head":{"label":"rafaelweingartner:lrg-cs-hackday-009","ref":"lrg-cs-hackday-009","sha":"49f5a6b02ef786260db6d965538fa5b09f0cf7d1","user":{"login":"rafaelweingartner","id":4129005,"avatar_url":"https://avatars.githubusercontent.com/u/4129005?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelweingartner","html_url":"https://github.com/rafaelweingartner","followers_url":"https://api.github.com/users/rafaelweingartner/followers","following_url":"https://api.github.com/users/rafaelweingartner/following{/other_user}","gists_url":"https://api.github.com/users/rafaelweingartner/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelweingartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelweingartner/subscriptions","organizations_url":"https://api.github.com/users/rafaelweingartner/orgs","repos_url":"https://api.github.com/users/rafaelweingartner/repos","events_url":"https://api.github.com/users/rafaelweingartner/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelweingartner/received_events","type":"User","site_admin":false},"repo":{"id":36757203,"name":"cloudstack","full_name":"rafaelweingartner/cloudstack","owner":{"login":"rafaelweingartner","id":4129005,"avatar_url":"https://avatars.githubusercontent.com/u/4129005?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelweingartner","html_url":"https://github.com/rafaelweingartner","followers_url":"https://api.github.com/users/rafaelweingartner/followers","following_url":"https://api.github.com/users/rafaelweingartner/following{/other_user}","gists_url":"https://api.github.com/users/rafaelweingartner/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelweingartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelweingartner/subscriptions","organizations_url":"https://api.github.com/users/rafaelweingartner/orgs","repos_url":"https://api.github.com/users/rafaelweingartner/repos","events_url":"https://api.github.com/users/rafaelweingartner/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelweingartner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rafaelweingartner/cloudstack","description":"Mirror of Apache Cloudstack","fork":true,"url":"https://api.github.com/repos/rafaelweingartner/cloudstack","forks_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/forks","keys_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/teams","hooks_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/events","assignees_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/tags","blobs_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/languages","stargazers_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/subscription","commits_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/merges","archive_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/downloads","issues_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/rafaelweingartner/cloudstack/releases{/id}","created_at":"2015-06-02T19:38:39Z","updated_at":"2015-06-02T19:39:01Z","pushed_at":"2015-12-01T13:48:02Z","git_url":"git://github.com/rafaelweingartner/cloudstack.git","ssh_url":"git@github.com:rafaelweingartner/cloudstack.git","clone_url":"https://github.com/rafaelweingartner/cloudstack.git","svn_url":"https://github.com/rafaelweingartner/cloudstack","homepage":null,"size":498333,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2ae3e0c9613ccc0679851246aecbc16d9aaa2a94","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":9759448,"name":"cloudstack","full_name":"apache/cloudstack","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/cloudstack","description":"Mirror of Apache Cloudstack","fork":false,"url":"https://api.github.com/repos/apache/cloudstack","forks_url":"https://api.github.com/repos/apache/cloudstack/forks","keys_url":"https://api.github.com/repos/apache/cloudstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/cloudstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/cloudstack/teams","hooks_url":"https://api.github.com/repos/apache/cloudstack/hooks","issue_events_url":"https://api.github.com/repos/apache/cloudstack/issues/events{/number}","events_url":"https://api.github.com/repos/apache/cloudstack/events","assignees_url":"https://api.github.com/repos/apache/cloudstack/assignees{/user}","branches_url":"https://api.github.com/repos/apache/cloudstack/branches{/branch}","tags_url":"https://api.github.com/repos/apache/cloudstack/tags","blobs_url":"https://api.github.com/repos/apache/cloudstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/cloudstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/cloudstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/cloudstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/cloudstack/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/cloudstack/languages","stargazers_url":"https://api.github.com/repos/apache/cloudstack/stargazers","contributors_url":"https://api.github.com/repos/apache/cloudstack/contributors","subscribers_url":"https://api.github.com/repos/apache/cloudstack/subscribers","subscription_url":"https://api.github.com/repos/apache/cloudstack/subscription","commits_url":"https://api.github.com/repos/apache/cloudstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/cloudstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/cloudstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/cloudstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/cloudstack/contents/{+path}","compare_url":"https://api.github.com/repos/apache/cloudstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/cloudstack/merges","archive_url":"https://api.github.com/repos/apache/cloudstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/cloudstack/downloads","issues_url":"https://api.github.com/repos/apache/cloudstack/issues{/number}","pulls_url":"https://api.github.com/repos/apache/cloudstack/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/cloudstack/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/cloudstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/cloudstack/labels{/name}","releases_url":"https://api.github.com/repos/apache/cloudstack/releases{/id}","created_at":"2013-04-29T22:27:12Z","updated_at":"2015-12-02T15:08:25Z","pushed_at":"2015-12-02T12:42:58Z","git_url":"git://github.com/apache/cloudstack.git","ssh_url":"git@github.com:apache/cloudstack.git","clone_url":"https://github.com/apache/cloudstack.git","svn_url":"https://github.com/apache/cloudstack","homepage":null,"size":506347,"stargazers_count":321,"watchers_count":321,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":412,"mirror_url":"git://git.apache.org/cloudstack.git","open_issues_count":141,"forks":412,"open_issues":141,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/943"},"html":{"href":"https://github.com/apache/cloudstack/pull/943"},"issue":{"href":"https://api.github.com/repos/apache/cloudstack/issues/943"},"comments":{"href":"https://api.github.com/repos/apache/cloudstack/issues/943/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/943/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/cloudstack/pulls/943/commits"},"statuses":{"href":"https://api.github.com/repos/apache/cloudstack/statuses/49f5a6b02ef786260db6d965538fa5b09f0cf7d1"}}}}