{"action":"closed","number":1107,"pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/1107","id":43833859,"html_url":"https://github.com/google/closure-compiler/pull/1107","diff_url":"https://github.com/google/closure-compiler/pull/1107.diff","patch_url":"https://github.com/google/closure-compiler/pull/1107.patch","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/1107","number":1107,"state":"closed","locked":false,"title":"Remove @nosideeffects from DataTransferItem.prototype.getAsString()","user":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"body":"The following code incorrectly compiles to nothing:\r\n\r\n```javascript\r\nvar test = /** @type {!DataTransferItem} */(window['item']);\r\ntest.getAsString(alert);\r\n```\r\n\r\n[`DataTransferItem.prototype.getAsString`](http://www.w3.org/TR/2011/WD-html5-20110113/dnd.html#the-datatransferitem-interface) was incorrect labeled as not having side effects.\r\n\r\nMore generally, it may be a good idea to warning about externs with `@nosideeffects` that are missing `@return`.","created_at":"2015-09-01T03:25:08Z","updated_at":"2015-09-01T03:35:38Z","closed_at":"2015-09-01T03:35:38Z","merged_at":"2015-09-01T03:35:38Z","merge_commit_sha":"b0a0181d44b878b1fe94a560cd7e6ea53f803e23","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/closure-compiler/pulls/1107/commits","review_comments_url":"https://api.github.com/repos/google/closure-compiler/pulls/1107/comments","review_comment_url":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/1107/comments","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/bac3c5d8db2a2306d0dbc87967d822a884bab6f0","head":{"label":"pauldraper:pauldraper-data-transfer-item","ref":"pauldraper-data-transfer-item","sha":"bac3c5d8db2a2306d0dbc87967d822a884bab6f0","user":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"repo":{"id":21509222,"name":"closure-compiler","full_name":"pauldraper/closure-compiler","owner":{"login":"pauldraper","id":1403271,"avatar_url":"https://avatars.githubusercontent.com/u/1403271?v=3","gravatar_id":"","url":"https://api.github.com/users/pauldraper","html_url":"https://github.com/pauldraper","followers_url":"https://api.github.com/users/pauldraper/followers","following_url":"https://api.github.com/users/pauldraper/following{/other_user}","gists_url":"https://api.github.com/users/pauldraper/gists{/gist_id}","starred_url":"https://api.github.com/users/pauldraper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauldraper/subscriptions","organizations_url":"https://api.github.com/users/pauldraper/orgs","repos_url":"https://api.github.com/users/pauldraper/repos","events_url":"https://api.github.com/users/pauldraper/events{/privacy}","received_events_url":"https://api.github.com/users/pauldraper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pauldraper/closure-compiler","description":"A JavaScript checker and optimizer.","fork":true,"url":"https://api.github.com/repos/pauldraper/closure-compiler","forks_url":"https://api.github.com/repos/pauldraper/closure-compiler/forks","keys_url":"https://api.github.com/repos/pauldraper/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pauldraper/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pauldraper/closure-compiler/teams","hooks_url":"https://api.github.com/repos/pauldraper/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/pauldraper/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/pauldraper/closure-compiler/events","assignees_url":"https://api.github.com/repos/pauldraper/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/pauldraper/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/pauldraper/closure-compiler/tags","blobs_url":"https://api.github.com/repos/pauldraper/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pauldraper/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pauldraper/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/pauldraper/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pauldraper/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/pauldraper/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/pauldraper/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/pauldraper/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/pauldraper/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/pauldraper/closure-compiler/subscription","commits_url":"https://api.github.com/repos/pauldraper/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/pauldraper/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/pauldraper/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/pauldraper/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/pauldraper/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/pauldraper/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pauldraper/closure-compiler/merges","archive_url":"https://api.github.com/repos/pauldraper/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pauldraper/closure-compiler/downloads","issues_url":"https://api.github.com/repos/pauldraper/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/pauldraper/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/pauldraper/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/pauldraper/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pauldraper/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/pauldraper/closure-compiler/releases{/id}","created_at":"2014-07-04T22:53:32Z","updated_at":"2014-12-29T17:57:18Z","pushed_at":"2015-09-01T03:19:49Z","git_url":"git://github.com/pauldraper/closure-compiler.git","ssh_url":"git@github.com:pauldraper/closure-compiler.git","clone_url":"https://github.com/pauldraper/closure-compiler.git","svn_url":"https://github.com/pauldraper/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":98464,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"178e7914054e0d07f9cf7478db1a6c388a176b91","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":18845024,"name":"closure-compiler","full_name":"google/closure-compiler","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/closure-compiler","description":"A JavaScript checker and optimizer.","fork":false,"url":"https://api.github.com/repos/google/closure-compiler","forks_url":"https://api.github.com/repos/google/closure-compiler/forks","keys_url":"https://api.github.com/repos/google/closure-compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/closure-compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/closure-compiler/teams","hooks_url":"https://api.github.com/repos/google/closure-compiler/hooks","issue_events_url":"https://api.github.com/repos/google/closure-compiler/issues/events{/number}","events_url":"https://api.github.com/repos/google/closure-compiler/events","assignees_url":"https://api.github.com/repos/google/closure-compiler/assignees{/user}","branches_url":"https://api.github.com/repos/google/closure-compiler/branches{/branch}","tags_url":"https://api.github.com/repos/google/closure-compiler/tags","blobs_url":"https://api.github.com/repos/google/closure-compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/closure-compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/closure-compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/closure-compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/closure-compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/google/closure-compiler/languages","stargazers_url":"https://api.github.com/repos/google/closure-compiler/stargazers","contributors_url":"https://api.github.com/repos/google/closure-compiler/contributors","subscribers_url":"https://api.github.com/repos/google/closure-compiler/subscribers","subscription_url":"https://api.github.com/repos/google/closure-compiler/subscription","commits_url":"https://api.github.com/repos/google/closure-compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/closure-compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/closure-compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/closure-compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/closure-compiler/contents/{+path}","compare_url":"https://api.github.com/repos/google/closure-compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/closure-compiler/merges","archive_url":"https://api.github.com/repos/google/closure-compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/closure-compiler/downloads","issues_url":"https://api.github.com/repos/google/closure-compiler/issues{/number}","pulls_url":"https://api.github.com/repos/google/closure-compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/google/closure-compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/google/closure-compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/closure-compiler/labels{/name}","releases_url":"https://api.github.com/repos/google/closure-compiler/releases{/id}","created_at":"2014-04-16T15:30:36Z","updated_at":"2015-08-31T21:49:28Z","pushed_at":"2015-09-01T03:35:38Z","git_url":"git://github.com/google/closure-compiler.git","ssh_url":"git@github.com:google/closure-compiler.git","clone_url":"https://github.com/google/closure-compiler.git","svn_url":"https://github.com/google/closure-compiler","homepage":" https://developers.google.com/closure/compiler/","size":110758,"stargazers_count":1602,"watchers_count":1602,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":361,"mirror_url":null,"open_issues_count":389,"forks":361,"open_issues":389,"watchers":1602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1107"},"html":{"href":"https://github.com/google/closure-compiler/pull/1107"},"issue":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1107"},"comments":{"href":"https://api.github.com/repos/google/closure-compiler/issues/1107/comments"},"review_comments":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1107/comments"},"review_comment":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/closure-compiler/pulls/1107/commits"},"statuses":{"href":"https://api.github.com/repos/google/closure-compiler/statuses/bac3c5d8db2a2306d0dbc87967d822a884bab6f0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"MatrixFrog","id":244381,"avatar_url":"https://avatars.githubusercontent.com/u/244381?v=3","gravatar_id":"","url":"https://api.github.com/users/MatrixFrog","html_url":"https://github.com/MatrixFrog","followers_url":"https://api.github.com/users/MatrixFrog/followers","following_url":"https://api.github.com/users/MatrixFrog/following{/other_user}","gists_url":"https://api.github.com/users/MatrixFrog/gists{/gist_id}","starred_url":"https://api.github.com/users/MatrixFrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MatrixFrog/subscriptions","organizations_url":"https://api.github.com/users/MatrixFrog/orgs","repos_url":"https://api.github.com/users/MatrixFrog/repos","events_url":"https://api.github.com/users/MatrixFrog/events{/privacy}","received_events_url":"https://api.github.com/users/MatrixFrog/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":1,"changed_files":1}}