{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/44830336","id":44830336,"diff_hunk":"@@ -48,6 +48,8 @@ type URLMods struct {\n \tPath   string\n \t// Corresponds to Fragment in the URL struct, but we use Ref since URL Fragments are used and git commit refs\n \tRef string\n+\t// for use by scm.go DownloaderForSource for updating source input parameter into the s2i command\n+\tNewSource string","path":"pkg/scm/git/git.go","position":5,"original_position":5,"commit_id":"e53c355c3042230278994b8772cbe5cdd377a753","original_commit_id":"e53c355c3042230278994b8772cbe5cdd377a753","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"since this appears to only be set/used when the original path was a local filesystem path, i think the name needs work.  (as does the comment).\r\n\r\nalternatively change the instantiation of URLMods such that this is always populated.\r\n\r\n","created_at":"2015-11-13T20:29:51Z","updated_at":"2015-11-13T20:29:51Z","html_url":"https://github.com/openshift/source-to-image/pull/350#discussion_r44830336","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/44830336"},"html":{"href":"https://github.com/openshift/source-to-image/pull/350#discussion_r44830336"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/350","id":50685556,"html_url":"https://github.com/openshift/source-to-image/pull/350","diff_url":"https://github.com/openshift/source-to-image/pull/350.diff","patch_url":"https://github.com/openshift/source-to-image/pull/350.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/350","number":350,"state":"open","locked":false,"title":"don't prepend file:// to url path with MungeNoProto","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"@bparees the one small piece of clean up from the origin testing of the clone spec / url validation pull ; there is a short term work around to the caller of MungeNoProtocolURL on the origin side (pkg/generate/git/git.go) (no callers on the source-to-image side).  The origin side change can tolerate MungeNoProtocolURL either prefixing or not prefixing the path with \"file://\".\r\n\r\nWe can godeps merge this change and remove the workaround in origin at our convenience.\r\n\r\nPTAL when you get the chance - thx","created_at":"2015-11-13T20:07:59Z","updated_at":"2015-11-13T20:29:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55c885e7c124a64076bc88c11db4f7a6438e0698","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/350/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/350/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/350/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/e53c355c3042230278994b8772cbe5cdd377a753","head":{"label":"gabemontero:fixMungeProto","ref":"fixMungeProto","sha":"e53c355c3042230278994b8772cbe5cdd377a753","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36944033,"name":"source-to-image","full_name":"gabemontero/source-to-image","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/gabemontero/source-to-image","forks_url":"https://api.github.com/repos/gabemontero/source-to-image/forks","keys_url":"https://api.github.com/repos/gabemontero/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/source-to-image/teams","hooks_url":"https://api.github.com/repos/gabemontero/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/source-to-image/events","assignees_url":"https://api.github.com/repos/gabemontero/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/source-to-image/tags","blobs_url":"https://api.github.com/repos/gabemontero/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/source-to-image/languages","stargazers_url":"https://api.github.com/repos/gabemontero/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/source-to-image/subscription","commits_url":"https://api.github.com/repos/gabemontero/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/source-to-image/merges","archive_url":"https://api.github.com/repos/gabemontero/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/source-to-image/downloads","issues_url":"https://api.github.com/repos/gabemontero/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/source-to-image/releases{/id}","created_at":"2015-06-05T16:49:12Z","updated_at":"2015-06-05T16:49:12Z","pushed_at":"2015-11-13T20:03:33Z","git_url":"git://github.com/gabemontero/source-to-image.git","ssh_url":"git@github.com:gabemontero/source-to-image.git","clone_url":"https://github.com/gabemontero/source-to-image.git","svn_url":"https://github.com/gabemontero/source-to-image","homepage":"","size":1555,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8c7464c87bcd7e34276080b15083323bbeb35dd4","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","created_at":"2014-01-28T19:32:40Z","updated_at":"2015-11-11T20:21:53Z","pushed_at":"2015-11-13T20:07:59Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":3187,"stargazers_count":149,"watchers_count":149,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":15,"forks":69,"open_issues":15,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/350"},"html":{"href":"https://github.com/openshift/source-to-image/pull/350"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/350"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/e53c355c3042230278994b8772cbe5cdd377a753"}}}}