{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4291","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4291/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4291/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4291/events","html_url":"https://github.com/ManageIQ/manageiq/pull/4291","id":105695122,"number":4291,"title":"[WIP] Remove Qpid AMQP support","user":{"login":"blomquisg","id":14183,"avatar_url":"https://avatars.githubusercontent.com/u/14183?v=3","gravatar_id":"","url":"https://api.github.com/users/blomquisg","html_url":"https://github.com/blomquisg","followers_url":"https://api.github.com/users/blomquisg/followers","following_url":"https://api.github.com/users/blomquisg/following{/other_user}","gists_url":"https://api.github.com/users/blomquisg/gists{/gist_id}","starred_url":"https://api.github.com/users/blomquisg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blomquisg/subscriptions","organizations_url":"https://api.github.com/users/blomquisg/orgs","repos_url":"https://api.github.com/users/blomquisg/repos","events_url":"https://api.github.com/users/blomquisg/events{/privacy}","received_events_url":"https://api.github.com/users/blomquisg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/enhancement","name":"enhancement","color":"84b6eb"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/gem%20changes","name":"gem changes","color":"6A92BC"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/openstack","name":"providers/openstack","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/wip","name":"wip","color":"eeeeee"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-09-09T22:16:24Z","updated_at":"2015-09-10T02:28:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4291","html_url":"https://github.com/ManageIQ/manageiq/pull/4291","diff_url":"https://github.com/ManageIQ/manageiq/pull/4291.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4291.patch"},"body":"Since OpenStack is no longer using Qpid for it's AMQP bus, we're no longer supporting the Qpid client for collecting messages from OpenStack's AMQP bus.\r\n\r\nThere are a couple reasons to actively remove support for Qpid:\r\n\r\n1) The logic (some of which is cleaned up here, but more cleanup could actually be done in `OpenstackEventMonitor`) for selecting the correct AMQP client is pretty complex.  The main reason for this code to ever exist was because there was no API-based mechanism to ask OpenStack which AMQP bus it was using, and the different AMQP implementations were incompatible (e.g., a Qpid client could not be used with a Rabbit server).\r\n\r\n2) The work involved in building the native packages for qpid was taxing.  Every time we prepare to release a new version of ManageIQ, there's is a measurable level of pain involved if the qpid native dependencies had any changes.  For instance, if we upgraded to a newer version of CentOS for the virtual appliance.\r\n\r\nNow that qpid is definitely not required to support AMQP connections to OpenStack, we're removing it."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/139098273","html_url":"https://github.com/ManageIQ/manageiq/pull/4291#issuecomment-139098273","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4291","id":139098273,"user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"created_at":"2015-09-10T02:28:48Z","updated_at":"2015-09-10T02:28:48Z","body":"> Also, seeing some decent decreases in coverage in gems/pending. I'll look at bolstering that back up. Unless @jrafanie is so keen on getting this in, he doesn't even care about tests.\r\n\r\nI don't see that you're removing non-qpid tests so the only place I can see you needing to add/keep tests for THIS PR is where the qpid/bunny gating needed to be removed and defaulted to bunny now?  I mean, it's not like you are removing test coverage in areas that remain useful, right?"}}