{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/28","id":44630540,"html_url":"https://github.com/bazaarvoice/bv-ui-core/pull/28","diff_url":"https://github.com/bazaarvoice/bv-ui-core/pull/28.diff","patch_url":"https://github.com/bazaarvoice/bv-ui-core/pull/28.patch","issue_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues/28","number":28,"state":"closed","locked":false,"title":"Migrating bv-ui-pixels-displayed to module in the core","user":{"login":"msmolev","id":297568,"avatar_url":"https://avatars.githubusercontent.com/u/297568?v=3","gravatar_id":"","url":"https://api.github.com/users/msmolev","html_url":"https://github.com/msmolev","followers_url":"https://api.github.com/users/msmolev/followers","following_url":"https://api.github.com/users/msmolev/following{/other_user}","gists_url":"https://api.github.com/users/msmolev/gists{/gist_id}","starred_url":"https://api.github.com/users/msmolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmolev/subscriptions","organizations_url":"https://api.github.com/users/msmolev/orgs","repos_url":"https://api.github.com/users/msmolev/repos","events_url":"https://api.github.com/users/msmolev/events{/privacy}","received_events_url":"https://api.github.com/users/msmolev/received_events","type":"User","site_admin":false},"body":"This is an attempt to migrate https://github.com/bazaarvoice/bv-ui-pixels-displayed into the core library.\r\nOriginal library, however, only checked vertical visibility. So I have also duplicated the function and created horizontal version as well. \r\n\r\nMigrated tests, created horizontal tests, added link in Readme.","created_at":"2015-09-10T05:57:40Z","updated_at":"2015-09-11T17:54:32Z","closed_at":"2015-09-11T17:54:32Z","merged_at":null,"merge_commit_sha":"2fc70bc68bb697c316469ac74a0354c9190d901d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/28/commits","review_comments_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/28/comments","review_comment_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues/28/comments","statuses_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/statuses/7afb52774aad4bfd1843a6e4852bb13c9154cffd","head":{"label":"msmolev:pixels-displayed","ref":"pixels-displayed","sha":"7afb52774aad4bfd1843a6e4852bb13c9154cffd","user":{"login":"msmolev","id":297568,"avatar_url":"https://avatars.githubusercontent.com/u/297568?v=3","gravatar_id":"","url":"https://api.github.com/users/msmolev","html_url":"https://github.com/msmolev","followers_url":"https://api.github.com/users/msmolev/followers","following_url":"https://api.github.com/users/msmolev/following{/other_user}","gists_url":"https://api.github.com/users/msmolev/gists{/gist_id}","starred_url":"https://api.github.com/users/msmolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmolev/subscriptions","organizations_url":"https://api.github.com/users/msmolev/orgs","repos_url":"https://api.github.com/users/msmolev/repos","events_url":"https://api.github.com/users/msmolev/events{/privacy}","received_events_url":"https://api.github.com/users/msmolev/received_events","type":"User","site_admin":false},"repo":{"id":42220946,"name":"bv-ui-core","full_name":"msmolev/bv-ui-core","owner":{"login":"msmolev","id":297568,"avatar_url":"https://avatars.githubusercontent.com/u/297568?v=3","gravatar_id":"","url":"https://api.github.com/users/msmolev","html_url":"https://github.com/msmolev","followers_url":"https://api.github.com/users/msmolev/followers","following_url":"https://api.github.com/users/msmolev/following{/other_user}","gists_url":"https://api.github.com/users/msmolev/gists{/gist_id}","starred_url":"https://api.github.com/users/msmolev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msmolev/subscriptions","organizations_url":"https://api.github.com/users/msmolev/orgs","repos_url":"https://api.github.com/users/msmolev/repos","events_url":"https://api.github.com/users/msmolev/events{/privacy}","received_events_url":"https://api.github.com/users/msmolev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/msmolev/bv-ui-core","description":"A Node module for common Bazaarvoice UI code.","fork":true,"url":"https://api.github.com/repos/msmolev/bv-ui-core","forks_url":"https://api.github.com/repos/msmolev/bv-ui-core/forks","keys_url":"https://api.github.com/repos/msmolev/bv-ui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msmolev/bv-ui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msmolev/bv-ui-core/teams","hooks_url":"https://api.github.com/repos/msmolev/bv-ui-core/hooks","issue_events_url":"https://api.github.com/repos/msmolev/bv-ui-core/issues/events{/number}","events_url":"https://api.github.com/repos/msmolev/bv-ui-core/events","assignees_url":"https://api.github.com/repos/msmolev/bv-ui-core/assignees{/user}","branches_url":"https://api.github.com/repos/msmolev/bv-ui-core/branches{/branch}","tags_url":"https://api.github.com/repos/msmolev/bv-ui-core/tags","blobs_url":"https://api.github.com/repos/msmolev/bv-ui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msmolev/bv-ui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msmolev/bv-ui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/msmolev/bv-ui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msmolev/bv-ui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/msmolev/bv-ui-core/languages","stargazers_url":"https://api.github.com/repos/msmolev/bv-ui-core/stargazers","contributors_url":"https://api.github.com/repos/msmolev/bv-ui-core/contributors","subscribers_url":"https://api.github.com/repos/msmolev/bv-ui-core/subscribers","subscription_url":"https://api.github.com/repos/msmolev/bv-ui-core/subscription","commits_url":"https://api.github.com/repos/msmolev/bv-ui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/msmolev/bv-ui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/msmolev/bv-ui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/msmolev/bv-ui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/msmolev/bv-ui-core/contents/{+path}","compare_url":"https://api.github.com/repos/msmolev/bv-ui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msmolev/bv-ui-core/merges","archive_url":"https://api.github.com/repos/msmolev/bv-ui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msmolev/bv-ui-core/downloads","issues_url":"https://api.github.com/repos/msmolev/bv-ui-core/issues{/number}","pulls_url":"https://api.github.com/repos/msmolev/bv-ui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/msmolev/bv-ui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/msmolev/bv-ui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msmolev/bv-ui-core/labels{/name}","releases_url":"https://api.github.com/repos/msmolev/bv-ui-core/releases{/id}","created_at":"2015-09-10T03:56:37Z","updated_at":"2015-09-10T03:56:38Z","pushed_at":"2015-09-10T21:50:34Z","git_url":"git://github.com/msmolev/bv-ui-core.git","ssh_url":"git@github.com:msmolev/bv-ui-core.git","clone_url":"https://github.com/msmolev/bv-ui-core.git","svn_url":"https://github.com/msmolev/bv-ui-core","homepage":"","size":344,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazaarvoice:master","ref":"master","sha":"524965d8c6bbc1a6e066beaf47b89c4c92bfb8fa","user":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"repo":{"id":39015617,"name":"bv-ui-core","full_name":"bazaarvoice/bv-ui-core","owner":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazaarvoice/bv-ui-core","description":"A Node module for common Bazaarvoice UI code.","fork":false,"url":"https://api.github.com/repos/bazaarvoice/bv-ui-core","forks_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/forks","keys_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/teams","hooks_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/hooks","issue_events_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues/events{/number}","events_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/events","assignees_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/assignees{/user}","branches_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/branches{/branch}","tags_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/tags","blobs_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/languages","stargazers_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/stargazers","contributors_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/contributors","subscribers_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/subscribers","subscription_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/subscription","commits_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/contents/{+path}","compare_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/merges","archive_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/downloads","issues_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues{/number}","pulls_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/labels{/name}","releases_url":"https://api.github.com/repos/bazaarvoice/bv-ui-core/releases{/id}","created_at":"2015-07-13T14:03:45Z","updated_at":"2015-09-01T02:26:30Z","pushed_at":"2015-09-11T17:54:31Z","git_url":"git://github.com/bazaarvoice/bv-ui-core.git","ssh_url":"git@github.com:bazaarvoice/bv-ui-core.git","clone_url":"https://github.com/bazaarvoice/bv-ui-core.git","svn_url":"https://github.com/bazaarvoice/bv-ui-core","homepage":"","size":344,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/28"},"html":{"href":"https://github.com/bazaarvoice/bv-ui-core/pull/28"},"issue":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues/28"},"comments":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/bazaarvoice/bv-ui-core/statuses/7afb52774aad4bfd1843a6e4852bb13c9154cffd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":5,"commits":1,"additions":404,"deletions":0,"changed_files":4}}