{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/25599885","id":25599885,"diff_hunk":"@@ -471,6 +471,9 @@ void ProgramShaderCache::Shutdown()\n \t// store all shaders in cache on disk\n \tif (g_ogl_config.bSupportsGLSLCache && !g_Config.bEnableShaderDebugging)\n \t{\n+\t\t// Clear any prior error code\n+\t\tglGetError();","path":"Source/Core/VideoBackends/OGL/ProgramShaderCache.cpp","position":5,"original_position":5,"commit_id":"f63eed9eb9a006e98e58dfaa2e198352ec5199fd","original_commit_id":"f63eed9eb9a006e98e58dfaa2e198352ec5199fd","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"Please move this into the loop, else an error within line 485 would prohibit two shaders from being dumped.","created_at":"2015-03-02T14:05:32Z","updated_at":"2015-03-02T14:05:32Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/2164#discussion_r25599885","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/25599885"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2164#discussion_r25599885"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164","id":30265688,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2164","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2164.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2164.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2164","number":2164,"state":"open","locked":false,"title":"ProgramShaderCache: Do plenty of error checking before writing shaders to the disk.","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"body":"Attempt at fixing issue [6951](https://code.google.com/p/dolphin-emu/issues/detail?id=6951).","created_at":"2015-03-02T08:31:13Z","updated_at":"2015-03-02T14:05:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b262201288540202f898623f80d1ded44a8c960","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2164/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f63eed9eb9a006e98e58dfaa2e198352ec5199fd","head":{"label":"Armada651:cache-fix","ref":"cache-fix","sha":"f63eed9eb9a006e98e58dfaa2e198352ec5199fd","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"repo":{"id":16296067,"name":"dolphin","full_name":"Armada651/dolphin","owner":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Armada651/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Armada651/dolphin","forks_url":"https://api.github.com/repos/Armada651/dolphin/forks","keys_url":"https://api.github.com/repos/Armada651/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Armada651/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Armada651/dolphin/teams","hooks_url":"https://api.github.com/repos/Armada651/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Armada651/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Armada651/dolphin/events","assignees_url":"https://api.github.com/repos/Armada651/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Armada651/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Armada651/dolphin/tags","blobs_url":"https://api.github.com/repos/Armada651/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Armada651/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Armada651/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Armada651/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Armada651/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Armada651/dolphin/languages","stargazers_url":"https://api.github.com/repos/Armada651/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Armada651/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Armada651/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Armada651/dolphin/subscription","commits_url":"https://api.github.com/repos/Armada651/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Armada651/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Armada651/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Armada651/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Armada651/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Armada651/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Armada651/dolphin/merges","archive_url":"https://api.github.com/repos/Armada651/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Armada651/dolphin/downloads","issues_url":"https://api.github.com/repos/Armada651/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Armada651/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Armada651/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Armada651/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Armada651/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Armada651/dolphin/releases{/id}","created_at":"2014-01-27T23:04:02Z","updated_at":"2015-01-03T00:37:25Z","pushed_at":"2015-03-02T14:02:21Z","git_url":"git://github.com/Armada651/dolphin.git","ssh_url":"git@github.com:Armada651/dolphin.git","clone_url":"https://github.com/Armada651/dolphin.git","svn_url":"https://github.com/Armada651/dolphin","homepage":null,"size":216535,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"cd8c37bc0792a492b59976eba10a3e54e0ea2842","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-03-02T13:30:13Z","pushed_at":"2015-03-02T01:18:53Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":281078,"stargazers_count":1126,"watchers_count":1126,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":345,"mirror_url":null,"open_issues_count":64,"forks":345,"open_issues":64,"watchers":1126,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2164"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2164"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2164/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2164/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/f63eed9eb9a006e98e58dfaa2e198352ec5199fd"}}}}