{"action":"created","issue":{"url":"https://api.github.com/repos/erming/shout/issues/385","labels_url":"https://api.github.com/repos/erming/shout/issues/385/labels{/name}","comments_url":"https://api.github.com/repos/erming/shout/issues/385/comments","events_url":"https://api.github.com/repos/erming/shout/issues/385/events","html_url":"https://github.com/erming/shout/pull/385","id":64974995,"number":385,"title":"made channel names in chat clickable; lets users join channels","user":{"login":"AmShaegar13","id":3840390,"avatar_url":"https://avatars.githubusercontent.com/u/3840390?v=3","gravatar_id":"","url":"https://api.github.com/users/AmShaegar13","html_url":"https://github.com/AmShaegar13","followers_url":"https://api.github.com/users/AmShaegar13/followers","following_url":"https://api.github.com/users/AmShaegar13/following{/other_user}","gists_url":"https://api.github.com/users/AmShaegar13/gists{/gist_id}","starred_url":"https://api.github.com/users/AmShaegar13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmShaegar13/subscriptions","organizations_url":"https://api.github.com/users/AmShaegar13/orgs","repos_url":"https://api.github.com/users/AmShaegar13/repos","events_url":"https://api.github.com/users/AmShaegar13/events{/privacy}","received_events_url":"https://api.github.com/users/AmShaegar13/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/erming/shout/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"astorije","id":113730,"avatar_url":"https://avatars.githubusercontent.com/u/113730?v=3","gravatar_id":"","url":"https://api.github.com/users/astorije","html_url":"https://github.com/astorije","followers_url":"https://api.github.com/users/astorije/followers","following_url":"https://api.github.com/users/astorije/following{/other_user}","gists_url":"https://api.github.com/users/astorije/gists{/gist_id}","starred_url":"https://api.github.com/users/astorije/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astorije/subscriptions","organizations_url":"https://api.github.com/users/astorije/orgs","repos_url":"https://api.github.com/users/astorije/repos","events_url":"https://api.github.com/users/astorije/events{/privacy}","received_events_url":"https://api.github.com/users/astorije/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-03-28T18:49:54Z","updated_at":"2015-09-28T00:51:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/erming/shout/pulls/385","html_url":"https://github.com/erming/shout/pull/385","diff_url":"https://github.com/erming/shout/pull/385.diff","patch_url":"https://github.com/erming/shout/pull/385.patch"},"body":"Implements #361."},"comment":{"url":"https://api.github.com/repos/erming/shout/issues/comments/143608044","html_url":"https://github.com/erming/shout/pull/385#issuecomment-143608044","issue_url":"https://api.github.com/repos/erming/shout/issues/385","id":143608044,"user":{"login":"astorije","id":113730,"avatar_url":"https://avatars.githubusercontent.com/u/113730?v=3","gravatar_id":"","url":"https://api.github.com/users/astorije","html_url":"https://github.com/astorije","followers_url":"https://api.github.com/users/astorije/followers","following_url":"https://api.github.com/users/astorije/following{/other_user}","gists_url":"https://api.github.com/users/astorije/gists{/gist_id}","starred_url":"https://api.github.com/users/astorije/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astorije/subscriptions","organizations_url":"https://api.github.com/users/astorije/orgs","repos_url":"https://api.github.com/users/astorije/repos","events_url":"https://api.github.com/users/astorije/events{/privacy}","received_events_url":"https://api.github.com/users/astorije/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T00:51:50Z","updated_at":"2015-09-28T00:51:50Z","body":"> I discovered another downside of the button: You cannot select it as text. We should really use span... This should fix long channel names.\r\n\r\nYes, go for it :-)\r\n\r\n> The regex matches the closing now...\r\n\r\nYou probably didn't push this, did you?\r\n\r\n> Looks like the HTML context is not good for this feature... We may have to rethink where this code belongs\r\n\r\nI don't think we should: this definitely belongs to the client, not the server! Plus, in the `msg` incoming from the socket is also fine too.\r\nHowever, I do realize some problems indeed. That `processed` thing is odd and we shouldn't need it: we are actually processing one message, so let's add the `span` button here only, not trying to loop through all non-processed lines (which should be just this one!).\r\nThere are solutions to the HTML tag issue, but we must be careful as it could add security concerns with XSS if not correctly handled. I'll sleep on it and let you fix the rest in the meantime. Thanks!"}}