{"push_id":769387547,"size":44,"distinct_size":1,"ref":"refs/heads/async-job","head":"adec02fd371e8409a8b2ded1c547d76f533c0c63","before":"8baa17c73d0a33871340399eb2ba12ea37b14523","commits":[{"sha":"4ec818d28c3984ec9d27c362fc8ff48af9335cde","author":{"email":"afc4fcf5240077e4dc33a8a4cccd740dc11d85b8@gmail.com","name":"Vladimir Rybas"},"message":"RDoc: fix wrong model name `:inverse_of` with `:belongs_to` [ci skip]\n\nThere's a typo in ActiveRecord associations RDocs.\nWrong `Taggable` model name, instead of `Tagging` in example of using\noption `:inverse_of` with `:belongs_to` association.\n\nCommit where typo was introduced:\nhttps://github.com/rails/rails/commit/91fd6510563f84ee473bb217bc63ed598abe3f24#diff-39001423802a8470dba9c931e66e101eR11\n\nFirst it appears in `activerecord/CHANGELOG` in example of `:inverse_of`\nusage:\n\n```ruby\n    class Post < ActiveRecord::Base\n      has_many :taggings\n      has_many :tags, :through => :taggings\n    end\n\n    class Tagging < ActiveRecord::Base\n      belongs_to :post\n      belongs_to :tag, :inverse_of => :tagging # :inverse_of must be set!\n    end\n\n    class Tag < ActiveRecord::Base\n      has_many :taggings\n      has_many :posts, :through => :taggings\n    end\n\n    post = Post.first\n    tag = post.tags.build :name => \"ruby\"\n!>  tag.save # will save a Taggable linking to the post\n```\n\nThe last line should be\n\n```ruby\n    tag.save # will save a Tagging linking to the post\n```\n\nThe same typo appears in\n`activerecord/lib/active_record/associations.rb`.\nThe association name is given as `:inverse_of => :taggings`, but class\nname is `Taggable`.\n\n```ruby\n    #   @post = Post.first\n    #   @tag = @post.tags.build :name => \"ruby\"\n    #   @tag.save\n    #\n!>  # The last line ought to save the through record (a <tt>Taggable</tt>). This will only work if the\n    # <tt>:inverse_of</tt> is set:\n    #\n!>  #   class Taggable < ActiveRecord::Base\n    #     belongs_to :post\n!>  #     belongs_to :tag, :inverse_of => :taggings\n    #   end\n```\n\nThis PR fixes model name.","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/4ec818d28c3984ec9d27c362fc8ff48af9335cde"},{"sha":"854ab2e1e62e0a89ffcf4f49a1172d49fb80dcc9","author":{"email":"ab814d14c829adcf37a589584b4b0b1ebe2590a1@gmail.com","name":"Aditya Kapoor"},"message":"add missing tests for action regexp","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/854ab2e1e62e0a89ffcf4f49a1172d49fb80dcc9"},{"sha":"dbfab58457c4a2c958718b8f67491965d879c69a","author":{"email":"e5111e24a5add8b86f869c85a0d52aed0f909f3a@gmail.com","name":"deepj"},"message":"Remove unused block arguments","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/dbfab58457c4a2c958718b8f67491965d879c69a"},{"sha":"b43c09836335141304f14c562052d6274ff9b792","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"Add `assert_nothing_raised` to make clear test case perpose","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/b43c09836335141304f14c562052d6274ff9b792"},{"sha":"7adef79e1413db36f25a363f96136a1df85ea1a2","author":{"email":"342d37be615ddbbab8c261f5fdf8f4974558af12@gmail.com","name":"akihiro17"},"message":"Remove unused variables","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/7adef79e1413db36f25a363f96136a1df85ea1a2"},{"sha":"454e0c1c8df143f95d5e2d77e669792857906fab","author":{"email":"37b8411fc533112bb69dd1aa56980922c21ae5e0@gmail.com","name":"yui-knk"},"message":"[ci skip] Fix migration file's timestamp\n\nIn rails generally migration file's timestamp is \"YYYYMMDDHHMMSS\".","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/454e0c1c8df143f95d5e2d77e669792857906fab"},{"sha":"c5abac2b317351f5edb9bfcb542e27e8f2cbc916","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Merge pull request #21342 from yui-knk/test/add_assert_method\n\nAdd `assert_nothing_raised` to make clear test case perpose","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/c5abac2b317351f5edb9bfcb542e27e8f2cbc916"},{"sha":"9e5ba3c86b71b4fc10d60d72328a6692acee237e","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Merge pull request #21355 from akihiro17/remove-variables\n\nRemove unused variables","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/9e5ba3c86b71b4fc10d60d72328a6692acee237e"},{"sha":"35decf4b6b94a84205fe8ee684e2d90a0d2b0a87","author":{"email":"999e8c50cd8b45fcffd2276fb62f876489a73119@gmail.com","name":"Carlos Antonio da Silva"},"message":"Merge pull request #21339 from deepj/unused-block-arguments\n\nRemove unused block arguments","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/35decf4b6b94a84205fe8ee684e2d90a0d2b0a87"},{"sha":"be19bf3728f38a709d3e6f961fee856dc843f176","author":{"email":"73e88645cae6486da78d02f3a03ed68d9cb5f050@gmail.com","name":"Robin Dupret"},"message":"Merge pull request #21354 from yui-knk/fix/migration_file_timestamp\n\n[ci skip] Fix migration file's timestamp","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/be19bf3728f38a709d3e6f961fee856dc843f176"},{"sha":"8d7ce0f22aee09d20091a4dc58cb379a09d13e26","author":{"email":"3de680f0fd062129730970f68a7d1bb004d15fd0@gmail.com","name":"Nick Sutterer"},"message":"remove LookupContext#with_layout_format by passing formats for layouts explicitely.","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/8d7ce0f22aee09d20091a4dc58cb379a09d13e26"},{"sha":"c0daa02c24ced5940ad9ab36ca81dd25614e5e41","author":{"email":"3de680f0fd062129730970f68a7d1bb004d15fd0@gmail.com","name":"Nick Sutterer"},"message":"remove useless case in #resolve_layout.","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/c0daa02c24ced5940ad9ab36ca81dd25614e5e41"},{"sha":"b58808ed6a36b2f0baf614df3aa679c6fac3f17a","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Allow release when CHANGELOG is changed","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/b58808ed6a36b2f0baf614df3aa679c6fac3f17a"},{"sha":"face6042667c38fb8a372fa6f0bbfff88c4470f3","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Pass formats to lookup_context\n\nBefore we were changing the state of the lookup_context for the duration\nof the with_layout_format block, but since we already know the formats\nwe can just pass it explicitly.\n\nRelated with 8d7ce0f22aee09d20091a4dc58cb379a09d13e26","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/face6042667c38fb8a372fa6f0bbfff88c4470f3"},{"sha":"518ae9f055cd31c0f00c221d56bf0d44733cb782","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Pass the correct formats","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/518ae9f055cd31c0f00c221d56bf0d44733cb782"},{"sha":"337684fa28a3e8d55874d5740585710d0fa99ead","author":{"email":"7bbcc45b0f8f88a262415b9271579a59b891be2e@gmail.com","name":"Aaron Patterson"},"message":"use a custom request class to determine the controller class\n\ncontroller class resolution has been moved to the request object, so we\nshould override that method instead of relying on the RouteSet to\ngenerate the controller class.","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/337684fa28a3e8d55874d5740585710d0fa99ead"},{"sha":"a50872d51deb728b4dbafd2c255b083f3730f7be","author":{"email":"83b6df43678619ef6696b71148ab739a31241a74@gmail.com","name":"Gaurav Sharma"},"message":"temp files are no more require\n\n`:nail_care:`","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/a50872d51deb728b4dbafd2c255b083f3730f7be"},{"sha":"bd94e6de37307adad13fbdd6b4f7c5ed252adfa3","author":{"email":"84c66fc058fe65d1bb08ca33b21bfe0fa5cb8f17@gmail.com","name":"Rafael Mendonça França"},"message":"Merge pull request #21359 from Gaurav2728/gaurav-remove_unused_require_file\n\ntemp files are no more require","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/bd94e6de37307adad13fbdd6b4f7c5ed252adfa3"},{"sha":"2237ee059669aa8b65355fa9c8d4b426d4ae113c","author":{"email":"7bbcc45b0f8f88a262415b9271579a59b891be2e@gmail.com","name":"Aaron Patterson"},"message":"subclass and delegate rather than mutating existing objects\n\nIf we subclass and augment the superclass, then we don't need to have\nsetters for particular things on the superclass.","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/2237ee059669aa8b65355fa9c8d4b426d4ae113c"},{"sha":"31cc4d621f57f35356b3395cf78d7cf043d6795c","author":{"email":"7bbcc45b0f8f88a262415b9271579a59b891be2e@gmail.com","name":"Aaron Patterson"},"message":"remove setter for the dispatcher class\n\nwe don't need it anymore.  We always use the same dispatcher in tests.","distinct":false,"url":"https://api.github.com/repos/jdantonio/rails/commits/31cc4d621f57f35356b3395cf78d7cf043d6795c"}]}