{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/33883332","id":33883332,"diff_hunk":"@@ -3105,7 +3105,11 @@ internal override int CompareKeys(int index1, int index2)\n                 if (next == null) return index1 - index2;\n                 return next.CompareKeys(index1, index2);\n             }\n-            return descending ? -c : c;\n+            // -c will result in a negative value for int.MaxValue (-int.MinValue == int.MinValue).\n+            // Flipping keys earlier is more likely to trigger something strange in a comparer,\n+            // particularly as it comes to the sort being stable.\n+            // 0.CompareTo(c) is always negative for a positive c and positive for a negative.\n+            return descending ? 0.CompareTo(c) : c;","path":"src/System.Linq/src/System/Linq/Enumerable.cs","position":9,"original_position":9,"commit_id":"0f622945dd30d90b312ef7e6a9e004ca5a394c62","original_commit_id":"0f622945dd30d90b312ef7e6a9e004ca5a394c62","user":{"login":"hackcraft","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/hackcraft","html_url":"https://github.com/hackcraft","followers_url":"https://api.github.com/users/hackcraft/followers","following_url":"https://api.github.com/users/hackcraft/following{/other_user}","gists_url":"https://api.github.com/users/hackcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/hackcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackcraft/subscriptions","organizations_url":"https://api.github.com/users/hackcraft/orgs","repos_url":"https://api.github.com/users/hackcraft/repos","events_url":"https://api.github.com/users/hackcraft/events{/privacy}","received_events_url":"https://api.github.com/users/hackcraft/received_events","type":"User","site_admin":false},"body":"At the time of coding I preferred the fact that `0.CompareTo(c)` would also do the right thing if `c` was `0`. That shouldn't happen though, and your suggestion has one less branch (I'd expect the jitter to do the right thing in inlining `CompareTo` but not necessarily in removing the branch that considers the possibility of `c == 0`). I shall change that line to your suggestion.","created_at":"2015-07-04T00:11:59Z","updated_at":"2015-07-04T00:11:59Z","html_url":"https://github.com/dotnet/corefx/pull/2240#discussion_r33883332","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/2240","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/33883332"},"html":{"href":"https://github.com/dotnet/corefx/pull/2240#discussion_r33883332"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2240"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/2240","id":39188098,"html_url":"https://github.com/dotnet/corefx/pull/2240","diff_url":"https://github.com/dotnet/corefx/pull/2240.diff","patch_url":"https://github.com/dotnet/corefx/pull/2240.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/2240","number":2240,"state":"open","locked":false,"title":"Fix OrderByDescending if comparer returns int.MinValue","user":{"login":"hackcraft","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/hackcraft","html_url":"https://github.com/hackcraft","followers_url":"https://api.github.com/users/hackcraft/followers","following_url":"https://api.github.com/users/hackcraft/following{/other_user}","gists_url":"https://api.github.com/users/hackcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/hackcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackcraft/subscriptions","organizations_url":"https://api.github.com/users/hackcraft/orgs","repos_url":"https://api.github.com/users/hackcraft/repos","events_url":"https://api.github.com/users/hackcraft/events{/privacy}","received_events_url":"https://api.github.com/users/hackcraft/received_events","type":"User","site_admin":false},"body":"int.MinValue is a valid \"x is less than y\" result for a comparer but\r\nOrderByDescending treats it incorrectly. Fix this.\r\n\r\nFix #2239","created_at":"2015-07-03T16:50:33Z","updated_at":"2015-07-04T00:11:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c3401b6a14c957905c4b2926262201185ada1c7c","assignee":{"login":"VSadov","id":8218165,"avatar_url":"https://avatars.githubusercontent.com/u/8218165?v=3","gravatar_id":"","url":"https://api.github.com/users/VSadov","html_url":"https://github.com/VSadov","followers_url":"https://api.github.com/users/VSadov/followers","following_url":"https://api.github.com/users/VSadov/following{/other_user}","gists_url":"https://api.github.com/users/VSadov/gists{/gist_id}","starred_url":"https://api.github.com/users/VSadov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VSadov/subscriptions","organizations_url":"https://api.github.com/users/VSadov/orgs","repos_url":"https://api.github.com/users/VSadov/repos","events_url":"https://api.github.com/users/VSadov/events{/privacy}","received_events_url":"https://api.github.com/users/VSadov/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/2240/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/2240/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/2240/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/0f622945dd30d90b312ef7e6a9e004ca5a394c62","head":{"label":"hackcraft:Fix_2239","ref":"Fix_2239","sha":"0f622945dd30d90b312ef7e6a9e004ca5a394c62","user":{"login":"hackcraft","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/hackcraft","html_url":"https://github.com/hackcraft","followers_url":"https://api.github.com/users/hackcraft/followers","following_url":"https://api.github.com/users/hackcraft/following{/other_user}","gists_url":"https://api.github.com/users/hackcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/hackcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackcraft/subscriptions","organizations_url":"https://api.github.com/users/hackcraft/orgs","repos_url":"https://api.github.com/users/hackcraft/repos","events_url":"https://api.github.com/users/hackcraft/events{/privacy}","received_events_url":"https://api.github.com/users/hackcraft/received_events","type":"User","site_admin":false},"repo":{"id":38018243,"name":"corefx","full_name":"hackcraft/corefx","owner":{"login":"hackcraft","id":1253369,"avatar_url":"https://avatars.githubusercontent.com/u/1253369?v=3","gravatar_id":"","url":"https://api.github.com/users/hackcraft","html_url":"https://github.com/hackcraft","followers_url":"https://api.github.com/users/hackcraft/followers","following_url":"https://api.github.com/users/hackcraft/following{/other_user}","gists_url":"https://api.github.com/users/hackcraft/gists{/gist_id}","starred_url":"https://api.github.com/users/hackcraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackcraft/subscriptions","organizations_url":"https://api.github.com/users/hackcraft/orgs","repos_url":"https://api.github.com/users/hackcraft/repos","events_url":"https://api.github.com/users/hackcraft/events{/privacy}","received_events_url":"https://api.github.com/users/hackcraft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hackcraft/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/hackcraft/corefx","forks_url":"https://api.github.com/repos/hackcraft/corefx/forks","keys_url":"https://api.github.com/repos/hackcraft/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hackcraft/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hackcraft/corefx/teams","hooks_url":"https://api.github.com/repos/hackcraft/corefx/hooks","issue_events_url":"https://api.github.com/repos/hackcraft/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/hackcraft/corefx/events","assignees_url":"https://api.github.com/repos/hackcraft/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/hackcraft/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/hackcraft/corefx/tags","blobs_url":"https://api.github.com/repos/hackcraft/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hackcraft/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hackcraft/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/hackcraft/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hackcraft/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/hackcraft/corefx/languages","stargazers_url":"https://api.github.com/repos/hackcraft/corefx/stargazers","contributors_url":"https://api.github.com/repos/hackcraft/corefx/contributors","subscribers_url":"https://api.github.com/repos/hackcraft/corefx/subscribers","subscription_url":"https://api.github.com/repos/hackcraft/corefx/subscription","commits_url":"https://api.github.com/repos/hackcraft/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/hackcraft/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/hackcraft/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/hackcraft/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/hackcraft/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/hackcraft/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hackcraft/corefx/merges","archive_url":"https://api.github.com/repos/hackcraft/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hackcraft/corefx/downloads","issues_url":"https://api.github.com/repos/hackcraft/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/hackcraft/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/hackcraft/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/hackcraft/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hackcraft/corefx/labels{/name}","releases_url":"https://api.github.com/repos/hackcraft/corefx/releases{/id}","created_at":"2015-06-25T00:19:13Z","updated_at":"2015-06-25T00:19:32Z","pushed_at":"2015-07-03T18:29:25Z","git_url":"git://github.com/hackcraft/corefx.git","ssh_url":"git@github.com:hackcraft/corefx.git","clone_url":"https://github.com/hackcraft/corefx.git","svn_url":"https://github.com/hackcraft/corefx","homepage":"http://dotnet.github.io/core/","size":23278,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"4d96146c324980b3cf2d1ea467bee90b260f4974","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-07-03T21:26:07Z","pushed_at":"2015-07-03T22:37:38Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/core/","size":50327,"stargazers_count":7997,"watchers_count":7997,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1653,"mirror_url":null,"open_issues_count":457,"forks":1653,"open_issues":457,"watchers":7997,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2240"},"html":{"href":"https://github.com/dotnet/corefx/pull/2240"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2240"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/2240/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2240/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/2240/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/0f622945dd30d90b312ef7e6a9e004ca5a394c62"}}}}