{"action":"created","issue":{"url":"https://api.github.com/repos/NanoHttpd/nanohttpd/issues/206","labels_url":"https://api.github.com/repos/NanoHttpd/nanohttpd/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/NanoHttpd/nanohttpd/issues/206/comments","events_url":"https://api.github.com/repos/NanoHttpd/nanohttpd/issues/206/events","html_url":"https://github.com/NanoHttpd/nanohttpd/pull/206","id":93748430,"number":206,"title":"keep line endings when using maven-java-formatter-plugin","user":{"login":"McFoggy","id":1119660,"avatar_url":"https://avatars.githubusercontent.com/u/1119660?v=3","gravatar_id":"","url":"https://api.github.com/users/McFoggy","html_url":"https://github.com/McFoggy","followers_url":"https://api.github.com/users/McFoggy/followers","following_url":"https://api.github.com/users/McFoggy/following{/other_user}","gists_url":"https://api.github.com/users/McFoggy/gists{/gist_id}","starred_url":"https://api.github.com/users/McFoggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/McFoggy/subscriptions","organizations_url":"https://api.github.com/users/McFoggy/orgs","repos_url":"https://api.github.com/users/McFoggy/repos","events_url":"https://api.github.com/users/McFoggy/events{/privacy}","received_events_url":"https://api.github.com/users/McFoggy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-08T09:42:08Z","updated_at":"2015-07-09T17:17:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NanoHttpd/nanohttpd/pulls/206","html_url":"https://github.com/NanoHttpd/nanohttpd/pull/206","diff_url":"https://github.com/NanoHttpd/nanohttpd/pull/206.diff","patch_url":"https://github.com/NanoHttpd/nanohttpd/pull/206.patch"},"body":"Small change not to have modified files on windows.\r\npreviously the maven-java-formatter-plugin was changing some file line endings from LF to CRLF.\r\n\r\nanother possibility is to enforce one and only one line ending by using for example `<lineEnding>KEEP</lineEnding>` see [maven-java-formatter-plugin site](http://code.revelc.net/formatter-maven-plugin/format-mojo.html)"},"comment":{"url":"https://api.github.com/repos/NanoHttpd/nanohttpd/issues/comments/120076013","html_url":"https://github.com/NanoHttpd/nanohttpd/pull/206#issuecomment-120076013","issue_url":"https://api.github.com/repos/NanoHttpd/nanohttpd/issues/206","id":120076013,"user":{"login":"elonen","id":2125766,"avatar_url":"https://avatars.githubusercontent.com/u/2125766?v=3","gravatar_id":"","url":"https://api.github.com/users/elonen","html_url":"https://github.com/elonen","followers_url":"https://api.github.com/users/elonen/followers","following_url":"https://api.github.com/users/elonen/following{/other_user}","gists_url":"https://api.github.com/users/elonen/gists{/gist_id}","starred_url":"https://api.github.com/users/elonen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elonen/subscriptions","organizations_url":"https://api.github.com/users/elonen/orgs","repos_url":"https://api.github.com/users/elonen/repos","events_url":"https://api.github.com/users/elonen/events{/privacy}","received_events_url":"https://api.github.com/users/elonen/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T17:17:50Z","updated_at":"2015-07-09T17:17:50Z","body":"I'd prefer to keep the line endings one way or the other instead of mixing them. Since Maven is already reformatting the source code, I don't see a reason for not converting the line endings as well.\r\n\r\nI've always though CRLF is a bit silly, and most modern Windows code editors can deal with plain LF (the default for all Unix variants), but no strong opinions for or against. Any comments on this @ritchieGitHub ?"}}