{"action":"created","issue":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/18167","labels_url":"https://api.github.com/repos/twbs/bootstrap/issues/18167/labels{/name}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/18167/comments","events_url":"https://api.github.com/repos/twbs/bootstrap/issues/18167/events","html_url":"https://github.com/twbs/bootstrap/issues/18167","id":115169559,"number":18167,"title":"v4 - Change modal widths to rem units","user":{"login":"Skwai","id":384454,"avatar_url":"https://avatars.githubusercontent.com/u/384454?v=3","gravatar_id":"","url":"https://api.github.com/users/Skwai","html_url":"https://github.com/Skwai","followers_url":"https://api.github.com/users/Skwai/followers","following_url":"https://api.github.com/users/Skwai/following{/other_user}","gists_url":"https://api.github.com/users/Skwai/gists{/gist_id}","starred_url":"https://api.github.com/users/Skwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skwai/subscriptions","organizations_url":"https://api.github.com/users/Skwai/orgs","repos_url":"https://api.github.com/users/Skwai/repos","events_url":"https://api.github.com/users/Skwai/events{/privacy}","received_events_url":"https://api.github.com/users/Skwai/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/twbs/bootstrap/labels/css","name":"css","color":"563d7c"},{"url":"https://api.github.com/repos/twbs/bootstrap/labels/v4","name":"v4","color":"563d7c"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-04T23:02:36Z","updated_at":"2015-11-04T23:20:20Z","closed_at":null,"body":"As everything else is using `rem` units in v4. Perhaps change modal widths from px to rem:\r\n\r\n```\r\n$modal-lg:                    900px !default;\r\n$modal-md:                    600px !default;\r\n$modal-sm:                    300px !default;\r\n```\r\n\r\nAlso, on that note many other elements still have px units such as `$alert-padding`"},"comment":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/153901866","html_url":"https://github.com/twbs/bootstrap/issues/18167#issuecomment-153901866","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/18167","id":153901866,"user":{"login":"Skwai","id":384454,"avatar_url":"https://avatars.githubusercontent.com/u/384454?v=3","gravatar_id":"","url":"https://api.github.com/users/Skwai","html_url":"https://github.com/Skwai","followers_url":"https://api.github.com/users/Skwai/followers","following_url":"https://api.github.com/users/Skwai/following{/other_user}","gists_url":"https://api.github.com/users/Skwai/gists{/gist_id}","starred_url":"https://api.github.com/users/Skwai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Skwai/subscriptions","organizations_url":"https://api.github.com/users/Skwai/orgs","repos_url":"https://api.github.com/users/Skwai/repos","events_url":"https://api.github.com/users/Skwai/events{/privacy}","received_events_url":"https://api.github.com/users/Skwai/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T23:20:20Z","updated_at":"2015-11-04T23:20:20Z","body":"Well that's good news. Was going to post an issue about borders not showing when their widths were calculated as <1px when the root font-size is reduced but it appears that won't be an issue"}}