{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/vignette/pulls/comments/38125049","id":38125049,"diff_hunk":"@@ -38,32 +43,39 @@\n \n (defn create-image-response\n   ([image image-map]\n-   (-> (response (->response-object image))\n-       (header \"Content-Type\" (content-type image))\n-       (header \"Content-Length\" (content-length image))\n-       (header \"ETag\" (etag image))\n-       (header \"X-Thumbnailer\" \"Vignette\")\n-       (add-content-disposition-header image-map)\n-       (add-surrogate-header image-map)))\n+   (as-> (response (->response-object image)) resp","path":"src/vignette/util/image_response.clj","position":23,"original_position":23,"commit_id":"75ef77fd80bbefd16837b16bd7a4a3982eac8fd3","original_commit_id":"75ef77fd80bbefd16837b16bd7a4a3982eac8fd3","user":{"login":"nmonterroso","id":325800,"avatar_url":"https://avatars.githubusercontent.com/u/325800?v=3","gravatar_id":"","url":"https://api.github.com/users/nmonterroso","html_url":"https://github.com/nmonterroso","followers_url":"https://api.github.com/users/nmonterroso/followers","following_url":"https://api.github.com/users/nmonterroso/following{/other_user}","gists_url":"https://api.github.com/users/nmonterroso/gists{/gist_id}","starred_url":"https://api.github.com/users/nmonterroso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmonterroso/subscriptions","organizations_url":"https://api.github.com/users/nmonterroso/orgs","repos_url":"https://api.github.com/users/nmonterroso/repos","events_url":"https://api.github.com/users/nmonterroso/events{/privacy}","received_events_url":"https://api.github.com/users/nmonterroso/received_events","type":"User","site_admin":false},"body":"why change this to use `as->`? from the changes looks like `->` still works","created_at":"2015-08-27T17:53:25Z","updated_at":"2015-08-27T17:53:25Z","html_url":"https://github.com/Wikia/vignette/pull/95#discussion_r38125049","pull_request_url":"https://api.github.com/repos/Wikia/vignette/pulls/95","_links":{"self":{"href":"https://api.github.com/repos/Wikia/vignette/pulls/comments/38125049"},"html":{"href":"https://github.com/Wikia/vignette/pull/95#discussion_r38125049"},"pull_request":{"href":"https://api.github.com/repos/Wikia/vignette/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/vignette/pulls/95","id":41760529,"html_url":"https://github.com/Wikia/vignette/pull/95","diff_url":"https://github.com/Wikia/vignette/pull/95.diff","patch_url":"https://github.com/Wikia/vignette/pull/95.patch","issue_url":"https://api.github.com/repos/Wikia/vignette/issues/95","number":95,"state":"open","locked":false,"title":"PLATFORM-1333 Vignette Static assets support","user":{"login":"pchojnacki","id":812891,"avatar_url":"https://avatars.githubusercontent.com/u/812891?v=3","gravatar_id":"","url":"https://api.github.com/users/pchojnacki","html_url":"https://github.com/pchojnacki","followers_url":"https://api.github.com/users/pchojnacki/followers","following_url":"https://api.github.com/users/pchojnacki/following{/other_user}","gists_url":"https://api.github.com/users/pchojnacki/gists{/gist_id}","starred_url":"https://api.github.com/users/pchojnacki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchojnacki/subscriptions","organizations_url":"https://api.github.com/users/pchojnacki/orgs","repos_url":"https://api.github.com/users/pchojnacki/repos","events_url":"https://api.github.com/users/pchojnacki/events{/privacy}","received_events_url":"https://api.github.com/users/pchojnacki/received_events","type":"User","site_admin":false},"body":"this change implements support for fetching images from Static Assets Service alongside usual images.\r\nAdditionally\r\n* introduces some rudimentary support for finding services using consul.\r\n* refactors routing that constitutes Vignette thumbnailing protocol so it can be reused within other contexts\r\n\r\nTodo:\r\n* [x] add tests to static_assets serving code\r\n* [x] decouple service discovery from static asset","created_at":"2015-08-06T07:52:13Z","updated_at":"2015-08-27T17:53:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1cc5e79e0453b0060387835f87cdb9ff599575f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/vignette/pulls/95/commits","review_comments_url":"https://api.github.com/repos/Wikia/vignette/pulls/95/comments","review_comment_url":"https://api.github.com/repos/Wikia/vignette/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/vignette/issues/95/comments","statuses_url":"https://api.github.com/repos/Wikia/vignette/statuses/75ef77fd80bbefd16837b16bd7a4a3982eac8fd3","head":{"label":"Wikia:routing_Refactoring_wip","ref":"routing_Refactoring_wip","sha":"75ef77fd80bbefd16837b16bd7a4a3982eac8fd3","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":20943477,"name":"vignette","full_name":"Wikia/vignette","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/vignette","description":"A Clojure library for thumbnail generation and storage.","fork":false,"url":"https://api.github.com/repos/Wikia/vignette","forks_url":"https://api.github.com/repos/Wikia/vignette/forks","keys_url":"https://api.github.com/repos/Wikia/vignette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/vignette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/vignette/teams","hooks_url":"https://api.github.com/repos/Wikia/vignette/hooks","issue_events_url":"https://api.github.com/repos/Wikia/vignette/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/vignette/events","assignees_url":"https://api.github.com/repos/Wikia/vignette/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/vignette/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/vignette/tags","blobs_url":"https://api.github.com/repos/Wikia/vignette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/vignette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/vignette/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/vignette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/vignette/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/vignette/languages","stargazers_url":"https://api.github.com/repos/Wikia/vignette/stargazers","contributors_url":"https://api.github.com/repos/Wikia/vignette/contributors","subscribers_url":"https://api.github.com/repos/Wikia/vignette/subscribers","subscription_url":"https://api.github.com/repos/Wikia/vignette/subscription","commits_url":"https://api.github.com/repos/Wikia/vignette/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/vignette/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/vignette/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/vignette/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/vignette/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/vignette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/vignette/merges","archive_url":"https://api.github.com/repos/Wikia/vignette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/vignette/downloads","issues_url":"https://api.github.com/repos/Wikia/vignette/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/vignette/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/vignette/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/vignette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/vignette/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/vignette/releases{/id}","created_at":"2014-06-18T00:02:46Z","updated_at":"2015-08-08T07:39:08Z","pushed_at":"2015-08-27T11:32:15Z","git_url":"git://github.com/Wikia/vignette.git","ssh_url":"git@github.com:Wikia/vignette.git","clone_url":"https://github.com/Wikia/vignette.git","svn_url":"https://github.com/Wikia/vignette","homepage":"https://github.com/Wikia/vignette","size":27463,"stargazers_count":9,"watchers_count":9,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":9,"default_branch":"master"}},"base":{"label":"Wikia:master","ref":"master","sha":"4ee0b4787b25093feddc5adf5322fe1198527a29","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":20943477,"name":"vignette","full_name":"Wikia/vignette","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/vignette","description":"A Clojure library for thumbnail generation and storage.","fork":false,"url":"https://api.github.com/repos/Wikia/vignette","forks_url":"https://api.github.com/repos/Wikia/vignette/forks","keys_url":"https://api.github.com/repos/Wikia/vignette/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/vignette/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/vignette/teams","hooks_url":"https://api.github.com/repos/Wikia/vignette/hooks","issue_events_url":"https://api.github.com/repos/Wikia/vignette/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/vignette/events","assignees_url":"https://api.github.com/repos/Wikia/vignette/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/vignette/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/vignette/tags","blobs_url":"https://api.github.com/repos/Wikia/vignette/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/vignette/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/vignette/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/vignette/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/vignette/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/vignette/languages","stargazers_url":"https://api.github.com/repos/Wikia/vignette/stargazers","contributors_url":"https://api.github.com/repos/Wikia/vignette/contributors","subscribers_url":"https://api.github.com/repos/Wikia/vignette/subscribers","subscription_url":"https://api.github.com/repos/Wikia/vignette/subscription","commits_url":"https://api.github.com/repos/Wikia/vignette/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/vignette/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/vignette/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/vignette/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/vignette/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/vignette/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/vignette/merges","archive_url":"https://api.github.com/repos/Wikia/vignette/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/vignette/downloads","issues_url":"https://api.github.com/repos/Wikia/vignette/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/vignette/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/vignette/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/vignette/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/vignette/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/vignette/releases{/id}","created_at":"2014-06-18T00:02:46Z","updated_at":"2015-08-08T07:39:08Z","pushed_at":"2015-08-27T11:32:15Z","git_url":"git://github.com/Wikia/vignette.git","ssh_url":"git@github.com:Wikia/vignette.git","clone_url":"https://github.com/Wikia/vignette.git","svn_url":"https://github.com/Wikia/vignette","homepage":"https://github.com/Wikia/vignette","size":27463,"stargazers_count":9,"watchers_count":9,"language":"Clojure","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/vignette/pulls/95"},"html":{"href":"https://github.com/Wikia/vignette/pull/95"},"issue":{"href":"https://api.github.com/repos/Wikia/vignette/issues/95"},"comments":{"href":"https://api.github.com/repos/Wikia/vignette/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/vignette/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/vignette/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/vignette/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/vignette/statuses/75ef77fd80bbefd16837b16bd7a4a3982eac8fd3"}}}}