{"action":"created","comment":{"url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/comments/34423606","id":34423606,"diff_hunk":"@@ -21,6 +21,27 @@ void VerticesNtuplizer::fillBranches( edm::Event const & event, const edm::Event\n \n   event.getByToken(vtxToken_, vertices_);\n     \n-  nBranches_->nPVs = vertices_->size();\n+  nBranches_->PV_N = vertices_->size();\n+  \n+  nBranches_->PV_filter = true;\n+  \n+  reco::VertexCollection::const_iterator firstGoodVertex = vertices_->end();\n+  int firstGoodVertexIdx = 0;\n+  for( reco::VertexCollection::const_iterator vtx = vertices_->begin(); vtx != vertices_->end(); ++vtx, ++firstGoodVertexIdx){\n+  \n+    nBranches_->PV_chi2.push_back(vtx->chi2());\n+    nBranches_->PV_ndof.push_back(vtx->ndof());\n+    nBranches_->PV_rho.push_back(vtx->position().Rho());\n+    nBranches_->PV_z.push_back(vtx->position().Z());\n+    ","path":"Ntuplizer/plugins/VerticesNtuplizer.cc","position":17,"original_position":17,"commit_id":"8eeb70b976ac78af7f011a2bb0486e159b9a43f1","original_commit_id":"8eeb70b976ac78af7f011a2bb0486e159b9a43f1","user":{"login":"clelange","id":5270053,"avatar_url":"https://avatars.githubusercontent.com/u/5270053?v=3","gravatar_id":"","url":"https://api.github.com/users/clelange","html_url":"https://github.com/clelange","followers_url":"https://api.github.com/users/clelange/followers","following_url":"https://api.github.com/users/clelange/following{/other_user}","gists_url":"https://api.github.com/users/clelange/gists{/gist_id}","starred_url":"https://api.github.com/users/clelange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clelange/subscriptions","organizations_url":"https://api.github.com/users/clelange/orgs","repos_url":"https://api.github.com/users/clelange/repos","events_url":"https://api.github.com/users/clelange/events{/privacy}","received_events_url":"https://api.github.com/users/clelange/received_events","type":"User","site_admin":false},"body":"Could add a branch PV_isGood here to make analysis faster.","created_at":"2015-07-12T17:31:30Z","updated_at":"2015-07-12T17:31:30Z","html_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII/pull/40#discussion_r34423606","pull_request_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/comments/34423606"},"html":{"href":"https://github.com/UZHCMS/EXOVVNtuplizerRunII/pull/40#discussion_r34423606"},"pull_request":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40","id":39760749,"html_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII/pull/40","diff_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII/pull/40.diff","patch_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII/pull/40.patch","issue_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues/40","number":40,"state":"open","locked":false,"title":"updated json file,removed individual HLT trigger flags and added inst…","user":{"login":"jngadiub","id":5583089,"avatar_url":"https://avatars.githubusercontent.com/u/5583089?v=3","gravatar_id":"","url":"https://api.github.com/users/jngadiub","html_url":"https://github.com/jngadiub","followers_url":"https://api.github.com/users/jngadiub/followers","following_url":"https://api.github.com/users/jngadiub/following{/other_user}","gists_url":"https://api.github.com/users/jngadiub/gists{/gist_id}","starred_url":"https://api.github.com/users/jngadiub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jngadiub/subscriptions","organizations_url":"https://api.github.com/users/jngadiub/orgs","repos_url":"https://api.github.com/users/jngadiub/repos","events_url":"https://api.github.com/users/jngadiub/events{/privacy}","received_events_url":"https://api.github.com/users/jngadiub/received_events","type":"User","site_admin":false},"body":"* updated json file with the latest version\r\n* removed individual HLT trigger flags and added instead a map<string,bool> with all useful triggers (HLT_isFired[\"trigname\"] = false/true)\r\n* added skip event if no PV are found\r\n* now use first good PV for lepton ID variables according to recommended quality requirements and added to the tree a flag (\"PV_filter\") which is true if a good PV is found according to the same requirements\r\n* added to the tree PV variables for PVs quality requirements (chi2/ndof/...)\r\n* changed variable name : nPVs  ---> PV_N\r\n* added the possibility to run data jobs on DAS files containing one specific run (added \"run\" configuration option to submitJobsOnT3batch.cfg, default is run = -1)","created_at":"2015-07-12T11:43:07Z","updated_at":"2015-07-12T17:31:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d07ab9ba5062bc832864df5ecfeecfb1d424e19","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40/commits","review_comments_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40/comments","review_comment_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues/40/comments","statuses_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/statuses/8eeb70b976ac78af7f011a2bb0486e159b9a43f1","head":{"label":"jngadiub:CMSSW_7_4_X","ref":"CMSSW_7_4_X","sha":"8eeb70b976ac78af7f011a2bb0486e159b9a43f1","user":{"login":"jngadiub","id":5583089,"avatar_url":"https://avatars.githubusercontent.com/u/5583089?v=3","gravatar_id":"","url":"https://api.github.com/users/jngadiub","html_url":"https://github.com/jngadiub","followers_url":"https://api.github.com/users/jngadiub/followers","following_url":"https://api.github.com/users/jngadiub/following{/other_user}","gists_url":"https://api.github.com/users/jngadiub/gists{/gist_id}","starred_url":"https://api.github.com/users/jngadiub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jngadiub/subscriptions","organizations_url":"https://api.github.com/users/jngadiub/orgs","repos_url":"https://api.github.com/users/jngadiub/repos","events_url":"https://api.github.com/users/jngadiub/events{/privacy}","received_events_url":"https://api.github.com/users/jngadiub/received_events","type":"User","site_admin":false},"repo":{"id":30233879,"name":"EXOVVNtuplizerRunII","full_name":"jngadiub/EXOVVNtuplizerRunII","owner":{"login":"jngadiub","id":5583089,"avatar_url":"https://avatars.githubusercontent.com/u/5583089?v=3","gravatar_id":"","url":"https://api.github.com/users/jngadiub","html_url":"https://github.com/jngadiub","followers_url":"https://api.github.com/users/jngadiub/followers","following_url":"https://api.github.com/users/jngadiub/following{/other_user}","gists_url":"https://api.github.com/users/jngadiub/gists{/gist_id}","starred_url":"https://api.github.com/users/jngadiub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jngadiub/subscriptions","organizations_url":"https://api.github.com/users/jngadiub/orgs","repos_url":"https://api.github.com/users/jngadiub/repos","events_url":"https://api.github.com/users/jngadiub/events{/privacy}","received_events_url":"https://api.github.com/users/jngadiub/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jngadiub/EXOVVNtuplizerRunII","description":"Ntuplizer for VV->lvj/jj","fork":true,"url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII","forks_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/forks","keys_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/teams","hooks_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/hooks","issue_events_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/issues/events{/number}","events_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/events","assignees_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/assignees{/user}","branches_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/branches{/branch}","tags_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/tags","blobs_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/git/refs{/sha}","trees_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/statuses/{sha}","languages_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/languages","stargazers_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/stargazers","contributors_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/contributors","subscribers_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/subscribers","subscription_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/subscription","commits_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/commits{/sha}","git_commits_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/git/commits{/sha}","comments_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/comments{/number}","issue_comment_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/issues/comments{/number}","contents_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/contents/{+path}","compare_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/merges","archive_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/downloads","issues_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/issues{/number}","pulls_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/pulls{/number}","milestones_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/milestones{/number}","notifications_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/labels{/name}","releases_url":"https://api.github.com/repos/jngadiub/EXOVVNtuplizerRunII/releases{/id}","created_at":"2015-02-03T08:59:44Z","updated_at":"2015-03-19T10:23:10Z","pushed_at":"2015-07-12T11:32:21Z","git_url":"git://github.com/jngadiub/EXOVVNtuplizerRunII.git","ssh_url":"git@github.com:jngadiub/EXOVVNtuplizerRunII.git","clone_url":"https://github.com/jngadiub/EXOVVNtuplizerRunII.git","svn_url":"https://github.com/jngadiub/EXOVVNtuplizerRunII","homepage":null,"size":2421,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"UZHCMS:master","ref":"master","sha":"f711599da6faafadd91bb58b5e843b21da921de0","user":{"login":"UZHCMS","id":11009164,"avatar_url":"https://avatars.githubusercontent.com/u/11009164?v=3","gravatar_id":"","url":"https://api.github.com/users/UZHCMS","html_url":"https://github.com/UZHCMS","followers_url":"https://api.github.com/users/UZHCMS/followers","following_url":"https://api.github.com/users/UZHCMS/following{/other_user}","gists_url":"https://api.github.com/users/UZHCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/UZHCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UZHCMS/subscriptions","organizations_url":"https://api.github.com/users/UZHCMS/orgs","repos_url":"https://api.github.com/users/UZHCMS/repos","events_url":"https://api.github.com/users/UZHCMS/events{/privacy}","received_events_url":"https://api.github.com/users/UZHCMS/received_events","type":"Organization","site_admin":false},"repo":{"id":30039475,"name":"EXOVVNtuplizerRunII","full_name":"UZHCMS/EXOVVNtuplizerRunII","owner":{"login":"UZHCMS","id":11009164,"avatar_url":"https://avatars.githubusercontent.com/u/11009164?v=3","gravatar_id":"","url":"https://api.github.com/users/UZHCMS","html_url":"https://github.com/UZHCMS","followers_url":"https://api.github.com/users/UZHCMS/followers","following_url":"https://api.github.com/users/UZHCMS/following{/other_user}","gists_url":"https://api.github.com/users/UZHCMS/gists{/gist_id}","starred_url":"https://api.github.com/users/UZHCMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UZHCMS/subscriptions","organizations_url":"https://api.github.com/users/UZHCMS/orgs","repos_url":"https://api.github.com/users/UZHCMS/repos","events_url":"https://api.github.com/users/UZHCMS/events{/privacy}","received_events_url":"https://api.github.com/users/UZHCMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII","description":"Ntuplizer for VV->lvj/jj","fork":false,"url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII","forks_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/forks","keys_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/teams","hooks_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/hooks","issue_events_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues/events{/number}","events_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/events","assignees_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/assignees{/user}","branches_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/branches{/branch}","tags_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/tags","blobs_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/git/refs{/sha}","trees_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/statuses/{sha}","languages_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/languages","stargazers_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/stargazers","contributors_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/contributors","subscribers_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/subscribers","subscription_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/subscription","commits_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/commits{/sha}","git_commits_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/git/commits{/sha}","comments_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/comments{/number}","issue_comment_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues/comments{/number}","contents_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/contents/{+path}","compare_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/merges","archive_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/downloads","issues_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues{/number}","pulls_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls{/number}","milestones_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/milestones{/number}","notifications_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/labels{/name}","releases_url":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/releases{/id}","created_at":"2015-01-29T20:23:47Z","updated_at":"2015-03-10T16:12:30Z","pushed_at":"2015-07-12T11:43:07Z","git_url":"git://github.com/UZHCMS/EXOVVNtuplizerRunII.git","ssh_url":"git@github.com:UZHCMS/EXOVVNtuplizerRunII.git","clone_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII.git","svn_url":"https://github.com/UZHCMS/EXOVVNtuplizerRunII","homepage":null,"size":2719,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40"},"html":{"href":"https://github.com/UZHCMS/EXOVVNtuplizerRunII/pull/40"},"issue":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues/40"},"comments":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/UZHCMS/EXOVVNtuplizerRunII/statuses/8eeb70b976ac78af7f011a2bb0486e159b9a43f1"}}}}