{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/tools/pulls/comments/42929932","id":42929932,"diff_hunk":"@@ -64,6 +64,12 @@ String runCheckedSync(List<String> cmd) =>\n /// Run cmd and return stdout.\n String runSync(List<String> cmd) => _runWithLoggingSync(cmd);\n \n+/// Return the platform specific name for the given Dart SDK binary. So, `pub`\n+/// ==> `pub.bat`.\n+String sdkBinaryName(String name) {\n+  return Platform.isWindows ? '${name}.bat' : name;\n+}","path":"lib/src/process.dart","position":8,"original_position":8,"commit_id":"9fe2180b40ea9899f3e3922990cdd290d6705416","original_commit_id":"9fe2180b40ea9899f3e3922990cdd290d6705416","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?v=3","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"I'll confirm that and remove if its not needed -","created_at":"2015-10-24T03:56:39Z","updated_at":"2015-10-24T03:56:39Z","html_url":"https://github.com/flutter/tools/pull/125#discussion_r42929932","pull_request_url":"https://api.github.com/repos/flutter/tools/pulls/125","_links":{"self":{"href":"https://api.github.com/repos/flutter/tools/pulls/comments/42929932"},"html":{"href":"https://github.com/flutter/tools/pull/125#discussion_r42929932"},"pull_request":{"href":"https://api.github.com/repos/flutter/tools/pulls/125"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/tools/pulls/125","id":48639592,"html_url":"https://github.com/flutter/tools/pull/125","diff_url":"https://github.com/flutter/tools/pull/125.diff","patch_url":"https://github.com/flutter/tools/pull/125.patch","issue_url":"https://api.github.com/repos/flutter/tools/issues/125","number":125,"state":"open","locked":false,"title":"fix tests on windows","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?v=3","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"Related to https://github.com/flutter/tools/issues/36, fix two tests - our tests now pass on windows.\r\n\r\n@abarth, fyi @TheBosZ ","created_at":"2015-10-23T23:02:18Z","updated_at":"2015-10-24T03:56:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1bb0e23cc5ea56e531b23c3246fb38d306c70ae5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flutter/tools/pulls/125/commits","review_comments_url":"https://api.github.com/repos/flutter/tools/pulls/125/comments","review_comment_url":"https://api.github.com/repos/flutter/tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/tools/issues/125/comments","statuses_url":"https://api.github.com/repos/flutter/tools/statuses/9fe2180b40ea9899f3e3922990cdd290d6705416","head":{"label":"flutter:windows_tests","ref":"windows_tests","sha":"9fe2180b40ea9899f3e3922990cdd290d6705416","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39414832,"name":"tools","full_name":"flutter/tools","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/tools","description":"Tools for building Flutter applications","fork":false,"url":"https://api.github.com/repos/flutter/tools","forks_url":"https://api.github.com/repos/flutter/tools/forks","keys_url":"https://api.github.com/repos/flutter/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/tools/teams","hooks_url":"https://api.github.com/repos/flutter/tools/hooks","issue_events_url":"https://api.github.com/repos/flutter/tools/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/tools/events","assignees_url":"https://api.github.com/repos/flutter/tools/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/tools/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/tools/tags","blobs_url":"https://api.github.com/repos/flutter/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/tools/languages","stargazers_url":"https://api.github.com/repos/flutter/tools/stargazers","contributors_url":"https://api.github.com/repos/flutter/tools/contributors","subscribers_url":"https://api.github.com/repos/flutter/tools/subscribers","subscription_url":"https://api.github.com/repos/flutter/tools/subscription","commits_url":"https://api.github.com/repos/flutter/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/tools/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/tools/merges","archive_url":"https://api.github.com/repos/flutter/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/tools/downloads","issues_url":"https://api.github.com/repos/flutter/tools/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/tools/labels{/name}","releases_url":"https://api.github.com/repos/flutter/tools/releases{/id}","created_at":"2015-07-21T00:19:47Z","updated_at":"2015-10-23T16:09:55Z","pushed_at":"2015-10-23T23:33:20Z","git_url":"git://github.com/flutter/tools.git","ssh_url":"git@github.com:flutter/tools.git","clone_url":"https://github.com/flutter/tools.git","svn_url":"https://github.com/flutter/tools","homepage":"","size":1096,"stargazers_count":3,"watchers_count":3,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":18,"forks":11,"open_issues":18,"watchers":3,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"5be4edbef9c3f4d73d9c4d3de0e6b44723419465","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":39414832,"name":"tools","full_name":"flutter/tools","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars.githubusercontent.com/u/14101776?v=3","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/tools","description":"Tools for building Flutter applications","fork":false,"url":"https://api.github.com/repos/flutter/tools","forks_url":"https://api.github.com/repos/flutter/tools/forks","keys_url":"https://api.github.com/repos/flutter/tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/tools/teams","hooks_url":"https://api.github.com/repos/flutter/tools/hooks","issue_events_url":"https://api.github.com/repos/flutter/tools/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/tools/events","assignees_url":"https://api.github.com/repos/flutter/tools/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/tools/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/tools/tags","blobs_url":"https://api.github.com/repos/flutter/tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/tools/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/tools/languages","stargazers_url":"https://api.github.com/repos/flutter/tools/stargazers","contributors_url":"https://api.github.com/repos/flutter/tools/contributors","subscribers_url":"https://api.github.com/repos/flutter/tools/subscribers","subscription_url":"https://api.github.com/repos/flutter/tools/subscription","commits_url":"https://api.github.com/repos/flutter/tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/tools/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/tools/merges","archive_url":"https://api.github.com/repos/flutter/tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/tools/downloads","issues_url":"https://api.github.com/repos/flutter/tools/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/tools/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/tools/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/tools/labels{/name}","releases_url":"https://api.github.com/repos/flutter/tools/releases{/id}","created_at":"2015-07-21T00:19:47Z","updated_at":"2015-10-23T16:09:55Z","pushed_at":"2015-10-23T23:33:20Z","git_url":"git://github.com/flutter/tools.git","ssh_url":"git@github.com:flutter/tools.git","clone_url":"https://github.com/flutter/tools.git","svn_url":"https://github.com/flutter/tools","homepage":"","size":1096,"stargazers_count":3,"watchers_count":3,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":18,"forks":11,"open_issues":18,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/tools/pulls/125"},"html":{"href":"https://github.com/flutter/tools/pull/125"},"issue":{"href":"https://api.github.com/repos/flutter/tools/issues/125"},"comments":{"href":"https://api.github.com/repos/flutter/tools/issues/125/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/tools/pulls/125/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/tools/pulls/125/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/tools/statuses/9fe2180b40ea9899f3e3922990cdd290d6705416"}}}}