{"action":"created","comment":{"url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments/48415680","id":48415680,"diff_hunk":"@@ -69,82 +65,65 @@ sync_primitives::RWLock::~RWLock() {\n   delete impl_;\n }\n \n-bool sync_primitives::RWLock::AcquireForReading() {\n-  return impl_->AcquireForReading();\n+void sync_primitives::RWLock::AcquireForReading() {\n+  impl_->AcquireForReading();\n }\n \n bool sync_primitives::RWLock::TryAcquireForReading() {\n   return impl_->TryAcquireForReading();\n }\n \n-bool sync_primitives::RWLock::AcquireForWriting() {\n-  return impl_->AcquireForWriting();\n+void sync_primitives::RWLock::AcquireForWriting() {\n+  impl_->AcquireForWriting();\n }\n \n bool sync_primitives::RWLock::TryAcquireForWriting() {\n   return impl_->TryAcquireForWriting();\n }\n \n-bool sync_primitives::RWLock::Release() {\n-  return impl_->Release();\n+void sync_primitives::RWLock::ReleaseForReading() {\n+  impl_->ReleaseForReading();\n+}\n+\n+void sync_primitives::RWLock::ReleaseForWriting() {\n+  impl_->ReleaseForWriting();\n }\n \n-sync_primitives::RWLock::Impl::Impl()\n-  : status_(kNotAcquired) {\n+sync_primitives::RWLock::Impl::Impl() {\n   InitializeSRWLock(&rwlock_);\n }\n \n sync_primitives::RWLock::Impl::~Impl() {\n-  sync_primitives::AutoLock lock(status_lock_);\n-  if (kNotAcquired != status_) {\n-    LOG4CXX_ERROR(logger_, \"RWLock is acquired\");\n-  }\n }\n \n-bool sync_primitives::RWLock::Impl::AcquireForReading() {\n-  sync_primitives::AutoLock lock(status_lock_);\n+void sync_primitives::RWLock::Impl::AcquireForReading() {\n   AcquireSRWLockShared(&rwlock_);\n-  status_ = kAcquiredForReading;\n-  return true;\n }\n \n bool sync_primitives::RWLock::Impl::TryAcquireForReading() {\n-  sync_primitives::AutoLock lock(status_lock_);\n   if (!TryAcquireSRWLockShared(&rwlock_)) {\n     LOG4CXX_WARN(logger_, \"Failed to acquire rwlock for reading\");\n     return false;\n   }\n-  status_ = kAcquiredForReading;\n   return true;\n }\n \n-bool sync_primitives::RWLock::Impl::AcquireForWriting() {\n-  sync_primitives::AutoLock lock(status_lock_);\n+void sync_primitives::RWLock::Impl::AcquireForWriting() {\n   AcquireSRWLockExclusive(&rwlock_);\n-  status_ = kAcquiredForWriting;\n-  return true;\n }\n \n bool sync_primitives::RWLock::Impl::TryAcquireForWriting() {\n-  sync_primitives::AutoLock lock(status_lock_);\n   if (!TryAcquireSRWLockExclusive(&rwlock_)) {\n     LOG4CXX_WARN(logger_, \"Failed to acquire rwlock for writing\");","path":"src/components/utils/src/rwlock_win.cc","position":106,"original_position":106,"commit_id":"a879cee7ae31ebfc8b7b669c1b21c9e08b939f29","original_commit_id":"a879cee7ae31ebfc8b7b669c1b21c9e08b939f29","user":{"login":"malirod","id":1135245,"avatar_url":"https://avatars.githubusercontent.com/u/1135245?v=3","gravatar_id":"","url":"https://api.github.com/users/malirod","html_url":"https://github.com/malirod","followers_url":"https://api.github.com/users/malirod/followers","following_url":"https://api.github.com/users/malirod/following{/other_user}","gists_url":"https://api.github.com/users/malirod/gists{/gist_id}","starred_url":"https://api.github.com/users/malirod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/malirod/subscriptions","organizations_url":"https://api.github.com/users/malirod/orgs","repos_url":"https://api.github.com/users/malirod/repos","events_url":"https://api.github.com/users/malirod/events{/privacy}","received_events_url":"https://api.github.com/users/malirod/received_events","type":"User","site_admin":false},"body":"@pestOO, please, describe your vision of this situation. this PR is already merged. how we should react on your comment in such case?","created_at":"2015-12-24T14:02:06Z","updated_at":"2015-12-24T14:02:06Z","html_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/56#discussion_r48415680","pull_request_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments/48415680"},"html":{"href":"https://github.com/LuxoftSDL/sdl_core_winport/pull/56#discussion_r48415680"},"pull_request":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56","id":54362390,"html_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/56","diff_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/56.diff","patch_url":"https://github.com/LuxoftSDL/sdl_core_winport/pull/56.patch","issue_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/56","number":56,"state":"closed","locked":false,"title":"Separate ReleaseForReading() and ReleaseForWriting() methods for RWLock","user":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-22T12:01:13Z","updated_at":"2015-12-24T14:02:06Z","closed_at":"2015-12-23T07:57:41Z","merged_at":"2015-12-23T07:57:41Z","merge_commit_sha":"2d884d55af7c0a5995a8e95bcbbf60f12e86c5f2","assignee":{"login":"AGaliuzov","id":11158516,"avatar_url":"https://avatars.githubusercontent.com/u/11158516?v=3","gravatar_id":"","url":"https://api.github.com/users/AGaliuzov","html_url":"https://github.com/AGaliuzov","followers_url":"https://api.github.com/users/AGaliuzov/followers","following_url":"https://api.github.com/users/AGaliuzov/following{/other_user}","gists_url":"https://api.github.com/users/AGaliuzov/gists{/gist_id}","starred_url":"https://api.github.com/users/AGaliuzov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AGaliuzov/subscriptions","organizations_url":"https://api.github.com/users/AGaliuzov/orgs","repos_url":"https://api.github.com/users/AGaliuzov/repos","events_url":"https://api.github.com/users/AGaliuzov/events{/privacy}","received_events_url":"https://api.github.com/users/AGaliuzov/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56/commits","review_comments_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56/comments","review_comment_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/56/comments","statuses_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/statuses/a879cee7ae31ebfc8b7b669c1b21c9e08b939f29","head":{"label":"anosach-luxoft:fix/RWLock-release","ref":"fix/RWLock-release","sha":"a879cee7ae31ebfc8b7b669c1b21c9e08b939f29","user":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"repo":{"id":44157837,"name":"sdl_core_winport","full_name":"anosach-luxoft/sdl_core_winport","owner":{"login":"anosach-luxoft","id":11158680,"avatar_url":"https://avatars.githubusercontent.com/u/11158680?v=3","gravatar_id":"","url":"https://api.github.com/users/anosach-luxoft","html_url":"https://github.com/anosach-luxoft","followers_url":"https://api.github.com/users/anosach-luxoft/followers","following_url":"https://api.github.com/users/anosach-luxoft/following{/other_user}","gists_url":"https://api.github.com/users/anosach-luxoft/gists{/gist_id}","starred_url":"https://api.github.com/users/anosach-luxoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anosach-luxoft/subscriptions","organizations_url":"https://api.github.com/users/anosach-luxoft/orgs","repos_url":"https://api.github.com/users/anosach-luxoft/repos","events_url":"https://api.github.com/users/anosach-luxoft/events{/privacy}","received_events_url":"https://api.github.com/users/anosach-luxoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anosach-luxoft/sdl_core_winport","description":"","fork":true,"url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport","forks_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/forks","keys_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/teams","hooks_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/hooks","issue_events_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/issues/events{/number}","events_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/events","assignees_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/assignees{/user}","branches_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/branches{/branch}","tags_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/tags","blobs_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/refs{/sha}","trees_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/statuses/{sha}","languages_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/languages","stargazers_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/stargazers","contributors_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/contributors","subscribers_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/subscribers","subscription_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/subscription","commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/commits{/sha}","git_commits_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/git/commits{/sha}","comments_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/comments{/number}","issue_comment_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/issues/comments{/number}","contents_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/contents/{+path}","compare_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/merges","archive_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/downloads","issues_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/issues{/number}","pulls_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/pulls{/number}","milestones_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/milestones{/number}","notifications_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/labels{/name}","releases_url":"https://api.github.com/repos/anosach-luxoft/sdl_core_winport/releases{/id}","created_at":"2015-10-13T06:55:03Z","updated_at":"2015-10-13T06:55:14Z","pushed_at":"2015-12-24T12:01:29Z","git_url":"git://github.com/anosach-luxoft/sdl_core_winport.git","ssh_url":"git@github.com:anosach-luxoft/sdl_core_winport.git","clone_url":"https://github.com/anosach-luxoft/sdl_core_winport.git","svn_url":"https://github.com/anosach-luxoft/sdl_core_winport","homepage":null,"size":17139,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LuxoftSDL:develop","ref":"develop","sha":"6df7cf39b26ee3b515964d0e76b5bdb1dd65b9a6","user":{"login":"LuxoftSDL","id":11190760,"avatar_url":"https://avatars.githubusercontent.com/u/11190760?v=3","gravatar_id":"","url":"https://api.github.com/users/LuxoftSDL","html_url":"https://github.com/LuxoftSDL","followers_url":"https://api.github.com/users/LuxoftSDL/followers","following_url":"https://api.github.com/users/LuxoftSDL/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftSDL/subscriptions","organizations_url":"https://api.github.com/users/LuxoftSDL/orgs","repos_url":"https://api.github.com/users/LuxoftSDL/repos","events_url":"https://api.github.com/users/LuxoftSDL/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftSDL/received_events","type":"Organization","site_admin":false},"repo":{"id":44124645,"name":"sdl_core_winport","full_name":"LuxoftSDL/sdl_core_winport","owner":{"login":"LuxoftSDL","id":11190760,"avatar_url":"https://avatars.githubusercontent.com/u/11190760?v=3","gravatar_id":"","url":"https://api.github.com/users/LuxoftSDL","html_url":"https://github.com/LuxoftSDL","followers_url":"https://api.github.com/users/LuxoftSDL/followers","following_url":"https://api.github.com/users/LuxoftSDL/following{/other_user}","gists_url":"https://api.github.com/users/LuxoftSDL/gists{/gist_id}","starred_url":"https://api.github.com/users/LuxoftSDL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LuxoftSDL/subscriptions","organizations_url":"https://api.github.com/users/LuxoftSDL/orgs","repos_url":"https://api.github.com/users/LuxoftSDL/repos","events_url":"https://api.github.com/users/LuxoftSDL/events{/privacy}","received_events_url":"https://api.github.com/users/LuxoftSDL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LuxoftSDL/sdl_core_winport","description":"","fork":false,"url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport","forks_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/forks","keys_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/teams","hooks_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/hooks","issue_events_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/events{/number}","events_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/events","assignees_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/assignees{/user}","branches_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/branches{/branch}","tags_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/tags","blobs_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/refs{/sha}","trees_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/statuses/{sha}","languages_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/languages","stargazers_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/stargazers","contributors_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/contributors","subscribers_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/subscribers","subscription_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/subscription","commits_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/commits{/sha}","git_commits_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/git/commits{/sha}","comments_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/comments{/number}","issue_comment_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/comments{/number}","contents_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/contents/{+path}","compare_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/merges","archive_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/downloads","issues_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues{/number}","pulls_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls{/number}","milestones_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/milestones{/number}","notifications_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/labels{/name}","releases_url":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/releases{/id}","created_at":"2015-10-12T17:59:45Z","updated_at":"2015-10-12T18:08:33Z","pushed_at":"2015-12-24T13:05:14Z","git_url":"git://github.com/LuxoftSDL/sdl_core_winport.git","ssh_url":"git@github.com:LuxoftSDL/sdl_core_winport.git","clone_url":"https://github.com/LuxoftSDL/sdl_core_winport.git","svn_url":"https://github.com/LuxoftSDL/sdl_core_winport","homepage":null,"size":17424,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56"},"html":{"href":"https://github.com/LuxoftSDL/sdl_core_winport/pull/56"},"issue":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/56"},"comments":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/LuxoftSDL/sdl_core_winport/statuses/a879cee7ae31ebfc8b7b669c1b21c9e08b939f29"}}}}