{"action":"created","issue":{"url":"https://api.github.com/repos/owncloud/core/issues/13509","labels_url":"https://api.github.com/repos/owncloud/core/issues/13509/labels{/name}","comments_url":"https://api.github.com/repos/owncloud/core/issues/13509/comments","events_url":"https://api.github.com/repos/owncloud/core/issues/13509/events","html_url":"https://github.com/owncloud/core/pull/13509","id":54875813,"number":13509,"title":"Fix reshare permission change to not impair other deletion code","user":{"login":"PVince81","id":277525,"avatar_url":"https://avatars.githubusercontent.com/u/277525?v=3","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/owncloud/core/labels/5+-+To+review","name":"5 - To review","color":"ededed"},{"url":"https://api.github.com/repos/owncloud/core/labels/ownCloud+8.0+Showstoppers","name":"ownCloud 8.0 Showstoppers","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/core/milestones/29","labels_url":"https://api.github.com/repos/owncloud/core/milestones/29/labels","id":841322,"number":29,"title":"8.0-current","description":null,"creator":{"login":"craigpg","id":160667,"avatar_url":"https://avatars.githubusercontent.com/u/160667?v=3","gravatar_id":"","url":"https://api.github.com/users/craigpg","html_url":"https://github.com/craigpg","followers_url":"https://api.github.com/users/craigpg/followers","following_url":"https://api.github.com/users/craigpg/following{/other_user}","gists_url":"https://api.github.com/users/craigpg/gists{/gist_id}","starred_url":"https://api.github.com/users/craigpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigpg/subscriptions","organizations_url":"https://api.github.com/users/craigpg/orgs","repos_url":"https://api.github.com/users/craigpg/repos","events_url":"https://api.github.com/users/craigpg/events{/privacy}","received_events_url":"https://api.github.com/users/craigpg/received_events","type":"User","site_admin":false},"open_issues":36,"closed_issues":636,"state":"open","created_at":"2014-10-27T01:20:05Z","updated_at":"2015-01-21T23:41:48Z","due_on":"2015-01-02T22:00:00Z","closed_at":null},"comments":2,"created_at":"2015-01-20T12:11:02Z","updated_at":"2015-01-22T09:13:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/owncloud/core/pulls/13509","html_url":"https://github.com/owncloud/core/pull/13509","diff_url":"https://github.com/owncloud/core/pull/13509.diff","patch_url":"https://github.com/owncloud/core/pull/13509.patch"},"body":"A recent change that prevents reshare permission changes to delete group\r\nshare children had the side-effect of also preventing group share\r\nchildren deletion when it needed to be done.\r\n\r\nThis fix adds an extra flag to isolate the \"reshare permission change\"\r\ndeletion case and keep the other ones as they were before, not only to\r\nfix the regression but also fix other potential regressions in code that\r\nuses this method.\r\n\r\nAlso updated the comment because now Helper::delete() is no longer\r\nlimited to reshares but also applies to group share children.\r\n\r\nFixes https://github.com/owncloud/core/issues/13445\r\n\r\nPlease review @schiesbn @icewind1991 @DeepDiver1975 @MorrisJobke "},"comment":{"url":"https://api.github.com/repos/owncloud/core/issues/comments/70991232","html_url":"https://github.com/owncloud/core/pull/13509#issuecomment-70991232","issue_url":"https://api.github.com/repos/owncloud/core/issues/13509","id":70991232,"user":{"login":"scrutinizer-notifier","id":6398257,"avatar_url":"https://avatars.githubusercontent.com/u/6398257?v=3","gravatar_id":"","url":"https://api.github.com/users/scrutinizer-notifier","html_url":"https://github.com/scrutinizer-notifier","followers_url":"https://api.github.com/users/scrutinizer-notifier/followers","following_url":"https://api.github.com/users/scrutinizer-notifier/following{/other_user}","gists_url":"https://api.github.com/users/scrutinizer-notifier/gists{/gist_id}","starred_url":"https://api.github.com/users/scrutinizer-notifier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrutinizer-notifier/subscriptions","organizations_url":"https://api.github.com/users/scrutinizer-notifier/orgs","repos_url":"https://api.github.com/users/scrutinizer-notifier/repos","events_url":"https://api.github.com/users/scrutinizer-notifier/events{/privacy}","received_events_url":"https://api.github.com/users/scrutinizer-notifier/received_events","type":"User","site_admin":false},"created_at":"2015-01-22T09:13:06Z","updated_at":"2015-01-22T09:13:06Z","body":"A [new inspection](https://scrutinizer-ci.com/g/owncloud/core/inspections/d4fe8c46-f886-4dc9-bcde-bb054b9756fb) was created."}}