{"action":"closed","number":92,"pull_request":{"url":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/92","id":30229063,"html_url":"https://github.com/yesodweb/Shelly.hs/pull/92","diff_url":"https://github.com/yesodweb/Shelly.hs/pull/92.diff","patch_url":"https://github.com/yesodweb/Shelly.hs/pull/92.patch","issue_url":"https://api.github.com/repos/yesodweb/Shelly.hs/issues/92","number":92,"state":"closed","locked":false,"title":"Fix run_ behavior","user":{"login":"TravisWhitaker","id":1310395,"avatar_url":"https://avatars.githubusercontent.com/u/1310395?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisWhitaker","html_url":"https://github.com/TravisWhitaker","followers_url":"https://api.github.com/users/TravisWhitaker/followers","following_url":"https://api.github.com/users/TravisWhitaker/following{/other_user}","gists_url":"https://api.github.com/users/TravisWhitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisWhitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisWhitaker/subscriptions","organizations_url":"https://api.github.com/users/TravisWhitaker/orgs","repos_url":"https://api.github.com/users/TravisWhitaker/repos","events_url":"https://api.github.com/users/TravisWhitaker/events{/privacy}","received_events_url":"https://api.github.com/users/TravisWhitaker/received_events","type":"User","site_admin":false},"body":"The implementation of `run_` ignores the `silently` combinator. For example:\r\n\r\n```haskell\r\n{-# LANGUAGE OverloadedStrings #-}\r\nimport Data.Text\r\nimport Shelly\r\nmain = (shelly . silently) $ do\r\n    run \"echo\" [\"run: this should not be printed\"]\r\n    run_ \"echo\" [\"run_: this should not be printed\"]\r\n```\r\n\r\nI think this \"leakage\" is caused by run_ inheriting the stdout handle. Only `runFoldLines` seems to respect the value of `sPrintStdout`. I don't think this change will break any of the combinators that rely on `run_`.\r\n\r\n","created_at":"2015-02-28T19:10:20Z","updated_at":"2015-02-28T19:57:03Z","closed_at":"2015-02-28T19:57:03Z","merged_at":null,"merge_commit_sha":"0ca3d423dfed6fe447a83a978830ad98555ba986","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/92/commits","review_comments_url":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/92/comments","review_comment_url":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yesodweb/Shelly.hs/issues/92/comments","statuses_url":"https://api.github.com/repos/yesodweb/Shelly.hs/statuses/50bad68783b0b6d34380bbcab26d2959b968a01f","head":{"label":"TravisWhitaker:fixrun_","ref":"fixrun_","sha":"50bad68783b0b6d34380bbcab26d2959b968a01f","user":{"login":"TravisWhitaker","id":1310395,"avatar_url":"https://avatars.githubusercontent.com/u/1310395?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisWhitaker","html_url":"https://github.com/TravisWhitaker","followers_url":"https://api.github.com/users/TravisWhitaker/followers","following_url":"https://api.github.com/users/TravisWhitaker/following{/other_user}","gists_url":"https://api.github.com/users/TravisWhitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisWhitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisWhitaker/subscriptions","organizations_url":"https://api.github.com/users/TravisWhitaker/orgs","repos_url":"https://api.github.com/users/TravisWhitaker/repos","events_url":"https://api.github.com/users/TravisWhitaker/events{/privacy}","received_events_url":"https://api.github.com/users/TravisWhitaker/received_events","type":"User","site_admin":false},"repo":{"id":31471339,"name":"Shelly.hs","full_name":"TravisWhitaker/Shelly.hs","owner":{"login":"TravisWhitaker","id":1310395,"avatar_url":"https://avatars.githubusercontent.com/u/1310395?v=3","gravatar_id":"","url":"https://api.github.com/users/TravisWhitaker","html_url":"https://github.com/TravisWhitaker","followers_url":"https://api.github.com/users/TravisWhitaker/followers","following_url":"https://api.github.com/users/TravisWhitaker/following{/other_user}","gists_url":"https://api.github.com/users/TravisWhitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/TravisWhitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TravisWhitaker/subscriptions","organizations_url":"https://api.github.com/users/TravisWhitaker/orgs","repos_url":"https://api.github.com/users/TravisWhitaker/repos","events_url":"https://api.github.com/users/TravisWhitaker/events{/privacy}","received_events_url":"https://api.github.com/users/TravisWhitaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TravisWhitaker/Shelly.hs","description":"Haskell shell scripting","fork":true,"url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs","forks_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/forks","keys_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/teams","hooks_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/hooks","issue_events_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/issues/events{/number}","events_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/events","assignees_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/assignees{/user}","branches_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/branches{/branch}","tags_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/tags","blobs_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/statuses/{sha}","languages_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/languages","stargazers_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/stargazers","contributors_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/contributors","subscribers_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/subscribers","subscription_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/subscription","commits_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/contents/{+path}","compare_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/merges","archive_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/downloads","issues_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/issues{/number}","pulls_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/pulls{/number}","milestones_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/milestones{/number}","notifications_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/labels{/name}","releases_url":"https://api.github.com/repos/TravisWhitaker/Shelly.hs/releases{/id}","created_at":"2015-02-28T18:11:39Z","updated_at":"2015-02-28T18:11:40Z","pushed_at":"2015-02-28T18:53:28Z","git_url":"git://github.com/TravisWhitaker/Shelly.hs.git","ssh_url":"git@github.com:TravisWhitaker/Shelly.hs.git","clone_url":"https://github.com/TravisWhitaker/Shelly.hs.git","svn_url":"https://github.com/TravisWhitaker/Shelly.hs","homepage":"","size":1952,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yesodweb:master","ref":"master","sha":"63eb83831c67a70a4048ffe921aecb5f2690d629","user":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"repo":{"id":3604387,"name":"Shelly.hs","full_name":"yesodweb/Shelly.hs","owner":{"login":"yesodweb","id":930379,"avatar_url":"https://avatars.githubusercontent.com/u/930379?v=3","gravatar_id":"","url":"https://api.github.com/users/yesodweb","html_url":"https://github.com/yesodweb","followers_url":"https://api.github.com/users/yesodweb/followers","following_url":"https://api.github.com/users/yesodweb/following{/other_user}","gists_url":"https://api.github.com/users/yesodweb/gists{/gist_id}","starred_url":"https://api.github.com/users/yesodweb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yesodweb/subscriptions","organizations_url":"https://api.github.com/users/yesodweb/orgs","repos_url":"https://api.github.com/users/yesodweb/repos","events_url":"https://api.github.com/users/yesodweb/events{/privacy}","received_events_url":"https://api.github.com/users/yesodweb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yesodweb/Shelly.hs","description":"Haskell shell scripting","fork":false,"url":"https://api.github.com/repos/yesodweb/Shelly.hs","forks_url":"https://api.github.com/repos/yesodweb/Shelly.hs/forks","keys_url":"https://api.github.com/repos/yesodweb/Shelly.hs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yesodweb/Shelly.hs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yesodweb/Shelly.hs/teams","hooks_url":"https://api.github.com/repos/yesodweb/Shelly.hs/hooks","issue_events_url":"https://api.github.com/repos/yesodweb/Shelly.hs/issues/events{/number}","events_url":"https://api.github.com/repos/yesodweb/Shelly.hs/events","assignees_url":"https://api.github.com/repos/yesodweb/Shelly.hs/assignees{/user}","branches_url":"https://api.github.com/repos/yesodweb/Shelly.hs/branches{/branch}","tags_url":"https://api.github.com/repos/yesodweb/Shelly.hs/tags","blobs_url":"https://api.github.com/repos/yesodweb/Shelly.hs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yesodweb/Shelly.hs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yesodweb/Shelly.hs/git/refs{/sha}","trees_url":"https://api.github.com/repos/yesodweb/Shelly.hs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yesodweb/Shelly.hs/statuses/{sha}","languages_url":"https://api.github.com/repos/yesodweb/Shelly.hs/languages","stargazers_url":"https://api.github.com/repos/yesodweb/Shelly.hs/stargazers","contributors_url":"https://api.github.com/repos/yesodweb/Shelly.hs/contributors","subscribers_url":"https://api.github.com/repos/yesodweb/Shelly.hs/subscribers","subscription_url":"https://api.github.com/repos/yesodweb/Shelly.hs/subscription","commits_url":"https://api.github.com/repos/yesodweb/Shelly.hs/commits{/sha}","git_commits_url":"https://api.github.com/repos/yesodweb/Shelly.hs/git/commits{/sha}","comments_url":"https://api.github.com/repos/yesodweb/Shelly.hs/comments{/number}","issue_comment_url":"https://api.github.com/repos/yesodweb/Shelly.hs/issues/comments{/number}","contents_url":"https://api.github.com/repos/yesodweb/Shelly.hs/contents/{+path}","compare_url":"https://api.github.com/repos/yesodweb/Shelly.hs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yesodweb/Shelly.hs/merges","archive_url":"https://api.github.com/repos/yesodweb/Shelly.hs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yesodweb/Shelly.hs/downloads","issues_url":"https://api.github.com/repos/yesodweb/Shelly.hs/issues{/number}","pulls_url":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls{/number}","milestones_url":"https://api.github.com/repos/yesodweb/Shelly.hs/milestones{/number}","notifications_url":"https://api.github.com/repos/yesodweb/Shelly.hs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yesodweb/Shelly.hs/labels{/name}","releases_url":"https://api.github.com/repos/yesodweb/Shelly.hs/releases{/id}","created_at":"2012-03-02T17:34:50Z","updated_at":"2015-02-28T19:27:22Z","pushed_at":"2015-02-28T19:27:55Z","git_url":"git://github.com/yesodweb/Shelly.hs.git","ssh_url":"git@github.com:yesodweb/Shelly.hs.git","clone_url":"https://github.com/yesodweb/Shelly.hs.git","svn_url":"https://github.com/yesodweb/Shelly.hs","homepage":"","size":1952,"stargazers_count":188,"watchers_count":188,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":9,"forks":35,"open_issues":9,"watchers":188,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/92"},"html":{"href":"https://github.com/yesodweb/Shelly.hs/pull/92"},"issue":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/issues/92"},"comments":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/yesodweb/Shelly.hs/statuses/50bad68783b0b6d34380bbcab26d2959b968a01f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":2,"deletions":2,"changed_files":1}}