{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5669","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5669/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5669/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5669/events","html_url":"https://github.com/bitcoin/bitcoin/pull/5669","id":54493399,"number":5669,"title":"Consensus: Move CheckTransaction() from main to consensus/consensus","user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Validation","name":"Validation","color":"6060aa"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-01-15T19:35:23Z","updated_at":"2015-01-20T00:08:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/5669","html_url":"https://github.com/bitcoin/bitcoin/pull/5669","diff_url":"https://github.com/bitcoin/bitcoin/pull/5669.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/5669.patch"},"body":"First decouple the function from class main::CValidationState, boost_foreach and util.h. \r\nThen move it out of main.\r\nThis is part of the effort to create libconsensus."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/70583170","html_url":"https://github.com/bitcoin/bitcoin/pull/5669#issuecomment-70583170","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/5669","id":70583170,"user":{"login":"jtimon","id":1008458,"avatar_url":"https://avatars.githubusercontent.com/u/1008458?v=3","gravatar_id":"","url":"https://api.github.com/users/jtimon","html_url":"https://github.com/jtimon","followers_url":"https://api.github.com/users/jtimon/followers","following_url":"https://api.github.com/users/jtimon/following{/other_user}","gists_url":"https://api.github.com/users/jtimon/gists{/gist_id}","starred_url":"https://api.github.com/users/jtimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtimon/subscriptions","organizations_url":"https://api.github.com/users/jtimon/orgs","repos_url":"https://api.github.com/users/jtimon/repos","events_url":"https://api.github.com/users/jtimon/events{/privacy}","received_events_url":"https://api.github.com/users/jtimon/received_events","type":"User","site_admin":false},"created_at":"2015-01-20T00:08:30Z","updated_at":"2015-01-20T00:08:30Z","body":"Rebased on top of #5681, added some \"SQUASHME\" notes since some small commits like those flagged with  \"MOVEONLY\", are only useful for the initial review (for example I separated theuni@fd19dd4 into https://github.com/jtimon/bitcoin/commit/72e5068ebe1aad33f05a02f7eabe65abb098dff0 and https://github.com/jtimon/bitcoin/commit/8a6590ccb3f51978333d50878af3d79005ca4dfb).\r\nI am very sorry for having screwed review by having rebased on top of  #5681.\r\nI should have signaled more clearly that this was a work in progress but I'm trying to keep the policy--refactor-related code in sync with this and I was really having problems editing and moving commits up and down without some solid include basis. I'm thankful to @jgarzik that C's include philosophy is to include everything that you're using, not just the higher level files. I hope that he can give some time to #5681 to make sure I didn't learned anything the wrong way.\r\nI'm also trying to keep in sync https://github.com/luke-jr/bitcoin/compare/nodepolicy2 and #5180.\r\nI hope reviewers don't get mad because I'm using #5681 as a common base for some seemingly unrelated previous proposals, but I believe they will become much easier to maintain.\r\nI needed that to know which ```#include \"main.h\"``` I could really delete when moving things out of main in parallel.\r\nI'll push my longest consensus/policy-related branch soon. If it doesn't make any sense to anyone I can go back to a version without #5681 on the consensus and policy related PRs I have. I may close some of them with some acks to if it makes more sense to concentrate related changes.\r\n \r\n  "}}