{"action":"created","comment":{"url":"https://api.github.com/repos/mapzen/vector-datasource/pulls/comments/23134884","id":23134884,"diff_hunk":"@@ -35,6 +35,24 @@ FROM\n         AND way_area::bigint > 102400 -- 4px\n         AND mz_way12 && !bbox!\n \n+    --\n+    -- Water line geometries\n+    --\n+    UNION\n+\n+    SELECT name,\n+           NULL AS area,\n+           waterway AS kind,\n+           'openstreetmap.org' AS source,\n+           way AS __geometry__,\n+           mz_id AS __id__\n+\n+    FROM planet_osm_line\n+\n+    WHERE\n+        waterway IN ('canal', 'river')","path":"queries/water-z9.pgsql","position":19,"original_position":19,"commit_id":"9658272622f137e4cfbb385051248ac4c787b8cf","original_commit_id":"9658272622f137e4cfbb385051248ac4c787b8cf","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"body":"Good point, that can filter a bit. The only thing is that, at the opposite of the areas, those lines are very often many pieces of a same river or canal, so we just need to check that we don't create hole in a river stream.\r\nI'll have a look.","created_at":"2015-01-18T17:14:48Z","updated_at":"2015-01-18T17:14:48Z","html_url":"https://github.com/mapzen/vector-datasource/pull/82#discussion_r23134884","pull_request_url":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/mapzen/vector-datasource/pulls/comments/23134884"},"html":{"href":"https://github.com/mapzen/vector-datasource/pull/82#discussion_r23134884"},"pull_request":{"href":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82","id":27568927,"html_url":"https://github.com/mapzen/vector-datasource/pull/82","diff_url":"https://github.com/mapzen/vector-datasource/pull/82.diff","patch_url":"https://github.com/mapzen/vector-datasource/pull/82.patch","issue_url":"https://api.github.com/repos/mapzen/vector-datasource/issues/82","number":82,"state":"open","locked":false,"title":"First attempt to add waterway lines (fix #81)","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"body":"So here is a shot :)\r\n\r\n`river` and `canal` are made visible starting at zoom 9, `dam` and `stream` starting at zoom 13 and `ditch` and `drain` at zoom 16.\r\n\r\nI'm not sure if we need a dedicated index, maybe a btree on waterway plus way. I'm happy to have your feedback on this :)\r\n\r\nThanks for reviewing!\r\n\r\nYohan\r\n\r\nRef: #81 ","created_at":"2015-01-18T09:19:59Z","updated_at":"2015-01-18T17:14:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c929e36297d730858c417a1fd6a48e860fdcc6aa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82/commits","review_comments_url":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82/comments","review_comment_url":"https://api.github.com/repos/mapzen/vector-datasource/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mapzen/vector-datasource/issues/82/comments","statuses_url":"https://api.github.com/repos/mapzen/vector-datasource/statuses/9658272622f137e4cfbb385051248ac4c787b8cf","head":{"label":"yohanboniface:water-lines","ref":"water-lines","sha":"9658272622f137e4cfbb385051248ac4c787b8cf","user":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"repo":{"id":29420707,"name":"vector-datasource","full_name":"yohanboniface/vector-datasource","owner":{"login":"yohanboniface","id":146023,"avatar_url":"https://avatars.githubusercontent.com/u/146023?v=3","gravatar_id":"","url":"https://api.github.com/users/yohanboniface","html_url":"https://github.com/yohanboniface","followers_url":"https://api.github.com/users/yohanboniface/followers","following_url":"https://api.github.com/users/yohanboniface/following{/other_user}","gists_url":"https://api.github.com/users/yohanboniface/gists{/gist_id}","starred_url":"https://api.github.com/users/yohanboniface/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yohanboniface/subscriptions","organizations_url":"https://api.github.com/users/yohanboniface/orgs","repos_url":"https://api.github.com/users/yohanboniface/repos","events_url":"https://api.github.com/users/yohanboniface/events{/privacy}","received_events_url":"https://api.github.com/users/yohanboniface/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yohanboniface/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap vector tiles in several formats","fork":true,"url":"https://api.github.com/repos/yohanboniface/vector-datasource","forks_url":"https://api.github.com/repos/yohanboniface/vector-datasource/forks","keys_url":"https://api.github.com/repos/yohanboniface/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yohanboniface/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yohanboniface/vector-datasource/teams","hooks_url":"https://api.github.com/repos/yohanboniface/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/yohanboniface/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/yohanboniface/vector-datasource/events","assignees_url":"https://api.github.com/repos/yohanboniface/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/yohanboniface/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/yohanboniface/vector-datasource/tags","blobs_url":"https://api.github.com/repos/yohanboniface/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yohanboniface/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yohanboniface/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/yohanboniface/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yohanboniface/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/yohanboniface/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/yohanboniface/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/yohanboniface/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/yohanboniface/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/yohanboniface/vector-datasource/subscription","commits_url":"https://api.github.com/repos/yohanboniface/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/yohanboniface/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/yohanboniface/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/yohanboniface/vector-datasource/issues/comments/{number}","contents_url":"https://api.github.com/repos/yohanboniface/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/yohanboniface/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yohanboniface/vector-datasource/merges","archive_url":"https://api.github.com/repos/yohanboniface/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yohanboniface/vector-datasource/downloads","issues_url":"https://api.github.com/repos/yohanboniface/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/yohanboniface/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/yohanboniface/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/yohanboniface/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yohanboniface/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/yohanboniface/vector-datasource/releases{/id}","created_at":"2015-01-18T09:00:29Z","updated_at":"2015-01-18T09:00:30Z","pushed_at":"2015-01-18T13:40:40Z","git_url":"git://github.com/yohanboniface/vector-datasource.git","ssh_url":"git@github.com:yohanboniface/vector-datasource.git","clone_url":"https://github.com/yohanboniface/vector-datasource.git","svn_url":"https://github.com/yohanboniface/vector-datasource","homepage":"http://mapzen.com/vector","size":23471,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapzen:master","ref":"master","sha":"6112e28d5e4eecd975010911b0af28ee489831ec","user":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?v=3","gravatar_id":"","url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"repo":{"id":13446739,"name":"vector-datasource","full_name":"mapzen/vector-datasource","owner":{"login":"mapzen","id":5435747,"avatar_url":"https://avatars.githubusercontent.com/u/5435747?v=3","gravatar_id":"","url":"https://api.github.com/users/mapzen","html_url":"https://github.com/mapzen","followers_url":"https://api.github.com/users/mapzen/followers","following_url":"https://api.github.com/users/mapzen/following{/other_user}","gists_url":"https://api.github.com/users/mapzen/gists{/gist_id}","starred_url":"https://api.github.com/users/mapzen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapzen/subscriptions","organizations_url":"https://api.github.com/users/mapzen/orgs","repos_url":"https://api.github.com/users/mapzen/repos","events_url":"https://api.github.com/users/mapzen/events{/privacy}","received_events_url":"https://api.github.com/users/mapzen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapzen/vector-datasource","description":"Mapzen vector tile service - OpenStreetMap vector tiles in several formats","fork":false,"url":"https://api.github.com/repos/mapzen/vector-datasource","forks_url":"https://api.github.com/repos/mapzen/vector-datasource/forks","keys_url":"https://api.github.com/repos/mapzen/vector-datasource/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapzen/vector-datasource/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapzen/vector-datasource/teams","hooks_url":"https://api.github.com/repos/mapzen/vector-datasource/hooks","issue_events_url":"https://api.github.com/repos/mapzen/vector-datasource/issues/events{/number}","events_url":"https://api.github.com/repos/mapzen/vector-datasource/events","assignees_url":"https://api.github.com/repos/mapzen/vector-datasource/assignees{/user}","branches_url":"https://api.github.com/repos/mapzen/vector-datasource/branches{/branch}","tags_url":"https://api.github.com/repos/mapzen/vector-datasource/tags","blobs_url":"https://api.github.com/repos/mapzen/vector-datasource/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapzen/vector-datasource/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapzen/vector-datasource/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapzen/vector-datasource/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapzen/vector-datasource/statuses/{sha}","languages_url":"https://api.github.com/repos/mapzen/vector-datasource/languages","stargazers_url":"https://api.github.com/repos/mapzen/vector-datasource/stargazers","contributors_url":"https://api.github.com/repos/mapzen/vector-datasource/contributors","subscribers_url":"https://api.github.com/repos/mapzen/vector-datasource/subscribers","subscription_url":"https://api.github.com/repos/mapzen/vector-datasource/subscription","commits_url":"https://api.github.com/repos/mapzen/vector-datasource/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapzen/vector-datasource/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapzen/vector-datasource/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapzen/vector-datasource/issues/comments/{number}","contents_url":"https://api.github.com/repos/mapzen/vector-datasource/contents/{+path}","compare_url":"https://api.github.com/repos/mapzen/vector-datasource/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapzen/vector-datasource/merges","archive_url":"https://api.github.com/repos/mapzen/vector-datasource/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapzen/vector-datasource/downloads","issues_url":"https://api.github.com/repos/mapzen/vector-datasource/issues{/number}","pulls_url":"https://api.github.com/repos/mapzen/vector-datasource/pulls{/number}","milestones_url":"https://api.github.com/repos/mapzen/vector-datasource/milestones{/number}","notifications_url":"https://api.github.com/repos/mapzen/vector-datasource/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapzen/vector-datasource/labels{/name}","releases_url":"https://api.github.com/repos/mapzen/vector-datasource/releases{/id}","created_at":"2013-10-09T15:54:45Z","updated_at":"2015-01-17T22:41:55Z","pushed_at":"2015-01-05T20:54:25Z","git_url":"git://github.com/mapzen/vector-datasource.git","ssh_url":"git@github.com:mapzen/vector-datasource.git","clone_url":"https://github.com/mapzen/vector-datasource.git","svn_url":"https://github.com/mapzen/vector-datasource","homepage":"http://mapzen.com/vector","size":24389,"stargazers_count":70,"watchers_count":70,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":9,"forks":12,"open_issues":9,"watchers":70,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82"},"html":{"href":"https://github.com/mapzen/vector-datasource/pull/82"},"issue":{"href":"https://api.github.com/repos/mapzen/vector-datasource/issues/82"},"comments":{"href":"https://api.github.com/repos/mapzen/vector-datasource/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/mapzen/vector-datasource/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mapzen/vector-datasource/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/mapzen/vector-datasource/statuses/9658272622f137e4cfbb385051248ac4c787b8cf"}}}}