{"action":"created","comment":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/46097453","id":46097453,"diff_hunk":"@@ -426,6 +428,8 @@ let message = function\n       Printf.sprintf \"the %S attribute is used more than once on this expression\" attr_name\n   | Inlining_impossible reason ->\n       Printf.sprintf \"Inlining impossible in this context: %s\" reason\n+  | No_cmx_file name ->\n+      Printf.sprintf \"no cmx file was found in path for module \" ^ name","path":"utils/warnings.ml","position":25,"original_position":25,"commit_id":"a0b93cbcc0306c0318214956c8847b525d01316f","original_commit_id":"a0b93cbcc0306c0318214956c8847b525d01316f","user":{"login":"gasche","id":426238,"avatar_url":"https://avatars.githubusercontent.com/u/426238?v=3","gravatar_id":"","url":"https://api.github.com/users/gasche","html_url":"https://github.com/gasche","followers_url":"https://api.github.com/users/gasche/followers","following_url":"https://api.github.com/users/gasche/following{/other_user}","gists_url":"https://api.github.com/users/gasche/gists{/gist_id}","starred_url":"https://api.github.com/users/gasche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gasche/subscriptions","organizations_url":"https://api.github.com/users/gasche/orgs","repos_url":"https://api.github.com/users/gasche/repos","events_url":"https://api.github.com/users/gasche/events{/privacy}","received_events_url":"https://api.github.com/users/gasche/received_events","type":"User","site_admin":false},"body":"Would there be a way to mention in the message that `-opaque` could be used, that would not make it the Daughter of All Error Messages?","created_at":"2015-11-29T20:25:39Z","updated_at":"2015-11-29T20:25:39Z","html_url":"https://github.com/ocaml/ocaml/pull/319#discussion_r46097453","pull_request_url":"https://api.github.com/repos/ocaml/ocaml/pulls/319","_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments/46097453"},"html":{"href":"https://github.com/ocaml/ocaml/pull/319#discussion_r46097453"},"pull_request":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/319"}}},"pull_request":{"url":"https://api.github.com/repos/ocaml/ocaml/pulls/319","id":52067578,"html_url":"https://github.com/ocaml/ocaml/pull/319","diff_url":"https://github.com/ocaml/ocaml/pull/319.diff","patch_url":"https://github.com/ocaml/ocaml/pull/319.patch","issue_url":"https://api.github.com/repos/ocaml/ocaml/issues/319","number":319,"state":"open","locked":false,"title":"Warning for missing .cmx files","user":{"login":"lpw25","id":2631210,"avatar_url":"https://avatars.githubusercontent.com/u/2631210?v=3","gravatar_id":"","url":"https://api.github.com/users/lpw25","html_url":"https://github.com/lpw25","followers_url":"https://api.github.com/users/lpw25/followers","following_url":"https://api.github.com/users/lpw25/following{/other_user}","gists_url":"https://api.github.com/users/lpw25/gists{/gist_id}","starred_url":"https://api.github.com/users/lpw25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpw25/subscriptions","organizations_url":"https://api.github.com/users/lpw25/orgs","repos_url":"https://api.github.com/users/lpw25/repos","events_url":"https://api.github.com/users/lpw25/events{/privacy}","received_events_url":"https://api.github.com/users/lpw25/received_events","type":"User","site_admin":false},"body":"This patch adds a warning for missing cmx files during cross-module inlining. This is useful because currently a misspecified build can silently damage the performance of programs.\r\n\r\nThe patch also extends the `-opaque` option to work on .mli files. Using `-opaque` on an .ml file means that its implementation should not be considered for cross-module inlining. Using `-opaque` on an .mli file means that no implementation of that interface should be considered for cross-module inlining.\r\n\r\nIf an interface is marked as `opaque` then the compiler does not search for a .cmx file, and so the new warning will not be triggered. This means that modules which are intended to be chosen at link-time (and so deliberately hide .cmx files) can avoid unnecessarily triggering the warning.\r\n\r\nAs an illustration of the utility of this new warning, not all cmx files were installed by the OCaml distribution, and the patch also adjusts the installation rules to install these files (which were in compiler-libs and ocamldoc).","created_at":"2015-11-29T18:29:02Z","updated_at":"2015-11-29T20:25:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"56a748e695f24a371a37a11386dcb43d021dbb62","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ocaml/ocaml/pulls/319/commits","review_comments_url":"https://api.github.com/repos/ocaml/ocaml/pulls/319/comments","review_comment_url":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ocaml/ocaml/issues/319/comments","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/a0b93cbcc0306c0318214956c8847b525d01316f","head":{"label":"lpw25:opaque-cmis","ref":"opaque-cmis","sha":"a0b93cbcc0306c0318214956c8847b525d01316f","user":{"login":"lpw25","id":2631210,"avatar_url":"https://avatars.githubusercontent.com/u/2631210?v=3","gravatar_id":"","url":"https://api.github.com/users/lpw25","html_url":"https://github.com/lpw25","followers_url":"https://api.github.com/users/lpw25/followers","following_url":"https://api.github.com/users/lpw25/following{/other_user}","gists_url":"https://api.github.com/users/lpw25/gists{/gist_id}","starred_url":"https://api.github.com/users/lpw25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpw25/subscriptions","organizations_url":"https://api.github.com/users/lpw25/orgs","repos_url":"https://api.github.com/users/lpw25/repos","events_url":"https://api.github.com/users/lpw25/events{/privacy}","received_events_url":"https://api.github.com/users/lpw25/received_events","type":"User","site_admin":false},"repo":{"id":12688734,"name":"ocaml","full_name":"lpw25/ocaml","owner":{"login":"lpw25","id":2631210,"avatar_url":"https://avatars.githubusercontent.com/u/2631210?v=3","gravatar_id":"","url":"https://api.github.com/users/lpw25","html_url":"https://github.com/lpw25","followers_url":"https://api.github.com/users/lpw25/followers","following_url":"https://api.github.com/users/lpw25/following{/other_user}","gists_url":"https://api.github.com/users/lpw25/gists{/gist_id}","starred_url":"https://api.github.com/users/lpw25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpw25/subscriptions","organizations_url":"https://api.github.com/users/lpw25/orgs","repos_url":"https://api.github.com/users/lpw25/repos","events_url":"https://api.github.com/users/lpw25/events{/privacy}","received_events_url":"https://api.github.com/users/lpw25/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lpw25/ocaml","description":"My experiments with and extensions to OCaml","fork":true,"url":"https://api.github.com/repos/lpw25/ocaml","forks_url":"https://api.github.com/repos/lpw25/ocaml/forks","keys_url":"https://api.github.com/repos/lpw25/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lpw25/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lpw25/ocaml/teams","hooks_url":"https://api.github.com/repos/lpw25/ocaml/hooks","issue_events_url":"https://api.github.com/repos/lpw25/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/lpw25/ocaml/events","assignees_url":"https://api.github.com/repos/lpw25/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/lpw25/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/lpw25/ocaml/tags","blobs_url":"https://api.github.com/repos/lpw25/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lpw25/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lpw25/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/lpw25/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lpw25/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/lpw25/ocaml/languages","stargazers_url":"https://api.github.com/repos/lpw25/ocaml/stargazers","contributors_url":"https://api.github.com/repos/lpw25/ocaml/contributors","subscribers_url":"https://api.github.com/repos/lpw25/ocaml/subscribers","subscription_url":"https://api.github.com/repos/lpw25/ocaml/subscription","commits_url":"https://api.github.com/repos/lpw25/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/lpw25/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/lpw25/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/lpw25/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/lpw25/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/lpw25/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lpw25/ocaml/merges","archive_url":"https://api.github.com/repos/lpw25/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lpw25/ocaml/downloads","issues_url":"https://api.github.com/repos/lpw25/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/lpw25/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/lpw25/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/lpw25/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lpw25/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/lpw25/ocaml/releases{/id}","created_at":"2013-09-08T22:30:48Z","updated_at":"2014-09-04T15:06:27Z","pushed_at":"2015-11-29T18:15:28Z","git_url":"git://github.com/lpw25/ocaml.git","ssh_url":"git@github.com:lpw25/ocaml.git","clone_url":"https://github.com/lpw25/ocaml.git","svn_url":"https://github.com/lpw25/ocaml","homepage":"","size":133397,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"lpw25/readme"}},"base":{"label":"ocaml:trunk","ref":"trunk","sha":"42ebc0469bd89b89c33a2e0fcf758c9f1c654113","user":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"repo":{"id":6786166,"name":"ocaml","full_name":"ocaml/ocaml","owner":{"login":"ocaml","id":1841483,"avatar_url":"https://avatars.githubusercontent.com/u/1841483?v=3","gravatar_id":"","url":"https://api.github.com/users/ocaml","html_url":"https://github.com/ocaml","followers_url":"https://api.github.com/users/ocaml/followers","following_url":"https://api.github.com/users/ocaml/following{/other_user}","gists_url":"https://api.github.com/users/ocaml/gists{/gist_id}","starred_url":"https://api.github.com/users/ocaml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocaml/subscriptions","organizations_url":"https://api.github.com/users/ocaml/orgs","repos_url":"https://api.github.com/users/ocaml/repos","events_url":"https://api.github.com/users/ocaml/events{/privacy}","received_events_url":"https://api.github.com/users/ocaml/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocaml/ocaml","description":"The core OCaml system: compilers, runtime system, base libraries","fork":false,"url":"https://api.github.com/repos/ocaml/ocaml","forks_url":"https://api.github.com/repos/ocaml/ocaml/forks","keys_url":"https://api.github.com/repos/ocaml/ocaml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocaml/ocaml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocaml/ocaml/teams","hooks_url":"https://api.github.com/repos/ocaml/ocaml/hooks","issue_events_url":"https://api.github.com/repos/ocaml/ocaml/issues/events{/number}","events_url":"https://api.github.com/repos/ocaml/ocaml/events","assignees_url":"https://api.github.com/repos/ocaml/ocaml/assignees{/user}","branches_url":"https://api.github.com/repos/ocaml/ocaml/branches{/branch}","tags_url":"https://api.github.com/repos/ocaml/ocaml/tags","blobs_url":"https://api.github.com/repos/ocaml/ocaml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocaml/ocaml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocaml/ocaml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocaml/ocaml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocaml/ocaml/statuses/{sha}","languages_url":"https://api.github.com/repos/ocaml/ocaml/languages","stargazers_url":"https://api.github.com/repos/ocaml/ocaml/stargazers","contributors_url":"https://api.github.com/repos/ocaml/ocaml/contributors","subscribers_url":"https://api.github.com/repos/ocaml/ocaml/subscribers","subscription_url":"https://api.github.com/repos/ocaml/ocaml/subscription","commits_url":"https://api.github.com/repos/ocaml/ocaml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocaml/ocaml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocaml/ocaml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocaml/ocaml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocaml/ocaml/contents/{+path}","compare_url":"https://api.github.com/repos/ocaml/ocaml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocaml/ocaml/merges","archive_url":"https://api.github.com/repos/ocaml/ocaml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocaml/ocaml/downloads","issues_url":"https://api.github.com/repos/ocaml/ocaml/issues{/number}","pulls_url":"https://api.github.com/repos/ocaml/ocaml/pulls{/number}","milestones_url":"https://api.github.com/repos/ocaml/ocaml/milestones{/number}","notifications_url":"https://api.github.com/repos/ocaml/ocaml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocaml/ocaml/labels{/name}","releases_url":"https://api.github.com/repos/ocaml/ocaml/releases{/id}","created_at":"2012-11-20T22:18:22Z","updated_at":"2015-11-29T07:22:48Z","pushed_at":"2015-11-29T20:06:50Z","git_url":"git://github.com/ocaml/ocaml.git","ssh_url":"git@github.com:ocaml/ocaml.git","clone_url":"https://github.com/ocaml/ocaml.git","svn_url":"https://github.com/ocaml/ocaml","homepage":"","size":159822,"stargazers_count":559,"watchers_count":559,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":196,"mirror_url":null,"open_issues_count":73,"forks":196,"open_issues":73,"watchers":559,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/319"},"html":{"href":"https://github.com/ocaml/ocaml/pull/319"},"issue":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/319"},"comments":{"href":"https://api.github.com/repos/ocaml/ocaml/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ocaml/ocaml/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/ocaml/ocaml/statuses/a0b93cbcc0306c0318214956c8847b525d01316f"}}}}