{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/5","id":31601955,"html_url":"https://github.com/96boards/arm-trusted-firmware/pull/5","diff_url":"https://github.com/96boards/arm-trusted-firmware/pull/5.diff","patch_url":"https://github.com/96boards/arm-trusted-firmware/pull/5.patch","issue_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues/5","number":5,"state":"open","locked":false,"title":"HiKey: pll.c: do not access memory at address 0x0","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"body":"This commit deletes the memory access test done in BL1 immediately after\r\nDDR initialization. The test is performed at address 0x0, which is valid\r\nbut may be subject to an unwanted compiler optimization. GCC 4.9, for\r\ninstance, assumes that programs cannot safely dereference null pointers\r\nand will generate a brk instruction, resulting in a BL1 hang.\r\n\r\nUsing -fno-delete-null-pointer-checks would be another option, but it is\r\nnot justified because we don't really need to access address 0x0 anyway.\r\n\r\nSigned-off-by: Jerome Forissier <jerome.forissier@linaro.org>","created_at":"2015-03-20T10:23:22Z","updated_at":"2015-03-20T10:23:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/5/commits","review_comments_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/5/comments","review_comment_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues/5/comments","statuses_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/statuses/d4727c7bfe87f3dd115b6b2beb24c923e31c7c38","head":{"label":"jforissier:address_zero_fix","ref":"address_zero_fix","sha":"d4727c7bfe87f3dd115b6b2beb24c923e31c7c38","user":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"repo":{"id":32471771,"name":"arm-trusted-firmware","full_name":"jforissier/arm-trusted-firmware","owner":{"login":"jforissier","id":8288195,"avatar_url":"https://avatars.githubusercontent.com/u/8288195?v=3","gravatar_id":"","url":"https://api.github.com/users/jforissier","html_url":"https://github.com/jforissier","followers_url":"https://api.github.com/users/jforissier/followers","following_url":"https://api.github.com/users/jforissier/following{/other_user}","gists_url":"https://api.github.com/users/jforissier/gists{/gist_id}","starred_url":"https://api.github.com/users/jforissier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jforissier/subscriptions","organizations_url":"https://api.github.com/users/jforissier/orgs","repos_url":"https://api.github.com/users/jforissier/repos","events_url":"https://api.github.com/users/jforissier/events{/privacy}","received_events_url":"https://api.github.com/users/jforissier/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jforissier/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/jforissier/arm-trusted-firmware","forks_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/jforissier/arm-trusted-firmware/releases{/id}","created_at":"2015-03-18T16:51:33Z","updated_at":"2015-03-18T16:51:35Z","pushed_at":"2015-03-20T10:21:00Z","git_url":"git://github.com/jforissier/arm-trusted-firmware.git","ssh_url":"git@github.com:jforissier/arm-trusted-firmware.git","clone_url":"https://github.com/jforissier/arm-trusted-firmware.git","svn_url":"https://github.com/jforissier/arm-trusted-firmware","homepage":null,"size":3703,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"hikey"}},"base":{"label":"96boards:hikey","ref":"hikey","sha":"437f856f5bc461253a5d9600358e82e75d172542","user":{"login":"96boards","id":10862183,"avatar_url":"https://avatars.githubusercontent.com/u/10862183?v=3","gravatar_id":"","url":"https://api.github.com/users/96boards","html_url":"https://github.com/96boards","followers_url":"https://api.github.com/users/96boards/followers","following_url":"https://api.github.com/users/96boards/following{/other_user}","gists_url":"https://api.github.com/users/96boards/gists{/gist_id}","starred_url":"https://api.github.com/users/96boards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/96boards/subscriptions","organizations_url":"https://api.github.com/users/96boards/orgs","repos_url":"https://api.github.com/users/96boards/repos","events_url":"https://api.github.com/users/96boards/events{/privacy}","received_events_url":"https://api.github.com/users/96boards/received_events","type":"Organization","site_admin":false},"repo":{"id":30957485,"name":"arm-trusted-firmware","full_name":"96boards/arm-trusted-firmware","owner":{"login":"96boards","id":10862183,"avatar_url":"https://avatars.githubusercontent.com/u/10862183?v=3","gravatar_id":"","url":"https://api.github.com/users/96boards","html_url":"https://github.com/96boards","followers_url":"https://api.github.com/users/96boards/followers","following_url":"https://api.github.com/users/96boards/following{/other_user}","gists_url":"https://api.github.com/users/96boards/gists{/gist_id}","starred_url":"https://api.github.com/users/96boards/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/96boards/subscriptions","organizations_url":"https://api.github.com/users/96boards/orgs","repos_url":"https://api.github.com/users/96boards/repos","events_url":"https://api.github.com/users/96boards/events{/privacy}","received_events_url":"https://api.github.com/users/96boards/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/96boards/arm-trusted-firmware","description":"ARM Trusted Firmware","fork":true,"url":"https://api.github.com/repos/96boards/arm-trusted-firmware","forks_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/forks","keys_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/teams","hooks_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/hooks","issue_events_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues/events{/number}","events_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/events","assignees_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/assignees{/user}","branches_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/branches{/branch}","tags_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/tags","blobs_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/languages","stargazers_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/stargazers","contributors_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/contributors","subscribers_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/subscribers","subscription_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/subscription","commits_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/contents/{+path}","compare_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/merges","archive_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/downloads","issues_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues{/number}","pulls_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/labels{/name}","releases_url":"https://api.github.com/repos/96boards/arm-trusted-firmware/releases{/id}","created_at":"2015-02-18T08:23:36Z","updated_at":"2015-03-20T07:45:53Z","pushed_at":"2015-03-20T09:57:42Z","git_url":"git://github.com/96boards/arm-trusted-firmware.git","ssh_url":"git@github.com:96boards/arm-trusted-firmware.git","clone_url":"https://github.com/96boards/arm-trusted-firmware.git","svn_url":"https://github.com/96boards/arm-trusted-firmware","homepage":null,"size":3703,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":1,"default_branch":"hikey"}},"_links":{"self":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/5"},"html":{"href":"https://github.com/96boards/arm-trusted-firmware/pull/5"},"issue":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues/5"},"comments":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/96boards/arm-trusted-firmware/statuses/d4727c7bfe87f3dd115b6b2beb24c923e31c7c38"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":0,"deletions":4,"changed_files":1}}