{"action":"created","issue":{"url":"https://api.github.com/repos/INN/Largo/issues/820","labels_url":"https://api.github.com/repos/INN/Largo/issues/820/labels{/name}","comments_url":"https://api.github.com/repos/INN/Largo/issues/820/comments","events_url":"https://api.github.com/repos/INN/Largo/issues/820/events","html_url":"https://github.com/INN/Largo/pull/820","id":99090345,"number":820,"title":"Footer options megapull","user":{"login":"benlk","id":1754187,"avatar_url":"https://avatars.githubusercontent.com/u/1754187?v=3","gravatar_id":"","url":"https://api.github.com/users/benlk","html_url":"https://github.com/benlk","followers_url":"https://api.github.com/users/benlk/followers","following_url":"https://api.github.com/users/benlk/following{/other_user}","gists_url":"https://api.github.com/users/benlk/gists{/gist_id}","starred_url":"https://api.github.com/users/benlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlk/subscriptions","organizations_url":"https://api.github.com/users/benlk/orgs","repos_url":"https://api.github.com/users/benlk/repos","events_url":"https://api.github.com/users/benlk/events{/privacy}","received_events_url":"https://api.github.com/users/benlk/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/INN/Largo/labels/status:%20needs%20review","name":"status: needs review","color":"09c9ff"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/INN/Largo/milestones/11","html_url":"https://github.com/INN/Largo/milestones/0.5.2%20-%20Bugfixes%20Only%20(Please)","labels_url":"https://api.github.com/repos/INN/Largo/milestones/11/labels","id":1205161,"number":11,"title":"0.5.2 - Bugfixes Only (Please)","description":"","creator":{"login":"aschweigert","id":490703,"avatar_url":"https://avatars.githubusercontent.com/u/490703?v=3","gravatar_id":"","url":"https://api.github.com/users/aschweigert","html_url":"https://github.com/aschweigert","followers_url":"https://api.github.com/users/aschweigert/followers","following_url":"https://api.github.com/users/aschweigert/following{/other_user}","gists_url":"https://api.github.com/users/aschweigert/gists{/gist_id}","starred_url":"https://api.github.com/users/aschweigert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschweigert/subscriptions","organizations_url":"https://api.github.com/users/aschweigert/orgs","repos_url":"https://api.github.com/users/aschweigert/repos","events_url":"https://api.github.com/users/aschweigert/events{/privacy}","received_events_url":"https://api.github.com/users/aschweigert/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":2,"state":"open","created_at":"2015-07-13T14:13:24Z","updated_at":"2015-08-05T00:39:25Z","due_on":"2015-08-07T04:00:00Z","closed_at":null},"comments":1,"created_at":"2015-08-05T00:39:25Z","updated_at":"2015-08-05T19:14:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/INN/Largo/pulls/820","html_url":"https://github.com/INN/Largo/pull/820","diff_url":"https://github.com/INN/Largo/pull/820.diff","patch_url":"https://github.com/INN/Largo/pull/820.patch"},"body":"## To do\r\n\r\n- [x] fix widget area not getting registered in 4col-asymm layout\r\n- [ ] check against all member child themes\r\n    - SE Energy News\r\n    - INVW\r\n    - FE\r\n    - NPQ\r\n- [ ] find member child themes that modify the boilerplate\r\n- [x] check against other browsers, this only thoroughly tested in Chrome/ium\r\n    - [x] IE9 in win7\r\n    - [x] safari 8\r\n    - [x] firefox 39\r\n- [ ] check that the advice in `partials/footer-widget-area.php` is correct and functional\r\n\r\n## Changes\r\n\r\n- stubbed tests for `/inc/header-footer.php`\r\n- tests for `inn_logo` and `largo_social_links`\r\n\r\n#### Images\r\n\r\nINN's normal, dark-on-light logo is now available at `img/inn_logo_blue_final.png`\r\n\r\nIf the INN logo images need to be replaced, some assumptions will need to be updated in `less/inc/footer.less`. These assumptions are documented there and in `img/README.md`\r\n\r\n#### new footer options\r\n\r\n`partials/footer-widget-area.php` has been broken into a number of partials. The `of_get_option('footer_layout')` layout is loaded with `get_template_part( 'partials/footer-widget', $layout);` if the template part is locatable with `locate_template`, otherwise it falls back to `3col-default`.\r\n\r\nDocumentation is included in `partials/footer-widget-area.php` for theme authors who want to add their own footer template, including instructions how to filter the options array.\r\n\r\n- asymmetrical 4-column layout\r\n\r\n<img width=\"1199\" alt=\"screen shot 2015-08-04 at 8 38 32 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9075890/d2acf6c0-3ae8-11e5-808b-72ecc6814e62.png\">\r\n\r\n- centered one-column layout, which will mess up some widgets\r\n\r\n<img width=\"1201\" alt=\"screen shot 2015-08-04 at 8 39 49 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9075904/02bf1e1a-3ae9-11e5-9ed9-746055520755.png\">\r\n\r\n#### footer boilerplate changes\r\n\r\n<img width=\"1048\" alt=\"screen shot 2015-08-04 at 4 38 48 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9072114/52987eb2-3ac7-11e5-9c2a-185c2ac76371.png\">\r\n\r\n<img width=\"900\" alt=\"screen shot 2015-08-04 at 4 39 11 pm\" src=\"https://cloud.githubusercontent.com/assets/1754187/9072124/635372c0-3ac7-11e5-9cfc-9579772cd9df.png\">\r\n\r\n- footer collapses to centered single-column layout at 969px\r\n- inn logo is now output by the new pluggable function `inn_logo`, so the default light-on-dark function can be swapped with the dark-on-light image. Documentation for this is in the images folder's new `README.md` and in `partials/footer-boilerplate.php`\r\n- inn logo becomes smaller\r\n- social media icons become smaller, appear vertically centered with the inn logo. **This may conflict/be overridden by child theme CSS**, as the `#footer` selector is now `ul#footer`.\r\n- reword the footer credit\r\n- remove the \"Inn Member Since\" credit\r\n- boilerplate is now span6/span6, changed form span9/span3. **This may break child theme CSS**\r\n\r\n## Why\r\n\r\n- #761 and [FE-146](http://jira.inn.org/browse/FE-146)"},"comment":{"url":"https://api.github.com/repos/INN/Largo/issues/comments/128114538","html_url":"https://github.com/INN/Largo/pull/820#issuecomment-128114538","issue_url":"https://api.github.com/repos/INN/Largo/issues/820","id":128114538,"user":{"login":"aschweigert","id":490703,"avatar_url":"https://avatars.githubusercontent.com/u/490703?v=3","gravatar_id":"","url":"https://api.github.com/users/aschweigert","html_url":"https://github.com/aschweigert","followers_url":"https://api.github.com/users/aschweigert/followers","following_url":"https://api.github.com/users/aschweigert/following{/other_user}","gists_url":"https://api.github.com/users/aschweigert/gists{/gist_id}","starred_url":"https://api.github.com/users/aschweigert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aschweigert/subscriptions","organizations_url":"https://api.github.com/users/aschweigert/orgs","repos_url":"https://api.github.com/users/aschweigert/repos","events_url":"https://api.github.com/users/aschweigert/events{/privacy}","received_events_url":"https://api.github.com/users/aschweigert/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T19:14:31Z","updated_at":"2015-08-05T19:14:31Z","body":"Given that we now have literally a billion different options here, I'm pretty strongly in favor of making people pick one and remove all overriding partials and css from child themes (for the sites hosted with us anyway).\r\n\r\nFor the sites we designed/built we DEFINITELY should do this (and I don't think we really need to even run it by people, tbh, because it won't be a significant change). For the ones built by someone else we should let them know and give them a deadline to switch over before removing it from their child themes (unless they present a really compelling argument why it needs to remain the way it is now)"}}