{"push_id":578621081,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"1c824127634e932d091bcaf374794f44a8eec4a1","before":"47e8b225a521b0f55643a6f6331ccceafda19d0e","commits":[{"sha":"ca71ceb7064fc08c7aee5ee6d0a1d9dbe2640814","author":{"email":"2d1e1b620879a2330241034f908c878d89499102@gmail.com","name":"Bartosz Dziewoński"},"message":"TextInputWidget: Deprecate 'icon' and 'indicator' events\n\nThe functionality they expose (user clicking on the icon/indicator) is\nfundamentally not accessible: the icon/indicator is not focusable (has\nno tabindex), has no keyboard events, doesn't have a label associated\nor a tooltip, and has no sensible way of fixing all of this.\n\nIf something needs to be clickable separately, it should probably be a\nseparate Widget with the appropriate mixins added.\n\nExample code change replacing the usage of 'indicator' event:\nhttps://git.wikimedia.org/blobdiff/oojs%2Fui/9b327d95578cf7e76c704ad31e49727e7ae7c6d9/src%2Fwidgets%2FComboBoxWidget.js\n\nChange-Id: I944bd1d3416b066b3283613d73fdf3dd61860c70","distinct":true,"url":"https://api.github.com/repos/wikimedia/oojs-ui/commits/ca71ceb7064fc08c7aee5ee6d0a1d9dbe2640814"},{"sha":"1c824127634e932d091bcaf374794f44a8eec4a1","author":{"email":"61a1c7c885f4fc173424af2875d459c32bdc4fee@gerrit.wikimedia.org","name":"jenkins-bot"},"message":"Merge \"TextInputWidget: Deprecate 'icon' and 'indicator' events\"","distinct":true,"url":"https://api.github.com/repos/wikimedia/oojs-ui/commits/1c824127634e932d091bcaf374794f44a8eec4a1"}]}