{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/5","id":51288851,"html_url":"https://github.com/jkakar/aws-erlang-metadata/pull/5","diff_url":"https://github.com/jkakar/aws-erlang-metadata/pull/5.diff","patch_url":"https://github.com/jkakar/aws-erlang-metadata/pull/5.patch","issue_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues/5","number":5,"state":"closed","locked":false,"title":"Allow the app to boot optionally without creds","user":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"body":"In some cases, the application could be used as part of a dual scheme\r\nwhere the app is used as a primary mechanism but where a failover\r\nauthentication scheme exists.\r\n\r\nIn such cases, wanting the app not to go down entirely when AWS metadata\r\nis available, but instead returning `undefined`, can be desireable.\r\n\r\nThis patch adds a configuration value that optionally allows the app not\r\nto fail on boot when AWS metadata isn't available.\r\n\r\nOther changes:\r\n\r\n- Rename 'aws_erlang' in rebar.config to 'aws', the actual app name, so\r\n  that dialyzer and other tools can properly find it.\r\n- Change the URL input to talk with hackney to a binary() from an\r\n  iolist() following Dialyzer recommendations.","created_at":"2015-11-19T22:11:01Z","updated_at":"2015-11-19T23:00:24Z","closed_at":"2015-11-19T23:00:24Z","merged_at":"2015-11-19T23:00:24Z","merge_commit_sha":"1fec94bd7ef75dc3787ce2f3c59c4ba6a1743a7a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/5/commits","review_comments_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/5/comments","review_comment_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues/5/comments","statuses_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/statuses/294a128028ac531838f19904782e8b1c720695b5","head":{"label":"ferd:make-failure-optional","ref":"make-failure-optional","sha":"294a128028ac531838f19904782e8b1c720695b5","user":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"repo":{"id":46523434,"name":"aws-erlang-metadata","full_name":"ferd/aws-erlang-metadata","owner":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferd/aws-erlang-metadata","description":"AWS instance metadata support for aws-erlang.","fork":true,"url":"https://api.github.com/repos/ferd/aws-erlang-metadata","forks_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/forks","keys_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/teams","hooks_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/hooks","issue_events_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/issues/events{/number}","events_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/events","assignees_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/assignees{/user}","branches_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/branches{/branch}","tags_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/tags","blobs_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/statuses/{sha}","languages_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/languages","stargazers_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/stargazers","contributors_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/contributors","subscribers_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/subscribers","subscription_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/subscription","commits_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/contents/{+path}","compare_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/merges","archive_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/downloads","issues_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/issues{/number}","pulls_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/pulls{/number}","milestones_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/milestones{/number}","notifications_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/labels{/name}","releases_url":"https://api.github.com/repos/ferd/aws-erlang-metadata/releases{/id}","created_at":"2015-11-19T22:09:36Z","updated_at":"2015-11-19T22:09:37Z","pushed_at":"2015-11-19T22:10:37Z","git_url":"git://github.com/ferd/aws-erlang-metadata.git","ssh_url":"git@github.com:ferd/aws-erlang-metadata.git","clone_url":"https://github.com/ferd/aws-erlang-metadata.git","svn_url":"https://github.com/ferd/aws-erlang-metadata","homepage":null,"size":904,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jkakar:master","ref":"master","sha":"99fb439ef78d5e41a282931ef1dbc106fb81d0fc","user":{"login":"jkakar","id":563398,"avatar_url":"https://avatars.githubusercontent.com/u/563398?v=3","gravatar_id":"","url":"https://api.github.com/users/jkakar","html_url":"https://github.com/jkakar","followers_url":"https://api.github.com/users/jkakar/followers","following_url":"https://api.github.com/users/jkakar/following{/other_user}","gists_url":"https://api.github.com/users/jkakar/gists{/gist_id}","starred_url":"https://api.github.com/users/jkakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkakar/subscriptions","organizations_url":"https://api.github.com/users/jkakar/orgs","repos_url":"https://api.github.com/users/jkakar/repos","events_url":"https://api.github.com/users/jkakar/events{/privacy}","received_events_url":"https://api.github.com/users/jkakar/received_events","type":"User","site_admin":false},"repo":{"id":45225140,"name":"aws-erlang-metadata","full_name":"jkakar/aws-erlang-metadata","owner":{"login":"jkakar","id":563398,"avatar_url":"https://avatars.githubusercontent.com/u/563398?v=3","gravatar_id":"","url":"https://api.github.com/users/jkakar","html_url":"https://github.com/jkakar","followers_url":"https://api.github.com/users/jkakar/followers","following_url":"https://api.github.com/users/jkakar/following{/other_user}","gists_url":"https://api.github.com/users/jkakar/gists{/gist_id}","starred_url":"https://api.github.com/users/jkakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkakar/subscriptions","organizations_url":"https://api.github.com/users/jkakar/orgs","repos_url":"https://api.github.com/users/jkakar/repos","events_url":"https://api.github.com/users/jkakar/events{/privacy}","received_events_url":"https://api.github.com/users/jkakar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jkakar/aws-erlang-metadata","description":"AWS instance metadata support for aws-erlang.","fork":false,"url":"https://api.github.com/repos/jkakar/aws-erlang-metadata","forks_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/forks","keys_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/teams","hooks_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/hooks","issue_events_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues/events{/number}","events_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/events","assignees_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/assignees{/user}","branches_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/branches{/branch}","tags_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/tags","blobs_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/git/refs{/sha}","trees_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/statuses/{sha}","languages_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/languages","stargazers_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/stargazers","contributors_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/contributors","subscribers_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/subscribers","subscription_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/subscription","commits_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/commits{/sha}","git_commits_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/git/commits{/sha}","comments_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/comments{/number}","issue_comment_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues/comments{/number}","contents_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/contents/{+path}","compare_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/merges","archive_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/downloads","issues_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues{/number}","pulls_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls{/number}","milestones_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/milestones{/number}","notifications_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/labels{/name}","releases_url":"https://api.github.com/repos/jkakar/aws-erlang-metadata/releases{/id}","created_at":"2015-10-30T02:49:17Z","updated_at":"2015-11-19T22:37:58Z","pushed_at":"2015-11-19T23:00:24Z","git_url":"git://github.com/jkakar/aws-erlang-metadata.git","ssh_url":"git@github.com:jkakar/aws-erlang-metadata.git","clone_url":"https://github.com/jkakar/aws-erlang-metadata.git","svn_url":"https://github.com/jkakar/aws-erlang-metadata","homepage":null,"size":1072,"stargazers_count":2,"watchers_count":2,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/5"},"html":{"href":"https://github.com/jkakar/aws-erlang-metadata/pull/5"},"issue":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues/5"},"comments":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/jkakar/aws-erlang-metadata/statuses/294a128028ac531838f19904782e8b1c720695b5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jkakar","id":563398,"avatar_url":"https://avatars.githubusercontent.com/u/563398?v=3","gravatar_id":"","url":"https://api.github.com/users/jkakar","html_url":"https://github.com/jkakar","followers_url":"https://api.github.com/users/jkakar/followers","following_url":"https://api.github.com/users/jkakar/following{/other_user}","gists_url":"https://api.github.com/users/jkakar/gists{/gist_id}","starred_url":"https://api.github.com/users/jkakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkakar/subscriptions","organizations_url":"https://api.github.com/users/jkakar/orgs","repos_url":"https://api.github.com/users/jkakar/repos","events_url":"https://api.github.com/users/jkakar/events{/privacy}","received_events_url":"https://api.github.com/users/jkakar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":53,"deletions":16,"changed_files":5}}