{"action":"created","issue":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2073","labels_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2073/labels{/name}","comments_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2073/comments","events_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2073/events","html_url":"https://github.com/openmicroscopy/bioformats/pull/2073","id":115773369,"number":2073,"title":"Fake: warn on invalid physical sizes","user":{"login":"melissalinkert","id":109998,"avatar_url":"https://avatars.githubusercontent.com/u/109998?v=3","gravatar_id":"","url":"https://api.github.com/users/melissalinkert","html_url":"https://github.com/melissalinkert","followers_url":"https://api.github.com/users/melissalinkert/followers","following_url":"https://api.github.com/users/melissalinkert/following{/other_user}","gists_url":"https://api.github.com/users/melissalinkert/gists{/gist_id}","starred_url":"https://api.github.com/users/melissalinkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissalinkert/subscriptions","organizations_url":"https://api.github.com/users/melissalinkert/orgs","repos_url":"https://api.github.com/users/melissalinkert/repos","events_url":"https://api.github.com/users/melissalinkert/events{/privacy}","received_events_url":"https://api.github.com/users/melissalinkert/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openmicroscopy/bioformats/labels/dev_5_1","name":"dev_5_1","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-09T00:45:01Z","updated_at":"2015-11-09T15:17:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/pulls/2073","html_url":"https://github.com/openmicroscopy/bioformats/pull/2073","diff_url":"https://github.com/openmicroscopy/bioformats/pull/2073.diff","patch_url":"https://github.com/openmicroscopy/bioformats/pull/2073.patch"},"body":"This warns instead of throwing an exception, and ensures that physical\r\nsizes of 0.0 are not allowed.\r\n\r\nTo test, compare the behavior of ```showinf -nopix -omexml fake/samples/emptySizes&physicalSizeX=0.0.fake```.  Without this change, XML validation should fail; with this change, PhysicalSizeX should not be populated at all."},"comment":{"url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/comments/155092908","html_url":"https://github.com/openmicroscopy/bioformats/pull/2073#issuecomment-155092908","issue_url":"https://api.github.com/repos/openmicroscopy/bioformats/issues/2073","id":155092908,"user":{"login":"sbesson","id":1355463,"avatar_url":"https://avatars.githubusercontent.com/u/1355463?v=3","gravatar_id":"","url":"https://api.github.com/users/sbesson","html_url":"https://github.com/sbesson","followers_url":"https://api.github.com/users/sbesson/followers","following_url":"https://api.github.com/users/sbesson/following{/other_user}","gists_url":"https://api.github.com/users/sbesson/gists{/gist_id}","starred_url":"https://api.github.com/users/sbesson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbesson/subscriptions","organizations_url":"https://api.github.com/users/sbesson/orgs","repos_url":"https://api.github.com/users/sbesson/repos","events_url":"https://api.github.com/users/sbesson/events{/privacy}","received_events_url":"https://api.github.com/users/sbesson/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T15:17:31Z","updated_at":"2015-11-09T15:17:31Z","body":"https://ci.openmicroscopy.org/job/BIOFORMATS-5.1-merge-repository-subset/134/console is passing with this PR included. Tested the following fake files:\r\n\r\n```\r\ntest&physicalSizeX=1.0s.fake ->  physical size X set\r\ntest&physicalSizeX=0.0.fake -> physical size X unset\r\ntest&physicalSizeX=0.0000011m.fake ->  physical size X set\r\ntest&physicalSizeX=0.000001m.fake -> physical size X unset\r\ntest&physicalSizeX=1.0s.fake -> physical size X unset + warning message\r\n```\r\n\r\nLooks good to merge."}}