{"action":"opened","number":371,"pull_request":{"url":"https://api.github.com/repos/non/cats/pulls/371","id":38369996,"html_url":"https://github.com/non/cats/pull/371","diff_url":"https://github.com/non/cats/pull/371.diff","patch_url":"https://github.com/non/cats/pull/371.patch","issue_url":"https://api.github.com/repos/non/cats/issues/371","number":371,"state":"open","locked":false,"title":"Fixed typo in the output of Const.show","user":{"login":"mikejcurry","id":10455080,"avatar_url":"https://avatars.githubusercontent.com/u/10455080?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejcurry","html_url":"https://github.com/mikejcurry","followers_url":"https://api.github.com/users/mikejcurry/followers","following_url":"https://api.github.com/users/mikejcurry/following{/other_user}","gists_url":"https://api.github.com/users/mikejcurry/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejcurry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejcurry/subscriptions","organizations_url":"https://api.github.com/users/mikejcurry/orgs","repos_url":"https://api.github.com/users/mikejcurry/repos","events_url":"https://api.github.com/users/mikejcurry/events{/privacy}","received_events_url":"https://api.github.com/users/mikejcurry/received_events","type":"User","site_admin":false},"body":"Const.show was outputting an extra } after the Const value as part of\nthe string generated. Updated code to render as Const(value) instead of\nConst(value}), which is consistent with the other show methods.\n\nThis PR is kind of a test bed for me, I’m really just learning github and trying to get a feel for cats, which is where I came across the inconsistency in the text generated.\n\nI’ve not added a test as part of this, but happy to add one. The only reason I have not added a test to verify the output is as expected is because it didn’t seem to fit with the other tests in ConstTest.scala which all seemed to be related to law checking, so I wasn’t sure whether you had alternative approach for these kinds of tests or not.\n\nMore than happy to create some tests around this (and the same for other classes), if it is useful.","created_at":"2015-06-23T18:52:15Z","updated_at":"2015-06-23T18:52:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/non/cats/pulls/371/commits","review_comments_url":"https://api.github.com/repos/non/cats/pulls/371/comments","review_comment_url":"https://api.github.com/repos/non/cats/pulls/comments{/number}","comments_url":"https://api.github.com/repos/non/cats/issues/371/comments","statuses_url":"https://api.github.com/repos/non/cats/statuses/60fa989497e6211b0ba9188f18ef40e053497465","head":{"label":"mikejcurry:master","ref":"master","sha":"60fa989497e6211b0ba9188f18ef40e053497465","user":{"login":"mikejcurry","id":10455080,"avatar_url":"https://avatars.githubusercontent.com/u/10455080?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejcurry","html_url":"https://github.com/mikejcurry","followers_url":"https://api.github.com/users/mikejcurry/followers","following_url":"https://api.github.com/users/mikejcurry/following{/other_user}","gists_url":"https://api.github.com/users/mikejcurry/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejcurry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejcurry/subscriptions","organizations_url":"https://api.github.com/users/mikejcurry/orgs","repos_url":"https://api.github.com/users/mikejcurry/repos","events_url":"https://api.github.com/users/mikejcurry/events{/privacy}","received_events_url":"https://api.github.com/users/mikejcurry/received_events","type":"User","site_admin":false},"repo":{"id":37745233,"name":"cats","full_name":"mikejcurry/cats","owner":{"login":"mikejcurry","id":10455080,"avatar_url":"https://avatars.githubusercontent.com/u/10455080?v=3","gravatar_id":"","url":"https://api.github.com/users/mikejcurry","html_url":"https://github.com/mikejcurry","followers_url":"https://api.github.com/users/mikejcurry/followers","following_url":"https://api.github.com/users/mikejcurry/following{/other_user}","gists_url":"https://api.github.com/users/mikejcurry/gists{/gist_id}","starred_url":"https://api.github.com/users/mikejcurry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikejcurry/subscriptions","organizations_url":"https://api.github.com/users/mikejcurry/orgs","repos_url":"https://api.github.com/users/mikejcurry/repos","events_url":"https://api.github.com/users/mikejcurry/events{/privacy}","received_events_url":"https://api.github.com/users/mikejcurry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikejcurry/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":true,"url":"https://api.github.com/repos/mikejcurry/cats","forks_url":"https://api.github.com/repos/mikejcurry/cats/forks","keys_url":"https://api.github.com/repos/mikejcurry/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikejcurry/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikejcurry/cats/teams","hooks_url":"https://api.github.com/repos/mikejcurry/cats/hooks","issue_events_url":"https://api.github.com/repos/mikejcurry/cats/issues/events{/number}","events_url":"https://api.github.com/repos/mikejcurry/cats/events","assignees_url":"https://api.github.com/repos/mikejcurry/cats/assignees{/user}","branches_url":"https://api.github.com/repos/mikejcurry/cats/branches{/branch}","tags_url":"https://api.github.com/repos/mikejcurry/cats/tags","blobs_url":"https://api.github.com/repos/mikejcurry/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikejcurry/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikejcurry/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikejcurry/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikejcurry/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/mikejcurry/cats/languages","stargazers_url":"https://api.github.com/repos/mikejcurry/cats/stargazers","contributors_url":"https://api.github.com/repos/mikejcurry/cats/contributors","subscribers_url":"https://api.github.com/repos/mikejcurry/cats/subscribers","subscription_url":"https://api.github.com/repos/mikejcurry/cats/subscription","commits_url":"https://api.github.com/repos/mikejcurry/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikejcurry/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikejcurry/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikejcurry/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikejcurry/cats/contents/{+path}","compare_url":"https://api.github.com/repos/mikejcurry/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikejcurry/cats/merges","archive_url":"https://api.github.com/repos/mikejcurry/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikejcurry/cats/downloads","issues_url":"https://api.github.com/repos/mikejcurry/cats/issues{/number}","pulls_url":"https://api.github.com/repos/mikejcurry/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/mikejcurry/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/mikejcurry/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikejcurry/cats/labels{/name}","releases_url":"https://api.github.com/repos/mikejcurry/cats/releases{/id}","created_at":"2015-06-19T20:51:26Z","updated_at":"2015-06-19T20:51:28Z","pushed_at":"2015-06-23T18:52:13Z","git_url":"git://github.com/mikejcurry/cats.git","ssh_url":"git@github.com:mikejcurry/cats.git","clone_url":"https://github.com/mikejcurry/cats.git","svn_url":"https://github.com/mikejcurry/cats","homepage":"http://non.github.io/cats/","size":3625,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"non:master","ref":"master","sha":"bfe1fade00f1646ee00504543ec9dcf8b439ef64","user":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"repo":{"id":29986727,"name":"cats","full_name":"non/cats","owner":{"login":"non","id":218045,"avatar_url":"https://avatars.githubusercontent.com/u/218045?v=3","gravatar_id":"","url":"https://api.github.com/users/non","html_url":"https://github.com/non","followers_url":"https://api.github.com/users/non/followers","following_url":"https://api.github.com/users/non/following{/other_user}","gists_url":"https://api.github.com/users/non/gists{/gist_id}","starred_url":"https://api.github.com/users/non/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/non/subscriptions","organizations_url":"https://api.github.com/users/non/orgs","repos_url":"https://api.github.com/users/non/repos","events_url":"https://api.github.com/users/non/events{/privacy}","received_events_url":"https://api.github.com/users/non/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/non/cats","description":"Lightweight, modular, and extensible library for functional programming.","fork":false,"url":"https://api.github.com/repos/non/cats","forks_url":"https://api.github.com/repos/non/cats/forks","keys_url":"https://api.github.com/repos/non/cats/keys{/key_id}","collaborators_url":"https://api.github.com/repos/non/cats/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/non/cats/teams","hooks_url":"https://api.github.com/repos/non/cats/hooks","issue_events_url":"https://api.github.com/repos/non/cats/issues/events{/number}","events_url":"https://api.github.com/repos/non/cats/events","assignees_url":"https://api.github.com/repos/non/cats/assignees{/user}","branches_url":"https://api.github.com/repos/non/cats/branches{/branch}","tags_url":"https://api.github.com/repos/non/cats/tags","blobs_url":"https://api.github.com/repos/non/cats/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/non/cats/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/non/cats/git/refs{/sha}","trees_url":"https://api.github.com/repos/non/cats/git/trees{/sha}","statuses_url":"https://api.github.com/repos/non/cats/statuses/{sha}","languages_url":"https://api.github.com/repos/non/cats/languages","stargazers_url":"https://api.github.com/repos/non/cats/stargazers","contributors_url":"https://api.github.com/repos/non/cats/contributors","subscribers_url":"https://api.github.com/repos/non/cats/subscribers","subscription_url":"https://api.github.com/repos/non/cats/subscription","commits_url":"https://api.github.com/repos/non/cats/commits{/sha}","git_commits_url":"https://api.github.com/repos/non/cats/git/commits{/sha}","comments_url":"https://api.github.com/repos/non/cats/comments{/number}","issue_comment_url":"https://api.github.com/repos/non/cats/issues/comments{/number}","contents_url":"https://api.github.com/repos/non/cats/contents/{+path}","compare_url":"https://api.github.com/repos/non/cats/compare/{base}...{head}","merges_url":"https://api.github.com/repos/non/cats/merges","archive_url":"https://api.github.com/repos/non/cats/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/non/cats/downloads","issues_url":"https://api.github.com/repos/non/cats/issues{/number}","pulls_url":"https://api.github.com/repos/non/cats/pulls{/number}","milestones_url":"https://api.github.com/repos/non/cats/milestones{/number}","notifications_url":"https://api.github.com/repos/non/cats/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/non/cats/labels{/name}","releases_url":"https://api.github.com/repos/non/cats/releases{/id}","created_at":"2015-01-28T20:26:48Z","updated_at":"2015-06-23T04:38:26Z","pushed_at":"2015-06-23T06:34:02Z","git_url":"git://github.com/non/cats.git","ssh_url":"git@github.com:non/cats.git","clone_url":"https://github.com/non/cats.git","svn_url":"https://github.com/non/cats","homepage":"http://non.github.io/cats/","size":5620,"stargazers_count":415,"watchers_count":415,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"open_issues_count":53,"forks":78,"open_issues":53,"watchers":415,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/non/cats/pulls/371"},"html":{"href":"https://github.com/non/cats/pull/371"},"issue":{"href":"https://api.github.com/repos/non/cats/issues/371"},"comments":{"href":"https://api.github.com/repos/non/cats/issues/371/comments"},"review_comments":{"href":"https://api.github.com/repos/non/cats/pulls/371/comments"},"review_comment":{"href":"https://api.github.com/repos/non/cats/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/non/cats/pulls/371/commits"},"statuses":{"href":"https://api.github.com/repos/non/cats/statuses/60fa989497e6211b0ba9188f18ef40e053497465"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}