{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39468631","id":39468631,"diff_hunk":"@@ -60,6 +60,7 @@ import (\n \t\"k8s.io/kubernetes/pkg/util\"\n \t\"k8s.io/kubernetes/pkg/util/bandwidth\"\n \tutilErrors \"k8s.io/kubernetes/pkg/util/errors\"\n+\tkubeioutil \"k8s.io/kubernetes/pkg/util/io\"","path":"pkg/kubelet/kubelet.go","position":4,"original_position":4,"commit_id":"3376b43e143efcb318f7aba1bd182f91bab271c0","original_commit_id":"3376b43e143efcb318f7aba1bd182f91bab271c0","user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"body":"ioutil to match the stdlib?  minor point really.\n\nOn Mon, Sep 14, 2015 at 9:17 PM, Tim Hockin <notifications@github.com>\nwrote:\n\n> In pkg/kubelet/kubelet.go\n> <https://github.com/kubernetes/kubernetes/pull/13791#discussion_r39465928>\n> :\n>\n> > @@ -60,6 +60,7 @@ import (\n> >  \t\"k8s.io/kubernetes/pkg/util\"\n> >  \t\"k8s.io/kubernetes/pkg/util/bandwidth\"\n> >  \tutilErrors \"k8s.io/kubernetes/pkg/util/errors\"\n> > +\tkubeioutil \"k8s.io/kubernetes/pkg/util/io\"\n>\n> utilio ?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/kubernetes/kubernetes/pull/13791/files#r39465928>.\n>\n\n\n\n-- \nClayton Coleman | Lead Engineer, OpenShift\n","created_at":"2015-09-15T02:20:07Z","updated_at":"2015-09-15T02:20:07Z","html_url":"https://github.com/kubernetes/kubernetes/pull/13791#discussion_r39468631","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/39468631"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13791#discussion_r39468631"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791","id":44661618,"html_url":"https://github.com/kubernetes/kubernetes/pull/13791","diff_url":"https://github.com/kubernetes/kubernetes/pull/13791.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/13791.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13791","number":13791,"state":"open","locked":false,"title":"Fix secrets in kubelet running in a container","user":{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},"body":"Fixes #13557\r\n\r\nIntroduce writer interface that could be used by volume plugins. This PR provides two implementations:\r\n1. standard implementation that uses golang standard libraries\r\n2. implementation that uses ```nsenter``` to write data in host mount namespace.\r\n\r\n@smarterclayton (who wrote ```nsenter_mounter.go``` which is similar)\r\n@dchen1107 (as this touches kubelet and volume plugins)\r\n@dalanlan @resouer (who are interested in running kubernetes in containers)\r\n@brendandburns (who is interested in cluster set up UX)\r\n\r\nRef #4869","created_at":"2015-09-10T12:32:47Z","updated_at":"2015-09-15T02:20:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29d0544102f5fad3252ea42967e7e19244977906","assignee":{"login":"pmorie","id":366488,"avatar_url":"https://avatars.githubusercontent.com/u/366488?v=3","gravatar_id":"","url":"https://api.github.com/users/pmorie","html_url":"https://github.com/pmorie","followers_url":"https://api.github.com/users/pmorie/followers","following_url":"https://api.github.com/users/pmorie/following{/other_user}","gists_url":"https://api.github.com/users/pmorie/gists{/gist_id}","starred_url":"https://api.github.com/users/pmorie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmorie/subscriptions","organizations_url":"https://api.github.com/users/pmorie/orgs","repos_url":"https://api.github.com/users/pmorie/repos","events_url":"https://api.github.com/users/pmorie/events{/privacy}","received_events_url":"https://api.github.com/users/pmorie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/13791/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3376b43e143efcb318f7aba1bd182f91bab271c0","head":{"label":"fgrzadkowski:fix_secrets_in_docker","ref":"fix_secrets_in_docker","sha":"3376b43e143efcb318f7aba1bd182f91bab271c0","user":{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},"repo":{"id":30216861,"name":"kubernetes","full_name":"fgrzadkowski/kubernetes","owner":{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fgrzadkowski/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/fgrzadkowski/kubernetes","forks_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/forks","keys_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/teams","hooks_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/events","assignees_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/tags","blobs_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/languages","stargazers_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/subscription","commits_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/merges","archive_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/downloads","issues_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/fgrzadkowski/kubernetes/releases{/id}","created_at":"2015-02-03T00:40:39Z","updated_at":"2015-03-20T09:51:54Z","pushed_at":"2015-09-14T20:39:54Z","git_url":"git://github.com/fgrzadkowski/kubernetes.git","ssh_url":"git@github.com:fgrzadkowski/kubernetes.git","clone_url":"https://github.com/fgrzadkowski/kubernetes.git","svn_url":"https://github.com/fgrzadkowski/kubernetes","homepage":"http://kubernetes.io","size":107280,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"818946080904c8aef062ef016190830d8dcd1dd6","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-09-15T01:48:48Z","pushed_at":"2015-09-15T02:04:42Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":407660,"stargazers_count":10231,"watchers_count":10231,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2526,"mirror_url":null,"open_issues_count":1764,"forks":2526,"open_issues":1764,"watchers":10231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/13791"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13791"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/13791/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/13791/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/3376b43e143efcb318f7aba1bd182f91bab271c0"}}}}