{"action":"created","comment":{"url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/comments/30641828","id":30641828,"diff_hunk":"@@ -47,7 +47,11 @@ ArgParser filesCommandArgParser() {\n                   help: 'Update the pubspec.yaml file with required '\n                         'dependencies. This will remove comments and might '\n                         'change the layout of the pubspec.yaml file.',\n-                  defaultsTo: 'false');\n+                  defaultsTo: 'false')\n+      ..addFlag('core-prefix',","path":"bin/generate.dart","position":6,"original_position":6,"commit_id":"7e05aca15dbf7ec35af13371f4e02b2f0c0f4e6c","original_commit_id":"7e05aca15dbf7ec35af13371f4e02b2f0c0f4e6c","user":{"login":"mkustermann","id":5757092,"avatar_url":"https://avatars.githubusercontent.com/u/5757092?v=3","gravatar_id":"","url":"https://api.github.com/users/mkustermann","html_url":"https://github.com/mkustermann","followers_url":"https://api.github.com/users/mkustermann/followers","following_url":"https://api.github.com/users/mkustermann/following{/other_user}","gists_url":"https://api.github.com/users/mkustermann/gists{/gist_id}","starred_url":"https://api.github.com/users/mkustermann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkustermann/subscriptions","organizations_url":"https://api.github.com/users/mkustermann/orgs","repos_url":"https://api.github.com/users/mkustermann/repos","events_url":"https://api.github.com/users/mkustermann/events{/privacy}","received_events_url":"https://api.github.com/users/mkustermann/received_events","type":"User","site_admin":false},"body":"Will this allow --enable-core-prefix --disable-core-prefix?\r\n\r\nIf so: What does --core-prefix do?","created_at":"2015-05-19T20:19:20Z","updated_at":"2015-05-19T20:19:20Z","html_url":"https://github.com/dart-lang/discoveryapis_generator/pull/151#discussion_r30641828","pull_request_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151","_links":{"self":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/comments/30641828"},"html":{"href":"https://github.com/dart-lang/discoveryapis_generator/pull/151#discussion_r30641828"},"pull_request":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151"}}},"pull_request":{"url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151","id":35741201,"html_url":"https://github.com/dart-lang/discoveryapis_generator/pull/151","diff_url":"https://github.com/dart-lang/discoveryapis_generator/pull/151.diff","patch_url":"https://github.com/dart-lang/discoveryapis_generator/pull/151.patch","issue_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/151","number":151,"state":"open","locked":false,"title":"address warnings in the generated core; remove the core. prefix","user":{"login":"devoncarew","id":1269969,"avatar_url":"https://avatars.githubusercontent.com/u/1269969?v=3","gravatar_id":"","url":"https://api.github.com/users/devoncarew","html_url":"https://github.com/devoncarew","followers_url":"https://api.github.com/users/devoncarew/followers","following_url":"https://api.github.com/users/devoncarew/following{/other_user}","gists_url":"https://api.github.com/users/devoncarew/gists{/gist_id}","starred_url":"https://api.github.com/users/devoncarew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/devoncarew/subscriptions","organizations_url":"https://api.github.com/users/devoncarew/orgs","repos_url":"https://api.github.com/users/devoncarew/repos","events_url":"https://api.github.com/users/devoncarew/events{/privacy}","received_events_url":"https://api.github.com/users/devoncarew/received_events","type":"User","site_admin":false},"body":"fix #139 \r\nworkaround for #141 \r\n\r\nAdd a cli option to remove the `core.` prefix for `dart:core`. User's can pass on `--no-core-prefix` to remove the prefix from generated code.\r\n\r\nAlso, only add imports for libraries that are referenced in the generated code. We count the number of times a library is used when generating code and only add an import if that library was used at least once. Added tests for the changes to `lib/src/namer.dart`.\r\n\r\nYou can see the changes in `example/dartservices.dart`.\r\n\r\n@mkustermann, @wibling ","created_at":"2015-05-19T15:15:17Z","updated_at":"2015-05-19T20:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec0c4e207d0c1b0f438274d6baf638e3fa960093","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151/commits","review_comments_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151/comments","review_comment_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/151/comments","statuses_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/statuses/7e05aca15dbf7ec35af13371f4e02b2f0c0f4e6c","head":{"label":"dart-lang:devoncarew_core_prefix","ref":"devoncarew_core_prefix","sha":"7e05aca15dbf7ec35af13371f4e02b2f0c0f4e6c","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":7549982,"name":"discoveryapis_generator","full_name":"dart-lang/discoveryapis_generator","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/discoveryapis_generator","description":"Create API Client libraries based on the API's Discovery documentation","fork":false,"url":"https://api.github.com/repos/dart-lang/discoveryapis_generator","forks_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/forks","keys_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/teams","hooks_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/events","assignees_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/tags","blobs_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/languages","stargazers_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/subscription","commits_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/merges","archive_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/downloads","issues_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/releases{/id}","created_at":"2013-01-10T22:31:27Z","updated_at":"2015-05-03T09:31:52Z","pushed_at":"2015-05-19T15:15:18Z","git_url":"git://github.com/dart-lang/discoveryapis_generator.git","ssh_url":"git@github.com:dart-lang/discoveryapis_generator.git","clone_url":"https://github.com/dart-lang/discoveryapis_generator.git","svn_url":"https://github.com/dart-lang/discoveryapis_generator","homepage":null,"size":1950,"stargazers_count":60,"watchers_count":60,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":9,"forks":24,"open_issues":9,"watchers":60,"default_branch":"master"}},"base":{"label":"dart-lang:master","ref":"master","sha":"6a774b28157a815bc927643d20bf5f8900afbbac","user":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":7549982,"name":"discoveryapis_generator","full_name":"dart-lang/discoveryapis_generator","owner":{"login":"dart-lang","id":1609975,"avatar_url":"https://avatars.githubusercontent.com/u/1609975?v=3","gravatar_id":"","url":"https://api.github.com/users/dart-lang","html_url":"https://github.com/dart-lang","followers_url":"https://api.github.com/users/dart-lang/followers","following_url":"https://api.github.com/users/dart-lang/following{/other_user}","gists_url":"https://api.github.com/users/dart-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/dart-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dart-lang/subscriptions","organizations_url":"https://api.github.com/users/dart-lang/orgs","repos_url":"https://api.github.com/users/dart-lang/repos","events_url":"https://api.github.com/users/dart-lang/events{/privacy}","received_events_url":"https://api.github.com/users/dart-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dart-lang/discoveryapis_generator","description":"Create API Client libraries based on the API's Discovery documentation","fork":false,"url":"https://api.github.com/repos/dart-lang/discoveryapis_generator","forks_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/forks","keys_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/teams","hooks_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/hooks","issue_events_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/events{/number}","events_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/events","assignees_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/assignees{/user}","branches_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/branches{/branch}","tags_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/tags","blobs_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/refs{/sha}","trees_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/statuses/{sha}","languages_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/languages","stargazers_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/stargazers","contributors_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/contributors","subscribers_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/subscribers","subscription_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/subscription","commits_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/commits{/sha}","git_commits_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/git/commits{/sha}","comments_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/comments{/number}","issue_comment_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/comments{/number}","contents_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/contents/{+path}","compare_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/merges","archive_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/downloads","issues_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues{/number}","pulls_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls{/number}","milestones_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/milestones{/number}","notifications_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/labels{/name}","releases_url":"https://api.github.com/repos/dart-lang/discoveryapis_generator/releases{/id}","created_at":"2013-01-10T22:31:27Z","updated_at":"2015-05-03T09:31:52Z","pushed_at":"2015-05-19T15:15:18Z","git_url":"git://github.com/dart-lang/discoveryapis_generator.git","ssh_url":"git@github.com:dart-lang/discoveryapis_generator.git","clone_url":"https://github.com/dart-lang/discoveryapis_generator.git","svn_url":"https://github.com/dart-lang/discoveryapis_generator","homepage":null,"size":1950,"stargazers_count":60,"watchers_count":60,"language":"Dart","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":9,"forks":24,"open_issues":9,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151"},"html":{"href":"https://github.com/dart-lang/discoveryapis_generator/pull/151"},"issue":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/151"},"comments":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/issues/151/comments"},"review_comments":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151/comments"},"review_comment":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/pulls/151/commits"},"statuses":{"href":"https://api.github.com/repos/dart-lang/discoveryapis_generator/statuses/7e05aca15dbf7ec35af13371f4e02b2f0c0f4e6c"}}}}