{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/69","labels_url":"https://api.github.com/repos/dotnet/coreclr/issues/69/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/69/comments","events_url":"https://api.github.com/repos/dotnet/coreclr/issues/69/events","html_url":"https://github.com/dotnet/coreclr/pull/69","id":56559059,"number":69,"title":"CMake touchups","user":{"login":"mathstuf","id":97253,"avatar_url":"https://avatars.githubusercontent.com/u/97253?v=3","gravatar_id":"","url":"https://api.github.com/users/mathstuf","html_url":"https://github.com/mathstuf","followers_url":"https://api.github.com/users/mathstuf/followers","following_url":"https://api.github.com/users/mathstuf/following{/other_user}","gists_url":"https://api.github.com/users/mathstuf/gists{/gist_id}","starred_url":"https://api.github.com/users/mathstuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathstuf/subscriptions","organizations_url":"https://api.github.com/users/mathstuf/orgs","repos_url":"https://api.github.com/users/mathstuf/repos","events_url":"https://api.github.com/users/mathstuf/events{/privacy}","received_events_url":"https://api.github.com/users/mathstuf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"rahku","id":10636986,"avatar_url":"https://avatars.githubusercontent.com/u/10636986?v=3","gravatar_id":"","url":"https://api.github.com/users/rahku","html_url":"https://github.com/rahku","followers_url":"https://api.github.com/users/rahku/followers","following_url":"https://api.github.com/users/rahku/following{/other_user}","gists_url":"https://api.github.com/users/rahku/gists{/gist_id}","starred_url":"https://api.github.com/users/rahku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rahku/subscriptions","organizations_url":"https://api.github.com/users/rahku/orgs","repos_url":"https://api.github.com/users/rahku/repos","events_url":"https://api.github.com/users/rahku/events{/privacy}","received_events_url":"https://api.github.com/users/rahku/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-02-04T17:27:25Z","updated_at":"2015-02-04T19:36:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/69","html_url":"https://github.com/dotnet/coreclr/pull/69","diff_url":"https://github.com/dotnet/coreclr/pull/69.diff","patch_url":"https://github.com/dotnet/coreclr/pull/69.patch"},"body":"---\r\nSomewhat related to #50. Conflicts at least.\r\n\r\nOther than these simple transformations, I see a few other things which should be addressed:\r\n\r\n  - assumption that `WIN32` means Visual Studio:\r\n    * in some places `CMAKE_CONFIGURATION_TYPES` should be used to detect multi-config generators;\r\n    * `MSVC` should be used to detect the VS compiler;\r\n  - detection of 64-bit should use `CMAKE_SIZEOF_VOID_P` rather than checking the CPU architecture name (though the architecture *should* be detected for arch-specific files elsewhere);\r\n  - I don't think this is [CMP0054](http://www.cmake.org/cmake/help/v3.1/policy/CMP0054.html)-clean, so some things might need cleaning up there where variables expand to `MSVC` or the like (these are usually actual bugs);\r\n  - `target_*` functions could likely be used to cut down on the number of `include_directories` and the like; and\r\n  - the configuration stuff is odd (see #50)."},"comment":{"url":"https://api.github.com/repos/dotnet/coreclr/issues/comments/72922620","html_url":"https://github.com/dotnet/coreclr/pull/69#issuecomment-72922620","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/69","id":72922620,"user":{"login":"AlexGhiondea","id":8396979,"avatar_url":"https://avatars.githubusercontent.com/u/8396979?v=3","gravatar_id":"","url":"https://api.github.com/users/AlexGhiondea","html_url":"https://github.com/AlexGhiondea","followers_url":"https://api.github.com/users/AlexGhiondea/followers","following_url":"https://api.github.com/users/AlexGhiondea/following{/other_user}","gists_url":"https://api.github.com/users/AlexGhiondea/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexGhiondea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexGhiondea/subscriptions","organizations_url":"https://api.github.com/users/AlexGhiondea/orgs","repos_url":"https://api.github.com/users/AlexGhiondea/repos","events_url":"https://api.github.com/users/AlexGhiondea/events{/privacy}","received_events_url":"https://api.github.com/users/AlexGhiondea/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T19:36:04Z","updated_at":"2015-02-04T19:36:04Z","body":"@mathstuf Yes -- that is what I meant. Thank you!"}}