{"action":"closed","issue":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/issues/109","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/issues/109/labels{/name}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/issues/109/comments","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/issues/109/events","html_url":"https://github.com/spring-cloud/spring-cloud-connectors/issues/109","id":64572890,"number":109,"title":"Support Oracle connections that specify an SID instead of a database name","user":{"login":"scottfrederick","id":60661,"avatar_url":"https://avatars.githubusercontent.com/u/60661?v=3","gravatar_id":"","url":"https://api.github.com/users/scottfrederick","html_url":"https://github.com/scottfrederick","followers_url":"https://api.github.com/users/scottfrederick/followers","following_url":"https://api.github.com/users/scottfrederick/following{/other_user}","gists_url":"https://api.github.com/users/scottfrederick/gists{/gist_id}","starred_url":"https://api.github.com/users/scottfrederick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottfrederick/subscriptions","organizations_url":"https://api.github.com/users/scottfrederick/orgs","repos_url":"https://api.github.com/users/scottfrederick/repos","events_url":"https://api.github.com/users/scottfrederick/events{/privacy}","received_events_url":"https://api.github.com/users/scottfrederick/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/milestones/2","html_url":"https://github.com/spring-cloud/spring-cloud-connectors/milestones/1.1.2","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-connectors/milestones/2/labels","id":991621,"number":2,"title":"1.1.2","description":"","creator":{"login":"scottfrederick","id":60661,"avatar_url":"https://avatars.githubusercontent.com/u/60661?v=3","gravatar_id":"","url":"https://api.github.com/users/scottfrederick","html_url":"https://github.com/scottfrederick","followers_url":"https://api.github.com/users/scottfrederick/followers","following_url":"https://api.github.com/users/scottfrederick/following{/other_user}","gists_url":"https://api.github.com/users/scottfrederick/gists{/gist_id}","starred_url":"https://api.github.com/users/scottfrederick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottfrederick/subscriptions","organizations_url":"https://api.github.com/users/scottfrederick/orgs","repos_url":"https://api.github.com/users/scottfrederick/repos","events_url":"https://api.github.com/users/scottfrederick/events{/privacy}","received_events_url":"https://api.github.com/users/scottfrederick/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":13,"state":"open","created_at":"2015-02-23T16:49:37Z","updated_at":"2015-05-11T23:56:46Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2015-03-26T16:26:41Z","updated_at":"2015-05-11T23:56:46Z","closed_at":"2015-05-11T23:56:46Z","body":"`OracleServiceInfo` [builds a JDBC URL](https://github.com/scottfrederick/spring-cloud-connectors/blob/master/spring-cloud-core/src/main/java/org/springframework/cloud/service/common/OracleServiceInfo.java) from the URI provided in the service credentials. The JDBC URL assumes that the path element from the credentials URI is a database name, and precedes it with a \"/\" in the JDBC URL (e.g. `oracle://user:password@host:port/database` in credentials is transformed into `jdbc:oracle:thin:user/password@host:port/database`)\r\n\r\nIf the path element from the credentials URI is an SID instead of a database name, then it should be preceeded by a \":\" in the JDBC URL instead (e.g. `oracle://user:password@host:port/sid` in credentials should be transformed into `jdbc:oracle:thin:user/password@host:port:sid`). \r\n\r\nSee https://community.oracle.com/thread/2290690. \r\n\r\nSupporting both database name and SID might require additional fields in the credentials so `OracleServiceInfo` can get an indication of what the path element of the URI represents. "}}