{"action":"closed","number":41,"pull_request":{"url":"https://api.github.com/repos/nolanlawson/local-npm/pulls/41","id":41405505,"html_url":"https://github.com/nolanlawson/local-npm/pull/41","diff_url":"https://github.com/nolanlawson/local-npm/pull/41.diff","patch_url":"https://github.com/nolanlawson/local-npm/pull/41.patch","issue_url":"https://api.github.com/repos/nolanlawson/local-npm/issues/41","number":41,"state":"closed","locked":false,"title":"(#39 #40) - fix replication over bad connection","user":{"login":"nolanlawson","id":283842,"avatar_url":"https://avatars.githubusercontent.com/u/283842?v=3","gravatar_id":"","url":"https://api.github.com/users/nolanlawson","html_url":"https://github.com/nolanlawson","followers_url":"https://api.github.com/users/nolanlawson/followers","following_url":"https://api.github.com/users/nolanlawson/following{/other_user}","gists_url":"https://api.github.com/users/nolanlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanlawson/subscriptions","organizations_url":"https://api.github.com/users/nolanlawson/orgs","repos_url":"https://api.github.com/users/nolanlawson/repos","events_url":"https://api.github.com/users/nolanlawson/events{/privacy}","received_events_url":"https://api.github.com/users/nolanlawson/received_events","type":"User","site_admin":false},"body":"Added a few workarounds for some PouchDB issues\r\nwhile we wait for those issues to get resolved:\r\n\r\n1) `cancel()` needs to be explicitly called to avoid EventEmitter leaks: (https://github.com/pouchdb/pouchdb/issues/4093)\r\n2) `skimRemote` needs to be re-assigned when `info()` fails because the constructor might have failed. Needs to be resolved by: https://github.com/pouchdb/pouchdb/issues/4057\r\n\r\nI also made turned the errors into warnings and clarified that we are retrying. I tested with an intermittent connection and everything looks good on my end. It's also not restarting replication from 0% every time.","created_at":"2015-08-01T18:10:36Z","updated_at":"2015-08-07T15:02:57Z","closed_at":"2015-08-07T15:02:57Z","merged_at":"2015-08-07T15:02:57Z","merge_commit_sha":"30b091666e5a87bf505b5177107193d3a7e083a2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nolanlawson/local-npm/pulls/41/commits","review_comments_url":"https://api.github.com/repos/nolanlawson/local-npm/pulls/41/comments","review_comment_url":"https://api.github.com/repos/nolanlawson/local-npm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nolanlawson/local-npm/issues/41/comments","statuses_url":"https://api.github.com/repos/nolanlawson/local-npm/statuses/99d85a3ab1b2aee5bd1c99b436813a918adfae7a","head":{"label":"nolanlawson:intermittent-connection","ref":"intermittent-connection","sha":"99d85a3ab1b2aee5bd1c99b436813a918adfae7a","user":{"login":"nolanlawson","id":283842,"avatar_url":"https://avatars.githubusercontent.com/u/283842?v=3","gravatar_id":"","url":"https://api.github.com/users/nolanlawson","html_url":"https://github.com/nolanlawson","followers_url":"https://api.github.com/users/nolanlawson/followers","following_url":"https://api.github.com/users/nolanlawson/following{/other_user}","gists_url":"https://api.github.com/users/nolanlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanlawson/subscriptions","organizations_url":"https://api.github.com/users/nolanlawson/orgs","repos_url":"https://api.github.com/users/nolanlawson/repos","events_url":"https://api.github.com/users/nolanlawson/events{/privacy}","received_events_url":"https://api.github.com/users/nolanlawson/received_events","type":"User","site_admin":false},"repo":{"id":22590963,"name":"local-npm","full_name":"nolanlawson/local-npm","owner":{"login":"nolanlawson","id":283842,"avatar_url":"https://avatars.githubusercontent.com/u/283842?v=3","gravatar_id":"","url":"https://api.github.com/users/nolanlawson","html_url":"https://github.com/nolanlawson","followers_url":"https://api.github.com/users/nolanlawson/followers","following_url":"https://api.github.com/users/nolanlawson/following{/other_user}","gists_url":"https://api.github.com/users/nolanlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanlawson/subscriptions","organizations_url":"https://api.github.com/users/nolanlawson/orgs","repos_url":"https://api.github.com/users/nolanlawson/repos","events_url":"https://api.github.com/users/nolanlawson/events{/privacy}","received_events_url":"https://api.github.com/users/nolanlawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nolanlawson/local-npm","description":"npm, replicated to your local machine","fork":false,"url":"https://api.github.com/repos/nolanlawson/local-npm","forks_url":"https://api.github.com/repos/nolanlawson/local-npm/forks","keys_url":"https://api.github.com/repos/nolanlawson/local-npm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nolanlawson/local-npm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nolanlawson/local-npm/teams","hooks_url":"https://api.github.com/repos/nolanlawson/local-npm/hooks","issue_events_url":"https://api.github.com/repos/nolanlawson/local-npm/issues/events{/number}","events_url":"https://api.github.com/repos/nolanlawson/local-npm/events","assignees_url":"https://api.github.com/repos/nolanlawson/local-npm/assignees{/user}","branches_url":"https://api.github.com/repos/nolanlawson/local-npm/branches{/branch}","tags_url":"https://api.github.com/repos/nolanlawson/local-npm/tags","blobs_url":"https://api.github.com/repos/nolanlawson/local-npm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nolanlawson/local-npm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nolanlawson/local-npm/git/refs{/sha}","trees_url":"https://api.github.com/repos/nolanlawson/local-npm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nolanlawson/local-npm/statuses/{sha}","languages_url":"https://api.github.com/repos/nolanlawson/local-npm/languages","stargazers_url":"https://api.github.com/repos/nolanlawson/local-npm/stargazers","contributors_url":"https://api.github.com/repos/nolanlawson/local-npm/contributors","subscribers_url":"https://api.github.com/repos/nolanlawson/local-npm/subscribers","subscription_url":"https://api.github.com/repos/nolanlawson/local-npm/subscription","commits_url":"https://api.github.com/repos/nolanlawson/local-npm/commits{/sha}","git_commits_url":"https://api.github.com/repos/nolanlawson/local-npm/git/commits{/sha}","comments_url":"https://api.github.com/repos/nolanlawson/local-npm/comments{/number}","issue_comment_url":"https://api.github.com/repos/nolanlawson/local-npm/issues/comments{/number}","contents_url":"https://api.github.com/repos/nolanlawson/local-npm/contents/{+path}","compare_url":"https://api.github.com/repos/nolanlawson/local-npm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nolanlawson/local-npm/merges","archive_url":"https://api.github.com/repos/nolanlawson/local-npm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nolanlawson/local-npm/downloads","issues_url":"https://api.github.com/repos/nolanlawson/local-npm/issues{/number}","pulls_url":"https://api.github.com/repos/nolanlawson/local-npm/pulls{/number}","milestones_url":"https://api.github.com/repos/nolanlawson/local-npm/milestones{/number}","notifications_url":"https://api.github.com/repos/nolanlawson/local-npm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nolanlawson/local-npm/labels{/name}","releases_url":"https://api.github.com/repos/nolanlawson/local-npm/releases{/id}","created_at":"2014-08-04T03:36:53Z","updated_at":"2015-08-01T18:18:10Z","pushed_at":"2015-08-07T15:02:57Z","git_url":"git://github.com/nolanlawson/local-npm.git","ssh_url":"git@github.com:nolanlawson/local-npm.git","clone_url":"https://github.com/nolanlawson/local-npm.git","svn_url":"https://github.com/nolanlawson/local-npm","homepage":"","size":1289,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":25,"default_branch":"master"}},"base":{"label":"nolanlawson:master","ref":"master","sha":"e68c1b1151f722269ba8352d727447483dfe5c21","user":{"login":"nolanlawson","id":283842,"avatar_url":"https://avatars.githubusercontent.com/u/283842?v=3","gravatar_id":"","url":"https://api.github.com/users/nolanlawson","html_url":"https://github.com/nolanlawson","followers_url":"https://api.github.com/users/nolanlawson/followers","following_url":"https://api.github.com/users/nolanlawson/following{/other_user}","gists_url":"https://api.github.com/users/nolanlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanlawson/subscriptions","organizations_url":"https://api.github.com/users/nolanlawson/orgs","repos_url":"https://api.github.com/users/nolanlawson/repos","events_url":"https://api.github.com/users/nolanlawson/events{/privacy}","received_events_url":"https://api.github.com/users/nolanlawson/received_events","type":"User","site_admin":false},"repo":{"id":22590963,"name":"local-npm","full_name":"nolanlawson/local-npm","owner":{"login":"nolanlawson","id":283842,"avatar_url":"https://avatars.githubusercontent.com/u/283842?v=3","gravatar_id":"","url":"https://api.github.com/users/nolanlawson","html_url":"https://github.com/nolanlawson","followers_url":"https://api.github.com/users/nolanlawson/followers","following_url":"https://api.github.com/users/nolanlawson/following{/other_user}","gists_url":"https://api.github.com/users/nolanlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanlawson/subscriptions","organizations_url":"https://api.github.com/users/nolanlawson/orgs","repos_url":"https://api.github.com/users/nolanlawson/repos","events_url":"https://api.github.com/users/nolanlawson/events{/privacy}","received_events_url":"https://api.github.com/users/nolanlawson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nolanlawson/local-npm","description":"npm, replicated to your local machine","fork":false,"url":"https://api.github.com/repos/nolanlawson/local-npm","forks_url":"https://api.github.com/repos/nolanlawson/local-npm/forks","keys_url":"https://api.github.com/repos/nolanlawson/local-npm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nolanlawson/local-npm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nolanlawson/local-npm/teams","hooks_url":"https://api.github.com/repos/nolanlawson/local-npm/hooks","issue_events_url":"https://api.github.com/repos/nolanlawson/local-npm/issues/events{/number}","events_url":"https://api.github.com/repos/nolanlawson/local-npm/events","assignees_url":"https://api.github.com/repos/nolanlawson/local-npm/assignees{/user}","branches_url":"https://api.github.com/repos/nolanlawson/local-npm/branches{/branch}","tags_url":"https://api.github.com/repos/nolanlawson/local-npm/tags","blobs_url":"https://api.github.com/repos/nolanlawson/local-npm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nolanlawson/local-npm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nolanlawson/local-npm/git/refs{/sha}","trees_url":"https://api.github.com/repos/nolanlawson/local-npm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nolanlawson/local-npm/statuses/{sha}","languages_url":"https://api.github.com/repos/nolanlawson/local-npm/languages","stargazers_url":"https://api.github.com/repos/nolanlawson/local-npm/stargazers","contributors_url":"https://api.github.com/repos/nolanlawson/local-npm/contributors","subscribers_url":"https://api.github.com/repos/nolanlawson/local-npm/subscribers","subscription_url":"https://api.github.com/repos/nolanlawson/local-npm/subscription","commits_url":"https://api.github.com/repos/nolanlawson/local-npm/commits{/sha}","git_commits_url":"https://api.github.com/repos/nolanlawson/local-npm/git/commits{/sha}","comments_url":"https://api.github.com/repos/nolanlawson/local-npm/comments{/number}","issue_comment_url":"https://api.github.com/repos/nolanlawson/local-npm/issues/comments{/number}","contents_url":"https://api.github.com/repos/nolanlawson/local-npm/contents/{+path}","compare_url":"https://api.github.com/repos/nolanlawson/local-npm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nolanlawson/local-npm/merges","archive_url":"https://api.github.com/repos/nolanlawson/local-npm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nolanlawson/local-npm/downloads","issues_url":"https://api.github.com/repos/nolanlawson/local-npm/issues{/number}","pulls_url":"https://api.github.com/repos/nolanlawson/local-npm/pulls{/number}","milestones_url":"https://api.github.com/repos/nolanlawson/local-npm/milestones{/number}","notifications_url":"https://api.github.com/repos/nolanlawson/local-npm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nolanlawson/local-npm/labels{/name}","releases_url":"https://api.github.com/repos/nolanlawson/local-npm/releases{/id}","created_at":"2014-08-04T03:36:53Z","updated_at":"2015-08-01T18:18:10Z","pushed_at":"2015-08-07T15:02:57Z","git_url":"git://github.com/nolanlawson/local-npm.git","ssh_url":"git@github.com:nolanlawson/local-npm.git","clone_url":"https://github.com/nolanlawson/local-npm.git","svn_url":"https://github.com/nolanlawson/local-npm","homepage":"","size":1289,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":8,"forks":3,"open_issues":8,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nolanlawson/local-npm/pulls/41"},"html":{"href":"https://github.com/nolanlawson/local-npm/pull/41"},"issue":{"href":"https://api.github.com/repos/nolanlawson/local-npm/issues/41"},"comments":{"href":"https://api.github.com/repos/nolanlawson/local-npm/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/nolanlawson/local-npm/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/nolanlawson/local-npm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nolanlawson/local-npm/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/nolanlawson/local-npm/statuses/99d85a3ab1b2aee5bd1c99b436813a918adfae7a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nolanlawson","id":283842,"avatar_url":"https://avatars.githubusercontent.com/u/283842?v=3","gravatar_id":"","url":"https://api.github.com/users/nolanlawson","html_url":"https://github.com/nolanlawson","followers_url":"https://api.github.com/users/nolanlawson/followers","following_url":"https://api.github.com/users/nolanlawson/following{/other_user}","gists_url":"https://api.github.com/users/nolanlawson/gists{/gist_id}","starred_url":"https://api.github.com/users/nolanlawson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolanlawson/subscriptions","organizations_url":"https://api.github.com/users/nolanlawson/orgs","repos_url":"https://api.github.com/users/nolanlawson/repos","events_url":"https://api.github.com/users/nolanlawson/events{/privacy}","received_events_url":"https://api.github.com/users/nolanlawson/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":13,"deletions":5,"changed_files":1}}