{"action":"closed","number":1028,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1028","id":37378365,"html_url":"https://github.com/coreos/rkt/pull/1028","diff_url":"https://github.com/coreos/rkt/pull/1028.diff","patch_url":"https://github.com/coreos/rkt/pull/1028.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1028","number":1028,"state":"closed","locked":false,"title":"stage0: use cobra cli library","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"This PR converts rkt to use the cobra CLI library. Please see the single commits descriptions that explain the various choices and differences.\r\n\r\nThis should satisfy all the points from https://github.com/coreos/rkt/issues/632#issuecomment-108904070 except the bash/zsh completion (TODO).\r\n\r\nProbably more functional tests to check that the various arguments are correctly handled should be useful.\r\n\r\n","created_at":"2015-06-10T16:33:24Z","updated_at":"2015-06-17T12:54:09Z","closed_at":"2015-06-17T12:54:09Z","merged_at":"2015-06-17T12:54:09Z","merge_commit_sha":"eb243aeb23612903c8ec59595e097d5e771eec44","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/11","html_url":"https://github.com/coreos/rkt/milestones/v0.6.1","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/11/labels","id":1037040,"number":11,"title":"v0.6.1","description":"","creator":{"login":"philips","id":33544,"avatar_url":"https://avatars.githubusercontent.com/u/33544?v=3","gravatar_id":"","url":"https://api.github.com/users/philips","html_url":"https://github.com/philips","followers_url":"https://api.github.com/users/philips/followers","following_url":"https://api.github.com/users/philips/following{/other_user}","gists_url":"https://api.github.com/users/philips/gists{/gist_id}","starred_url":"https://api.github.com/users/philips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philips/subscriptions","organizations_url":"https://api.github.com/users/philips/orgs","repos_url":"https://api.github.com/users/philips/repos","events_url":"https://api.github.com/users/philips/events{/privacy}","received_events_url":"https://api.github.com/users/philips/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":52,"state":"open","created_at":"2015-03-24T19:40:37Z","updated_at":"2015-06-17T12:54:09Z","due_on":"2015-06-17T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1028/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1028/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1028/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/2b0c0a9161ce875be8dadb581b46af029804b8f8","head":{"label":"sgotti:rkt_cobra","ref":"rkt_cobra","sha":"2b0c0a9161ce875be8dadb581b46af029804b8f8","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"repo":{"id":27428376,"name":"rkt","full_name":"sgotti/rkt","owner":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgotti/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/sgotti/rkt","forks_url":"https://api.github.com/repos/sgotti/rkt/forks","keys_url":"https://api.github.com/repos/sgotti/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgotti/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgotti/rkt/teams","hooks_url":"https://api.github.com/repos/sgotti/rkt/hooks","issue_events_url":"https://api.github.com/repos/sgotti/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/sgotti/rkt/events","assignees_url":"https://api.github.com/repos/sgotti/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/sgotti/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/sgotti/rkt/tags","blobs_url":"https://api.github.com/repos/sgotti/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgotti/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgotti/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgotti/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgotti/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/sgotti/rkt/languages","stargazers_url":"https://api.github.com/repos/sgotti/rkt/stargazers","contributors_url":"https://api.github.com/repos/sgotti/rkt/contributors","subscribers_url":"https://api.github.com/repos/sgotti/rkt/subscribers","subscription_url":"https://api.github.com/repos/sgotti/rkt/subscription","commits_url":"https://api.github.com/repos/sgotti/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgotti/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgotti/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgotti/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgotti/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/sgotti/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgotti/rkt/merges","archive_url":"https://api.github.com/repos/sgotti/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgotti/rkt/downloads","issues_url":"https://api.github.com/repos/sgotti/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/sgotti/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/sgotti/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/sgotti/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgotti/rkt/labels{/name}","releases_url":"https://api.github.com/repos/sgotti/rkt/releases{/id}","created_at":"2014-12-02T10:56:31Z","updated_at":"2015-05-23T10:07:22Z","pushed_at":"2015-06-17T10:00:08Z","git_url":"git://github.com/sgotti/rkt.git","ssh_url":"git@github.com:sgotti/rkt.git","clone_url":"https://github.com/sgotti/rkt.git","svn_url":"https://github.com/sgotti/rkt","homepage":"","size":7030,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"60bff9025281bf33a46e5f64f3f33ab13b49d643","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-06-17T11:57:12Z","pushed_at":"2015-06-17T12:54:09Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":14236,"stargazers_count":4357,"watchers_count":4357,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":335,"mirror_url":null,"open_issues_count":123,"forks":335,"open_issues":123,"watchers":4357,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1028"},"html":{"href":"https://github.com/coreos/rkt/pull/1028"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1028"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1028/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1028/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1028/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/2b0c0a9161ce875be8dadb581b46af029804b8f8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"iaguis","id":507354,"avatar_url":"https://avatars.githubusercontent.com/u/507354?v=3","gravatar_id":"","url":"https://api.github.com/users/iaguis","html_url":"https://github.com/iaguis","followers_url":"https://api.github.com/users/iaguis/followers","following_url":"https://api.github.com/users/iaguis/following{/other_user}","gists_url":"https://api.github.com/users/iaguis/gists{/gist_id}","starred_url":"https://api.github.com/users/iaguis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iaguis/subscriptions","organizations_url":"https://api.github.com/users/iaguis/orgs","repos_url":"https://api.github.com/users/iaguis/repos","events_url":"https://api.github.com/users/iaguis/events{/privacy}","received_events_url":"https://api.github.com/users/iaguis/received_events","type":"User","site_admin":false},"comments":16,"review_comments":6,"commits":3,"additions":4792,"deletions":654,"changed_files":61}}