{"action":"created","comment":{"url":"https://api.github.com/repos/google/googletest/pulls/comments/45757744","id":45757744,"diff_hunk":"@@ -2116,9 +2116,11 @@ GTEST_API_ AssertionResult DoubleLE(const char* expr1, const char* expr2,\n // of the dummy variable name, thus allowing multiple SCOPED_TRACE()s\n // to appear in the same block - as long as they are on different\n // lines.\n-#define SCOPED_TRACE(message) \\\n-  ::testing::internal::ScopedTrace GTEST_CONCAT_TOKEN_(gtest_trace_, __LINE__)(\\\n-    __FILE__, __LINE__, ::testing::Message() << (message))\n+#define SCOPED_TRACE_(file, line, message) \\","path":"googletest/include/gtest/gtest.h","position":7,"original_position":7,"commit_id":"10c4bc95187d0297881326abdb410ccc96fdfd44","original_commit_id":"10c4bc95187d0297881326abdb410ccc96fdfd44","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"body":"updated to `file, line, message`","created_at":"2015-11-24T16:23:58Z","updated_at":"2015-11-24T16:23:58Z","html_url":"https://github.com/google/googletest/pull/620#discussion_r45757744","pull_request_url":"https://api.github.com/repos/google/googletest/pulls/620","_links":{"self":{"href":"https://api.github.com/repos/google/googletest/pulls/comments/45757744"},"html":{"href":"https://github.com/google/googletest/pull/620#discussion_r45757744"},"pull_request":{"href":"https://api.github.com/repos/google/googletest/pulls/620"}}},"pull_request":{"url":"https://api.github.com/repos/google/googletest/pulls/620","id":49395419,"html_url":"https://github.com/google/googletest/pull/620","diff_url":"https://github.com/google/googletest/pull/620.diff","patch_url":"https://github.com/google/googletest/pull/620.patch","issue_url":"https://api.github.com/repos/google/googletest/issues/620","number":620,"state":"open","locked":false,"title":"Allow specifying file/line for SCOPED_TRACE","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"body":"Example use:\r\n\r\n```c++\r\nvoid custom_assert(const Foo& actual, int expected_1, expected_2, expected_3) {\r\n  ASSERT_EQ(expected_1, actual.thing_1());\r\n  // ...\r\n}\r\n\r\n#define CUSTOM_ASSERT(actual, expected_1, expected_2, expected_3, message) \\\r\n  do { \\\r\n    SCOPED_TRACE_(message, __FILE__, __LINE__); \\\r\n    custom_assert(actual, expected_1, expected_2, expected_3); \\\r\n  } while(0)\r\n```\r\n\r\nGrouping re-used assertions into a subroutine, while still keeping the stack trace clean","created_at":"2015-11-02T05:08:46Z","updated_at":"2015-11-24T16:23:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ba8cf8db31dea2cdf4ce19358aa1c7a7326e2cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/googletest/pulls/620/commits","review_comments_url":"https://api.github.com/repos/google/googletest/pulls/620/comments","review_comment_url":"https://api.github.com/repos/google/googletest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/googletest/issues/620/comments","statuses_url":"https://api.github.com/repos/google/googletest/statuses/10c4bc95187d0297881326abdb410ccc96fdfd44","head":{"label":"caitp:patch-1","ref":"patch-1","sha":"10c4bc95187d0297881326abdb410ccc96fdfd44","user":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"repo":{"id":45373086,"name":"googletest","full_name":"caitp/googletest","owner":{"login":"caitp","id":2294695,"avatar_url":"https://avatars.githubusercontent.com/u/2294695?v=3","gravatar_id":"","url":"https://api.github.com/users/caitp","html_url":"https://github.com/caitp","followers_url":"https://api.github.com/users/caitp/followers","following_url":"https://api.github.com/users/caitp/following{/other_user}","gists_url":"https://api.github.com/users/caitp/gists{/gist_id}","starred_url":"https://api.github.com/users/caitp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caitp/subscriptions","organizations_url":"https://api.github.com/users/caitp/orgs","repos_url":"https://api.github.com/users/caitp/repos","events_url":"https://api.github.com/users/caitp/events{/privacy}","received_events_url":"https://api.github.com/users/caitp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/caitp/googletest","description":"Google Test","fork":true,"url":"https://api.github.com/repos/caitp/googletest","forks_url":"https://api.github.com/repos/caitp/googletest/forks","keys_url":"https://api.github.com/repos/caitp/googletest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caitp/googletest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caitp/googletest/teams","hooks_url":"https://api.github.com/repos/caitp/googletest/hooks","issue_events_url":"https://api.github.com/repos/caitp/googletest/issues/events{/number}","events_url":"https://api.github.com/repos/caitp/googletest/events","assignees_url":"https://api.github.com/repos/caitp/googletest/assignees{/user}","branches_url":"https://api.github.com/repos/caitp/googletest/branches{/branch}","tags_url":"https://api.github.com/repos/caitp/googletest/tags","blobs_url":"https://api.github.com/repos/caitp/googletest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caitp/googletest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caitp/googletest/git/refs{/sha}","trees_url":"https://api.github.com/repos/caitp/googletest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caitp/googletest/statuses/{sha}","languages_url":"https://api.github.com/repos/caitp/googletest/languages","stargazers_url":"https://api.github.com/repos/caitp/googletest/stargazers","contributors_url":"https://api.github.com/repos/caitp/googletest/contributors","subscribers_url":"https://api.github.com/repos/caitp/googletest/subscribers","subscription_url":"https://api.github.com/repos/caitp/googletest/subscription","commits_url":"https://api.github.com/repos/caitp/googletest/commits{/sha}","git_commits_url":"https://api.github.com/repos/caitp/googletest/git/commits{/sha}","comments_url":"https://api.github.com/repos/caitp/googletest/comments{/number}","issue_comment_url":"https://api.github.com/repos/caitp/googletest/issues/comments{/number}","contents_url":"https://api.github.com/repos/caitp/googletest/contents/{+path}","compare_url":"https://api.github.com/repos/caitp/googletest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caitp/googletest/merges","archive_url":"https://api.github.com/repos/caitp/googletest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caitp/googletest/downloads","issues_url":"https://api.github.com/repos/caitp/googletest/issues{/number}","pulls_url":"https://api.github.com/repos/caitp/googletest/pulls{/number}","milestones_url":"https://api.github.com/repos/caitp/googletest/milestones{/number}","notifications_url":"https://api.github.com/repos/caitp/googletest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caitp/googletest/labels{/name}","releases_url":"https://api.github.com/repos/caitp/googletest/releases{/id}","created_at":"2015-11-02T05:00:44Z","updated_at":"2015-11-02T05:00:46Z","pushed_at":"2015-11-24T16:23:07Z","git_url":"git://github.com/caitp/googletest.git","ssh_url":"git@github.com:caitp/googletest.git","clone_url":"https://github.com/caitp/googletest.git","svn_url":"https://github.com/caitp/googletest","homepage":"","size":2270,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"93c37d59b01326aa142520997ed4a6a4eef44648","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":39840932,"name":"googletest","full_name":"google/googletest","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/googletest","description":"Google Test","fork":false,"url":"https://api.github.com/repos/google/googletest","forks_url":"https://api.github.com/repos/google/googletest/forks","keys_url":"https://api.github.com/repos/google/googletest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/googletest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/googletest/teams","hooks_url":"https://api.github.com/repos/google/googletest/hooks","issue_events_url":"https://api.github.com/repos/google/googletest/issues/events{/number}","events_url":"https://api.github.com/repos/google/googletest/events","assignees_url":"https://api.github.com/repos/google/googletest/assignees{/user}","branches_url":"https://api.github.com/repos/google/googletest/branches{/branch}","tags_url":"https://api.github.com/repos/google/googletest/tags","blobs_url":"https://api.github.com/repos/google/googletest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/googletest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/googletest/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/googletest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/googletest/statuses/{sha}","languages_url":"https://api.github.com/repos/google/googletest/languages","stargazers_url":"https://api.github.com/repos/google/googletest/stargazers","contributors_url":"https://api.github.com/repos/google/googletest/contributors","subscribers_url":"https://api.github.com/repos/google/googletest/subscribers","subscription_url":"https://api.github.com/repos/google/googletest/subscription","commits_url":"https://api.github.com/repos/google/googletest/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/googletest/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/googletest/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/googletest/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/googletest/contents/{+path}","compare_url":"https://api.github.com/repos/google/googletest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/googletest/merges","archive_url":"https://api.github.com/repos/google/googletest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/googletest/downloads","issues_url":"https://api.github.com/repos/google/googletest/issues{/number}","pulls_url":"https://api.github.com/repos/google/googletest/pulls{/number}","milestones_url":"https://api.github.com/repos/google/googletest/milestones{/number}","notifications_url":"https://api.github.com/repos/google/googletest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/googletest/labels{/name}","releases_url":"https://api.github.com/repos/google/googletest/releases{/id}","created_at":"2015-07-28T15:07:53Z","updated_at":"2015-11-24T14:57:47Z","pushed_at":"2015-11-24T16:23:08Z","git_url":"git://github.com/google/googletest.git","ssh_url":"git@github.com:google/googletest.git","clone_url":"https://github.com/google/googletest.git","svn_url":"https://github.com/google/googletest","homepage":"","size":3024,"stargazers_count":796,"watchers_count":796,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":195,"mirror_url":null,"open_issues_count":207,"forks":195,"open_issues":207,"watchers":796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/googletest/pulls/620"},"html":{"href":"https://github.com/google/googletest/pull/620"},"issue":{"href":"https://api.github.com/repos/google/googletest/issues/620"},"comments":{"href":"https://api.github.com/repos/google/googletest/issues/620/comments"},"review_comments":{"href":"https://api.github.com/repos/google/googletest/pulls/620/comments"},"review_comment":{"href":"https://api.github.com/repos/google/googletest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/googletest/pulls/620/commits"},"statuses":{"href":"https://api.github.com/repos/google/googletest/statuses/10c4bc95187d0297881326abdb410ccc96fdfd44"}}}}