{"action":"created","comment":{"url":"https://api.github.com/repos/dartsim/dart/pulls/comments/43919453","id":43919453,"diff_hunk":"@@ -121,7 +126,7 @@ class Shape : public virtual common::Subject\n   //           biased mesh shape. Two Vector3ds might be better; one is for\n   //           minimum verterx, and the other is for maximum verterx of the\n   //           bounding box.\n-  const Eigen::Vector3d& getBoundingBoxDim() const;\n+  Eigen::Vector3d getBoundingBoxDim() const;","path":"dart/dynamics/Shape.h","position":26,"original_position":26,"commit_id":"55e1266f6ebb5c38135b6a7b314d26be5bd746d6","original_commit_id":"55e1266f6ebb5c38135b6a7b314d26be5bd746d6","user":{"login":"mkoval","id":142251,"avatar_url":"https://avatars.githubusercontent.com/u/142251?v=3","gravatar_id":"","url":"https://api.github.com/users/mkoval","html_url":"https://github.com/mkoval","followers_url":"https://api.github.com/users/mkoval/followers","following_url":"https://api.github.com/users/mkoval/following{/other_user}","gists_url":"https://api.github.com/users/mkoval/gists{/gist_id}","starred_url":"https://api.github.com/users/mkoval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkoval/subscriptions","organizations_url":"https://api.github.com/users/mkoval/orgs","repos_url":"https://api.github.com/users/mkoval/repos","events_url":"https://api.github.com/users/mkoval/events{/privacy}","received_events_url":"https://api.github.com/users/mkoval/received_events","type":"User","site_admin":false},"body":"There is a `DEPRECATED` macro defined in [`Deprecated.h`](https://github.com/dartsim/dart/blob/e8b4f1c40e26140d93ea803bcb4a76547ebe05fb/dart/common/Deprecated.h) that has `#ifdef`s for all of the supported compilers. The argument is the major/minor version number when the deprecation occurred.\r\n\r\nDART 5.1.1 was just released, so I suppose it should be `DEPRECATED(5.2)` now?","created_at":"2015-11-04T18:37:09Z","updated_at":"2015-11-04T18:37:09Z","html_url":"https://github.com/dartsim/dart/pull/547#discussion_r43919453","pull_request_url":"https://api.github.com/repos/dartsim/dart/pulls/547","_links":{"self":{"href":"https://api.github.com/repos/dartsim/dart/pulls/comments/43919453"},"html":{"href":"https://github.com/dartsim/dart/pull/547#discussion_r43919453"},"pull_request":{"href":"https://api.github.com/repos/dartsim/dart/pulls/547"}}},"pull_request":{"url":"https://api.github.com/repos/dartsim/dart/pulls/547","id":49605753,"html_url":"https://github.com/dartsim/dart/pull/547","diff_url":"https://github.com/dartsim/dart/pull/547.diff","patch_url":"https://github.com/dartsim/dart/pull/547.patch","issue_url":"https://api.github.com/repos/dartsim/dart/issues/547","number":547,"state":"open","locked":false,"title":"new bounding box semantics","user":{"login":"mklingen","id":241184,"avatar_url":"https://avatars.githubusercontent.com/u/241184?v=3","gravatar_id":"","url":"https://api.github.com/users/mklingen","html_url":"https://github.com/mklingen","followers_url":"https://api.github.com/users/mklingen/followers","following_url":"https://api.github.com/users/mklingen/following{/other_user}","gists_url":"https://api.github.com/users/mklingen/gists{/gist_id}","starred_url":"https://api.github.com/users/mklingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklingen/subscriptions","organizations_url":"https://api.github.com/users/mklingen/orgs","repos_url":"https://api.github.com/users/mklingen/repos","events_url":"https://api.github.com/users/mklingen/events{/privacy}","received_events_url":"https://api.github.com/users/mklingen/received_events","type":"User","site_admin":false},"body":"Replaces old `boundingBoxDim` semantics with a new `BoundingBox` class that has a minimum and maximum. This reduces ambiguity and allows for off-center bounding boxes.","created_at":"2015-11-03T20:15:37Z","updated_at":"2015-11-04T18:37:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20eb71403988f45d97b1a2fe96be911bda3a3647","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dartsim/dart/pulls/547/commits","review_comments_url":"https://api.github.com/repos/dartsim/dart/pulls/547/comments","review_comment_url":"https://api.github.com/repos/dartsim/dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dartsim/dart/issues/547/comments","statuses_url":"https://api.github.com/repos/dartsim/dart/statuses/55e1266f6ebb5c38135b6a7b314d26be5bd746d6","head":{"label":"mklingen:feature/bounding_box","ref":"feature/bounding_box","sha":"55e1266f6ebb5c38135b6a7b314d26be5bd746d6","user":{"login":"mklingen","id":241184,"avatar_url":"https://avatars.githubusercontent.com/u/241184?v=3","gravatar_id":"","url":"https://api.github.com/users/mklingen","html_url":"https://github.com/mklingen","followers_url":"https://api.github.com/users/mklingen/followers","following_url":"https://api.github.com/users/mklingen/following{/other_user}","gists_url":"https://api.github.com/users/mklingen/gists{/gist_id}","starred_url":"https://api.github.com/users/mklingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklingen/subscriptions","organizations_url":"https://api.github.com/users/mklingen/orgs","repos_url":"https://api.github.com/users/mklingen/repos","events_url":"https://api.github.com/users/mklingen/events{/privacy}","received_events_url":"https://api.github.com/users/mklingen/received_events","type":"User","site_admin":false},"repo":{"id":45492637,"name":"dart","full_name":"mklingen/dart","owner":{"login":"mklingen","id":241184,"avatar_url":"https://avatars.githubusercontent.com/u/241184?v=3","gravatar_id":"","url":"https://api.github.com/users/mklingen","html_url":"https://github.com/mklingen","followers_url":"https://api.github.com/users/mklingen/followers","following_url":"https://api.github.com/users/mklingen/following{/other_user}","gists_url":"https://api.github.com/users/mklingen/gists{/gist_id}","starred_url":"https://api.github.com/users/mklingen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mklingen/subscriptions","organizations_url":"https://api.github.com/users/mklingen/orgs","repos_url":"https://api.github.com/users/mklingen/repos","events_url":"https://api.github.com/users/mklingen/events{/privacy}","received_events_url":"https://api.github.com/users/mklingen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mklingen/dart","description":"Dynamic Animation and Robotics Toolkit","fork":true,"url":"https://api.github.com/repos/mklingen/dart","forks_url":"https://api.github.com/repos/mklingen/dart/forks","keys_url":"https://api.github.com/repos/mklingen/dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mklingen/dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mklingen/dart/teams","hooks_url":"https://api.github.com/repos/mklingen/dart/hooks","issue_events_url":"https://api.github.com/repos/mklingen/dart/issues/events{/number}","events_url":"https://api.github.com/repos/mklingen/dart/events","assignees_url":"https://api.github.com/repos/mklingen/dart/assignees{/user}","branches_url":"https://api.github.com/repos/mklingen/dart/branches{/branch}","tags_url":"https://api.github.com/repos/mklingen/dart/tags","blobs_url":"https://api.github.com/repos/mklingen/dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mklingen/dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mklingen/dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/mklingen/dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mklingen/dart/statuses/{sha}","languages_url":"https://api.github.com/repos/mklingen/dart/languages","stargazers_url":"https://api.github.com/repos/mklingen/dart/stargazers","contributors_url":"https://api.github.com/repos/mklingen/dart/contributors","subscribers_url":"https://api.github.com/repos/mklingen/dart/subscribers","subscription_url":"https://api.github.com/repos/mklingen/dart/subscription","commits_url":"https://api.github.com/repos/mklingen/dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/mklingen/dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/mklingen/dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/mklingen/dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/mklingen/dart/contents/{+path}","compare_url":"https://api.github.com/repos/mklingen/dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mklingen/dart/merges","archive_url":"https://api.github.com/repos/mklingen/dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mklingen/dart/downloads","issues_url":"https://api.github.com/repos/mklingen/dart/issues{/number}","pulls_url":"https://api.github.com/repos/mklingen/dart/pulls{/number}","milestones_url":"https://api.github.com/repos/mklingen/dart/milestones{/number}","notifications_url":"https://api.github.com/repos/mklingen/dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mklingen/dart/labels{/name}","releases_url":"https://api.github.com/repos/mklingen/dart/releases{/id}","created_at":"2015-11-03T20:10:27Z","updated_at":"2015-11-03T20:10:41Z","pushed_at":"2015-11-03T20:18:12Z","git_url":"git://github.com/mklingen/dart.git","ssh_url":"git@github.com:mklingen/dart.git","clone_url":"https://github.com/mklingen/dart.git","svn_url":"https://github.com/mklingen/dart","homepage":"http://dartsim.github.io/","size":105184,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dartsim:master","ref":"master","sha":"af3d1cd3f9fcf6751e9ae4d8afed35801f83787b","user":{"login":"dartsim","id":4191609,"avatar_url":"https://avatars.githubusercontent.com/u/4191609?v=3","gravatar_id":"","url":"https://api.github.com/users/dartsim","html_url":"https://github.com/dartsim","followers_url":"https://api.github.com/users/dartsim/followers","following_url":"https://api.github.com/users/dartsim/following{/other_user}","gists_url":"https://api.github.com/users/dartsim/gists{/gist_id}","starred_url":"https://api.github.com/users/dartsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartsim/subscriptions","organizations_url":"https://api.github.com/users/dartsim/orgs","repos_url":"https://api.github.com/users/dartsim/repos","events_url":"https://api.github.com/users/dartsim/events{/privacy}","received_events_url":"https://api.github.com/users/dartsim/received_events","type":"Organization","site_admin":false},"repo":{"id":2418592,"name":"dart","full_name":"dartsim/dart","owner":{"login":"dartsim","id":4191609,"avatar_url":"https://avatars.githubusercontent.com/u/4191609?v=3","gravatar_id":"","url":"https://api.github.com/users/dartsim","html_url":"https://github.com/dartsim","followers_url":"https://api.github.com/users/dartsim/followers","following_url":"https://api.github.com/users/dartsim/following{/other_user}","gists_url":"https://api.github.com/users/dartsim/gists{/gist_id}","starred_url":"https://api.github.com/users/dartsim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dartsim/subscriptions","organizations_url":"https://api.github.com/users/dartsim/orgs","repos_url":"https://api.github.com/users/dartsim/repos","events_url":"https://api.github.com/users/dartsim/events{/privacy}","received_events_url":"https://api.github.com/users/dartsim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dartsim/dart","description":"Dynamic Animation and Robotics Toolkit","fork":false,"url":"https://api.github.com/repos/dartsim/dart","forks_url":"https://api.github.com/repos/dartsim/dart/forks","keys_url":"https://api.github.com/repos/dartsim/dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dartsim/dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dartsim/dart/teams","hooks_url":"https://api.github.com/repos/dartsim/dart/hooks","issue_events_url":"https://api.github.com/repos/dartsim/dart/issues/events{/number}","events_url":"https://api.github.com/repos/dartsim/dart/events","assignees_url":"https://api.github.com/repos/dartsim/dart/assignees{/user}","branches_url":"https://api.github.com/repos/dartsim/dart/branches{/branch}","tags_url":"https://api.github.com/repos/dartsim/dart/tags","blobs_url":"https://api.github.com/repos/dartsim/dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dartsim/dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dartsim/dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/dartsim/dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dartsim/dart/statuses/{sha}","languages_url":"https://api.github.com/repos/dartsim/dart/languages","stargazers_url":"https://api.github.com/repos/dartsim/dart/stargazers","contributors_url":"https://api.github.com/repos/dartsim/dart/contributors","subscribers_url":"https://api.github.com/repos/dartsim/dart/subscribers","subscription_url":"https://api.github.com/repos/dartsim/dart/subscription","commits_url":"https://api.github.com/repos/dartsim/dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/dartsim/dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/dartsim/dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/dartsim/dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/dartsim/dart/contents/{+path}","compare_url":"https://api.github.com/repos/dartsim/dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dartsim/dart/merges","archive_url":"https://api.github.com/repos/dartsim/dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dartsim/dart/downloads","issues_url":"https://api.github.com/repos/dartsim/dart/issues{/number}","pulls_url":"https://api.github.com/repos/dartsim/dart/pulls{/number}","milestones_url":"https://api.github.com/repos/dartsim/dart/milestones{/number}","notifications_url":"https://api.github.com/repos/dartsim/dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dartsim/dart/labels{/name}","releases_url":"https://api.github.com/repos/dartsim/dart/releases{/id}","created_at":"2011-09-19T21:53:51Z","updated_at":"2015-10-31T02:33:55Z","pushed_at":"2015-11-04T18:02:33Z","git_url":"git://github.com/dartsim/dart.git","ssh_url":"git@github.com:dartsim/dart.git","clone_url":"https://github.com/dartsim/dart.git","svn_url":"https://github.com/dartsim/dart","homepage":"http://dartsim.github.io/","size":115625,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":51,"mirror_url":null,"open_issues_count":118,"forks":51,"open_issues":118,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dartsim/dart/pulls/547"},"html":{"href":"https://github.com/dartsim/dart/pull/547"},"issue":{"href":"https://api.github.com/repos/dartsim/dart/issues/547"},"comments":{"href":"https://api.github.com/repos/dartsim/dart/issues/547/comments"},"review_comments":{"href":"https://api.github.com/repos/dartsim/dart/pulls/547/comments"},"review_comment":{"href":"https://api.github.com/repos/dartsim/dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dartsim/dart/pulls/547/commits"},"statuses":{"href":"https://api.github.com/repos/dartsim/dart/statuses/55e1266f6ebb5c38135b6a7b314d26be5bd746d6"}}}}