{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/7351","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/7351/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7351/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/7351/events","html_url":"https://github.com/edx/edx-platform/pull/7351","id":61302390,"number":7351,"title":"Remove extra lean modal trigger","user":{"login":"kluo","id":868615,"avatar_url":"https://avatars.githubusercontent.com/u/868615?v=3","gravatar_id":"","url":"https://api.github.com/users/kluo","html_url":"https://github.com/kluo","followers_url":"https://api.github.com/users/kluo/followers","following_url":"https://api.github.com/users/kluo/following{/other_user}","gists_url":"https://api.github.com/users/kluo/gists{/gist_id}","starred_url":"https://api.github.com/users/kluo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kluo/subscriptions","organizations_url":"https://api.github.com/users/kluo/orgs","repos_url":"https://api.github.com/users/kluo/repos","events_url":"https://api.github.com/users/kluo/events{/privacy}","received_events_url":"https://api.github.com/users/kluo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/needs%20triage","name":"needs triage","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-14T00:01:27Z","updated_at":"2015-03-14T00:01:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7351","html_url":"https://github.com/edx/edx-platform/pull/7351","diff_url":"https://github.com/edx/edx-platform/pull/7351.diff","patch_url":"https://github.com/edx/edx-platform/pull/7351.patch"},"body":"There are two lean modal triggers in base.js. First one here: https://github.com/edx/edx-platform/blob/master/cms/static/js/base.js#L61\r\nExtra one introduced in https://github.com/edx/edx-platform/commit/9b09d043bd02d323565a74eb96f7bc93dfabc5de\r\n\r\nThe effect of this can be seen when you click lean modals in Studio. They will show a darker background first, and then the lighter one, from the 2 triggers. For example, if you go to https://studio.edx.org/ and click the image, you can see this."},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/79544364","html_url":"https://github.com/edx/edx-platform/pull/7351#issuecomment-79544364","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7351","id":79544364,"user":{"login":"edx-webhook","id":8964148,"avatar_url":"https://avatars.githubusercontent.com/u/8964148?v=3","gravatar_id":"","url":"https://api.github.com/users/edx-webhook","html_url":"https://github.com/edx-webhook","followers_url":"https://api.github.com/users/edx-webhook/followers","following_url":"https://api.github.com/users/edx-webhook/following{/other_user}","gists_url":"https://api.github.com/users/edx-webhook/gists{/gist_id}","starred_url":"https://api.github.com/users/edx-webhook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx-webhook/subscriptions","organizations_url":"https://api.github.com/users/edx-webhook/orgs","repos_url":"https://api.github.com/users/edx-webhook/repos","events_url":"https://api.github.com/users/edx-webhook/events{/privacy}","received_events_url":"https://api.github.com/users/edx-webhook/received_events","type":"User","site_admin":false},"created_at":"2015-03-14T00:01:28Z","updated_at":"2015-03-14T00:01:28Z","body":"Thanks for the pull request, @kluo! I've created [OSPR-457](https://openedx.atlassian.net/browse/OSPR-457) to keep track of it in JIRA. JIRA is a place for product owners to prioritize feature reviews by the engineering development teams. \n\nFeel free to add as much of the following information to the ticket:\n- supporting documentation\n- edx-code email threads\n- timeline information ('this must be merged by XX date', and why that is)\n- partner information ('this is a course on edx.org')\n- any other information that can help Product understand the context for the PR\n\nAll technical communication about the code itself will still be done via the Github pull request interface. As a reminder, [our process documentation is here](http://edx-developer-guide.readthedocs.org/en/latest/process/overview.html)."}}