{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/1433","labels_url":"https://api.github.com/repos/openshift/origin/issues/1433/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/1433/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/1433/events","html_url":"https://github.com/openshift/origin/pull/1433","id":64070194,"number":1433,"title":"Comprehensive fixes for deployment image triggering","user":{"login":"ironcladlou","id":298299,"avatar_url":"https://avatars.githubusercontent.com/u/298299?v=3","gravatar_id":"","url":"https://api.github.com/users/ironcladlou","html_url":"https://github.com/ironcladlou","followers_url":"https://api.github.com/users/ironcladlou/followers","following_url":"https://api.github.com/users/ironcladlou/following{/other_user}","gists_url":"https://api.github.com/users/ironcladlou/gists{/gist_id}","starred_url":"https://api.github.com/users/ironcladlou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironcladlou/subscriptions","organizations_url":"https://api.github.com/users/ironcladlou/orgs","repos_url":"https://api.github.com/users/ironcladlou/repos","events_url":"https://api.github.com/users/ironcladlou/events{/privacy}","received_events_url":"https://api.github.com/users/ironcladlou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-03-24T18:43:16Z","updated_at":"2015-03-30T19:52:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/1433","html_url":"https://github.com/openshift/origin/pull/1433","diff_url":"https://github.com/openshift/origin/pull/1433.diff","patch_url":"https://github.com/openshift/origin/pull/1433.patch"},"body":"The current deployment image triggering logic is not accounting for various edge cases related to image IDs (or lack thereof). Define all the triggering scenarios in the comprehensive unit test and plug the holes in the triggering code so that triggers work consistently.\r\n\r\nOne known side effect of the current flawed code is mis-firing triggers which update the container to a nil image ID, causing races described in #1443.\r\n\r\nBase all comparisons on image ID, and add new state to image change trigger params to store the last image ID used for triggering."},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/87806862","html_url":"https://github.com/openshift/origin/pull/1433#issuecomment-87806862","issue_url":"https://api.github.com/repos/openshift/origin/issues/1433","id":87806862,"user":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T19:52:47Z","updated_at":"2015-03-30T19:52:47Z","body":"\r\n\r\n\r\n> On Mar 30, 2015, at 3:40 PM, Dan Mace <notifications@github.com> wrote:\r\n> \r\n> Okay, @ncdc @smarterclayton and @pmorie.\r\n> \r\n> I had to rewrite the deployment image change trigger controller, the generator, and all the related tests. I also had to make an additive/backwards-compatible API change to add a status struct to DeploymentTriggerImageChangeParams so we can correctly track the last triggered image ID.\r\n> \r\nSo I have a question... Why is the pull spec in the pod template not sufficient?  Why do we need this other field?\r\n> The changes are significant, but as far as I know, the behavior is actually correct now in terms of ImageRepository interactions. Hopefully you all can do some auditing.\r\n> \r\n> In the meantime, [test].\r\n> \r\n> —\r\n> Reply to this email directly or view it on GitHub.\r\n> \r\n"}}