{"action":"closed","number":997,"pull_request":{"url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/997","id":33345010,"html_url":"https://github.com/matethurzo/liferay-portal/pull/997","diff_url":"https://github.com/matethurzo/liferay-portal/pull/997.diff","patch_url":"https://github.com/matethurzo/liferay-portal/pull/997.patch","issue_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/997","number":997,"state":"closed","locked":false,"title":"LPS-54978 Remove incorrect logic","user":{"login":"epgarcia","id":1579803,"avatar_url":"https://avatars.githubusercontent.com/u/1579803?v=3","gravatar_id":"","url":"https://api.github.com/users/epgarcia","html_url":"https://github.com/epgarcia","followers_url":"https://api.github.com/users/epgarcia/followers","following_url":"https://api.github.com/users/epgarcia/following{/other_user}","gists_url":"https://api.github.com/users/epgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/epgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epgarcia/subscriptions","organizations_url":"https://api.github.com/users/epgarcia/orgs","repos_url":"https://api.github.com/users/epgarcia/repos","events_url":"https://api.github.com/users/epgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/epgarcia/received_events","type":"User","site_admin":false},"body":"Hey @matethurzo,\r\n\r\nAs discussed we want to remove dependencies of some core classes with the Web Content API, so it can be extracted from the portal. In this process we found some usages of the JournalContentUtil.clearCache, specially in the import logic.\r\n\r\nAs a first step I've moved JournalContentUtil.clearCache to the JournalPortletDataHandler, as we did with Wiki. If you want to implement a Listener-based approach, you can do it on top of this PR or send me instructions to do it.\r\n\r\nThanks!\r\n\r\n@juliocamarero","created_at":"2015-04-15T11:22:55Z","updated_at":"2015-04-28T11:01:15Z","closed_at":"2015-04-28T11:01:15Z","merged_at":null,"merge_commit_sha":"a27eb9de5920edd8a207ab7c34921714b0fae11f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/997/commits","review_comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/997/comments","review_comment_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/997/comments","statuses_url":"https://api.github.com/repos/matethurzo/liferay-portal/statuses/12553a70f6aa1190fe1e10e60d4c72868b76a330","head":{"label":"epgarcia:LPS-54978.JournalCache","ref":"LPS-54978.JournalCache","sha":"12553a70f6aa1190fe1e10e60d4c72868b76a330","user":{"login":"epgarcia","id":1579803,"avatar_url":"https://avatars.githubusercontent.com/u/1579803?v=3","gravatar_id":"","url":"https://api.github.com/users/epgarcia","html_url":"https://github.com/epgarcia","followers_url":"https://api.github.com/users/epgarcia/followers","following_url":"https://api.github.com/users/epgarcia/following{/other_user}","gists_url":"https://api.github.com/users/epgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/epgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epgarcia/subscriptions","organizations_url":"https://api.github.com/users/epgarcia/orgs","repos_url":"https://api.github.com/users/epgarcia/repos","events_url":"https://api.github.com/users/epgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/epgarcia/received_events","type":"User","site_admin":false},"repo":{"id":3844046,"name":"liferay-portal","full_name":"epgarcia/liferay-portal","owner":{"login":"epgarcia","id":1579803,"avatar_url":"https://avatars.githubusercontent.com/u/1579803?v=3","gravatar_id":"","url":"https://api.github.com/users/epgarcia","html_url":"https://github.com/epgarcia","followers_url":"https://api.github.com/users/epgarcia/followers","following_url":"https://api.github.com/users/epgarcia/following{/other_user}","gists_url":"https://api.github.com/users/epgarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/epgarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epgarcia/subscriptions","organizations_url":"https://api.github.com/users/epgarcia/orgs","repos_url":"https://api.github.com/users/epgarcia/repos","events_url":"https://api.github.com/users/epgarcia/events{/privacy}","received_events_url":"https://api.github.com/users/epgarcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/epgarcia/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/epgarcia/liferay-portal","forks_url":"https://api.github.com/repos/epgarcia/liferay-portal/forks","keys_url":"https://api.github.com/repos/epgarcia/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/epgarcia/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/epgarcia/liferay-portal/teams","hooks_url":"https://api.github.com/repos/epgarcia/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/epgarcia/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/epgarcia/liferay-portal/events","assignees_url":"https://api.github.com/repos/epgarcia/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/epgarcia/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/epgarcia/liferay-portal/tags","blobs_url":"https://api.github.com/repos/epgarcia/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/epgarcia/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/epgarcia/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/epgarcia/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/epgarcia/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/epgarcia/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/epgarcia/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/epgarcia/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/epgarcia/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/epgarcia/liferay-portal/subscription","commits_url":"https://api.github.com/repos/epgarcia/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/epgarcia/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/epgarcia/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/epgarcia/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/epgarcia/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/epgarcia/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/epgarcia/liferay-portal/merges","archive_url":"https://api.github.com/repos/epgarcia/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/epgarcia/liferay-portal/downloads","issues_url":"https://api.github.com/repos/epgarcia/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/epgarcia/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/epgarcia/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/epgarcia/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/epgarcia/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/epgarcia/liferay-portal/releases{/id}","created_at":"2012-03-27T13:37:51Z","updated_at":"2015-04-28T07:27:26Z","pushed_at":"2015-04-28T10:58:32Z","git_url":"git://github.com/epgarcia/liferay-portal.git","ssh_url":"git@github.com:epgarcia/liferay-portal.git","clone_url":"https://github.com/epgarcia/liferay-portal.git","svn_url":"https://github.com/epgarcia/liferay-portal","homepage":"http://liferay.com","size":4346238,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"matethurzo:master","ref":"master","sha":"eede23296642c0647ceb69ba062eb7a6f356dad8","user":{"login":"matethurzo","id":861774,"avatar_url":"https://avatars.githubusercontent.com/u/861774?v=3","gravatar_id":"","url":"https://api.github.com/users/matethurzo","html_url":"https://github.com/matethurzo","followers_url":"https://api.github.com/users/matethurzo/followers","following_url":"https://api.github.com/users/matethurzo/following{/other_user}","gists_url":"https://api.github.com/users/matethurzo/gists{/gist_id}","starred_url":"https://api.github.com/users/matethurzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matethurzo/subscriptions","organizations_url":"https://api.github.com/users/matethurzo/orgs","repos_url":"https://api.github.com/users/matethurzo/repos","events_url":"https://api.github.com/users/matethurzo/events{/privacy}","received_events_url":"https://api.github.com/users/matethurzo/received_events","type":"User","site_admin":false},"repo":{"id":1923779,"name":"liferay-portal","full_name":"matethurzo/liferay-portal","owner":{"login":"matethurzo","id":861774,"avatar_url":"https://avatars.githubusercontent.com/u/861774?v=3","gravatar_id":"","url":"https://api.github.com/users/matethurzo","html_url":"https://github.com/matethurzo","followers_url":"https://api.github.com/users/matethurzo/followers","following_url":"https://api.github.com/users/matethurzo/following{/other_user}","gists_url":"https://api.github.com/users/matethurzo/gists{/gist_id}","starred_url":"https://api.github.com/users/matethurzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matethurzo/subscriptions","organizations_url":"https://api.github.com/users/matethurzo/orgs","repos_url":"https://api.github.com/users/matethurzo/repos","events_url":"https://api.github.com/users/matethurzo/events{/privacy}","received_events_url":"https://api.github.com/users/matethurzo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matethurzo/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/matethurzo/liferay-portal","forks_url":"https://api.github.com/repos/matethurzo/liferay-portal/forks","keys_url":"https://api.github.com/repos/matethurzo/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matethurzo/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matethurzo/liferay-portal/teams","hooks_url":"https://api.github.com/repos/matethurzo/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/matethurzo/liferay-portal/events","assignees_url":"https://api.github.com/repos/matethurzo/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/matethurzo/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/matethurzo/liferay-portal/tags","blobs_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matethurzo/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/matethurzo/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/matethurzo/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/matethurzo/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/matethurzo/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/matethurzo/liferay-portal/subscription","commits_url":"https://api.github.com/repos/matethurzo/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/matethurzo/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/matethurzo/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/matethurzo/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matethurzo/liferay-portal/merges","archive_url":"https://api.github.com/repos/matethurzo/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matethurzo/liferay-portal/downloads","issues_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/matethurzo/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/matethurzo/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matethurzo/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/matethurzo/liferay-portal/releases{/id}","created_at":"2011-06-20T13:56:19Z","updated_at":"2015-04-28T07:21:06Z","pushed_at":"2015-04-28T10:59:24Z","git_url":"git://github.com/matethurzo/liferay-portal.git","ssh_url":"git@github.com:matethurzo/liferay-portal.git","clone_url":"https://github.com/matethurzo/liferay-portal.git","svn_url":"https://github.com/matethurzo/liferay-portal","homepage":"http://liferay.com","size":4420952,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/997"},"html":{"href":"https://github.com/matethurzo/liferay-portal/pull/997"},"issue":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/issues/997"},"comments":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/issues/997/comments"},"review_comments":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/997/comments"},"review_comment":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/997/commits"},"statuses":{"href":"https://api.github.com/repos/matethurzo/liferay-portal/statuses/12553a70f6aa1190fe1e10e60d4c72868b76a330"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"commits":2,"additions":3,"deletions":9,"changed_files":4}}