{"action":"closed","number":3359,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3359","id":28033025,"html_url":"https://github.com/netty/netty/pull/3359","diff_url":"https://github.com/netty/netty/pull/3359.diff","patch_url":"https://github.com/netty/netty/pull/3359.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/3359","number":3359,"state":"closed","locked":false,"title":"Zlib decoder calls reduction and index fix","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"Motivation:\r\nThe JdkZlibDecoder and JZlibDecoder call isReadable and readableBytes in the same method. There is an opportunity to reduce the number of methods calls to just use readableBytes.  JdkZlibDecoder reads from a ByteBuf with an absolute index instead of using readerIndex()\r\n\r\nModifications:\r\n- Use readableBytes where isReadable was used\r\n- Correct absolute ByteBuf index to be relative to readerIndex()\r\n\r\nResult:\r\nLess method calls duplicating work and preventing an index out of bounds exception.","created_at":"2015-01-26T15:12:45Z","updated_at":"2015-01-26T20:17:01Z","closed_at":"2015-01-26T20:17:01Z","merged_at":null,"merge_commit_sha":"aee5f176be6bbf47e435f02e014188c5982fbfd4","assignee":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/109","labels_url":"https://api.github.com/repos/netty/netty/milestones/109/labels","id":918308,"number":109,"title":"4.0.26.Final","description":null,"creator":{"login":"trustin","id":173918,"avatar_url":"https://avatars.githubusercontent.com/u/173918?v=3","gravatar_id":"","url":"https://api.github.com/users/trustin","html_url":"https://github.com/trustin","followers_url":"https://api.github.com/users/trustin/followers","following_url":"https://api.github.com/users/trustin/following{/other_user}","gists_url":"https://api.github.com/users/trustin/gists{/gist_id}","starred_url":"https://api.github.com/users/trustin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trustin/subscriptions","organizations_url":"https://api.github.com/users/trustin/orgs","repos_url":"https://api.github.com/users/trustin/repos","events_url":"https://api.github.com/users/trustin/events{/privacy}","received_events_url":"https://api.github.com/users/trustin/received_events","type":"User","site_admin":false},"open_issues":56,"closed_issues":14,"state":"open","created_at":"2014-12-31T07:43:52Z","updated_at":"2015-01-26T20:17:01Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/netty/netty/pulls/3359/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/3359/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments/{number}","comments_url":"https://api.github.com/repos/netty/netty/issues/3359/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/f04d62d33999512755c1dc67e59ab45420a9009c","head":{"label":"akamai:zlib_cleanup","ref":"zlib_cleanup","sha":"f04d62d33999512755c1dc67e59ab45420a9009c","user":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=3","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"repo":{"id":22530159,"name":"netty","full_name":"akamai/netty","owner":{"login":"akamai","id":7504551,"avatar_url":"https://avatars.githubusercontent.com/u/7504551?v=3","gravatar_id":"","url":"https://api.github.com/users/akamai","html_url":"https://github.com/akamai","followers_url":"https://api.github.com/users/akamai/followers","following_url":"https://api.github.com/users/akamai/following{/other_user}","gists_url":"https://api.github.com/users/akamai/gists{/gist_id}","starred_url":"https://api.github.com/users/akamai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akamai/subscriptions","organizations_url":"https://api.github.com/users/akamai/orgs","repos_url":"https://api.github.com/users/akamai/repos","events_url":"https://api.github.com/users/akamai/events{/privacy}","received_events_url":"https://api.github.com/users/akamai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akamai/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/akamai/netty","forks_url":"https://api.github.com/repos/akamai/netty/forks","keys_url":"https://api.github.com/repos/akamai/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akamai/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akamai/netty/teams","hooks_url":"https://api.github.com/repos/akamai/netty/hooks","issue_events_url":"https://api.github.com/repos/akamai/netty/issues/events{/number}","events_url":"https://api.github.com/repos/akamai/netty/events","assignees_url":"https://api.github.com/repos/akamai/netty/assignees{/user}","branches_url":"https://api.github.com/repos/akamai/netty/branches{/branch}","tags_url":"https://api.github.com/repos/akamai/netty/tags","blobs_url":"https://api.github.com/repos/akamai/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akamai/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akamai/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/akamai/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akamai/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/akamai/netty/languages","stargazers_url":"https://api.github.com/repos/akamai/netty/stargazers","contributors_url":"https://api.github.com/repos/akamai/netty/contributors","subscribers_url":"https://api.github.com/repos/akamai/netty/subscribers","subscription_url":"https://api.github.com/repos/akamai/netty/subscription","commits_url":"https://api.github.com/repos/akamai/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/akamai/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/akamai/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/akamai/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/akamai/netty/contents/{+path}","compare_url":"https://api.github.com/repos/akamai/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akamai/netty/merges","archive_url":"https://api.github.com/repos/akamai/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akamai/netty/downloads","issues_url":"https://api.github.com/repos/akamai/netty/issues{/number}","pulls_url":"https://api.github.com/repos/akamai/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/akamai/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/akamai/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akamai/netty/labels{/name}","releases_url":"https://api.github.com/repos/akamai/netty/releases{/id}","created_at":"2014-08-01T21:49:13Z","updated_at":"2015-01-22T21:45:11Z","pushed_at":"2015-01-26T15:12:16Z","git_url":"git://github.com/akamai/netty.git","ssh_url":"git@github.com:akamai/netty.git","clone_url":"https://github.com/akamai/netty.git","svn_url":"https://github.com/akamai/netty","homepage":"http://netty.io/","size":38835,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:4.1","ref":"4.1","sha":"bc97d7d7a17b058a7ed1084aa3aced5fe349e86c","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments/{number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-01-26T20:16:06Z","pushed_at":"2015-01-26T20:16:32Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":106120,"stargazers_count":4089,"watchers_count":4089,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1987,"mirror_url":null,"open_issues_count":216,"forks":1987,"open_issues":216,"watchers":4089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/3359"},"html":{"href":"https://github.com/netty/netty/pull/3359"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/3359"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/3359/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/3359/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/3359/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/f04d62d33999512755c1dc67e59ab45420a9009c"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":10,"deletions":8,"changed_files":2}}