{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/35930221","id":35930221,"diff_hunk":"@@ -302,8 +336,7 @@ public void transportTerminated() {\n           log.warning(\"transportTerminated called without previous transportShutdown\");\n           activeTransport = null;\n         }\n-        // TODO(notcarl): replace this with something more meaningful\n-        transportShutdown(Status.UNKNOWN);\n+        clearActiveTransport();","path":"core/src/main/java/io/grpc/ChannelImpl.java","position":124,"original_position":124,"commit_id":"54beb4045b59f29715ba837e60a8e12115e05bf6","original_commit_id":"ef20386f9bbd7aad9369a80a2f1d6eb2c167f1b1","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"Good point.  Strangely transportShutdown() was being called here originally, which was in the same situation.","created_at":"2015-07-30T22:47:17Z","updated_at":"2015-07-30T22:47:17Z","html_url":"https://github.com/grpc/grpc-java/pull/672#discussion_r35930221","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/672","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/35930221"},"html":{"href":"https://github.com/grpc/grpc-java/pull/672#discussion_r35930221"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/672","id":40952443,"html_url":"https://github.com/grpc/grpc-java/pull/672","diff_url":"https://github.com/grpc/grpc-java/pull/672.diff","patch_url":"https://github.com/grpc/grpc-java/pull/672.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/672","number":672,"state":"open","locked":false,"title":"Alternate Channel Reconnect implementation","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-27T21:37:14Z","updated_at":"2015-07-30T22:47:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea3e2240809e22f6749fa6b73872a41c92cf8a92","assignee":{"login":"ejona86","id":2811396,"avatar_url":"https://avatars.githubusercontent.com/u/2811396?v=3","gravatar_id":"","url":"https://api.github.com/users/ejona86","html_url":"https://github.com/ejona86","followers_url":"https://api.github.com/users/ejona86/followers","following_url":"https://api.github.com/users/ejona86/following{/other_user}","gists_url":"https://api.github.com/users/ejona86/gists{/gist_id}","starred_url":"https://api.github.com/users/ejona86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejona86/subscriptions","organizations_url":"https://api.github.com/users/ejona86/orgs","repos_url":"https://api.github.com/users/ejona86/repos","events_url":"https://api.github.com/users/ejona86/events{/privacy}","received_events_url":"https://api.github.com/users/ejona86/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/672/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/672/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/672/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/54beb4045b59f29715ba837e60a8e12115e05bf6","head":{"label":"carl-mastrangelo:blockingChannelImple","ref":"blockingChannelImple","sha":"54beb4045b59f29715ba837e60a8e12115e05bf6","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"repo":{"id":38781678,"name":"grpc-java","full_name":"carl-mastrangelo/grpc-java","owner":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carl-mastrangelo/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/carl-mastrangelo/grpc-java","forks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/forks","keys_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/teams","hooks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/events","assignees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/tags","blobs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/languages","stargazers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscription","commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/merges","archive_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/downloads","issues_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/releases{/id}","created_at":"2015-07-08T21:45:19Z","updated_at":"2015-07-08T21:45:20Z","pushed_at":"2015-07-30T22:45:38Z","git_url":"git://github.com/carl-mastrangelo/grpc-java.git","ssh_url":"git@github.com:carl-mastrangelo/grpc-java.git","clone_url":"https://github.com/carl-mastrangelo/grpc-java.git","svn_url":"https://github.com/carl-mastrangelo/grpc-java","homepage":"","size":3112,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"bd8987af1a143ca9fe639e3d3a6be604fb004f7d","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","created_at":"2014-12-08T19:00:00Z","updated_at":"2015-07-29T14:32:07Z","pushed_at":"2015-07-30T22:45:39Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"","size":20066,"stargazers_count":805,"watchers_count":805,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":182,"mirror_url":null,"open_issues_count":87,"forks":182,"open_issues":87,"watchers":805,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/672"},"html":{"href":"https://github.com/grpc/grpc-java/pull/672"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/672"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/54beb4045b59f29715ba837e60a8e12115e05bf6"}}}}