{"action":"created","comment":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/23115975","id":23115975,"diff_hunk":"@@ -145,10 +145,10 @@ angular.module('uiGmapgoogle-maps.directives.api.models.child')\n         return if @isNotValid(scope) or !@gObject?\n         @renderGMarker doDraw, =>\n           oldValue = @gObject.getIcon()","path":"src/coffee/directives/api/models/child/marker-child-model.coffee","position":3,"original_position":3,"commit_id":"7fe5f4cccde9612affe8425fda0452c945c703f8","original_commit_id":"7fe5f4cccde9612affe8425fda0452c945c703f8","user":{"login":"zlegein","id":18176,"avatar_url":"https://avatars.githubusercontent.com/u/18176?v=3","gravatar_id":"","url":"https://api.github.com/users/zlegein","html_url":"https://github.com/zlegein","followers_url":"https://api.github.com/users/zlegein/followers","following_url":"https://api.github.com/users/zlegein/following{/other_user}","gists_url":"https://api.github.com/users/zlegein/gists{/gist_id}","starred_url":"https://api.github.com/users/zlegein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlegein/subscriptions","organizations_url":"https://api.github.com/users/zlegein/orgs","repos_url":"https://api.github.com/users/zlegein/repos","events_url":"https://api.github.com/users/zlegein/events{/privacy}","received_events_url":"https://api.github.com/users/zlegein/received_events","type":"User","site_admin":false},"body":"no, i didn't put this in master","created_at":"2015-01-16T23:03:27Z","updated_at":"2015-01-16T23:03:27Z","html_url":"https://github.com/angular-ui/angular-google-maps/pull/1094#discussion_r23115975","pull_request_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094","_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/23115975"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/1094#discussion_r23115975"},"pull_request":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094"}}},"pull_request":{"url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094","id":27535214,"html_url":"https://github.com/angular-ui/angular-google-maps/pull/1094","diff_url":"https://github.com/angular-ui/angular-google-maps/pull/1094.diff","patch_url":"https://github.com/angular-ui/angular-google-maps/pull/1094.patch","issue_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1094","number":1094,"state":"closed","locked":false,"title":"1075 - patch for getting the icon model property","user":{"login":"zlegein","id":18176,"avatar_url":"https://avatars.githubusercontent.com/u/18176?v=3","gravatar_id":"","url":"https://api.github.com/users/zlegein","html_url":"https://github.com/zlegein","followers_url":"https://api.github.com/users/zlegein/followers","following_url":"https://api.github.com/users/zlegein/following{/other_user}","gists_url":"https://api.github.com/users/zlegein/gists{/gist_id}","starred_url":"https://api.github.com/users/zlegein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlegein/subscriptions","organizations_url":"https://api.github.com/users/zlegein/orgs","repos_url":"https://api.github.com/users/zlegein/repos","events_url":"https://api.github.com/users/zlegein/events{/privacy}","received_events_url":"https://api.github.com/users/zlegein/received_events","type":"User","site_admin":false},"body":"I was getting this error when using the new plural code:\r\n```\r\nTypeError: Cannot read property 'http://maps.google.com/mapfiles/ms/icons/blue-dot.png' of undefined\r\n    at MarkerChildModel.angular.module.factory.ModelKey.scopeOrModelVal (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:1396:60)\r\n    at MarkerChildModel.angular.module.factory.ModelKey.getProp (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:1328:23)\r\n    at MarkerChildModel.__bind [as getProp] (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:1265:63)\r\n    at http://localhost:3100/dist/angular-google-maps_dev_mapped.js:3164:32\r\n    at MarkerChildModel.angular.module.factory.MarkerChildModel.renderGMarker (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:3040:15)\r\n    at MarkerChildModel.angular.module.factory.MarkerChildModel.setIcon (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:3160:23)\r\n    at __bind (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:2889:63)\r\n    at MarkerChildModel.angular.module.factory.MarkerChildModel.maybeSetScopeValue (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:3112:13)\r\n    at MarkerChildModel.__bind [as maybeSetScopeValue] (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:2889:63)\r\n    at MarkerChildModel.angular.module.factory.MarkerChildModel.setMyScope (http://localhost:3100/dist/angular-google-maps_dev_mapped.js:3080:27)\r\n```\r\nSo, I added the `scope` back into the `getProp` call and that got things back to where they were. I added an issue as an example to play around with.  You can toggle the icon property and you can toggle the marker object. But once you toggle the marker object you can no longer toggle the icon property. I was still looking into why that was. It appears to be an issue when replacing the model object in the collection, once that happens the replacement is not longer binding properly.","created_at":"2015-01-16T20:47:30Z","updated_at":"2015-01-16T23:03:27Z","closed_at":"2015-01-16T23:00:04Z","merged_at":"2015-01-16T23:00:04Z","merge_commit_sha":"a841cc32ffba629d2c2cfb70f0035ec9af7ec535","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/{number}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1094/comments","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/7fe5f4cccde9612affe8425fda0452c945c703f8","head":{"label":"zlegein:develop","ref":"develop","sha":"7fe5f4cccde9612affe8425fda0452c945c703f8","user":{"login":"zlegein","id":18176,"avatar_url":"https://avatars.githubusercontent.com/u/18176?v=3","gravatar_id":"","url":"https://api.github.com/users/zlegein","html_url":"https://github.com/zlegein","followers_url":"https://api.github.com/users/zlegein/followers","following_url":"https://api.github.com/users/zlegein/following{/other_user}","gists_url":"https://api.github.com/users/zlegein/gists{/gist_id}","starred_url":"https://api.github.com/users/zlegein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlegein/subscriptions","organizations_url":"https://api.github.com/users/zlegein/orgs","repos_url":"https://api.github.com/users/zlegein/repos","events_url":"https://api.github.com/users/zlegein/events{/privacy}","received_events_url":"https://api.github.com/users/zlegein/received_events","type":"User","site_admin":false},"repo":{"id":29308030,"name":"angular-google-maps","full_name":"zlegein/angular-google-maps","owner":{"login":"zlegein","id":18176,"avatar_url":"https://avatars.githubusercontent.com/u/18176?v=3","gravatar_id":"","url":"https://api.github.com/users/zlegein","html_url":"https://github.com/zlegein","followers_url":"https://api.github.com/users/zlegein/followers","following_url":"https://api.github.com/users/zlegein/following{/other_user}","gists_url":"https://api.github.com/users/zlegein/gists{/gist_id}","starred_url":"https://api.github.com/users/zlegein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zlegein/subscriptions","organizations_url":"https://api.github.com/users/zlegein/orgs","repos_url":"https://api.github.com/users/zlegein/repos","events_url":"https://api.github.com/users/zlegein/events{/privacy}","received_events_url":"https://api.github.com/users/zlegein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zlegein/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":true,"url":"https://api.github.com/repos/zlegein/angular-google-maps","forks_url":"https://api.github.com/repos/zlegein/angular-google-maps/forks","keys_url":"https://api.github.com/repos/zlegein/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zlegein/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zlegein/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/zlegein/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/zlegein/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/zlegein/angular-google-maps/events","assignees_url":"https://api.github.com/repos/zlegein/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/zlegein/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/zlegein/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/zlegein/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zlegein/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zlegein/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/zlegein/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zlegein/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/zlegein/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/zlegein/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/zlegein/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/zlegein/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/zlegein/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/zlegein/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/zlegein/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/zlegein/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/zlegein/angular-google-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/zlegein/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/zlegein/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zlegein/angular-google-maps/merges","archive_url":"https://api.github.com/repos/zlegein/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zlegein/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/zlegein/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/zlegein/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/zlegein/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/zlegein/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zlegein/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/zlegein/angular-google-maps/releases{/id}","created_at":"2015-01-15T17:05:44Z","updated_at":"2015-01-15T17:05:46Z","pushed_at":"2015-01-16T20:40:21Z","git_url":"git://github.com/zlegein/angular-google-maps.git","ssh_url":"git@github.com:zlegein/angular-google-maps.git","clone_url":"https://github.com/zlegein/angular-google-maps.git","svn_url":"https://github.com/zlegein/angular-google-maps","homepage":"http://angular-ui.github.io/angular-google-maps","size":21382,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular-ui:develop","ref":"develop","sha":"0f11ae653ad523a18621e67abe29f13fd3170f3a","user":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"repo":{"id":5438867,"name":"angular-google-maps","full_name":"angular-ui/angular-google-maps","owner":{"login":"angular-ui","id":1530011,"avatar_url":"https://avatars.githubusercontent.com/u/1530011?v=3","gravatar_id":"","url":"https://api.github.com/users/angular-ui","html_url":"https://github.com/angular-ui","followers_url":"https://api.github.com/users/angular-ui/followers","following_url":"https://api.github.com/users/angular-ui/following{/other_user}","gists_url":"https://api.github.com/users/angular-ui/gists{/gist_id}","starred_url":"https://api.github.com/users/angular-ui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular-ui/subscriptions","organizations_url":"https://api.github.com/users/angular-ui/orgs","repos_url":"https://api.github.com/users/angular-ui/repos","events_url":"https://api.github.com/users/angular-ui/events{/privacy}","received_events_url":"https://api.github.com/users/angular-ui/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular-ui/angular-google-maps","description":"AngularJS directives for the Google Maps Javascript API","fork":false,"url":"https://api.github.com/repos/angular-ui/angular-google-maps","forks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/forks","keys_url":"https://api.github.com/repos/angular-ui/angular-google-maps/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular-ui/angular-google-maps/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular-ui/angular-google-maps/teams","hooks_url":"https://api.github.com/repos/angular-ui/angular-google-maps/hooks","issue_events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/events{/number}","events_url":"https://api.github.com/repos/angular-ui/angular-google-maps/events","assignees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/assignees{/user}","branches_url":"https://api.github.com/repos/angular-ui/angular-google-maps/branches{/branch}","tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/tags","blobs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/{sha}","languages_url":"https://api.github.com/repos/angular-ui/angular-google-maps/languages","stargazers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/stargazers","contributors_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contributors","subscribers_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscribers","subscription_url":"https://api.github.com/repos/angular-ui/angular-google-maps/subscription","commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular-ui/angular-google-maps/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular-ui/angular-google-maps/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/comments/{number}","contents_url":"https://api.github.com/repos/angular-ui/angular-google-maps/contents/{+path}","compare_url":"https://api.github.com/repos/angular-ui/angular-google-maps/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular-ui/angular-google-maps/merges","archive_url":"https://api.github.com/repos/angular-ui/angular-google-maps/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular-ui/angular-google-maps/downloads","issues_url":"https://api.github.com/repos/angular-ui/angular-google-maps/issues{/number}","pulls_url":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls{/number}","milestones_url":"https://api.github.com/repos/angular-ui/angular-google-maps/milestones{/number}","notifications_url":"https://api.github.com/repos/angular-ui/angular-google-maps/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular-ui/angular-google-maps/labels{/name}","releases_url":"https://api.github.com/repos/angular-ui/angular-google-maps/releases{/id}","created_at":"2012-08-16T12:50:47Z","updated_at":"2015-01-16T21:24:41Z","pushed_at":"2015-01-16T23:00:04Z","git_url":"git://github.com/angular-ui/angular-google-maps.git","ssh_url":"git@github.com:angular-ui/angular-google-maps.git","clone_url":"https://github.com/angular-ui/angular-google-maps.git","svn_url":"https://github.com/angular-ui/angular-google-maps","homepage":"http://angular-ui.github.io/angular-google-maps","size":36044,"stargazers_count":1349,"watchers_count":1349,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":550,"mirror_url":null,"open_issues_count":83,"forks":550,"open_issues":83,"watchers":1349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094"},"html":{"href":"https://github.com/angular-ui/angular-google-maps/pull/1094"},"issue":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1094"},"comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/angular-ui/angular-google-maps/statuses/7fe5f4cccde9612affe8425fda0452c945c703f8"}}}}