{"action":"created","issue":{"url":"https://api.github.com/repos/esbullington/react-d3/issues/247","labels_url":"https://api.github.com/repos/esbullington/react-d3/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/esbullington/react-d3/issues/247/comments","events_url":"https://api.github.com/repos/esbullington/react-d3/issues/247/events","html_url":"https://github.com/esbullington/react-d3/pull/247","id":99661932,"number":247,"title":"Data point symbols","user":{"login":"nightlyop","id":5469488,"avatar_url":"https://avatars.githubusercontent.com/u/5469488?v=3","gravatar_id":"","url":"https://api.github.com/users/nightlyop","html_url":"https://github.com/nightlyop","followers_url":"https://api.github.com/users/nightlyop/followers","following_url":"https://api.github.com/users/nightlyop/following{/other_user}","gists_url":"https://api.github.com/users/nightlyop/gists{/gist_id}","starred_url":"https://api.github.com/users/nightlyop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightlyop/subscriptions","organizations_url":"https://api.github.com/users/nightlyop/orgs","repos_url":"https://api.github.com/users/nightlyop/repos","events_url":"https://api.github.com/users/nightlyop/events{/privacy}","received_events_url":"https://api.github.com/users/nightlyop/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-08-07T14:47:59Z","updated_at":"2015-08-26T06:11:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/esbullington/react-d3/pulls/247","html_url":"https://github.com/esbullington/react-d3/pull/247","diff_url":"https://github.com/esbullington/react-d3/pull/247.diff","patch_url":"https://github.com/esbullington/react-d3/pull/247.patch"},"body":"Currently, all data points in line charts are displayed as circles. I need the possibility to use other symbols (eg. squares, stars, diamonds, \"v\", ...) to display the data points. Moreover I need to be able to specify the symbol for every data point. The reason therefore is, that my chart has to use the same system as an older one we're selling. In our case the kind of symbol indicates special observations made when the displayed value was measured.\r\n\r\nI tried to make the Voronoi Container more generic and so far the symbols `circle` (default; same as before) and `rect` can be used.\r\n\r\n`VoronoiContainer.jsx` replaces `VoronoiCircleContainer.jsx` because most of the symbols I'd like to create will share most of the code in here. Because of that I also renamed variables like `circleFill` to `symbolFill`.\r\n\r\nWhat do you think about this approach?"},"comment":{"url":"https://api.github.com/repos/esbullington/react-d3/issues/comments/134850465","html_url":"https://github.com/esbullington/react-d3/pull/247#issuecomment-134850465","issue_url":"https://api.github.com/repos/esbullington/react-d3/issues/247","id":134850465,"user":{"login":"nightlyop","id":5469488,"avatar_url":"https://avatars.githubusercontent.com/u/5469488?v=3","gravatar_id":"","url":"https://api.github.com/users/nightlyop","html_url":"https://github.com/nightlyop","followers_url":"https://api.github.com/users/nightlyop/followers","following_url":"https://api.github.com/users/nightlyop/following{/other_user}","gists_url":"https://api.github.com/users/nightlyop/gists{/gist_id}","starred_url":"https://api.github.com/users/nightlyop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightlyop/subscriptions","organizations_url":"https://api.github.com/users/nightlyop/orgs","repos_url":"https://api.github.com/users/nightlyop/repos","events_url":"https://api.github.com/users/nightlyop/events{/privacy}","received_events_url":"https://api.github.com/users/nightlyop/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T06:11:34Z","updated_at":"2015-08-26T06:11:34Z","body":"Sure, I'm not in a hurry."}}