{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/31","id":37236281,"html_url":"https://github.com/MovingBlocks/DestinationSol/pull/31","diff_url":"https://github.com/MovingBlocks/DestinationSol/pull/31.diff","patch_url":"https://github.com/MovingBlocks/DestinationSol/pull/31.patch","issue_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/31","number":31,"state":"closed","locked":false,"title":"Resolution screen show supported resolutions","user":{"login":"SimonC4","id":7613950,"avatar_url":"https://avatars.githubusercontent.com/u/7613950?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonC4","html_url":"https://github.com/SimonC4","followers_url":"https://api.github.com/users/SimonC4/followers","following_url":"https://api.github.com/users/SimonC4/following{/other_user}","gists_url":"https://api.github.com/users/SimonC4/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonC4/subscriptions","organizations_url":"https://api.github.com/users/SimonC4/orgs","repos_url":"https://api.github.com/users/SimonC4/repos","events_url":"https://api.github.com/users/SimonC4/events{/privacy}","received_events_url":"https://api.github.com/users/SimonC4/received_events","type":"User","site_admin":false},"body":"This had been bugging me. The resolution screen showed 3 hardcoded resolutions regardless of whether they were supported or not. This would cause crashes on my machine if selected incorrectly and is the cause of other user's issues as reported on Steam.\r\n\r\nThe solution is to cycle through supported resolutions as provided by libGDX. This isn't the most elegant as some of the resolutions are very small, but from my testing on Mac and Windows 7, all of the supplied resolutions work in windows or full screen, so at least it will prevent crashes. \r\n\r\nI also made another change that after you leave the resolution screen, the new settings are applied immediately without having to restart the game. \r\n\r\nIt's not perfect and could do with some refinements, but I think it's better than what currently exists. Would be keen for someone else to do some testing on it. ","created_at":"2015-06-09T09:52:15Z","updated_at":"2015-06-23T03:14:16Z","closed_at":"2015-06-23T03:14:16Z","merged_at":"2015-06-23T03:14:16Z","merge_commit_sha":"b493528b262f78b019f7e4c0ca6d53918e3e14ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/31/commits","review_comments_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/31/comments","review_comment_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/31/comments","statuses_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/statuses/33b0a81774efdebf0a7eca530c43f817a1116ae7","head":{"label":"SimonC4:graphics","ref":"graphics","sha":"33b0a81774efdebf0a7eca530c43f817a1116ae7","user":{"login":"SimonC4","id":7613950,"avatar_url":"https://avatars.githubusercontent.com/u/7613950?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonC4","html_url":"https://github.com/SimonC4","followers_url":"https://api.github.com/users/SimonC4/followers","following_url":"https://api.github.com/users/SimonC4/following{/other_user}","gists_url":"https://api.github.com/users/SimonC4/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonC4/subscriptions","organizations_url":"https://api.github.com/users/SimonC4/orgs","repos_url":"https://api.github.com/users/SimonC4/repos","events_url":"https://api.github.com/users/SimonC4/events{/privacy}","received_events_url":"https://api.github.com/users/SimonC4/received_events","type":"User","site_admin":false},"repo":{"id":35849336,"name":"DestinationSol","full_name":"SimonC4/DestinationSol","owner":{"login":"SimonC4","id":7613950,"avatar_url":"https://avatars.githubusercontent.com/u/7613950?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonC4","html_url":"https://github.com/SimonC4","followers_url":"https://api.github.com/users/SimonC4/followers","following_url":"https://api.github.com/users/SimonC4/following{/other_user}","gists_url":"https://api.github.com/users/SimonC4/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonC4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonC4/subscriptions","organizations_url":"https://api.github.com/users/SimonC4/orgs","repos_url":"https://api.github.com/users/SimonC4/repos","events_url":"https://api.github.com/users/SimonC4/events{/privacy}","received_events_url":"https://api.github.com/users/SimonC4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SimonC4/DestinationSol","description":"Official continuation of Destination Sol, the great fun little arcade space shooter from http://sourceforge.net/projects/destinationsol/","fork":true,"url":"https://api.github.com/repos/SimonC4/DestinationSol","forks_url":"https://api.github.com/repos/SimonC4/DestinationSol/forks","keys_url":"https://api.github.com/repos/SimonC4/DestinationSol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SimonC4/DestinationSol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SimonC4/DestinationSol/teams","hooks_url":"https://api.github.com/repos/SimonC4/DestinationSol/hooks","issue_events_url":"https://api.github.com/repos/SimonC4/DestinationSol/issues/events{/number}","events_url":"https://api.github.com/repos/SimonC4/DestinationSol/events","assignees_url":"https://api.github.com/repos/SimonC4/DestinationSol/assignees{/user}","branches_url":"https://api.github.com/repos/SimonC4/DestinationSol/branches{/branch}","tags_url":"https://api.github.com/repos/SimonC4/DestinationSol/tags","blobs_url":"https://api.github.com/repos/SimonC4/DestinationSol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SimonC4/DestinationSol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SimonC4/DestinationSol/git/refs{/sha}","trees_url":"https://api.github.com/repos/SimonC4/DestinationSol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SimonC4/DestinationSol/statuses/{sha}","languages_url":"https://api.github.com/repos/SimonC4/DestinationSol/languages","stargazers_url":"https://api.github.com/repos/SimonC4/DestinationSol/stargazers","contributors_url":"https://api.github.com/repos/SimonC4/DestinationSol/contributors","subscribers_url":"https://api.github.com/repos/SimonC4/DestinationSol/subscribers","subscription_url":"https://api.github.com/repos/SimonC4/DestinationSol/subscription","commits_url":"https://api.github.com/repos/SimonC4/DestinationSol/commits{/sha}","git_commits_url":"https://api.github.com/repos/SimonC4/DestinationSol/git/commits{/sha}","comments_url":"https://api.github.com/repos/SimonC4/DestinationSol/comments{/number}","issue_comment_url":"https://api.github.com/repos/SimonC4/DestinationSol/issues/comments{/number}","contents_url":"https://api.github.com/repos/SimonC4/DestinationSol/contents/{+path}","compare_url":"https://api.github.com/repos/SimonC4/DestinationSol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SimonC4/DestinationSol/merges","archive_url":"https://api.github.com/repos/SimonC4/DestinationSol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SimonC4/DestinationSol/downloads","issues_url":"https://api.github.com/repos/SimonC4/DestinationSol/issues{/number}","pulls_url":"https://api.github.com/repos/SimonC4/DestinationSol/pulls{/number}","milestones_url":"https://api.github.com/repos/SimonC4/DestinationSol/milestones{/number}","notifications_url":"https://api.github.com/repos/SimonC4/DestinationSol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SimonC4/DestinationSol/labels{/name}","releases_url":"https://api.github.com/repos/SimonC4/DestinationSol/releases{/id}","created_at":"2015-05-19T00:13:57Z","updated_at":"2015-06-19T08:35:03Z","pushed_at":"2015-06-19T09:01:57Z","git_url":"git://github.com/SimonC4/DestinationSol.git","ssh_url":"git@github.com:SimonC4/DestinationSol.git","clone_url":"https://github.com/SimonC4/DestinationSol.git","svn_url":"https://github.com/SimonC4/DestinationSol","homepage":null,"size":196641,"stargazers_count":0,"watchers_count":0,"language":"Groff","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MovingBlocks:master","ref":"master","sha":"e160be655c5ec7fe10774bb022c614741cb3b3c0","user":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"repo":{"id":34216921,"name":"DestinationSol","full_name":"MovingBlocks/DestinationSol","owner":{"login":"MovingBlocks","id":1292442,"avatar_url":"https://avatars.githubusercontent.com/u/1292442?v=3","gravatar_id":"","url":"https://api.github.com/users/MovingBlocks","html_url":"https://github.com/MovingBlocks","followers_url":"https://api.github.com/users/MovingBlocks/followers","following_url":"https://api.github.com/users/MovingBlocks/following{/other_user}","gists_url":"https://api.github.com/users/MovingBlocks/gists{/gist_id}","starred_url":"https://api.github.com/users/MovingBlocks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MovingBlocks/subscriptions","organizations_url":"https://api.github.com/users/MovingBlocks/orgs","repos_url":"https://api.github.com/users/MovingBlocks/repos","events_url":"https://api.github.com/users/MovingBlocks/events{/privacy}","received_events_url":"https://api.github.com/users/MovingBlocks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MovingBlocks/DestinationSol","description":"Official continuation of Destination Sol, the great fun little arcade space shooter from http://sourceforge.net/projects/destinationsol/","fork":false,"url":"https://api.github.com/repos/MovingBlocks/DestinationSol","forks_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/forks","keys_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/teams","hooks_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/hooks","issue_events_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/events{/number}","events_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/events","assignees_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/assignees{/user}","branches_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/branches{/branch}","tags_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/tags","blobs_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/git/refs{/sha}","trees_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/statuses/{sha}","languages_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/languages","stargazers_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/stargazers","contributors_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/contributors","subscribers_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/subscribers","subscription_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/subscription","commits_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/commits{/sha}","git_commits_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/git/commits{/sha}","comments_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/comments{/number}","issue_comment_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/comments{/number}","contents_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/contents/{+path}","compare_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/merges","archive_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/downloads","issues_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues{/number}","pulls_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls{/number}","milestones_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/milestones{/number}","notifications_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/labels{/name}","releases_url":"https://api.github.com/repos/MovingBlocks/DestinationSol/releases{/id}","created_at":"2015-04-19T17:41:27Z","updated_at":"2015-06-18T17:12:22Z","pushed_at":"2015-06-23T03:14:15Z","git_url":"git://github.com/MovingBlocks/DestinationSol.git","ssh_url":"git@github.com:MovingBlocks/DestinationSol.git","clone_url":"https://github.com/MovingBlocks/DestinationSol.git","svn_url":"https://github.com/MovingBlocks/DestinationSol","homepage":null,"size":196948,"stargazers_count":8,"watchers_count":8,"language":"Groff","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":8,"forks":7,"open_issues":8,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/31"},"html":{"href":"https://github.com/MovingBlocks/DestinationSol/pull/31"},"issue":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/31"},"comments":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/MovingBlocks/DestinationSol/statuses/33b0a81774efdebf0a7eca530c43f817a1116ae7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars.githubusercontent.com/u/1063833?v=3","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":3,"additions":24,"deletions":13,"changed_files":3}}