{"action":"opened","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/3","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/3/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/3/events","html_url":"https://github.com/JoinMarket-Org/joinmarket/issues/3","id":119781830,"number":3,"title":"[CLOSED] Investigate nonce usage in libnacl","user":{"login":"AdamISZ","id":4278257,"avatar_url":"https://avatars.githubusercontent.com/u/4278257?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamISZ","html_url":"https://github.com/AdamISZ","followers_url":"https://api.github.com/users/AdamISZ/followers","following_url":"https://api.github.com/users/AdamISZ/following{/other_user}","gists_url":"https://api.github.com/users/AdamISZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamISZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamISZ/subscriptions","organizations_url":"https://api.github.com/users/AdamISZ/orgs","repos_url":"https://api.github.com/users/AdamISZ/repos","events_url":"https://api.github.com/users/AdamISZ/events{/privacy}","received_events_url":"https://api.github.com/users/AdamISZ/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-12-01T18:48:02Z","updated_at":"2015-12-01T18:48:02Z","closed_at":null,"body":"<a href=\"https://github.com/AdamISZ\"><img src=\"https://avatars.githubusercontent.com/u/4278257?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [AdamISZ](https://github.com/AdamISZ)**\n_Friday Jan 23, 2015 at 17:46 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT_\n_Originally opened as https://github.com/chris-belcher/joinmarket/issues/3_\n\n----\n\nAccording to the libnacl documentation:\r\n\r\n\"Every encryption routine requires a nonce. The nonce is a 24 char string that must never be used twice with the same keypair. If no nonce is passed in then a nonce is generated based on random data. If it is desired to generate a nonce manually this can be done by passing it into the encrypt method.\"\r\n\r\n(from https://libnacl.readthedocs.org/en/latest/topics/public.html ).\r\n\r\nIt would be good to double check and evaluate whether the nonce defaults are correct and safe, especially to have another pair of eyes look at it.\r\n\r\n(libnacl is the Python binding we use to libsodium: http://doc.libsodium.org/index.html)\n"}}