{"action":"created","issue":{"url":"https://api.github.com/repos/astropy/astropy/issues/4264","labels_url":"https://api.github.com/repos/astropy/astropy/issues/4264/labels{/name}","comments_url":"https://api.github.com/repos/astropy/astropy/issues/4264/comments","events_url":"https://api.github.com/repos/astropy/astropy/issues/4264/events","html_url":"https://github.com/astropy/astropy/pull/4264","id":112882128,"number":4264,"title":"Updates to bounding box interface and cleanup","user":{"login":"embray","id":676149,"avatar_url":"https://avatars.githubusercontent.com/u/676149?v=3","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/astropy/astropy/labels/Affects-dev","name":"Affects-dev","color":"eb6420"},{"url":"https://api.github.com/repos/astropy/astropy/labels/modeling","name":"modeling","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/astropy/astropy/milestones/20","html_url":"https://github.com/astropy/astropy/milestones/v1.1.0","labels_url":"https://api.github.com/repos/astropy/astropy/milestones/20/labels","id":907426,"number":20,"title":"v1.1.0","description":"","creator":{"login":"eteq","id":346587,"avatar_url":"https://avatars.githubusercontent.com/u/346587?v=3","gravatar_id":"","url":"https://api.github.com/users/eteq","html_url":"https://github.com/eteq","followers_url":"https://api.github.com/users/eteq/followers","following_url":"https://api.github.com/users/eteq/following{/other_user}","gists_url":"https://api.github.com/users/eteq/gists{/gist_id}","starred_url":"https://api.github.com/users/eteq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eteq/subscriptions","organizations_url":"https://api.github.com/users/eteq/orgs","repos_url":"https://api.github.com/users/eteq/repos","events_url":"https://api.github.com/users/eteq/events{/privacy}","received_events_url":"https://api.github.com/users/eteq/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":173,"state":"open","created_at":"2014-12-17T20:05:23Z","updated_at":"2015-10-22T20:21:09Z","due_on":"2015-07-23T04:00:00Z","closed_at":null},"comments":2,"created_at":"2015-10-22T20:12:24Z","updated_at":"2015-10-22T21:38:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/astropy/astropy/pulls/4264","html_url":"https://github.com/astropy/astropy/pull/4264","diff_url":"https://github.com/astropy/astropy/pull/4264.diff","patch_url":"https://github.com/astropy/astropy/pull/4264.patch"},"body":"This is the update to #4040--it includes all the fixes from #4040, but also includes my updates to the bounding box interface.\r\n\r\nThe purpose of these updates, as explained in the commit message of 779ef3e5bb14d9711dc24ae26578bfd7c22d618b, is to make the interface for `bounding_box` fairly consistent with the interface for `Model.inverse`.  To that end the `bounding_box_default` method is eliminated, and model classes that define a bounding box can do so as a class-level attribute, method, or property simply called `bounding_box`, which is then wrapped by the Model metaclass to incorporate the default getter/setter behavior for the `Model.bounding_box` property.  This is similar to how `Model.inverse` works.\r\n\r\nOne downside to this that I just noticed while testing the documentation is that if a `Model` subclass has a `bounding_box` with its own docstring, that docstring usually gets thrown away.  We definitely don't want that, so I am going to open a separate issue to fix that later."},"comment":{"url":"https://api.github.com/repos/astropy/astropy/issues/comments/150363621","html_url":"https://github.com/astropy/astropy/pull/4264#issuecomment-150363621","issue_url":"https://api.github.com/repos/astropy/astropy/issues/4264","id":150363621,"user":{"login":"patti","id":4968596,"avatar_url":"https://avatars.githubusercontent.com/u/4968596?v=3","gravatar_id":"","url":"https://api.github.com/users/patti","html_url":"https://github.com/patti","followers_url":"https://api.github.com/users/patti/followers","following_url":"https://api.github.com/users/patti/following{/other_user}","gists_url":"https://api.github.com/users/patti/gists{/gist_id}","starred_url":"https://api.github.com/users/patti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patti/subscriptions","organizations_url":"https://api.github.com/users/patti/orgs","repos_url":"https://api.github.com/users/patti/repos","events_url":"https://api.github.com/users/patti/events{/privacy}","received_events_url":"https://api.github.com/users/patti/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T21:38:09Z","updated_at":"2015-10-22T21:38:09Z","body":":+1:"}}