{"action":"created","issue":{"url":"https://api.github.com/repos/aseemk/express-streamline/issues/19","labels_url":"https://api.github.com/repos/aseemk/express-streamline/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/aseemk/express-streamline/issues/19/comments","events_url":"https://api.github.com/repos/aseemk/express-streamline/issues/19/events","html_url":"https://github.com/aseemk/express-streamline/pull/19","id":58459270,"number":19,"title":"Support Express 4 Routers","user":{"login":"winniehell","id":1652293,"avatar_url":"https://avatars.githubusercontent.com/u/1652293?v=3","gravatar_id":"","url":"https://api.github.com/users/winniehell","html_url":"https://github.com/winniehell","followers_url":"https://api.github.com/users/winniehell/followers","following_url":"https://api.github.com/users/winniehell/following{/other_user}","gists_url":"https://api.github.com/users/winniehell/gists{/gist_id}","starred_url":"https://api.github.com/users/winniehell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniehell/subscriptions","organizations_url":"https://api.github.com/users/winniehell/orgs","repos_url":"https://api.github.com/users/winniehell/repos","events_url":"https://api.github.com/users/winniehell/events{/privacy}","received_events_url":"https://api.github.com/users/winniehell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-21T13:22:39Z","updated_at":"2015-02-21T18:58:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aseemk/express-streamline/pulls/19","html_url":"https://github.com/aseemk/express-streamline/pull/19","diff_url":"https://github.com/aseemk/express-streamline/pull/19.diff","patch_url":"https://github.com/aseemk/express-streamline/pull/19.patch"},"body":"For [Routers] the request handlers fall through. Please see the attached failing test. I think the problem is that Routers need to be patched along with apps.\r\n\r\nThe test checks whether Router is falling through. Since Routers don't exist in Express 3 the test is skipped. For Express 5 `process.nextTick` seems to run after the error handler. If you know of any other way please let me know...\r\n\r\n[Routers]: http://expressjs.com/4x/api.html#router"},"comment":{"url":"https://api.github.com/repos/aseemk/express-streamline/issues/comments/75386588","html_url":"https://github.com/aseemk/express-streamline/pull/19#issuecomment-75386588","issue_url":"https://api.github.com/repos/aseemk/express-streamline/issues/19","id":75386588,"user":{"login":"winniehell","id":1652293,"avatar_url":"https://avatars.githubusercontent.com/u/1652293?v=3","gravatar_id":"","url":"https://api.github.com/users/winniehell","html_url":"https://github.com/winniehell","followers_url":"https://api.github.com/users/winniehell/followers","following_url":"https://api.github.com/users/winniehell/following{/other_user}","gists_url":"https://api.github.com/users/winniehell/gists{/gist_id}","starred_url":"https://api.github.com/users/winniehell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/winniehell/subscriptions","organizations_url":"https://api.github.com/users/winniehell/orgs","repos_url":"https://api.github.com/users/winniehell/repos","events_url":"https://api.github.com/users/winniehell/events{/privacy}","received_events_url":"https://api.github.com/users/winniehell/received_events","type":"User","site_admin":false},"created_at":"2015-02-21T18:58:43Z","updated_at":"2015-02-21T18:58:43Z","body":"Nope, nevermind&mdash;seems like `Route.dispatch` is only called after the first `next()`. So maybe patching [Layer.handle_request] directly would be the right approach since all request handlers are wrapped by Layer in [Router.use].\r\n\r\n[Layer.handle_request]: /strongloop/express/blob/4.11.2/lib/router/layer.js#L73\r\n[Router.use]: /strongloop/express/blob/4.11.2/lib/router/index.js#L452-L456"}}