{"action":"closed","number":80,"pull_request":{"url":"https://api.github.com/repos/Emasher/EmashersMods/pulls/80","id":14039024,"html_url":"https://github.com/Emasher/EmashersMods/pull/80","diff_url":"https://github.com/Emasher/EmashersMods/pull/80.diff","patch_url":"https://github.com/Emasher/EmashersMods/pull/80.patch","issue_url":"https://api.github.com/repos/Emasher/EmashersMods/issues/80","number":80,"state":"closed","locked":false,"title":"shifting TileDirectionChangers now update tracks and elevators","user":{"login":"Ghoughpteighbteau","id":1427632,"avatar_url":"https://avatars.githubusercontent.com/u/1427632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghoughpteighbteau","html_url":"https://github.com/Ghoughpteighbteau","followers_url":"https://api.github.com/users/Ghoughpteighbteau/followers","following_url":"https://api.github.com/users/Ghoughpteighbteau/following{/other_user}","gists_url":"https://api.github.com/users/Ghoughpteighbteau/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghoughpteighbteau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghoughpteighbteau/subscriptions","organizations_url":"https://api.github.com/users/Ghoughpteighbteau/orgs","repos_url":"https://api.github.com/users/Ghoughpteighbteau/repos","events_url":"https://api.github.com/users/Ghoughpteighbteau/events{/privacy}","received_events_url":"https://api.github.com/users/Ghoughpteighbteau/received_events","type":"User","site_admin":false},"body":"This patch directly fixes #77\r\n\r\nLooks like much of this code would be happier if it was in scala. I miss closures and first class functions T.T\r\n\r\nAnyway, my strategy for this fix is in the case of shifting a TileDirectionChanger, to check for neighbour sockets and send them an update signal. \r\n\r\nIt has wasted operations, but it's concise.\r\n\r\nAnother strategy would be to take advantage of the onAdjChange method (which is how I assume the original submitter was getting his elevator to update). This feels more semantically correct... but I didn't like how that codepath panned out. ","created_at":"2014-03-27T01:38:06Z","updated_at":"2015-05-24T10:17:01Z","closed_at":"2015-05-24T10:17:01Z","merged_at":null,"merge_commit_sha":"4698727138a93006f6700e2381e41b8b7914f8a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Emasher/EmashersMods/pulls/80/commits","review_comments_url":"https://api.github.com/repos/Emasher/EmashersMods/pulls/80/comments","review_comment_url":"https://api.github.com/repos/Emasher/EmashersMods/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Emasher/EmashersMods/issues/80/comments","statuses_url":"https://api.github.com/repos/Emasher/EmashersMods/statuses/909d1b3037e35d55ba084b1a09d3089c5a7cac6c","head":{"label":"Ghoughpteighbteau:tileShift","ref":"tileShift","sha":"909d1b3037e35d55ba084b1a09d3089c5a7cac6c","user":{"login":"Ghoughpteighbteau","id":1427632,"avatar_url":"https://avatars.githubusercontent.com/u/1427632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghoughpteighbteau","html_url":"https://github.com/Ghoughpteighbteau","followers_url":"https://api.github.com/users/Ghoughpteighbteau/followers","following_url":"https://api.github.com/users/Ghoughpteighbteau/following{/other_user}","gists_url":"https://api.github.com/users/Ghoughpteighbteau/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghoughpteighbteau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghoughpteighbteau/subscriptions","organizations_url":"https://api.github.com/users/Ghoughpteighbteau/orgs","repos_url":"https://api.github.com/users/Ghoughpteighbteau/repos","events_url":"https://api.github.com/users/Ghoughpteighbteau/events{/privacy}","received_events_url":"https://api.github.com/users/Ghoughpteighbteau/received_events","type":"User","site_admin":false},"repo":{"id":17581549,"name":"EmashersMods","full_name":"Ghoughpteighbteau/EmashersMods","owner":{"login":"Ghoughpteighbteau","id":1427632,"avatar_url":"https://avatars.githubusercontent.com/u/1427632?v=3","gravatar_id":"","url":"https://api.github.com/users/Ghoughpteighbteau","html_url":"https://github.com/Ghoughpteighbteau","followers_url":"https://api.github.com/users/Ghoughpteighbteau/followers","following_url":"https://api.github.com/users/Ghoughpteighbteau/following{/other_user}","gists_url":"https://api.github.com/users/Ghoughpteighbteau/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghoughpteighbteau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghoughpteighbteau/subscriptions","organizations_url":"https://api.github.com/users/Ghoughpteighbteau/orgs","repos_url":"https://api.github.com/users/Ghoughpteighbteau/repos","events_url":"https://api.github.com/users/Ghoughpteighbteau/events{/privacy}","received_events_url":"https://api.github.com/users/Ghoughpteighbteau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ghoughpteighbteau/EmashersMods","description":"Emasher's Minecraft Mods","fork":true,"url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods","forks_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/forks","keys_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/teams","hooks_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/hooks","issue_events_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/issues/events{/number}","events_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/events","assignees_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/assignees{/user}","branches_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/branches{/branch}","tags_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/tags","blobs_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/statuses/{sha}","languages_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/languages","stargazers_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/stargazers","contributors_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/contributors","subscribers_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/subscribers","subscription_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/subscription","commits_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/contents/{+path}","compare_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/merges","archive_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/downloads","issues_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/issues{/number}","pulls_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/pulls{/number}","milestones_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/milestones{/number}","notifications_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/labels{/name}","releases_url":"https://api.github.com/repos/Ghoughpteighbteau/EmashersMods/releases{/id}","created_at":"2014-03-10T04:18:18Z","updated_at":"2014-03-27T01:38:06Z","pushed_at":"2014-03-27T01:30:42Z","git_url":"git://github.com/Ghoughpteighbteau/EmashersMods.git","ssh_url":"git@github.com:Ghoughpteighbteau/EmashersMods.git","clone_url":"https://github.com/Ghoughpteighbteau/EmashersMods.git","svn_url":"https://github.com/Ghoughpteighbteau/EmashersMods","homepage":null,"size":1694,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Emasher:master","ref":"master","sha":"808e3975f31632765f3d860bc31519122af86d8a","user":{"login":"Emasher","id":2807605,"avatar_url":"https://avatars.githubusercontent.com/u/2807605?v=3","gravatar_id":"","url":"https://api.github.com/users/Emasher","html_url":"https://github.com/Emasher","followers_url":"https://api.github.com/users/Emasher/followers","following_url":"https://api.github.com/users/Emasher/following{/other_user}","gists_url":"https://api.github.com/users/Emasher/gists{/gist_id}","starred_url":"https://api.github.com/users/Emasher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emasher/subscriptions","organizations_url":"https://api.github.com/users/Emasher/orgs","repos_url":"https://api.github.com/users/Emasher/repos","events_url":"https://api.github.com/users/Emasher/events{/privacy}","received_events_url":"https://api.github.com/users/Emasher/received_events","type":"User","site_admin":false},"repo":{"id":13002059,"name":"EmashersMods","full_name":"Emasher/EmashersMods","owner":{"login":"Emasher","id":2807605,"avatar_url":"https://avatars.githubusercontent.com/u/2807605?v=3","gravatar_id":"","url":"https://api.github.com/users/Emasher","html_url":"https://github.com/Emasher","followers_url":"https://api.github.com/users/Emasher/followers","following_url":"https://api.github.com/users/Emasher/following{/other_user}","gists_url":"https://api.github.com/users/Emasher/gists{/gist_id}","starred_url":"https://api.github.com/users/Emasher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Emasher/subscriptions","organizations_url":"https://api.github.com/users/Emasher/orgs","repos_url":"https://api.github.com/users/Emasher/repos","events_url":"https://api.github.com/users/Emasher/events{/privacy}","received_events_url":"https://api.github.com/users/Emasher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Emasher/EmashersMods","description":"Emasher's Minecraft Mods","fork":false,"url":"https://api.github.com/repos/Emasher/EmashersMods","forks_url":"https://api.github.com/repos/Emasher/EmashersMods/forks","keys_url":"https://api.github.com/repos/Emasher/EmashersMods/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Emasher/EmashersMods/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Emasher/EmashersMods/teams","hooks_url":"https://api.github.com/repos/Emasher/EmashersMods/hooks","issue_events_url":"https://api.github.com/repos/Emasher/EmashersMods/issues/events{/number}","events_url":"https://api.github.com/repos/Emasher/EmashersMods/events","assignees_url":"https://api.github.com/repos/Emasher/EmashersMods/assignees{/user}","branches_url":"https://api.github.com/repos/Emasher/EmashersMods/branches{/branch}","tags_url":"https://api.github.com/repos/Emasher/EmashersMods/tags","blobs_url":"https://api.github.com/repos/Emasher/EmashersMods/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Emasher/EmashersMods/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Emasher/EmashersMods/git/refs{/sha}","trees_url":"https://api.github.com/repos/Emasher/EmashersMods/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Emasher/EmashersMods/statuses/{sha}","languages_url":"https://api.github.com/repos/Emasher/EmashersMods/languages","stargazers_url":"https://api.github.com/repos/Emasher/EmashersMods/stargazers","contributors_url":"https://api.github.com/repos/Emasher/EmashersMods/contributors","subscribers_url":"https://api.github.com/repos/Emasher/EmashersMods/subscribers","subscription_url":"https://api.github.com/repos/Emasher/EmashersMods/subscription","commits_url":"https://api.github.com/repos/Emasher/EmashersMods/commits{/sha}","git_commits_url":"https://api.github.com/repos/Emasher/EmashersMods/git/commits{/sha}","comments_url":"https://api.github.com/repos/Emasher/EmashersMods/comments{/number}","issue_comment_url":"https://api.github.com/repos/Emasher/EmashersMods/issues/comments{/number}","contents_url":"https://api.github.com/repos/Emasher/EmashersMods/contents/{+path}","compare_url":"https://api.github.com/repos/Emasher/EmashersMods/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Emasher/EmashersMods/merges","archive_url":"https://api.github.com/repos/Emasher/EmashersMods/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Emasher/EmashersMods/downloads","issues_url":"https://api.github.com/repos/Emasher/EmashersMods/issues{/number}","pulls_url":"https://api.github.com/repos/Emasher/EmashersMods/pulls{/number}","milestones_url":"https://api.github.com/repos/Emasher/EmashersMods/milestones{/number}","notifications_url":"https://api.github.com/repos/Emasher/EmashersMods/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Emasher/EmashersMods/labels{/name}","releases_url":"https://api.github.com/repos/Emasher/EmashersMods/releases{/id}","created_at":"2013-09-21T20:41:51Z","updated_at":"2015-04-02T02:00:44Z","pushed_at":"2015-05-24T10:16:05Z","git_url":"git://github.com/Emasher/EmashersMods.git","ssh_url":"git@github.com:Emasher/EmashersMods.git","clone_url":"https://github.com/Emasher/EmashersMods.git","svn_url":"https://github.com/Emasher/EmashersMods","homepage":null,"size":24749,"stargazers_count":20,"watchers_count":20,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"open_issues_count":7,"forks":15,"open_issues":7,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Emasher/EmashersMods/pulls/80"},"html":{"href":"https://github.com/Emasher/EmashersMods/pull/80"},"issue":{"href":"https://api.github.com/repos/Emasher/EmashersMods/issues/80"},"comments":{"href":"https://api.github.com/repos/Emasher/EmashersMods/issues/80/comments"},"review_comments":{"href":"https://api.github.com/repos/Emasher/EmashersMods/pulls/80/comments"},"review_comment":{"href":"https://api.github.com/repos/Emasher/EmashersMods/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Emasher/EmashersMods/pulls/80/commits"},"statuses":{"href":"https://api.github.com/repos/Emasher/EmashersMods/statuses/909d1b3037e35d55ba084b1a09d3089c5a7cac6c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":49,"deletions":86,"changed_files":1}}