{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/2306","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2306/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2306/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2306/events","html_url":"https://github.com/mne-tools/mne-python/pull/2306","id":95475682,"number":2306,"title":"Add support for cross-frequency coupling and circular stats","user":{"login":"choldgraf","id":1839645,"avatar_url":"https://avatars.githubusercontent.com/u/1839645?v=3","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/7","html_url":"https://github.com/mne-tools/mne-python/milestones/0.11","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/7/labels","id":1288558,"number":7,"title":"0.11","description":null,"creator":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":2,"state":"open","created_at":"2015-09-03T15:20:08Z","updated_at":"2015-09-16T14:29:45Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2015-07-16T16:41:10Z","updated_at":"2015-10-01T21:39:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2306","html_url":"https://github.com/mne-tools/mne-python/pull/2306","diff_url":"https://github.com/mne-tools/mne-python/pull/2306.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2306.patch"},"body":"This is a clone of #1388, also discussed in #182 \r\n\r\nNext up is to decide whether to keep the basic functionality the same, or to include ability to compute CFC between multiple signals (so it would behave similarly to the `spectral_connectivity` function)"},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/144857513","html_url":"https://github.com/mne-tools/mne-python/pull/2306#issuecomment-144857513","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2306","id":144857513,"user":{"login":"choldgraf","id":1839645,"avatar_url":"https://avatars.githubusercontent.com/u/1839645?v=3","gravatar_id":"","url":"https://api.github.com/users/choldgraf","html_url":"https://github.com/choldgraf","followers_url":"https://api.github.com/users/choldgraf/followers","following_url":"https://api.github.com/users/choldgraf/following{/other_user}","gists_url":"https://api.github.com/users/choldgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/choldgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choldgraf/subscriptions","organizations_url":"https://api.github.com/users/choldgraf/orgs","repos_url":"https://api.github.com/users/choldgraf/repos","events_url":"https://api.github.com/users/choldgraf/events{/privacy}","received_events_url":"https://api.github.com/users/choldgraf/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T21:39:06Z","updated_at":"2015-10-01T21:39:06Z","body":"@dengemann which link are you speaking of? The one from the Voytek lab?\r\n\r\nRegarding this code - the original author included two implementations that are the most \"canonical\" or at least the original ones. I think it's fine to just focus on these as well, and I also agree that an API kind of approach would be useful in case people want to extend this in the future. I am reminded of the recent cleaning up of the `time_frequency` module, where there were lots of functions that did close to the same thing but had different names and counter-intuitively different behavior. I'd like whatever the CFC component becomes to be as streamlined, clear, and extensible as we can make it."}}