{"action":"created","issue":{"url":"https://api.github.com/repos/OpenRC/openrc/issues/39","labels_url":"https://api.github.com/repos/OpenRC/openrc/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/OpenRC/openrc/issues/39/comments","events_url":"https://api.github.com/repos/OpenRC/openrc/issues/39/events","html_url":"https://github.com/OpenRC/openrc/issues/39","id":59393889,"number":39,"title":"Clean up rc-cgroup.sh for clarity","user":{"login":"tokiclover","id":905988,"avatar_url":"https://avatars.githubusercontent.com/u/905988?v=3","gravatar_id":"","url":"https://api.github.com/users/tokiclover","html_url":"https://github.com/tokiclover","followers_url":"https://api.github.com/users/tokiclover/followers","following_url":"https://api.github.com/users/tokiclover/following{/other_user}","gists_url":"https://api.github.com/users/tokiclover/gists{/gist_id}","starred_url":"https://api.github.com/users/tokiclover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokiclover/subscriptions","organizations_url":"https://api.github.com/users/tokiclover/orgs","repos_url":"https://api.github.com/users/tokiclover/repos","events_url":"https://api.github.com/users/tokiclover/events{/privacy}","received_events_url":"https://api.github.com/users/tokiclover/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-03-01T12:19:10Z","updated_at":"2015-03-20T09:07:14Z","closed_at":"2015-03-19T23:49:16Z","body":"Please, consider this patch in an attempt to clean up rc-cgroup.sh. I've just took a look the other day because I needed to make quick similar file for [Supervision-Scripts][1] and had a hard time going trough it because of poor coding style (somewhat confused at times) and bad variable naming scheme.\r\n\r\nI suggest as well:\r\n    * Renaming cgroup_cleanup() to cgroup_del_service() or cgroup_remove_service() to get more consistency on helpers naming (in par with cgroup_add_service()). This is not done in the current iteration because it would require patching runscripts.sh.\r\n    * Use an environment variable--(e.g.) RC_CGROUP_NAME--for the use of 'openrc' group (name.)\r\n\r\nThanks.\r\n\r\n(I am opening a bug request because I don't want to clone OpenRC and submit pull requests. Too much has to be done for that end. Moreover, upstream *can* or *could* completely ignore it--too much work and troubles for nothing. No thanks, Sir!)\r\n\r\nNOTE: This is a copy of [bug][2] request.\r\n\r\n[1]: https://github.com/tokiclover/supervision-scripts\r\n[2]: https://bugs.gentoo.org/show_bug.cgi?id=541792"},"comment":{"url":"https://api.github.com/repos/OpenRC/openrc/issues/comments/83960128","html_url":"https://github.com/OpenRC/openrc/issues/39#issuecomment-83960128","issue_url":"https://api.github.com/repos/OpenRC/openrc/issues/39","id":83960128,"user":{"login":"tokiclover","id":905988,"avatar_url":"https://avatars.githubusercontent.com/u/905988?v=3","gravatar_id":"","url":"https://api.github.com/users/tokiclover","html_url":"https://github.com/tokiclover","followers_url":"https://api.github.com/users/tokiclover/followers","following_url":"https://api.github.com/users/tokiclover/following{/other_user}","gists_url":"https://api.github.com/users/tokiclover/gists{/gist_id}","starred_url":"https://api.github.com/users/tokiclover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tokiclover/subscriptions","organizations_url":"https://api.github.com/users/tokiclover/orgs","repos_url":"https://api.github.com/users/tokiclover/repos","events_url":"https://api.github.com/users/tokiclover/events{/privacy}","received_events_url":"https://api.github.com/users/tokiclover/received_events","type":"User","site_admin":false},"created_at":"2015-03-20T09:07:14Z","updated_at":"2015-03-20T09:07:14Z","body":"2015-03-20 0:49 GMT+01:00 Doug Freed <notifications@github.com>:\n\n> Closed #39 <https://github.com/OpenRC/openrc/issues/39>.\n>\nYes Lieutenant Chief, Sir! With such good *will*, the details do not matter\nthe least; you *could*, mind you, have, at least, found a \"fun[ny]\" thing\nto say instead of... repeating yourself,--or the Chief mantra,--*ad\ninfinitum.*\n"}}