{"action":"created","issue":{"url":"https://api.github.com/repos/Debian/apt/issues/4","labels_url":"https://api.github.com/repos/Debian/apt/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/Debian/apt/issues/4/comments","events_url":"https://api.github.com/repos/Debian/apt/issues/4/events","html_url":"https://github.com/Debian/apt/pull/4","id":104138131,"number":4,"title":"Search packages with order-by feature","user":{"login":"Ziul","id":880492,"avatar_url":"https://avatars.githubusercontent.com/u/880492?v=3","gravatar_id":"","url":"https://api.github.com/users/Ziul","html_url":"https://github.com/Ziul","followers_url":"https://api.github.com/users/Ziul/followers","following_url":"https://api.github.com/users/Ziul/following{/other_user}","gists_url":"https://api.github.com/users/Ziul/gists{/gist_id}","starred_url":"https://api.github.com/users/Ziul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ziul/subscriptions","organizations_url":"https://api.github.com/users/Ziul/orgs","repos_url":"https://api.github.com/users/Ziul/repos","events_url":"https://api.github.com/users/Ziul/events{/privacy}","received_events_url":"https://api.github.com/users/Ziul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-31T21:25:37Z","updated_at":"2015-09-07T16:16:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Debian/apt/pulls/4","html_url":"https://github.com/Debian/apt/pull/4","diff_url":"https://github.com/Debian/apt/pull/4.diff","patch_url":"https://github.com/Debian/apt/pull/4.patch"},"body":"\r\n#### Included support to search packages into CLI ordered by:\r\n\r\n-   Alphabetic [default]\r\n-   Reverse Alphabetic\r\n-   Status\r\n-   Version\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Debian/apt/issues/comments/138334435","html_url":"https://github.com/Debian/apt/pull/4#issuecomment-138334435","issue_url":"https://api.github.com/repos/Debian/apt/issues/4","id":138334435,"user":{"login":"Ziul","id":880492,"avatar_url":"https://avatars.githubusercontent.com/u/880492?v=3","gravatar_id":"","url":"https://api.github.com/users/Ziul","html_url":"https://github.com/Ziul","followers_url":"https://api.github.com/users/Ziul/followers","following_url":"https://api.github.com/users/Ziul/following{/other_user}","gists_url":"https://api.github.com/users/Ziul/gists{/gist_id}","starred_url":"https://api.github.com/users/Ziul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ziul/subscriptions","organizations_url":"https://api.github.com/users/Ziul/orgs","repos_url":"https://api.github.com/users/Ziul/repos","events_url":"https://api.github.com/users/Ziul/events{/privacy}","received_events_url":"https://api.github.com/users/Ziul/received_events","type":"User","site_admin":false},"created_at":"2015-09-07T16:16:22Z","updated_at":"2015-09-07T16:16:22Z","body":"Hi!\r\n> I am not sure how you \"trying to keep it updated\", but it looks like you are rebasing debian/experimental on your pull-request instead of the other way around, because the hashes from my/mvos commits don't match with /experimental anymore, so merging your commits means remerging ours (which fails).\r\n\r\nStrange... Some commits ago the github show a conflict from my pr with /experimental. So i just `pull --rebase` /experimental with my branch and was fast-forwarded. Than so github pass it with ok as it's now. But nothing that a cherry-pick couldn't solve.\r\n\r\n> Why are you using a magic constant here?\r\n\r\nMy bad! Soon after mvo5 give hist feedback i should fix it.\r\n\r\n> Some of your new lines have trailing whitespaces.\r\n\r\nDamn! still thos ones? Review than i will!\r\n\r\n> Apropos documentation:\r\n\r\nMy bad[2]! I'll update it. Should be in this [file](https://github.com/Debian/apt/blob/debian/experimental/doc/apt.8.xml) right? Planing to let it simmillar with the `list` option.\r\n\r\n> apt-private/private-package-info.cc has a gazillion includes: Are these really all needed?\r\n\r\nProbably not. I'll try to clean it after the feedback.\r\n\r\n> prefer \"outputVector.emplace_back(CacheFile, records, V, outs.str());\"\r\n\r\nNice tip! Didn't know that one.\r\n\r\n> I am relatively sure you can achieve the same with std::sort(outputVector.rbegin(), outputVector.rend(), OrderByAlphabetic); saving us from implementing the same order twice\r\n\r\nUnfortly, the default order from cache means sort into the `source.list` and than into alphabetic, which means isn't the alphabetic at all. As in the beginner was using `maps`, it was transparent.\r\n\r\n> \"hashit\" is an awful name for a function, even in our private set. Some sensible name would be better – and maybe move it into PackageInfo as a static method. I think the OrderBy functions would be better as static methods as well.\r\n\r\nNote taked! Wasnt so inpiraded to name that `hashit`.\r\n\r\n> The format member of PackageInfo is never used apart from its getter/setter\r\n\r\nThe ideia was use `_format` to overwrite the `<<` operator. Probably in the soons pr i should use it more. I hope in the end could offer something like `axi-cache` does when you look for \"gyt\" instead \"git\"\r\n\r\n"}}