{"action":"opened","number":491,"pull_request":{"url":"https://api.github.com/repos/NixOS/nix/pulls/491","id":30500035,"html_url":"https://github.com/NixOS/nix/pull/491","diff_url":"https://github.com/NixOS/nix/pull/491.diff","patch_url":"https://github.com/NixOS/nix/pull/491.patch","issue_url":"https://api.github.com/repos/NixOS/nix/issues/491","number":491,"state":"open","locked":false,"title":"Verify TLS certificate before downloading binaries","user":{"login":"philandstuff","id":581269,"avatar_url":"https://avatars.githubusercontent.com/u/581269?v=3","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"body":"The --insecure flag to curl tells curl not to bother checking if the TLS\r\ncertificate presented by the server actually matches the hostname\r\nrequested, and actually is issued by a trusted CA chain.  This almost\r\nentirely negates any benefit from using TLS in the first place.\r\n\r\nThis removes the --insecure flag to ensure we actually have a secure\r\nconnection to the intended hostname before downloading binaries.\r\n\r\nManually tested locally within a dev-shell; was able to download\r\nbinaries from https://cache.nixos.org without issue.","created_at":"2015-03-04T20:13:51Z","updated_at":"2015-03-04T20:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nix/pulls/491/commits","review_comments_url":"https://api.github.com/repos/NixOS/nix/pulls/491/comments","review_comment_url":"https://api.github.com/repos/NixOS/nix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nix/issues/491/comments","statuses_url":"https://api.github.com/repos/NixOS/nix/statuses/efa18a30d33b73a25ae3fc8702c1c76ef7a8b57b","head":{"label":"philandstuff:securely-download-binaries","ref":"securely-download-binaries","sha":"efa18a30d33b73a25ae3fc8702c1c76ef7a8b57b","user":{"login":"philandstuff","id":581269,"avatar_url":"https://avatars.githubusercontent.com/u/581269?v=3","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"repo":{"id":31677447,"name":"nix","full_name":"philandstuff/nix","owner":{"login":"philandstuff","id":581269,"avatar_url":"https://avatars.githubusercontent.com/u/581269?v=3","gravatar_id":"","url":"https://api.github.com/users/philandstuff","html_url":"https://github.com/philandstuff","followers_url":"https://api.github.com/users/philandstuff/followers","following_url":"https://api.github.com/users/philandstuff/following{/other_user}","gists_url":"https://api.github.com/users/philandstuff/gists{/gist_id}","starred_url":"https://api.github.com/users/philandstuff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philandstuff/subscriptions","organizations_url":"https://api.github.com/users/philandstuff/orgs","repos_url":"https://api.github.com/users/philandstuff/repos","events_url":"https://api.github.com/users/philandstuff/events{/privacy}","received_events_url":"https://api.github.com/users/philandstuff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/philandstuff/nix","description":"Nix, the purely functional package manager","fork":true,"url":"https://api.github.com/repos/philandstuff/nix","forks_url":"https://api.github.com/repos/philandstuff/nix/forks","keys_url":"https://api.github.com/repos/philandstuff/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/philandstuff/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/philandstuff/nix/teams","hooks_url":"https://api.github.com/repos/philandstuff/nix/hooks","issue_events_url":"https://api.github.com/repos/philandstuff/nix/issues/events{/number}","events_url":"https://api.github.com/repos/philandstuff/nix/events","assignees_url":"https://api.github.com/repos/philandstuff/nix/assignees{/user}","branches_url":"https://api.github.com/repos/philandstuff/nix/branches{/branch}","tags_url":"https://api.github.com/repos/philandstuff/nix/tags","blobs_url":"https://api.github.com/repos/philandstuff/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/philandstuff/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/philandstuff/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/philandstuff/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/philandstuff/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/philandstuff/nix/languages","stargazers_url":"https://api.github.com/repos/philandstuff/nix/stargazers","contributors_url":"https://api.github.com/repos/philandstuff/nix/contributors","subscribers_url":"https://api.github.com/repos/philandstuff/nix/subscribers","subscription_url":"https://api.github.com/repos/philandstuff/nix/subscription","commits_url":"https://api.github.com/repos/philandstuff/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/philandstuff/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/philandstuff/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/philandstuff/nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/philandstuff/nix/contents/{+path}","compare_url":"https://api.github.com/repos/philandstuff/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/philandstuff/nix/merges","archive_url":"https://api.github.com/repos/philandstuff/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/philandstuff/nix/downloads","issues_url":"https://api.github.com/repos/philandstuff/nix/issues{/number}","pulls_url":"https://api.github.com/repos/philandstuff/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/philandstuff/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/philandstuff/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/philandstuff/nix/labels{/name}","releases_url":"https://api.github.com/repos/philandstuff/nix/releases{/id}","created_at":"2015-03-04T20:08:10Z","updated_at":"2015-03-04T20:08:11Z","pushed_at":"2015-03-04T20:13:27Z","git_url":"git://github.com/philandstuff/nix.git","ssh_url":"git@github.com:philandstuff/nix.git","clone_url":"https://github.com/philandstuff/nix.git","svn_url":"https://github.com/philandstuff/nix","homepage":"http://nixos.org/nix/","size":21740,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"9f3eb56b460ad14647b90f9fc841776daf9beb47","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":3386088,"name":"nix","full_name":"NixOS/nix","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nix","description":"Nix, the purely functional package manager","fork":false,"url":"https://api.github.com/repos/NixOS/nix","forks_url":"https://api.github.com/repos/NixOS/nix/forks","keys_url":"https://api.github.com/repos/NixOS/nix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nix/teams","hooks_url":"https://api.github.com/repos/NixOS/nix/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nix/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nix/events","assignees_url":"https://api.github.com/repos/NixOS/nix/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nix/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nix/tags","blobs_url":"https://api.github.com/repos/NixOS/nix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nix/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nix/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nix/languages","stargazers_url":"https://api.github.com/repos/NixOS/nix/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nix/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nix/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nix/subscription","commits_url":"https://api.github.com/repos/NixOS/nix/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nix/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nix/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nix/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nix/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nix/merges","archive_url":"https://api.github.com/repos/NixOS/nix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nix/downloads","issues_url":"https://api.github.com/repos/NixOS/nix/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nix/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nix/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nix/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nix/releases{/id}","created_at":"2012-02-08T10:17:59Z","updated_at":"2015-03-04T15:28:00Z","pushed_at":"2015-03-04T15:27:59Z","git_url":"git://github.com/NixOS/nix.git","ssh_url":"git@github.com:NixOS/nix.git","clone_url":"https://github.com/NixOS/nix.git","svn_url":"https://github.com/NixOS/nix","homepage":"http://nixos.org/nix/","size":21740,"stargazers_count":428,"watchers_count":428,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":167,"forks":103,"open_issues":167,"watchers":428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nix/pulls/491"},"html":{"href":"https://github.com/NixOS/nix/pull/491"},"issue":{"href":"https://api.github.com/repos/NixOS/nix/issues/491"},"comments":{"href":"https://api.github.com/repos/NixOS/nix/issues/491/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nix/pulls/491/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nix/pulls/491/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nix/statuses/efa18a30d33b73a25ae3fc8702c1c76ef7a8b57b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}