{"action":"opened","number":18,"pull_request":{"url":"https://api.github.com/repos/meteor/postgres-packages/pulls/18","id":44816898,"html_url":"https://github.com/meteor/postgres-packages/pull/18","diff_url":"https://github.com/meteor/postgres-packages/pull/18.diff","patch_url":"https://github.com/meteor/postgres-packages/pull/18.patch","issue_url":"https://api.github.com/repos/meteor/postgres-packages/issues/18","number":18,"state":"open","locked":false,"title":"support package to work across different databases, fix deleteAllResumeTokens, added few more methods","user":{"login":"mariobriggs","id":3006502,"avatar_url":"https://avatars.githubusercontent.com/u/3006502?v=3","gravatar_id":"","url":"https://api.github.com/users/mariobriggs","html_url":"https://github.com/mariobriggs","followers_url":"https://api.github.com/users/mariobriggs/followers","following_url":"https://api.github.com/users/mariobriggs/following{/other_user}","gists_url":"https://api.github.com/users/mariobriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/mariobriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariobriggs/subscriptions","organizations_url":"https://api.github.com/users/mariobriggs/orgs","repos_url":"https://api.github.com/users/mariobriggs/repos","events_url":"https://api.github.com/users/mariobriggs/events{/privacy}","received_events_url":"https://api.github.com/users/mariobriggs/received_events","type":"User","site_admin":false},"body":"hi Guys,\r\nfirst off thanks for this effort to use other backends for meteor-accounts.\r\n\r\n1 - I have attempted to see if with some small changes, can make this pluggable to work with any supported backend db. I defined a variable (Meteor.AccountsDBClient)in accounts-base-pg-driver that is set to the interface class and then accounts-base uses that variable to instantiate the required class.\r\n\r\n This currently requires that 'accounts-password-pg-driver' is defined before accounts-password in the app's packages (i tried to overcome this by having accounts-base-pg-driver 'use' accounts-base, but that causes circular dependencies)\r\n\r\np.s not claiming this is best or final, but wanted to make a start on your super effort and extend it to [couchdb](https://github.com/mariobriggs/meteor-accounts-couchdb), since we had a few requests for this. So thanks to you.\r\n\r\n2 - added methods in the 'AccountsDBClientPG' for moving out the 'observes' on users & users-services (setupObserves, stopObserves).\r\n Also add a few more methods (removeOtherHashedLoginTokens, expireResumeTokens, updatePassword) in the interface and ensured it is invoked via that from password-server.js and accounts-server.js\r\n\r\n3- small fix to deleteAllResumeTokens and added the userId parameter, so can be used even when required to delete for a particular user","created_at":"2015-09-11T18:57:41Z","updated_at":"2015-09-11T18:57:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/meteor/postgres-packages/pulls/18/commits","review_comments_url":"https://api.github.com/repos/meteor/postgres-packages/pulls/18/comments","review_comment_url":"https://api.github.com/repos/meteor/postgres-packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/meteor/postgres-packages/issues/18/comments","statuses_url":"https://api.github.com/repos/meteor/postgres-packages/statuses/e3b14204741a852d63f572607a571e6e72f1e738","head":{"label":"mariobriggs:master","ref":"master","sha":"e3b14204741a852d63f572607a571e6e72f1e738","user":{"login":"mariobriggs","id":3006502,"avatar_url":"https://avatars.githubusercontent.com/u/3006502?v=3","gravatar_id":"","url":"https://api.github.com/users/mariobriggs","html_url":"https://github.com/mariobriggs","followers_url":"https://api.github.com/users/mariobriggs/followers","following_url":"https://api.github.com/users/mariobriggs/following{/other_user}","gists_url":"https://api.github.com/users/mariobriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/mariobriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariobriggs/subscriptions","organizations_url":"https://api.github.com/users/mariobriggs/orgs","repos_url":"https://api.github.com/users/mariobriggs/repos","events_url":"https://api.github.com/users/mariobriggs/events{/privacy}","received_events_url":"https://api.github.com/users/mariobriggs/received_events","type":"User","site_admin":false},"repo":{"id":42301005,"name":"postgres-packages","full_name":"mariobriggs/postgres-packages","owner":{"login":"mariobriggs","id":3006502,"avatar_url":"https://avatars.githubusercontent.com/u/3006502?v=3","gravatar_id":"","url":"https://api.github.com/users/mariobriggs","html_url":"https://github.com/mariobriggs","followers_url":"https://api.github.com/users/mariobriggs/followers","following_url":"https://api.github.com/users/mariobriggs/following{/other_user}","gists_url":"https://api.github.com/users/mariobriggs/gists{/gist_id}","starred_url":"https://api.github.com/users/mariobriggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariobriggs/subscriptions","organizations_url":"https://api.github.com/users/mariobriggs/orgs","repos_url":"https://api.github.com/users/mariobriggs/repos","events_url":"https://api.github.com/users/mariobriggs/events{/privacy}","received_events_url":"https://api.github.com/users/mariobriggs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mariobriggs/postgres-packages","description":"Early preview of PostgreSQL support for Meteor","fork":true,"url":"https://api.github.com/repos/mariobriggs/postgres-packages","forks_url":"https://api.github.com/repos/mariobriggs/postgres-packages/forks","keys_url":"https://api.github.com/repos/mariobriggs/postgres-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mariobriggs/postgres-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mariobriggs/postgres-packages/teams","hooks_url":"https://api.github.com/repos/mariobriggs/postgres-packages/hooks","issue_events_url":"https://api.github.com/repos/mariobriggs/postgres-packages/issues/events{/number}","events_url":"https://api.github.com/repos/mariobriggs/postgres-packages/events","assignees_url":"https://api.github.com/repos/mariobriggs/postgres-packages/assignees{/user}","branches_url":"https://api.github.com/repos/mariobriggs/postgres-packages/branches{/branch}","tags_url":"https://api.github.com/repos/mariobriggs/postgres-packages/tags","blobs_url":"https://api.github.com/repos/mariobriggs/postgres-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mariobriggs/postgres-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mariobriggs/postgres-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/mariobriggs/postgres-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mariobriggs/postgres-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/mariobriggs/postgres-packages/languages","stargazers_url":"https://api.github.com/repos/mariobriggs/postgres-packages/stargazers","contributors_url":"https://api.github.com/repos/mariobriggs/postgres-packages/contributors","subscribers_url":"https://api.github.com/repos/mariobriggs/postgres-packages/subscribers","subscription_url":"https://api.github.com/repos/mariobriggs/postgres-packages/subscription","commits_url":"https://api.github.com/repos/mariobriggs/postgres-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/mariobriggs/postgres-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/mariobriggs/postgres-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/mariobriggs/postgres-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/mariobriggs/postgres-packages/contents/{+path}","compare_url":"https://api.github.com/repos/mariobriggs/postgres-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mariobriggs/postgres-packages/merges","archive_url":"https://api.github.com/repos/mariobriggs/postgres-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mariobriggs/postgres-packages/downloads","issues_url":"https://api.github.com/repos/mariobriggs/postgres-packages/issues{/number}","pulls_url":"https://api.github.com/repos/mariobriggs/postgres-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/mariobriggs/postgres-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/mariobriggs/postgres-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mariobriggs/postgres-packages/labels{/name}","releases_url":"https://api.github.com/repos/mariobriggs/postgres-packages/releases{/id}","created_at":"2015-09-11T09:53:29Z","updated_at":"2015-09-11T09:53:31Z","pushed_at":"2015-09-11T12:30:52Z","git_url":"git://github.com/mariobriggs/postgres-packages.git","ssh_url":"git@github.com:mariobriggs/postgres-packages.git","clone_url":"https://github.com/mariobriggs/postgres-packages.git","svn_url":"https://github.com/mariobriggs/postgres-packages","homepage":"http://meteor-postgres.readthedocs.org/","size":1401,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"meteor:master","ref":"master","sha":"a7f3b743a6dff0c95d4c4eef5aa1c359dc8f55a0","user":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"repo":{"id":40576101,"name":"postgres-packages","full_name":"meteor/postgres-packages","owner":{"login":"meteor","id":789528,"avatar_url":"https://avatars.githubusercontent.com/u/789528?v=3","gravatar_id":"","url":"https://api.github.com/users/meteor","html_url":"https://github.com/meteor","followers_url":"https://api.github.com/users/meteor/followers","following_url":"https://api.github.com/users/meteor/following{/other_user}","gists_url":"https://api.github.com/users/meteor/gists{/gist_id}","starred_url":"https://api.github.com/users/meteor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meteor/subscriptions","organizations_url":"https://api.github.com/users/meteor/orgs","repos_url":"https://api.github.com/users/meteor/repos","events_url":"https://api.github.com/users/meteor/events{/privacy}","received_events_url":"https://api.github.com/users/meteor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/meteor/postgres-packages","description":"Early preview of PostgreSQL support for Meteor","fork":false,"url":"https://api.github.com/repos/meteor/postgres-packages","forks_url":"https://api.github.com/repos/meteor/postgres-packages/forks","keys_url":"https://api.github.com/repos/meteor/postgres-packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meteor/postgres-packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meteor/postgres-packages/teams","hooks_url":"https://api.github.com/repos/meteor/postgres-packages/hooks","issue_events_url":"https://api.github.com/repos/meteor/postgres-packages/issues/events{/number}","events_url":"https://api.github.com/repos/meteor/postgres-packages/events","assignees_url":"https://api.github.com/repos/meteor/postgres-packages/assignees{/user}","branches_url":"https://api.github.com/repos/meteor/postgres-packages/branches{/branch}","tags_url":"https://api.github.com/repos/meteor/postgres-packages/tags","blobs_url":"https://api.github.com/repos/meteor/postgres-packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meteor/postgres-packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meteor/postgres-packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/meteor/postgres-packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meteor/postgres-packages/statuses/{sha}","languages_url":"https://api.github.com/repos/meteor/postgres-packages/languages","stargazers_url":"https://api.github.com/repos/meteor/postgres-packages/stargazers","contributors_url":"https://api.github.com/repos/meteor/postgres-packages/contributors","subscribers_url":"https://api.github.com/repos/meteor/postgres-packages/subscribers","subscription_url":"https://api.github.com/repos/meteor/postgres-packages/subscription","commits_url":"https://api.github.com/repos/meteor/postgres-packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/meteor/postgres-packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/meteor/postgres-packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/meteor/postgres-packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/meteor/postgres-packages/contents/{+path}","compare_url":"https://api.github.com/repos/meteor/postgres-packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meteor/postgres-packages/merges","archive_url":"https://api.github.com/repos/meteor/postgres-packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meteor/postgres-packages/downloads","issues_url":"https://api.github.com/repos/meteor/postgres-packages/issues{/number}","pulls_url":"https://api.github.com/repos/meteor/postgres-packages/pulls{/number}","milestones_url":"https://api.github.com/repos/meteor/postgres-packages/milestones{/number}","notifications_url":"https://api.github.com/repos/meteor/postgres-packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meteor/postgres-packages/labels{/name}","releases_url":"https://api.github.com/repos/meteor/postgres-packages/releases{/id}","created_at":"2015-08-12T02:32:57Z","updated_at":"2015-09-11T00:57:33Z","pushed_at":"2015-09-10T18:18:48Z","git_url":"git://github.com/meteor/postgres-packages.git","ssh_url":"git@github.com:meteor/postgres-packages.git","clone_url":"https://github.com/meteor/postgres-packages.git","svn_url":"https://github.com/meteor/postgres-packages","homepage":"http://meteor-postgres.readthedocs.org/","size":1401,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":8,"forks":5,"open_issues":8,"watchers":79,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/meteor/postgres-packages/pulls/18"},"html":{"href":"https://github.com/meteor/postgres-packages/pull/18"},"issue":{"href":"https://api.github.com/repos/meteor/postgres-packages/issues/18"},"comments":{"href":"https://api.github.com/repos/meteor/postgres-packages/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/meteor/postgres-packages/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/meteor/postgres-packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/meteor/postgres-packages/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/meteor/postgres-packages/statuses/e3b14204741a852d63f572607a571e6e72f1e738"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":142,"deletions":111,"changed_files":6}}