{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/27572790","id":27572790,"diff_hunk":"@@ -158,6 +158,15 @@ public function buildForm(FormBuilderInterface $builder, array $options)\n      */\n     public function buildView(FormView $view, FormInterface $form, array $options)\n     {\n+        $choiceTranslationDomain = $options['choice_translation_domain'];\n+        $translationDomain = $options['translation_domain'];\n+\n+        if ($view->parent) {\n+            if (null === $choiceTranslationDomain) {\n+                $choiceTranslationDomain = $view->parent->vars['translation_domain'];","path":"src/Symfony/Component/Form/Extension/Core/Type/ChoiceType.php","position":9,"original_position":9,"commit_id":"fcf30a6fda3d18a74de0b447defd436d87722277","original_commit_id":"fcf30a6fda3d18a74de0b447defd436d87722277","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"No, it is not done if the user is passing ``null`` in the option","created_at":"2015-04-01T14:21:04Z","updated_at":"2015-04-01T14:21:04Z","html_url":"https://github.com/symfony/symfony/pull/13651#discussion_r27572790","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/13651","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/27572790"},"html":{"href":"https://github.com/symfony/symfony/pull/13651#discussion_r27572790"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13651"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/13651","id":29044129,"html_url":"https://github.com/symfony/symfony/pull/13651","diff_url":"https://github.com/symfony/symfony/pull/13651.diff","patch_url":"https://github.com/symfony/symfony/pull/13651.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/13651","number":13651,"state":"open","locked":false,"title":"[2.7][Form][choice] added choice_translation_domain to avoid trans options.","user":{"login":"aitboudad","id":1753742,"avatar_url":"https://avatars.githubusercontent.com/u/1753742?v=3","gravatar_id":"","url":"https://api.github.com/users/aitboudad","html_url":"https://github.com/aitboudad","followers_url":"https://api.github.com/users/aitboudad/followers","following_url":"https://api.github.com/users/aitboudad/following{/other_user}","gists_url":"https://api.github.com/users/aitboudad/gists{/gist_id}","starred_url":"https://api.github.com/users/aitboudad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aitboudad/subscriptions","organizations_url":"https://api.github.com/users/aitboudad/orgs","repos_url":"https://api.github.com/users/aitboudad/repos","events_url":"https://api.github.com/users/aitboudad/events{/privacy}","received_events_url":"https://api.github.com/users/aitboudad/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no\r\n| Deprecations? | no\r\n| Fixed tickets  | ~\r\n| Tests pass?   | yes\r\n| License       | MIT\r\n\r\nsee https://github.com/symfony/symfony/issues/12941#issuecomment-72904531","created_at":"2015-02-10T20:59:36Z","updated_at":"2015-04-01T14:21:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed5c7d7bc96ee01298a7fcd8582b073284aa336f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/13651/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/13651/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/13651/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/fcf30a6fda3d18a74de0b447defd436d87722277","head":{"label":"aitboudad:form_entity_trans","ref":"form_entity_trans","sha":"fcf30a6fda3d18a74de0b447defd436d87722277","user":{"login":"aitboudad","id":1753742,"avatar_url":"https://avatars.githubusercontent.com/u/1753742?v=3","gravatar_id":"","url":"https://api.github.com/users/aitboudad","html_url":"https://github.com/aitboudad","followers_url":"https://api.github.com/users/aitboudad/followers","following_url":"https://api.github.com/users/aitboudad/following{/other_user}","gists_url":"https://api.github.com/users/aitboudad/gists{/gist_id}","starred_url":"https://api.github.com/users/aitboudad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aitboudad/subscriptions","organizations_url":"https://api.github.com/users/aitboudad/orgs","repos_url":"https://api.github.com/users/aitboudad/repos","events_url":"https://api.github.com/users/aitboudad/events{/privacy}","received_events_url":"https://api.github.com/users/aitboudad/received_events","type":"User","site_admin":false},"repo":{"id":14936215,"name":"symfony","full_name":"aitboudad/symfony","owner":{"login":"aitboudad","id":1753742,"avatar_url":"https://avatars.githubusercontent.com/u/1753742?v=3","gravatar_id":"","url":"https://api.github.com/users/aitboudad","html_url":"https://github.com/aitboudad","followers_url":"https://api.github.com/users/aitboudad/followers","following_url":"https://api.github.com/users/aitboudad/following{/other_user}","gists_url":"https://api.github.com/users/aitboudad/gists{/gist_id}","starred_url":"https://api.github.com/users/aitboudad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aitboudad/subscriptions","organizations_url":"https://api.github.com/users/aitboudad/orgs","repos_url":"https://api.github.com/users/aitboudad/repos","events_url":"https://api.github.com/users/aitboudad/events{/privacy}","received_events_url":"https://api.github.com/users/aitboudad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aitboudad/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/aitboudad/symfony","forks_url":"https://api.github.com/repos/aitboudad/symfony/forks","keys_url":"https://api.github.com/repos/aitboudad/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aitboudad/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aitboudad/symfony/teams","hooks_url":"https://api.github.com/repos/aitboudad/symfony/hooks","issue_events_url":"https://api.github.com/repos/aitboudad/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/aitboudad/symfony/events","assignees_url":"https://api.github.com/repos/aitboudad/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/aitboudad/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/aitboudad/symfony/tags","blobs_url":"https://api.github.com/repos/aitboudad/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aitboudad/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aitboudad/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/aitboudad/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aitboudad/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/aitboudad/symfony/languages","stargazers_url":"https://api.github.com/repos/aitboudad/symfony/stargazers","contributors_url":"https://api.github.com/repos/aitboudad/symfony/contributors","subscribers_url":"https://api.github.com/repos/aitboudad/symfony/subscribers","subscription_url":"https://api.github.com/repos/aitboudad/symfony/subscription","commits_url":"https://api.github.com/repos/aitboudad/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/aitboudad/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/aitboudad/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/aitboudad/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/aitboudad/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/aitboudad/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aitboudad/symfony/merges","archive_url":"https://api.github.com/repos/aitboudad/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aitboudad/symfony/downloads","issues_url":"https://api.github.com/repos/aitboudad/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/aitboudad/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/aitboudad/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/aitboudad/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aitboudad/symfony/labels{/name}","releases_url":"https://api.github.com/repos/aitboudad/symfony/releases{/id}","created_at":"2013-12-04T21:22:37Z","updated_at":"2015-03-16T09:52:00Z","pushed_at":"2015-04-01T14:09:58Z","git_url":"git://github.com/aitboudad/symfony.git","ssh_url":"git@github.com:aitboudad/symfony.git","clone_url":"https://github.com/aitboudad/symfony.git","svn_url":"https://github.com/aitboudad/symfony","homepage":"symfony.com","size":54576,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"5188cfecc58c78bda18cd7081ea86ea69f0d596c","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-04-01T13:58:33Z","pushed_at":"2015-04-01T14:20:14Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":213910,"stargazers_count":9935,"watchers_count":9935,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3888,"mirror_url":null,"open_issues_count":805,"forks":3888,"open_issues":805,"watchers":9935,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13651"},"html":{"href":"https://github.com/symfony/symfony/pull/13651"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/13651"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/13651/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13651/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/13651/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/fcf30a6fda3d18a74de0b447defd436d87722277"}}}}