{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1546","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1546/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1546/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1546/events","html_url":"https://github.com/MarlinFirmware/Marlin/pull/1546","id":59389933,"number":1546,"title":"Added support for Felix 2.0/3.0 printers","user":{"login":"chron0","id":3270028,"avatar_url":"https://avatars.githubusercontent.com/u/3270028?v=3","gravatar_id":"","url":"https://api.github.com/users/chron0","html_url":"https://github.com/chron0","followers_url":"https://api.github.com/users/chron0/followers","following_url":"https://api.github.com/users/chron0/following{/other_user}","gists_url":"https://api.github.com/users/chron0/gists{/gist_id}","starred_url":"https://api.github.com/users/chron0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chron0/subscriptions","organizations_url":"https://api.github.com/users/chron0/orgs","repos_url":"https://api.github.com/users/chron0/repos","events_url":"https://api.github.com/users/chron0/events{/privacy}","received_events_url":"https://api.github.com/users/chron0/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Improvement","name":"Improvement","color":"009800"},{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Needs%20more%20work","name":"Needs more work","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-01T09:42:49Z","updated_at":"2015-03-03T07:16:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/pulls/1546","html_url":"https://github.com/MarlinFirmware/Marlin/pull/1546","diff_url":"https://github.com/MarlinFirmware/Marlin/pull/1546.diff","patch_url":"https://github.com/MarlinFirmware/Marlin/pull/1546.patch"},"body":"Basic support for Felix 2.0/3.0 printers. I haven't committed the Configuration.h since these parameters are machine specific and it didn't seem reasonable to overwrite the default Configuration.h, as most parameters in there are machine specific. I'll keep it in a separate branch for now, where a ready to go package for Felix printers can be pulled, but it'd be nice to have the board/pin assignments already in there upstream, so that we only have to take care of sharing Configuration.h for now. Are you guys thinking about abstracting the FW a little bit more, so that we could have all machine specific parameters combined in separate files and then only pick a machine type in Configuration.h? This approach would leave enough room for unique DIY builds to tinker/play and makes FW compilation and usage for users of the same type of machine much more simple and accessible. LCD has not been tested (we're using Octoprint so we don't need/have one) but compilation/upload/control and printing are working so far (tested on https://apollo.open-resource.org/mission:resources:picoprint). Thanks and greetings to all who have helped build and share Marlin."},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/76898138","html_url":"https://github.com/MarlinFirmware/Marlin/pull/1546#issuecomment-76898138","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1546","id":76898138,"user":{"login":"chron0","id":3270028,"avatar_url":"https://avatars.githubusercontent.com/u/3270028?v=3","gravatar_id":"","url":"https://api.github.com/users/chron0","html_url":"https://github.com/chron0","followers_url":"https://api.github.com/users/chron0/followers","following_url":"https://api.github.com/users/chron0/following{/other_user}","gists_url":"https://api.github.com/users/chron0/gists{/gist_id}","starred_url":"https://api.github.com/users/chron0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chron0/subscriptions","organizations_url":"https://api.github.com/users/chron0/orgs","repos_url":"https://api.github.com/users/chron0/repos","events_url":"https://api.github.com/users/chron0/events{/privacy}","received_events_url":"https://api.github.com/users/chron0/received_events","type":"User","site_admin":false},"created_at":"2015-03-03T07:16:44Z","updated_at":"2015-03-03T07:16:44Z","body":"No of course not, there must have been something weird going on, since the changed README and root Configuration.h were obvious to me NOT to change in the PR since it would make no sense for upstream Marlin, these were changed only in my other local branch (Marlix) but somehow they got over into the pr-felix branch :/ I hope that's it now..."}}