{"action":"opened","number":84,"pull_request":{"url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/84","id":34815825,"html_url":"https://github.com/atrauzzi/laravel-doctrine/pull/84","diff_url":"https://github.com/atrauzzi/laravel-doctrine/pull/84.diff","patch_url":"https://github.com/atrauzzi/laravel-doctrine/pull/84.patch","issue_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues/84","number":84,"state":"open","locked":false,"title":"Refactor entity manager creation","user":{"login":"mbbender","id":1754012,"avatar_url":"https://avatars.githubusercontent.com/u/1754012?v=3","gravatar_id":"","url":"https://api.github.com/users/mbbender","html_url":"https://github.com/mbbender","followers_url":"https://api.github.com/users/mbbender/followers","following_url":"https://api.github.com/users/mbbender/following{/other_user}","gists_url":"https://api.github.com/users/mbbender/gists{/gist_id}","starred_url":"https://api.github.com/users/mbbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbbender/subscriptions","organizations_url":"https://api.github.com/users/mbbender/orgs","repos_url":"https://api.github.com/users/mbbender/repos","events_url":"https://api.github.com/users/mbbender/events{/privacy}","received_events_url":"https://api.github.com/users/mbbender/received_events","type":"User","site_admin":false},"body":"I attempted to clean up the way the Entity Manager is registered. I didn't do to much other than create functions for the various components in the ServiceProvider but an hoping it lends itself to better testing as we go. \r\n\r\nAs a suggestion, I think it might be a good time to tag a 1.0.1 version before this merge and use this PR for a 1.1 branch so I don't break everyones code like I did with the Cache Factory...  Then we can add a 1.1.x-dev version to our composer files to be working with latest stuff without affecting anyone that has a 1.0.x version that they may actually be using. What do you think?\r\n\r\n\r\n\r\n","created_at":"2015-05-06T13:23:06Z","updated_at":"2015-05-06T13:23:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/84/commits","review_comments_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/84/comments","review_comment_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues/84/comments","statuses_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/statuses/ce22169a8eeb90be676ccd35f87d1725d9355305","head":{"label":"mbbender:refactor_entity_manager_creation","ref":"refactor_entity_manager_creation","sha":"ce22169a8eeb90be676ccd35f87d1725d9355305","user":{"login":"mbbender","id":1754012,"avatar_url":"https://avatars.githubusercontent.com/u/1754012?v=3","gravatar_id":"","url":"https://api.github.com/users/mbbender","html_url":"https://github.com/mbbender","followers_url":"https://api.github.com/users/mbbender/followers","following_url":"https://api.github.com/users/mbbender/following{/other_user}","gists_url":"https://api.github.com/users/mbbender/gists{/gist_id}","starred_url":"https://api.github.com/users/mbbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbbender/subscriptions","organizations_url":"https://api.github.com/users/mbbender/orgs","repos_url":"https://api.github.com/users/mbbender/repos","events_url":"https://api.github.com/users/mbbender/events{/privacy}","received_events_url":"https://api.github.com/users/mbbender/received_events","type":"User","site_admin":false},"repo":{"id":34690565,"name":"laravel-doctrine","full_name":"mbbender/laravel-doctrine","owner":{"login":"mbbender","id":1754012,"avatar_url":"https://avatars.githubusercontent.com/u/1754012?v=3","gravatar_id":"","url":"https://api.github.com/users/mbbender","html_url":"https://github.com/mbbender","followers_url":"https://api.github.com/users/mbbender/followers","following_url":"https://api.github.com/users/mbbender/following{/other_user}","gists_url":"https://api.github.com/users/mbbender/gists{/gist_id}","starred_url":"https://api.github.com/users/mbbender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbbender/subscriptions","organizations_url":"https://api.github.com/users/mbbender/orgs","repos_url":"https://api.github.com/users/mbbender/repos","events_url":"https://api.github.com/users/mbbender/events{/privacy}","received_events_url":"https://api.github.com/users/mbbender/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbbender/laravel-doctrine","description":"An ORM for a Framework for Web Artisans","fork":true,"url":"https://api.github.com/repos/mbbender/laravel-doctrine","forks_url":"https://api.github.com/repos/mbbender/laravel-doctrine/forks","keys_url":"https://api.github.com/repos/mbbender/laravel-doctrine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbbender/laravel-doctrine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbbender/laravel-doctrine/teams","hooks_url":"https://api.github.com/repos/mbbender/laravel-doctrine/hooks","issue_events_url":"https://api.github.com/repos/mbbender/laravel-doctrine/issues/events{/number}","events_url":"https://api.github.com/repos/mbbender/laravel-doctrine/events","assignees_url":"https://api.github.com/repos/mbbender/laravel-doctrine/assignees{/user}","branches_url":"https://api.github.com/repos/mbbender/laravel-doctrine/branches{/branch}","tags_url":"https://api.github.com/repos/mbbender/laravel-doctrine/tags","blobs_url":"https://api.github.com/repos/mbbender/laravel-doctrine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbbender/laravel-doctrine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbbender/laravel-doctrine/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbbender/laravel-doctrine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbbender/laravel-doctrine/statuses/{sha}","languages_url":"https://api.github.com/repos/mbbender/laravel-doctrine/languages","stargazers_url":"https://api.github.com/repos/mbbender/laravel-doctrine/stargazers","contributors_url":"https://api.github.com/repos/mbbender/laravel-doctrine/contributors","subscribers_url":"https://api.github.com/repos/mbbender/laravel-doctrine/subscribers","subscription_url":"https://api.github.com/repos/mbbender/laravel-doctrine/subscription","commits_url":"https://api.github.com/repos/mbbender/laravel-doctrine/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbbender/laravel-doctrine/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbbender/laravel-doctrine/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbbender/laravel-doctrine/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbbender/laravel-doctrine/contents/{+path}","compare_url":"https://api.github.com/repos/mbbender/laravel-doctrine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbbender/laravel-doctrine/merges","archive_url":"https://api.github.com/repos/mbbender/laravel-doctrine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbbender/laravel-doctrine/downloads","issues_url":"https://api.github.com/repos/mbbender/laravel-doctrine/issues{/number}","pulls_url":"https://api.github.com/repos/mbbender/laravel-doctrine/pulls{/number}","milestones_url":"https://api.github.com/repos/mbbender/laravel-doctrine/milestones{/number}","notifications_url":"https://api.github.com/repos/mbbender/laravel-doctrine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbbender/laravel-doctrine/labels{/name}","releases_url":"https://api.github.com/repos/mbbender/laravel-doctrine/releases{/id}","created_at":"2015-04-27T20:50:59Z","updated_at":"2015-05-06T02:03:31Z","pushed_at":"2015-05-06T13:16:33Z","git_url":"git://github.com/mbbender/laravel-doctrine.git","ssh_url":"git@github.com:mbbender/laravel-doctrine.git","clone_url":"https://github.com/mbbender/laravel-doctrine.git","svn_url":"https://github.com/mbbender/laravel-doctrine","homepage":null,"size":224,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atrauzzi:master","ref":"master","sha":"bfbeed0dff89dc6a9222c822274baeaff321f2cc","user":{"login":"atrauzzi","id":115199,"avatar_url":"https://avatars.githubusercontent.com/u/115199?v=3","gravatar_id":"","url":"https://api.github.com/users/atrauzzi","html_url":"https://github.com/atrauzzi","followers_url":"https://api.github.com/users/atrauzzi/followers","following_url":"https://api.github.com/users/atrauzzi/following{/other_user}","gists_url":"https://api.github.com/users/atrauzzi/gists{/gist_id}","starred_url":"https://api.github.com/users/atrauzzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrauzzi/subscriptions","organizations_url":"https://api.github.com/users/atrauzzi/orgs","repos_url":"https://api.github.com/users/atrauzzi/repos","events_url":"https://api.github.com/users/atrauzzi/events{/privacy}","received_events_url":"https://api.github.com/users/atrauzzi/received_events","type":"User","site_admin":false},"repo":{"id":9043229,"name":"laravel-doctrine","full_name":"atrauzzi/laravel-doctrine","owner":{"login":"atrauzzi","id":115199,"avatar_url":"https://avatars.githubusercontent.com/u/115199?v=3","gravatar_id":"","url":"https://api.github.com/users/atrauzzi","html_url":"https://github.com/atrauzzi","followers_url":"https://api.github.com/users/atrauzzi/followers","following_url":"https://api.github.com/users/atrauzzi/following{/other_user}","gists_url":"https://api.github.com/users/atrauzzi/gists{/gist_id}","starred_url":"https://api.github.com/users/atrauzzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atrauzzi/subscriptions","organizations_url":"https://api.github.com/users/atrauzzi/orgs","repos_url":"https://api.github.com/users/atrauzzi/repos","events_url":"https://api.github.com/users/atrauzzi/events{/privacy}","received_events_url":"https://api.github.com/users/atrauzzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atrauzzi/laravel-doctrine","description":"An ORM for a Framework for Web Artisans","fork":false,"url":"https://api.github.com/repos/atrauzzi/laravel-doctrine","forks_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/forks","keys_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/teams","hooks_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/hooks","issue_events_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues/events{/number}","events_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/events","assignees_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/assignees{/user}","branches_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/branches{/branch}","tags_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/tags","blobs_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/git/refs{/sha}","trees_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/statuses/{sha}","languages_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/languages","stargazers_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/stargazers","contributors_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/contributors","subscribers_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/subscribers","subscription_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/subscription","commits_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/commits{/sha}","git_commits_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/git/commits{/sha}","comments_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/comments{/number}","issue_comment_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues/comments{/number}","contents_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/contents/{+path}","compare_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/merges","archive_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/downloads","issues_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues{/number}","pulls_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls{/number}","milestones_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/milestones{/number}","notifications_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/labels{/name}","releases_url":"https://api.github.com/repos/atrauzzi/laravel-doctrine/releases{/id}","created_at":"2013-03-27T00:13:30Z","updated_at":"2015-05-06T12:57:53Z","pushed_at":"2015-05-06T13:23:06Z","git_url":"git://github.com/atrauzzi/laravel-doctrine.git","ssh_url":"git@github.com:atrauzzi/laravel-doctrine.git","clone_url":"https://github.com/atrauzzi/laravel-doctrine.git","svn_url":"https://github.com/atrauzzi/laravel-doctrine","homepage":null,"size":733,"stargazers_count":97,"watchers_count":97,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":8,"forks":62,"open_issues":8,"watchers":97,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/84"},"html":{"href":"https://github.com/atrauzzi/laravel-doctrine/pull/84"},"issue":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues/84"},"comments":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/atrauzzi/laravel-doctrine/statuses/ce22169a8eeb90be676ccd35f87d1725d9355305"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":19,"additions":226,"deletions":206,"changed_files":1}}