{"action":"opened","number":2513,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/2513","id":37117587,"html_url":"https://github.com/juju/juju/pull/2513","diff_url":"https://github.com/juju/juju/pull/2513.diff","patch_url":"https://github.com/juju/juju/pull/2513.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/2513","number":2513,"state":"open","locked":false,"title":"state: fix block-device/address update assertions","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"body":"Change block-device and machine address updates to not\ncare about concurrent updates.\n\nBlock-device and address updates are currently asserting\nthat there are no concurrent changes. There are several\nproblems with this:\n - to do this, they assert that the current field value\n   is equal to the in-memory struct representation. This\n   means that removing or reordering fields in the struct\n   will cause assertion failures\n - even without changing the above, there is an issue in\n   mgo that can cause reordering of map elements in\n   assertions\n - the assertions are pointless\n\nThe assertions are pointless for two main reasons:\n - for each of block-devices and addresses, there is a single\n   worker responsible for updating. Any concurrent update\n   issues are thus purely academic\n - even if we prevent a change between observing the current\n   value and updating, we still loop and then update. The net\n   effect is that we always update, except in the case of\n   \"state changing too fast\".\n\nFixes https://bugs.launchpad.net/bugs/1461871","created_at":"2015-06-08T01:46:45Z","updated_at":"2015-06-08T01:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/2513/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/2513/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/2513/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/275962aac188655823dc15ec4abf0128d25ed2a8","head":{"label":"axw:lp1461871-state-struct-assertions","ref":"lp1461871-state-struct-assertions","sha":"275962aac188655823dc15ec4abf0128d25ed2a8","user":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"repo":{"id":20466577,"name":"juju","full_name":"axw/juju","owner":{"login":"axw","id":843579,"avatar_url":"https://avatars.githubusercontent.com/u/843579?v=3","gravatar_id":"","url":"https://api.github.com/users/axw","html_url":"https://github.com/axw","followers_url":"https://api.github.com/users/axw/followers","following_url":"https://api.github.com/users/axw/following{/other_user}","gists_url":"https://api.github.com/users/axw/gists{/gist_id}","starred_url":"https://api.github.com/users/axw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/axw/subscriptions","organizations_url":"https://api.github.com/users/axw/orgs","repos_url":"https://api.github.com/users/axw/repos","events_url":"https://api.github.com/users/axw/events{/privacy}","received_events_url":"https://api.github.com/users/axw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/axw/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/axw/juju","forks_url":"https://api.github.com/repos/axw/juju/forks","keys_url":"https://api.github.com/repos/axw/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/axw/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/axw/juju/teams","hooks_url":"https://api.github.com/repos/axw/juju/hooks","issue_events_url":"https://api.github.com/repos/axw/juju/issues/events{/number}","events_url":"https://api.github.com/repos/axw/juju/events","assignees_url":"https://api.github.com/repos/axw/juju/assignees{/user}","branches_url":"https://api.github.com/repos/axw/juju/branches{/branch}","tags_url":"https://api.github.com/repos/axw/juju/tags","blobs_url":"https://api.github.com/repos/axw/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/axw/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/axw/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/axw/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/axw/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/axw/juju/languages","stargazers_url":"https://api.github.com/repos/axw/juju/stargazers","contributors_url":"https://api.github.com/repos/axw/juju/contributors","subscribers_url":"https://api.github.com/repos/axw/juju/subscribers","subscription_url":"https://api.github.com/repos/axw/juju/subscription","commits_url":"https://api.github.com/repos/axw/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/axw/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/axw/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/axw/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/axw/juju/contents/{+path}","compare_url":"https://api.github.com/repos/axw/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/axw/juju/merges","archive_url":"https://api.github.com/repos/axw/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/axw/juju/downloads","issues_url":"https://api.github.com/repos/axw/juju/issues{/number}","pulls_url":"https://api.github.com/repos/axw/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/axw/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/axw/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/axw/juju/labels{/name}","releases_url":"https://api.github.com/repos/axw/juju/releases{/id}","created_at":"2014-06-04T01:51:25Z","updated_at":"2014-09-10T04:02:03Z","pushed_at":"2015-06-08T01:46:35Z","git_url":"git://github.com/axw/juju.git","ssh_url":"git@github.com:axw/juju.git","clone_url":"https://github.com/axw/juju.git","svn_url":"https://github.com/axw/juju","homepage":null,"size":54491,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:1.24","ref":"1.24","sha":"54c24dd3eb1a8bc1c43bab0b5180463c8ab91c98","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","created_at":"2014-06-03T14:28:10Z","updated_at":"2015-06-03T13:36:02Z","pushed_at":"2015-06-08T01:46:45Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":84422,"stargazers_count":285,"watchers_count":285,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":67,"forks":93,"open_issues":67,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/2513"},"html":{"href":"https://github.com/juju/juju/pull/2513"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/2513"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/2513/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/2513/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/2513/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/275962aac188655823dc15ec4abf0128d25ed2a8"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":15,"changed_files":3}}