{"action":"created","issue":{"url":"https://api.github.com/repos/Famous/engine/issues/168","labels_url":"https://api.github.com/repos/Famous/engine/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/Famous/engine/issues/168/comments","events_url":"https://api.github.com/repos/Famous/engine/issues/168/events","html_url":"https://github.com/Famous/engine/issues/168","id":79693800,"number":168,"title":"GestureHandler does not trigger \"end\" events for \"tap\" gestures","user":{"login":"pilwon","id":61540,"avatar_url":"https://avatars.githubusercontent.com/u/61540?v=3","gravatar_id":"","url":"https://api.github.com/users/pilwon","html_url":"https://github.com/pilwon","followers_url":"https://api.github.com/users/pilwon/followers","following_url":"https://api.github.com/users/pilwon/following{/other_user}","gists_url":"https://api.github.com/users/pilwon/gists{/gist_id}","starred_url":"https://api.github.com/users/pilwon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pilwon/subscriptions","organizations_url":"https://api.github.com/users/pilwon/orgs","repos_url":"https://api.github.com/users/pilwon/repos","events_url":"https://api.github.com/users/pilwon/events{/privacy}","received_events_url":"https://api.github.com/users/pilwon/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Famous/engine/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-23T02:23:25Z","updated_at":"2015-05-29T17:29:27Z","closed_at":null,"body":"`GestureHandler` currently triggers only `start` events for `tap` gestures.\r\n\r\nThe source code tells me this was intended behavior by design, but wouldn't it be more consistent with other gesture types to trigger an `end` event (or at least provide an option to subscribe this event status)? Any of these events on receive can terminate the `tap` event being tracked: `touchmove`, `mousemove`,  `touchend`, `mouseup`, and `mouseleave`.\r\n\r\nBesides consistency, it would allow handling long press (touch & hold) gestures. We can also only react to `end` events, similar to `onTouchEnd`/`onMouseUp`.\r\n\r\nIf the original intention behind triggering only `start` events was for simplicity in event handling, we can probably add a filtering option to `.on()` while triggering both `start` and `end` by default. (ex: `.on('tap', ['start'], cb)` or `.on('tap:start', cb)`)"},"comment":{"url":"https://api.github.com/repos/Famous/engine/issues/comments/106880499","html_url":"https://github.com/Famous/engine/issues/168#issuecomment-106880499","issue_url":"https://api.github.com/repos/Famous/engine/issues/168","id":106880499,"user":{"login":"michaelobriena","id":2331602,"avatar_url":"https://avatars.githubusercontent.com/u/2331602?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelobriena","html_url":"https://github.com/michaelobriena","followers_url":"https://api.github.com/users/michaelobriena/followers","following_url":"https://api.github.com/users/michaelobriena/following{/other_user}","gists_url":"https://api.github.com/users/michaelobriena/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelobriena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelobriena/subscriptions","organizations_url":"https://api.github.com/users/michaelobriena/orgs","repos_url":"https://api.github.com/users/michaelobriena/repos","events_url":"https://api.github.com/users/michaelobriena/events{/privacy}","received_events_url":"https://api.github.com/users/michaelobriena/received_events","type":"User","site_admin":false},"created_at":"2015-05-29T17:29:27Z","updated_at":"2015-05-29T17:29:27Z","body":"@pilwon great suggestion.  I think I personally need to do some more research on this before throwing in an opinion."}}