{"action":"created","issue":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/217","labels_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/217/labels{/name}","comments_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/217/comments","events_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/217/events","html_url":"https://github.com/meetecho/janus-gateway/pull/217","id":72858417,"number":217,"title":"Add RTSP support to the streaming plugin using libcurl","user":{"login":"mpromonet","id":1367630,"avatar_url":"https://avatars.githubusercontent.com/u/1367630?v=3","gravatar_id":"","url":"https://api.github.com/users/mpromonet","html_url":"https://github.com/mpromonet","followers_url":"https://api.github.com/users/mpromonet/followers","following_url":"https://api.github.com/users/mpromonet/following{/other_user}","gists_url":"https://api.github.com/users/mpromonet/gists{/gist_id}","starred_url":"https://api.github.com/users/mpromonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpromonet/subscriptions","organizations_url":"https://api.github.com/users/mpromonet/orgs","repos_url":"https://api.github.com/users/mpromonet/repos","events_url":"https://api.github.com/users/mpromonet/events{/privacy}","received_events_url":"https://api.github.com/users/mpromonet/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-03T20:11:44Z","updated_at":"2015-05-06T09:54:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/meetecho/janus-gateway/pulls/217","html_url":"https://github.com/meetecho/janus-gateway/pull/217","diff_url":"https://github.com/meetecho/janus-gateway/pull/217.diff","patch_url":"https://github.com/meetecho/janus-gateway/pull/217.patch"},"body":"As libcurl is already present for other purpose and provide a basic support of RTSP, I build this pull request in order to ask to an RTSP server the streams to relay.\r\nBasically it use libcurl to get RTP information and next use the RTP streaming code of the streaming plugin.\r\n\r\nIt could be configured through the janusjanus.plugin.streaming.cfg like this : \r\n\r\n      [h264-rapicam-rtsp]\r\n      type = rtsp\r\n      id = 99\r\n      description = RTSP Test\r\n      audio = no\r\n      video = yes\r\n      url=rtsp://127.0.0.1:8554/unicast\r\n"},"comment":{"url":"https://api.github.com/repos/meetecho/janus-gateway/issues/comments/99402678","html_url":"https://github.com/meetecho/janus-gateway/pull/217#issuecomment-99402678","issue_url":"https://api.github.com/repos/meetecho/janus-gateway/issues/217","id":99402678,"user":{"login":"lminiero","id":3684796,"avatar_url":"https://avatars.githubusercontent.com/u/3684796?v=3","gravatar_id":"","url":"https://api.github.com/users/lminiero","html_url":"https://github.com/lminiero","followers_url":"https://api.github.com/users/lminiero/followers","following_url":"https://api.github.com/users/lminiero/following{/other_user}","gists_url":"https://api.github.com/users/lminiero/gists{/gist_id}","starred_url":"https://api.github.com/users/lminiero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lminiero/subscriptions","organizations_url":"https://api.github.com/users/lminiero/orgs","repos_url":"https://api.github.com/users/lminiero/repos","events_url":"https://api.github.com/users/lminiero/events{/privacy}","received_events_url":"https://api.github.com/users/lminiero/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T09:54:27Z","updated_at":"2015-05-06T09:54:27Z","body":"Ah, I didn't notice the curl_easy_cleanup part, sorry about that! Then in that case concern 2. disappears: I guess the libcurl cleanup takes care of a TEARDOWN automatically so no need to do that.\r\n\r\nNo need to look into Sofia SDP either: for now I think your approach works fine.\r\n\r\nAs such, don't worry about fixing anything in the code apart from some refinement you might deem necessary. I'll review the code in the next few days and then I'll merge it."}}