{"push_id":681592158,"size":7,"distinct_size":7,"ref":"refs/heads/opal_coverity","head":"7e349977463bbc34858f20503afe231aa3afceb6","before":"7b7993e40638271f72de18961dab204bd702b296","commits":[{"sha":"c87ef46599171ccfad385db759f126e9220328ba","author":{"email":"07b107919bc47895a8b637378595bdacb368c62d@cs.unm.edu","name":"Nathan Hjelm"},"message":"Merge pull request #612 from hjelmn/opal_coverity\n\nopal coverity fixes","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/c87ef46599171ccfad385db759f126e9220328ba"},{"sha":"b1c100c40272a221e7d4b71bed67f17a223014a7","author":{"email":"07b107919bc47895a8b637378595bdacb368c62d@lanl.gov","name":"Nathan Hjelm"},"message":"win_get_info: fix indentation\n\nSigned-off-by: Nathan Hjelm <hjelmn@lanl.gov>","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/b1c100c40272a221e7d4b71bed67f17a223014a7"},{"sha":"ea35e472284a2b3a44383b86744367de2eeb01c8","author":{"email":"842ab96c725bc14a04af3d8f9c70074618b6e198@open-mpi.org","name":"Ralph Castain"},"message":"Fat SMPs (i.e., systems with nodes containing large numbers of cpus) were failing to start due to connection failures of the opal/pmix support. Root cause was that (a) we were setting the client socket to non-blocking before calling connect, and (b) the server was using the event library to harvest the accepts, and also did the handshake while in that event. So the server would backup beyond the connection backlog limit, and we would fail.\n\nChanging the client to leave its socket as blocking during the connect doesn't solve the problem by itself - you also have to introduce a sleep delay once the backlog is hit to avoid simply machine-gunning your way thru retries. This gets somewhat difficult to adjust as you don't want to unnecessarily prolong startup time.\n\nWe've solved this before by adding a listening thread that simply reaps accepts and shoves them into the event library for subsequent processing. This would resolve the problem, but meant yet another daemon-level thread. So I centralized the listening thread support and let multiple elements register listeners on it. Thus, each daemon now has a single listening thread that reaps accepts from multiple sources - for now, the orte/pmix server and the oob/usock support are using it. I'll add in the oob/tcp component later.\n\nThis still didn't fully resolve the SMP problem, especially on coprocessor cards (e.g., KNC). Removing the shared memory dstore support helped further improve the behavior - it looks like there is some kind of memory paging issue there that needs further understanding. Given that the shared memory support was about to be lost when I bring over the PMIx integration (until it is restored in that library), it seemed like a reasonable thing to just remove it at this point.","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/ea35e472284a2b3a44383b86744367de2eeb01c8"},{"sha":"daa55fd582603d277c3316c2cf96fb98f415b5f5","author":{"email":"842ab96c725bc14a04af3d8f9c70074618b6e198@open-mpi.org","name":"rhc54"},"message":"Merge pull request #613 from rhc54/topic/listener\n\nCentralize listener connection support","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/daa55fd582603d277c3316c2cf96fb98f415b5f5"},{"sha":"bac308b1846cdf71646f37ac303d7d68206c739a","author":{"email":"842ab96c725bc14a04af3d8f9c70074618b6e198@open-mpi.org","name":"Ralph Castain"},"message":"Remove stale header","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/bac308b1846cdf71646f37ac303d7d68206c739a"},{"sha":"6b93db6a9af33db50197dcb3710f49c7e0db0de8","author":{"email":"842ab96c725bc14a04af3d8f9c70074618b6e198@open-mpi.org","name":"Ralph Castain"},"message":"Grrr...not sure how this slipped thru","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/6b93db6a9af33db50197dcb3710f49c7e0db0de8"},{"sha":"7e349977463bbc34858f20503afe231aa3afceb6","author":{"email":"07b107919bc47895a8b637378595bdacb368c62d@lanl.gov","name":"Nathan Hjelm"},"message":"event/libevent2022: fix coverity issue\n\nCID 1269841 Out-of-bounds access (OVERRUN)\n\nCorrect issue. If the string being concatingated fills the remaining\nbuffer then a \\0 is written past the end of the string. In practice\nthis should never happen but it should be fixed. I re-organized the\ncode a bit to clear this error.\n\nSigned-off-by: Nathan Hjelm <hjelmn@lanl.gov>","distinct":true,"url":"https://api.github.com/repos/hjelmn/ompi/commits/7e349977463bbc34858f20503afe231aa3afceb6"}]}