{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/42403244","id":42403244,"diff_hunk":"@@ -34,6 +34,7 @@ The first Node.js LTS release! See https://github.com/nodejs/LTS/ for details of\n   - Added new `-c` (or `--check`) command line argument for checking script syntax without executing the code (Dave Eddy) [#2411](https://github.com/nodejs/node/pull/2411)\n   - Added `process.versions.icu` to hold the current ICU library version (Evan Lucas) [#3102](https://github.com/nodejs/node/pull/3102)\n   - Added `process.release.lts` to hold the current LTS codename when the binary is from an active LTS release line (Rod Vagg) [#3212](https://github.com/nodejs/node/pull/3212)\n+  - Added new optional parameter `encoding` to `Buffer.indexOf`. Changed search algorithm from naive to naive + Boyer-Moore-Horspool. (Karl Skomski) [#2539](https://github.com/nodejs/node/pull/2539)","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"24b5a56d7a1887d90b213a391f4d600be1db33f2","original_commit_id":"24b5a56d7a1887d90b213a391f4d600be1db33f2","user":{"login":"silverwind","id":115237,"avatar_url":"https://avatars.githubusercontent.com/u/115237?v=3","gravatar_id":"","url":"https://api.github.com/users/silverwind","html_url":"https://github.com/silverwind","followers_url":"https://api.github.com/users/silverwind/followers","following_url":"https://api.github.com/users/silverwind/following{/other_user}","gists_url":"https://api.github.com/users/silverwind/gists{/gist_id}","starred_url":"https://api.github.com/users/silverwind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverwind/subscriptions","organizations_url":"https://api.github.com/users/silverwind/orgs","repos_url":"https://api.github.com/users/silverwind/repos","events_url":"https://api.github.com/users/silverwind/events{/privacy}","received_events_url":"https://api.github.com/users/silverwind/received_events","type":"User","site_admin":false},"body":"No one's going to read that anyways, that's for sure. I'm feeling adding to the changelog after the release isn't quite right. Let's remove it.","created_at":"2015-10-19T17:53:09Z","updated_at":"2015-10-19T17:53:09Z","html_url":"https://github.com/nodejs/node/pull/3373#discussion_r42403244","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/3373","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/42403244"},"html":{"href":"https://github.com/nodejs/node/pull/3373#discussion_r42403244"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/3373"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/3373","id":47706559,"html_url":"https://github.com/nodejs/node/pull/3373","diff_url":"https://github.com/nodejs/node/pull/3373.diff","patch_url":"https://github.com/nodejs/node/pull/3373.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/3373","number":3373,"state":"open","locked":false,"title":"doc: Document buffer.indexOf changes in v4.2.0","user":{"login":"skomski","id":166891,"avatar_url":"https://avatars.githubusercontent.com/u/166891?v=3","gravatar_id":"","url":"https://api.github.com/users/skomski","html_url":"https://github.com/skomski","followers_url":"https://api.github.com/users/skomski/followers","following_url":"https://api.github.com/users/skomski/following{/other_user}","gists_url":"https://api.github.com/users/skomski/gists{/gist_id}","starred_url":"https://api.github.com/users/skomski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomski/subscriptions","organizations_url":"https://api.github.com/users/skomski/orgs","repos_url":"https://api.github.com/users/skomski/repos","events_url":"https://api.github.com/users/skomski/events{/privacy}","received_events_url":"https://api.github.com/users/skomski/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-14T19:54:06Z","updated_at":"2015-10-19T17:53:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef66735eaea31bb8d3eb03b632725dc930d154af","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/3373/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/3373/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/3373/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/24b5a56d7a1887d90b213a391f4d600be1db33f2","head":{"label":"skomski:add-doc-buffer-indexof","ref":"add-doc-buffer-indexof","sha":"24b5a56d7a1887d90b213a391f4d600be1db33f2","user":{"login":"skomski","id":166891,"avatar_url":"https://avatars.githubusercontent.com/u/166891?v=3","gravatar_id":"","url":"https://api.github.com/users/skomski","html_url":"https://github.com/skomski","followers_url":"https://api.github.com/users/skomski/followers","following_url":"https://api.github.com/users/skomski/following{/other_user}","gists_url":"https://api.github.com/users/skomski/gists{/gist_id}","starred_url":"https://api.github.com/users/skomski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomski/subscriptions","organizations_url":"https://api.github.com/users/skomski/orgs","repos_url":"https://api.github.com/users/skomski/repos","events_url":"https://api.github.com/users/skomski/events{/privacy}","received_events_url":"https://api.github.com/users/skomski/received_events","type":"User","site_admin":false},"repo":{"id":40603145,"name":"node","full_name":"skomski/node","owner":{"login":"skomski","id":166891,"avatar_url":"https://avatars.githubusercontent.com/u/166891?v=3","gravatar_id":"","url":"https://api.github.com/users/skomski","html_url":"https://github.com/skomski","followers_url":"https://api.github.com/users/skomski/followers","following_url":"https://api.github.com/users/skomski/following{/other_user}","gists_url":"https://api.github.com/users/skomski/gists{/gist_id}","starred_url":"https://api.github.com/users/skomski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skomski/subscriptions","organizations_url":"https://api.github.com/users/skomski/orgs","repos_url":"https://api.github.com/users/skomski/repos","events_url":"https://api.github.com/users/skomski/events{/privacy}","received_events_url":"https://api.github.com/users/skomski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skomski/node","description":"Future Node.js releases will be from this repo.","fork":true,"url":"https://api.github.com/repos/skomski/node","forks_url":"https://api.github.com/repos/skomski/node/forks","keys_url":"https://api.github.com/repos/skomski/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skomski/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skomski/node/teams","hooks_url":"https://api.github.com/repos/skomski/node/hooks","issue_events_url":"https://api.github.com/repos/skomski/node/issues/events{/number}","events_url":"https://api.github.com/repos/skomski/node/events","assignees_url":"https://api.github.com/repos/skomski/node/assignees{/user}","branches_url":"https://api.github.com/repos/skomski/node/branches{/branch}","tags_url":"https://api.github.com/repos/skomski/node/tags","blobs_url":"https://api.github.com/repos/skomski/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skomski/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skomski/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/skomski/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skomski/node/statuses/{sha}","languages_url":"https://api.github.com/repos/skomski/node/languages","stargazers_url":"https://api.github.com/repos/skomski/node/stargazers","contributors_url":"https://api.github.com/repos/skomski/node/contributors","subscribers_url":"https://api.github.com/repos/skomski/node/subscribers","subscription_url":"https://api.github.com/repos/skomski/node/subscription","commits_url":"https://api.github.com/repos/skomski/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/skomski/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/skomski/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/skomski/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/skomski/node/contents/{+path}","compare_url":"https://api.github.com/repos/skomski/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skomski/node/merges","archive_url":"https://api.github.com/repos/skomski/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skomski/node/downloads","issues_url":"https://api.github.com/repos/skomski/node/issues{/number}","pulls_url":"https://api.github.com/repos/skomski/node/pulls{/number}","milestones_url":"https://api.github.com/repos/skomski/node/milestones{/number}","notifications_url":"https://api.github.com/repos/skomski/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skomski/node/labels{/name}","releases_url":"https://api.github.com/repos/skomski/node/releases{/id}","created_at":"2015-08-12T13:47:20Z","updated_at":"2015-08-12T13:47:24Z","pushed_at":"2015-10-14T19:50:50Z","git_url":"git://github.com/skomski/node.git","ssh_url":"git@github.com:skomski/node.git","clone_url":"https://github.com/skomski/node.git","svn_url":"https://github.com/skomski/node","homepage":"https://iojs.org","size":148167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"dae9fae0fe9b7807838e6e54f1bafa0537ecfc91","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-10-19T17:41:40Z","pushed_at":"2015-10-19T17:47:28Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":378526,"stargazers_count":16293,"watchers_count":16293,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1581,"mirror_url":null,"open_issues_count":536,"forks":1581,"open_issues":536,"watchers":16293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/3373"},"html":{"href":"https://github.com/nodejs/node/pull/3373"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/3373"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/3373/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/3373/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/3373/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/24b5a56d7a1887d90b213a391f4d600be1db33f2"}}}}