{"action":"created","issue":{"url":"https://api.github.com/repos/tmpvar/jsdom/issues/1293","labels_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1293/labels{/name}","comments_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1293/comments","events_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1293/events","html_url":"https://github.com/tmpvar/jsdom/pull/1293","id":118017325,"number":1293,"title":"Clean up selenium after itself. Also report start up errors properly","user":{"login":"Joris-van-der-Wel","id":745898,"avatar_url":"https://avatars.githubusercontent.com/u/745898?v=3","gravatar_id":"","url":"https://api.github.com/users/Joris-van-der-Wel","html_url":"https://github.com/Joris-van-der-Wel","followers_url":"https://api.github.com/users/Joris-van-der-Wel/followers","following_url":"https://api.github.com/users/Joris-van-der-Wel/following{/other_user}","gists_url":"https://api.github.com/users/Joris-van-der-Wel/gists{/gist_id}","starred_url":"https://api.github.com/users/Joris-van-der-Wel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joris-van-der-Wel/subscriptions","organizations_url":"https://api.github.com/users/Joris-van-der-Wel/orgs","repos_url":"https://api.github.com/users/Joris-van-der-Wel/repos","events_url":"https://api.github.com/users/Joris-van-der-Wel/events{/privacy}","received_events_url":"https://api.github.com/users/Joris-van-der-Wel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-20T11:08:13Z","updated_at":"2015-11-21T12:47:10Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tmpvar/jsdom/pulls/1293","html_url":"https://github.com/tmpvar/jsdom/pull/1293","diff_url":"https://github.com/tmpvar/jsdom/pull/1293.diff","patch_url":"https://github.com/tmpvar/jsdom/pull/1293.patch"},"body":"Errors from seleniumStart were not reported properly (the relevant promise was already resolved), it would always time out.\r\n\r\nThis change also makes sure the selenium server is killed after the script run. Otherwise, I have to kill it manually after every run.\r\n\r\nPreviously we manually checked for the \"Selenium Server is up and running\" message. As far as I can tell, this is not needed anymore. I am guessing selenium-standalone has been updated?"},"comment":{"url":"https://api.github.com/repos/tmpvar/jsdom/issues/comments/158635931","html_url":"https://github.com/tmpvar/jsdom/pull/1293#issuecomment-158635931","issue_url":"https://api.github.com/repos/tmpvar/jsdom/issues/1293","id":158635931,"user":{"login":"Joris-van-der-Wel","id":745898,"avatar_url":"https://avatars.githubusercontent.com/u/745898?v=3","gravatar_id":"","url":"https://api.github.com/users/Joris-van-der-Wel","html_url":"https://github.com/Joris-van-der-Wel","followers_url":"https://api.github.com/users/Joris-van-der-Wel/followers","following_url":"https://api.github.com/users/Joris-van-der-Wel/following{/other_user}","gists_url":"https://api.github.com/users/Joris-van-der-Wel/gists{/gist_id}","starred_url":"https://api.github.com/users/Joris-van-der-Wel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Joris-van-der-Wel/subscriptions","organizations_url":"https://api.github.com/users/Joris-van-der-Wel/orgs","repos_url":"https://api.github.com/users/Joris-van-der-Wel/repos","events_url":"https://api.github.com/users/Joris-van-der-Wel/events{/privacy}","received_events_url":"https://api.github.com/users/Joris-van-der-Wel/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T12:47:10Z","updated_at":"2015-11-21T12:47:10Z","body":"Works for me on windows 8.1"}}