{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/47394800","id":47394800,"diff_hunk":"@@ -108,25 +113,8 @@ void ngTest(String description, Function fn,\n   test(description, () async {\n     await _runInjectableFunction(fn);\n   }, testOn: testOn, timeout: timeout, skip: skip, onPlatform: onPlatform);\n-}\n-\n-final _providersExpando =\n-    new Expando<List<Provider>>('Providers for the current test');\n-final _injectorExpando =\n-    new Expando<Injector>('Angular Injector for the current test');\n-\n-List get _currentTestProviders {\n-  if (_providersExpando[_currentTest] == null) {\n-    return _providersExpando[_currentTest] = [];\n-  }\n-  return _providersExpando[_currentTest];\n-}\n \n-Injector get _currentInjector => _injectorExpando[_currentTest];\n-void set _currentInjector(Injector newInjector) {\n-  _injectorExpando[_currentTest] = newInjector;\n+  _addTestInjectorTearDown();\n }\n \n-// TODO: warning, the Invoker.current.liveTest is not a settled API and is\n-// subject to change in future versions of package:test.\n-LiveTest get _currentTest => Invoker.current.liveTest;\n+TestInjector _testInjector = getTestInjector();","path":"modules_dart/angular2_testing/lib/angular2_testing.dart","position":93,"original_position":93,"commit_id":"2f993baf0fe7d8d6f5787aeb61f7d96f88467c35","original_commit_id":"2f993baf0fe7d8d6f5787aeb61f7d96f88467c35","user":{"login":"kevmoo","id":17034,"avatar_url":"https://avatars.githubusercontent.com/u/17034?v=3","gravatar_id":"","url":"https://api.github.com/users/kevmoo","html_url":"https://github.com/kevmoo","followers_url":"https://api.github.com/users/kevmoo/followers","following_url":"https://api.github.com/users/kevmoo/following{/other_user}","gists_url":"https://api.github.com/users/kevmoo/gists{/gist_id}","starred_url":"https://api.github.com/users/kevmoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevmoo/subscriptions","organizations_url":"https://api.github.com/users/kevmoo/orgs","repos_url":"https://api.github.com/users/kevmoo/repos","events_url":"https://api.github.com/users/kevmoo/events{/privacy}","received_events_url":"https://api.github.com/users/kevmoo/received_events","type":"User","site_admin":false},"body":"Make this `final`?","created_at":"2015-12-11T19:32:53Z","updated_at":"2015-12-11T19:32:53Z","html_url":"https://github.com/angular/angular/pull/5819#discussion_r47394800","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/5819","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/47394800"},"html":{"href":"https://github.com/angular/angular/pull/5819#discussion_r47394800"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/5819"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/5819","id":53337026,"html_url":"https://github.com/angular/angular/pull/5819","diff_url":"https://github.com/angular/angular/pull/5819.diff","patch_url":"https://github.com/angular/angular/pull/5819.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/5819","number":5819,"state":"open","locked":false,"title":"refactor(testing): move common testing logic into test_injector","user":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"body":"Before, all test framework wrappers (internal for dart and js/ts,\r\nangular2_test for dart and testing for js/ts) had similar logic to\r\nkeep track of current global test injector and test provider list.\r\nThis change wraps that logic into one class managed by the test\r\ninjector.","created_at":"2015-12-11T00:11:32Z","updated_at":"2015-12-11T19:32:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fd400802ca612487f7f11f2b1bcafe18199bcca","assignee":{"login":"vicb","id":248818,"avatar_url":"https://avatars.githubusercontent.com/u/248818?v=3","gravatar_id":"","url":"https://api.github.com/users/vicb","html_url":"https://github.com/vicb","followers_url":"https://api.github.com/users/vicb/followers","following_url":"https://api.github.com/users/vicb/following{/other_user}","gists_url":"https://api.github.com/users/vicb/gists{/gist_id}","starred_url":"https://api.github.com/users/vicb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicb/subscriptions","organizations_url":"https://api.github.com/users/vicb/orgs","repos_url":"https://api.github.com/users/vicb/repos","events_url":"https://api.github.com/users/vicb/events{/privacy}","received_events_url":"https://api.github.com/users/vicb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/5819/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/5819/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/5819/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/2f993baf0fe7d8d6f5787aeb61f7d96f88467c35","head":{"label":"juliemr:test-provider-config-3","ref":"test-provider-config-3","sha":"2f993baf0fe7d8d6f5787aeb61f7d96f88467c35","user":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"repo":{"id":28985296,"name":"angular","full_name":"juliemr/angular","owner":{"login":"juliemr","id":2081709,"avatar_url":"https://avatars.githubusercontent.com/u/2081709?v=3","gravatar_id":"","url":"https://api.github.com/users/juliemr","html_url":"https://github.com/juliemr","followers_url":"https://api.github.com/users/juliemr/followers","following_url":"https://api.github.com/users/juliemr/following{/other_user}","gists_url":"https://api.github.com/users/juliemr/gists{/gist_id}","starred_url":"https://api.github.com/users/juliemr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliemr/subscriptions","organizations_url":"https://api.github.com/users/juliemr/orgs","repos_url":"https://api.github.com/users/juliemr/repos","events_url":"https://api.github.com/users/juliemr/events{/privacy}","received_events_url":"https://api.github.com/users/juliemr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/juliemr/angular","description":"","fork":true,"url":"https://api.github.com/repos/juliemr/angular","forks_url":"https://api.github.com/repos/juliemr/angular/forks","keys_url":"https://api.github.com/repos/juliemr/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juliemr/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juliemr/angular/teams","hooks_url":"https://api.github.com/repos/juliemr/angular/hooks","issue_events_url":"https://api.github.com/repos/juliemr/angular/issues/events{/number}","events_url":"https://api.github.com/repos/juliemr/angular/events","assignees_url":"https://api.github.com/repos/juliemr/angular/assignees{/user}","branches_url":"https://api.github.com/repos/juliemr/angular/branches{/branch}","tags_url":"https://api.github.com/repos/juliemr/angular/tags","blobs_url":"https://api.github.com/repos/juliemr/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juliemr/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juliemr/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/juliemr/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juliemr/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/juliemr/angular/languages","stargazers_url":"https://api.github.com/repos/juliemr/angular/stargazers","contributors_url":"https://api.github.com/repos/juliemr/angular/contributors","subscribers_url":"https://api.github.com/repos/juliemr/angular/subscribers","subscription_url":"https://api.github.com/repos/juliemr/angular/subscription","commits_url":"https://api.github.com/repos/juliemr/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/juliemr/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/juliemr/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/juliemr/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/juliemr/angular/contents/{+path}","compare_url":"https://api.github.com/repos/juliemr/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juliemr/angular/merges","archive_url":"https://api.github.com/repos/juliemr/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juliemr/angular/downloads","issues_url":"https://api.github.com/repos/juliemr/angular/issues{/number}","pulls_url":"https://api.github.com/repos/juliemr/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/juliemr/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/juliemr/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juliemr/angular/labels{/name}","releases_url":"https://api.github.com/repos/juliemr/angular/releases{/id}","created_at":"2015-01-08T20:46:47Z","updated_at":"2015-07-16T01:51:08Z","pushed_at":"2015-12-11T18:59:06Z","git_url":"git://github.com/juliemr/angular.git","ssh_url":"git@github.com:juliemr/angular.git","clone_url":"https://github.com/juliemr/angular.git","svn_url":"https://github.com/juliemr/angular","homepage":null,"size":21321,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"3fd898e91f5d4cdf8b75187f11add3efa953a914","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-12-11T17:16:19Z","pushed_at":"2015-12-11T19:23:47Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":99700,"stargazers_count":7148,"watchers_count":7148,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1915,"mirror_url":null,"open_issues_count":733,"forks":1915,"open_issues":733,"watchers":7148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/5819"},"html":{"href":"https://github.com/angular/angular/pull/5819"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/5819"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/5819/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/5819/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/5819/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/2f993baf0fe7d8d6f5787aeb61f7d96f88467c35"}}}}