{"action":"created","issue":{"url":"https://api.github.com/repos/nikgraf/belle/issues/135","labels_url":"https://api.github.com/repos/nikgraf/belle/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/nikgraf/belle/issues/135/comments","events_url":"https://api.github.com/repos/nikgraf/belle/issues/135/events","html_url":"https://github.com/nikgraf/belle/issues/135","id":95957146,"number":135,"title":"Unexpected ComboBox default filter lookup behaviour","user":{"login":"alanrsoares","id":273334,"avatar_url":"https://avatars.githubusercontent.com/u/273334?v=3","gravatar_id":"","url":"https://api.github.com/users/alanrsoares","html_url":"https://github.com/alanrsoares","followers_url":"https://api.github.com/users/alanrsoares/followers","following_url":"https://api.github.com/users/alanrsoares/following{/other_user}","gists_url":"https://api.github.com/users/alanrsoares/gists{/gist_id}","starred_url":"https://api.github.com/users/alanrsoares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanrsoares/subscriptions","organizations_url":"https://api.github.com/users/alanrsoares/orgs","repos_url":"https://api.github.com/users/alanrsoares/repos","events_url":"https://api.github.com/users/alanrsoares/events{/privacy}","received_events_url":"https://api.github.com/users/alanrsoares/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nikgraf/belle/labels/ComboBox","name":"ComboBox","color":"bfe5bf"},{"url":"https://api.github.com/repos/nikgraf/belle/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":{"login":"nikgraf","id":223045,"avatar_url":"https://avatars.githubusercontent.com/u/223045?v=3","gravatar_id":"","url":"https://api.github.com/users/nikgraf","html_url":"https://github.com/nikgraf","followers_url":"https://api.github.com/users/nikgraf/followers","following_url":"https://api.github.com/users/nikgraf/following{/other_user}","gists_url":"https://api.github.com/users/nikgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/nikgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikgraf/subscriptions","organizations_url":"https://api.github.com/users/nikgraf/orgs","repos_url":"https://api.github.com/users/nikgraf/repos","events_url":"https://api.github.com/users/nikgraf/events{/privacy}","received_events_url":"https://api.github.com/users/nikgraf/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nikgraf/belle/milestones/2","html_url":"https://github.com/nikgraf/belle/milestones/xyz%20(placeholder%20name)","labels_url":"https://api.github.com/repos/nikgraf/belle/milestones/2/labels","id":1217451,"number":2,"title":"xyz (placeholder name)","description":"","creator":{"login":"nikgraf","id":223045,"avatar_url":"https://avatars.githubusercontent.com/u/223045?v=3","gravatar_id":"","url":"https://api.github.com/users/nikgraf","html_url":"https://github.com/nikgraf","followers_url":"https://api.github.com/users/nikgraf/followers","following_url":"https://api.github.com/users/nikgraf/following{/other_user}","gists_url":"https://api.github.com/users/nikgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/nikgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikgraf/subscriptions","organizations_url":"https://api.github.com/users/nikgraf/orgs","repos_url":"https://api.github.com/users/nikgraf/repos","events_url":"https://api.github.com/users/nikgraf/events{/privacy}","received_events_url":"https://api.github.com/users/nikgraf/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2015-07-21T06:53:28Z","updated_at":"2015-07-21T06:56:58Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-07-19T23:11:06Z","updated_at":"2015-07-21T07:07:59Z","closed_at":null,"body":"Hey guys. I'm using Belle's ComboBox as replacement to @JedWatson's react-select.\r\nSome issues I've spotted regarding the default behaviour:\r\n- Default filter lookup only caters Option.value, not the text (which would be the user expected behaviour)\r\n- Default filter lookup expect that Option.value is a string, when the most common use cases is mapping ids (numbers most of the time) as values."},"comment":{"url":"https://api.github.com/repos/nikgraf/belle/issues/comments/123194059","html_url":"https://github.com/nikgraf/belle/issues/135#issuecomment-123194059","issue_url":"https://api.github.com/repos/nikgraf/belle/issues/135","id":123194059,"user":{"login":"nikgraf","id":223045,"avatar_url":"https://avatars.githubusercontent.com/u/223045?v=3","gravatar_id":"","url":"https://api.github.com/users/nikgraf","html_url":"https://github.com/nikgraf","followers_url":"https://api.github.com/users/nikgraf/followers","following_url":"https://api.github.com/users/nikgraf/following{/other_user}","gists_url":"https://api.github.com/users/nikgraf/gists{/gist_id}","starred_url":"https://api.github.com/users/nikgraf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikgraf/subscriptions","organizations_url":"https://api.github.com/users/nikgraf/orgs","repos_url":"https://api.github.com/users/nikgraf/repos","events_url":"https://api.github.com/users/nikgraf/events{/privacy}","received_events_url":"https://api.github.com/users/nikgraf/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T07:07:59Z","updated_at":"2015-07-21T07:07:59Z","body":"@alanrsoares Just had a call with @jpuri and we came up with an idea:\r\n\r\nInstead of allowing to change the behaviour of value we could add an optional identifier which we provide in the onUpdate callback. We also consider adding an extra callback in case a exact match happened.\r\n\r\n```\r\n<Option value=\"France\" identifier={ 1234 }>\r\n    <img src=\"/path/to/france-image\" />France (Best Price)\r\n</Option>\r\n\r\n\r\nonChange({\r\n  value: \"France\",\r\n  identifier: 1234\r\n})\r\n```"}}