{"action":"created","issue":{"url":"https://api.github.com/repos/operasoftware/devopera/issues/261","labels_url":"https://api.github.com/repos/operasoftware/devopera/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/operasoftware/devopera/issues/261/comments","events_url":"https://api.github.com/repos/operasoftware/devopera/issues/261/events","html_url":"https://github.com/operasoftware/devopera/pull/261","id":64819078,"number":261,"title":"Add Service Worker","user":{"login":"mathiasbynens","id":81942,"avatar_url":"https://avatars.githubusercontent.com/u/81942?v=3","gravatar_id":"","url":"https://api.github.com/users/mathiasbynens","html_url":"https://github.com/mathiasbynens","followers_url":"https://api.github.com/users/mathiasbynens/followers","following_url":"https://api.github.com/users/mathiasbynens/following{/other_user}","gists_url":"https://api.github.com/users/mathiasbynens/gists{/gist_id}","starred_url":"https://api.github.com/users/mathiasbynens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mathiasbynens/subscriptions","organizations_url":"https://api.github.com/users/mathiasbynens/orgs","repos_url":"https://api.github.com/users/mathiasbynens/repos","events_url":"https://api.github.com/users/mathiasbynens/events{/privacy}","received_events_url":"https://api.github.com/users/mathiasbynens/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pepelsbey","id":105274,"avatar_url":"https://avatars.githubusercontent.com/u/105274?v=3","gravatar_id":"","url":"https://api.github.com/users/pepelsbey","html_url":"https://github.com/pepelsbey","followers_url":"https://api.github.com/users/pepelsbey/followers","following_url":"https://api.github.com/users/pepelsbey/following{/other_user}","gists_url":"https://api.github.com/users/pepelsbey/gists{/gist_id}","starred_url":"https://api.github.com/users/pepelsbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepelsbey/subscriptions","organizations_url":"https://api.github.com/users/pepelsbey/orgs","repos_url":"https://api.github.com/users/pepelsbey/repos","events_url":"https://api.github.com/users/pepelsbey/events{/privacy}","received_events_url":"https://api.github.com/users/pepelsbey/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-03-27T18:04:29Z","updated_at":"2015-03-31T11:22:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/operasoftware/devopera/pulls/261","html_url":"https://github.com/operasoftware/devopera/pull/261","diff_url":"https://github.com/operasoftware/devopera/pull/261.diff","patch_url":"https://github.com/operasoftware/devopera/pull/261.patch"},"body":"Note that `service-worker.js` must be in the root (i.e. not in the `scripts` directory) as we want it to have access to the whole origin.\r\n\r\nAnother consequence is that assets (i.e. CSS + JS files + images used from the CSS on every page) must be versioned, i.e. every time they change, they need a new file name and the service worker must be updated accordingly."},"comment":{"url":"https://api.github.com/repos/operasoftware/devopera/issues/comments/88051565","html_url":"https://github.com/operasoftware/devopera/pull/261#issuecomment-88051565","issue_url":"https://api.github.com/repos/operasoftware/devopera/issues/261","id":88051565,"user":{"login":"pepelsbey","id":105274,"avatar_url":"https://avatars.githubusercontent.com/u/105274?v=3","gravatar_id":"","url":"https://api.github.com/users/pepelsbey","html_url":"https://github.com/pepelsbey","followers_url":"https://api.github.com/users/pepelsbey/followers","following_url":"https://api.github.com/users/pepelsbey/following{/other_user}","gists_url":"https://api.github.com/users/pepelsbey/gists{/gist_id}","starred_url":"https://api.github.com/users/pepelsbey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pepelsbey/subscriptions","organizations_url":"https://api.github.com/users/pepelsbey/orgs","repos_url":"https://api.github.com/users/pepelsbey/repos","events_url":"https://api.github.com/users/pepelsbey/events{/privacy}","received_events_url":"https://api.github.com/users/pepelsbey/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T11:22:30Z","updated_at":"2015-03-31T11:22:30Z","body":"It makes it a bit more complicated. Solution I proposed with `?v=xxx` is also not correct, since building doesn’t mean file is changed. So we should check if file is really changed since last version before renaming (adding a new tag). I’m open for ideas how to integrate proper versioning."}}