{"action":"created","comment":{"url":"https://api.github.com/repos/playframework/playframework/pulls/comments/34965583","id":34965583,"diff_hunk":"@@ -0,0 +1,23 @@\n+/*\n+ * Copyright (C) 2009-2015 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+package play.core.j\n+\n+import java.io.{ InputStream, File }\n+import java.nio.file.Path\n+\n+import play.api.mvc.{ RangeResult, Result }\n+\n+/**\n+ * Java compatible RangeResult\n+ */\n+object JavaRangeResult {","path":"framework/src/play/src/main/scala/play/core/j/JavaRangeResult.scala","position":14,"original_position":14,"commit_id":"104ed1a0e3b2650e516baf6e4e49954700eeb30d","original_commit_id":"104ed1a0e3b2650e516baf6e4e49954700eeb30d","user":{"login":"marcospereira","id":4576,"avatar_url":"https://avatars.githubusercontent.com/u/4576?v=3","gravatar_id":"","url":"https://api.github.com/users/marcospereira","html_url":"https://github.com/marcospereira","followers_url":"https://api.github.com/users/marcospereira/followers","following_url":"https://api.github.com/users/marcospereira/following{/other_user}","gists_url":"https://api.github.com/users/marcospereira/gists{/gist_id}","starred_url":"https://api.github.com/users/marcospereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcospereira/subscriptions","organizations_url":"https://api.github.com/users/marcospereira/orgs","repos_url":"https://api.github.com/users/marcospereira/repos","events_url":"https://api.github.com/users/marcospereira/events{/privacy}","received_events_url":"https://api.github.com/users/marcospereira/received_events","type":"User","site_admin":false},"body":"And maybe these methods can go to `play.core.j.JavaResults`.","created_at":"2015-07-20T01:53:43Z","updated_at":"2015-07-20T01:53:43Z","html_url":"https://github.com/playframework/playframework/pull/4865#discussion_r34965583","pull_request_url":"https://api.github.com/repos/playframework/playframework/pulls/4865","_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments/34965583"},"html":{"href":"https://github.com/playframework/playframework/pull/4865#discussion_r34965583"},"pull_request":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4865"}}},"pull_request":{"url":"https://api.github.com/repos/playframework/playframework/pulls/4865","id":40301213,"html_url":"https://github.com/playframework/playframework/pull/4865","diff_url":"https://github.com/playframework/playframework/pull/4865.diff","patch_url":"https://github.com/playframework/playframework/pull/4865.patch","issue_url":"https://api.github.com/repos/playframework/playframework/issues/4865","number":4865,"state":"open","locked":false,"title":"Added range request support","user":{"login":"bjfletcher","id":733849,"avatar_url":"https://avatars.githubusercontent.com/u/733849?v=3","gravatar_id":"","url":"https://api.github.com/users/bjfletcher","html_url":"https://github.com/bjfletcher","followers_url":"https://api.github.com/users/bjfletcher/followers","following_url":"https://api.github.com/users/bjfletcher/following{/other_user}","gists_url":"https://api.github.com/users/bjfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/bjfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjfletcher/subscriptions","organizations_url":"https://api.github.com/users/bjfletcher/orgs","repos_url":"https://api.github.com/users/bjfletcher/repos","events_url":"https://api.github.com/users/bjfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/bjfletcher/received_events","type":"User","site_admin":false},"body":"Does this new `RangeRequest` API for Scala look good to you?\r\n\r\nI've not done the Java assets controller yet. I can do this later.\r\n\r\nSee the old pull request #4770 for some API discussion around this. Particularly my first comment: https://github.com/playframework/playframework/pull/4770#issue-91083774 and @jroper's comment: https://github.com/playframework/playframework/pull/4770#issuecomment-116436485. The code for that old pull request, should you wish to see it, is here: https://github.com/bjfletcher/playframework/tree/ranged-sendFile (it was on my `master` - should have branched before the pull request!)\r\n\r\nMany thanks for any feedback.","created_at":"2015-07-19T00:55:32Z","updated_at":"2015-07-20T01:53:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79299a6faf620232e10df8dbcf609425760907c0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/playframework/playframework/pulls/4865/commits","review_comments_url":"https://api.github.com/repos/playframework/playframework/pulls/4865/comments","review_comment_url":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/4865/comments","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/104ed1a0e3b2650e516baf6e4e49954700eeb30d","head":{"label":"bjfletcher:range-api","ref":"range-api","sha":"104ed1a0e3b2650e516baf6e4e49954700eeb30d","user":{"login":"bjfletcher","id":733849,"avatar_url":"https://avatars.githubusercontent.com/u/733849?v=3","gravatar_id":"","url":"https://api.github.com/users/bjfletcher","html_url":"https://github.com/bjfletcher","followers_url":"https://api.github.com/users/bjfletcher/followers","following_url":"https://api.github.com/users/bjfletcher/following{/other_user}","gists_url":"https://api.github.com/users/bjfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/bjfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjfletcher/subscriptions","organizations_url":"https://api.github.com/users/bjfletcher/orgs","repos_url":"https://api.github.com/users/bjfletcher/repos","events_url":"https://api.github.com/users/bjfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/bjfletcher/received_events","type":"User","site_admin":false},"repo":{"id":23148003,"name":"playframework","full_name":"bjfletcher/playframework","owner":{"login":"bjfletcher","id":733849,"avatar_url":"https://avatars.githubusercontent.com/u/733849?v=3","gravatar_id":"","url":"https://api.github.com/users/bjfletcher","html_url":"https://github.com/bjfletcher","followers_url":"https://api.github.com/users/bjfletcher/followers","following_url":"https://api.github.com/users/bjfletcher/following{/other_user}","gists_url":"https://api.github.com/users/bjfletcher/gists{/gist_id}","starred_url":"https://api.github.com/users/bjfletcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjfletcher/subscriptions","organizations_url":"https://api.github.com/users/bjfletcher/orgs","repos_url":"https://api.github.com/users/bjfletcher/repos","events_url":"https://api.github.com/users/bjfletcher/events{/privacy}","received_events_url":"https://api.github.com/users/bjfletcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bjfletcher/playframework","description":"Play Framework","fork":true,"url":"https://api.github.com/repos/bjfletcher/playframework","forks_url":"https://api.github.com/repos/bjfletcher/playframework/forks","keys_url":"https://api.github.com/repos/bjfletcher/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bjfletcher/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bjfletcher/playframework/teams","hooks_url":"https://api.github.com/repos/bjfletcher/playframework/hooks","issue_events_url":"https://api.github.com/repos/bjfletcher/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/bjfletcher/playframework/events","assignees_url":"https://api.github.com/repos/bjfletcher/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/bjfletcher/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/bjfletcher/playframework/tags","blobs_url":"https://api.github.com/repos/bjfletcher/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bjfletcher/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bjfletcher/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/bjfletcher/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bjfletcher/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/bjfletcher/playframework/languages","stargazers_url":"https://api.github.com/repos/bjfletcher/playframework/stargazers","contributors_url":"https://api.github.com/repos/bjfletcher/playframework/contributors","subscribers_url":"https://api.github.com/repos/bjfletcher/playframework/subscribers","subscription_url":"https://api.github.com/repos/bjfletcher/playframework/subscription","commits_url":"https://api.github.com/repos/bjfletcher/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/bjfletcher/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/bjfletcher/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/bjfletcher/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/bjfletcher/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/bjfletcher/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bjfletcher/playframework/merges","archive_url":"https://api.github.com/repos/bjfletcher/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bjfletcher/playframework/downloads","issues_url":"https://api.github.com/repos/bjfletcher/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/bjfletcher/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/bjfletcher/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/bjfletcher/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bjfletcher/playframework/labels{/name}","releases_url":"https://api.github.com/repos/bjfletcher/playframework/releases{/id}","created_at":"2014-08-20T12:38:02Z","updated_at":"2015-01-31T22:21:12Z","pushed_at":"2015-07-19T15:16:31Z","git_url":"git://github.com/bjfletcher/playframework.git","ssh_url":"git@github.com:bjfletcher/playframework.git","clone_url":"https://github.com/bjfletcher/playframework.git","svn_url":"https://github.com/bjfletcher/playframework","homepage":"http://www.playframework.com/","size":77049,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"playframework:master","ref":"master","sha":"e876f70004cd368a74eef21efd20f0b97c863a6a","user":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"repo":{"id":2340549,"name":"playframework","full_name":"playframework/playframework","owner":{"login":"playframework","id":319107,"avatar_url":"https://avatars.githubusercontent.com/u/319107?v=3","gravatar_id":"","url":"https://api.github.com/users/playframework","html_url":"https://github.com/playframework","followers_url":"https://api.github.com/users/playframework/followers","following_url":"https://api.github.com/users/playframework/following{/other_user}","gists_url":"https://api.github.com/users/playframework/gists{/gist_id}","starred_url":"https://api.github.com/users/playframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/playframework/subscriptions","organizations_url":"https://api.github.com/users/playframework/orgs","repos_url":"https://api.github.com/users/playframework/repos","events_url":"https://api.github.com/users/playframework/events{/privacy}","received_events_url":"https://api.github.com/users/playframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/playframework/playframework","description":"Play Framework","fork":false,"url":"https://api.github.com/repos/playframework/playframework","forks_url":"https://api.github.com/repos/playframework/playframework/forks","keys_url":"https://api.github.com/repos/playframework/playframework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/playframework/playframework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/playframework/playframework/teams","hooks_url":"https://api.github.com/repos/playframework/playframework/hooks","issue_events_url":"https://api.github.com/repos/playframework/playframework/issues/events{/number}","events_url":"https://api.github.com/repos/playframework/playframework/events","assignees_url":"https://api.github.com/repos/playframework/playframework/assignees{/user}","branches_url":"https://api.github.com/repos/playframework/playframework/branches{/branch}","tags_url":"https://api.github.com/repos/playframework/playframework/tags","blobs_url":"https://api.github.com/repos/playframework/playframework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/playframework/playframework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/playframework/playframework/git/refs{/sha}","trees_url":"https://api.github.com/repos/playframework/playframework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/playframework/playframework/statuses/{sha}","languages_url":"https://api.github.com/repos/playframework/playframework/languages","stargazers_url":"https://api.github.com/repos/playframework/playframework/stargazers","contributors_url":"https://api.github.com/repos/playframework/playframework/contributors","subscribers_url":"https://api.github.com/repos/playframework/playframework/subscribers","subscription_url":"https://api.github.com/repos/playframework/playframework/subscription","commits_url":"https://api.github.com/repos/playframework/playframework/commits{/sha}","git_commits_url":"https://api.github.com/repos/playframework/playframework/git/commits{/sha}","comments_url":"https://api.github.com/repos/playframework/playframework/comments{/number}","issue_comment_url":"https://api.github.com/repos/playframework/playframework/issues/comments{/number}","contents_url":"https://api.github.com/repos/playframework/playframework/contents/{+path}","compare_url":"https://api.github.com/repos/playframework/playframework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/playframework/playframework/merges","archive_url":"https://api.github.com/repos/playframework/playframework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/playframework/playframework/downloads","issues_url":"https://api.github.com/repos/playframework/playframework/issues{/number}","pulls_url":"https://api.github.com/repos/playframework/playframework/pulls{/number}","milestones_url":"https://api.github.com/repos/playframework/playframework/milestones{/number}","notifications_url":"https://api.github.com/repos/playframework/playframework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/playframework/playframework/labels{/name}","releases_url":"https://api.github.com/repos/playframework/playframework/releases{/id}","created_at":"2011-09-07T09:24:08Z","updated_at":"2015-07-19T23:09:23Z","pushed_at":"2015-07-19T20:47:16Z","git_url":"git://github.com/playframework/playframework.git","ssh_url":"git@github.com:playframework/playframework.git","clone_url":"https://github.com/playframework/playframework.git","svn_url":"https://github.com/playframework/playframework","homepage":"http://www.playframework.com/","size":127313,"stargazers_count":6532,"watchers_count":6532,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2318,"mirror_url":null,"open_issues_count":270,"forks":2318,"open_issues":270,"watchers":6532,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4865"},"html":{"href":"https://github.com/playframework/playframework/pull/4865"},"issue":{"href":"https://api.github.com/repos/playframework/playframework/issues/4865"},"comments":{"href":"https://api.github.com/repos/playframework/playframework/issues/4865/comments"},"review_comments":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4865/comments"},"review_comment":{"href":"https://api.github.com/repos/playframework/playframework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/playframework/playframework/pulls/4865/commits"},"statuses":{"href":"https://api.github.com/repos/playframework/playframework/statuses/104ed1a0e3b2650e516baf6e4e49954700eeb30d"}}}}