{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/39726725","id":39726725,"diff_hunk":"@@ -0,0 +1,28 @@\n+class MakePuppetSettingsGeneric < ActiveRecord::Migration\n+  def up\n+    Setting::Puppet.all.each do |setting|\n+      setting.update_column(:category, 'Setting::Configuration')","path":"db/migrate/20150915193833_make_puppet_settings_generic.rb","position":4,"original_position":4,"commit_id":"eb0dc558052dc8cd6cc33edc04170317c346cdbc","original_commit_id":"eb0dc558052dc8cd6cc33edc04170317c346cdbc","user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"body":"Doesn't Setting::Configuration.load_defaults do this?  It should update the category on initialisation.","created_at":"2015-09-17T09:32:53Z","updated_at":"2015-09-17T09:32:53Z","html_url":"https://github.com/theforeman/foreman/pull/2726#discussion_r39726725","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2726","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/39726725"},"html":{"href":"https://github.com/theforeman/foreman/pull/2726#discussion_r39726725"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2726"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2726","id":45110049,"html_url":"https://github.com/theforeman/foreman/pull/2726","diff_url":"https://github.com/theforeman/foreman/pull/2726.diff","patch_url":"https://github.com/theforeman/foreman/pull/2726.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2726","number":2726,"state":"open","locked":false,"title":"fixes #11836 - depuppetize settings","user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"body":"- `puppet_interval` :arrow_right: `configuration_interval`\r\n- `trusted_puppetmaster_hosts` :arrow_right: `trusted_hosts`\r\n- `ignore_puppet_facts_for_provisioning` :arrow_right: `ignore_facts_for_provisioning`\r\n- Adds ability to deprecate settings\r\n- Renames Setting::Puppet to Setting:Configuration\r\n\r\n\r\n","created_at":"2015-09-15T22:21:24Z","updated_at":"2015-09-17T09:32:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a481cff5f8ddd1375cf4630bc9a22f3622f77a72","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2726/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2726/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2726/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/eb0dc558052dc8cd6cc33edc04170317c346cdbc","head":{"label":"stbenjam:bye-bye-puppet","ref":"bye-bye-puppet","sha":"eb0dc558052dc8cd6cc33edc04170317c346cdbc","user":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"repo":{"id":14199116,"name":"foreman","full_name":"stbenjam/foreman","owner":{"login":"stbenjam","id":429763,"avatar_url":"https://avatars.githubusercontent.com/u/429763?v=3","gravatar_id":"","url":"https://api.github.com/users/stbenjam","html_url":"https://github.com/stbenjam","followers_url":"https://api.github.com/users/stbenjam/followers","following_url":"https://api.github.com/users/stbenjam/following{/other_user}","gists_url":"https://api.github.com/users/stbenjam/gists{/gist_id}","starred_url":"https://api.github.com/users/stbenjam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stbenjam/subscriptions","organizations_url":"https://api.github.com/users/stbenjam/orgs","repos_url":"https://api.github.com/users/stbenjam/repos","events_url":"https://api.github.com/users/stbenjam/events{/privacy}","received_events_url":"https://api.github.com/users/stbenjam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stbenjam/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/stbenjam/foreman","forks_url":"https://api.github.com/repos/stbenjam/foreman/forks","keys_url":"https://api.github.com/repos/stbenjam/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stbenjam/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stbenjam/foreman/teams","hooks_url":"https://api.github.com/repos/stbenjam/foreman/hooks","issue_events_url":"https://api.github.com/repos/stbenjam/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/stbenjam/foreman/events","assignees_url":"https://api.github.com/repos/stbenjam/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/stbenjam/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/stbenjam/foreman/tags","blobs_url":"https://api.github.com/repos/stbenjam/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stbenjam/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stbenjam/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/stbenjam/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stbenjam/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/stbenjam/foreman/languages","stargazers_url":"https://api.github.com/repos/stbenjam/foreman/stargazers","contributors_url":"https://api.github.com/repos/stbenjam/foreman/contributors","subscribers_url":"https://api.github.com/repos/stbenjam/foreman/subscribers","subscription_url":"https://api.github.com/repos/stbenjam/foreman/subscription","commits_url":"https://api.github.com/repos/stbenjam/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/stbenjam/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/stbenjam/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/stbenjam/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/stbenjam/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/stbenjam/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stbenjam/foreman/merges","archive_url":"https://api.github.com/repos/stbenjam/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stbenjam/foreman/downloads","issues_url":"https://api.github.com/repos/stbenjam/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/stbenjam/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/stbenjam/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/stbenjam/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stbenjam/foreman/labels{/name}","releases_url":"https://api.github.com/repos/stbenjam/foreman/releases{/id}","created_at":"2013-11-07T09:08:03Z","updated_at":"2014-07-17T04:36:45Z","pushed_at":"2015-09-16T13:15:56Z","git_url":"git://github.com/stbenjam/foreman.git","ssh_url":"git@github.com:stbenjam/foreman.git","clone_url":"https://github.com/stbenjam/foreman.git","svn_url":"https://github.com/stbenjam/foreman","homepage":"http://theforeman.org","size":27043,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"69f8931855cccb723625cb3b83008809a37e9ba7","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-09-17T06:05:33Z","pushed_at":"2015-09-17T09:17:45Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":92639,"stargazers_count":851,"watchers_count":851,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":429,"mirror_url":null,"open_issues_count":67,"forks":429,"open_issues":67,"watchers":851,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2726"},"html":{"href":"https://github.com/theforeman/foreman/pull/2726"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2726"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2726/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2726/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2726/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/eb0dc558052dc8cd6cc33edc04170317c346cdbc"}}}}