{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/24729221","id":24729221,"diff_hunk":"@@ -713,52 +712,52 @@ bool overmap::has_note(int const x, int const y, int const z) const\n         return false;\n     }\n \n-    for (auto &i : layer[z + OVERMAP_DEPTH].notes) {","path":"src/overmap.cpp","position":12,"original_position":12,"commit_id":"36ef7f387aa3b766acd04963e8a074a72c659c54","original_commit_id":"36ef7f387aa3b766acd04963e8a074a72c659c54","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"body":"Fair enough. I tend to think that being explicit with a named algorithm is better though.\r\nA wonderful [talk](http://channel9.msdn.com/Events/GoingNative/2013/Cpp-Seasoning) given about a year ago on the matter. A good watch regardless of this particular case.","created_at":"2015-02-16T02:09:42Z","updated_at":"2015-02-16T02:09:42Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11262#discussion_r24729221","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/24729221"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11262#discussion_r24729221"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262","id":29333036,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11262","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11262.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11262.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11262","number":11262,"state":"open","locked":false,"title":"Tidy up a bit and fix a few narrowing warnings","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"body":"**options.h**\r\n+ Flip c-style enum to c++.\r\n+ Remove redundant forward declaration.\r\n\r\n**overmap.***\r\n+ Cleanup note related functions\r\n+ Remove unused field from `om_note`.\r\n+ Remove constructor from `om_note`.\r\n+ Make `nullstr` a function local static.\r\n+ Fix a few narrowing warnings by using an integer multiply then divide.\r\n+ Use in-class initializers for `groundcover_extra`.\r\n+ Use in-class initializers for `regional_settings`.\r\n+ Remove some redundant const.","created_at":"2015-02-15T10:40:12Z","updated_at":"2015-02-16T02:09:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86a747b3982ad9ff69045b7adbd02d72df070fef","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11262/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/36ef7f387aa3b766acd04963e8a074a72c659c54","head":{"label":"bkentel:overmap-tidy-warnings","ref":"overmap-tidy-warnings","sha":"36ef7f387aa3b766acd04963e8a074a72c659c54","user":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"repo":{"id":28679284,"name":"Cataclysm-DDA","full_name":"bkentel/Cataclysm-DDA","owner":{"login":"bkentel","id":780369,"avatar_url":"https://avatars.githubusercontent.com/u/780369?v=3","gravatar_id":"","url":"https://api.github.com/users/bkentel","html_url":"https://github.com/bkentel","followers_url":"https://api.github.com/users/bkentel/followers","following_url":"https://api.github.com/users/bkentel/following{/other_user}","gists_url":"https://api.github.com/users/bkentel/gists{/gist_id}","starred_url":"https://api.github.com/users/bkentel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkentel/subscriptions","organizations_url":"https://api.github.com/users/bkentel/orgs","repos_url":"https://api.github.com/users/bkentel/repos","events_url":"https://api.github.com/users/bkentel/events{/privacy}","received_events_url":"https://api.github.com/users/bkentel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkentel/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/bkentel/Cataclysm-DDA","forks_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/bkentel/Cataclysm-DDA/releases{/id}","created_at":"2015-01-01T02:36:43Z","updated_at":"2015-02-15T14:07:03Z","pushed_at":"2015-02-16T01:43:46Z","git_url":"git://github.com/bkentel/Cataclysm-DDA.git","ssh_url":"git@github.com:bkentel/Cataclysm-DDA.git","clone_url":"https://github.com/bkentel/Cataclysm-DDA.git","svn_url":"https://github.com/bkentel/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":352624,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"28ac4198130a2dcc6bd9a1cef6bde8527ce60212","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/{number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-02-15T22:33:14Z","pushed_at":"2015-02-15T22:33:14Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":425397,"stargazers_count":599,"watchers_count":599,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":647,"mirror_url":null,"open_issues_count":824,"forks":647,"open_issues":824,"watchers":599,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/11262"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11262"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/11262/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/11262/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/36ef7f387aa3b766acd04963e8a074a72c659c54"}}}}