{"action":"created","issue":{"url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/issues/4","labels_url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/issues/4/comments","events_url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/issues/4/events","html_url":"https://github.com/SonarCommunity/sonar-pitest/pull/4","id":58498660,"number":4,"title":"pitest-plugin 1.0 for Sonar 5.0","user":{"login":"gmuecke","id":8408106,"avatar_url":"https://avatars.githubusercontent.com/u/8408106?v=3","gravatar_id":"","url":"https://api.github.com/users/gmuecke","html_url":"https://github.com/gmuecke","followers_url":"https://api.github.com/users/gmuecke/followers","following_url":"https://api.github.com/users/gmuecke/following{/other_user}","gists_url":"https://api.github.com/users/gmuecke/gists{/gist_id}","starred_url":"https://api.github.com/users/gmuecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmuecke/subscriptions","organizations_url":"https://api.github.com/users/gmuecke/orgs","repos_url":"https://api.github.com/users/gmuecke/repos","events_url":"https://api.github.com/users/gmuecke/events{/privacy}","received_events_url":"https://api.github.com/users/gmuecke/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-02-22T10:56:48Z","updated_at":"2015-04-12T21:34:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/pulls/4","html_url":"https://github.com/SonarCommunity/sonar-pitest/pull/4","diff_url":"https://github.com/SonarCommunity/sonar-pitest/pull/4.diff","patch_url":"https://github.com/SonarCommunity/sonar-pitest/pull/4.patch"},"body":"The pull request contains:\r\n- code migrated to sonar api 5.0\r\n- package reorganization\r\n- 20 new rules (+17 for each mutator, +1 for mutation coverage below threshold, +1 for unknown mutant status, +1 for uncovered mutants)\r\n- detail descriptions for each mutator specific rule from PIT\r\n- an updated widget for mutation coverage"},"comment":{"url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/issues/comments/92135971","html_url":"https://github.com/SonarCommunity/sonar-pitest/pull/4#issuecomment-92135971","issue_url":"https://api.github.com/repos/SonarCommunity/sonar-pitest/issues/4","id":92135971,"user":{"login":"gmuecke","id":8408106,"avatar_url":"https://avatars.githubusercontent.com/u/8408106?v=3","gravatar_id":"","url":"https://api.github.com/users/gmuecke","html_url":"https://github.com/gmuecke","followers_url":"https://api.github.com/users/gmuecke/followers","following_url":"https://api.github.com/users/gmuecke/following{/other_user}","gists_url":"https://api.github.com/users/gmuecke/gists{/gist_id}","starred_url":"https://api.github.com/users/gmuecke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmuecke/subscriptions","organizations_url":"https://api.github.com/users/gmuecke/orgs","repos_url":"https://api.github.com/users/gmuecke/repos","events_url":"https://api.github.com/users/gmuecke/events{/privacy}","received_events_url":"https://api.github.com/users/gmuecke/received_events","type":"User","site_admin":false},"created_at":"2015-04-12T21:34:28Z","updated_at":"2015-04-12T21:34:28Z","body":"Hi Alex,\n\nsorry for making such a huge change in on PR, I started playing around with\nthe original code and it led me sort of accidentally to where it is now :)\nBut as it is no gradual change but more of a complete overhaul, I\ndeliberately versioned it 1.0 and you could simply merge it as-is (but of\ncourse, thats up to you).\n\nRegarding the convention starting tests with \"should\"... I usually stick to\nthe generated test-method names and extend them with some param and\nexpected result information where it makes sense. Is it a sonar-community\nconvention? Could you provide me a pointer to where I can find more\ninformation about the sonar coding conventions so I'm better prepared next\ntime?\n\nMost of the tests should have a structure \"prepare\", \"act\", \"assert\" which\nis basically the same as given-when-then (I´m using a template for that\nfrom another project in my default configuration).\nI agree, testing getters and setters is a no-brainer, the reason I usually\ndo it anyway is that I´ve seen it non-implemented returning null in\nproduction code, and its a quick win to get line coverage :)\n\nThanks for your effort!\nGerald\n\nOn Sun, Apr 12, 2015 at 11:01 PM, Alexandre Victoor <\nnotifications@github.com> wrote:\n\n> Thanks Gerald\n> I will quite a lot of work to integrate this pull request.\n> Please next time keep the same conventions already in place in the code.\n> Regarding the tests, there is a convention where each test case is related\n> to a behavior and hence begins with a \"should\". The body of the test is\n> usually split in 3 sections \"given\", \"when\", \"then\".\n> This does not make sens to test getters and setters.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/SonarCommunity/sonar-pitest/pull/4#issuecomment-92126670>\n> .\n>\n"}}