{"action":"created","issue":{"url":"https://api.github.com/repos/windy1/google-places-api-java/issues/30","labels_url":"https://api.github.com/repos/windy1/google-places-api-java/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/windy1/google-places-api-java/issues/30/comments","events_url":"https://api.github.com/repos/windy1/google-places-api-java/issues/30/events","html_url":"https://github.com/windy1/google-places-api-java/pull/30","id":76077537,"number":30,"title":"Implementing hashcode, equals, getters on Param, adding test coverage, testability","user":{"login":"jameskbride","id":1082328,"avatar_url":"https://avatars.githubusercontent.com/u/1082328?v=3","gravatar_id":"","url":"https://api.github.com/users/jameskbride","html_url":"https://github.com/jameskbride","followers_url":"https://api.github.com/users/jameskbride/followers","following_url":"https://api.github.com/users/jameskbride/following{/other_user}","gists_url":"https://api.github.com/users/jameskbride/gists{/gist_id}","starred_url":"https://api.github.com/users/jameskbride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameskbride/subscriptions","organizations_url":"https://api.github.com/users/jameskbride/orgs","repos_url":"https://api.github.com/users/jameskbride/repos","events_url":"https://api.github.com/users/jameskbride/events{/privacy}","received_events_url":"https://api.github.com/users/jameskbride/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-13T18:23:31Z","updated_at":"2015-05-19T00:19:04Z","closed_at":"2015-05-19T00:19:04Z","pull_request":{"url":"https://api.github.com/repos/windy1/google-places-api-java/pulls/30","html_url":"https://github.com/windy1/google-places-api-java/pull/30","diff_url":"https://github.com/windy1/google-places-api-java/pull/30.diff","patch_url":"https://github.com/windy1/google-places-api-java/pull/30.patch"},"body":"Hi Walker,\r\n\r\nI wanted to suggest a few changes for consistency and testing purposes.  \r\n1. Implementing hashcode, equals on Param\r\n2. Adding getters to Param for accessibility, testing\r\n3. Adding additional test coverage (for these changes)\r\n4. Making a number of protected methods public for accessibility\r\n\r\nI introduced these in my own fork a couple of months ago and I've been using them since with no problems.  My primary reason for doing so was to be able to test around the library.  Let me know what you think and get back to me when you can.\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/windy1/google-places-api-java/issues/comments/103279605","html_url":"https://github.com/windy1/google-places-api-java/pull/30#issuecomment-103279605","issue_url":"https://api.github.com/repos/windy1/google-places-api-java/issues/30","id":103279605,"user":{"login":"jameskbride","id":1082328,"avatar_url":"https://avatars.githubusercontent.com/u/1082328?v=3","gravatar_id":"","url":"https://api.github.com/users/jameskbride","html_url":"https://github.com/jameskbride","followers_url":"https://api.github.com/users/jameskbride/followers","following_url":"https://api.github.com/users/jameskbride/following{/other_user}","gists_url":"https://api.github.com/users/jameskbride/gists{/gist_id}","starred_url":"https://api.github.com/users/jameskbride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameskbride/subscriptions","organizations_url":"https://api.github.com/users/jameskbride/orgs","repos_url":"https://api.github.com/users/jameskbride/repos","events_url":"https://api.github.com/users/jameskbride/events{/privacy}","received_events_url":"https://api.github.com/users/jameskbride/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T00:19:04Z","updated_at":"2015-05-19T00:19:04Z","body":"Hi @windy1, apologies for a half-baked pull request.  Regarding the first part from a few days ago see the notes above.  The second part allows an arbitrary API url to be passed in, with the hopes that we could make a server-side call to Google Places from a client without exposing the API key in the params. To secure the call to the server though we would need to have some other security mechanism in place, such as OAuth2, etc.  \r\n\r\nLet me know what you think about the security aspects of this project.  In the meantime I'm going to close this pull request.  \r\n\r\nThanks."}}