{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments/47855088","id":47855088,"diff_hunk":"@@ -2,6 +2,10 @@\n All notable changes to this project will be documented in this file.\n This project adheres to [Semantic Versioning](http://semver.org/).\n \n+## [0.3.2] - 2015-12-16\n+\n+- The `windows` library incorrectly used `target_link_libraryes` instead of `add_leatherman_deps`","path":"CHANGELOG.md","position":6,"original_position":6,"commit_id":"aa7bc37d66ed44ecc9c1fba823809fed49ac58b0","original_commit_id":"aa7bc37d66ed44ecc9c1fba823809fed49ac58b0","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Also please add a `### Fixed` subsection.","created_at":"2015-12-17T00:32:01Z","updated_at":"2015-12-17T00:32:01Z","html_url":"https://github.com/puppetlabs/leatherman/pull/119#discussion_r47855088","pull_request_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments/47855088"},"html":{"href":"https://github.com/puppetlabs/leatherman/pull/119#discussion_r47855088"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119","id":53918629,"html_url":"https://github.com/puppetlabs/leatherman/pull/119","diff_url":"https://github.com/puppetlabs/leatherman/pull/119.diff","patch_url":"https://github.com/puppetlabs/leatherman/pull/119.patch","issue_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/119","number":119,"state":"open","locked":false,"title":"(maint) Use leatherman_deps instead of target_link_libraries in windows","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"body":"target_link_libraries will cause failures when leatherman projects are\r\npulled in via find_package.","created_at":"2015-12-17T00:19:01Z","updated_at":"2015-12-17T00:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4cc25f9ce8e3f6fd4347f537acbec46a07f2e2bf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/119/comments","statuses_url":"https://api.github.com/repos/puppetlabs/leatherman/statuses/aa7bc37d66ed44ecc9c1fba823809fed49ac58b0","head":{"label":"branan:main/master/windows_link","ref":"main/master/windows_link","sha":"aa7bc37d66ed44ecc9c1fba823809fed49ac58b0","user":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"repo":{"id":31233779,"name":"leatherman","full_name":"branan/leatherman","owner":{"login":"branan","id":37594,"avatar_url":"https://avatars.githubusercontent.com/u/37594?v=3","gravatar_id":"","url":"https://api.github.com/users/branan","html_url":"https://github.com/branan","followers_url":"https://api.github.com/users/branan/followers","following_url":"https://api.github.com/users/branan/following{/other_user}","gists_url":"https://api.github.com/users/branan/gists{/gist_id}","starred_url":"https://api.github.com/users/branan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/branan/subscriptions","organizations_url":"https://api.github.com/users/branan/orgs","repos_url":"https://api.github.com/users/branan/repos","events_url":"https://api.github.com/users/branan/events{/privacy}","received_events_url":"https://api.github.com/users/branan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/branan/leatherman","description":"","fork":true,"url":"https://api.github.com/repos/branan/leatherman","forks_url":"https://api.github.com/repos/branan/leatherman/forks","keys_url":"https://api.github.com/repos/branan/leatherman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/branan/leatherman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/branan/leatherman/teams","hooks_url":"https://api.github.com/repos/branan/leatherman/hooks","issue_events_url":"https://api.github.com/repos/branan/leatherman/issues/events{/number}","events_url":"https://api.github.com/repos/branan/leatherman/events","assignees_url":"https://api.github.com/repos/branan/leatherman/assignees{/user}","branches_url":"https://api.github.com/repos/branan/leatherman/branches{/branch}","tags_url":"https://api.github.com/repos/branan/leatherman/tags","blobs_url":"https://api.github.com/repos/branan/leatherman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/branan/leatherman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/branan/leatherman/git/refs{/sha}","trees_url":"https://api.github.com/repos/branan/leatherman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/branan/leatherman/statuses/{sha}","languages_url":"https://api.github.com/repos/branan/leatherman/languages","stargazers_url":"https://api.github.com/repos/branan/leatherman/stargazers","contributors_url":"https://api.github.com/repos/branan/leatherman/contributors","subscribers_url":"https://api.github.com/repos/branan/leatherman/subscribers","subscription_url":"https://api.github.com/repos/branan/leatherman/subscription","commits_url":"https://api.github.com/repos/branan/leatherman/commits{/sha}","git_commits_url":"https://api.github.com/repos/branan/leatherman/git/commits{/sha}","comments_url":"https://api.github.com/repos/branan/leatherman/comments{/number}","issue_comment_url":"https://api.github.com/repos/branan/leatherman/issues/comments{/number}","contents_url":"https://api.github.com/repos/branan/leatherman/contents/{+path}","compare_url":"https://api.github.com/repos/branan/leatherman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/branan/leatherman/merges","archive_url":"https://api.github.com/repos/branan/leatherman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/branan/leatherman/downloads","issues_url":"https://api.github.com/repos/branan/leatherman/issues{/number}","pulls_url":"https://api.github.com/repos/branan/leatherman/pulls{/number}","milestones_url":"https://api.github.com/repos/branan/leatherman/milestones{/number}","notifications_url":"https://api.github.com/repos/branan/leatherman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/branan/leatherman/labels{/name}","releases_url":"https://api.github.com/repos/branan/leatherman/releases{/id}","created_at":"2015-02-23T22:40:25Z","updated_at":"2015-12-10T17:35:21Z","pushed_at":"2015-12-17T00:27:38Z","git_url":"git://github.com/branan/leatherman.git","ssh_url":"git@github.com:branan/leatherman.git","clone_url":"https://github.com/branan/leatherman.git","svn_url":"https://github.com/branan/leatherman","homepage":null,"size":670,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"329d23aae501ffed751e638407e0c3aaa4b55af2","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":31226286,"name":"leatherman","full_name":"puppetlabs/leatherman","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/leatherman","description":"A collection of C++ and CMake utility libraries.","fork":false,"url":"https://api.github.com/repos/puppetlabs/leatherman","forks_url":"https://api.github.com/repos/puppetlabs/leatherman/forks","keys_url":"https://api.github.com/repos/puppetlabs/leatherman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/leatherman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/leatherman/teams","hooks_url":"https://api.github.com/repos/puppetlabs/leatherman/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/leatherman/events","assignees_url":"https://api.github.com/repos/puppetlabs/leatherman/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/leatherman/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/leatherman/tags","blobs_url":"https://api.github.com/repos/puppetlabs/leatherman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/leatherman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/leatherman/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/leatherman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/leatherman/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/leatherman/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/leatherman/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/leatherman/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/leatherman/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/leatherman/subscription","commits_url":"https://api.github.com/repos/puppetlabs/leatherman/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/leatherman/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/leatherman/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/leatherman/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/leatherman/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/leatherman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/leatherman/merges","archive_url":"https://api.github.com/repos/puppetlabs/leatherman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/leatherman/downloads","issues_url":"https://api.github.com/repos/puppetlabs/leatherman/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/leatherman/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/leatherman/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/leatherman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/leatherman/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/leatherman/releases{/id}","created_at":"2015-02-23T19:50:46Z","updated_at":"2015-10-08T21:55:05Z","pushed_at":"2015-12-17T00:27:38Z","git_url":"git://github.com/puppetlabs/leatherman.git","ssh_url":"git@github.com:puppetlabs/leatherman.git","clone_url":"https://github.com/puppetlabs/leatherman.git","svn_url":"https://github.com/puppetlabs/leatherman","homepage":"","size":803,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119"},"html":{"href":"https://github.com/puppetlabs/leatherman/pull/119"},"issue":{"href":"https://api.github.com/repos/puppetlabs/leatherman/issues/119"},"comments":{"href":"https://api.github.com/repos/puppetlabs/leatherman/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/leatherman/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/leatherman/statuses/aa7bc37d66ed44ecc9c1fba823809fed49ac58b0"}}}}