{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/35273973","id":35273973,"diff_hunk":"@@ -1,5 +1,86 @@\n #!/usr/bin/env bash\n \n+# copy of corefx/build.sh from here\n+\n+__scriptpath=$(cd \"$(dirname \"$0\")\"; pwd -P)\n+__packageroot=$__scriptpath/packages\n+__sourceroot=$__scriptpath/src\n+__nugetpath=$__packageroot/NuGet.exe\n+__nugetconfig=$__sourceroot/NuGet.Config\n+__msbuildpackageid=\"Microsoft.Build.Mono.Debug\"\n+__msbuildpackageversion=\"14.1.0.0-prerelease\"\n+__msbuildpath=$__packageroot/$__msbuildpackageid.$__msbuildpackageversion/lib/MSBuild.exe\n+__resgenpackageid=\"Mono.Tools.ResgenModified\"\n+__resgenpackageversion=\"1.0.0\"\n+__resgenpath=$__packageroot/$__resgenpackageid.$__resgenpackageversion/tools/resgen.exe\n+\n+if [ $(uname) == \"Linux\" ]; then\n+    __monoroot=/devel","path":"build.sh","position":18,"original_position":18,"commit_id":"323c123b5e66a9e26f26965426f8c49c5a235ae8","original_commit_id":"323c123b5e66a9e26f26965426f8c49c5a235ae8","user":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars.githubusercontent.com/u/53929?v=3","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"body":"oops, yes. Thanks.","created_at":"2015-07-22T22:51:58Z","updated_at":"2015-07-22T22:51:58Z","html_url":"https://github.com/dotnet/coreclr/pull/1275#discussion_r35273973","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1275","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/35273973"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1275#discussion_r35273973"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1275"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/1275","id":40607729,"html_url":"https://github.com/dotnet/coreclr/pull/1275","diff_url":"https://github.com/dotnet/coreclr/pull/1275.diff","patch_url":"https://github.com/dotnet/coreclr/pull/1275.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/1275","number":1275,"state":"open","locked":false,"title":"Add support for mscorlib.dll build on Unix.","user":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars.githubusercontent.com/u/53929?v=3","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"body":"Rationale: mscorlib.dll does not build outside Windows yet.\r\nhttps://github.com/dotnet/coreclr/blob/8d3936b/Documentation/building/linux-instructions.md#build-the-framework-\r\n\r\nThis change removes the limitation.\r\n\r\nBasically it does what corefx does on Unix. It pulls MSBuild package\r\nfrom myget and use it to build mscorlib.dll.\r\n\r\nSome additional notes:\r\n\r\n- Mono (as of 4.0/4.2) does not support resgen -d option. So I created\r\n  a patched version that supports it.\r\n- Then I have created NuGet package for that resgen.exe so that we don't\r\n  have to wait for Mono bugfix for above. Just like the custom MSBuild\r\n  that corefx uses, it now uses the packaged resgen.exe.\r\n  (src/mscorlib/GenerateSplitStringResources.targets takes ResGenCommand\r\n  custom build property, so I pass it to msbuild run.)\r\n- BclRewriter.exe does not work outside Windows yet, so there are some\r\n  build targets file hacks that makes it conditional to non-Unix OS.\r\n- Similarly, there is call to rc.exe. It could be disabled by passing\r\n  /p:GenerateNativeVersionInfo=false to msbuild.\r\n- Pdb generation is not working on Unix (PdbWriter depends on COM stuff)\r\n  so I disabled any relevant parts by adding MSBuild condition.\r\n- NuGet packaging fails due to incomplete set of files (e.g. pdb), so\r\n  it is also skipped by MSBuild condition.","created_at":"2015-07-22T20:27:17Z","updated_at":"2015-07-22T22:51:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e32b28d7f09f3523ff2de00d7ef9609af2984ef4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1275/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1275/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/1275/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/323c123b5e66a9e26f26965426f8c49c5a235ae8","head":{"label":"atsushieno:support-unix-mscorlib-build","ref":"support-unix-mscorlib-build","sha":"323c123b5e66a9e26f26965426f8c49c5a235ae8","user":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars.githubusercontent.com/u/53929?v=3","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"repo":{"id":39442966,"name":"coreclr","full_name":"atsushieno/coreclr","owner":{"login":"atsushieno","id":53929,"avatar_url":"https://avatars.githubusercontent.com/u/53929?v=3","gravatar_id":"","url":"https://api.github.com/users/atsushieno","html_url":"https://github.com/atsushieno","followers_url":"https://api.github.com/users/atsushieno/followers","following_url":"https://api.github.com/users/atsushieno/following{/other_user}","gists_url":"https://api.github.com/users/atsushieno/gists{/gist_id}","starred_url":"https://api.github.com/users/atsushieno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsushieno/subscriptions","organizations_url":"https://api.github.com/users/atsushieno/orgs","repos_url":"https://api.github.com/users/atsushieno/repos","events_url":"https://api.github.com/users/atsushieno/events{/privacy}","received_events_url":"https://api.github.com/users/atsushieno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atsushieno/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/atsushieno/coreclr","forks_url":"https://api.github.com/repos/atsushieno/coreclr/forks","keys_url":"https://api.github.com/repos/atsushieno/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atsushieno/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atsushieno/coreclr/teams","hooks_url":"https://api.github.com/repos/atsushieno/coreclr/hooks","issue_events_url":"https://api.github.com/repos/atsushieno/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/atsushieno/coreclr/events","assignees_url":"https://api.github.com/repos/atsushieno/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/atsushieno/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/atsushieno/coreclr/tags","blobs_url":"https://api.github.com/repos/atsushieno/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atsushieno/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atsushieno/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/atsushieno/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atsushieno/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/atsushieno/coreclr/languages","stargazers_url":"https://api.github.com/repos/atsushieno/coreclr/stargazers","contributors_url":"https://api.github.com/repos/atsushieno/coreclr/contributors","subscribers_url":"https://api.github.com/repos/atsushieno/coreclr/subscribers","subscription_url":"https://api.github.com/repos/atsushieno/coreclr/subscription","commits_url":"https://api.github.com/repos/atsushieno/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/atsushieno/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/atsushieno/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/atsushieno/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/atsushieno/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/atsushieno/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atsushieno/coreclr/merges","archive_url":"https://api.github.com/repos/atsushieno/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atsushieno/coreclr/downloads","issues_url":"https://api.github.com/repos/atsushieno/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/atsushieno/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/atsushieno/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/atsushieno/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atsushieno/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/atsushieno/coreclr/releases{/id}","created_at":"2015-07-21T12:03:50Z","updated_at":"2015-07-21T12:04:29Z","pushed_at":"2015-07-22T20:26:37Z","git_url":"git://github.com/atsushieno/coreclr.git","ssh_url":"git@github.com:atsushieno/coreclr.git","clone_url":"https://github.com/atsushieno/coreclr.git","svn_url":"https://github.com/atsushieno/coreclr","homepage":"http://dotnet.github.io/core/","size":35637,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"d7aff0c9c00d3595fb3d437fd6171dd4ee187a3d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-07-22T20:22:50Z","pushed_at":"2015-07-22T21:26:09Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/core/","size":54738,"stargazers_count":4892,"watchers_count":4892,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":966,"mirror_url":null,"open_issues_count":216,"forks":966,"open_issues":216,"watchers":4892,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1275"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1275"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1275"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1275/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1275/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1275/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/323c123b5e66a9e26f26965426f8c49c5a235ae8"}}}}