{"action":"created","comment":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/comments/33094330","id":33094330,"diff_hunk":"@@ -406,8 +406,19 @@ def render_function(class_name, func_name, sigs, return_type, non_pointer, copy,\n   if not js_impl: continue\n   implements[name] = [js_impl[0]]\n \n+nodeHeight = {}\n+for child, parent in implements.iteritems():","path":"tools/webidl_binder.py","position":5,"original_position":5,"commit_id":"926fee089df348ab8f4434cb0ababdb3cf1a9ceb","original_commit_id":"926fee089df348ab8f4434cb0ababdb3cf1a9ceb","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"body":"this depends on the order of iteration, doesn't it? or is there some reason that this order is guaranteed to be correct? (i.e., `nodeHeight.get` might succeed or fail based on the order)","created_at":"2015-06-23T21:23:36Z","updated_at":"2015-06-23T21:23:36Z","html_url":"https://github.com/kripken/emscripten/pull/3564#discussion_r33094330","pull_request_url":"https://api.github.com/repos/kripken/emscripten/pulls/3564","_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments/33094330"},"html":{"href":"https://github.com/kripken/emscripten/pull/3564#discussion_r33094330"},"pull_request":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3564"}}},"pull_request":{"url":"https://api.github.com/repos/kripken/emscripten/pulls/3564","id":38357736,"html_url":"https://github.com/kripken/emscripten/pull/3564","diff_url":"https://github.com/kripken/emscripten/pull/3564.diff","patch_url":"https://github.com/kripken/emscripten/pull/3564.patch","issue_url":"https://api.github.com/repos/kripken/emscripten/issues/3564","number":3564,"state":"open","locked":false,"title":"Fix broken sort() algorithm.","user":{"login":"mlogan","id":708638,"avatar_url":"https://avatars.githubusercontent.com/u/708638?v=3","gravatar_id":"","url":"https://api.github.com/users/mlogan","html_url":"https://github.com/mlogan","followers_url":"https://api.github.com/users/mlogan/followers","following_url":"https://api.github.com/users/mlogan/following{/other_user}","gists_url":"https://api.github.com/users/mlogan/gists{/gist_id}","starred_url":"https://api.github.com/users/mlogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlogan/subscriptions","organizations_url":"https://api.github.com/users/mlogan/orgs","repos_url":"https://api.github.com/users/mlogan/repos","events_url":"https://api.github.com/users/mlogan/events{/privacy}","received_events_url":"https://api.github.com/users/mlogan/received_events","type":"User","site_admin":false},"body":"We didn't notice this forever because we were inadvertently putting two copies of our js glue into our build. (The first copy satisfied all dependencies of the second copy.)","created_at":"2015-06-23T16:45:30Z","updated_at":"2015-06-23T21:23:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c36b820c8c732938d51b136e0ffb88d0328636c7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kripken/emscripten/pulls/3564/commits","review_comments_url":"https://api.github.com/repos/kripken/emscripten/pulls/3564/comments","review_comment_url":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kripken/emscripten/issues/3564/comments","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/926fee089df348ab8f4434cb0ababdb3cf1a9ceb","head":{"label":"artillery:incoming","ref":"incoming","sha":"926fee089df348ab8f4434cb0ababdb3cf1a9ceb","user":{"login":"artillery","id":1179961,"avatar_url":"https://avatars.githubusercontent.com/u/1179961?v=3","gravatar_id":"","url":"https://api.github.com/users/artillery","html_url":"https://github.com/artillery","followers_url":"https://api.github.com/users/artillery/followers","following_url":"https://api.github.com/users/artillery/following{/other_user}","gists_url":"https://api.github.com/users/artillery/gists{/gist_id}","starred_url":"https://api.github.com/users/artillery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artillery/subscriptions","organizations_url":"https://api.github.com/users/artillery/orgs","repos_url":"https://api.github.com/users/artillery/repos","events_url":"https://api.github.com/users/artillery/events{/privacy}","received_events_url":"https://api.github.com/users/artillery/received_events","type":"Organization","site_admin":false},"repo":{"id":22549488,"name":"emscripten","full_name":"artillery/emscripten","owner":{"login":"artillery","id":1179961,"avatar_url":"https://avatars.githubusercontent.com/u/1179961?v=3","gravatar_id":"","url":"https://api.github.com/users/artillery","html_url":"https://github.com/artillery","followers_url":"https://api.github.com/users/artillery/followers","following_url":"https://api.github.com/users/artillery/following{/other_user}","gists_url":"https://api.github.com/users/artillery/gists{/gist_id}","starred_url":"https://api.github.com/users/artillery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artillery/subscriptions","organizations_url":"https://api.github.com/users/artillery/orgs","repos_url":"https://api.github.com/users/artillery/repos","events_url":"https://api.github.com/users/artillery/events{/privacy}","received_events_url":"https://api.github.com/users/artillery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/artillery/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":true,"url":"https://api.github.com/repos/artillery/emscripten","forks_url":"https://api.github.com/repos/artillery/emscripten/forks","keys_url":"https://api.github.com/repos/artillery/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artillery/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artillery/emscripten/teams","hooks_url":"https://api.github.com/repos/artillery/emscripten/hooks","issue_events_url":"https://api.github.com/repos/artillery/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/artillery/emscripten/events","assignees_url":"https://api.github.com/repos/artillery/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/artillery/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/artillery/emscripten/tags","blobs_url":"https://api.github.com/repos/artillery/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artillery/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artillery/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/artillery/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artillery/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/artillery/emscripten/languages","stargazers_url":"https://api.github.com/repos/artillery/emscripten/stargazers","contributors_url":"https://api.github.com/repos/artillery/emscripten/contributors","subscribers_url":"https://api.github.com/repos/artillery/emscripten/subscribers","subscription_url":"https://api.github.com/repos/artillery/emscripten/subscription","commits_url":"https://api.github.com/repos/artillery/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/artillery/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/artillery/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/artillery/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/artillery/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/artillery/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artillery/emscripten/merges","archive_url":"https://api.github.com/repos/artillery/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artillery/emscripten/downloads","issues_url":"https://api.github.com/repos/artillery/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/artillery/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/artillery/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/artillery/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artillery/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/artillery/emscripten/releases{/id}","created_at":"2014-08-02T15:58:54Z","updated_at":"2015-04-22T21:11:37Z","pushed_at":"2015-06-23T16:44:09Z","git_url":"git://github.com/artillery/emscripten.git","ssh_url":"git@github.com:artillery/emscripten.git","clone_url":"https://github.com/artillery/emscripten.git","svn_url":"https://github.com/artillery/emscripten","homepage":"","size":128203,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kripken:incoming","ref":"incoming","sha":"7646de854015569564e0e0d9f646c96968c5b2cc","user":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"repo":{"id":1357796,"name":"emscripten","full_name":"kripken/emscripten","owner":{"login":"kripken","id":173661,"avatar_url":"https://avatars.githubusercontent.com/u/173661?v=3","gravatar_id":"","url":"https://api.github.com/users/kripken","html_url":"https://github.com/kripken","followers_url":"https://api.github.com/users/kripken/followers","following_url":"https://api.github.com/users/kripken/following{/other_user}","gists_url":"https://api.github.com/users/kripken/gists{/gist_id}","starred_url":"https://api.github.com/users/kripken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripken/subscriptions","organizations_url":"https://api.github.com/users/kripken/orgs","repos_url":"https://api.github.com/users/kripken/repos","events_url":"https://api.github.com/users/kripken/events{/privacy}","received_events_url":"https://api.github.com/users/kripken/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kripken/emscripten","description":"Emscripten: An LLVM-to-JavaScript Compiler","fork":false,"url":"https://api.github.com/repos/kripken/emscripten","forks_url":"https://api.github.com/repos/kripken/emscripten/forks","keys_url":"https://api.github.com/repos/kripken/emscripten/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kripken/emscripten/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kripken/emscripten/teams","hooks_url":"https://api.github.com/repos/kripken/emscripten/hooks","issue_events_url":"https://api.github.com/repos/kripken/emscripten/issues/events{/number}","events_url":"https://api.github.com/repos/kripken/emscripten/events","assignees_url":"https://api.github.com/repos/kripken/emscripten/assignees{/user}","branches_url":"https://api.github.com/repos/kripken/emscripten/branches{/branch}","tags_url":"https://api.github.com/repos/kripken/emscripten/tags","blobs_url":"https://api.github.com/repos/kripken/emscripten/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kripken/emscripten/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kripken/emscripten/git/refs{/sha}","trees_url":"https://api.github.com/repos/kripken/emscripten/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kripken/emscripten/statuses/{sha}","languages_url":"https://api.github.com/repos/kripken/emscripten/languages","stargazers_url":"https://api.github.com/repos/kripken/emscripten/stargazers","contributors_url":"https://api.github.com/repos/kripken/emscripten/contributors","subscribers_url":"https://api.github.com/repos/kripken/emscripten/subscribers","subscription_url":"https://api.github.com/repos/kripken/emscripten/subscription","commits_url":"https://api.github.com/repos/kripken/emscripten/commits{/sha}","git_commits_url":"https://api.github.com/repos/kripken/emscripten/git/commits{/sha}","comments_url":"https://api.github.com/repos/kripken/emscripten/comments{/number}","issue_comment_url":"https://api.github.com/repos/kripken/emscripten/issues/comments{/number}","contents_url":"https://api.github.com/repos/kripken/emscripten/contents/{+path}","compare_url":"https://api.github.com/repos/kripken/emscripten/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kripken/emscripten/merges","archive_url":"https://api.github.com/repos/kripken/emscripten/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kripken/emscripten/downloads","issues_url":"https://api.github.com/repos/kripken/emscripten/issues{/number}","pulls_url":"https://api.github.com/repos/kripken/emscripten/pulls{/number}","milestones_url":"https://api.github.com/repos/kripken/emscripten/milestones{/number}","notifications_url":"https://api.github.com/repos/kripken/emscripten/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kripken/emscripten/labels{/name}","releases_url":"https://api.github.com/repos/kripken/emscripten/releases{/id}","created_at":"2011-02-12T05:23:30Z","updated_at":"2015-06-23T18:31:25Z","pushed_at":"2015-06-23T19:44:56Z","git_url":"git://github.com/kripken/emscripten.git","ssh_url":"git@github.com:kripken/emscripten.git","clone_url":"https://github.com/kripken/emscripten.git","svn_url":"https://github.com/kripken/emscripten","homepage":"","size":243019,"stargazers_count":8480,"watchers_count":8480,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":979,"mirror_url":null,"open_issues_count":628,"forks":979,"open_issues":628,"watchers":8480,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3564"},"html":{"href":"https://github.com/kripken/emscripten/pull/3564"},"issue":{"href":"https://api.github.com/repos/kripken/emscripten/issues/3564"},"comments":{"href":"https://api.github.com/repos/kripken/emscripten/issues/3564/comments"},"review_comments":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3564/comments"},"review_comment":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kripken/emscripten/pulls/3564/commits"},"statuses":{"href":"https://api.github.com/repos/kripken/emscripten/statuses/926fee089df348ab8f4434cb0ababdb3cf1a9ceb"}}}}