{"action":"created","issue":{"url":"https://api.github.com/repos/ExCiteS/geokey/issues/327","labels_url":"https://api.github.com/repos/ExCiteS/geokey/issues/327/labels{/name}","comments_url":"https://api.github.com/repos/ExCiteS/geokey/issues/327/comments","events_url":"https://api.github.com/repos/ExCiteS/geokey/issues/327/events","html_url":"https://github.com/ExCiteS/geokey/pull/327","id":122021244,"number":327,"title":"Allow Observations with null/None location.","user":{"login":"mstevens83","id":2787305,"avatar_url":"https://avatars.githubusercontent.com/u/2787305?v=3","gravatar_id":"","url":"https://api.github.com/users/mstevens83","html_url":"https://github.com/mstevens83","followers_url":"https://api.github.com/users/mstevens83/followers","following_url":"https://api.github.com/users/mstevens83/following{/other_user}","gists_url":"https://api.github.com/users/mstevens83/gists{/gist_id}","starred_url":"https://api.github.com/users/mstevens83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstevens83/subscriptions","organizations_url":"https://api.github.com/users/mstevens83/orgs","repos_url":"https://api.github.com/users/mstevens83/repos","events_url":"https://api.github.com/users/mstevens83/events{/privacy}","received_events_url":"https://api.github.com/users/mstevens83/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ExCiteS/geokey/labels/design","name":"design","color":"207de5"},{"url":"https://api.github.com/repos/ExCiteS/geokey/labels/discussion","name":"discussion","color":"f7c6c7"},{"url":"https://api.github.com/repos/ExCiteS/geokey/labels/enhancement","name":"enhancement","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-14T11:06:38Z","updated_at":"2015-12-14T11:19:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ExCiteS/geokey/pulls/327","html_url":"https://github.com/ExCiteS/geokey/pull/327","diff_url":"https://github.com/ExCiteS/geokey/pull/327.diff","patch_url":"https://github.com/ExCiteS/geokey/pull/327.patch"},"body":"Potentially breaking, but all tests pass.\r\n\r\nMore investigation and discussion needed..."},"comment":{"url":"https://api.github.com/repos/ExCiteS/geokey/issues/comments/164412956","html_url":"https://github.com/ExCiteS/geokey/pull/327#issuecomment-164412956","issue_url":"https://api.github.com/repos/ExCiteS/geokey/issues/327","id":164412956,"user":{"login":"mstevens83","id":2787305,"avatar_url":"https://avatars.githubusercontent.com/u/2787305?v=3","gravatar_id":"","url":"https://api.github.com/users/mstevens83","html_url":"https://github.com/mstevens83","followers_url":"https://api.github.com/users/mstevens83/followers","following_url":"https://api.github.com/users/mstevens83/following{/other_user}","gists_url":"https://api.github.com/users/mstevens83/gists{/gist_id}","starred_url":"https://api.github.com/users/mstevens83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstevens83/subscriptions","organizations_url":"https://api.github.com/users/mstevens83/orgs","repos_url":"https://api.github.com/users/mstevens83/repos","events_url":"https://api.github.com/users/mstevens83/events{/privacy}","received_events_url":"https://api.github.com/users/mstevens83/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T11:19:12Z","updated_at":"2015-12-14T11:19:12Z","body":"I'm copy-pasting @oliverroick's opinion (from e-mail):\r\n> Have you written tests for the contribution serialiser to test serialisation with null locations, both getting data in and out. I think there might be some issues. I think there are some test cases for writing null locations. Make sure that data is actually written to the database when you provide a null location. I'm pretty sure that GeoKey raises an exception, unless you removed that part already. \r\n> For extensions, the only one that might be affected by this could be geokey-export. I'm quite certain, that things will break when you throw a null location at it.\r\n> As a general rule, I would check anything that reads data from GeoKey: geokey-epicollect (thought that was supposed to be discontinued after Cyberlab is finished), geokey-export and Community Maps. These should all have a strategy to deal with null locations. For writing data, I don't see any issues. They are all build to provide a location, so nothing changes from their perspective.\r\n"}}