{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/comments/41962717","id":41962717,"diff_hunk":"@@ -505,9 +529,22 @@ YUI.add('bundle-importer', function(Y) {\n         move on to the next record.\n     */\n     _execute_addUnit: function(record, next) {\n+      var serviceId, charmUrl, size, name;\n+      // The bundlelib no longer returns the same format as required by the\n+      // GUI's add_unit env method so this re-maps the arguments so that they\n+      // match.\n+      // If the length is longer than 2 then it's still using the old format\n+      // which includes the matching args.\n+      // XXX This can be removed once the bundlelib has been updated across\n+      // all platforms.\n+      if (record.args.length === 2) {\n+        // Move the machine placement to the third argument spot.","path":"jujugui/static/gui/src/app/utils/bundle-importer.js","position":71,"original_position":71,"commit_id":"4945f0c0363380722a82ff1605c9f6406014179c","original_commit_id":"4945f0c0363380722a82ff1605c9f6406014179c","user":{"login":"frankban","id":1408172,"avatar_url":"https://avatars.githubusercontent.com/u/1408172?v=3","gravatar_id":"","url":"https://api.github.com/users/frankban","html_url":"https://github.com/frankban","followers_url":"https://api.github.com/users/frankban/followers","following_url":"https://api.github.com/users/frankban/following{/other_user}","gists_url":"https://api.github.com/users/frankban/gists{/gist_id}","starred_url":"https://api.github.com/users/frankban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankban/subscriptions","organizations_url":"https://api.github.com/users/frankban/orgs","repos_url":"https://api.github.com/users/frankban/repos","events_url":"https://api.github.com/users/frankban/events{/privacy}","received_events_url":"https://api.github.com/users/frankban/received_events","type":"User","site_admin":false},"body":"Thanks for these comments.","created_at":"2015-10-14T07:32:47Z","updated_at":"2015-10-14T07:32:47Z","html_url":"https://github.com/juju/juju-gui/pull/896#discussion_r41962717","pull_request_url":"https://api.github.com/repos/juju/juju-gui/pulls/896","_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments/41962717"},"html":{"href":"https://github.com/juju/juju-gui/pull/896#discussion_r41962717"},"pull_request":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/896"}}},"pull_request":{"url":"https://api.github.com/repos/juju/juju-gui/pulls/896","id":47602291,"html_url":"https://github.com/juju/juju-gui/pull/896","diff_url":"https://github.com/juju/juju-gui/pull/896.diff","patch_url":"https://github.com/juju/juju-gui/pull/896.patch","issue_url":"https://api.github.com/repos/juju/juju-gui/issues/896","number":896,"state":"open","locked":false,"title":"Update changeset format","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?v=3","gravatar_id":"","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"body":"The bundlelib changeset format was modified so these modifications are now supported in the GUI. The GUI supports both the new and old format although the old format will be deprecated soon.","created_at":"2015-10-13T23:34:13Z","updated_at":"2015-10-14T07:32:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dc0c492f6408e65b4a69b64212661ee94b89d44d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju-gui/pulls/896/commits","review_comments_url":"https://api.github.com/repos/juju/juju-gui/pulls/896/comments","review_comment_url":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju-gui/issues/896/comments","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/4945f0c0363380722a82ff1605c9f6406014179c","head":{"label":"hatched:update-changeset-format","ref":"update-changeset-format","sha":"4945f0c0363380722a82ff1605c9f6406014179c","user":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?v=3","gravatar_id":"","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"repo":{"id":14962756,"name":"juju-gui","full_name":"hatched/juju-gui","owner":{"login":"hatched","id":532033,"avatar_url":"https://avatars.githubusercontent.com/u/532033?v=3","gravatar_id":"","url":"https://api.github.com/users/hatched","html_url":"https://github.com/hatched","followers_url":"https://api.github.com/users/hatched/followers","following_url":"https://api.github.com/users/hatched/following{/other_user}","gists_url":"https://api.github.com/users/hatched/gists{/gist_id}","starred_url":"https://api.github.com/users/hatched/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hatched/subscriptions","organizations_url":"https://api.github.com/users/hatched/orgs","repos_url":"https://api.github.com/users/hatched/repos","events_url":"https://api.github.com/users/hatched/events{/privacy}","received_events_url":"https://api.github.com/users/hatched/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hatched/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":true,"url":"https://api.github.com/repos/hatched/juju-gui","forks_url":"https://api.github.com/repos/hatched/juju-gui/forks","keys_url":"https://api.github.com/repos/hatched/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hatched/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hatched/juju-gui/teams","hooks_url":"https://api.github.com/repos/hatched/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/hatched/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/hatched/juju-gui/events","assignees_url":"https://api.github.com/repos/hatched/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/hatched/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/hatched/juju-gui/tags","blobs_url":"https://api.github.com/repos/hatched/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hatched/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hatched/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/hatched/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hatched/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/hatched/juju-gui/languages","stargazers_url":"https://api.github.com/repos/hatched/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/hatched/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/hatched/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/hatched/juju-gui/subscription","commits_url":"https://api.github.com/repos/hatched/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/hatched/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/hatched/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/hatched/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/hatched/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/hatched/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hatched/juju-gui/merges","archive_url":"https://api.github.com/repos/hatched/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hatched/juju-gui/downloads","issues_url":"https://api.github.com/repos/hatched/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/hatched/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/hatched/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/hatched/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hatched/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/hatched/juju-gui/releases{/id}","created_at":"2013-12-05T18:57:16Z","updated_at":"2015-03-19T15:41:36Z","pushed_at":"2015-10-14T01:01:12Z","git_url":"git://github.com/hatched/juju-gui.git","ssh_url":"git@github.com:hatched/juju-gui.git","clone_url":"https://github.com/hatched/juju-gui.git","svn_url":"https://github.com/hatched/juju-gui","homepage":null,"size":113409,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"juju:pyramid-fork","ref":"pyramid-fork","sha":"7078c859ec4aea461c847891dd95982496d14b50","user":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":14960387,"name":"juju-gui","full_name":"juju/juju-gui","owner":{"login":"juju","id":4604548,"avatar_url":"https://avatars.githubusercontent.com/u/4604548?v=3","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju-gui","description":"Juju-GUI is a web-based GUI for Juju <https://juju.ubuntu.com/>.","fork":false,"url":"https://api.github.com/repos/juju/juju-gui","forks_url":"https://api.github.com/repos/juju/juju-gui/forks","keys_url":"https://api.github.com/repos/juju/juju-gui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju-gui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju-gui/teams","hooks_url":"https://api.github.com/repos/juju/juju-gui/hooks","issue_events_url":"https://api.github.com/repos/juju/juju-gui/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju-gui/events","assignees_url":"https://api.github.com/repos/juju/juju-gui/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju-gui/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju-gui/tags","blobs_url":"https://api.github.com/repos/juju/juju-gui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju-gui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju-gui/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju-gui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju-gui/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju-gui/languages","stargazers_url":"https://api.github.com/repos/juju/juju-gui/stargazers","contributors_url":"https://api.github.com/repos/juju/juju-gui/contributors","subscribers_url":"https://api.github.com/repos/juju/juju-gui/subscribers","subscription_url":"https://api.github.com/repos/juju/juju-gui/subscription","commits_url":"https://api.github.com/repos/juju/juju-gui/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju-gui/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju-gui/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju-gui/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju-gui/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju-gui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju-gui/merges","archive_url":"https://api.github.com/repos/juju/juju-gui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju-gui/downloads","issues_url":"https://api.github.com/repos/juju/juju-gui/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju-gui/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju-gui/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju-gui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju-gui/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju-gui/releases{/id}","created_at":"2013-12-05T17:15:48Z","updated_at":"2015-08-31T23:27:31Z","pushed_at":"2015-10-14T07:17:03Z","git_url":"git://github.com/juju/juju-gui.git","ssh_url":"git@github.com:juju/juju-gui.git","clone_url":"https://github.com/juju/juju-gui.git","svn_url":"https://github.com/juju/juju-gui","homepage":null,"size":116447,"stargazers_count":54,"watchers_count":54,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":7,"forks":43,"open_issues":7,"watchers":54,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/896"},"html":{"href":"https://github.com/juju/juju-gui/pull/896"},"issue":{"href":"https://api.github.com/repos/juju/juju-gui/issues/896"},"comments":{"href":"https://api.github.com/repos/juju/juju-gui/issues/896/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/896/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju-gui/pulls/896/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju-gui/statuses/4945f0c0363380722a82ff1605c9f6406014179c"}}}}