{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/calico-docker/pulls/comments/36564913","id":36564913,"diff_hunk":"@@ -0,0 +1,23 @@\n+# Copyright 2015 Metaswitch Networks\n+#\n+# Licensed under the Apache License, Version 2.0 (the \"License\");\n+# you may not use this file except in compliance with the License.\n+# You may obtain a copy of the License at\n+#\n+#     http://www.apache.org/licenses/LICENSE-2.0\n+#\n+# Unless required by applicable law or agreed to in writing, software\n+# distributed under the License is distributed on an \"AS IS\" BASIS,\n+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+# See the License for the specific language governing permissions and\n+# limitations under the License.\n+\n+# IPv4 Pool Adresses\n+DEFAULT_IPV4_POOL = \"192.168.0.0/16\"\n+IPV4_POOL_ADDR_1 =  \"192.168.1.1\"\n+IPV4_POOL_ADDR_2 =  \"192.168.1.2\"\n+\n+# IPv6 Pool Addresses\n+DEFAULT_IPV6_POOL = \"fd80:24e2:f998:72d6::/64\"\n+IPV6_POOL_ADDR_1 = \"fd80:24e2:f998:72d6::11\"\n+IPV6_POOL_ADDR_2 = \"fd80:24e2:f998:72d6::22\"","path":"calico_containers/tests/st/utils/defaults.py","position":23,"original_position":23,"commit_id":"2b1fd256ffb1f0527ce55a699ecf7b1a526676aa","original_commit_id":"2b1fd256ffb1f0527ce55a699ecf7b1a526676aa","user":{"login":"TrimBiggs","id":1302077,"avatar_url":"https://avatars.githubusercontent.com/u/1302077?v=3","gravatar_id":"","url":"https://api.github.com/users/TrimBiggs","html_url":"https://github.com/TrimBiggs","followers_url":"https://api.github.com/users/TrimBiggs/followers","following_url":"https://api.github.com/users/TrimBiggs/following{/other_user}","gists_url":"https://api.github.com/users/TrimBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/TrimBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrimBiggs/subscriptions","organizations_url":"https://api.github.com/users/TrimBiggs/orgs","repos_url":"https://api.github.com/users/TrimBiggs/repos","events_url":"https://api.github.com/users/TrimBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/TrimBiggs/received_events","type":"User","site_admin":false},"body":"Whoops, ADDR_1 and ADDR_2 aren't used here, I copied them from another test I wrote, meant to get rid of them.\r\n\r\nThere isn't a `defaults` or `constants` file for the calico pools.  These pools are general also, not just libnetwork.  \r\n\r\nI decided to put these default pool addresses in an ST file in case we decide to use more ST constants that are unrelated to the rest of the repo (as the ADDR_1 and ADDR_2 values would be).  I would also be on board with saving the IP as a global wherever the default pool is defined in calico-docker, though I think have a defaults file for the STs is also useful.","created_at":"2015-08-07T21:55:12Z","updated_at":"2015-08-07T21:55:12Z","html_url":"https://github.com/projectcalico/calico-docker/pull/428#discussion_r36564913","pull_request_url":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-docker/pulls/comments/36564913"},"html":{"href":"https://github.com/projectcalico/calico-docker/pull/428#discussion_r36564913"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428","id":41935080,"html_url":"https://github.com/projectcalico/calico-docker/pull/428","diff_url":"https://github.com/projectcalico/calico-docker/pull/428.diff","patch_url":"https://github.com/projectcalico/calico-docker/pull/428.patch","issue_url":"https://api.github.com/repos/projectcalico/calico-docker/issues/428","number":428,"state":"open","locked":false,"title":"Add system tests for calicoctl pool command","user":{"login":"TrimBiggs","id":1302077,"avatar_url":"https://avatars.githubusercontent.com/u/1302077?v=3","gravatar_id":"","url":"https://api.github.com/users/TrimBiggs","html_url":"https://github.com/TrimBiggs","followers_url":"https://api.github.com/users/TrimBiggs/followers","following_url":"https://api.github.com/users/TrimBiggs/following{/other_user}","gists_url":"https://api.github.com/users/TrimBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/TrimBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrimBiggs/subscriptions","organizations_url":"https://api.github.com/users/TrimBiggs/orgs","repos_url":"https://api.github.com/users/TrimBiggs/repos","events_url":"https://api.github.com/users/TrimBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/TrimBiggs/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-07T21:28:40Z","updated_at":"2015-08-07T21:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86cbddb95ceac032d6821c401cea5b2f2db2ed6d","assignee":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars.githubusercontent.com/u/3227729?v=3","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428/commits","review_comments_url":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428/comments","review_comment_url":"https://api.github.com/repos/projectcalico/calico-docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/calico-docker/issues/428/comments","statuses_url":"https://api.github.com/repos/projectcalico/calico-docker/statuses/2b1fd256ffb1f0527ce55a699ecf7b1a526676aa","head":{"label":"TrimBiggs:st-pool","ref":"st-pool","sha":"2b1fd256ffb1f0527ce55a699ecf7b1a526676aa","user":{"login":"TrimBiggs","id":1302077,"avatar_url":"https://avatars.githubusercontent.com/u/1302077?v=3","gravatar_id":"","url":"https://api.github.com/users/TrimBiggs","html_url":"https://github.com/TrimBiggs","followers_url":"https://api.github.com/users/TrimBiggs/followers","following_url":"https://api.github.com/users/TrimBiggs/following{/other_user}","gists_url":"https://api.github.com/users/TrimBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/TrimBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrimBiggs/subscriptions","organizations_url":"https://api.github.com/users/TrimBiggs/orgs","repos_url":"https://api.github.com/users/TrimBiggs/repos","events_url":"https://api.github.com/users/TrimBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/TrimBiggs/received_events","type":"User","site_admin":false},"repo":{"id":38397840,"name":"calico-docker","full_name":"TrimBiggs/calico-docker","owner":{"login":"TrimBiggs","id":1302077,"avatar_url":"https://avatars.githubusercontent.com/u/1302077?v=3","gravatar_id":"","url":"https://api.github.com/users/TrimBiggs","html_url":"https://github.com/TrimBiggs","followers_url":"https://api.github.com/users/TrimBiggs/followers","following_url":"https://api.github.com/users/TrimBiggs/following{/other_user}","gists_url":"https://api.github.com/users/TrimBiggs/gists{/gist_id}","starred_url":"https://api.github.com/users/TrimBiggs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrimBiggs/subscriptions","organizations_url":"https://api.github.com/users/TrimBiggs/orgs","repos_url":"https://api.github.com/users/TrimBiggs/repos","events_url":"https://api.github.com/users/TrimBiggs/events{/privacy}","received_events_url":"https://api.github.com/users/TrimBiggs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TrimBiggs/calico-docker","description":"Docker version of Project Calico","fork":true,"url":"https://api.github.com/repos/TrimBiggs/calico-docker","forks_url":"https://api.github.com/repos/TrimBiggs/calico-docker/forks","keys_url":"https://api.github.com/repos/TrimBiggs/calico-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrimBiggs/calico-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrimBiggs/calico-docker/teams","hooks_url":"https://api.github.com/repos/TrimBiggs/calico-docker/hooks","issue_events_url":"https://api.github.com/repos/TrimBiggs/calico-docker/issues/events{/number}","events_url":"https://api.github.com/repos/TrimBiggs/calico-docker/events","assignees_url":"https://api.github.com/repos/TrimBiggs/calico-docker/assignees{/user}","branches_url":"https://api.github.com/repos/TrimBiggs/calico-docker/branches{/branch}","tags_url":"https://api.github.com/repos/TrimBiggs/calico-docker/tags","blobs_url":"https://api.github.com/repos/TrimBiggs/calico-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrimBiggs/calico-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrimBiggs/calico-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrimBiggs/calico-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrimBiggs/calico-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/TrimBiggs/calico-docker/languages","stargazers_url":"https://api.github.com/repos/TrimBiggs/calico-docker/stargazers","contributors_url":"https://api.github.com/repos/TrimBiggs/calico-docker/contributors","subscribers_url":"https://api.github.com/repos/TrimBiggs/calico-docker/subscribers","subscription_url":"https://api.github.com/repos/TrimBiggs/calico-docker/subscription","commits_url":"https://api.github.com/repos/TrimBiggs/calico-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrimBiggs/calico-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrimBiggs/calico-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrimBiggs/calico-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrimBiggs/calico-docker/contents/{+path}","compare_url":"https://api.github.com/repos/TrimBiggs/calico-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrimBiggs/calico-docker/merges","archive_url":"https://api.github.com/repos/TrimBiggs/calico-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrimBiggs/calico-docker/downloads","issues_url":"https://api.github.com/repos/TrimBiggs/calico-docker/issues{/number}","pulls_url":"https://api.github.com/repos/TrimBiggs/calico-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/TrimBiggs/calico-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/TrimBiggs/calico-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrimBiggs/calico-docker/labels{/name}","releases_url":"https://api.github.com/repos/TrimBiggs/calico-docker/releases{/id}","created_at":"2015-07-01T22:16:32Z","updated_at":"2015-07-01T22:16:32Z","pushed_at":"2015-08-07T21:48:11Z","git_url":"git://github.com/TrimBiggs/calico-docker.git","ssh_url":"git@github.com:TrimBiggs/calico-docker.git","clone_url":"https://github.com/TrimBiggs/calico-docker.git","svn_url":"https://github.com/TrimBiggs/calico-docker","homepage":"http://www.projectcalico.org","size":13534,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:master","ref":"master","sha":"7b4b57f0366b1c2914b36e1945289f6119ed14ce","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":29629333,"name":"calico-docker","full_name":"projectcalico/calico-docker","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars.githubusercontent.com/u/12304728?v=3","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/calico-docker","description":"Docker version of Project Calico","fork":false,"url":"https://api.github.com/repos/projectcalico/calico-docker","forks_url":"https://api.github.com/repos/projectcalico/calico-docker/forks","keys_url":"https://api.github.com/repos/projectcalico/calico-docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/calico-docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/calico-docker/teams","hooks_url":"https://api.github.com/repos/projectcalico/calico-docker/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/calico-docker/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/calico-docker/events","assignees_url":"https://api.github.com/repos/projectcalico/calico-docker/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/calico-docker/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/calico-docker/tags","blobs_url":"https://api.github.com/repos/projectcalico/calico-docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/calico-docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/calico-docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/calico-docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/calico-docker/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/calico-docker/languages","stargazers_url":"https://api.github.com/repos/projectcalico/calico-docker/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/calico-docker/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/calico-docker/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/calico-docker/subscription","commits_url":"https://api.github.com/repos/projectcalico/calico-docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/calico-docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/calico-docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/calico-docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/calico-docker/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/calico-docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/calico-docker/merges","archive_url":"https://api.github.com/repos/projectcalico/calico-docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/calico-docker/downloads","issues_url":"https://api.github.com/repos/projectcalico/calico-docker/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/calico-docker/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/calico-docker/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/calico-docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/calico-docker/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/calico-docker/releases{/id}","created_at":"2015-01-21T23:46:47Z","updated_at":"2015-08-07T02:43:44Z","pushed_at":"2015-08-07T21:48:12Z","git_url":"git://github.com/projectcalico/calico-docker.git","ssh_url":"git@github.com:projectcalico/calico-docker.git","clone_url":"https://github.com/projectcalico/calico-docker.git","svn_url":"https://github.com/projectcalico/calico-docker","homepage":"http://www.projectcalico.org","size":16733,"stargazers_count":107,"watchers_count":107,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":19,"forks":23,"open_issues":19,"watchers":107,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428"},"html":{"href":"https://github.com/projectcalico/calico-docker/pull/428"},"issue":{"href":"https://api.github.com/repos/projectcalico/calico-docker/issues/428"},"comments":{"href":"https://api.github.com/repos/projectcalico/calico-docker/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/calico-docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/calico-docker/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/calico-docker/statuses/2b1fd256ffb1f0527ce55a699ecf7b1a526676aa"}}}}