{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/38881567","id":38881567,"diff_hunk":"@@ -1228,8 +1228,8 @@ impl Index<usize> for Json {\n     type Output = Json;\n \n     fn index<'a>(&'a self, idx: usize) -> &'a Json {","path":"src/libserialize/json.rs","position":88,"original_position":88,"commit_id":"9cca96545faf2cfc972cc67b83deae2a78935c43","original_commit_id":"9cca96545faf2cfc972cc67b83deae2a78935c43","user":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"body":"No elision?","created_at":"2015-09-07T22:51:49Z","updated_at":"2015-09-07T22:51:49Z","html_url":"https://github.com/rust-lang/rust/pull/28287#discussion_r38881567","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/28287","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/38881567"},"html":{"href":"https://github.com/rust-lang/rust/pull/28287#discussion_r38881567"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28287"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/28287","id":44381751,"html_url":"https://github.com/rust-lang/rust/pull/28287","diff_url":"https://github.com/rust-lang/rust/pull/28287.diff","patch_url":"https://github.com/rust-lang/rust/pull/28287.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/28287","number":28287,"state":"open","locked":false,"title":"some more clippy-based improvements","user":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"body":"It's a large number of small improvements to the code, mostly readability-related, but removing closures and replacing `str::to_string()` with `.to_owned()` should also positively affect performance.\r\n\r\nr? @Manishearth (once it compiles, of course :smile:)","created_at":"2015-09-07T22:40:41Z","updated_at":"2015-09-07T22:51:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"31a76fe30e80a84b5625e3cabc71a593bb879011","assignee":{"login":"Manishearth","id":1617736,"avatar_url":"https://avatars.githubusercontent.com/u/1617736?v=3","gravatar_id":"","url":"https://api.github.com/users/Manishearth","html_url":"https://github.com/Manishearth","followers_url":"https://api.github.com/users/Manishearth/followers","following_url":"https://api.github.com/users/Manishearth/following{/other_user}","gists_url":"https://api.github.com/users/Manishearth/gists{/gist_id}","starred_url":"https://api.github.com/users/Manishearth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Manishearth/subscriptions","organizations_url":"https://api.github.com/users/Manishearth/orgs","repos_url":"https://api.github.com/users/Manishearth/repos","events_url":"https://api.github.com/users/Manishearth/events{/privacy}","received_events_url":"https://api.github.com/users/Manishearth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/28287/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/28287/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/28287/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/9cca96545faf2cfc972cc67b83deae2a78935c43","head":{"label":"llogiq:clippy","ref":"clippy","sha":"9cca96545faf2cfc972cc67b83deae2a78935c43","user":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"repo":{"id":41794445,"name":"rust","full_name":"llogiq/rust","owner":{"login":"llogiq","id":4200835,"avatar_url":"https://avatars.githubusercontent.com/u/4200835?v=3","gravatar_id":"","url":"https://api.github.com/users/llogiq","html_url":"https://github.com/llogiq","followers_url":"https://api.github.com/users/llogiq/followers","following_url":"https://api.github.com/users/llogiq/following{/other_user}","gists_url":"https://api.github.com/users/llogiq/gists{/gist_id}","starred_url":"https://api.github.com/users/llogiq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llogiq/subscriptions","organizations_url":"https://api.github.com/users/llogiq/orgs","repos_url":"https://api.github.com/users/llogiq/repos","events_url":"https://api.github.com/users/llogiq/events{/privacy}","received_events_url":"https://api.github.com/users/llogiq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/llogiq/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/llogiq/rust","forks_url":"https://api.github.com/repos/llogiq/rust/forks","keys_url":"https://api.github.com/repos/llogiq/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/llogiq/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/llogiq/rust/teams","hooks_url":"https://api.github.com/repos/llogiq/rust/hooks","issue_events_url":"https://api.github.com/repos/llogiq/rust/issues/events{/number}","events_url":"https://api.github.com/repos/llogiq/rust/events","assignees_url":"https://api.github.com/repos/llogiq/rust/assignees{/user}","branches_url":"https://api.github.com/repos/llogiq/rust/branches{/branch}","tags_url":"https://api.github.com/repos/llogiq/rust/tags","blobs_url":"https://api.github.com/repos/llogiq/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/llogiq/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/llogiq/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/llogiq/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/llogiq/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/llogiq/rust/languages","stargazers_url":"https://api.github.com/repos/llogiq/rust/stargazers","contributors_url":"https://api.github.com/repos/llogiq/rust/contributors","subscribers_url":"https://api.github.com/repos/llogiq/rust/subscribers","subscription_url":"https://api.github.com/repos/llogiq/rust/subscription","commits_url":"https://api.github.com/repos/llogiq/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/llogiq/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/llogiq/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/llogiq/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/llogiq/rust/contents/{+path}","compare_url":"https://api.github.com/repos/llogiq/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/llogiq/rust/merges","archive_url":"https://api.github.com/repos/llogiq/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/llogiq/rust/downloads","issues_url":"https://api.github.com/repos/llogiq/rust/issues{/number}","pulls_url":"https://api.github.com/repos/llogiq/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/llogiq/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/llogiq/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/llogiq/rust/labels{/name}","releases_url":"https://api.github.com/repos/llogiq/rust/releases{/id}","created_at":"2015-09-02T10:11:00Z","updated_at":"2015-09-02T10:11:15Z","pushed_at":"2015-09-07T22:37:53Z","git_url":"git://github.com/llogiq/rust.git","ssh_url":"git@github.com:llogiq/rust.git","clone_url":"https://github.com/llogiq/rust.git","svn_url":"https://github.com/llogiq/rust","homepage":"http://www.rust-lang.org","size":316109,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"7bf626a68045be1d1a4fac9a635113bb7775b6bb","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-09-07T22:43:47Z","pushed_at":"2015-09-07T22:40:41Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":671755,"stargazers_count":13254,"watchers_count":13254,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2573,"mirror_url":null,"open_issues_count":2272,"forks":2573,"open_issues":2272,"watchers":13254,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28287"},"html":{"href":"https://github.com/rust-lang/rust/pull/28287"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28287"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/28287/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28287/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/28287/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/9cca96545faf2cfc972cc67b83deae2a78935c43"}}}}