{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/6","id":12301070,"html_url":"https://github.com/CpuID/pve2-api-php-client/pull/6","diff_url":"https://github.com/CpuID/pve2-api-php-client/pull/6.diff","patch_url":"https://github.com/CpuID/pve2-api-php-client/pull/6.patch","issue_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues/6","number":6,"state":"closed","locked":false,"title":"Cleanup and update to PHP5 class conventions","user":{"login":"danhunsaker","id":1534396,"avatar_url":"https://avatars.githubusercontent.com/u/1534396?v=3","gravatar_id":"","url":"https://api.github.com/users/danhunsaker","html_url":"https://github.com/danhunsaker","followers_url":"https://api.github.com/users/danhunsaker/followers","following_url":"https://api.github.com/users/danhunsaker/following{/other_user}","gists_url":"https://api.github.com/users/danhunsaker/gists{/gist_id}","starred_url":"https://api.github.com/users/danhunsaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhunsaker/subscriptions","organizations_url":"https://api.github.com/users/danhunsaker/orgs","repos_url":"https://api.github.com/users/danhunsaker/repos","events_url":"https://api.github.com/users/danhunsaker/events{/privacy}","received_events_url":"https://api.github.com/users/danhunsaker/received_events","type":"User","site_admin":false},"body":"- Should throw exceptions on errors that prevent proper `__cosntruct()` execution.\r\n- Should throw exceptions on errors that prevent proper execution of other logic, unless actual error handling is implemented internally to such logic.\r\n\r\nAlso minimized operation overhead by moving initial node list loading to end of successful login, instead of on every action possible post-login.  (There were checks to determine if upstream requests were required to fulfill this need, but that check itself presents an amount of overhead which can be undesirable in a high performance, high request load situation.)\r\n\r\nAdditionally, removed superfluous `pve_` from property and method names.  The fact that they are part of the `PVE2_API` class tells us that much of their nature.  The fact that all were in protected/private scope makes the extra characters even more unnecessary.\r\n\r\n----\r\n\r\nNOTE: `diff` isn't very smart about detecting when newlines are added to existing text, so the first several changes (until about line 83 in the old/53 in the new) are less drastic than they appear.  (`git` uses `diff` rather than replicate its functionality because Linus believes in not reinventing wheels he doesn't have to; git is obviously a wheel he had to :grin: )","created_at":"2014-02-07T06:03:21Z","updated_at":"2015-02-02T11:22:33Z","closed_at":"2015-02-02T11:22:32Z","merged_at":"2015-02-02T11:22:32Z","merge_commit_sha":"a6304990e5db7fc6c4090658eacd8e19614ea5a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/6/commits","review_comments_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/6/comments","review_comment_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/comments/{number}","comments_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues/6/comments","statuses_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/statuses/36872baab78de90e89386dcac2e44ffe05bc41eb","head":{"label":"danhunsaker:improve/PHP5-class-standards","ref":"improve/PHP5-class-standards","sha":"36872baab78de90e89386dcac2e44ffe05bc41eb","user":{"login":"danhunsaker","id":1534396,"avatar_url":"https://avatars.githubusercontent.com/u/1534396?v=3","gravatar_id":"","url":"https://api.github.com/users/danhunsaker","html_url":"https://github.com/danhunsaker","followers_url":"https://api.github.com/users/danhunsaker/followers","following_url":"https://api.github.com/users/danhunsaker/following{/other_user}","gists_url":"https://api.github.com/users/danhunsaker/gists{/gist_id}","starred_url":"https://api.github.com/users/danhunsaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhunsaker/subscriptions","organizations_url":"https://api.github.com/users/danhunsaker/orgs","repos_url":"https://api.github.com/users/danhunsaker/repos","events_url":"https://api.github.com/users/danhunsaker/events{/privacy}","received_events_url":"https://api.github.com/users/danhunsaker/received_events","type":"User","site_admin":false},"repo":{"id":16018589,"name":"pve2-api-php-client","full_name":"danhunsaker/pve2-api-php-client","owner":{"login":"danhunsaker","id":1534396,"avatar_url":"https://avatars.githubusercontent.com/u/1534396?v=3","gravatar_id":"","url":"https://api.github.com/users/danhunsaker","html_url":"https://github.com/danhunsaker","followers_url":"https://api.github.com/users/danhunsaker/followers","following_url":"https://api.github.com/users/danhunsaker/following{/other_user}","gists_url":"https://api.github.com/users/danhunsaker/gists{/gist_id}","starred_url":"https://api.github.com/users/danhunsaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danhunsaker/subscriptions","organizations_url":"https://api.github.com/users/danhunsaker/orgs","repos_url":"https://api.github.com/users/danhunsaker/repos","events_url":"https://api.github.com/users/danhunsaker/events{/privacy}","received_events_url":"https://api.github.com/users/danhunsaker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danhunsaker/pve2-api-php-client","description":"Proxmox 2.0 API Client for PHP","fork":true,"url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client","forks_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/forks","keys_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/teams","hooks_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/hooks","issue_events_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/events","assignees_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/tags","blobs_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/languages","stargazers_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/stargazers","contributors_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/contributors","subscribers_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/subscribers","subscription_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/subscription","commits_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/merges","archive_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/downloads","issues_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/labels{/name}","releases_url":"https://api.github.com/repos/danhunsaker/pve2-api-php-client/releases{/id}","created_at":"2014-01-18T03:54:40Z","updated_at":"2014-02-07T06:03:21Z","pushed_at":"2014-02-07T05:51:19Z","git_url":"git://github.com/danhunsaker/pve2-api-php-client.git","ssh_url":"git@github.com:danhunsaker/pve2-api-php-client.git","clone_url":"https://github.com/danhunsaker/pve2-api-php-client.git","svn_url":"https://github.com/danhunsaker/pve2-api-php-client","homepage":"","size":118,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CpuID:master","ref":"master","sha":"3ad2a097dc59c9ddef5bbff7587b0f26f7e1a45c","user":{"login":"CpuID","id":916201,"avatar_url":"https://avatars.githubusercontent.com/u/916201?v=3","gravatar_id":"","url":"https://api.github.com/users/CpuID","html_url":"https://github.com/CpuID","followers_url":"https://api.github.com/users/CpuID/followers","following_url":"https://api.github.com/users/CpuID/following{/other_user}","gists_url":"https://api.github.com/users/CpuID/gists{/gist_id}","starred_url":"https://api.github.com/users/CpuID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CpuID/subscriptions","organizations_url":"https://api.github.com/users/CpuID/orgs","repos_url":"https://api.github.com/users/CpuID/repos","events_url":"https://api.github.com/users/CpuID/events{/privacy}","received_events_url":"https://api.github.com/users/CpuID/received_events","type":"User","site_admin":false},"repo":{"id":3997776,"name":"pve2-api-php-client","full_name":"CpuID/pve2-api-php-client","owner":{"login":"CpuID","id":916201,"avatar_url":"https://avatars.githubusercontent.com/u/916201?v=3","gravatar_id":"","url":"https://api.github.com/users/CpuID","html_url":"https://github.com/CpuID","followers_url":"https://api.github.com/users/CpuID/followers","following_url":"https://api.github.com/users/CpuID/following{/other_user}","gists_url":"https://api.github.com/users/CpuID/gists{/gist_id}","starred_url":"https://api.github.com/users/CpuID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CpuID/subscriptions","organizations_url":"https://api.github.com/users/CpuID/orgs","repos_url":"https://api.github.com/users/CpuID/repos","events_url":"https://api.github.com/users/CpuID/events{/privacy}","received_events_url":"https://api.github.com/users/CpuID/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CpuID/pve2-api-php-client","description":"Proxmox 2.0 API Client for PHP","fork":false,"url":"https://api.github.com/repos/CpuID/pve2-api-php-client","forks_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/forks","keys_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/teams","hooks_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/hooks","issue_events_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues/events{/number}","events_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/events","assignees_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/assignees{/user}","branches_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/branches{/branch}","tags_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/tags","blobs_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/statuses/{sha}","languages_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/languages","stargazers_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/stargazers","contributors_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/contributors","subscribers_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/subscribers","subscription_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/subscription","commits_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues/comments/{number}","contents_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/contents/{+path}","compare_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/merges","archive_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/downloads","issues_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues{/number}","pulls_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls{/number}","milestones_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/milestones{/number}","notifications_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/labels{/name}","releases_url":"https://api.github.com/repos/CpuID/pve2-api-php-client/releases{/id}","created_at":"2012-04-11T20:17:43Z","updated_at":"2014-12-08T02:53:19Z","pushed_at":"2015-02-02T11:22:33Z","git_url":"git://github.com/CpuID/pve2-api-php-client.git","ssh_url":"git@github.com:CpuID/pve2-api-php-client.git","clone_url":"https://github.com/CpuID/pve2-api-php-client.git","svn_url":"https://github.com/CpuID/pve2-api-php-client","homepage":"","size":140,"stargazers_count":35,"watchers_count":35,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":3,"forks":25,"open_issues":3,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/6"},"html":{"href":"https://github.com/CpuID/pve2-api-php-client/pull/6"},"issue":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues/6"},"comments":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/CpuID/pve2-api-php-client/statuses/36872baab78de90e89386dcac2e44ffe05bc41eb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"CpuID","id":916201,"avatar_url":"https://avatars.githubusercontent.com/u/916201?v=3","gravatar_id":"","url":"https://api.github.com/users/CpuID","html_url":"https://github.com/CpuID","followers_url":"https://api.github.com/users/CpuID/followers","following_url":"https://api.github.com/users/CpuID/following{/other_user}","gists_url":"https://api.github.com/users/CpuID/gists{/gist_id}","starred_url":"https://api.github.com/users/CpuID/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CpuID/subscriptions","organizations_url":"https://api.github.com/users/CpuID/orgs","repos_url":"https://api.github.com/users/CpuID/repos","events_url":"https://api.github.com/users/CpuID/events{/privacy}","received_events_url":"https://api.github.com/users/CpuID/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":115,"deletions":236,"changed_files":1}}