{"action":"closed","number":6438,"pull_request":{"url":"https://api.github.com/repos/facebook/hhvm/pulls/6438","id":49192984,"html_url":"https://github.com/facebook/hhvm/pull/6438","diff_url":"https://github.com/facebook/hhvm/pull/6438.diff","patch_url":"https://github.com/facebook/hhvm/pull/6438.patch","issue_url":"https://api.github.com/repos/facebook/hhvm/issues/6438","number":6438,"state":"closed","locked":false,"title":"Clarify documentation around $name in fb_intercept callbacks.","user":{"login":"kyleds","id":14931595,"avatar_url":"https://avatars.githubusercontent.com/u/14931595?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleds","html_url":"https://github.com/kyleds","followers_url":"https://api.github.com/users/kyleds/followers","following_url":"https://api.github.com/users/kyleds/following{/other_user}","gists_url":"https://api.github.com/users/kyleds/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleds/subscriptions","organizations_url":"https://api.github.com/users/kyleds/orgs","repos_url":"https://api.github.com/users/kyleds/repos","events_url":"https://api.github.com/users/kyleds/events{/privacy}","received_events_url":"https://api.github.com/users/kyleds/received_events","type":"User","site_admin":false},"body":"It was not entirely intuitive for $name to be in the fully-qualified\r\nClass::method form. This caused some headache when implementing an\r\nintercept function. Perhaps worse than the lack of clarity is PHP's\r\nwillingness to allow callables in this way  ([$instance, 'Class::method']).","created_at":"2015-10-29T20:09:25Z","updated_at":"2015-11-05T05:03:47Z","closed_at":"2015-11-05T05:03:47Z","merged_at":null,"merge_commit_sha":"bde0801c6b118805e1007234b8280a094448fe85","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/hhvm/pulls/6438/commits","review_comments_url":"https://api.github.com/repos/facebook/hhvm/pulls/6438/comments","review_comment_url":"https://api.github.com/repos/facebook/hhvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/hhvm/issues/6438/comments","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/fa762154b1dbad1643ff43d95fadf9986a7ae2e7","head":{"label":"kyleds:clarify_intercept_name_semantics","ref":"clarify_intercept_name_semantics","sha":"fa762154b1dbad1643ff43d95fadf9986a7ae2e7","user":{"login":"kyleds","id":14931595,"avatar_url":"https://avatars.githubusercontent.com/u/14931595?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleds","html_url":"https://github.com/kyleds","followers_url":"https://api.github.com/users/kyleds/followers","following_url":"https://api.github.com/users/kyleds/following{/other_user}","gists_url":"https://api.github.com/users/kyleds/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleds/subscriptions","organizations_url":"https://api.github.com/users/kyleds/orgs","repos_url":"https://api.github.com/users/kyleds/repos","events_url":"https://api.github.com/users/kyleds/events{/privacy}","received_events_url":"https://api.github.com/users/kyleds/received_events","type":"User","site_admin":false},"repo":{"id":45207682,"name":"hhvm","full_name":"kyleds/hhvm","owner":{"login":"kyleds","id":14931595,"avatar_url":"https://avatars.githubusercontent.com/u/14931595?v=3","gravatar_id":"","url":"https://api.github.com/users/kyleds","html_url":"https://github.com/kyleds","followers_url":"https://api.github.com/users/kyleds/followers","following_url":"https://api.github.com/users/kyleds/following{/other_user}","gists_url":"https://api.github.com/users/kyleds/gists{/gist_id}","starred_url":"https://api.github.com/users/kyleds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyleds/subscriptions","organizations_url":"https://api.github.com/users/kyleds/orgs","repos_url":"https://api.github.com/users/kyleds/repos","events_url":"https://api.github.com/users/kyleds/events{/privacy}","received_events_url":"https://api.github.com/users/kyleds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kyleds/hhvm","description":"A virtual machine designed for executing programs written in Hack and PHP. ","fork":true,"url":"https://api.github.com/repos/kyleds/hhvm","forks_url":"https://api.github.com/repos/kyleds/hhvm/forks","keys_url":"https://api.github.com/repos/kyleds/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kyleds/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kyleds/hhvm/teams","hooks_url":"https://api.github.com/repos/kyleds/hhvm/hooks","issue_events_url":"https://api.github.com/repos/kyleds/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/kyleds/hhvm/events","assignees_url":"https://api.github.com/repos/kyleds/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/kyleds/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/kyleds/hhvm/tags","blobs_url":"https://api.github.com/repos/kyleds/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kyleds/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kyleds/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/kyleds/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kyleds/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/kyleds/hhvm/languages","stargazers_url":"https://api.github.com/repos/kyleds/hhvm/stargazers","contributors_url":"https://api.github.com/repos/kyleds/hhvm/contributors","subscribers_url":"https://api.github.com/repos/kyleds/hhvm/subscribers","subscription_url":"https://api.github.com/repos/kyleds/hhvm/subscription","commits_url":"https://api.github.com/repos/kyleds/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/kyleds/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/kyleds/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/kyleds/hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/kyleds/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/kyleds/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kyleds/hhvm/merges","archive_url":"https://api.github.com/repos/kyleds/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kyleds/hhvm/downloads","issues_url":"https://api.github.com/repos/kyleds/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/kyleds/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/kyleds/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/kyleds/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kyleds/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/kyleds/hhvm/releases{/id}","created_at":"2015-10-29T20:07:22Z","updated_at":"2015-10-29T20:08:53Z","pushed_at":"2015-10-29T20:08:22Z","git_url":"git://github.com/kyleds/hhvm.git","ssh_url":"git@github.com:kyleds/hhvm.git","clone_url":"https://github.com/kyleds/hhvm.git","svn_url":"https://github.com/kyleds/hhvm","homepage":"http://hhvm.com","size":226911,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"65bb54a06f38d5532dc0485e6feb0edcd311c360","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":455600,"name":"hhvm","full_name":"facebook/hhvm","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/hhvm","description":"A virtual machine designed for executing programs written in Hack and PHP. ","fork":false,"url":"https://api.github.com/repos/facebook/hhvm","forks_url":"https://api.github.com/repos/facebook/hhvm/forks","keys_url":"https://api.github.com/repos/facebook/hhvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/hhvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/hhvm/teams","hooks_url":"https://api.github.com/repos/facebook/hhvm/hooks","issue_events_url":"https://api.github.com/repos/facebook/hhvm/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/hhvm/events","assignees_url":"https://api.github.com/repos/facebook/hhvm/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/hhvm/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/hhvm/tags","blobs_url":"https://api.github.com/repos/facebook/hhvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/hhvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/hhvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/hhvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/hhvm/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/hhvm/languages","stargazers_url":"https://api.github.com/repos/facebook/hhvm/stargazers","contributors_url":"https://api.github.com/repos/facebook/hhvm/contributors","subscribers_url":"https://api.github.com/repos/facebook/hhvm/subscribers","subscription_url":"https://api.github.com/repos/facebook/hhvm/subscription","commits_url":"https://api.github.com/repos/facebook/hhvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/hhvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/hhvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/hhvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/hhvm/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/hhvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/hhvm/merges","archive_url":"https://api.github.com/repos/facebook/hhvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/hhvm/downloads","issues_url":"https://api.github.com/repos/facebook/hhvm/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/hhvm/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/hhvm/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/hhvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/hhvm/labels{/name}","releases_url":"https://api.github.com/repos/facebook/hhvm/releases{/id}","created_at":"2010-01-02T01:17:06Z","updated_at":"2015-11-05T04:26:34Z","pushed_at":"2015-11-05T05:03:43Z","git_url":"git://github.com/facebook/hhvm.git","ssh_url":"git@github.com:facebook/hhvm.git","clone_url":"https://github.com/facebook/hhvm.git","svn_url":"https://github.com/facebook/hhvm","homepage":"http://hhvm.com","size":516476,"stargazers_count":12838,"watchers_count":12838,"language":"C++","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":2334,"mirror_url":null,"open_issues_count":1013,"forks":2334,"open_issues":1013,"watchers":12838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/6438"},"html":{"href":"https://github.com/facebook/hhvm/pull/6438"},"issue":{"href":"https://api.github.com/repos/facebook/hhvm/issues/6438"},"comments":{"href":"https://api.github.com/repos/facebook/hhvm/issues/6438/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/6438/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/hhvm/pulls/6438/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/hhvm/statuses/fa762154b1dbad1643ff43d95fadf9986a7ae2e7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":1}}