{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/react-native/issues/2332","labels_url":"https://api.github.com/repos/facebook/react-native/issues/2332/labels{/name}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/2332/comments","events_url":"https://api.github.com/repos/facebook/react-native/issues/2332/events","html_url":"https://github.com/facebook/react-native/pull/2332","id":100970080,"number":2332,"title":"[Push notifications] Fix for IOS 8","user":{"login":"DannyvanderJagt","id":1556953,"avatar_url":"https://avatars.githubusercontent.com/u/1556953?v=3","gravatar_id":"","url":"https://api.github.com/users/DannyvanderJagt","html_url":"https://github.com/DannyvanderJagt","followers_url":"https://api.github.com/users/DannyvanderJagt/followers","following_url":"https://api.github.com/users/DannyvanderJagt/following{/other_user}","gists_url":"https://api.github.com/users/DannyvanderJagt/gists{/gist_id}","starred_url":"https://api.github.com/users/DannyvanderJagt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DannyvanderJagt/subscriptions","organizations_url":"https://api.github.com/users/DannyvanderJagt/orgs","repos_url":"https://api.github.com/users/DannyvanderJagt/repos","events_url":"https://api.github.com/users/DannyvanderJagt/events{/privacy}","received_events_url":"https://api.github.com/users/DannyvanderJagt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"e7e7e7"},{"url":"https://api.github.com/repos/facebook/react-native/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04"}],"state":"open","locked":false,"assignee":{"login":"ericvicenti","id":1483597,"avatar_url":"https://avatars.githubusercontent.com/u/1483597?v=3","gravatar_id":"","url":"https://api.github.com/users/ericvicenti","html_url":"https://github.com/ericvicenti","followers_url":"https://api.github.com/users/ericvicenti/followers","following_url":"https://api.github.com/users/ericvicenti/following{/other_user}","gists_url":"https://api.github.com/users/ericvicenti/gists{/gist_id}","starred_url":"https://api.github.com/users/ericvicenti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericvicenti/subscriptions","organizations_url":"https://api.github.com/users/ericvicenti/orgs","repos_url":"https://api.github.com/users/ericvicenti/repos","events_url":"https://api.github.com/users/ericvicenti/events{/privacy}","received_events_url":"https://api.github.com/users/ericvicenti/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2015-08-14T09:17:48Z","updated_at":"2015-09-29T21:30:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/2332","html_url":"https://github.com/facebook/react-native/pull/2332","diff_url":"https://github.com/facebook/react-native/pull/2332.diff","patch_url":"https://github.com/facebook/react-native/pull/2332.patch"},"body":"**Problem**\r\nUsing push notifications in IOS 8 will throw this error:\r\n`registerForRemoteNotificationTypes: is not supported in iOS 8.0 and later.`\r\nThe problem is that the check is running on compile instead of runtime.\r\n\r\n**Solution**\r\nIf have changed the compile if statement to a runtime if statement. The fix is tested on: IOS 7.1 and 8.* and everything is working now.\r\nThis solution is also discussed in: https://github.com/facebook/react-native/issues/1613 and it was part of  https://github.com/facebook/react-native/pull/1979. (is being separated to keep things moving)\r\n\r\nPlease let me know what you think."},"comment":{"url":"https://api.github.com/repos/facebook/react-native/issues/comments/144197092","html_url":"https://github.com/facebook/react-native/pull/2332#issuecomment-144197092","issue_url":"https://api.github.com/repos/facebook/react-native/issues/2332","id":144197092,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T21:30:41Z","updated_at":"2015-09-29T21:30:41Z","body":"Thanks for importing. If you are an FB employee go to https://our.intern.facebook.com/intern/opensource/github/pull_request/1056653971043101/int_phab to review."}}