{"action":"closed","number":2026,"pull_request":{"url":"https://api.github.com/repos/mumble-voip/mumble/pulls/2026","id":54603333,"html_url":"https://github.com/mumble-voip/mumble/pull/2026","diff_url":"https://github.com/mumble-voip/mumble/pull/2026.diff","patch_url":"https://github.com/mumble-voip/mumble/pull/2026.patch","issue_url":"https://api.github.com/repos/mumble-voip/mumble/issues/2026","number":2026,"state":"closed","locked":false,"title":"Murmur: allow both bitmasked version and version string when setting 'suggestversion' via RPC.","user":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=3","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"body":"This commit changes the logic for setting the 'suggestversion' config\r\noption via RPC to automatically figure out whether the passed-in value\r\nis a bitmasked version or a version string.\r\n\r\nIf it is a version string, it will convert the version string to the\r\nbitmasked format, which is what is used internally.\r\n\r\nPrior to this, 'suggestversion' via RPC only allowed a bitmasked\r\nversion. This was confusing users, since the .ini file requires a\r\na version string.\r\n\r\nFixes mumble-voip/mumble#989","created_at":"2015-12-26T14:56:47Z","updated_at":"2015-12-26T21:03:47Z","closed_at":"2015-12-26T21:03:47Z","merged_at":null,"merge_commit_sha":"42912675b31de3484f68c807e97b9cd1dddd7bce","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/2026/commits","review_comments_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/2026/comments","review_comment_url":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/issues/2026/comments","statuses_url":"https://api.github.com/repos/mumble-voip/mumble/statuses/dc918c94dcbdbbc55239420a2b1dafcdebddcc4f","head":{"label":"mkrautz:suggestversion","ref":"suggestversion","sha":"dc918c94dcbdbbc55239420a2b1dafcdebddcc4f","user":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=3","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"repo":{"id":3210109,"name":"mumble","full_name":"mkrautz/mumble","owner":{"login":"mkrautz","id":36527,"avatar_url":"https://avatars.githubusercontent.com/u/36527?v=3","gravatar_id":"","url":"https://api.github.com/users/mkrautz","html_url":"https://github.com/mkrautz","followers_url":"https://api.github.com/users/mkrautz/followers","following_url":"https://api.github.com/users/mkrautz/following{/other_user}","gists_url":"https://api.github.com/users/mkrautz/gists{/gist_id}","starred_url":"https://api.github.com/users/mkrautz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkrautz/subscriptions","organizations_url":"https://api.github.com/users/mkrautz/orgs","repos_url":"https://api.github.com/users/mkrautz/repos","events_url":"https://api.github.com/users/mkrautz/events{/privacy}","received_events_url":"https://api.github.com/users/mkrautz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mkrautz/mumble","description":"Mumble VoIP Client/Server","fork":true,"url":"https://api.github.com/repos/mkrautz/mumble","forks_url":"https://api.github.com/repos/mkrautz/mumble/forks","keys_url":"https://api.github.com/repos/mkrautz/mumble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mkrautz/mumble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mkrautz/mumble/teams","hooks_url":"https://api.github.com/repos/mkrautz/mumble/hooks","issue_events_url":"https://api.github.com/repos/mkrautz/mumble/issues/events{/number}","events_url":"https://api.github.com/repos/mkrautz/mumble/events","assignees_url":"https://api.github.com/repos/mkrautz/mumble/assignees{/user}","branches_url":"https://api.github.com/repos/mkrautz/mumble/branches{/branch}","tags_url":"https://api.github.com/repos/mkrautz/mumble/tags","blobs_url":"https://api.github.com/repos/mkrautz/mumble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mkrautz/mumble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mkrautz/mumble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mkrautz/mumble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mkrautz/mumble/statuses/{sha}","languages_url":"https://api.github.com/repos/mkrautz/mumble/languages","stargazers_url":"https://api.github.com/repos/mkrautz/mumble/stargazers","contributors_url":"https://api.github.com/repos/mkrautz/mumble/contributors","subscribers_url":"https://api.github.com/repos/mkrautz/mumble/subscribers","subscription_url":"https://api.github.com/repos/mkrautz/mumble/subscription","commits_url":"https://api.github.com/repos/mkrautz/mumble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mkrautz/mumble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mkrautz/mumble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mkrautz/mumble/issues/comments{/number}","contents_url":"https://api.github.com/repos/mkrautz/mumble/contents/{+path}","compare_url":"https://api.github.com/repos/mkrautz/mumble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mkrautz/mumble/merges","archive_url":"https://api.github.com/repos/mkrautz/mumble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mkrautz/mumble/downloads","issues_url":"https://api.github.com/repos/mkrautz/mumble/issues{/number}","pulls_url":"https://api.github.com/repos/mkrautz/mumble/pulls{/number}","milestones_url":"https://api.github.com/repos/mkrautz/mumble/milestones{/number}","notifications_url":"https://api.github.com/repos/mkrautz/mumble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mkrautz/mumble/labels{/name}","releases_url":"https://api.github.com/repos/mkrautz/mumble/releases{/id}","created_at":"2012-01-18T16:24:06Z","updated_at":"2015-08-14T23:40:24Z","pushed_at":"2015-12-26T18:38:30Z","git_url":"git://github.com/mkrautz/mumble.git","ssh_url":"git@github.com:mkrautz/mumble.git","clone_url":"https://github.com/mkrautz/mumble.git","svn_url":"https://github.com/mkrautz/mumble","homepage":"http://mumble.info","size":35578,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":6,"default_branch":"master"}},"base":{"label":"mumble-voip:master","ref":"master","sha":"da8a95e541183dd2b2abd6e8c5334924f056e30a","user":{"login":"mumble-voip","id":639008,"avatar_url":"https://avatars.githubusercontent.com/u/639008?v=3","gravatar_id":"","url":"https://api.github.com/users/mumble-voip","html_url":"https://github.com/mumble-voip","followers_url":"https://api.github.com/users/mumble-voip/followers","following_url":"https://api.github.com/users/mumble-voip/following{/other_user}","gists_url":"https://api.github.com/users/mumble-voip/gists{/gist_id}","starred_url":"https://api.github.com/users/mumble-voip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumble-voip/subscriptions","organizations_url":"https://api.github.com/users/mumble-voip/orgs","repos_url":"https://api.github.com/users/mumble-voip/repos","events_url":"https://api.github.com/users/mumble-voip/events{/privacy}","received_events_url":"https://api.github.com/users/mumble-voip/received_events","type":"Organization","site_admin":false},"repo":{"id":1413319,"name":"mumble","full_name":"mumble-voip/mumble","owner":{"login":"mumble-voip","id":639008,"avatar_url":"https://avatars.githubusercontent.com/u/639008?v=3","gravatar_id":"","url":"https://api.github.com/users/mumble-voip","html_url":"https://github.com/mumble-voip","followers_url":"https://api.github.com/users/mumble-voip/followers","following_url":"https://api.github.com/users/mumble-voip/following{/other_user}","gists_url":"https://api.github.com/users/mumble-voip/gists{/gist_id}","starred_url":"https://api.github.com/users/mumble-voip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mumble-voip/subscriptions","organizations_url":"https://api.github.com/users/mumble-voip/orgs","repos_url":"https://api.github.com/users/mumble-voip/repos","events_url":"https://api.github.com/users/mumble-voip/events{/privacy}","received_events_url":"https://api.github.com/users/mumble-voip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mumble-voip/mumble","description":"Mumble VoIP Client/Server","fork":false,"url":"https://api.github.com/repos/mumble-voip/mumble","forks_url":"https://api.github.com/repos/mumble-voip/mumble/forks","keys_url":"https://api.github.com/repos/mumble-voip/mumble/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mumble-voip/mumble/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mumble-voip/mumble/teams","hooks_url":"https://api.github.com/repos/mumble-voip/mumble/hooks","issue_events_url":"https://api.github.com/repos/mumble-voip/mumble/issues/events{/number}","events_url":"https://api.github.com/repos/mumble-voip/mumble/events","assignees_url":"https://api.github.com/repos/mumble-voip/mumble/assignees{/user}","branches_url":"https://api.github.com/repos/mumble-voip/mumble/branches{/branch}","tags_url":"https://api.github.com/repos/mumble-voip/mumble/tags","blobs_url":"https://api.github.com/repos/mumble-voip/mumble/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mumble-voip/mumble/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mumble-voip/mumble/git/refs{/sha}","trees_url":"https://api.github.com/repos/mumble-voip/mumble/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mumble-voip/mumble/statuses/{sha}","languages_url":"https://api.github.com/repos/mumble-voip/mumble/languages","stargazers_url":"https://api.github.com/repos/mumble-voip/mumble/stargazers","contributors_url":"https://api.github.com/repos/mumble-voip/mumble/contributors","subscribers_url":"https://api.github.com/repos/mumble-voip/mumble/subscribers","subscription_url":"https://api.github.com/repos/mumble-voip/mumble/subscription","commits_url":"https://api.github.com/repos/mumble-voip/mumble/commits{/sha}","git_commits_url":"https://api.github.com/repos/mumble-voip/mumble/git/commits{/sha}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/comments{/number}","issue_comment_url":"https://api.github.com/repos/mumble-voip/mumble/issues/comments{/number}","contents_url":"https://api.github.com/repos/mumble-voip/mumble/contents/{+path}","compare_url":"https://api.github.com/repos/mumble-voip/mumble/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mumble-voip/mumble/merges","archive_url":"https://api.github.com/repos/mumble-voip/mumble/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mumble-voip/mumble/downloads","issues_url":"https://api.github.com/repos/mumble-voip/mumble/issues{/number}","pulls_url":"https://api.github.com/repos/mumble-voip/mumble/pulls{/number}","milestones_url":"https://api.github.com/repos/mumble-voip/mumble/milestones{/number}","notifications_url":"https://api.github.com/repos/mumble-voip/mumble/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mumble-voip/mumble/labels{/name}","releases_url":"https://api.github.com/repos/mumble-voip/mumble/releases{/id}","created_at":"2011-02-26T01:30:08Z","updated_at":"2015-12-25T18:58:28Z","pushed_at":"2015-12-26T21:03:29Z","git_url":"git://github.com/mumble-voip/mumble.git","ssh_url":"git@github.com:mumble-voip/mumble.git","clone_url":"https://github.com/mumble-voip/mumble.git","svn_url":"https://github.com/mumble-voip/mumble","homepage":"http://www.mumble.info","size":39774,"stargazers_count":1053,"watchers_count":1053,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":352,"mirror_url":null,"open_issues_count":439,"forks":352,"open_issues":439,"watchers":1053,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/2026"},"html":{"href":"https://github.com/mumble-voip/mumble/pull/2026"},"issue":{"href":"https://api.github.com/repos/mumble-voip/mumble/issues/2026"},"comments":{"href":"https://api.github.com/repos/mumble-voip/mumble/issues/2026/comments"},"review_comments":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/2026/comments"},"review_comment":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mumble-voip/mumble/pulls/2026/commits"},"statuses":{"href":"https://api.github.com/repos/mumble-voip/mumble/statuses/dc918c94dcbdbbc55239420a2b1dafcdebddcc4f"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":0,"commits":1,"additions":33,"deletions":4,"changed_files":1}}