{"action":"opened","number":937,"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/937","id":36100216,"html_url":"https://github.com/coreos/rkt/pull/937","diff_url":"https://github.com/coreos/rkt/pull/937.diff","patch_url":"https://github.com/coreos/rkt/pull/937.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/937","number":937,"state":"open","locked":false,"title":"rkt/rmimage: Apply reference check to the whole image.","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"body":"This is based on #936 so only the last patch is the interesting one.\r\n\r\nBy now only the treestore isn't removed if an image is referenced by\r\nsome pod.\r\nThis brings the need of a store gc to remove the rendered images in\r\nthe treestore when they aren't referenced anymore. This is difficult to\r\ncoordinate and is an extra work that can be avoided simply not removing\r\nalso the image from the store (store.RemoveACI) if the image is\r\nreferenced. IMHO it's also more consistent as the image doesn't\r\ndisappear from the `rkt images` output.","created_at":"2015-05-24T09:13:04Z","updated_at":"2015-05-24T09:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/937/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/937/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/937/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/53b5866fe15b14e22ec62bd34df79fb0810a884b","head":{"label":"sgotti:rkt_rmimage_onlyifnotreferenced","ref":"rkt_rmimage_onlyifnotreferenced","sha":"53b5866fe15b14e22ec62bd34df79fb0810a884b","user":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"repo":{"id":27428376,"name":"rkt","full_name":"sgotti/rkt","owner":{"login":"sgotti","id":1690273,"avatar_url":"https://avatars.githubusercontent.com/u/1690273?v=3","gravatar_id":"","url":"https://api.github.com/users/sgotti","html_url":"https://github.com/sgotti","followers_url":"https://api.github.com/users/sgotti/followers","following_url":"https://api.github.com/users/sgotti/following{/other_user}","gists_url":"https://api.github.com/users/sgotti/gists{/gist_id}","starred_url":"https://api.github.com/users/sgotti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgotti/subscriptions","organizations_url":"https://api.github.com/users/sgotti/orgs","repos_url":"https://api.github.com/users/sgotti/repos","events_url":"https://api.github.com/users/sgotti/events{/privacy}","received_events_url":"https://api.github.com/users/sgotti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgotti/rkt","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/sgotti/rkt","forks_url":"https://api.github.com/repos/sgotti/rkt/forks","keys_url":"https://api.github.com/repos/sgotti/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgotti/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgotti/rkt/teams","hooks_url":"https://api.github.com/repos/sgotti/rkt/hooks","issue_events_url":"https://api.github.com/repos/sgotti/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/sgotti/rkt/events","assignees_url":"https://api.github.com/repos/sgotti/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/sgotti/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/sgotti/rkt/tags","blobs_url":"https://api.github.com/repos/sgotti/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgotti/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgotti/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgotti/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgotti/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/sgotti/rkt/languages","stargazers_url":"https://api.github.com/repos/sgotti/rkt/stargazers","contributors_url":"https://api.github.com/repos/sgotti/rkt/contributors","subscribers_url":"https://api.github.com/repos/sgotti/rkt/subscribers","subscription_url":"https://api.github.com/repos/sgotti/rkt/subscription","commits_url":"https://api.github.com/repos/sgotti/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgotti/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgotti/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgotti/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgotti/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/sgotti/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgotti/rkt/merges","archive_url":"https://api.github.com/repos/sgotti/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgotti/rkt/downloads","issues_url":"https://api.github.com/repos/sgotti/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/sgotti/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/sgotti/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/sgotti/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgotti/rkt/labels{/name}","releases_url":"https://api.github.com/repos/sgotti/rkt/releases{/id}","created_at":"2014-12-02T10:56:31Z","updated_at":"2015-05-23T10:07:22Z","pushed_at":"2015-05-24T09:12:35Z","git_url":"git://github.com/sgotti/rkt.git","ssh_url":"git@github.com:sgotti/rkt.git","clone_url":"https://github.com/sgotti/rkt.git","svn_url":"https://github.com/sgotti/rkt","homepage":"","size":7150,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"e5be761deb0620403aa181702b05609f994cba9a","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-05-24T01:44:38Z","pushed_at":"2015-05-24T09:13:04Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":17220,"stargazers_count":4196,"watchers_count":4196,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":null,"open_issues_count":119,"forks":317,"open_issues":119,"watchers":4196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/937"},"html":{"href":"https://github.com/coreos/rkt/pull/937"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/937"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/937/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/937/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/937/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/53b5866fe15b14e22ec62bd34df79fb0810a884b"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":179,"deletions":18,"changed_files":2}}