{"action":"created","comment":{"url":"https://api.github.com/repos/Eyescale/Pression/pulls/comments/23597663","id":23597663,"diff_hunk":"@@ -59,8 +59,11 @@ class PluginRegistry\n             directories.push_back( getcwd( cwd, MAXPATHLEN ));\n \n #ifdef _WIN32\n+            //rgh: does not compile, and seems to be handled by code above.\n+            /*\n             if( GetModuleFileName( 0, cwd, MAXPATHLEN ) > 0 )\n                 directories.push_back( pression::getDirname( cwd ));","path":"pression/pluginRegistry.cpp","position":16,"original_position":16,"commit_id":"1a420d2709c1484a15cb8b4c236e8497523b2634","original_commit_id":"1a420d2709c1484a15cb8b4c236e8497523b2634","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":"change it to lunchbox::getDirname(). This should fix the compilation","created_at":"2015-01-27T10:05:06Z","updated_at":"2015-01-27T10:05:06Z","html_url":"https://github.com/Eyescale/Pression/pull/2#discussion_r23597663","pull_request_url":"https://api.github.com/repos/Eyescale/Pression/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Pression/pulls/comments/23597663"},"html":{"href":"https://github.com/Eyescale/Pression/pull/2#discussion_r23597663"},"pull_request":{"href":"https://api.github.com/repos/Eyescale/Pression/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/Eyescale/Pression/pulls/2","id":28094869,"html_url":"https://github.com/Eyescale/Pression/pull/2","diff_url":"https://github.com/Eyescale/Pression/pull/2.diff","patch_url":"https://github.com/Eyescale/Pression/pull/2.patch","issue_url":"https://api.github.com/repos/Eyescale/Pression/issues/2","number":2,"state":"open","locked":false,"title":"Remove non-compiling, seemingly unneeded code. Fix include.","user":{"login":"RubenGarcia","id":1815251,"avatar_url":"https://avatars.githubusercontent.com/u/1815251?v=3","gravatar_id":"","url":"https://api.github.com/users/RubenGarcia","html_url":"https://github.com/RubenGarcia","followers_url":"https://api.github.com/users/RubenGarcia/followers","following_url":"https://api.github.com/users/RubenGarcia/following{/other_user}","gists_url":"https://api.github.com/users/RubenGarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenGarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenGarcia/subscriptions","organizations_url":"https://api.github.com/users/RubenGarcia/orgs","repos_url":"https://api.github.com/users/RubenGarcia/repos","events_url":"https://api.github.com/users/RubenGarcia/events{/privacy}","received_events_url":"https://api.github.com/users/RubenGarcia/received_events","type":"User","site_admin":false},"body":"It may be required that in line 62, code to get the %path% environment\r\nvariable is put.","created_at":"2015-01-27T09:41:23Z","updated_at":"2015-01-27T10:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b84c091f3d19948ef7e178ddfc41d94c859db5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Eyescale/Pression/pulls/2/commits","review_comments_url":"https://api.github.com/repos/Eyescale/Pression/pulls/2/comments","review_comment_url":"https://api.github.com/repos/Eyescale/Pression/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Eyescale/Pression/issues/2/comments","statuses_url":"https://api.github.com/repos/Eyescale/Pression/statuses/1a420d2709c1484a15cb8b4c236e8497523b2634","head":{"label":"RubenGarcia:master","ref":"master","sha":"1a420d2709c1484a15cb8b4c236e8497523b2634","user":{"login":"RubenGarcia","id":1815251,"avatar_url":"https://avatars.githubusercontent.com/u/1815251?v=3","gravatar_id":"","url":"https://api.github.com/users/RubenGarcia","html_url":"https://github.com/RubenGarcia","followers_url":"https://api.github.com/users/RubenGarcia/followers","following_url":"https://api.github.com/users/RubenGarcia/following{/other_user}","gists_url":"https://api.github.com/users/RubenGarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenGarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenGarcia/subscriptions","organizations_url":"https://api.github.com/users/RubenGarcia/orgs","repos_url":"https://api.github.com/users/RubenGarcia/repos","events_url":"https://api.github.com/users/RubenGarcia/events{/privacy}","received_events_url":"https://api.github.com/users/RubenGarcia/received_events","type":"User","site_admin":false},"repo":{"id":29907028,"name":"Pression","full_name":"RubenGarcia/Pression","owner":{"login":"RubenGarcia","id":1815251,"avatar_url":"https://avatars.githubusercontent.com/u/1815251?v=3","gravatar_id":"","url":"https://api.github.com/users/RubenGarcia","html_url":"https://github.com/RubenGarcia","followers_url":"https://api.github.com/users/RubenGarcia/followers","following_url":"https://api.github.com/users/RubenGarcia/following{/other_user}","gists_url":"https://api.github.com/users/RubenGarcia/gists{/gist_id}","starred_url":"https://api.github.com/users/RubenGarcia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RubenGarcia/subscriptions","organizations_url":"https://api.github.com/users/RubenGarcia/orgs","repos_url":"https://api.github.com/users/RubenGarcia/repos","events_url":"https://api.github.com/users/RubenGarcia/events{/privacy}","received_events_url":"https://api.github.com/users/RubenGarcia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RubenGarcia/Pression","description":"Compression and data transfer plugins","fork":true,"url":"https://api.github.com/repos/RubenGarcia/Pression","forks_url":"https://api.github.com/repos/RubenGarcia/Pression/forks","keys_url":"https://api.github.com/repos/RubenGarcia/Pression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RubenGarcia/Pression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RubenGarcia/Pression/teams","hooks_url":"https://api.github.com/repos/RubenGarcia/Pression/hooks","issue_events_url":"https://api.github.com/repos/RubenGarcia/Pression/issues/events{/number}","events_url":"https://api.github.com/repos/RubenGarcia/Pression/events","assignees_url":"https://api.github.com/repos/RubenGarcia/Pression/assignees{/user}","branches_url":"https://api.github.com/repos/RubenGarcia/Pression/branches{/branch}","tags_url":"https://api.github.com/repos/RubenGarcia/Pression/tags","blobs_url":"https://api.github.com/repos/RubenGarcia/Pression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RubenGarcia/Pression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RubenGarcia/Pression/git/refs{/sha}","trees_url":"https://api.github.com/repos/RubenGarcia/Pression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RubenGarcia/Pression/statuses/{sha}","languages_url":"https://api.github.com/repos/RubenGarcia/Pression/languages","stargazers_url":"https://api.github.com/repos/RubenGarcia/Pression/stargazers","contributors_url":"https://api.github.com/repos/RubenGarcia/Pression/contributors","subscribers_url":"https://api.github.com/repos/RubenGarcia/Pression/subscribers","subscription_url":"https://api.github.com/repos/RubenGarcia/Pression/subscription","commits_url":"https://api.github.com/repos/RubenGarcia/Pression/commits{/sha}","git_commits_url":"https://api.github.com/repos/RubenGarcia/Pression/git/commits{/sha}","comments_url":"https://api.github.com/repos/RubenGarcia/Pression/comments{/number}","issue_comment_url":"https://api.github.com/repos/RubenGarcia/Pression/issues/comments/{number}","contents_url":"https://api.github.com/repos/RubenGarcia/Pression/contents/{+path}","compare_url":"https://api.github.com/repos/RubenGarcia/Pression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RubenGarcia/Pression/merges","archive_url":"https://api.github.com/repos/RubenGarcia/Pression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RubenGarcia/Pression/downloads","issues_url":"https://api.github.com/repos/RubenGarcia/Pression/issues{/number}","pulls_url":"https://api.github.com/repos/RubenGarcia/Pression/pulls{/number}","milestones_url":"https://api.github.com/repos/RubenGarcia/Pression/milestones{/number}","notifications_url":"https://api.github.com/repos/RubenGarcia/Pression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RubenGarcia/Pression/labels{/name}","releases_url":"https://api.github.com/repos/RubenGarcia/Pression/releases{/id}","created_at":"2015-01-27T09:32:22Z","updated_at":"2015-01-27T09:37:57Z","pushed_at":"2015-01-27T09:37:56Z","git_url":"git://github.com/RubenGarcia/Pression.git","ssh_url":"git@github.com:RubenGarcia/Pression.git","clone_url":"https://github.com/RubenGarcia/Pression.git","svn_url":"https://github.com/RubenGarcia/Pression","homepage":null,"size":439,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Eyescale:master","ref":"master","sha":"a322c91b70b5df2a26ce6f6f13f630934ab22f3c","user":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"repo":{"id":27916172,"name":"Pression","full_name":"Eyescale/Pression","owner":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eyescale/Pression","description":"Compression and data transfer plugins","fork":false,"url":"https://api.github.com/repos/Eyescale/Pression","forks_url":"https://api.github.com/repos/Eyescale/Pression/forks","keys_url":"https://api.github.com/repos/Eyescale/Pression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eyescale/Pression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eyescale/Pression/teams","hooks_url":"https://api.github.com/repos/Eyescale/Pression/hooks","issue_events_url":"https://api.github.com/repos/Eyescale/Pression/issues/events{/number}","events_url":"https://api.github.com/repos/Eyescale/Pression/events","assignees_url":"https://api.github.com/repos/Eyescale/Pression/assignees{/user}","branches_url":"https://api.github.com/repos/Eyescale/Pression/branches{/branch}","tags_url":"https://api.github.com/repos/Eyescale/Pression/tags","blobs_url":"https://api.github.com/repos/Eyescale/Pression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eyescale/Pression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eyescale/Pression/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eyescale/Pression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eyescale/Pression/statuses/{sha}","languages_url":"https://api.github.com/repos/Eyescale/Pression/languages","stargazers_url":"https://api.github.com/repos/Eyescale/Pression/stargazers","contributors_url":"https://api.github.com/repos/Eyescale/Pression/contributors","subscribers_url":"https://api.github.com/repos/Eyescale/Pression/subscribers","subscription_url":"https://api.github.com/repos/Eyescale/Pression/subscription","commits_url":"https://api.github.com/repos/Eyescale/Pression/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eyescale/Pression/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eyescale/Pression/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eyescale/Pression/issues/comments/{number}","contents_url":"https://api.github.com/repos/Eyescale/Pression/contents/{+path}","compare_url":"https://api.github.com/repos/Eyescale/Pression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eyescale/Pression/merges","archive_url":"https://api.github.com/repos/Eyescale/Pression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eyescale/Pression/downloads","issues_url":"https://api.github.com/repos/Eyescale/Pression/issues{/number}","pulls_url":"https://api.github.com/repos/Eyescale/Pression/pulls{/number}","milestones_url":"https://api.github.com/repos/Eyescale/Pression/milestones{/number}","notifications_url":"https://api.github.com/repos/Eyescale/Pression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eyescale/Pression/labels{/name}","releases_url":"https://api.github.com/repos/Eyescale/Pression/releases{/id}","created_at":"2014-12-12T10:35:12Z","updated_at":"2015-01-21T16:23:05Z","pushed_at":"2015-01-21T16:23:04Z","git_url":"git://github.com/Eyescale/Pression.git","ssh_url":"git@github.com:Eyescale/Pression.git","clone_url":"https://github.com/Eyescale/Pression.git","svn_url":"https://github.com/Eyescale/Pression","homepage":null,"size":439,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Pression/pulls/2"},"html":{"href":"https://github.com/Eyescale/Pression/pull/2"},"issue":{"href":"https://api.github.com/repos/Eyescale/Pression/issues/2"},"comments":{"href":"https://api.github.com/repos/Eyescale/Pression/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/Eyescale/Pression/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/Eyescale/Pression/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Eyescale/Pression/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/Eyescale/Pression/statuses/1a420d2709c1484a15cb8b4c236e8497523b2634"}}}}