{"comment":{"url":"https://api.github.com/repos/burmanm/hawkular-metrics/comments/13024461","html_url":"https://github.com/burmanm/hawkular-metrics/commit/589b371f178ff8b7f8f1dd704a63119346fa9f4a#commitcomment-13024461","id":13024461,"user":{"login":"stefannegrea","id":3912943,"avatar_url":"https://avatars.githubusercontent.com/u/3912943?v=3","gravatar_id":"","url":"https://api.github.com/users/stefannegrea","html_url":"https://github.com/stefannegrea","followers_url":"https://api.github.com/users/stefannegrea/followers","following_url":"https://api.github.com/users/stefannegrea/following{/other_user}","gists_url":"https://api.github.com/users/stefannegrea/gists{/gist_id}","starred_url":"https://api.github.com/users/stefannegrea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefannegrea/subscriptions","organizations_url":"https://api.github.com/users/stefannegrea/orgs","repos_url":"https://api.github.com/users/stefannegrea/repos","events_url":"https://api.github.com/users/stefannegrea/events{/privacy}","received_events_url":"https://api.github.com/users/stefannegrea/received_events","type":"User","site_admin":false},"position":35,"line":35,"path":"api/metrics-api-common/src/main/java/org/hawkular/metrics/api/jaxrs/util/MetricTypeTextConverter.java","commit_id":"589b371f178ff8b7f8f1dd704a63119346fa9f4a","created_at":"2015-09-02T14:22:28Z","updated_at":"2015-09-02T14:22:28Z","body":"It's not so much about compilation but about covering all the known cases. If later we decide to add 'xyz' type, but it is no covered by this code, it should thrown an exception, not just be processed by the fall-through code. It's just safer programming to limit the options."}}