{"action":"closed","number":456,"pull_request":{"url":"https://api.github.com/repos/google/physical-web/pulls/456","id":39428262,"html_url":"https://github.com/google/physical-web/pull/456","diff_url":"https://github.com/google/physical-web/pull/456.diff","patch_url":"https://github.com/google/physical-web/pull/456.patch","issue_url":"https://api.github.com/repos/google/physical-web/issues/456","number":456,"state":"closed","locked":false,"title":"[android] Require explicit call to DL favicon","user":{"login":"cco3","id":236057,"avatar_url":"https://avatars.githubusercontent.com/u/236057?v=3","gravatar_id":"","url":"https://api.github.com/users/cco3","html_url":"https://github.com/cco3","followers_url":"https://api.github.com/users/cco3/followers","following_url":"https://api.github.com/users/cco3/following{/other_user}","gists_url":"https://api.github.com/users/cco3/gists{/gist_id}","starred_url":"https://api.github.com/users/cco3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cco3/subscriptions","organizations_url":"https://api.github.com/users/cco3/orgs","repos_url":"https://api.github.com/users/cco3/repos","events_url":"https://api.github.com/users/cco3/events{/privacy}","received_events_url":"https://api.github.com/users/cco3/received_events","type":"User","site_admin":false},"body":"This is desirable for three reasons:\r\n\r\n1. These are independent features of the PWS, the calls should be made\r\n   distinct\r\n2. The BeaconConfigFragment doesn't use the icon, so we shouldn't\r\n   download it\r\n3. When we start caching PWOs in the discovery service, we'll need to\r\n   fetch icons if we already have the url metadata, but no icon.","created_at":"2015-07-07T23:34:49Z","updated_at":"2015-07-08T19:23:36Z","closed_at":"2015-07-08T19:23:36Z","merged_at":"2015-07-08T19:23:36Z","merge_commit_sha":"bef6089de23c2dee5cde7868c02e2db8636ce6e4","assignee":{"login":"matthewsibigtroth","id":6209944,"avatar_url":"https://avatars.githubusercontent.com/u/6209944?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewsibigtroth","html_url":"https://github.com/matthewsibigtroth","followers_url":"https://api.github.com/users/matthewsibigtroth/followers","following_url":"https://api.github.com/users/matthewsibigtroth/following{/other_user}","gists_url":"https://api.github.com/users/matthewsibigtroth/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewsibigtroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewsibigtroth/subscriptions","organizations_url":"https://api.github.com/users/matthewsibigtroth/orgs","repos_url":"https://api.github.com/users/matthewsibigtroth/repos","events_url":"https://api.github.com/users/matthewsibigtroth/events{/privacy}","received_events_url":"https://api.github.com/users/matthewsibigtroth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/google/physical-web/pulls/456/commits","review_comments_url":"https://api.github.com/repos/google/physical-web/pulls/456/comments","review_comment_url":"https://api.github.com/repos/google/physical-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/physical-web/issues/456/comments","statuses_url":"https://api.github.com/repos/google/physical-web/statuses/53b78bcaf6c5cb84d14cac3904f7ac3d844d598b","head":{"label":"cco3:requestimage","ref":"requestimage","sha":"53b78bcaf6c5cb84d14cac3904f7ac3d844d598b","user":{"login":"cco3","id":236057,"avatar_url":"https://avatars.githubusercontent.com/u/236057?v=3","gravatar_id":"","url":"https://api.github.com/users/cco3","html_url":"https://github.com/cco3","followers_url":"https://api.github.com/users/cco3/followers","following_url":"https://api.github.com/users/cco3/following{/other_user}","gists_url":"https://api.github.com/users/cco3/gists{/gist_id}","starred_url":"https://api.github.com/users/cco3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cco3/subscriptions","organizations_url":"https://api.github.com/users/cco3/orgs","repos_url":"https://api.github.com/users/cco3/repos","events_url":"https://api.github.com/users/cco3/events{/privacy}","received_events_url":"https://api.github.com/users/cco3/received_events","type":"User","site_admin":false},"repo":{"id":32601630,"name":"physical-web","full_name":"cco3/physical-web","owner":{"login":"cco3","id":236057,"avatar_url":"https://avatars.githubusercontent.com/u/236057?v=3","gravatar_id":"","url":"https://api.github.com/users/cco3","html_url":"https://github.com/cco3","followers_url":"https://api.github.com/users/cco3/followers","following_url":"https://api.github.com/users/cco3/following{/other_user}","gists_url":"https://api.github.com/users/cco3/gists{/gist_id}","starred_url":"https://api.github.com/users/cco3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cco3/subscriptions","organizations_url":"https://api.github.com/users/cco3/orgs","repos_url":"https://api.github.com/users/cco3/repos","events_url":"https://api.github.com/users/cco3/events{/privacy}","received_events_url":"https://api.github.com/users/cco3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cco3/physical-web","description":"The Physical Web: walk up and use anything","fork":true,"url":"https://api.github.com/repos/cco3/physical-web","forks_url":"https://api.github.com/repos/cco3/physical-web/forks","keys_url":"https://api.github.com/repos/cco3/physical-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cco3/physical-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cco3/physical-web/teams","hooks_url":"https://api.github.com/repos/cco3/physical-web/hooks","issue_events_url":"https://api.github.com/repos/cco3/physical-web/issues/events{/number}","events_url":"https://api.github.com/repos/cco3/physical-web/events","assignees_url":"https://api.github.com/repos/cco3/physical-web/assignees{/user}","branches_url":"https://api.github.com/repos/cco3/physical-web/branches{/branch}","tags_url":"https://api.github.com/repos/cco3/physical-web/tags","blobs_url":"https://api.github.com/repos/cco3/physical-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cco3/physical-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cco3/physical-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/cco3/physical-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cco3/physical-web/statuses/{sha}","languages_url":"https://api.github.com/repos/cco3/physical-web/languages","stargazers_url":"https://api.github.com/repos/cco3/physical-web/stargazers","contributors_url":"https://api.github.com/repos/cco3/physical-web/contributors","subscribers_url":"https://api.github.com/repos/cco3/physical-web/subscribers","subscription_url":"https://api.github.com/repos/cco3/physical-web/subscription","commits_url":"https://api.github.com/repos/cco3/physical-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/cco3/physical-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/cco3/physical-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/cco3/physical-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/cco3/physical-web/contents/{+path}","compare_url":"https://api.github.com/repos/cco3/physical-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cco3/physical-web/merges","archive_url":"https://api.github.com/repos/cco3/physical-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cco3/physical-web/downloads","issues_url":"https://api.github.com/repos/cco3/physical-web/issues{/number}","pulls_url":"https://api.github.com/repos/cco3/physical-web/pulls{/number}","milestones_url":"https://api.github.com/repos/cco3/physical-web/milestones{/number}","notifications_url":"https://api.github.com/repos/cco3/physical-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cco3/physical-web/labels{/name}","releases_url":"https://api.github.com/repos/cco3/physical-web/releases{/id}","created_at":"2015-03-20T18:58:58Z","updated_at":"2015-03-20T18:58:58Z","pushed_at":"2015-07-08T19:07:10Z","git_url":"git://github.com/cco3/physical-web.git","ssh_url":"git@github.com:cco3/physical-web.git","clone_url":"https://github.com/cco3/physical-web.git","svn_url":"https://github.com/cco3/physical-web","homepage":"http://physical-web.org","size":8837,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"137843dc098be939abd277de0949536a89a29bfe","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":24650339,"name":"physical-web","full_name":"google/physical-web","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/physical-web","description":"The Physical Web: walk up and use anything","fork":false,"url":"https://api.github.com/repos/google/physical-web","forks_url":"https://api.github.com/repos/google/physical-web/forks","keys_url":"https://api.github.com/repos/google/physical-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/physical-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/physical-web/teams","hooks_url":"https://api.github.com/repos/google/physical-web/hooks","issue_events_url":"https://api.github.com/repos/google/physical-web/issues/events{/number}","events_url":"https://api.github.com/repos/google/physical-web/events","assignees_url":"https://api.github.com/repos/google/physical-web/assignees{/user}","branches_url":"https://api.github.com/repos/google/physical-web/branches{/branch}","tags_url":"https://api.github.com/repos/google/physical-web/tags","blobs_url":"https://api.github.com/repos/google/physical-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/physical-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/physical-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/physical-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/physical-web/statuses/{sha}","languages_url":"https://api.github.com/repos/google/physical-web/languages","stargazers_url":"https://api.github.com/repos/google/physical-web/stargazers","contributors_url":"https://api.github.com/repos/google/physical-web/contributors","subscribers_url":"https://api.github.com/repos/google/physical-web/subscribers","subscription_url":"https://api.github.com/repos/google/physical-web/subscription","commits_url":"https://api.github.com/repos/google/physical-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/physical-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/physical-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/physical-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/physical-web/contents/{+path}","compare_url":"https://api.github.com/repos/google/physical-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/physical-web/merges","archive_url":"https://api.github.com/repos/google/physical-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/physical-web/downloads","issues_url":"https://api.github.com/repos/google/physical-web/issues{/number}","pulls_url":"https://api.github.com/repos/google/physical-web/pulls{/number}","milestones_url":"https://api.github.com/repos/google/physical-web/milestones{/number}","notifications_url":"https://api.github.com/repos/google/physical-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/physical-web/labels{/name}","releases_url":"https://api.github.com/repos/google/physical-web/releases{/id}","created_at":"2014-09-30T18:32:14Z","updated_at":"2015-07-08T14:30:53Z","pushed_at":"2015-07-08T19:23:36Z","git_url":"git://github.com/google/physical-web.git","ssh_url":"git@github.com:google/physical-web.git","clone_url":"https://github.com/google/physical-web.git","svn_url":"https://github.com/google/physical-web","homepage":"http://physical-web.org","size":11091,"stargazers_count":4034,"watchers_count":4034,"language":"Objective-C","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":404,"mirror_url":null,"open_issues_count":19,"forks":404,"open_issues":19,"watchers":4034,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/physical-web/pulls/456"},"html":{"href":"https://github.com/google/physical-web/pull/456"},"issue":{"href":"https://api.github.com/repos/google/physical-web/issues/456"},"comments":{"href":"https://api.github.com/repos/google/physical-web/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/google/physical-web/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/google/physical-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/physical-web/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/google/physical-web/statuses/53b78bcaf6c5cb84d14cac3904f7ac3d844d598b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cco3","id":236057,"avatar_url":"https://avatars.githubusercontent.com/u/236057?v=3","gravatar_id":"","url":"https://api.github.com/users/cco3","html_url":"https://github.com/cco3","followers_url":"https://api.github.com/users/cco3/followers","following_url":"https://api.github.com/users/cco3/following{/other_user}","gists_url":"https://api.github.com/users/cco3/gists{/gist_id}","starred_url":"https://api.github.com/users/cco3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cco3/subscriptions","organizations_url":"https://api.github.com/users/cco3/orgs","repos_url":"https://api.github.com/users/cco3/repos","events_url":"https://api.github.com/users/cco3/events{/privacy}","received_events_url":"https://api.github.com/users/cco3/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":35,"deletions":16,"changed_files":4}}