{"action":"created","issue":{"url":"https://api.github.com/repos/kevinkhill/lavacharts/issues/84","labels_url":"https://api.github.com/repos/kevinkhill/lavacharts/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/kevinkhill/lavacharts/issues/84/comments","events_url":"https://api.github.com/repos/kevinkhill/lavacharts/issues/84/events","html_url":"https://github.com/kevinkhill/lavacharts/issues/84","id":122516842,"number":84,"title":"addRow() is generating wrong output when taking DataCell as input for any cell","user":{"login":"antoniotajuelo","id":1245328,"avatar_url":"https://avatars.githubusercontent.com/u/1245328?v=3","gravatar_id":"","url":"https://api.github.com/users/antoniotajuelo","html_url":"https://github.com/antoniotajuelo","followers_url":"https://api.github.com/users/antoniotajuelo/followers","following_url":"https://api.github.com/users/antoniotajuelo/following{/other_user}","gists_url":"https://api.github.com/users/antoniotajuelo/gists{/gist_id}","starred_url":"https://api.github.com/users/antoniotajuelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoniotajuelo/subscriptions","organizations_url":"https://api.github.com/users/antoniotajuelo/orgs","repos_url":"https://api.github.com/users/antoniotajuelo/repos","events_url":"https://api.github.com/users/antoniotajuelo/events{/privacy}","received_events_url":"https://api.github.com/users/antoniotajuelo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-16T14:35:37Z","updated_at":"2015-12-18T13:32:28Z","closed_at":null,"body":"Hello,\r\n\r\naddRow() is working in an unexpected way. If you use addRow() and pass a DataCell as input for any cell, it generates wrong input.\r\n\r\nExample:\r\n$chart->addRow(array(2015, new DataCell(0.8,'80%')));\r\n\r\nFix:\r\nIn file lavacharts/src/Configs/DataTable.php, line 378 should be replaced with:\r\n                          if(is_object($optCellArray[$index])) {\r\n                            $rowVals[] = array('v' => $optCellArray[$index]->v,'f' => $optCellArray[$index]->f,'p' => $optCellArray[$index]->p);\r\n                          } else {\r\n                            $rowVals[] = array('v' => $optCellArray[$index]);\r\n                          }"},"comment":{"url":"https://api.github.com/repos/kevinkhill/lavacharts/issues/comments/165779486","html_url":"https://github.com/kevinkhill/lavacharts/issues/84#issuecomment-165779486","issue_url":"https://api.github.com/repos/kevinkhill/lavacharts/issues/84","id":165779486,"user":{"login":"kevinkhill","id":266076,"avatar_url":"https://avatars.githubusercontent.com/u/266076?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinkhill","html_url":"https://github.com/kevinkhill","followers_url":"https://api.github.com/users/kevinkhill/followers","following_url":"https://api.github.com/users/kevinkhill/following{/other_user}","gists_url":"https://api.github.com/users/kevinkhill/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkhill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkhill/subscriptions","organizations_url":"https://api.github.com/users/kevinkhill/orgs","repos_url":"https://api.github.com/users/kevinkhill/repos","events_url":"https://api.github.com/users/kevinkhill/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkhill/received_events","type":"User","site_admin":false},"created_at":"2015-12-18T13:32:28Z","updated_at":"2015-12-18T13:32:28Z","body":"Ah, yes, I see. You're right, I don't think I currently support that capability. I am in the middle of getting v3 out the door, so I will add this to my list of todos once it is released. I have quit working on the codebase for now so I can finish the docs. Although, if you want to whip up a pull request with that functionality, I'd happily merge it in."}}