{"action":"created","issue":{"url":"https://api.github.com/repos/d11wtq/dockerpty/issues/36","labels_url":"https://api.github.com/repos/d11wtq/dockerpty/issues/36/labels{/name}","comments_url":"https://api.github.com/repos/d11wtq/dockerpty/issues/36/comments","events_url":"https://api.github.com/repos/d11wtq/dockerpty/issues/36/events","html_url":"https://github.com/d11wtq/dockerpty/pull/36","id":70218304,"number":36,"title":"handle partial writes correctly","user":{"login":"zwily","id":4167,"avatar_url":"https://avatars.githubusercontent.com/u/4167?v=3","gravatar_id":"","url":"https://api.github.com/users/zwily","html_url":"https://github.com/zwily","followers_url":"https://api.github.com/users/zwily/followers","following_url":"https://api.github.com/users/zwily/following{/other_user}","gists_url":"https://api.github.com/users/zwily/gists{/gist_id}","starred_url":"https://api.github.com/users/zwily/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zwily/subscriptions","organizations_url":"https://api.github.com/users/zwily/orgs","repos_url":"https://api.github.com/users/zwily/repos","events_url":"https://api.github.com/users/zwily/events{/privacy}","received_events_url":"https://api.github.com/users/zwily/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-04-22T19:47:36Z","updated_at":"2015-04-24T12:46:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/d11wtq/dockerpty/pulls/36","html_url":"https://github.com/d11wtq/dockerpty/pull/36","diff_url":"https://github.com/d11wtq/dockerpty/pull/36.diff","patch_url":"https://github.com/d11wtq/dockerpty/pull/36.patch"},"body":"This is an attempt to fix #26. os.write() does not guarantee that it\r\nwill write the entire string given. This change creates a buffer to\r\nstore the remainder of partial writes, and adds streams with pending\r\ndata to the main select loop so we can attempt to flush the data."},"comment":{"url":"https://api.github.com/repos/d11wtq/dockerpty/issues/comments/95921322","html_url":"https://github.com/d11wtq/dockerpty/pull/36#issuecomment-95921322","issue_url":"https://api.github.com/repos/d11wtq/dockerpty/issues/36","id":95921322,"user":{"login":"aanand","id":1062,"avatar_url":"https://avatars.githubusercontent.com/u/1062?v=3","gravatar_id":"","url":"https://api.github.com/users/aanand","html_url":"https://github.com/aanand","followers_url":"https://api.github.com/users/aanand/followers","following_url":"https://api.github.com/users/aanand/following{/other_user}","gists_url":"https://api.github.com/users/aanand/gists{/gist_id}","starred_url":"https://api.github.com/users/aanand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aanand/subscriptions","organizations_url":"https://api.github.com/users/aanand/orgs","repos_url":"https://api.github.com/users/aanand/repos","events_url":"https://api.github.com/users/aanand/events{/privacy}","received_events_url":"https://api.github.com/users/aanand/received_events","type":"User","site_admin":false},"created_at":"2015-04-24T12:46:05Z","updated_at":"2015-04-24T12:46:05Z","body":"OK, this now seems to work. Thanks! Not sure why the tests are failing though.\r\n\r\nCan any of it be simplified? If `_hijack_tty` is poking aroud inside Pump's attributes, that suggests Pump isn't a great abstraction right now."}}