{"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments/48186462","id":48186462,"diff_hunk":"@@ -9,8 +9,10 @@\n #include \"TitaniumWindows/Map/Annotation.hpp\"\n #include \"TitaniumWindows/Utility.hpp\"\n #include \"Titanium/detail/TiLogger.hpp\"\n+#include \"Titanium/detail/TiImpl.hpp\"\n+#include \"TitaniumWindows/WindowsMacros.hpp\"\n \n-#if WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP\n+#if defined(IS_WINDOWS_PHONE)","path":"Source/Map/src/Annotation.cpp","position":8,"original_position":8,"commit_id":"4fc7b81bb1ad42f66ec4cf902f24ca94a810b65a","original_commit_id":"4fc7b81bb1ad42f66ec4cf902f24ca94a810b65a","user":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"body":"I believe both maps and geolocation is now universal in Windows 10, so this needs to check for either Windows Phone 8.1 || Windows 10.\r\n\r\nhttps://msdn.microsoft.com/library/windows/apps/windows.ui.xaml.controls.maps.aspx\r\nhttps://msdn.microsoft.com/en-us/library/windows/apps/xaml/windows.devices.geolocation.aspx\r\n\r\n","created_at":"2015-12-21T20:19:13Z","updated_at":"2015-12-21T20:19:13Z","html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/512#discussion_r48186462","pull_request_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments/48186462"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/512#discussion_r48186462"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512","id":54259251,"html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/512","diff_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/512.diff","patch_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/512.patch","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/512","number":512,"state":"open","locked":false,"title":"Add platform-specific (store or phone only) guard macros","user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"body":"Fix for [TIMOB-20064](https://jira.appcelerator.org/browse/TIMOB-20064)\r\n\r\nAdd platform-specific (store or phone only) guard macros\r\n\r\n## Definitions\r\n```\r\n#if (WINVER >= 0x0A00)\r\n#define IS_WINDOWS_10\r\n#define IS_WINDOWS_MOBILE (Windows::System::Profile::AnalyticsInfo::VersionInfo->DeviceFamily == \"Windows.Mobile\")\r\n#else\r\n#if WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP\r\n#define IS_WINDOWS_PHONE\r\n#endif\r\n#endif\r\n```\r\n\r\n## Usage\r\n- `IS_WINDOWS_10`     ... Windows 10\r\n- `IS_WINDOWS_MOBILE` ... Windows 10 Mobile\r\n- `IS_WINDOWS_PHONE`  ... Windows Phone\r\n- `TitaniumWindows::Utility::IsWindowsPhoneOrMobile()` ... Windows 10 Mobile or Windows 8.1 Phone\r\n\r\n`#if WINAPI_FAMILY == WINAPI_FAMILY_PHONE_APP` -> `#if defined(IS_WINDOWS_PHONE)`\r\n`#if (WINVER >= 0x0A00)` -> `#if defined(IS_WINDOWS_10)`\r\n\r\n","created_at":"2015-12-21T14:03:28Z","updated_at":"2015-12-21T20:19:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca2cd533016cee1bce920f5e1e70e4ad77e1f35","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512/commits","review_comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512/comments","review_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/512/comments","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/4fc7b81bb1ad42f66ec4cf902f24ca94a810b65a","head":{"label":"infosia:TIMOB-20064","ref":"TIMOB-20064","sha":"4fc7b81bb1ad42f66ec4cf902f24ca94a810b65a","user":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"repo":{"id":33272635,"name":"titanium_mobile_windows","full_name":"infosia/titanium_mobile_windows","owner":{"login":"infosia","id":1661068,"avatar_url":"https://avatars.githubusercontent.com/u/1661068?v=3","gravatar_id":"","url":"https://api.github.com/users/infosia","html_url":"https://github.com/infosia","followers_url":"https://api.github.com/users/infosia/followers","following_url":"https://api.github.com/users/infosia/following{/other_user}","gists_url":"https://api.github.com/users/infosia/gists{/gist_id}","starred_url":"https://api.github.com/users/infosia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/infosia/subscriptions","organizations_url":"https://api.github.com/users/infosia/orgs","repos_url":"https://api.github.com/users/infosia/repos","events_url":"https://api.github.com/users/infosia/events{/privacy}","received_events_url":"https://api.github.com/users/infosia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/infosia/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":true,"url":"https://api.github.com/repos/infosia/titanium_mobile_windows","forks_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/infosia/titanium_mobile_windows/releases{/id}","created_at":"2015-04-01T20:57:51Z","updated_at":"2015-05-08T01:24:55Z","pushed_at":"2015-12-21T13:55:20Z","git_url":"git://github.com/infosia/titanium_mobile_windows.git","ssh_url":"git@github.com:infosia/titanium_mobile_windows.git","clone_url":"https://github.com/infosia/titanium_mobile_windows.git","svn_url":"https://github.com/infosia/titanium_mobile_windows","homepage":null,"size":60455,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"b6d8581bf00f9ce2e0b5b7477656ecd532c0a618","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":27684398,"name":"titanium_mobile_windows","full_name":"appcelerator/titanium_mobile_windows","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":false,"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows","forks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/releases{/id}","created_at":"2014-12-07T20:55:18Z","updated_at":"2015-12-01T09:55:28Z","pushed_at":"2015-12-21T20:02:22Z","git_url":"git://github.com/appcelerator/titanium_mobile_windows.git","ssh_url":"git@github.com:appcelerator/titanium_mobile_windows.git","clone_url":"https://github.com/appcelerator/titanium_mobile_windows.git","svn_url":"https://github.com/appcelerator/titanium_mobile_windows","homepage":null,"size":66140,"stargazers_count":8,"watchers_count":8,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":3,"forks":11,"open_issues":3,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/512"},"issue":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/512"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/512/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/512/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/4fc7b81bb1ad42f66ec4cf902f24ca94a810b65a"}}}}