{"action":"created","issue":{"url":"https://api.github.com/repos/mzabriskie/react-disqus-thread/issues/15","labels_url":"https://api.github.com/repos/mzabriskie/react-disqus-thread/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/mzabriskie/react-disqus-thread/issues/15/comments","events_url":"https://api.github.com/repos/mzabriskie/react-disqus-thread/issues/15/events","html_url":"https://github.com/mzabriskie/react-disqus-thread/issues/15","id":122122245,"number":15,"title":"Props don't update","user":{"login":"mzabriskie","id":199035,"avatar_url":"https://avatars.githubusercontent.com/u/199035?v=3","gravatar_id":"","url":"https://api.github.com/users/mzabriskie","html_url":"https://github.com/mzabriskie","followers_url":"https://api.github.com/users/mzabriskie/followers","following_url":"https://api.github.com/users/mzabriskie/following{/other_user}","gists_url":"https://api.github.com/users/mzabriskie/gists{/gist_id}","starred_url":"https://api.github.com/users/mzabriskie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzabriskie/subscriptions","organizations_url":"https://api.github.com/users/mzabriskie/orgs","repos_url":"https://api.github.com/users/mzabriskie/repos","events_url":"https://api.github.com/users/mzabriskie/events{/privacy}","received_events_url":"https://api.github.com/users/mzabriskie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-14T20:17:25Z","updated_at":"2015-12-14T20:26:01Z","closed_at":null,"body":"If I have a component like this:\r\n\r\n```js\r\nconstructor(props) {\r\n  super(props);\r\n\r\n  this.state = {\r\n    commentsVisible: false\r\n  };\r\n}\r\n\r\nhandleCommentsClick() {\r\n  this.setState({\r\n    commentsVisible: !this.state.commentsVisible\r\n  });\r\n}\r\n\r\nrender() {\r\n  var className = this.state.commentsVisible ? '' : 'hidden';\r\n  var message = this.state.commentsVisible ? 'Hide Comments' : 'View Comments';\r\n\r\n  return (\r\n    <div>\r\n      <a href=\"#\" onClick={this.handleCommentsClick}>\r\n        {message}\r\n      </a>\r\n      <DisqusThread\r\n        className={className}\r\n        shortname=\"myshortname\"\r\n        identifier=\"example\"\r\n        title=\"Foo\"\r\n      />\r\n    </div>\r\n  ); \r\n}\r\n```\r\n\r\nThe comments will never be displayed. This is because `shouldComponentUpdate` only checks if the `id` or `url` prop has changed. I think it would be better to just remove this function entirely."},"comment":{"url":"https://api.github.com/repos/mzabriskie/react-disqus-thread/issues/comments/164549266","html_url":"https://github.com/mzabriskie/react-disqus-thread/issues/15#issuecomment-164549266","issue_url":"https://api.github.com/repos/mzabriskie/react-disqus-thread/issues/15","id":164549266,"user":{"login":"sashashakun","id":5776864,"avatar_url":"https://avatars.githubusercontent.com/u/5776864?v=3","gravatar_id":"","url":"https://api.github.com/users/sashashakun","html_url":"https://github.com/sashashakun","followers_url":"https://api.github.com/users/sashashakun/followers","following_url":"https://api.github.com/users/sashashakun/following{/other_user}","gists_url":"https://api.github.com/users/sashashakun/gists{/gist_id}","starred_url":"https://api.github.com/users/sashashakun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sashashakun/subscriptions","organizations_url":"https://api.github.com/users/sashashakun/orgs","repos_url":"https://api.github.com/users/sashashakun/repos","events_url":"https://api.github.com/users/sashashakun/events{/privacy}","received_events_url":"https://api.github.com/users/sashashakun/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T20:26:01Z","updated_at":"2015-12-14T20:26:01Z","body":"Hello, is I understand properly, that you're talking about removing checking for ```id``` or ```url``` changing?"}}