{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/3516","labels_url":"https://api.github.com/repos/netty/netty/issues/3516/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/3516/comments","events_url":"https://api.github.com/repos/netty/netty/issues/3516/events","html_url":"https://github.com/netty/netty/pull/3516","id":63140386,"number":3516,"title":"Fix GOAWAY logic in Http2Encoder and Http2Decoder.","user":{"login":"buchgr","id":1388179,"avatar_url":"https://avatars.githubusercontent.com/u/1388179?v=3","gravatar_id":"","url":"https://api.github.com/users/buchgr","html_url":"https://github.com/buchgr","followers_url":"https://api.github.com/users/buchgr/followers","following_url":"https://api.github.com/users/buchgr/following{/other_user}","gists_url":"https://api.github.com/users/buchgr/gists{/gist_id}","starred_url":"https://api.github.com/users/buchgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchgr/subscriptions","organizations_url":"https://api.github.com/users/buchgr/orgs","repos_url":"https://api.github.com/users/buchgr/repos","events_url":"https://api.github.com/users/buchgr/events{/privacy}","received_events_url":"https://api.github.com/users/buchgr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/netty/netty/labels/defect","name":"defect","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/netty/netty/milestones/112","html_url":"https://github.com/netty/netty/milestones/4.1.0.Beta5","labels_url":"https://api.github.com/repos/netty/netty/milestones/112/labels","id":1005380,"number":112,"title":"4.1.0.Beta5","description":"","creator":{"login":"normanmaurer","id":439362,"avatar_url":"https://avatars.githubusercontent.com/u/439362?v=3","gravatar_id":"","url":"https://api.github.com/users/normanmaurer","html_url":"https://github.com/normanmaurer","followers_url":"https://api.github.com/users/normanmaurer/followers","following_url":"https://api.github.com/users/normanmaurer/following{/other_user}","gists_url":"https://api.github.com/users/normanmaurer/gists{/gist_id}","starred_url":"https://api.github.com/users/normanmaurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normanmaurer/subscriptions","organizations_url":"https://api.github.com/users/normanmaurer/orgs","repos_url":"https://api.github.com/users/normanmaurer/repos","events_url":"https://api.github.com/users/normanmaurer/events{/privacy}","received_events_url":"https://api.github.com/users/normanmaurer/received_events","type":"User","site_admin":false},"open_issues":59,"closed_issues":13,"state":"open","created_at":"2015-03-04T09:22:23Z","updated_at":"2015-03-20T07:59:38Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-03-20T02:18:31Z","updated_at":"2015-03-22T01:46:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3516","html_url":"https://github.com/netty/netty/pull/3516","diff_url":"https://github.com/netty/netty/pull/3516.diff","patch_url":"https://github.com/netty/netty/pull/3516.patch"},"body":"Motivation:\r\n\r\n1) The current implementation doesn't allow for HEADERS, DATA, PING, PRIORITY and SETTINGS\r\n   frames to be sent after GOAWAY.\r\n\r\n2) When receiving or sending a GOAWAY frame, all streams with ids greater than the lastStreamId\r\n   of the GOAWAY frame should be closed. That's not happening.\r\n\r\nModifications:\r\n\r\n1) Allow sending of HEADERS and DATA frames after GOAWAY for streams with ids < lastStreamId.\r\n2) Always allow sending PING, PRIORITY AND SETTINGS frames.\r\n3) Allow sending multiple GOAWAY frames with decreasing lastStreamIds.\r\n4) After receiving or sending a GOAWAY frame, close all streams with ids > lastStreamId.\r\n\r\nResult:\r\n\r\nThe GOAWAY handling is more correct."},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/84491377","html_url":"https://github.com/netty/netty/pull/3516#issuecomment-84491377","issue_url":"https://api.github.com/repos/netty/netty/issues/3516","id":84491377,"user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"created_at":"2015-03-22T01:46:29Z","updated_at":"2015-03-22T01:46:29Z","body":"@buchgr - Are you now in agreement that we should be more careful about using `isGoAwaySent` and `isGoAwayRecieved` more carefully (https://github.com/netty/netty/pull/3516#issuecomment-83921372) to account for each peer's last stream id?"}}