{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/io.js/issues/1922","labels_url":"https://api.github.com/repos/nodejs/io.js/issues/1922/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/1922/comments","events_url":"https://api.github.com/repos/nodejs/io.js/issues/1922/events","html_url":"https://github.com/nodejs/io.js/pull/1922","id":86472389,"number":1922,"title":"buffer: prevent failed assertions","user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/io.js/labels/buffer","name":"buffer","color":"f7c6c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-06-09T06:28:35Z","updated_at":"2015-06-09T23:18:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/1922","html_url":"https://github.com/nodejs/io.js/pull/1922","diff_url":"https://github.com/nodejs/io.js/pull/1922.diff","patch_url":"https://github.com/nodejs/io.js/pull/1922.patch"},"body":"This commit adds `assert()` calls in JS, which prevents non-buffer\r\ninstances from triggering failed C++ assertions (killing the process).\r\n\r\nThey will now die with an `AssertionError`. `Buffer.prototype.copy` had to\r\nbe wrapped in JS to allow for the assertion, with a modification to the\r\narguments passed.\r\n\r\nFixes: https://github.com/nodejs/io.js/issues/1485\r\n\r\nFollows https://github.com/nodejs/io.js/pull/1486."},"comment":{"url":"https://api.github.com/repos/nodejs/io.js/issues/comments/110530367","html_url":"https://github.com/nodejs/io.js/pull/1922#issuecomment-110530367","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/1922","id":110530367,"user":{"login":"brendanashworth","id":3038254,"avatar_url":"https://avatars.githubusercontent.com/u/3038254?v=3","gravatar_id":"","url":"https://api.github.com/users/brendanashworth","html_url":"https://github.com/brendanashworth","followers_url":"https://api.github.com/users/brendanashworth/followers","following_url":"https://api.github.com/users/brendanashworth/following{/other_user}","gists_url":"https://api.github.com/users/brendanashworth/gists{/gist_id}","starred_url":"https://api.github.com/users/brendanashworth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendanashworth/subscriptions","organizations_url":"https://api.github.com/users/brendanashworth/orgs","repos_url":"https://api.github.com/users/brendanashworth/repos","events_url":"https://api.github.com/users/brendanashworth/events{/privacy}","received_events_url":"https://api.github.com/users/brendanashworth/received_events","type":"User","site_admin":false},"created_at":"2015-06-09T23:18:54Z","updated_at":"2015-06-09T23:18:54Z","body":"@trevnorris should I continue with this PR then? or would you like to just keep it with yours?"}}