{"action":"created","issue":{"url":"https://api.github.com/repos/azatoth/twinkle/issues/295","labels_url":"https://api.github.com/repos/azatoth/twinkle/issues/295/labels{/name}","comments_url":"https://api.github.com/repos/azatoth/twinkle/issues/295/comments","events_url":"https://api.github.com/repos/azatoth/twinkle/issues/295/events","html_url":"https://github.com/azatoth/twinkle/pull/295","id":109730325,"number":295,"title":"Reporting if page has been protected before! And minor morebits.css change","user":{"login":"MusikAnimal","id":366374,"avatar_url":"https://avatars.githubusercontent.com/u/366374?v=3","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-10-05T04:42:12Z","updated_at":"2015-10-07T05:23:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/azatoth/twinkle/pulls/295","html_url":"https://github.com/azatoth/twinkle/pull/295","diff_url":"https://github.com/azatoth/twinkle/pull/295.diff","patch_url":"https://github.com/azatoth/twinkle/pull/295.patch"},"body":"Fairly sizable update to the protect module that could use another set of eyes.\r\n\r\nWhen protecting a page, admins must first check the protection log to make an informed decision on the duration. Just as with the block module, I've made it report if there were prior protection periods, and link to the protection log if there were. Here we also have to do a separate API call to fetch the pending changes log.\r\n\r\nNext, I've included the log notice and current protection notice to be visible for all users, not just admins. We often get requests for semi-protection when the page is semi-protected, and the log info is useful for them to decide what duration to request and to explain their rationale. We also want to use meaningful colours to grab the user's attention. For instance, here again, if a page is already protected we want that to be clear so they don't request the same level of protection. So \"no protection\" appears as green and if there is a current protection the message will appear in red. The log messages are also in red as that is crucial information for the admins. This puts the log/current state colours in line with the block module.\r\n\r\nFinally, a minor CSS change. To conditionally include one or two links to the logs (protect or pending changes), I need to use a `<span>` wrapper so I could pass it to Morebits.status. There might be a better way of doing this, not sure, but I noticed with each child span the alignment gets increasingly off. Turns out we've got a `vertical-align:middle` on the text, which I think we only need for inline images which appears to only include the ui-icon. I tested on various modules and multiple browsers and everything looks good.\r\n\r\n@atlight mind taking a look? Or any other Twinkle followers? :)"},"comment":{"url":"https://api.github.com/repos/azatoth/twinkle/issues/comments/146079981","html_url":"https://github.com/azatoth/twinkle/pull/295#issuecomment-146079981","issue_url":"https://api.github.com/repos/azatoth/twinkle/issues/295","id":146079981,"user":{"login":"MusikAnimal","id":366374,"avatar_url":"https://avatars.githubusercontent.com/u/366374?v=3","gravatar_id":"","url":"https://api.github.com/users/MusikAnimal","html_url":"https://github.com/MusikAnimal","followers_url":"https://api.github.com/users/MusikAnimal/followers","following_url":"https://api.github.com/users/MusikAnimal/following{/other_user}","gists_url":"https://api.github.com/users/MusikAnimal/gists{/gist_id}","starred_url":"https://api.github.com/users/MusikAnimal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MusikAnimal/subscriptions","organizations_url":"https://api.github.com/users/MusikAnimal/orgs","repos_url":"https://api.github.com/users/MusikAnimal/repos","events_url":"https://api.github.com/users/MusikAnimal/events{/privacy}","received_events_url":"https://api.github.com/users/MusikAnimal/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T05:23:58Z","updated_at":"2015-10-07T05:23:58Z","body":"@atlight barring objections I'm going to move forward with this. Many thanks for your time"}}