{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3296","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3296/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3296/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3296/events","html_url":"https://github.com/cockroachdb/cockroach/pull/3296","id":120046922,"number":3296,"title":"Fix broken gossip acceptance test","user":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars.githubusercontent.com/u/6147149?v=3","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tschottdorf","id":5076964,"avatar_url":"https://avatars.githubusercontent.com/u/5076964?v=3","gravatar_id":"","url":"https://api.github.com/users/tschottdorf","html_url":"https://github.com/tschottdorf","followers_url":"https://api.github.com/users/tschottdorf/followers","following_url":"https://api.github.com/users/tschottdorf/following{/other_user}","gists_url":"https://api.github.com/users/tschottdorf/gists{/gist_id}","starred_url":"https://api.github.com/users/tschottdorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tschottdorf/subscriptions","organizations_url":"https://api.github.com/users/tschottdorf/orgs","repos_url":"https://api.github.com/users/tschottdorf/repos","events_url":"https://api.github.com/users/tschottdorf/events{/privacy}","received_events_url":"https://api.github.com/users/tschottdorf/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-12-02T22:09:00Z","updated_at":"2015-12-06T17:10:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/3296","html_url":"https://github.com/cockroachdb/cockroach/pull/3296","diff_url":"https://github.com/cockroachdb/cockroach/pull/3296.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/3296.patch"},"body":"Restored ClientDisconnectRedundant unittest (it got lost in the shuffle).\r\nTweaked the usage of Gossip.SetNodeID and Gossip.SetNodeDescriptor\r\nsuch that Gossip.SetNodeID MUST be called and that SetNodeDescriptor()\r\nisn't sufficient. Previously, either would set the NodeID, which seems\r\nwrong--there should be one way only to do it.\r\n\r\nChanged the bootstrapper code to pause between bootstrapping attempts\r\nto prevent busy bootstrapping if the sentinel node simply isn't\r\navailable and there's a small gossip network.\r\n\r\nChanged Store.maybeGossipFirstRange to include a retry loop to continue\r\ntrying with a relatively tight exponential backoff (max backoff is 1s)\r\nin the event that the leader lease is inconclusive. We don't want to be\r\nbound by the 60s cluster ID gossip interval. This is what was tripping\r\nup the gossip peerings test.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/3296)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/162329709","html_url":"https://github.com/cockroachdb/cockroach/pull/3296#issuecomment-162329709","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/3296","id":162329709,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars.githubusercontent.com/u/160562?v=3","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2015-12-06T17:10:24Z","updated_at":"2015-12-06T17:10:24Z","body":"LGTM\n\n---\n\nReview status: all files reviewed at latest revision, 9 unresolved discussions.\n\n---\n\n*[gossip/gossip.go, line 180 \\[r1\\]](https://reviewable.io:443/reviews/cockroachdb/cockroach/3296#-K4Zn89laFRTiTC3uBrJ:-K4sF6mcxAsRK4xrnzfq:289822682) ([raw file](https://github.com/cockroachdb/cockroach/blob/5bc08068d8cbe2b55630eb5ad0032c597959c9b4/gossip/gossip.go#L180)):*\nIt doesn't seem like this should be a `log.Errorf` - probably a panic unless you want to return an error to every call site.\n\n---\n\n\n*Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/cockroachdb/cockroach/3296#-:-K4sGSEwwtfzndv2I_c9:676834233)*\n<!-- Sent from Reviewable.io -->\n"}}