{"action":"created","issue":{"url":"https://api.github.com/repos/mikera/core.matrix/issues/264","labels_url":"https://api.github.com/repos/mikera/core.matrix/issues/264/labels{/name}","comments_url":"https://api.github.com/repos/mikera/core.matrix/issues/264/comments","events_url":"https://api.github.com/repos/mikera/core.matrix/issues/264/events","html_url":"https://github.com/mikera/core.matrix/issues/264","id":123716012,"number":264,"title":"immutable function type parameter?","user":{"login":"carocad","id":10408729,"avatar_url":"https://avatars.githubusercontent.com/u/10408729?v=3","gravatar_id":"","url":"https://api.github.com/users/carocad","html_url":"https://github.com/carocad","followers_url":"https://api.github.com/users/carocad/followers","following_url":"https://api.github.com/users/carocad/following{/other_user}","gists_url":"https://api.github.com/users/carocad/gists{/gist_id}","starred_url":"https://api.github.com/users/carocad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carocad/subscriptions","organizations_url":"https://api.github.com/users/carocad/orgs","repos_url":"https://api.github.com/users/carocad/repos","events_url":"https://api.github.com/users/carocad/events{/privacy}","received_events_url":"https://api.github.com/users/carocad/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mikera/core.matrix/labels/question","name":"question","color":"cc317c"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-12-23T20:05:22Z","updated_at":"2015-12-27T09:04:33Z","closed_at":"2015-12-27T09:04:33Z","body":"Hey guys,\r\nFirst of all I'm not fully sure if this issue should be in this repo or in the vectorz-clj.\r\nMy issue/question is regarding the \"immutable\" function of core.matrix. According to the documentation it says that two parameters can be passed; data and type. Obviously data is the matrix that I want to make immutable but what is type? is this a documentation bug or is it right? because when I checked the vectorz-clj implementation of that protocol, only the data parameters was being passed.\r\n\r\nAlso if possible I would like to know if the immutable function does the job in O(1) time as with the transient/persistent Clojure equivalent or does it create a complete new matrix? I ask this because if a person took the job of creating a mutable matrix and then making it immutable, then that person is obviously interested in performance.\r\n\r\nthanks in advance"},"comment":{"url":"https://api.github.com/repos/mikera/core.matrix/issues/comments/167395932","html_url":"https://github.com/mikera/core.matrix/issues/264#issuecomment-167395932","issue_url":"https://api.github.com/repos/mikera/core.matrix/issues/264","id":167395932,"user":{"login":"mikera","id":212007,"avatar_url":"https://avatars.githubusercontent.com/u/212007?v=3","gravatar_id":"","url":"https://api.github.com/users/mikera","html_url":"https://github.com/mikera","followers_url":"https://api.github.com/users/mikera/followers","following_url":"https://api.github.com/users/mikera/following{/other_user}","gists_url":"https://api.github.com/users/mikera/gists{/gist_id}","starred_url":"https://api.github.com/users/mikera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikera/subscriptions","organizations_url":"https://api.github.com/users/mikera/orgs","repos_url":"https://api.github.com/users/mikera/repos","events_url":"https://api.github.com/users/mikera/events{/privacy}","received_events_url":"https://api.github.com/users/mikera/received_events","type":"User","site_admin":false},"created_at":"2015-12-27T09:04:33Z","updated_at":"2015-12-27T09:04:33Z","body":"I've removed the redundant parameter for the moment, will be absent in next release. Thanks for the report!"}}