{"action":"opened","number":27,"pull_request":{"url":"https://api.github.com/repos/php-school/cli-menu/pulls/27","id":54178013,"html_url":"https://github.com/php-school/cli-menu/pull/27","diff_url":"https://github.com/php-school/cli-menu/pull/27.diff","patch_url":"https://github.com/php-school/cli-menu/pull/27.patch","issue_url":"https://api.github.com/repos/php-school/cli-menu/issues/27","number":27,"state":"open","locked":false,"title":"Split ASCII art justification code into its own class.","user":{"login":"thehereward","id":5547470,"avatar_url":"https://avatars.githubusercontent.com/u/5547470?v=3","gravatar_id":"","url":"https://api.github.com/users/thehereward","html_url":"https://github.com/thehereward","followers_url":"https://api.github.com/users/thehereward/followers","following_url":"https://api.github.com/users/thehereward/following{/other_user}","gists_url":"https://api.github.com/users/thehereward/gists{/gist_id}","starred_url":"https://api.github.com/users/thehereward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehereward/subscriptions","organizations_url":"https://api.github.com/users/thehereward/orgs","repos_url":"https://api.github.com/users/thehereward/repos","events_url":"https://api.github.com/users/thehereward/events{/privacy}","received_events_url":"https://api.github.com/users/thehereward/received_events","type":"User","site_admin":false},"body":"I think this is a little bit of an improvement, but possibly not as much as I originally hoped it would be... But I enjoyed writing it so it's not necessarily all wasted effort.\r\n\r\nIt certainly separates out concerns (AsciiArtItem now no longer concerns itself with how to justify its contents) which I think is a bit easier to understand now. Whether its worth the addition of the extra class is a decision I'll leave up to you. :-)","created_at":"2015-12-19T12:41:38Z","updated_at":"2015-12-19T12:41:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php-school/cli-menu/pulls/27/commits","review_comments_url":"https://api.github.com/repos/php-school/cli-menu/pulls/27/comments","review_comment_url":"https://api.github.com/repos/php-school/cli-menu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php-school/cli-menu/issues/27/comments","statuses_url":"https://api.github.com/repos/php-school/cli-menu/statuses/386fef5720a5b9d8d0fcb41009b10020dbee7a57","head":{"label":"thehereward:refactor-ascii-art","ref":"refactor-ascii-art","sha":"386fef5720a5b9d8d0fcb41009b10020dbee7a57","user":{"login":"thehereward","id":5547470,"avatar_url":"https://avatars.githubusercontent.com/u/5547470?v=3","gravatar_id":"","url":"https://api.github.com/users/thehereward","html_url":"https://github.com/thehereward","followers_url":"https://api.github.com/users/thehereward/followers","following_url":"https://api.github.com/users/thehereward/following{/other_user}","gists_url":"https://api.github.com/users/thehereward/gists{/gist_id}","starred_url":"https://api.github.com/users/thehereward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehereward/subscriptions","organizations_url":"https://api.github.com/users/thehereward/orgs","repos_url":"https://api.github.com/users/thehereward/repos","events_url":"https://api.github.com/users/thehereward/events{/privacy}","received_events_url":"https://api.github.com/users/thehereward/received_events","type":"User","site_admin":false},"repo":{"id":48246344,"name":"cli-menu","full_name":"thehereward/cli-menu","owner":{"login":"thehereward","id":5547470,"avatar_url":"https://avatars.githubusercontent.com/u/5547470?v=3","gravatar_id":"","url":"https://api.github.com/users/thehereward","html_url":"https://github.com/thehereward","followers_url":"https://api.github.com/users/thehereward/followers","following_url":"https://api.github.com/users/thehereward/following{/other_user}","gists_url":"https://api.github.com/users/thehereward/gists{/gist_id}","starred_url":"https://api.github.com/users/thehereward/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thehereward/subscriptions","organizations_url":"https://api.github.com/users/thehereward/orgs","repos_url":"https://api.github.com/users/thehereward/repos","events_url":"https://api.github.com/users/thehereward/events{/privacy}","received_events_url":"https://api.github.com/users/thehereward/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thehereward/cli-menu","description":"Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.","fork":true,"url":"https://api.github.com/repos/thehereward/cli-menu","forks_url":"https://api.github.com/repos/thehereward/cli-menu/forks","keys_url":"https://api.github.com/repos/thehereward/cli-menu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thehereward/cli-menu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thehereward/cli-menu/teams","hooks_url":"https://api.github.com/repos/thehereward/cli-menu/hooks","issue_events_url":"https://api.github.com/repos/thehereward/cli-menu/issues/events{/number}","events_url":"https://api.github.com/repos/thehereward/cli-menu/events","assignees_url":"https://api.github.com/repos/thehereward/cli-menu/assignees{/user}","branches_url":"https://api.github.com/repos/thehereward/cli-menu/branches{/branch}","tags_url":"https://api.github.com/repos/thehereward/cli-menu/tags","blobs_url":"https://api.github.com/repos/thehereward/cli-menu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thehereward/cli-menu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thehereward/cli-menu/git/refs{/sha}","trees_url":"https://api.github.com/repos/thehereward/cli-menu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thehereward/cli-menu/statuses/{sha}","languages_url":"https://api.github.com/repos/thehereward/cli-menu/languages","stargazers_url":"https://api.github.com/repos/thehereward/cli-menu/stargazers","contributors_url":"https://api.github.com/repos/thehereward/cli-menu/contributors","subscribers_url":"https://api.github.com/repos/thehereward/cli-menu/subscribers","subscription_url":"https://api.github.com/repos/thehereward/cli-menu/subscription","commits_url":"https://api.github.com/repos/thehereward/cli-menu/commits{/sha}","git_commits_url":"https://api.github.com/repos/thehereward/cli-menu/git/commits{/sha}","comments_url":"https://api.github.com/repos/thehereward/cli-menu/comments{/number}","issue_comment_url":"https://api.github.com/repos/thehereward/cli-menu/issues/comments{/number}","contents_url":"https://api.github.com/repos/thehereward/cli-menu/contents/{+path}","compare_url":"https://api.github.com/repos/thehereward/cli-menu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thehereward/cli-menu/merges","archive_url":"https://api.github.com/repos/thehereward/cli-menu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thehereward/cli-menu/downloads","issues_url":"https://api.github.com/repos/thehereward/cli-menu/issues{/number}","pulls_url":"https://api.github.com/repos/thehereward/cli-menu/pulls{/number}","milestones_url":"https://api.github.com/repos/thehereward/cli-menu/milestones{/number}","notifications_url":"https://api.github.com/repos/thehereward/cli-menu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thehereward/cli-menu/labels{/name}","releases_url":"https://api.github.com/repos/thehereward/cli-menu/releases{/id}","created_at":"2015-12-18T16:56:36Z","updated_at":"2015-12-18T16:56:40Z","pushed_at":"2015-12-19T12:35:56Z","git_url":"git://github.com/thehereward/cli-menu.git","ssh_url":"git@github.com:thehereward/cli-menu.git","clone_url":"https://github.com/thehereward/cli-menu.git","svn_url":"https://github.com/thehereward/cli-menu","homepage":"","size":95,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php-school:master","ref":"master","sha":"1243e86f42c4b468e2c94747467963057191666f","user":{"login":"php-school","id":14904751,"avatar_url":"https://avatars.githubusercontent.com/u/14904751?v=3","gravatar_id":"","url":"https://api.github.com/users/php-school","html_url":"https://github.com/php-school","followers_url":"https://api.github.com/users/php-school/followers","following_url":"https://api.github.com/users/php-school/following{/other_user}","gists_url":"https://api.github.com/users/php-school/gists{/gist_id}","starred_url":"https://api.github.com/users/php-school/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-school/subscriptions","organizations_url":"https://api.github.com/users/php-school/orgs","repos_url":"https://api.github.com/users/php-school/repos","events_url":"https://api.github.com/users/php-school/events{/privacy}","received_events_url":"https://api.github.com/users/php-school/received_events","type":"Organization","site_admin":false},"repo":{"id":44531557,"name":"cli-menu","full_name":"php-school/cli-menu","owner":{"login":"php-school","id":14904751,"avatar_url":"https://avatars.githubusercontent.com/u/14904751?v=3","gravatar_id":"","url":"https://api.github.com/users/php-school","html_url":"https://github.com/php-school","followers_url":"https://api.github.com/users/php-school/followers","following_url":"https://api.github.com/users/php-school/following{/other_user}","gists_url":"https://api.github.com/users/php-school/gists{/gist_id}","starred_url":"https://api.github.com/users/php-school/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php-school/subscriptions","organizations_url":"https://api.github.com/users/php-school/orgs","repos_url":"https://api.github.com/users/php-school/repos","events_url":"https://api.github.com/users/php-school/events{/privacy}","received_events_url":"https://api.github.com/users/php-school/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php-school/cli-menu","description":"Build beautiful PHP CLI menus. Simple yet Powerful. Expressive DSL.","fork":false,"url":"https://api.github.com/repos/php-school/cli-menu","forks_url":"https://api.github.com/repos/php-school/cli-menu/forks","keys_url":"https://api.github.com/repos/php-school/cli-menu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php-school/cli-menu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php-school/cli-menu/teams","hooks_url":"https://api.github.com/repos/php-school/cli-menu/hooks","issue_events_url":"https://api.github.com/repos/php-school/cli-menu/issues/events{/number}","events_url":"https://api.github.com/repos/php-school/cli-menu/events","assignees_url":"https://api.github.com/repos/php-school/cli-menu/assignees{/user}","branches_url":"https://api.github.com/repos/php-school/cli-menu/branches{/branch}","tags_url":"https://api.github.com/repos/php-school/cli-menu/tags","blobs_url":"https://api.github.com/repos/php-school/cli-menu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php-school/cli-menu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php-school/cli-menu/git/refs{/sha}","trees_url":"https://api.github.com/repos/php-school/cli-menu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php-school/cli-menu/statuses/{sha}","languages_url":"https://api.github.com/repos/php-school/cli-menu/languages","stargazers_url":"https://api.github.com/repos/php-school/cli-menu/stargazers","contributors_url":"https://api.github.com/repos/php-school/cli-menu/contributors","subscribers_url":"https://api.github.com/repos/php-school/cli-menu/subscribers","subscription_url":"https://api.github.com/repos/php-school/cli-menu/subscription","commits_url":"https://api.github.com/repos/php-school/cli-menu/commits{/sha}","git_commits_url":"https://api.github.com/repos/php-school/cli-menu/git/commits{/sha}","comments_url":"https://api.github.com/repos/php-school/cli-menu/comments{/number}","issue_comment_url":"https://api.github.com/repos/php-school/cli-menu/issues/comments{/number}","contents_url":"https://api.github.com/repos/php-school/cli-menu/contents/{+path}","compare_url":"https://api.github.com/repos/php-school/cli-menu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php-school/cli-menu/merges","archive_url":"https://api.github.com/repos/php-school/cli-menu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php-school/cli-menu/downloads","issues_url":"https://api.github.com/repos/php-school/cli-menu/issues{/number}","pulls_url":"https://api.github.com/repos/php-school/cli-menu/pulls{/number}","milestones_url":"https://api.github.com/repos/php-school/cli-menu/milestones{/number}","notifications_url":"https://api.github.com/repos/php-school/cli-menu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php-school/cli-menu/labels{/name}","releases_url":"https://api.github.com/repos/php-school/cli-menu/releases{/id}","created_at":"2015-10-19T12:00:28Z","updated_at":"2015-12-19T03:38:38Z","pushed_at":"2015-12-19T12:22:38Z","git_url":"git://github.com/php-school/cli-menu.git","ssh_url":"git@github.com:php-school/cli-menu.git","clone_url":"https://github.com/php-school/cli-menu.git","svn_url":"https://github.com/php-school/cli-menu","homepage":"","size":91,"stargazers_count":386,"watchers_count":386,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":5,"forks":16,"open_issues":5,"watchers":386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php-school/cli-menu/pulls/27"},"html":{"href":"https://github.com/php-school/cli-menu/pull/27"},"issue":{"href":"https://api.github.com/repos/php-school/cli-menu/issues/27"},"comments":{"href":"https://api.github.com/repos/php-school/cli-menu/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/php-school/cli-menu/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/php-school/cli-menu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php-school/cli-menu/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/php-school/cli-menu/statuses/386fef5720a5b9d8d0fcb41009b10020dbee7a57"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":82,"deletions":24,"changed_files":2}}