{"action":"created","issue":{"url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/issues/303","labels_url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/issues/303/labels{/name}","comments_url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/issues/303/comments","events_url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/issues/303/events","html_url":"https://github.com/cleanflight/cleanflight-configurator/pull/303","id":122630973,"number":303,"title":"MSP_SET_RXFAIL_CONFIG changed to allow more future RX channels","user":{"login":"ProDrone","id":7206988,"avatar_url":"https://avatars.githubusercontent.com/u/7206988?v=3","gravatar_id":"","url":"https://api.github.com/users/ProDrone","html_url":"https://github.com/ProDrone","followers_url":"https://api.github.com/users/ProDrone/followers","following_url":"https://api.github.com/users/ProDrone/following{/other_user}","gists_url":"https://api.github.com/users/ProDrone/gists{/gist_id}","starred_url":"https://api.github.com/users/ProDrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProDrone/subscriptions","organizations_url":"https://api.github.com/users/ProDrone/orgs","repos_url":"https://api.github.com/users/ProDrone/repos","events_url":"https://api.github.com/users/ProDrone/events{/privacy}","received_events_url":"https://api.github.com/users/ProDrone/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-16T23:53:42Z","updated_at":"2015-12-17T10:38:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/pulls/303","html_url":"https://github.com/cleanflight/cleanflight-configurator/pull/303","diff_url":"https://github.com/cleanflight/cleanflight-configurator/pull/303.diff","patch_url":"https://github.com/cleanflight/cleanflight-configurator/pull/303.patch"},"body":"@hydra This is the change you mentioned on IRC the other day:\r\n~~~\r\n[22:04] <hydra_> ProDrone: if we ever support more than 18 channels we will have a problem with this:\r\n[22:04] <hydra_> #define MSP_SET_RXFAIL_CONFIG           78 //in message          Sets RXFAIL settings\r\n[22:04] <hydra_> #define INBUF_SIZE 64\r\n[22:05] <hydra_> 18 * 3 = 54\r\n[22:05] <hydra_> just so you're aware.\r\n[22:05] <hydra_> a different approach is taken for things like the LED_STRIP configuration, etc.\r\n[22:06] <hydra_> an index is supplied with the data. and one message is set for each index that needs to be sent.\r\n[22:07] <hydra_> in an alternative world the FC would then be sent up to 18 rxfail messages, each with an index and 3 extra bytes payload\r\n[22:07] <hydra_> no worries.  might be worth doing this now before the next configurator and CF release\r\n[22:07] <hydra_> see if you think it's worth it.\r\n[22:08] <hydra_> it simplifies the FC code but complicates the configurator code, but a pattern is already set in the configurator so you can follow it.\r\n[22:09] <hydra_> it's not complicated to do either.\r\n[22:09] <hydra_> I'll merge the configurator changes now, since they will work with the current code.\r\n[22:09] <hydra_> then you can give me a PR for both if you have time.\r\n~~~\r\n\r\n__NOTES:__\r\n- This goes together with cleanflight pull request: https://github.com/cleanflight/cleanflight/pull/1590\r\n- Includes a bug-fix for saving the LED strip config.\r\n- Includes some other bug-fixes to prevent processing of zero length data."},"comment":{"url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/issues/comments/165415744","html_url":"https://github.com/cleanflight/cleanflight-configurator/pull/303#issuecomment-165415744","issue_url":"https://api.github.com/repos/cleanflight/cleanflight-configurator/issues/303","id":165415744,"user":{"login":"ProDrone","id":7206988,"avatar_url":"https://avatars.githubusercontent.com/u/7206988?v=3","gravatar_id":"","url":"https://api.github.com/users/ProDrone","html_url":"https://github.com/ProDrone","followers_url":"https://api.github.com/users/ProDrone/followers","following_url":"https://api.github.com/users/ProDrone/following{/other_user}","gists_url":"https://api.github.com/users/ProDrone/gists{/gist_id}","starred_url":"https://api.github.com/users/ProDrone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProDrone/subscriptions","organizations_url":"https://api.github.com/users/ProDrone/orgs","repos_url":"https://api.github.com/users/ProDrone/repos","events_url":"https://api.github.com/users/ProDrone/events{/privacy}","received_events_url":"https://api.github.com/users/ProDrone/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T10:38:22Z","updated_at":"2015-12-17T10:38:22Z","body":"@hydra cameCase corrected. Added some bugfixes. Squashed and rebased."}}