{"action":"created","issue":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2672","labels_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2672/labels{/name}","comments_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2672/comments","events_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2672/events","html_url":"https://github.com/checkstyle/checkstyle/pull/2672","id":120868753,"number":2672,"title":"Issue #2523: Make DetectorOptions as final and immutable","user":{"login":"MEZk","id":7242568,"avatar_url":"https://avatars.githubusercontent.com/u/7242568?v=3","gravatar_id":"","url":"https://api.github.com/users/MEZk","html_url":"https://github.com/MEZk","followers_url":"https://api.github.com/users/MEZk/followers","following_url":"https://api.github.com/users/MEZk/following{/other_user}","gists_url":"https://api.github.com/users/MEZk/gists{/gist_id}","starred_url":"https://api.github.com/users/MEZk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MEZk/subscriptions","organizations_url":"https://api.github.com/users/MEZk/orgs","repos_url":"https://api.github.com/users/MEZk/repos","events_url":"https://api.github.com/users/MEZk/events{/privacy}","received_events_url":"https://api.github.com/users/MEZk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-07T21:11:35Z","updated_at":"2015-12-13T15:25:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/checkstyle/checkstyle/pulls/2672","html_url":"https://github.com/checkstyle/checkstyle/pull/2672","diff_url":"https://github.com/checkstyle/checkstyle/pull/2672.diff","patch_url":"https://github.com/checkstyle/checkstyle/pull/2672.patch"},"body":"@romani \r\nI need your advice on how to resolve PMD and IDEA Inspections violations:\r\n\r\nPMD:\r\n`\r\nPMD Failure: com.puppycrawl.tools.checkstyle.checks.regexp.DetectorOptions:128 Rule:AccessorClassGeneration Priority:3 Avoid instantiation through private constructors from outside of the constructors class..\r\n`\r\nhttps://pmd.github.io/pmd-5.4.1/pmd-java/rules/java/design.html#AccessorClassGeneration\r\n\r\nIDEA Inspections:\r\nEncapsulation issues - Package-visible inner class (1)\r\nDescription: `Reports package-local inner classes. \r\nUse the first checkbox below to ignore package-local inner enums.\r\nUse the seconds checkbox below to ignore package-local inner interface.\r\n`\r\n\r\nMemory issues - Return of instance of anonymous, local or inner class (9)\r\nDescription: `Reports return statements returning an instance of an anonymous, local, or inner class. Such instances keep an implicit reference to the outer instance. Which means the instance can prevent the outer instance from being garbage collected. Any caller of a method which returns such an instance might cause a memory leak by holding on to the instance returned.\r\nUse the checkbox below to ignore returns from protected or package-local methods. Returns from private methods are always ignored.\r\n`\r\n\r\n```\r\nEncapsulation issues:\r\nDetectorOptions.java (1)\r\n132: Builder Package-visible inner class Builder\r\n```\r\n\r\n```\r\nMemory issues:\r\nDetectorOptions.java (9)\r\n128: newBuilder() Return of instance of non-static inner class Builder\r\n144: format() Return of instance of non-static inner class Builder\r\n154: message() Return of instance of non-static inner class Builder\r\n164: minimum() Return of instance of non-static inner class Builder\r\n174: maximum() Return of instance of non-static inner class Builder\r\n184: ignoreCase() Return of instance of non-static inner class Builder\r\n194: reporter() Return of instance of non-static inner class Builder\r\n204: compileFlags() Return of instance of non-static inner class Builder\r\n214: suppressor() Return of instance of non-static inner class Builder\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/checkstyle/checkstyle/issues/comments/164267896","html_url":"https://github.com/checkstyle/checkstyle/pull/2672#issuecomment-164267896","issue_url":"https://api.github.com/repos/checkstyle/checkstyle/issues/2672","id":164267896,"user":{"login":"romani","id":812984,"avatar_url":"https://avatars.githubusercontent.com/u/812984?v=3","gravatar_id":"","url":"https://api.github.com/users/romani","html_url":"https://github.com/romani","followers_url":"https://api.github.com/users/romani/followers","following_url":"https://api.github.com/users/romani/following{/other_user}","gists_url":"https://api.github.com/users/romani/gists{/gist_id}","starred_url":"https://api.github.com/users/romani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romani/subscriptions","organizations_url":"https://api.github.com/users/romani/orgs","repos_url":"https://api.github.com/users/romani/repos","events_url":"https://api.github.com/users/romani/events{/privacy}","received_events_url":"https://api.github.com/users/romani/received_events","type":"User","site_admin":false},"created_at":"2015-12-13T15:25:46Z","updated_at":"2015-12-13T15:25:46Z","body":"Please squash commits to ease review"}}