{"action":"created","comment":{"url":"https://api.github.com/repos/jasnell/dev-policy/pulls/comments/27781850","id":27781850,"diff_hunk":"@@ -20,68 +20,66 @@ Like the TSC governance, all issues and pull requests follow a Consensus Seeking\n \n Collaborators may opt to elevate significant or controversial modifications, or modifications that have not found consensus to the TSC for discussion by assigning the tsc-agenda tag to a pull request or issue. The TSC should serve as the final arbiter where required.\n \n-If full TSC review is not required, and there is a Working Group whose charter covers the subject of the issue or pull request, then it can be tagged using a Working Group specific tag (to be selected by the Working Group itself). In such cases, the WG can decide whether to further elevate the item to the full tsc (using the *tsc-agenda* tag) or decide on the matter itself. \n+If full TSC review is not required, and there is a Working Group whose charter covers the subject of the issue or pull request, then it can be tagged using a Working Group specific tag (to be selected by the Working Group itself). In such cases, the WG can decide whether to further elevate the item to the full tsc (using the *tsc-agenda* tag) or decide on the matter itself.\n \n In either case, issues or PR’s for which additional review is required should have the review-required tag added and removed only after either the Working Group or TSC decision has been made.\n \n ### Accepting Modifications\n \n-A “Contribution” to the project is any work that is voluntarily submitted to the project. These include not only source code in the form of bug fixes, code improvements, new functions, etc, but contributions to documentation, design etc that are intended for the overall improvement of the project.\n+A \"Contribution\" to the project is any work that is voluntarily submitted to the project. These include not only source code in the form of bug fixes, code improvements, new functions, etc, but contributions to documentation, design etc that are intended for the overall improvement of the project.\n \n-Contributions to the Project are made on a collaborative basis. Any individual with a GitHub account may propose a contribution by submitting a Pull Request (PR). Contributions must be evaluated by project Collaborators with sufficient expertise and approved using the Consensus Seeking Process described above. \n+Contributions to the Project are made on a collaborative basis. Any individual with a GitHub account may propose a contribution by submitting a Pull Request (PR). Contributions must be evaluated by project Collaborators with sufficient expertise and approved using the Consensus Seeking Process described above.\n \n-Pull Requests submitted by individuals who are currently not Collaborators must be sponsored by an existing Collaborator before the PR will be considered. The sponsoring Collaborator becomes responsible for the PR.\n+All Pull Requests submitted by individuals who are not currently Collaborators must be signed-off on by an existing Collaborator before the PR will be considered. The sponsoring Collaborator becomes responsible for the PR.\n \n-Before any Pull Request can be accepted into the project, it must be signed-off by at least two Collaborators (the submitting / sponsoring Collaborator and one additional Collaborator with sufficient expertise to evaluate the specific PR). \n+Pull Requests from an existing Collaborator must be signed-off on by at least one other Collaborator with sufficient expertise to evaluate the specific PR. Collaborators are encouraged to seek additional review and sign-off for non-trivial changes. A Trivial Change is any which fixes minor bugs or improves performance without affecting API or causing other wide-reaching impact.","path":"README.md","position":30,"original_position":30,"commit_id":"8a530497dc27478890c7c21c205aafe87c12a5c1","original_commit_id":"8a530497dc27478890c7c21c205aafe87c12a5c1","user":{"login":"chrisdickinson","id":37303,"avatar_url":"https://avatars.githubusercontent.com/u/37303?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisdickinson","html_url":"https://github.com/chrisdickinson","followers_url":"https://api.github.com/users/chrisdickinson/followers","following_url":"https://api.github.com/users/chrisdickinson/following{/other_user}","gists_url":"https://api.github.com/users/chrisdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdickinson/subscriptions","organizations_url":"https://api.github.com/users/chrisdickinson/orgs","repos_url":"https://api.github.com/users/chrisdickinson/repos","events_url":"https://api.github.com/users/chrisdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdickinson/received_events","type":"User","site_admin":false},"body":"9 times out of 10 review is the best way to go. However, humans being humans, there will always be exceptions to this rule – I err towards encoding that understanding into the document. That way we can point to the document solely, instead of having a document plus some oral history about when it's okay to bend or break the rule.","created_at":"2015-04-06T00:31:33Z","updated_at":"2015-04-06T00:31:33Z","html_url":"https://github.com/jasnell/dev-policy/pull/11#discussion_r27781850","pull_request_url":"https://api.github.com/repos/jasnell/dev-policy/pulls/11","_links":{"self":{"href":"https://api.github.com/repos/jasnell/dev-policy/pulls/comments/27781850"},"html":{"href":"https://github.com/jasnell/dev-policy/pull/11#discussion_r27781850"},"pull_request":{"href":"https://api.github.com/repos/jasnell/dev-policy/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/jasnell/dev-policy/pulls/11","id":32643299,"html_url":"https://github.com/jasnell/dev-policy/pull/11","diff_url":"https://github.com/jasnell/dev-policy/pull/11.diff","patch_url":"https://github.com/jasnell/dev-policy/pull/11.patch","issue_url":"https://api.github.com/repos/jasnell/dev-policy/issues/11","number":11,"state":"open","locked":false,"title":"doc: numerous edits","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"body":"Numerous edits based on feedback received thus far.\n\n1. Clarifications to sign-off rule\n2. Remove review-required\n3. Structure improvements\n4. Addressing security related commits and exceptions to process and\nversioning rules for security related commits\n5. Suggested LTS policy (suggested by jasnell)\n6. Other minor edits","created_at":"2015-04-05T03:05:28Z","updated_at":"2015-04-06T00:31:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2653238f967e107670291ffa802cb3cb58217ade","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jasnell/dev-policy/pulls/11/commits","review_comments_url":"https://api.github.com/repos/jasnell/dev-policy/pulls/11/comments","review_comment_url":"https://api.github.com/repos/jasnell/dev-policy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jasnell/dev-policy/issues/11/comments","statuses_url":"https://api.github.com/repos/jasnell/dev-policy/statuses/8a530497dc27478890c7c21c205aafe87c12a5c1","head":{"label":"jasnell:20150404-edits","ref":"20150404-edits","sha":"8a530497dc27478890c7c21c205aafe87c12a5c1","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"repo":{"id":33390841,"name":"dev-policy","full_name":"jasnell/dev-policy","owner":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasnell/dev-policy","description":"node-foundation dev policy **draft**","fork":false,"url":"https://api.github.com/repos/jasnell/dev-policy","forks_url":"https://api.github.com/repos/jasnell/dev-policy/forks","keys_url":"https://api.github.com/repos/jasnell/dev-policy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasnell/dev-policy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasnell/dev-policy/teams","hooks_url":"https://api.github.com/repos/jasnell/dev-policy/hooks","issue_events_url":"https://api.github.com/repos/jasnell/dev-policy/issues/events{/number}","events_url":"https://api.github.com/repos/jasnell/dev-policy/events","assignees_url":"https://api.github.com/repos/jasnell/dev-policy/assignees{/user}","branches_url":"https://api.github.com/repos/jasnell/dev-policy/branches{/branch}","tags_url":"https://api.github.com/repos/jasnell/dev-policy/tags","blobs_url":"https://api.github.com/repos/jasnell/dev-policy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasnell/dev-policy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasnell/dev-policy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasnell/dev-policy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasnell/dev-policy/statuses/{sha}","languages_url":"https://api.github.com/repos/jasnell/dev-policy/languages","stargazers_url":"https://api.github.com/repos/jasnell/dev-policy/stargazers","contributors_url":"https://api.github.com/repos/jasnell/dev-policy/contributors","subscribers_url":"https://api.github.com/repos/jasnell/dev-policy/subscribers","subscription_url":"https://api.github.com/repos/jasnell/dev-policy/subscription","commits_url":"https://api.github.com/repos/jasnell/dev-policy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasnell/dev-policy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasnell/dev-policy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasnell/dev-policy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasnell/dev-policy/contents/{+path}","compare_url":"https://api.github.com/repos/jasnell/dev-policy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasnell/dev-policy/merges","archive_url":"https://api.github.com/repos/jasnell/dev-policy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasnell/dev-policy/downloads","issues_url":"https://api.github.com/repos/jasnell/dev-policy/issues{/number}","pulls_url":"https://api.github.com/repos/jasnell/dev-policy/pulls{/number}","milestones_url":"https://api.github.com/repos/jasnell/dev-policy/milestones{/number}","notifications_url":"https://api.github.com/repos/jasnell/dev-policy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasnell/dev-policy/labels{/name}","releases_url":"https://api.github.com/repos/jasnell/dev-policy/releases{/id}","created_at":"2015-04-04T01:53:25Z","updated_at":"2015-04-04T02:06:54Z","pushed_at":"2015-04-05T04:18:51Z","git_url":"git://github.com/jasnell/dev-policy.git","ssh_url":"git@github.com:jasnell/dev-policy.git","clone_url":"https://github.com/jasnell/dev-policy.git","svn_url":"https://github.com/jasnell/dev-policy","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"base":{"label":"jasnell:master","ref":"master","sha":"a0fff09998e138df4ea3e7488e90e12c3ddff8e0","user":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"repo":{"id":33390841,"name":"dev-policy","full_name":"jasnell/dev-policy","owner":{"login":"jasnell","id":439929,"avatar_url":"https://avatars.githubusercontent.com/u/439929?v=3","gravatar_id":"","url":"https://api.github.com/users/jasnell","html_url":"https://github.com/jasnell","followers_url":"https://api.github.com/users/jasnell/followers","following_url":"https://api.github.com/users/jasnell/following{/other_user}","gists_url":"https://api.github.com/users/jasnell/gists{/gist_id}","starred_url":"https://api.github.com/users/jasnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasnell/subscriptions","organizations_url":"https://api.github.com/users/jasnell/orgs","repos_url":"https://api.github.com/users/jasnell/repos","events_url":"https://api.github.com/users/jasnell/events{/privacy}","received_events_url":"https://api.github.com/users/jasnell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasnell/dev-policy","description":"node-foundation dev policy **draft**","fork":false,"url":"https://api.github.com/repos/jasnell/dev-policy","forks_url":"https://api.github.com/repos/jasnell/dev-policy/forks","keys_url":"https://api.github.com/repos/jasnell/dev-policy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasnell/dev-policy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasnell/dev-policy/teams","hooks_url":"https://api.github.com/repos/jasnell/dev-policy/hooks","issue_events_url":"https://api.github.com/repos/jasnell/dev-policy/issues/events{/number}","events_url":"https://api.github.com/repos/jasnell/dev-policy/events","assignees_url":"https://api.github.com/repos/jasnell/dev-policy/assignees{/user}","branches_url":"https://api.github.com/repos/jasnell/dev-policy/branches{/branch}","tags_url":"https://api.github.com/repos/jasnell/dev-policy/tags","blobs_url":"https://api.github.com/repos/jasnell/dev-policy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasnell/dev-policy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasnell/dev-policy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasnell/dev-policy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasnell/dev-policy/statuses/{sha}","languages_url":"https://api.github.com/repos/jasnell/dev-policy/languages","stargazers_url":"https://api.github.com/repos/jasnell/dev-policy/stargazers","contributors_url":"https://api.github.com/repos/jasnell/dev-policy/contributors","subscribers_url":"https://api.github.com/repos/jasnell/dev-policy/subscribers","subscription_url":"https://api.github.com/repos/jasnell/dev-policy/subscription","commits_url":"https://api.github.com/repos/jasnell/dev-policy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasnell/dev-policy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasnell/dev-policy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasnell/dev-policy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasnell/dev-policy/contents/{+path}","compare_url":"https://api.github.com/repos/jasnell/dev-policy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasnell/dev-policy/merges","archive_url":"https://api.github.com/repos/jasnell/dev-policy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasnell/dev-policy/downloads","issues_url":"https://api.github.com/repos/jasnell/dev-policy/issues{/number}","pulls_url":"https://api.github.com/repos/jasnell/dev-policy/pulls{/number}","milestones_url":"https://api.github.com/repos/jasnell/dev-policy/milestones{/number}","notifications_url":"https://api.github.com/repos/jasnell/dev-policy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasnell/dev-policy/labels{/name}","releases_url":"https://api.github.com/repos/jasnell/dev-policy/releases{/id}","created_at":"2015-04-04T01:53:25Z","updated_at":"2015-04-04T02:06:54Z","pushed_at":"2015-04-05T04:18:51Z","git_url":"git://github.com/jasnell/dev-policy.git","ssh_url":"git@github.com:jasnell/dev-policy.git","clone_url":"https://github.com/jasnell/dev-policy.git","svn_url":"https://github.com/jasnell/dev-policy","homepage":"","size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jasnell/dev-policy/pulls/11"},"html":{"href":"https://github.com/jasnell/dev-policy/pull/11"},"issue":{"href":"https://api.github.com/repos/jasnell/dev-policy/issues/11"},"comments":{"href":"https://api.github.com/repos/jasnell/dev-policy/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/jasnell/dev-policy/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/jasnell/dev-policy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jasnell/dev-policy/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/jasnell/dev-policy/statuses/8a530497dc27478890c7c21c205aafe87c12a5c1"}}}}