{"action":"created","comment":{"url":"https://api.github.com/repos/apache/tajo/pulls/comments/36612232","id":36612232,"diff_hunk":"@@ -164,21 +166,22 @@ public TableDesc createExternalTable(final String tableName, final Schema schema\n       throw new RuntimeException(e);\n     }\n \n-    if (isThisError(res.getState(), Errors.ResultCode.DUPLICATE_TABLE)) {\n-      throw new DuplicateTableException(res.getState());\n-    }\n+    throwsIfThisError(res.getState(), DuplicateTableException.class);\n+    throwsIfThisError(res.getState(), InsufficientPrivilegeException.class);\n+    throwsIfThisError(res.getState(), UnavailableTableLocationException.class);\n \n     ensureOk(res.getState());\n     return CatalogUtil.newTableDesc(res.getTable());\n   }\n \n   @Override\n-  public boolean dropTable(String tableName) throws UndefinedTableException {\n-    return dropTable(tableName, false);\n+  public void dropTable(String tableName) throws UndefinedTableException, InsufficientPrivilegeException {\n+    dropTable(tableName, false);\n   }\n \n   @Override\n-  public boolean dropTable(final String tableName, final boolean purge) throws UndefinedTableException {\n+  public void dropTable(final String tableName, final boolean purge)\n+      throws UndefinedTableException, InsufficientPrivilegeException {","path":"tajo-client/src/main/java/org/apache/tajo/client/CatalogAdminClientImpl.java","position":165,"original_position":165,"commit_id":"48b0f64cfeaabb9f0f2136200d78f74274e96b07","original_commit_id":"48b0f64cfeaabb9f0f2136200d78f74274e96b07","user":{"login":"jihoonson","id":2322288,"avatar_url":"https://avatars.githubusercontent.com/u/2322288?v=3","gravatar_id":"","url":"https://api.github.com/users/jihoonson","html_url":"https://github.com/jihoonson","followers_url":"https://api.github.com/users/jihoonson/followers","following_url":"https://api.github.com/users/jihoonson/following{/other_user}","gists_url":"https://api.github.com/users/jihoonson/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonson/subscriptions","organizations_url":"https://api.github.com/users/jihoonson/orgs","repos_url":"https://api.github.com/users/jihoonson/repos","events_url":"https://api.github.com/users/jihoonson/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonson/received_events","type":"User","site_admin":false},"body":"I misunderstood some codes. Please forget this comment.","created_at":"2015-08-10T08:55:59Z","updated_at":"2015-08-10T08:55:59Z","html_url":"https://github.com/apache/tajo/pull/680#discussion_r36612232","pull_request_url":"https://api.github.com/repos/apache/tajo/pulls/680","_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments/36612232"},"html":{"href":"https://github.com/apache/tajo/pull/680#discussion_r36612232"},"pull_request":{"href":"https://api.github.com/repos/apache/tajo/pulls/680"}}},"pull_request":{"url":"https://api.github.com/repos/apache/tajo/pulls/680","id":41954833,"html_url":"https://github.com/apache/tajo/pull/680","diff_url":"https://github.com/apache/tajo/pull/680.diff","patch_url":"https://github.com/apache/tajo/pull/680.patch","issue_url":"https://api.github.com/repos/apache/tajo/issues/680","number":680,"state":"open","locked":false,"title":"TAJO-1748: Refine client APIs to throw specific exceptions.","user":{"login":"hyunsik","id":225941,"avatar_url":"https://avatars.githubusercontent.com/u/225941?v=3","gravatar_id":"","url":"https://api.github.com/users/hyunsik","html_url":"https://github.com/hyunsik","followers_url":"https://api.github.com/users/hyunsik/followers","following_url":"https://api.github.com/users/hyunsik/following{/other_user}","gists_url":"https://api.github.com/users/hyunsik/gists{/gist_id}","starred_url":"https://api.github.com/users/hyunsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyunsik/subscriptions","organizations_url":"https://api.github.com/users/hyunsik/orgs","repos_url":"https://api.github.com/users/hyunsik/repos","events_url":"https://api.github.com/users/hyunsik/events{/privacy}","received_events_url":"https://api.github.com/users/hyunsik/received_events","type":"User","site_admin":false},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/apache/tajo/680)\n<!-- Reviewable:end -->\n","created_at":"2015-08-08T14:22:35Z","updated_at":"2015-08-10T08:55:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3932361bb471b77ecc2bd0efb0cce3157000969f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/tajo/pulls/680/commits","review_comments_url":"https://api.github.com/repos/apache/tajo/pulls/680/comments","review_comment_url":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/tajo/issues/680/comments","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/48b0f64cfeaabb9f0f2136200d78f74274e96b07","head":{"label":"hyunsik:TAJO-1748","ref":"TAJO-1748","sha":"48b0f64cfeaabb9f0f2136200d78f74274e96b07","user":{"login":"hyunsik","id":225941,"avatar_url":"https://avatars.githubusercontent.com/u/225941?v=3","gravatar_id":"","url":"https://api.github.com/users/hyunsik","html_url":"https://github.com/hyunsik","followers_url":"https://api.github.com/users/hyunsik/followers","following_url":"https://api.github.com/users/hyunsik/following{/other_user}","gists_url":"https://api.github.com/users/hyunsik/gists{/gist_id}","starred_url":"https://api.github.com/users/hyunsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyunsik/subscriptions","organizations_url":"https://api.github.com/users/hyunsik/orgs","repos_url":"https://api.github.com/users/hyunsik/repos","events_url":"https://api.github.com/users/hyunsik/events{/privacy}","received_events_url":"https://api.github.com/users/hyunsik/received_events","type":"User","site_admin":false},"repo":{"id":17972237,"name":"tajo","full_name":"hyunsik/tajo","owner":{"login":"hyunsik","id":225941,"avatar_url":"https://avatars.githubusercontent.com/u/225941?v=3","gravatar_id":"","url":"https://api.github.com/users/hyunsik","html_url":"https://github.com/hyunsik","followers_url":"https://api.github.com/users/hyunsik/followers","following_url":"https://api.github.com/users/hyunsik/following{/other_user}","gists_url":"https://api.github.com/users/hyunsik/gists{/gist_id}","starred_url":"https://api.github.com/users/hyunsik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyunsik/subscriptions","organizations_url":"https://api.github.com/users/hyunsik/orgs","repos_url":"https://api.github.com/users/hyunsik/repos","events_url":"https://api.github.com/users/hyunsik/events{/privacy}","received_events_url":"https://api.github.com/users/hyunsik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hyunsik/tajo","description":"Mirror of Apache Tajo","fork":true,"url":"https://api.github.com/repos/hyunsik/tajo","forks_url":"https://api.github.com/repos/hyunsik/tajo/forks","keys_url":"https://api.github.com/repos/hyunsik/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyunsik/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyunsik/tajo/teams","hooks_url":"https://api.github.com/repos/hyunsik/tajo/hooks","issue_events_url":"https://api.github.com/repos/hyunsik/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/hyunsik/tajo/events","assignees_url":"https://api.github.com/repos/hyunsik/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/hyunsik/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/hyunsik/tajo/tags","blobs_url":"https://api.github.com/repos/hyunsik/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyunsik/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyunsik/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyunsik/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyunsik/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/hyunsik/tajo/languages","stargazers_url":"https://api.github.com/repos/hyunsik/tajo/stargazers","contributors_url":"https://api.github.com/repos/hyunsik/tajo/contributors","subscribers_url":"https://api.github.com/repos/hyunsik/tajo/subscribers","subscription_url":"https://api.github.com/repos/hyunsik/tajo/subscription","commits_url":"https://api.github.com/repos/hyunsik/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyunsik/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyunsik/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyunsik/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyunsik/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/hyunsik/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyunsik/tajo/merges","archive_url":"https://api.github.com/repos/hyunsik/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyunsik/tajo/downloads","issues_url":"https://api.github.com/repos/hyunsik/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/hyunsik/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/hyunsik/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/hyunsik/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyunsik/tajo/labels{/name}","releases_url":"https://api.github.com/repos/hyunsik/tajo/releases{/id}","created_at":"2014-03-21T07:53:46Z","updated_at":"2015-04-07T06:07:49Z","pushed_at":"2015-08-09T14:36:41Z","git_url":"git://github.com/hyunsik/tajo.git","ssh_url":"git@github.com:hyunsik/tajo.git","clone_url":"https://github.com/hyunsik/tajo.git","svn_url":"https://github.com/hyunsik/tajo","homepage":null,"size":23121,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"f868c0e237f7523f429d0196e67652e980ca5907","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17971138,"name":"tajo","full_name":"apache/tajo","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/tajo","description":"Mirror of Apache Tajo","fork":false,"url":"https://api.github.com/repos/apache/tajo","forks_url":"https://api.github.com/repos/apache/tajo/forks","keys_url":"https://api.github.com/repos/apache/tajo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/tajo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/tajo/teams","hooks_url":"https://api.github.com/repos/apache/tajo/hooks","issue_events_url":"https://api.github.com/repos/apache/tajo/issues/events{/number}","events_url":"https://api.github.com/repos/apache/tajo/events","assignees_url":"https://api.github.com/repos/apache/tajo/assignees{/user}","branches_url":"https://api.github.com/repos/apache/tajo/branches{/branch}","tags_url":"https://api.github.com/repos/apache/tajo/tags","blobs_url":"https://api.github.com/repos/apache/tajo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/tajo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/tajo/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/tajo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/tajo/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/tajo/languages","stargazers_url":"https://api.github.com/repos/apache/tajo/stargazers","contributors_url":"https://api.github.com/repos/apache/tajo/contributors","subscribers_url":"https://api.github.com/repos/apache/tajo/subscribers","subscription_url":"https://api.github.com/repos/apache/tajo/subscription","commits_url":"https://api.github.com/repos/apache/tajo/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/tajo/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/tajo/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/tajo/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/tajo/contents/{+path}","compare_url":"https://api.github.com/repos/apache/tajo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/tajo/merges","archive_url":"https://api.github.com/repos/apache/tajo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/tajo/downloads","issues_url":"https://api.github.com/repos/apache/tajo/issues{/number}","pulls_url":"https://api.github.com/repos/apache/tajo/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/tajo/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/tajo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/tajo/labels{/name}","releases_url":"https://api.github.com/repos/apache/tajo/releases{/id}","created_at":"2014-03-21T07:00:07Z","updated_at":"2015-07-31T09:44:57Z","pushed_at":"2015-08-10T08:38:01Z","git_url":"git://github.com/apache/tajo.git","ssh_url":"git@github.com:apache/tajo.git","clone_url":"https://github.com/apache/tajo.git","svn_url":"https://github.com/apache/tajo","homepage":null,"size":42464,"stargazers_count":59,"watchers_count":59,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":"git://git.apache.org/tajo.git","open_issues_count":57,"forks":67,"open_issues":57,"watchers":59,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/tajo/pulls/680"},"html":{"href":"https://github.com/apache/tajo/pull/680"},"issue":{"href":"https://api.github.com/repos/apache/tajo/issues/680"},"comments":{"href":"https://api.github.com/repos/apache/tajo/issues/680/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/tajo/pulls/680/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/tajo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/tajo/pulls/680/commits"},"statuses":{"href":"https://api.github.com/repos/apache/tajo/statuses/48b0f64cfeaabb9f0f2136200d78f74274e96b07"}}}}