{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/33891521","id":33891521,"diff_hunk":"@@ -0,0 +1,141 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *   http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+package org.apache.reef.io.network.impl;\n+\n+import org.apache.reef.io.network.Message;\n+import org.apache.reef.wake.Identifier;\n+\n+import java.net.SocketAddress;\n+import java.util.List;\n+\n+\n+final class DefaultNSMessage<T> implements Message<T> {\n+\n+  private final List<T> messages;\n+  private SocketAddress remoteAddr;\n+  private final String connectionFactoryId;\n+  private final Identifier srcId;\n+  private final Identifier remoteId;\n+\n+  /**\n+   * Constructs a network service message.\n+   *\n+   * @param connectionFactoryId the connection factory identifier\n+   * @param srcId      the source identifier\n+   * @param remoteId   the remote identifier\n+   * @param messages  the list of messages\n+   */\n+  public DefaultNSMessage(\n+      final String connectionFactoryId,\n+      final Identifier srcId,","path":"lang/java/reef-io/src/main/java/org/apache/reef/io/network/impl/DefaultNSMessage.java","position":null,"original_position":46,"commit_id":"8f0a414c4ad5bb70507ae73bdcde5703560d329e","original_commit_id":"0b40f737b74dc3af1a17cf3ea21101c8769a376a","user":{"login":"taegeonum","id":1371383,"avatar_url":"https://avatars.githubusercontent.com/u/1371383?v=3","gravatar_id":"","url":"https://api.github.com/users/taegeonum","html_url":"https://github.com/taegeonum","followers_url":"https://api.github.com/users/taegeonum/followers","following_url":"https://api.github.com/users/taegeonum/following{/other_user}","gists_url":"https://api.github.com/users/taegeonum/gists{/gist_id}","starred_url":"https://api.github.com/users/taegeonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taegeonum/subscriptions","organizations_url":"https://api.github.com/users/taegeonum/orgs","repos_url":"https://api.github.com/users/taegeonum/repos","events_url":"https://api.github.com/users/taegeonum/events{/privacy}","received_events_url":"https://api.github.com/users/taegeonum/received_events","type":"User","site_admin":false},"body":"I decided to keep srcId because in `Message` interface, it also uses `srcId`","created_at":"2015-07-05T02:44:08Z","updated_at":"2015-07-05T02:44:08Z","html_url":"https://github.com/apache/incubator-reef/pull/255#discussion_r33891521","pull_request_url":"https://api.github.com/repos/apache/incubator-reef/pulls/255","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments/33891521"},"html":{"href":"https://github.com/apache/incubator-reef/pull/255#discussion_r33891521"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/255"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-reef/pulls/255","id":38720848,"html_url":"https://github.com/apache/incubator-reef/pull/255","diff_url":"https://github.com/apache/incubator-reef/pull/255.diff","patch_url":"https://github.com/apache/incubator-reef/pull/255.patch","issue_url":"https://api.github.com/repos/apache/incubator-reef/issues/255","number":255,"state":"open","locked":false,"title":"[REEF-184] Allow NetworkService to add more than one message handlers","user":{"login":"taegeonum","id":1371383,"avatar_url":"https://avatars.githubusercontent.com/u/1371383?v=3","gravatar_id":"","url":"https://api.github.com/users/taegeonum","html_url":"https://github.com/taegeonum","followers_url":"https://api.github.com/users/taegeonum/followers","following_url":"https://api.github.com/users/taegeonum/following{/other_user}","gists_url":"https://api.github.com/users/taegeonum/gists{/gist_id}","starred_url":"https://api.github.com/users/taegeonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taegeonum/subscriptions","organizations_url":"https://api.github.com/users/taegeonum/orgs","repos_url":"https://api.github.com/users/taegeonum/repos","events_url":"https://api.github.com/users/taegeonum/events{/privacy}","received_events_url":"https://api.github.com/users/taegeonum/received_events","type":"User","site_admin":false},"body":"This pull request addressed the issue by\r\n\r\n  * Introduce an interface of `NetworkServiceClient`\r\n  * Implement `DefaultNetworkServiceImpl` which is an implementation of `NetworkServiceClient`\r\n\r\nAcknowledgement: Collaborates with @gwsshs22 (GeonWoo Kim)\r\n\r\nJIRA: [REEF-184](http://issues.apache.org/jira/browse/REEF-184)","created_at":"2015-06-28T06:17:59Z","updated_at":"2015-07-05T02:44:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92a95c621dee3ea25b7bff98c3ada2f8467cb87f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-reef/pulls/255/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-reef/pulls/255/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-reef/issues/255/comments","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/8f0a414c4ad5bb70507ae73bdcde5703560d329e","head":{"label":"taegeonum:REEF-184","ref":"REEF-184","sha":"8f0a414c4ad5bb70507ae73bdcde5703560d329e","user":{"login":"taegeonum","id":1371383,"avatar_url":"https://avatars.githubusercontent.com/u/1371383?v=3","gravatar_id":"","url":"https://api.github.com/users/taegeonum","html_url":"https://github.com/taegeonum","followers_url":"https://api.github.com/users/taegeonum/followers","following_url":"https://api.github.com/users/taegeonum/following{/other_user}","gists_url":"https://api.github.com/users/taegeonum/gists{/gist_id}","starred_url":"https://api.github.com/users/taegeonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taegeonum/subscriptions","organizations_url":"https://api.github.com/users/taegeonum/orgs","repos_url":"https://api.github.com/users/taegeonum/repos","events_url":"https://api.github.com/users/taegeonum/events{/privacy}","received_events_url":"https://api.github.com/users/taegeonum/received_events","type":"User","site_admin":false},"repo":{"id":27798307,"name":"incubator-reef","full_name":"taegeonum/incubator-reef","owner":{"login":"taegeonum","id":1371383,"avatar_url":"https://avatars.githubusercontent.com/u/1371383?v=3","gravatar_id":"","url":"https://api.github.com/users/taegeonum","html_url":"https://github.com/taegeonum","followers_url":"https://api.github.com/users/taegeonum/followers","following_url":"https://api.github.com/users/taegeonum/following{/other_user}","gists_url":"https://api.github.com/users/taegeonum/gists{/gist_id}","starred_url":"https://api.github.com/users/taegeonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taegeonum/subscriptions","organizations_url":"https://api.github.com/users/taegeonum/orgs","repos_url":"https://api.github.com/users/taegeonum/repos","events_url":"https://api.github.com/users/taegeonum/events{/privacy}","received_events_url":"https://api.github.com/users/taegeonum/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taegeonum/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":true,"url":"https://api.github.com/repos/taegeonum/incubator-reef","forks_url":"https://api.github.com/repos/taegeonum/incubator-reef/forks","keys_url":"https://api.github.com/repos/taegeonum/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taegeonum/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taegeonum/incubator-reef/teams","hooks_url":"https://api.github.com/repos/taegeonum/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/taegeonum/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/taegeonum/incubator-reef/events","assignees_url":"https://api.github.com/repos/taegeonum/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/taegeonum/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/taegeonum/incubator-reef/tags","blobs_url":"https://api.github.com/repos/taegeonum/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taegeonum/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taegeonum/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/taegeonum/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taegeonum/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/taegeonum/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/taegeonum/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/taegeonum/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/taegeonum/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/taegeonum/incubator-reef/subscription","commits_url":"https://api.github.com/repos/taegeonum/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/taegeonum/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/taegeonum/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/taegeonum/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/taegeonum/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/taegeonum/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taegeonum/incubator-reef/merges","archive_url":"https://api.github.com/repos/taegeonum/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taegeonum/incubator-reef/downloads","issues_url":"https://api.github.com/repos/taegeonum/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/taegeonum/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/taegeonum/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/taegeonum/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taegeonum/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/taegeonum/incubator-reef/releases{/id}","created_at":"2014-12-10T02:24:04Z","updated_at":"2015-02-22T10:46:56Z","pushed_at":"2015-07-05T02:25:26Z","git_url":"git://github.com/taegeonum/incubator-reef.git","ssh_url":"git@github.com:taegeonum/incubator-reef.git","clone_url":"https://github.com/taegeonum/incubator-reef.git","svn_url":"https://github.com/taegeonum/incubator-reef","homepage":null,"size":29898,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"2ce6c81e21129e038c95fceac33f54f4194e9cb0","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":25623941,"name":"incubator-reef","full_name":"apache/incubator-reef","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-reef","description":"Mirror of Apache REEF (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/incubator-reef","forks_url":"https://api.github.com/repos/apache/incubator-reef/forks","keys_url":"https://api.github.com/repos/apache/incubator-reef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-reef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-reef/teams","hooks_url":"https://api.github.com/repos/apache/incubator-reef/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-reef/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-reef/events","assignees_url":"https://api.github.com/repos/apache/incubator-reef/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-reef/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-reef/tags","blobs_url":"https://api.github.com/repos/apache/incubator-reef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-reef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-reef/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-reef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-reef/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-reef/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-reef/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-reef/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-reef/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-reef/subscription","commits_url":"https://api.github.com/repos/apache/incubator-reef/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-reef/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-reef/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-reef/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-reef/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-reef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-reef/merges","archive_url":"https://api.github.com/repos/apache/incubator-reef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-reef/downloads","issues_url":"https://api.github.com/repos/apache/incubator-reef/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-reef/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-reef/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-reef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-reef/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-reef/releases{/id}","created_at":"2014-10-23T07:00:10Z","updated_at":"2015-07-03T08:22:28Z","pushed_at":"2015-07-05T02:25:26Z","git_url":"git://github.com/apache/incubator-reef.git","ssh_url":"git@github.com:apache/incubator-reef.git","clone_url":"https://github.com/apache/incubator-reef.git","svn_url":"https://github.com/apache/incubator-reef","homepage":null,"size":41006,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":"git://git.apache.org/incubator-reef.git","open_issues_count":3,"forks":27,"open_issues":3,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/255"},"html":{"href":"https://github.com/apache/incubator-reef/pull/255"},"issue":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/255"},"comments":{"href":"https://api.github.com/repos/apache/incubator-reef/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-reef/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-reef/statuses/8f0a414c4ad5bb70507ae73bdcde5703560d329e"}}}}