{"action":"opened","number":4097,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4097","id":43642349,"html_url":"https://github.com/ManageIQ/manageiq/pull/4097","diff_url":"https://github.com/ManageIQ/manageiq/pull/4097.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/4097.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4097","number":4097,"state":"open","locked":false,"title":"Fix bug where attr_writer was overriding the key_root= method.","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"body":"Extracted from #4082 \r\n\r\n@kbrock please review...@fryguy and I fixed an issue where the `key_root=` class method was being \r\n\r\n:v: whacked :v: \r\n\r\nby the `attr_writer`, causing the v*_key caches to not be reset via `key_root=`, particularly during tests.\r\n\r\nI ran into this \"bug\" locally for seemingly unrelated tests and couldn't track it down previously:\r\n`bin/rspec gems/pending/spec/util/miq-password_spec.rb spec/models/miq_server/rhn_mirror_spec.rb --seed 46323`\r\n\r\nIt's weird to run gems/pending tests with models but I was doing it for changes that affected all of miq_server and util.\r\n\r\nThis test would run the miq-password spec first, reset the `key_root`, not clear out the v*_key, and subsequent tests that run `MiqDatabase.seed` such as rhn_mirror_spec.rb would fail with seemingly cryptic errors like: \r\n\r\n```\r\n     Failure/Error: it(\"#decrypt\")        { expect(MiqPassword.new.decrypt(enc_v2)).to           be_decrypted(pass) }\r\n     OpenSSL::Cipher::CipherError:\r\n       bad decrypt\r\n```\r\n\r\nOr \r\n```\r\n     Failure/Error: it(\"#recrypt legacy\") { expect(MiqPassword.new.recrypt(enc_v0)).to eq(enc_v2) }\r\n\r\n       expected: \"v2:{27X41c6xqCCdVcw4LlQ1Qg==}\"\r\n            got: \"v2:{kGuPkrN8fYq0cJPTjytisw==}\"\r\n```\r\n\r\nThese tests now don't randomly fail with this PR.\r\n","created_at":"2015-08-28T15:49:46Z","updated_at":"2015-08-28T15:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4097/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4097/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/4097/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/87ea6be450e0cdcf1384a2b320a4e81701b5e207","head":{"label":"jrafanie:fix_overridden_key_root_setter","ref":"fix_overridden_key_root_setter","sha":"87ea6be450e0cdcf1384a2b320a4e81701b5e207","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"repo":{"id":20803842,"name":"manageiq","full_name":"jrafanie/manageiq","owner":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrafanie/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/jrafanie/manageiq","forks_url":"https://api.github.com/repos/jrafanie/manageiq/forks","keys_url":"https://api.github.com/repos/jrafanie/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrafanie/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrafanie/manageiq/teams","hooks_url":"https://api.github.com/repos/jrafanie/manageiq/hooks","issue_events_url":"https://api.github.com/repos/jrafanie/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/jrafanie/manageiq/events","assignees_url":"https://api.github.com/repos/jrafanie/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/jrafanie/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/jrafanie/manageiq/tags","blobs_url":"https://api.github.com/repos/jrafanie/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrafanie/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrafanie/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrafanie/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrafanie/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/jrafanie/manageiq/languages","stargazers_url":"https://api.github.com/repos/jrafanie/manageiq/stargazers","contributors_url":"https://api.github.com/repos/jrafanie/manageiq/contributors","subscribers_url":"https://api.github.com/repos/jrafanie/manageiq/subscribers","subscription_url":"https://api.github.com/repos/jrafanie/manageiq/subscription","commits_url":"https://api.github.com/repos/jrafanie/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrafanie/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrafanie/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrafanie/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrafanie/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/jrafanie/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrafanie/manageiq/merges","archive_url":"https://api.github.com/repos/jrafanie/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrafanie/manageiq/downloads","issues_url":"https://api.github.com/repos/jrafanie/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/jrafanie/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/jrafanie/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/jrafanie/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrafanie/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/jrafanie/manageiq/releases{/id}","created_at":"2014-06-13T12:47:01Z","updated_at":"2015-04-02T16:14:36Z","pushed_at":"2015-08-28T15:48:05Z","git_url":"git://github.com/jrafanie/manageiq.git","ssh_url":"git@github.com:jrafanie/manageiq.git","clone_url":"https://github.com/jrafanie/manageiq.git","svn_url":"https://github.com/jrafanie/manageiq","homepage":null,"size":82565,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"4443f41bc37a06b97ffe576a7097e3617804bc81","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-08-27T11:01:30Z","pushed_at":"2015-08-28T15:49:47Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":153844,"stargazers_count":134,"watchers_count":134,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":143,"mirror_url":null,"open_issues_count":398,"forks":143,"open_issues":398,"watchers":134,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4097"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/4097"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4097"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/4097/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4097/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/4097/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/87ea6be450e0cdcf1384a2b320a4e81701b5e207"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":21,"deletions":8,"changed_files":2}}