{"action":"created","comment":{"url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments/39225024","id":39225024,"diff_hunk":"@@ -8,22 +10,22 @@ var itemSelectorAdHocItems = (function() {\n   };\n \n   var adHocItemTemplate = function(value) {\n+    var barcode = santizeCallnumber(value);\n+\n     return $(\n       '<span data-barcode=\"' +\n-        santizeCallnumber(value) +\n+        barcode +\n       '\" data-callnumber=\"' +\n         value +\n       '\"></span>'\n     );\n   };\n \n-  var adHochiddenFieldTemplate = function(item, fieldName) {\n-    return $(\n-      '<input id=\"hidden-' + item.data('barcode') + '\" ' +\n-      'type=\"hidden\" ' +\n-      'name=\"' + fieldName + '\" ' +\n-      'value=\"' + item.data('callnumber') + '\" />'\n-    );\n+  var adHochiddenFieldTemplate = function(name, value) {\n+    return '<input id=\"hidden-' + santizeCallnumber(value) + '\"' +\n+    'type=\"hidden\" ' +\n+    'name=\"' + name + '\" ' +\n+    'value=\"' + value + '\" />'","path":"app/assets/javascripts/item_selector/item_selector_ad_hoc_items.js","position":33,"original_position":33,"commit_id":"518492a1e95ad851fa60d9c868d36258f8382e52","original_commit_id":"518492a1e95ad851fa60d9c868d36258f8382e52","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Missing semicolon.","created_at":"2015-09-10T23:00:28Z","updated_at":"2015-09-10T23:00:28Z","html_url":"https://github.com/sul-dlss/sul-requests/pull/403#discussion_r39225024","pull_request_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments/39225024"},"html":{"href":"https://github.com/sul-dlss/sul-requests/pull/403#discussion_r39225024"},"pull_request":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403","id":44729865,"html_url":"https://github.com/sul-dlss/sul-requests/pull/403","diff_url":"https://github.com/sul-dlss/sul-requests/pull/403.diff","patch_url":"https://github.com/sul-dlss/sul-requests/pull/403.patch","issue_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/403","number":403,"state":"open","locked":false,"title":"Preserve user values after validation failures","user":{"login":"cbeer","id":111218,"avatar_url":"https://avatars.githubusercontent.com/u/111218?v=3","gravatar_id":"","url":"https://api.github.com/users/cbeer","html_url":"https://github.com/cbeer","followers_url":"https://api.github.com/users/cbeer/followers","following_url":"https://api.github.com/users/cbeer/following{/other_user}","gists_url":"https://api.github.com/users/cbeer/gists{/gist_id}","starred_url":"https://api.github.com/users/cbeer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbeer/subscriptions","organizations_url":"https://api.github.com/users/cbeer/orgs","repos_url":"https://api.github.com/users/cbeer/repos","events_url":"https://api.github.com/users/cbeer/events{/privacy}","received_events_url":"https://api.github.com/users/cbeer/received_events","type":"User","site_admin":false},"body":"Fixes #319 ","created_at":"2015-09-10T23:00:19Z","updated_at":"2015-09-10T23:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d3667aa434b91a1feb7798ad0448fe0508d59a5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403/commits","review_comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403/comments","review_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/403/comments","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/518492a1e95ad851fa60d9c868d36258f8382e52","head":{"label":"sul-dlss:319-preserve-user-values","ref":"319-preserve-user-values","sha":"518492a1e95ad851fa60d9c868d36258f8382e52","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":33213527,"name":"sul-requests","full_name":"sul-dlss/sul-requests","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/sul-requests","description":"Rails application for requesting materials from Stanford University Library","fork":false,"url":"https://api.github.com/repos/sul-dlss/sul-requests","forks_url":"https://api.github.com/repos/sul-dlss/sul-requests/forks","keys_url":"https://api.github.com/repos/sul-dlss/sul-requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/sul-requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/sul-requests/teams","hooks_url":"https://api.github.com/repos/sul-dlss/sul-requests/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/sul-requests/events","assignees_url":"https://api.github.com/repos/sul-dlss/sul-requests/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/sul-requests/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/tags","blobs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/sul-requests/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/sul-requests/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/sul-requests/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscription","commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/sul-requests/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/sul-requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/sul-requests/merges","archive_url":"https://api.github.com/repos/sul-dlss/sul-requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/sul-requests/downloads","issues_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/sul-requests/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/sul-requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/sul-requests/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/sul-requests/releases{/id}","created_at":"2015-03-31T22:27:27Z","updated_at":"2015-05-08T19:12:58Z","pushed_at":"2015-09-10T23:00:19Z","git_url":"git://github.com/sul-dlss/sul-requests.git","ssh_url":"git@github.com:sul-dlss/sul-requests.git","clone_url":"https://github.com/sul-dlss/sul-requests.git","svn_url":"https://github.com/sul-dlss/sul-requests","homepage":null,"size":4556,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":2,"default_branch":"master"}},"base":{"label":"sul-dlss:master","ref":"master","sha":"9391ad86b54e347170ebdb117b06c60c1b582c46","user":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"repo":{"id":33213527,"name":"sul-requests","full_name":"sul-dlss/sul-requests","owner":{"login":"sul-dlss","id":230583,"avatar_url":"https://avatars.githubusercontent.com/u/230583?v=3","gravatar_id":"","url":"https://api.github.com/users/sul-dlss","html_url":"https://github.com/sul-dlss","followers_url":"https://api.github.com/users/sul-dlss/followers","following_url":"https://api.github.com/users/sul-dlss/following{/other_user}","gists_url":"https://api.github.com/users/sul-dlss/gists{/gist_id}","starred_url":"https://api.github.com/users/sul-dlss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sul-dlss/subscriptions","organizations_url":"https://api.github.com/users/sul-dlss/orgs","repos_url":"https://api.github.com/users/sul-dlss/repos","events_url":"https://api.github.com/users/sul-dlss/events{/privacy}","received_events_url":"https://api.github.com/users/sul-dlss/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sul-dlss/sul-requests","description":"Rails application for requesting materials from Stanford University Library","fork":false,"url":"https://api.github.com/repos/sul-dlss/sul-requests","forks_url":"https://api.github.com/repos/sul-dlss/sul-requests/forks","keys_url":"https://api.github.com/repos/sul-dlss/sul-requests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sul-dlss/sul-requests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sul-dlss/sul-requests/teams","hooks_url":"https://api.github.com/repos/sul-dlss/sul-requests/hooks","issue_events_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/events{/number}","events_url":"https://api.github.com/repos/sul-dlss/sul-requests/events","assignees_url":"https://api.github.com/repos/sul-dlss/sul-requests/assignees{/user}","branches_url":"https://api.github.com/repos/sul-dlss/sul-requests/branches{/branch}","tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/tags","blobs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/refs{/sha}","trees_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/{sha}","languages_url":"https://api.github.com/repos/sul-dlss/sul-requests/languages","stargazers_url":"https://api.github.com/repos/sul-dlss/sul-requests/stargazers","contributors_url":"https://api.github.com/repos/sul-dlss/sul-requests/contributors","subscribers_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscribers","subscription_url":"https://api.github.com/repos/sul-dlss/sul-requests/subscription","commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/commits{/sha}","git_commits_url":"https://api.github.com/repos/sul-dlss/sul-requests/git/commits{/sha}","comments_url":"https://api.github.com/repos/sul-dlss/sul-requests/comments{/number}","issue_comment_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues/comments{/number}","contents_url":"https://api.github.com/repos/sul-dlss/sul-requests/contents/{+path}","compare_url":"https://api.github.com/repos/sul-dlss/sul-requests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sul-dlss/sul-requests/merges","archive_url":"https://api.github.com/repos/sul-dlss/sul-requests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sul-dlss/sul-requests/downloads","issues_url":"https://api.github.com/repos/sul-dlss/sul-requests/issues{/number}","pulls_url":"https://api.github.com/repos/sul-dlss/sul-requests/pulls{/number}","milestones_url":"https://api.github.com/repos/sul-dlss/sul-requests/milestones{/number}","notifications_url":"https://api.github.com/repos/sul-dlss/sul-requests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sul-dlss/sul-requests/labels{/name}","releases_url":"https://api.github.com/repos/sul-dlss/sul-requests/releases{/id}","created_at":"2015-03-31T22:27:27Z","updated_at":"2015-05-08T19:12:58Z","pushed_at":"2015-09-10T23:00:19Z","git_url":"git://github.com/sul-dlss/sul-requests.git","ssh_url":"git@github.com:sul-dlss/sul-requests.git","clone_url":"https://github.com/sul-dlss/sul-requests.git","svn_url":"https://github.com/sul-dlss/sul-requests","homepage":null,"size":4556,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":18,"forks":0,"open_issues":18,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403"},"html":{"href":"https://github.com/sul-dlss/sul-requests/pull/403"},"issue":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/issues/403"},"comments":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/sul-dlss/sul-requests/statuses/518492a1e95ad851fa60d9c868d36258f8382e52"}}}}