{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/opm-parser/pulls/comments/48015824","id":48015824,"diff_hunk":"@@ -337,8 +333,7 @@ namespace Opm {\n         auto& container = forceGetTables(keywordName , numTables);\n         for (size_t tableIdx = 0; tableIdx < keyword->size(); ++tableIdx) {\n             const auto tableRecord = keyword->getRecord( tableIdx );\n-            std::shared_ptr<PlyrockTable> table = std::make_shared<PlyrockTable>();\n-            table->init( tableRecord );\n+            std::shared_ptr<PlyrockTable> table = std::make_shared<PlyrockTable>(tableRecord);","path":"opm/parser/eclipse/EclipseState/Tables/TableManager.cpp","position":35,"original_position":35,"commit_id":"54184bd7068b60f2c0377c6cb71939a1fd4ac56e","original_commit_id":"54184bd7068b60f2c0377c6cb71939a1fd4ac56e","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"body":"Well - the concept of defaulted tables *should* be handled by the `TableContainer` class.","created_at":"2015-12-18T11:12:57Z","updated_at":"2015-12-18T11:12:57Z","html_url":"https://github.com/OPM/opm-parser/pull/649#discussion_r48015824","pull_request_url":"https://api.github.com/repos/OPM/opm-parser/pulls/649","_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/comments/48015824"},"html":{"href":"https://github.com/OPM/opm-parser/pull/649#discussion_r48015824"},"pull_request":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/649"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/opm-parser/pulls/649","id":53962412,"html_url":"https://github.com/OPM/opm-parser/pull/649","diff_url":"https://github.com/OPM/opm-parser/pull/649.diff","patch_url":"https://github.com/OPM/opm-parser/pull/649.patch","issue_url":"https://api.github.com/repos/OPM/opm-parser/issues/649","number":649,"state":"open","locked":false,"title":"Table column","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"body":"[ Not ready for merge - some serious fixups required :-)]\r\n\r\nReworking the table code:\r\n\r\n- Working towards a situation where the tables can be specified in Json; not there yet.\r\n- Reduced use of templates - especially for `PVTO` and `PVTG`\r\n- Reduce the dependency on `xxxTable::init()` - the constructor should create a fully initialized and ready to use table object.\r\n- Added *Schema* classes for table and column metadata.\r\n- Removed special casing of test methods.\r\n- Removed friends and such - `public:` and `private:` should be enough\r\n\r\nIn this PR I have tried to put myself on a `std::shared_ptr<T>` diet; a bit like cod-liver oil  - it is good for you, but it does not taste good. Any comments on management of objects highly appreciated.\r\n\r\n \r\nDownstream PR's are in the works.","created_at":"2015-12-17T11:04:09Z","updated_at":"2015-12-18T11:12:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ff1f638ea886ae067a52f473a800a1b16d22c018","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/opm-parser/pulls/649/commits","review_comments_url":"https://api.github.com/repos/OPM/opm-parser/pulls/649/comments","review_comment_url":"https://api.github.com/repos/OPM/opm-parser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/opm-parser/issues/649/comments","statuses_url":"https://api.github.com/repos/OPM/opm-parser/statuses/54184bd7068b60f2c0377c6cb71939a1fd4ac56e","head":{"label":"joakim-hove:table-column","ref":"table-column","sha":"54184bd7068b60f2c0377c6cb71939a1fd4ac56e","user":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"repo":{"id":8883572,"name":"opm-parser","full_name":"joakim-hove/opm-parser","owner":{"login":"joakim-hove","id":1321665,"avatar_url":"https://avatars.githubusercontent.com/u/1321665?v=3","gravatar_id":"","url":"https://api.github.com/users/joakim-hove","html_url":"https://github.com/joakim-hove","followers_url":"https://api.github.com/users/joakim-hove/followers","following_url":"https://api.github.com/users/joakim-hove/following{/other_user}","gists_url":"https://api.github.com/users/joakim-hove/gists{/gist_id}","starred_url":"https://api.github.com/users/joakim-hove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joakim-hove/subscriptions","organizations_url":"https://api.github.com/users/joakim-hove/orgs","repos_url":"https://api.github.com/users/joakim-hove/repos","events_url":"https://api.github.com/users/joakim-hove/events{/privacy}","received_events_url":"https://api.github.com/users/joakim-hove/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joakim-hove/opm-parser","description":"","fork":true,"url":"https://api.github.com/repos/joakim-hove/opm-parser","forks_url":"https://api.github.com/repos/joakim-hove/opm-parser/forks","keys_url":"https://api.github.com/repos/joakim-hove/opm-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joakim-hove/opm-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joakim-hove/opm-parser/teams","hooks_url":"https://api.github.com/repos/joakim-hove/opm-parser/hooks","issue_events_url":"https://api.github.com/repos/joakim-hove/opm-parser/issues/events{/number}","events_url":"https://api.github.com/repos/joakim-hove/opm-parser/events","assignees_url":"https://api.github.com/repos/joakim-hove/opm-parser/assignees{/user}","branches_url":"https://api.github.com/repos/joakim-hove/opm-parser/branches{/branch}","tags_url":"https://api.github.com/repos/joakim-hove/opm-parser/tags","blobs_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joakim-hove/opm-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/joakim-hove/opm-parser/languages","stargazers_url":"https://api.github.com/repos/joakim-hove/opm-parser/stargazers","contributors_url":"https://api.github.com/repos/joakim-hove/opm-parser/contributors","subscribers_url":"https://api.github.com/repos/joakim-hove/opm-parser/subscribers","subscription_url":"https://api.github.com/repos/joakim-hove/opm-parser/subscription","commits_url":"https://api.github.com/repos/joakim-hove/opm-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/joakim-hove/opm-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/joakim-hove/opm-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/joakim-hove/opm-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/joakim-hove/opm-parser/contents/{+path}","compare_url":"https://api.github.com/repos/joakim-hove/opm-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joakim-hove/opm-parser/merges","archive_url":"https://api.github.com/repos/joakim-hove/opm-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joakim-hove/opm-parser/downloads","issues_url":"https://api.github.com/repos/joakim-hove/opm-parser/issues{/number}","pulls_url":"https://api.github.com/repos/joakim-hove/opm-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/joakim-hove/opm-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/joakim-hove/opm-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joakim-hove/opm-parser/labels{/name}","releases_url":"https://api.github.com/repos/joakim-hove/opm-parser/releases{/id}","created_at":"2013-03-19T16:41:12Z","updated_at":"2015-05-08T04:40:51Z","pushed_at":"2015-12-17T10:52:48Z","git_url":"git://github.com/joakim-hove/opm-parser.git","ssh_url":"git@github.com:joakim-hove/opm-parser.git","clone_url":"https://github.com/joakim-hove/opm-parser.git","svn_url":"https://github.com/joakim-hove/opm-parser","homepage":null,"size":5297,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"1ba033c1d14bb5a11db3da1b2af3256a39e0097c","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":8604178,"name":"opm-parser","full_name":"OPM/opm-parser","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/opm-parser","description":"","fork":false,"url":"https://api.github.com/repos/OPM/opm-parser","forks_url":"https://api.github.com/repos/OPM/opm-parser/forks","keys_url":"https://api.github.com/repos/OPM/opm-parser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/opm-parser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/opm-parser/teams","hooks_url":"https://api.github.com/repos/OPM/opm-parser/hooks","issue_events_url":"https://api.github.com/repos/OPM/opm-parser/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/opm-parser/events","assignees_url":"https://api.github.com/repos/OPM/opm-parser/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/opm-parser/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/opm-parser/tags","blobs_url":"https://api.github.com/repos/OPM/opm-parser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/opm-parser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/opm-parser/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/opm-parser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/opm-parser/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/opm-parser/languages","stargazers_url":"https://api.github.com/repos/OPM/opm-parser/stargazers","contributors_url":"https://api.github.com/repos/OPM/opm-parser/contributors","subscribers_url":"https://api.github.com/repos/OPM/opm-parser/subscribers","subscription_url":"https://api.github.com/repos/OPM/opm-parser/subscription","commits_url":"https://api.github.com/repos/OPM/opm-parser/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/opm-parser/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/opm-parser/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/opm-parser/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/opm-parser/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/opm-parser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/opm-parser/merges","archive_url":"https://api.github.com/repos/OPM/opm-parser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/opm-parser/downloads","issues_url":"https://api.github.com/repos/OPM/opm-parser/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/opm-parser/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/opm-parser/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/opm-parser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/opm-parser/labels{/name}","releases_url":"https://api.github.com/repos/OPM/opm-parser/releases{/id}","created_at":"2013-03-06T13:39:46Z","updated_at":"2015-07-05T17:33:03Z","pushed_at":"2015-12-17T11:04:09Z","git_url":"git://github.com/OPM/opm-parser.git","ssh_url":"git@github.com:OPM/opm-parser.git","clone_url":"https://github.com/OPM/opm-parser.git","svn_url":"https://github.com/OPM/opm-parser","homepage":null,"size":5971,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":6,"forks":28,"open_issues":6,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/649"},"html":{"href":"https://github.com/OPM/opm-parser/pull/649"},"issue":{"href":"https://api.github.com/repos/OPM/opm-parser/issues/649"},"comments":{"href":"https://api.github.com/repos/OPM/opm-parser/issues/649/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/649/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/opm-parser/pulls/649/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/opm-parser/statuses/54184bd7068b60f2c0377c6cb71939a1fd4ac56e"}}}}