{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/378","labels_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/378/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/378/comments","events_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/378/events","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/378","id":115000499,"number":378,"title":"Fix inconsistant Chinese language codes of cldr and moment","user":{"login":"louyihua","id":1275238,"avatar_url":"https://avatars.githubusercontent.com/u/1275238?v=3","gravatar_id":"","url":"https://api.github.com/users/louyihua","html_url":"https://github.com/louyihua","followers_url":"https://api.github.com/users/louyihua/followers","following_url":"https://api.github.com/users/louyihua/following{/other_user}","gists_url":"https://api.github.com/users/louyihua/gists{/gist_id}","starred_url":"https://api.github.com/users/louyihua/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louyihua/subscriptions","organizations_url":"https://api.github.com/users/louyihua/orgs","repos_url":"https://api.github.com/users/louyihua/repos","events_url":"https://api.github.com/users/louyihua/events{/privacy}","received_events_url":"https://api.github.com/users/louyihua/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels/open-source-contribution","name":"open-source-contribution","color":"bfe5bf"},{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/labels/waiting%20on%20author","name":"waiting on author","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-11-04T08:38:25Z","updated_at":"2015-12-01T18:05:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/pulls/378","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/378","diff_url":"https://github.com/edx/edx-analytics-dashboard/pull/378.diff","patch_url":"https://github.com/edx/edx-analytics-dashboard/pull/378.patch"},"body":"The Chinese language codes have many variants, and different components may use different values.\r\nFor example, DJANGO < 1.7 and moment uses 'zh-cn' && 'zh-tw' for Simplified Chinese and Traditional Chinese, while CLDR uses 'zh' && 'zh-hant' and DJANGO >= 1.7 uses 'zh-hans' && 'zh-hant'.\r\n\r\nIn current dashboard, dates in tables are always displayed in English on a Chinese language settings, because the fixed language code 'zh' does not match the value 'zh-cn' used in moment.\r\nThis fix corrects the things and it will adapt further situations because all the variants of Chinese language codes are considered."},"comment":{"url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/comments/161049787","html_url":"https://github.com/edx/edx-analytics-dashboard/pull/378#issuecomment-161049787","issue_url":"https://api.github.com/repos/edx/edx-analytics-dashboard/issues/378","id":161049787,"user":{"login":"sarina","id":1985317,"avatar_url":"https://avatars.githubusercontent.com/u/1985317?v=3","gravatar_id":"","url":"https://api.github.com/users/sarina","html_url":"https://github.com/sarina","followers_url":"https://api.github.com/users/sarina/followers","following_url":"https://api.github.com/users/sarina/following{/other_user}","gists_url":"https://api.github.com/users/sarina/gists{/gist_id}","starred_url":"https://api.github.com/users/sarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarina/subscriptions","organizations_url":"https://api.github.com/users/sarina/orgs","repos_url":"https://api.github.com/users/sarina/repos","events_url":"https://api.github.com/users/sarina/events{/privacy}","received_events_url":"https://api.github.com/users/sarina/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T18:05:32Z","updated_at":"2015-12-01T18:05:32Z","body":"And the PR needs a rebase.\r\n\r\nI think the author is based in China, so it may take a bit of down time for him to respond :smile: "}}