{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/app/pulls/comments/39724718","id":39724718,"diff_hunk":"@@ -63,56 +61,17 @@ define('ext.wikia.adEngine.lookup.services', [\n \t\t\t\tslotTargeting[key] = amazonParams[key];\n \t\t\t});\n \t\t}\n-\t}\n-\n-\t// Copied from AdLogicPageParams\n-\t// No longer needed when AmazonOld is removed\n-\tfunction decodeLegacyDartParams(dartString) {\n-\t\tvar params = {},\n-\t\t\tkvs,\n-\t\t\tkv,\n-\t\t\tkey,\n-\t\t\tvalue,\n-\t\t\ti,\n-\t\t\tlen;\n-\n-\t\tlog(['decodeLegacyDartParams', dartString], 'debug', logGroup);\n-\n-\t\tif (typeof dartString === 'string') {\n-\t\t\tkvs = dartString.split(';');\n-\t\t\tfor (i = 0, len = kvs.length; i < len; i += 1) {\n-\t\t\t\tkv = kvs[i].split('=');\n-\t\t\t\tkey = kv[0];\n-\t\t\t\tvalue = kv[1];\n-\t\t\t\tif (key && value) {\n-\t\t\t\t\tparams[key] = params[key] || [];\n-\t\t\t\t\tparams[key].push(value);\n-\t\t\t\t}\n-\t\t\t}\n-\t\t}\n-\n-\t\treturn params;\n-\t}\n \n-\t// No longer needed when AmazonOld is removed\n-\tfunction extendPageTargeting(pageTargeting) {\n-\t\tvar amazonParams;\n+\t\tif (oxBidder && oxBidder.wasCalled() && Object.keys) {","path":"extensions/wikia/AdEngine/js/lookup/services.js","position":68,"original_position":68,"commit_id":"704cf91600fd6bebffd91e0b98b344903fa8419b","original_commit_id":"704cf91600fd6bebffd91e0b98b344903fa8419b","user":{"login":"nandy-andy","id":1662451,"avatar_url":"https://avatars.githubusercontent.com/u/1662451?v=3","gravatar_id":"","url":"https://api.github.com/users/nandy-andy","html_url":"https://github.com/nandy-andy","followers_url":"https://api.github.com/users/nandy-andy/followers","following_url":"https://api.github.com/users/nandy-andy/following{/other_user}","gists_url":"https://api.github.com/users/nandy-andy/gists{/gist_id}","starred_url":"https://api.github.com/users/nandy-andy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nandy-andy/subscriptions","organizations_url":"https://api.github.com/users/nandy-andy/orgs","repos_url":"https://api.github.com/users/nandy-andy/repos","events_url":"https://api.github.com/users/nandy-andy/events{/privacy}","received_events_url":"https://api.github.com/users/nandy-andy/received_events","type":"User","site_admin":false},"body":"This code is very similar to the code used for Amazon. I wonder if we could extract it somehow and make it less DRY.","created_at":"2015-09-17T09:07:11Z","updated_at":"2015-09-17T09:07:11Z","html_url":"https://github.com/Wikia/app/pull/8492#discussion_r39724718","pull_request_url":"https://api.github.com/repos/Wikia/app/pulls/8492","_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments/39724718"},"html":{"href":"https://github.com/Wikia/app/pull/8492#discussion_r39724718"},"pull_request":{"href":"https://api.github.com/repos/Wikia/app/pulls/8492"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8492","id":45144978,"html_url":"https://github.com/Wikia/app/pull/8492","diff_url":"https://github.com/Wikia/app/pull/8492.diff","patch_url":"https://github.com/Wikia/app/pull/8492.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8492","number":8492,"state":"open","locked":false,"title":"ADEN-2264 OpenX bidder","user":{"login":"fraszczakszymon","id":2042649,"avatar_url":"https://avatars.githubusercontent.com/u/2042649?v=3","gravatar_id":"","url":"https://api.github.com/users/fraszczakszymon","html_url":"https://github.com/fraszczakszymon","followers_url":"https://api.github.com/users/fraszczakszymon/followers","following_url":"https://api.github.com/users/fraszczakszymon/following{/other_user}","gists_url":"https://api.github.com/users/fraszczakszymon/gists{/gist_id}","starred_url":"https://api.github.com/users/fraszczakszymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fraszczakszymon/subscriptions","organizations_url":"https://api.github.com/users/fraszczakszymon/orgs","repos_url":"https://api.github.com/users/fraszczakszymon/repos","events_url":"https://api.github.com/users/fraszczakszymon/events{/privacy}","received_events_url":"https://api.github.com/users/fraszczakszymon/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-16T08:42:34Z","updated_at":"2015-09-17T09:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1703c40014cce0c656f75edb813bdcc707a6b3c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8492/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8492/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8492/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/704cf91600fd6bebffd91e0b98b344903fa8419b","head":{"label":"Wikia:aden-2264-openx-bidder","ref":"aden-2264-openx-bidder","sha":"704cf91600fd6bebffd91e0b98b344903fa8419b","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-11T11:45:30Z","pushed_at":"2015-09-17T09:02:41Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1486114,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":68,"forks":66,"open_issues":68,"watchers":86,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"c2ad94c2e2a21ea208826be9f266ce884053a4e8","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-09-11T11:45:30Z","pushed_at":"2015-09-17T09:02:41Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1486114,"stargazers_count":86,"watchers_count":86,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":68,"forks":66,"open_issues":68,"watchers":86,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8492"},"html":{"href":"https://github.com/Wikia/app/pull/8492"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8492"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8492/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8492/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8492/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/704cf91600fd6bebffd91e0b98b344903fa8419b"}}}}