{"push_id":635532770,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"1a49c80d9f42d41bf40daa46c1d372ddb8d3d718","before":"e6171068291bfb4770d47cb8172ea27653231b11","commits":[{"sha":"ed604e8429f7ea005c9443633c51c21f04400e33","author":{"email":"afe25ba6f12231365d4a0e0ffa287036dccc1246@hp.com","name":"James Capps"},"message":"Fix LP Bug 1382686 - LIKE predicate fails on some UTF8 columns\n\nThe description of this LP bug says that the LIKE predicate fails when\nthe pattern string starts with a '%' and when selecting from a view, but\nnot when selecting from the underlying table.  However, in the supplied\nreproducible test case, the view's column had a character set of UTF8\nwhile the underlying table had a character set of UCS2.\n\nAs it turns out, the real problem is not related to selecting from a\nview.  The root cause is a bug in the PCODE implementation for the LIKE\npredicate and this problem can occur any time the LIKE predicate is\napplied to a column declared as VARCHAR(nnn) CHARACTER SET UTF8 where\n128 <= nnn <= 255... and the problem may not be limited to situations\nwhere the LIKE pattern starts with a '%'.\n\nWhen nnn > 255, the PCODE implmentation is not used, so the problem does\nnot occur then.\n\nThe root cause is a place in the code where the length of the column (in\ncharacters, not bytes) is stored in a single byte and is retrieved as if\nthat byte contains a *signed* value.  When 128 <= nnn <= 255, that\nretrieval results in a negative value.  The fix is to retrieve the value\nas an *unsigned* value.\n\nNOTE: This commit changes 2 lines of code.  The second line changed is\nthe only one necessary to fix the problem.  The first line is being\nchanged as well because it has a similar problem and would prevent the\nLIKE predicate from working properly if the LIKE pattern had more than\n127 pattern parts.\n\nChange-Id: Ideb063cbd62b9155e9b1f579bcd0edb187e8a1c8","distinct":true,"url":"https://api.github.com/repos/trafodion/core/commits/ed604e8429f7ea005c9443633c51c21f04400e33"},{"sha":"1a49c80d9f42d41bf40daa46c1d372ddb8d3d718","author":{"email":"d95b56ce41a2e1ac4cecdd398defd7414407cc08@review.trafodion.org","name":"Trafodion Jenkins"},"message":"Merge \"Fix LP Bug 1382686 - LIKE predicate fails on some UTF8 columns\"","distinct":true,"url":"https://api.github.com/repos/trafodion/core/commits/1a49c80d9f42d41bf40daa46c1d372ddb8d3d718"}]}