{"action":"created","comment":{"url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/comments/39266465","id":39266465,"diff_hunk":"@@ -3,15 +3,25 @@\n namespace Zenstruck\\BackupBundle\\Destination;\n \n use Psr\\Log\\LoggerInterface;\n+use \\Countable;\n+use \\IteratorAggregate;\n \n /**\n  * @author Kevin Bond <kevinbond@gmail.com>\n  */\n-interface Destination\n+interface Destination extends Countable, IteratorAggregate","path":"Destination/Destination.php","position":11,"original_position":11,"commit_id":"605a57b19df1464e65a784a97ba85cb96d23a522","original_commit_id":"f4b04b0f10334992548a402df43d25bac8ff026b","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"body":"I would like the destination interface to remain as is. There is no reason for `S3CmdDestinaion` to implement `Countable`, `IteratorAggregate`. If you want `RotatingStreamDestination` to implement them, that's fine.","created_at":"2015-09-11T12:37:01Z","updated_at":"2015-09-11T12:37:01Z","html_url":"https://github.com/kbond/ZenstruckBackupBundle/pull/3#discussion_r39266465","pull_request_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/comments/39266465"},"html":{"href":"https://github.com/kbond/ZenstruckBackupBundle/pull/3#discussion_r39266465"},"pull_request":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3","id":44434659,"html_url":"https://github.com/kbond/ZenstruckBackupBundle/pull/3","diff_url":"https://github.com/kbond/ZenstruckBackupBundle/pull/3.diff","patch_url":"https://github.com/kbond/ZenstruckBackupBundle/pull/3.patch","issue_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues/3","number":3,"state":"open","locked":false,"title":"Inital mockup for rotations created","user":{"login":"TheCelavi","id":410738,"avatar_url":"https://avatars.githubusercontent.com/u/410738?v=3","gravatar_id":"","url":"https://api.github.com/users/TheCelavi","html_url":"https://github.com/TheCelavi","followers_url":"https://api.github.com/users/TheCelavi/followers","following_url":"https://api.github.com/users/TheCelavi/following{/other_user}","gists_url":"https://api.github.com/users/TheCelavi/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCelavi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCelavi/subscriptions","organizations_url":"https://api.github.com/users/TheCelavi/orgs","repos_url":"https://api.github.com/users/TheCelavi/repos","events_url":"https://api.github.com/users/TheCelavi/events{/privacy}","received_events_url":"https://api.github.com/users/TheCelavi/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-08T13:53:53Z","updated_at":"2015-09-11T12:37:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a95ee5c82ff3fd289c1407f440134d68116f525b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3/commits","review_comments_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3/comments","review_comment_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues/3/comments","statuses_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/statuses/605a57b19df1464e65a784a97ba85cb96d23a522","head":{"label":"RunOpenCode:master","ref":"master","sha":"605a57b19df1464e65a784a97ba85cb96d23a522","user":{"login":"RunOpenCode","id":2715749,"avatar_url":"https://avatars.githubusercontent.com/u/2715749?v=3","gravatar_id":"","url":"https://api.github.com/users/RunOpenCode","html_url":"https://github.com/RunOpenCode","followers_url":"https://api.github.com/users/RunOpenCode/followers","following_url":"https://api.github.com/users/RunOpenCode/following{/other_user}","gists_url":"https://api.github.com/users/RunOpenCode/gists{/gist_id}","starred_url":"https://api.github.com/users/RunOpenCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RunOpenCode/subscriptions","organizations_url":"https://api.github.com/users/RunOpenCode/orgs","repos_url":"https://api.github.com/users/RunOpenCode/repos","events_url":"https://api.github.com/users/RunOpenCode/events{/privacy}","received_events_url":"https://api.github.com/users/RunOpenCode/received_events","type":"Organization","site_admin":false},"repo":{"id":41795163,"name":"ZenstruckBackupBundle","full_name":"RunOpenCode/ZenstruckBackupBundle","owner":{"login":"RunOpenCode","id":2715749,"avatar_url":"https://avatars.githubusercontent.com/u/2715749?v=3","gravatar_id":"","url":"https://api.github.com/users/RunOpenCode","html_url":"https://github.com/RunOpenCode","followers_url":"https://api.github.com/users/RunOpenCode/followers","following_url":"https://api.github.com/users/RunOpenCode/following{/other_user}","gists_url":"https://api.github.com/users/RunOpenCode/gists{/gist_id}","starred_url":"https://api.github.com/users/RunOpenCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RunOpenCode/subscriptions","organizations_url":"https://api.github.com/users/RunOpenCode/orgs","repos_url":"https://api.github.com/users/RunOpenCode/repos","events_url":"https://api.github.com/users/RunOpenCode/events{/privacy}","received_events_url":"https://api.github.com/users/RunOpenCode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RunOpenCode/ZenstruckBackupBundle","description":"Symfony2 Bundle that wraps backup commands","fork":true,"url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle","forks_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/forks","keys_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/teams","hooks_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/hooks","issue_events_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/issues/events{/number}","events_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/events","assignees_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/assignees{/user}","branches_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/branches{/branch}","tags_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/tags","blobs_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/languages","stargazers_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/stargazers","contributors_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/contributors","subscribers_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/subscribers","subscription_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/subscription","commits_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/contents/{+path}","compare_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/merges","archive_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/downloads","issues_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/issues{/number}","pulls_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/labels{/name}","releases_url":"https://api.github.com/repos/RunOpenCode/ZenstruckBackupBundle/releases{/id}","created_at":"2015-09-02T10:28:51Z","updated_at":"2015-09-02T10:28:52Z","pushed_at":"2015-09-11T00:36:26Z","git_url":"git://github.com/RunOpenCode/ZenstruckBackupBundle.git","ssh_url":"git@github.com:RunOpenCode/ZenstruckBackupBundle.git","clone_url":"https://github.com/RunOpenCode/ZenstruckBackupBundle.git","svn_url":"https://github.com/RunOpenCode/ZenstruckBackupBundle","homepage":"http://zenstruck.com/projects/ZenstruckBackupBundle","size":119,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kbond:master","ref":"master","sha":"f4058a96ddcf512cf37e7cdc482f862c8712e92b","user":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"repo":{"id":18815669,"name":"ZenstruckBackupBundle","full_name":"kbond/ZenstruckBackupBundle","owner":{"login":"kbond","id":127811,"avatar_url":"https://avatars.githubusercontent.com/u/127811?v=3","gravatar_id":"","url":"https://api.github.com/users/kbond","html_url":"https://github.com/kbond","followers_url":"https://api.github.com/users/kbond/followers","following_url":"https://api.github.com/users/kbond/following{/other_user}","gists_url":"https://api.github.com/users/kbond/gists{/gist_id}","starred_url":"https://api.github.com/users/kbond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbond/subscriptions","organizations_url":"https://api.github.com/users/kbond/orgs","repos_url":"https://api.github.com/users/kbond/repos","events_url":"https://api.github.com/users/kbond/events{/privacy}","received_events_url":"https://api.github.com/users/kbond/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbond/ZenstruckBackupBundle","description":"Symfony2 Bundle that wraps backup commands","fork":false,"url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle","forks_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/forks","keys_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/teams","hooks_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/hooks","issue_events_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues/events{/number}","events_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/events","assignees_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/assignees{/user}","branches_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/branches{/branch}","tags_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/tags","blobs_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/languages","stargazers_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/stargazers","contributors_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/contributors","subscribers_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/subscribers","subscription_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/subscription","commits_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/contents/{+path}","compare_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/merges","archive_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/downloads","issues_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues{/number}","pulls_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/labels{/name}","releases_url":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/releases{/id}","created_at":"2014-04-15T20:57:03Z","updated_at":"2015-09-08T13:08:07Z","pushed_at":"2015-09-11T00:36:27Z","git_url":"git://github.com/kbond/ZenstruckBackupBundle.git","ssh_url":"git@github.com:kbond/ZenstruckBackupBundle.git","clone_url":"https://github.com/kbond/ZenstruckBackupBundle.git","svn_url":"https://github.com/kbond/ZenstruckBackupBundle","homepage":"http://zenstruck.com/projects/ZenstruckBackupBundle","size":248,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3"},"html":{"href":"https://github.com/kbond/ZenstruckBackupBundle/pull/3"},"issue":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues/3"},"comments":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/kbond/ZenstruckBackupBundle/statuses/605a57b19df1464e65a784a97ba85cb96d23a522"}}}}