{"action":"closed","number":3528,"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/3528","id":50774095,"html_url":"https://github.com/ReactiveX/RxJava/pull/3528","diff_url":"https://github.com/ReactiveX/RxJava/pull/3528.diff","patch_url":"https://github.com/ReactiveX/RxJava/pull/3528.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3528","number":3528,"state":"closed","locked":false,"title":"1.x: Avoid to call next when Iterator is drained","user":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=3","gravatar_id":"","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"body":"`delay` delays the `onCompleted` event and `unsubscribe` is called when `onCompleted` finishes. So if we put a `o.zipWith(Iterable, func)` before `delay`, such as `o.zipWith(Iterable, func).delay(...)`, `o` may keep emitting items even if `zipWith` emits an `onCompleted` event. This PR just fixed `OperatorZipIterable` to handle this case.\r\n\r\nFixes https://github.com/ReactiveX/RxScala/issues/180","created_at":"2015-11-16T05:59:01Z","updated_at":"2015-11-16T18:32:18Z","closed_at":"2015-11-16T18:32:18Z","merged_at":"2015-11-16T18:32:18Z","merge_commit_sha":"ba6a016a8512efaad13f0ebb8f18f92e49183239","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/3528/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/3528/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/3528/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/2fc3e986323b4f5702c8e881d5078bb653affeb2","head":{"label":"zsxwing:zipIter-delay","ref":"zipIter-delay","sha":"2fc3e986323b4f5702c8e881d5078bb653affeb2","user":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=3","gravatar_id":"","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"repo":{"id":12863876,"name":"RxJava","full_name":"zsxwing/RxJava","owner":{"login":"zsxwing","id":1000778,"avatar_url":"https://avatars.githubusercontent.com/u/1000778?v=3","gravatar_id":"","url":"https://api.github.com/users/zsxwing","html_url":"https://github.com/zsxwing","followers_url":"https://api.github.com/users/zsxwing/followers","following_url":"https://api.github.com/users/zsxwing/following{/other_user}","gists_url":"https://api.github.com/users/zsxwing/gists{/gist_id}","starred_url":"https://api.github.com/users/zsxwing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zsxwing/subscriptions","organizations_url":"https://api.github.com/users/zsxwing/orgs","repos_url":"https://api.github.com/users/zsxwing/repos","events_url":"https://api.github.com/users/zsxwing/events{/privacy}","received_events_url":"https://api.github.com/users/zsxwing/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zsxwing/RxJava","description":"RxJava - a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":true,"url":"https://api.github.com/repos/zsxwing/RxJava","forks_url":"https://api.github.com/repos/zsxwing/RxJava/forks","keys_url":"https://api.github.com/repos/zsxwing/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zsxwing/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zsxwing/RxJava/teams","hooks_url":"https://api.github.com/repos/zsxwing/RxJava/hooks","issue_events_url":"https://api.github.com/repos/zsxwing/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/zsxwing/RxJava/events","assignees_url":"https://api.github.com/repos/zsxwing/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/zsxwing/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/zsxwing/RxJava/tags","blobs_url":"https://api.github.com/repos/zsxwing/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zsxwing/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zsxwing/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/zsxwing/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zsxwing/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/zsxwing/RxJava/languages","stargazers_url":"https://api.github.com/repos/zsxwing/RxJava/stargazers","contributors_url":"https://api.github.com/repos/zsxwing/RxJava/contributors","subscribers_url":"https://api.github.com/repos/zsxwing/RxJava/subscribers","subscription_url":"https://api.github.com/repos/zsxwing/RxJava/subscription","commits_url":"https://api.github.com/repos/zsxwing/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/zsxwing/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/zsxwing/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/zsxwing/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/zsxwing/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/zsxwing/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zsxwing/RxJava/merges","archive_url":"https://api.github.com/repos/zsxwing/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zsxwing/RxJava/downloads","issues_url":"https://api.github.com/repos/zsxwing/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/zsxwing/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/zsxwing/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/zsxwing/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zsxwing/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/zsxwing/RxJava/releases{/id}","created_at":"2013-09-16T09:50:55Z","updated_at":"2014-07-04T08:45:27Z","pushed_at":"2015-11-16T18:09:11Z","git_url":"git://github.com/zsxwing/RxJava.git","ssh_url":"git@github.com:zsxwing/RxJava.git","clone_url":"https://github.com/zsxwing/RxJava.git","svn_url":"https://github.com/zsxwing/RxJava","homepage":"","size":15558,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.x"}},"base":{"label":"ReactiveX:1.x","ref":"1.x","sha":"bbc85bf1d46b8df69b72d773f80f2a3c461571dc","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"ReactiveX/RxJava","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJava","forks_url":"https://api.github.com/repos/ReactiveX/RxJava/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJava/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJava/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJava/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJava/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJava/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJava/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJava/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJava/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJava/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJava/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJava/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJava/releases{/id}","created_at":"2013-01-08T20:11:48Z","updated_at":"2015-11-16T17:28:50Z","pushed_at":"2015-11-16T18:32:18Z","git_url":"git://github.com/ReactiveX/RxJava.git","ssh_url":"git@github.com:ReactiveX/RxJava.git","clone_url":"https://github.com/ReactiveX/RxJava.git","svn_url":"https://github.com/ReactiveX/RxJava","homepage":"","size":472098,"stargazers_count":8700,"watchers_count":8700,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1243,"mirror_url":null,"open_issues_count":192,"forks":1243,"open_issues":192,"watchers":8700,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/3528"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/3528"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/3528"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/3528/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/3528/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/3528/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJava/statuses/2fc3e986323b4f5702c8e881d5078bb653affeb2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"akarnokd","id":1269832,"avatar_url":"https://avatars.githubusercontent.com/u/1269832?v=3","gravatar_id":"","url":"https://api.github.com/users/akarnokd","html_url":"https://github.com/akarnokd","followers_url":"https://api.github.com/users/akarnokd/followers","following_url":"https://api.github.com/users/akarnokd/following{/other_user}","gists_url":"https://api.github.com/users/akarnokd/gists{/gist_id}","starred_url":"https://api.github.com/users/akarnokd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akarnokd/subscriptions","organizations_url":"https://api.github.com/users/akarnokd/orgs","repos_url":"https://api.github.com/users/akarnokd/repos","events_url":"https://api.github.com/users/akarnokd/events{/privacy}","received_events_url":"https://api.github.com/users/akarnokd/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"commits":1,"additions":31,"deletions":3,"changed_files":2}}