{"action":"created","issue":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1443","labels_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1443/labels{/name}","comments_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1443/comments","events_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1443/events","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1443","id":118273758,"number":1443,"title":"Fixes PLY parsing of char and uchar scalars","user":{"login":"SergioRAgostinho","id":1709142,"avatar_url":"https://avatars.githubusercontent.com/u/1709142?v=3","gravatar_id":"","url":"https://api.github.com/users/SergioRAgostinho","html_url":"https://github.com/SergioRAgostinho","followers_url":"https://api.github.com/users/SergioRAgostinho/followers","following_url":"https://api.github.com/users/SergioRAgostinho/following{/other_user}","gists_url":"https://api.github.com/users/SergioRAgostinho/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioRAgostinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioRAgostinho/subscriptions","organizations_url":"https://api.github.com/users/SergioRAgostinho/orgs","repos_url":"https://api.github.com/users/SergioRAgostinho/repos","events_url":"https://api.github.com/users/SergioRAgostinho/events{/privacy}","received_events_url":"https://api.github.com/users/SergioRAgostinho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-11-22T16:39:57Z","updated_at":"2015-11-25T22:49:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/pulls/1443","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1443","diff_url":"https://github.com/PointCloudLibrary/pcl/pull/1443.diff","patch_url":"https://github.com/PointCloudLibrary/pcl/pull/1443.patch"},"body":"WIP of #1381\r\n\r\n```int8``` and ```uint8``` types were being evaluated as ```char``` and ```unsigned char```, their actual original type, which breaks their lexical_cast evaluation as integers.  Functionally-wise, this PR will make color parsing work. "},"comment":{"url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/comments/159749070","html_url":"https://github.com/PointCloudLibrary/pcl/pull/1443#issuecomment-159749070","issue_url":"https://api.github.com/repos/PointCloudLibrary/pcl/issues/1443","id":159749070,"user":{"login":"SergioRAgostinho","id":1709142,"avatar_url":"https://avatars.githubusercontent.com/u/1709142?v=3","gravatar_id":"","url":"https://api.github.com/users/SergioRAgostinho","html_url":"https://github.com/SergioRAgostinho","followers_url":"https://api.github.com/users/SergioRAgostinho/followers","following_url":"https://api.github.com/users/SergioRAgostinho/following{/other_user}","gists_url":"https://api.github.com/users/SergioRAgostinho/gists{/gist_id}","starred_url":"https://api.github.com/users/SergioRAgostinho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SergioRAgostinho/subscriptions","organizations_url":"https://api.github.com/users/SergioRAgostinho/orgs","repos_url":"https://api.github.com/users/SergioRAgostinho/repos","events_url":"https://api.github.com/users/SergioRAgostinho/events{/privacy}","received_events_url":"https://api.github.com/users/SergioRAgostinho/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T22:49:14Z","updated_at":"2015-11-25T22:49:14Z","body":"Thanks for trying it out. I'll probably amend the commit description with this small summary you just wrote on your comment. \r\n\r\nRegarding the test, don't merge this PR right yet, I'll  write the test as well. I already gave a look into that file and [test_io.cpp](https://github.com/PointCloudLibrary/pcl/blob/master/test/io/test_io.cpp) which has the [PLYReaderWriter](https://github.com/PointCloudLibrary/pcl/blob/master/test/io/test_io.cpp#L809-L866) test and I was wondering if it would not be preferable to gather all these PLY specific tests in a new test_ply.cpp file. \r\n\r\nI also found very strange the absence of PLY files in the test folder. Going through the source I realised that most code is actually saving and loading PLY files on-the-fly for each test. Which makes it more challenging to understand if the issue is actually on the reader/load or the writer/save. We should at least make sure the reader is working reliably before using it to evaluate the outputs of the writer. "}}