{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments/37711143","id":37711143,"diff_hunk":"@@ -567,13 +665,204 @@ public Priority getMinimumPriority() {\n      *\n      * @return the threshold limit\n      */\n+    @CheckForNull\n     public String getThresholdLimit() {\n         return thresholdLimit;\n     }\n \n+    /**\n+     * @see {@link #getThresholdLimit()}\n+     */\n+    @DataBoundSetter\n+    public void setThresholdLimit(String thresholdLimit) {\n+        this.thresholdLimit = StringUtils.defaultIfEmpty(thresholdLimit, DEFAULT_PRIORITY_THRESHOLD_LIMIT);\n+    }\n+\n     @Override\n     public BuildStepMonitor getRequiredMonitorService() {\n-        return canComputeNew() ? BuildStepMonitor.STEP : BuildStepMonitor.NONE;\n+        return BuildStepMonitor.NONE;\n+    }\n+\n+    /**\n+     *  Added to avoid the fat constructor. It replicates the constructor behaviour and\n+     *  offers the same field name outside.\n+     *  \n+     *  Useful when defining the groovy script in workflow jobs.\n+     */\n+    @DataBoundSetter\n+    public void setCanResolveRelativePaths(boolean canResolveRelativePaths) {\n+        doNotResolveRelativePaths = !canResolveRelativePaths;\n+    }\n+\n+    /**\n+     *  Added to avoid the fat constructor. It replicates the constructor behavior and\n+     *  offers the same field name outside.\n+     *  \n+     *  Useful when defining the groovy script in workflow jobs.\n+     */\n+    @DataBoundSetter\n+    public void setCanComputeNew(boolean canComputeNew) {\n+        dontComputeNew = !canComputeNew;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableTotalAll() {\n+        return thresholds.unstableTotalHigh;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableTotalAll(String unstableTotalAll) {\n+        thresholds.unstableTotalAll = unstableTotalAll;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableTotalHigh() {\n+        return thresholds.unstableTotalHigh;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableTotalHigh(String unstableTotalHigh) {\n+        thresholds.unstableTotalHigh = unstableTotalHigh;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableTotalNormal() {\n+        return thresholds.unstableTotalNormal;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableTotalNormal(String unstableTotalNormal) {\n+        thresholds.unstableTotalNormal = unstableTotalNormal;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableTotalLow() {\n+        return thresholds.unstableTotalLow;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableTotalLow(String unstableTotalLow) {\n+        thresholds.unstableTotalLow = unstableTotalLow;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableNewAll() {\n+        return thresholds.unstableNewAll;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableNewAll(String unstableNewAll) {\n+        thresholds.unstableNewAll = unstableNewAll;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableNewHigh() {\n+        return thresholds.unstableNewHigh;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableNewHigh(String unstableNewHigh) {\n+        thresholds.unstableNewHigh = unstableNewHigh;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableNewNormal() {\n+        return thresholds.unstableNewNormal;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableNewNormal(String unstableNewNormal) {\n+        thresholds.unstableNewNormal = unstableNewNormal;\n+    }\n+\n+    @CheckForNull\n+    public String getUnstableNewLow() {\n+        return thresholds.unstableNewLow;\n+    }\n+\n+    @DataBoundSetter\n+    public void setUnstableNewLow(String unstableNewLow) {\n+        thresholds.unstableNewLow = unstableNewLow;\n+    }\n+\n+    @CheckForNull\n+    public String getFailedTotalAll() {\n+        return thresholds.failedTotalAll;\n+    }\n+\n+    @DataBoundSetter\n+    public void setFailedTotalAll(String failedTotalAll) {\n+        thresholds.failedTotalAll = failedTotalAll;\n+    }\n+\n+    @CheckForNull\n+    public String getFailedTotalHigh() {\n+        return thresholds.failedTotalHigh;\n+    }\n+\n+    @DataBoundSetter\n+    public void setFailedTotalHigh(String failedTotalHigh) {\n+        thresholds.failedTotalHigh = failedTotalHigh;\n+    }\n+\n+    @CheckForNull\n+    public String getFailedTotalNormal() {\n+        return thresholds.failedTotalNormal;\n+    }\n+\n+    @DataBoundSetter\n+    public void setFailedTotalNormal(String failedTotalNormal) {\n+        thresholds.failedTotalNormal = failedTotalNormal;\n+    }\n+\n+    @CheckForNull\n+    public String getFailedTotalLow() {\n+        return thresholds.failedTotalNormal;","path":"src/main/java/hudson/plugins/analysis/core/HealthAwareRecorder.java","position":484,"original_position":484,"commit_id":"aa43fb2e2cadd99c96808fd7e3b001d6d64a5d63","original_commit_id":"aa43fb2e2cadd99c96808fd7e3b001d6d64a5d63","user":{"login":"uhafner","id":503338,"avatar_url":"https://avatars.githubusercontent.com/u/503338?v=3","gravatar_id":"","url":"https://api.github.com/users/uhafner","html_url":"https://github.com/uhafner","followers_url":"https://api.github.com/users/uhafner/followers","following_url":"https://api.github.com/users/uhafner/following{/other_user}","gists_url":"https://api.github.com/users/uhafner/gists{/gist_id}","starred_url":"https://api.github.com/users/uhafner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uhafner/subscriptions","organizations_url":"https://api.github.com/users/uhafner/orgs","repos_url":"https://api.github.com/users/uhafner/repos","events_url":"https://api.github.com/users/uhafner/events{/privacy}","received_events_url":"https://api.github.com/users/uhafner/received_events","type":"User","site_admin":false},"body":"totalLow","created_at":"2015-08-23T22:12:37Z","updated_at":"2015-08-23T22:12:37Z","html_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/31#discussion_r37711143","pull_request_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments/37711143"},"html":{"href":"https://github.com/jenkinsci/analysis-core-plugin/pull/31#discussion_r37711143"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31","id":40929799,"html_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/31","diff_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/31.diff","patch_url":"https://github.com/jenkinsci/analysis-core-plugin/pull/31.patch","issue_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/31","number":31,"state":"open","locked":false,"title":"[JENKINS-25977] Add workflow compatibility","user":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"body":"https://issues.jenkins-ci.org/browse/JENKINS-25977\r\n\r\nRequired changes to make this plugin compatible with Workflow jobs. After this changes any plugin extending ```analysis-core``` can be adapted to use Workflow too.\r\n\r\nRequires upstream: https://github.com/jenkinsci/analysis-pom-plugin/pull/2\r\n\r\nFor downstream PRs, use this dependency to analysis-core (it contains this PR as a snapshot):\r\n\r\n```\r\n<dependency>\r\n    <groupId>org.jvnet.hudson.plugins</groupId>\r\n    <artifactId>analysis-core</artifactId>\r\n    <version>1.73-beta-SNAPSHOT</version><!-- TODO: change to 1.73 before release -->\r\n</dependency>\r\n```\r\n\r\nDownstream PRs:\r\n* https://github.com/jenkinsci/findbugs-plugin/pull/9\r\n* https://github.com/jenkinsci/tasks-plugin/pull/2\r\n* https://github.com/jenkinsci/checkstyle-plugin/pull/8\r\n* https://github.com/jenkinsci/pmd-plugin/pull/3","created_at":"2015-07-27T17:46:36Z","updated_at":"2015-08-23T22:12:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"838bec70fe8e6c2076ed7d56d28e8d5e73905de5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/31/comments","statuses_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/statuses/aa43fb2e2cadd99c96808fd7e3b001d6d64a5d63","head":{"label":"amuniz:JENKINS-25977-workflow-compat","ref":"JENKINS-25977-workflow-compat","sha":"aa43fb2e2cadd99c96808fd7e3b001d6d64a5d63","user":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"repo":{"id":39244614,"name":"analysis-core-plugin","full_name":"amuniz/analysis-core-plugin","owner":{"login":"amuniz","id":1017585,"avatar_url":"https://avatars.githubusercontent.com/u/1017585?v=3","gravatar_id":"","url":"https://api.github.com/users/amuniz","html_url":"https://github.com/amuniz","followers_url":"https://api.github.com/users/amuniz/followers","following_url":"https://api.github.com/users/amuniz/following{/other_user}","gists_url":"https://api.github.com/users/amuniz/gists{/gist_id}","starred_url":"https://api.github.com/users/amuniz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amuniz/subscriptions","organizations_url":"https://api.github.com/users/amuniz/orgs","repos_url":"https://api.github.com/users/amuniz/repos","events_url":"https://api.github.com/users/amuniz/events{/privacy}","received_events_url":"https://api.github.com/users/amuniz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amuniz/analysis-core-plugin","description":"Jenkins analysis-core plugin","fork":true,"url":"https://api.github.com/repos/amuniz/analysis-core-plugin","forks_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/forks","keys_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/teams","hooks_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/hooks","issue_events_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/events","assignees_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/tags","blobs_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/languages","stargazers_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/stargazers","contributors_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/contributors","subscribers_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/subscribers","subscription_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/subscription","commits_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/merges","archive_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/downloads","issues_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/labels{/name}","releases_url":"https://api.github.com/repos/amuniz/analysis-core-plugin/releases{/id}","created_at":"2015-07-17T08:52:33Z","updated_at":"2015-07-17T08:52:34Z","pushed_at":"2015-08-21T10:26:21Z","git_url":"git://github.com/amuniz/analysis-core-plugin.git","ssh_url":"git@github.com:amuniz/analysis-core-plugin.git","clone_url":"https://github.com/amuniz/analysis-core-plugin.git","svn_url":"https://github.com/amuniz/analysis-core-plugin","homepage":"http://jenkins-ci.org/","size":2197,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"c90a666255b447b6374158e678bc398f7fd7d2e7","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1163439,"name":"analysis-core-plugin","full_name":"jenkinsci/analysis-core-plugin","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/analysis-core-plugin","description":"Jenkins analysis-core plugin","fork":false,"url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin","forks_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/forks","keys_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/teams","hooks_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/events","assignees_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/tags","blobs_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/subscription","commits_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/merges","archive_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/downloads","issues_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/releases{/id}","created_at":"2010-12-13T05:25:57Z","updated_at":"2015-04-14T11:41:05Z","pushed_at":"2015-08-21T10:26:21Z","git_url":"git://github.com/jenkinsci/analysis-core-plugin.git","ssh_url":"git@github.com:jenkinsci/analysis-core-plugin.git","clone_url":"https://github.com/jenkinsci/analysis-core-plugin.git","svn_url":"https://github.com/jenkinsci/analysis-core-plugin","homepage":"http://jenkins-ci.org/","size":4523,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":43,"mirror_url":null,"open_issues_count":1,"forks":43,"open_issues":1,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31"},"html":{"href":"https://github.com/jenkinsci/analysis-core-plugin/pull/31"},"issue":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/31"},"comments":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/analysis-core-plugin/statuses/aa43fb2e2cadd99c96808fd7e3b001d6d64a5d63"}}}}