{"action":"created","comment":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/36177655","id":36177655,"diff_hunk":"@@ -0,0 +1,11 @@\n+--- pdns/dnsproxy.cc.orig       Thu Oct 30 06:18:22 2014\n++++ pdns/dnsproxy.cc    Mon Dec  8 14:55:41 2014\n+@@ -169,7 +169,7 @@\n+       memcpy(&d,buffer,sizeof(d));\n+       {\n+         Lock l(&d_lock);\n+-#if BYTE_ORDER == BIG_ENDIAN\n++#ifdef _LITTLE_ENDIAN","path":"dnsproxy.cc.patch","position":8,"original_position":8,"commit_id":"ba302def9e6d0d4d076af08da3f068bc702202f7","original_commit_id":"ba302def9e6d0d4d076af08da3f068bc702202f7","user":{"login":"zeha","id":26175,"avatar_url":"https://avatars.githubusercontent.com/u/26175?v=3","gravatar_id":"","url":"https://api.github.com/users/zeha","html_url":"https://github.com/zeha","followers_url":"https://api.github.com/users/zeha/followers","following_url":"https://api.github.com/users/zeha/following{/other_user}","gists_url":"https://api.github.com/users/zeha/gists{/gist_id}","starred_url":"https://api.github.com/users/zeha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeha/subscriptions","organizations_url":"https://api.github.com/users/zeha/orgs","repos_url":"https://api.github.com/users/zeha/repos","events_url":"https://api.github.com/users/zeha/events{/privacy}","received_events_url":"https://api.github.com/users/zeha/received_events","type":"User","site_admin":false},"body":"doesn't the change imply that the `#if` should go away completely?","created_at":"2015-08-04T11:20:11Z","updated_at":"2015-08-04T11:20:11Z","html_url":"https://github.com/PowerDNS/pdns/pull/2655#discussion_r36177655","pull_request_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655","_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments/36177655"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/2655#discussion_r36177655"},"pull_request":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655"}}},"pull_request":{"url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655","id":40774083,"html_url":"https://github.com/PowerDNS/pdns/pull/2655","diff_url":"https://github.com/PowerDNS/pdns/pull/2655.diff","patch_url":"https://github.com/PowerDNS/pdns/pull/2655.patch","issue_url":"https://api.github.com/repos/PowerDNS/pdns/issues/2655","number":2655,"state":"open","locked":false,"title":"BUGFIX: pdns-1283 pdns_server and pdns_recursor do not get along","user":{"login":"UX-admin","id":3876804,"avatar_url":"https://avatars.githubusercontent.com/u/3876804?v=3","gravatar_id":"","url":"https://api.github.com/users/UX-admin","html_url":"https://github.com/UX-admin","followers_url":"https://api.github.com/users/UX-admin/followers","following_url":"https://api.github.com/users/UX-admin/following{/other_user}","gists_url":"https://api.github.com/users/UX-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/UX-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UX-admin/subscriptions","organizations_url":"https://api.github.com/users/UX-admin/orgs","repos_url":"https://api.github.com/users/UX-admin/repos","events_url":"https://api.github.com/users/UX-admin/events{/privacy}","received_events_url":"https://api.github.com/users/UX-admin/received_events","type":"User","site_admin":false},"body":"https://github.com/PowerDNS/pdns/issues/1283","created_at":"2015-07-24T13:22:44Z","updated_at":"2015-08-04T11:20:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92df99ee158ab7aadeed4eaa1ea2d1a6ef0d231b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655/commits","review_comments_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655/comments","review_comment_url":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/issues/2655/comments","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/ba302def9e6d0d4d076af08da3f068bc702202f7","head":{"label":"UX-admin:patch-1","ref":"patch-1","sha":"ba302def9e6d0d4d076af08da3f068bc702202f7","user":{"login":"UX-admin","id":3876804,"avatar_url":"https://avatars.githubusercontent.com/u/3876804?v=3","gravatar_id":"","url":"https://api.github.com/users/UX-admin","html_url":"https://github.com/UX-admin","followers_url":"https://api.github.com/users/UX-admin/followers","following_url":"https://api.github.com/users/UX-admin/following{/other_user}","gists_url":"https://api.github.com/users/UX-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/UX-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UX-admin/subscriptions","organizations_url":"https://api.github.com/users/UX-admin/orgs","repos_url":"https://api.github.com/users/UX-admin/repos","events_url":"https://api.github.com/users/UX-admin/events{/privacy}","received_events_url":"https://api.github.com/users/UX-admin/received_events","type":"User","site_admin":false},"repo":{"id":39633374,"name":"pdns","full_name":"UX-admin/pdns","owner":{"login":"UX-admin","id":3876804,"avatar_url":"https://avatars.githubusercontent.com/u/3876804?v=3","gravatar_id":"","url":"https://api.github.com/users/UX-admin","html_url":"https://github.com/UX-admin","followers_url":"https://api.github.com/users/UX-admin/followers","following_url":"https://api.github.com/users/UX-admin/following{/other_user}","gists_url":"https://api.github.com/users/UX-admin/gists{/gist_id}","starred_url":"https://api.github.com/users/UX-admin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UX-admin/subscriptions","organizations_url":"https://api.github.com/users/UX-admin/orgs","repos_url":"https://api.github.com/users/UX-admin/repos","events_url":"https://api.github.com/users/UX-admin/events{/privacy}","received_events_url":"https://api.github.com/users/UX-admin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/UX-admin/pdns","description":"PowerDNS","fork":true,"url":"https://api.github.com/repos/UX-admin/pdns","forks_url":"https://api.github.com/repos/UX-admin/pdns/forks","keys_url":"https://api.github.com/repos/UX-admin/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UX-admin/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UX-admin/pdns/teams","hooks_url":"https://api.github.com/repos/UX-admin/pdns/hooks","issue_events_url":"https://api.github.com/repos/UX-admin/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/UX-admin/pdns/events","assignees_url":"https://api.github.com/repos/UX-admin/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/UX-admin/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/UX-admin/pdns/tags","blobs_url":"https://api.github.com/repos/UX-admin/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UX-admin/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UX-admin/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/UX-admin/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UX-admin/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/UX-admin/pdns/languages","stargazers_url":"https://api.github.com/repos/UX-admin/pdns/stargazers","contributors_url":"https://api.github.com/repos/UX-admin/pdns/contributors","subscribers_url":"https://api.github.com/repos/UX-admin/pdns/subscribers","subscription_url":"https://api.github.com/repos/UX-admin/pdns/subscription","commits_url":"https://api.github.com/repos/UX-admin/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/UX-admin/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/UX-admin/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/UX-admin/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/UX-admin/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/UX-admin/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UX-admin/pdns/merges","archive_url":"https://api.github.com/repos/UX-admin/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UX-admin/pdns/downloads","issues_url":"https://api.github.com/repos/UX-admin/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/UX-admin/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/UX-admin/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/UX-admin/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UX-admin/pdns/labels{/name}","releases_url":"https://api.github.com/repos/UX-admin/pdns/releases{/id}","created_at":"2015-07-24T12:58:15Z","updated_at":"2015-07-24T12:58:20Z","pushed_at":"2015-07-24T13:20:22Z","git_url":"git://github.com/UX-admin/pdns.git","ssh_url":"git@github.com:UX-admin/pdns.git","clone_url":"https://github.com/UX-admin/pdns.git","svn_url":"https://github.com/UX-admin/pdns","homepage":null,"size":25237,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PowerDNS:master","ref":"master","sha":"f4ece5adc6e7ef47c83f56133c37522d9c7be546","user":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"repo":{"id":9693534,"name":"pdns","full_name":"PowerDNS/pdns","owner":{"login":"PowerDNS","id":1282630,"avatar_url":"https://avatars.githubusercontent.com/u/1282630?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerDNS","html_url":"https://github.com/PowerDNS","followers_url":"https://api.github.com/users/PowerDNS/followers","following_url":"https://api.github.com/users/PowerDNS/following{/other_user}","gists_url":"https://api.github.com/users/PowerDNS/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerDNS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerDNS/subscriptions","organizations_url":"https://api.github.com/users/PowerDNS/orgs","repos_url":"https://api.github.com/users/PowerDNS/repos","events_url":"https://api.github.com/users/PowerDNS/events{/privacy}","received_events_url":"https://api.github.com/users/PowerDNS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PowerDNS/pdns","description":"PowerDNS","fork":false,"url":"https://api.github.com/repos/PowerDNS/pdns","forks_url":"https://api.github.com/repos/PowerDNS/pdns/forks","keys_url":"https://api.github.com/repos/PowerDNS/pdns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PowerDNS/pdns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PowerDNS/pdns/teams","hooks_url":"https://api.github.com/repos/PowerDNS/pdns/hooks","issue_events_url":"https://api.github.com/repos/PowerDNS/pdns/issues/events{/number}","events_url":"https://api.github.com/repos/PowerDNS/pdns/events","assignees_url":"https://api.github.com/repos/PowerDNS/pdns/assignees{/user}","branches_url":"https://api.github.com/repos/PowerDNS/pdns/branches{/branch}","tags_url":"https://api.github.com/repos/PowerDNS/pdns/tags","blobs_url":"https://api.github.com/repos/PowerDNS/pdns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PowerDNS/pdns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PowerDNS/pdns/git/refs{/sha}","trees_url":"https://api.github.com/repos/PowerDNS/pdns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PowerDNS/pdns/statuses/{sha}","languages_url":"https://api.github.com/repos/PowerDNS/pdns/languages","stargazers_url":"https://api.github.com/repos/PowerDNS/pdns/stargazers","contributors_url":"https://api.github.com/repos/PowerDNS/pdns/contributors","subscribers_url":"https://api.github.com/repos/PowerDNS/pdns/subscribers","subscription_url":"https://api.github.com/repos/PowerDNS/pdns/subscription","commits_url":"https://api.github.com/repos/PowerDNS/pdns/commits{/sha}","git_commits_url":"https://api.github.com/repos/PowerDNS/pdns/git/commits{/sha}","comments_url":"https://api.github.com/repos/PowerDNS/pdns/comments{/number}","issue_comment_url":"https://api.github.com/repos/PowerDNS/pdns/issues/comments{/number}","contents_url":"https://api.github.com/repos/PowerDNS/pdns/contents/{+path}","compare_url":"https://api.github.com/repos/PowerDNS/pdns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PowerDNS/pdns/merges","archive_url":"https://api.github.com/repos/PowerDNS/pdns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PowerDNS/pdns/downloads","issues_url":"https://api.github.com/repos/PowerDNS/pdns/issues{/number}","pulls_url":"https://api.github.com/repos/PowerDNS/pdns/pulls{/number}","milestones_url":"https://api.github.com/repos/PowerDNS/pdns/milestones{/number}","notifications_url":"https://api.github.com/repos/PowerDNS/pdns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PowerDNS/pdns/labels{/name}","releases_url":"https://api.github.com/repos/PowerDNS/pdns/releases{/id}","created_at":"2013-04-26T11:16:49Z","updated_at":"2015-08-04T08:52:36Z","pushed_at":"2015-08-04T10:58:48Z","git_url":"git://github.com/PowerDNS/pdns.git","ssh_url":"git@github.com:PowerDNS/pdns.git","clone_url":"https://github.com/PowerDNS/pdns.git","svn_url":"https://github.com/PowerDNS/pdns","homepage":null,"size":45834,"stargazers_count":418,"watchers_count":418,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":368,"forks":151,"open_issues":368,"watchers":418,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655"},"html":{"href":"https://github.com/PowerDNS/pdns/pull/2655"},"issue":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/2655"},"comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/issues/2655/comments"},"review_comments":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655/comments"},"review_comment":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PowerDNS/pdns/pulls/2655/commits"},"statuses":{"href":"https://api.github.com/repos/PowerDNS/pdns/statuses/ba302def9e6d0d4d076af08da3f068bc702202f7"}}}}