{"action":"closed","number":22,"pull_request":{"url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/22","id":30752576,"html_url":"https://github.com/pei-jung/liferay-portal/pull/22","diff_url":"https://github.com/pei-jung/liferay-portal/pull/22.diff","patch_url":"https://github.com/pei-jung/liferay-portal/pull/22.patch","issue_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/22","number":22,"state":"closed","locked":false,"title":"LPS-54081 SF","user":{"login":"JorgeFerrer","id":868032,"avatar_url":"https://avatars.githubusercontent.com/u/868032?v=3","gravatar_id":"","url":"https://api.github.com/users/JorgeFerrer","html_url":"https://github.com/JorgeFerrer","followers_url":"https://api.github.com/users/JorgeFerrer/followers","following_url":"https://api.github.com/users/JorgeFerrer/following{/other_user}","gists_url":"https://api.github.com/users/JorgeFerrer/gists{/gist_id}","starred_url":"https://api.github.com/users/JorgeFerrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorgeFerrer/subscriptions","organizations_url":"https://api.github.com/users/JorgeFerrer/orgs","repos_url":"https://api.github.com/users/JorgeFerrer/repos","events_url":"https://api.github.com/users/JorgeFerrer/events{/privacy}","received_events_url":"https://api.github.com/users/JorgeFerrer/received_events","type":"User","site_admin":false},"body":"Hey Pei-Jung, we have more people helping apply the new exceptions pattern! :). I've taken a quick look at the code and it looks good, but I'd prefer if you can take a closer look just in case they have missed any detail. If you don't make any significant changes feel free to send a pull directly to Brian and Cc me","created_at":"2015-03-09T11:22:26Z","updated_at":"2015-03-10T17:06:31Z","closed_at":"2015-03-10T17:06:31Z","merged_at":null,"merge_commit_sha":"10300b61696b9608947489b529366e47420337a7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/22/commits","review_comments_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/22/comments","review_comment_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/22/comments","statuses_url":"https://api.github.com/repos/pei-jung/liferay-portal/statuses/83a06387438003b28ef3499776752bc77cfe5b4f","head":{"label":"JorgeFerrer:pr-488","ref":"pr-488","sha":"83a06387438003b28ef3499776752bc77cfe5b4f","user":{"login":"JorgeFerrer","id":868032,"avatar_url":"https://avatars.githubusercontent.com/u/868032?v=3","gravatar_id":"","url":"https://api.github.com/users/JorgeFerrer","html_url":"https://github.com/JorgeFerrer","followers_url":"https://api.github.com/users/JorgeFerrer/followers","following_url":"https://api.github.com/users/JorgeFerrer/following{/other_user}","gists_url":"https://api.github.com/users/JorgeFerrer/gists{/gist_id}","starred_url":"https://api.github.com/users/JorgeFerrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorgeFerrer/subscriptions","organizations_url":"https://api.github.com/users/JorgeFerrer/orgs","repos_url":"https://api.github.com/users/JorgeFerrer/repos","events_url":"https://api.github.com/users/JorgeFerrer/events{/privacy}","received_events_url":"https://api.github.com/users/JorgeFerrer/received_events","type":"User","site_admin":false},"repo":{"id":1959076,"name":"liferay-portal","full_name":"JorgeFerrer/liferay-portal","owner":{"login":"JorgeFerrer","id":868032,"avatar_url":"https://avatars.githubusercontent.com/u/868032?v=3","gravatar_id":"","url":"https://api.github.com/users/JorgeFerrer","html_url":"https://github.com/JorgeFerrer","followers_url":"https://api.github.com/users/JorgeFerrer/followers","following_url":"https://api.github.com/users/JorgeFerrer/following{/other_user}","gists_url":"https://api.github.com/users/JorgeFerrer/gists{/gist_id}","starred_url":"https://api.github.com/users/JorgeFerrer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JorgeFerrer/subscriptions","organizations_url":"https://api.github.com/users/JorgeFerrer/orgs","repos_url":"https://api.github.com/users/JorgeFerrer/repos","events_url":"https://api.github.com/users/JorgeFerrer/events{/privacy}","received_events_url":"https://api.github.com/users/JorgeFerrer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JorgeFerrer/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/JorgeFerrer/liferay-portal","forks_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/forks","keys_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/teams","hooks_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/events","assignees_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/tags","blobs_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/subscription","commits_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/merges","archive_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/downloads","issues_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/JorgeFerrer/liferay-portal/releases{/id}","created_at":"2011-06-27T08:01:00Z","updated_at":"2015-03-10T09:17:46Z","pushed_at":"2015-03-10T09:17:43Z","git_url":"git://github.com/JorgeFerrer/liferay-portal.git","ssh_url":"git@github.com:JorgeFerrer/liferay-portal.git","clone_url":"https://github.com/JorgeFerrer/liferay-portal.git","svn_url":"https://github.com/JorgeFerrer/liferay-portal","homepage":"http://liferay.com","size":4139016,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":4,"default_branch":"master"}},"base":{"label":"pei-jung:master","ref":"master","sha":"7dfbca0d35612c464d932239975965aca40325da","user":{"login":"pei-jung","id":5168351,"avatar_url":"https://avatars.githubusercontent.com/u/5168351?v=3","gravatar_id":"","url":"https://api.github.com/users/pei-jung","html_url":"https://github.com/pei-jung","followers_url":"https://api.github.com/users/pei-jung/followers","following_url":"https://api.github.com/users/pei-jung/following{/other_user}","gists_url":"https://api.github.com/users/pei-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/pei-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pei-jung/subscriptions","organizations_url":"https://api.github.com/users/pei-jung/orgs","repos_url":"https://api.github.com/users/pei-jung/repos","events_url":"https://api.github.com/users/pei-jung/events{/privacy}","received_events_url":"https://api.github.com/users/pei-jung/received_events","type":"User","site_admin":false},"repo":{"id":11906688,"name":"liferay-portal","full_name":"pei-jung/liferay-portal","owner":{"login":"pei-jung","id":5168351,"avatar_url":"https://avatars.githubusercontent.com/u/5168351?v=3","gravatar_id":"","url":"https://api.github.com/users/pei-jung","html_url":"https://github.com/pei-jung","followers_url":"https://api.github.com/users/pei-jung/followers","following_url":"https://api.github.com/users/pei-jung/following{/other_user}","gists_url":"https://api.github.com/users/pei-jung/gists{/gist_id}","starred_url":"https://api.github.com/users/pei-jung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pei-jung/subscriptions","organizations_url":"https://api.github.com/users/pei-jung/orgs","repos_url":"https://api.github.com/users/pei-jung/repos","events_url":"https://api.github.com/users/pei-jung/events{/privacy}","received_events_url":"https://api.github.com/users/pei-jung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pei-jung/liferay-portal","description":"","fork":true,"url":"https://api.github.com/repos/pei-jung/liferay-portal","forks_url":"https://api.github.com/repos/pei-jung/liferay-portal/forks","keys_url":"https://api.github.com/repos/pei-jung/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pei-jung/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pei-jung/liferay-portal/teams","hooks_url":"https://api.github.com/repos/pei-jung/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/pei-jung/liferay-portal/events","assignees_url":"https://api.github.com/repos/pei-jung/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/pei-jung/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/pei-jung/liferay-portal/tags","blobs_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pei-jung/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/pei-jung/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/pei-jung/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/pei-jung/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/pei-jung/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/pei-jung/liferay-portal/subscription","commits_url":"https://api.github.com/repos/pei-jung/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/pei-jung/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/pei-jung/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/pei-jung/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/pei-jung/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pei-jung/liferay-portal/merges","archive_url":"https://api.github.com/repos/pei-jung/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pei-jung/liferay-portal/downloads","issues_url":"https://api.github.com/repos/pei-jung/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/pei-jung/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/pei-jung/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/pei-jung/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pei-jung/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/pei-jung/liferay-portal/releases{/id}","created_at":"2013-08-05T19:22:22Z","updated_at":"2015-03-09T23:03:13Z","pushed_at":"2015-03-10T17:04:04Z","git_url":"git://github.com/pei-jung/liferay-portal.git","ssh_url":"git@github.com:pei-jung/liferay-portal.git","clone_url":"https://github.com/pei-jung/liferay-portal.git","svn_url":"https://github.com/pei-jung/liferay-portal","homepage":"http://liferay.com","size":4117583,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/22"},"html":{"href":"https://github.com/pei-jung/liferay-portal/pull/22"},"issue":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/issues/22"},"comments":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/pei-jung/liferay-portal/statuses/83a06387438003b28ef3499776752bc77cfe5b4f"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":693,"additions":10176,"deletions":5002,"changed_files":2195}}