{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/1607","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/1607/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1607/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/1607/events","html_url":"https://github.com/buildbot/buildbot/pull/1607","id":63841504,"number":1607,"title":"buildbotServiceManager: factorize for buildslave manager","user":{"login":"tardyp","id":109859,"avatar_url":"https://avatars.githubusercontent.com/u/109859?v=3","gravatar_id":"","url":"https://api.github.com/users/tardyp","html_url":"https://github.com/tardyp","followers_url":"https://api.github.com/users/tardyp/followers","following_url":"https://api.github.com/users/tardyp/following{/other_user}","gists_url":"https://api.github.com/users/tardyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tardyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tardyp/subscriptions","organizations_url":"https://api.github.com/users/tardyp/orgs","repos_url":"https://api.github.com/users/tardyp/repos","events_url":"https://api.github.com/users/tardyp/events{/privacy}","received_events_url":"https://api.github.com/users/tardyp/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20more%20review","name":"needs more review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-23T21:50:51Z","updated_at":"2015-03-28T22:16:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1607","html_url":"https://github.com/buildbot/buildbot/pull/1607","diff_url":"https://github.com/buildbot/buildbot/pull/1607.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1607.patch"},"body":"This factorize the buildslave manager child management code to be used\r\nby other managers.\r\n\r\nBuildslaves are becoming BuildbotServices, with generic constructor, checkConfig(), and reconfigService()\r\n\r\nNotable changes:\r\n- slave.slavename -> slave.name\r\n  This makes naming more generic. slave.slavename is kept as an aliased property\r\n\r\n- slave.master -> property\r\n  Special property of BuildbotService climb up the parents until master is found\r\n\r\n\r\nBaby step for reporter api..."},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/87323192","html_url":"https://github.com/buildbot/buildbot/pull/1607#issuecomment-87323192","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1607","id":87323192,"user":{"login":"sa2ajj","id":447092,"avatar_url":"https://avatars.githubusercontent.com/u/447092?v=3","gravatar_id":"","url":"https://api.github.com/users/sa2ajj","html_url":"https://github.com/sa2ajj","followers_url":"https://api.github.com/users/sa2ajj/followers","following_url":"https://api.github.com/users/sa2ajj/following{/other_user}","gists_url":"https://api.github.com/users/sa2ajj/gists{/gist_id}","starred_url":"https://api.github.com/users/sa2ajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sa2ajj/subscriptions","organizations_url":"https://api.github.com/users/sa2ajj/orgs","repos_url":"https://api.github.com/users/sa2ajj/repos","events_url":"https://api.github.com/users/sa2ajj/events{/privacy}","received_events_url":"https://api.github.com/users/sa2ajj/received_events","type":"User","site_admin":false},"created_at":"2015-03-28T22:16:49Z","updated_at":"2015-03-28T22:16:49Z","body":"@tardyp do you think you could rebase it on top of my [PR](1609)?"}}