{"action":"created","issue":{"url":"https://api.github.com/repos/ga4gh/server/issues/548","labels_url":"https://api.github.com/repos/ga4gh/server/issues/548/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/server/issues/548/comments","events_url":"https://api.github.com/repos/ga4gh/server/issues/548/events","html_url":"https://github.com/ga4gh/server/issues/548","id":99254190,"number":548,"title":"missing class in generated code?","user":{"login":"bwalsh","id":47808,"avatar_url":"https://avatars.githubusercontent.com/u/47808?v=3","gravatar_id":"","url":"https://api.github.com/users/bwalsh","html_url":"https://github.com/bwalsh","followers_url":"https://api.github.com/users/bwalsh/followers","following_url":"https://api.github.com/users/bwalsh/following{/other_user}","gists_url":"https://api.github.com/users/bwalsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bwalsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwalsh/subscriptions","organizations_url":"https://api.github.com/users/bwalsh/orgs","repos_url":"https://api.github.com/users/bwalsh/repos","events_url":"https://api.github.com/users/bwalsh/events{/privacy}","received_events_url":"https://api.github.com/users/bwalsh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-05T17:13:28Z","updated_at":"2015-08-06T19:11:30Z","closed_at":null,"body":"That schema contains two definitions of the class `SearchFeaturesResponse`.  How are these handled in the generated code in _protocol_definitions.py?   (Currently I only see one)\r\n\r\nThe schema project the current server is based on is  `version = '0.6.be171b00'`\r\nSnippets from this commit follow\r\n\r\n* One in the file genotypephenotypemethods.avdl,  protocol GenotypePhenotypeMethods\r\n```\r\n/** This is the response from `POST /genotypephenotype/search` expressed as JSON. */\r\nrecord SearchFeaturesResponse {\r\n  /**\r\n  The list of matching FeaturePhenotypeAssociation.\r\n  */\r\n  array<org.ga4gh.models.FeaturePhenotypeAssociation> associations = [];\r\n\r\n  ...\r\n```\r\n\r\n* The second one is found in sequenceAnnotationmethods.avdl \r\n```\r\n  /** This is the response from `POST /features/search` expressed as JSON. */\r\n  record SearchFeaturesResponse {\r\n    /**\r\n    The list of matching annotations, sorted by start position. Annotations which\r\n    share a start position are returned in a deterministic order.\r\n    */\r\n    array<org.ga4gh.models.Feature> features = [];\r\n\r\n    ... \r\n```\r\n\r\n* The generated code only has the class associated with `sequenceAnnotationmethods.avdl`\r\n\r\n```\r\n    def __init__(self):\r\n        self.features = []\r\n        self.nextPageToken = None\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ga4gh/server/issues/comments/128477196","html_url":"https://github.com/ga4gh/server/issues/548#issuecomment-128477196","issue_url":"https://api.github.com/repos/ga4gh/server/issues/548","id":128477196,"user":{"login":"jeromekelleher","id":2664569,"avatar_url":"https://avatars.githubusercontent.com/u/2664569?v=3","gravatar_id":"","url":"https://api.github.com/users/jeromekelleher","html_url":"https://github.com/jeromekelleher","followers_url":"https://api.github.com/users/jeromekelleher/followers","following_url":"https://api.github.com/users/jeromekelleher/following{/other_user}","gists_url":"https://api.github.com/users/jeromekelleher/gists{/gist_id}","starred_url":"https://api.github.com/users/jeromekelleher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeromekelleher/subscriptions","organizations_url":"https://api.github.com/users/jeromekelleher/orgs","repos_url":"https://api.github.com/users/jeromekelleher/repos","events_url":"https://api.github.com/users/jeromekelleher/events{/privacy}","received_events_url":"https://api.github.com/users/jeromekelleher/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T19:11:30Z","updated_at":"2015-08-06T19:11:30Z","body":"I'm not sure that ``process_schemas`` can do anything here @bwalsh --- we'll just have to change the names of one or both of these classes in the upstream schemas. This is a schema bug. I wouldn't read too much in to the schemas passing validation: the avro tools are quite weak for this sort of thing."}}