{"action":"closed","number":109,"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/109","id":48903270,"html_url":"https://github.com/neos/flow-development-collection/pull/109","diff_url":"https://github.com/neos/flow-development-collection/pull/109.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/109.patch","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/109","number":109,"state":"closed","locked":false,"title":"[BUGFIX] Validator chain is built correctly for cyclic relations","user":{"login":"albe","id":4259532,"avatar_url":"https://avatars.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"body":"For cases where an entity A references entity B and B in turn\r\nreferences A (as first property), the validator chain would not\r\nvalidate the reference to A inside B, even though those might be\r\ndifferent instances.\r\nThis is due to the newly created ObjectValidator for B not being added\r\nto the CollectionValidator inside A - so when B again visits A, the\r\nreturned validator collection is empty and hence not added to the\r\nvalidator chain.\r\n\r\nThis change fixes that, by adding the new ObjectValidator to the chain\r\nearly, and only removing it later on, if it is still empty after all\r\nproperties being checked. This could potentially lead to a deeper\r\nvalidator chain than would be necessary (cycle of empty ObjectValidators),\r\nbut should not break anything or degrade performance.\r\n\r\nFixes: FLOW-352","created_at":"2015-10-27T17:21:09Z","updated_at":"2015-11-27T14:37:08Z","closed_at":"2015-11-27T14:37:08Z","merged_at":null,"merge_commit_sha":"0beccd5664404c76d0abd952781aa62b622badff","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/109/commits","review_comments_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/109/comments","review_comment_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/109/comments","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/64905565eb1f62a63b9f03dfa91e40fed6f40eae","head":{"label":"albe:cyclic_validator_chain","ref":"cyclic_validator_chain","sha":"64905565eb1f62a63b9f03dfa91e40fed6f40eae","user":{"login":"albe","id":4259532,"avatar_url":"https://avatars.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"repo":{"id":41612763,"name":"flow-development-collection","full_name":"albe/flow-development-collection","owner":{"login":"albe","id":4259532,"avatar_url":"https://avatars.githubusercontent.com/u/4259532?v=3","gravatar_id":"","url":"https://api.github.com/users/albe","html_url":"https://github.com/albe","followers_url":"https://api.github.com/users/albe/followers","following_url":"https://api.github.com/users/albe/following{/other_user}","gists_url":"https://api.github.com/users/albe/gists{/gist_id}","starred_url":"https://api.github.com/users/albe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albe/subscriptions","organizations_url":"https://api.github.com/users/albe/orgs","repos_url":"https://api.github.com/users/albe/repos","events_url":"https://api.github.com/users/albe/events{/privacy}","received_events_url":"https://api.github.com/users/albe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albe/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":true,"url":"https://api.github.com/repos/albe/flow-development-collection","forks_url":"https://api.github.com/repos/albe/flow-development-collection/forks","keys_url":"https://api.github.com/repos/albe/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albe/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albe/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/albe/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/albe/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/albe/flow-development-collection/events","assignees_url":"https://api.github.com/repos/albe/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/albe/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/albe/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/albe/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albe/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albe/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/albe/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albe/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/albe/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/albe/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/albe/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/albe/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/albe/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/albe/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/albe/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/albe/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/albe/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/albe/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/albe/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albe/flow-development-collection/merges","archive_url":"https://api.github.com/repos/albe/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albe/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/albe/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/albe/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/albe/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/albe/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albe/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/albe/flow-development-collection/releases{/id}","created_at":"2015-08-30T01:29:22Z","updated_at":"2015-08-30T01:29:28Z","pushed_at":"2015-10-28T14:47:11Z","git_url":"git://github.com/albe/flow-development-collection.git","ssh_url":"git@github.com:albe/flow-development-collection.git","clone_url":"https://github.com/albe/flow-development-collection.git","svn_url":"https://github.com/albe/flow-development-collection","homepage":null,"size":33230,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:3.0","ref":"3.0","sha":"77d775e8c124b25ea489ce6a440e63c7eb7eaa4b","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40963991,"name":"flow-development-collection","full_name":"neos/flow-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":false,"url":"https://api.github.com/repos/neos/flow-development-collection","forks_url":"https://api.github.com/repos/neos/flow-development-collection/forks","keys_url":"https://api.github.com/repos/neos/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/flow-development-collection/events","assignees_url":"https://api.github.com/repos/neos/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/flow-development-collection/merges","archive_url":"https://api.github.com/repos/neos/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/flow-development-collection/releases{/id}","created_at":"2015-08-18T09:48:13Z","updated_at":"2015-11-24T12:59:24Z","pushed_at":"2015-11-27T14:36:01Z","git_url":"git://github.com/neos/flow-development-collection.git","ssh_url":"git@github.com:neos/flow-development-collection.git","clone_url":"https://github.com/neos/flow-development-collection.git","svn_url":"https://github.com/neos/flow-development-collection","homepage":null,"size":33891,"stargazers_count":26,"watchers_count":26,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":37,"forks":36,"open_issues":37,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/109"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/109"},"issue":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/109"},"comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/neos/flow-development-collection/statuses/64905565eb1f62a63b9f03dfa91e40fed6f40eae"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":65,"deletions":2,"changed_files":2}}