{"action":"created","issue":{"url":"https://api.github.com/repos/mgcrea/angular-strap/issues/1572","labels_url":"https://api.github.com/repos/mgcrea/angular-strap/issues/1572/labels{/name}","comments_url":"https://api.github.com/repos/mgcrea/angular-strap/issues/1572/comments","events_url":"https://api.github.com/repos/mgcrea/angular-strap/issues/1572/events","html_url":"https://github.com/mgcrea/angular-strap/issues/1572","id":61079155,"number":1572,"title":"options for all directives","user":{"login":"Hrafnkellos","id":2863090,"avatar_url":"https://avatars.githubusercontent.com/u/2863090?v=3","gravatar_id":"","url":"https://api.github.com/users/Hrafnkellos","html_url":"https://github.com/Hrafnkellos","followers_url":"https://api.github.com/users/Hrafnkellos/followers","following_url":"https://api.github.com/users/Hrafnkellos/following{/other_user}","gists_url":"https://api.github.com/users/Hrafnkellos/gists{/gist_id}","starred_url":"https://api.github.com/users/Hrafnkellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hrafnkellos/subscriptions","organizations_url":"https://api.github.com/users/Hrafnkellos/orgs","repos_url":"https://api.github.com/users/Hrafnkellos/repos","events_url":"https://api.github.com/users/Hrafnkellos/events{/privacy}","received_events_url":"https://api.github.com/users/Hrafnkellos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-13T14:40:47Z","updated_at":"2015-03-13T15:11:44Z","closed_at":null,"body":"When populating options for directives like the TypeAhead\r\n    \r\n    // Directive options\r\n    var options = {scope: scope};\r\n    angular.forEach(['placement', 'container', 'delay', 'trigger', 'keyboard', 'html', 'animation', 'template', 'filter', 'limit', 'minLength', 'watchOptions', 'selectMode', 'comparator', 'id'], function(key) {\r\n       if(angular.isDefined(attr[key])) options[key] = attr[key];\r\n    });\r\n\r\nOptions like minLength,delay and limit which are numbers, they are seen as strings witch is not correct. if i were to set these options they would be translated in the options object like so \r\n\r\n    {\r\n        minLength: \"0\",\r\n        limit: \"0\",\r\n        delay: \"0\"\r\n    }\r\n\r\nwe would like to have\r\n\r\n    {\r\n        minLength: 0,\r\n        limit: 0,\r\n        delay: 0\r\n    }\r\n\r\nthis causes incorrect logic when doing things like !\"0\" // output: false witch should be !0 //output: true"},"comment":{"url":"https://api.github.com/repos/mgcrea/angular-strap/issues/comments/79030073","html_url":"https://github.com/mgcrea/angular-strap/issues/1572#issuecomment-79030073","issue_url":"https://api.github.com/repos/mgcrea/angular-strap/issues/1572","id":79030073,"user":{"login":"Hrafnkellos","id":2863090,"avatar_url":"https://avatars.githubusercontent.com/u/2863090?v=3","gravatar_id":"","url":"https://api.github.com/users/Hrafnkellos","html_url":"https://github.com/Hrafnkellos","followers_url":"https://api.github.com/users/Hrafnkellos/followers","following_url":"https://api.github.com/users/Hrafnkellos/following{/other_user}","gists_url":"https://api.github.com/users/Hrafnkellos/gists{/gist_id}","starred_url":"https://api.github.com/users/Hrafnkellos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hrafnkellos/subscriptions","organizations_url":"https://api.github.com/users/Hrafnkellos/orgs","repos_url":"https://api.github.com/users/Hrafnkellos/repos","events_url":"https://api.github.com/users/Hrafnkellos/events{/privacy}","received_events_url":"https://api.github.com/users/Hrafnkellos/received_events","type":"User","site_admin":false},"created_at":"2015-03-13T15:11:44Z","updated_at":"2015-03-13T15:11:44Z","body":"that exact logic for !\"0\" can be found in the code. b.t.w."}}