{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments/48063071","id":48063071,"diff_hunk":"@@ -4,18 +4,44 @@\n   pkg.url \"http://buildsources.delivery.puppetlabs.net/curl-#{pkg.get_version}.tar.gz\"\n \n   pkg.build_requires \"openssl\"\n+  pkg.build_requires \"puppet-ca-bundle\"\n+\n+  prefix = settings[:prefix]\n+  pem_file = \"#{settings[:prefix]}/ssl/cert.pem\"\n+\n+  make = platform[:make]\n+\n+  if platform.is_windows?\n+    pkg.build_requires \"pl-zlib-#{platform.architecture}\"\n+    pkg.build_requires \"runtime\"\n+\n+    pkg.environment \"PATH\" => \"#{settings[:gcc_bindir]}:$$PATH\"\n+    pkg.environment \"CYGWIN\" => settings[:cygwin]\n+    pkg.environment \"CC\" => settings[:cc]\n+    pkg.environment \"CXX\" => settings[:cxx]\n+\n+    prefix = platform.convert_to_windows_path(settings[:prefix])\n+    pem_file = platform.convert_to_windows_path(\"#{settings[:puppet_configdir]}/ssl/cert.pem\")\n+\n+    make = \"/usr/bin/make\"\n+  end\n \n   pkg.configure do\n     [\"LDFLAGS='#{settings[:ldflags]}' \\\n-     ./configure --prefix=#{settings[:prefix]} \\\n-     --with-ssl=#{settings[:prefix]} --enable-threaded-resolver --disable-ldap --disable-ldaps --with-ca-bundle=#{settings[:prefix]}/ssl/cert.pem\"]\n+     ./configure --prefix=#{prefix} \\\n+        --with-ssl=#{prefix} \\\n+        --enable-threaded-resolver \\\n+        --disable-ldap \\\n+        --disable-ldaps \\\n+        --with-ca-bundle=#{pem_file} \\\n+        #{settings[:host]}\"]\n   end\n \n   pkg.build do\n-    [\"#{platform[:make]} -j$(shell expr $(shell #{platform[:num_cores]}) + 1)\"]\n+    [\"#{make} -j$(shell expr $(shell #{platform[:num_cores]}) + 1)\"]","path":"configs/components/curl.rb","position":41,"original_position":41,"commit_id":"76ee68dd855e32c30f4d88a6ed7ac7999b24746e","original_commit_id":"76ee68dd855e32c30f4d88a6ed7ac7999b24746e","user":{"login":"stahnma","id":6961,"avatar_url":"https://avatars.githubusercontent.com/u/6961?v=3","gravatar_id":"","url":"https://api.github.com/users/stahnma","html_url":"https://github.com/stahnma","followers_url":"https://api.github.com/users/stahnma/followers","following_url":"https://api.github.com/users/stahnma/following{/other_user}","gists_url":"https://api.github.com/users/stahnma/gists{/gist_id}","starred_url":"https://api.github.com/users/stahnma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stahnma/subscriptions","organizations_url":"https://api.github.com/users/stahnma/orgs","repos_url":"https://api.github.com/users/stahnma/repos","events_url":"https://api.github.com/users/stahnma/events{/privacy}","received_events_url":"https://api.github.com/users/stahnma/received_events","type":"User","site_admin":false},"body":"Why change from platform make to make? ","created_at":"2015-12-18T19:54:14Z","updated_at":"2015-12-18T19:54:14Z","html_url":"https://github.com/puppetlabs/puppet-agent/pull/455#discussion_r48063071","pull_request_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments/48063071"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/455#discussion_r48063071"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455","id":53922437,"html_url":"https://github.com/puppetlabs/puppet-agent/pull/455","diff_url":"https://github.com/puppetlabs/puppet-agent/pull/455.diff","patch_url":"https://github.com/puppetlabs/puppet-agent/pull/455.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/455","number":455,"state":"open","locked":false,"title":"(RE-6013, RE-6012, RE-6116, RE-611) Build OpenSSL, Curl, and our ca certs for windows","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"body":"This initial commit adds in the base work to build the puppet-agent project on windows, and modifies the curl, openssl, puppet-ca-bundle and runtime components to run on windows.","created_at":"2015-12-17T01:11:45Z","updated_at":"2015-12-18T19:54:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0dbf233213b117b2ab716abc9f4cb3aa2b7fc6f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/455/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/76ee68dd855e32c30f4d88a6ed7ac7999b24746e","head":{"label":"melissa:ticket/vanagon_for_the_win/initial-windows","ref":"ticket/vanagon_for_the_win/initial-windows","sha":"76ee68dd855e32c30f4d88a6ed7ac7999b24746e","user":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"repo":{"id":48144163,"name":"puppet-agent","full_name":"melissa/puppet-agent","owner":{"login":"melissa","id":4473089,"avatar_url":"https://avatars.githubusercontent.com/u/4473089?v=3","gravatar_id":"","url":"https://api.github.com/users/melissa","html_url":"https://github.com/melissa","followers_url":"https://api.github.com/users/melissa/followers","following_url":"https://api.github.com/users/melissa/following{/other_user}","gists_url":"https://api.github.com/users/melissa/gists{/gist_id}","starred_url":"https://api.github.com/users/melissa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melissa/subscriptions","organizations_url":"https://api.github.com/users/melissa/orgs","repos_url":"https://api.github.com/users/melissa/repos","events_url":"https://api.github.com/users/melissa/events{/privacy}","received_events_url":"https://api.github.com/users/melissa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/melissa/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":true,"url":"https://api.github.com/repos/melissa/puppet-agent","forks_url":"https://api.github.com/repos/melissa/puppet-agent/forks","keys_url":"https://api.github.com/repos/melissa/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/melissa/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/melissa/puppet-agent/teams","hooks_url":"https://api.github.com/repos/melissa/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/melissa/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/melissa/puppet-agent/events","assignees_url":"https://api.github.com/repos/melissa/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/melissa/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/melissa/puppet-agent/tags","blobs_url":"https://api.github.com/repos/melissa/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/melissa/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/melissa/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/melissa/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/melissa/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/melissa/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/melissa/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/melissa/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/melissa/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/melissa/puppet-agent/subscription","commits_url":"https://api.github.com/repos/melissa/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/melissa/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/melissa/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/melissa/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/melissa/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/melissa/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/melissa/puppet-agent/merges","archive_url":"https://api.github.com/repos/melissa/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/melissa/puppet-agent/downloads","issues_url":"https://api.github.com/repos/melissa/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/melissa/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/melissa/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/melissa/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/melissa/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/melissa/puppet-agent/releases{/id}","created_at":"2015-12-17T01:07:40Z","updated_at":"2015-12-17T01:07:41Z","pushed_at":"2015-12-18T19:31:43Z","git_url":"git://github.com/melissa/puppet-agent.git","ssh_url":"git@github.com:melissa/puppet-agent.git","clone_url":"https://github.com/melissa/puppet-agent.git","svn_url":"https://github.com/melissa/puppet-agent","homepage":null,"size":3156,"stargazers_count":0,"watchers_count":0,"language":"Groff","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:feature/master/windows-vanagon-development","ref":"feature/master/windows-vanagon-development","sha":"9d62b34b9c16f33c438db2bc81b1d31e1a2747a3","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":26777895,"name":"puppet-agent","full_name":"puppetlabs/puppet-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppet-agent","description":"All of the directions for building a puppet agent package.","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppet-agent","forks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppet-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppet-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppet-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppet-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppet-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppet-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppet-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppet-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppet-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppet-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppet-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppet-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppet-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppet-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppet-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppet-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppet-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppet-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppet-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppet-agent/releases{/id}","created_at":"2014-11-17T21:23:08Z","updated_at":"2015-12-17T06:42:14Z","pushed_at":"2015-12-18T19:27:33Z","git_url":"git://github.com/puppetlabs/puppet-agent.git","ssh_url":"git@github.com:puppetlabs/puppet-agent.git","clone_url":"https://github.com/puppetlabs/puppet-agent.git","svn_url":"https://github.com/puppetlabs/puppet-agent","homepage":null,"size":3210,"stargazers_count":3,"watchers_count":3,"language":"Groff","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":5,"forks":14,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455"},"html":{"href":"https://github.com/puppetlabs/puppet-agent/pull/455"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/455"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/issues/455/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/pulls/455/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppet-agent/statuses/76ee68dd855e32c30f4d88a6ed7ac7999b24746e"}}}}