{"action":"closed","number":8684,"pull_request":{"url":"https://api.github.com/repos/Wikia/app/pulls/8684","id":46801031,"html_url":"https://github.com/Wikia/app/pull/8684","diff_url":"https://github.com/Wikia/app/pull/8684.diff","patch_url":"https://github.com/Wikia/app/pull/8684.patch","issue_url":"https://api.github.com/repos/Wikia/app/issues/8684","number":8684,"state":"closed","locked":false,"title":"[PLATFORM-1539] Pool counter error log improvement","user":{"login":"jcellary","id":7473307,"avatar_url":"https://avatars.githubusercontent.com/u/7473307?v=3","gravatar_id":"","url":"https://api.github.com/users/jcellary","html_url":"https://github.com/jcellary","followers_url":"https://api.github.com/users/jcellary/followers","following_url":"https://api.github.com/users/jcellary/following{/other_user}","gists_url":"https://api.github.com/users/jcellary/gists{/gist_id}","starred_url":"https://api.github.com/users/jcellary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcellary/subscriptions","organizations_url":"https://api.github.com/users/jcellary/orgs","repos_url":"https://api.github.com/users/jcellary/repos","events_url":"https://api.github.com/users/jcellary/events{/privacy}","received_events_url":"https://api.github.com/users/jcellary/received_events","type":"User","site_admin":false},"body":"Pool counter log error method used getWikiText method which returns error message which is localized - we don't want that, so I log the error array instead.\r\n\r\nAdditionally the error that was logged is very generic and doesn't provide any context. I added logging of the original status, which will potentially allow us to get more information about the root cause.\r\n\r\nPinging @macbre and @wladekb \r\n\r\nWarning! I'm a Media Wiki newbie so please make a good code review, to make sure I'm not breaking something :)","created_at":"2015-10-05T16:13:22Z","updated_at":"2015-10-12T08:44:11Z","closed_at":"2015-10-12T08:44:11Z","merged_at":"2015-10-12T08:44:11Z","merge_commit_sha":"d9dbe745e60b6f0d80b1ab14cd315f7ee7179722","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/app/pulls/8684/commits","review_comments_url":"https://api.github.com/repos/Wikia/app/pulls/8684/comments","review_comment_url":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/app/issues/8684/comments","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/7876227c65a775626287fbc4cbe62db4a67a07df","head":{"label":"Wikia:poolcoounter-improved-error-log","ref":"poolcoounter-improved-error-log","sha":"7876227c65a775626287fbc4cbe62db4a67a07df","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-10-06T14:49:26Z","pushed_at":"2015-10-12T08:44:12Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1487399,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":61,"forks":71,"open_issues":61,"watchers":88,"default_branch":"dev"}},"base":{"label":"Wikia:dev","ref":"dev","sha":"cffdc9ae660d876646e9085cd9edbc309704906e","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":5532313,"name":"app","full_name":"Wikia/app","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/app","description":"Wikia Application Code","fork":false,"url":"https://api.github.com/repos/Wikia/app","forks_url":"https://api.github.com/repos/Wikia/app/forks","keys_url":"https://api.github.com/repos/Wikia/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/app/teams","hooks_url":"https://api.github.com/repos/Wikia/app/hooks","issue_events_url":"https://api.github.com/repos/Wikia/app/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/app/events","assignees_url":"https://api.github.com/repos/Wikia/app/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/app/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/app/tags","blobs_url":"https://api.github.com/repos/Wikia/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/app/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/app/languages","stargazers_url":"https://api.github.com/repos/Wikia/app/stargazers","contributors_url":"https://api.github.com/repos/Wikia/app/contributors","subscribers_url":"https://api.github.com/repos/Wikia/app/subscribers","subscription_url":"https://api.github.com/repos/Wikia/app/subscription","commits_url":"https://api.github.com/repos/Wikia/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/app/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/app/merges","archive_url":"https://api.github.com/repos/Wikia/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/app/downloads","issues_url":"https://api.github.com/repos/Wikia/app/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/app/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/app/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/app/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/app/releases{/id}","created_at":"2012-08-23T20:55:58Z","updated_at":"2015-10-06T14:49:26Z","pushed_at":"2015-10-12T08:44:12Z","git_url":"git://github.com/Wikia/app.git","ssh_url":"git@github.com:Wikia/app.git","clone_url":"https://github.com/Wikia/app.git","svn_url":"https://github.com/Wikia/app","homepage":"http://dev.wikia.com","size":1487399,"stargazers_count":88,"watchers_count":88,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":61,"forks":71,"open_issues":61,"watchers":88,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/app/pulls/8684"},"html":{"href":"https://github.com/Wikia/app/pull/8684"},"issue":{"href":"https://api.github.com/repos/Wikia/app/issues/8684"},"comments":{"href":"https://api.github.com/repos/Wikia/app/issues/8684/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/app/pulls/8684/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/app/pulls/8684/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/app/statuses/7876227c65a775626287fbc4cbe62db4a67a07df"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jcellary","id":7473307,"avatar_url":"https://avatars.githubusercontent.com/u/7473307?v=3","gravatar_id":"","url":"https://api.github.com/users/jcellary","html_url":"https://github.com/jcellary","followers_url":"https://api.github.com/users/jcellary/followers","following_url":"https://api.github.com/users/jcellary/following{/other_user}","gists_url":"https://api.github.com/users/jcellary/gists{/gist_id}","starred_url":"https://api.github.com/users/jcellary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcellary/subscriptions","organizations_url":"https://api.github.com/users/jcellary/orgs","repos_url":"https://api.github.com/users/jcellary/repos","events_url":"https://api.github.com/users/jcellary/events{/privacy}","received_events_url":"https://api.github.com/users/jcellary/received_events","type":"User","site_admin":false},"comments":3,"review_comments":12,"commits":8,"additions":31,"deletions":5,"changed_files":3}}