{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/chorn/dialable/pulls/2","id":52968744,"html_url":"https://github.com/chorn/dialable/pull/2","diff_url":"https://github.com/chorn/dialable/pull/2.diff","patch_url":"https://github.com/chorn/dialable/pull/2.patch","issue_url":"https://api.github.com/repos/chorn/dialable/issues/2","number":2,"state":"closed","locked":false,"title":"Huge refactoring branch that I forgot about","user":{"login":"chorn","id":12013,"avatar_url":"https://avatars.githubusercontent.com/u/12013?v=3","gravatar_id":"","url":"https://api.github.com/users/chorn","html_url":"https://github.com/chorn","followers_url":"https://api.github.com/users/chorn/followers","following_url":"https://api.github.com/users/chorn/following{/other_user}","gists_url":"https://api.github.com/users/chorn/gists{/gist_id}","starred_url":"https://api.github.com/users/chorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chorn/subscriptions","organizations_url":"https://api.github.com/users/chorn/orgs","repos_url":"https://api.github.com/users/chorn/repos","events_url":"https://api.github.com/users/chorn/events{/privacy}","received_events_url":"https://api.github.com/users/chorn/received_events","type":"User","site_admin":false},"body":"Yeah, so this one time I started making tiny refactoring passes, and then next thing you know, I'd split up the whole thing into smaller pieces. My specs were still green!  Yay!\r\n\r\nExcept I hated that the `areacode=` method was doing lots of work related to the ugly data in the NANPA dataset.\r\n\r\nAnd then I forgot about it for a few months.\r\n\r\nThis week I found it again, and finished up those changes. I also learned from `tzinfo` that the normal Ruby date/time code only works with 2 timezones, yours and UTC. That makes the daylight savings time code based relative time offsets stuff I was doing almost certainly wrong. Now, the timezones are the ISO yada yada \"US/Eastern\" style instead of EST/EDT. If that breaks a thing for you I'm really sorry! Let me know and I'll try to find another way. I am pretty sure no one cares though. :)\r\n\r\nAlso, the next thing to do will be to refactor the specs to match the new code organization.","created_at":"2015-12-08T11:28:34Z","updated_at":"2015-12-08T11:28:52Z","closed_at":"2015-12-08T11:28:52Z","merged_at":"2015-12-08T11:28:52Z","merge_commit_sha":"dde00b290070351ccdb2ede7dc60b4b77e27836b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chorn/dialable/pulls/2/commits","review_comments_url":"https://api.github.com/repos/chorn/dialable/pulls/2/comments","review_comment_url":"https://api.github.com/repos/chorn/dialable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chorn/dialable/issues/2/comments","statuses_url":"https://api.github.com/repos/chorn/dialable/statuses/9873cd3412659c538195064a19a9bfa78a458f4b","head":{"label":"chorn:refactor-unugly","ref":"refactor-unugly","sha":"9873cd3412659c538195064a19a9bfa78a458f4b","user":{"login":"chorn","id":12013,"avatar_url":"https://avatars.githubusercontent.com/u/12013?v=3","gravatar_id":"","url":"https://api.github.com/users/chorn","html_url":"https://github.com/chorn","followers_url":"https://api.github.com/users/chorn/followers","following_url":"https://api.github.com/users/chorn/following{/other_user}","gists_url":"https://api.github.com/users/chorn/gists{/gist_id}","starred_url":"https://api.github.com/users/chorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chorn/subscriptions","organizations_url":"https://api.github.com/users/chorn/orgs","repos_url":"https://api.github.com/users/chorn/repos","events_url":"https://api.github.com/users/chorn/events{/privacy}","received_events_url":"https://api.github.com/users/chorn/received_events","type":"User","site_admin":false},"repo":{"id":80849,"name":"dialable","full_name":"chorn/dialable","owner":{"login":"chorn","id":12013,"avatar_url":"https://avatars.githubusercontent.com/u/12013?v=3","gravatar_id":"","url":"https://api.github.com/users/chorn","html_url":"https://github.com/chorn","followers_url":"https://api.github.com/users/chorn/followers","following_url":"https://api.github.com/users/chorn/following{/other_user}","gists_url":"https://api.github.com/users/chorn/gists{/gist_id}","starred_url":"https://api.github.com/users/chorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chorn/subscriptions","organizations_url":"https://api.github.com/users/chorn/orgs","repos_url":"https://api.github.com/users/chorn/repos","events_url":"https://api.github.com/users/chorn/events{/privacy}","received_events_url":"https://api.github.com/users/chorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chorn/dialable","description":"A Ruby gem that provides parsing and output of North American Numbering Plan (NANP) phone numbers, and includes location and time zones.","fork":false,"url":"https://api.github.com/repos/chorn/dialable","forks_url":"https://api.github.com/repos/chorn/dialable/forks","keys_url":"https://api.github.com/repos/chorn/dialable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chorn/dialable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chorn/dialable/teams","hooks_url":"https://api.github.com/repos/chorn/dialable/hooks","issue_events_url":"https://api.github.com/repos/chorn/dialable/issues/events{/number}","events_url":"https://api.github.com/repos/chorn/dialable/events","assignees_url":"https://api.github.com/repos/chorn/dialable/assignees{/user}","branches_url":"https://api.github.com/repos/chorn/dialable/branches{/branch}","tags_url":"https://api.github.com/repos/chorn/dialable/tags","blobs_url":"https://api.github.com/repos/chorn/dialable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chorn/dialable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chorn/dialable/git/refs{/sha}","trees_url":"https://api.github.com/repos/chorn/dialable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chorn/dialable/statuses/{sha}","languages_url":"https://api.github.com/repos/chorn/dialable/languages","stargazers_url":"https://api.github.com/repos/chorn/dialable/stargazers","contributors_url":"https://api.github.com/repos/chorn/dialable/contributors","subscribers_url":"https://api.github.com/repos/chorn/dialable/subscribers","subscription_url":"https://api.github.com/repos/chorn/dialable/subscription","commits_url":"https://api.github.com/repos/chorn/dialable/commits{/sha}","git_commits_url":"https://api.github.com/repos/chorn/dialable/git/commits{/sha}","comments_url":"https://api.github.com/repos/chorn/dialable/comments{/number}","issue_comment_url":"https://api.github.com/repos/chorn/dialable/issues/comments{/number}","contents_url":"https://api.github.com/repos/chorn/dialable/contents/{+path}","compare_url":"https://api.github.com/repos/chorn/dialable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chorn/dialable/merges","archive_url":"https://api.github.com/repos/chorn/dialable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chorn/dialable/downloads","issues_url":"https://api.github.com/repos/chorn/dialable/issues{/number}","pulls_url":"https://api.github.com/repos/chorn/dialable/pulls{/number}","milestones_url":"https://api.github.com/repos/chorn/dialable/milestones{/number}","notifications_url":"https://api.github.com/repos/chorn/dialable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chorn/dialable/labels{/name}","releases_url":"https://api.github.com/repos/chorn/dialable/releases{/id}","created_at":"2008-11-25T17:24:16Z","updated_at":"2015-07-21T11:01:31Z","pushed_at":"2015-12-08T11:28:52Z","git_url":"git://github.com/chorn/dialable.git","ssh_url":"git@github.com:chorn/dialable.git","clone_url":"https://github.com/chorn/dialable.git","svn_url":"https://github.com/chorn/dialable","homepage":"","size":52,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"chorn:master","ref":"master","sha":"91237ae7b9391e357aa01fe8133a2d2ff55f9834","user":{"login":"chorn","id":12013,"avatar_url":"https://avatars.githubusercontent.com/u/12013?v=3","gravatar_id":"","url":"https://api.github.com/users/chorn","html_url":"https://github.com/chorn","followers_url":"https://api.github.com/users/chorn/followers","following_url":"https://api.github.com/users/chorn/following{/other_user}","gists_url":"https://api.github.com/users/chorn/gists{/gist_id}","starred_url":"https://api.github.com/users/chorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chorn/subscriptions","organizations_url":"https://api.github.com/users/chorn/orgs","repos_url":"https://api.github.com/users/chorn/repos","events_url":"https://api.github.com/users/chorn/events{/privacy}","received_events_url":"https://api.github.com/users/chorn/received_events","type":"User","site_admin":false},"repo":{"id":80849,"name":"dialable","full_name":"chorn/dialable","owner":{"login":"chorn","id":12013,"avatar_url":"https://avatars.githubusercontent.com/u/12013?v=3","gravatar_id":"","url":"https://api.github.com/users/chorn","html_url":"https://github.com/chorn","followers_url":"https://api.github.com/users/chorn/followers","following_url":"https://api.github.com/users/chorn/following{/other_user}","gists_url":"https://api.github.com/users/chorn/gists{/gist_id}","starred_url":"https://api.github.com/users/chorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chorn/subscriptions","organizations_url":"https://api.github.com/users/chorn/orgs","repos_url":"https://api.github.com/users/chorn/repos","events_url":"https://api.github.com/users/chorn/events{/privacy}","received_events_url":"https://api.github.com/users/chorn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chorn/dialable","description":"A Ruby gem that provides parsing and output of North American Numbering Plan (NANP) phone numbers, and includes location and time zones.","fork":false,"url":"https://api.github.com/repos/chorn/dialable","forks_url":"https://api.github.com/repos/chorn/dialable/forks","keys_url":"https://api.github.com/repos/chorn/dialable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chorn/dialable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chorn/dialable/teams","hooks_url":"https://api.github.com/repos/chorn/dialable/hooks","issue_events_url":"https://api.github.com/repos/chorn/dialable/issues/events{/number}","events_url":"https://api.github.com/repos/chorn/dialable/events","assignees_url":"https://api.github.com/repos/chorn/dialable/assignees{/user}","branches_url":"https://api.github.com/repos/chorn/dialable/branches{/branch}","tags_url":"https://api.github.com/repos/chorn/dialable/tags","blobs_url":"https://api.github.com/repos/chorn/dialable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chorn/dialable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chorn/dialable/git/refs{/sha}","trees_url":"https://api.github.com/repos/chorn/dialable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chorn/dialable/statuses/{sha}","languages_url":"https://api.github.com/repos/chorn/dialable/languages","stargazers_url":"https://api.github.com/repos/chorn/dialable/stargazers","contributors_url":"https://api.github.com/repos/chorn/dialable/contributors","subscribers_url":"https://api.github.com/repos/chorn/dialable/subscribers","subscription_url":"https://api.github.com/repos/chorn/dialable/subscription","commits_url":"https://api.github.com/repos/chorn/dialable/commits{/sha}","git_commits_url":"https://api.github.com/repos/chorn/dialable/git/commits{/sha}","comments_url":"https://api.github.com/repos/chorn/dialable/comments{/number}","issue_comment_url":"https://api.github.com/repos/chorn/dialable/issues/comments{/number}","contents_url":"https://api.github.com/repos/chorn/dialable/contents/{+path}","compare_url":"https://api.github.com/repos/chorn/dialable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chorn/dialable/merges","archive_url":"https://api.github.com/repos/chorn/dialable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chorn/dialable/downloads","issues_url":"https://api.github.com/repos/chorn/dialable/issues{/number}","pulls_url":"https://api.github.com/repos/chorn/dialable/pulls{/number}","milestones_url":"https://api.github.com/repos/chorn/dialable/milestones{/number}","notifications_url":"https://api.github.com/repos/chorn/dialable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chorn/dialable/labels{/name}","releases_url":"https://api.github.com/repos/chorn/dialable/releases{/id}","created_at":"2008-11-25T17:24:16Z","updated_at":"2015-07-21T11:01:31Z","pushed_at":"2015-12-08T11:28:52Z","git_url":"git://github.com/chorn/dialable.git","ssh_url":"git@github.com:chorn/dialable.git","clone_url":"https://github.com/chorn/dialable.git","svn_url":"https://github.com/chorn/dialable","homepage":"","size":52,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chorn/dialable/pulls/2"},"html":{"href":"https://github.com/chorn/dialable/pull/2"},"issue":{"href":"https://api.github.com/repos/chorn/dialable/issues/2"},"comments":{"href":"https://api.github.com/repos/chorn/dialable/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/chorn/dialable/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/chorn/dialable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chorn/dialable/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/chorn/dialable/statuses/9873cd3412659c538195064a19a9bfa78a458f4b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"chorn","id":12013,"avatar_url":"https://avatars.githubusercontent.com/u/12013?v=3","gravatar_id":"","url":"https://api.github.com/users/chorn","html_url":"https://github.com/chorn","followers_url":"https://api.github.com/users/chorn/followers","following_url":"https://api.github.com/users/chorn/following{/other_user}","gists_url":"https://api.github.com/users/chorn/gists{/gist_id}","starred_url":"https://api.github.com/users/chorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chorn/subscriptions","organizations_url":"https://api.github.com/users/chorn/orgs","repos_url":"https://api.github.com/users/chorn/repos","events_url":"https://api.github.com/users/chorn/events{/privacy}","received_events_url":"https://api.github.com/users/chorn/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":5,"additions":1521,"deletions":690,"changed_files":21}}