{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/22812476","id":22812476,"diff_hunk":"@@ -23,7 +23,7 @@ TEST(facter_util_environment, search_paths_empty_path) {\n     environment::reload_search_paths();\n \n     auto paths = environment::search_paths();\n-    ASSERT_EQ(0u, count(paths.begin(), paths.end(), \"\"));\n+    ASSERT_EQ(0u, static_cast<unsigned int>(count(paths.begin(), paths.end(), \"\")));","path":"lib/tests/util/windows/environment.cc","position":5,"original_position":5,"commit_id":"ec3f90052faec82a0c07cafbde99c0ce518e9e18","original_commit_id":"ec3f90052faec82a0c07cafbde99c0ce518e9e18","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Seems it's specified that way, so you should just change 0u to 0 instead.\r\n\r\nRef:\r\nhttp://www.cplusplus.com/reference/map/multimap/ - difference_type\r\nhttp://www.cplusplus.com/reference/algorithm/count/ - returns difference_type","created_at":"2015-01-12T19:01:13Z","updated_at":"2015-01-12T19:01:13Z","html_url":"https://github.com/puppetlabs/cfacter/pull/259#discussion_r22812476","pull_request_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/22812476"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/259#discussion_r22812476"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259","id":27143687,"html_url":"https://github.com/puppetlabs/cfacter/pull/259","diff_url":"https://github.com/puppetlabs/cfacter/pull/259.diff","patch_url":"https://github.com/puppetlabs/cfacter/pull/259.patch","issue_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/259","number":259,"state":"open","locked":false,"title":"(maint) Fix Windows build errors under GCC 4.9.","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"body":"A few Windows-related types have invalid, self-delegating constructors.\r\n\r\nThere's a signed/unsigned mismatch in one Windows-related test.","created_at":"2015-01-10T03:31:56Z","updated_at":"2015-01-12T19:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a129dbb45e6b1abbfda9af111e2fea4d6aa07489","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/{number}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/259/comments","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/ec3f90052faec82a0c07cafbde99c0ce518e9e18","head":{"label":"peterhuene:maint/fix","ref":"maint/fix","sha":"ec3f90052faec82a0c07cafbde99c0ce518e9e18","user":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"repo":{"id":19052426,"name":"cfacter","full_name":"peterhuene/cfacter","owner":{"login":"peterhuene","id":509666,"avatar_url":"https://avatars.githubusercontent.com/u/509666?v=3","gravatar_id":"","url":"https://api.github.com/users/peterhuene","html_url":"https://github.com/peterhuene","followers_url":"https://api.github.com/users/peterhuene/followers","following_url":"https://api.github.com/users/peterhuene/following{/other_user}","gists_url":"https://api.github.com/users/peterhuene/gists{/gist_id}","starred_url":"https://api.github.com/users/peterhuene/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterhuene/subscriptions","organizations_url":"https://api.github.com/users/peterhuene/orgs","repos_url":"https://api.github.com/users/peterhuene/repos","events_url":"https://api.github.com/users/peterhuene/events{/privacy}","received_events_url":"https://api.github.com/users/peterhuene/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterhuene/cfacter","description":"","fork":true,"url":"https://api.github.com/repos/peterhuene/cfacter","forks_url":"https://api.github.com/repos/peterhuene/cfacter/forks","keys_url":"https://api.github.com/repos/peterhuene/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterhuene/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterhuene/cfacter/teams","hooks_url":"https://api.github.com/repos/peterhuene/cfacter/hooks","issue_events_url":"https://api.github.com/repos/peterhuene/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/peterhuene/cfacter/events","assignees_url":"https://api.github.com/repos/peterhuene/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/peterhuene/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/peterhuene/cfacter/tags","blobs_url":"https://api.github.com/repos/peterhuene/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterhuene/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterhuene/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterhuene/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterhuene/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/peterhuene/cfacter/languages","stargazers_url":"https://api.github.com/repos/peterhuene/cfacter/stargazers","contributors_url":"https://api.github.com/repos/peterhuene/cfacter/contributors","subscribers_url":"https://api.github.com/repos/peterhuene/cfacter/subscribers","subscription_url":"https://api.github.com/repos/peterhuene/cfacter/subscription","commits_url":"https://api.github.com/repos/peterhuene/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterhuene/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterhuene/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterhuene/cfacter/issues/comments/{number}","contents_url":"https://api.github.com/repos/peterhuene/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/peterhuene/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterhuene/cfacter/merges","archive_url":"https://api.github.com/repos/peterhuene/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterhuene/cfacter/downloads","issues_url":"https://api.github.com/repos/peterhuene/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/peterhuene/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/peterhuene/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/peterhuene/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterhuene/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/peterhuene/cfacter/releases{/id}","created_at":"2014-04-23T01:16:12Z","updated_at":"2015-01-09T22:07:49Z","pushed_at":"2015-01-10T03:31:36Z","git_url":"git://github.com/peterhuene/cfacter.git","ssh_url":"git@github.com:peterhuene/cfacter.git","clone_url":"https://github.com/peterhuene/cfacter.git","svn_url":"https://github.com/peterhuene/cfacter","homepage":null,"size":6105,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"db2ee2fd35a162e91dd9cfdd21951afdc9ddc765","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":17602228,"name":"cfacter","full_name":"puppetlabs/cfacter","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/cfacter","description":"Collect and display system facts from a C++ library.","fork":false,"url":"https://api.github.com/repos/puppetlabs/cfacter","forks_url":"https://api.github.com/repos/puppetlabs/cfacter/forks","keys_url":"https://api.github.com/repos/puppetlabs/cfacter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/cfacter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/cfacter/teams","hooks_url":"https://api.github.com/repos/puppetlabs/cfacter/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/cfacter/events","assignees_url":"https://api.github.com/repos/puppetlabs/cfacter/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/cfacter/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/cfacter/tags","blobs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/cfacter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/cfacter/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/cfacter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/cfacter/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/cfacter/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/cfacter/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/cfacter/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/cfacter/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/cfacter/subscription","commits_url":"https://api.github.com/repos/puppetlabs/cfacter/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/cfacter/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/cfacter/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/cfacter/issues/comments/{number}","contents_url":"https://api.github.com/repos/puppetlabs/cfacter/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/cfacter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/cfacter/merges","archive_url":"https://api.github.com/repos/puppetlabs/cfacter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/cfacter/downloads","issues_url":"https://api.github.com/repos/puppetlabs/cfacter/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/cfacter/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/cfacter/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/cfacter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/cfacter/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/cfacter/releases{/id}","created_at":"2014-03-10T17:48:17Z","updated_at":"2015-01-09T22:03:45Z","pushed_at":"2015-01-09T22:03:45Z","git_url":"git://github.com/puppetlabs/cfacter.git","ssh_url":"git@github.com:puppetlabs/cfacter.git","clone_url":"https://github.com/puppetlabs/cfacter.git","svn_url":"https://github.com/puppetlabs/cfacter","homepage":"https://tickets.puppetlabs.com/browse/CFACT","size":79090,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":4,"forks":26,"open_issues":4,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259"},"html":{"href":"https://github.com/puppetlabs/cfacter/pull/259"},"issue":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/259"},"comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/issues/259/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/cfacter/pulls/259/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/cfacter/statuses/ec3f90052faec82a0c07cafbde99c0ce518e9e18"}}}}