{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/lexoyo/connect-fs/pulls/1","id":28160590,"html_url":"https://github.com/lexoyo/connect-fs/pull/1","diff_url":"https://github.com/lexoyo/connect-fs/pull/1.diff","patch_url":"https://github.com/lexoyo/connect-fs/pull/1.patch","issue_url":"https://api.github.com/repos/lexoyo/connect-fs/issues/1","number":1,"state":"closed","locked":false,"title":"ignore empty session files","user":{"login":"x4base","id":1527501,"avatar_url":"https://avatars.githubusercontent.com/u/1527501?v=3","gravatar_id":"","url":"https://api.github.com/users/x4base","html_url":"https://github.com/x4base","followers_url":"https://api.github.com/users/x4base/followers","following_url":"https://api.github.com/users/x4base/following{/other_user}","gists_url":"https://api.github.com/users/x4base/gists{/gist_id}","starred_url":"https://api.github.com/users/x4base/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x4base/subscriptions","organizations_url":"https://api.github.com/users/x4base/orgs","repos_url":"https://api.github.com/users/x4base/repos","events_url":"https://api.github.com/users/x4base/events{/privacy}","received_events_url":"https://api.github.com/users/x4base/received_events","type":"User","site_admin":false},"body":"!data is true means that the file is just somehow empty. I think there is not much the user can do here. Maybe it's better just to ignore this and let a new session to be started. Or it will just hang all the requests. We even ignored it when err is not empty at line #136, right? It means we really don't care what happens.","created_at":"2015-01-28T01:16:35Z","updated_at":"2015-01-31T17:59:42Z","closed_at":"2015-01-31T17:59:42Z","merged_at":"2015-01-31T17:59:42Z","merge_commit_sha":"4ac4201d2d056f634213aa7182c2d8fa1b5eb581","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lexoyo/connect-fs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/lexoyo/connect-fs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/lexoyo/connect-fs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lexoyo/connect-fs/issues/1/comments","statuses_url":"https://api.github.com/repos/lexoyo/connect-fs/statuses/de18ebe800978f71a5544b9e09e90b60cf18ebf3","head":{"label":"x4base:master","ref":"master","sha":"de18ebe800978f71a5544b9e09e90b60cf18ebf3","user":{"login":"x4base","id":1527501,"avatar_url":"https://avatars.githubusercontent.com/u/1527501?v=3","gravatar_id":"","url":"https://api.github.com/users/x4base","html_url":"https://github.com/x4base","followers_url":"https://api.github.com/users/x4base/followers","following_url":"https://api.github.com/users/x4base/following{/other_user}","gists_url":"https://api.github.com/users/x4base/gists{/gist_id}","starred_url":"https://api.github.com/users/x4base/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x4base/subscriptions","organizations_url":"https://api.github.com/users/x4base/orgs","repos_url":"https://api.github.com/users/x4base/repos","events_url":"https://api.github.com/users/x4base/events{/privacy}","received_events_url":"https://api.github.com/users/x4base/received_events","type":"User","site_admin":false},"repo":{"id":29943142,"name":"connect-fs","full_name":"x4base/connect-fs","owner":{"login":"x4base","id":1527501,"avatar_url":"https://avatars.githubusercontent.com/u/1527501?v=3","gravatar_id":"","url":"https://api.github.com/users/x4base","html_url":"https://github.com/x4base","followers_url":"https://api.github.com/users/x4base/followers","following_url":"https://api.github.com/users/x4base/following{/other_user}","gists_url":"https://api.github.com/users/x4base/gists{/gist_id}","starred_url":"https://api.github.com/users/x4base/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/x4base/subscriptions","organizations_url":"https://api.github.com/users/x4base/orgs","repos_url":"https://api.github.com/users/x4base/repos","events_url":"https://api.github.com/users/x4base/events{/privacy}","received_events_url":"https://api.github.com/users/x4base/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/x4base/connect-fs","description":"FileSystem session store for Connect and Express","fork":true,"url":"https://api.github.com/repos/x4base/connect-fs","forks_url":"https://api.github.com/repos/x4base/connect-fs/forks","keys_url":"https://api.github.com/repos/x4base/connect-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/x4base/connect-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/x4base/connect-fs/teams","hooks_url":"https://api.github.com/repos/x4base/connect-fs/hooks","issue_events_url":"https://api.github.com/repos/x4base/connect-fs/issues/events{/number}","events_url":"https://api.github.com/repos/x4base/connect-fs/events","assignees_url":"https://api.github.com/repos/x4base/connect-fs/assignees{/user}","branches_url":"https://api.github.com/repos/x4base/connect-fs/branches{/branch}","tags_url":"https://api.github.com/repos/x4base/connect-fs/tags","blobs_url":"https://api.github.com/repos/x4base/connect-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/x4base/connect-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/x4base/connect-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/x4base/connect-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/x4base/connect-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/x4base/connect-fs/languages","stargazers_url":"https://api.github.com/repos/x4base/connect-fs/stargazers","contributors_url":"https://api.github.com/repos/x4base/connect-fs/contributors","subscribers_url":"https://api.github.com/repos/x4base/connect-fs/subscribers","subscription_url":"https://api.github.com/repos/x4base/connect-fs/subscription","commits_url":"https://api.github.com/repos/x4base/connect-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/x4base/connect-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/x4base/connect-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/x4base/connect-fs/issues/comments/{number}","contents_url":"https://api.github.com/repos/x4base/connect-fs/contents/{+path}","compare_url":"https://api.github.com/repos/x4base/connect-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/x4base/connect-fs/merges","archive_url":"https://api.github.com/repos/x4base/connect-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/x4base/connect-fs/downloads","issues_url":"https://api.github.com/repos/x4base/connect-fs/issues{/number}","pulls_url":"https://api.github.com/repos/x4base/connect-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/x4base/connect-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/x4base/connect-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/x4base/connect-fs/labels{/name}","releases_url":"https://api.github.com/repos/x4base/connect-fs/releases{/id}","created_at":"2015-01-28T00:50:16Z","updated_at":"2015-01-30T21:59:32Z","pushed_at":"2015-01-30T21:59:32Z","git_url":"git://github.com/x4base/connect-fs.git","ssh_url":"git@github.com:x4base/connect-fs.git","clone_url":"https://github.com/x4base/connect-fs.git","svn_url":"https://github.com/x4base/connect-fs","homepage":"","size":105,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lexoyo:master","ref":"master","sha":"3f34a07dd62fec07770ba947e2cf2ba6abbdf3ec","user":{"login":"lexoyo","id":715377,"avatar_url":"https://avatars.githubusercontent.com/u/715377?v=3","gravatar_id":"","url":"https://api.github.com/users/lexoyo","html_url":"https://github.com/lexoyo","followers_url":"https://api.github.com/users/lexoyo/followers","following_url":"https://api.github.com/users/lexoyo/following{/other_user}","gists_url":"https://api.github.com/users/lexoyo/gists{/gist_id}","starred_url":"https://api.github.com/users/lexoyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexoyo/subscriptions","organizations_url":"https://api.github.com/users/lexoyo/orgs","repos_url":"https://api.github.com/users/lexoyo/repos","events_url":"https://api.github.com/users/lexoyo/events{/privacy}","received_events_url":"https://api.github.com/users/lexoyo/received_events","type":"User","site_admin":false},"repo":{"id":23252286,"name":"connect-fs","full_name":"lexoyo/connect-fs","owner":{"login":"lexoyo","id":715377,"avatar_url":"https://avatars.githubusercontent.com/u/715377?v=3","gravatar_id":"","url":"https://api.github.com/users/lexoyo","html_url":"https://github.com/lexoyo","followers_url":"https://api.github.com/users/lexoyo/followers","following_url":"https://api.github.com/users/lexoyo/following{/other_user}","gists_url":"https://api.github.com/users/lexoyo/gists{/gist_id}","starred_url":"https://api.github.com/users/lexoyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexoyo/subscriptions","organizations_url":"https://api.github.com/users/lexoyo/orgs","repos_url":"https://api.github.com/users/lexoyo/repos","events_url":"https://api.github.com/users/lexoyo/events{/privacy}","received_events_url":"https://api.github.com/users/lexoyo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lexoyo/connect-fs","description":"FileSystem session store for Connect and Express","fork":true,"url":"https://api.github.com/repos/lexoyo/connect-fs","forks_url":"https://api.github.com/repos/lexoyo/connect-fs/forks","keys_url":"https://api.github.com/repos/lexoyo/connect-fs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lexoyo/connect-fs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lexoyo/connect-fs/teams","hooks_url":"https://api.github.com/repos/lexoyo/connect-fs/hooks","issue_events_url":"https://api.github.com/repos/lexoyo/connect-fs/issues/events{/number}","events_url":"https://api.github.com/repos/lexoyo/connect-fs/events","assignees_url":"https://api.github.com/repos/lexoyo/connect-fs/assignees{/user}","branches_url":"https://api.github.com/repos/lexoyo/connect-fs/branches{/branch}","tags_url":"https://api.github.com/repos/lexoyo/connect-fs/tags","blobs_url":"https://api.github.com/repos/lexoyo/connect-fs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lexoyo/connect-fs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lexoyo/connect-fs/git/refs{/sha}","trees_url":"https://api.github.com/repos/lexoyo/connect-fs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lexoyo/connect-fs/statuses/{sha}","languages_url":"https://api.github.com/repos/lexoyo/connect-fs/languages","stargazers_url":"https://api.github.com/repos/lexoyo/connect-fs/stargazers","contributors_url":"https://api.github.com/repos/lexoyo/connect-fs/contributors","subscribers_url":"https://api.github.com/repos/lexoyo/connect-fs/subscribers","subscription_url":"https://api.github.com/repos/lexoyo/connect-fs/subscription","commits_url":"https://api.github.com/repos/lexoyo/connect-fs/commits{/sha}","git_commits_url":"https://api.github.com/repos/lexoyo/connect-fs/git/commits{/sha}","comments_url":"https://api.github.com/repos/lexoyo/connect-fs/comments{/number}","issue_comment_url":"https://api.github.com/repos/lexoyo/connect-fs/issues/comments/{number}","contents_url":"https://api.github.com/repos/lexoyo/connect-fs/contents/{+path}","compare_url":"https://api.github.com/repos/lexoyo/connect-fs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lexoyo/connect-fs/merges","archive_url":"https://api.github.com/repos/lexoyo/connect-fs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lexoyo/connect-fs/downloads","issues_url":"https://api.github.com/repos/lexoyo/connect-fs/issues{/number}","pulls_url":"https://api.github.com/repos/lexoyo/connect-fs/pulls{/number}","milestones_url":"https://api.github.com/repos/lexoyo/connect-fs/milestones{/number}","notifications_url":"https://api.github.com/repos/lexoyo/connect-fs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lexoyo/connect-fs/labels{/name}","releases_url":"https://api.github.com/repos/lexoyo/connect-fs/releases{/id}","created_at":"2014-08-23T09:12:44Z","updated_at":"2014-08-23T09:25:39Z","pushed_at":"2015-01-31T17:59:43Z","git_url":"git://github.com/lexoyo/connect-fs.git","ssh_url":"git@github.com:lexoyo/connect-fs.git","clone_url":"https://github.com/lexoyo/connect-fs.git","svn_url":"https://github.com/lexoyo/connect-fs","homepage":"","size":166,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lexoyo/connect-fs/pulls/1"},"html":{"href":"https://github.com/lexoyo/connect-fs/pull/1"},"issue":{"href":"https://api.github.com/repos/lexoyo/connect-fs/issues/1"},"comments":{"href":"https://api.github.com/repos/lexoyo/connect-fs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/lexoyo/connect-fs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/lexoyo/connect-fs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lexoyo/connect-fs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/lexoyo/connect-fs/statuses/de18ebe800978f71a5544b9e09e90b60cf18ebf3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"lexoyo","id":715377,"avatar_url":"https://avatars.githubusercontent.com/u/715377?v=3","gravatar_id":"","url":"https://api.github.com/users/lexoyo","html_url":"https://github.com/lexoyo","followers_url":"https://api.github.com/users/lexoyo/followers","following_url":"https://api.github.com/users/lexoyo/following{/other_user}","gists_url":"https://api.github.com/users/lexoyo/gists{/gist_id}","starred_url":"https://api.github.com/users/lexoyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lexoyo/subscriptions","organizations_url":"https://api.github.com/users/lexoyo/orgs","repos_url":"https://api.github.com/users/lexoyo/repos","events_url":"https://api.github.com/users/lexoyo/events{/privacy}","received_events_url":"https://api.github.com/users/lexoyo/received_events","type":"User","site_admin":false},"comments":3,"review_comments":2,"commits":4,"additions":4,"deletions":5,"changed_files":1}}