{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/700","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/700/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/700/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/700/events","html_url":"https://github.com/apache/cloudstack/pull/700","id":101205348,"number":700,"title":"Removed duplicate code in CitrixResourceBase and its subclasses","user":{"login":"cristofolini","id":2652220,"avatar_url":"https://avatars.githubusercontent.com/u/2652220?v=3","gravatar_id":"","url":"https://api.github.com/users/cristofolini","html_url":"https://github.com/cristofolini","followers_url":"https://api.github.com/users/cristofolini/followers","following_url":"https://api.github.com/users/cristofolini/following{/other_user}","gists_url":"https://api.github.com/users/cristofolini/gists{/gist_id}","starred_url":"https://api.github.com/users/cristofolini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristofolini/subscriptions","organizations_url":"https://api.github.com/users/cristofolini/orgs","repos_url":"https://api.github.com/users/cristofolini/repos","events_url":"https://api.github.com/users/cristofolini/events{/privacy}","received_events_url":"https://api.github.com/users/cristofolini/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":17,"created_at":"2015-08-15T20:01:55Z","updated_at":"2015-08-17T16:30:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/cloudstack/pulls/700","html_url":"https://github.com/apache/cloudstack/pull/700","diff_url":"https://github.com/apache/cloudstack/pull/700.diff","patch_url":"https://github.com/apache/cloudstack/pull/700.patch"},"body":"Removed unnecessary duplicated code by having the body of the getPatchFiles method only in the CitrixResourceBase superclass. Given that all of its implementations consisted of the same code except for the path which contains the necessary file for that implementation. An abstract method getPatchFilePath was created in the CitrixResourceBase superclass so that each implementation may return the path containing the specific file needed by that implementation.\r\n\r\nTest cases were created for each implementation, simple as they may be. One assert is made to verify that the path returned by each implementation corresponds to the path that was previously specified on each getPatchFiles implementation.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/131881064","html_url":"https://github.com/apache/cloudstack/pull/700#issuecomment-131881064","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/700","id":131881064,"user":{"login":"rafaelweingartner","id":4129005,"avatar_url":"https://avatars.githubusercontent.com/u/4129005?v=3","gravatar_id":"","url":"https://api.github.com/users/rafaelweingartner","html_url":"https://github.com/rafaelweingartner","followers_url":"https://api.github.com/users/rafaelweingartner/followers","following_url":"https://api.github.com/users/rafaelweingartner/following{/other_user}","gists_url":"https://api.github.com/users/rafaelweingartner/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaelweingartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaelweingartner/subscriptions","organizations_url":"https://api.github.com/users/rafaelweingartner/orgs","repos_url":"https://api.github.com/users/rafaelweingartner/repos","events_url":"https://api.github.com/users/rafaelweingartner/events{/privacy}","received_events_url":"https://api.github.com/users/rafaelweingartner/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T16:30:28Z","updated_at":"2015-08-17T16:30:28Z","body":"Fixed the commit title and message.\r\n\r\nIs it appearing as two (2) commits for you?\r\nHere it shows as just one.\r\n"}}