{"action":"created","comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/36407720","id":36407720,"diff_hunk":"@@ -94,7 +94,7 @@ int timer_init(tim_t dev, unsigned int ticks_per_us, void (*callback)(int))\n     /* send update event as trigger output */\n     timer0->CR2 |= TIM_CR2_MMS_1;\n     /* set auto-reload and prescaler values and load new values */\n-    timer0->ARR = TIMER_0_MAX_VALUE;\n+    timer0->ARR = 0xFFFF;","path":"cpu/stm32f1/periph/timer.c","position":5,"original_position":5,"commit_id":"eba9f431aef8dad280c97cc3bcf110ec1497fb67","original_commit_id":"eba9f431aef8dad280c97cc3bcf110ec1497fb67","user":{"login":"haukepetersen","id":620834,"avatar_url":"https://avatars.githubusercontent.com/u/620834?v=3","gravatar_id":"","url":"https://api.github.com/users/haukepetersen","html_url":"https://github.com/haukepetersen","followers_url":"https://api.github.com/users/haukepetersen/followers","following_url":"https://api.github.com/users/haukepetersen/following{/other_user}","gists_url":"https://api.github.com/users/haukepetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/haukepetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haukepetersen/subscriptions","organizations_url":"https://api.github.com/users/haukepetersen/orgs","repos_url":"https://api.github.com/users/haukepetersen/repos","events_url":"https://api.github.com/users/haukepetersen/events{/privacy}","received_events_url":"https://api.github.com/users/haukepetersen/received_events","type":"User","site_admin":false},"body":"why? In the periph_conf you set `TIMER_0_MAX_VALUE` to 0xffffffff","created_at":"2015-08-06T12:24:53Z","updated_at":"2015-08-06T12:24:53Z","html_url":"https://github.com/RIOT-OS/RIOT/pull/3525#discussion_r36407720","pull_request_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525","_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments/36407720"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3525#discussion_r36407720"},"pull_request":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525"}}},"pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525","id":41221680,"html_url":"https://github.com/RIOT-OS/RIOT/pull/3525","diff_url":"https://github.com/RIOT-OS/RIOT/pull/3525.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/3525.patch","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3525","number":3525,"state":"open","locked":false,"title":"switch to xtimer","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"body":"This PR contains changes that drop hwtimer+vtimer and use periph/timer and xtimer instead.\r\n\r\nDepends on #2926, those commits will go away as soon as xtimer itself is in.\r\n\r\nI've included a small (and inefficient) vtimer wrapper which makes using xtimer a drop-in replacement. Even using that wrapper, the code and memory requirements are lower than using the original hwtimer+vtimer code, with a lot of room for improvements.\r\n\r\nThis is work in progress. A lot else will not work at the moment. I'm putting it out so people can comment and collaborate early.\r\n\r\nCompiles & works on:\r\n\r\n- [x] native \r\n- [x] samr21\r\n- [x] iot-lab_M3","created_at":"2015-07-30T11:02:22Z","updated_at":"2015-08-06T12:24:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"341c39e47a038f97236878015cb494f133f2e617","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525/commits","review_comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525/comments","review_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3525/comments","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/eba9f431aef8dad280c97cc3bcf110ec1497fb67","head":{"label":"kaspar030:switch_to_xtimer","ref":"switch_to_xtimer","sha":"eba9f431aef8dad280c97cc3bcf110ec1497fb67","user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"repo":{"id":14115364,"name":"RIOT","full_name":"kaspar030/RIOT","owner":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars.githubusercontent.com/u/4679640?v=3","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kaspar030/RIOT","description":"RIOT -  The friendly OS for IoT","fork":true,"url":"https://api.github.com/repos/kaspar030/RIOT","forks_url":"https://api.github.com/repos/kaspar030/RIOT/forks","keys_url":"https://api.github.com/repos/kaspar030/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kaspar030/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kaspar030/RIOT/teams","hooks_url":"https://api.github.com/repos/kaspar030/RIOT/hooks","issue_events_url":"https://api.github.com/repos/kaspar030/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/kaspar030/RIOT/events","assignees_url":"https://api.github.com/repos/kaspar030/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/kaspar030/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/kaspar030/RIOT/tags","blobs_url":"https://api.github.com/repos/kaspar030/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kaspar030/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kaspar030/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/kaspar030/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kaspar030/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/kaspar030/RIOT/languages","stargazers_url":"https://api.github.com/repos/kaspar030/RIOT/stargazers","contributors_url":"https://api.github.com/repos/kaspar030/RIOT/contributors","subscribers_url":"https://api.github.com/repos/kaspar030/RIOT/subscribers","subscription_url":"https://api.github.com/repos/kaspar030/RIOT/subscription","commits_url":"https://api.github.com/repos/kaspar030/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/kaspar030/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/kaspar030/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/kaspar030/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/kaspar030/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/kaspar030/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kaspar030/RIOT/merges","archive_url":"https://api.github.com/repos/kaspar030/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kaspar030/RIOT/downloads","issues_url":"https://api.github.com/repos/kaspar030/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/kaspar030/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/kaspar030/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/kaspar030/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kaspar030/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/kaspar030/RIOT/releases{/id}","created_at":"2013-11-04T16:04:12Z","updated_at":"2015-05-08T14:32:24Z","pushed_at":"2015-08-06T11:11:50Z","git_url":"git://github.com/kaspar030/RIOT.git","ssh_url":"git@github.com:kaspar030/RIOT.git","clone_url":"https://github.com/kaspar030/RIOT.git","svn_url":"https://github.com/kaspar030/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":21368,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"RIOT-OS:master","ref":"master","sha":"220371c54a38599271bddc6408537c3407b3b29d","user":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"repo":{"id":7370241,"name":"RIOT","full_name":"RIOT-OS/RIOT","owner":{"login":"RIOT-OS","id":3079480,"avatar_url":"https://avatars.githubusercontent.com/u/3079480?v=3","gravatar_id":"","url":"https://api.github.com/users/RIOT-OS","html_url":"https://github.com/RIOT-OS","followers_url":"https://api.github.com/users/RIOT-OS/followers","following_url":"https://api.github.com/users/RIOT-OS/following{/other_user}","gists_url":"https://api.github.com/users/RIOT-OS/gists{/gist_id}","starred_url":"https://api.github.com/users/RIOT-OS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RIOT-OS/subscriptions","organizations_url":"https://api.github.com/users/RIOT-OS/orgs","repos_url":"https://api.github.com/users/RIOT-OS/repos","events_url":"https://api.github.com/users/RIOT-OS/events{/privacy}","received_events_url":"https://api.github.com/users/RIOT-OS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RIOT-OS/RIOT","description":"RIOT -  The friendly OS for IoT","fork":false,"url":"https://api.github.com/repos/RIOT-OS/RIOT","forks_url":"https://api.github.com/repos/RIOT-OS/RIOT/forks","keys_url":"https://api.github.com/repos/RIOT-OS/RIOT/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RIOT-OS/RIOT/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RIOT-OS/RIOT/teams","hooks_url":"https://api.github.com/repos/RIOT-OS/RIOT/hooks","issue_events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/events{/number}","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/events","assignees_url":"https://api.github.com/repos/RIOT-OS/RIOT/assignees{/user}","branches_url":"https://api.github.com/repos/RIOT-OS/RIOT/branches{/branch}","tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/tags","blobs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/refs{/sha}","trees_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/{sha}","languages_url":"https://api.github.com/repos/RIOT-OS/RIOT/languages","stargazers_url":"https://api.github.com/repos/RIOT-OS/RIOT/stargazers","contributors_url":"https://api.github.com/repos/RIOT-OS/RIOT/contributors","subscribers_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscribers","subscription_url":"https://api.github.com/repos/RIOT-OS/RIOT/subscription","commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/commits{/sha}","git_commits_url":"https://api.github.com/repos/RIOT-OS/RIOT/git/commits{/sha}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/comments{/number}","issue_comment_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments{/number}","contents_url":"https://api.github.com/repos/RIOT-OS/RIOT/contents/{+path}","compare_url":"https://api.github.com/repos/RIOT-OS/RIOT/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RIOT-OS/RIOT/merges","archive_url":"https://api.github.com/repos/RIOT-OS/RIOT/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RIOT-OS/RIOT/downloads","issues_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues{/number}","pulls_url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls{/number}","milestones_url":"https://api.github.com/repos/RIOT-OS/RIOT/milestones{/number}","notifications_url":"https://api.github.com/repos/RIOT-OS/RIOT/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/labels{/name}","releases_url":"https://api.github.com/repos/RIOT-OS/RIOT/releases{/id}","created_at":"2012-12-29T20:38:40Z","updated_at":"2015-08-04T11:08:54Z","pushed_at":"2015-08-06T12:05:28Z","git_url":"git://github.com/RIOT-OS/RIOT.git","ssh_url":"git@github.com:RIOT-OS/RIOT.git","clone_url":"https://github.com/RIOT-OS/RIOT.git","svn_url":"https://github.com/RIOT-OS/RIOT","homepage":"https://github.com/RIOT-OS/RIOT/wiki","size":121820,"stargazers_count":463,"watchers_count":463,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":352,"mirror_url":null,"open_issues_count":394,"forks":352,"open_issues":394,"watchers":463,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525"},"html":{"href":"https://github.com/RIOT-OS/RIOT/pull/3525"},"issue":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3525"},"comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/issues/3525/comments"},"review_comments":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525/comments"},"review_comment":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/3525/commits"},"statuses":{"href":"https://api.github.com/repos/RIOT-OS/RIOT/statuses/eba9f431aef8dad280c97cc3bcf110ec1497fb67"}}}}