{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/46274138","id":46274138,"diff_hunk":"@@ -178,6 +186,20 @@\n         ;\n         th.order();\n \n+        //Disable Pagination if a widget is in the data\n+        if (context.pagination()) {\n+            for (var iDx1 = 0; iDx1 < this._db._data.length; iDx1 ++) {","path":"src/other/Table.js","position":66,"original_position":66,"commit_id":"345dc3e43a99aebf60bcfc4f562f0a4d884788e5","original_commit_id":"345dc3e43a99aebf60bcfc4f562f0a4d884788e5","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"This breaks the \"Class encapsulation\" - IOW you should _not_ be reaching inside \"_db\".  Also this is potentially expensive...\r\n\r\nYou could have achieved the same thing with the following:\r\n```\r\nvar hasEmbeddedWidget = this.data().some(function(row) {\r\n    return row.some(function(cell) {\r\n        return cell instanceof Widget;\r\n    });\r\n});\r\n```\r\n\r\n","created_at":"2015-12-01T12:59:23Z","updated_at":"2015-12-01T12:59:23Z","html_url":"https://github.com/hpcc-systems/Visualization/pull/1237#discussion_r46274138","pull_request_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/46274138"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/1237#discussion_r46274138"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237","id":52174671,"html_url":"https://github.com/hpcc-systems/Visualization/pull/1237","diff_url":"https://github.com/hpcc-systems/Visualization/pull/1237.diff","patch_url":"https://github.com/hpcc-systems/Visualization/pull/1237.patch","issue_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/1237","number":1237,"state":"open","locked":false,"title":"GH-1161 Ability to embed a widget into a Table Widget cell","user":{"login":"dtsnell4","id":4304235,"avatar_url":"https://avatars.githubusercontent.com/u/4304235?v=3","gravatar_id":"","url":"https://api.github.com/users/dtsnell4","html_url":"https://github.com/dtsnell4","followers_url":"https://api.github.com/users/dtsnell4/followers","following_url":"https://api.github.com/users/dtsnell4/following{/other_user}","gists_url":"https://api.github.com/users/dtsnell4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsnell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsnell4/subscriptions","organizations_url":"https://api.github.com/users/dtsnell4/orgs","repos_url":"https://api.github.com/users/dtsnell4/repos","events_url":"https://api.github.com/users/dtsnell4/events{/privacy}","received_events_url":"https://api.github.com/users/dtsnell4/received_events","type":"User","site_admin":false},"body":"Adds the ability to include other widgets in the data to be displayed in a table cell.\r\n\r\nFixes GH-1161\r\n\r\nSigned-off-by: Dan Snell <Dan.Snell@lexisnexis.com>","created_at":"2015-11-30T20:28:31Z","updated_at":"2015-12-01T12:59:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fabb0fe993dcb822b83d1f5dcc774cad29c35dd6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/1237/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/345dc3e43a99aebf60bcfc4f562f0a4d884788e5","head":{"label":"dtsnell4:GH-1161_Table_Child_Widgets","ref":"GH-1161_Table_Child_Widgets","sha":"345dc3e43a99aebf60bcfc4f562f0a4d884788e5","user":{"login":"dtsnell4","id":4304235,"avatar_url":"https://avatars.githubusercontent.com/u/4304235?v=3","gravatar_id":"","url":"https://api.github.com/users/dtsnell4","html_url":"https://github.com/dtsnell4","followers_url":"https://api.github.com/users/dtsnell4/followers","following_url":"https://api.github.com/users/dtsnell4/following{/other_user}","gists_url":"https://api.github.com/users/dtsnell4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsnell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsnell4/subscriptions","organizations_url":"https://api.github.com/users/dtsnell4/orgs","repos_url":"https://api.github.com/users/dtsnell4/repos","events_url":"https://api.github.com/users/dtsnell4/events{/privacy}","received_events_url":"https://api.github.com/users/dtsnell4/received_events","type":"User","site_admin":false},"repo":{"id":35633558,"name":"Visualization","full_name":"dtsnell4/Visualization","owner":{"login":"dtsnell4","id":4304235,"avatar_url":"https://avatars.githubusercontent.com/u/4304235?v=3","gravatar_id":"","url":"https://api.github.com/users/dtsnell4","html_url":"https://github.com/dtsnell4","followers_url":"https://api.github.com/users/dtsnell4/followers","following_url":"https://api.github.com/users/dtsnell4/following{/other_user}","gists_url":"https://api.github.com/users/dtsnell4/gists{/gist_id}","starred_url":"https://api.github.com/users/dtsnell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtsnell4/subscriptions","organizations_url":"https://api.github.com/users/dtsnell4/orgs","repos_url":"https://api.github.com/users/dtsnell4/repos","events_url":"https://api.github.com/users/dtsnell4/events{/privacy}","received_events_url":"https://api.github.com/users/dtsnell4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtsnell4/Visualization","description":"Common Visualization Components","fork":true,"url":"https://api.github.com/repos/dtsnell4/Visualization","forks_url":"https://api.github.com/repos/dtsnell4/Visualization/forks","keys_url":"https://api.github.com/repos/dtsnell4/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtsnell4/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtsnell4/Visualization/teams","hooks_url":"https://api.github.com/repos/dtsnell4/Visualization/hooks","issue_events_url":"https://api.github.com/repos/dtsnell4/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/dtsnell4/Visualization/events","assignees_url":"https://api.github.com/repos/dtsnell4/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/dtsnell4/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/dtsnell4/Visualization/tags","blobs_url":"https://api.github.com/repos/dtsnell4/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtsnell4/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtsnell4/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtsnell4/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtsnell4/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/dtsnell4/Visualization/languages","stargazers_url":"https://api.github.com/repos/dtsnell4/Visualization/stargazers","contributors_url":"https://api.github.com/repos/dtsnell4/Visualization/contributors","subscribers_url":"https://api.github.com/repos/dtsnell4/Visualization/subscribers","subscription_url":"https://api.github.com/repos/dtsnell4/Visualization/subscription","commits_url":"https://api.github.com/repos/dtsnell4/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtsnell4/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtsnell4/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtsnell4/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtsnell4/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/dtsnell4/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtsnell4/Visualization/merges","archive_url":"https://api.github.com/repos/dtsnell4/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtsnell4/Visualization/downloads","issues_url":"https://api.github.com/repos/dtsnell4/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/dtsnell4/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/dtsnell4/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/dtsnell4/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtsnell4/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/dtsnell4/Visualization/releases{/id}","created_at":"2015-05-14T19:58:07Z","updated_at":"2015-05-14T19:58:08Z","pushed_at":"2015-11-30T20:27:26Z","git_url":"git://github.com/dtsnell4/Visualization.git","ssh_url":"git@github.com:dtsnell4/Visualization.git","clone_url":"https://github.com/dtsnell4/Visualization.git","svn_url":"https://github.com/dtsnell4/Visualization","homepage":"","size":14170,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-1.10.0","ref":"candidate-1.10.0","sha":"b99c88eeba9451676188bd34a508343b5ea609c8","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":22117259,"name":"Visualization","full_name":"hpcc-systems/Visualization","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/Visualization","description":"HPCC Visualization Framework","fork":false,"url":"https://api.github.com/repos/hpcc-systems/Visualization","forks_url":"https://api.github.com/repos/hpcc-systems/Visualization/forks","keys_url":"https://api.github.com/repos/hpcc-systems/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/Visualization/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/Visualization/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/Visualization/events","assignees_url":"https://api.github.com/repos/hpcc-systems/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/Visualization/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/Visualization/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/Visualization/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/Visualization/merges","archive_url":"https://api.github.com/repos/hpcc-systems/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/Visualization/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/Visualization/releases{/id}","created_at":"2014-07-22T19:13:04Z","updated_at":"2015-11-25T15:54:57Z","pushed_at":"2015-12-01T12:38:56Z","git_url":"git://github.com/hpcc-systems/Visualization.git","ssh_url":"git@github.com:hpcc-systems/Visualization.git","clone_url":"https://github.com/hpcc-systems/Visualization.git","svn_url":"https://github.com/hpcc-systems/Visualization","homepage":"http://rawgit.com/hpcc-systems/Visualization/master/demos/dermatology.html","size":21148,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":111,"forks":23,"open_issues":111,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/1237"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/1237"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/1237/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/1237/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/345dc3e43a99aebf60bcfc4f562f0a4d884788e5"}}}}