{"action":"closed","number":114,"pull_request":{"url":"https://api.github.com/repos/libuv/libuv/pulls/114","id":26817150,"html_url":"https://github.com/libuv/libuv/pull/114","diff_url":"https://github.com/libuv/libuv/pull/114.diff","patch_url":"https://github.com/libuv/libuv/pull/114.patch","issue_url":"https://api.github.com/repos/libuv/libuv/issues/114","number":114,"state":"closed","locked":false,"title":"[requestify]: uv_read","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"body":"Still in very early stages, I want to collect some initial feedback, since updating / fixing all tests will take a while.\r\n\r\nNotes on the implementation: I initially wanted to add the \"completed requests\" queue to the loop and start off by putting completed read and write requests there, but it's too involved and I'd need to add shutdown and connect requests there from the start. So, adjustments will be necessary for the \"pull based event loop\" approach, but this gets us much closer.\r\n\r\nThings to be done:\r\n\r\n- [x] Unix implementation\r\n- [ ] Update tests\r\n- [ ] Add new tests\r\n- [ ] Windows implementation\r\n- [ ] Merge uv_read and uv_try_read?\r\n- [ ] Update documentation\r\n\r\nR=@bnoordhuis\r\nR=@piscisaureus","created_at":"2015-01-05T10:58:49Z","updated_at":"2015-02-10T09:45:52Z","closed_at":"2015-02-10T09:45:52Z","merged_at":null,"merge_commit_sha":"f3e24843296f9df86fc5765097a4b5fa459ed6b9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libuv/libuv/pulls/114/commits","review_comments_url":"https://api.github.com/repos/libuv/libuv/pulls/114/comments","review_comment_url":"https://api.github.com/repos/libuv/libuv/pulls/comments/{number}","comments_url":"https://api.github.com/repos/libuv/libuv/issues/114/comments","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/06447cb623502d5cf336de1d83bb3da618b1a324","head":{"label":"saghul:uv_read","ref":"uv_read","sha":"06447cb623502d5cf336de1d83bb3da618b1a324","user":{"login":"saghul","id":317464,"avatar_url":"https://avatars.githubusercontent.com/u/317464?v=3","gravatar_id":"","url":"https://api.github.com/users/saghul","html_url":"https://github.com/saghul","followers_url":"https://api.github.com/users/saghul/followers","following_url":"https://api.github.com/users/saghul/following{/other_user}","gists_url":"https://api.github.com/users/saghul/gists{/gist_id}","starred_url":"https://api.github.com/users/saghul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saghul/subscriptions","organizations_url":"https://api.github.com/users/saghul/orgs","repos_url":"https://api.github.com/users/saghul/repos","events_url":"https://api.github.com/users/saghul/events{/privacy}","received_events_url":"https://api.github.com/users/saghul/received_events","type":"User","site_admin":false},"repo":null},"base":{"label":"libuv:master","ref":"master","sha":"182411e98bf650256c9c4789d49df878a321473e","user":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"repo":{"id":14812739,"name":"libuv","full_name":"libuv/libuv","owner":{"login":"libuv","id":4030929,"avatar_url":"https://avatars.githubusercontent.com/u/4030929?v=3","gravatar_id":"","url":"https://api.github.com/users/libuv","html_url":"https://github.com/libuv","followers_url":"https://api.github.com/users/libuv/followers","following_url":"https://api.github.com/users/libuv/following{/other_user}","gists_url":"https://api.github.com/users/libuv/gists{/gist_id}","starred_url":"https://api.github.com/users/libuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libuv/subscriptions","organizations_url":"https://api.github.com/users/libuv/orgs","repos_url":"https://api.github.com/users/libuv/repos","events_url":"https://api.github.com/users/libuv/events{/privacy}","received_events_url":"https://api.github.com/users/libuv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libuv/libuv","description":"Cross-platform asychronous I/O","fork":false,"url":"https://api.github.com/repos/libuv/libuv","forks_url":"https://api.github.com/repos/libuv/libuv/forks","keys_url":"https://api.github.com/repos/libuv/libuv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libuv/libuv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libuv/libuv/teams","hooks_url":"https://api.github.com/repos/libuv/libuv/hooks","issue_events_url":"https://api.github.com/repos/libuv/libuv/issues/events{/number}","events_url":"https://api.github.com/repos/libuv/libuv/events","assignees_url":"https://api.github.com/repos/libuv/libuv/assignees{/user}","branches_url":"https://api.github.com/repos/libuv/libuv/branches{/branch}","tags_url":"https://api.github.com/repos/libuv/libuv/tags","blobs_url":"https://api.github.com/repos/libuv/libuv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libuv/libuv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libuv/libuv/git/refs{/sha}","trees_url":"https://api.github.com/repos/libuv/libuv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libuv/libuv/statuses/{sha}","languages_url":"https://api.github.com/repos/libuv/libuv/languages","stargazers_url":"https://api.github.com/repos/libuv/libuv/stargazers","contributors_url":"https://api.github.com/repos/libuv/libuv/contributors","subscribers_url":"https://api.github.com/repos/libuv/libuv/subscribers","subscription_url":"https://api.github.com/repos/libuv/libuv/subscription","commits_url":"https://api.github.com/repos/libuv/libuv/commits{/sha}","git_commits_url":"https://api.github.com/repos/libuv/libuv/git/commits{/sha}","comments_url":"https://api.github.com/repos/libuv/libuv/comments{/number}","issue_comment_url":"https://api.github.com/repos/libuv/libuv/issues/comments/{number}","contents_url":"https://api.github.com/repos/libuv/libuv/contents/{+path}","compare_url":"https://api.github.com/repos/libuv/libuv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libuv/libuv/merges","archive_url":"https://api.github.com/repos/libuv/libuv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libuv/libuv/downloads","issues_url":"https://api.github.com/repos/libuv/libuv/issues{/number}","pulls_url":"https://api.github.com/repos/libuv/libuv/pulls{/number}","milestones_url":"https://api.github.com/repos/libuv/libuv/milestones{/number}","notifications_url":"https://api.github.com/repos/libuv/libuv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libuv/libuv/labels{/name}","releases_url":"https://api.github.com/repos/libuv/libuv/releases{/id}","created_at":"2013-11-30T00:29:56Z","updated_at":"2015-02-10T09:31:28Z","pushed_at":"2015-02-09T20:16:26Z","git_url":"git://github.com/libuv/libuv.git","ssh_url":"git@github.com:libuv/libuv.git","clone_url":"https://github.com/libuv/libuv.git","svn_url":"https://github.com/libuv/libuv","homepage":"http://libuv.org/","size":16937,"stargazers_count":901,"watchers_count":901,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":36,"forks":39,"open_issues":36,"watchers":901,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/libuv/libuv/pulls/114"},"html":{"href":"https://github.com/libuv/libuv/pull/114"},"issue":{"href":"https://api.github.com/repos/libuv/libuv/issues/114"},"comments":{"href":"https://api.github.com/repos/libuv/libuv/issues/114/comments"},"review_comments":{"href":"https://api.github.com/repos/libuv/libuv/pulls/114/comments"},"review_comment":{"href":"https://api.github.com/repos/libuv/libuv/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/libuv/libuv/pulls/114/commits"},"statuses":{"href":"https://api.github.com/repos/libuv/libuv/statuses/06447cb623502d5cf336de1d83bb3da618b1a324"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":2,"additions":358,"deletions":226,"changed_files":7}}