{"action":"created","comment":{"url":"https://api.github.com/repos/Mantle/Mantle/pulls/comments/35845319","id":35845319,"diff_hunk":"@@ -577,4 +577,56 @@ + (NSValueTransformer *)NSDateJSONTransformer {\n \texpect(weakTransformer).toEventually(beNil());\n });\n \n+it(@\"should initialize a MTLJSONSerializingProperty with MTLJSONAdapter by default\", ^{\n+\tNSDictionary *serializingValues = @{\n+\t\t\t\t\t\t\t @\"username\": @\"testName\",\n+\t\t\t\t\t\t\t @\"count\": @\"5\",\n+\t\t\t\t\t\t\t };\n+\t\n+\t\n+\tNSDictionary *JSONDictionary = @{\n+\t\t\t\t\t\t\t\t\t @\"property\": @\"property0\",\n+\t\t\t\t\t\t\t\t\t @\"mtlJSONSerializingProperty\": serializingValues,\n+\t\t\t\t\t\t\t\t\t @\"nonMTLJSONSerializingProperty\": @{}\n+\t\t\t\t\t\t\t\t\t };\n+\t\n+\tMTLJSONAdapter *adapter = [[MTLJSONAdapter alloc] initWithModelClass:MTLPropertyModel.class];\n+\texpect(adapter).notTo(beNil());\n+\t\n+\tNSError *error = nil;\n+\tMTLPropertyModel *model = [adapter modelFromJSONDictionary:JSONDictionary error:&error];\n+\texpect(error).to(beNil());\n+\t\n+\texpect(model).notTo(beNil());\n+\texpect(model.property).to(equal(@\"property0\"));\n+\texpect(model.mtlJSONSerializingProperty).notTo(beNil());\n+\texpect(model.mtlJSONSerializingProperty.name).to(equal(@\"testName\"));\n+\t\n+});\n+\n+it(@\"should only initialize a MTLJSONSerializingProperty with MTLJSONAdaptor by default, not MTLModel\", ^{\n+\tNSDictionary *serializingValues = @{\n+\t\t\t\t\t\t\t\t\t\t@\"username\": @\"testName\",\n+\t\t\t\t\t\t\t\t\t\t@\"count\": @\"5\",\n+\t\t\t\t\t\t\t\t\t\t};\n+\t\n+\t\n+\tNSDictionary *JSONDictionary = @{\n+\t\t\t\t\t\t\t\t\t @\"property\": @\"property0\",\n+\t\t\t\t\t\t\t\t\t @\"mtlJSONSerializingProperty\": serializingValues,\n+\t\t\t\t\t\t\t\t\t @\"nonMTLJSONSerializingProperty\": @{}\n+\t\t\t\t\t\t\t\t\t };\n+\t\n+\tMTLJSONAdapter *adapter = [[MTLJSONAdapter alloc] initWithModelClass:MTLPropertyModel.class];\n+\texpect(adapter).notTo(beNil());\n+\t\n+\tNSError *error = nil;\n+\tMTLPropertyModel *model = [adapter modelFromJSONDictionary:JSONDictionary error:&error];\n+\texpect(error).to(beNil());\n+\texpect(model).notTo(beNil());\n+\t\n+\tNSString *emptyModel = NSStringFromClass(MTLTestModel.class);\n+\tNSString *propertyType = NSStringFromClass(model.nonMTLJSONSerializingProperty.class);\n+\texpect(propertyType).notTo(equal(emptyModel));\n+});","path":"MantleTests/MTLJSONAdapterSpec.m","position":55,"original_position":55,"commit_id":"d53935130078be332eec631c940dc782ed290519","original_commit_id":"d53935130078be332eec631c940dc782ed290519","user":{"login":"robb","id":212465,"avatar_url":"https://avatars.githubusercontent.com/u/212465?v=3","gravatar_id":"","url":"https://api.github.com/users/robb","html_url":"https://github.com/robb","followers_url":"https://api.github.com/users/robb/followers","following_url":"https://api.github.com/users/robb/following{/other_user}","gists_url":"https://api.github.com/users/robb/gists{/gist_id}","starred_url":"https://api.github.com/users/robb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robb/subscriptions","organizations_url":"https://api.github.com/users/robb/orgs","repos_url":"https://api.github.com/users/robb/repos","events_url":"https://api.github.com/users/robb/events{/privacy}","received_events_url":"https://api.github.com/users/robb/received_events","type":"User","site_admin":false},"body":"Can you add a empty line above the `QuickSpecEnd`?","created_at":"2015-07-30T07:35:01Z","updated_at":"2015-07-30T07:35:01Z","html_url":"https://github.com/Mantle/Mantle/pull/533#discussion_r35845319","pull_request_url":"https://api.github.com/repos/Mantle/Mantle/pulls/533","_links":{"self":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/comments/35845319"},"html":{"href":"https://github.com/Mantle/Mantle/pull/533#discussion_r35845319"},"pull_request":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/533"}}},"pull_request":{"url":"https://api.github.com/repos/Mantle/Mantle/pulls/533","id":37019840,"html_url":"https://github.com/Mantle/Mantle/pull/533","diff_url":"https://github.com/Mantle/Mantle/pull/533.diff","patch_url":"https://github.com/Mantle/Mantle/pull/533.patch","issue_url":"https://api.github.com/repos/Mantle/Mantle/issues/533","number":533,"state":"open","locked":false,"title":"Transform the json with dictionaryTransformer by default.","user":{"login":"younthu","id":2912431,"avatar_url":"https://avatars.githubusercontent.com/u/2912431?v=3","gravatar_id":"","url":"https://api.github.com/users/younthu","html_url":"https://github.com/younthu","followers_url":"https://api.github.com/users/younthu/followers","following_url":"https://api.github.com/users/younthu/following{/other_user}","gists_url":"https://api.github.com/users/younthu/gists{/gist_id}","starred_url":"https://api.github.com/users/younthu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/younthu/subscriptions","organizations_url":"https://api.github.com/users/younthu/orgs","repos_url":"https://api.github.com/users/younthu/repos","events_url":"https://api.github.com/users/younthu/events{/privacy}","received_events_url":"https://api.github.com/users/younthu/received_events","type":"User","site_admin":false},"body":"In case user's model class specify no transformer for User defined MTLModel subclass, we should try to parse it with dictionaryTransformer by default, in side of MTLJSONAdapter adapter, because we are parsing json.","created_at":"2015-06-05T10:42:08Z","updated_at":"2015-07-30T07:35:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b28719b4f14b8ddb46d8e8f71d76fa8792263690","assignee":{"login":"robb","id":212465,"avatar_url":"https://avatars.githubusercontent.com/u/212465?v=3","gravatar_id":"","url":"https://api.github.com/users/robb","html_url":"https://github.com/robb","followers_url":"https://api.github.com/users/robb/followers","following_url":"https://api.github.com/users/robb/following{/other_user}","gists_url":"https://api.github.com/users/robb/gists{/gist_id}","starred_url":"https://api.github.com/users/robb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robb/subscriptions","organizations_url":"https://api.github.com/users/robb/orgs","repos_url":"https://api.github.com/users/robb/repos","events_url":"https://api.github.com/users/robb/events{/privacy}","received_events_url":"https://api.github.com/users/robb/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Mantle/Mantle/pulls/533/commits","review_comments_url":"https://api.github.com/repos/Mantle/Mantle/pulls/533/comments","review_comment_url":"https://api.github.com/repos/Mantle/Mantle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mantle/Mantle/issues/533/comments","statuses_url":"https://api.github.com/repos/Mantle/Mantle/statuses/d53935130078be332eec631c940dc782ed290519","head":{"label":"younthu:master","ref":"master","sha":"d53935130078be332eec631c940dc782ed290519","user":{"login":"younthu","id":2912431,"avatar_url":"https://avatars.githubusercontent.com/u/2912431?v=3","gravatar_id":"","url":"https://api.github.com/users/younthu","html_url":"https://github.com/younthu","followers_url":"https://api.github.com/users/younthu/followers","following_url":"https://api.github.com/users/younthu/following{/other_user}","gists_url":"https://api.github.com/users/younthu/gists{/gist_id}","starred_url":"https://api.github.com/users/younthu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/younthu/subscriptions","organizations_url":"https://api.github.com/users/younthu/orgs","repos_url":"https://api.github.com/users/younthu/repos","events_url":"https://api.github.com/users/younthu/events{/privacy}","received_events_url":"https://api.github.com/users/younthu/received_events","type":"User","site_admin":false},"repo":{"id":36926509,"name":"Mantle","full_name":"younthu/Mantle","owner":{"login":"younthu","id":2912431,"avatar_url":"https://avatars.githubusercontent.com/u/2912431?v=3","gravatar_id":"","url":"https://api.github.com/users/younthu","html_url":"https://github.com/younthu","followers_url":"https://api.github.com/users/younthu/followers","following_url":"https://api.github.com/users/younthu/following{/other_user}","gists_url":"https://api.github.com/users/younthu/gists{/gist_id}","starred_url":"https://api.github.com/users/younthu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/younthu/subscriptions","organizations_url":"https://api.github.com/users/younthu/orgs","repos_url":"https://api.github.com/users/younthu/repos","events_url":"https://api.github.com/users/younthu/events{/privacy}","received_events_url":"https://api.github.com/users/younthu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/younthu/Mantle","description":"Model framework for Cocoa and Cocoa Touch","fork":true,"url":"https://api.github.com/repos/younthu/Mantle","forks_url":"https://api.github.com/repos/younthu/Mantle/forks","keys_url":"https://api.github.com/repos/younthu/Mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/younthu/Mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/younthu/Mantle/teams","hooks_url":"https://api.github.com/repos/younthu/Mantle/hooks","issue_events_url":"https://api.github.com/repos/younthu/Mantle/issues/events{/number}","events_url":"https://api.github.com/repos/younthu/Mantle/events","assignees_url":"https://api.github.com/repos/younthu/Mantle/assignees{/user}","branches_url":"https://api.github.com/repos/younthu/Mantle/branches{/branch}","tags_url":"https://api.github.com/repos/younthu/Mantle/tags","blobs_url":"https://api.github.com/repos/younthu/Mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/younthu/Mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/younthu/Mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/younthu/Mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/younthu/Mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/younthu/Mantle/languages","stargazers_url":"https://api.github.com/repos/younthu/Mantle/stargazers","contributors_url":"https://api.github.com/repos/younthu/Mantle/contributors","subscribers_url":"https://api.github.com/repos/younthu/Mantle/subscribers","subscription_url":"https://api.github.com/repos/younthu/Mantle/subscription","commits_url":"https://api.github.com/repos/younthu/Mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/younthu/Mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/younthu/Mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/younthu/Mantle/issues/comments{/number}","contents_url":"https://api.github.com/repos/younthu/Mantle/contents/{+path}","compare_url":"https://api.github.com/repos/younthu/Mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/younthu/Mantle/merges","archive_url":"https://api.github.com/repos/younthu/Mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/younthu/Mantle/downloads","issues_url":"https://api.github.com/repos/younthu/Mantle/issues{/number}","pulls_url":"https://api.github.com/repos/younthu/Mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/younthu/Mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/younthu/Mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/younthu/Mantle/labels{/name}","releases_url":"https://api.github.com/repos/younthu/Mantle/releases{/id}","created_at":"2015-06-05T10:19:19Z","updated_at":"2015-06-05T10:19:20Z","pushed_at":"2015-07-30T01:26:07Z","git_url":"git://github.com/younthu/Mantle.git","ssh_url":"git@github.com:younthu/Mantle.git","clone_url":"https://github.com/younthu/Mantle.git","svn_url":"https://github.com/younthu/Mantle","homepage":"","size":1445,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Mantle:master","ref":"master","sha":"c55800e6a27b717021261c62f60958a5ff014f84","user":{"login":"Mantle","id":7318467,"avatar_url":"https://avatars.githubusercontent.com/u/7318467?v=3","gravatar_id":"","url":"https://api.github.com/users/Mantle","html_url":"https://github.com/Mantle","followers_url":"https://api.github.com/users/Mantle/followers","following_url":"https://api.github.com/users/Mantle/following{/other_user}","gists_url":"https://api.github.com/users/Mantle/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantle/subscriptions","organizations_url":"https://api.github.com/users/Mantle/orgs","repos_url":"https://api.github.com/users/Mantle/repos","events_url":"https://api.github.com/users/Mantle/events{/privacy}","received_events_url":"https://api.github.com/users/Mantle/received_events","type":"Organization","site_admin":false},"repo":{"id":5683364,"name":"Mantle","full_name":"Mantle/Mantle","owner":{"login":"Mantle","id":7318467,"avatar_url":"https://avatars.githubusercontent.com/u/7318467?v=3","gravatar_id":"","url":"https://api.github.com/users/Mantle","html_url":"https://github.com/Mantle","followers_url":"https://api.github.com/users/Mantle/followers","following_url":"https://api.github.com/users/Mantle/following{/other_user}","gists_url":"https://api.github.com/users/Mantle/gists{/gist_id}","starred_url":"https://api.github.com/users/Mantle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mantle/subscriptions","organizations_url":"https://api.github.com/users/Mantle/orgs","repos_url":"https://api.github.com/users/Mantle/repos","events_url":"https://api.github.com/users/Mantle/events{/privacy}","received_events_url":"https://api.github.com/users/Mantle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mantle/Mantle","description":"Model framework for Cocoa and Cocoa Touch","fork":false,"url":"https://api.github.com/repos/Mantle/Mantle","forks_url":"https://api.github.com/repos/Mantle/Mantle/forks","keys_url":"https://api.github.com/repos/Mantle/Mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mantle/Mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mantle/Mantle/teams","hooks_url":"https://api.github.com/repos/Mantle/Mantle/hooks","issue_events_url":"https://api.github.com/repos/Mantle/Mantle/issues/events{/number}","events_url":"https://api.github.com/repos/Mantle/Mantle/events","assignees_url":"https://api.github.com/repos/Mantle/Mantle/assignees{/user}","branches_url":"https://api.github.com/repos/Mantle/Mantle/branches{/branch}","tags_url":"https://api.github.com/repos/Mantle/Mantle/tags","blobs_url":"https://api.github.com/repos/Mantle/Mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mantle/Mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mantle/Mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mantle/Mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mantle/Mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/Mantle/Mantle/languages","stargazers_url":"https://api.github.com/repos/Mantle/Mantle/stargazers","contributors_url":"https://api.github.com/repos/Mantle/Mantle/contributors","subscribers_url":"https://api.github.com/repos/Mantle/Mantle/subscribers","subscription_url":"https://api.github.com/repos/Mantle/Mantle/subscription","commits_url":"https://api.github.com/repos/Mantle/Mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mantle/Mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mantle/Mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mantle/Mantle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mantle/Mantle/contents/{+path}","compare_url":"https://api.github.com/repos/Mantle/Mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mantle/Mantle/merges","archive_url":"https://api.github.com/repos/Mantle/Mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mantle/Mantle/downloads","issues_url":"https://api.github.com/repos/Mantle/Mantle/issues{/number}","pulls_url":"https://api.github.com/repos/Mantle/Mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/Mantle/Mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/Mantle/Mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mantle/Mantle/labels{/name}","releases_url":"https://api.github.com/repos/Mantle/Mantle/releases{/id}","created_at":"2012-09-05T06:24:59Z","updated_at":"2015-07-30T07:13:18Z","pushed_at":"2015-07-30T01:26:09Z","git_url":"git://github.com/Mantle/Mantle.git","ssh_url":"git@github.com:Mantle/Mantle.git","clone_url":"https://github.com/Mantle/Mantle.git","svn_url":"https://github.com/Mantle/Mantle","homepage":"","size":64040,"stargazers_count":7391,"watchers_count":7391,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":905,"mirror_url":null,"open_issues_count":30,"forks":905,"open_issues":30,"watchers":7391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/533"},"html":{"href":"https://github.com/Mantle/Mantle/pull/533"},"issue":{"href":"https://api.github.com/repos/Mantle/Mantle/issues/533"},"comments":{"href":"https://api.github.com/repos/Mantle/Mantle/issues/533/comments"},"review_comments":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/533/comments"},"review_comment":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mantle/Mantle/pulls/533/commits"},"statuses":{"href":"https://api.github.com/repos/Mantle/Mantle/statuses/d53935130078be332eec631c940dc782ed290519"}}}}