{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/34278138","id":34278138,"diff_hunk":"@@ -22,22 +21,24 @@ const (\n \n // AddInputOutputEdges links the build config to other nodes for the images and source repositories it depends on.\n func AddInputOutputEdges(g osgraph.MutableUniqueGraph, node *buildgraph.BuildConfigNode) *buildgraph.BuildConfigNode {\n-\toutput := node.BuildConfig.Parameters.Output\n+\toutput := node.BuildConfig.Spec.Output\n \tto := output.To\n \tswitch {\n-\tcase to != nil && len(to.Name) > 0:\n-\t\tout := imagegraph.FindOrCreateSyntheticImageStreamTagNode(g, imagegraph.MakeImageStreamTagObjectMeta(defaultNamespace(to.Namespace, node.BuildConfig.Namespace), to.Name, output.Tag))\n+\tcase to == nil:\n+\tcase to.Kind == \"DockerImage\":\n+\t\tout := imagegraph.EnsureDockerRepositoryNode(g, to.Name, \"\")","path":"pkg/build/graph/edges.go","position":25,"original_position":25,"commit_id":"cbde40a7153ecd64a9d4c03f37315ed871a726d8","original_commit_id":"cbde40a7153ecd64a9d4c03f37315ed871a726d8","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"the tag is part of the name in those cases, if there is one, so ParseDockerImageReference takes care of it.\r\n\r\n","created_at":"2015-07-09T17:09:39Z","updated_at":"2015-07-09T17:09:39Z","html_url":"https://github.com/openshift/origin/pull/3566#discussion_r34278138","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/3566","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/34278138"},"html":{"href":"https://github.com/openshift/origin/pull/3566#discussion_r34278138"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/3566"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/3566","id":39216136,"html_url":"https://github.com/openshift/origin/pull/3566","diff_url":"https://github.com/openshift/origin/pull/3566.diff","patch_url":"https://github.com/openshift/origin/pull/3566.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/3566","number":3566,"state":"open","locked":false,"title":"refactor internal build api to match v1","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-07-05T04:53:14Z","updated_at":"2015-07-09T17:09:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"62db419c338d293af9384cfda40332cee4ad683f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/3566/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/3566/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/3566/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/cbde40a7153ecd64a9d4c03f37315ed871a726d8","head":{"label":"bparees:api_refactor","ref":"api_refactor","sha":"cbde40a7153ecd64a9d4c03f37315ed871a726d8","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"repo":{"id":23590442,"name":"origin","full_name":"bparees/origin","owner":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bparees/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/bparees/origin","forks_url":"https://api.github.com/repos/bparees/origin/forks","keys_url":"https://api.github.com/repos/bparees/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bparees/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bparees/origin/teams","hooks_url":"https://api.github.com/repos/bparees/origin/hooks","issue_events_url":"https://api.github.com/repos/bparees/origin/issues/events{/number}","events_url":"https://api.github.com/repos/bparees/origin/events","assignees_url":"https://api.github.com/repos/bparees/origin/assignees{/user}","branches_url":"https://api.github.com/repos/bparees/origin/branches{/branch}","tags_url":"https://api.github.com/repos/bparees/origin/tags","blobs_url":"https://api.github.com/repos/bparees/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bparees/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bparees/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bparees/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bparees/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/bparees/origin/languages","stargazers_url":"https://api.github.com/repos/bparees/origin/stargazers","contributors_url":"https://api.github.com/repos/bparees/origin/contributors","subscribers_url":"https://api.github.com/repos/bparees/origin/subscribers","subscription_url":"https://api.github.com/repos/bparees/origin/subscription","commits_url":"https://api.github.com/repos/bparees/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bparees/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bparees/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bparees/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bparees/origin/contents/{+path}","compare_url":"https://api.github.com/repos/bparees/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bparees/origin/merges","archive_url":"https://api.github.com/repos/bparees/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bparees/origin/downloads","issues_url":"https://api.github.com/repos/bparees/origin/issues{/number}","pulls_url":"https://api.github.com/repos/bparees/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/bparees/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/bparees/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bparees/origin/labels{/name}","releases_url":"https://api.github.com/repos/bparees/origin/releases{/id}","created_at":"2014-09-02T18:28:48Z","updated_at":"2015-05-08T16:33:48Z","pushed_at":"2015-07-09T16:48:27Z","git_url":"git://github.com/bparees/origin.git","ssh_url":"git@github.com:bparees/origin.git","clone_url":"https://github.com/bparees/origin.git","svn_url":"https://github.com/bparees/origin","homepage":"https://openshift.github.io","size":121357,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"3ed8ae3ef1e64f129294ac1675fb317f2793392d","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-07-09T08:29:05Z","pushed_at":"2015-07-09T16:23:33Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":184566,"stargazers_count":536,"watchers_count":536,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":287,"mirror_url":null,"open_issues_count":402,"forks":287,"open_issues":402,"watchers":536,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/3566"},"html":{"href":"https://github.com/openshift/origin/pull/3566"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/3566"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/3566/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/3566/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/3566/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/cbde40a7153ecd64a9d4c03f37315ed871a726d8"}}}}