{"action":"created","issue":{"url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/issues/241","labels_url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/issues/241/labels{/name}","comments_url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/issues/241/comments","events_url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/issues/241/events","html_url":"https://github.com/domaindrivendev/Swashbuckle/pull/241","id":62804533,"number":241,"title":"Fix for comments with JsonProperty attribute set for properties and fields","user":{"login":"aphu","id":3229976,"avatar_url":"https://avatars.githubusercontent.com/u/3229976?v=3","gravatar_id":"","url":"https://api.github.com/users/aphu","html_url":"https://github.com/aphu","followers_url":"https://api.github.com/users/aphu/followers","following_url":"https://api.github.com/users/aphu/following{/other_user}","gists_url":"https://api.github.com/users/aphu/gists{/gist_id}","starred_url":"https://api.github.com/users/aphu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aphu/subscriptions","organizations_url":"https://api.github.com/users/aphu/orgs","repos_url":"https://api.github.com/users/aphu/repos","events_url":"https://api.github.com/users/aphu/events{/privacy}","received_events_url":"https://api.github.com/users/aphu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-18T21:21:19Z","updated_at":"2015-03-25T00:26:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/pulls/241","html_url":"https://github.com/domaindrivendev/Swashbuckle/pull/241","diff_url":"https://github.com/domaindrivendev/Swashbuckle/pull/241.diff","patch_url":"https://github.com/domaindrivendev/Swashbuckle/pull/241.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/issues/comments/85754399","html_url":"https://github.com/domaindrivendev/Swashbuckle/pull/241#issuecomment-85754399","issue_url":"https://api.github.com/repos/domaindrivendev/Swashbuckle/issues/241","id":85754399,"user":{"login":"domaindrivendev","id":1434343,"avatar_url":"https://avatars.githubusercontent.com/u/1434343?v=3","gravatar_id":"","url":"https://api.github.com/users/domaindrivendev","html_url":"https://github.com/domaindrivendev","followers_url":"https://api.github.com/users/domaindrivendev/followers","following_url":"https://api.github.com/users/domaindrivendev/following{/other_user}","gists_url":"https://api.github.com/users/domaindrivendev/gists{/gist_id}","starred_url":"https://api.github.com/users/domaindrivendev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domaindrivendev/subscriptions","organizations_url":"https://api.github.com/users/domaindrivendev/orgs","repos_url":"https://api.github.com/users/domaindrivendev/repos","events_url":"https://api.github.com/users/domaindrivendev/events{/privacy}","received_events_url":"https://api.github.com/users/domaindrivendev/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T00:26:04Z","updated_at":"2015-03-25T00:26:04Z","body":"This is a known issue with the existing implementation - if you look closely at the code I already have a TODO: comment highlighting the deeper issue ...\r\n\r\nNamely, a limitation in the application of ISchemaFilter, which is perfectly highlighted by this issue.\r\n\r\nIf you consider it's interface ...\r\n\r\n    void Apply(Schema schema, SchemaRegistry schemaRegistry, Type type);\r\n\r\nthere's an immediate problem if you need to modify properties on the Schema based on a corresponding MemberInfo on the system Type. There is no reliable way to correlate the two.\r\n\r\nI think this interface will need to be adjusted to provide some additional context that maps Type members to their corresponding schema properties. Then, the XmlComments implementation can be easily fixed. Stay tuned for the fix ..."}}