{"action":"created","comment":{"url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/comments/31995021","id":31995021,"diff_hunk":"@@ -301,9 +301,9 @@ protected function generateNonce()\n     /**\n      * Configure the option resolver\n      *\n-     * @param OptionsResolverInterface $resolver\n+     * @param OptionsResolver $resolver\n      */\n-    protected function configureOptions(OptionsResolverInterface $resolver)\n+    protected function configureOptions(OptionsResolver $resolver)","path":"OAuth/ResourceOwner/AbstractResourceOwner.php","position":null,"original_position":18,"commit_id":"0653b4ac2d3d0f55bdc623cf1824d3fa4ec7f52b","original_commit_id":"133e97c3dd39f4d31ccfaf181a604723478f9c56","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"check that your local setup includes E_STRICT in its error reporting :)","created_at":"2015-06-09T09:10:44Z","updated_at":"2015-06-09T09:10:44Z","html_url":"https://github.com/hwi/HWIOAuthBundle/pull/773#discussion_r31995021","pull_request_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773","_links":{"self":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/comments/31995021"},"html":{"href":"https://github.com/hwi/HWIOAuthBundle/pull/773#discussion_r31995021"},"pull_request":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773"}}},"pull_request":{"url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773","id":34594269,"html_url":"https://github.com/hwi/HWIOAuthBundle/pull/773","diff_url":"https://github.com/hwi/HWIOAuthBundle/pull/773.diff","patch_url":"https://github.com/hwi/HWIOAuthBundle/pull/773.patch","issue_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues/773","number":773,"state":"open","locked":false,"title":"Fix deprecated usages (SF 2.6/2.7/2.8)","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars.githubusercontent.com/u/1698357?v=3","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"This PR is a remake of #730.\r\n\r\nAll BC will be kept for Symfony 2.3+.\r\n\r\nWhat is done here:\r\n\r\n * `symfony/phpunit-bridge` package install to get more proper deprecation notices\r\n * Updated Travis configuration\r\n * Drop FOSUserBundle 1.2 support (Only for symfony <2.3)\r\n * Add missing `symfony/form` package\r\n * Fix deprecated `SecurityContextInterface` usage\r\n * Fix deprecated `OptionsResolverInterface` usage\r\n * Fix deprecated `OptionsResolver::setAllowedValues` arguments usage\r\n * Fix deprecated `OptionsResolver::setOptional` method usage\r\n * Fix deprecated `OptionsResolver::setNormalizers` method usage\r\n * Fix deprecated `OptionsResolver::addAllowedTypes` method usage\r\n * Fix new `UndefinedOptionsException` thrown error\r\n * Improves `ConnectController` with `Controller` extends (`$this->render`, `$this->redirect`...)\r\n * Tests for `ConnectController`\r\n * Remove deprecated usages on `ConnectController`\r\n\r\nTodo:\r\n \r\n* Add `friendsofsymfony/user-bundle` as a dev requirement.\r\n* Remove ugly `goto` case from `ConnectController`\r\n\r\nThe list will be updated as long as I'm working on it. Will remove `[WIP]` tag when it will be finished.","created_at":"2015-05-03T00:29:22Z","updated_at":"2015-06-09T09:10:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df3afca7e1e863d11d505eacffc6abdc3abb0a5e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773/commits","review_comments_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773/comments","review_comment_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues/773/comments","statuses_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/statuses/0653b4ac2d3d0f55bdc623cf1824d3fa4ec7f52b","head":{"label":"NewsConnect:deprecated-fixes","ref":"deprecated-fixes","sha":"0653b4ac2d3d0f55bdc623cf1824d3fa4ec7f52b","user":{"login":"NewsConnect","id":12121373,"avatar_url":"https://avatars.githubusercontent.com/u/12121373?v=3","gravatar_id":"","url":"https://api.github.com/users/NewsConnect","html_url":"https://github.com/NewsConnect","followers_url":"https://api.github.com/users/NewsConnect/followers","following_url":"https://api.github.com/users/NewsConnect/following{/other_user}","gists_url":"https://api.github.com/users/NewsConnect/gists{/gist_id}","starred_url":"https://api.github.com/users/NewsConnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewsConnect/subscriptions","organizations_url":"https://api.github.com/users/NewsConnect/orgs","repos_url":"https://api.github.com/users/NewsConnect/repos","events_url":"https://api.github.com/users/NewsConnect/events{/privacy}","received_events_url":"https://api.github.com/users/NewsConnect/received_events","type":"Organization","site_admin":false},"repo":{"id":34606278,"name":"HWIOAuthBundle","full_name":"NewsConnect/HWIOAuthBundle","owner":{"login":"NewsConnect","id":12121373,"avatar_url":"https://avatars.githubusercontent.com/u/12121373?v=3","gravatar_id":"","url":"https://api.github.com/users/NewsConnect","html_url":"https://github.com/NewsConnect","followers_url":"https://api.github.com/users/NewsConnect/followers","following_url":"https://api.github.com/users/NewsConnect/following{/other_user}","gists_url":"https://api.github.com/users/NewsConnect/gists{/gist_id}","starred_url":"https://api.github.com/users/NewsConnect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NewsConnect/subscriptions","organizations_url":"https://api.github.com/users/NewsConnect/orgs","repos_url":"https://api.github.com/users/NewsConnect/repos","events_url":"https://api.github.com/users/NewsConnect/events{/privacy}","received_events_url":"https://api.github.com/users/NewsConnect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NewsConnect/HWIOAuthBundle","description":"OAuth client integration for Symfony. Supports both OAuth1.0a and OAuth2.","fork":true,"url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle","forks_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/forks","keys_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/teams","hooks_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/hooks","issue_events_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/issues/events{/number}","events_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/events","assignees_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/assignees{/user}","branches_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/branches{/branch}","tags_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/tags","blobs_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/languages","stargazers_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/stargazers","contributors_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/contributors","subscribers_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/subscribers","subscription_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/subscription","commits_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/contents/{+path}","compare_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/merges","archive_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/downloads","issues_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/issues{/number}","pulls_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/labels{/name}","releases_url":"https://api.github.com/repos/NewsConnect/HWIOAuthBundle/releases{/id}","created_at":"2015-04-26T09:55:14Z","updated_at":"2015-05-04T21:27:45Z","pushed_at":"2015-06-09T09:07:30Z","git_url":"git://github.com/NewsConnect/HWIOAuthBundle.git","ssh_url":"git@github.com:NewsConnect/HWIOAuthBundle.git","clone_url":"https://github.com/NewsConnect/HWIOAuthBundle.git","svn_url":"https://github.com/NewsConnect/HWIOAuthBundle","homepage":"","size":1932,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hwi:master","ref":"master","sha":"97e3c15ab398d9248f5409414be9a717ea5a0a43","user":{"login":"hwi","id":1150427,"avatar_url":"https://avatars.githubusercontent.com/u/1150427?v=3","gravatar_id":"","url":"https://api.github.com/users/hwi","html_url":"https://github.com/hwi","followers_url":"https://api.github.com/users/hwi/followers","following_url":"https://api.github.com/users/hwi/following{/other_user}","gists_url":"https://api.github.com/users/hwi/gists{/gist_id}","starred_url":"https://api.github.com/users/hwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwi/subscriptions","organizations_url":"https://api.github.com/users/hwi/orgs","repos_url":"https://api.github.com/users/hwi/repos","events_url":"https://api.github.com/users/hwi/events{/privacy}","received_events_url":"https://api.github.com/users/hwi/received_events","type":"Organization","site_admin":false},"repo":{"id":3601728,"name":"HWIOAuthBundle","full_name":"hwi/HWIOAuthBundle","owner":{"login":"hwi","id":1150427,"avatar_url":"https://avatars.githubusercontent.com/u/1150427?v=3","gravatar_id":"","url":"https://api.github.com/users/hwi","html_url":"https://github.com/hwi","followers_url":"https://api.github.com/users/hwi/followers","following_url":"https://api.github.com/users/hwi/following{/other_user}","gists_url":"https://api.github.com/users/hwi/gists{/gist_id}","starred_url":"https://api.github.com/users/hwi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwi/subscriptions","organizations_url":"https://api.github.com/users/hwi/orgs","repos_url":"https://api.github.com/users/hwi/repos","events_url":"https://api.github.com/users/hwi/events{/privacy}","received_events_url":"https://api.github.com/users/hwi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hwi/HWIOAuthBundle","description":"OAuth client integration for Symfony. Supports both OAuth1.0a and OAuth2.","fork":false,"url":"https://api.github.com/repos/hwi/HWIOAuthBundle","forks_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/forks","keys_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/teams","hooks_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/hooks","issue_events_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues/events{/number}","events_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/events","assignees_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/assignees{/user}","branches_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/branches{/branch}","tags_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/tags","blobs_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/languages","stargazers_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/stargazers","contributors_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/contributors","subscribers_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/subscribers","subscription_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/subscription","commits_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/contents/{+path}","compare_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/merges","archive_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/downloads","issues_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues{/number}","pulls_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/labels{/name}","releases_url":"https://api.github.com/repos/hwi/HWIOAuthBundle/releases{/id}","created_at":"2012-03-02T11:56:40Z","updated_at":"2015-06-08T13:07:33Z","pushed_at":"2015-06-09T09:07:30Z","git_url":"git://github.com/hwi/HWIOAuthBundle.git","ssh_url":"git@github.com:hwi/HWIOAuthBundle.git","clone_url":"https://github.com/hwi/HWIOAuthBundle.git","svn_url":"https://github.com/hwi/HWIOAuthBundle","homepage":"","size":5171,"stargazers_count":918,"watchers_count":918,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":367,"mirror_url":null,"open_issues_count":193,"forks":367,"open_issues":193,"watchers":918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773"},"html":{"href":"https://github.com/hwi/HWIOAuthBundle/pull/773"},"issue":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues/773"},"comments":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/issues/773/comments"},"review_comments":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773/comments"},"review_comment":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/pulls/773/commits"},"statuses":{"href":"https://api.github.com/repos/hwi/HWIOAuthBundle/statuses/0653b4ac2d3d0f55bdc623cf1824d3fa4ec7f52b"}}}}