{"action":"created","issue":{"url":"https://api.github.com/repos/ianchesal/packer-config/issues/13","labels_url":"https://api.github.com/repos/ianchesal/packer-config/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/ianchesal/packer-config/issues/13/comments","events_url":"https://api.github.com/repos/ianchesal/packer-config/issues/13/events","html_url":"https://github.com/ianchesal/packer-config/pull/13","id":109889214,"number":13,"title":"Add windows provisioners with functionality for key dependencies","user":{"login":"diamond29","id":4523594,"avatar_url":"https://avatars.githubusercontent.com/u/4523594?v=3","gravatar_id":"","url":"https://api.github.com/users/diamond29","html_url":"https://github.com/diamond29","followers_url":"https://api.github.com/users/diamond29/followers","following_url":"https://api.github.com/users/diamond29/following{/other_user}","gists_url":"https://api.github.com/users/diamond29/gists{/gist_id}","starred_url":"https://api.github.com/users/diamond29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diamond29/subscriptions","organizations_url":"https://api.github.com/users/diamond29/orgs","repos_url":"https://api.github.com/users/diamond29/repos","events_url":"https://api.github.com/users/diamond29/events{/privacy}","received_events_url":"https://api.github.com/users/diamond29/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-05T21:23:39Z","updated_at":"2015-11-14T19:28:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ianchesal/packer-config/pulls/13","html_url":"https://github.com/ianchesal/packer-config/pull/13","diff_url":"https://github.com/ianchesal/packer-config/pull/13.diff","patch_url":"https://github.com/ianchesal/packer-config/pull/13.patch"},"body":"Hey Ian,\r\n\r\nI added some code at the request of my coworkers for these windows provisioners when I saw that the elevated_user and elevated_password keys for the powershell provisioner require eachother's presence. I started writing some code to enforce this and called them \"dependencies.\" I thought this might be useful also for people to add more \"dependencies\" to get stricter validation in their code (I might want to use it).\r\n\r\nJust wanted to get your thoughts before I continue further - it still needs more tests and a tweak here or there. Alternatively I could scrap that idea and just add the provisioners.\r\n\r\nThe shells all look pretty similar, but there was no logical connection between them in the packer documentation so I didn't give them a base class/module to share logic from.\r\n\r\nThanks!\r\nGreg"},"comment":{"url":"https://api.github.com/repos/ianchesal/packer-config/issues/comments/156738570","html_url":"https://github.com/ianchesal/packer-config/pull/13#issuecomment-156738570","issue_url":"https://api.github.com/repos/ianchesal/packer-config/issues/13","id":156738570,"user":{"login":"ianchesal","id":291808,"avatar_url":"https://avatars.githubusercontent.com/u/291808?v=3","gravatar_id":"","url":"https://api.github.com/users/ianchesal","html_url":"https://github.com/ianchesal","followers_url":"https://api.github.com/users/ianchesal/followers","following_url":"https://api.github.com/users/ianchesal/following{/other_user}","gists_url":"https://api.github.com/users/ianchesal/gists{/gist_id}","starred_url":"https://api.github.com/users/ianchesal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianchesal/subscriptions","organizations_url":"https://api.github.com/users/ianchesal/orgs","repos_url":"https://api.github.com/users/ianchesal/repos","events_url":"https://api.github.com/users/ianchesal/events{/privacy}","received_events_url":"https://api.github.com/users/ianchesal/received_events","type":"User","site_admin":false},"created_at":"2015-11-14T19:28:33Z","updated_at":"2015-11-14T19:28:33Z","body":"@diamond29 sorry for the delay on this. Merging now!"}}