{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/webmaker-android/pulls/comments/32128600","id":32128600,"diff_hunk":"@@ -3,13 +3,21 @@ var React = require('react');\n var FormInput = React.createClass({\n   getDefaultProps: function () {\n     return {\n-      type: 'text'\n+      type: 'text',\n+      tabIndex: 0\n     };\n   },\n+  checkForReturn: function (e) {\n+    if (e.keyCode === 13) {\n+      if (typeof this.props.onReturn === 'function') {","path":"www_src/pages/login/form-input.jsx","position":11,"original_position":11,"commit_id":"f065b1e441b5e3a2e7b7e9664a03278505c7306a","original_commit_id":"f065b1e441b5e3a2e7b7e9664a03278505c7306a","user":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?v=3","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"body":"Not sure I understand. From an ergonomics perspective, a dev can set `onReturn` to any value or type. Because hitting the return button while testing is something that could be easily overlooked, checking to ensure that `onReturn` is a function seems perfectly reasonable.","created_at":"2015-06-10T15:17:43Z","updated_at":"2015-06-10T15:17:43Z","html_url":"https://github.com/mozilla/webmaker-android/pull/2137#discussion_r32128600","pull_request_url":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137","_links":{"self":{"href":"https://api.github.com/repos/mozilla/webmaker-android/pulls/comments/32128600"},"html":{"href":"https://github.com/mozilla/webmaker-android/pull/2137#discussion_r32128600"},"pull_request":{"href":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137","id":37321505,"html_url":"https://github.com/mozilla/webmaker-android/pull/2137","diff_url":"https://github.com/mozilla/webmaker-android/pull/2137.diff","patch_url":"https://github.com/mozilla/webmaker-android/pull/2137.patch","issue_url":"https://api.github.com/repos/mozilla/webmaker-android/issues/2137","number":2137,"state":"open","locked":false,"title":"Simulate \"tab\" when pressing Android \"done\" button","user":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?v=3","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"body":"This was really difficult to nail down but I think the log-in and sign-up forms are feeling more solid / usable now. I implemented this in a way that should be re-usable / flexible for us going forward.\r\n\r\nResolves GH-2094","created_at":"2015-06-10T03:35:20Z","updated_at":"2015-06-10T15:17:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11905e8c7c498edbe78484d636484ed00f569928","assignee":{"login":"k88hudson","id":1455535,"avatar_url":"https://avatars.githubusercontent.com/u/1455535?v=3","gravatar_id":"","url":"https://api.github.com/users/k88hudson","html_url":"https://github.com/k88hudson","followers_url":"https://api.github.com/users/k88hudson/followers","following_url":"https://api.github.com/users/k88hudson/following{/other_user}","gists_url":"https://api.github.com/users/k88hudson/gists{/gist_id}","starred_url":"https://api.github.com/users/k88hudson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k88hudson/subscriptions","organizations_url":"https://api.github.com/users/k88hudson/orgs","repos_url":"https://api.github.com/users/k88hudson/repos","events_url":"https://api.github.com/users/k88hudson/events{/privacy}","received_events_url":"https://api.github.com/users/k88hudson/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137/commits","review_comments_url":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137/comments","review_comment_url":"https://api.github.com/repos/mozilla/webmaker-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/webmaker-android/issues/2137/comments","statuses_url":"https://api.github.com/repos/mozilla/webmaker-android/statuses/f065b1e441b5e3a2e7b7e9664a03278505c7306a","head":{"label":"thisandagain:gh2094","ref":"gh2094","sha":"f065b1e441b5e3a2e7b7e9664a03278505c7306a","user":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?v=3","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"repo":{"id":35340137,"name":"webmaker-android","full_name":"thisandagain/webmaker-android","owner":{"login":"thisandagain","id":747641,"avatar_url":"https://avatars.githubusercontent.com/u/747641?v=3","gravatar_id":"","url":"https://api.github.com/users/thisandagain","html_url":"https://github.com/thisandagain","followers_url":"https://api.github.com/users/thisandagain/followers","following_url":"https://api.github.com/users/thisandagain/following{/other_user}","gists_url":"https://api.github.com/users/thisandagain/gists{/gist_id}","starred_url":"https://api.github.com/users/thisandagain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thisandagain/subscriptions","organizations_url":"https://api.github.com/users/thisandagain/orgs","repos_url":"https://api.github.com/users/thisandagain/repos","events_url":"https://api.github.com/users/thisandagain/events{/privacy}","received_events_url":"https://api.github.com/users/thisandagain/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thisandagain/webmaker-android","description":"Webmaker for Android","fork":true,"url":"https://api.github.com/repos/thisandagain/webmaker-android","forks_url":"https://api.github.com/repos/thisandagain/webmaker-android/forks","keys_url":"https://api.github.com/repos/thisandagain/webmaker-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thisandagain/webmaker-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thisandagain/webmaker-android/teams","hooks_url":"https://api.github.com/repos/thisandagain/webmaker-android/hooks","issue_events_url":"https://api.github.com/repos/thisandagain/webmaker-android/issues/events{/number}","events_url":"https://api.github.com/repos/thisandagain/webmaker-android/events","assignees_url":"https://api.github.com/repos/thisandagain/webmaker-android/assignees{/user}","branches_url":"https://api.github.com/repos/thisandagain/webmaker-android/branches{/branch}","tags_url":"https://api.github.com/repos/thisandagain/webmaker-android/tags","blobs_url":"https://api.github.com/repos/thisandagain/webmaker-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thisandagain/webmaker-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thisandagain/webmaker-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/thisandagain/webmaker-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thisandagain/webmaker-android/statuses/{sha}","languages_url":"https://api.github.com/repos/thisandagain/webmaker-android/languages","stargazers_url":"https://api.github.com/repos/thisandagain/webmaker-android/stargazers","contributors_url":"https://api.github.com/repos/thisandagain/webmaker-android/contributors","subscribers_url":"https://api.github.com/repos/thisandagain/webmaker-android/subscribers","subscription_url":"https://api.github.com/repos/thisandagain/webmaker-android/subscription","commits_url":"https://api.github.com/repos/thisandagain/webmaker-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/thisandagain/webmaker-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/thisandagain/webmaker-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/thisandagain/webmaker-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/thisandagain/webmaker-android/contents/{+path}","compare_url":"https://api.github.com/repos/thisandagain/webmaker-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thisandagain/webmaker-android/merges","archive_url":"https://api.github.com/repos/thisandagain/webmaker-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thisandagain/webmaker-android/downloads","issues_url":"https://api.github.com/repos/thisandagain/webmaker-android/issues{/number}","pulls_url":"https://api.github.com/repos/thisandagain/webmaker-android/pulls{/number}","milestones_url":"https://api.github.com/repos/thisandagain/webmaker-android/milestones{/number}","notifications_url":"https://api.github.com/repos/thisandagain/webmaker-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thisandagain/webmaker-android/labels{/name}","releases_url":"https://api.github.com/repos/thisandagain/webmaker-android/releases{/id}","created_at":"2015-05-09T18:28:27Z","updated_at":"2015-05-09T18:28:28Z","pushed_at":"2015-06-10T03:38:31Z","git_url":"git://github.com/thisandagain/webmaker-android.git","ssh_url":"git@github.com:thisandagain/webmaker-android.git","clone_url":"https://github.com/thisandagain/webmaker-android.git","svn_url":"https://github.com/thisandagain/webmaker-android","homepage":"http://webmaker.org","size":19844,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mozilla:develop","ref":"develop","sha":"3b7c5a05bab57bea2e6b28618ddb7fe18ee823ef","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":22361331,"name":"webmaker-android","full_name":"mozilla/webmaker-android","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/webmaker-android","description":"Webmaker for Android","fork":false,"url":"https://api.github.com/repos/mozilla/webmaker-android","forks_url":"https://api.github.com/repos/mozilla/webmaker-android/forks","keys_url":"https://api.github.com/repos/mozilla/webmaker-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/webmaker-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/webmaker-android/teams","hooks_url":"https://api.github.com/repos/mozilla/webmaker-android/hooks","issue_events_url":"https://api.github.com/repos/mozilla/webmaker-android/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/webmaker-android/events","assignees_url":"https://api.github.com/repos/mozilla/webmaker-android/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/webmaker-android/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/webmaker-android/tags","blobs_url":"https://api.github.com/repos/mozilla/webmaker-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/webmaker-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/webmaker-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/webmaker-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/webmaker-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/webmaker-android/languages","stargazers_url":"https://api.github.com/repos/mozilla/webmaker-android/stargazers","contributors_url":"https://api.github.com/repos/mozilla/webmaker-android/contributors","subscribers_url":"https://api.github.com/repos/mozilla/webmaker-android/subscribers","subscription_url":"https://api.github.com/repos/mozilla/webmaker-android/subscription","commits_url":"https://api.github.com/repos/mozilla/webmaker-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/webmaker-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/webmaker-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/webmaker-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/webmaker-android/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/webmaker-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/webmaker-android/merges","archive_url":"https://api.github.com/repos/mozilla/webmaker-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/webmaker-android/downloads","issues_url":"https://api.github.com/repos/mozilla/webmaker-android/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/webmaker-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/webmaker-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/webmaker-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/webmaker-android/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/webmaker-android/releases{/id}","created_at":"2014-07-28T23:25:53Z","updated_at":"2015-06-10T09:12:14Z","pushed_at":"2015-06-10T03:38:31Z","git_url":"git://github.com/mozilla/webmaker-android.git","ssh_url":"git@github.com:mozilla/webmaker-android.git","clone_url":"https://github.com/mozilla/webmaker-android.git","svn_url":"https://github.com/mozilla/webmaker-android","homepage":"http://webmaker.org","size":24491,"stargazers_count":87,"watchers_count":87,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"open_issues_count":209,"forks":75,"open_issues":209,"watchers":87,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137"},"html":{"href":"https://github.com/mozilla/webmaker-android/pull/2137"},"issue":{"href":"https://api.github.com/repos/mozilla/webmaker-android/issues/2137"},"comments":{"href":"https://api.github.com/repos/mozilla/webmaker-android/issues/2137/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/webmaker-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/webmaker-android/pulls/2137/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/webmaker-android/statuses/f065b1e441b5e3a2e7b7e9664a03278505c7306a"}}}}