{"push_id":726495590,"size":10,"distinct_size":10,"ref":"refs/heads/master","head":"cd9a827b6928ed0cb80c78ebf897e2d77132296a","before":"6e9086fb2c4d031e6e99efca85ad4a5f3c0b9f42","commits":[{"sha":"e2ab42716825c5dedbb0036ae56a28e6119083f5","author":{"email":"028c9373aaf61b41f9c30e69951b05554a2bb781@biblibre.com","name":"Fridolin Somers"},"message":"Bug 14485: HTML comment disables translation in cataloguing/addbooks.tt\n\nIn cataloguing/addbooks.tt, the line :\n  [% total %] result(s) found in catalog,\nis not present in PO files even after an update.\nI've found that the cause is the previous HTML comment line.\n\nThis patch converts HTML comment into TT comment and adds a div to have a more comprehensive string to translate.\n\nTest plan :\n- without patch\n- go into <sources>/misc/translator\n- run PO update for example in french : translate update fr-FR\n=> the text \"result(s) found in catalog\" is missing from PO file : fr-FR-staff-prog.po\n- restore default PO files\n- apply patch\n- go into <sources>/misc/translator\n- run PO update for example in french : translate update fr-FR\n=> You find text \"result(s) found in catalog\" in PO file : fr-FR-staff-prog.po\n\nSponsored-by: Universidad de El Salvador\n\nSigned-off-by: Hector Eduardo Castro Avalos <hector.hecaxmmx@gmail.com>\nWorks as advertised. Just one msgid appear with msgid \"%s result(s) found in catalog,\"\n\nSigned-off-by: Jonathan Druart <jonathan.druart@koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@theke.io>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/e2ab42716825c5dedbb0036ae56a28e6119083f5"},{"sha":"274942abbd299e39ba75b947023bdc881d4a54b4","author":{"email":"5fee00239940f883d4c2854e41c7f989e75278a3@bywatersolutions.com","name":"Nicole C. Engard"},"message":"Bug 14424: Patron Help Files for 3.20\n\nThis patch updates the help files for 3.20\n\nTo test:\n\n* Visit\n * Main patron page\n * Patron search page\n * Patron permissions page\n* Confirm the text is right on all three\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/274942abbd299e39ba75b947023bdc881d4a54b4"},{"sha":"ddd2ec87523b1d5379c8a021347fa600ddd66cc2","author":{"email":"5fee00239940f883d4c2854e41c7f989e75278a3@bywatersolutions.com","name":"Nicole C. Engard"},"message":"Bug 14424: Update cataloging help for 3.20\n\nThis patch updates 3 help files for catalolging in 3.20\n\nTo test:\n\n* Visit\n * cataloging home\n * cataloging a new record\n * mergin bib records\n* Confirm text is right and visible\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/ddd2ec87523b1d5379c8a021347fa600ddd66cc2"},{"sha":"a350d02b995483bdd3bc7ede2271ad8a17190acc","author":{"email":"5fee00239940f883d4c2854e41c7f989e75278a3@bywatersolutions.com","name":"Nicole C. Engard"},"message":"Bug 14424: Update Discharge Help for 3.20\n\nThis patch adds the missing discharge help file and updates the moremember file with\ninfo on discharges.\n\nTo test:\n\n* Visit a patron\n* View and confirm help is right\n* Visit the discharge page on the patron\n* Confirm help file loads and is right\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/a350d02b995483bdd3bc7ede2271ad8a17190acc"},{"sha":"4e271637cd64ef733fadb231be51f22146a1a9e8","author":{"email":"5fee00239940f883d4c2854e41c7f989e75278a3@bywatersolutions.com","name":"Nicole C. Engard"},"message":"Bug 14424: Update Acq Help for 3.20\n\nThis patch adds the missing order from subscription help and updates basket\nhelp.\n\nTo test:\n\n* Visit a basket, review the help\n* Click order from a subscrption, review the help\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/4e271637cd64ef733fadb231be51f22146a1a9e8"},{"sha":"c00c6e3c675da7f244d5042e1ba9be4648bd4ee9","author":{"email":"5fee00239940f883d4c2854e41c7f989e75278a3@bywatersolutions.com","name":"Nicole C. Engard"},"message":"Bug 14424: Add on site checkouts help for 3.20\n\nThere is no help for the pending on site checkouts report. This patch\nadds it.\n\nTo test:\n\n* visit pending on site checkouts\n* click help\n* confirm help is there and correct\n\nSigned-off-by: Mark Tompsett <mtompset@hotmail.com>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/c00c6e3c675da7f244d5042e1ba9be4648bd4ee9"},{"sha":"5a57b3c163e6609aa99ab34e906aa05bd033d5ff","author":{"email":"63ac9f6777fb741d62c33cd73a438a8ce82c7d4a@theke.io","name":"Tomas Cohen Arazi"},"message":"Bug 14508: 'New patron' dropdown empty list on circulation.pl\n\nThis patch makes includes/patron-toolbar.inc (the one in charge of\nrendering the 'New patron' dropdown) make use of the Categories\nTemplate Toolkit plugin to create the list of categories.\n\n(1) To check the setup is sane:\n- Go to the Patrons page\n=> SUCCESS: The 'New patron' dropdown is populated\n- Click on the [+] symbol on the Patron search on the top\n=> SUCCESS: The Categories dropdown is populated\n\n(2) To test the patch:\n- On the checkout form, perform a patron search that\n  (a) returns more than one result\n  (b) returns zero results\n- Click the dropdown menu to create a new patron\n=> FAIL: Dropdown is empty\n- Repeat for (a) or (b)\n- Apply the patch and reload\n=> SUCCESS: The dropdown is correctly populated\n- Repeat (1)\n=> SUCCESS: Nothing got broken\n- Verify the logs\n=> SUCCESS: No new warnings\n- Sign off :-D\n- Get a cookie\n- Smile\n\nRegards\n\nDiscussion: we might need a new bug to start cleaning stuff like this:\n\n@categories=C4::Category->all;\nif(scalar(@categories) < 1){\n    $no_add = 1;\n    $template->param(no_categories => 1);\n}\nelse {\n    $template->param(categories=>\\@categories);\n}\n\nbut it belongs to a new bug me thinks. Well, suggestions are welcome, but this must\nbe fixed on stable ASAP so hurry :-D\n\nFollowed test plan, works as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/5a57b3c163e6609aa99ab34e906aa05bd033d5ff"},{"sha":"468d3d9c83a9760e796cdf43c7da2766ccf7c9b9","author":{"email":"a615d43918f8842cce2d8f1824979af142242c68@biblibre.com","name":"Julian FIOL"},"message":"Bug 14496: Improving opac-detail.pl performances\n\nGet notes and subjects from MARC record\nONLY when XSLT is not activated.\n\nIt's useless doing it when XSLT is activated,\nbecause XSLT takes care of it by its own.\n\n=> With this patch, we are saving precious\nmilliseconds\n\nI compared the display of some records in XSLT view with and without patch, was the same (as expected).\nSigned-off-by: Marc Veron <veron@veron.ch>\n\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nOn a slower server, I saw a time save of 0.0274 to 0.0908 seconds (with XSLT).\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/468d3d9c83a9760e796cdf43c7da2766ccf7c9b9"},{"sha":"63427fce6074e8f3c5e0c37b9a76b1618fb0add0","author":{"email":"7d245ca6ec1e53cd78dd694ff544fed078fda499@hotmail.com","name":"Mark Tompsett"},"message":"Bug 14428: Remove C4::Input\n\nJonathan Druart agreed that C4::Input is vestigial code that should be removed.\nHere is how I checked. First I found where C4::Input was used. Then, I checked\nwhat functions are in the package: just checkdigit. Then, I confirmed that\ncheckdigit is not used at all in any acquisition, administration, or member\nrelated perl scripts. Lastly, I took a look at our supposed test file for the\npackage. It was painfully sparse.\n\nAs such, this patch removes the test file and the package file, and removes\nC4::Input references from these six files:\n- acqui/addorderiso2709.pl\n- acqui/basketgroup.pl\n- acqui/neworderempty.pl\n- acqui/uncertainprice.pl\n- admin/aqplan.pl\n- members/memberentry.pl\nNOTE: neworderempty had 3 lines of it?! Didn't anyone see that?!\n\nHere is the output of what I did to confirm this correction:\n\nmtompset@debian:~/kohaclone$ git reset --hard origin/master\nHEAD is now at 6e9086f Bug 3206: (QA followup) missing comma on sysprefs.sql\nmtompset@debian:~/kohaclone$ git grep C4::Input\nC4/Input.pm:package C4::Input; #assumes C4/Input\nC4/Input.pm:C4::Input - Miscellaneous sanity checks\nC4/Input.pm:  use C4::Input;\nacqui/addorderiso2709.pl:use C4::Input;\nacqui/basketgroup.pl:use C4::Input;\nacqui/neworderempty.pl:use C4::Input;\nacqui/neworderempty.pl:use C4::Input;\nacqui/neworderempty.pl:use C4::Input;\nacqui/uncertainprice.pl:use C4::Input;\nadmin/aqplan.pl:use C4::Input;\nmembers/memberentry.pl:use C4::Input;\nt/Input.t:        use_ok('C4::Input');\nmtompset@debian:~/kohaclone$ grep sub C4/Input.pm\nsub checkdigit ($;$) {\n                my $temp2 = substr($infl,$i,1);\n        if ($rem eq substr($infl,8,1)) {\n} # sub checkdigit\nmtompset@debian:~/kohaclone$ grep checkdigit `find acqui -type f`\nmtompset@debian:~/kohaclone$ grep checkdigit `find admin -type f`\nmtompset@debian:~/kohaclone$ grep checkdigit `find members -type f`\nmtompset@debian:~/kohaclone$ cat t/Input.t\n\nuse strict;\nuse warnings;\n\nuse Test::More tests => 1;\n\nBEGIN {\n        use_ok('C4::Input');\n}\n\nApply this patch, and the output of git grep C4::Input will be empty.\nRun koha qa test tools (kind of overkill)\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/63427fce6074e8f3c5e0c37b9a76b1618fb0add0"},{"sha":"cd9a827b6928ed0cb80c78ebf897e2d77132296a","author":{"email":"8bf4de7d20b37969080dc26f52a336a016210a46@web.de","name":"Katrin Fischer"},"message":"Bug 14303: Fix item search CSV export - obsolete \"by\" and display of publication year for MARC21\n\nThe exported CSV file from the item search didn't display the publication\nyear in MARC21 installations and the title always contained 'by'\neven if there was no author information to display. Also the by is\nnot needed by MARC21 as the data should include punctuation.\n\nThis basically copies the changes done to the JSON format\non bug 13859 to the CSV include.\n\nTo test: Switch from 'Screen' to 'CSV'\n- Check publication date always displays (MARC21 and UNIMARC)\n- Check that for MARC21 the 'by' has been removed from the title information\n- Check that for UNIMARC the 'by' only displays when there is also\n  an author to display\n\nTested for MARC21, works as expected.\nSigned-off-by: Marc Véron <veron@veron.ch>\n\nSigned-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>\nSigned-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>","distinct":true,"url":"https://api.github.com/repos/fredericd/Koha/commits/cd9a827b6928ed0cb80c78ebf897e2d77132296a"}]}