{"action":"opened","number":2,"pull_request":{"url":"https://api.github.com/repos/cpjreynolds/rustty/pulls/2","id":40813954,"html_url":"https://github.com/cpjreynolds/rustty/pull/2","diff_url":"https://github.com/cpjreynolds/rustty/pull/2.diff","patch_url":"https://github.com/cpjreynolds/rustty/pull/2.patch","issue_url":"https://api.github.com/repos/cpjreynolds/rustty/issues/2","number":2,"state":"open","locked":false,"title":"Handle out of bounds error","user":{"login":"hsoft","id":505201,"avatar_url":"https://avatars.githubusercontent.com/u/505201?v=3","gravatar_id":"","url":"https://api.github.com/users/hsoft","html_url":"https://github.com/hsoft","followers_url":"https://api.github.com/users/hsoft/followers","following_url":"https://api.github.com/users/hsoft/following{/other_user}","gists_url":"https://api.github.com/users/hsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/hsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsoft/subscriptions","organizations_url":"https://api.github.com/users/hsoft/orgs","repos_url":"https://api.github.com/users/hsoft/repos","events_url":"https://api.github.com/users/hsoft/events{/privacy}","received_events_url":"https://api.github.com/users/hsoft/received_events","type":"User","site_admin":false},"body":"Accessing out of bounds indexes would make us panic (without message\r\nbecause of our messing up with the TTY). This commits handles out of\r\nbounds errors be returning a dummy cell.\r\n\r\nThis required to change the indexing API from `term[y][x]` to `term[(y,\r\nx)]` because otherwise, we would have had to override `Vec`'s indexing\r\nmethods (our rows are plain vectors and although our first indexing go\r\nthrough `CellBuffer`'s indexing implementation, our second indexing is\r\nhandled directly by `Vec`).\r\n\r\nThe old API was left there for now, to avoid breakeage.\r\n\r\n@cpjreynolds, what do you think of the proposed indexing API? Is there a particular reason why `term[y][x]` was chosen instead of `term[(y, x)]` in the first place?","created_at":"2015-07-24T20:44:36Z","updated_at":"2015-07-24T20:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cpjreynolds/rustty/pulls/2/commits","review_comments_url":"https://api.github.com/repos/cpjreynolds/rustty/pulls/2/comments","review_comment_url":"https://api.github.com/repos/cpjreynolds/rustty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cpjreynolds/rustty/issues/2/comments","statuses_url":"https://api.github.com/repos/cpjreynolds/rustty/statuses/efba0d5b627de0e4ee833a781d3cb4a61795943f","head":{"label":"hsoft:handle-out-of-bounds","ref":"handle-out-of-bounds","sha":"efba0d5b627de0e4ee833a781d3cb4a61795943f","user":{"login":"hsoft","id":505201,"avatar_url":"https://avatars.githubusercontent.com/u/505201?v=3","gravatar_id":"","url":"https://api.github.com/users/hsoft","html_url":"https://github.com/hsoft","followers_url":"https://api.github.com/users/hsoft/followers","following_url":"https://api.github.com/users/hsoft/following{/other_user}","gists_url":"https://api.github.com/users/hsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/hsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsoft/subscriptions","organizations_url":"https://api.github.com/users/hsoft/orgs","repos_url":"https://api.github.com/users/hsoft/repos","events_url":"https://api.github.com/users/hsoft/events{/privacy}","received_events_url":"https://api.github.com/users/hsoft/received_events","type":"User","site_admin":false},"repo":{"id":39656165,"name":"rustty","full_name":"hsoft/rustty","owner":{"login":"hsoft","id":505201,"avatar_url":"https://avatars.githubusercontent.com/u/505201?v=3","gravatar_id":"","url":"https://api.github.com/users/hsoft","html_url":"https://github.com/hsoft","followers_url":"https://api.github.com/users/hsoft/followers","following_url":"https://api.github.com/users/hsoft/following{/other_user}","gists_url":"https://api.github.com/users/hsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/hsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsoft/subscriptions","organizations_url":"https://api.github.com/users/hsoft/orgs","repos_url":"https://api.github.com/users/hsoft/repos","events_url":"https://api.github.com/users/hsoft/events{/privacy}","received_events_url":"https://api.github.com/users/hsoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hsoft/rustty","description":"A terminal UI library","fork":true,"url":"https://api.github.com/repos/hsoft/rustty","forks_url":"https://api.github.com/repos/hsoft/rustty/forks","keys_url":"https://api.github.com/repos/hsoft/rustty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hsoft/rustty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hsoft/rustty/teams","hooks_url":"https://api.github.com/repos/hsoft/rustty/hooks","issue_events_url":"https://api.github.com/repos/hsoft/rustty/issues/events{/number}","events_url":"https://api.github.com/repos/hsoft/rustty/events","assignees_url":"https://api.github.com/repos/hsoft/rustty/assignees{/user}","branches_url":"https://api.github.com/repos/hsoft/rustty/branches{/branch}","tags_url":"https://api.github.com/repos/hsoft/rustty/tags","blobs_url":"https://api.github.com/repos/hsoft/rustty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hsoft/rustty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hsoft/rustty/git/refs{/sha}","trees_url":"https://api.github.com/repos/hsoft/rustty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hsoft/rustty/statuses/{sha}","languages_url":"https://api.github.com/repos/hsoft/rustty/languages","stargazers_url":"https://api.github.com/repos/hsoft/rustty/stargazers","contributors_url":"https://api.github.com/repos/hsoft/rustty/contributors","subscribers_url":"https://api.github.com/repos/hsoft/rustty/subscribers","subscription_url":"https://api.github.com/repos/hsoft/rustty/subscription","commits_url":"https://api.github.com/repos/hsoft/rustty/commits{/sha}","git_commits_url":"https://api.github.com/repos/hsoft/rustty/git/commits{/sha}","comments_url":"https://api.github.com/repos/hsoft/rustty/comments{/number}","issue_comment_url":"https://api.github.com/repos/hsoft/rustty/issues/comments{/number}","contents_url":"https://api.github.com/repos/hsoft/rustty/contents/{+path}","compare_url":"https://api.github.com/repos/hsoft/rustty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hsoft/rustty/merges","archive_url":"https://api.github.com/repos/hsoft/rustty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hsoft/rustty/downloads","issues_url":"https://api.github.com/repos/hsoft/rustty/issues{/number}","pulls_url":"https://api.github.com/repos/hsoft/rustty/pulls{/number}","milestones_url":"https://api.github.com/repos/hsoft/rustty/milestones{/number}","notifications_url":"https://api.github.com/repos/hsoft/rustty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hsoft/rustty/labels{/name}","releases_url":"https://api.github.com/repos/hsoft/rustty/releases{/id}","created_at":"2015-07-24T20:36:41Z","updated_at":"2015-07-24T20:36:42Z","pushed_at":"2015-07-24T20:42:51Z","git_url":"git://github.com/hsoft/rustty.git","ssh_url":"git@github.com:hsoft/rustty.git","clone_url":"https://github.com/hsoft/rustty.git","svn_url":"https://github.com/hsoft/rustty","homepage":"http://cpjreynolds.github.io/rustty","size":3495,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cpjreynolds:master","ref":"master","sha":"91669d9a194db6779894f88d9f7afaf1346b1564","user":{"login":"cpjreynolds","id":9537951,"avatar_url":"https://avatars.githubusercontent.com/u/9537951?v=3","gravatar_id":"","url":"https://api.github.com/users/cpjreynolds","html_url":"https://github.com/cpjreynolds","followers_url":"https://api.github.com/users/cpjreynolds/followers","following_url":"https://api.github.com/users/cpjreynolds/following{/other_user}","gists_url":"https://api.github.com/users/cpjreynolds/gists{/gist_id}","starred_url":"https://api.github.com/users/cpjreynolds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpjreynolds/subscriptions","organizations_url":"https://api.github.com/users/cpjreynolds/orgs","repos_url":"https://api.github.com/users/cpjreynolds/repos","events_url":"https://api.github.com/users/cpjreynolds/events{/privacy}","received_events_url":"https://api.github.com/users/cpjreynolds/received_events","type":"User","site_admin":false},"repo":{"id":34760387,"name":"rustty","full_name":"cpjreynolds/rustty","owner":{"login":"cpjreynolds","id":9537951,"avatar_url":"https://avatars.githubusercontent.com/u/9537951?v=3","gravatar_id":"","url":"https://api.github.com/users/cpjreynolds","html_url":"https://github.com/cpjreynolds","followers_url":"https://api.github.com/users/cpjreynolds/followers","following_url":"https://api.github.com/users/cpjreynolds/following{/other_user}","gists_url":"https://api.github.com/users/cpjreynolds/gists{/gist_id}","starred_url":"https://api.github.com/users/cpjreynolds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpjreynolds/subscriptions","organizations_url":"https://api.github.com/users/cpjreynolds/orgs","repos_url":"https://api.github.com/users/cpjreynolds/repos","events_url":"https://api.github.com/users/cpjreynolds/events{/privacy}","received_events_url":"https://api.github.com/users/cpjreynolds/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpjreynolds/rustty","description":"A terminal UI library","fork":false,"url":"https://api.github.com/repos/cpjreynolds/rustty","forks_url":"https://api.github.com/repos/cpjreynolds/rustty/forks","keys_url":"https://api.github.com/repos/cpjreynolds/rustty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpjreynolds/rustty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpjreynolds/rustty/teams","hooks_url":"https://api.github.com/repos/cpjreynolds/rustty/hooks","issue_events_url":"https://api.github.com/repos/cpjreynolds/rustty/issues/events{/number}","events_url":"https://api.github.com/repos/cpjreynolds/rustty/events","assignees_url":"https://api.github.com/repos/cpjreynolds/rustty/assignees{/user}","branches_url":"https://api.github.com/repos/cpjreynolds/rustty/branches{/branch}","tags_url":"https://api.github.com/repos/cpjreynolds/rustty/tags","blobs_url":"https://api.github.com/repos/cpjreynolds/rustty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpjreynolds/rustty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpjreynolds/rustty/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpjreynolds/rustty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpjreynolds/rustty/statuses/{sha}","languages_url":"https://api.github.com/repos/cpjreynolds/rustty/languages","stargazers_url":"https://api.github.com/repos/cpjreynolds/rustty/stargazers","contributors_url":"https://api.github.com/repos/cpjreynolds/rustty/contributors","subscribers_url":"https://api.github.com/repos/cpjreynolds/rustty/subscribers","subscription_url":"https://api.github.com/repos/cpjreynolds/rustty/subscription","commits_url":"https://api.github.com/repos/cpjreynolds/rustty/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpjreynolds/rustty/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpjreynolds/rustty/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpjreynolds/rustty/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpjreynolds/rustty/contents/{+path}","compare_url":"https://api.github.com/repos/cpjreynolds/rustty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpjreynolds/rustty/merges","archive_url":"https://api.github.com/repos/cpjreynolds/rustty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpjreynolds/rustty/downloads","issues_url":"https://api.github.com/repos/cpjreynolds/rustty/issues{/number}","pulls_url":"https://api.github.com/repos/cpjreynolds/rustty/pulls{/number}","milestones_url":"https://api.github.com/repos/cpjreynolds/rustty/milestones{/number}","notifications_url":"https://api.github.com/repos/cpjreynolds/rustty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpjreynolds/rustty/labels{/name}","releases_url":"https://api.github.com/repos/cpjreynolds/rustty/releases{/id}","created_at":"2015-04-28T22:58:51Z","updated_at":"2015-07-22T20:41:31Z","pushed_at":"2015-07-10T18:43:21Z","git_url":"git://github.com/cpjreynolds/rustty.git","ssh_url":"git@github.com:cpjreynolds/rustty.git","clone_url":"https://github.com/cpjreynolds/rustty.git","svn_url":"https://github.com/cpjreynolds/rustty","homepage":"http://cpjreynolds.github.io/rustty","size":4240,"stargazers_count":4,"watchers_count":4,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cpjreynolds/rustty/pulls/2"},"html":{"href":"https://github.com/cpjreynolds/rustty/pull/2"},"issue":{"href":"https://api.github.com/repos/cpjreynolds/rustty/issues/2"},"comments":{"href":"https://api.github.com/repos/cpjreynolds/rustty/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/cpjreynolds/rustty/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/cpjreynolds/rustty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cpjreynolds/rustty/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/cpjreynolds/rustty/statuses/efba0d5b627de0e4ee833a781d3cb4a61795943f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":54,"deletions":7,"changed_files":2}}