{"action":"created","comment":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/22729546","id":22729546,"diff_hunk":"@@ -831,12 +845,13 @@ boolean encryptFileAuthenticatedSymmetric(File file, OutputStream outputStream,\n \t * @throws InvalidKeyException\n \t *             if key is invalid\n \t */\n-\tFile decryptFileAuthenticatedSymmetricAndValidateTag(InputStream inputStream, String pathName, SecretKey key)\n+\tpublic File decryptFileAuthenticatedSymmetricAndValidateTag(InputStream inputStream, String pathName, SecretKey key)\n \t\t\tthrows InvalidKeyException {\n \t\tFileOutputStream fileOutput = null;","path":"src/main/java/de/qabel/core/crypto/CryptoUtils.java","position":88,"original_position":88,"commit_id":"61263558bc5e3cbf2aa8571d60c568d07bafd39c","original_commit_id":"61263558bc5e3cbf2aa8571d60c568d07bafd39c","user":{"login":"aBothe","id":1143073,"avatar_url":"https://avatars.githubusercontent.com/u/1143073?v=3","gravatar_id":"","url":"https://api.github.com/users/aBothe","html_url":"https://github.com/aBothe","followers_url":"https://api.github.com/users/aBothe/followers","following_url":"https://api.github.com/users/aBothe/following{/other_user}","gists_url":"https://api.github.com/users/aBothe/gists{/gist_id}","starred_url":"https://api.github.com/users/aBothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aBothe/subscriptions","organizations_url":"https://api.github.com/users/aBothe/orgs","repos_url":"https://api.github.com/users/aBothe/repos","events_url":"https://api.github.com/users/aBothe/events{/privacy}","received_events_url":"https://api.github.com/users/aBothe/received_events","type":"User","site_admin":false},"body":"Please avoid setting it null by default. Down there, if the FileOutputStream() ctor fails, make it null instead - or return, or create said temp file.","created_at":"2015-01-09T17:31:29Z","updated_at":"2015-01-09T17:31:29Z","html_url":"https://github.com/Qabel/qabel-core/pull/241#discussion_r22729546","pull_request_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/241","_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/22729546"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/241#discussion_r22729546"},"pull_request":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/Qabel/qabel-core/pulls/241","id":26818002,"html_url":"https://github.com/Qabel/qabel-core/pull/241","diff_url":"https://github.com/Qabel/qabel-core/pull/241.diff","patch_url":"https://github.com/Qabel/qabel-core/pull/241.patch","issue_url":"https://api.github.com/repos/Qabel/qabel-core/issues/241","number":241,"state":"open","locked":false,"title":"Implemented storage API","user":{"login":"cburkert","id":122697,"avatar_url":"https://avatars.githubusercontent.com/u/122697?v=3","gravatar_id":"","url":"https://api.github.com/users/cburkert","html_url":"https://github.com/cburkert","followers_url":"https://api.github.com/users/cburkert/followers","following_url":"https://api.github.com/users/cburkert/following{/other_user}","gists_url":"https://api.github.com/users/cburkert/gists{/gist_id}","starred_url":"https://api.github.com/users/cburkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburkert/subscriptions","organizations_url":"https://api.github.com/users/cburkert/orgs","repos_url":"https://api.github.com/users/cburkert/repos","events_url":"https://api.github.com/users/cburkert/events{/privacy}","received_events_url":"https://api.github.com/users/cburkert/received_events","type":"User","site_admin":false},"body":"This implements the client API of the storage protocol.","created_at":"2015-01-05T11:19:18Z","updated_at":"2015-01-09T17:31:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd7583f87060a8dfe3973b6eab6caab3d954f82","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/241/commits","review_comments_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/241/comments","review_comment_url":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/issues/241/comments","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/61263558bc5e3cbf2aa8571d60c568d07bafd39c","head":{"label":"cburkert:storage_api","ref":"storage_api","sha":"61263558bc5e3cbf2aa8571d60c568d07bafd39c","user":{"login":"cburkert","id":122697,"avatar_url":"https://avatars.githubusercontent.com/u/122697?v=3","gravatar_id":"","url":"https://api.github.com/users/cburkert","html_url":"https://github.com/cburkert","followers_url":"https://api.github.com/users/cburkert/followers","following_url":"https://api.github.com/users/cburkert/following{/other_user}","gists_url":"https://api.github.com/users/cburkert/gists{/gist_id}","starred_url":"https://api.github.com/users/cburkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburkert/subscriptions","organizations_url":"https://api.github.com/users/cburkert/orgs","repos_url":"https://api.github.com/users/cburkert/repos","events_url":"https://api.github.com/users/cburkert/events{/privacy}","received_events_url":"https://api.github.com/users/cburkert/received_events","type":"User","site_admin":false},"repo":{"id":24841690,"name":"qabel-core","full_name":"cburkert/qabel-core","owner":{"login":"cburkert","id":122697,"avatar_url":"https://avatars.githubusercontent.com/u/122697?v=3","gravatar_id":"","url":"https://api.github.com/users/cburkert","html_url":"https://github.com/cburkert","followers_url":"https://api.github.com/users/cburkert/followers","following_url":"https://api.github.com/users/cburkert/following{/other_user}","gists_url":"https://api.github.com/users/cburkert/gists{/gist_id}","starred_url":"https://api.github.com/users/cburkert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cburkert/subscriptions","organizations_url":"https://api.github.com/users/cburkert/orgs","repos_url":"https://api.github.com/users/cburkert/repos","events_url":"https://api.github.com/users/cburkert/events{/privacy}","received_events_url":"https://api.github.com/users/cburkert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cburkert/qabel-core","description":"Implementation of Qabel-Core in Java","fork":true,"url":"https://api.github.com/repos/cburkert/qabel-core","forks_url":"https://api.github.com/repos/cburkert/qabel-core/forks","keys_url":"https://api.github.com/repos/cburkert/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cburkert/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cburkert/qabel-core/teams","hooks_url":"https://api.github.com/repos/cburkert/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/cburkert/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/cburkert/qabel-core/events","assignees_url":"https://api.github.com/repos/cburkert/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/cburkert/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/cburkert/qabel-core/tags","blobs_url":"https://api.github.com/repos/cburkert/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cburkert/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cburkert/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/cburkert/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cburkert/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/cburkert/qabel-core/languages","stargazers_url":"https://api.github.com/repos/cburkert/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/cburkert/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/cburkert/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/cburkert/qabel-core/subscription","commits_url":"https://api.github.com/repos/cburkert/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/cburkert/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/cburkert/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/cburkert/qabel-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/cburkert/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/cburkert/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cburkert/qabel-core/merges","archive_url":"https://api.github.com/repos/cburkert/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cburkert/qabel-core/downloads","issues_url":"https://api.github.com/repos/cburkert/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/cburkert/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/cburkert/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/cburkert/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cburkert/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/cburkert/qabel-core/releases{/id}","created_at":"2014-10-06T10:26:49Z","updated_at":"2014-12-24T09:56:08Z","pushed_at":"2015-01-09T16:40:34Z","git_url":"git://github.com/cburkert/qabel-core.git","ssh_url":"git@github.com:cburkert/qabel-core.git","clone_url":"https://github.com/cburkert/qabel-core.git","svn_url":"https://github.com/cburkert/qabel-core","homepage":null,"size":2738,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Qabel:master","ref":"master","sha":"7a48e124cdba9eb4f21e356cbb68eaef95e5e999","user":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"repo":{"id":22873447,"name":"qabel-core","full_name":"Qabel/qabel-core","owner":{"login":"Qabel","id":7711470,"avatar_url":"https://avatars.githubusercontent.com/u/7711470?v=3","gravatar_id":"","url":"https://api.github.com/users/Qabel","html_url":"https://github.com/Qabel","followers_url":"https://api.github.com/users/Qabel/followers","following_url":"https://api.github.com/users/Qabel/following{/other_user}","gists_url":"https://api.github.com/users/Qabel/gists{/gist_id}","starred_url":"https://api.github.com/users/Qabel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Qabel/subscriptions","organizations_url":"https://api.github.com/users/Qabel/orgs","repos_url":"https://api.github.com/users/Qabel/repos","events_url":"https://api.github.com/users/Qabel/events{/privacy}","received_events_url":"https://api.github.com/users/Qabel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Qabel/qabel-core","description":"Implementation of Qabel-Core in Java","fork":false,"url":"https://api.github.com/repos/Qabel/qabel-core","forks_url":"https://api.github.com/repos/Qabel/qabel-core/forks","keys_url":"https://api.github.com/repos/Qabel/qabel-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Qabel/qabel-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Qabel/qabel-core/teams","hooks_url":"https://api.github.com/repos/Qabel/qabel-core/hooks","issue_events_url":"https://api.github.com/repos/Qabel/qabel-core/issues/events{/number}","events_url":"https://api.github.com/repos/Qabel/qabel-core/events","assignees_url":"https://api.github.com/repos/Qabel/qabel-core/assignees{/user}","branches_url":"https://api.github.com/repos/Qabel/qabel-core/branches{/branch}","tags_url":"https://api.github.com/repos/Qabel/qabel-core/tags","blobs_url":"https://api.github.com/repos/Qabel/qabel-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Qabel/qabel-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Qabel/qabel-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Qabel/qabel-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Qabel/qabel-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Qabel/qabel-core/languages","stargazers_url":"https://api.github.com/repos/Qabel/qabel-core/stargazers","contributors_url":"https://api.github.com/repos/Qabel/qabel-core/contributors","subscribers_url":"https://api.github.com/repos/Qabel/qabel-core/subscribers","subscription_url":"https://api.github.com/repos/Qabel/qabel-core/subscription","commits_url":"https://api.github.com/repos/Qabel/qabel-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Qabel/qabel-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Qabel/qabel-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Qabel/qabel-core/issues/comments/{number}","contents_url":"https://api.github.com/repos/Qabel/qabel-core/contents/{+path}","compare_url":"https://api.github.com/repos/Qabel/qabel-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Qabel/qabel-core/merges","archive_url":"https://api.github.com/repos/Qabel/qabel-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Qabel/qabel-core/downloads","issues_url":"https://api.github.com/repos/Qabel/qabel-core/issues{/number}","pulls_url":"https://api.github.com/repos/Qabel/qabel-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Qabel/qabel-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Qabel/qabel-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Qabel/qabel-core/labels{/name}","releases_url":"https://api.github.com/repos/Qabel/qabel-core/releases{/id}","created_at":"2014-08-12T10:25:10Z","updated_at":"2015-01-05T14:06:46Z","pushed_at":"2015-01-05T14:06:46Z","git_url":"git://github.com/Qabel/qabel-core.git","ssh_url":"git@github.com:Qabel/qabel-core.git","clone_url":"https://github.com/Qabel/qabel-core.git","svn_url":"https://github.com/Qabel/qabel-core","homepage":null,"size":5012,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":26,"forks":11,"open_issues":26,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/241"},"html":{"href":"https://github.com/Qabel/qabel-core/pull/241"},"issue":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/241"},"comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Qabel/qabel-core/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/Qabel/qabel-core/statuses/61263558bc5e3cbf2aa8571d60c568d07bafd39c"}}}}