{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24483974","id":24483974,"diff_hunk":"@@ -78,7 +78,7 @@ class RestartFieldLoader\n             local_domain_size[d] = params->window.localDimensions.size[d];\n \n         PMACC_AUTO(destBox, field.getHostBuffer().getDataBox());\n-        for (uint32_t i = 0; i < simDim; ++i)\n+        for (uint32_t i = 0; i < numComponents; ++i)","path":"src/picongpu/include/plugins/hdf5/restart/RestartFieldLoader.hpp","position":14,"original_position":14,"commit_id":"248971a28abec3c28abb066d694caadae0845da0","original_commit_id":"248971a28abec3c28abb066d694caadae0845da0","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"unsigned to signed comparison","created_at":"2015-02-11T10:04:49Z","updated_at":"2015-02-11T10:04:49Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/689#discussion_r24483974","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/24483974"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/689#discussion_r24483974"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689","id":29055464,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/689","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/689.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/689.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/689","number":689,"state":"open","locked":false,"title":"Fix #688 2D Restart Fields","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"body":"**Fix #688 2D Restart Fields**: in 2D simulations, the last component (z) of FieldE and FieldB was not initialized again (default: zero).\r\n\r\n- [ ] verify with 2D KHI simulation and check `EnergyFields.dat` before/after restart (especially `B_z`)\r\n\r\n**unrelated:**\r\n- wrong docs string and index names in `hdf5/writer/Field.hpp` -> extra pull #690\r\n\r\nthe index names in `hdf5/writer/Field.hpp` are not ideal (even if the implementation is correct): once `d` is used as an index `[0; simDim]` and once as an index `[0; nComponents]` and same mixed with `i`.","created_at":"2015-02-10T23:25:31Z","updated_at":"2015-02-11T10:04:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cdfecf2e566937ca0f1d4614bd984516785df950","assignee":null,"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":61,"closed_issues":555,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-02-10T23:55:58Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/689/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/248971a28abec3c28abb066d694caadae0845da0","head":{"label":"ax3l:fix-hdf52Drestart","ref":"fix-hdf52Drestart","sha":"248971a28abec3c28abb066d694caadae0845da0","user":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"repo":{"id":12108745,"name":"picongpu","full_name":"ax3l/picongpu","owner":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ax3l/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/ax3l/picongpu","forks_url":"https://api.github.com/repos/ax3l/picongpu/forks","keys_url":"https://api.github.com/repos/ax3l/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ax3l/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ax3l/picongpu/teams","hooks_url":"https://api.github.com/repos/ax3l/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ax3l/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ax3l/picongpu/events","assignees_url":"https://api.github.com/repos/ax3l/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ax3l/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ax3l/picongpu/tags","blobs_url":"https://api.github.com/repos/ax3l/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ax3l/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ax3l/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ax3l/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ax3l/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ax3l/picongpu/languages","stargazers_url":"https://api.github.com/repos/ax3l/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ax3l/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ax3l/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ax3l/picongpu/subscription","commits_url":"https://api.github.com/repos/ax3l/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ax3l/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ax3l/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ax3l/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ax3l/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ax3l/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ax3l/picongpu/merges","archive_url":"https://api.github.com/repos/ax3l/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ax3l/picongpu/downloads","issues_url":"https://api.github.com/repos/ax3l/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ax3l/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ax3l/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ax3l/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ax3l/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ax3l/picongpu/releases{/id}","created_at":"2013-08-14T12:51:14Z","updated_at":"2015-01-29T07:35:47Z","pushed_at":"2015-02-11T10:02:00Z","git_url":"git://github.com/ax3l/picongpu.git","ssh_url":"git@github.com:ax3l/picongpu.git","clone_url":"https://github.com/ax3l/picongpu.git","svn_url":"https://github.com/ax3l/picongpu","homepage":"http://picongpu.hzdr.de","size":9358,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":4,"default_branch":"master"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"a7e0fcda6c7b68b6e275086574c0df7ea5fd38c4","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments/{number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-02-09T18:07:02Z","pushed_at":"2015-02-09T22:47:00Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":13823,"stargazers_count":86,"watchers_count":86,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":103,"forks":47,"open_issues":103,"watchers":86,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/689"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/689"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/689/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/689/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/248971a28abec3c28abb066d694caadae0845da0"}}}}