{"action":"created","issue":{"url":"https://api.github.com/repos/xolvio/md-blog/issues/13","labels_url":"https://api.github.com/repos/xolvio/md-blog/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/xolvio/md-blog/issues/13/comments","events_url":"https://api.github.com/repos/xolvio/md-blog/issues/13/events","html_url":"https://github.com/xolvio/md-blog/pull/13","id":53365059,"number":13,"title":"Version History","user":{"login":"GameMaker","id":1099635,"avatar_url":"https://avatars.githubusercontent.com/u/1099635?v=3","gravatar_id":"","url":"https://api.github.com/users/GameMaker","html_url":"https://github.com/GameMaker","followers_url":"https://api.github.com/users/GameMaker/followers","following_url":"https://api.github.com/users/GameMaker/following{/other_user}","gists_url":"https://api.github.com/users/GameMaker/gists{/gist_id}","starred_url":"https://api.github.com/users/GameMaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GameMaker/subscriptions","organizations_url":"https://api.github.com/users/GameMaker/orgs","repos_url":"https://api.github.com/users/GameMaker/repos","events_url":"https://api.github.com/users/GameMaker/events{/privacy}","received_events_url":"https://api.github.com/users/GameMaker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":15,"created_at":"2015-01-05T05:15:36Z","updated_at":"2015-01-17T23:29:00Z","closed_at":"2015-01-17T23:29:00Z","pull_request":{"url":"https://api.github.com/repos/xolvio/md-blog/pulls/13","html_url":"https://github.com/xolvio/md-blog/pull/13","diff_url":"https://github.com/xolvio/md-blog/pull/13.diff","patch_url":"https://github.com/xolvio/md-blog/pull/13.patch"},"body":"Added version history, with restore / delete.\r\n\r\nAdds a new \"History\" button to blogControls template.\r\nEvery 'save' pushes a version to the history array."},"comment":{"url":"https://api.github.com/repos/xolvio/md-blog/issues/comments/70389240","html_url":"https://github.com/xolvio/md-blog/pull/13#issuecomment-70389240","issue_url":"https://api.github.com/repos/xolvio/md-blog/issues/13","id":70389240,"user":{"login":"samhatoum","id":2021955,"avatar_url":"https://avatars.githubusercontent.com/u/2021955?v=3","gravatar_id":"","url":"https://api.github.com/users/samhatoum","html_url":"https://github.com/samhatoum","followers_url":"https://api.github.com/users/samhatoum/followers","following_url":"https://api.github.com/users/samhatoum/following{/other_user}","gists_url":"https://api.github.com/users/samhatoum/gists{/gist_id}","starred_url":"https://api.github.com/users/samhatoum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samhatoum/subscriptions","organizations_url":"https://api.github.com/users/samhatoum/orgs","repos_url":"https://api.github.com/users/samhatoum/repos","events_url":"https://api.github.com/users/samhatoum/events{/privacy}","received_events_url":"https://api.github.com/users/samhatoum/received_events","type":"User","site_admin":false},"created_at":"2015-01-17T23:29:00Z","updated_at":"2015-01-17T23:29:00Z","body":"Hey @GameMaker \r\n\r\nI just tested this locally and there are still a few bugs (using the standard app)\r\n\r\n* [ ] Clicking history on the blog post list opens all history tabs for all posts\r\n* [ ] When restoring a version and the restored version is re-inserted at the top of the history list, the history list is not updated reactively (on page refresh it becomes visible)\r\n* [ ] There are some server errors like `Exception while invoking method 'mdblog-getHistory' TypeError: Cannot call method 'push' of undefined\r\n`\r\n\r\nI know we went through quite a few experimentation and iterations to get to this point and therefore the code has become a little organic, so what I'd like to do with this feature is close this PR and I will re-write it soon, using a) testing and b) all the lessons learnt from our experiments!\r\n\r\nSorry to have to do this, I genuinely appreciate your hard work. It's just going to take me more time to get through the issues than it would take me to rewrite it and I'm worried about future changes being fragile without the testing in place too, given that there's a lot of code here.\r\n\r\n"}}