{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/46161608","id":46161608,"diff_hunk":"@@ -1081,4 +1141,98 @@ def route_target_tester(bgp_af, af, opts, should, test_id)\n                    \"#{test_id} : #{af} : route_target_#{opt}_evpn\")\n     end\n   end\n+\n+  ##\n+  ## suppress_inactive\n+  ##\n+  def suppress_inactive(asn, vrf, af)\n+    bgp_af = RouterBgpAF.new(asn, vrf, af)\n+\n+    #\n+    # Set and verify\n+    #\n+    val = false\n+    bgp_af.suppress_inactive = val\n+    assert_equal(val, bgp_af.suppress_inactive,","path":"tests/test_bgp_af.rb","position":83,"original_position":83,"commit_id":"1a1ac4af1d87f093c6f82a3606d5f6675f2e976e","original_commit_id":"1a1ac4af1d87f093c6f82a3606d5f6675f2e976e","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"body":"Don't use `assert_equal` for bool tests -- use `refute` when testing for false, `assert` for true.\r\n","created_at":"2015-11-30T16:00:49Z","updated_at":"2015-11-30T16:00:49Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/106#discussion_r46161608","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/46161608"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/106#discussion_r46161608"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106","id":51738856,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/106","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/106.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/106.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/106","number":106,"state":"open","locked":false,"title":"add three properties to cisco_bgp","user":{"login":"andy91315","id":1629644,"avatar_url":"https://avatars.githubusercontent.com/u/1629644?v=3","gravatar_id":"","url":"https://api.github.com/users/andy91315","html_url":"https://github.com/andy91315","followers_url":"https://api.github.com/users/andy91315/followers","following_url":"https://api.github.com/users/andy91315/following{/other_user}","gists_url":"https://api.github.com/users/andy91315/gists{/gist_id}","starred_url":"https://api.github.com/users/andy91315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy91315/subscriptions","organizations_url":"https://api.github.com/users/andy91315/orgs","repos_url":"https://api.github.com/users/andy91315/repos","events_url":"https://api.github.com/users/andy91315/events{/privacy}","received_events_url":"https://api.github.com/users/andy91315/received_events","type":"User","site_admin":false},"body":"1. pass minitest \r\nFinished in 598.124218s, 0.1037 runs/s, 0.3929 assertions/s.\r\n62 runs, 235 assertions, 0 failures, 0 errors, 0 skips\r\n\r\n2. pass static analysis","created_at":"2015-11-25T00:46:54Z","updated_at":"2015-11-30T16:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d7087323c92180b852b29a57d02434a45767644","assignee":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/106/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/1a1ac4af1d87f093c6f82a3606d5f6675f2e976e","head":{"label":"andy91315:develop","ref":"develop","sha":"1a1ac4af1d87f093c6f82a3606d5f6675f2e976e","user":{"login":"andy91315","id":1629644,"avatar_url":"https://avatars.githubusercontent.com/u/1629644?v=3","gravatar_id":"","url":"https://api.github.com/users/andy91315","html_url":"https://github.com/andy91315","followers_url":"https://api.github.com/users/andy91315/followers","following_url":"https://api.github.com/users/andy91315/following{/other_user}","gists_url":"https://api.github.com/users/andy91315/gists{/gist_id}","starred_url":"https://api.github.com/users/andy91315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy91315/subscriptions","organizations_url":"https://api.github.com/users/andy91315/orgs","repos_url":"https://api.github.com/users/andy91315/repos","events_url":"https://api.github.com/users/andy91315/events{/privacy}","received_events_url":"https://api.github.com/users/andy91315/received_events","type":"User","site_admin":false},"repo":{"id":44636922,"name":"cisco-network-node-utils","full_name":"andy91315/cisco-network-node-utils","owner":{"login":"andy91315","id":1629644,"avatar_url":"https://avatars.githubusercontent.com/u/1629644?v=3","gravatar_id":"","url":"https://api.github.com/users/andy91315","html_url":"https://github.com/andy91315","followers_url":"https://api.github.com/users/andy91315/followers","following_url":"https://api.github.com/users/andy91315/following{/other_user}","gists_url":"https://api.github.com/users/andy91315/gists{/gist_id}","starred_url":"https://api.github.com/users/andy91315/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy91315/subscriptions","organizations_url":"https://api.github.com/users/andy91315/orgs","repos_url":"https://api.github.com/users/andy91315/repos","events_url":"https://api.github.com/users/andy91315/events{/privacy}","received_events_url":"https://api.github.com/users/andy91315/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy91315/cisco-network-node-utils","description":"","fork":true,"url":"https://api.github.com/repos/andy91315/cisco-network-node-utils","forks_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/andy91315/cisco-network-node-utils/releases{/id}","created_at":"2015-10-20T21:50:41Z","updated_at":"2015-10-20T21:50:41Z","pushed_at":"2015-11-30T04:43:42Z","git_url":"git://github.com/andy91315/cisco-network-node-utils.git","ssh_url":"git@github.com:andy91315/cisco-network-node-utils.git","clone_url":"https://github.com/andy91315/cisco-network-node-utils.git","svn_url":"https://github.com/andy91315/cisco-network-node-utils","homepage":null,"size":1074,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:develop","ref":"develop","sha":"df6c25e7ac318a5fc8a1e5cf8eed51e7ff6d756f","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-11-12T06:34:19Z","pushed_at":"2015-11-30T04:43:42Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":1992,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":5,"forks":26,"open_issues":5,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/106"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/106"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/1a1ac4af1d87f093c6f82a3606d5f6675f2e976e"}}}}