{"action":"created","issue":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/1704","labels_url":"https://api.github.com/repos/rackerlabs/otter/issues/1704/labels{/name}","comments_url":"https://api.github.com/repos/rackerlabs/otter/issues/1704/comments","events_url":"https://api.github.com/repos/rackerlabs/otter/issues/1704/events","html_url":"https://github.com/rackerlabs/otter/pull/1704","id":104635258,"number":1704,"title":"Tests for autoscale self-healing changes in CLB params","user":{"login":"cyli","id":223200,"avatar_url":"https://avatars.githubusercontent.com/u/223200?v=3","gravatar_id":"","url":"https://api.github.com/users/cyli","html_url":"https://github.com/cyli","followers_url":"https://api.github.com/users/cyli/followers","following_url":"https://api.github.com/users/cyli/following{/other_user}","gists_url":"https://api.github.com/users/cyli/gists{/gist_id}","starred_url":"https://api.github.com/users/cyli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyli/subscriptions","organizations_url":"https://api.github.com/users/cyli/orgs","repos_url":"https://api.github.com/users/cyli/repos","events_url":"https://api.github.com/users/cyli/events{/privacy}","received_events_url":"https://api.github.com/users/cyli/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2015-09-03T07:07:24Z","updated_at":"2015-09-05T20:16:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/1704","html_url":"https://github.com/rackerlabs/otter/pull/1704","diff_url":"https://github.com/rackerlabs/otter/pull/1704.diff","patch_url":"https://github.com/rackerlabs/otter/pull/1704.patch"},"body":"This was originally just an integration tests that fixes #1491.\r\n\r\nHowever, found a bug where we were not passing the right payload to CLB - we were passing something like `{\"weight\": 1, \"condition\": \"ENABLED\"}` instead of `{\"node\": {\"weight\": 1, \"condition\": \"ENABLED\", \"type\": \"PRIMARY\"}}`.\r\n\r\nSo changed that in `cloud_client`, but that also required a change to `steps`.\r\n\r\nFixes #1241.\r\nFixes #1242.\r\nFixes #1243.\r\nFixes #1267.\r\n\r\nThis makes `ChangeCLBNode` fail if the CLB has been deleted, but maybe that is not always the desired outcome.  See #1705.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/rackerlabs/otter/1704)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/rackerlabs/otter/issues/comments/137991238","html_url":"https://github.com/rackerlabs/otter/pull/1704#issuecomment-137991238","issue_url":"https://api.github.com/repos/rackerlabs/otter/issues/1704","id":137991238,"user":{"login":"manishtomar","id":758529,"avatar_url":"https://avatars.githubusercontent.com/u/758529?v=3","gravatar_id":"","url":"https://api.github.com/users/manishtomar","html_url":"https://github.com/manishtomar","followers_url":"https://api.github.com/users/manishtomar/followers","following_url":"https://api.github.com/users/manishtomar/following{/other_user}","gists_url":"https://api.github.com/users/manishtomar/gists{/gist_id}","starred_url":"https://api.github.com/users/manishtomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishtomar/subscriptions","organizations_url":"https://api.github.com/users/manishtomar/orgs","repos_url":"https://api.github.com/users/manishtomar/repos","events_url":"https://api.github.com/users/manishtomar/events{/privacy}","received_events_url":"https://api.github.com/users/manishtomar/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T20:16:30Z","updated_at":"2015-09-05T20:16:30Z","body":"@radix Is this good to go? If so, please merge it :)"}}