{"action":"created","comment":{"url":"https://api.github.com/repos/netty/netty/pulls/comments/45662710","id":45662710,"diff_hunk":"@@ -648,6 +660,20 @@ protected int _getUnsignedMedium(int index) {\n     }\n \n     @Override\n+    protected int _getUnsignedMediumLE(int index) {\n+        Component c = findComponent(index);\n+        if (index + 3 <= c.endOffset) {\n+            return c.buf.getUnsignedMediumLE(index - c.offset);\n+        } else if (order() == ByteOrder.BIG_ENDIAN) {\n+            return _getShortLE(index) & 0xFFFF |","path":"buffer/src/main/java/io/netty/buffer/CompositeByteBuf.java","position":28,"original_position":28,"commit_id":"a44c4190d44223ad7025df751fe7ed5e9f221a17","original_commit_id":"a44c4190d44223ad7025df751fe7ed5e9f221a17","user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"body":"nit: consider putting this on 1 line and also consider using lowercase `f`s for consistency.","created_at":"2015-11-23T21:23:53Z","updated_at":"2015-11-23T21:23:53Z","html_url":"https://github.com/netty/netty/pull/4477#discussion_r45662710","pull_request_url":"https://api.github.com/repos/netty/netty/pulls/4477","_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/comments/45662710"},"html":{"href":"https://github.com/netty/netty/pull/4477#discussion_r45662710"},"pull_request":{"href":"https://api.github.com/repos/netty/netty/pulls/4477"}}},"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4477","id":50868016,"html_url":"https://github.com/netty/netty/pull/4477","diff_url":"https://github.com/netty/netty/pull/4477.diff","patch_url":"https://github.com/netty/netty/pull/4477.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/4477","number":4477,"state":"open","locked":false,"title":"Add first-class Little Endian support for Int to ByteBuf and descendants","user":{"login":"ifesdjeen","id":12669,"avatar_url":"https://avatars.githubusercontent.com/u/12669?v=3","gravatar_id":"","url":"https://api.github.com/users/ifesdjeen","html_url":"https://github.com/ifesdjeen","followers_url":"https://api.github.com/users/ifesdjeen/followers","following_url":"https://api.github.com/users/ifesdjeen/following{/other_user}","gists_url":"https://api.github.com/users/ifesdjeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ifesdjeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifesdjeen/subscriptions","organizations_url":"https://api.github.com/users/ifesdjeen/orgs","repos_url":"https://api.github.com/users/ifesdjeen/repos","events_url":"https://api.github.com/users/ifesdjeen/events{/privacy}","received_events_url":"https://api.github.com/users/ifesdjeen/received_events","type":"User","site_admin":false},"body":"As discussed in #3209, this PR adds Little Endian accessors \r\nto ByteBuf and descendants.\r\n\r\nCorresponding accessors were added to UnsafeByteBufUtil,\r\nHeapByteBufferUtil to avoid calling `Integer.reverseBytes`. ","created_at":"2015-11-16T21:23:24Z","updated_at":"2015-11-23T21:23:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21eeccb798300114024411d6fc1aea66b614ef2c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/4477/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/4477/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/4477/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/a44c4190d44223ad7025df751fe7ed5e9f221a17","head":{"label":"ifesdjeen:add-little-endian-byte-order-accessors","ref":"add-little-endian-byte-order-accessors","sha":"a44c4190d44223ad7025df751fe7ed5e9f221a17","user":{"login":"ifesdjeen","id":12669,"avatar_url":"https://avatars.githubusercontent.com/u/12669?v=3","gravatar_id":"","url":"https://api.github.com/users/ifesdjeen","html_url":"https://github.com/ifesdjeen","followers_url":"https://api.github.com/users/ifesdjeen/followers","following_url":"https://api.github.com/users/ifesdjeen/following{/other_user}","gists_url":"https://api.github.com/users/ifesdjeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ifesdjeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifesdjeen/subscriptions","organizations_url":"https://api.github.com/users/ifesdjeen/orgs","repos_url":"https://api.github.com/users/ifesdjeen/repos","events_url":"https://api.github.com/users/ifesdjeen/events{/privacy}","received_events_url":"https://api.github.com/users/ifesdjeen/received_events","type":"User","site_admin":false},"repo":{"id":14229370,"name":"netty","full_name":"ifesdjeen/netty","owner":{"login":"ifesdjeen","id":12669,"avatar_url":"https://avatars.githubusercontent.com/u/12669?v=3","gravatar_id":"","url":"https://api.github.com/users/ifesdjeen","html_url":"https://github.com/ifesdjeen","followers_url":"https://api.github.com/users/ifesdjeen/followers","following_url":"https://api.github.com/users/ifesdjeen/following{/other_user}","gists_url":"https://api.github.com/users/ifesdjeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ifesdjeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ifesdjeen/subscriptions","organizations_url":"https://api.github.com/users/ifesdjeen/orgs","repos_url":"https://api.github.com/users/ifesdjeen/repos","events_url":"https://api.github.com/users/ifesdjeen/events{/privacy}","received_events_url":"https://api.github.com/users/ifesdjeen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ifesdjeen/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/ifesdjeen/netty","forks_url":"https://api.github.com/repos/ifesdjeen/netty/forks","keys_url":"https://api.github.com/repos/ifesdjeen/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ifesdjeen/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ifesdjeen/netty/teams","hooks_url":"https://api.github.com/repos/ifesdjeen/netty/hooks","issue_events_url":"https://api.github.com/repos/ifesdjeen/netty/issues/events{/number}","events_url":"https://api.github.com/repos/ifesdjeen/netty/events","assignees_url":"https://api.github.com/repos/ifesdjeen/netty/assignees{/user}","branches_url":"https://api.github.com/repos/ifesdjeen/netty/branches{/branch}","tags_url":"https://api.github.com/repos/ifesdjeen/netty/tags","blobs_url":"https://api.github.com/repos/ifesdjeen/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ifesdjeen/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ifesdjeen/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/ifesdjeen/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ifesdjeen/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/ifesdjeen/netty/languages","stargazers_url":"https://api.github.com/repos/ifesdjeen/netty/stargazers","contributors_url":"https://api.github.com/repos/ifesdjeen/netty/contributors","subscribers_url":"https://api.github.com/repos/ifesdjeen/netty/subscribers","subscription_url":"https://api.github.com/repos/ifesdjeen/netty/subscription","commits_url":"https://api.github.com/repos/ifesdjeen/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/ifesdjeen/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/ifesdjeen/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/ifesdjeen/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/ifesdjeen/netty/contents/{+path}","compare_url":"https://api.github.com/repos/ifesdjeen/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ifesdjeen/netty/merges","archive_url":"https://api.github.com/repos/ifesdjeen/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ifesdjeen/netty/downloads","issues_url":"https://api.github.com/repos/ifesdjeen/netty/issues{/number}","pulls_url":"https://api.github.com/repos/ifesdjeen/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/ifesdjeen/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/ifesdjeen/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ifesdjeen/netty/labels{/name}","releases_url":"https://api.github.com/repos/ifesdjeen/netty/releases{/id}","created_at":"2013-11-08T09:50:41Z","updated_at":"2013-11-20T10:21:03Z","pushed_at":"2015-11-20T12:36:23Z","git_url":"git://github.com/ifesdjeen/netty.git","ssh_url":"git@github.com:ifesdjeen/netty.git","clone_url":"https://github.com/ifesdjeen/netty.git","svn_url":"https://github.com/ifesdjeen/netty","homepage":"http://netty.io/","size":40640,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:master","ref":"master","sha":"ebfe3d2ba737b55ab770d6385786586ef0858203","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-11-23T20:57:40Z","pushed_at":"2015-11-23T20:53:35Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":58385,"stargazers_count":5631,"watchers_count":5631,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2859,"mirror_url":null,"open_issues_count":337,"forks":2859,"open_issues":337,"watchers":5631,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/4477"},"html":{"href":"https://github.com/netty/netty/pull/4477"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/4477"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/4477/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/4477/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/4477/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/a44c4190d44223ad7025df751fe7ed5e9f221a17"}}}}