{"action":"created","comment":{"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments/47984576","id":47984576,"diff_hunk":"@@ -139,17 +156,29 @@\n       return validKey;\n     }\n \n-    function normalizedKeyForEvent(keyEvent) {\n-      // fall back from .key, to .keyIdentifier, to .keyCode, and then to\n-      // .detail.key to support artificial keyboard events\n-      return transformKey(keyEvent.key) ||\n+    /**\n+      * Calculates the normalized key for a KeyboardEvent.\n+      * @param {KeyboardEvent} keyEvent\n+      * @param {Boolean} [noSpecialChars] Set to true to limit keyEvent.key\n+      * transformation to alpha-numeric chars. This is useful with key\n+      * combinations like shift + 2, which on FF for MacOS produces\n+      * keyEvent.key = @\n+      * To get 2 returned, set noSpecialChars = true\n+      * To get @ returned, set noSpecialChars = false\n+     */\n+    function normalizedKeyForEvent(keyEvent, noSpecialChars) {","path":"iron-a11y-keys-behavior.html","position":59,"original_position":59,"commit_id":"6d2bf72812de0a4561a0ee3089ed2d1a008b8486","original_commit_id":"6d2bf72812de0a4561a0ee3089ed2d1a008b8486","user":{"login":"valdrinkoshi","id":6173664,"avatar_url":"https://avatars.githubusercontent.com/u/6173664?v=3","gravatar_id":"","url":"https://api.github.com/users/valdrinkoshi","html_url":"https://github.com/valdrinkoshi","followers_url":"https://api.github.com/users/valdrinkoshi/followers","following_url":"https://api.github.com/users/valdrinkoshi/following{/other_user}","gists_url":"https://api.github.com/users/valdrinkoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/valdrinkoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valdrinkoshi/subscriptions","organizations_url":"https://api.github.com/users/valdrinkoshi/orgs","repos_url":"https://api.github.com/users/valdrinkoshi/repos","events_url":"https://api.github.com/users/valdrinkoshi/events{/privacy}","received_events_url":"https://api.github.com/users/valdrinkoshi/received_events","type":"User","site_admin":false},"body":"@cdata WDYT?","created_at":"2015-12-18T01:17:31Z","updated_at":"2015-12-18T01:17:31Z","html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/29#discussion_r47984576","pull_request_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments/47984576"},"html":{"href":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/29#discussion_r47984576"},"pull_request":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29","id":53779896,"html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/29","diff_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/29.diff","patch_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/29.patch","issue_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/29","number":29,"state":"open","locked":false,"title":"support only alpha-numeric chars for combos","user":{"login":"valdrinkoshi","id":6173664,"avatar_url":"https://avatars.githubusercontent.com/u/6173664?v=3","gravatar_id":"","url":"https://api.github.com/users/valdrinkoshi","html_url":"https://github.com/valdrinkoshi","followers_url":"https://api.github.com/users/valdrinkoshi/followers","following_url":"https://api.github.com/users/valdrinkoshi/following{/other_user}","gists_url":"https://api.github.com/users/valdrinkoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/valdrinkoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valdrinkoshi/subscriptions","organizations_url":"https://api.github.com/users/valdrinkoshi/orgs","repos_url":"https://api.github.com/users/valdrinkoshi/repos","events_url":"https://api.github.com/users/valdrinkoshi/events{/privacy}","received_events_url":"https://api.github.com/users/valdrinkoshi/received_events","type":"User","site_admin":false},"body":"Fixes #28 by supporting only alpha-numeric chars for combos.\r\nSpecial characters recognition is still supported, but not with combos.","created_at":"2015-12-15T23:46:56Z","updated_at":"2015-12-18T01:17:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"718d4d3a339d221be70e43694c8c1dcb191bcd17","assignee":{"login":"cdata","id":240083,"avatar_url":"https://avatars.githubusercontent.com/u/240083?v=3","gravatar_id":"","url":"https://api.github.com/users/cdata","html_url":"https://github.com/cdata","followers_url":"https://api.github.com/users/cdata/followers","following_url":"https://api.github.com/users/cdata/following{/other_user}","gists_url":"https://api.github.com/users/cdata/gists{/gist_id}","starred_url":"https://api.github.com/users/cdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdata/subscriptions","organizations_url":"https://api.github.com/users/cdata/orgs","repos_url":"https://api.github.com/users/cdata/repos","events_url":"https://api.github.com/users/cdata/events{/privacy}","received_events_url":"https://api.github.com/users/cdata/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29/commits","review_comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29/comments","review_comment_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/29/comments","statuses_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/6d2bf72812de0a4561a0ee3089ed2d1a008b8486","head":{"label":"PolymerElements:issue-28","ref":"issue-28","sha":"6d2bf72812de0a4561a0ee3089ed2d1a008b8486","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":35118041,"name":"iron-a11y-keys-behavior","full_name":"PolymerElements/iron-a11y-keys-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","description":"A behavior that enables keybindings for greater a11y","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior","forks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/releases{/id}","created_at":"2015-05-05T18:53:47Z","updated_at":"2015-11-16T09:41:20Z","pushed_at":"2015-12-18T01:16:40Z","git_url":"git://github.com/PolymerElements/iron-a11y-keys-behavior.git","ssh_url":"git@github.com:PolymerElements/iron-a11y-keys-behavior.git","clone_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior.git","svn_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","homepage":"","size":1452,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":3,"default_branch":"master"}},"base":{"label":"PolymerElements:master","ref":"master","sha":"cd8c972278c0d916bef57209d7dce5b81e67687c","user":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"repo":{"id":35118041,"name":"iron-a11y-keys-behavior","full_name":"PolymerElements/iron-a11y-keys-behavior","owner":{"login":"PolymerElements","id":11639138,"avatar_url":"https://avatars.githubusercontent.com/u/11639138?v=3","gravatar_id":"","url":"https://api.github.com/users/PolymerElements","html_url":"https://github.com/PolymerElements","followers_url":"https://api.github.com/users/PolymerElements/followers","following_url":"https://api.github.com/users/PolymerElements/following{/other_user}","gists_url":"https://api.github.com/users/PolymerElements/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymerElements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymerElements/subscriptions","organizations_url":"https://api.github.com/users/PolymerElements/orgs","repos_url":"https://api.github.com/users/PolymerElements/repos","events_url":"https://api.github.com/users/PolymerElements/events{/privacy}","received_events_url":"https://api.github.com/users/PolymerElements/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","description":"A behavior that enables keybindings for greater a11y","fork":false,"url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior","forks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/forks","keys_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/teams","hooks_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/hooks","issue_events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/events{/number}","events_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/events","assignees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/assignees{/user}","branches_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/branches{/branch}","tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/tags","blobs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/languages","stargazers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/stargazers","contributors_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contributors","subscribers_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscribers","subscription_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/subscription","commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/contents/{+path}","compare_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/merges","archive_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/downloads","issues_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues{/number}","pulls_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/labels{/name}","releases_url":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/releases{/id}","created_at":"2015-05-05T18:53:47Z","updated_at":"2015-11-16T09:41:20Z","pushed_at":"2015-12-18T01:16:40Z","git_url":"git://github.com/PolymerElements/iron-a11y-keys-behavior.git","ssh_url":"git@github.com:PolymerElements/iron-a11y-keys-behavior.git","clone_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior.git","svn_url":"https://github.com/PolymerElements/iron-a11y-keys-behavior","homepage":"","size":1452,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":7,"forks":5,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29"},"html":{"href":"https://github.com/PolymerElements/iron-a11y-keys-behavior/pull/29"},"issue":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/29"},"comments":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/PolymerElements/iron-a11y-keys-behavior/statuses/6d2bf72812de0a4561a0ee3089ed2d1a008b8486"}}}}