{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/24256860","id":24256860,"diff_hunk":"@@ -130,11 +130,15 @@ public override bool Equals(object obj)\n \n             public override int GetHashCode()\n             {\n-                return Hash.Combine(_descriptor,\n-                        Hash.Combine(_messageArgs.GetHashCode(),\n-                         Hash.Combine(_location.GetHashCode(),\n-                          Hash.Combine(_severity.GetHashCode(), _warningLevel)\n-                        )));\n+                int hash = 0;\n+\n+                hash = Hash.Combine(_location.GetHashCode(), 0);\n+                hash = Hash.Combine((int)_severity, hash);\n+                hash = Hash.Combine(_warningLevel, hash);\n+                hash = Hash.Combine(Hash.CombineValues(_messageArgs), hash);\n+                hash = Hash.Combine(_descriptor, hash);","path":"src/Compilers/Core/Portable/Diagnostic/Diagnostic_SimpleDiagnostic.cs","position":null,"original_position":15,"commit_id":"9adca24759bce614fd51338df9da6a2a85543a61","original_commit_id":"41a2ef9dbaa8a0f14d6ffa0ecabb25b9b5f592a6","user":{"login":"pharring","id":9952654,"avatar_url":"https://avatars.githubusercontent.com/u/9952654?v=3","gravatar_id":"","url":"https://api.github.com/users/pharring","html_url":"https://github.com/pharring","followers_url":"https://api.github.com/users/pharring/followers","following_url":"https://api.github.com/users/pharring/following{/other_user}","gists_url":"https://api.github.com/users/pharring/gists{/gist_id}","starred_url":"https://api.github.com/users/pharring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pharring/subscriptions","organizations_url":"https://api.github.com/users/pharring/orgs","repos_url":"https://api.github.com/users/pharring/repos","events_url":"https://api.github.com/users/pharring/events{/privacy}","received_events_url":"https://api.github.com/users/pharring/received_events","type":"User","site_admin":false},"body":"Just an observation: While using the local variable undoubtedly makes the code easier to read, it does introduce a slight performance overhead. The original form's IL is shorter and (obviously) eliminates a local variable slot. The Roslyn compiler (currently) doesn't try to eliminate the local. I don't know whether the various JIT compilers will do so either.","created_at":"2015-02-06T17:35:29Z","updated_at":"2015-02-06T17:35:29Z","html_url":"https://github.com/dotnet/roslyn/pull/209#discussion_r24256860","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/209","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/24256860"},"html":{"href":"https://github.com/dotnet/roslyn/pull/209#discussion_r24256860"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/209","id":28555843,"html_url":"https://github.com/dotnet/roslyn/pull/209","diff_url":"https://github.com/dotnet/roslyn/pull/209.diff","patch_url":"https://github.com/dotnet/roslyn/pull/209.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/209","number":209,"state":"open","locked":false,"title":"Fix SimpleDiagnostic GetHashCode is more specific than Equals","user":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"body":"Fixes #57.\r\n\r\nI hope it is okay that I just went ahead and fixed it.","created_at":"2015-02-03T14:26:17Z","updated_at":"2015-02-06T17:35:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf09d716c21e0180fc9aac85228cb8fa8545e019","assignee":{"login":"mavasani","id":10605811,"avatar_url":"https://avatars.githubusercontent.com/u/10605811?v=3","gravatar_id":"","url":"https://api.github.com/users/mavasani","html_url":"https://github.com/mavasani","followers_url":"https://api.github.com/users/mavasani/followers","following_url":"https://api.github.com/users/mavasani/following{/other_user}","gists_url":"https://api.github.com/users/mavasani/gists{/gist_id}","starred_url":"https://api.github.com/users/mavasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavasani/subscriptions","organizations_url":"https://api.github.com/users/mavasani/orgs","repos_url":"https://api.github.com/users/mavasani/repos","events_url":"https://api.github.com/users/mavasani/events{/privacy}","received_events_url":"https://api.github.com/users/mavasani/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/dotnet/roslyn/milestones/6","labels_url":"https://api.github.com/repos/dotnet/roslyn/milestones/6/labels","id":956299,"number":6,"title":"1.0-rc2","description":"","creator":{"login":"theoy","id":8222470,"avatar_url":"https://avatars.githubusercontent.com/u/8222470?v=3","gravatar_id":"","url":"https://api.github.com/users/theoy","html_url":"https://github.com/theoy","followers_url":"https://api.github.com/users/theoy/followers","following_url":"https://api.github.com/users/theoy/following{/other_user}","gists_url":"https://api.github.com/users/theoy/gists{/gist_id}","starred_url":"https://api.github.com/users/theoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theoy/subscriptions","organizations_url":"https://api.github.com/users/theoy/orgs","repos_url":"https://api.github.com/users/theoy/repos","events_url":"https://api.github.com/users/theoy/events{/privacy}","received_events_url":"https://api.github.com/users/theoy/received_events","type":"User","site_admin":false},"open_issues":44,"closed_issues":6,"state":"open","created_at":"2015-01-29T06:19:12Z","updated_at":"2015-02-06T00:46:07Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/209/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/209/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/209/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/9adca24759bce614fd51338df9da6a2a85543a61","head":{"label":"pdelvo:fix-57","ref":"fix-57","sha":"9adca24759bce614fd51338df9da6a2a85543a61","user":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"repo":{"id":30246316,"name":"roslyn","full_name":"pdelvo/roslyn","owner":{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars.githubusercontent.com/u/1710209?v=3","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pdelvo/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/pdelvo/roslyn","forks_url":"https://api.github.com/repos/pdelvo/roslyn/forks","keys_url":"https://api.github.com/repos/pdelvo/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pdelvo/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pdelvo/roslyn/teams","hooks_url":"https://api.github.com/repos/pdelvo/roslyn/hooks","issue_events_url":"https://api.github.com/repos/pdelvo/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/pdelvo/roslyn/events","assignees_url":"https://api.github.com/repos/pdelvo/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/pdelvo/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/pdelvo/roslyn/tags","blobs_url":"https://api.github.com/repos/pdelvo/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pdelvo/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pdelvo/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/pdelvo/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pdelvo/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/pdelvo/roslyn/languages","stargazers_url":"https://api.github.com/repos/pdelvo/roslyn/stargazers","contributors_url":"https://api.github.com/repos/pdelvo/roslyn/contributors","subscribers_url":"https://api.github.com/repos/pdelvo/roslyn/subscribers","subscription_url":"https://api.github.com/repos/pdelvo/roslyn/subscription","commits_url":"https://api.github.com/repos/pdelvo/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/pdelvo/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/pdelvo/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/pdelvo/roslyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/pdelvo/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/pdelvo/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pdelvo/roslyn/merges","archive_url":"https://api.github.com/repos/pdelvo/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pdelvo/roslyn/downloads","issues_url":"https://api.github.com/repos/pdelvo/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/pdelvo/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/pdelvo/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/pdelvo/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pdelvo/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/pdelvo/roslyn/releases{/id}","created_at":"2015-02-03T14:21:47Z","updated_at":"2015-02-03T14:22:12Z","pushed_at":"2015-02-06T16:25:19Z","git_url":"git://github.com/pdelvo/roslyn.git","ssh_url":"git@github.com:pdelvo/roslyn.git","clone_url":"https://github.com/pdelvo/roslyn.git","svn_url":"https://github.com/pdelvo/roslyn","homepage":"","size":50992,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"c844dcc2713af0a2be20392cb487f3d6e0415f5d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments/{number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-02-06T16:52:17Z","pushed_at":"2015-02-06T01:14:16Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":62292,"stargazers_count":1063,"watchers_count":1063,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":167,"mirror_url":null,"open_issues_count":218,"forks":167,"open_issues":218,"watchers":1063,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/209"},"html":{"href":"https://github.com/dotnet/roslyn/pull/209"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/209"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/9adca24759bce614fd51338df9da6a2a85543a61"}}}}