{"action":"created","issue":{"url":"https://api.github.com/repos/request/request/issues/1598","labels_url":"https://api.github.com/repos/request/request/issues/1598/labels{/name}","comments_url":"https://api.github.com/repos/request/request/issues/1598/comments","events_url":"https://api.github.com/repos/request/request/issues/1598/events","html_url":"https://github.com/request/request/pull/1598","id":79992196,"number":1598,"title":"fix the way http verbs are defined","user":{"login":"flannelJesus","id":5897515,"avatar_url":"https://avatars.githubusercontent.com/u/5897515?v=3","gravatar_id":"","url":"https://api.github.com/users/flannelJesus","html_url":"https://github.com/flannelJesus","followers_url":"https://api.github.com/users/flannelJesus/followers","following_url":"https://api.github.com/users/flannelJesus/following{/other_user}","gists_url":"https://api.github.com/users/flannelJesus/gists{/gist_id}","starred_url":"https://api.github.com/users/flannelJesus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flannelJesus/subscriptions","organizations_url":"https://api.github.com/users/flannelJesus/orgs","repos_url":"https://api.github.com/users/flannelJesus/repos","events_url":"https://api.github.com/users/flannelJesus/events{/privacy}","received_events_url":"https://api.github.com/users/flannelJesus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-24T00:04:12Z","updated_at":"2015-05-24T15:45:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/request/request/pulls/1598","html_url":"https://github.com/request/request/pull/1598","diff_url":"https://github.com/request/request/pull/1598.diff","patch_url":"https://github.com/request/request/pull/1598.patch"},"body":"I changed the way they are defined so that they are more IDE-friendly. The way they were defined, an IDE wouldn't easily recognize them and would often show 'request.get' or 'request.post' etc as a possible error. Ctrl+clicking on the 'get' function wouldn't take you to where it was defined. Now it will!"},"comment":{"url":"https://api.github.com/repos/request/request/issues/comments/105028391","html_url":"https://github.com/request/request/pull/1598#issuecomment-105028391","issue_url":"https://api.github.com/repos/request/request/issues/1598","id":105028391,"user":{"login":"froatsnook","id":10405574,"avatar_url":"https://avatars.githubusercontent.com/u/10405574?v=3","gravatar_id":"","url":"https://api.github.com/users/froatsnook","html_url":"https://github.com/froatsnook","followers_url":"https://api.github.com/users/froatsnook/followers","following_url":"https://api.github.com/users/froatsnook/following{/other_user}","gists_url":"https://api.github.com/users/froatsnook/gists{/gist_id}","starred_url":"https://api.github.com/users/froatsnook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/froatsnook/subscriptions","organizations_url":"https://api.github.com/users/froatsnook/orgs","repos_url":"https://api.github.com/users/froatsnook/repos","events_url":"https://api.github.com/users/froatsnook/events{/privacy}","received_events_url":"https://api.github.com/users/froatsnook/received_events","type":"User","site_admin":false},"created_at":"2015-05-24T15:45:37Z","updated_at":"2015-05-24T15:45:37Z","body":"@flannelJesus Feel free to squash together your two commits into one.  That way there's less noise in the diffs, in the git blame, etc.  Since no one else is tracking the flannelJesus/fix-verbs branch, it's not a faux-pas to rewrite history.  In case you've never done this before, you can:\r\n\r\nDo an interactive rebase onto two commits before HEAD:\r\n\r\n```\r\ngit rebase -i HEAD~~\r\n```\r\n\r\nThat opens your editor with this:\r\n\r\n```\r\npick f5eaea8 fix the way http verbs are defined\r\npick a63a3fc fix formatting according to eslint settings\r\n```\r\n\r\nThen change the second `pick` to `fixup` like this:\r\n\r\n```\r\npick f5eaea8 fix the way http verbs are defined\r\nfixup a63a3fc fix formatting according to eslint settings\r\n```\r\n\r\nand save and quit.  git will merge together the two commits into one and take the commit message from the first.  Interactive rebase is super powerful.  Instead of fixup, you can use squash (if you want to edit the commit message of the combined commit) or reword if you just want to change the commit message.  You can also reorder commits (just by reordering the lines in this file) and squash together multiple commits (put multiple fixup/squash in a row).  One thing I often do is find a typo from a few commits ago.  In order to fix that, you add a new commit that fixes it, then do an interactive rebase and reorder the lines and change the new commit to fixup.  It's like the typo never happened (again unless someone is tracking your branch, in which case rewriting history is ugly).  There might be merge conflicts when you reorder commits, so be careful with that.\r\n\r\nAfter you change your history, you have to do a *forced* push to github:\r\n\r\n```\r\ngit push --force origin fix-verbs\r\n```\r\n\r\nThis automatically updates the pull request!"}}