{"action":"created","comment":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/35119377","id":35119377,"diff_hunk":"@@ -100,37 +108,40 @@ Test Rdef Copy Paste Save\n     # Click Undo - Channel should be Yellow\n     Click Element                           id=rdef-undo-btn\n     Wait For Channel Color                  rgb(255, 255, 0)\n+\n     # And all buttons Undo, Redo & Save enabled\n     Element Should Be Enabled               id=rdef-undo-btn\n     Element Should Be Enabled               id=rdef-redo-btn\n     Element Should Be Enabled               id=rdef-setdef-btn\n \n     # Save (with Yellow channel) & wait for thumbnail to update\n-    ${thumbSrc}=                            Execute Javascript  return $.trim($(\"button.clicked img.rdef\").attr('src'))\n+    ${thumbSrc}=                            Get Element Attribute      xpath=//button[@class=\"rdef clicked\"]/img@src\n     Click Element                           id=rdef-setdef-btn\n     Wait For BlockUI\n-    Wait For Condition                      return ($.trim($(\"button.clicked img.rdef\").attr('src')) != '${thumbSrc}')\n+    Wait Until Page Contains Element        xpath=//button[@class=\"rdef clicked\"]/img[@src!='${thumbSrc}']\n     # Redo (to Blue channel)\n     Click Element                           id=rdef-redo-btn\n     Wait For Channel Color                  rgb(0, 0, 255)\n     # Copy (paste button is enabled)\n-    Click Element                           xpath=//button[contains(@class, \"copy_rdef\")]\n-    Wait Until Page Contains Element        xpath=//button[contains(@class, \"paste_rdef\")][not(@disabled=\"disabled\")]\n+    Click Element                           id=rdef-copy-btn\n+    Wait For Toolbar Button Enabled         rdef-paste-btn\n \n     # Check that 'Save' has worked by refreshing right panel (click on thumbnail)","path":"components/tests/ui/testcases/web/rdef_test.txt","position":94,"original_position":94,"commit_id":"284af73c156709c452a261d353b5a284d3baeb7f","original_commit_id":"284af73c156709c452a261d353b5a284d3baeb7f","user":{"login":"will-moore","id":900055,"avatar_url":"https://avatars.githubusercontent.com/u/900055?v=3","gravatar_id":"","url":"https://api.github.com/users/will-moore","html_url":"https://github.com/will-moore","followers_url":"https://api.github.com/users/will-moore/followers","following_url":"https://api.github.com/users/will-moore/following{/other_user}","gists_url":"https://api.github.com/users/will-moore/gists{/gist_id}","starred_url":"https://api.github.com/users/will-moore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-moore/subscriptions","organizations_url":"https://api.github.com/users/will-moore/orgs","repos_url":"https://api.github.com/users/will-moore/repos","events_url":"https://api.github.com/users/will-moore/events{/privacy}","received_events_url":"https://api.github.com/users/will-moore/received_events","type":"User","site_admin":false},"body":"The (click on thumbnail) part of this comment is out of date now.","created_at":"2015-07-21T15:57:34Z","updated_at":"2015-07-21T15:57:34Z","html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3960#discussion_r35119377","pull_request_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960","_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments/35119377"},"html":{"href":"https://github.com/openmicroscopy/openmicroscopy/pull/3960#discussion_r35119377"},"pull_request":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960"}}},"pull_request":{"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960","id":39800275,"html_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3960","diff_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3960.diff","patch_url":"https://github.com/openmicroscopy/openmicroscopy/pull/3960.patch","issue_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3960","number":3960,"state":"open","locked":false,"title":"Improving rendering and delete tests","user":{"login":"aleksandra-tarkowska","id":1065155,"avatar_url":"https://avatars.githubusercontent.com/u/1065155?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandra-tarkowska","html_url":"https://github.com/aleksandra-tarkowska","followers_url":"https://api.github.com/users/aleksandra-tarkowska/followers","following_url":"https://api.github.com/users/aleksandra-tarkowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-tarkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-tarkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-tarkowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-tarkowska/orgs","repos_url":"https://api.github.com/users/aleksandra-tarkowska/repos","events_url":"https://api.github.com/users/aleksandra-tarkowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-tarkowska/received_events","type":"User","site_admin":false},"body":"Following #3942 this should improve tests that requires reloading preview panel. It was mandatory to introduce token to identify content (it shouldn't have any effect on application)\r\n\r\n\r\n\r\nNote: Copy Past Rendering were always failing on the copy/paste action\r\n\r\nCurrent status: https://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-robotframework/299/robot/report/log.html\r\n\r\nhttps://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-robotframework/285/robot/report/log.html#s1-s1-s5\r\nhttps://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-robotframework/286/robot/report/log.html#s1-s1-s5\r\nhttps://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-robotframework/287/robot/report/log.html#s1-s1-s5\r\nhttps://ci.openmicroscopy.org/view/Failing/job/OMERO-5.1-merge-robotframework/288/robot/report/log.html#s1-s1-s5\r\n\r\nThis is due to not saving rendering in HTTP session:\r\n```\r\n2015-07-20 09:43:28,622  INFO [               omeroweb.webgateway.views] (proc.17092) copy_image_rdef_json:1707  REQUEST: GET: <QueryDict: {u'c': [u'1|0:255$0000FF'], u'm': [u'g'], u'pixel_range': [u'0:255'], u'imageId': [u'4826'], u'p': [u'normal'], u'ia': [u'0']}> ;  POST <QueryDict: {}>\r\n2015-07-20 09:43:28,622  INFO [               omeroweb.webgateway.views] (proc.17092) copy_image_rdef_json:1708  copy sessionID: 8j0otgvnhh38a0nva3ts1pzn7se6hgpk\r\n2015-07-20 09:43:28,622  INFO [               omeroweb.webgateway.views] (proc.17092) copy_image_rdef_json:1748  copy rdef: {'c': '1|0:255$0000FF', 'm': 'g', 'pixel_range': '0:255', 'imageId': 4826}\r\n\r\n2015-07-20 09:43:29,474  INFO [               omeroweb.webgateway.views] (proc.15920) get_image_rdef_json:1841  get sessionID: 8j0otgvnhh38a0nva3ts1pzn7se6hgpk\r\n2015-07-20 09:43:29,474  INFO [               omeroweb.webgateway.views] (proc.15920) get_image_rdef_json:1843  get rdef: None\r\n2015-07-20 09:43:29,475  INFO [               omeroweb.webgateway.views] (proc.15920) get_image_rdef_json:1847  fromid: None\r\n2015-07-20 09:43:29,475  INFO [               omeroweb.webgateway.views] (proc.15920) get_image_rdef_json:1864  get2 rdef: None\r\n```\r\nThis issue was tested with tests run in chrome against trout-integration and local apache and nginx. It always failed. It is only passing on the development server where session is handled in a different way.\r\n\r\ncc: @will-moore \r\n\r\n","created_at":"2015-07-13T11:03:05Z","updated_at":"2015-07-21T15:57:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7113fa85934429389d4760fede04f2bffeca70a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960/commits","review_comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960/comments","review_comment_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3960/comments","statuses_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/284af73c156709c452a261d353b5a284d3baeb7f","head":{"label":"aleksandra-tarkowska:improving_robot","ref":"improving_robot","sha":"284af73c156709c452a261d353b5a284d3baeb7f","user":{"login":"aleksandra-tarkowska","id":1065155,"avatar_url":"https://avatars.githubusercontent.com/u/1065155?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandra-tarkowska","html_url":"https://github.com/aleksandra-tarkowska","followers_url":"https://api.github.com/users/aleksandra-tarkowska/followers","following_url":"https://api.github.com/users/aleksandra-tarkowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-tarkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-tarkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-tarkowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-tarkowska/orgs","repos_url":"https://api.github.com/users/aleksandra-tarkowska/repos","events_url":"https://api.github.com/users/aleksandra-tarkowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-tarkowska/received_events","type":"User","site_admin":false},"repo":{"id":2422748,"name":"openmicroscopy","full_name":"aleksandra-tarkowska/openmicroscopy","owner":{"login":"aleksandra-tarkowska","id":1065155,"avatar_url":"https://avatars.githubusercontent.com/u/1065155?v=3","gravatar_id":"","url":"https://api.github.com/users/aleksandra-tarkowska","html_url":"https://github.com/aleksandra-tarkowska","followers_url":"https://api.github.com/users/aleksandra-tarkowska/followers","following_url":"https://api.github.com/users/aleksandra-tarkowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-tarkowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-tarkowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-tarkowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-tarkowska/orgs","repos_url":"https://api.github.com/users/aleksandra-tarkowska/repos","events_url":"https://api.github.com/users/aleksandra-tarkowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-tarkowska/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aleksandra-tarkowska/openmicroscopy","description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","fork":true,"url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy","forks_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/forks","keys_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/teams","hooks_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/hooks","issue_events_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/issues/events{/number}","events_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/events","assignees_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/assignees{/user}","branches_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/branches{/branch}","tags_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/tags","blobs_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/statuses/{sha}","languages_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/languages","stargazers_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/stargazers","contributors_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/contributors","subscribers_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/subscribers","subscription_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/subscription","commits_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/contents/{+path}","compare_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/merges","archive_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/downloads","issues_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/issues{/number}","pulls_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/pulls{/number}","milestones_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/milestones{/number}","notifications_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/labels{/name}","releases_url":"https://api.github.com/repos/aleksandra-tarkowska/openmicroscopy/releases{/id}","created_at":"2011-09-20T14:10:30Z","updated_at":"2015-04-06T09:08:09Z","pushed_at":"2015-07-20T11:47:55Z","git_url":"git://github.com/aleksandra-tarkowska/openmicroscopy.git","ssh_url":"git@github.com:aleksandra-tarkowska/openmicroscopy.git","clone_url":"https://github.com/aleksandra-tarkowska/openmicroscopy.git","svn_url":"https://github.com/aleksandra-tarkowska/openmicroscopy","homepage":"http://www.openmicroscopy.org","size":2110475,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"openmicroscopy:develop","ref":"develop","sha":"673d1c2f11e1cdfc2c28936a0376682b94bdb7c8","user":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"repo":{"id":2228226,"name":"openmicroscopy","full_name":"openmicroscopy/openmicroscopy","owner":{"login":"openmicroscopy","id":975861,"avatar_url":"https://avatars.githubusercontent.com/u/975861?v=3","gravatar_id":"","url":"https://api.github.com/users/openmicroscopy","html_url":"https://github.com/openmicroscopy","followers_url":"https://api.github.com/users/openmicroscopy/followers","following_url":"https://api.github.com/users/openmicroscopy/following{/other_user}","gists_url":"https://api.github.com/users/openmicroscopy/gists{/gist_id}","starred_url":"https://api.github.com/users/openmicroscopy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openmicroscopy/subscriptions","organizations_url":"https://api.github.com/users/openmicroscopy/orgs","repos_url":"https://api.github.com/users/openmicroscopy/repos","events_url":"https://api.github.com/users/openmicroscopy/events{/privacy}","received_events_url":"https://api.github.com/users/openmicroscopy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openmicroscopy/openmicroscopy","description":"OME (Open Microscopy Environment) develops open-source software and data format standards for the storage and manipulation of biological light microscopy data. A joint project between universities, research establishments and industry in Europe and the USA, OME has over 20 active researchers with strong links to the microscopy community. Funded by private and public research grants, OME has been a major force on the international microscopy stage since 2000.","fork":false,"url":"https://api.github.com/repos/openmicroscopy/openmicroscopy","forks_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/forks","keys_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/teams","hooks_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/hooks","issue_events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/events{/number}","events_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/events","assignees_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/assignees{/user}","branches_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/branches{/branch}","tags_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/tags","blobs_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/refs{/sha}","trees_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/{sha}","languages_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/languages","stargazers_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/stargazers","contributors_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/contributors","subscribers_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/subscribers","subscription_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/subscription","commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/commits{/sha}","git_commits_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/git/commits{/sha}","comments_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/comments{/number}","issue_comment_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/comments{/number}","contents_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/contents/{+path}","compare_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/merges","archive_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/downloads","issues_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues{/number}","pulls_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls{/number}","milestones_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/milestones{/number}","notifications_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/labels{/name}","releases_url":"https://api.github.com/repos/openmicroscopy/openmicroscopy/releases{/id}","created_at":"2011-08-18T14:26:02Z","updated_at":"2015-07-09T22:18:23Z","pushed_at":"2015-07-21T13:22:52Z","git_url":"git://github.com/openmicroscopy/openmicroscopy.git","ssh_url":"git@github.com:openmicroscopy/openmicroscopy.git","clone_url":"https://github.com/openmicroscopy/openmicroscopy.git","svn_url":"https://github.com/openmicroscopy/openmicroscopy","homepage":"http://www.openmicroscopy.org","size":2164744,"stargazers_count":68,"watchers_count":68,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":41,"forks":67,"open_issues":41,"watchers":68,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960"},"html":{"href":"https://github.com/openmicroscopy/openmicroscopy/pull/3960"},"issue":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3960"},"comments":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/issues/3960/comments"},"review_comments":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960/comments"},"review_comment":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/pulls/3960/commits"},"statuses":{"href":"https://api.github.com/repos/openmicroscopy/openmicroscopy/statuses/284af73c156709c452a261d353b5a284d3baeb7f"}}}}