{"action":"created","issue":{"url":"https://api.github.com/repos/jembi/bsis/issues/315","labels_url":"https://api.github.com/repos/jembi/bsis/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/jembi/bsis/issues/315/comments","events_url":"https://api.github.com/repos/jembi/bsis/issues/315/events","html_url":"https://github.com/jembi/bsis/pull/315","id":97892310,"number":315,"title":"added sheduled task to update the general config at startup","user":{"login":"debonair","id":618654,"avatar_url":"https://avatars.githubusercontent.com/u/618654?v=3","gravatar_id":"","url":"https://api.github.com/users/debonair","html_url":"https://github.com/debonair","followers_url":"https://api.github.com/users/debonair/followers","following_url":"https://api.github.com/users/debonair/following{/other_user}","gists_url":"https://api.github.com/users/debonair/gists{/gist_id}","starred_url":"https://api.github.com/users/debonair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debonair/subscriptions","organizations_url":"https://api.github.com/users/debonair/orgs","repos_url":"https://api.github.com/users/debonair/repos","events_url":"https://api.github.com/users/debonair/events{/privacy}","received_events_url":"https://api.github.com/users/debonair/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-07-29T09:13:23Z","updated_at":"2015-07-31T08:47:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jembi/bsis/pulls/315","html_url":"https://github.com/jembi/bsis/pull/315","diff_url":"https://github.com/jembi/bsis/pull/315.diff","patch_url":"https://github.com/jembi/bsis/pull/315.patch"},"body":"@danfuterman Please take a look at my initial solution for updating the general config values, while I add the default values to the liquibase file"},"comment":{"url":"https://api.github.com/repos/jembi/bsis/issues/comments/126611024","html_url":"https://github.com/jembi/bsis/pull/315#issuecomment-126611024","issue_url":"https://api.github.com/repos/jembi/bsis/issues/315","id":126611024,"user":{"login":"danfuterman","id":1052668,"avatar_url":"https://avatars.githubusercontent.com/u/1052668?v=3","gravatar_id":"","url":"https://api.github.com/users/danfuterman","html_url":"https://github.com/danfuterman","followers_url":"https://api.github.com/users/danfuterman/followers","following_url":"https://api.github.com/users/danfuterman/following{/other_user}","gists_url":"https://api.github.com/users/danfuterman/gists{/gist_id}","starred_url":"https://api.github.com/users/danfuterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danfuterman/subscriptions","organizations_url":"https://api.github.com/users/danfuterman/orgs","repos_url":"https://api.github.com/users/danfuterman/repos","events_url":"https://api.github.com/users/danfuterman/events{/privacy}","received_events_url":"https://api.github.com/users/danfuterman/received_events","type":"User","site_admin":false},"created_at":"2015-07-31T08:47:25Z","updated_at":"2015-07-31T08:47:25Z","body":"@debonair - two suggestions:\r\n\r\n - it would be great if dataType could be specified by name, rather than the full json dataType. i.e.:\r\nthis: \r\n```\r\n       {\r\n           \"datatype\": \"text\"\r\n           \"description\": \"Example Property Description\",\r\n           \"name\": \"examplePropertyName\",\r\n           \"value\": \"exampleValue\"\r\n        }\r\n```\r\nwould be better than the current way:\r\n```\r\n          {\r\n           \"dataType\": {\r\n               \"id\": 1,\r\n               \"datatype\": \"text\"\r\n           },\r\n           \"description\": \"Example Property Description\",\r\n           \"name\": \"examplePropertyName\",\r\n           \"value\": \"exampleValue\"\r\n        }\r\n```\r\n\r\n - I'd suggest improving the error handling and feedback. 1. Is it possible to get the logging to output on the mvn command line build, so that the status and outcomes are displayed when compiling the app? 2. It would be great to include the following logging:\r\n  - when the configs.json file can't be found or opened - display a message to say something like 'no config file found, default values used'.\r\n  - when a config property is successfully added or updated, display a relevant message along with the name of the property.\r\n  - when a config property is unsuccessfully added or updated (because of an issue with the json or values etc.) - display a relevant message along with the name of the property.\r\n - Q. What happens if the json is not formatted correctly - will it just affect that property, will it affect the properties after that, or will it cause the whole thing to fail?"}}