{"action":"created","comment":{"url":"https://api.github.com/repos/iojs/io.js/pulls/comments/26504654","id":26504654,"diff_hunk":"@@ -726,28 +726,29 @@ Local<Value> ErrnoException(Isolate* isolate,\n   }\n   Local<String> message = OneByteString(env->isolate(), msg);\n \n-  Local<String> cons1 =\n+  Local<String> cons =\n       String::Concat(estring, FIXED_ONE_BYTE_STRING(env->isolate(), \", \"));\n-  Local<String> cons2 = String::Concat(cons1, message);\n+  cons = String::Concat(cons, message);\n \n-  if (path) {\n-    Local<String> cons3 =\n-        String::Concat(cons2, FIXED_ONE_BYTE_STRING(env->isolate(), \" '\"));\n-    Local<String> cons4 =\n-        String::Concat(cons3, String::NewFromUtf8(env->isolate(), path));\n-    Local<String> cons5 =\n-        String::Concat(cons4, FIXED_ONE_BYTE_STRING(env->isolate(), \"'\"));\n-    e = Exception::Error(cons5);\n-  } else {\n-    e = Exception::Error(cons2);\n+  Local<String> path_string;\n+  if (path != nullptr) {\n+    // FIXME(bnoordhuis) It's questionable to interpret the file path as UTF-8.","path":"src/node.cc","position":22,"original_position":22,"commit_id":"12f2fc97d941798caddb59b13c686906aad6c35a","original_commit_id":"12f2fc97d941798caddb59b13c686906aad6c35a","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"One-byte strings or if you want more radical, buffers or typed arrays.  It also depends on the platform: file paths are untyped binary blobs on most Unices, but on OS X (i.e. HFS+) and Windows, they're Unicode.\r\n\r\nI'm not sure what the right answer is, just that our current approach is wrong. :-)","created_at":"2015-03-16T17:00:38Z","updated_at":"2015-03-16T17:00:38Z","html_url":"https://github.com/iojs/io.js/pull/1148#discussion_r26504654","pull_request_url":"https://api.github.com/repos/iojs/io.js/pulls/1148","_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments/26504654"},"html":{"href":"https://github.com/iojs/io.js/pull/1148#discussion_r26504654"},"pull_request":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1148"}}},"pull_request":{"url":"https://api.github.com/repos/iojs/io.js/pulls/1148","id":31166451,"html_url":"https://github.com/iojs/io.js/pull/1148","diff_url":"https://github.com/iojs/io.js/pull/1148.diff","patch_url":"https://github.com/iojs/io.js/pull/1148.patch","issue_url":"https://api.github.com/repos/iojs/io.js/issues/1148","number":1148,"state":"open","locked":false,"title":"Minor fixups","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"body":"R=@trevnorris?","created_at":"2015-03-13T21:42:25Z","updated_at":"2015-03-16T17:00:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"862e675e439087d33da5b54233a7339d22d8fb7b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iojs/io.js/pulls/1148/commits","review_comments_url":"https://api.github.com/repos/iojs/io.js/pulls/1148/comments","review_comment_url":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iojs/io.js/issues/1148/comments","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/12f2fc97d941798caddb59b13c686906aad6c35a","head":{"label":"bnoordhuis:minor-fixups","ref":"minor-fixups","sha":"12f2fc97d941798caddb59b13c686906aad6c35a","user":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"repo":{"id":27560441,"name":"io.js","full_name":"bnoordhuis/io.js","owner":{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars.githubusercontent.com/u/275871?v=3","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bnoordhuis/io.js","description":"Evented IO for V8 JavaScript","fork":true,"url":"https://api.github.com/repos/bnoordhuis/io.js","forks_url":"https://api.github.com/repos/bnoordhuis/io.js/forks","keys_url":"https://api.github.com/repos/bnoordhuis/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bnoordhuis/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bnoordhuis/io.js/teams","hooks_url":"https://api.github.com/repos/bnoordhuis/io.js/hooks","issue_events_url":"https://api.github.com/repos/bnoordhuis/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/bnoordhuis/io.js/events","assignees_url":"https://api.github.com/repos/bnoordhuis/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/bnoordhuis/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/bnoordhuis/io.js/tags","blobs_url":"https://api.github.com/repos/bnoordhuis/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bnoordhuis/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bnoordhuis/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/bnoordhuis/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bnoordhuis/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/bnoordhuis/io.js/languages","stargazers_url":"https://api.github.com/repos/bnoordhuis/io.js/stargazers","contributors_url":"https://api.github.com/repos/bnoordhuis/io.js/contributors","subscribers_url":"https://api.github.com/repos/bnoordhuis/io.js/subscribers","subscription_url":"https://api.github.com/repos/bnoordhuis/io.js/subscription","commits_url":"https://api.github.com/repos/bnoordhuis/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/bnoordhuis/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/bnoordhuis/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/bnoordhuis/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/bnoordhuis/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/bnoordhuis/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bnoordhuis/io.js/merges","archive_url":"https://api.github.com/repos/bnoordhuis/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bnoordhuis/io.js/downloads","issues_url":"https://api.github.com/repos/bnoordhuis/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/bnoordhuis/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/bnoordhuis/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/bnoordhuis/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bnoordhuis/io.js/labels{/name}","releases_url":"https://api.github.com/repos/bnoordhuis/io.js/releases{/id}","created_at":"2014-12-04T21:15:25Z","updated_at":"2014-12-30T16:28:26Z","pushed_at":"2015-03-16T11:43:07Z","git_url":"git://github.com/bnoordhuis/io.js.git","ssh_url":"git@github.com:bnoordhuis/io.js.git","clone_url":"https://github.com/bnoordhuis/io.js.git","svn_url":"https://github.com/bnoordhuis/io.js","homepage":null,"size":122194,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"v0.12"}},"base":{"label":"iojs:v1.x","ref":"v1.x","sha":"7bde3f1a8f53d82992a8fed73e5f93159bb400b3","user":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"io.js","full_name":"iojs/io.js","owner":{"login":"iojs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/iojs","html_url":"https://github.com/iojs","followers_url":"https://api.github.com/users/iojs/followers","following_url":"https://api.github.com/users/iojs/following{/other_user}","gists_url":"https://api.github.com/users/iojs/gists{/gist_id}","starred_url":"https://api.github.com/users/iojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iojs/subscriptions","organizations_url":"https://api.github.com/users/iojs/orgs","repos_url":"https://api.github.com/users/iojs/repos","events_url":"https://api.github.com/users/iojs/events{/privacy}","received_events_url":"https://api.github.com/users/iojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iojs/io.js","description":"A friendly fork of Node.js with an open governance model","fork":false,"url":"https://api.github.com/repos/iojs/io.js","forks_url":"https://api.github.com/repos/iojs/io.js/forks","keys_url":"https://api.github.com/repos/iojs/io.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iojs/io.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iojs/io.js/teams","hooks_url":"https://api.github.com/repos/iojs/io.js/hooks","issue_events_url":"https://api.github.com/repos/iojs/io.js/issues/events{/number}","events_url":"https://api.github.com/repos/iojs/io.js/events","assignees_url":"https://api.github.com/repos/iojs/io.js/assignees{/user}","branches_url":"https://api.github.com/repos/iojs/io.js/branches{/branch}","tags_url":"https://api.github.com/repos/iojs/io.js/tags","blobs_url":"https://api.github.com/repos/iojs/io.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iojs/io.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iojs/io.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iojs/io.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iojs/io.js/statuses/{sha}","languages_url":"https://api.github.com/repos/iojs/io.js/languages","stargazers_url":"https://api.github.com/repos/iojs/io.js/stargazers","contributors_url":"https://api.github.com/repos/iojs/io.js/contributors","subscribers_url":"https://api.github.com/repos/iojs/io.js/subscribers","subscription_url":"https://api.github.com/repos/iojs/io.js/subscription","commits_url":"https://api.github.com/repos/iojs/io.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iojs/io.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iojs/io.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iojs/io.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/iojs/io.js/contents/{+path}","compare_url":"https://api.github.com/repos/iojs/io.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iojs/io.js/merges","archive_url":"https://api.github.com/repos/iojs/io.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iojs/io.js/downloads","issues_url":"https://api.github.com/repos/iojs/io.js/issues{/number}","pulls_url":"https://api.github.com/repos/iojs/io.js/pulls{/number}","milestones_url":"https://api.github.com/repos/iojs/io.js/milestones{/number}","notifications_url":"https://api.github.com/repos/iojs/io.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iojs/io.js/labels{/name}","releases_url":"https://api.github.com/repos/iojs/io.js/releases{/id}","created_at":"2014-11-26T19:57:11Z","updated_at":"2015-03-16T16:51:37Z","pushed_at":"2015-03-16T16:51:35Z","git_url":"git://github.com/iojs/io.js.git","ssh_url":"git@github.com:iojs/io.js.git","clone_url":"https://github.com/iojs/io.js.git","svn_url":"https://github.com/iojs/io.js","homepage":"https://iojs.org","size":155012,"stargazers_count":11096,"watchers_count":11096,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":723,"mirror_url":null,"open_issues_count":194,"forks":723,"open_issues":194,"watchers":11096,"default_branch":"v1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1148"},"html":{"href":"https://github.com/iojs/io.js/pull/1148"},"issue":{"href":"https://api.github.com/repos/iojs/io.js/issues/1148"},"comments":{"href":"https://api.github.com/repos/iojs/io.js/issues/1148/comments"},"review_comments":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1148/comments"},"review_comment":{"href":"https://api.github.com/repos/iojs/io.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iojs/io.js/pulls/1148/commits"},"statuses":{"href":"https://api.github.com/repos/iojs/io.js/statuses/12f2fc97d941798caddb59b13c686906aad6c35a"}}}}