{"action":"closed","number":261,"pull_request":{"url":"https://api.github.com/repos/kbengine/kbengine/pulls/261","id":47881209,"html_url":"https://github.com/kbengine/kbengine/pull/261","diff_url":"https://github.com/kbengine/kbengine/pull/261.diff","patch_url":"https://github.com/kbengine/kbengine/pull/261.patch","issue_url":"https://api.github.com/repos/kbengine/kbengine/issues/261","number":261,"state":"closed","locked":false,"title":"fix error: logical not is only applied to the left hand side of compa…","user":{"login":"sdayu","id":701076,"avatar_url":"https://avatars.githubusercontent.com/u/701076?v=3","gravatar_id":"","url":"https://api.github.com/users/sdayu","html_url":"https://github.com/sdayu","followers_url":"https://api.github.com/users/sdayu/followers","following_url":"https://api.github.com/users/sdayu/following{/other_user}","gists_url":"https://api.github.com/users/sdayu/gists{/gist_id}","starred_url":"https://api.github.com/users/sdayu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdayu/subscriptions","organizations_url":"https://api.github.com/users/sdayu/orgs","repos_url":"https://api.github.com/users/sdayu/repos","events_url":"https://api.github.com/users/sdayu/events{/privacy}","received_events_url":"https://api.github.com/users/sdayu/received_events","type":"User","site_admin":false},"body":"change code for g++ 5.2.1, logical not is only applied to the left hand side of comparison.\r\n\r\nmailer.cpp: In member function ‘jwsmtp::mailer::Address jwsmtp::mailer::parseaddress(const string&)’:\r\nmailer.cpp:1210:33: error: logical not is only applied to the left hand side of comparison [-Werror=logical-not-parentheses]\r\n    if(!addresstoparse.find(\"@\") == std::string::npos) {\r\n                                 ^\r\ncc1plus: all warnings being treated as errors\r\n/home/boatkrap/src/kbengine/kbe/src/build/common.mak:543: recipe for target 'Hybrid64/mailer.o' failed\r\nmake[2]: *** [Hybrid64/mailer.o] Error 1\r\nmake[2]: Leaving directory '/home/boatkrap/src/kbengine/kbe/src/lib/dependencies/jwsmtp/jwsmtp/jwsmtp'\r\nMakefile:22: recipe for target 'all' failed\r\nmake[1]: *** [all] Error 2\r\nmake[1]: Leaving directory '/home/boatkrap/src/kbengine/kbe/src/lib'\r\nMakefile:7: recipe for target 'all' failed\r\nmake: *** [all] Error 2","created_at":"2015-10-16T08:04:32Z","updated_at":"2015-10-27T08:44:21Z","closed_at":"2015-10-27T08:44:21Z","merged_at":"2015-10-27T08:44:21Z","merge_commit_sha":"f9e3292db9a959e15e33140091515d844352c9df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kbengine/kbengine/pulls/261/commits","review_comments_url":"https://api.github.com/repos/kbengine/kbengine/pulls/261/comments","review_comment_url":"https://api.github.com/repos/kbengine/kbengine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbengine/kbengine/issues/261/comments","statuses_url":"https://api.github.com/repos/kbengine/kbengine/statuses/b5b6b492a3b95df3ec0e103fb642e24b616e1610","head":{"label":"sdayu:master","ref":"master","sha":"b5b6b492a3b95df3ec0e103fb642e24b616e1610","user":{"login":"sdayu","id":701076,"avatar_url":"https://avatars.githubusercontent.com/u/701076?v=3","gravatar_id":"","url":"https://api.github.com/users/sdayu","html_url":"https://github.com/sdayu","followers_url":"https://api.github.com/users/sdayu/followers","following_url":"https://api.github.com/users/sdayu/following{/other_user}","gists_url":"https://api.github.com/users/sdayu/gists{/gist_id}","starred_url":"https://api.github.com/users/sdayu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdayu/subscriptions","organizations_url":"https://api.github.com/users/sdayu/orgs","repos_url":"https://api.github.com/users/sdayu/repos","events_url":"https://api.github.com/users/sdayu/events{/privacy}","received_events_url":"https://api.github.com/users/sdayu/received_events","type":"User","site_admin":false},"repo":{"id":44368202,"name":"kbengine","full_name":"sdayu/kbengine","owner":{"login":"sdayu","id":701076,"avatar_url":"https://avatars.githubusercontent.com/u/701076?v=3","gravatar_id":"","url":"https://api.github.com/users/sdayu","html_url":"https://github.com/sdayu","followers_url":"https://api.github.com/users/sdayu/followers","following_url":"https://api.github.com/users/sdayu/following{/other_user}","gists_url":"https://api.github.com/users/sdayu/gists{/gist_id}","starred_url":"https://api.github.com/users/sdayu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdayu/subscriptions","organizations_url":"https://api.github.com/users/sdayu/orgs","repos_url":"https://api.github.com/users/sdayu/repos","events_url":"https://api.github.com/users/sdayu/events{/privacy}","received_events_url":"https://api.github.com/users/sdayu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sdayu/kbengine","description":"A MMOG engine of server.","fork":true,"url":"https://api.github.com/repos/sdayu/kbengine","forks_url":"https://api.github.com/repos/sdayu/kbengine/forks","keys_url":"https://api.github.com/repos/sdayu/kbengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdayu/kbengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdayu/kbengine/teams","hooks_url":"https://api.github.com/repos/sdayu/kbengine/hooks","issue_events_url":"https://api.github.com/repos/sdayu/kbengine/issues/events{/number}","events_url":"https://api.github.com/repos/sdayu/kbengine/events","assignees_url":"https://api.github.com/repos/sdayu/kbengine/assignees{/user}","branches_url":"https://api.github.com/repos/sdayu/kbengine/branches{/branch}","tags_url":"https://api.github.com/repos/sdayu/kbengine/tags","blobs_url":"https://api.github.com/repos/sdayu/kbengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdayu/kbengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdayu/kbengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdayu/kbengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdayu/kbengine/statuses/{sha}","languages_url":"https://api.github.com/repos/sdayu/kbengine/languages","stargazers_url":"https://api.github.com/repos/sdayu/kbengine/stargazers","contributors_url":"https://api.github.com/repos/sdayu/kbengine/contributors","subscribers_url":"https://api.github.com/repos/sdayu/kbengine/subscribers","subscription_url":"https://api.github.com/repos/sdayu/kbengine/subscription","commits_url":"https://api.github.com/repos/sdayu/kbengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdayu/kbengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdayu/kbengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdayu/kbengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdayu/kbengine/contents/{+path}","compare_url":"https://api.github.com/repos/sdayu/kbengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdayu/kbengine/merges","archive_url":"https://api.github.com/repos/sdayu/kbengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdayu/kbengine/downloads","issues_url":"https://api.github.com/repos/sdayu/kbengine/issues{/number}","pulls_url":"https://api.github.com/repos/sdayu/kbengine/pulls{/number}","milestones_url":"https://api.github.com/repos/sdayu/kbengine/milestones{/number}","notifications_url":"https://api.github.com/repos/sdayu/kbengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdayu/kbengine/labels{/name}","releases_url":"https://api.github.com/repos/sdayu/kbengine/releases{/id}","created_at":"2015-10-16T07:03:32Z","updated_at":"2015-10-16T07:04:35Z","pushed_at":"2015-10-16T08:01:37Z","git_url":"git://github.com/sdayu/kbengine.git","ssh_url":"git@github.com:sdayu/kbengine.git","clone_url":"https://github.com/sdayu/kbengine.git","svn_url":"https://github.com/sdayu/kbengine","homepage":"http://www.kbengine.org","size":219295,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kbengine:master","ref":"master","sha":"0d2625256d9edfa6641b58b55728898b11453431","user":{"login":"kbengine","id":2336717,"avatar_url":"https://avatars.githubusercontent.com/u/2336717?v=3","gravatar_id":"","url":"https://api.github.com/users/kbengine","html_url":"https://github.com/kbengine","followers_url":"https://api.github.com/users/kbengine/followers","following_url":"https://api.github.com/users/kbengine/following{/other_user}","gists_url":"https://api.github.com/users/kbengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kbengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbengine/subscriptions","organizations_url":"https://api.github.com/users/kbengine/orgs","repos_url":"https://api.github.com/users/kbengine/repos","events_url":"https://api.github.com/users/kbengine/events{/privacy}","received_events_url":"https://api.github.com/users/kbengine/received_events","type":"User","site_admin":false},"repo":{"id":16907474,"name":"kbengine","full_name":"kbengine/kbengine","owner":{"login":"kbengine","id":2336717,"avatar_url":"https://avatars.githubusercontent.com/u/2336717?v=3","gravatar_id":"","url":"https://api.github.com/users/kbengine","html_url":"https://github.com/kbengine","followers_url":"https://api.github.com/users/kbengine/followers","following_url":"https://api.github.com/users/kbengine/following{/other_user}","gists_url":"https://api.github.com/users/kbengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kbengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbengine/subscriptions","organizations_url":"https://api.github.com/users/kbengine/orgs","repos_url":"https://api.github.com/users/kbengine/repos","events_url":"https://api.github.com/users/kbengine/events{/privacy}","received_events_url":"https://api.github.com/users/kbengine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbengine/kbengine","description":"A MMOG engine of server.","fork":false,"url":"https://api.github.com/repos/kbengine/kbengine","forks_url":"https://api.github.com/repos/kbengine/kbengine/forks","keys_url":"https://api.github.com/repos/kbengine/kbengine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbengine/kbengine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbengine/kbengine/teams","hooks_url":"https://api.github.com/repos/kbengine/kbengine/hooks","issue_events_url":"https://api.github.com/repos/kbengine/kbengine/issues/events{/number}","events_url":"https://api.github.com/repos/kbengine/kbengine/events","assignees_url":"https://api.github.com/repos/kbengine/kbengine/assignees{/user}","branches_url":"https://api.github.com/repos/kbengine/kbengine/branches{/branch}","tags_url":"https://api.github.com/repos/kbengine/kbengine/tags","blobs_url":"https://api.github.com/repos/kbengine/kbengine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbengine/kbengine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbengine/kbengine/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbengine/kbengine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbengine/kbengine/statuses/{sha}","languages_url":"https://api.github.com/repos/kbengine/kbengine/languages","stargazers_url":"https://api.github.com/repos/kbengine/kbengine/stargazers","contributors_url":"https://api.github.com/repos/kbengine/kbengine/contributors","subscribers_url":"https://api.github.com/repos/kbengine/kbengine/subscribers","subscription_url":"https://api.github.com/repos/kbengine/kbengine/subscription","commits_url":"https://api.github.com/repos/kbengine/kbengine/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbengine/kbengine/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbengine/kbengine/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbengine/kbengine/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbengine/kbengine/contents/{+path}","compare_url":"https://api.github.com/repos/kbengine/kbengine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbengine/kbengine/merges","archive_url":"https://api.github.com/repos/kbengine/kbengine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbengine/kbengine/downloads","issues_url":"https://api.github.com/repos/kbengine/kbengine/issues{/number}","pulls_url":"https://api.github.com/repos/kbengine/kbengine/pulls{/number}","milestones_url":"https://api.github.com/repos/kbengine/kbengine/milestones{/number}","notifications_url":"https://api.github.com/repos/kbengine/kbengine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbengine/kbengine/labels{/name}","releases_url":"https://api.github.com/repos/kbengine/kbengine/releases{/id}","created_at":"2014-02-17T09:12:15Z","updated_at":"2015-10-27T08:07:26Z","pushed_at":"2015-10-27T08:44:22Z","git_url":"git://github.com/kbengine/kbengine.git","ssh_url":"git@github.com:kbengine/kbengine.git","clone_url":"https://github.com/kbengine/kbengine.git","svn_url":"https://github.com/kbengine/kbengine","homepage":"http://www.kbengine.org","size":309208,"stargazers_count":861,"watchers_count":861,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":750,"mirror_url":null,"open_issues_count":26,"forks":750,"open_issues":26,"watchers":861,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbengine/kbengine/pulls/261"},"html":{"href":"https://github.com/kbengine/kbengine/pull/261"},"issue":{"href":"https://api.github.com/repos/kbengine/kbengine/issues/261"},"comments":{"href":"https://api.github.com/repos/kbengine/kbengine/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/kbengine/kbengine/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/kbengine/kbengine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbengine/kbengine/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/kbengine/kbengine/statuses/b5b6b492a3b95df3ec0e103fb642e24b616e1610"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kbengine","id":2336717,"avatar_url":"https://avatars.githubusercontent.com/u/2336717?v=3","gravatar_id":"","url":"https://api.github.com/users/kbengine","html_url":"https://github.com/kbengine","followers_url":"https://api.github.com/users/kbengine/followers","following_url":"https://api.github.com/users/kbengine/following{/other_user}","gists_url":"https://api.github.com/users/kbengine/gists{/gist_id}","starred_url":"https://api.github.com/users/kbengine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbengine/subscriptions","organizations_url":"https://api.github.com/users/kbengine/orgs","repos_url":"https://api.github.com/users/kbengine/repos","events_url":"https://api.github.com/users/kbengine/events{/privacy}","received_events_url":"https://api.github.com/users/kbengine/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}