{"action":"created","issue":{"url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/issues/11","labels_url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/issues/11/comments","events_url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/issues/11/events","html_url":"https://github.com/pixiv/pixiv-novel-parser/pull/11","id":94326344,"number":11,"title":"Improve modulability (and Browserify friendly)","user":{"login":"hakatashi","id":3126484,"avatar_url":"https://avatars.githubusercontent.com/u/3126484?v=3","gravatar_id":"","url":"https://api.github.com/users/hakatashi","html_url":"https://github.com/hakatashi","followers_url":"https://api.github.com/users/hakatashi/followers","following_url":"https://api.github.com/users/hakatashi/following{/other_user}","gists_url":"https://api.github.com/users/hakatashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hakatashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakatashi/subscriptions","organizations_url":"https://api.github.com/users/hakatashi/orgs","repos_url":"https://api.github.com/users/hakatashi/repos","events_url":"https://api.github.com/users/hakatashi/events{/privacy}","received_events_url":"https://api.github.com/users/hakatashi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-10T15:14:08Z","updated_at":"2015-07-10T15:20:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/pulls/11","html_url":"https://github.com/pixiv/pixiv-novel-parser/pull/11","diff_url":"https://github.com/pixiv/pixiv-novel-parser/pull/11.diff","patch_url":"https://github.com/pixiv/pixiv-novel-parser/pull/11.patch"},"body":"In the browser environment, the current code always routes it to avoid require()ing modules and exports `PixivNovelParser` as global variable. It's handy in sharing totally the same codes between browser and node.js, but somewhat less of modulability to export a functionality. Also the module loading from Browserify doesn't work.\r\n\r\nHereby I discarded all the ability to detect the browser environment from the main code and introduced gulp-browserify to generate browser-side package. Browser detection has moved to [src/global.js](src/global.js), which is only loaded from this package."},"comment":{"url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/issues/comments/120434974","html_url":"https://github.com/pixiv/pixiv-novel-parser/pull/11#issuecomment-120434974","issue_url":"https://api.github.com/repos/pixiv/pixiv-novel-parser/issues/11","id":120434974,"user":{"login":"hakatashi","id":3126484,"avatar_url":"https://avatars.githubusercontent.com/u/3126484?v=3","gravatar_id":"","url":"https://api.github.com/users/hakatashi","html_url":"https://github.com/hakatashi","followers_url":"https://api.github.com/users/hakatashi/followers","following_url":"https://api.github.com/users/hakatashi/following{/other_user}","gists_url":"https://api.github.com/users/hakatashi/gists{/gist_id}","starred_url":"https://api.github.com/users/hakatashi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakatashi/subscriptions","organizations_url":"https://api.github.com/users/hakatashi/orgs","repos_url":"https://api.github.com/users/hakatashi/repos","events_url":"https://api.github.com/users/hakatashi/events{/privacy}","received_events_url":"https://api.github.com/users/hakatashi/received_events","type":"User","site_admin":false},"created_at":"2015-07-10T15:20:53Z","updated_at":"2015-07-10T15:20:53Z","body":"よく考えたら英語で書く必要なかった……"}}