{"action":"closed","number":1751,"pull_request":{"url":"https://api.github.com/repos/wp-cli/wp-cli/pulls/1751","id":32944163,"html_url":"https://github.com/wp-cli/wp-cli/pull/1751","diff_url":"https://github.com/wp-cli/wp-cli/pull/1751.diff","patch_url":"https://github.com/wp-cli/wp-cli/pull/1751.patch","issue_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/1751","number":1751,"state":"closed","locked":false,"title":"[fix #1703] Find the right token to modify wp-config.php","user":{"login":"Fab1en","id":1143066,"avatar_url":"https://avatars.githubusercontent.com/u/1143066?v=3","gravatar_id":"","url":"https://api.github.com/users/Fab1en","html_url":"https://github.com/Fab1en","followers_url":"https://api.github.com/users/Fab1en/followers","following_url":"https://api.github.com/users/Fab1en/following{/other_user}","gists_url":"https://api.github.com/users/Fab1en/gists{/gist_id}","starred_url":"https://api.github.com/users/Fab1en/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fab1en/subscriptions","organizations_url":"https://api.github.com/users/Fab1en/orgs","repos_url":"https://api.github.com/users/Fab1en/repos","events_url":"https://api.github.com/users/Fab1en/events{/privacy}","received_events_url":"https://api.github.com/users/Fab1en/received_events","type":"User","site_admin":false},"body":"The comments in `wp-config.php` file are translated in the user language language in localized versions, so we cannot rely on it to modify the file content.\r\nThe fix look into the `wp-config-sample.php` file for the right token to search in the `wp-config.php` file.\r\n\r\nThere is perhaps more work to do on the method to find the `wp-config-sample.php` file path. Unit tests could also be updated to test this case. Finally, some simple checks could be added to the found `$token` to avoid silent failure. \r\n\r\nSee #1703 ","created_at":"2015-04-09T10:44:25Z","updated_at":"2015-09-03T13:00:10Z","closed_at":"2015-09-03T13:00:10Z","merged_at":null,"merge_commit_sha":"fe122a91867b4b58de7d03724fa65cea35b888ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wp-cli/wp-cli/pulls/1751/commits","review_comments_url":"https://api.github.com/repos/wp-cli/wp-cli/pulls/1751/comments","review_comment_url":"https://api.github.com/repos/wp-cli/wp-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/1751/comments","statuses_url":"https://api.github.com/repos/wp-cli/wp-cli/statuses/f8f920e065e57e5e118f333a0006fcb7d91f0d48","head":{"label":"1nterval:fix_1703_modify_wp-config_non_english","ref":"fix_1703_modify_wp-config_non_english","sha":"f8f920e065e57e5e118f333a0006fcb7d91f0d48","user":{"login":"1nterval","id":2494471,"avatar_url":"https://avatars.githubusercontent.com/u/2494471?v=3","gravatar_id":"","url":"https://api.github.com/users/1nterval","html_url":"https://github.com/1nterval","followers_url":"https://api.github.com/users/1nterval/followers","following_url":"https://api.github.com/users/1nterval/following{/other_user}","gists_url":"https://api.github.com/users/1nterval/gists{/gist_id}","starred_url":"https://api.github.com/users/1nterval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1nterval/subscriptions","organizations_url":"https://api.github.com/users/1nterval/orgs","repos_url":"https://api.github.com/users/1nterval/repos","events_url":"https://api.github.com/users/1nterval/events{/privacy}","received_events_url":"https://api.github.com/users/1nterval/received_events","type":"Organization","site_admin":false},"repo":{"id":33661965,"name":"wp-cli","full_name":"1nterval/wp-cli","owner":{"login":"1nterval","id":2494471,"avatar_url":"https://avatars.githubusercontent.com/u/2494471?v=3","gravatar_id":"","url":"https://api.github.com/users/1nterval","html_url":"https://github.com/1nterval","followers_url":"https://api.github.com/users/1nterval/followers","following_url":"https://api.github.com/users/1nterval/following{/other_user}","gists_url":"https://api.github.com/users/1nterval/gists{/gist_id}","starred_url":"https://api.github.com/users/1nterval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1nterval/subscriptions","organizations_url":"https://api.github.com/users/1nterval/orgs","repos_url":"https://api.github.com/users/1nterval/repos","events_url":"https://api.github.com/users/1nterval/events{/privacy}","received_events_url":"https://api.github.com/users/1nterval/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/1nterval/wp-cli","description":"A command line interface for WordPress","fork":true,"url":"https://api.github.com/repos/1nterval/wp-cli","forks_url":"https://api.github.com/repos/1nterval/wp-cli/forks","keys_url":"https://api.github.com/repos/1nterval/wp-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/1nterval/wp-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/1nterval/wp-cli/teams","hooks_url":"https://api.github.com/repos/1nterval/wp-cli/hooks","issue_events_url":"https://api.github.com/repos/1nterval/wp-cli/issues/events{/number}","events_url":"https://api.github.com/repos/1nterval/wp-cli/events","assignees_url":"https://api.github.com/repos/1nterval/wp-cli/assignees{/user}","branches_url":"https://api.github.com/repos/1nterval/wp-cli/branches{/branch}","tags_url":"https://api.github.com/repos/1nterval/wp-cli/tags","blobs_url":"https://api.github.com/repos/1nterval/wp-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/1nterval/wp-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/1nterval/wp-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/1nterval/wp-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/1nterval/wp-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/1nterval/wp-cli/languages","stargazers_url":"https://api.github.com/repos/1nterval/wp-cli/stargazers","contributors_url":"https://api.github.com/repos/1nterval/wp-cli/contributors","subscribers_url":"https://api.github.com/repos/1nterval/wp-cli/subscribers","subscription_url":"https://api.github.com/repos/1nterval/wp-cli/subscription","commits_url":"https://api.github.com/repos/1nterval/wp-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/1nterval/wp-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/1nterval/wp-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/1nterval/wp-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/1nterval/wp-cli/contents/{+path}","compare_url":"https://api.github.com/repos/1nterval/wp-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/1nterval/wp-cli/merges","archive_url":"https://api.github.com/repos/1nterval/wp-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/1nterval/wp-cli/downloads","issues_url":"https://api.github.com/repos/1nterval/wp-cli/issues{/number}","pulls_url":"https://api.github.com/repos/1nterval/wp-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/1nterval/wp-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/1nterval/wp-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/1nterval/wp-cli/labels{/name}","releases_url":"https://api.github.com/repos/1nterval/wp-cli/releases{/id}","created_at":"2015-04-09T10:03:27Z","updated_at":"2015-04-09T10:03:28Z","pushed_at":"2015-04-09T10:39:48Z","git_url":"git://github.com/1nterval/wp-cli.git","ssh_url":"git@github.com:1nterval/wp-cli.git","clone_url":"https://github.com/1nterval/wp-cli.git","svn_url":"https://github.com/1nterval/wp-cli","homepage":"http://wp-cli.org/","size":5905,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wp-cli:master","ref":"master","sha":"512ad36c905f2802f5a4f7ea05bb814e39eaf966","user":{"login":"wp-cli","id":1570774,"avatar_url":"https://avatars.githubusercontent.com/u/1570774?v=3","gravatar_id":"","url":"https://api.github.com/users/wp-cli","html_url":"https://github.com/wp-cli","followers_url":"https://api.github.com/users/wp-cli/followers","following_url":"https://api.github.com/users/wp-cli/following{/other_user}","gists_url":"https://api.github.com/users/wp-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/wp-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wp-cli/subscriptions","organizations_url":"https://api.github.com/users/wp-cli/orgs","repos_url":"https://api.github.com/users/wp-cli/repos","events_url":"https://api.github.com/users/wp-cli/events{/privacy}","received_events_url":"https://api.github.com/users/wp-cli/received_events","type":"Organization","site_admin":false},"repo":{"id":2360755,"name":"wp-cli","full_name":"wp-cli/wp-cli","owner":{"login":"wp-cli","id":1570774,"avatar_url":"https://avatars.githubusercontent.com/u/1570774?v=3","gravatar_id":"","url":"https://api.github.com/users/wp-cli","html_url":"https://github.com/wp-cli","followers_url":"https://api.github.com/users/wp-cli/followers","following_url":"https://api.github.com/users/wp-cli/following{/other_user}","gists_url":"https://api.github.com/users/wp-cli/gists{/gist_id}","starred_url":"https://api.github.com/users/wp-cli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wp-cli/subscriptions","organizations_url":"https://api.github.com/users/wp-cli/orgs","repos_url":"https://api.github.com/users/wp-cli/repos","events_url":"https://api.github.com/users/wp-cli/events{/privacy}","received_events_url":"https://api.github.com/users/wp-cli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wp-cli/wp-cli","description":"A command line interface for WordPress","fork":false,"url":"https://api.github.com/repos/wp-cli/wp-cli","forks_url":"https://api.github.com/repos/wp-cli/wp-cli/forks","keys_url":"https://api.github.com/repos/wp-cli/wp-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wp-cli/wp-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wp-cli/wp-cli/teams","hooks_url":"https://api.github.com/repos/wp-cli/wp-cli/hooks","issue_events_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/events{/number}","events_url":"https://api.github.com/repos/wp-cli/wp-cli/events","assignees_url":"https://api.github.com/repos/wp-cli/wp-cli/assignees{/user}","branches_url":"https://api.github.com/repos/wp-cli/wp-cli/branches{/branch}","tags_url":"https://api.github.com/repos/wp-cli/wp-cli/tags","blobs_url":"https://api.github.com/repos/wp-cli/wp-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wp-cli/wp-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wp-cli/wp-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/wp-cli/wp-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wp-cli/wp-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/wp-cli/wp-cli/languages","stargazers_url":"https://api.github.com/repos/wp-cli/wp-cli/stargazers","contributors_url":"https://api.github.com/repos/wp-cli/wp-cli/contributors","subscribers_url":"https://api.github.com/repos/wp-cli/wp-cli/subscribers","subscription_url":"https://api.github.com/repos/wp-cli/wp-cli/subscription","commits_url":"https://api.github.com/repos/wp-cli/wp-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/wp-cli/wp-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/wp-cli/wp-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/wp-cli/wp-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/wp-cli/wp-cli/contents/{+path}","compare_url":"https://api.github.com/repos/wp-cli/wp-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wp-cli/wp-cli/merges","archive_url":"https://api.github.com/repos/wp-cli/wp-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wp-cli/wp-cli/downloads","issues_url":"https://api.github.com/repos/wp-cli/wp-cli/issues{/number}","pulls_url":"https://api.github.com/repos/wp-cli/wp-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/wp-cli/wp-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/wp-cli/wp-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wp-cli/wp-cli/labels{/name}","releases_url":"https://api.github.com/repos/wp-cli/wp-cli/releases{/id}","created_at":"2011-09-10T12:51:59Z","updated_at":"2015-09-01T11:21:56Z","pushed_at":"2015-09-03T12:58:30Z","git_url":"git://github.com/wp-cli/wp-cli.git","ssh_url":"git@github.com:wp-cli/wp-cli.git","clone_url":"https://github.com/wp-cli/wp-cli.git","svn_url":"https://github.com/wp-cli/wp-cli","homepage":"http://wp-cli.org/","size":17170,"stargazers_count":2248,"watchers_count":2248,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":467,"mirror_url":null,"open_issues_count":155,"forks":467,"open_issues":155,"watchers":2248,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wp-cli/wp-cli/pulls/1751"},"html":{"href":"https://github.com/wp-cli/wp-cli/pull/1751"},"issue":{"href":"https://api.github.com/repos/wp-cli/wp-cli/issues/1751"},"comments":{"href":"https://api.github.com/repos/wp-cli/wp-cli/issues/1751/comments"},"review_comments":{"href":"https://api.github.com/repos/wp-cli/wp-cli/pulls/1751/comments"},"review_comment":{"href":"https://api.github.com/repos/wp-cli/wp-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wp-cli/wp-cli/pulls/1751/commits"},"statuses":{"href":"https://api.github.com/repos/wp-cli/wp-cli/statuses/f8f920e065e57e5e118f333a0006fcb7d91f0d48"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":2,"commits":1,"additions":24,"deletions":1,"changed_files":2}}