{"push_id":739249876,"size":9,"distinct_size":9,"ref":"refs/heads/master","head":"37e2b7b85bdd244059630eb1131b147c71cd1340","before":"b6cc488d561ad8008e80a60c5bda82392ab05cfe","commits":[{"sha":"99093881718d17eaf4119ea74a310f20d9d07157","author":{"email":"50c461d782bf45c44b515a61b2705ea60d47d0cd@redhat.com","name":"Vikhyat Umrao"},"message":"rbd: use image-spec and snap-spec in rbd help\n\nThis patch changes image-name instances to image-spec and snap-name\ninstances to snap-spec to try to clarify usage for some commands and\ndisambiguate the term {image,snap}-name, which has been used to denote\nboth simple names and compound names (specs).\n\n<image-spec> is [<pool-name>]/<image-name>\n<snap-spec> is [<pool-name>]/<image-name>@<snap-name>\n\nThis patch also removes duplicate checks for image-name and snap-name.\n\nSigned-off-by: Vikhyat Umrao <vumrao@redhat.com>\n[idryomov@gmail.com: some commands take either image-spec or snap-spec,\nother fixes, formatting, changelog]\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/99093881718d17eaf4119ea74a310f20d9d07157"},{"sha":"76989cc4aef1e14b1466b3c7644e2453515dc946","author":{"email":"152d4c5bebf13a5b809d42b4d789cf9d887e6698@gmail.com","name":"Ilya Dryomov"},"message":"doc: use spec syntax in rbd docs\n\nUse spec syntax instead of --pool, --image and --snap to hopefully push\npeople towards the former.\n\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/76989cc4aef1e14b1466b3c7644e2453515dc946"},{"sha":"bbc5c71284f978b41e64f8703c4288d04cff0d82","author":{"email":"152d4c5bebf13a5b809d42b4d789cf9d887e6698@gmail.com","name":"Ilya Dryomov"},"message":"rbd: import doesn't require image-spec arg, ditto for export and path\n\nMark those as such in help and clarify what image-spec defaults to.\n\nRelated, all command args in our man page are enclosed into brackets.\nI suppose the reason is that they are optional in the sense that you\ncan have commands like\n\n    $ rbd clone --pool a --image b --snap -c --dest-pool d --dest e\n\nwith no args.  Given that we are trying to push people towards\n\n    $ rbd clone a/b@c d/e\n\nundo that so that real optional arguments can be marked optional.\nWhile at it, add synopsis for each command and use backticks for\ndenoting commands more consistently.\n\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/bbc5c71284f978b41e64f8703c4288d04cff0d82"},{"sha":"b60e144cebc9f5f1916adbb7e43f67af4988699f","author":{"email":"152d4c5bebf13a5b809d42b4d789cf9d887e6698@gmail.com","name":"Ilya Dryomov"},"message":"rbd: error out if dest_snapname is specified\n\nNo command uses it as of now, but only clone command fails; cp, mv and\nimport simply ignore it.  Check if it's set and exit with a generic\nerror message.\n\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/b60e144cebc9f5f1916adbb7e43f67af4988699f"},{"sha":"7d65bd9bd1b00582b635be62771d960bde701028","author":{"email":"152d4c5bebf13a5b809d42b4d789cf9d887e6698@gmail.com","name":"Ilya Dryomov"},"message":"rbd: assorted cli arg parsing fixes\n\n- import-diff needs image-spec, yet OPT_IMPORT_DIFF was in the list of\n  commands that don't need imgname\n\n- check for lock id after imgname, so that if imgname isn't specified\n  we fail with imgname rather than lock id error message\n\n- error out if locker isn't specified\n\n- move feature-name validity check after imgname checks so that if\n  imgname is malformed we fail with imgname rather than feature error\n  message\n\n- error out if image-meta key or value isn't specified\n\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/7d65bd9bd1b00582b635be62771d960bde701028"},{"sha":"afbf90d5b5629edae9cac09e926fd6a783fa79ca","author":{"email":"152d4c5bebf13a5b809d42b4d789cf9d887e6698@gmail.com","name":"Ilya Dryomov"},"message":"rbd: du command should take spec as an argument\n\nChange du to take <image-spec> | <snap-spec> as an argument instead of\ngoing through --image option.  The new synopsis is\n\n    (du | disk-usage) [<image-spec> | <snap-spec>]\n\nThis is to make it look more like the rest of the commands: the only\nother command that takes pool as an argument is ls and it can't really\nserve as a prototype for du, because the latter has to work on images\nand snapshots as well.\n\nExamples:\n\n    # stats for pool rbd\n    $ rbd du\n    $ rbd -p rbd du\n\n    # stats for pool foo\n    $ rbd -p foo du\n\n    # stats for snapshot mysnap of image baz in pool rbd\n    $ rbd du baz@mysnap\n\n    # stats for image bar in pool foo\n    $ rbd du foo/bar\n\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/afbf90d5b5629edae9cac09e926fd6a783fa79ca"},{"sha":"17a3e4b969cc04e1977dac7eae0f08ddeadec57e","author":{"email":"152d4c5bebf13a5b809d42b4d789cf9d887e6698@gmail.com","name":"Ilya Dryomov"},"message":"rbd: rename --object-extents option to --whole-object\n\n--object-extents is a bit confusing - extent is generally something of\na varying length and here the meaning is \"diff whole objects\".  Rename\nit to --whole-object (the name of diff_iterate() parameter).\n\nSigned-off-by: Ilya Dryomov <idryomov@gmail.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/17a3e4b969cc04e1977dac7eae0f08ddeadec57e"},{"sha":"b2feeb7f3267b2ab0f9926f09f75caa786a29375","author":{"email":"1442af5e32b56bc0fa9c40ad9e4d67aeb05f1e26@redhat.com","name":"Josh Durgin"},"message":"Merge pull request #5352 from ceph/wip-rbd-help-specs\n\nrbd: cli help and arg parsing fixes\r\n\r\nReviewed-by: Jason Dillaman <dillaman@redhat.com>\r\nReviewed-by: Josh Durgin <jdurgin@redhat.com>","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/b2feeb7f3267b2ab0f9926f09f75caa786a29375"},{"sha":"37e2b7b85bdd244059630eb1131b147c71cd1340","author":{"email":"1442af5e32b56bc0fa9c40ad9e4d67aeb05f1e26@redhat.com","name":"Josh Durgin"},"message":"Merge remote-tracking branch 'origin/next'","distinct":true,"url":"https://api.github.com/repos/jschmid1/ceph/commits/37e2b7b85bdd244059630eb1131b147c71cd1340"}]}