{"action":"created","issue":{"url":"https://api.github.com/repos/opensagres/xdocreport/issues/63","labels_url":"https://api.github.com/repos/opensagres/xdocreport/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/opensagres/xdocreport/issues/63/comments","events_url":"https://api.github.com/repos/opensagres/xdocreport/issues/63/events","html_url":"https://github.com/opensagres/xdocreport/issues/63","id":102315403,"number":63,"title":"Versioning: Upgrade to upcoming iText 5.5.7","user":{"login":"blagae","id":8480167,"avatar_url":"https://avatars.githubusercontent.com/u/8480167?v=3","gravatar_id":"","url":"https://api.github.com/users/blagae","html_url":"https://github.com/blagae","followers_url":"https://api.github.com/users/blagae/followers","following_url":"https://api.github.com/users/blagae/following{/other_user}","gists_url":"https://api.github.com/users/blagae/gists{/gist_id}","starred_url":"https://api.github.com/users/blagae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blagae/subscriptions","organizations_url":"https://api.github.com/users/blagae/orgs","repos_url":"https://api.github.com/users/blagae/repos","events_url":"https://api.github.com/users/blagae/events{/privacy}","received_events_url":"https://api.github.com/users/blagae/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-21T07:17:01Z","updated_at":"2015-09-01T12:49:33Z","closed_at":null,"body":"I looked into building XDocReport with the latest version of iText 5, but it turns out that something changed in iText 5.4.2 that made the AbstractXWPFPOIConverterTest::AdvancedTable2 test in org.apache.poi.xwpf.converter.pdf.itext5 fail with a NullPointerException. I fixed this yesterday in iText with a simple null check, but another very recent commit on iText's develop branch (https://github.com/itext/itextpdf/commit/48b4e460a208c51257121ba877ec8a4bd3c2416f) made another test fail, namely AbstractODFDOMConverterTest::Issue247 in org.odftoolkit.converter.pdf.itext5 .\r\n\r\nTurns out that a new overloaded method was added in iText's PdfContentByte which isn't \"properly\" overridden in XDocReport's ExtendedPdfContentByte (because it can't access that method until iText releases another version). I have fixed that as well in XDocReport, but I can only push that commit after the release of iText 5.5.7 (tentatively scheduled for September 15th). Both fixes aren't in iText 5.5.6, of course, and will both be included in iText 5.5.7\r\n\r\n\r\nThis all means that XDocReport 1.0.5 won't build with any iText version higher than 5.4.1, and any versions of XDocReport after a pull request for this issue won't build with any iText version lower than 5.5.7. I don't have a lot of experience with versioning problems, so I have no idea what to do. Do you have any suggestions ?"},"comment":{"url":"https://api.github.com/repos/opensagres/xdocreport/issues/comments/136704807","html_url":"https://github.com/opensagres/xdocreport/issues/63#issuecomment-136704807","issue_url":"https://api.github.com/repos/opensagres/xdocreport/issues/63","id":136704807,"user":{"login":"blagae","id":8480167,"avatar_url":"https://avatars.githubusercontent.com/u/8480167?v=3","gravatar_id":"","url":"https://api.github.com/users/blagae","html_url":"https://github.com/blagae","followers_url":"https://api.github.com/users/blagae/followers","following_url":"https://api.github.com/users/blagae/following{/other_user}","gists_url":"https://api.github.com/users/blagae/gists{/gist_id}","starred_url":"https://api.github.com/users/blagae/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blagae/subscriptions","organizations_url":"https://api.github.com/users/blagae/orgs","repos_url":"https://api.github.com/users/blagae/repos","events_url":"https://api.github.com/users/blagae/events{/privacy}","received_events_url":"https://api.github.com/users/blagae/received_events","type":"User","site_admin":false},"created_at":"2015-09-01T12:49:33Z","updated_at":"2015-09-01T12:49:33Z","body":"I've investigated this, and it's impossible to use reflection because the call to the overridden method addImage() happens in iText itself. There is no way to tell iText to call the other overloaded method from outside, because all parameters come from internal calculations.\r\n\r\nSince I need a method that only occurs from iText 5.5.7 on, I need to put that version in the POM file anyway. So I think that it won't pose a problem, because older versions won't compile (this inheritance problem can't be fixed with reflection). Is it all right with you if we just force iText 5 users to go to the newest versions ? I don't see any downsides to that approach, but your opinion may vary."}}