{"action":"created","issue":{"url":"https://api.github.com/repos/bosun-monitor/bosun/issues/825","labels_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/825/labels{/name}","comments_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/825/comments","events_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/825/events","html_url":"https://github.com/bosun-monitor/bosun/issues/825","id":63771137,"number":825,"title":"Need Style and Conventions Doc","user":{"login":"kylebrandt","id":1692624,"avatar_url":"https://avatars.githubusercontent.com/u/1692624?v=3","gravatar_id":"","url":"https://api.github.com/users/kylebrandt","html_url":"https://github.com/kylebrandt","followers_url":"https://api.github.com/users/kylebrandt/followers","following_url":"https://api.github.com/users/kylebrandt/following{/other_user}","gists_url":"https://api.github.com/users/kylebrandt/gists{/gist_id}","starred_url":"https://api.github.com/users/kylebrandt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylebrandt/subscriptions","organizations_url":"https://api.github.com/users/kylebrandt/orgs","repos_url":"https://api.github.com/users/kylebrandt/repos","events_url":"https://api.github.com/users/kylebrandt/events{/privacy}","received_events_url":"https://api.github.com/users/kylebrandt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-23T16:44:11Z","updated_at":"2015-03-23T19:27:10Z","closed_at":null,"body":"We should have an md for committing. Would have things like:\r\n\r\n * PRs must be squashed before commit\r\n * Must be go fmt'd\r\n * Provide a description, unit, and type for all new metrics. Descriptions should not be in the Add line, but in another data structure or a constant (See keepalive collectors for the constants, and the memcached for a datastructure version.\r\n * Run esc when changing any html or js files\r\n * JS needs to be compiled from typescript.\r\n * Everything gets a code review before going into master \r\n\r\nThe reason for this is not waste anyone's time. Without this we waste our own time by having to keep telling people about these things, and we waste the time of the commiter by making them jump through unknown hoops."},"comment":{"url":"https://api.github.com/repos/bosun-monitor/bosun/issues/comments/85158356","html_url":"https://github.com/bosun-monitor/bosun/issues/825#issuecomment-85158356","issue_url":"https://api.github.com/repos/bosun-monitor/bosun/issues/825","id":85158356,"user":{"login":"mjibson","id":41181,"avatar_url":"https://avatars.githubusercontent.com/u/41181?v=3","gravatar_id":"","url":"https://api.github.com/users/mjibson","html_url":"https://github.com/mjibson","followers_url":"https://api.github.com/users/mjibson/followers","following_url":"https://api.github.com/users/mjibson/following{/other_user}","gists_url":"https://api.github.com/users/mjibson/gists{/gist_id}","starred_url":"https://api.github.com/users/mjibson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjibson/subscriptions","organizations_url":"https://api.github.com/users/mjibson/orgs","repos_url":"https://api.github.com/users/mjibson/repos","events_url":"https://api.github.com/users/mjibson/events{/privacy}","received_events_url":"https://api.github.com/users/mjibson/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T19:27:10Z","updated_at":"2015-03-23T19:27:10Z","body":"@Dieterbe esc has been fixed. `go get -u github.com/mjibson/esc` for the new one."}}