{"action":"created","issue":{"url":"https://api.github.com/repos/segmentio/analytics-ios/issues/485","labels_url":"https://api.github.com/repos/segmentio/analytics-ios/issues/485/labels{/name}","comments_url":"https://api.github.com/repos/segmentio/analytics-ios/issues/485/comments","events_url":"https://api.github.com/repos/segmentio/analytics-ios/issues/485/events","html_url":"https://github.com/segmentio/analytics-ios/pull/485","id":118824537,"number":485,"title":"[WIP] [Identify] Make Anonymous ID customisable.","user":{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-25T12:15:10Z","updated_at":"2015-11-25T15:54:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/segmentio/analytics-ios/pulls/485","html_url":"https://github.com/segmentio/analytics-ios/pull/485","diff_url":"https://github.com/segmentio/analytics-ios/pull/485.diff","patch_url":"https://github.com/segmentio/analytics-ios/pull/485.patch"},"body":"This is a first stab at making the Anonymous ID customisable, as asked about in #482. Some more background can be found in [this PR](https://github.com/artsy/eigen/pull/958) on our app.\r\n\r\nThis is very much a work in progress, I did the bare minimum to get _what we needed_ to work, so now I’m looking for feedback on:\r\n\r\n* Is adding this feature conceptually ok?\r\n* Would you prefer I refactor the `-getAnonymousId:` code into e.g. the getter of the `anonymousId` property, or what is the style you’d prefer?\r\n* General code-style"},"comment":{"url":"https://api.github.com/repos/segmentio/analytics-ios/issues/comments/159649594","html_url":"https://github.com/segmentio/analytics-ios/pull/485#issuecomment-159649594","issue_url":"https://api.github.com/repos/segmentio/analytics-ios/issues/485","id":159649594,"user":{"login":"alloy","id":2320,"avatar_url":"https://avatars.githubusercontent.com/u/2320?v=3","gravatar_id":"","url":"https://api.github.com/users/alloy","html_url":"https://github.com/alloy","followers_url":"https://api.github.com/users/alloy/followers","following_url":"https://api.github.com/users/alloy/following{/other_user}","gists_url":"https://api.github.com/users/alloy/gists{/gist_id}","starred_url":"https://api.github.com/users/alloy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alloy/subscriptions","organizations_url":"https://api.github.com/users/alloy/orgs","repos_url":"https://api.github.com/users/alloy/repos","events_url":"https://api.github.com/users/alloy/events{/privacy}","received_events_url":"https://api.github.com/users/alloy/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T15:54:14Z","updated_at":"2015-11-25T15:54:14Z","body":"Nope, my only reason for asking it is purely to conform to your code base design ideas :)\r\n\r\nRegarding exposing it, I’m fine with either, but maybe for consistency a method like \r\n`-[SEGAnalytics identify:anonymousID:traits:options:]` would be better? Whatever you choose, let me know and I’ll wrap this patch up."}}