{"action":"created","comment":{"url":"https://api.github.com/repos/rancherio/python-agent/pulls/comments/30457808","id":30457808,"diff_hunk":"@@ -103,7 +103,11 @@ def _do_snapshot_backup(self, snapshot, storage_pool, progress):\n                                blockstore_uuid)\n         log.info(\"Backed up snapshot %s for volume %s\" % (\n             snapshot_uuid, volume_uuid))\n-        snapshot.data.fields['backup'] = True\n+        latest_snapshots_set = set([snapshot_uuid])","path":"cattle/plugins/volmgr/handler.py","position":5,"original_position":5,"commit_id":"bf1823ec24ec17014d14db700bf0de60f327447d","original_commit_id":"bf1823ec24ec17014d14db700bf0de60f327447d","user":{"login":"ibuildthecloud","id":1754002,"avatar_url":"https://avatars.githubusercontent.com/u/1754002?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuildthecloud","html_url":"https://github.com/ibuildthecloud","followers_url":"https://api.github.com/users/ibuildthecloud/followers","following_url":"https://api.github.com/users/ibuildthecloud/following{/other_user}","gists_url":"https://api.github.com/users/ibuildthecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuildthecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuildthecloud/subscriptions","organizations_url":"https://api.github.com/users/ibuildthecloud/orgs","repos_url":"https://api.github.com/users/ibuildthecloud/repos","events_url":"https://api.github.com/users/ibuildthecloud/events{/privacy}","received_events_url":"https://api.github.com/users/ibuildthecloud/received_events","type":"User","site_admin":false},"body":"What happens when you take 3 snapshots on a volume and they backup in parallel?  Is that possible?","created_at":"2015-05-16T03:02:24Z","updated_at":"2015-05-16T03:02:24Z","html_url":"https://github.com/rancherio/python-agent/pull/121#discussion_r30457808","pull_request_url":"https://api.github.com/repos/rancherio/python-agent/pulls/121","_links":{"self":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/comments/30457808"},"html":{"href":"https://github.com/rancherio/python-agent/pull/121#discussion_r30457808"},"pull_request":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/121"}}},"pull_request":{"url":"https://api.github.com/repos/rancherio/python-agent/pulls/121","id":35344639,"html_url":"https://github.com/rancherio/python-agent/pull/121","diff_url":"https://github.com/rancherio/python-agent/pull/121.diff","patch_url":"https://github.com/rancherio/python-agent/pull/121.patch","issue_url":"https://api.github.com/repos/rancherio/python-agent/issues/121","number":121,"state":"open","locked":false,"title":"snapshot: Only keep last snapshot in internal snapshots","user":{"login":"yasker","id":3344618,"avatar_url":"https://avatars.githubusercontent.com/u/3344618?v=3","gravatar_id":"","url":"https://api.github.com/users/yasker","html_url":"https://github.com/yasker","followers_url":"https://api.github.com/users/yasker/followers","following_url":"https://api.github.com/users/yasker/following{/other_user}","gists_url":"https://api.github.com/users/yasker/gists{/gist_id}","starred_url":"https://api.github.com/users/yasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasker/subscriptions","organizations_url":"https://api.github.com/users/yasker/orgs","repos_url":"https://api.github.com/users/yasker/repos","events_url":"https://api.github.com/users/yasker/events{/privacy}","received_events_url":"https://api.github.com/users/yasker/received_events","type":"User","site_admin":false},"body":"Only cleanup other snapshots when it's already backed up and not the last one\r\n\r\nAlso cleanup some leftovers.","created_at":"2015-05-13T16:22:08Z","updated_at":"2015-05-16T03:02:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83940a8bbd34d8a84802ddd646bdd7be05fb0e61","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rancherio/python-agent/pulls/121/commits","review_comments_url":"https://api.github.com/repos/rancherio/python-agent/pulls/121/comments","review_comment_url":"https://api.github.com/repos/rancherio/python-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancherio/python-agent/issues/121/comments","statuses_url":"https://api.github.com/repos/rancherio/python-agent/statuses/bf1823ec24ec17014d14db700bf0de60f327447d","head":{"label":"yasker:work","ref":"work","sha":"bf1823ec24ec17014d14db700bf0de60f327447d","user":{"login":"yasker","id":3344618,"avatar_url":"https://avatars.githubusercontent.com/u/3344618?v=3","gravatar_id":"","url":"https://api.github.com/users/yasker","html_url":"https://github.com/yasker","followers_url":"https://api.github.com/users/yasker/followers","following_url":"https://api.github.com/users/yasker/following{/other_user}","gists_url":"https://api.github.com/users/yasker/gists{/gist_id}","starred_url":"https://api.github.com/users/yasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasker/subscriptions","organizations_url":"https://api.github.com/users/yasker/orgs","repos_url":"https://api.github.com/users/yasker/repos","events_url":"https://api.github.com/users/yasker/events{/privacy}","received_events_url":"https://api.github.com/users/yasker/received_events","type":"User","site_admin":false},"repo":{"id":29788649,"name":"python-agent","full_name":"yasker/python-agent","owner":{"login":"yasker","id":3344618,"avatar_url":"https://avatars.githubusercontent.com/u/3344618?v=3","gravatar_id":"","url":"https://api.github.com/users/yasker","html_url":"https://github.com/yasker","followers_url":"https://api.github.com/users/yasker/followers","following_url":"https://api.github.com/users/yasker/following{/other_user}","gists_url":"https://api.github.com/users/yasker/gists{/gist_id}","starred_url":"https://api.github.com/users/yasker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yasker/subscriptions","organizations_url":"https://api.github.com/users/yasker/orgs","repos_url":"https://api.github.com/users/yasker/repos","events_url":"https://api.github.com/users/yasker/events{/privacy}","received_events_url":"https://api.github.com/users/yasker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yasker/python-agent","description":"Python agent for Rancher","fork":true,"url":"https://api.github.com/repos/yasker/python-agent","forks_url":"https://api.github.com/repos/yasker/python-agent/forks","keys_url":"https://api.github.com/repos/yasker/python-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yasker/python-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yasker/python-agent/teams","hooks_url":"https://api.github.com/repos/yasker/python-agent/hooks","issue_events_url":"https://api.github.com/repos/yasker/python-agent/issues/events{/number}","events_url":"https://api.github.com/repos/yasker/python-agent/events","assignees_url":"https://api.github.com/repos/yasker/python-agent/assignees{/user}","branches_url":"https://api.github.com/repos/yasker/python-agent/branches{/branch}","tags_url":"https://api.github.com/repos/yasker/python-agent/tags","blobs_url":"https://api.github.com/repos/yasker/python-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yasker/python-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yasker/python-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/yasker/python-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yasker/python-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/yasker/python-agent/languages","stargazers_url":"https://api.github.com/repos/yasker/python-agent/stargazers","contributors_url":"https://api.github.com/repos/yasker/python-agent/contributors","subscribers_url":"https://api.github.com/repos/yasker/python-agent/subscribers","subscription_url":"https://api.github.com/repos/yasker/python-agent/subscription","commits_url":"https://api.github.com/repos/yasker/python-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/yasker/python-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/yasker/python-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/yasker/python-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/yasker/python-agent/contents/{+path}","compare_url":"https://api.github.com/repos/yasker/python-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yasker/python-agent/merges","archive_url":"https://api.github.com/repos/yasker/python-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yasker/python-agent/downloads","issues_url":"https://api.github.com/repos/yasker/python-agent/issues{/number}","pulls_url":"https://api.github.com/repos/yasker/python-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/yasker/python-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/yasker/python-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yasker/python-agent/labels{/name}","releases_url":"https://api.github.com/repos/yasker/python-agent/releases{/id}","created_at":"2015-01-24T19:28:09Z","updated_at":"2015-05-07T21:01:24Z","pushed_at":"2015-05-13T17:18:14Z","git_url":"git://github.com/yasker/python-agent.git","ssh_url":"git@github.com:yasker/python-agent.git","clone_url":"https://github.com/yasker/python-agent.git","svn_url":"https://github.com/yasker/python-agent","homepage":null,"size":5463,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancherio:master","ref":"master","sha":"4ab547c8505e656082c045006ff54d1c47425656","user":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"repo":{"id":26792702,"name":"python-agent","full_name":"rancherio/python-agent","owner":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancherio/python-agent","description":"Python agent for Rancher","fork":false,"url":"https://api.github.com/repos/rancherio/python-agent","forks_url":"https://api.github.com/repos/rancherio/python-agent/forks","keys_url":"https://api.github.com/repos/rancherio/python-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancherio/python-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancherio/python-agent/teams","hooks_url":"https://api.github.com/repos/rancherio/python-agent/hooks","issue_events_url":"https://api.github.com/repos/rancherio/python-agent/issues/events{/number}","events_url":"https://api.github.com/repos/rancherio/python-agent/events","assignees_url":"https://api.github.com/repos/rancherio/python-agent/assignees{/user}","branches_url":"https://api.github.com/repos/rancherio/python-agent/branches{/branch}","tags_url":"https://api.github.com/repos/rancherio/python-agent/tags","blobs_url":"https://api.github.com/repos/rancherio/python-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancherio/python-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancherio/python-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancherio/python-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancherio/python-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/rancherio/python-agent/languages","stargazers_url":"https://api.github.com/repos/rancherio/python-agent/stargazers","contributors_url":"https://api.github.com/repos/rancherio/python-agent/contributors","subscribers_url":"https://api.github.com/repos/rancherio/python-agent/subscribers","subscription_url":"https://api.github.com/repos/rancherio/python-agent/subscription","commits_url":"https://api.github.com/repos/rancherio/python-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancherio/python-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancherio/python-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancherio/python-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancherio/python-agent/contents/{+path}","compare_url":"https://api.github.com/repos/rancherio/python-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancherio/python-agent/merges","archive_url":"https://api.github.com/repos/rancherio/python-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancherio/python-agent/downloads","issues_url":"https://api.github.com/repos/rancherio/python-agent/issues{/number}","pulls_url":"https://api.github.com/repos/rancherio/python-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/rancherio/python-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/rancherio/python-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancherio/python-agent/labels{/name}","releases_url":"https://api.github.com/repos/rancherio/python-agent/releases{/id}","created_at":"2014-11-18T05:00:53Z","updated_at":"2015-05-06T16:18:17Z","pushed_at":"2015-05-13T17:18:15Z","git_url":"git://github.com/rancherio/python-agent.git","ssh_url":"git@github.com:rancherio/python-agent.git","clone_url":"https://github.com/rancherio/python-agent.git","svn_url":"https://github.com/rancherio/python-agent","homepage":null,"size":7678,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":1,"forks":12,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/121"},"html":{"href":"https://github.com/rancherio/python-agent/pull/121"},"issue":{"href":"https://api.github.com/repos/rancherio/python-agent/issues/121"},"comments":{"href":"https://api.github.com/repos/rancherio/python-agent/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancherio/python-agent/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/rancherio/python-agent/statuses/bf1823ec24ec17014d14db700bf0de60f327447d"}}}}