{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin/pulls/comments/47634315","id":47634315,"diff_hunk":"@@ -8,235 +8,240 @@ TIME_MIN=$((60 * $TIME_SEC))\n # setup_env_vars exports all the necessary environment variables for configuring and\n # starting OS server.\n function setup_env_vars {\n-\t# set path so OpenShift is available\n-\tGO_OUT=\"${OS_ROOT}/_output/local/bin/$(os::util::host_platform)\"\n-\texport PATH=\"${GO_OUT}:${PATH}\"\n-\n-\texport ETCD_PORT=\"${ETCD_PORT:-4001}\"\n-\texport ETCD_PEER_PORT=\"${ETCD_PEER_PORT:-7001}\"\n-\texport API_BIND_HOST=\"${API_BIND_HOST:-$(openshift start --print-ip)}\"\n-\texport API_HOST=\"${API_HOST:-${API_BIND_HOST}}\"\n-\texport API_PORT=\"${API_PORT:-8443}\"\n-\texport LOG_DIR=\"${LOG_DIR:-${BASETMPDIR}/logs}\"\n-\texport ETCD_DATA_DIR=\"${BASETMPDIR}/etcd\"\n-\texport VOLUME_DIR=\"${BASETMPDIR}/volumes\"\n-\texport FAKE_HOME_DIR=\"${BASETMPDIR}/openshift.local.home\"\n-\texport API_SCHEME=\"${API_SCHEME:-https}\"\n-\texport MASTER_ADDR=\"${API_SCHEME}://${API_HOST}:${API_PORT}\"\n-\texport PUBLIC_MASTER_HOST=\"${PUBLIC_MASTER_HOST:-${API_HOST}}\"\n-\texport KUBELET_SCHEME=\"${KUBELET_SCHEME:-https}\"\n-\texport KUBELET_BIND_HOST=\"${KUBELET_BIND_HOST:-$(openshift start --print-ip)}\"\n-\texport KUBELET_HOST=\"${KUBELET_HOST:-${KUBELET_BIND_HOST}}\"\n-\texport KUBELET_PORT=\"${KUBELET_PORT:-10250}\"\n-\texport SERVER_CONFIG_DIR=\"${BASETMPDIR}/openshift.local.config\"\n-\texport MASTER_CONFIG_DIR=\"${SERVER_CONFIG_DIR}/master\"\n-\texport NODE_CONFIG_DIR=\"${SERVER_CONFIG_DIR}/node-${KUBELET_HOST}\"\n-\texport ARTIFACT_DIR=\"${ARTIFACT_DIR:-${BASETMPDIR}/artifacts}\"\n-\tif [ -z ${SUDO+x} ]; then\n-\t\texport SUDO=\"${SUDO:-1}\"\n-\tfi\n-\n-\t# Use either the latest release built images, or latest.\n-\tif [[ -z \"${USE_IMAGES-}\" ]]; then\n-\t\tIMAGES='openshift/origin-${component}:latest'\n-\t\texport TAG=latest\n-\t\texport USE_IMAGES=${IMAGES}\n-\t\tif [[ -e \"${OS_ROOT}/_output/local/releases/.commit\" ]]; then\n-\t\t\tCOMMIT=\"$(cat \"${OS_ROOT}/_output/local/releases/.commit\")\"\n-\t\t\tIMAGES=\"openshift/origin-\\${component}:${COMMIT}\"\n-\t\t\texport TAG=${COMMIT}\n-\t\t\texport USE_IMAGES=${IMAGES}\n-\t\tfi\n-\tfi\n-\n-\tif [[ \"${API_SCHEME}\" == \"https\" ]]; then\n-\t\texport CURL_CA_BUNDLE=\"${MASTER_CONFIG_DIR}/ca.crt\"\n-\t\texport CURL_CERT=\"${MASTER_CONFIG_DIR}/admin.crt\"\n-\t\texport CURL_KEY=\"${MASTER_CONFIG_DIR}/admin.key\"\n-\tfi\n-\n-\t# change the location of $HOME so no one does anything naughty\n-\texport HOME=\"${FAKE_HOME_DIR}\"\n+  # set path so OpenShift is available","path":"hack/util.sh","position":53,"original_position":53,"commit_id":"1b082850d7847436a042cf9adc1f859bd1ae08bf","original_commit_id":"1b082850d7847436a042cf9adc1f859bd1ae08bf","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"Also, finding the change is like a game of where's waldo.","created_at":"2015-12-15T13:21:10Z","updated_at":"2015-12-15T13:21:10Z","html_url":"https://github.com/openshift/origin/pull/6319#discussion_r47634315","pull_request_url":"https://api.github.com/repos/openshift/origin/pulls/6319","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments/47634315"},"html":{"href":"https://github.com/openshift/origin/pull/6319#discussion_r47634315"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin/pulls/6319"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/6319","id":53689271,"html_url":"https://github.com/openshift/origin/pull/6319","diff_url":"https://github.com/openshift/origin/pull/6319.diff","patch_url":"https://github.com/openshift/origin/pull/6319.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/6319","number":6319,"state":"open","locked":false,"title":"Allow to pass extra args to server in extended test and mute config loading messages","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"body":"This PR will:\r\n\r\n* mute messages like this:\r\n```console\r\nI1211 10:53:21.257617   26640 loader.go:241] Config loaded from file /tmp/openshift-extended-tests/core/openshift.local.config/master/admin.kubeconfig\r\n```\r\n* allow to pass `SERVER_ARGS` into `./test/extended/core.sh` with additional arguments to `openshift start` (like `--latest-images`)","created_at":"2015-12-15T11:10:28Z","updated_at":"2015-12-15T13:21:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"792c78c8596ebcc7e5abe295ff2826f7a45e459c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/6319/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/6319/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/6319/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/1b082850d7847436a042cf9adc1f859bd1ae08bf","head":{"label":"mfojtik:extended-params","ref":"extended-params","sha":"1b082850d7847436a042cf9adc1f859bd1ae08bf","user":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"repo":{"id":22954249,"name":"origin","full_name":"mfojtik/origin","owner":{"login":"mfojtik","id":44136,"avatar_url":"https://avatars.githubusercontent.com/u/44136?v=3","gravatar_id":"","url":"https://api.github.com/users/mfojtik","html_url":"https://github.com/mfojtik","followers_url":"https://api.github.com/users/mfojtik/followers","following_url":"https://api.github.com/users/mfojtik/following{/other_user}","gists_url":"https://api.github.com/users/mfojtik/gists{/gist_id}","starred_url":"https://api.github.com/users/mfojtik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfojtik/subscriptions","organizations_url":"https://api.github.com/users/mfojtik/orgs","repos_url":"https://api.github.com/users/mfojtik/repos","events_url":"https://api.github.com/users/mfojtik/events{/privacy}","received_events_url":"https://api.github.com/users/mfojtik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfojtik/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/mfojtik/origin","forks_url":"https://api.github.com/repos/mfojtik/origin/forks","keys_url":"https://api.github.com/repos/mfojtik/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfojtik/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfojtik/origin/teams","hooks_url":"https://api.github.com/repos/mfojtik/origin/hooks","issue_events_url":"https://api.github.com/repos/mfojtik/origin/issues/events{/number}","events_url":"https://api.github.com/repos/mfojtik/origin/events","assignees_url":"https://api.github.com/repos/mfojtik/origin/assignees{/user}","branches_url":"https://api.github.com/repos/mfojtik/origin/branches{/branch}","tags_url":"https://api.github.com/repos/mfojtik/origin/tags","blobs_url":"https://api.github.com/repos/mfojtik/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfojtik/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfojtik/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfojtik/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfojtik/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/mfojtik/origin/languages","stargazers_url":"https://api.github.com/repos/mfojtik/origin/stargazers","contributors_url":"https://api.github.com/repos/mfojtik/origin/contributors","subscribers_url":"https://api.github.com/repos/mfojtik/origin/subscribers","subscription_url":"https://api.github.com/repos/mfojtik/origin/subscription","commits_url":"https://api.github.com/repos/mfojtik/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfojtik/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfojtik/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfojtik/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfojtik/origin/contents/{+path}","compare_url":"https://api.github.com/repos/mfojtik/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfojtik/origin/merges","archive_url":"https://api.github.com/repos/mfojtik/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfojtik/origin/downloads","issues_url":"https://api.github.com/repos/mfojtik/origin/issues{/number}","pulls_url":"https://api.github.com/repos/mfojtik/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/mfojtik/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/mfojtik/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfojtik/origin/labels{/name}","releases_url":"https://api.github.com/repos/mfojtik/origin/releases{/id}","created_at":"2014-08-14T13:11:47Z","updated_at":"2015-05-07T09:05:06Z","pushed_at":"2015-12-15T11:32:58Z","git_url":"git://github.com/mfojtik/origin.git","ssh_url":"git@github.com:mfojtik/origin.git","clone_url":"https://github.com/mfojtik/origin.git","svn_url":"https://github.com/mfojtik/origin","homepage":"https://openshift.github.io","size":179891,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"759c4708cc0a02d6fca071f7e66d23231e663b44","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-12-15T08:37:14Z","pushed_at":"2015-12-15T13:14:47Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":228547,"stargazers_count":866,"watchers_count":866,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":549,"mirror_url":null,"open_issues_count":739,"forks":549,"open_issues":739,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/6319"},"html":{"href":"https://github.com/openshift/origin/pull/6319"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/6319"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/6319/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/6319/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/6319/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/1b082850d7847436a042cf9adc1f859bd1ae08bf"}}}}