{"action":"opened","number":480,"pull_request":{"url":"https://api.github.com/repos/atom/settings-view/pulls/480","id":34096688,"html_url":"https://github.com/atom/settings-view/pull/480","diff_url":"https://github.com/atom/settings-view/pull/480.diff","patch_url":"https://github.com/atom/settings-view/pull/480.patch","issue_url":"https://api.github.com/repos/atom/settings-view/issues/480","number":480,"state":"open","locked":false,"title":"Use remove() instead of hide() for button group styling","user":{"login":"jlord","id":1305617,"avatar_url":"https://avatars.githubusercontent.com/u/1305617?v=3","gravatar_id":"","url":"https://api.github.com/users/jlord","html_url":"https://github.com/jlord","followers_url":"https://api.github.com/users/jlord/followers","following_url":"https://api.github.com/users/jlord/following{/other_user}","gists_url":"https://api.github.com/users/jlord/gists{/gist_id}","starred_url":"https://api.github.com/users/jlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlord/subscriptions","organizations_url":"https://api.github.com/users/jlord/orgs","repos_url":"https://api.github.com/users/jlord/repos","events_url":"https://api.github.com/users/jlord/events{/privacy}","received_events_url":"https://api.github.com/users/jlord/received_events","type":"User","site_admin":true},"body":"We've fixed this in places in the past (and there are likely more places that will turn up) where we switch to `remove()` so that the remaining buttons get rounded corners (even with `display: none;` it is still in the dom and messes up the CSS).\r\n\r\nThis in particular was affecting themes that had no settings and which be default cannot be disabled or have a status indicator. :traffic_light: \r\n\r\nThis PR removes instead of hides the three non-relevant buttons. ","created_at":"2015-04-25T00:28:01Z","updated_at":"2015-04-25T00:28:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"afdc8e717fdfa6ab4663fbe8b5f69e36e09d232a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/settings-view/pulls/480/commits","review_comments_url":"https://api.github.com/repos/atom/settings-view/pulls/480/comments","review_comment_url":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/settings-view/issues/480/comments","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/c0c3affbfee2dd89cb370cf726e5e2ffeed3775c","head":{"label":"atom:jl-theme-btngroup","ref":"jl-theme-btngroup","sha":"c0c3affbfee2dd89cb370cf726e5e2ffeed3775c","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12090329,"name":"settings-view","full_name":"atom/settings-view","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/settings-view","description":"Edit Atom settings","fork":false,"url":"https://api.github.com/repos/atom/settings-view","forks_url":"https://api.github.com/repos/atom/settings-view/forks","keys_url":"https://api.github.com/repos/atom/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/settings-view/teams","hooks_url":"https://api.github.com/repos/atom/settings-view/hooks","issue_events_url":"https://api.github.com/repos/atom/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/atom/settings-view/events","assignees_url":"https://api.github.com/repos/atom/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/atom/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/atom/settings-view/tags","blobs_url":"https://api.github.com/repos/atom/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/settings-view/languages","stargazers_url":"https://api.github.com/repos/atom/settings-view/stargazers","contributors_url":"https://api.github.com/repos/atom/settings-view/contributors","subscribers_url":"https://api.github.com/repos/atom/settings-view/subscribers","subscription_url":"https://api.github.com/repos/atom/settings-view/subscription","commits_url":"https://api.github.com/repos/atom/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/atom/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/settings-view/merges","archive_url":"https://api.github.com/repos/atom/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/settings-view/downloads","issues_url":"https://api.github.com/repos/atom/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/atom/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/atom/settings-view/releases{/id}","created_at":"2013-08-13T19:16:23Z","updated_at":"2015-04-22T17:36:53Z","pushed_at":"2015-04-25T00:28:02Z","git_url":"git://github.com/atom/settings-view.git","ssh_url":"git@github.com:atom/settings-view.git","clone_url":"https://github.com/atom/settings-view.git","svn_url":"https://github.com/atom/settings-view","homepage":null,"size":4194,"stargazers_count":44,"watchers_count":44,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":91,"forks":48,"open_issues":91,"watchers":44,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"3f2042408df5a8858ffe5ae398ff7b42b7fc7857","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12090329,"name":"settings-view","full_name":"atom/settings-view","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/settings-view","description":"Edit Atom settings","fork":false,"url":"https://api.github.com/repos/atom/settings-view","forks_url":"https://api.github.com/repos/atom/settings-view/forks","keys_url":"https://api.github.com/repos/atom/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/settings-view/teams","hooks_url":"https://api.github.com/repos/atom/settings-view/hooks","issue_events_url":"https://api.github.com/repos/atom/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/atom/settings-view/events","assignees_url":"https://api.github.com/repos/atom/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/atom/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/atom/settings-view/tags","blobs_url":"https://api.github.com/repos/atom/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/settings-view/languages","stargazers_url":"https://api.github.com/repos/atom/settings-view/stargazers","contributors_url":"https://api.github.com/repos/atom/settings-view/contributors","subscribers_url":"https://api.github.com/repos/atom/settings-view/subscribers","subscription_url":"https://api.github.com/repos/atom/settings-view/subscription","commits_url":"https://api.github.com/repos/atom/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/atom/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/settings-view/merges","archive_url":"https://api.github.com/repos/atom/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/settings-view/downloads","issues_url":"https://api.github.com/repos/atom/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/atom/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/atom/settings-view/releases{/id}","created_at":"2013-08-13T19:16:23Z","updated_at":"2015-04-22T17:36:53Z","pushed_at":"2015-04-25T00:28:02Z","git_url":"git://github.com/atom/settings-view.git","ssh_url":"git@github.com:atom/settings-view.git","clone_url":"https://github.com/atom/settings-view.git","svn_url":"https://github.com/atom/settings-view","homepage":null,"size":4194,"stargazers_count":44,"watchers_count":44,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":91,"forks":48,"open_issues":91,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/settings-view/pulls/480"},"html":{"href":"https://github.com/atom/settings-view/pull/480"},"issue":{"href":"https://api.github.com/repos/atom/settings-view/issues/480"},"comments":{"href":"https://api.github.com/repos/atom/settings-view/issues/480/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/settings-view/pulls/480/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/settings-view/pulls/480/commits"},"statuses":{"href":"https://api.github.com/repos/atom/settings-view/statuses/c0c3affbfee2dd89cb370cf726e5e2ffeed3775c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}