{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/736","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/736/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/736/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/736/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/issues/736","id":115519898,"number":736,"title":"Current dev won't compile for NodeMCU board revision 0.9","user":{"login":"UserXYZ","id":4689860,"avatar_url":"https://avatars.githubusercontent.com/u/4689860?v=3","gravatar_id":"","url":"https://api.github.com/users/UserXYZ","html_url":"https://github.com/UserXYZ","followers_url":"https://api.github.com/users/UserXYZ/followers","following_url":"https://api.github.com/users/UserXYZ/following{/other_user}","gists_url":"https://api.github.com/users/UserXYZ/gists{/gist_id}","starred_url":"https://api.github.com/users/UserXYZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UserXYZ/subscriptions","organizations_url":"https://api.github.com/users/UserXYZ/orgs","repos_url":"https://api.github.com/users/UserXYZ/repos","events_url":"https://api.github.com/users/UserXYZ/events{/privacy}","received_events_url":"https://api.github.com/users/UserXYZ/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-06T14:56:10Z","updated_at":"2015-11-09T17:02:46Z","closed_at":"2015-11-09T16:51:07Z","body":"When enabling DEVKIT_VERSION_0_9 in user_config.h, READLINE_INTERVAL is not defined and compilation crashes almost instantly.\r\nIn previous dev revisions, even with SDK 1.4, this was explicitelly defined, regardles of DEVKIT_VERSION and so compilation worked.\r\nFurther, with DEVKIT_VERSION_0_9 enabled, compilation crashes on node.c with following error:\r\n\r\n```\r\nnode.c:246:6: error: conflicting types for 'key_long_press' [-Werror]\r\n void key_long_press(void *arg) {\r\n      ^\r\nnode.c:183:7: note: previous implicit declaration of 'key_long_press' was here\r\n       key_long_press(NULL);\r\n       ^\r\nnode.c:258:6: error: conflicting types for 'key_short_press' [-Werror]\r\n void key_short_press(void *arg) {\r\n      ^\r\nnode.c:187:7: note: previous implicit declaration of 'key_short_press' was here\r\n       key_short_press(NULL);\r\n       ^\r\ncc1: all warnings being treated as errors\r\n```\r\n\r\nI tried rebuilding esp-open-sdk with crostools from https://github.com/pfalcon/esp-open-sdk.git (which worked before and is, as far as I know, suggested set for building the firmware) but it made no difference.\r\n\r\nIf DEVKIT_VERSION_0_9 is undefined, compilation works without problems.\r\n\r\nIt seems that somebody made a change without checking output on both board revisions and that rendered compilation for old board impossible.\r\nBuilding is done on Fedora 21 and Ubuntu 12.04, no difference.\r\n\r\nFor some reason, frightanic's dev build still passes, don't know how if he also had his dev tools/SDK updated...?"},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/155125245","html_url":"https://github.com/nodemcu/nodemcu-firmware/issues/736#issuecomment-155125245","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/736","id":155125245,"user":{"login":"drawkula","id":9768622,"avatar_url":"https://avatars.githubusercontent.com/u/9768622?v=3","gravatar_id":"","url":"https://api.github.com/users/drawkula","html_url":"https://github.com/drawkula","followers_url":"https://api.github.com/users/drawkula/followers","following_url":"https://api.github.com/users/drawkula/following{/other_user}","gists_url":"https://api.github.com/users/drawkula/gists{/gist_id}","starred_url":"https://api.github.com/users/drawkula/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drawkula/subscriptions","organizations_url":"https://api.github.com/users/drawkula/orgs","repos_url":"https://api.github.com/users/drawkula/repos","events_url":"https://api.github.com/users/drawkula/events{/privacy}","received_events_url":"https://api.github.com/users/drawkula/received_events","type":"User","site_admin":false},"created_at":"2015-11-09T17:02:45Z","updated_at":"2015-11-09T17:02:45Z","body":"Ok... the \"does not compile issue is gone\", but it still is unusable. Perhaps it is a new issue now?\r\n\r\n@UserXYZ try to run it... the reboot loop do not prevent flashing the old firmware again..."}}