{"action":"opened","number":68,"pull_request":{"url":"https://api.github.com/repos/contao/core-bundle/pulls/68","id":31532393,"html_url":"https://github.com/contao/core-bundle/pull/68","diff_url":"https://github.com/contao/core-bundle/pull/68.diff","patch_url":"https://github.com/contao/core-bundle/pull/68.patch","issue_url":"https://api.github.com/repos/contao/core-bundle/issues/68","number":68,"state":"open","locked":false,"title":"[WIP] Symfony Session Handling","user":{"login":"Toflar","id":481937,"avatar_url":"https://avatars.githubusercontent.com/u/481937?v=3","gravatar_id":"","url":"https://api.github.com/users/Toflar","html_url":"https://github.com/Toflar","followers_url":"https://api.github.com/users/Toflar/followers","following_url":"https://api.github.com/users/Toflar/following{/other_user}","gists_url":"https://api.github.com/users/Toflar/gists{/gist_id}","starred_url":"https://api.github.com/users/Toflar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toflar/subscriptions","organizations_url":"https://api.github.com/users/Toflar/orgs","repos_url":"https://api.github.com/users/Toflar/repos","events_url":"https://api.github.com/users/Toflar/events{/privacy}","received_events_url":"https://api.github.com/users/Toflar/received_events","type":"User","site_admin":false},"body":"Requires the following changes in `contao/standard-edition`'s `config.yml`:\r\n\r\n```diff\r\n-    session: false\r\n+    csrf_protection: ~\r\n+    session:\r\n+        handler_id: ~\r\n```\r\n\r\n(I did not make a separate PR because of the effort :-)).\r\n\r\nI know it's mixing session handling with CSRF token handling but they sort of belong together and I had to make sure I could log in again, so I hacked it all together :-)\r\n\r\n## ToDo's\r\n* [ ] Should we add an `ArrayAccess` wrapper for `$_SESSION`? Why?\r\n* [ ] Should we add `public function getToken()` to `Template` because one should not use `REQUEST_TOKEN` anymore?\r\n* [ ] Tests\r\n\r\n","created_at":"2015-03-19T15:11:09Z","updated_at":"2015-03-19T15:11:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contao/core-bundle/pulls/68/commits","review_comments_url":"https://api.github.com/repos/contao/core-bundle/pulls/68/comments","review_comment_url":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contao/core-bundle/issues/68/comments","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/921f92bcafbd4d1e3bcbca104a2013978201019c","head":{"label":"Toflar:feature/symfony-session","ref":"feature/symfony-session","sha":"921f92bcafbd4d1e3bcbca104a2013978201019c","user":{"login":"Toflar","id":481937,"avatar_url":"https://avatars.githubusercontent.com/u/481937?v=3","gravatar_id":"","url":"https://api.github.com/users/Toflar","html_url":"https://github.com/Toflar","followers_url":"https://api.github.com/users/Toflar/followers","following_url":"https://api.github.com/users/Toflar/following{/other_user}","gists_url":"https://api.github.com/users/Toflar/gists{/gist_id}","starred_url":"https://api.github.com/users/Toflar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toflar/subscriptions","organizations_url":"https://api.github.com/users/Toflar/orgs","repos_url":"https://api.github.com/users/Toflar/repos","events_url":"https://api.github.com/users/Toflar/events{/privacy}","received_events_url":"https://api.github.com/users/Toflar/received_events","type":"User","site_admin":false},"repo":{"id":26642166,"name":"core-bundle","full_name":"Toflar/core-bundle","owner":{"login":"Toflar","id":481937,"avatar_url":"https://avatars.githubusercontent.com/u/481937?v=3","gravatar_id":"","url":"https://api.github.com/users/Toflar","html_url":"https://github.com/Toflar","followers_url":"https://api.github.com/users/Toflar/followers","following_url":"https://api.github.com/users/Toflar/following{/other_user}","gists_url":"https://api.github.com/users/Toflar/gists{/gist_id}","starred_url":"https://api.github.com/users/Toflar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Toflar/subscriptions","organizations_url":"https://api.github.com/users/Toflar/orgs","repos_url":"https://api.github.com/users/Toflar/repos","events_url":"https://api.github.com/users/Toflar/events{/privacy}","received_events_url":"https://api.github.com/users/Toflar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Toflar/core-bundle","description":"Contao 4 core bundle","fork":true,"url":"https://api.github.com/repos/Toflar/core-bundle","forks_url":"https://api.github.com/repos/Toflar/core-bundle/forks","keys_url":"https://api.github.com/repos/Toflar/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Toflar/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Toflar/core-bundle/teams","hooks_url":"https://api.github.com/repos/Toflar/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/Toflar/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/Toflar/core-bundle/events","assignees_url":"https://api.github.com/repos/Toflar/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/Toflar/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/Toflar/core-bundle/tags","blobs_url":"https://api.github.com/repos/Toflar/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Toflar/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Toflar/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Toflar/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Toflar/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/Toflar/core-bundle/languages","stargazers_url":"https://api.github.com/repos/Toflar/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/Toflar/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/Toflar/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/Toflar/core-bundle/subscription","commits_url":"https://api.github.com/repos/Toflar/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Toflar/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Toflar/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Toflar/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Toflar/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/Toflar/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Toflar/core-bundle/merges","archive_url":"https://api.github.com/repos/Toflar/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Toflar/core-bundle/downloads","issues_url":"https://api.github.com/repos/Toflar/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/Toflar/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/Toflar/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/Toflar/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Toflar/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/Toflar/core-bundle/releases{/id}","created_at":"2014-11-14T14:32:10Z","updated_at":"2014-11-14T14:32:12Z","pushed_at":"2015-03-19T15:11:07Z","git_url":"git://github.com/Toflar/core-bundle.git","ssh_url":"git@github.com:Toflar/core-bundle.git","clone_url":"https://github.com/Toflar/core-bundle.git","svn_url":"https://github.com/Toflar/core-bundle","homepage":"","size":18627,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"contao:develop","ref":"develop","sha":"3a1fe2d52acf0f3e7367f337140ff97dc021a32f","user":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"repo":{"id":20519851,"name":"core-bundle","full_name":"contao/core-bundle","owner":{"login":"contao","id":1206136,"avatar_url":"https://avatars.githubusercontent.com/u/1206136?v=3","gravatar_id":"","url":"https://api.github.com/users/contao","html_url":"https://github.com/contao","followers_url":"https://api.github.com/users/contao/followers","following_url":"https://api.github.com/users/contao/following{/other_user}","gists_url":"https://api.github.com/users/contao/gists{/gist_id}","starred_url":"https://api.github.com/users/contao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contao/subscriptions","organizations_url":"https://api.github.com/users/contao/orgs","repos_url":"https://api.github.com/users/contao/repos","events_url":"https://api.github.com/users/contao/events{/privacy}","received_events_url":"https://api.github.com/users/contao/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contao/core-bundle","description":"Contao 4 core bundle","fork":false,"url":"https://api.github.com/repos/contao/core-bundle","forks_url":"https://api.github.com/repos/contao/core-bundle/forks","keys_url":"https://api.github.com/repos/contao/core-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contao/core-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contao/core-bundle/teams","hooks_url":"https://api.github.com/repos/contao/core-bundle/hooks","issue_events_url":"https://api.github.com/repos/contao/core-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/contao/core-bundle/events","assignees_url":"https://api.github.com/repos/contao/core-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/contao/core-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/contao/core-bundle/tags","blobs_url":"https://api.github.com/repos/contao/core-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contao/core-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contao/core-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/contao/core-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contao/core-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/contao/core-bundle/languages","stargazers_url":"https://api.github.com/repos/contao/core-bundle/stargazers","contributors_url":"https://api.github.com/repos/contao/core-bundle/contributors","subscribers_url":"https://api.github.com/repos/contao/core-bundle/subscribers","subscription_url":"https://api.github.com/repos/contao/core-bundle/subscription","commits_url":"https://api.github.com/repos/contao/core-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/contao/core-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/contao/core-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/contao/core-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/contao/core-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/contao/core-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contao/core-bundle/merges","archive_url":"https://api.github.com/repos/contao/core-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contao/core-bundle/downloads","issues_url":"https://api.github.com/repos/contao/core-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/contao/core-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/contao/core-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/contao/core-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contao/core-bundle/labels{/name}","releases_url":"https://api.github.com/repos/contao/core-bundle/releases{/id}","created_at":"2014-06-05T09:45:55Z","updated_at":"2015-03-19T15:10:29Z","pushed_at":"2015-03-19T15:10:29Z","git_url":"git://github.com/contao/core-bundle.git","ssh_url":"git@github.com:contao/core-bundle.git","clone_url":"https://github.com/contao/core-bundle.git","svn_url":"https://github.com/contao/core-bundle","homepage":"","size":23007,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/68"},"html":{"href":"https://github.com/contao/core-bundle/pull/68"},"issue":{"href":"https://api.github.com/repos/contao/core-bundle/issues/68"},"comments":{"href":"https://api.github.com/repos/contao/core-bundle/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contao/core-bundle/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/contao/core-bundle/statuses/921f92bcafbd4d1e3bcbca104a2013978201019c"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":129,"deletions":127,"changed_files":5}}