{"action":"created","comment":{"url":"https://api.github.com/repos/starteam/starcellbio_html/pulls/comments/25898847","id":25898847,"diff_hunk":"@@ -73,25 +73,34 @@ scb.Treatment = function scb_Treatment(data, context, parent) {\n \tObject.defineProperty(self, 'duration', {\n \t\tget : function() {\n \t\t\tvar time = parseFloat(data.duration_value);\n-\t\t\t//var days = Math.floor(time / 86400);\n \t\t\tvar days = Math.floor((time % 604800) / 86400);\n-\n \t\t\tvar hours = Math.floor((time % 86400) / 3600);\n-\t\t\tvar minutes = Math.round((time % 3600) / 60);\n-\t\t\t\n+\t\t\tvar minutes = Math.floor((time % 3600) / 60);\n \t\t\tvar months = Math.floor(time /2592000);\n-\t\t\t\n \t\t\tvar weeks = Math.floor((time % 2592000) / 604800);\n-\t\t\tvar now = (time < 60 );\n+\t\t\tvar now = (time < 30 );","path":"html_app/model/Treatment.js","position":15,"original_position":15,"commit_id":"6cdd7d848763e88ef60c17f289a9b24a2571ee7f","original_commit_id":"6cdd7d848763e88ef60c17f289a9b24a2571ee7f","user":{"login":"pdpinch","id":430126,"avatar_url":"https://avatars.githubusercontent.com/u/430126?v=3","gravatar_id":"","url":"https://api.github.com/users/pdpinch","html_url":"https://github.com/pdpinch","followers_url":"https://api.github.com/users/pdpinch/followers","following_url":"https://api.github.com/users/pdpinch/following{/other_user}","gists_url":"https://api.github.com/users/pdpinch/gists{/gist_id}","starred_url":"https://api.github.com/users/pdpinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdpinch/subscriptions","organizations_url":"https://api.github.com/users/pdpinch/orgs","repos_url":"https://api.github.com/users/pdpinch/repos","events_url":"https://api.github.com/users/pdpinch/events{/privacy}","received_events_url":"https://api.github.com/users/pdpinch/received_events","type":"User","site_admin":false},"body":"Wow. It's really confusing to have this code duplicated for each assignment. I opened issue https://github.com/starteam/starcellbio_html/issues/61 to think about refactoring it. ","created_at":"2015-03-05T20:32:31Z","updated_at":"2015-03-05T20:32:31Z","html_url":"https://github.com/starteam/starcellbio_html/pull/32#discussion_r25898847","pull_request_url":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32","_links":{"self":{"href":"https://api.github.com/repos/starteam/starcellbio_html/pulls/comments/25898847"},"html":{"href":"https://github.com/starteam/starcellbio_html/pull/32#discussion_r25898847"},"pull_request":{"href":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32","id":30118134,"html_url":"https://github.com/starteam/starcellbio_html/pull/32","diff_url":"https://github.com/starteam/starcellbio_html/pull/32.diff","patch_url":"https://github.com/starteam/starcellbio_html/pull/32.patch","issue_url":"https://api.github.com/repos/starteam/starcellbio_html/issues/32","number":32,"state":"open","locked":false,"title":"Feature/sutd assignment2","user":{"login":"annagav","id":7574259,"avatar_url":"https://avatars.githubusercontent.com/u/7574259?v=3","gravatar_id":"","url":"https://api.github.com/users/annagav","html_url":"https://github.com/annagav","followers_url":"https://api.github.com/users/annagav/followers","following_url":"https://api.github.com/users/annagav/following{/other_user}","gists_url":"https://api.github.com/users/annagav/gists{/gist_id}","starred_url":"https://api.github.com/users/annagav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annagav/subscriptions","organizations_url":"https://api.github.com/users/annagav/orgs","repos_url":"https://api.github.com/users/annagav/repos","events_url":"https://api.github.com/users/annagav/events{/privacy}","received_events_url":"https://api.github.com/users/annagav/received_events","type":"User","site_admin":false},"body":"Contains working:\r\n- Western blot\r\n- Flow Cytometry\r\n- Microscopy\r\n\r\nIncludes modifications to the microscopy technique of Exercise 3.","created_at":"2015-02-26T21:27:33Z","updated_at":"2015-03-05T20:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c7d733ee4ff20391dc7fcab7cae5941e60dd8a5d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32/commits","review_comments_url":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32/comments","review_comment_url":"https://api.github.com/repos/starteam/starcellbio_html/pulls/comments{/number}","comments_url":"https://api.github.com/repos/starteam/starcellbio_html/issues/32/comments","statuses_url":"https://api.github.com/repos/starteam/starcellbio_html/statuses/6cdd7d848763e88ef60c17f289a9b24a2571ee7f","head":{"label":"annagav:feature/sutd_assignment2","ref":"feature/sutd_assignment2","sha":"6cdd7d848763e88ef60c17f289a9b24a2571ee7f","user":{"login":"annagav","id":7574259,"avatar_url":"https://avatars.githubusercontent.com/u/7574259?v=3","gravatar_id":"","url":"https://api.github.com/users/annagav","html_url":"https://github.com/annagav","followers_url":"https://api.github.com/users/annagav/followers","following_url":"https://api.github.com/users/annagav/following{/other_user}","gists_url":"https://api.github.com/users/annagav/gists{/gist_id}","starred_url":"https://api.github.com/users/annagav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annagav/subscriptions","organizations_url":"https://api.github.com/users/annagav/orgs","repos_url":"https://api.github.com/users/annagav/repos","events_url":"https://api.github.com/users/annagav/events{/privacy}","received_events_url":"https://api.github.com/users/annagav/received_events","type":"User","site_admin":false},"repo":{"id":26652367,"name":"starcellbio_html","full_name":"annagav/starcellbio_html","owner":{"login":"annagav","id":7574259,"avatar_url":"https://avatars.githubusercontent.com/u/7574259?v=3","gravatar_id":"","url":"https://api.github.com/users/annagav","html_url":"https://github.com/annagav","followers_url":"https://api.github.com/users/annagav/followers","following_url":"https://api.github.com/users/annagav/following{/other_user}","gists_url":"https://api.github.com/users/annagav/gists{/gist_id}","starred_url":"https://api.github.com/users/annagav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/annagav/subscriptions","organizations_url":"https://api.github.com/users/annagav/orgs","repos_url":"https://api.github.com/users/annagav/repos","events_url":"https://api.github.com/users/annagav/events{/privacy}","received_events_url":"https://api.github.com/users/annagav/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/annagav/starcellbio_html","description":"","fork":true,"url":"https://api.github.com/repos/annagav/starcellbio_html","forks_url":"https://api.github.com/repos/annagav/starcellbio_html/forks","keys_url":"https://api.github.com/repos/annagav/starcellbio_html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/annagav/starcellbio_html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/annagav/starcellbio_html/teams","hooks_url":"https://api.github.com/repos/annagav/starcellbio_html/hooks","issue_events_url":"https://api.github.com/repos/annagav/starcellbio_html/issues/events{/number}","events_url":"https://api.github.com/repos/annagav/starcellbio_html/events","assignees_url":"https://api.github.com/repos/annagav/starcellbio_html/assignees{/user}","branches_url":"https://api.github.com/repos/annagav/starcellbio_html/branches{/branch}","tags_url":"https://api.github.com/repos/annagav/starcellbio_html/tags","blobs_url":"https://api.github.com/repos/annagav/starcellbio_html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/annagav/starcellbio_html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/annagav/starcellbio_html/git/refs{/sha}","trees_url":"https://api.github.com/repos/annagav/starcellbio_html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/annagav/starcellbio_html/statuses/{sha}","languages_url":"https://api.github.com/repos/annagav/starcellbio_html/languages","stargazers_url":"https://api.github.com/repos/annagav/starcellbio_html/stargazers","contributors_url":"https://api.github.com/repos/annagav/starcellbio_html/contributors","subscribers_url":"https://api.github.com/repos/annagav/starcellbio_html/subscribers","subscription_url":"https://api.github.com/repos/annagav/starcellbio_html/subscription","commits_url":"https://api.github.com/repos/annagav/starcellbio_html/commits{/sha}","git_commits_url":"https://api.github.com/repos/annagav/starcellbio_html/git/commits{/sha}","comments_url":"https://api.github.com/repos/annagav/starcellbio_html/comments{/number}","issue_comment_url":"https://api.github.com/repos/annagav/starcellbio_html/issues/comments{/number}","contents_url":"https://api.github.com/repos/annagav/starcellbio_html/contents/{+path}","compare_url":"https://api.github.com/repos/annagav/starcellbio_html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/annagav/starcellbio_html/merges","archive_url":"https://api.github.com/repos/annagav/starcellbio_html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/annagav/starcellbio_html/downloads","issues_url":"https://api.github.com/repos/annagav/starcellbio_html/issues{/number}","pulls_url":"https://api.github.com/repos/annagav/starcellbio_html/pulls{/number}","milestones_url":"https://api.github.com/repos/annagav/starcellbio_html/milestones{/number}","notifications_url":"https://api.github.com/repos/annagav/starcellbio_html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/annagav/starcellbio_html/labels{/name}","releases_url":"https://api.github.com/repos/annagav/starcellbio_html/releases{/id}","created_at":"2014-11-14T18:45:00Z","updated_at":"2014-11-14T18:45:01Z","pushed_at":"2015-03-05T20:28:35Z","git_url":"git://github.com/annagav/starcellbio_html.git","ssh_url":"git@github.com:annagav/starcellbio_html.git","clone_url":"https://github.com/annagav/starcellbio_html.git","svn_url":"https://github.com/annagav/starcellbio_html","homepage":null,"size":321000,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"starteam:develop","ref":"develop","sha":"41cc4078e328e673d2cd40093bab05ee75e21d03","user":{"login":"starteam","id":2973496,"avatar_url":"https://avatars.githubusercontent.com/u/2973496?v=3","gravatar_id":"","url":"https://api.github.com/users/starteam","html_url":"https://github.com/starteam","followers_url":"https://api.github.com/users/starteam/followers","following_url":"https://api.github.com/users/starteam/following{/other_user}","gists_url":"https://api.github.com/users/starteam/gists{/gist_id}","starred_url":"https://api.github.com/users/starteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starteam/subscriptions","organizations_url":"https://api.github.com/users/starteam/orgs","repos_url":"https://api.github.com/users/starteam/repos","events_url":"https://api.github.com/users/starteam/events{/privacy}","received_events_url":"https://api.github.com/users/starteam/received_events","type":"Organization","site_admin":false},"repo":{"id":7005293,"name":"starcellbio_html","full_name":"starteam/starcellbio_html","owner":{"login":"starteam","id":2973496,"avatar_url":"https://avatars.githubusercontent.com/u/2973496?v=3","gravatar_id":"","url":"https://api.github.com/users/starteam","html_url":"https://github.com/starteam","followers_url":"https://api.github.com/users/starteam/followers","following_url":"https://api.github.com/users/starteam/following{/other_user}","gists_url":"https://api.github.com/users/starteam/gists{/gist_id}","starred_url":"https://api.github.com/users/starteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starteam/subscriptions","organizations_url":"https://api.github.com/users/starteam/orgs","repos_url":"https://api.github.com/users/starteam/repos","events_url":"https://api.github.com/users/starteam/events{/privacy}","received_events_url":"https://api.github.com/users/starteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/starteam/starcellbio_html","description":"","fork":false,"url":"https://api.github.com/repos/starteam/starcellbio_html","forks_url":"https://api.github.com/repos/starteam/starcellbio_html/forks","keys_url":"https://api.github.com/repos/starteam/starcellbio_html/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starteam/starcellbio_html/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starteam/starcellbio_html/teams","hooks_url":"https://api.github.com/repos/starteam/starcellbio_html/hooks","issue_events_url":"https://api.github.com/repos/starteam/starcellbio_html/issues/events{/number}","events_url":"https://api.github.com/repos/starteam/starcellbio_html/events","assignees_url":"https://api.github.com/repos/starteam/starcellbio_html/assignees{/user}","branches_url":"https://api.github.com/repos/starteam/starcellbio_html/branches{/branch}","tags_url":"https://api.github.com/repos/starteam/starcellbio_html/tags","blobs_url":"https://api.github.com/repos/starteam/starcellbio_html/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starteam/starcellbio_html/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starteam/starcellbio_html/git/refs{/sha}","trees_url":"https://api.github.com/repos/starteam/starcellbio_html/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starteam/starcellbio_html/statuses/{sha}","languages_url":"https://api.github.com/repos/starteam/starcellbio_html/languages","stargazers_url":"https://api.github.com/repos/starteam/starcellbio_html/stargazers","contributors_url":"https://api.github.com/repos/starteam/starcellbio_html/contributors","subscribers_url":"https://api.github.com/repos/starteam/starcellbio_html/subscribers","subscription_url":"https://api.github.com/repos/starteam/starcellbio_html/subscription","commits_url":"https://api.github.com/repos/starteam/starcellbio_html/commits{/sha}","git_commits_url":"https://api.github.com/repos/starteam/starcellbio_html/git/commits{/sha}","comments_url":"https://api.github.com/repos/starteam/starcellbio_html/comments{/number}","issue_comment_url":"https://api.github.com/repos/starteam/starcellbio_html/issues/comments{/number}","contents_url":"https://api.github.com/repos/starteam/starcellbio_html/contents/{+path}","compare_url":"https://api.github.com/repos/starteam/starcellbio_html/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starteam/starcellbio_html/merges","archive_url":"https://api.github.com/repos/starteam/starcellbio_html/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starteam/starcellbio_html/downloads","issues_url":"https://api.github.com/repos/starteam/starcellbio_html/issues{/number}","pulls_url":"https://api.github.com/repos/starteam/starcellbio_html/pulls{/number}","milestones_url":"https://api.github.com/repos/starteam/starcellbio_html/milestones{/number}","notifications_url":"https://api.github.com/repos/starteam/starcellbio_html/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starteam/starcellbio_html/labels{/name}","releases_url":"https://api.github.com/repos/starteam/starcellbio_html/releases{/id}","created_at":"2012-12-04T19:09:23Z","updated_at":"2015-02-10T22:51:32Z","pushed_at":"2015-03-05T15:55:50Z","git_url":"git://github.com/starteam/starcellbio_html.git","ssh_url":"git@github.com:starteam/starcellbio_html.git","clone_url":"https://github.com/starteam/starcellbio_html.git","svn_url":"https://github.com/starteam/starcellbio_html","homepage":null,"size":585337,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":33,"forks":6,"open_issues":33,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32"},"html":{"href":"https://github.com/starteam/starcellbio_html/pull/32"},"issue":{"href":"https://api.github.com/repos/starteam/starcellbio_html/issues/32"},"comments":{"href":"https://api.github.com/repos/starteam/starcellbio_html/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/starteam/starcellbio_html/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/starteam/starcellbio_html/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/starteam/starcellbio_html/statuses/6cdd7d848763e88ef60c17f289a9b24a2571ee7f"}}}}