{"action":"created","comment":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments/45233575","id":45233575,"diff_hunk":"@@ -0,0 +1,95 @@\n+﻿<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<Project ToolsVersion=\"12.0\" DefaultTargets=\"Build\" xmlns=\"http://schemas.microsoft.com/developer/msbuild/2003\">\n+  <Import Project=\"$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\Microsoft.Common.props\" Condition=\"Exists('$(MSBuildExtensionsPath)\\$(MSBuildToolsVersion)\\Microsoft.Common.props')\" />\n+  <PropertyGroup>\n+    <Configuration Condition=\" '$(Configuration)' == '' \">Debug</Configuration>\n+    <Platform Condition=\" '$(Platform)' == '' \">AnyCPU</Platform>\n+    <SchemaVersion>2.0</SchemaVersion>\n+    <ProjectGuid>b1bdd96d-47e1-4e65-8107-fbae23a06db4</ProjectGuid>\n+    <OutputType>Exe</OutputType>\n+    <RootNamespace>FSharp.Compiler.Service.ProjectCracker</RootNamespace>\n+    <AssemblyName>FSharp.Compiler.Service.ProjectCracker</AssemblyName>\n+    <TargetFrameworkVersion Condition=\" '$(TargetFrameworkVersion)' == '' \">v4.5</TargetFrameworkVersion>\n+    <TargetFSharpCoreVersion>4.3.0.0</TargetFSharpCoreVersion>\n+    <SolutionDir Condition=\"$(SolutionDir) == '' Or $(SolutionDir) == '*Undefined*'\">..\\..\\..\\</SolutionDir>\n+    <Name>FSharp.Compiler.Service.ProjectCracker</Name>\n+    <OtherFlags>$(OtherFlags) --staticlink:FSharp.Core</OtherFlags>\n+    <NoWarn>$(NoWarn);40</NoWarn>\n+  </PropertyGroup>\n+  <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'Debug|AnyCPU' \">\n+    <DebugSymbols>true</DebugSymbols>\n+    <DebugType>full</DebugType>\n+    <Optimize>false</Optimize>\n+    <Tailcalls>false</Tailcalls>\n+    <OutputPath>bin\\Debug\\</OutputPath>\n+    <DefineConstants>DEBUG;TRACE</DefineConstants>\n+    <WarningLevel>3</WarningLevel>\n+    <PlatformTarget>AnyCPU</PlatformTarget>\n+    <DocumentationFile>bin\\Debug\\FSharp.Compiler.Service.ProjectCracker.XML</DocumentationFile>\n+    <Prefer32Bit>true</Prefer32Bit>\n+  </PropertyGroup>\n+  <PropertyGroup Condition=\" '$(Configuration)|$(Platform)' == 'Release|AnyCPU' \">\n+    <DebugType>pdbonly</DebugType>\n+    <Optimize>true</Optimize>\n+    <Tailcalls>true</Tailcalls>\n+    <OutputPath>bin\\Release\\</OutputPath>\n+    <DefineConstants>TRACE</DefineConstants>\n+    <WarningLevel>3</WarningLevel>\n+    <PlatformTarget>AnyCPU</PlatformTarget>\n+    <DocumentationFile>bin\\Release\\FSharp.Compiler.Service.ProjectCracker.XML</DocumentationFile>\n+    <Prefer32Bit>true</Prefer32Bit>\n+  </PropertyGroup>\n+  <ItemGroup>\n+    <Reference Include=\"Microsoft.Build.Framework\" Condition=\" '$(TargetFrameworkVersion)' == 'v4.0'\" />\n+    <Reference Include=\"Microsoft.Build.Engine\" Condition=\" '$(TargetFrameworkVersion)' == 'v4.0'\" />\n+    <Reference Include=\"Microsoft.Build\" Condition=\" '$(TargetFrameworkVersion)' == 'v4.0'\" />\n+    <Reference Include=\"Microsoft.Build.Utilities.v4.0\" Condition=\" '$(TargetFrameworkVersion)' == 'v4.0'\" />\n+    <Reference Include=\"Microsoft.Build.Framework, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a\" Condition=\" '$(TargetFrameworkVersion)' == 'v4.5'\">","path":"src/fsharp/FSharp.Compiler.Service.ProjectCracker/FSharp.Compiler.Service.ProjectCracker.fsproj","position":47,"original_position":47,"commit_id":"85a3a4371ed1651e761d2bf58cac90a33fa43eb9","original_commit_id":"85a3a4371ed1651e761d2bf58cac90a33fa43eb9","user":{"login":"rneatherway","id":243995,"avatar_url":"https://avatars.githubusercontent.com/u/243995?v=3","gravatar_id":"","url":"https://api.github.com/users/rneatherway","html_url":"https://github.com/rneatherway","followers_url":"https://api.github.com/users/rneatherway/followers","following_url":"https://api.github.com/users/rneatherway/following{/other_user}","gists_url":"https://api.github.com/users/rneatherway/gists{/gist_id}","starred_url":"https://api.github.com/users/rneatherway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rneatherway/subscriptions","organizations_url":"https://api.github.com/users/rneatherway/orgs","repos_url":"https://api.github.com/users/rneatherway/repos","events_url":"https://api.github.com/users/rneatherway/events{/privacy}","received_events_url":"https://api.github.com/users/rneatherway/received_events","type":"User","site_admin":false},"body":"I'm not 100% sure. I only envisage using the version 12 dependencies. I just copied the pattern used in FCS.fsproj for the past while. I'm testing without it now.","created_at":"2015-11-18T17:48:02Z","updated_at":"2015-11-18T17:48:02Z","html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/464#discussion_r45233575","pull_request_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464","_links":{"self":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments/45233575"},"html":{"href":"https://github.com/fsharp/FSharp.Compiler.Service/pull/464#discussion_r45233575"},"pull_request":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464"}}},"pull_request":{"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464","id":50962532,"html_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/464","diff_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/464.diff","patch_url":"https://github.com/fsharp/FSharp.Compiler.Service/pull/464.patch","issue_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/464","number":464,"state":"open","locked":false,"title":"Move FCS project cracking out of process","user":{"login":"rneatherway","id":243995,"avatar_url":"https://avatars.githubusercontent.com/u/243995?v=3","gravatar_id":"","url":"https://api.github.com/users/rneatherway","html_url":"https://github.com/rneatherway","followers_url":"https://api.github.com/users/rneatherway/followers","following_url":"https://api.github.com/users/rneatherway/following{/other_user}","gists_url":"https://api.github.com/users/rneatherway/gists{/gist_id}","starred_url":"https://api.github.com/users/rneatherway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rneatherway/subscriptions","organizations_url":"https://api.github.com/users/rneatherway/orgs","repos_url":"https://api.github.com/users/rneatherway/repos","events_url":"https://api.github.com/users/rneatherway/events{/privacy}","received_events_url":"https://api.github.com/users/rneatherway/received_events","type":"User","site_admin":false},"body":"This aims to fix many problems stemming from two main issues:\r\n\r\n* FCS depends on MSBuild v12, and not all machines have this installed.\r\n* It's hard to apply robust assembly redirects, as this is up to the\r\n  application referencing FCS. These are needed to redirect MSBuild v4\r\n  to whatever is being used (for custom MSBuild tasks), and also to\r\n  allow redirecting to MSBuild v14 if necessary.\r\n\r\nThe API is preserved, with an additional function,\r\n`GetProjectOptionsFromProjectFileLogged` to allow easier access to the\r\nlogs for presentation to users and bug-reporting.\r\n\r\nThe functionality is implemented by FCS calling a new console\r\napplication, FSharp.Compiler.Service.ProjectCracker.exe, and the\r\nresponse is transmitted via serialization using JSON to types shared by\r\na common source file, so there is no binary dependency between the two.\r\n\r\nThe ProjectCracker static links to FSharp.Core, as it is in the same\r\ndirectory as FCS.dll. Thus bundling a separate copy would force the\r\nchoice of version on all users of FCS, which is not acceptable.\r\n\r\n@dsyme this implements my suggestion from #459.","created_at":"2015-11-17T15:41:26Z","updated_at":"2015-11-18T17:48:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a47d8005b68ec1a6735e18fcde6df9d666ef529e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464/commits","review_comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464/comments","review_comment_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/464/comments","statuses_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/statuses/85a3a4371ed1651e761d2bf58cac90a33fa43eb9","head":{"label":"rneatherway:projects-out-of-process-json-clean","ref":"projects-out-of-process-json-clean","sha":"85a3a4371ed1651e761d2bf58cac90a33fa43eb9","user":{"login":"rneatherway","id":243995,"avatar_url":"https://avatars.githubusercontent.com/u/243995?v=3","gravatar_id":"","url":"https://api.github.com/users/rneatherway","html_url":"https://github.com/rneatherway","followers_url":"https://api.github.com/users/rneatherway/followers","following_url":"https://api.github.com/users/rneatherway/following{/other_user}","gists_url":"https://api.github.com/users/rneatherway/gists{/gist_id}","starred_url":"https://api.github.com/users/rneatherway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rneatherway/subscriptions","organizations_url":"https://api.github.com/users/rneatherway/orgs","repos_url":"https://api.github.com/users/rneatherway/repos","events_url":"https://api.github.com/users/rneatherway/events{/privacy}","received_events_url":"https://api.github.com/users/rneatherway/received_events","type":"User","site_admin":false},"repo":{"id":13725994,"name":"FSharp.Compiler.Service","full_name":"rneatherway/FSharp.Compiler.Service","owner":{"login":"rneatherway","id":243995,"avatar_url":"https://avatars.githubusercontent.com/u/243995?v=3","gravatar_id":"","url":"https://api.github.com/users/rneatherway","html_url":"https://github.com/rneatherway","followers_url":"https://api.github.com/users/rneatherway/followers","following_url":"https://api.github.com/users/rneatherway/following{/other_user}","gists_url":"https://api.github.com/users/rneatherway/gists{/gist_id}","starred_url":"https://api.github.com/users/rneatherway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rneatherway/subscriptions","organizations_url":"https://api.github.com/users/rneatherway/orgs","repos_url":"https://api.github.com/users/rneatherway/repos","events_url":"https://api.github.com/users/rneatherway/events{/privacy}","received_events_url":"https://api.github.com/users/rneatherway/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rneatherway/FSharp.Compiler.Service","description":"Modified clone of F# compiler exposing additional functionality for editing clients","fork":true,"url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service","forks_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/forks","keys_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/teams","hooks_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/hooks","issue_events_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/issues/events{/number}","events_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/events","assignees_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/assignees{/user}","branches_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/branches{/branch}","tags_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/tags","blobs_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/git/refs{/sha}","trees_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/statuses/{sha}","languages_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/languages","stargazers_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/stargazers","contributors_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/contributors","subscribers_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/subscribers","subscription_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/subscription","commits_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/commits{/sha}","git_commits_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/git/commits{/sha}","comments_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/comments{/number}","issue_comment_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/issues/comments{/number}","contents_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/contents/{+path}","compare_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/merges","archive_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/downloads","issues_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/issues{/number}","pulls_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/pulls{/number}","milestones_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/milestones{/number}","notifications_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/labels{/name}","releases_url":"https://api.github.com/repos/rneatherway/FSharp.Compiler.Service/releases{/id}","created_at":"2013-10-20T20:09:35Z","updated_at":"2014-10-17T17:41:24Z","pushed_at":"2015-11-18T17:44:43Z","git_url":"git://github.com/rneatherway/FSharp.Compiler.Service.git","ssh_url":"git@github.com:rneatherway/FSharp.Compiler.Service.git","clone_url":"https://github.com/rneatherway/FSharp.Compiler.Service.git","svn_url":"https://github.com/rneatherway/FSharp.Compiler.Service","homepage":null,"size":121972,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fsharp:master","ref":"master","sha":"839bab6f22aed50844862e88d880324cab04f226","user":{"login":"fsharp","id":485415,"avatar_url":"https://avatars.githubusercontent.com/u/485415?v=3","gravatar_id":"","url":"https://api.github.com/users/fsharp","html_url":"https://github.com/fsharp","followers_url":"https://api.github.com/users/fsharp/followers","following_url":"https://api.github.com/users/fsharp/following{/other_user}","gists_url":"https://api.github.com/users/fsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/fsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsharp/subscriptions","organizations_url":"https://api.github.com/users/fsharp/orgs","repos_url":"https://api.github.com/users/fsharp/repos","events_url":"https://api.github.com/users/fsharp/events{/privacy}","received_events_url":"https://api.github.com/users/fsharp/received_events","type":"Organization","site_admin":false},"repo":{"id":13227260,"name":"FSharp.Compiler.Service","full_name":"fsharp/FSharp.Compiler.Service","owner":{"login":"fsharp","id":485415,"avatar_url":"https://avatars.githubusercontent.com/u/485415?v=3","gravatar_id":"","url":"https://api.github.com/users/fsharp","html_url":"https://github.com/fsharp","followers_url":"https://api.github.com/users/fsharp/followers","following_url":"https://api.github.com/users/fsharp/following{/other_user}","gists_url":"https://api.github.com/users/fsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/fsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fsharp/subscriptions","organizations_url":"https://api.github.com/users/fsharp/orgs","repos_url":"https://api.github.com/users/fsharp/repos","events_url":"https://api.github.com/users/fsharp/events{/privacy}","received_events_url":"https://api.github.com/users/fsharp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fsharp/FSharp.Compiler.Service","description":"F# compiler component exposing additional functionality for editing clients","fork":false,"url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service","forks_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/forks","keys_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/teams","hooks_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/hooks","issue_events_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/events{/number}","events_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/events","assignees_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/assignees{/user}","branches_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/branches{/branch}","tags_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/tags","blobs_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/refs{/sha}","trees_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/statuses/{sha}","languages_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/languages","stargazers_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/stargazers","contributors_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/contributors","subscribers_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/subscribers","subscription_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/subscription","commits_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/commits{/sha}","git_commits_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/git/commits{/sha}","comments_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/comments{/number}","issue_comment_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/comments{/number}","contents_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/contents/{+path}","compare_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/merges","archive_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/downloads","issues_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues{/number}","pulls_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls{/number}","milestones_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/milestones{/number}","notifications_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/labels{/name}","releases_url":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/releases{/id}","created_at":"2013-09-30T21:01:56Z","updated_at":"2015-10-18T23:58:35Z","pushed_at":"2015-11-17T15:41:27Z","git_url":"git://github.com/fsharp/FSharp.Compiler.Service.git","ssh_url":"git@github.com:fsharp/FSharp.Compiler.Service.git","clone_url":"https://github.com/fsharp/FSharp.Compiler.Service.git","svn_url":"https://github.com/fsharp/FSharp.Compiler.Service","homepage":"http://fsharp.github.io/FSharp.Compiler.Service","size":136077,"stargazers_count":104,"watchers_count":104,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":63,"mirror_url":null,"open_issues_count":90,"forks":63,"open_issues":90,"watchers":104,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464"},"html":{"href":"https://github.com/fsharp/FSharp.Compiler.Service/pull/464"},"issue":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/464"},"comments":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/issues/464/comments"},"review_comments":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464/comments"},"review_comment":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/pulls/464/commits"},"statuses":{"href":"https://api.github.com/repos/fsharp/FSharp.Compiler.Service/statuses/85a3a4371ed1651e761d2bf58cac90a33fa43eb9"}}}}