{"action":"created","comment":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/22888563","id":22888563,"diff_hunk":"@@ -2,13 +2,63 @@\n \n /**\n  * Text input field with validation for numeric values. Supports validating\n- * the numeric value as to the {@link i18n::get_locale()} value.\n+ * the numeric value as to the {@link i18n::get_locale()} value, or an\n+ * overridden locale specific to this field.\n  * \n  * @package forms\n  * @subpackage fields-formattedinput\n  */\n class NumericField extends TextField {\n \n+\t/**\n+\t * @var string\n+\t */\n+\tprotected $locale = null;\n+\n+\tpublic function setValue($value, $data = array()) {","path":"forms/NumericField.php","position":18,"original_position":18,"commit_id":"5bdd3c08f1b3e9f5a0f3a3dd341ca22e9dfde5f6","original_commit_id":"5bdd3c08f1b3e9f5a0f3a3dd341ca22e9dfde5f6","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"PHPDoc for setValue? It's already specified on `FormField::setValue` and doesn't need to be redefined. It should inherit automatically.","created_at":"2015-01-13T19:44:14Z","updated_at":"2015-01-13T19:44:14Z","html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3008#discussion_r22888563","pull_request_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008","_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/22888563"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/3008#discussion_r22888563"},"pull_request":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008"}}},"pull_request":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008","id":14367844,"html_url":"https://github.com/silverstripe/silverstripe-framework/pull/3008","diff_url":"https://github.com/silverstripe/silverstripe-framework/pull/3008.diff","patch_url":"https://github.com/silverstripe/silverstripe-framework/pull/3008.patch","issue_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3008","number":3008,"state":"open","locked":false,"title":"BUG Fixed handling of numbers in certain locales.","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"body":"Fixes #2161\r\n\r\n@lekoala, @jurriaan, @andrelohmann \r\n\r\nDo you like this solution?\r\n\r\nCredit to @andrelohmann for beginning this solution.","created_at":"2014-04-04T04:52:16Z","updated_at":"2015-01-13T19:44:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"81ac1fe90064d30bf15faad81ef297521d6aa984","assignee":null,"milestone":{"url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/11","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones/11/labels","id":870643,"number":11,"title":"3.1.9","description":"","creator":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2014-11-18T05:38:05Z","updated_at":"2014-12-31T23:19:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008/commits","review_comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008/comments","review_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/{number}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3008/comments","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/5bdd3c08f1b3e9f5a0f3a3dd341ca22e9dfde5f6","head":{"label":"tractorcow:pulls/numeric-locale-fix","ref":"pulls/numeric-locale-fix","sha":"5bdd3c08f1b3e9f5a0f3a3dd341ca22e9dfde5f6","user":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"repo":{"id":5337017,"name":"sapphire","full_name":"tractorcow/sapphire","owner":{"login":"tractorcow","id":936064,"avatar_url":"https://avatars.githubusercontent.com/u/936064?v=3","gravatar_id":"","url":"https://api.github.com/users/tractorcow","html_url":"https://github.com/tractorcow","followers_url":"https://api.github.com/users/tractorcow/followers","following_url":"https://api.github.com/users/tractorcow/following{/other_user}","gists_url":"https://api.github.com/users/tractorcow/gists{/gist_id}","starred_url":"https://api.github.com/users/tractorcow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tractorcow/subscriptions","organizations_url":"https://api.github.com/users/tractorcow/orgs","repos_url":"https://api.github.com/users/tractorcow/repos","events_url":"https://api.github.com/users/tractorcow/events{/privacy}","received_events_url":"https://api.github.com/users/tractorcow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tractorcow/sapphire","description":"SilverStripe's Sapphire Framework","fork":true,"url":"https://api.github.com/repos/tractorcow/sapphire","forks_url":"https://api.github.com/repos/tractorcow/sapphire/forks","keys_url":"https://api.github.com/repos/tractorcow/sapphire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tractorcow/sapphire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tractorcow/sapphire/teams","hooks_url":"https://api.github.com/repos/tractorcow/sapphire/hooks","issue_events_url":"https://api.github.com/repos/tractorcow/sapphire/issues/events{/number}","events_url":"https://api.github.com/repos/tractorcow/sapphire/events","assignees_url":"https://api.github.com/repos/tractorcow/sapphire/assignees{/user}","branches_url":"https://api.github.com/repos/tractorcow/sapphire/branches{/branch}","tags_url":"https://api.github.com/repos/tractorcow/sapphire/tags","blobs_url":"https://api.github.com/repos/tractorcow/sapphire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tractorcow/sapphire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tractorcow/sapphire/git/refs{/sha}","trees_url":"https://api.github.com/repos/tractorcow/sapphire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tractorcow/sapphire/statuses/{sha}","languages_url":"https://api.github.com/repos/tractorcow/sapphire/languages","stargazers_url":"https://api.github.com/repos/tractorcow/sapphire/stargazers","contributors_url":"https://api.github.com/repos/tractorcow/sapphire/contributors","subscribers_url":"https://api.github.com/repos/tractorcow/sapphire/subscribers","subscription_url":"https://api.github.com/repos/tractorcow/sapphire/subscription","commits_url":"https://api.github.com/repos/tractorcow/sapphire/commits{/sha}","git_commits_url":"https://api.github.com/repos/tractorcow/sapphire/git/commits{/sha}","comments_url":"https://api.github.com/repos/tractorcow/sapphire/comments{/number}","issue_comment_url":"https://api.github.com/repos/tractorcow/sapphire/issues/comments/{number}","contents_url":"https://api.github.com/repos/tractorcow/sapphire/contents/{+path}","compare_url":"https://api.github.com/repos/tractorcow/sapphire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tractorcow/sapphire/merges","archive_url":"https://api.github.com/repos/tractorcow/sapphire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tractorcow/sapphire/downloads","issues_url":"https://api.github.com/repos/tractorcow/sapphire/issues{/number}","pulls_url":"https://api.github.com/repos/tractorcow/sapphire/pulls{/number}","milestones_url":"https://api.github.com/repos/tractorcow/sapphire/milestones{/number}","notifications_url":"https://api.github.com/repos/tractorcow/sapphire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tractorcow/sapphire/labels{/name}","releases_url":"https://api.github.com/repos/tractorcow/sapphire/releases{/id}","created_at":"2012-08-08T04:07:21Z","updated_at":"2014-08-10T21:24:26Z","pushed_at":"2015-01-13T05:30:13Z","git_url":"git://github.com/tractorcow/sapphire.git","ssh_url":"git@github.com:tractorcow/sapphire.git","clone_url":"https://github.com/tractorcow/sapphire.git","svn_url":"https://github.com/tractorcow/sapphire","homepage":"http://silverstripe.org/","size":52801,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"3.1"}},"base":{"label":"silverstripe:3.1","ref":"3.1","sha":"cf9c6666dd5480ec4931cbb0aa1c6037f152491c","user":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"repo":{"id":1318892,"name":"silverstripe-framework","full_name":"silverstripe/silverstripe-framework","owner":{"login":"silverstripe","id":379348,"avatar_url":"https://avatars.githubusercontent.com/u/379348?v=3","gravatar_id":"","url":"https://api.github.com/users/silverstripe","html_url":"https://github.com/silverstripe","followers_url":"https://api.github.com/users/silverstripe/followers","following_url":"https://api.github.com/users/silverstripe/following{/other_user}","gists_url":"https://api.github.com/users/silverstripe/gists{/gist_id}","starred_url":"https://api.github.com/users/silverstripe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/silverstripe/subscriptions","organizations_url":"https://api.github.com/users/silverstripe/orgs","repos_url":"https://api.github.com/users/silverstripe/repos","events_url":"https://api.github.com/users/silverstripe/events{/privacy}","received_events_url":"https://api.github.com/users/silverstripe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/silverstripe/silverstripe-framework","description":"SilverStripe Framework, the MVC framework that powers SilverStripe CMS","fork":false,"url":"https://api.github.com/repos/silverstripe/silverstripe-framework","forks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/forks","keys_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/teams","hooks_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/hooks","issue_events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/events{/number}","events_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/events","assignees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/assignees{/user}","branches_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/branches{/branch}","tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/tags","blobs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/languages","stargazers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/stargazers","contributors_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contributors","subscribers_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscribers","subscription_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/subscription","commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/comments/{number}","contents_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/contents/{+path}","compare_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/merges","archive_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/downloads","issues_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues{/number}","pulls_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/labels{/name}","releases_url":"https://api.github.com/repos/silverstripe/silverstripe-framework/releases{/id}","created_at":"2011-02-02T02:04:13Z","updated_at":"2015-01-13T05:28:30Z","pushed_at":"2015-01-13T03:27:02Z","git_url":"git://github.com/silverstripe/silverstripe-framework.git","ssh_url":"git@github.com:silverstripe/silverstripe-framework.git","clone_url":"https://github.com/silverstripe/silverstripe-framework.git","svn_url":"https://github.com/silverstripe/silverstripe-framework","homepage":"http://silverstripe.org/","size":96689,"stargazers_count":415,"watchers_count":415,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":448,"mirror_url":null,"open_issues_count":535,"forks":448,"open_issues":535,"watchers":415,"default_branch":"3.1"}},"_links":{"self":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008"},"html":{"href":"https://github.com/silverstripe/silverstripe-framework/pull/3008"},"issue":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3008"},"comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/issues/3008/comments"},"review_comments":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008/comments"},"review_comment":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/pulls/3008/commits"},"statuses":{"href":"https://api.github.com/repos/silverstripe/silverstripe-framework/statuses/5bdd3c08f1b3e9f5a0f3a3dd341ca22e9dfde5f6"}}}}