{"action":"created","issue":{"url":"https://api.github.com/repos/matteodem/meteor-easy-search/issues/344","labels_url":"https://api.github.com/repos/matteodem/meteor-easy-search/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/matteodem/meteor-easy-search/issues/344/comments","events_url":"https://api.github.com/repos/matteodem/meteor-easy-search/issues/344/events","html_url":"https://github.com/matteodem/meteor-easy-search/issues/344","id":114244022,"number":344,"title":"Does this package need to use lodash?","user":{"login":"rjsmith","id":678653,"avatar_url":"https://avatars.githubusercontent.com/u/678653?v=3","gravatar_id":"","url":"https://api.github.com/users/rjsmith","html_url":"https://github.com/rjsmith","followers_url":"https://api.github.com/users/rjsmith/followers","following_url":"https://api.github.com/users/rjsmith/following{/other_user}","gists_url":"https://api.github.com/users/rjsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/rjsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjsmith/subscriptions","organizations_url":"https://api.github.com/users/rjsmith/orgs","repos_url":"https://api.github.com/users/rjsmith/repos","events_url":"https://api.github.com/users/rjsmith/events{/privacy}","received_events_url":"https://api.github.com/users/rjsmith/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/matteodem/meteor-easy-search/labels/enhancement","name":"enhancement","color":"c7def8"},{"url":"https://api.github.com/repos/matteodem/meteor-easy-search/labels/Project:Components","name":"Project:Components","color":"5319e7"},{"url":"https://api.github.com/repos/matteodem/meteor-easy-search/labels/Project:Core","name":"Project:Core","color":"207de5"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-30T10:37:16Z","updated_at":"2015-10-30T14:26:14Z","closed_at":null,"body":"Hi,\r\nI spotted that easy:core and easy:components both declare a dependency on erasaur:meteor-lodash. This adds the lodash library to my application (250kb unzipped) .. I have not been using it previously, nor it seems has any of the other 50+ community packages I use in my application so far. I would prefer not to be forced to incorporate lodash into my app at this point .. but I do still want to use meteor-easy-search.\r\n\r\nI experimented with a local fork to replace with the meteor-platform 'underscore' library in both `easy:core` and `easy:components` packages. The only issue I found was on this line which uses the `_.assign` lodash method .. I replaced it with _.extend:\r\n\r\nhttps://github.com/matteodem/meteor-easy-search/blob/master/packages/easysearch:core/lib/core/index.js#L26\r\n\r\nReplaced with:\r\n```javascript\r\n    this.config = _.extend({}, Index.defaultConfiguration, config);\r\n```\r\n\r\nWould you accept a PR that changes that breaking line above, and changes the dependency on lodash to be [`weak`](http://docs.meteor.com/#/full/pack_use) instead?\r\n"},"comment":{"url":"https://api.github.com/repos/matteodem/meteor-easy-search/issues/comments/152540173","html_url":"https://github.com/matteodem/meteor-easy-search/issues/344#issuecomment-152540173","issue_url":"https://api.github.com/repos/matteodem/meteor-easy-search/issues/344","id":152540173,"user":{"login":"rjsmith","id":678653,"avatar_url":"https://avatars.githubusercontent.com/u/678653?v=3","gravatar_id":"","url":"https://api.github.com/users/rjsmith","html_url":"https://github.com/rjsmith","followers_url":"https://api.github.com/users/rjsmith/followers","following_url":"https://api.github.com/users/rjsmith/following{/other_user}","gists_url":"https://api.github.com/users/rjsmith/gists{/gist_id}","starred_url":"https://api.github.com/users/rjsmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjsmith/subscriptions","organizations_url":"https://api.github.com/users/rjsmith/orgs","repos_url":"https://api.github.com/users/rjsmith/repos","events_url":"https://api.github.com/users/rjsmith/events{/privacy}","received_events_url":"https://api.github.com/users/rjsmith/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T14:26:14Z","updated_at":"2015-10-30T14:26:14Z","body":"Hi @matteodem . I have a local commit ready that I could submit as a PR ... please let me know."}}