{"action":"closed","number":101,"pull_request":{"url":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/101","id":50909068,"html_url":"https://github.com/go-fsnotify/fsnotify/pull/101","diff_url":"https://github.com/go-fsnotify/fsnotify/pull/101.diff","patch_url":"https://github.com/go-fsnotify/fsnotify/pull/101.patch","issue_url":"https://api.github.com/repos/go-fsnotify/fsnotify/issues/101","number":101,"state":"closed","locked":false,"title":"Avoid infinite loops from symlinks cycles","user":{"login":"illicitonion","id":1131704,"avatar_url":"https://avatars.githubusercontent.com/u/1131704?v=3","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"body":"The semenatics of using kqueue are already slightly different than\r\ninotify, specifically that inotify will give you events for the symlink\r\nitself whereas kqueue will only give events for the target of the\r\nsymlink. This preserves that behaviour, that symlinks don't get notified\r\non, but ensures that circular symlinks don't recurse forever.\r\n\r\nThis change pushes the resolved filename up through the stack so that\r\nthe fileExists map can be properly populated; not doing so would mean\r\nthat deleting a cyclical symlink and then replacing it with a file of\r\nthe same name would not notify for that file's creation (or subsequent\r\nevents) because we would believe that the file already existed.","created_at":"2015-11-17T06:26:14Z","updated_at":"2015-11-17T21:51:27Z","closed_at":"2015-11-17T21:51:27Z","merged_at":null,"merge_commit_sha":"f789fc7e9233d7d750400a362f52f21e11e00368","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/101/commits","review_comments_url":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/101/comments","review_comment_url":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-fsnotify/fsnotify/issues/101/comments","statuses_url":"https://api.github.com/repos/go-fsnotify/fsnotify/statuses/4dc42d07d916c3aa2a40614372f2925e59420b9e","head":{"label":"illicitonion:symlinkloops","ref":"symlinkloops","sha":"4dc42d07d916c3aa2a40614372f2925e59420b9e","user":{"login":"illicitonion","id":1131704,"avatar_url":"https://avatars.githubusercontent.com/u/1131704?v=3","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"repo":{"id":46327302,"name":"fsnotify","full_name":"illicitonion/fsnotify","owner":{"login":"illicitonion","id":1131704,"avatar_url":"https://avatars.githubusercontent.com/u/1131704?v=3","gravatar_id":"","url":"https://api.github.com/users/illicitonion","html_url":"https://github.com/illicitonion","followers_url":"https://api.github.com/users/illicitonion/followers","following_url":"https://api.github.com/users/illicitonion/following{/other_user}","gists_url":"https://api.github.com/users/illicitonion/gists{/gist_id}","starred_url":"https://api.github.com/users/illicitonion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/illicitonion/subscriptions","organizations_url":"https://api.github.com/users/illicitonion/orgs","repos_url":"https://api.github.com/users/illicitonion/repos","events_url":"https://api.github.com/users/illicitonion/events{/privacy}","received_events_url":"https://api.github.com/users/illicitonion/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/illicitonion/fsnotify","description":"File system notifications for Go.","fork":true,"url":"https://api.github.com/repos/illicitonion/fsnotify","forks_url":"https://api.github.com/repos/illicitonion/fsnotify/forks","keys_url":"https://api.github.com/repos/illicitonion/fsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/illicitonion/fsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/illicitonion/fsnotify/teams","hooks_url":"https://api.github.com/repos/illicitonion/fsnotify/hooks","issue_events_url":"https://api.github.com/repos/illicitonion/fsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/illicitonion/fsnotify/events","assignees_url":"https://api.github.com/repos/illicitonion/fsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/illicitonion/fsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/illicitonion/fsnotify/tags","blobs_url":"https://api.github.com/repos/illicitonion/fsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/illicitonion/fsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/illicitonion/fsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/illicitonion/fsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/illicitonion/fsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/illicitonion/fsnotify/languages","stargazers_url":"https://api.github.com/repos/illicitonion/fsnotify/stargazers","contributors_url":"https://api.github.com/repos/illicitonion/fsnotify/contributors","subscribers_url":"https://api.github.com/repos/illicitonion/fsnotify/subscribers","subscription_url":"https://api.github.com/repos/illicitonion/fsnotify/subscription","commits_url":"https://api.github.com/repos/illicitonion/fsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/illicitonion/fsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/illicitonion/fsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/illicitonion/fsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/illicitonion/fsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/illicitonion/fsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/illicitonion/fsnotify/merges","archive_url":"https://api.github.com/repos/illicitonion/fsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/illicitonion/fsnotify/downloads","issues_url":"https://api.github.com/repos/illicitonion/fsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/illicitonion/fsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/illicitonion/fsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/illicitonion/fsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/illicitonion/fsnotify/labels{/name}","releases_url":"https://api.github.com/repos/illicitonion/fsnotify/releases{/id}","created_at":"2015-11-17T06:19:29Z","updated_at":"2015-11-17T06:19:30Z","pushed_at":"2015-11-17T21:24:20Z","git_url":"git://github.com/illicitonion/fsnotify.git","ssh_url":"git@github.com:illicitonion/fsnotify.git","clone_url":"https://github.com/illicitonion/fsnotify.git","svn_url":"https://github.com/illicitonion/fsnotify","homepage":"https://fsnotify.org/","size":280,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-fsnotify:master","ref":"master","sha":"7be54206639f256967dd82fa767397ba5f8f48f5","user":{"login":"go-fsnotify","id":8013877,"avatar_url":"https://avatars.githubusercontent.com/u/8013877?v=3","gravatar_id":"","url":"https://api.github.com/users/go-fsnotify","html_url":"https://github.com/go-fsnotify","followers_url":"https://api.github.com/users/go-fsnotify/followers","following_url":"https://api.github.com/users/go-fsnotify/following{/other_user}","gists_url":"https://api.github.com/users/go-fsnotify/gists{/gist_id}","starred_url":"https://api.github.com/users/go-fsnotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-fsnotify/subscriptions","organizations_url":"https://api.github.com/users/go-fsnotify/orgs","repos_url":"https://api.github.com/users/go-fsnotify/repos","events_url":"https://api.github.com/users/go-fsnotify/events{/privacy}","received_events_url":"https://api.github.com/users/go-fsnotify/received_events","type":"Organization","site_admin":false},"repo":{"id":21306961,"name":"fsnotify","full_name":"go-fsnotify/fsnotify","owner":{"login":"go-fsnotify","id":8013877,"avatar_url":"https://avatars.githubusercontent.com/u/8013877?v=3","gravatar_id":"","url":"https://api.github.com/users/go-fsnotify","html_url":"https://github.com/go-fsnotify","followers_url":"https://api.github.com/users/go-fsnotify/followers","following_url":"https://api.github.com/users/go-fsnotify/following{/other_user}","gists_url":"https://api.github.com/users/go-fsnotify/gists{/gist_id}","starred_url":"https://api.github.com/users/go-fsnotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-fsnotify/subscriptions","organizations_url":"https://api.github.com/users/go-fsnotify/orgs","repos_url":"https://api.github.com/users/go-fsnotify/repos","events_url":"https://api.github.com/users/go-fsnotify/events{/privacy}","received_events_url":"https://api.github.com/users/go-fsnotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-fsnotify/fsnotify","description":"File system notifications for Go.","fork":false,"url":"https://api.github.com/repos/go-fsnotify/fsnotify","forks_url":"https://api.github.com/repos/go-fsnotify/fsnotify/forks","keys_url":"https://api.github.com/repos/go-fsnotify/fsnotify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-fsnotify/fsnotify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-fsnotify/fsnotify/teams","hooks_url":"https://api.github.com/repos/go-fsnotify/fsnotify/hooks","issue_events_url":"https://api.github.com/repos/go-fsnotify/fsnotify/issues/events{/number}","events_url":"https://api.github.com/repos/go-fsnotify/fsnotify/events","assignees_url":"https://api.github.com/repos/go-fsnotify/fsnotify/assignees{/user}","branches_url":"https://api.github.com/repos/go-fsnotify/fsnotify/branches{/branch}","tags_url":"https://api.github.com/repos/go-fsnotify/fsnotify/tags","blobs_url":"https://api.github.com/repos/go-fsnotify/fsnotify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-fsnotify/fsnotify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-fsnotify/fsnotify/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-fsnotify/fsnotify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-fsnotify/fsnotify/statuses/{sha}","languages_url":"https://api.github.com/repos/go-fsnotify/fsnotify/languages","stargazers_url":"https://api.github.com/repos/go-fsnotify/fsnotify/stargazers","contributors_url":"https://api.github.com/repos/go-fsnotify/fsnotify/contributors","subscribers_url":"https://api.github.com/repos/go-fsnotify/fsnotify/subscribers","subscription_url":"https://api.github.com/repos/go-fsnotify/fsnotify/subscription","commits_url":"https://api.github.com/repos/go-fsnotify/fsnotify/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-fsnotify/fsnotify/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-fsnotify/fsnotify/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-fsnotify/fsnotify/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-fsnotify/fsnotify/contents/{+path}","compare_url":"https://api.github.com/repos/go-fsnotify/fsnotify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-fsnotify/fsnotify/merges","archive_url":"https://api.github.com/repos/go-fsnotify/fsnotify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-fsnotify/fsnotify/downloads","issues_url":"https://api.github.com/repos/go-fsnotify/fsnotify/issues{/number}","pulls_url":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls{/number}","milestones_url":"https://api.github.com/repos/go-fsnotify/fsnotify/milestones{/number}","notifications_url":"https://api.github.com/repos/go-fsnotify/fsnotify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-fsnotify/fsnotify/labels{/name}","releases_url":"https://api.github.com/repos/go-fsnotify/fsnotify/releases{/id}","created_at":"2014-06-28T16:47:01Z","updated_at":"2015-11-17T15:56:35Z","pushed_at":"2015-11-17T21:50:45Z","git_url":"git://github.com/go-fsnotify/fsnotify.git","ssh_url":"git@github.com:go-fsnotify/fsnotify.git","clone_url":"https://github.com/go-fsnotify/fsnotify.git","svn_url":"https://github.com/go-fsnotify/fsnotify","homepage":"https://fsnotify.org/","size":349,"stargazers_count":664,"watchers_count":664,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":52,"forks":79,"open_issues":52,"watchers":664,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/101"},"html":{"href":"https://github.com/go-fsnotify/fsnotify/pull/101"},"issue":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/issues/101"},"comments":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/issues/101/comments"},"review_comments":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/101/comments"},"review_comment":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/pulls/101/commits"},"statuses":{"href":"https://api.github.com/repos/go-fsnotify/fsnotify/statuses/4dc42d07d916c3aa2a40614372f2925e59420b9e"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":5,"commits":3,"additions":76,"deletions":15,"changed_files":2}}