{"action":"closed","number":342,"pull_request":{"url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/342","id":29632375,"html_url":"https://github.com/aspnetboilerplate/aspnetboilerplate/pull/342","diff_url":"https://github.com/aspnetboilerplate/aspnetboilerplate/pull/342.diff","patch_url":"https://github.com/aspnetboilerplate/aspnetboilerplate/pull/342.patch","issue_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues/342","number":342,"state":"closed","locked":false,"title":"Update SettingManager Class","user":{"login":"emaish","id":6557160,"avatar_url":"https://avatars.githubusercontent.com/u/6557160?v=3","gravatar_id":"","url":"https://api.github.com/users/emaish","html_url":"https://github.com/emaish","followers_url":"https://api.github.com/users/emaish/followers","following_url":"https://api.github.com/users/emaish/following{/other_user}","gists_url":"https://api.github.com/users/emaish/gists{/gist_id}","starred_url":"https://api.github.com/users/emaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaish/subscriptions","organizations_url":"https://api.github.com/users/emaish/orgs","repos_url":"https://api.github.com/users/emaish/repos","events_url":"https://api.github.com/users/emaish/events{/privacy}","received_events_url":"https://api.github.com/users/emaish/received_events","type":"User","site_admin":false},"body":"i made a change in the SettingManager class .GetSettingValueAsync and GetAllSettingValuesAsync methods.\r\nBecause Setting Value for Application should always be considered regardless the setting definition scope. Because if setting definition scope is \"User\" or \"Tenant\" and no value inserted yet in database it should get the value from saved Application Value ( Value with TenantId and UserId equal null) if available .","created_at":"2015-02-19T17:43:57Z","updated_at":"2015-03-04T12:05:40Z","closed_at":"2015-03-04T12:05:40Z","merged_at":null,"merge_commit_sha":"610a9ea91b86ca87d081e60d86b89d31dbc7d340","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/342/commits","review_comments_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/342/comments","review_comment_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues/342/comments","statuses_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/statuses/83b7dc9d961632860b79b36e7c0f87214bd73355","head":{"label":"emaish:emaish-patch-1","ref":"emaish-patch-1","sha":"83b7dc9d961632860b79b36e7c0f87214bd73355","user":{"login":"emaish","id":6557160,"avatar_url":"https://avatars.githubusercontent.com/u/6557160?v=3","gravatar_id":"","url":"https://api.github.com/users/emaish","html_url":"https://github.com/emaish","followers_url":"https://api.github.com/users/emaish/followers","following_url":"https://api.github.com/users/emaish/following{/other_user}","gists_url":"https://api.github.com/users/emaish/gists{/gist_id}","starred_url":"https://api.github.com/users/emaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaish/subscriptions","organizations_url":"https://api.github.com/users/emaish/orgs","repos_url":"https://api.github.com/users/emaish/repos","events_url":"https://api.github.com/users/emaish/events{/privacy}","received_events_url":"https://api.github.com/users/emaish/received_events","type":"User","site_admin":false},"repo":{"id":31026263,"name":"aspnetboilerplate","full_name":"emaish/aspnetboilerplate","owner":{"login":"emaish","id":6557160,"avatar_url":"https://avatars.githubusercontent.com/u/6557160?v=3","gravatar_id":"","url":"https://api.github.com/users/emaish","html_url":"https://github.com/emaish","followers_url":"https://api.github.com/users/emaish/followers","following_url":"https://api.github.com/users/emaish/following{/other_user}","gists_url":"https://api.github.com/users/emaish/gists{/gist_id}","starred_url":"https://api.github.com/users/emaish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emaish/subscriptions","organizations_url":"https://api.github.com/users/emaish/orgs","repos_url":"https://api.github.com/users/emaish/repos","events_url":"https://api.github.com/users/emaish/events{/privacy}","received_events_url":"https://api.github.com/users/emaish/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/emaish/aspnetboilerplate","description":"ASP.NET Boilerplate","fork":true,"url":"https://api.github.com/repos/emaish/aspnetboilerplate","forks_url":"https://api.github.com/repos/emaish/aspnetboilerplate/forks","keys_url":"https://api.github.com/repos/emaish/aspnetboilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/emaish/aspnetboilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/emaish/aspnetboilerplate/teams","hooks_url":"https://api.github.com/repos/emaish/aspnetboilerplate/hooks","issue_events_url":"https://api.github.com/repos/emaish/aspnetboilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/emaish/aspnetboilerplate/events","assignees_url":"https://api.github.com/repos/emaish/aspnetboilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/emaish/aspnetboilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/emaish/aspnetboilerplate/tags","blobs_url":"https://api.github.com/repos/emaish/aspnetboilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/emaish/aspnetboilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/emaish/aspnetboilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/emaish/aspnetboilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/emaish/aspnetboilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/emaish/aspnetboilerplate/languages","stargazers_url":"https://api.github.com/repos/emaish/aspnetboilerplate/stargazers","contributors_url":"https://api.github.com/repos/emaish/aspnetboilerplate/contributors","subscribers_url":"https://api.github.com/repos/emaish/aspnetboilerplate/subscribers","subscription_url":"https://api.github.com/repos/emaish/aspnetboilerplate/subscription","commits_url":"https://api.github.com/repos/emaish/aspnetboilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/emaish/aspnetboilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/emaish/aspnetboilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/emaish/aspnetboilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/emaish/aspnetboilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/emaish/aspnetboilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/emaish/aspnetboilerplate/merges","archive_url":"https://api.github.com/repos/emaish/aspnetboilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/emaish/aspnetboilerplate/downloads","issues_url":"https://api.github.com/repos/emaish/aspnetboilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/emaish/aspnetboilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/emaish/aspnetboilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/emaish/aspnetboilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/emaish/aspnetboilerplate/labels{/name}","releases_url":"https://api.github.com/repos/emaish/aspnetboilerplate/releases{/id}","created_at":"2015-02-19T17:06:51Z","updated_at":"2015-02-19T17:06:53Z","pushed_at":"2015-02-19T17:34:13Z","git_url":"git://github.com/emaish/aspnetboilerplate.git","ssh_url":"git@github.com:emaish/aspnetboilerplate.git","clone_url":"https://github.com/emaish/aspnetboilerplate.git","svn_url":"https://github.com/emaish/aspnetboilerplate","homepage":"http://www.aspnetboilerplate.com","size":9681,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aspnetboilerplate:master","ref":"master","sha":"285a28f5daec30866d3e01a4d2d8b49f7c2b7e2d","user":{"login":"aspnetboilerplate","id":5957277,"avatar_url":"https://avatars.githubusercontent.com/u/5957277?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnetboilerplate","html_url":"https://github.com/aspnetboilerplate","followers_url":"https://api.github.com/users/aspnetboilerplate/followers","following_url":"https://api.github.com/users/aspnetboilerplate/following{/other_user}","gists_url":"https://api.github.com/users/aspnetboilerplate/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnetboilerplate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnetboilerplate/subscriptions","organizations_url":"https://api.github.com/users/aspnetboilerplate/orgs","repos_url":"https://api.github.com/users/aspnetboilerplate/repos","events_url":"https://api.github.com/users/aspnetboilerplate/events{/privacy}","received_events_url":"https://api.github.com/users/aspnetboilerplate/received_events","type":"Organization","site_admin":false},"repo":{"id":12201538,"name":"aspnetboilerplate","full_name":"aspnetboilerplate/aspnetboilerplate","owner":{"login":"aspnetboilerplate","id":5957277,"avatar_url":"https://avatars.githubusercontent.com/u/5957277?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnetboilerplate","html_url":"https://github.com/aspnetboilerplate","followers_url":"https://api.github.com/users/aspnetboilerplate/followers","following_url":"https://api.github.com/users/aspnetboilerplate/following{/other_user}","gists_url":"https://api.github.com/users/aspnetboilerplate/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnetboilerplate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnetboilerplate/subscriptions","organizations_url":"https://api.github.com/users/aspnetboilerplate/orgs","repos_url":"https://api.github.com/users/aspnetboilerplate/repos","events_url":"https://api.github.com/users/aspnetboilerplate/events{/privacy}","received_events_url":"https://api.github.com/users/aspnetboilerplate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnetboilerplate/aspnetboilerplate","description":"ASP.NET Boilerplate","fork":false,"url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate","forks_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/forks","keys_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/teams","hooks_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/hooks","issue_events_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues/events{/number}","events_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/events","assignees_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/assignees{/user}","branches_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/branches{/branch}","tags_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/tags","blobs_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/languages","stargazers_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/stargazers","contributors_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/contributors","subscribers_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/subscribers","subscription_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/subscription","commits_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/contents/{+path}","compare_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/merges","archive_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/downloads","issues_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues{/number}","pulls_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/labels{/name}","releases_url":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/releases{/id}","created_at":"2013-08-18T20:45:08Z","updated_at":"2015-03-03T19:33:30Z","pushed_at":"2015-03-03T19:33:29Z","git_url":"git://github.com/aspnetboilerplate/aspnetboilerplate.git","ssh_url":"git@github.com:aspnetboilerplate/aspnetboilerplate.git","clone_url":"https://github.com/aspnetboilerplate/aspnetboilerplate.git","svn_url":"https://github.com/aspnetboilerplate/aspnetboilerplate","homepage":"http://www.aspnetboilerplate.com","size":16044,"stargazers_count":263,"watchers_count":263,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":56,"forks":120,"open_issues":56,"watchers":263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/342"},"html":{"href":"https://github.com/aspnetboilerplate/aspnetboilerplate/pull/342"},"issue":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues/342"},"comments":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/issues/342/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/342/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/pulls/342/commits"},"statuses":{"href":"https://api.github.com/repos/aspnetboilerplate/aspnetboilerplate/statuses/83b7dc9d961632860b79b36e7c0f87214bd73355"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":5,"changed_files":1}}