{"action":"created","issue":{"url":"https://api.github.com/repos/crowbar/barclamp-ceph/issues/136","labels_url":"https://api.github.com/repos/crowbar/barclamp-ceph/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/crowbar/barclamp-ceph/issues/136/comments","events_url":"https://api.github.com/repos/crowbar/barclamp-ceph/issues/136/events","html_url":"https://github.com/crowbar/barclamp-ceph/pull/136","id":60468978,"number":136,"title":"Fix use_ssd_for_journal edge cases","user":{"login":"tserong","id":754700,"avatar_url":"https://avatars.githubusercontent.com/u/754700?v=3","gravatar_id":"","url":"https://api.github.com/users/tserong","html_url":"https://github.com/tserong","followers_url":"https://api.github.com/users/tserong/followers","following_url":"https://api.github.com/users/tserong/following{/other_user}","gists_url":"https://api.github.com/users/tserong/gists{/gist_id}","starred_url":"https://api.github.com/users/tserong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tserong/subscriptions","organizations_url":"https://api.github.com/users/tserong/orgs","repos_url":"https://api.github.com/users/tserong/repos","events_url":"https://api.github.com/users/tserong/events{/privacy}","received_events_url":"https://api.github.com/users/tserong/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-10T09:03:37Z","updated_at":"2015-03-10T09:47:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crowbar/barclamp-ceph/pulls/136","html_url":"https://github.com/crowbar/barclamp-ceph/pull/136","diff_url":"https://github.com/crowbar/barclamp-ceph/pull/136.diff","patch_url":"https://github.com/crowbar/barclamp-ceph/pull/136.patch"},"body":"There's a few odd edge cases with different settings for disk_mode and use_ssd_for_journal:\r\n\r\n* If you've only got one disk, and you're using SSDs, that disk ends up being allocated as a journal with no OSD.\r\n* Using disk_mode == first doesn't work with SSDs (again, you get a single journal and no OSD).\r\n* On a system with all SSDs, you end up with only journals, and no OSDs.\r\n\r\nThis set of commits makes the following changes in order to remedy the above:\r\n\r\n1. Default disk_mode to \"all\" (no real world deployment is ever going to want to only allocate the first disk and no others in a storage node).\r\n2. If someone really wants to use disk_mode == \"first\", just allocate the first disk as an OSD, regardless of whether it's an SSD or HDD.\r\n3. When first deploying, if the node only has one type of disk, set use_ssd_for_journal to false for that node (so you just get OSDs)."},"comment":{"url":"https://api.github.com/repos/crowbar/barclamp-ceph/issues/comments/78022706","html_url":"https://github.com/crowbar/barclamp-ceph/pull/136#issuecomment-78022706","issue_url":"https://api.github.com/repos/crowbar/barclamp-ceph/issues/136","id":78022706,"user":{"login":"tserong","id":754700,"avatar_url":"https://avatars.githubusercontent.com/u/754700?v=3","gravatar_id":"","url":"https://api.github.com/users/tserong","html_url":"https://github.com/tserong","followers_url":"https://api.github.com/users/tserong/followers","following_url":"https://api.github.com/users/tserong/following{/other_user}","gists_url":"https://api.github.com/users/tserong/gists{/gist_id}","starred_url":"https://api.github.com/users/tserong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tserong/subscriptions","organizations_url":"https://api.github.com/users/tserong/orgs","repos_url":"https://api.github.com/users/tserong/repos","events_url":"https://api.github.com/users/tserong/events{/privacy}","received_events_url":"https://api.github.com/users/tserong/received_events","type":"User","site_admin":false},"created_at":"2015-03-10T09:47:24Z","updated_at":"2015-03-10T09:47:24Z","body":"Is a migrate script necessary when changing the value of attribute defaults? Or only when adding/removing attributes from the schema?\r\n\r\nIf I edit `/opt/dell/chef/data_bags/crowbar/bc-template-ceph.json` manually, then run `/opt/dell/bin/barclamp_install.rb --rpm /opt/dell/barclamps/ceph`, then `knife data bag show crowbar bc-template-ceph`, it shows my changed value of `disk_mode`, without any migrate script having been run."}}