{"action":"created","issue":{"url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837","labels_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837/labels{/name}","comments_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837/comments","events_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837/events","html_url":"https://github.com/NodeRedis/node_redis/pull/837","id":106201442,"number":837,"title":"retrofit tests so that they work on Windows","user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/NodeRedis/node_redis/labels/2.0","name":"2.0","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-13T06:22:43Z","updated_at":"2015-09-14T02:48:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NodeRedis/node_redis/pulls/837","html_url":"https://github.com/NodeRedis/node_redis/pull/837","diff_url":"https://github.com/NodeRedis/node_redis/pull/837.diff","patch_url":"https://github.com/NodeRedis/node_redis/pull/837.patch"},"body":"* added appveyor configuration (a Windows CI server).\r\n* hiredis is now installed as an optional dev dependency (since Windows machines have trouble building it with node-gyp).\r\n* auth-spec is now skipped if we fail to spawn a Redis (in our Windows CI we assume a Redis is provisioned by the CI environment, not that we can spawn it using a `redis` bin).\r\n* Windows tests run on an older Redis, I fixed up some of the tests that were conditional based on which Redis version was being used.\r\n* found a single test that behaves weirdly on Windows, and added a  TODO (relates to an error being returned even though the operation should simply be enqueued)."},"comment":{"url":"https://api.github.com/repos/NodeRedis/node_redis/issues/comments/139946660","html_url":"https://github.com/NodeRedis/node_redis/pull/837#issuecomment-139946660","issue_url":"https://api.github.com/repos/NodeRedis/node_redis/issues/837","id":139946660,"user":{"login":"bcoe","id":194609,"avatar_url":"https://avatars.githubusercontent.com/u/194609?v=3","gravatar_id":"","url":"https://api.github.com/users/bcoe","html_url":"https://github.com/bcoe","followers_url":"https://api.github.com/users/bcoe/followers","following_url":"https://api.github.com/users/bcoe/following{/other_user}","gists_url":"https://api.github.com/users/bcoe/gists{/gist_id}","starred_url":"https://api.github.com/users/bcoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcoe/subscriptions","organizations_url":"https://api.github.com/users/bcoe/orgs","repos_url":"https://api.github.com/users/bcoe/repos","events_url":"https://api.github.com/users/bcoe/events{/privacy}","received_events_url":"https://api.github.com/users/bcoe/received_events","type":"User","site_admin":false},"created_at":"2015-09-14T02:48:28Z","updated_at":"2015-09-14T02:48:28Z","body":"I think this is ready to go out the door -- my only concern is the slight drop in test-coverage, but I think this is a rounding issue due to shuffling code around a bit, should come out in the wash when we land some of @BridgeAR's pulls that increase coverage."}}