{"action":"created","issue":{"url":"https://api.github.com/repos/pulviscriptor/agario-client/issues/2","labels_url":"https://api.github.com/repos/pulviscriptor/agario-client/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/pulviscriptor/agario-client/issues/2/comments","events_url":"https://api.github.com/repos/pulviscriptor/agario-client/issues/2/events","html_url":"https://github.com/pulviscriptor/agario-client/pull/2","id":85100264,"number":2,"title":"In browser support","user":{"login":"GeoffreyFrogeye","id":1685403,"avatar_url":"https://avatars.githubusercontent.com/u/1685403?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyFrogeye","html_url":"https://github.com/GeoffreyFrogeye","followers_url":"https://api.github.com/users/GeoffreyFrogeye/followers","following_url":"https://api.github.com/users/GeoffreyFrogeye/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyFrogeye/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyFrogeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyFrogeye/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyFrogeye/orgs","repos_url":"https://api.github.com/users/GeoffreyFrogeye/repos","events_url":"https://api.github.com/users/GeoffreyFrogeye/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyFrogeye/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-04T13:29:18Z","updated_at":"2015-06-05T14:39:48Z","closed_at":"2015-06-04T16:56:19Z","pull_request":{"url":"https://api.github.com/repos/pulviscriptor/agario-client/pulls/2","html_url":"https://github.com/pulviscriptor/agario-client/pull/2","diff_url":"https://github.com/pulviscriptor/agario-client/pull/2.diff","patch_url":"https://github.com/pulviscriptor/agario-client/pull/2.patch"},"body":"Do **not** merge until the following list is filled.\r\n\r\nThis PR is in fact a combination of two features, the first one is the support for `agario-client.js` for the browser, and [a fully featured graphical client](http://i.imgur.com/vGLXdN0.png) in browser. I had some issues with making the client cross-compatible (it only works in the browser for now), and I wanted to discuss the way to go before considering this complete. And in the meanwhile I developed this graphical client on the same branch, that's why this PR contains two features, my bad :wink:.\r\n\r\nHere's the TODO list:\r\n- [x] Make the client work in the browser\r\n- [ ] Make the client cross-platform\r\n- [ ] Add some documentation\r\n\r\nI was thinking about using [some hack](http://stackoverflow.com/questions/4224606/how-to-check-whether-a-script-is-running-under-node-js) to detect which platform is running `agario-client.js` and then load the libraries accordingly, are you okay with that ?"},"comment":{"url":"https://api.github.com/repos/pulviscriptor/agario-client/issues/comments/109313293","html_url":"https://github.com/pulviscriptor/agario-client/pull/2#issuecomment-109313293","issue_url":"https://api.github.com/repos/pulviscriptor/agario-client/issues/2","id":109313293,"user":{"login":"GeoffreyFrogeye","id":1685403,"avatar_url":"https://avatars.githubusercontent.com/u/1685403?v=3","gravatar_id":"","url":"https://api.github.com/users/GeoffreyFrogeye","html_url":"https://github.com/GeoffreyFrogeye","followers_url":"https://api.github.com/users/GeoffreyFrogeye/followers","following_url":"https://api.github.com/users/GeoffreyFrogeye/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyFrogeye/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyFrogeye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyFrogeye/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyFrogeye/orgs","repos_url":"https://api.github.com/users/GeoffreyFrogeye/repos","events_url":"https://api.github.com/users/GeoffreyFrogeye/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyFrogeye/received_events","type":"User","site_admin":false},"created_at":"2015-06-05T14:39:48Z","updated_at":"2015-06-05T14:39:48Z","body":"Thanks! I had some issues understanding browserify so this little tutorial is just what I needed!\r\n\r\nSo I created [my own repo](https://github.com/GeoffreyFrogeye/agario-webclient) and everything works fine! But how did you manage not to overwrite `window.WebSocket`? I did [a little trick](https://github.com/GeoffreyFrogeye/agario-webclient/commit/48397199c55780b15dd187505f388422a52c82a4#diff-b67911656ef5d18c4ae36cb6741b7965R3), but this isn't the right way to go I think.\r\n\r\n> Also your client is pretty cool, i like it.\r\n\r\nThanks, but it wouldn't be that cool without yours :smile:."}}