{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/1173","labels_url":"https://api.github.com/repos/uProxy/uproxy/issues/1173/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/1173/comments","events_url":"https://api.github.com/repos/uProxy/uproxy/issues/1173/events","html_url":"https://github.com/uProxy/uproxy/pull/1173","id":64839883,"number":1173,"title":"Add NAT to logs. Show in new view-logs page.","user":{"login":"lucyhe","id":8723127,"avatar_url":"https://avatars.githubusercontent.com/u/8723127?v=3","gravatar_id":"","url":"https://api.github.com/users/lucyhe","html_url":"https://github.com/lucyhe","followers_url":"https://api.github.com/users/lucyhe/followers","following_url":"https://api.github.com/users/lucyhe/following{/other_user}","gists_url":"https://api.github.com/users/lucyhe/gists{/gist_id}","starred_url":"https://api.github.com/users/lucyhe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucyhe/subscriptions","organizations_url":"https://api.github.com/users/lucyhe/orgs","repos_url":"https://api.github.com/users/lucyhe/repos","events_url":"https://api.github.com/users/lucyhe/events{/privacy}","received_events_url":"https://api.github.com/users/lucyhe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-27T19:52:44Z","updated_at":"2015-03-30T16:30:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/1173","html_url":"https://github.com/uProxy/uproxy/pull/1173","diff_url":"https://github.com/uProxy/uproxy/pull/1173.diff","patch_url":"https://github.com/uProxy/uproxy/pull/1173.patch"},"body":"Checking the checkbox opens this dialog:\r\nClicking More Info takes you to the \"does uproxy log data about me\" question in the FAQ.\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6875848/bc90201c-d498-11e4-9f42-d83787ce97ae.png)\r\n\r\n\r\nI updated the hover text:\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6875326/f0244caa-d493-11e4-9337-a1db4fff4b88.png)\r\n\r\nClicking \"Preview\" opens this:\r\nClicking \"No\" just sends you back to the feedback page, more info goes to FAQ and yes will open the new view logs page (below):\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6875840/af1ad1fc-d498-11e4-83ad-9233b0751ccd.png)\r\n\r\n\r\nView logs page, while loading:\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6875136/33832e40-d493-11e4-9bf4-a2525031ed96.png)\r\n\r\nView logs page, loaded, with NAT data at the top:\r\n![image](https://cloud.githubusercontent.com/assets/8723127/6878466/06c3de5a-d4b5-11e4-966b-eeedcedc2e98.png)\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n<!-- Reviewable:start -->\r\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/1173)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/87742947","html_url":"https://github.com/uProxy/uproxy/pull/1173#issuecomment-87742947","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/1173","id":87742947,"user":{"login":"salomegeo","id":7504487,"avatar_url":"https://avatars.githubusercontent.com/u/7504487?v=3","gravatar_id":"","url":"https://api.github.com/users/salomegeo","html_url":"https://github.com/salomegeo","followers_url":"https://api.github.com/users/salomegeo/followers","following_url":"https://api.github.com/users/salomegeo/following{/other_user}","gists_url":"https://api.github.com/users/salomegeo/gists{/gist_id}","starred_url":"https://api.github.com/users/salomegeo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salomegeo/subscriptions","organizations_url":"https://api.github.com/users/salomegeo/orgs","repos_url":"https://api.github.com/users/salomegeo/repos","events_url":"https://api.github.com/users/salomegeo/events{/privacy}","received_events_url":"https://api.github.com/users/salomegeo/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T16:30:53Z","updated_at":"2015-03-30T16:30:53Z","body":"Comments from the [review on Reviewable.io](https://reviewable.io:443/reviews/uproxy/uproxy/1173)\n\nReviewed files:\n- src/generic_core/core.ts @ r3\n- src/generic_core/diagnose.ts @ r3\n- src/generic_core/freedom-module.json @ r2\n- src/generic_core/messages.ts @ r1\n- src/generic_ui/polymer/feedback.html @ r3\n- src/generic_ui/polymer/feedback.ts @ r3\n- src/generic_ui/polymer/logs.html @ r4\n- src/generic_ui/polymer/logs.ts @ r1\n- src/generic_ui/polymer/root.html @ r1\n- src/generic_ui/view-logs.html @ r1\n- src/uproxy.ts @ r2\n\n\n\n\n\n---\n\n<sup>**[src/generic_core/core.ts, line 444 \\[r4\\]](https://reviewable.io:443/reviews/uproxy/uproxy/1173#-JlfU-SdD1dSPSrektou)** ([raw file](https://github.com/uproxy/uproxy/blob/896e87bf90c937bce67ab9961f8a32b4637fdd12/src/generic_core/core.ts#L444)):</sup>\nDo we need to check in this comment?\n\n---\n\n<sup>**[src/generic_core/core.ts, line 480 \\[r4\\]](https://reviewable.io:443/reviews/uproxy/uproxy/1173#-JlfVKL5bq_aaTdIO70x)** ([raw file](https://github.com/uproxy/uproxy/blob/896e87bf90c937bce67ab9961f8a32b4637fdd12/src/generic_core/core.ts#L480)):</sup>\nThis too\n\n---\n\n<sup>**[src/generic_core/core.ts, line 511 \\[r4\\]](https://reviewable.io:443/reviews/uproxy/uproxy/1173#-JlfVbbXmBCJ5hcQu2fo)** ([raw file](https://github.com/uproxy/uproxy/blob/896e87bf90c937bce67ab9961f8a32b4637fdd12/src/generic_core/core.ts#L511)):</sup>\nHow often do you think users submit feedback?\n\nUser might do this, try something, then change the internet and try it again, in that case they are submitting wrong feedback.\n\nI don't think too strongly about this, but I think querying every time to get the nat type should be affordable.\n\n---\n\n<sup>**[src/generic_ui/polymer/logs.ts, line 14 \\[r4\\]](https://reviewable.io:443/reviews/uproxy/uproxy/1173#-JlfT8q8JPsLoWgAbvCI)** ([raw file](https://github.com/uproxy/uproxy/blob/896e87bf90c937bce67ab9961f8a32b4637fdd12/src/generic_ui/polymer/logs.ts#L14)):</sup>\nWhy do you need this statement?\n\n---\n\n<sup>**[src/generic_ui/view-logs.html, line 6 \\[r4\\]](https://reviewable.io:443/reviews/uproxy/uproxy/1173#-JlfSYzvWcCuCz7OwFk7)** ([raw file](https://github.com/uproxy/uproxy/blob/896e87bf90c937bce67ab9961f8a32b4637fdd12/src/generic_ui/view-logs.html#L6)):</sup>\nis there a way to avoid including dependencies from here?\n\n---\n\n\n<!-- Sent from Reviewable.io -->\n"}}