{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments/43302375","id":43302375,"diff_hunk":"@@ -0,0 +1,66 @@\n+/*\n+ * Copyright 2015 the original author or authors.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\");\n+ * you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ *\n+ *      http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.springframework.cloud.stream.module.jdbc;\n+\n+import java.util.LinkedHashMap;\n+import java.util.Map;\n+\n+import org.springframework.core.convert.TypeDescriptor;\n+import org.springframework.core.convert.converter.ConditionalConverter;\n+import org.springframework.core.convert.converter.Converter;\n+import org.springframework.util.Assert;\n+\n+/**\n+ * A Converter from String to Map that accepts csv {@literal key:value} pairs\n+ * (similar to what comes out of the box in Spring Core) but also simple\n+ * {@literal key} items, in which case the value is assumed to be equal to the key.\n+ *\n+ * <p>Additionally, commas and colons can be escaped by using a backslash, which is\n+ * useful if said mappings are to be used for SpEL for example.</p>\n+ *\n+ * @author Eric Bottard\n+ */\n+public class ShorthandMapConverter implements Converter<String, Map<String, String>>, ConditionalConverter{\n+\n+\n+\t@Override\n+\tpublic Map<String, String> convert(String source) {\n+\t\tMap<String, String> result = new LinkedHashMap<>();\n+\n+\t\t// Split on comma if not preceded by backslash\n+\t\tString[] mappings = source.split(\"(?<!\\\\\\\\),\");\n+\t\tfor (String mapping : mappings) {\n+\t\t\t// Turn backslash-comma back to comma\n+\t\t\tString unescaped = mapping.trim().replace(\"\\\\,\", \",\");\n+\t\t\tif (unescaped.length() == 0) {\n+\t\t\t\tcontinue;\n+\t\t\t}\n+\t\t\t// Split on colon, if not preceded by backslash\n+\t\t\tString[] keyValuePair = unescaped.split(\"(?<!\\\\\\\\):\");\n+\t\t\tAssert.isTrue(keyValuePair.length <= 2, \"'\" + unescaped + \"' could not be parsed to a 'key:value' pair or simple 'key' with implicit value\");","path":"jdbc-sink/src/main/java/org/springframework/cloud/stream/module/jdbc/ShorthandMapConverter.java","position":54,"original_position":54,"commit_id":"c2953709e597cad702ca3fa3edee112f42dfa666","original_commit_id":"c2953709e597cad702ca3fa3edee112f42dfa666","user":{"login":"artembilan","id":1071590,"avatar_url":"https://avatars.githubusercontent.com/u/1071590?v=3","gravatar_id":"","url":"https://api.github.com/users/artembilan","html_url":"https://github.com/artembilan","followers_url":"https://api.github.com/users/artembilan/followers","following_url":"https://api.github.com/users/artembilan/following{/other_user}","gists_url":"https://api.github.com/users/artembilan/gists{/gist_id}","starred_url":"https://api.github.com/users/artembilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artembilan/subscriptions","organizations_url":"https://api.github.com/users/artembilan/orgs","repos_url":"https://api.github.com/users/artembilan/repos","events_url":"https://api.github.com/users/artembilan/events{/privacy}","received_events_url":"https://api.github.com/users/artembilan/received_events","type":"User","site_admin":false},"body":"Very long like of code.\r\nMinor,  of course, but I wonder if we follow with some code style rules...","created_at":"2015-10-28T19:01:13Z","updated_at":"2015-10-28T19:01:13Z","html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/55#discussion_r43302375","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments/43302375"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/55#discussion_r43302375"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55","id":48953407,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/55","diff_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/55.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/55.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/55","number":55,"state":"open","locked":false,"title":"XD-3482 Add jdbc sink","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"body":"- based on Eric's PR #40\r\n\r\n- change to use JdbcMessageHandler from Spring Integration\r\n","created_at":"2015-10-28T01:05:33Z","updated_at":"2015-10-28T19:01:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc08465125cd4995b455ad6954c63645954648ba","assignee":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/55/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/c2953709e597cad702ca3fa3edee112f42dfa666","head":{"label":"trisberg:XD-3482-jdbc-sink","ref":"XD-3482-jdbc-sink","sha":"c2953709e597cad702ca3fa3edee112f42dfa666","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"repo":{"id":40381186,"name":"spring-cloud-stream-modules","full_name":"trisberg/spring-cloud-stream-modules","owner":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trisberg/spring-cloud-stream-modules","description":"","fork":true,"url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules","forks_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/forks","keys_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/teams","hooks_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/hooks","issue_events_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/issues/events{/number}","events_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/events","assignees_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/assignees{/user}","branches_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/branches{/branch}","tags_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/tags","blobs_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/languages","stargazers_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/stargazers","contributors_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/contributors","subscribers_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/subscribers","subscription_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/subscription","commits_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/contents/{+path}","compare_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/merges","archive_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/downloads","issues_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/issues{/number}","pulls_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/labels{/name}","releases_url":"https://api.github.com/repos/trisberg/spring-cloud-stream-modules/releases{/id}","created_at":"2015-08-07T21:14:13Z","updated_at":"2015-08-07T21:14:13Z","pushed_at":"2015-10-28T14:54:22Z","git_url":"git://github.com/trisberg/spring-cloud-stream-modules.git","ssh_url":"git@github.com:trisberg/spring-cloud-stream-modules.git","clone_url":"https://github.com/trisberg/spring-cloud-stream-modules.git","svn_url":"https://github.com/trisberg/spring-cloud-stream-modules","homepage":null,"size":1111,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"ed9a37782e155afd882874e44409c87e55084114","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":40096018,"name":"spring-cloud-stream-modules","full_name":"spring-cloud/spring-cloud-stream-modules","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-stream-modules","description":"","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/releases{/id}","created_at":"2015-08-02T23:22:20Z","updated_at":"2015-10-15T20:02:14Z","pushed_at":"2015-10-28T14:54:22Z","git_url":"git://github.com/spring-cloud/spring-cloud-stream-modules.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-stream-modules.git","clone_url":"https://github.com/spring-cloud/spring-cloud-stream-modules.git","svn_url":"https://github.com/spring-cloud/spring-cloud-stream-modules","homepage":null,"size":1820,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"open_issues_count":7,"forks":17,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-stream-modules/pull/55"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/55"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-stream-modules/statuses/c2953709e597cad702ca3fa3edee112f42dfa666"}}}}