{"action":"created","issue":{"url":"https://api.github.com/repos/dguerri/LibVirtKvm-scripts/issues/8","labels_url":"https://api.github.com/repos/dguerri/LibVirtKvm-scripts/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/dguerri/LibVirtKvm-scripts/issues/8/comments","events_url":"https://api.github.com/repos/dguerri/LibVirtKvm-scripts/issues/8/events","html_url":"https://github.com/dguerri/LibVirtKvm-scripts/issues/8","id":64312027,"number":8,"title":"Remove rebasing step in backup proceedure? ","user":{"login":"AJRepo","id":7245631,"avatar_url":"https://avatars.githubusercontent.com/u/7245631?v=3","gravatar_id":"","url":"https://api.github.com/users/AJRepo","html_url":"https://github.com/AJRepo","followers_url":"https://api.github.com/users/AJRepo/followers","following_url":"https://api.github.com/users/AJRepo/following{/other_user}","gists_url":"https://api.github.com/users/AJRepo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJRepo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJRepo/subscriptions","organizations_url":"https://api.github.com/users/AJRepo/orgs","repos_url":"https://api.github.com/users/AJRepo/repos","events_url":"https://api.github.com/users/AJRepo/events{/privacy}","received_events_url":"https://api.github.com/users/AJRepo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-03-25T16:25:47Z","updated_at":"2015-03-26T15:01:34Z","closed_at":null,"body":"Thanks again for a nice program.  If I've read the code right, I see that there is a rebasing of the backing files in the backup directory which stores the full path to that source in the backup directory. \r\n\r\nSo you currently have \r\n```\r\n   new_backing_file=\"$BACKUP_DIRECTORY/$(basename $backing_file)\"\r\n...\r\n   new_parent_backing_file=$BACKUP_DIRECTORY/$(basename $parent_backing_file)\r\n...\r\n   command_output=$($QEMU_IMG rebase -u -b \"$new_parent_backing_file\" \"$new_backing_file\")\r\n```\r\n\r\nI think that would make sense if you ran the VM in the backup directory, but in the case of a disaster recovery (DR) you'd put the backup files back in their original location, not run from the backup directory (which might potentially cause an issue anyway as this script would then be backing up the VM from and to the same directory).  \r\n\r\nSo I think it might make more sense to not rebase the backup files.  What do you think? "},"comment":{"url":"https://api.github.com/repos/dguerri/LibVirtKvm-scripts/issues/comments/86555425","html_url":"https://github.com/dguerri/LibVirtKvm-scripts/issues/8#issuecomment-86555425","issue_url":"https://api.github.com/repos/dguerri/LibVirtKvm-scripts/issues/8","id":86555425,"user":{"login":"dguerri","id":509264,"avatar_url":"https://avatars.githubusercontent.com/u/509264?v=3","gravatar_id":"","url":"https://api.github.com/users/dguerri","html_url":"https://github.com/dguerri","followers_url":"https://api.github.com/users/dguerri/followers","following_url":"https://api.github.com/users/dguerri/following{/other_user}","gists_url":"https://api.github.com/users/dguerri/gists{/gist_id}","starred_url":"https://api.github.com/users/dguerri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dguerri/subscriptions","organizations_url":"https://api.github.com/users/dguerri/orgs","repos_url":"https://api.github.com/users/dguerri/repos","events_url":"https://api.github.com/users/dguerri/events{/privacy}","received_events_url":"https://api.github.com/users/dguerri/received_events","type":"User","site_admin":false},"created_at":"2015-03-26T15:01:34Z","updated_at":"2015-03-26T15:01:34Z","body":"That's great. Thanks @AJRepo ."}}