{"action":"created","issue":{"url":"https://api.github.com/repos/tim-kos/transloadit_xhr/issues/10","labels_url":"https://api.github.com/repos/tim-kos/transloadit_xhr/issues/10/labels{/name}","comments_url":"https://api.github.com/repos/tim-kos/transloadit_xhr/issues/10/comments","events_url":"https://api.github.com/repos/tim-kos/transloadit_xhr/issues/10/events","html_url":"https://github.com/tim-kos/transloadit_xhr/pull/10","id":68979275,"number":10,"title":"Parameter normalization","user":{"login":"baohouse","id":4228012,"avatar_url":"https://avatars.githubusercontent.com/u/4228012?v=3","gravatar_id":"","url":"https://api.github.com/users/baohouse","html_url":"https://github.com/baohouse","followers_url":"https://api.github.com/users/baohouse/followers","following_url":"https://api.github.com/users/baohouse/following{/other_user}","gists_url":"https://api.github.com/users/baohouse/gists{/gist_id}","starred_url":"https://api.github.com/users/baohouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baohouse/subscriptions","organizations_url":"https://api.github.com/users/baohouse/orgs","repos_url":"https://api.github.com/users/baohouse/repos","events_url":"https://api.github.com/users/baohouse/events{/privacy}","received_events_url":"https://api.github.com/users/baohouse/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-16T18:09:46Z","updated_at":"2015-09-18T07:46:04Z","closed_at":"2015-09-18T07:46:04Z","pull_request":{"url":"https://api.github.com/repos/tim-kos/transloadit_xhr/pulls/10","html_url":"https://github.com/tim-kos/transloadit_xhr/pull/10","diff_url":"https://github.com/tim-kos/transloadit_xhr/pull/10.diff","patch_url":"https://github.com/tim-kos/transloadit_xhr/pull/10.patch"},"body":"* Added parameter normalization for the \"params\" and \"signature\" parameters, which must be stringified JSON.\r\n* Also made \"signature\" optional in the formPost, which causes problems for unsigned uploads. The problem happens if the key exists but has a null value, so if \"signature\" is null/undefined, we best not have that property in the formPost."},"comment":{"url":"https://api.github.com/repos/tim-kos/transloadit_xhr/issues/comments/141372318","html_url":"https://github.com/tim-kos/transloadit_xhr/pull/10#issuecomment-141372318","issue_url":"https://api.github.com/repos/tim-kos/transloadit_xhr/issues/10","id":141372318,"user":{"login":"tim-kos","id":15005,"avatar_url":"https://avatars.githubusercontent.com/u/15005?v=3","gravatar_id":"","url":"https://api.github.com/users/tim-kos","html_url":"https://github.com/tim-kos","followers_url":"https://api.github.com/users/tim-kos/followers","following_url":"https://api.github.com/users/tim-kos/following{/other_user}","gists_url":"https://api.github.com/users/tim-kos/gists{/gist_id}","starred_url":"https://api.github.com/users/tim-kos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tim-kos/subscriptions","organizations_url":"https://api.github.com/users/tim-kos/orgs","repos_url":"https://api.github.com/users/tim-kos/repos","events_url":"https://api.github.com/users/tim-kos/events{/privacy}","received_events_url":"https://api.github.com/users/tim-kos/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T07:46:04Z","updated_at":"2015-09-18T07:46:04Z","body":"I don't think we need this because we have\r\n\r\n```\r\nif (typeof this.params !== 'string') {\r\n      this.params = JSON.stringify(this.params);\r\n    }\r\n```\r\n\r\nin uploadFile(). Also signatures should not be treated as JSON objects.\r\n\r\nI have made signatures optional, though, and added you to the contributors list."}}