{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/comments/25597451","id":25597451,"diff_hunk":"@@ -399,6 +399,74 @@ beginCellCentroids(const Dune::CpGrid& grid);\n double cellCentroidCoordinate(const Dune::CpGrid& grid, int cell_index,\n                               int coordinate);\n \n+/// \\brief Get the centroid of a cell.\n+/// \\param grid The grid whose cell centroid we query.\n+/// \\param cell_index The index of the corresponding cell.\n+const double* cellCentroid(const Dune::CpGrid& grid, int cell_index);\n+\n+/// \\brief Get the volume of a cell.\n+/// \\param grid The grid the cell belongs to.\n+/// \\param cell_index The index of the cell.\n+double cellVolume(const  Dune::CpGrid& grid, int cell_index);\n+\n+/// \\brief An iterator over the cell volumes.\n+class CellVolumeIterator\n+    : public Dune::RandomAccessIteratorFacade<CellVolumeIterator, double, double, int>","path":"dune/grid/cpgrid/GridHelpers.hpp","position":16,"original_position":16,"commit_id":"af2f07843dd85418ee414f1da77b6afa728a4276","original_commit_id":"af2f07843dd85418ee414f1da77b6afa728a4276","user":{"login":"bska","id":1871438,"avatar_url":"https://avatars.githubusercontent.com/u/1871438?v=3","gravatar_id":"","url":"https://api.github.com/users/bska","html_url":"https://github.com/bska","followers_url":"https://api.github.com/users/bska/followers","following_url":"https://api.github.com/users/bska/following{/other_user}","gists_url":"https://api.github.com/users/bska/gists{/gist_id}","starred_url":"https://api.github.com/users/bska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bska/subscriptions","organizations_url":"https://api.github.com/users/bska/orgs","repos_url":"https://api.github.com/users/bska/repos","events_url":"https://api.github.com/users/bska/events{/privacy}","received_events_url":"https://api.github.com/users/bska/received_events","type":"User","site_admin":false},"body":"This (public inheritance from `Dune::RandomAccessIteratorFacade<>`) appears to rely on namespace pollution from opm-autodiff's [`opm/autodiff/GridHelpers.hpp`](https://github.com/blattms/opm-autodiff/blob/uggridhelpers-completion/opm/autodiff/GridHelpers.hpp#L81).  Any chance you could\r\n```C++\r\n#include <dune/common/iteratorfacades.hh>\r\n```\r\nhere (in dune-cornerpoint's edition of `GridHelpers.hpp`, [`dune/grid/cpgrid/GridHelpers.hpp`](https://github.com/blattms/dune-cornerpoint/blob/uggridhelpers-completion/dune/grid/cpgrid/GridHelpers.hpp)) rather than there?","created_at":"2015-03-02T13:24:55Z","updated_at":"2015-03-02T13:24:55Z","html_url":"https://github.com/OPM/dune-cornerpoint/pull/130#discussion_r25597451","pull_request_url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130","_links":{"self":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/comments/25597451"},"html":{"href":"https://github.com/OPM/dune-cornerpoint/pull/130#discussion_r25597451"},"pull_request":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130"}}},"pull_request":{"url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130","id":30272517,"html_url":"https://github.com/OPM/dune-cornerpoint/pull/130","diff_url":"https://github.com/OPM/dune-cornerpoint/pull/130.diff","patch_url":"https://github.com/OPM/dune-cornerpoint/pull/130.patch","issue_url":"https://api.github.com/repos/OPM/dune-cornerpoint/issues/130","number":130,"state":"open","locked":false,"title":"Moves all functions that do not depend on Eigen to Opm::UgGridHelpers. [2/3]","user":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"body":"This PR moves all the grid helper functions that do not depend on Eigen to the module where the\r\ngrid is declared and implement.\r\n\r\nThis is the first out of three PRs that should be merged simultaneously. The irst one is OPM/opm-core#764.","created_at":"2015-03-02T10:31:42Z","updated_at":"2015-03-02T13:24:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e8503a87fe407da1a3e7fcd93b12ce874e62db5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130/commits","review_comments_url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130/comments","review_comment_url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/dune-cornerpoint/issues/130/comments","statuses_url":"https://api.github.com/repos/OPM/dune-cornerpoint/statuses/af2f07843dd85418ee414f1da77b6afa728a4276","head":{"label":"blattms:uggridhelpers-completion","ref":"uggridhelpers-completion","sha":"af2f07843dd85418ee414f1da77b6afa728a4276","user":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"repo":{"id":5701678,"name":"dune-cornerpoint","full_name":"blattms/dune-cornerpoint","owner":{"login":"blattms","id":1944640,"avatar_url":"https://avatars.githubusercontent.com/u/1944640?v=3","gravatar_id":"","url":"https://api.github.com/users/blattms","html_url":"https://github.com/blattms","followers_url":"https://api.github.com/users/blattms/followers","following_url":"https://api.github.com/users/blattms/following{/other_user}","gists_url":"https://api.github.com/users/blattms/gists{/gist_id}","starred_url":"https://api.github.com/users/blattms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blattms/subscriptions","organizations_url":"https://api.github.com/users/blattms/orgs","repos_url":"https://api.github.com/users/blattms/repos","events_url":"https://api.github.com/users/blattms/events{/privacy}","received_events_url":"https://api.github.com/users/blattms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blattms/dune-cornerpoint","description":"DUNE module supporting grids in a corner-point format","fork":true,"url":"https://api.github.com/repos/blattms/dune-cornerpoint","forks_url":"https://api.github.com/repos/blattms/dune-cornerpoint/forks","keys_url":"https://api.github.com/repos/blattms/dune-cornerpoint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blattms/dune-cornerpoint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blattms/dune-cornerpoint/teams","hooks_url":"https://api.github.com/repos/blattms/dune-cornerpoint/hooks","issue_events_url":"https://api.github.com/repos/blattms/dune-cornerpoint/issues/events{/number}","events_url":"https://api.github.com/repos/blattms/dune-cornerpoint/events","assignees_url":"https://api.github.com/repos/blattms/dune-cornerpoint/assignees{/user}","branches_url":"https://api.github.com/repos/blattms/dune-cornerpoint/branches{/branch}","tags_url":"https://api.github.com/repos/blattms/dune-cornerpoint/tags","blobs_url":"https://api.github.com/repos/blattms/dune-cornerpoint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blattms/dune-cornerpoint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blattms/dune-cornerpoint/git/refs{/sha}","trees_url":"https://api.github.com/repos/blattms/dune-cornerpoint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blattms/dune-cornerpoint/statuses/{sha}","languages_url":"https://api.github.com/repos/blattms/dune-cornerpoint/languages","stargazers_url":"https://api.github.com/repos/blattms/dune-cornerpoint/stargazers","contributors_url":"https://api.github.com/repos/blattms/dune-cornerpoint/contributors","subscribers_url":"https://api.github.com/repos/blattms/dune-cornerpoint/subscribers","subscription_url":"https://api.github.com/repos/blattms/dune-cornerpoint/subscription","commits_url":"https://api.github.com/repos/blattms/dune-cornerpoint/commits{/sha}","git_commits_url":"https://api.github.com/repos/blattms/dune-cornerpoint/git/commits{/sha}","comments_url":"https://api.github.com/repos/blattms/dune-cornerpoint/comments{/number}","issue_comment_url":"https://api.github.com/repos/blattms/dune-cornerpoint/issues/comments{/number}","contents_url":"https://api.github.com/repos/blattms/dune-cornerpoint/contents/{+path}","compare_url":"https://api.github.com/repos/blattms/dune-cornerpoint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blattms/dune-cornerpoint/merges","archive_url":"https://api.github.com/repos/blattms/dune-cornerpoint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blattms/dune-cornerpoint/downloads","issues_url":"https://api.github.com/repos/blattms/dune-cornerpoint/issues{/number}","pulls_url":"https://api.github.com/repos/blattms/dune-cornerpoint/pulls{/number}","milestones_url":"https://api.github.com/repos/blattms/dune-cornerpoint/milestones{/number}","notifications_url":"https://api.github.com/repos/blattms/dune-cornerpoint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blattms/dune-cornerpoint/labels{/name}","releases_url":"https://api.github.com/repos/blattms/dune-cornerpoint/releases{/id}","created_at":"2012-09-06T12:11:18Z","updated_at":"2015-02-11T13:19:56Z","pushed_at":"2015-03-02T10:26:47Z","git_url":"git://github.com/blattms/dune-cornerpoint.git","ssh_url":"git@github.com:blattms/dune-cornerpoint.git","clone_url":"https://github.com/blattms/dune-cornerpoint.git","svn_url":"https://github.com/blattms/dune-cornerpoint","homepage":"http://www.opm-project.org","size":4348,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"9734437c74e0ff1c62f789edad6800619a004114","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":4787535,"name":"dune-cornerpoint","full_name":"OPM/dune-cornerpoint","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars.githubusercontent.com/u/1827197?v=3","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/dune-cornerpoint","description":"DUNE module supporting grids in a corner-point format","fork":false,"url":"https://api.github.com/repos/OPM/dune-cornerpoint","forks_url":"https://api.github.com/repos/OPM/dune-cornerpoint/forks","keys_url":"https://api.github.com/repos/OPM/dune-cornerpoint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/dune-cornerpoint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/dune-cornerpoint/teams","hooks_url":"https://api.github.com/repos/OPM/dune-cornerpoint/hooks","issue_events_url":"https://api.github.com/repos/OPM/dune-cornerpoint/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/dune-cornerpoint/events","assignees_url":"https://api.github.com/repos/OPM/dune-cornerpoint/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/dune-cornerpoint/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/dune-cornerpoint/tags","blobs_url":"https://api.github.com/repos/OPM/dune-cornerpoint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/dune-cornerpoint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/dune-cornerpoint/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/dune-cornerpoint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/dune-cornerpoint/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/dune-cornerpoint/languages","stargazers_url":"https://api.github.com/repos/OPM/dune-cornerpoint/stargazers","contributors_url":"https://api.github.com/repos/OPM/dune-cornerpoint/contributors","subscribers_url":"https://api.github.com/repos/OPM/dune-cornerpoint/subscribers","subscription_url":"https://api.github.com/repos/OPM/dune-cornerpoint/subscription","commits_url":"https://api.github.com/repos/OPM/dune-cornerpoint/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/dune-cornerpoint/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/dune-cornerpoint/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/dune-cornerpoint/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/dune-cornerpoint/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/dune-cornerpoint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/dune-cornerpoint/merges","archive_url":"https://api.github.com/repos/OPM/dune-cornerpoint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/dune-cornerpoint/downloads","issues_url":"https://api.github.com/repos/OPM/dune-cornerpoint/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/dune-cornerpoint/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/dune-cornerpoint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/dune-cornerpoint/labels{/name}","releases_url":"https://api.github.com/repos/OPM/dune-cornerpoint/releases{/id}","created_at":"2012-06-25T21:16:36Z","updated_at":"2015-03-02T09:10:16Z","pushed_at":"2015-03-02T09:10:14Z","git_url":"git://github.com/OPM/dune-cornerpoint.git","ssh_url":"git@github.com:OPM/dune-cornerpoint.git","clone_url":"https://github.com/OPM/dune-cornerpoint.git","svn_url":"https://github.com/OPM/dune-cornerpoint","homepage":"http://www.opm-project.org","size":4802,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":7,"forks":19,"open_issues":7,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130"},"html":{"href":"https://github.com/OPM/dune-cornerpoint/pull/130"},"issue":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/issues/130"},"comments":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/issues/130/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/pulls/130/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/dune-cornerpoint/statuses/af2f07843dd85418ee414f1da77b6afa728a4276"}}}}