{"action":"created","issue":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1093","labels_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1093/labels{/name}","comments_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1093/comments","events_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1093/events","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1093","id":103001551,"number":1093,"title":"[jsk_pcl_ros] Fix ExtractCuboidParticlesTopN by removing template super class, which is too difficult to handle shared_ptr owenership.","user":{"login":"garaemon","id":40454,"avatar_url":"https://avatars.githubusercontent.com/u/40454?v=3","gravatar_id":"","url":"https://api.github.com/users/garaemon","html_url":"https://github.com/garaemon","followers_url":"https://api.github.com/users/garaemon/followers","following_url":"https://api.github.com/users/garaemon/following{/other_user}","gists_url":"https://api.github.com/users/garaemon/gists{/gist_id}","starred_url":"https://api.github.com/users/garaemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garaemon/subscriptions","organizations_url":"https://api.github.com/users/garaemon/orgs","repos_url":"https://api.github.com/users/garaemon/repos","events_url":"https://api.github.com/users/garaemon/events{/privacy}","received_events_url":"https://api.github.com/users/garaemon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-25T11:19:56Z","updated_at":"2015-08-25T13:49:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/pulls/1093","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1093","diff_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1093.diff","patch_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1093.patch"},"body":"A lot of changes\r\n1. Update build_check.cpp.in to automatically instantiating nodelet classes thanks to scripts/build_check_helper.py. This test greatly helps us to debug nodelet.\r\n2. Do not include shared_ptr in pcl point type. It may cause difficult bug when converting from/to `PCLPointCloud2`. Because conversions between `pcl::PointCloud` and `PCLPointCloud2` are based on memcpy and the initial memory is not initialized. It means first shared_ptr points to illegal object address and no way to clear it (except for memset).\r\n3. Do not use template super class for ExtractCuboidParticlesTopN. I don't know why but it causes strange shared_ptr ownership problem."},"comment":{"url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/comments/134592193","html_url":"https://github.com/jsk-ros-pkg/jsk_recognition/pull/1093#issuecomment-134592193","issue_url":"https://api.github.com/repos/jsk-ros-pkg/jsk_recognition/issues/1093","id":134592193,"user":{"login":"garaemon","id":40454,"avatar_url":"https://avatars.githubusercontent.com/u/40454?v=3","gravatar_id":"","url":"https://api.github.com/users/garaemon","html_url":"https://github.com/garaemon","followers_url":"https://api.github.com/users/garaemon/followers","following_url":"https://api.github.com/users/garaemon/following{/other_user}","gists_url":"https://api.github.com/users/garaemon/gists{/gist_id}","starred_url":"https://api.github.com/users/garaemon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garaemon/subscriptions","organizations_url":"https://api.github.com/users/garaemon/orgs","repos_url":"https://api.github.com/users/garaemon/repos","events_url":"https://api.github.com/users/garaemon/events{/privacy}","received_events_url":"https://api.github.com/users/garaemon/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T13:49:49Z","updated_at":"2015-08-25T13:49:49Z","body":"```\r\n[jsk_pcl_ros] /workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros/build_check.cpp: In function 'int main(int, char**)': \r\n[jsk_pcl_ros] /workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros/build_check.cpp:196:1: error: 'PointIndicesToMaskImage' is not a member of 'jsk_pcl_ros' \r\n[jsk_pcl_ros] /workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros/build_check.cpp:196:38: error: expected ';' before 'instance_39' \r\n[jsk_pcl_ros] make[2]: *** [CMakeFiles/build_check.dir/build_check.cpp.o] Error 1 \r\n[jsk_pcl_ros] make[1]: *** [CMakeFiles/build_check.dir/all] Error 2             \r\n[jsk_pcl_ros] make: *** [all] Error 2                                           \r\n[jsk_pcl_ros] <== '/workspace/ros/ws_jsk_recognition/build/jsk_pcl_ros/build_env.sh /usr/bin/make --jobserver-fds=3,4 -j' failed with return code '2' \r\n```\r\n\r\nI will update to fix it"}}