{"action":"created","issue":{"url":"https://api.github.com/repos/lifthrasiir/rust-encoding/issues/89","labels_url":"https://api.github.com/repos/lifthrasiir/rust-encoding/issues/89/labels{/name}","comments_url":"https://api.github.com/repos/lifthrasiir/rust-encoding/issues/89/comments","events_url":"https://api.github.com/repos/lifthrasiir/rust-encoding/issues/89/events","html_url":"https://github.com/lifthrasiir/rust-encoding/pull/89","id":95907664,"number":89,"title":"Split encoding::types into encoding-types crate","user":{"login":"nagisa","id":679122,"avatar_url":"https://avatars.githubusercontent.com/u/679122?v=3","gravatar_id":"","url":"https://api.github.com/users/nagisa","html_url":"https://github.com/nagisa","followers_url":"https://api.github.com/users/nagisa/followers","following_url":"https://api.github.com/users/nagisa/following{/other_user}","gists_url":"https://api.github.com/users/nagisa/gists{/gist_id}","starred_url":"https://api.github.com/users/nagisa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagisa/subscriptions","organizations_url":"https://api.github.com/users/nagisa/orgs","repos_url":"https://api.github.com/users/nagisa/repos","events_url":"https://api.github.com/users/nagisa/events{/privacy}","received_events_url":"https://api.github.com/users/nagisa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"lifthrasiir","id":323836,"avatar_url":"https://avatars.githubusercontent.com/u/323836?v=3","gravatar_id":"","url":"https://api.github.com/users/lifthrasiir","html_url":"https://github.com/lifthrasiir","followers_url":"https://api.github.com/users/lifthrasiir/followers","following_url":"https://api.github.com/users/lifthrasiir/following{/other_user}","gists_url":"https://api.github.com/users/lifthrasiir/gists{/gist_id}","starred_url":"https://api.github.com/users/lifthrasiir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifthrasiir/subscriptions","organizations_url":"https://api.github.com/users/lifthrasiir/orgs","repos_url":"https://api.github.com/users/lifthrasiir/repos","events_url":"https://api.github.com/users/lifthrasiir/events{/privacy}","received_events_url":"https://api.github.com/users/lifthrasiir/received_events","type":"User","site_admin":false},"milestone":null,"comments":3,"created_at":"2015-07-19T11:19:15Z","updated_at":"2015-07-21T16:02:57Z","closed_at":"2015-07-21T16:01:10Z","pull_request":{"url":"https://api.github.com/repos/lifthrasiir/rust-encoding/pulls/89","html_url":"https://github.com/lifthrasiir/rust-encoding/pull/89","diff_url":"https://github.com/lifthrasiir/rust-encoding/pull/89.diff","patch_url":"https://github.com/lifthrasiir/rust-encoding/pull/89.patch"},"body":"This allows for creation of alternative non-WHATWG encodings that use the same\r\ninterface as encodings defined in this crate without pulling in all the\r\ntables and encodings.\r\n\r\nThis commit does not introduce any breaking changes; all the types previously defined in\r\nencoding::types are reexported.\r\n\r\nFixes #81.\r\n\r\n---\r\n\r\nI tried to avoid breaking changes for now, but IMO `fn decode` being in `encoding::types` makes little sense; I’d move it to `encoding` at some point later."},"comment":{"url":"https://api.github.com/repos/lifthrasiir/rust-encoding/issues/comments/123385662","html_url":"https://github.com/lifthrasiir/rust-encoding/pull/89#issuecomment-123385662","issue_url":"https://api.github.com/repos/lifthrasiir/rust-encoding/issues/89","id":123385662,"user":{"login":"lifthrasiir","id":323836,"avatar_url":"https://avatars.githubusercontent.com/u/323836?v=3","gravatar_id":"","url":"https://api.github.com/users/lifthrasiir","html_url":"https://github.com/lifthrasiir","followers_url":"https://api.github.com/users/lifthrasiir/followers","following_url":"https://api.github.com/users/lifthrasiir/following{/other_user}","gists_url":"https://api.github.com/users/lifthrasiir/gists{/gist_id}","starred_url":"https://api.github.com/users/lifthrasiir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifthrasiir/subscriptions","organizations_url":"https://api.github.com/users/lifthrasiir/orgs","repos_url":"https://api.github.com/users/lifthrasiir/repos","events_url":"https://api.github.com/users/lifthrasiir/events{/privacy}","received_events_url":"https://api.github.com/users/lifthrasiir/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T16:02:57Z","updated_at":"2015-07-21T16:02:57Z","body":"@nagisa Ah, that's a legitimate reason (and my suggestion can be incrementally implemented anyway). I have no reason not to merge this, so I went ahead; thank you for the PR!"}}