{"action":"created","issue":{"url":"https://api.github.com/repos/cruffenach/CRToast/issues/125","labels_url":"https://api.github.com/repos/cruffenach/CRToast/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/cruffenach/CRToast/issues/125/comments","events_url":"https://api.github.com/repos/cruffenach/CRToast/issues/125/events","html_url":"https://github.com/cruffenach/CRToast/pull/125","id":52884138,"number":125,"title":"Complete Refactor","user":{"login":"dmiedema","id":511142,"avatar_url":"https://avatars.githubusercontent.com/u/511142?v=3","gravatar_id":"","url":"https://api.github.com/users/dmiedema","html_url":"https://github.com/dmiedema","followers_url":"https://api.github.com/users/dmiedema/followers","following_url":"https://api.github.com/users/dmiedema/following{/other_user}","gists_url":"https://api.github.com/users/dmiedema/gists{/gist_id}","starred_url":"https://api.github.com/users/dmiedema/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmiedema/subscriptions","organizations_url":"https://api.github.com/users/dmiedema/orgs","repos_url":"https://api.github.com/users/dmiedema/repos","events_url":"https://api.github.com/users/dmiedema/events{/privacy}","received_events_url":"https://api.github.com/users/dmiedema/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2014-12-26T06:12:48Z","updated_at":"2015-01-04T04:05:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cruffenach/CRToast/pulls/125","html_url":"https://github.com/cruffenach/CRToast/pull/125","diff_url":"https://github.com/cruffenach/CRToast/pull/125.diff","patch_url":"https://github.com/cruffenach/CRToast/pull/125.patch"},"body":"This is a complete reorganization of the current file structure. In the process I had to make a few more things 'public' since all the implementations were in one file allowing for shared knowledge.\r\n\r\nI don't know if this is something you're looking to do, however I would like to start the discussion about it. This PR supersedes all my other pull (https://github.com/cruffenach/CRToast/pull/122, https://github.com/cruffenach/CRToast/pull/121, https://github.com/cruffenach/CRToast/pull/120, https://github.com/cruffenach/CRToast/pull/115) requests as well as adds a few other features from other users that have mentioned changed in the issues (https://github.com/miwillhite/CRToast/commit/498a731fb818c3aa7e2e5cf2b6a5bb56c8befc9f, https://github.com/cruffenach/CRToast/pull/69). I'm not 100% sure the changes in https://github.com/cruffenach/CRToast/pull/69 are successful & still pass but thats another issue.\r\n\r\nIs this something that you would like to do? I feel that it adds a few requested features as well as fixes a few bugs. Maybe not in the same way but I tried to stay consistent to the current codebase. [issues with the current code format have been brought up](https://github.com/cruffenach/CRToast/issues/124) so i felt that refactoring was a decent idea even if it does come at a slight loss of elegance.\r\n\r\nThis is a gargantuan PR to look over so I totally understand not being super stoked about seeing it :grin: sorry."},"comment":{"url":"https://api.github.com/repos/cruffenach/CRToast/issues/comments/68620238","html_url":"https://github.com/cruffenach/CRToast/pull/125#issuecomment-68620238","issue_url":"https://api.github.com/repos/cruffenach/CRToast/issues/125","id":68620238,"user":{"login":"Ashton-W","id":1650398,"avatar_url":"https://avatars.githubusercontent.com/u/1650398?v=3","gravatar_id":"","url":"https://api.github.com/users/Ashton-W","html_url":"https://github.com/Ashton-W","followers_url":"https://api.github.com/users/Ashton-W/followers","following_url":"https://api.github.com/users/Ashton-W/following{/other_user}","gists_url":"https://api.github.com/users/Ashton-W/gists{/gist_id}","starred_url":"https://api.github.com/users/Ashton-W/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ashton-W/subscriptions","organizations_url":"https://api.github.com/users/Ashton-W/orgs","repos_url":"https://api.github.com/users/Ashton-W/repos","events_url":"https://api.github.com/users/Ashton-W/events{/privacy}","received_events_url":"https://api.github.com/users/Ashton-W/received_events","type":"User","site_admin":false},"created_at":"2015-01-04T04:05:29Z","updated_at":"2015-01-04T04:05:29Z","body":"It's using an enum so I think the only choice is to mask it's use out with a SDK check macro."}}