{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/docs/pulls/comments/23473259","id":23473259,"diff_hunk":"@@ -152,9 +152,9 @@ The `retrieveByToken` function retrieves a user by their unique `$identifier` an\n \n The `updateRememberToken` method updates the `$user` field `remember_token` with the new `$token`. The new token can be either a fresh token, assigned on successfull \"remember me\" login attempt, or a null when user is logged out.\n \n-The `retrieveByCredentials` method receives the array of credentials passed to the `Auth::attempt` method when attempting to sign into an application. The method should then \"query\" the underlying persistent storage for the user matching those credentials. Typically, this method will run a query with a \"where\" condition on `$credentials['username']`. **This method should not attempt to do any password validation or authentication.**\n+The `retrieveByCredentials` method receives the array of credentials passed to the `Auth::attempt` method when attempting to sign into an application. The method should then \"query\" the underlying persistent storage for the user matching those credentials. Typically, this method will run a query with a \"where\" condition on `$credentials['username']`. The method should then return an implementation of UserInterface. **This method should not attempt to do any password validation or authentication.**","path":"extending.md","position":5,"original_position":5,"commit_id":"64d9925d6d0176789c6cb840e963e39dae4cefee","original_commit_id":"64d9925d6d0176789c6cb840e963e39dae4cefee","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"UserInterface needs to be contained within \"`\".","created_at":"2015-01-23T19:29:05Z","updated_at":"2015-01-23T19:29:05Z","html_url":"https://github.com/laravel/docs/pull/1029#discussion_r23473259","pull_request_url":"https://api.github.com/repos/laravel/docs/pulls/1029","_links":{"self":{"href":"https://api.github.com/repos/laravel/docs/pulls/comments/23473259"},"html":{"href":"https://github.com/laravel/docs/pull/1029#discussion_r23473259"},"pull_request":{"href":"https://api.github.com/repos/laravel/docs/pulls/1029"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/docs/pulls/1029","id":27903934,"html_url":"https://github.com/laravel/docs/pull/1029","diff_url":"https://github.com/laravel/docs/pull/1029.diff","patch_url":"https://github.com/laravel/docs/pull/1029.patch","issue_url":"https://api.github.com/repos/laravel/docs/issues/1029","number":1029,"state":"open","locked":false,"title":"Clarified what retrieveByCredentials and validateCredentials return","user":{"login":"dustinalan","id":1383577,"avatar_url":"https://avatars.githubusercontent.com/u/1383577?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinalan","html_url":"https://github.com/dustinalan","followers_url":"https://api.github.com/users/dustinalan/followers","following_url":"https://api.github.com/users/dustinalan/following{/other_user}","gists_url":"https://api.github.com/users/dustinalan/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinalan/subscriptions","organizations_url":"https://api.github.com/users/dustinalan/orgs","repos_url":"https://api.github.com/users/dustinalan/repos","events_url":"https://api.github.com/users/dustinalan/events{/privacy}","received_events_url":"https://api.github.com/users/dustinalan/received_events","type":"User","site_admin":false},"body":"Hopefully will save someone some time with custom auth systems.","created_at":"2015-01-23T06:30:14Z","updated_at":"2015-01-23T19:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2771cfd70427203caa3190a960f18ba28a4a2442","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/docs/pulls/1029/commits","review_comments_url":"https://api.github.com/repos/laravel/docs/pulls/1029/comments","review_comment_url":"https://api.github.com/repos/laravel/docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/laravel/docs/issues/1029/comments","statuses_url":"https://api.github.com/repos/laravel/docs/statuses/64d9925d6d0176789c6cb840e963e39dae4cefee","head":{"label":"dustinalan:patch-1","ref":"patch-1","sha":"64d9925d6d0176789c6cb840e963e39dae4cefee","user":{"login":"dustinalan","id":1383577,"avatar_url":"https://avatars.githubusercontent.com/u/1383577?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinalan","html_url":"https://github.com/dustinalan","followers_url":"https://api.github.com/users/dustinalan/followers","following_url":"https://api.github.com/users/dustinalan/following{/other_user}","gists_url":"https://api.github.com/users/dustinalan/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinalan/subscriptions","organizations_url":"https://api.github.com/users/dustinalan/orgs","repos_url":"https://api.github.com/users/dustinalan/repos","events_url":"https://api.github.com/users/dustinalan/events{/privacy}","received_events_url":"https://api.github.com/users/dustinalan/received_events","type":"User","site_admin":false},"repo":{"id":29702483,"name":"docs","full_name":"dustinalan/docs","owner":{"login":"dustinalan","id":1383577,"avatar_url":"https://avatars.githubusercontent.com/u/1383577?v=3","gravatar_id":"","url":"https://api.github.com/users/dustinalan","html_url":"https://github.com/dustinalan","followers_url":"https://api.github.com/users/dustinalan/followers","following_url":"https://api.github.com/users/dustinalan/following{/other_user}","gists_url":"https://api.github.com/users/dustinalan/gists{/gist_id}","starred_url":"https://api.github.com/users/dustinalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dustinalan/subscriptions","organizations_url":"https://api.github.com/users/dustinalan/orgs","repos_url":"https://api.github.com/users/dustinalan/repos","events_url":"https://api.github.com/users/dustinalan/events{/privacy}","received_events_url":"https://api.github.com/users/dustinalan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dustinalan/docs","description":"","fork":true,"url":"https://api.github.com/repos/dustinalan/docs","forks_url":"https://api.github.com/repos/dustinalan/docs/forks","keys_url":"https://api.github.com/repos/dustinalan/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dustinalan/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dustinalan/docs/teams","hooks_url":"https://api.github.com/repos/dustinalan/docs/hooks","issue_events_url":"https://api.github.com/repos/dustinalan/docs/issues/events{/number}","events_url":"https://api.github.com/repos/dustinalan/docs/events","assignees_url":"https://api.github.com/repos/dustinalan/docs/assignees{/user}","branches_url":"https://api.github.com/repos/dustinalan/docs/branches{/branch}","tags_url":"https://api.github.com/repos/dustinalan/docs/tags","blobs_url":"https://api.github.com/repos/dustinalan/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dustinalan/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dustinalan/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dustinalan/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dustinalan/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/dustinalan/docs/languages","stargazers_url":"https://api.github.com/repos/dustinalan/docs/stargazers","contributors_url":"https://api.github.com/repos/dustinalan/docs/contributors","subscribers_url":"https://api.github.com/repos/dustinalan/docs/subscribers","subscription_url":"https://api.github.com/repos/dustinalan/docs/subscription","commits_url":"https://api.github.com/repos/dustinalan/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dustinalan/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dustinalan/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dustinalan/docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/dustinalan/docs/contents/{+path}","compare_url":"https://api.github.com/repos/dustinalan/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dustinalan/docs/merges","archive_url":"https://api.github.com/repos/dustinalan/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dustinalan/docs/downloads","issues_url":"https://api.github.com/repos/dustinalan/docs/issues{/number}","pulls_url":"https://api.github.com/repos/dustinalan/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/dustinalan/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/dustinalan/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dustinalan/docs/labels{/name}","releases_url":"https://api.github.com/repos/dustinalan/docs/releases{/id}","created_at":"2015-01-22T21:58:18Z","updated_at":"2015-01-20T17:04:13Z","pushed_at":"2015-01-23T06:29:32Z","git_url":"git://github.com/dustinalan/docs.git","ssh_url":"git@github.com:dustinalan/docs.git","clone_url":"https://github.com/dustinalan/docs.git","svn_url":"https://github.com/dustinalan/docs","homepage":"","size":1975,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"4.2"}},"base":{"label":"laravel:4.2","ref":"4.2","sha":"b26e2ff1c1483dfc9274d76c4e5d3ad9a99a3cce","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7546847,"name":"docs","full_name":"laravel/docs","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/docs","description":"","fork":false,"url":"https://api.github.com/repos/laravel/docs","forks_url":"https://api.github.com/repos/laravel/docs/forks","keys_url":"https://api.github.com/repos/laravel/docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/docs/teams","hooks_url":"https://api.github.com/repos/laravel/docs/hooks","issue_events_url":"https://api.github.com/repos/laravel/docs/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/docs/events","assignees_url":"https://api.github.com/repos/laravel/docs/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/docs/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/docs/tags","blobs_url":"https://api.github.com/repos/laravel/docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/docs/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/docs/languages","stargazers_url":"https://api.github.com/repos/laravel/docs/stargazers","contributors_url":"https://api.github.com/repos/laravel/docs/contributors","subscribers_url":"https://api.github.com/repos/laravel/docs/subscribers","subscription_url":"https://api.github.com/repos/laravel/docs/subscription","commits_url":"https://api.github.com/repos/laravel/docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/laravel/docs/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/docs/merges","archive_url":"https://api.github.com/repos/laravel/docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/docs/downloads","issues_url":"https://api.github.com/repos/laravel/docs/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/docs/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/docs/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/docs/labels{/name}","releases_url":"https://api.github.com/repos/laravel/docs/releases{/id}","created_at":"2013-01-10T19:08:45Z","updated_at":"2015-01-22T23:15:39Z","pushed_at":"2015-01-23T17:44:54Z","git_url":"git://github.com/laravel/docs.git","ssh_url":"git@github.com:laravel/docs.git","clone_url":"https://github.com/laravel/docs.git","svn_url":"https://github.com/laravel/docs","homepage":"","size":8571,"stargazers_count":386,"watchers_count":386,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":809,"mirror_url":null,"open_issues_count":96,"forks":809,"open_issues":96,"watchers":386,"default_branch":"4.2"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/docs/pulls/1029"},"html":{"href":"https://github.com/laravel/docs/pull/1029"},"issue":{"href":"https://api.github.com/repos/laravel/docs/issues/1029"},"comments":{"href":"https://api.github.com/repos/laravel/docs/issues/1029/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/docs/pulls/1029/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/laravel/docs/pulls/1029/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/docs/statuses/64d9925d6d0176789c6cb840e963e39dae4cefee"}}}}