{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2227","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2227/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2227/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2227/events","html_url":"https://github.com/ManageIQ/manageiq/pull/2227","id":62655080,"number":2227,"title":"Dialog reordering fixes - JS event storm, using id instead of original order","user":{"login":"himdel","id":289743,"avatar_url":"https://avatars.githubusercontent.com/u/289743?v=3","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-18T10:36:30Z","updated_at":"2015-03-18T10:47:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/2227","html_url":"https://github.com/ManageIQ/manageiq/pull/2227","diff_url":"https://github.com/ManageIQ/manageiq/pull/2227.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/2227.patch"},"body":"Reordering stuff in the service dialog editor wouldn't work unless each single reorder got saved. This was caused by the original order being used as index into the current array of items, meaning any subsequent change was using the wrong state. Rewritten to use ids, instead of order.\r\n\r\nAditionally, every single such change calls miqInitDashboardCols which *added* an event handler - meaning every reorder action generated twice more events than the previous one. Fixed to replace the event handler (`$.off` + `$.on` instead of `$.bind`).\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1203003"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/82889121","html_url":"https://github.com/ManageIQ/manageiq/pull/2227#issuecomment-82889121","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/2227","id":82889121,"user":{"login":"miq-bot","id":7806257,"avatar_url":"https://avatars.githubusercontent.com/u/7806257?v=3","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2015-03-18T10:47:40Z","updated_at":"2015-03-18T10:47:40Z","body":"<rubocop />Checked commits https://github.com/himdel/manageiq/commit/5e4fc47e9fcbdb404d1ce7aa3bd502ba83a9d50b .. https://github.com/himdel/manageiq/commit/150412117f01df1343c4d3d56ffbc6a37d2cd2ca with rubocop 0.27.1\n1 file checked, 0 offenses detected\nEverything looks good. :cake:\n"}}