{"action":"closed","number":1,"pull_request":{"url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/1","id":18172116,"html_url":"https://github.com/purpleidea/puppet-rsnapshot/pull/1","diff_url":"https://github.com/purpleidea/puppet-rsnapshot/pull/1.diff","patch_url":"https://github.com/purpleidea/puppet-rsnapshot/pull/1.patch","issue_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues/1","number":1,"state":"closed","locked":false,"title":"use 'echo' in included backup conf definition to avoid error due to ``s","user":{"login":"joelbernstein","id":45095,"avatar_url":"https://avatars.githubusercontent.com/u/45095?v=3","gravatar_id":"","url":"https://api.github.com/users/joelbernstein","html_url":"https://github.com/joelbernstein","followers_url":"https://api.github.com/users/joelbernstein/followers","following_url":"https://api.github.com/users/joelbernstein/following{/other_user}","gists_url":"https://api.github.com/users/joelbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/joelbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelbernstein/subscriptions","organizations_url":"https://api.github.com/users/joelbernstein/orgs","repos_url":"https://api.github.com/users/joelbernstein/repos","events_url":"https://api.github.com/users/joelbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/joelbernstein/received_events","type":"User","site_admin":false},"body":"Currently, master tries to include a set of rsnapshot backup definitions by including a shell script like:\r\ninclude_conf `/path/to/include.sh`\r\ninclude.sh does something like: cat /path/to/include.d/*.conf\r\n\r\nEach of those files looks like \"backup\\t\\t...\" and contains a definition intended to be interpolated where the first include_conf directive is used. However, at least under bash on the gentoo boxes I'm working on, that results in a shell error complaining that \"backup\" is not a valid command. It's trying to execute that line, due to the `` backticks.\r\n\r\nI'm not sure whether this is by design (and there's some issue with my environment), whether Puppet or rsnapshot have changed their behaviour, or whether this is actually just a bug, however this 1 line change fixes the problem by forcing the line through \"echo\".\r\n\r\nI'm happy to discuss or provide more example of how to reproduce the issue.","created_at":"2014-07-09T16:50:29Z","updated_at":"2015-04-21T20:18:16Z","closed_at":"2015-04-21T20:18:16Z","merged_at":null,"merge_commit_sha":"1b49f2c5aa2b3eb937f1e678d41cbadecd83effa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/1/commits","review_comments_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/1/comments","review_comment_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues/1/comments","statuses_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/statuses/cb21ac43d00df8b37bc1a76c2cc23e986a10ec17","head":{"label":"joelbernstein:master","ref":"master","sha":"cb21ac43d00df8b37bc1a76c2cc23e986a10ec17","user":{"login":"joelbernstein","id":45095,"avatar_url":"https://avatars.githubusercontent.com/u/45095?v=3","gravatar_id":"","url":"https://api.github.com/users/joelbernstein","html_url":"https://github.com/joelbernstein","followers_url":"https://api.github.com/users/joelbernstein/followers","following_url":"https://api.github.com/users/joelbernstein/following{/other_user}","gists_url":"https://api.github.com/users/joelbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/joelbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelbernstein/subscriptions","organizations_url":"https://api.github.com/users/joelbernstein/orgs","repos_url":"https://api.github.com/users/joelbernstein/repos","events_url":"https://api.github.com/users/joelbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/joelbernstein/received_events","type":"User","site_admin":false},"repo":{"id":21660240,"name":"puppet-rsnapshot","full_name":"joelbernstein/puppet-rsnapshot","owner":{"login":"joelbernstein","id":45095,"avatar_url":"https://avatars.githubusercontent.com/u/45095?v=3","gravatar_id":"","url":"https://api.github.com/users/joelbernstein","html_url":"https://github.com/joelbernstein","followers_url":"https://api.github.com/users/joelbernstein/followers","following_url":"https://api.github.com/users/joelbernstein/following{/other_user}","gists_url":"https://api.github.com/users/joelbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/joelbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joelbernstein/subscriptions","organizations_url":"https://api.github.com/users/joelbernstein/orgs","repos_url":"https://api.github.com/users/joelbernstein/repos","events_url":"https://api.github.com/users/joelbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/joelbernstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joelbernstein/puppet-rsnapshot","description":"puppet module for rsnapshot","fork":true,"url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot","forks_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/forks","keys_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/teams","hooks_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/hooks","issue_events_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/issues/events{/number}","events_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/events","assignees_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/assignees{/user}","branches_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/branches{/branch}","tags_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/tags","blobs_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/statuses/{sha}","languages_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/languages","stargazers_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/stargazers","contributors_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/contributors","subscribers_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/subscribers","subscription_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/subscription","commits_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/contents/{+path}","compare_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/merges","archive_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/downloads","issues_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/issues{/number}","pulls_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/pulls{/number}","milestones_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/milestones{/number}","notifications_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/labels{/name}","releases_url":"https://api.github.com/repos/joelbernstein/puppet-rsnapshot/releases{/id}","created_at":"2014-07-09T16:35:57Z","updated_at":"2014-07-09T16:46:06Z","pushed_at":"2014-07-09T16:46:05Z","git_url":"git://github.com/joelbernstein/puppet-rsnapshot.git","ssh_url":"git@github.com:joelbernstein/puppet-rsnapshot.git","clone_url":"https://github.com/joelbernstein/puppet-rsnapshot.git","svn_url":"https://github.com/joelbernstein/puppet-rsnapshot","homepage":null,"size":185,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"purpleidea:master","ref":"master","sha":"fb970322dbb92746491586c731a1aae12f3016db","user":{"login":"purpleidea","id":135091,"avatar_url":"https://avatars.githubusercontent.com/u/135091?v=3","gravatar_id":"","url":"https://api.github.com/users/purpleidea","html_url":"https://github.com/purpleidea","followers_url":"https://api.github.com/users/purpleidea/followers","following_url":"https://api.github.com/users/purpleidea/following{/other_user}","gists_url":"https://api.github.com/users/purpleidea/gists{/gist_id}","starred_url":"https://api.github.com/users/purpleidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpleidea/subscriptions","organizations_url":"https://api.github.com/users/purpleidea/orgs","repos_url":"https://api.github.com/users/purpleidea/repos","events_url":"https://api.github.com/users/purpleidea/events{/privacy}","received_events_url":"https://api.github.com/users/purpleidea/received_events","type":"User","site_admin":false},"repo":{"id":10467881,"name":"puppet-rsnapshot","full_name":"purpleidea/puppet-rsnapshot","owner":{"login":"purpleidea","id":135091,"avatar_url":"https://avatars.githubusercontent.com/u/135091?v=3","gravatar_id":"","url":"https://api.github.com/users/purpleidea","html_url":"https://github.com/purpleidea","followers_url":"https://api.github.com/users/purpleidea/followers","following_url":"https://api.github.com/users/purpleidea/following{/other_user}","gists_url":"https://api.github.com/users/purpleidea/gists{/gist_id}","starred_url":"https://api.github.com/users/purpleidea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpleidea/subscriptions","organizations_url":"https://api.github.com/users/purpleidea/orgs","repos_url":"https://api.github.com/users/purpleidea/repos","events_url":"https://api.github.com/users/purpleidea/events{/privacy}","received_events_url":"https://api.github.com/users/purpleidea/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/purpleidea/puppet-rsnapshot","description":"puppet module for rsnapshot","fork":false,"url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot","forks_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/forks","keys_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/teams","hooks_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/hooks","issue_events_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues/events{/number}","events_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/events","assignees_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/assignees{/user}","branches_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/branches{/branch}","tags_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/tags","blobs_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/git/refs{/sha}","trees_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/statuses/{sha}","languages_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/languages","stargazers_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/stargazers","contributors_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/contributors","subscribers_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/subscribers","subscription_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/subscription","commits_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/commits{/sha}","git_commits_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/git/commits{/sha}","comments_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/comments{/number}","issue_comment_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues/comments{/number}","contents_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/contents/{+path}","compare_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/merges","archive_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/downloads","issues_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues{/number}","pulls_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls{/number}","milestones_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/milestones{/number}","notifications_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/labels{/name}","releases_url":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/releases{/id}","created_at":"2013-06-04T00:31:33Z","updated_at":"2014-12-09T21:10:27Z","pushed_at":"2013-06-04T03:49:51Z","git_url":"git://github.com/purpleidea/puppet-rsnapshot.git","ssh_url":"git@github.com:purpleidea/puppet-rsnapshot.git","clone_url":"https://github.com/purpleidea/puppet-rsnapshot.git","svn_url":"https://github.com/purpleidea/puppet-rsnapshot","homepage":null,"size":180,"stargazers_count":3,"watchers_count":3,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/1"},"html":{"href":"https://github.com/purpleidea/puppet-rsnapshot/pull/1"},"issue":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues/1"},"comments":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/purpleidea/puppet-rsnapshot/statuses/cb21ac43d00df8b37bc1a76c2cc23e986a10ec17"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":5,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}