{"action":"created","comment":{"url":"https://api.github.com/repos/feross/SpoofMAC/pulls/comments/48453584","id":48453584,"diff_hunk":"@@ -63,7 +144,8 @@ def find_interfaces(self, targets=None):\n         # - the adapter name/device associated with this, if any,\n         # - the MAC address, if any\n \n-        output = subprocess.check_output([\"ifconfig\"], stderr=subprocess.STDOUT, universal_newlines=True)\n+        #output = subprocess.check_output([\"ifconfig\"], stderr=subprocess.STDOUT, universal_newlines=True)\n+        output = subprocess.check_output([\"ip addr\"], stderr=subprocess.STDOUT, universal_newlines=True)","path":"spoofmac/interface.py","position":101,"original_position":101,"commit_id":"d19d0ab8aac698fb2fe3503b27b3d4bd79562ffb","original_commit_id":"d19d0ab8aac698fb2fe3503b27b3d4bd79562ffb","user":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"body":"Shouldn't this line stay unchanged?","created_at":"2015-12-27T10:48:51Z","updated_at":"2015-12-27T10:48:51Z","html_url":"https://github.com/feross/SpoofMAC/pull/58#discussion_r48453584","pull_request_url":"https://api.github.com/repos/feross/SpoofMAC/pulls/58","_links":{"self":{"href":"https://api.github.com/repos/feross/SpoofMAC/pulls/comments/48453584"},"html":{"href":"https://github.com/feross/SpoofMAC/pull/58#discussion_r48453584"},"pull_request":{"href":"https://api.github.com/repos/feross/SpoofMAC/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/feross/SpoofMAC/pulls/58","id":54615506,"html_url":"https://github.com/feross/SpoofMAC/pull/58","diff_url":"https://github.com/feross/SpoofMAC/pull/58.diff","patch_url":"https://github.com/feross/SpoofMAC/pull/58.patch","issue_url":"https://api.github.com/repos/feross/SpoofMAC/issues/58","number":58,"state":"open","locked":false,"title":"Add command ip support for linux platform","user":{"login":"lublud","id":3452658,"avatar_url":"https://avatars.githubusercontent.com/u/3452658?v=3","gravatar_id":"","url":"https://api.github.com/users/lublud","html_url":"https://github.com/lublud","followers_url":"https://api.github.com/users/lublud/followers","following_url":"https://api.github.com/users/lublud/following{/other_user}","gists_url":"https://api.github.com/users/lublud/gists{/gist_id}","starred_url":"https://api.github.com/users/lublud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lublud/subscriptions","organizations_url":"https://api.github.com/users/lublud/orgs","repos_url":"https://api.github.com/users/lublud/repos","events_url":"https://api.github.com/users/lublud/events{/privacy}","received_events_url":"https://api.github.com/users/lublud/received_events","type":"User","site_admin":false},"body":"Being a arch linux user, `ip` has been chosen over `ifconfig` [deprecated](https://www.archlinux.org/news/deprecation-of-net-tools/).\r\n\r\nI thus changed a bit the code so I can use it with `ip`.\r\n\r\nTested only on arch linux.","created_at":"2015-12-27T10:47:01Z","updated_at":"2015-12-27T10:48:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66ed76172bb0be287cc3cce71ee680ee02b5e64d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/feross/SpoofMAC/pulls/58/commits","review_comments_url":"https://api.github.com/repos/feross/SpoofMAC/pulls/58/comments","review_comment_url":"https://api.github.com/repos/feross/SpoofMAC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/feross/SpoofMAC/issues/58/comments","statuses_url":"https://api.github.com/repos/feross/SpoofMAC/statuses/d19d0ab8aac698fb2fe3503b27b3d4bd79562ffb","head":{"label":"lublud:master","ref":"master","sha":"d19d0ab8aac698fb2fe3503b27b3d4bd79562ffb","user":{"login":"lublud","id":3452658,"avatar_url":"https://avatars.githubusercontent.com/u/3452658?v=3","gravatar_id":"","url":"https://api.github.com/users/lublud","html_url":"https://github.com/lublud","followers_url":"https://api.github.com/users/lublud/followers","following_url":"https://api.github.com/users/lublud/following{/other_user}","gists_url":"https://api.github.com/users/lublud/gists{/gist_id}","starred_url":"https://api.github.com/users/lublud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lublud/subscriptions","organizations_url":"https://api.github.com/users/lublud/orgs","repos_url":"https://api.github.com/users/lublud/repos","events_url":"https://api.github.com/users/lublud/events{/privacy}","received_events_url":"https://api.github.com/users/lublud/received_events","type":"User","site_admin":false},"repo":{"id":47921791,"name":"SpoofMAC","full_name":"lublud/SpoofMAC","owner":{"login":"lublud","id":3452658,"avatar_url":"https://avatars.githubusercontent.com/u/3452658?v=3","gravatar_id":"","url":"https://api.github.com/users/lublud","html_url":"https://github.com/lublud","followers_url":"https://api.github.com/users/lublud/followers","following_url":"https://api.github.com/users/lublud/following{/other_user}","gists_url":"https://api.github.com/users/lublud/gists{/gist_id}","starred_url":"https://api.github.com/users/lublud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lublud/subscriptions","organizations_url":"https://api.github.com/users/lublud/orgs","repos_url":"https://api.github.com/users/lublud/repos","events_url":"https://api.github.com/users/lublud/events{/privacy}","received_events_url":"https://api.github.com/users/lublud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lublud/SpoofMAC","description":":briefcase: Change your MAC address (OS X, Windows, Linux)","fork":true,"url":"https://api.github.com/repos/lublud/SpoofMAC","forks_url":"https://api.github.com/repos/lublud/SpoofMAC/forks","keys_url":"https://api.github.com/repos/lublud/SpoofMAC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lublud/SpoofMAC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lublud/SpoofMAC/teams","hooks_url":"https://api.github.com/repos/lublud/SpoofMAC/hooks","issue_events_url":"https://api.github.com/repos/lublud/SpoofMAC/issues/events{/number}","events_url":"https://api.github.com/repos/lublud/SpoofMAC/events","assignees_url":"https://api.github.com/repos/lublud/SpoofMAC/assignees{/user}","branches_url":"https://api.github.com/repos/lublud/SpoofMAC/branches{/branch}","tags_url":"https://api.github.com/repos/lublud/SpoofMAC/tags","blobs_url":"https://api.github.com/repos/lublud/SpoofMAC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lublud/SpoofMAC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lublud/SpoofMAC/git/refs{/sha}","trees_url":"https://api.github.com/repos/lublud/SpoofMAC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lublud/SpoofMAC/statuses/{sha}","languages_url":"https://api.github.com/repos/lublud/SpoofMAC/languages","stargazers_url":"https://api.github.com/repos/lublud/SpoofMAC/stargazers","contributors_url":"https://api.github.com/repos/lublud/SpoofMAC/contributors","subscribers_url":"https://api.github.com/repos/lublud/SpoofMAC/subscribers","subscription_url":"https://api.github.com/repos/lublud/SpoofMAC/subscription","commits_url":"https://api.github.com/repos/lublud/SpoofMAC/commits{/sha}","git_commits_url":"https://api.github.com/repos/lublud/SpoofMAC/git/commits{/sha}","comments_url":"https://api.github.com/repos/lublud/SpoofMAC/comments{/number}","issue_comment_url":"https://api.github.com/repos/lublud/SpoofMAC/issues/comments{/number}","contents_url":"https://api.github.com/repos/lublud/SpoofMAC/contents/{+path}","compare_url":"https://api.github.com/repos/lublud/SpoofMAC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lublud/SpoofMAC/merges","archive_url":"https://api.github.com/repos/lublud/SpoofMAC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lublud/SpoofMAC/downloads","issues_url":"https://api.github.com/repos/lublud/SpoofMAC/issues{/number}","pulls_url":"https://api.github.com/repos/lublud/SpoofMAC/pulls{/number}","milestones_url":"https://api.github.com/repos/lublud/SpoofMAC/milestones{/number}","notifications_url":"https://api.github.com/repos/lublud/SpoofMAC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lublud/SpoofMAC/labels{/name}","releases_url":"https://api.github.com/repos/lublud/SpoofMAC/releases{/id}","created_at":"2015-12-13T14:12:47Z","updated_at":"2015-12-13T14:12:47Z","pushed_at":"2015-12-27T10:33:56Z","git_url":"git://github.com/lublud/SpoofMAC.git","ssh_url":"git@github.com:lublud/SpoofMAC.git","clone_url":"https://github.com/lublud/SpoofMAC.git","svn_url":"https://github.com/lublud/SpoofMAC","homepage":"http://feross.org/spoofmac/","size":115,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"feross:master","ref":"master","sha":"5601b20ffc4ed8eeb451945fab911d6451f49926","user":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"repo":{"id":2300485,"name":"SpoofMAC","full_name":"feross/SpoofMAC","owner":{"login":"feross","id":121766,"avatar_url":"https://avatars.githubusercontent.com/u/121766?v=3","gravatar_id":"","url":"https://api.github.com/users/feross","html_url":"https://github.com/feross","followers_url":"https://api.github.com/users/feross/followers","following_url":"https://api.github.com/users/feross/following{/other_user}","gists_url":"https://api.github.com/users/feross/gists{/gist_id}","starred_url":"https://api.github.com/users/feross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feross/subscriptions","organizations_url":"https://api.github.com/users/feross/orgs","repos_url":"https://api.github.com/users/feross/repos","events_url":"https://api.github.com/users/feross/events{/privacy}","received_events_url":"https://api.github.com/users/feross/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feross/SpoofMAC","description":":briefcase: Change your MAC address (OS X, Windows, Linux)","fork":false,"url":"https://api.github.com/repos/feross/SpoofMAC","forks_url":"https://api.github.com/repos/feross/SpoofMAC/forks","keys_url":"https://api.github.com/repos/feross/SpoofMAC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feross/SpoofMAC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feross/SpoofMAC/teams","hooks_url":"https://api.github.com/repos/feross/SpoofMAC/hooks","issue_events_url":"https://api.github.com/repos/feross/SpoofMAC/issues/events{/number}","events_url":"https://api.github.com/repos/feross/SpoofMAC/events","assignees_url":"https://api.github.com/repos/feross/SpoofMAC/assignees{/user}","branches_url":"https://api.github.com/repos/feross/SpoofMAC/branches{/branch}","tags_url":"https://api.github.com/repos/feross/SpoofMAC/tags","blobs_url":"https://api.github.com/repos/feross/SpoofMAC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feross/SpoofMAC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feross/SpoofMAC/git/refs{/sha}","trees_url":"https://api.github.com/repos/feross/SpoofMAC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feross/SpoofMAC/statuses/{sha}","languages_url":"https://api.github.com/repos/feross/SpoofMAC/languages","stargazers_url":"https://api.github.com/repos/feross/SpoofMAC/stargazers","contributors_url":"https://api.github.com/repos/feross/SpoofMAC/contributors","subscribers_url":"https://api.github.com/repos/feross/SpoofMAC/subscribers","subscription_url":"https://api.github.com/repos/feross/SpoofMAC/subscription","commits_url":"https://api.github.com/repos/feross/SpoofMAC/commits{/sha}","git_commits_url":"https://api.github.com/repos/feross/SpoofMAC/git/commits{/sha}","comments_url":"https://api.github.com/repos/feross/SpoofMAC/comments{/number}","issue_comment_url":"https://api.github.com/repos/feross/SpoofMAC/issues/comments{/number}","contents_url":"https://api.github.com/repos/feross/SpoofMAC/contents/{+path}","compare_url":"https://api.github.com/repos/feross/SpoofMAC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feross/SpoofMAC/merges","archive_url":"https://api.github.com/repos/feross/SpoofMAC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feross/SpoofMAC/downloads","issues_url":"https://api.github.com/repos/feross/SpoofMAC/issues{/number}","pulls_url":"https://api.github.com/repos/feross/SpoofMAC/pulls{/number}","milestones_url":"https://api.github.com/repos/feross/SpoofMAC/milestones{/number}","notifications_url":"https://api.github.com/repos/feross/SpoofMAC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feross/SpoofMAC/labels{/name}","releases_url":"https://api.github.com/repos/feross/SpoofMAC/releases{/id}","created_at":"2011-08-31T08:43:43Z","updated_at":"2015-12-27T08:51:34Z","pushed_at":"2015-12-27T10:47:01Z","git_url":"git://github.com/feross/SpoofMAC.git","ssh_url":"git@github.com:feross/SpoofMAC.git","clone_url":"https://github.com/feross/SpoofMAC.git","svn_url":"https://github.com/feross/SpoofMAC","homepage":"http://feross.org/spoofmac/","size":488,"stargazers_count":1549,"watchers_count":1549,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":6,"forks":138,"open_issues":6,"watchers":1549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/feross/SpoofMAC/pulls/58"},"html":{"href":"https://github.com/feross/SpoofMAC/pull/58"},"issue":{"href":"https://api.github.com/repos/feross/SpoofMAC/issues/58"},"comments":{"href":"https://api.github.com/repos/feross/SpoofMAC/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/feross/SpoofMAC/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/feross/SpoofMAC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/feross/SpoofMAC/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/feross/SpoofMAC/statuses/d19d0ab8aac698fb2fe3503b27b3d4bd79562ffb"}}}}