{"action":"created","comment":{"url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/comments/36587804","id":36587804,"diff_hunk":"@@ -3,7 +3,7 @@\n /// An ``Optional`` can contain ``Optional::Value<T>`` or ``Optional::Absent``.\n /// It is similar to an ``Option``, but ``Optional::Absent`` means it will be\n /// omitted when serialized, while ``None`` will be serialized to ``null``.\n-#[derive(Debug, Copy, Clone)]\n+#[derive(Clone, Copy, PartialEq, PartialOrd, Eq, Ord, Debug, Hash)]","path":"spaceapi/src/utils.rs","position":5,"original_position":5,"commit_id":"7c2bfba76b17f6b04eca55a721a601ee46aa366c","original_commit_id":"7c2bfba76b17f6b04eca55a721a601ee46aa366c","user":{"login":"dbrgn","id":105168,"avatar_url":"https://avatars.githubusercontent.com/u/105168?v=3","gravatar_id":"","url":"https://api.github.com/users/dbrgn","html_url":"https://github.com/dbrgn","followers_url":"https://api.github.com/users/dbrgn/followers","following_url":"https://api.github.com/users/dbrgn/following{/other_user}","gists_url":"https://api.github.com/users/dbrgn/gists{/gist_id}","starred_url":"https://api.github.com/users/dbrgn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbrgn/subscriptions","organizations_url":"https://api.github.com/users/dbrgn/orgs","repos_url":"https://api.github.com/users/dbrgn/repos","events_url":"https://api.github.com/users/dbrgn/events{/privacy}","received_events_url":"https://api.github.com/users/dbrgn/received_events","type":"User","site_admin":false},"body":"How are `Optional<T>` compared when deriving these traits? Also, why are we using both `PartialEq` and `Eq`? Do you think `Absent == Absent` should be `True`? And if we want `Eq` behavior, do we also need `PartialEq`?","created_at":"2015-08-09T13:11:51Z","updated_at":"2015-08-09T13:11:51Z","html_url":"https://github.com/coredump-ch/spaceapi/pull/54#discussion_r36587804","pull_request_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54","_links":{"self":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/comments/36587804"},"html":{"href":"https://github.com/coredump-ch/spaceapi/pull/54#discussion_r36587804"},"pull_request":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54","id":41970129,"html_url":"https://github.com/coredump-ch/spaceapi/pull/54","diff_url":"https://github.com/coredump-ch/spaceapi/pull/54.diff","patch_url":"https://github.com/coredump-ch/spaceapi/pull/54.patch","issue_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/54","number":54,"state":"open","locked":false,"title":"Update open state","user":{"login":"rnestler","id":1435346,"avatar_url":"https://avatars.githubusercontent.com/u/1435346?v=3","gravatar_id":"","url":"https://api.github.com/users/rnestler","html_url":"https://github.com/rnestler","followers_url":"https://api.github.com/users/rnestler/followers","following_url":"https://api.github.com/users/rnestler/following{/other_user}","gists_url":"https://api.github.com/users/rnestler/gists{/gist_id}","starred_url":"https://api.github.com/users/rnestler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rnestler/subscriptions","organizations_url":"https://api.github.com/users/rnestler/orgs","repos_url":"https://api.github.com/users/rnestler/repos","events_url":"https://api.github.com/users/rnestler/events{/privacy}","received_events_url":"https://api.github.com/users/rnestler/received_events","type":"User","site_admin":false},"body":"This updates the open state according to the `value` in the people_now_present sensor. Note that currently it updates only the `open` field. Maybe we should also add a `StateTemplate` similar to the sensor templates. Or provide a hook or something similar to update the state variable.","created_at":"2015-08-09T13:07:00Z","updated_at":"2015-08-09T13:11:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"879c0adea9f0357bdbe5c012af0c716dfb2ab775","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54/commits","review_comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54/comments","review_comment_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/54/comments","statuses_url":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/7c2bfba76b17f6b04eca55a721a601ee46aa366c","head":{"label":"coredump-ch:update_open_state","ref":"update_open_state","sha":"7c2bfba76b17f6b04eca55a721a601ee46aa366c","user":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":16317444,"name":"spaceapi","full_name":"coredump-ch/spaceapi","owner":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coredump-ch/spaceapi","description":"Implementation of the Space API.","fork":false,"url":"https://api.github.com/repos/coredump-ch/spaceapi","forks_url":"https://api.github.com/repos/coredump-ch/spaceapi/forks","keys_url":"https://api.github.com/repos/coredump-ch/spaceapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coredump-ch/spaceapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coredump-ch/spaceapi/teams","hooks_url":"https://api.github.com/repos/coredump-ch/spaceapi/hooks","issue_events_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/events{/number}","events_url":"https://api.github.com/repos/coredump-ch/spaceapi/events","assignees_url":"https://api.github.com/repos/coredump-ch/spaceapi/assignees{/user}","branches_url":"https://api.github.com/repos/coredump-ch/spaceapi/branches{/branch}","tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/tags","blobs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/{sha}","languages_url":"https://api.github.com/repos/coredump-ch/spaceapi/languages","stargazers_url":"https://api.github.com/repos/coredump-ch/spaceapi/stargazers","contributors_url":"https://api.github.com/repos/coredump-ch/spaceapi/contributors","subscribers_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscribers","subscription_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscription","commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/coredump-ch/spaceapi/contents/{+path}","compare_url":"https://api.github.com/repos/coredump-ch/spaceapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coredump-ch/spaceapi/merges","archive_url":"https://api.github.com/repos/coredump-ch/spaceapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coredump-ch/spaceapi/downloads","issues_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues{/number}","pulls_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls{/number}","milestones_url":"https://api.github.com/repos/coredump-ch/spaceapi/milestones{/number}","notifications_url":"https://api.github.com/repos/coredump-ch/spaceapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coredump-ch/spaceapi/labels{/name}","releases_url":"https://api.github.com/repos/coredump-ch/spaceapi/releases{/id}","created_at":"2014-01-28T16:23:32Z","updated_at":"2015-06-03T06:45:20Z","pushed_at":"2015-08-09T13:07:00Z","git_url":"git://github.com/coredump-ch/spaceapi.git","ssh_url":"git@github.com:coredump-ch/spaceapi.git","clone_url":"https://github.com/coredump-ch/spaceapi.git","svn_url":"https://github.com/coredump-ch/spaceapi","homepage":null,"size":728,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"rust"}},"base":{"label":"coredump-ch:rust","ref":"rust","sha":"fa61ed570ec221209406e1ed81ebcc771e0f04a4","user":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"repo":{"id":16317444,"name":"spaceapi","full_name":"coredump-ch/spaceapi","owner":{"login":"coredump-ch","id":5295118,"avatar_url":"https://avatars.githubusercontent.com/u/5295118?v=3","gravatar_id":"","url":"https://api.github.com/users/coredump-ch","html_url":"https://github.com/coredump-ch","followers_url":"https://api.github.com/users/coredump-ch/followers","following_url":"https://api.github.com/users/coredump-ch/following{/other_user}","gists_url":"https://api.github.com/users/coredump-ch/gists{/gist_id}","starred_url":"https://api.github.com/users/coredump-ch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coredump-ch/subscriptions","organizations_url":"https://api.github.com/users/coredump-ch/orgs","repos_url":"https://api.github.com/users/coredump-ch/repos","events_url":"https://api.github.com/users/coredump-ch/events{/privacy}","received_events_url":"https://api.github.com/users/coredump-ch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coredump-ch/spaceapi","description":"Implementation of the Space API.","fork":false,"url":"https://api.github.com/repos/coredump-ch/spaceapi","forks_url":"https://api.github.com/repos/coredump-ch/spaceapi/forks","keys_url":"https://api.github.com/repos/coredump-ch/spaceapi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coredump-ch/spaceapi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coredump-ch/spaceapi/teams","hooks_url":"https://api.github.com/repos/coredump-ch/spaceapi/hooks","issue_events_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/events{/number}","events_url":"https://api.github.com/repos/coredump-ch/spaceapi/events","assignees_url":"https://api.github.com/repos/coredump-ch/spaceapi/assignees{/user}","branches_url":"https://api.github.com/repos/coredump-ch/spaceapi/branches{/branch}","tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/tags","blobs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/refs{/sha}","trees_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/{sha}","languages_url":"https://api.github.com/repos/coredump-ch/spaceapi/languages","stargazers_url":"https://api.github.com/repos/coredump-ch/spaceapi/stargazers","contributors_url":"https://api.github.com/repos/coredump-ch/spaceapi/contributors","subscribers_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscribers","subscription_url":"https://api.github.com/repos/coredump-ch/spaceapi/subscription","commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/commits{/sha}","git_commits_url":"https://api.github.com/repos/coredump-ch/spaceapi/git/commits{/sha}","comments_url":"https://api.github.com/repos/coredump-ch/spaceapi/comments{/number}","issue_comment_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues/comments{/number}","contents_url":"https://api.github.com/repos/coredump-ch/spaceapi/contents/{+path}","compare_url":"https://api.github.com/repos/coredump-ch/spaceapi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coredump-ch/spaceapi/merges","archive_url":"https://api.github.com/repos/coredump-ch/spaceapi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coredump-ch/spaceapi/downloads","issues_url":"https://api.github.com/repos/coredump-ch/spaceapi/issues{/number}","pulls_url":"https://api.github.com/repos/coredump-ch/spaceapi/pulls{/number}","milestones_url":"https://api.github.com/repos/coredump-ch/spaceapi/milestones{/number}","notifications_url":"https://api.github.com/repos/coredump-ch/spaceapi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coredump-ch/spaceapi/labels{/name}","releases_url":"https://api.github.com/repos/coredump-ch/spaceapi/releases{/id}","created_at":"2014-01-28T16:23:32Z","updated_at":"2015-06-03T06:45:20Z","pushed_at":"2015-08-09T13:07:00Z","git_url":"git://github.com/coredump-ch/spaceapi.git","ssh_url":"git@github.com:coredump-ch/spaceapi.git","clone_url":"https://github.com/coredump-ch/spaceapi.git","svn_url":"https://github.com/coredump-ch/spaceapi","homepage":null,"size":728,"stargazers_count":3,"watchers_count":3,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":15,"forks":0,"open_issues":15,"watchers":3,"default_branch":"rust"}},"_links":{"self":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54"},"html":{"href":"https://github.com/coredump-ch/spaceapi/pull/54"},"issue":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/issues/54"},"comments":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/coredump-ch/spaceapi/statuses/7c2bfba76b17f6b04eca55a721a601ee46aa366c"}}}}