{"action":"created","issue":{"url":"https://api.github.com/repos/cvmfs/cvmfs/issues/694","labels_url":"https://api.github.com/repos/cvmfs/cvmfs/issues/694/labels{/name}","comments_url":"https://api.github.com/repos/cvmfs/cvmfs/issues/694/comments","events_url":"https://api.github.com/repos/cvmfs/cvmfs/issues/694/events","html_url":"https://github.com/cvmfs/cvmfs/pull/694","id":54318861,"number":694,"title":"Fix: Rename Timestamp Threshold and Remove CVMFS_GARBAGE_COLLECTION from Stratum 1","user":{"login":"reneme","id":1562139,"avatar_url":"https://avatars.githubusercontent.com/u/1562139?v=3","gravatar_id":"","url":"https://api.github.com/users/reneme","html_url":"https://github.com/reneme","followers_url":"https://api.github.com/users/reneme/followers","following_url":"https://api.github.com/users/reneme/following{/other_user}","gists_url":"https://api.github.com/users/reneme/gists{/gist_id}","starred_url":"https://api.github.com/users/reneme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reneme/subscriptions","organizations_url":"https://api.github.com/users/reneme/orgs","repos_url":"https://api.github.com/users/reneme/repos","events_url":"https://api.github.com/users/reneme/events{/privacy}","received_events_url":"https://api.github.com/users/reneme/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-14T12:55:33Z","updated_at":"2015-01-14T21:02:13Z","closed_at":"2015-01-14T14:55:13Z","pull_request":{"url":"https://api.github.com/repos/cvmfs/cvmfs/pulls/694","html_url":"https://github.com/cvmfs/cvmfs/pull/694","diff_url":"https://github.com/cvmfs/cvmfs/pull/694.diff","patch_url":"https://github.com/cvmfs/cvmfs/pull/694.patch"},"body":"As @DrDaveD correctly pointed out, `CVMFS_GARBAGE_COLLECTION=true` is not necessary on stratum 1 as this information is already embedded in the manifest file put together and signed by stratum 0. Therefore, this makes `CVMFS_GARBAGE_COLLECTION` a stratum-0-only configuration variable and takes only the *.cvmfspublished* file into account on stratum 1. Furthermore this renames `CVMFS_GC_TIMESTAMP_THRESHOLD` to `CVMFS_AUTO_GC_TIMESPAN` for better usability."},"comment":{"url":"https://api.github.com/repos/cvmfs/cvmfs/issues/comments/69991005","html_url":"https://github.com/cvmfs/cvmfs/pull/694#issuecomment-69991005","issue_url":"https://api.github.com/repos/cvmfs/cvmfs/issues/694","id":69991005,"user":{"login":"DrDaveD","id":2129743,"avatar_url":"https://avatars.githubusercontent.com/u/2129743?v=3","gravatar_id":"","url":"https://api.github.com/users/DrDaveD","html_url":"https://github.com/DrDaveD","followers_url":"https://api.github.com/users/DrDaveD/followers","following_url":"https://api.github.com/users/DrDaveD/following{/other_user}","gists_url":"https://api.github.com/users/DrDaveD/gists{/gist_id}","starred_url":"https://api.github.com/users/DrDaveD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrDaveD/subscriptions","organizations_url":"https://api.github.com/users/DrDaveD/orgs","repos_url":"https://api.github.com/users/DrDaveD/repos","events_url":"https://api.github.com/users/DrDaveD/events{/privacy}","received_events_url":"https://api.github.com/users/DrDaveD/received_events","type":"User","site_admin":false},"created_at":"2015-01-14T21:02:13Z","updated_at":"2015-01-14T21:02:13Z","body":"I'm still uncomfortable with \"CVMFS_AUTO_GC_TIMESPAN\" having the double meaning of enabling auto GC and setting a timespan.  One issue is that when you decide to enable \"cvmfs_server gc\" as a separate public function, it would make sense for it to use the same timespan variable if set, but not if it has \"AUTO\" in the name.\r\n\r\nI think it would better to go with CVMFS_AUTO_GARBAGE_COLLECTION or CVMFS_AUTO_GC as true/false for both stratum 0 and stratum 1, stick with a timespan/timestamp variable that does not have \"AUTO\" in the name, and let it have a default value of '3 days ago' if it is not set.    Let \"cvmfs_server gc\" not require any variables, but honor the timespan/timestamp variable if it is set and otherwise use the default."}}