{"action":"created","issue":{"url":"https://api.github.com/repos/genehack/smart-tab/issues/11","labels_url":"https://api.github.com/repos/genehack/smart-tab/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/genehack/smart-tab/issues/11/comments","events_url":"https://api.github.com/repos/genehack/smart-tab/issues/11/events","html_url":"https://github.com/genehack/smart-tab/pull/11","id":76659730,"number":11,"title":"Fall back to major mode's tab if unable to expand","user":{"login":"bard","id":19322,"avatar_url":"https://avatars.githubusercontent.com/u/19322?v=3","gravatar_id":"","url":"https://api.github.com/users/bard","html_url":"https://github.com/bard","followers_url":"https://api.github.com/users/bard/followers","following_url":"https://api.github.com/users/bard/following{/other_user}","gists_url":"https://api.github.com/users/bard/gists{/gist_id}","starred_url":"https://api.github.com/users/bard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bard/subscriptions","organizations_url":"https://api.github.com/users/bard/orgs","repos_url":"https://api.github.com/users/bard/repos","events_url":"https://api.github.com/users/bard/events{/privacy}","received_events_url":"https://api.github.com/users/bard/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-05-15T09:11:56Z","updated_at":"2015-06-30T19:20:06Z","closed_at":"2015-06-27T20:07:09Z","pull_request":{"url":"https://api.github.com/repos/genehack/smart-tab/pulls/11","html_url":"https://github.com/genehack/smart-tab/pull/11","diff_url":"https://github.com/genehack/smart-tab/pull/11.diff","patch_url":"https://github.com/genehack/smart-tab/pull/11.patch"},"body":"In modes where tab is associated to something other than indenting,\r\nsmart-tab breaks the behavior, unless the user manually disables it\r\nthrough `smart-tab-disabled-major-modes`.\r\n\r\nIf no completion is available, make `smart-tab-default` fall back to tab\r\nbehavior as defined in major mode or, if none is defined,\r\n`indent-for-tab-command`.\r\n\r\nPossibly makes `smart-tab-disabled-major-modes` superfluous. Motivated\r\nby smart-tab breaking markdown-mode. Re-implements 7c80c79, though a bit\r\nmore elegantly."},"comment":{"url":"https://api.github.com/repos/genehack/smart-tab/issues/comments/117311685","html_url":"https://github.com/genehack/smart-tab/pull/11#issuecomment-117311685","issue_url":"https://api.github.com/repos/genehack/smart-tab/issues/11","id":117311685,"user":{"login":"waymondo","id":923418,"avatar_url":"https://avatars.githubusercontent.com/u/923418?v=3","gravatar_id":"","url":"https://api.github.com/users/waymondo","html_url":"https://github.com/waymondo","followers_url":"https://api.github.com/users/waymondo/followers","following_url":"https://api.github.com/users/waymondo/following{/other_user}","gists_url":"https://api.github.com/users/waymondo/gists{/gist_id}","starred_url":"https://api.github.com/users/waymondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/waymondo/subscriptions","organizations_url":"https://api.github.com/users/waymondo/orgs","repos_url":"https://api.github.com/users/waymondo/repos","events_url":"https://api.github.com/users/waymondo/events{/privacy}","received_events_url":"https://api.github.com/users/waymondo/received_events","type":"User","site_admin":false},"created_at":"2015-06-30T19:20:05Z","updated_at":"2015-06-30T19:20:05Z","body":"The merging of PR created an unideal behavior in \"indent sensitive\" modes (such as `coffee-mode` and `slim-mode`). An example in `coffee-mode`:\r\n\r\n``` coffeescript\r\nsomeFunction = ->\r\n  foobar = 'baz'\r\n  makeThing(foob|)\r\n```\r\n\r\nWith the cursor at `|`, this will correctly complete to `foobar`, but it will also over-eagerly indent the code with the same tab trigger:\r\n\r\n``` coffeescript\r\nsomeFunction = ->\r\n  foobar = 'baz'\r\n    makeThing(foobar)\r\n```\r\n\r\nI haven't dug hard into the source yet, just wanted to let you both know in case you had any ideas or preferences on implementation."}}