{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar/pulls/comments/36076733","id":36076733,"diff_hunk":"@@ -556,72 +544,46 @@ test ! -e $cloud_dir -a -d $smt_dir && ln -s $smt_dir $cloud_dir\n \n # FIXME: repos that we cannot check yet:\n #   Cloud 6 Pool / Updates: non-existing repos\n-REPOS_SKIP_CHECKS+=\" SUSE-OpenStack-Cloud-SLE11-6-Pool SUSE-OpenStack-Cloud-SLE11-6-Updates SUSE-OpenStack-Cloud-6-Pool SUSE-OpenStack-Cloud-6-Updates\"\n-\n-# Checks for SLE11 medias\n-MEDIA=/srv/tftpboot/suse-11.3/install\n-\n-if [ -f $MEDIA/content ] && egrep -q \"REPOID.*/suse-cloud-deps/\" $MEDIA/content; then\n-    echo \"Detected SUSE OpenStack Cloud Deps media.\"\n-    REPOS_SKIP_CHECKS+=\" SLES11-SP3-Pool SLES11-SP3-Updates\"\n-else\n-    check_media_content \\\n-        SLES11_SP3 \\\n-        $MEDIA \\\n-        d0bb700ab51c180200995dfdf5a6ade8\n-fi\n-\n-check_media_links $MEDIA\n+REPOS_SKIP_CHECKS+=\" SUSE-OpenStack-Cloud-6-Pool SUSE-OpenStack-Cloud-6-Updates\"\n \n REQUIRE_STORAGE='false'\n-REQUIRE_SLES11='true'\n REQUIRE_CLOUD='true'\n if is_ses; then\n   REQUIRE_STORAGE='true'\n-  REQUIRE_SLES11='false'\n   REQUIRE_CLOUD='false'\n fi\n \n-if ! is_ses; then\n-  check_media_content \\\n-      Cloud \\\n-      /srv/tftpboot/suse-11.3/repos/Cloud \\\n-      #1558be86e7354d31e71e7c8c2574031a\n-fi\n-\n-check_repo_tag repo    11.3 SLES11-SP3-Pool        'updates://zypp-patches.suse.de/autobuild/SLE_SERVER/11-SP3/pool/x86_64' $REQUIRE_SLES11\n-check_repo_tag repo    11.3 SLES11-SP3-Updates     'obsrepository://build.suse.de/SUSE:Updates:SLE-SERVER:11-SP3:x86_64/update' $REQUIRE_SLES11\n-check_repo_tag summary 11.3 SUSE-OpenStack-Cloud-SLE11-6-Pool      'SUSE OpenStack Cloud 6 for SLE11 SP3' $REQUIRE_CLOUD\n-#check_repo_tag repo    11.3 SUSE-OpenStack-Cloud-SLE11-6-Updates   'updates://zypp-patches.suse.de/autobuild/SUSE_CLOUD/6/update/x86_64' $REQUIRE_CLOUD\n-check_repo_tag key     11.3 SUSE-OpenStack-Cloud-SLE11-6-Updates '' $REQUIRE_CLOUD\n-check_repo_tag summary 11.3 SLE11-HAE-SP3-Pool     'SUSE Linux Enterprise High Availability Extension 11 SP3' 'false'\n-check_repo_tag repo    11.3 SLE11-HAE-SP3-Updates  'obsrepository://build.suse.de/SUSE:Updates:SLE-HAE:11-SP3:x86_64/update' 'false'\n-\n-# Checks for SLE12 media (currently optional)\n+# Checks for SLE12 medias\n MEDIA=/srv/tftpboot/suse-12.0/install\n-if [ -e $MEDIA/install/boot/x86_64/common ]; then\n+\n+if [ -f $MEDIA/content ] && egrep -q \"REPOID.*/suse-cloud-deps/\" $MEDIA/content; then\n+    echo \"Detected SUSE OpenStack Cloud Deps media.\"\n+    REPOS_SKIP_CHECKS+=\" SLES12-Pool SLES12-Updates\"\n+else\n   check_media_content \\\n       SLES12 \\\n       $MEDIA \\\n       b52c0f2b41a6a10d49cc89edcdc1b13d\n+fi\n \n-  check_media_links $MEDIA\n+check_media_links $MEDIA\n \n+if ! is_ses; then\n   check_media_content \\\n       Cloud \\\n       /srv/tftpboot/suse-12.0/repos/Cloud \\\n       #1f2cdc1f7593a4091623d7792fb61237\n-\n-  check_repo_tag repo    12.0 SLES12-Pool                         'obsproduct://build.suse.de/SUSE:SLE-12:GA/SLES/12/POOL/x86_64'\n-  check_repo_tag repo    12.0 SLES12-Updates                      'obsrepository://build.suse.de/SUSE:Updates:SLE-SERVER:12:x86_64/update'\n-  check_repo_tag repo    12.0 SUSE-OpenStack-Cloud-6-Pool         'obsproduct://build.suse.de/SUSE:SLE-12:Update:Products:Cloud6/suse-openstack-cloud/6/POOL/x86_64' $REQUIRE_CLOUD\n-  check_repo_tag summary 12.0 SUSE-OpenStack-Cloud-6-Updates      'SUSE OpenStack Cloud 6' $REQUIRE_CLOUD\n-  check_repo_tag repo    12.0 SLE12-HA-Pool                       'obsproduct://build.suse.de/SUSE:SLE-12:GA/sle-ha/12/POOL/x86_64' 'false'\n-  check_repo_tag repo    12.0 SLE12-HA-Updates                    'obsrepository://build.suse.de/SUSE:Updates:SLE-HA:12:x86_64/update' 'false'\n-  check_repo_tag repo    12.0 SUSE-Enterprise-Storage-1.0-Pool    'obsproduct://build.suse.de/SUSE:SLE-12:Update:Products:Cloud5/ses/1/POOL/x86_64' $REQUIRE_STORAGE\n-  check_repo_tag summary 12.0 SUSE-Enterprise-Storage-1.0-Updates 'SUSE Enterprise Storage 1.0' $REQUIRE_STORAGE\n fi\n \n+check_repo_tag repo    12.0 SLES12-Pool                         'obsproduct://build.suse.de/SUSE:SLE-12:GA/SLES/12/POOL/x86_64'\n+check_repo_tag repo    12.0 SLES12-Updates                      'obsrepository://build.suse.de/SUSE:Updates:SLE-SERVER:12:x86_64/update'\n+check_repo_tag repo    12.0 SUSE-OpenStack-Cloud-6-Pool         'obsproduct://build.suse.de/SUSE:SLE-12:Update:Products:Cloud6/suse-openstack-cloud/6/POOL/x86_64' $REQUIRE_CLOUD\n+check_repo_tag summary 12.0 SUSE-OpenStack-Cloud-6-Updates      'SUSE OpenStack Cloud 6' '' $REQUIRE_CLOUD","path":"scripts/install-chef-suse.sh","position":102,"original_position":102,"commit_id":"b5d107a55b92c6d64d3f1d7d9fad43cec5dcb3ed","original_commit_id":"b5d107a55b92c6d64d3f1d7d9fad43cec5dcb3ed","user":{"login":"MaximilianMeister","id":5364817,"avatar_url":"https://avatars.githubusercontent.com/u/5364817?v=3","gravatar_id":"","url":"https://api.github.com/users/MaximilianMeister","html_url":"https://github.com/MaximilianMeister","followers_url":"https://api.github.com/users/MaximilianMeister/followers","following_url":"https://api.github.com/users/MaximilianMeister/following{/other_user}","gists_url":"https://api.github.com/users/MaximilianMeister/gists{/gist_id}","starred_url":"https://api.github.com/users/MaximilianMeister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaximilianMeister/subscriptions","organizations_url":"https://api.github.com/users/MaximilianMeister/orgs","repos_url":"https://api.github.com/users/MaximilianMeister/repos","events_url":"https://api.github.com/users/MaximilianMeister/events{/privacy}","received_events_url":"https://api.github.com/users/MaximilianMeister/received_events","type":"User","site_admin":false},"body":"is the empty `''` that you added intentional? don't see any change to the interface of `check_repo_tag` ","created_at":"2015-08-03T11:34:42Z","updated_at":"2015-08-03T11:34:42Z","html_url":"https://github.com/crowbar/crowbar/pull/2125#discussion_r36076733","pull_request_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2125","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/comments/36076733"},"html":{"href":"https://github.com/crowbar/crowbar/pull/2125#discussion_r36076733"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2125"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar/pulls/2125","id":41451034,"html_url":"https://github.com/crowbar/crowbar/pull/2125","diff_url":"https://github.com/crowbar/crowbar/pull/2125.diff","patch_url":"https://github.com/crowbar/crowbar/pull/2125.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar/issues/2125","number":2125,"state":"open","locked":false,"title":"[WIP] SLE12 bits for install-suse-cloud","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-03T09:53:32Z","updated_at":"2015-08-03T11:34:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b6ecbf1cf73744196f1d4eea951444bf74c0cb9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2125/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar/pulls/2125/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar/issues/2125/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar/statuses/b5d107a55b92c6d64d3f1d7d9fad43cec5dcb3ed","head":{"label":"vuntz:sle12","ref":"sle12","sha":"b5d107a55b92c6d64d3f1d7d9fad43cec5dcb3ed","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"repo":{"id":10238607,"name":"crowbar","full_name":"vuntz/crowbar","owner":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vuntz/crowbar","description":"Cloud Installer (originated by Dell)","fork":true,"url":"https://api.github.com/repos/vuntz/crowbar","forks_url":"https://api.github.com/repos/vuntz/crowbar/forks","keys_url":"https://api.github.com/repos/vuntz/crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuntz/crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuntz/crowbar/teams","hooks_url":"https://api.github.com/repos/vuntz/crowbar/hooks","issue_events_url":"https://api.github.com/repos/vuntz/crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/vuntz/crowbar/events","assignees_url":"https://api.github.com/repos/vuntz/crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/vuntz/crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/vuntz/crowbar/tags","blobs_url":"https://api.github.com/repos/vuntz/crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuntz/crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuntz/crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuntz/crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuntz/crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/vuntz/crowbar/languages","stargazers_url":"https://api.github.com/repos/vuntz/crowbar/stargazers","contributors_url":"https://api.github.com/repos/vuntz/crowbar/contributors","subscribers_url":"https://api.github.com/repos/vuntz/crowbar/subscribers","subscription_url":"https://api.github.com/repos/vuntz/crowbar/subscription","commits_url":"https://api.github.com/repos/vuntz/crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuntz/crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuntz/crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuntz/crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuntz/crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/vuntz/crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuntz/crowbar/merges","archive_url":"https://api.github.com/repos/vuntz/crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuntz/crowbar/downloads","issues_url":"https://api.github.com/repos/vuntz/crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/vuntz/crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/vuntz/crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/vuntz/crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuntz/crowbar/labels{/name}","releases_url":"https://api.github.com/repos/vuntz/crowbar/releases{/id}","created_at":"2013-05-23T07:47:58Z","updated_at":"2014-02-26T11:44:17Z","pushed_at":"2015-08-03T10:03:02Z","git_url":"git://github.com/vuntz/crowbar.git","ssh_url":"git@github.com:vuntz/crowbar.git","clone_url":"https://github.com/vuntz/crowbar.git","svn_url":"https://github.com/vuntz/crowbar","homepage":"https://github.com/crowbar/crowbar/wiki","size":39753,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"5d8565dac116a7848d322924cde086066fdf5a9b","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":2040151,"name":"crowbar","full_name":"crowbar/crowbar","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar","description":"Cloud Operations Platform","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar","forks_url":"https://api.github.com/repos/crowbar/crowbar/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar/releases{/id}","created_at":"2011-07-13T05:02:51Z","updated_at":"2015-07-29T19:28:48Z","pushed_at":"2015-08-03T10:03:03Z","git_url":"git://github.com/crowbar/crowbar.git","ssh_url":"git@github.com:crowbar/crowbar.git","clone_url":"https://github.com/crowbar/crowbar.git","svn_url":"https://github.com/crowbar/crowbar","homepage":"https://github.com/crowbar/crowbar","size":52940,"stargazers_count":693,"watchers_count":693,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":280,"mirror_url":null,"open_issues_count":48,"forks":280,"open_issues":48,"watchers":693,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2125"},"html":{"href":"https://github.com/crowbar/crowbar/pull/2125"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar/issues/2125"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar/issues/2125/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2125/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar/pulls/2125/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar/statuses/b5d107a55b92c6d64d3f1d7d9fad43cec5dcb3ed"}}}}