{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/46041886","id":46041886,"diff_hunk":"@@ -1083,7 +1081,7 @@ class CronTableItem\n     CronTableItem(CronTableItem * _prev, CronTableItem * _next, char const * spec, char const * _tag, bool inframe) : prev(_prev), next(_next), tag(_tag), markDelete(false), markNew(inframe)\n     {\n         char const * specend = cron.set(spec);\n-        if((specend-spec) != strlen(spec))\n+        if (*specend)","path":"system/jlib/jtime.cpp","position":14,"original_position":14,"commit_id":"1fd3ecf6af9278d8c270914d43aaeb35a2e0202a","original_commit_id":"1fd3ecf6af9278d8c270914d43aaeb35a2e0202a","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"I think this is equivalent!","created_at":"2015-11-27T12:15:05Z","updated_at":"2015-11-27T12:15:05Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7986#discussion_r46041886","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/46041886"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7986#discussion_r46041886"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986","id":51988560,"html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7986","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7986.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/7986.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7986","number":7986,"state":"open","locked":false,"title":"Jlib wall error","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-27T12:08:35Z","updated_at":"2015-11-27T12:15:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d88f959025c3aa2b9d8dc62a67ad4314897521f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7986/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/1fd3ecf6af9278d8c270914d43aaeb35a2e0202a","head":{"label":"richardkchapman:jlib-wall-error","ref":"jlib-wall-error","sha":"1fd3ecf6af9278d8c270914d43aaeb35a2e0202a","user":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"repo":{"id":2031005,"name":"HPCC-Platform","full_name":"richardkchapman/HPCC-Platform","owner":{"login":"richardkchapman","id":900820,"avatar_url":"https://avatars.githubusercontent.com/u/900820?v=3","gravatar_id":"","url":"https://api.github.com/users/richardkchapman","html_url":"https://github.com/richardkchapman","followers_url":"https://api.github.com/users/richardkchapman/followers","following_url":"https://api.github.com/users/richardkchapman/following{/other_user}","gists_url":"https://api.github.com/users/richardkchapman/gists{/gist_id}","starred_url":"https://api.github.com/users/richardkchapman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardkchapman/subscriptions","organizations_url":"https://api.github.com/users/richardkchapman/orgs","repos_url":"https://api.github.com/users/richardkchapman/repos","events_url":"https://api.github.com/users/richardkchapman/events{/privacy}","received_events_url":"https://api.github.com/users/richardkchapman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardkchapman/HPCC-Platform","description":"HPCC Systems big data solution, community edition","fork":true,"url":"https://api.github.com/repos/richardkchapman/HPCC-Platform","forks_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/richardkchapman/HPCC-Platform/releases{/id}","created_at":"2011-07-11T15:22:03Z","updated_at":"2015-02-12T17:31:52Z","pushed_at":"2015-11-27T12:07:56Z","git_url":"git://github.com/richardkchapman/HPCC-Platform.git","ssh_url":"git@github.com:richardkchapman/HPCC-Platform.git","clone_url":"https://github.com/richardkchapman/HPCC-Platform.git","svn_url":"https://github.com/richardkchapman/HPCC-Platform","homepage":"www.hpccsystems.com","size":159300,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"hpcc-systems:candidate-6.0.0","ref":"candidate-6.0.0","sha":"fb431e2eb0fc8219648c1e509deb76067b63005a","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","created_at":"2011-07-11T14:29:51Z","updated_at":"2015-11-24T08:28:23Z","pushed_at":"2015-11-27T12:08:35Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"track.hpccsystems.com","size":171056,"stargazers_count":261,"watchers_count":261,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"open_issues_count":441,"forks":128,"open_issues":441,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/7986"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7986"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/7986/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/7986/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/1fd3ecf6af9278d8c270914d43aaeb35a2e0202a"}}}}