{"action":"closed","number":637,"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora/pulls/637","id":50690761,"html_url":"https://github.com/Islandora/islandora/pull/637","diff_url":"https://github.com/Islandora/islandora/pull/637.diff","patch_url":"https://github.com/Islandora/islandora/pull/637.patch","issue_url":"https://api.github.com/repos/Islandora/islandora/issues/637","number":637,"state":"closed","locked":false,"title":"ISLANDORA-1547","user":{"login":"matthewperry","id":8352593,"avatar_url":"https://avatars.githubusercontent.com/u/8352593?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewperry","html_url":"https://github.com/matthewperry","followers_url":"https://api.github.com/users/matthewperry/followers","following_url":"https://api.github.com/users/matthewperry/following{/other_user}","gists_url":"https://api.github.com/users/matthewperry/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewperry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewperry/subscriptions","organizations_url":"https://api.github.com/users/matthewperry/orgs","repos_url":"https://api.github.com/users/matthewperry/repos","events_url":"https://api.github.com/users/matthewperry/events{/privacy}","received_events_url":"https://api.github.com/users/matthewperry/received_events","type":"User","site_admin":false},"body":"**Jira:** https://jira.duraspace.org/browse/ISLANDORA-1547\r\n\r\n# What does this Pull Request do?\r\nAdds a drupal_alter to allow for modification to the datastream edit registry.\r\n\r\n# How should this be tested?\r\nPull down the pull both the islandora (core) pull request and the islandora_xml_forms pull request.\r\n\r\nTest 1: Confirming the addition of an custom index value does not impact form loading.\r\nEdit an existing object's datastream the process should function the same as before the pull and load\r\nthe registry item built in xml_form_builder_islandora_edit_datastream_registry. \r\n\r\nTest 2: Testing the drupal_alter.\r\nHave a module implement hook_islandora_edit_datastream_modify_registry_alter() and test making changes to the edit_registry.\r\n\r\n  1) Adding an edition registry item - this should load the default switch logic so that multiple routes are rendered.\r\n\r\n  2) Removing unset the $edit_registry - this should trigger switch case 0 and return the user to the manage datastream page with a drupal message \"There are no edit methods specified for this datastream.\"\r\n\r\n  3) Assuming the registry has just the values for xml_form_builder_edit_form_registry. Edit the url path for $edit_registry['xml_form_builder_edit_form_registry']['url'] and point it to another page.  This page should load when you click edit on a datastream.\r\n\r\n  4) Try the above 1-3 type changes but limit using the object's content model or the datastream being modified.\r\n\r\n\r\n\r\n# Background context:\r\nA way of loading a custom edit form when modifying a datastream without having to use a goto in a form_alter. While keeping the user from having to select the registry route manually.  By making modifications to the edit registry it helps avoid any potential confusion from building one form and redirecting to another.\r\n\r\n\r\n**Tagging:** @Islandora/7-x-1-x-committers, @ruebot, @DiegoPino \r\n\r\n\r\n----\r\nMatthew Perry\r\n_Developer_\r\n**[discoverygarden inc.](http://www.discoverygarden.ca) | Managing Digital Content**","created_at":"2015-11-13T20:55:44Z","updated_at":"2015-11-24T14:42:23Z","closed_at":"2015-11-24T14:42:23Z","merged_at":"2015-11-24T14:42:23Z","merge_commit_sha":"17f02a886f0003d98212a7bbed33073f6e069edf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Islandora/islandora/pulls/637/commits","review_comments_url":"https://api.github.com/repos/Islandora/islandora/pulls/637/comments","review_comment_url":"https://api.github.com/repos/Islandora/islandora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Islandora/islandora/issues/637/comments","statuses_url":"https://api.github.com/repos/Islandora/islandora/statuses/c70255d8ef663ad57e1ffa7579468ac80f583da1","head":{"label":"matthewperry:7.x-ISLANDORA-1547","ref":"7.x-ISLANDORA-1547","sha":"c70255d8ef663ad57e1ffa7579468ac80f583da1","user":{"login":"matthewperry","id":8352593,"avatar_url":"https://avatars.githubusercontent.com/u/8352593?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewperry","html_url":"https://github.com/matthewperry","followers_url":"https://api.github.com/users/matthewperry/followers","following_url":"https://api.github.com/users/matthewperry/following{/other_user}","gists_url":"https://api.github.com/users/matthewperry/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewperry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewperry/subscriptions","organizations_url":"https://api.github.com/users/matthewperry/orgs","repos_url":"https://api.github.com/users/matthewperry/repos","events_url":"https://api.github.com/users/matthewperry/events{/privacy}","received_events_url":"https://api.github.com/users/matthewperry/received_events","type":"User","site_admin":false},"repo":{"id":46138823,"name":"islandora","full_name":"matthewperry/islandora","owner":{"login":"matthewperry","id":8352593,"avatar_url":"https://avatars.githubusercontent.com/u/8352593?v=3","gravatar_id":"","url":"https://api.github.com/users/matthewperry","html_url":"https://github.com/matthewperry","followers_url":"https://api.github.com/users/matthewperry/followers","following_url":"https://api.github.com/users/matthewperry/following{/other_user}","gists_url":"https://api.github.com/users/matthewperry/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewperry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewperry/subscriptions","organizations_url":"https://api.github.com/users/matthewperry/orgs","repos_url":"https://api.github.com/users/matthewperry/repos","events_url":"https://api.github.com/users/matthewperry/events{/privacy}","received_events_url":"https://api.github.com/users/matthewperry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthewperry/islandora","description":"A Drupal module for browsing and managing Fedora-based digital repositories","fork":true,"url":"https://api.github.com/repos/matthewperry/islandora","forks_url":"https://api.github.com/repos/matthewperry/islandora/forks","keys_url":"https://api.github.com/repos/matthewperry/islandora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewperry/islandora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewperry/islandora/teams","hooks_url":"https://api.github.com/repos/matthewperry/islandora/hooks","issue_events_url":"https://api.github.com/repos/matthewperry/islandora/issues/events{/number}","events_url":"https://api.github.com/repos/matthewperry/islandora/events","assignees_url":"https://api.github.com/repos/matthewperry/islandora/assignees{/user}","branches_url":"https://api.github.com/repos/matthewperry/islandora/branches{/branch}","tags_url":"https://api.github.com/repos/matthewperry/islandora/tags","blobs_url":"https://api.github.com/repos/matthewperry/islandora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewperry/islandora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewperry/islandora/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewperry/islandora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewperry/islandora/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewperry/islandora/languages","stargazers_url":"https://api.github.com/repos/matthewperry/islandora/stargazers","contributors_url":"https://api.github.com/repos/matthewperry/islandora/contributors","subscribers_url":"https://api.github.com/repos/matthewperry/islandora/subscribers","subscription_url":"https://api.github.com/repos/matthewperry/islandora/subscription","commits_url":"https://api.github.com/repos/matthewperry/islandora/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewperry/islandora/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewperry/islandora/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewperry/islandora/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewperry/islandora/contents/{+path}","compare_url":"https://api.github.com/repos/matthewperry/islandora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewperry/islandora/merges","archive_url":"https://api.github.com/repos/matthewperry/islandora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewperry/islandora/downloads","issues_url":"https://api.github.com/repos/matthewperry/islandora/issues{/number}","pulls_url":"https://api.github.com/repos/matthewperry/islandora/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewperry/islandora/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewperry/islandora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewperry/islandora/labels{/name}","releases_url":"https://api.github.com/repos/matthewperry/islandora/releases{/id}","created_at":"2015-11-13T18:08:38Z","updated_at":"2015-11-13T18:08:41Z","pushed_at":"2015-11-16T17:14:59Z","git_url":"git://github.com/matthewperry/islandora.git","ssh_url":"git@github.com:matthewperry/islandora.git","clone_url":"https://github.com/matthewperry/islandora.git","svn_url":"https://github.com/matthewperry/islandora","homepage":"http://islandora.ca/","size":22653,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x"}},"base":{"label":"Islandora:7.x","ref":"7.x","sha":"ced77301a585d63ec843e7e49055cbdb8b27b466","user":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"repo":{"id":1107291,"name":"islandora","full_name":"Islandora/islandora","owner":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islandora/islandora","description":"A Drupal module for browsing and managing Fedora-based digital repositories","fork":true,"url":"https://api.github.com/repos/Islandora/islandora","forks_url":"https://api.github.com/repos/Islandora/islandora/forks","keys_url":"https://api.github.com/repos/Islandora/islandora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islandora/islandora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islandora/islandora/teams","hooks_url":"https://api.github.com/repos/Islandora/islandora/hooks","issue_events_url":"https://api.github.com/repos/Islandora/islandora/issues/events{/number}","events_url":"https://api.github.com/repos/Islandora/islandora/events","assignees_url":"https://api.github.com/repos/Islandora/islandora/assignees{/user}","branches_url":"https://api.github.com/repos/Islandora/islandora/branches{/branch}","tags_url":"https://api.github.com/repos/Islandora/islandora/tags","blobs_url":"https://api.github.com/repos/Islandora/islandora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islandora/islandora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islandora/islandora/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islandora/islandora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islandora/islandora/statuses/{sha}","languages_url":"https://api.github.com/repos/Islandora/islandora/languages","stargazers_url":"https://api.github.com/repos/Islandora/islandora/stargazers","contributors_url":"https://api.github.com/repos/Islandora/islandora/contributors","subscribers_url":"https://api.github.com/repos/Islandora/islandora/subscribers","subscription_url":"https://api.github.com/repos/Islandora/islandora/subscription","commits_url":"https://api.github.com/repos/Islandora/islandora/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islandora/islandora/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islandora/islandora/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islandora/islandora/issues/comments{/number}","contents_url":"https://api.github.com/repos/Islandora/islandora/contents/{+path}","compare_url":"https://api.github.com/repos/Islandora/islandora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islandora/islandora/merges","archive_url":"https://api.github.com/repos/Islandora/islandora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islandora/islandora/downloads","issues_url":"https://api.github.com/repos/Islandora/islandora/issues{/number}","pulls_url":"https://api.github.com/repos/Islandora/islandora/pulls{/number}","milestones_url":"https://api.github.com/repos/Islandora/islandora/milestones{/number}","notifications_url":"https://api.github.com/repos/Islandora/islandora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islandora/islandora/labels{/name}","releases_url":"https://api.github.com/repos/Islandora/islandora/releases{/id}","created_at":"2010-11-23T21:56:01Z","updated_at":"2015-11-12T19:49:13Z","pushed_at":"2015-11-24T14:42:23Z","git_url":"git://github.com/Islandora/islandora.git","ssh_url":"git@github.com:Islandora/islandora.git","clone_url":"https://github.com/Islandora/islandora.git","svn_url":"https://github.com/Islandora/islandora","homepage":"http://islandora.ca/","size":17838,"stargazers_count":78,"watchers_count":78,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"open_issues_count":1,"forks":70,"open_issues":1,"watchers":78,"default_branch":"7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/637"},"html":{"href":"https://github.com/Islandora/islandora/pull/637"},"issue":{"href":"https://api.github.com/repos/Islandora/islandora/issues/637"},"comments":{"href":"https://api.github.com/repos/Islandora/islandora/issues/637/comments"},"review_comments":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/637/comments"},"review_comment":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Islandora/islandora/pulls/637/commits"},"statuses":{"href":"https://api.github.com/repos/Islandora/islandora/statuses/c70255d8ef663ad57e1ffa7579468ac80f583da1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ruebot","id":218561,"avatar_url":"https://avatars.githubusercontent.com/u/218561?v=3","gravatar_id":"","url":"https://api.github.com/users/ruebot","html_url":"https://github.com/ruebot","followers_url":"https://api.github.com/users/ruebot/followers","following_url":"https://api.github.com/users/ruebot/following{/other_user}","gists_url":"https://api.github.com/users/ruebot/gists{/gist_id}","starred_url":"https://api.github.com/users/ruebot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruebot/subscriptions","organizations_url":"https://api.github.com/users/ruebot/orgs","repos_url":"https://api.github.com/users/ruebot/repos","events_url":"https://api.github.com/users/ruebot/events{/privacy}","received_events_url":"https://api.github.com/users/ruebot/received_events","type":"User","site_admin":false},"comments":17,"review_comments":3,"commits":5,"additions":52,"deletions":3,"changed_files":5}}