{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/26472043","id":26472043,"diff_hunk":"@@ -141,9 +141,9 @@ class TestDashboard(MachineCase):\n         b.leave_page()\n         b.wait_js_cond('$(\"#machine-dropdown ul li\").length == 2')\n         b.click('#machine-dropdown ul li:nth-child(1) a')\n-        b.wait_js_cond('cockpit.location.href == \"/@localhost\"')\n+        b.wait_js_cond('window.location.hash == \"#/@localhost\"')","path":"test/check-dashboard","position":5,"original_position":5,"commit_id":"23672b6299a1b96fa60a8539acbeecc15975663d","original_commit_id":"23672b6299a1b96fa60a8539acbeecc15975663d","user":{"login":"mvollmer","id":3228183,"avatar_url":"https://avatars.githubusercontent.com/u/3228183?v=3","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"body":"Right, makes sense.","created_at":"2015-03-16T10:08:30Z","updated_at":"2015-03-16T10:08:30Z","html_url":"https://github.com/cockpit-project/cockpit/pull/1892#discussion_r26472043","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/26472043"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/1892#discussion_r26472043"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892","id":30539716,"html_url":"https://github.com/cockpit-project/cockpit/pull/1892","diff_url":"https://github.com/cockpit-project/cockpit/pull/1892.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/1892.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/1892","number":1892,"state":"open","locked":false,"title":"base: Use requirejs as our AMD loader","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"This uses requirejs as our AMD loader, and drops our custom implementation. Most instances of cockpit.js becomes AMD loaded rather than loaded in a script tag.","created_at":"2015-03-05T08:58:56Z","updated_at":"2015-03-16T10:08:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b48f1ea1fd647ec4f18bf069686aeb28f89ec09","assignee":{"login":"mvollmer","id":3228183,"avatar_url":"https://avatars.githubusercontent.com/u/3228183?v=3","gravatar_id":"","url":"https://api.github.com/users/mvollmer","html_url":"https://github.com/mvollmer","followers_url":"https://api.github.com/users/mvollmer/followers","following_url":"https://api.github.com/users/mvollmer/following{/other_user}","gists_url":"https://api.github.com/users/mvollmer/gists{/gist_id}","starred_url":"https://api.github.com/users/mvollmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvollmer/subscriptions","organizations_url":"https://api.github.com/users/mvollmer/orgs","repos_url":"https://api.github.com/users/mvollmer/repos","events_url":"https://api.github.com/users/mvollmer/events{/privacy}","received_events_url":"https://api.github.com/users/mvollmer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cockpit-project/cockpit/milestones/19","html_url":"https://github.com/cockpit-project/cockpit/milestones/Protocol%20Compatibility","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones/19/labels","id":1021527,"number":19,"title":"Protocol Compatibility","description":"Basic protocol compatibility.\r\n\r\nGoal: Be able to talk to a Fedora 22 cockpit-bridge from a later cockpit-ws and vs. versa.","creator":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":0,"state":"open","created_at":"2015-03-14T15:47:43Z","updated_at":"2015-03-16T07:26:22Z","due_on":"2015-03-30T22:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/1892/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/23672b6299a1b96fa60a8539acbeecc15975663d","head":{"label":"stefwalter:requirejs","ref":"requirejs","sha":"23672b6299a1b96fa60a8539acbeecc15975663d","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"repo":{"id":14296513,"name":"cockpit","full_name":"stefwalter/cockpit","owner":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars.githubusercontent.com/u/795070?v=3","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stefwalter/cockpit","description":"Cockpit, a user interface for Linux servers","fork":true,"url":"https://api.github.com/repos/stefwalter/cockpit","forks_url":"https://api.github.com/repos/stefwalter/cockpit/forks","keys_url":"https://api.github.com/repos/stefwalter/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stefwalter/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stefwalter/cockpit/teams","hooks_url":"https://api.github.com/repos/stefwalter/cockpit/hooks","issue_events_url":"https://api.github.com/repos/stefwalter/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/stefwalter/cockpit/events","assignees_url":"https://api.github.com/repos/stefwalter/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/stefwalter/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/stefwalter/cockpit/tags","blobs_url":"https://api.github.com/repos/stefwalter/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stefwalter/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stefwalter/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/stefwalter/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stefwalter/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/stefwalter/cockpit/languages","stargazers_url":"https://api.github.com/repos/stefwalter/cockpit/stargazers","contributors_url":"https://api.github.com/repos/stefwalter/cockpit/contributors","subscribers_url":"https://api.github.com/repos/stefwalter/cockpit/subscribers","subscription_url":"https://api.github.com/repos/stefwalter/cockpit/subscription","commits_url":"https://api.github.com/repos/stefwalter/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/stefwalter/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/stefwalter/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/stefwalter/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/stefwalter/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/stefwalter/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stefwalter/cockpit/merges","archive_url":"https://api.github.com/repos/stefwalter/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stefwalter/cockpit/downloads","issues_url":"https://api.github.com/repos/stefwalter/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/stefwalter/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/stefwalter/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/stefwalter/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stefwalter/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/stefwalter/cockpit/releases{/id}","created_at":"2013-11-11T09:27:50Z","updated_at":"2015-01-30T14:52:29Z","pushed_at":"2015-03-16T09:50:09Z","git_url":"git://github.com/stefwalter/cockpit.git","ssh_url":"git@github.com:stefwalter/cockpit.git","clone_url":"https://github.com/stefwalter/cockpit.git","svn_url":"https://github.com/stefwalter/cockpit","homepage":"http://www.cockpit-project.org/","size":21380,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"63550767ef1494000632af8bd3fdbc787bb9b42e","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars.githubusercontent.com/u/5765104?v=3","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"Cockpit, a user interface for GNU/Linux servers","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","created_at":"2013-11-01T17:36:46Z","updated_at":"2015-03-16T08:45:41Z","pushed_at":"2015-03-16T08:45:40Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":28277,"stargazers_count":920,"watchers_count":920,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"open_issues_count":303,"forks":93,"open_issues":303,"watchers":920,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/1892"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/1892"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/1892/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/1892/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/23672b6299a1b96fa60a8539acbeecc15975663d"}}}}