{"push_id":869755001,"size":88,"distinct_size":3,"ref":"refs/heads/travis_scripts","head":"26e9bfeebea6836fecae9b639bda70ad5574802d","before":"3017e3fe666eee994148928dccbe66572285ec52","commits":[{"sha":"cacdea7988dc85bd441e5a8637960135f7f7c01b","author":{"email":"ec4b33ce7e6f20774aea1f12f0f537a441f5680b@redhat.com","name":"Brandon Dunne"},"message":"Simple corrections of numvcpus => cpu_total_cores","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/cacdea7988dc85bd441e5a8637960135f7f7c01b"},{"sha":"187b94b1fc49ff0562421044d41fbe5efc5b54e9","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Preload virtual columns on initial table, not included tables\n\nFixes an issue seen in #5205 where:\n1) a vm compare report had cpu_total_cores included via the hardware association:\n2) cpu_total_cores is a virtual column on VmOrTemplate and a column on Hardware\n\n```\ndb: VmOrTemplate\n...\n\ninclude:\n...\n  hardware:\n    group: Properties\n    columns:\n    - cpu_total_cores\n    - memory_mb\n...\n\ncol_order:\n- name\n...\n- hardware.cpu_total_cores\n```\n\nThe problem occurs when the report's base model (db: VmOrTemplate for example)\nhas a virtual column with the same name as one in one of the included tables (hardware => cpu_total_cores).\n\nWe're checking if the include => columns is a virtual_column? on each recursive call to\nto_model_hash_build_preload.  This only makes sense to do on the initial call,\nwhich is for VmOrTemplate, and not subsequent includes, such as for hardware.\n\nThis could also be fixed by changing the report to use the virtual column on VmOrTemplate:\n\n```\ndb: VmOrTemplate\n...\n\ncols:\n- cpu_total_cores\n...\n\ninclude:\n...\n  hardware:\n    group: Properties\n    columns:\n    - memory_mb\n...\n\ncol_order:\n- name\n...\n- cpu_total_cores\n```\n\nChanging a report to make this work seems like a bug, as we'd be breaking\nexisting reports whenever we accidentally add a virtual_column that matches\nan existing report's included table's column.","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/187b94b1fc49ff0562421044d41fbe5efc5b54e9"},{"sha":"428e1c428a0b805674cae68c3c32170131c57d18","author":{"email":"aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d@timjwade.com","name":"Tim Wade"},"message":"[api] Allow providers#create to accept auth_key for openshift\n\nIn the UI, adding an openshift provider allows for a token to be added.\nThe API prevents the token from being added because it only accepts\nuserid/password in the credentials. This change allows for the\n`auth_key` to be specified for openshift providers, bringing it into\nparity with the UI.\n\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1278041","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/428e1c428a0b805674cae68c3c32170131c57d18"},{"sha":"26a02e11343723e52d3b26d9b1f5a96f0b11a649","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Add support for specifying virtual columns in included assocations.\n\nPreviously, to_model_hash_build_preload would only do the \"right thing\"\nfor virtual columns, cols, on the main table (db).","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/26a02e11343723e52d3b26d9b1f5a96f0b11a649"},{"sha":"896fce34ca523b1b5c7272213d87ab91082e54b4","author":{"email":"ec4b33ce7e6f20774aea1f12f0f537a441f5680b@redhat.com","name":"Brandon Dunne"},"message":"Use anonymous classes to prevent test problems\n\nConstants weren't completely removed causing reflections to contain\nreferences to old objects that weren't completely removed.","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/896fce34ca523b1b5c7272213d87ab91082e54b4"},{"sha":"aa1d963b57fb22d91e5271c18062821c4105babf","author":{"email":"aaf4c61ddcc5e8a2dabede0f3b482cd9aea9434d@timjwade.com","name":"Tim Wade"},"message":"Fix report result serialization and deserialization\n\nIt looks like a bug was introduced in fa9984f845b0 where\n`MiqReportResult.report_results=` was only expecting a `MiqReport`\nobject, whereas `#_async_generate_result` will send it a CSV, plain\ntext, or PDF. It calls `#to_hash` on the object which results in a `NoMethodError`.\n\nAs a quick fix, this commit switches on type on both the setter and\ngetter so that the object passed in can be serialized and deserialized correctly.\n\nFixes https://bugzilla.redhat.com/show_bug.cgi?id=1273275","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/aa1d963b57fb22d91e5271c18062821c4105babf"},{"sha":"f2989d251919c58057aa615e45509a4dbbb8ac4c","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Test virtual and regular column includes from different associations","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/f2989d251919c58057aa615e45509a4dbbb8ac4c"},{"sha":"0e2238d92b92878181a4f700a5b825a10594db57","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Cleanup some specs","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/0e2238d92b92878181a4f700a5b825a10594db57"},{"sha":"cb5a8d9feea876cf32f1cfb8c947ee2a3b7b85be","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Silence the create_table output","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/cb5a8d9feea876cf32f1cfb8c947ee2a3b7b85be"},{"sha":"6d6240b60a4126acd42c00d9be68c01de42a4b52","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Add a test case for 2 included associations' columns.","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/6d6240b60a4126acd42c00d9be68c01de42a4b52"},{"sha":"231e1278e8a43214ad8347c61782d4350e26e964","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Look in reflections_with_virtual in case there's virtual columns, etc.","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/231e1278e8a43214ad8347c61782d4350e26e964"},{"sha":"0040fd583d0070c6610dd874e2cddcb1bdb1113b","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Test to_model_hash directly not private methods.","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/0040fd583d0070c6610dd874e2cddcb1bdb1113b"},{"sha":"e10627aaa14f62ee1635bb22205be9e5c20f6863","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"TestVm didn't have the proper association setup to pass the tests.\n\nAdd test_operating_system as a has_one on TestVm.\nFix assertions","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/e10627aaa14f62ee1635bb22205be9e5c20f6863"},{"sha":"c676980e6bd822135df8264482569d1d7bf2de6f","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Use hash rockets.","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/c676980e6bd822135df8264482569d1d7bf2de6f"},{"sha":"86f0b53ff7417a836c9f2fcbfd11ab77e7afd06c","author":{"email":"ea442e001a5636eeee710090794bb7eb2e3459c8@redhat.com","name":"Joe Rafaniello"},"message":"Align/rubocop all the things","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/86f0b53ff7417a836c9f2fcbfd11ab77e7afd06c"},{"sha":"c708a27bd749a31a14dccc6c36099b00536a4a80","author":{"email":"ec4b33ce7e6f20774aea1f12f0f537a441f5680b@redhat.com","name":"Brandon Dunne"},"message":"Extract behavior setting to methods for greater flexibility","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/c708a27bd749a31a14dccc6c36099b00536a4a80"},{"sha":"0860ee7895e2c21e39e03076d0fd2cfc1858b2d8","author":{"email":"ec4b33ce7e6f20774aea1f12f0f537a441f5680b@redhat.com","name":"Brandon Dunne"},"message":"Create MiqAeMethodService::Deprecation for automation deprecations","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/0860ee7895e2c21e39e03076d0fd2cfc1858b2d8"},{"sha":"dd05cf3bf21f73523b15018592c9f185bd82fa17","author":{"email":"8499781c77eea64542ae6fc9ae310ccf635eba31@redhat.com","name":"Libor Pichler"},"message":"Fixing correct storing MiqExpression when new widget is created\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1204826","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/dd05cf3bf21f73523b15018592c9f185bd82fa17"},{"sha":"f6edd3cba1df049d1385595be28c4596bd8bc258","author":{"email":"8499781c77eea64542ae6fc9ae310ccf635eba31@redhat.com","name":"Libor Pichler"},"message":"Add spec for correct storing MiqExpression when new widget is created","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/f6edd3cba1df049d1385595be28c4596bd8bc258"},{"sha":"e0ea4b898c95b75711bc853a742b01b38f4b70d5","author":{"email":"3543bf13ea6db7013709be4905e9af3aa989aa04@redhat.com","name":"dkorn"},"message":"Collect additional Pod Events\n\nThe following container group events are added:\n* OutOfDisk\n* NodeSelectorMismatching\n* InsufficientFreeCPU\n* InsufficientFreeMemoryCreated","distinct":false,"url":"https://api.github.com/repos/kbrock/manageiq/commits/e0ea4b898c95b75711bc853a742b01b38f4b70d5"}]}