{"action":"created","issue":{"url":"https://api.github.com/repos/sillsdev/masterinstaller/issues/4","labels_url":"https://api.github.com/repos/sillsdev/masterinstaller/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/sillsdev/masterinstaller/issues/4/comments","events_url":"https://api.github.com/repos/sillsdev/masterinstaller/issues/4/events","html_url":"https://github.com/sillsdev/masterinstaller/pull/4","id":116639467,"number":4,"title":"Initial work on generating the master installer code","user":{"login":"jasonleenaylor","id":2295227,"avatar_url":"https://avatars.githubusercontent.com/u/2295227?v=3","gravatar_id":"","url":"https://api.github.com/users/jasonleenaylor","html_url":"https://github.com/jasonleenaylor","followers_url":"https://api.github.com/users/jasonleenaylor/followers","following_url":"https://api.github.com/users/jasonleenaylor/following{/other_user}","gists_url":"https://api.github.com/users/jasonleenaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonleenaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonleenaylor/subscriptions","organizations_url":"https://api.github.com/users/jasonleenaylor/orgs","repos_url":"https://api.github.com/users/jasonleenaylor/repos","events_url":"https://api.github.com/users/jasonleenaylor/events{/privacy}","received_events_url":"https://api.github.com/users/jasonleenaylor/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-12T21:02:45Z","updated_at":"2015-11-13T16:09:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sillsdev/masterinstaller/pulls/4","html_url":"https://github.com/sillsdev/masterinstaller/pull/4","diff_url":"https://github.com/sillsdev/masterinstaller/pull/4.diff","patch_url":"https://github.com/sillsdev/masterinstaller/pull/4.patch"},"body":"\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/sillsdev/masterinstaller/4)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/sillsdev/masterinstaller/issues/comments/156475187","html_url":"https://github.com/sillsdev/masterinstaller/pull/4#issuecomment-156475187","issue_url":"https://api.github.com/repos/sillsdev/masterinstaller/issues/4","id":156475187,"user":{"login":"papeh","id":4933670,"avatar_url":"https://avatars.githubusercontent.com/u/4933670?v=3","gravatar_id":"","url":"https://api.github.com/users/papeh","html_url":"https://github.com/papeh","followers_url":"https://api.github.com/users/papeh/followers","following_url":"https://api.github.com/users/papeh/following{/other_user}","gists_url":"https://api.github.com/users/papeh/gists{/gist_id}","starred_url":"https://api.github.com/users/papeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/papeh/subscriptions","organizations_url":"https://api.github.com/users/papeh/orgs","repos_url":"https://api.github.com/users/papeh/repos","events_url":"https://api.github.com/users/papeh/events{/privacy}","received_events_url":"https://api.github.com/users/papeh/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T16:09:22Z","updated_at":"2015-11-13T16:09:22Z","body":"\n\n\n\nReviewed 35 of 35 files at r1.\nReview status: all files reviewed at latest revision, 4 unresolved discussions.\n\n---\n\n<sup>**[Code and Projects/MasterInstallerConfigurator/MasterInstallerCompiler.cs, line 13 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/masterinstaller/4#-K30Yz9h9PCXT231yM_V)** ([raw file](https://github.com/sillsdev/masterinstaller/blob/38dfa6fbb391342c28d3f34f5fc1265ca50f6b39/Code and Projects/MasterInstallerConfigurator/MasterInstallerCompiler.cs#L13)):</sup>\nSpaces in paths are poor practice; however, if this directory has already had this name, I won't make you change it now.\n<!-- Reviewable comment -K30Yz9h9PCXT231yM_W:319849727 -->\n\n---\n\n<sup>**[Code and Projects/MasterInstallerConfigurator/MasterInstallerCompiler.cs, line 88 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/masterinstaller/4#-K30_PG5Or2XCYJ9oYHm)** ([raw file](https://github.com/sillsdev/masterinstaller/blob/38dfa6fbb391342c28d3f34f5fc1265ca50f6b39/Code and Projects/MasterInstallerConfigurator/MasterInstallerCompiler.cs#L88)):</sup>\nunnecessary spaces in this path (considerCamelCase)\n<!-- Reviewable comment -K30_PG5Or2XCYJ9oYHn:1758948564 -->\n\n---\n\n<sup>**[Installer Definitions/FW 8.2.2 SE/FW 8.2.2 SE.xml, line 191 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/masterinstaller/4#-K30afLLYNjSGahLPaoR)** ([raw file](https://github.com/sillsdev/masterinstaller/blob/38dfa6fbb391342c28d3f34f5fc1265ca50f6b39/Installer Definitions/FW 8.2.2 SE/FW 8.2.2 SE.xml#L191)):</sup>\nThis redirects to http://www.microsoft.com/en-us/download\n<!-- Reviewable comment -K30afLLYNjSGahLPaoS:672282061 -->\n\n---\n\n<sup>**[Installer Definitions/Phonology Assistant/Phonology Assistant.xml, line 19 \\[r1\\]](https://reviewable.io:443/reviews/sillsdev/masterinstaller/4#-K30akzWi6RI6H_B-X3L)** ([raw file](https://github.com/sillsdev/masterinstaller/blob/6aaa2bfa8cdf4fd0efc53bc7560671507bc14b25/Installer Definitions/Phonology Assistant/Phonology Assistant.xml#L19)):</sup>\n0 instead of empty string?\n<!-- Reviewable comment -K30akzWi6RI6H_B-X3M:-518489147 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/sillsdev/masterinstaller/4)\n<!-- Sent from Reviewable.io -->\n"}}