{"action":"created","comment":{"url":"https://api.github.com/repos/SciTools/biggus/pulls/comments/26782820","id":26782820,"diff_hunk":"@@ -2281,14 +2281,27 @@ def _full_keys(keys, ndim):\n     if not isinstance(keys, tuple):\n         keys = (keys,)\n \n+    # Make keys mutable, and take a copy.\n+    keys = list(keys)[:]","path":"biggus/__init__.py","position":5,"original_position":5,"commit_id":"d64428e43736327184cd69f0b0b63f61eff1a047","original_commit_id":"d64428e43736327184cd69f0b0b63f61eff1a047","user":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"body":"As I wasn't 100% confident what the result of the following was:\r\n\r\n```\r\n>>> a = [1, 2, 3]\r\n>>> b = list(a)\r\n>>> a is b\r\nFalse\r\n```\r\n\r\nAs a consequence, the ``[:]`` is redundant.","created_at":"2015-03-19T18:18:35Z","updated_at":"2015-03-19T18:18:35Z","html_url":"https://github.com/SciTools/biggus/pull/122#discussion_r26782820","pull_request_url":"https://api.github.com/repos/SciTools/biggus/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/SciTools/biggus/pulls/comments/26782820"},"html":{"href":"https://github.com/SciTools/biggus/pull/122#discussion_r26782820"},"pull_request":{"href":"https://api.github.com/repos/SciTools/biggus/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/SciTools/biggus/pulls/122","id":31470344,"html_url":"https://github.com/SciTools/biggus/pull/122","diff_url":"https://github.com/SciTools/biggus/pull/122.diff","patch_url":"https://github.com/SciTools/biggus/pull/122.patch","issue_url":"https://api.github.com/repos/SciTools/biggus/issues/122","number":122,"state":"closed","locked":false,"title":"Fix for #121.","user":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"body":"``_full_keys`` now handles an ndim + 1 iterable of keys, provided one of them is an Ellipsis.","created_at":"2015-03-18T20:46:32Z","updated_at":"2015-03-19T18:18:35Z","closed_at":"2015-03-19T15:02:01Z","merged_at":"2015-03-19T15:02:01Z","merge_commit_sha":"5b0a3799f3c03738d0f2afe449c26dcc8503fdc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SciTools/biggus/pulls/122/commits","review_comments_url":"https://api.github.com/repos/SciTools/biggus/pulls/122/comments","review_comment_url":"https://api.github.com/repos/SciTools/biggus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SciTools/biggus/issues/122/comments","statuses_url":"https://api.github.com/repos/SciTools/biggus/statuses/d64428e43736327184cd69f0b0b63f61eff1a047","head":{"label":"pelson:full_slices_null_ellipsis","ref":"full_slices_null_ellipsis","sha":"d64428e43736327184cd69f0b0b63f61eff1a047","user":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"repo":{"id":9844892,"name":"biggus","full_name":"pelson/biggus","owner":{"login":"pelson","id":810663,"avatar_url":"https://avatars.githubusercontent.com/u/810663?v=3","gravatar_id":"","url":"https://api.github.com/users/pelson","html_url":"https://github.com/pelson","followers_url":"https://api.github.com/users/pelson/followers","following_url":"https://api.github.com/users/pelson/following{/other_user}","gists_url":"https://api.github.com/users/pelson/gists{/gist_id}","starred_url":"https://api.github.com/users/pelson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pelson/subscriptions","organizations_url":"https://api.github.com/users/pelson/orgs","repos_url":"https://api.github.com/users/pelson/repos","events_url":"https://api.github.com/users/pelson/events{/privacy}","received_events_url":"https://api.github.com/users/pelson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pelson/biggus","description":"Virtual large arrays and lazy evaluation.","fork":true,"url":"https://api.github.com/repos/pelson/biggus","forks_url":"https://api.github.com/repos/pelson/biggus/forks","keys_url":"https://api.github.com/repos/pelson/biggus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pelson/biggus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pelson/biggus/teams","hooks_url":"https://api.github.com/repos/pelson/biggus/hooks","issue_events_url":"https://api.github.com/repos/pelson/biggus/issues/events{/number}","events_url":"https://api.github.com/repos/pelson/biggus/events","assignees_url":"https://api.github.com/repos/pelson/biggus/assignees{/user}","branches_url":"https://api.github.com/repos/pelson/biggus/branches{/branch}","tags_url":"https://api.github.com/repos/pelson/biggus/tags","blobs_url":"https://api.github.com/repos/pelson/biggus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pelson/biggus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pelson/biggus/git/refs{/sha}","trees_url":"https://api.github.com/repos/pelson/biggus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pelson/biggus/statuses/{sha}","languages_url":"https://api.github.com/repos/pelson/biggus/languages","stargazers_url":"https://api.github.com/repos/pelson/biggus/stargazers","contributors_url":"https://api.github.com/repos/pelson/biggus/contributors","subscribers_url":"https://api.github.com/repos/pelson/biggus/subscribers","subscription_url":"https://api.github.com/repos/pelson/biggus/subscription","commits_url":"https://api.github.com/repos/pelson/biggus/commits{/sha}","git_commits_url":"https://api.github.com/repos/pelson/biggus/git/commits{/sha}","comments_url":"https://api.github.com/repos/pelson/biggus/comments{/number}","issue_comment_url":"https://api.github.com/repos/pelson/biggus/issues/comments{/number}","contents_url":"https://api.github.com/repos/pelson/biggus/contents/{+path}","compare_url":"https://api.github.com/repos/pelson/biggus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pelson/biggus/merges","archive_url":"https://api.github.com/repos/pelson/biggus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pelson/biggus/downloads","issues_url":"https://api.github.com/repos/pelson/biggus/issues{/number}","pulls_url":"https://api.github.com/repos/pelson/biggus/pulls{/number}","milestones_url":"https://api.github.com/repos/pelson/biggus/milestones{/number}","notifications_url":"https://api.github.com/repos/pelson/biggus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pelson/biggus/labels{/name}","releases_url":"https://api.github.com/repos/pelson/biggus/releases{/id}","created_at":"2013-05-03T21:22:07Z","updated_at":"2014-06-11T12:30:37Z","pushed_at":"2015-03-18T22:36:03Z","git_url":"git://github.com/pelson/biggus.git","ssh_url":"git@github.com:pelson/biggus.git","clone_url":"https://github.com/pelson/biggus.git","svn_url":"https://github.com/pelson/biggus","homepage":"","size":670,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SciTools:master","ref":"master","sha":"5c01bc0c7fc5a89f8ccb33baeb6244e2729132d5","user":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"repo":{"id":5265623,"name":"biggus","full_name":"SciTools/biggus","owner":{"login":"SciTools","id":1391487,"avatar_url":"https://avatars.githubusercontent.com/u/1391487?v=3","gravatar_id":"","url":"https://api.github.com/users/SciTools","html_url":"https://github.com/SciTools","followers_url":"https://api.github.com/users/SciTools/followers","following_url":"https://api.github.com/users/SciTools/following{/other_user}","gists_url":"https://api.github.com/users/SciTools/gists{/gist_id}","starred_url":"https://api.github.com/users/SciTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SciTools/subscriptions","organizations_url":"https://api.github.com/users/SciTools/orgs","repos_url":"https://api.github.com/users/SciTools/repos","events_url":"https://api.github.com/users/SciTools/events{/privacy}","received_events_url":"https://api.github.com/users/SciTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SciTools/biggus","description":"Virtual large arrays and lazy evaluation.","fork":false,"url":"https://api.github.com/repos/SciTools/biggus","forks_url":"https://api.github.com/repos/SciTools/biggus/forks","keys_url":"https://api.github.com/repos/SciTools/biggus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SciTools/biggus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SciTools/biggus/teams","hooks_url":"https://api.github.com/repos/SciTools/biggus/hooks","issue_events_url":"https://api.github.com/repos/SciTools/biggus/issues/events{/number}","events_url":"https://api.github.com/repos/SciTools/biggus/events","assignees_url":"https://api.github.com/repos/SciTools/biggus/assignees{/user}","branches_url":"https://api.github.com/repos/SciTools/biggus/branches{/branch}","tags_url":"https://api.github.com/repos/SciTools/biggus/tags","blobs_url":"https://api.github.com/repos/SciTools/biggus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SciTools/biggus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SciTools/biggus/git/refs{/sha}","trees_url":"https://api.github.com/repos/SciTools/biggus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SciTools/biggus/statuses/{sha}","languages_url":"https://api.github.com/repos/SciTools/biggus/languages","stargazers_url":"https://api.github.com/repos/SciTools/biggus/stargazers","contributors_url":"https://api.github.com/repos/SciTools/biggus/contributors","subscribers_url":"https://api.github.com/repos/SciTools/biggus/subscribers","subscription_url":"https://api.github.com/repos/SciTools/biggus/subscription","commits_url":"https://api.github.com/repos/SciTools/biggus/commits{/sha}","git_commits_url":"https://api.github.com/repos/SciTools/biggus/git/commits{/sha}","comments_url":"https://api.github.com/repos/SciTools/biggus/comments{/number}","issue_comment_url":"https://api.github.com/repos/SciTools/biggus/issues/comments{/number}","contents_url":"https://api.github.com/repos/SciTools/biggus/contents/{+path}","compare_url":"https://api.github.com/repos/SciTools/biggus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SciTools/biggus/merges","archive_url":"https://api.github.com/repos/SciTools/biggus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SciTools/biggus/downloads","issues_url":"https://api.github.com/repos/SciTools/biggus/issues{/number}","pulls_url":"https://api.github.com/repos/SciTools/biggus/pulls{/number}","milestones_url":"https://api.github.com/repos/SciTools/biggus/milestones{/number}","notifications_url":"https://api.github.com/repos/SciTools/biggus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SciTools/biggus/labels{/name}","releases_url":"https://api.github.com/repos/SciTools/biggus/releases{/id}","created_at":"2012-08-01T22:26:06Z","updated_at":"2015-03-19T15:02:03Z","pushed_at":"2015-03-19T15:02:02Z","git_url":"git://github.com/SciTools/biggus.git","ssh_url":"git@github.com:SciTools/biggus.git","clone_url":"https://github.com/SciTools/biggus.git","svn_url":"https://github.com/SciTools/biggus","homepage":"http://biggus.readthedocs.org/","size":1234,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":26,"forks":22,"open_issues":26,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SciTools/biggus/pulls/122"},"html":{"href":"https://github.com/SciTools/biggus/pull/122"},"issue":{"href":"https://api.github.com/repos/SciTools/biggus/issues/122"},"comments":{"href":"https://api.github.com/repos/SciTools/biggus/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/SciTools/biggus/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/SciTools/biggus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SciTools/biggus/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/SciTools/biggus/statuses/d64428e43736327184cd69f0b0b63f61eff1a047"}}}}