{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/41963888","id":41963888,"diff_hunk":"@@ -249,15 +246,19 @@ public void writeShort(int position, int v, ByteOrder byteOrder) throws IOExcept\n \n     @Override\n     public void writeUTF(final String str) throws IOException {\n-        if (utfBuffer == null) {\n-            utfBuffer = new byte[UTF_BUFFER_SIZE];\n+        int len = (str != null) ? str.length() : NULL_ARRAY;\n+        writeInt(len);\n+        if (len > 0) {\n+            ensureAvailable(len * 3);\n+            for (int i = 0; i < len; i++) {\n+                pos += Bits.writeUtf8Char(buffer, pos, str.charAt(i));","path":"hazelcast/src/main/java/com/hazelcast/internal/serialization/impl/ByteArrayObjectDataOutput.java","position":51,"original_position":51,"commit_id":"5cf478ceb33e374724ea5dba3265e45d8f469aea","original_commit_id":"5cf478ceb33e374724ea5dba3265e45d8f469aea","user":{"login":"cangencer","id":510278,"avatar_url":"https://avatars.githubusercontent.com/u/510278?v=3","gravatar_id":"","url":"https://api.github.com/users/cangencer","html_url":"https://github.com/cangencer","followers_url":"https://api.github.com/users/cangencer/followers","following_url":"https://api.github.com/users/cangencer/following{/other_user}","gists_url":"https://api.github.com/users/cangencer/gists{/gist_id}","starred_url":"https://api.github.com/users/cangencer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cangencer/subscriptions","organizations_url":"https://api.github.com/users/cangencer/orgs","repos_url":"https://api.github.com/users/cangencer/repos","events_url":"https://api.github.com/users/cangencer/events{/privacy}","received_events_url":"https://api.github.com/users/cangencer/received_events","type":"User","site_admin":false},"body":"I have a suspicion this might not be right. If the char is part of a surrogate pair then you need both the low surrogate and the surrogate to convert it into a utf-8 character.","created_at":"2015-10-14T07:50:21Z","updated_at":"2015-10-14T07:50:21Z","html_url":"https://github.com/hazelcast/hazelcast/pull/6393#discussion_r41963888","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/41963888"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6393#discussion_r41963888"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393","id":46947689,"html_url":"https://github.com/hazelcast/hazelcast/pull/6393","diff_url":"https://github.com/hazelcast/hazelcast/pull/6393.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/6393.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6393","number":6393,"state":"open","locked":false,"title":"Serialization compatibility","user":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-06T19:38:46Z","updated_at":"2015-10-14T07:50:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ada8bd62806a04150b1046b2181ffde75768f945","assignee":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61","html_url":"https://github.com/hazelcast/hazelcast/milestones/3.6","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/61/labels","id":982584,"number":61,"title":"3.6","description":"","creator":{"login":"enesakar","id":234086,"avatar_url":"https://avatars.githubusercontent.com/u/234086?v=3","gravatar_id":"","url":"https://api.github.com/users/enesakar","html_url":"https://github.com/enesakar","followers_url":"https://api.github.com/users/enesakar/followers","following_url":"https://api.github.com/users/enesakar/following{/other_user}","gists_url":"https://api.github.com/users/enesakar/gists{/gist_id}","starred_url":"https://api.github.com/users/enesakar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enesakar/subscriptions","organizations_url":"https://api.github.com/users/enesakar/orgs","repos_url":"https://api.github.com/users/enesakar/repos","events_url":"https://api.github.com/users/enesakar/events{/privacy}","received_events_url":"https://api.github.com/users/enesakar/received_events","type":"User","site_admin":false},"open_issues":160,"closed_issues":559,"state":"open","created_at":"2015-02-17T09:27:09Z","updated_at":"2015-10-14T07:39:38Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/6393/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/5cf478ceb33e374724ea5dba3265e45d8f469aea","head":{"label":"asimarslan:feature/master/serialization-compatibility2","ref":"feature/master/serialization-compatibility2","sha":"5cf478ceb33e374724ea5dba3265e45d8f469aea","user":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"repo":{"id":10238745,"name":"hazelcast","full_name":"asimarslan/hazelcast","owner":{"login":"asimarslan","id":2497208,"avatar_url":"https://avatars.githubusercontent.com/u/2497208?v=3","gravatar_id":"","url":"https://api.github.com/users/asimarslan","html_url":"https://github.com/asimarslan","followers_url":"https://api.github.com/users/asimarslan/followers","following_url":"https://api.github.com/users/asimarslan/following{/other_user}","gists_url":"https://api.github.com/users/asimarslan/gists{/gist_id}","starred_url":"https://api.github.com/users/asimarslan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimarslan/subscriptions","organizations_url":"https://api.github.com/users/asimarslan/orgs","repos_url":"https://api.github.com/users/asimarslan/repos","events_url":"https://api.github.com/users/asimarslan/events{/privacy}","received_events_url":"https://api.github.com/users/asimarslan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asimarslan/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/asimarslan/hazelcast","forks_url":"https://api.github.com/repos/asimarslan/hazelcast/forks","keys_url":"https://api.github.com/repos/asimarslan/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asimarslan/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asimarslan/hazelcast/teams","hooks_url":"https://api.github.com/repos/asimarslan/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/asimarslan/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/asimarslan/hazelcast/events","assignees_url":"https://api.github.com/repos/asimarslan/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/asimarslan/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/asimarslan/hazelcast/tags","blobs_url":"https://api.github.com/repos/asimarslan/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asimarslan/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asimarslan/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/asimarslan/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asimarslan/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/asimarslan/hazelcast/languages","stargazers_url":"https://api.github.com/repos/asimarslan/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/asimarslan/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/asimarslan/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/asimarslan/hazelcast/subscription","commits_url":"https://api.github.com/repos/asimarslan/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/asimarslan/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/asimarslan/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/asimarslan/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/asimarslan/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/asimarslan/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asimarslan/hazelcast/merges","archive_url":"https://api.github.com/repos/asimarslan/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asimarslan/hazelcast/downloads","issues_url":"https://api.github.com/repos/asimarslan/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/asimarslan/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/asimarslan/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/asimarslan/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asimarslan/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/asimarslan/hazelcast/releases{/id}","created_at":"2013-05-23T07:56:42Z","updated_at":"2015-04-01T14:20:18Z","pushed_at":"2015-10-13T18:32:52Z","git_url":"git://github.com/asimarslan/hazelcast.git","ssh_url":"git@github.com:asimarslan/hazelcast.git","clone_url":"https://github.com/asimarslan/hazelcast.git","svn_url":"https://github.com/asimarslan/hazelcast","homepage":"www.hazelcast.com","size":76923,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"22e51b3ce2c2363399180552632fe7cebc9932e4","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-10-14T05:42:05Z","pushed_at":"2015-10-14T07:39:38Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":159536,"stargazers_count":1264,"watchers_count":1264,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":617,"mirror_url":null,"open_issues_count":532,"forks":617,"open_issues":532,"watchers":1264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/6393"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6393"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/6393/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/6393/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/5cf478ceb33e374724ea5dba3265e45d8f469aea"}}}}