{"action":"created","comment":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/26492302","id":26492302,"diff_hunk":"@@ -148,8 +155,17 @@ private boolean writeTailMetadata(boolean finished) {\n     return jsonObjectFileHelper.writeObject(tailMetadata, path, log);\n   }\n \n+  /**\n+   * Return a String for generating a PathMatcher.\n+   * The matching files are caught by the S3 Uploader and pushed to S3.\n+   * @return file glob String.\n+   */\n   private String getS3Glob() {\n-    return String.format(\"%s*.gz*\", taskDefinition.getServiceLogOutPath().getFileName());\n+    List<String> fileNames = new LinkedList<>();\n+    fileNames.add(taskDefinition.getServiceLogOutPath().getFileName().toString());\n+    fileNames.addAll(Arrays.asList(configuration.getS3FilesToBackup()));\n+\n+    return String.format(\"{%s}*.gz*\", StringUtils.join(fileNames, \",\"));","path":"SingularityExecutor/src/main/java/com/hubspot/singularity/executor/task/SingularityExecutorTaskLogManager.java","position":38,"original_position":38,"commit_id":"b0234d1c623bc5573fcbca79091d9052d3a07289","original_commit_id":"b0234d1c623bc5573fcbca79091d9052d3a07289","user":{"login":"wolfd","id":930169,"avatar_url":"https://avatars.githubusercontent.com/u/930169?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfd","html_url":"https://github.com/wolfd","followers_url":"https://api.github.com/users/wolfd/followers","following_url":"https://api.github.com/users/wolfd/following{/other_user}","gists_url":"https://api.github.com/users/wolfd/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfd/subscriptions","organizations_url":"https://api.github.com/users/wolfd/orgs","repos_url":"https://api.github.com/users/wolfd/repos","events_url":"https://api.github.com/users/wolfd/events{/privacy}","received_events_url":"https://api.github.com/users/wolfd/received_events","type":"User","site_admin":false},"body":"The glob syntax seems to be fine, as it generates\r\n\"fileGlob\":\"{service.log,executor.bash.log,executor.java.log}*.gz*\"\r\nin the json config.\r\n\r\nChanged to Joiner in the next commit.","created_at":"2015-03-16T15:05:24Z","updated_at":"2015-03-16T15:05:24Z","html_url":"https://github.com/HubSpot/Singularity/pull/479#discussion_r26492302","pull_request_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/479","_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments/26492302"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/479#discussion_r26492302"},"pull_request":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/479"}}},"pull_request":{"url":"https://api.github.com/repos/HubSpot/Singularity/pulls/479","id":31160036,"html_url":"https://github.com/HubSpot/Singularity/pull/479","diff_url":"https://github.com/HubSpot/Singularity/pull/479.diff","patch_url":"https://github.com/HubSpot/Singularity/pull/479.patch","issue_url":"https://api.github.com/repos/HubSpot/Singularity/issues/479","number":479,"state":"open","locked":false,"title":"Add option to persist more logrotated files in S3","user":{"login":"wolfd","id":930169,"avatar_url":"https://avatars.githubusercontent.com/u/930169?v=3","gravatar_id":"","url":"https://api.github.com/users/wolfd","html_url":"https://github.com/wolfd","followers_url":"https://api.github.com/users/wolfd/followers","following_url":"https://api.github.com/users/wolfd/following{/other_user}","gists_url":"https://api.github.com/users/wolfd/gists{/gist_id}","starred_url":"https://api.github.com/users/wolfd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolfd/subscriptions","organizations_url":"https://api.github.com/users/wolfd/orgs","repos_url":"https://api.github.com/users/wolfd/repos","events_url":"https://api.github.com/users/wolfd/events{/privacy}","received_events_url":"https://api.github.com/users/wolfd/received_events","type":"User","site_admin":false},"body":"Also adds documentation to some files I was reading.\r\nCreate the logrotate directory as part of the runner.","created_at":"2015-03-13T20:15:44Z","updated_at":"2015-03-16T15:05:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c8816fdd9a189f0849d173a4e0cc56165857dad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/479/commits","review_comments_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/479/comments","review_comment_url":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/issues/479/comments","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/b0234d1c623bc5573fcbca79091d9052d3a07289","head":{"label":"HubSpot:persist_more_logs","ref":"persist_more_logs","sha":"b0234d1c623bc5573fcbca79091d9052d3a07289","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-03-15T13:17:28Z","pushed_at":"2015-03-16T14:50:59Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":23545,"stargazers_count":260,"watchers_count":260,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":54,"forks":40,"open_issues":54,"watchers":260,"default_branch":"master"}},"base":{"label":"HubSpot:master","ref":"master","sha":"b1d44df75247922b012e7fc62bc7c4c86712291c","user":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"repo":{"id":13631804,"name":"Singularity","full_name":"HubSpot/Singularity","owner":{"login":"HubSpot","id":326419,"avatar_url":"https://avatars.githubusercontent.com/u/326419?v=3","gravatar_id":"","url":"https://api.github.com/users/HubSpot","html_url":"https://github.com/HubSpot","followers_url":"https://api.github.com/users/HubSpot/followers","following_url":"https://api.github.com/users/HubSpot/following{/other_user}","gists_url":"https://api.github.com/users/HubSpot/gists{/gist_id}","starred_url":"https://api.github.com/users/HubSpot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HubSpot/subscriptions","organizations_url":"https://api.github.com/users/HubSpot/orgs","repos_url":"https://api.github.com/users/HubSpot/repos","events_url":"https://api.github.com/users/HubSpot/events{/privacy}","received_events_url":"https://api.github.com/users/HubSpot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HubSpot/Singularity","description":"Scheduler (HTTP API and webapp) for running mesos tasks—long running processes, one-off tasks, and scheduled jobs. #hubspot-open-source","fork":false,"url":"https://api.github.com/repos/HubSpot/Singularity","forks_url":"https://api.github.com/repos/HubSpot/Singularity/forks","keys_url":"https://api.github.com/repos/HubSpot/Singularity/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HubSpot/Singularity/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HubSpot/Singularity/teams","hooks_url":"https://api.github.com/repos/HubSpot/Singularity/hooks","issue_events_url":"https://api.github.com/repos/HubSpot/Singularity/issues/events{/number}","events_url":"https://api.github.com/repos/HubSpot/Singularity/events","assignees_url":"https://api.github.com/repos/HubSpot/Singularity/assignees{/user}","branches_url":"https://api.github.com/repos/HubSpot/Singularity/branches{/branch}","tags_url":"https://api.github.com/repos/HubSpot/Singularity/tags","blobs_url":"https://api.github.com/repos/HubSpot/Singularity/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HubSpot/Singularity/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HubSpot/Singularity/git/refs{/sha}","trees_url":"https://api.github.com/repos/HubSpot/Singularity/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HubSpot/Singularity/statuses/{sha}","languages_url":"https://api.github.com/repos/HubSpot/Singularity/languages","stargazers_url":"https://api.github.com/repos/HubSpot/Singularity/stargazers","contributors_url":"https://api.github.com/repos/HubSpot/Singularity/contributors","subscribers_url":"https://api.github.com/repos/HubSpot/Singularity/subscribers","subscription_url":"https://api.github.com/repos/HubSpot/Singularity/subscription","commits_url":"https://api.github.com/repos/HubSpot/Singularity/commits{/sha}","git_commits_url":"https://api.github.com/repos/HubSpot/Singularity/git/commits{/sha}","comments_url":"https://api.github.com/repos/HubSpot/Singularity/comments{/number}","issue_comment_url":"https://api.github.com/repos/HubSpot/Singularity/issues/comments{/number}","contents_url":"https://api.github.com/repos/HubSpot/Singularity/contents/{+path}","compare_url":"https://api.github.com/repos/HubSpot/Singularity/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HubSpot/Singularity/merges","archive_url":"https://api.github.com/repos/HubSpot/Singularity/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HubSpot/Singularity/downloads","issues_url":"https://api.github.com/repos/HubSpot/Singularity/issues{/number}","pulls_url":"https://api.github.com/repos/HubSpot/Singularity/pulls{/number}","milestones_url":"https://api.github.com/repos/HubSpot/Singularity/milestones{/number}","notifications_url":"https://api.github.com/repos/HubSpot/Singularity/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HubSpot/Singularity/labels{/name}","releases_url":"https://api.github.com/repos/HubSpot/Singularity/releases{/id}","created_at":"2013-10-16T21:28:49Z","updated_at":"2015-03-15T13:17:28Z","pushed_at":"2015-03-16T14:50:59Z","git_url":"git://github.com/HubSpot/Singularity.git","ssh_url":"git@github.com:HubSpot/Singularity.git","clone_url":"https://github.com/HubSpot/Singularity.git","svn_url":"https://github.com/HubSpot/Singularity","homepage":"https://github.com/HubSpot/Singularity","size":23545,"stargazers_count":260,"watchers_count":260,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"open_issues_count":54,"forks":40,"open_issues":54,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/479"},"html":{"href":"https://github.com/HubSpot/Singularity/pull/479"},"issue":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/479"},"comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/issues/479/comments"},"review_comments":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/479/comments"},"review_comment":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HubSpot/Singularity/pulls/479/commits"},"statuses":{"href":"https://api.github.com/repos/HubSpot/Singularity/statuses/b0234d1c623bc5573fcbca79091d9052d3a07289"}}}}