{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/33166687","id":33166687,"diff_hunk":"@@ -289,7 +288,7 @@ public void testIgnoreMalformedOption() throws Exception {\n                     .endObject()\n                     .bytes());\n         } catch (MapperParsingException e) {\n-            assertThat(e.getCause(), instanceOf(MapperParsingException.class));\n+            assertThat(e.getCause(), instanceOf(IllegalArgumentException.class));","path":"core/src/test/java/org/elasticsearch/index/mapper/date/SimpleDateMappingTests.java","position":75,"original_position":75,"commit_id":"11ceb48d17f03b26479b47c6b8da614da5b015e4","original_commit_id":"11ceb48d17f03b26479b47c6b8da614da5b015e4","user":{"login":"rjernst","id":289412,"avatar_url":"https://avatars.githubusercontent.com/u/289412?v=3","gravatar_id":"","url":"https://api.github.com/users/rjernst","html_url":"https://github.com/rjernst","followers_url":"https://api.github.com/users/rjernst/followers","following_url":"https://api.github.com/users/rjernst/following{/other_user}","gists_url":"https://api.github.com/users/rjernst/gists{/gist_id}","starred_url":"https://api.github.com/users/rjernst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjernst/subscriptions","organizations_url":"https://api.github.com/users/rjernst/orgs","repos_url":"https://api.github.com/users/rjernst/repos","events_url":"https://api.github.com/users/rjernst/events{/privacy}","received_events_url":"https://api.github.com/users/rjernst/received_events","type":"User","site_admin":false},"body":"can we check part of the message so we know we got the right exception? ditto for the other cases like this in this file","created_at":"2015-06-24T16:27:41Z","updated_at":"2015-06-24T16:27:41Z","html_url":"https://github.com/elastic/elasticsearch/pull/11515#discussion_r33166687","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/33166687"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/11515#discussion_r33166687"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515","id":37043180,"html_url":"https://github.com/elastic/elasticsearch/pull/11515","diff_url":"https://github.com/elastic/elasticsearch/pull/11515.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/11515.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11515","number":11515,"state":"open","locked":false,"title":"Allow for backwards compatibility for unix timestamp in pre 2.x indices","user":{"login":"spinscale","id":667544,"avatar_url":"https://avatars.githubusercontent.com/u/667544?v=3","gravatar_id":"","url":"https://api.github.com/users/spinscale","html_url":"https://github.com/spinscale","followers_url":"https://api.github.com/users/spinscale/followers","following_url":"https://api.github.com/users/spinscale/following{/other_user}","gists_url":"https://api.github.com/users/spinscale/gists{/gist_id}","starred_url":"https://api.github.com/users/spinscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinscale/subscriptions","organizations_url":"https://api.github.com/users/spinscale/orgs","repos_url":"https://api.github.com/users/spinscale/repos","events_url":"https://api.github.com/users/spinscale/events{/privacy}","received_events_url":"https://api.github.com/users/spinscale/received_events","type":"User","site_admin":false},"body":"In order to be backwards compatible, indices created before 2.x must support\r\nindexing of a unix timestamp and its configured date format. Indices created\r\nwith 2.x must configure the `epoch_millis` date formatter in order to\r\nsupport this. Also the `numeric_resolution` parameter is not needed anymore,\r\nas this is configured by either using `epoch_millis` or `epoch_seconds`, however\r\nit must still be supported for older indices.\r\n\r\nRelates #10971","created_at":"2015-06-05T15:40:40Z","updated_at":"2015-06-24T16:27:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3764ef4ded7419e5475e90ea73a1f5348c2610ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/11515/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/11ceb48d17f03b26479b47c6b8da614da5b015e4","head":{"label":"spinscale:1506-unix-timestamp-bwc-compat","ref":"1506-unix-timestamp-bwc-compat","sha":"11ceb48d17f03b26479b47c6b8da614da5b015e4","user":{"login":"spinscale","id":667544,"avatar_url":"https://avatars.githubusercontent.com/u/667544?v=3","gravatar_id":"","url":"https://api.github.com/users/spinscale","html_url":"https://github.com/spinscale","followers_url":"https://api.github.com/users/spinscale/followers","following_url":"https://api.github.com/users/spinscale/following{/other_user}","gists_url":"https://api.github.com/users/spinscale/gists{/gist_id}","starred_url":"https://api.github.com/users/spinscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinscale/subscriptions","organizations_url":"https://api.github.com/users/spinscale/orgs","repos_url":"https://api.github.com/users/spinscale/repos","events_url":"https://api.github.com/users/spinscale/events{/privacy}","received_events_url":"https://api.github.com/users/spinscale/received_events","type":"User","site_admin":false},"repo":{"id":8698747,"name":"elasticsearch","full_name":"spinscale/elasticsearch","owner":{"login":"spinscale","id":667544,"avatar_url":"https://avatars.githubusercontent.com/u/667544?v=3","gravatar_id":"","url":"https://api.github.com/users/spinscale","html_url":"https://github.com/spinscale","followers_url":"https://api.github.com/users/spinscale/followers","following_url":"https://api.github.com/users/spinscale/following{/other_user}","gists_url":"https://api.github.com/users/spinscale/gists{/gist_id}","starred_url":"https://api.github.com/users/spinscale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinscale/subscriptions","organizations_url":"https://api.github.com/users/spinscale/orgs","repos_url":"https://api.github.com/users/spinscale/repos","events_url":"https://api.github.com/users/spinscale/events{/privacy}","received_events_url":"https://api.github.com/users/spinscale/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/spinscale/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/spinscale/elasticsearch","forks_url":"https://api.github.com/repos/spinscale/elasticsearch/forks","keys_url":"https://api.github.com/repos/spinscale/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinscale/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinscale/elasticsearch/teams","hooks_url":"https://api.github.com/repos/spinscale/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/spinscale/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/spinscale/elasticsearch/events","assignees_url":"https://api.github.com/repos/spinscale/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/spinscale/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/spinscale/elasticsearch/tags","blobs_url":"https://api.github.com/repos/spinscale/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinscale/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinscale/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinscale/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinscale/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/spinscale/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/spinscale/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/spinscale/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/spinscale/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/spinscale/elasticsearch/subscription","commits_url":"https://api.github.com/repos/spinscale/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinscale/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinscale/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinscale/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinscale/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/spinscale/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinscale/elasticsearch/merges","archive_url":"https://api.github.com/repos/spinscale/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinscale/elasticsearch/downloads","issues_url":"https://api.github.com/repos/spinscale/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/spinscale/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/spinscale/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/spinscale/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinscale/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/spinscale/elasticsearch/releases{/id}","created_at":"2013-03-11T07:47:35Z","updated_at":"2015-03-10T00:44:51Z","pushed_at":"2015-06-24T12:07:16Z","git_url":"git://github.com/spinscale/elasticsearch.git","ssh_url":"git@github.com:spinscale/elasticsearch.git","clone_url":"https://github.com/spinscale/elasticsearch.git","svn_url":"https://github.com/spinscale/elasticsearch","homepage":"http://elasticsearch.org","size":121320,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"aaa9ee35ea1a19d8c461e720df614c07a77e78f2","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2015-06-24T15:07:35Z","pushed_at":"2015-06-24T16:08:53Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":1896291,"stargazers_count":11742,"watchers_count":11742,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3713,"mirror_url":null,"open_issues_count":1121,"forks":3713,"open_issues":1121,"watchers":11742,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/11515"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/11515"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/11515/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/11515/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/11ceb48d17f03b26479b47c6b8da614da5b015e4"}}}}