{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/36381139","id":36381139,"diff_hunk":"@@ -539,4 +824,38 @@ public void updatePinnedInodes(Set<Integer> inodes) {\n       mPinnedInodes.addAll(Preconditions.checkNotNull(inodes));\n     }\n   }\n+\n+  /**\n+   * A wrapper on necessary info after a move block operation\n+   */\n+  private static class MoveBlockResult {\n+    private final boolean mDone;\n+    private final long mBlockSize;\n+    private final BlockStoreLocation mSrcLocation;\n+    private final BlockStoreLocation mDstLocation;\n+\n+    MoveBlockResult(boolean done, long blockSize, BlockStoreLocation srcLocation,\n+        BlockStoreLocation dstLocation) {\n+      mDone = done;\n+      mBlockSize = blockSize;\n+      mSrcLocation = srcLocation;\n+      mDstLocation = dstLocation;\n+    }\n+\n+    boolean done() {","path":"servers/src/main/java/tachyon/worker/block/TieredBlockStore.java","position":973,"original_position":973,"commit_id":"7c81b32fdc4c5bca2d8aa0cb653f4f8e36aa4d1d","original_commit_id":"7c81b32fdc4c5bca2d8aa0cb653f4f8e36aa4d1d","user":{"login":"gpang","id":429032,"avatar_url":"https://avatars.githubusercontent.com/u/429032?v=3","gravatar_id":"","url":"https://api.github.com/users/gpang","html_url":"https://github.com/gpang","followers_url":"https://api.github.com/users/gpang/followers","following_url":"https://api.github.com/users/gpang/following{/other_user}","gists_url":"https://api.github.com/users/gpang/gists{/gist_id}","starred_url":"https://api.github.com/users/gpang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpang/subscriptions","organizations_url":"https://api.github.com/users/gpang/orgs","repos_url":"https://api.github.com/users/gpang/repos","events_url":"https://api.github.com/users/gpang/events{/privacy}","received_events_url":"https://api.github.com/users/gpang/received_events","type":"User","site_admin":false},"body":"Is this basically success or not? I think \"success()\" (and mSuccess) would be a better name for it.","created_at":"2015-08-06T04:49:47Z","updated_at":"2015-08-06T04:49:47Z","html_url":"https://github.com/amplab/tachyon/pull/1202#discussion_r36381139","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1202","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/36381139"},"html":{"href":"https://github.com/amplab/tachyon/pull/1202#discussion_r36381139"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1202"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1202","id":41310276,"html_url":"https://github.com/amplab/tachyon/pull/1202","diff_url":"https://github.com/amplab/tachyon/pull/1202.diff","patch_url":"https://github.com/amplab/tachyon/pull/1202.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1202","number":1202,"state":"open","locked":false,"title":"[TACHYON-694][TACHYON-695] Fine grained locking in tiered storage","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"body":"https://tachyon.atlassian.net/browse/TACHYON-694\r\nhttps://tachyon.atlassian.net/browse/TACHYON-695\r\n\r\nCurrent tiered storage (`TieredBlockStore`) has read/write lock \"mEvictionLock\" as a global lock (within a single store) to provide thread safety. While simple, it comprises performance. In this PR, we avoid using global lock but try use per-Block lock as much as possible as a performance optimization.","created_at":"2015-07-31T06:14:55Z","updated_at":"2015-08-06T04:49:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82f06cda703c632c7f2f9b563587ed345ce236ea","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1202/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1202/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1202/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/7c81b32fdc4c5bca2d8aa0cb653f4f8e36aa4d1d","head":{"label":"apc999:fine_locking","ref":"fine_locking","sha":"7c81b32fdc4c5bca2d8aa0cb653f4f8e36aa4d1d","user":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"repo":{"id":32042306,"name":"tachyon","full_name":"apc999/tachyon","owner":{"login":"apc999","id":1413748,"avatar_url":"https://avatars.githubusercontent.com/u/1413748?v=3","gravatar_id":"","url":"https://api.github.com/users/apc999","html_url":"https://github.com/apc999","followers_url":"https://api.github.com/users/apc999/followers","following_url":"https://api.github.com/users/apc999/following{/other_user}","gists_url":"https://api.github.com/users/apc999/gists{/gist_id}","starred_url":"https://api.github.com/users/apc999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apc999/subscriptions","organizations_url":"https://api.github.com/users/apc999/orgs","repos_url":"https://api.github.com/users/apc999/repos","events_url":"https://api.github.com/users/apc999/events{/privacy}","received_events_url":"https://api.github.com/users/apc999/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apc999/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/apc999/tachyon","forks_url":"https://api.github.com/repos/apc999/tachyon/forks","keys_url":"https://api.github.com/repos/apc999/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apc999/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apc999/tachyon/teams","hooks_url":"https://api.github.com/repos/apc999/tachyon/hooks","issue_events_url":"https://api.github.com/repos/apc999/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/apc999/tachyon/events","assignees_url":"https://api.github.com/repos/apc999/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/apc999/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/apc999/tachyon/tags","blobs_url":"https://api.github.com/repos/apc999/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apc999/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apc999/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/apc999/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apc999/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/apc999/tachyon/languages","stargazers_url":"https://api.github.com/repos/apc999/tachyon/stargazers","contributors_url":"https://api.github.com/repos/apc999/tachyon/contributors","subscribers_url":"https://api.github.com/repos/apc999/tachyon/subscribers","subscription_url":"https://api.github.com/repos/apc999/tachyon/subscription","commits_url":"https://api.github.com/repos/apc999/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/apc999/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/apc999/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/apc999/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/apc999/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/apc999/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apc999/tachyon/merges","archive_url":"https://api.github.com/repos/apc999/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apc999/tachyon/downloads","issues_url":"https://api.github.com/repos/apc999/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/apc999/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/apc999/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/apc999/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apc999/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/apc999/tachyon/releases{/id}","created_at":"2015-03-11T21:31:13Z","updated_at":"2015-05-12T21:15:01Z","pushed_at":"2015-08-05T23:33:39Z","git_url":"git://github.com/apc999/tachyon.git","ssh_url":"git@github.com:apc999/tachyon.git","clone_url":"https://github.com/apc999/tachyon.git","svn_url":"https://github.com/apc999/tachyon","homepage":"http://tachyon-project.org","size":16217,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"6b9dc71dd767b58a2d916b71271e2b51cc42be3d","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-08-06T01:43:20Z","pushed_at":"2015-08-06T04:29:00Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":38461,"stargazers_count":1495,"watchers_count":1495,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":574,"mirror_url":null,"open_issues_count":23,"forks":574,"open_issues":23,"watchers":1495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1202"},"html":{"href":"https://github.com/amplab/tachyon/pull/1202"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1202"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1202/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1202/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1202/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/7c81b32fdc4c5bca2d8aa0cb653f4f8e36aa4d1d"}}}}