{"action":"created","issue":{"url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/120","labels_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/120/comments","events_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/120/events","html_url":"https://github.com/chris-belcher/joinmarket/issues/120","id":92677009,"number":120,"title":"Make use of maker contribution to tx fee","user":{"login":"domob1812","id":4943644,"avatar_url":"https://avatars.githubusercontent.com/u/4943644?v=3","gravatar_id":"","url":"https://api.github.com/users/domob1812","html_url":"https://github.com/domob1812","followers_url":"https://api.github.com/users/domob1812/followers","following_url":"https://api.github.com/users/domob1812/following{/other_user}","gists_url":"https://api.github.com/users/domob1812/gists{/gist_id}","starred_url":"https://api.github.com/users/domob1812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domob1812/subscriptions","organizations_url":"https://api.github.com/users/domob1812/orgs","repos_url":"https://api.github.com/users/domob1812/repos","events_url":"https://api.github.com/users/domob1812/events{/privacy}","received_events_url":"https://api.github.com/users/domob1812/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":20,"created_at":"2015-07-02T16:20:40Z","updated_at":"2015-07-07T12:19:34Z","closed_at":null,"body":"As far as I can tell, `sendpayment.py` does not make use (nor even display) the maker's contribution to tx fees.  I can imagine the following change (maybe optional):  Say that I want to specify a (total) tx fee of some amount myself as taker, e. g., 10000 satoshi.  I also want manual order selection.  Then, the screen that displays the offers could explicitly tell me about the fee contribution of the makers towards my desired (total) tx fee.  E. g., if someone offers a join for 5000 satoshi but pays 1000 satoshi as tx fee contribution, the screen could show me an \"effective\" cost of only 4000 satoshi for that order.  (Because the total cost for me including the desired tx fee is 9000 + 5000 = 10000 + 4000 = 14000 satoshi.)\r\n\r\nIf I understand the current code correctly, the fee I can set is always simply added to those of the makers.  I think that it would be a nice option to specify the desired total fee instead and show the makers' contributions in the way described above.\r\n\r\nDoes that make sense?  I'm willing to work on an implementation if yes."},"comment":{"url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/comments/119188101","html_url":"https://github.com/chris-belcher/joinmarket/issues/120#issuecomment-119188101","issue_url":"https://api.github.com/repos/chris-belcher/joinmarket/issues/120","id":119188101,"user":{"login":"adlai","id":94171,"avatar_url":"https://avatars.githubusercontent.com/u/94171?v=3","gravatar_id":"","url":"https://api.github.com/users/adlai","html_url":"https://github.com/adlai","followers_url":"https://api.github.com/users/adlai/followers","following_url":"https://api.github.com/users/adlai/following{/other_user}","gists_url":"https://api.github.com/users/adlai/gists{/gist_id}","starred_url":"https://api.github.com/users/adlai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adlai/subscriptions","organizations_url":"https://api.github.com/users/adlai/orgs","repos_url":"https://api.github.com/users/adlai/repos","events_url":"https://api.github.com/users/adlai/events{/privacy}","received_events_url":"https://api.github.com/users/adlai/received_events","type":"User","site_admin":false},"created_at":"2015-07-07T12:19:34Z","updated_at":"2015-07-07T12:19:34Z","body":">>what we're calling maker contributions are in actuality contributed by the taker\r\n\r\n>Why? When you do the accounting it comes out of the maker's utxos.\r\n\r\nHow did you get that? The sum of a maker's inputs is less than the sum of outputs. The sum of the taker's inputs is more than the sum of the taker's output(s). By definition, the taker has paid the makers, and the miner fee. The fact that some indirection happened during the negotiations is ultimately irrelevant. The only maker (that I'm aware of) who made a net contribution to miner fees is \"b3gn3g\".\r\n\r\nThe second part scales much better if we accept that a determined spider can trivially coax that information out of the makers, and have them publish it in the open from the beginning... but I'll take my battles one by one ☺"}}