{"action":"created","issue":{"url":"https://api.github.com/repos/dealii/dealii/issues/598","labels_url":"https://api.github.com/repos/dealii/dealii/issues/598/labels{/name}","comments_url":"https://api.github.com/repos/dealii/dealii/issues/598/comments","events_url":"https://api.github.com/repos/dealii/dealii/issues/598/events","html_url":"https://github.com/dealii/dealii/issues/598","id":58898532,"number":598,"title":"Assert vs AssertThrow in the testsuite","user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars.githubusercontent.com/u/7504421?v=3","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-25T13:07:04Z","updated_at":"2015-02-25T13:29:40Z","closed_at":null,"body":"@Rombur writes:\r\n...................\r\nI checked in the testsuite and we use Assert 2644 times and AssertThrow 63 times. I found several tests that do nothing in release in mode :( Should we just change all of the Assert to AssertThrow or go through all the tests and see what's appropriate ?\r\n...................\r\n\r\nIt's a good question. I don't know what to do. We could:\r\n- Ignore the issue. Most of these tests probably still produce output that is indicative of whether the code worked. We run 7200 tests, if even 100 of those don't do anything in release mode, then that's still only 1%.\r\n- Make a wholesale change. We have a few tests that explicitly want exceptions instead of aborts from `Assert` but that I think they can only (and probably do) only run in debug mode.\r\n- Other options?"},"comment":{"url":"https://api.github.com/repos/dealii/dealii/issues/comments/75959221","html_url":"https://github.com/dealii/dealii/issues/598#issuecomment-75959221","issue_url":"https://api.github.com/repos/dealii/dealii/issues/598","id":75959221,"user":{"login":"tjhei","id":1531285,"avatar_url":"https://avatars.githubusercontent.com/u/1531285?v=3","gravatar_id":"","url":"https://api.github.com/users/tjhei","html_url":"https://github.com/tjhei","followers_url":"https://api.github.com/users/tjhei/followers","following_url":"https://api.github.com/users/tjhei/following{/other_user}","gists_url":"https://api.github.com/users/tjhei/gists{/gist_id}","starred_url":"https://api.github.com/users/tjhei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjhei/subscriptions","organizations_url":"https://api.github.com/users/tjhei/orgs","repos_url":"https://api.github.com/users/tjhei/repos","events_url":"https://api.github.com/users/tjhei/events{/privacy}","received_events_url":"https://api.github.com/users/tjhei/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T13:29:40Z","updated_at":"2015-02-25T13:29:40Z","body":"While I haven't seen/fixed any bug by running the release mode tests, I do think it would be useful to have better coverage in release mode. This is because I had problems with the Intel compiler generating wrong optimized code in the past (hey, that is why we are disabling vectorization...).\r\n\r\nBut yes, there are several tests that expect exceptions/asserts to trigger so we need to be careful there."}}