{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29169341","id":29169341,"diff_hunk":"@@ -181,6 +182,29 @@ func (s *APIServer) verifyPortalFlags() {\n \t}\n }\n \n+// dial attempts to open a TCP connection to the provided address, explicitly\n+// enabling keep-alives with a one-second interval.\n+//\n+// TODO: This is copy-pasted from etcd.Client.dial(), since that method isn't public.","path":"cmd/kube-apiserver/app/server.go","position":15,"original_position":15,"commit_id":"a7ed8f0a821ce78d64931b37dcc2c277d5b3f270","original_commit_id":"a7ed8f0a821ce78d64931b37dcc2c277d5b3f270","user":{"login":"lavalamp","id":647318,"avatar_url":"https://avatars.githubusercontent.com/u/647318?v=3","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"body":":( Unfortunately, that means it needs to be located in a file in third_party","created_at":"2015-04-27T17:30:43Z","updated_at":"2015-04-27T17:30:43Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7353#discussion_r29169341","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29169341"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7353#discussion_r29169341"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353","id":34150562,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7353","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7353.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7353.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7353","number":7353,"state":"open","locked":false,"title":"Increase maxIdleConnection limit when creating etcd client in apiserver.","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"body":"Fix #7160 \r\n\r\ncc @fgrzadkowski @lavalamp @xiang90 ","created_at":"2015-04-27T09:03:30Z","updated_at":"2015-04-27T17:30:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a86b8fdc9ade23a4acea62c0085bf9f297039421","assignee":{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7353/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/a7ed8f0a821ce78d64931b37dcc2c277d5b3f270","head":{"label":"wojtek-t:too_many_dials","ref":"too_many_dials","sha":"a7ed8f0a821ce78d64931b37dcc2c277d5b3f270","user":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"repo":{"id":30216785,"name":"kubernetes","full_name":"wojtek-t/kubernetes","owner":{"login":"wojtek-t","id":10743879,"avatar_url":"https://avatars.githubusercontent.com/u/10743879?v=3","gravatar_id":"","url":"https://api.github.com/users/wojtek-t","html_url":"https://github.com/wojtek-t","followers_url":"https://api.github.com/users/wojtek-t/followers","following_url":"https://api.github.com/users/wojtek-t/following{/other_user}","gists_url":"https://api.github.com/users/wojtek-t/gists{/gist_id}","starred_url":"https://api.github.com/users/wojtek-t/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wojtek-t/subscriptions","organizations_url":"https://api.github.com/users/wojtek-t/orgs","repos_url":"https://api.github.com/users/wojtek-t/repos","events_url":"https://api.github.com/users/wojtek-t/events{/privacy}","received_events_url":"https://api.github.com/users/wojtek-t/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wojtek-t/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/wojtek-t/kubernetes","forks_url":"https://api.github.com/repos/wojtek-t/kubernetes/forks","keys_url":"https://api.github.com/repos/wojtek-t/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wojtek-t/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wojtek-t/kubernetes/teams","hooks_url":"https://api.github.com/repos/wojtek-t/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wojtek-t/kubernetes/events","assignees_url":"https://api.github.com/repos/wojtek-t/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wojtek-t/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/tags","blobs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wojtek-t/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wojtek-t/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wojtek-t/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wojtek-t/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wojtek-t/kubernetes/subscription","commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wojtek-t/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wojtek-t/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wojtek-t/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wojtek-t/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wojtek-t/kubernetes/merges","archive_url":"https://api.github.com/repos/wojtek-t/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wojtek-t/kubernetes/downloads","issues_url":"https://api.github.com/repos/wojtek-t/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wojtek-t/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wojtek-t/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wojtek-t/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wojtek-t/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wojtek-t/kubernetes/releases{/id}","created_at":"2015-02-03T00:37:55Z","updated_at":"2015-02-03T00:37:58Z","pushed_at":"2015-04-27T14:32:23Z","git_url":"git://github.com/wojtek-t/kubernetes.git","ssh_url":"git@github.com:wojtek-t/kubernetes.git","clone_url":"https://github.com/wojtek-t/kubernetes.git","svn_url":"https://github.com/wojtek-t/kubernetes","homepage":"http://kubernetes.io","size":47606,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"4256164a2fff2842df0b2f54b73151e660bda2ec","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-27T17:27:51Z","pushed_at":"2015-04-27T17:27:51Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":206862,"stargazers_count":7372,"watchers_count":7372,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1477,"mirror_url":null,"open_issues_count":952,"forks":1477,"open_issues":952,"watchers":7372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7353"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7353"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7353/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7353/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/a7ed8f0a821ce78d64931b37dcc2c277d5b3f270"}}}}