{"push_id":838584555,"size":165,"distinct_size":0,"ref":"refs/heads/MDL-49993_master","head":"9382ac38d60bee1226e3ba13906770552bea6012","before":"b117fac04b9f2918c08f7493c6cfd68051562bd3","commits":[{"sha":"d9fddb0bc6b3749cee3d9d886e63c47cd9d2e44c","author":{"email":"a2b1f257afcd3351a9eefa4410db841b5dd44f2c@googlemail.com","name":"Andrew Hancox"},"message":"MDL-50940 behat: Added ability to check field value by xpath","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/d9fddb0bc6b3749cee3d9d886e63c47cd9d2e44c"},{"sha":"267033a97969bd7ec4d30e33f2096b67fd121c20","author":{"email":"308059d2078ba123c435ebf7d0f20d8f137330cf@moodle.com","name":"rajesh Taneja"},"message":"MDL-50940 behat: Added support for field matching with xpath","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/267033a97969bd7ec4d30e33f2096b67fd121c20"},{"sha":"fb57f15170f412c75386966bbf1098026d9da14e","author":{"email":"a2b1f257afcd3351a9eefa4410db841b5dd44f2c@googlemail.com","name":"Andrew Hancox"},"message":"MDL-51399 report_outline: Hide blog column if blogs are disabled.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/fb57f15170f412c75386966bbf1098026d9da14e"},{"sha":"2542cb54689d76cb412f8d8621aeb810960b54bf","author":{"email":"79b333c96ec99512a3bf72653b23c7ed8a52dc42@moodle.com","name":"Marina Glancy"},"message":"MDL-51604 course: trigger course created event earlier","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/2542cb54689d76cb412f8d8621aeb810960b54bf"},{"sha":"ea9431eb7b8d0fd856524a5b2f74cec52c6fcaf6","author":{"email":"507ce55bbc16d4fb2defbe26a0dcef008bca1f1a@oakland.edu","name":"Eric Merrill"},"message":"MDL-51500 navigation: Compute links with destination context\n\nWe should calculate the links based on the destination context,\nnot the current course. Could show links that are not accessible.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/ea9431eb7b8d0fd856524a5b2f74cec52c6fcaf6"},{"sha":"48b5b28ff46b87df57fefd9b57facc8ebfdbf793","author":{"email":"8bca9000dd0d0d5222bb70de55634e5935168af7@uqam.ca","name":"Pierre Pichet"},"message":"MDL-38214 Questions: Add MCS, MCVS, MCHS Cloze subquestion types\n\nqtype_multianswer: fix codechecker issues.\n\nSigned-off-by: Pierre Pichet <pichet.pierre@uqam.ca>","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/48b5b28ff46b87df57fefd9b57facc8ebfdbf793"},{"sha":"bd156853528cf56fecc8608b148ccff5ea17fb53","author":{"email":"8bca9000dd0d0d5222bb70de55634e5935168af7@uqam.ca","name":"Pierre Pichet"},"message":"MDL-38214 Questions: Add MCS, MCVS, MCHS Cloze subquestion types\n\nDaniel Seemuth add MCO,MCVS,MCHS new multianswer subquestion types\nqtype_multianswer_initialise_multichoice_subquestion.\nPierre Pichet MCO to MCS, add shuffling display in decode and verify edit_multianswer_form.php\nadd test_questiontext_extraction.\n\nSigned-off-by: Pierre Pichet <pichet.pierre@uqam.ca>","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/bd156853528cf56fecc8608b148ccff5ea17fb53"},{"sha":"fd17898c0c15f2032f9b93ffc9106df802fd3917","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Improve the styling of the Plugins check screen\n\nThe intention here is to make the table a little bit more compact (using\nless columns) and to make use of the bootstrap based label elements if\navailable.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/fd17898c0c15f2032f9b93ffc9106df802fd3917"},{"sha":"e9d3c212288f59633ad67819ba207502318e4748","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Fix \\core\\update\\checker::enabled() logic\n\nThe method should check against $CFG->disableupdatenotifications and not\n$CFG->disableupdateautodeploy. This had to be a copy&paste mistake from\nthe \\core\\update\\deployer::enabled().\n\nWhile looking at it, I also fixed couple of places where this method\nshould and could be used.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/e9d3c212288f59633ad67819ba207502318e4748"},{"sha":"30d8bc5f6681b53f11049c351ff6719bc7e64f98","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Do not always load info about available updates\n\nBefore this patch, whenever core_plugin_manager::get_plugins() was\ncalled, it always attached info about available updates. But this is\nneeded only in quite rare cases, such as when the admin is looking at\nthe Plugins overview and Plugins check screens. There is no need to load\nthis on other places and for non-admin users.\n\nThe patch removes the loading from the method\ncore_plugin_manager::get_plugins_of_type() and implements lazy loading\ndirectly in the plugininfo classes so that it is loaded only when\n\\core\\plugininfo\\base::available_updates() is actually called.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/30d8bc5f6681b53f11049c351ff6719bc7e64f98"},{"sha":"361feecdcfefa729c728d80ea3f712708ecf507d","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Make core_plugin_manager better suited for unit testing\n\nWe can now override the plugin manager's methods in the testable\nsubclass while still keeping the singleton behaviour of it. The change\nmakes use of late static binding.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/361feecdcfefa729c728d80ea3f712708ecf507d"},{"sha":"2d488c8f0140ed5126e36e258223d93101c755d0","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Keep reference to plugin manager in plugininfo objects\n\nPlugin info objects are owned by the plugin manager (composition\npattern). Even if the plugin manager is a singleton, we need to keep\nexplicit reference to the plugin manager that owns the plugin info so\nthat we can mock up things in unit tests.\n\nTherefore this patch introduces a new property of plugin info objects\nthat holds the reference to the instance of the plugin manager that made\n(and hence owns) the given info instance.\n\nThe only trouble here is with static methods of plugin info classes such\nas \\core\\plugininfo\\base::get_enabled_plugins(). In these cases, the\ncode keeps using the core_plugin_manager singleton. The solution would\nbe to pass the plugin manager instance as a parameter but that is not\nworth of change for now, IMHO.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/2d488c8f0140ed5126e36e258223d93101c755d0"},{"sha":"c44bbe35bfd3b06ff633cc7d9b9a3960f2896433","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Improve loading of available updates info\n\nThe actual loading of available updates info objects is moved back to\nthe plugin manager class. As we can now mockup the manager in unit\ntests, this allows us to bypass the real \\core\\update\\checker and have\nunit tests for \\core\\plugininfo\\base::available_updates().","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/c44bbe35bfd3b06ff633cc7d9b9a3960f2896433"},{"sha":"7eb87eff652527ccc1603939c69b6ca1583b7b46","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Move requirements resolving to the plugin manager\n\nThe patch moves the resolving logic from the renderer (where it should\nnot really be) to the plugin manager (controller). This is needed\nbecause we will need the very same logic to be used at other places.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/7eb87eff652527ccc1603939c69b6ca1583b7b46"},{"sha":"48900324b306e8294e4704d08b3b6c7aa7e15331","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Introduce new \\core\\update\\api client class\n\nThe purpose of this class is to provide a general client for all APIs\navailable at https://download.moodle.org/api/ (e.g. available updates,\nplugin info, plugins list etc). Currently, fetching data from this API\nis done separately at several places. This leads to code duplication and\nharder maintenance (I know it well).\n\nAdditionally, the existing client was implemented as\ntool_installaddon_pluginfo_client in the admin/tool/installaddon/ scope.\nI will soon need to use the same functionality in the\ncore_plugin_manager and it would hurt my karma if the core was depending\non a class provided by a admin tool plugin (even if it is standard one).\n\nSo, there is new \\core\\update\\api client implementing the version 1.3 of\nthe pluginfo API. There is a TODO note left for remaining services.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/48900324b306e8294e4704d08b3b6c7aa7e15331"},{"sha":"5a92cd0b8dafb95de1fc862ed4446a8626a748f4","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Display missing dependencies on plugins check screen\n\nThe patch improves the dependencies resolution in the plugin manager so\nthat the information about availability of the missing dependency is\nincluded and can be displayed at the Plugins check screen during the\nupgrade.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/5a92cd0b8dafb95de1fc862ed4446a8626a748f4"},{"sha":"0e442ee776f734dc43651cbd75ba930fdcd32f50","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Introduce new \\core\\update\\core_manager tool\n\nThe plan is to have a single tool looking after all operations with\nplugin ZIP packages (downloading, unzipping, moving to the dirroot and\nback). For legacy reasons, we have that logic currently duplicated in\nmdeploy and tool_installaddon. I would like to unify and simplify the\nwhole machinery to use the same code for available updates, manual\ninstallation and plugin dependencies.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/0e442ee776f734dc43651cbd75ba930fdcd32f50"},{"sha":"f2d8ed45e3dc2e214a08e9fd40f89bfd2e97b47a","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Introduce new \\core\\update\\validator class\n\nThis is not really new class. Originally, the validator was implemented\nin the scope of the tool_installaddon plugin. But we need its features\nin other parts at the core level (e.g. during the upgrade to validate\navailable missing dependencies or available updates). Looking back, it\nwas a mistake to have it implemented at the plugin level rather than the\ncore level.\n\nSo this patch moves the tool_installaddon_validator class to\n\\core\\update\\validator class, together with associated unit tests,\nfixture files and strings. There were changes made in the\ntool_installaddon to make use of this new class instead of the old one.\n\nThis is a great step towards the bright future, hopefully there won't be\nmany regressions.\n\nAMOS BEGIN\n MOV [validationmsg_componentmatch,tool_installaddon],[validationmsg_componentmatch,core_plugin]\n MOV [validationmsg_componentmismatchname,tool_installaddon],[validationmsg_componentmismatchname,core_plugin]\n MOV [validationmsg_componentmismatchname_help,tool_installaddon],[validationmsg_componentmismatchname_help,core_plugin]\n MOV [validationmsg_componentmismatchname_info,tool_installaddon],[validationmsg_componentmismatchname_info,core_plugin]\n MOV [validationmsg_componentmismatchtype,tool_installaddon],[validationmsg_componentmismatchtype,core_plugin]\n MOV [validationmsg_componentmismatchtype_info,tool_installaddon],[validationmsg_componentmismatchtype_info,core_plugin]\n MOV [validationmsg_filenotexists,tool_installaddon],[validationmsg_filenotexists,core_plugin]\n MOV [validationmsg_filesnumber,tool_installaddon],[validationmsg_filesnumber,core_plugin]\n MOV [validationmsg_filestatus,tool_installaddon],[validationmsg_filestatus,core_plugin]\n MOV [validationmsg_filestatus_info,tool_installaddon],[validationmsg_filestatus_info,core_plugin]\n MOV [validationmsg_foundlangfile,tool_installaddon],[validationmsg_foundlangfile,core_plugin]\n MOV [validationmsg_maturity,tool_installaddon],[validationmsg_maturity,core_plugin]\n MOV [validationmsg_maturity_help,tool_installaddon],[validationmsg_maturity_help,core_plugin]\n MOV [validationmsg_missingcomponent,tool_installaddon],[validationmsg_missingcomponent,core_plugin]\n MOV [validationmsg_missingcomponent_help,tool_installaddon],[validationmsg_missingcomponent_help,core_plugin]\n MOV [validationmsg_missingcomponent_link,tool_installaddon],[validationmsg_missingcomponent_link,core_plugin]\n MOV [validationmsg_missingexpectedlangenfile,tool_installaddon],[validationmsg_missingexpectedlangenfile,core_plugin]\n MOV [validationmsg_missingexpectedlangenfile_info,tool_installaddon],[validationmsg_missingexpectedlangenfile_info,core_plugin]\n MOV [validationmsg_missinglangenfile,tool_installaddon],[validationmsg_missinglangenfile,core_plugin]\n MOV [validationmsg_missinglangenfolder,tool_installaddon],[validationmsg_missinglangenfolder,core_plugin]\n MOV [validationmsg_missingversion,tool_installaddon],[validationmsg_missingversion,core_plugin]\n MOV [validationmsg_missingversionphp,tool_installaddon],[validationmsg_missingversionphp,core_plugin]\n MOV [validationmsg_multiplelangenfiles,tool_installaddon],[validationmsg_multiplelangenfiles,core_plugin]\n MOV [validationmsg_onedir,tool_installaddon],[validationmsg_onedir,core_plugin]\n MOV [validationmsg_onedir_help,tool_installaddon],[validationmsg_onedir_help,core_plugin]\n MOV [validationmsg_pathwritable,tool_installaddon],[validationmsg_pathwritable,core_plugin]\n MOV [validationmsg_pluginversion,tool_installaddon],[validationmsg_pluginversion,core_plugin]\n MOV [validationmsg_release,tool_installaddon],[validationmsg_release,core_plugin]\n MOV [validationmsg_requiresmoodle,tool_installaddon],[validationmsg_requiresmoodle,core_plugin]\n MOV [validationmsg_rootdir,tool_installaddon],[validationmsg_rootdir,core_plugin]\n MOV [validationmsg_rootdir_help,tool_installaddon],[validationmsg_rootdir_help,core_plugin]\n MOV [validationmsg_rootdirinvalid,tool_installaddon],[validationmsg_rootdirinvalid,core_plugin]\n MOV [validationmsg_rootdirinvalid_help,tool_installaddon],[validationmsg_rootdirinvalid_help,core_plugin]\n MOV [validationmsg_targetexists,tool_installaddon],[validationmsg_targetexists,core_plugin]\n MOV [validationmsg_targetexists_help,tool_installaddon],[validationmsg_targetexists_help,core_plugin]\n MOV [validationmsg_unknowntype,tool_installaddon],[validationmsg_unknowntype,core_plugin]\n MOV [validationmsg_versionphpsyntax,tool_installaddon],[validationmsg_versionphpsyntax,core_plugin]\n MOV [validationmsglevel_debug,tool_installaddon],[validationmsglevel_debug,core_plugin]\n MOV [validationmsglevel_error,tool_installaddon],[validationmsglevel_error,core_plugin]\n MOV [validationmsglevel_info,tool_installaddon],[validationmsglevel_info,core_plugin]\n MOV [validationmsglevel_warning,tool_installaddon],[validationmsglevel_warning,core_plugin]\nAMOS END","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/f2d8ed45e3dc2e214a08e9fd40f89bfd2e97b47a"},{"sha":"2f29cf6e630d72269989cfb8ea41fb7a32ec0483","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Add ability to cancel installation of a new plugin\n\nThe plugins check screen now provides buttons to cancel installation of\na plugin. Available only for new installations (not upgrades) and for\nadditional plugins (not standard), given that the web server process has\nwrite access to the plugin folder.\n\nThis has also been reported as MDL-48535.\n\nAs a part of the patch, there is improved processing of page URLs during\nthe upgrade. All this dancing around $reload URL is not needed once the\n$PAGE->url is properly set to guide the admin on the correct page during\nthe upgrade process.","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/2f29cf6e630d72269989cfb8ea41fb7a32ec0483"},{"sha":"9137a89a1a566812e3b8278385b41f5c314e44eb","author":{"email":"aa743a0aaec8f7d7a1f01442503957f4d7a2d634@moodle.com","name":"David Mudrák"},"message":"MDL-49329 admin: Improve the UI for installing dependencies","distinct":false,"url":"https://api.github.com/repos/grabs/moodle/commits/9137a89a1a566812e3b8278385b41f5c314e44eb"}]}