{"action":"closed","number":6193,"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/6193","id":47073447,"html_url":"https://github.com/ceph/ceph/pull/6193","diff_url":"https://github.com/ceph/ceph/pull/6193.diff","patch_url":"https://github.com/ceph/ceph/pull/6193.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/6193","number":6193,"state":"closed","locked":false,"title":"ReplicatedPG::maybe_handle_cache: do not promote before checking full","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"body":"Otherwise, ops with need_promote() can order past ops without it\r\ncausing an rgw write sequence like:\r\n\r\nwritefull 0~0\r\nwritefull 0~512kb\r\nwrite 512kb~512kb\r\n\r\nto reorder to\r\n\r\nwritefull 0~0 -- delayed: full\r\nwritefull 0~512kb -- delayed: full\r\nwrite 512kb~512kb -- promote and execute\r\nwritefull 0~0 -- execute\r\nwritefull 0~512kb -- execute\r\n\r\nFixes: 13240\r\nSigned-off-by: Samuel Just <sjust@redhat.com>","created_at":"2015-10-07T19:51:11Z","updated_at":"2015-10-09T23:16:27Z","closed_at":"2015-10-09T23:16:27Z","merged_at":"2015-10-09T23:16:27Z","merge_commit_sha":"d7e33965b28100faf5f88fdcdeb4cdea196cca27","assignee":null,"milestone":{"url":"https://api.github.com/repos/ceph/ceph/milestones/7","html_url":"https://github.com/ceph/ceph/milestones/infernalis","labels_url":"https://api.github.com/repos/ceph/ceph/milestones/7/labels","id":1252449,"number":7,"title":"infernalis","description":"","creator":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":183,"state":"open","created_at":"2015-08-12T19:54:01Z","updated_at":"2015-10-09T23:16:27Z","due_on":"2016-10-30T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/6193/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/6193/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/6193/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/1a2689f8d74537b105cdcf2933f080a2bee9f190","head":{"label":"athanatos:wip-13240","ref":"wip-13240","sha":"1a2689f8d74537b105cdcf2933f080a2bee9f190","user":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"repo":{"id":2424229,"name":"ceph","full_name":"athanatos/ceph","owner":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/athanatos/ceph","description":"Ceph distributed file system","fork":true,"url":"https://api.github.com/repos/athanatos/ceph","forks_url":"https://api.github.com/repos/athanatos/ceph/forks","keys_url":"https://api.github.com/repos/athanatos/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/athanatos/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/athanatos/ceph/teams","hooks_url":"https://api.github.com/repos/athanatos/ceph/hooks","issue_events_url":"https://api.github.com/repos/athanatos/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/athanatos/ceph/events","assignees_url":"https://api.github.com/repos/athanatos/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/athanatos/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/athanatos/ceph/tags","blobs_url":"https://api.github.com/repos/athanatos/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/athanatos/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/athanatos/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/athanatos/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/athanatos/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/athanatos/ceph/languages","stargazers_url":"https://api.github.com/repos/athanatos/ceph/stargazers","contributors_url":"https://api.github.com/repos/athanatos/ceph/contributors","subscribers_url":"https://api.github.com/repos/athanatos/ceph/subscribers","subscription_url":"https://api.github.com/repos/athanatos/ceph/subscription","commits_url":"https://api.github.com/repos/athanatos/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/athanatos/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/athanatos/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/athanatos/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/athanatos/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/athanatos/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/athanatos/ceph/merges","archive_url":"https://api.github.com/repos/athanatos/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/athanatos/ceph/downloads","issues_url":"https://api.github.com/repos/athanatos/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/athanatos/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/athanatos/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/athanatos/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/athanatos/ceph/labels{/name}","releases_url":"https://api.github.com/repos/athanatos/ceph/releases{/id}","created_at":"2011-09-20T17:52:49Z","updated_at":"2015-08-22T02:15:30Z","pushed_at":"2015-10-09T20:16:29Z","git_url":"git://github.com/athanatos/ceph.git","ssh_url":"git@github.com:athanatos/ceph.git","clone_url":"https://github.com/athanatos/ceph.git","svn_url":"https://github.com/athanatos/ceph","homepage":"http://ceph.newdream.net/","size":135182,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"ceph:infernalis","ref":"infernalis","sha":"10bd1cac20738ba750004cff9f8fa5659e20e337","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars.githubusercontent.com/u/1015767?v=3","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","created_at":"2011-09-01T21:41:26Z","updated_at":"2015-10-09T18:18:24Z","pushed_at":"2015-10-09T23:16:27Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":517528,"stargazers_count":1585,"watchers_count":1585,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":935,"mirror_url":null,"open_issues_count":249,"forks":935,"open_issues":249,"watchers":1585,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/6193"},"html":{"href":"https://github.com/ceph/ceph/pull/6193"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/6193"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/6193/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/6193/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/6193/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/1a2689f8d74537b105cdcf2933f080a2bee9f190"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"athanatos","id":544782,"avatar_url":"https://avatars.githubusercontent.com/u/544782?v=3","gravatar_id":"","url":"https://api.github.com/users/athanatos","html_url":"https://github.com/athanatos","followers_url":"https://api.github.com/users/athanatos/followers","following_url":"https://api.github.com/users/athanatos/following{/other_user}","gists_url":"https://api.github.com/users/athanatos/gists{/gist_id}","starred_url":"https://api.github.com/users/athanatos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/athanatos/subscriptions","organizations_url":"https://api.github.com/users/athanatos/orgs","repos_url":"https://api.github.com/users/athanatos/repos","events_url":"https://api.github.com/users/athanatos/events{/privacy}","received_events_url":"https://api.github.com/users/athanatos/received_events","type":"User","site_admin":false},"comments":6,"review_comments":1,"commits":1,"additions":12,"deletions":11,"changed_files":1}}