{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/26823912","id":26823912,"diff_hunk":"@@ -384,10 +384,13 @@ static void ProcessTriangleInternal(const VertexShader::OutputVertex& v0,\n \n                 auto GetSource = [&](Source source) -> Math::Vec4<u8> {\n                     switch (source) {\n-                    // TODO: What's the difference between these two?\n+                    // TODO: Implement fragment lighting. The following is a bunch of hacks.\n                     case Source::PrimaryColor:\n                     case Source::PrimaryFragmentColor:\n                         return primary_color;\n+                    \n+                    case Source::SecondaryFragmentColor:\n+                        return 0;","path":"src/video_core/rasterizer.cpp","position":11,"original_position":11,"commit_id":"cc8599e8f183a2b08a1320d474cffc5526e4253b","original_commit_id":"cc8599e8f183a2b08a1320d474cffc5526e4253b","user":{"login":"Normmatt","id":564191,"avatar_url":"https://avatars.githubusercontent.com/u/564191?v=3","gravatar_id":"","url":"https://api.github.com/users/Normmatt","html_url":"https://github.com/Normmatt","followers_url":"https://api.github.com/users/Normmatt/followers","following_url":"https://api.github.com/users/Normmatt/following{/other_user}","gists_url":"https://api.github.com/users/Normmatt/gists{/gist_id}","starred_url":"https://api.github.com/users/Normmatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Normmatt/subscriptions","organizations_url":"https://api.github.com/users/Normmatt/orgs","repos_url":"https://api.github.com/users/Normmatt/repos","events_url":"https://api.github.com/users/Normmatt/events{/privacy}","received_events_url":"https://api.github.com/users/Normmatt/received_events","type":"User","site_admin":false},"body":"shouldn't this return {} like in the default case?","created_at":"2015-03-20T08:11:13Z","updated_at":"2015-03-20T08:11:13Z","html_url":"https://github.com/citra-emu/citra/pull/666#discussion_r26823912","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/666","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/26823912"},"html":{"href":"https://github.com/citra-emu/citra/pull/666#discussion_r26823912"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/666"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/666","id":31492170,"html_url":"https://github.com/citra-emu/citra/pull/666","diff_url":"https://github.com/citra-emu/citra/pull/666.diff","patch_url":"https://github.com/citra-emu/citra/pull/666.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/666","number":666,"state":"open","locked":false,"title":"Pica/Rasterizer: Add SecondaryFragmentColor","user":{"login":"MoochMcGee","id":956763,"avatar_url":"https://avatars.githubusercontent.com/u/956763?v=3","gravatar_id":"","url":"https://api.github.com/users/MoochMcGee","html_url":"https://github.com/MoochMcGee","followers_url":"https://api.github.com/users/MoochMcGee/followers","following_url":"https://api.github.com/users/MoochMcGee/following{/other_user}","gists_url":"https://api.github.com/users/MoochMcGee/gists{/gist_id}","starred_url":"https://api.github.com/users/MoochMcGee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoochMcGee/subscriptions","organizations_url":"https://api.github.com/users/MoochMcGee/orgs","repos_url":"https://api.github.com/users/MoochMcGee/repos","events_url":"https://api.github.com/users/MoochMcGee/events{/privacy}","received_events_url":"https://api.github.com/users/MoochMcGee/received_events","type":"User","site_admin":false},"body":"Verified with the Dragon Quest 7 warning screen.\r\n\r\n![dq7_screen_1](https://cloud.githubusercontent.com/assets/956763/6680208/27fd12da-cc22-11e4-83fb-b168fef071c9.png)\r\n","created_at":"2015-03-19T03:10:25Z","updated_at":"2015-03-20T08:11:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fda757cc592d0c311c84026cdf42a58348cd0107","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/666/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/666/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/666/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/cc8599e8f183a2b08a1320d474cffc5526e4253b","head":{"label":"MoochMcGee:fragment-shit","ref":"fragment-shit","sha":"cc8599e8f183a2b08a1320d474cffc5526e4253b","user":{"login":"MoochMcGee","id":956763,"avatar_url":"https://avatars.githubusercontent.com/u/956763?v=3","gravatar_id":"","url":"https://api.github.com/users/MoochMcGee","html_url":"https://github.com/MoochMcGee","followers_url":"https://api.github.com/users/MoochMcGee/followers","following_url":"https://api.github.com/users/MoochMcGee/following{/other_user}","gists_url":"https://api.github.com/users/MoochMcGee/gists{/gist_id}","starred_url":"https://api.github.com/users/MoochMcGee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoochMcGee/subscriptions","organizations_url":"https://api.github.com/users/MoochMcGee/orgs","repos_url":"https://api.github.com/users/MoochMcGee/repos","events_url":"https://api.github.com/users/MoochMcGee/events{/privacy}","received_events_url":"https://api.github.com/users/MoochMcGee/received_events","type":"User","site_admin":false},"repo":{"id":29442738,"name":"citra","full_name":"MoochMcGee/citra","owner":{"login":"MoochMcGee","id":956763,"avatar_url":"https://avatars.githubusercontent.com/u/956763?v=3","gravatar_id":"","url":"https://api.github.com/users/MoochMcGee","html_url":"https://github.com/MoochMcGee","followers_url":"https://api.github.com/users/MoochMcGee/followers","following_url":"https://api.github.com/users/MoochMcGee/following{/other_user}","gists_url":"https://api.github.com/users/MoochMcGee/gists{/gist_id}","starred_url":"https://api.github.com/users/MoochMcGee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MoochMcGee/subscriptions","organizations_url":"https://api.github.com/users/MoochMcGee/orgs","repos_url":"https://api.github.com/users/MoochMcGee/repos","events_url":"https://api.github.com/users/MoochMcGee/events{/privacy}","received_events_url":"https://api.github.com/users/MoochMcGee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MoochMcGee/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/MoochMcGee/citra","forks_url":"https://api.github.com/repos/MoochMcGee/citra/forks","keys_url":"https://api.github.com/repos/MoochMcGee/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MoochMcGee/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MoochMcGee/citra/teams","hooks_url":"https://api.github.com/repos/MoochMcGee/citra/hooks","issue_events_url":"https://api.github.com/repos/MoochMcGee/citra/issues/events{/number}","events_url":"https://api.github.com/repos/MoochMcGee/citra/events","assignees_url":"https://api.github.com/repos/MoochMcGee/citra/assignees{/user}","branches_url":"https://api.github.com/repos/MoochMcGee/citra/branches{/branch}","tags_url":"https://api.github.com/repos/MoochMcGee/citra/tags","blobs_url":"https://api.github.com/repos/MoochMcGee/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MoochMcGee/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MoochMcGee/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/MoochMcGee/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MoochMcGee/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/MoochMcGee/citra/languages","stargazers_url":"https://api.github.com/repos/MoochMcGee/citra/stargazers","contributors_url":"https://api.github.com/repos/MoochMcGee/citra/contributors","subscribers_url":"https://api.github.com/repos/MoochMcGee/citra/subscribers","subscription_url":"https://api.github.com/repos/MoochMcGee/citra/subscription","commits_url":"https://api.github.com/repos/MoochMcGee/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/MoochMcGee/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/MoochMcGee/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/MoochMcGee/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/MoochMcGee/citra/contents/{+path}","compare_url":"https://api.github.com/repos/MoochMcGee/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MoochMcGee/citra/merges","archive_url":"https://api.github.com/repos/MoochMcGee/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MoochMcGee/citra/downloads","issues_url":"https://api.github.com/repos/MoochMcGee/citra/issues{/number}","pulls_url":"https://api.github.com/repos/MoochMcGee/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/MoochMcGee/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/MoochMcGee/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MoochMcGee/citra/labels{/name}","releases_url":"https://api.github.com/repos/MoochMcGee/citra/releases{/id}","created_at":"2015-01-18T21:59:17Z","updated_at":"2015-03-17T01:58:00Z","pushed_at":"2015-03-17T02:04:43Z","git_url":"git://github.com/MoochMcGee/citra.git","ssh_url":"git@github.com:MoochMcGee/citra.git","clone_url":"https://github.com/MoochMcGee/citra.git","svn_url":"https://github.com/MoochMcGee/citra","homepage":null,"size":8094,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"df71ed194d041e01878636cf7939a29b6e14f56b","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-03-20T01:37:44Z","pushed_at":"2015-03-20T06:20:14Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":20292,"stargazers_count":686,"watchers_count":686,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":174,"mirror_url":null,"open_issues_count":45,"forks":174,"open_issues":45,"watchers":686,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/666"},"html":{"href":"https://github.com/citra-emu/citra/pull/666"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/666"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/666/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/666/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/666/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/cc8599e8f183a2b08a1320d474cffc5526e4253b"}}}}