{"action":"closed","number":3421,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/3421","id":38476982,"html_url":"https://github.com/openshift/origin/pull/3421","diff_url":"https://github.com/openshift/origin/pull/3421.diff","patch_url":"https://github.com/openshift/origin/pull/3421.patch","issue_url":"https://api.github.com/repos/openshift/origin/issues/3421","number":3421,"state":"closed","locked":false,"title":"[WIP][DO_NOT_MERGE] Issue 2881: osc-key-values directive layout wrapping issues on browser resize","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"body":"This is meant to initially address [Issue 2881](https://github.com/openshift/origin/issues/2881), but also includes some thoughts on flexbox usage in general.\r\n\r\n* Expands flexbox utilities in _flexbox.less\r\n* updates osc-key-values.html directive view to handle resize more gracefully\r\n\r\n@spadgett @liggitt and anyone else interested in css/flex discussion!\r\n\r\nI expanded on _flexbox.less a bit, adding some additional utilities for describing layout in html.  The additional css is inspired by the layout frameworks in the [Angular Material](https://material.angularjs.org/latest/#/layout/grid) & [Polymer](https://www.polymer-project.org/0.5/docs/polymer/layout-attrs.html) projects.  Both use attribute selectors for layout (rather than classes) which makes it easier to reason about & change the markup.  The idea is something like \"attributes for layout, classes for look/feel\".  Check out the files changed & feel free to share any thoughts. Thanks!\r\n\r\nQuick example, simplified to show how flex layout attrs can be used:\r\n\r\n```html\r\n<div layout row reverse align-items=\"center\">\r\n  <div flex>flex foo</div>\r\n  <div layout column>\r\n    <div flex grow=\"2\" shrink=\"2\">flex bar</div>\r\n    <div>no flex baz</div>\r\n  </div>\r\n  <div>no flex.</div>\r\n</div>\r\n```\r\n\r\n(This pull request is not yet ready, I have a few more items to address, but wanted to get some feedback early.  Also, I'll have to update my html formatting before the final, I tend to have aggressively short line lengths.) \r\n","created_at":"2015-06-24T19:15:44Z","updated_at":"2015-06-25T17:43:38Z","closed_at":"2015-06-25T17:43:37Z","merged_at":null,"merge_commit_sha":"e9de1ad3c684f02910b5689ed7561f00f1281be0","assignee":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars.githubusercontent.com/u/1167259?v=3","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin/pulls/3421/commits","review_comments_url":"https://api.github.com/repos/openshift/origin/pulls/3421/comments","review_comment_url":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin/issues/3421/comments","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/ccbefa552d8205730ba65ed6a369c6780886ce78","head":{"label":"benjaminapetersen:bpeterse/bug/2881","ref":"bpeterse/bug/2881","sha":"ccbefa552d8205730ba65ed6a369c6780886ce78","user":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"repo":{"id":37674696,"name":"origin","full_name":"benjaminapetersen/origin","owner":{"login":"benjaminapetersen","id":280512,"avatar_url":"https://avatars.githubusercontent.com/u/280512?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benjaminapetersen/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":true,"url":"https://api.github.com/repos/benjaminapetersen/origin","forks_url":"https://api.github.com/repos/benjaminapetersen/origin/forks","keys_url":"https://api.github.com/repos/benjaminapetersen/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benjaminapetersen/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benjaminapetersen/origin/teams","hooks_url":"https://api.github.com/repos/benjaminapetersen/origin/hooks","issue_events_url":"https://api.github.com/repos/benjaminapetersen/origin/issues/events{/number}","events_url":"https://api.github.com/repos/benjaminapetersen/origin/events","assignees_url":"https://api.github.com/repos/benjaminapetersen/origin/assignees{/user}","branches_url":"https://api.github.com/repos/benjaminapetersen/origin/branches{/branch}","tags_url":"https://api.github.com/repos/benjaminapetersen/origin/tags","blobs_url":"https://api.github.com/repos/benjaminapetersen/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benjaminapetersen/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benjaminapetersen/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/benjaminapetersen/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benjaminapetersen/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/benjaminapetersen/origin/languages","stargazers_url":"https://api.github.com/repos/benjaminapetersen/origin/stargazers","contributors_url":"https://api.github.com/repos/benjaminapetersen/origin/contributors","subscribers_url":"https://api.github.com/repos/benjaminapetersen/origin/subscribers","subscription_url":"https://api.github.com/repos/benjaminapetersen/origin/subscription","commits_url":"https://api.github.com/repos/benjaminapetersen/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/benjaminapetersen/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/benjaminapetersen/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/benjaminapetersen/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/benjaminapetersen/origin/contents/{+path}","compare_url":"https://api.github.com/repos/benjaminapetersen/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benjaminapetersen/origin/merges","archive_url":"https://api.github.com/repos/benjaminapetersen/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benjaminapetersen/origin/downloads","issues_url":"https://api.github.com/repos/benjaminapetersen/origin/issues{/number}","pulls_url":"https://api.github.com/repos/benjaminapetersen/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/benjaminapetersen/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/benjaminapetersen/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benjaminapetersen/origin/labels{/name}","releases_url":"https://api.github.com/repos/benjaminapetersen/origin/releases{/id}","created_at":"2015-06-18T17:38:49Z","updated_at":"2015-06-18T17:38:52Z","pushed_at":"2015-06-25T17:43:37Z","git_url":"git://github.com/benjaminapetersen/origin.git","ssh_url":"git@github.com:benjaminapetersen/origin.git","clone_url":"https://github.com/benjaminapetersen/origin.git","svn_url":"https://github.com/benjaminapetersen/origin","homepage":"http://www.openshift.org","size":116910,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"d02b4572bbbfba4f989e8f6f5c6fa1b92268a901","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":22442668,"name":"origin","full_name":"openshift/origin","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin","description":"OpenShift 3 - build, deploy, and manage your applications with Docker and Kubernetes","fork":false,"url":"https://api.github.com/repos/openshift/origin","forks_url":"https://api.github.com/repos/openshift/origin/forks","keys_url":"https://api.github.com/repos/openshift/origin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin/teams","hooks_url":"https://api.github.com/repos/openshift/origin/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin/events","assignees_url":"https://api.github.com/repos/openshift/origin/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin/tags","blobs_url":"https://api.github.com/repos/openshift/origin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin/languages","stargazers_url":"https://api.github.com/repos/openshift/origin/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin/subscription","commits_url":"https://api.github.com/repos/openshift/origin/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin/merges","archive_url":"https://api.github.com/repos/openshift/origin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin/downloads","issues_url":"https://api.github.com/repos/openshift/origin/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin/releases{/id}","created_at":"2014-07-30T20:04:05Z","updated_at":"2015-06-25T17:05:55Z","pushed_at":"2015-06-25T16:50:29Z","git_url":"git://github.com/openshift/origin.git","ssh_url":"git@github.com:openshift/origin.git","clone_url":"https://github.com/openshift/origin.git","svn_url":"https://github.com/openshift/origin","homepage":"http://www.openshift.org","size":183379,"stargazers_count":495,"watchers_count":495,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":385,"forks":259,"open_issues":385,"watchers":495,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin/pulls/3421"},"html":{"href":"https://github.com/openshift/origin/pull/3421"},"issue":{"href":"https://api.github.com/repos/openshift/origin/issues/3421"},"comments":{"href":"https://api.github.com/repos/openshift/origin/issues/3421/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin/pulls/3421/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin/pulls/3421/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin/statuses/ccbefa552d8205730ba65ed6a369c6780886ce78"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":6,"review_comments":8,"commits":1,"additions":295,"deletions":42,"changed_files":2}}