{"action":"created","issue":{"url":"https://api.github.com/repos/acemod/ACE3/issues/1598","labels_url":"https://api.github.com/repos/acemod/ACE3/issues/1598/labels{/name}","comments_url":"https://api.github.com/repos/acemod/ACE3/issues/1598/comments","events_url":"https://api.github.com/repos/acemod/ACE3/issues/1598/events","html_url":"https://github.com/acemod/ACE3/pull/1598","id":87923934,"number":1598,"title":"Fix Server not reading modules","user":{"login":"PabstMirror","id":9376747,"avatar_url":"https://avatars.githubusercontent.com/u/9376747?v=3","gravatar_id":"","url":"https://api.github.com/users/PabstMirror","html_url":"https://github.com/PabstMirror","followers_url":"https://api.github.com/users/PabstMirror/followers","following_url":"https://api.github.com/users/PabstMirror/following{/other_user}","gists_url":"https://api.github.com/users/PabstMirror/gists{/gist_id}","starred_url":"https://api.github.com/users/PabstMirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PabstMirror/subscriptions","organizations_url":"https://api.github.com/users/PabstMirror/orgs","repos_url":"https://api.github.com/users/PabstMirror/repos","events_url":"https://api.github.com/users/PabstMirror/events{/privacy}","received_events_url":"https://api.github.com/users/PabstMirror/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/acemod/ACE3/labels/Bug%20fix","name":"Bug fix","color":"009800"}],"state":"closed","locked":false,"assignee":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/acemod/ACE3/milestones/3","html_url":"https://github.com/acemod/ACE3/milestones/3.1.0","labels_url":"https://api.github.com/repos/acemod/ACE3/milestones/3/labels","id":959656,"number":3,"title":"3.1.0","description":"","creator":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"open_issues":27,"closed_issues":272,"state":"open","created_at":"2015-01-31T19:41:24Z","updated_at":"2015-06-13T15:16:36Z","due_on":"2015-06-05T07:00:00Z","closed_at":null},"comments":3,"created_at":"2015-06-13T04:07:45Z","updated_at":"2015-06-13T15:22:26Z","closed_at":"2015-06-13T15:01:22Z","pull_request":{"url":"https://api.github.com/repos/acemod/ACE3/pulls/1598","html_url":"https://github.com/acemod/ACE3/pull/1598","diff_url":"https://github.com/acemod/ACE3/pull/1598.diff","patch_url":"https://github.com/acemod/ACE3/pull/1598.patch"},"body":"Critical:\r\n`InitSettingsFromModules` in only called from a PFEH bellow `if (!hasInterface) exitWith {};`,\r\nso dedicated servers never read modules.\r\n\r\n\r\nAlso, fixes a possible issue where the server has synced GVAR(settings), but not finished syncing all the modules.  Clients could raise `SettingsInitialized` before all module setting have been recieved.  Server now sets a bool publicVariable after reading all modules."},"comment":{"url":"https://api.github.com/repos/acemod/ACE3/issues/comments/111719274","html_url":"https://github.com/acemod/ACE3/pull/1598#issuecomment-111719274","issue_url":"https://api.github.com/repos/acemod/ACE3/issues/1598","id":111719274,"user":{"login":"esteldunedain","id":7674951,"avatar_url":"https://avatars.githubusercontent.com/u/7674951?v=3","gravatar_id":"","url":"https://api.github.com/users/esteldunedain","html_url":"https://github.com/esteldunedain","followers_url":"https://api.github.com/users/esteldunedain/followers","following_url":"https://api.github.com/users/esteldunedain/following{/other_user}","gists_url":"https://api.github.com/users/esteldunedain/gists{/gist_id}","starred_url":"https://api.github.com/users/esteldunedain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteldunedain/subscriptions","organizations_url":"https://api.github.com/users/esteldunedain/orgs","repos_url":"https://api.github.com/users/esteldunedain/repos","events_url":"https://api.github.com/users/esteldunedain/events{/privacy}","received_events_url":"https://api.github.com/users/esteldunedain/received_events","type":"User","site_admin":false},"created_at":"2015-06-13T15:22:26Z","updated_at":"2015-06-13T15:22:26Z","body":"I've read it more carefully, and @PabstMirror addressed my concern already. Perfect!\r\n\r\nBottom line:\r\n\r\n1 - Server inits settings from config\r\n2 - Server inits modules\r\n3 - Clients launch the \"SettingsInitialized\" event locally when the above is ready and received.\r\n\r\nBrilliant!\""}}