{"action":"created","issue":{"url":"https://api.github.com/repos/bndtools/bnd/issues/927","labels_url":"https://api.github.com/repos/bndtools/bnd/issues/927/labels{/name}","comments_url":"https://api.github.com/repos/bndtools/bnd/issues/927/comments","events_url":"https://api.github.com/repos/bndtools/bnd/issues/927/events","html_url":"https://github.com/bndtools/bnd/issues/927","id":72491746,"number":927,"title":"Failed bndlib tests on windows","user":{"login":"marcdejonge","id":354901,"avatar_url":"https://avatars.githubusercontent.com/u/354901?v=3","gravatar_id":"","url":"https://api.github.com/users/marcdejonge","html_url":"https://github.com/marcdejonge","followers_url":"https://api.github.com/users/marcdejonge/followers","following_url":"https://api.github.com/users/marcdejonge/following{/other_user}","gists_url":"https://api.github.com/users/marcdejonge/gists{/gist_id}","starred_url":"https://api.github.com/users/marcdejonge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcdejonge/subscriptions","organizations_url":"https://api.github.com/users/marcdejonge/orgs","repos_url":"https://api.github.com/users/marcdejonge/repos","events_url":"https://api.github.com/users/marcdejonge/events{/privacy}","received_events_url":"https://api.github.com/users/marcdejonge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"pkriens","id":200494,"avatar_url":"https://avatars.githubusercontent.com/u/200494?v=3","gravatar_id":"","url":"https://api.github.com/users/pkriens","html_url":"https://github.com/pkriens","followers_url":"https://api.github.com/users/pkriens/followers","following_url":"https://api.github.com/users/pkriens/following{/other_user}","gists_url":"https://api.github.com/users/pkriens/gists{/gist_id}","starred_url":"https://api.github.com/users/pkriens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkriens/subscriptions","organizations_url":"https://api.github.com/users/pkriens/orgs","repos_url":"https://api.github.com/users/pkriens/repos","events_url":"https://api.github.com/users/pkriens/events{/privacy}","received_events_url":"https://api.github.com/users/pkriens/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/bndtools/bnd/milestones/11","html_url":"https://github.com/bndtools/bnd/milestones/3.0","labels_url":"https://api.github.com/repos/bndtools/bnd/milestones/11/labels","id":703667,"number":11,"title":"3.0","description":"3.0.0.REL","creator":{"login":"bjhargrave","id":277682,"avatar_url":"https://avatars.githubusercontent.com/u/277682?v=3","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":36,"state":"open","created_at":"2014-06-27T16:01:50Z","updated_at":"2015-06-01T08:06:01Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-05-01T18:28:44Z","updated_at":"2015-06-01T11:52:46Z","closed_at":null,"body":"There are a couple of failed tests when I run junit 3 on bndlib.tests.\r\n\r\nThere are 2 tests in `BuilderTest` that try to use the user path as an `URI` by doing:\r\n```\r\nnew URI(pwd).toString()\r\n```\r\nThis fails on a windows machine because a path such as `C:\\Users\\...` is not a valid URI. I will propose a quick fix for this\r\n\r\nThe second problem is a bit harder, but in involved the `CommandResource`. On [this line](https://github.com/bndtools/bnd/blob/master/biz.aQute.bndlib/src/aQute/bnd/osgi/CommandResource.java#L25) the command `sh` in invoked, which of course will never work on a normal windows machine (without cygwin or someting similar). Because of this there are 3 tests in `ResourceTest` that fail.\r\n\r\nShould the `CommandResource` ever work on a Windows machine? Or should we just ignore these? In that case I do propose that we give a clear warning when the `CommandResource` is used on a windows machine that this won't work."},"comment":{"url":"https://api.github.com/repos/bndtools/bnd/issues/comments/107414716","html_url":"https://github.com/bndtools/bnd/issues/927#issuecomment-107414716","issue_url":"https://api.github.com/repos/bndtools/bnd/issues/927","id":107414716,"user":{"login":"bjhargrave","id":277682,"avatar_url":"https://avatars.githubusercontent.com/u/277682?v=3","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"created_at":"2015-06-01T11:52:46Z","updated_at":"2015-06-01T11:52:46Z","body":"Why do we need to disable these tests? They seem to be passing in the appveyor CI builds.\r\n"}}