{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/40931967","id":40931967,"diff_hunk":"@@ -0,0 +1,43 @@\n+# Copyright (C) 2014 SUSE Linux Products GmbH","path":"lib/OpenQA/Schema/Result/GruDependencies.pm","position":1,"original_position":1,"commit_id":"c2f680c422ccdec5a23caf17bf27696e27bfb030","original_commit_id":"c2f680c422ccdec5a23caf17bf27696e27bfb030","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"body":"heh, I actually was genuinely not sure what to do about that :) i guess add a Red Hat line and bump both to 2015?","created_at":"2015-10-01T16:06:59Z","updated_at":"2015-10-01T16:06:59Z","html_url":"https://github.com/os-autoinst/openQA/pull/426#discussion_r40931967","pull_request_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/426","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments/40931967"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/426#discussion_r40931967"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/openQA/pulls/426","id":43098999,"html_url":"https://github.com/os-autoinst/openQA/pull/426","diff_url":"https://github.com/os-autoinst/openQA/pull/426.diff","patch_url":"https://github.com/os-autoinst/openQA/pull/426.patch","issue_url":"https://api.github.com/repos/os-autoinst/openQA/issues/426","number":426,"state":"open","locked":false,"title":"allow ISO to be a URL, download if needed","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"body":"This is an extremely stupid PoC implementation; it blocks the\r\nPOST request until the download is done, which likely isn't\r\nwhat we want. But for some value of 'work', it does work: when\r\nI tried it, the 'client' command returned some ERROR, but the\r\nISO was downloaded and the job scheduled and ran successfully.\r\n\r\nI think a sane implementation might use this 'GRU' thing I'm\r\nnow trying to grok. It might look something like 'create the\r\njobs, tell the GRU to download the ISO and notify workers when\r\nit's done, return job IDs'. It occurs to me that might be\r\nrather racy, though - if any other job-create-y type thing\r\nhappens while the ISO is downloading, workers will presumably\r\ntry and pick up the jobs and Bad Stuff will happen.\r\n\r\nPerhaps jobs should have some kind of 'not ready yet' attribute\r\nwhich workers could look for, and skip if it's set? Perhaps\r\nthey already do and I don't know about it?\r\n\r\nThis is probably also some kind of security hole if you don't\r\ntrust people who are authorized to run POSTs, but I think the\r\ndesign is broadly that only trusted people should be allowed\r\nto do that.\r\n\r\nComments welcome!\r\n\r\nedit: further thoughts: a proper implementation would of course also check if the ISO is already downloaded and skip the download if so, and I'd also want it to allow specifying a target name (because Fedora has hilarious collisions for `boot.iso`); have to figure the best way to allow that. If the way to do this is through the GRU, it should also presumably be able to delete the jobs if it can't manage to download the ISO.","created_at":"2015-08-22T06:56:05Z","updated_at":"2015-10-01T16:06:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fbc0e0a10c9144612c138a7bc417087532ab67d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/426/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/426/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/issues/426/comments","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/c2f680c422ccdec5a23caf17bf27696e27bfb030","head":{"label":"AdamWill:download-iso","ref":"download-iso","sha":"c2f680c422ccdec5a23caf17bf27696e27bfb030","user":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"repo":{"id":31450875,"name":"openQA","full_name":"AdamWill/openQA","owner":{"login":"AdamWill","id":916551,"avatar_url":"https://avatars.githubusercontent.com/u/916551?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamWill","html_url":"https://github.com/AdamWill","followers_url":"https://api.github.com/users/AdamWill/followers","following_url":"https://api.github.com/users/AdamWill/following{/other_user}","gists_url":"https://api.github.com/users/AdamWill/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamWill/subscriptions","organizations_url":"https://api.github.com/users/AdamWill/orgs","repos_url":"https://api.github.com/users/AdamWill/repos","events_url":"https://api.github.com/users/AdamWill/events{/privacy}","received_events_url":"https://api.github.com/users/AdamWill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AdamWill/openQA","description":"openQA web-frontend, scheduler and tools","fork":true,"url":"https://api.github.com/repos/AdamWill/openQA","forks_url":"https://api.github.com/repos/AdamWill/openQA/forks","keys_url":"https://api.github.com/repos/AdamWill/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AdamWill/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AdamWill/openQA/teams","hooks_url":"https://api.github.com/repos/AdamWill/openQA/hooks","issue_events_url":"https://api.github.com/repos/AdamWill/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/AdamWill/openQA/events","assignees_url":"https://api.github.com/repos/AdamWill/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/AdamWill/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/AdamWill/openQA/tags","blobs_url":"https://api.github.com/repos/AdamWill/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AdamWill/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AdamWill/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/AdamWill/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AdamWill/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/AdamWill/openQA/languages","stargazers_url":"https://api.github.com/repos/AdamWill/openQA/stargazers","contributors_url":"https://api.github.com/repos/AdamWill/openQA/contributors","subscribers_url":"https://api.github.com/repos/AdamWill/openQA/subscribers","subscription_url":"https://api.github.com/repos/AdamWill/openQA/subscription","commits_url":"https://api.github.com/repos/AdamWill/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/AdamWill/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/AdamWill/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/AdamWill/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/AdamWill/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/AdamWill/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AdamWill/openQA/merges","archive_url":"https://api.github.com/repos/AdamWill/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AdamWill/openQA/downloads","issues_url":"https://api.github.com/repos/AdamWill/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/AdamWill/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/AdamWill/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/AdamWill/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AdamWill/openQA/labels{/name}","releases_url":"https://api.github.com/repos/AdamWill/openQA/releases{/id}","created_at":"2015-02-28T04:25:25Z","updated_at":"2015-05-05T23:19:10Z","pushed_at":"2015-09-30T02:58:30Z","git_url":"git://github.com/AdamWill/openQA.git","ssh_url":"git@github.com:AdamWill/openQA.git","clone_url":"https://github.com/AdamWill/openQA.git","svn_url":"https://github.com/AdamWill/openQA","homepage":"http://openqa.opensuse.org/","size":13765,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"cc82053fba7c96984f552ebb5fda77dbe4b708a2","user":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":20883829,"name":"openQA","full_name":"os-autoinst/openQA","owner":{"login":"os-autoinst","id":6918706,"avatar_url":"https://avatars.githubusercontent.com/u/6918706?v=3","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/os-autoinst/openQA","description":"openQA web-frontend, scheduler and tools","fork":false,"url":"https://api.github.com/repos/os-autoinst/openQA","forks_url":"https://api.github.com/repos/os-autoinst/openQA/forks","keys_url":"https://api.github.com/repos/os-autoinst/openQA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/openQA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/openQA/teams","hooks_url":"https://api.github.com/repos/os-autoinst/openQA/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/openQA/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/openQA/events","assignees_url":"https://api.github.com/repos/os-autoinst/openQA/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/openQA/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/openQA/tags","blobs_url":"https://api.github.com/repos/os-autoinst/openQA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/openQA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/openQA/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/openQA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/openQA/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/openQA/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/openQA/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/openQA/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/openQA/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/openQA/subscription","commits_url":"https://api.github.com/repos/os-autoinst/openQA/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/openQA/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/openQA/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/openQA/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/openQA/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/openQA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/openQA/merges","archive_url":"https://api.github.com/repos/os-autoinst/openQA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/openQA/downloads","issues_url":"https://api.github.com/repos/os-autoinst/openQA/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/openQA/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/openQA/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/openQA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/openQA/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/openQA/releases{/id}","created_at":"2014-06-16T12:23:22Z","updated_at":"2015-09-29T01:30:01Z","pushed_at":"2015-09-30T03:01:22Z","git_url":"git://github.com/os-autoinst/openQA.git","ssh_url":"git@github.com:os-autoinst/openQA.git","clone_url":"https://github.com/os-autoinst/openQA.git","svn_url":"https://github.com/os-autoinst/openQA","homepage":"http://openqa.opensuse.org/","size":17617,"stargazers_count":23,"watchers_count":23,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":9,"forks":26,"open_issues":9,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/426"},"html":{"href":"https://github.com/os-autoinst/openQA/pull/426"},"issue":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/426"},"comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/openQA/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/openQA/statuses/c2f680c422ccdec5a23caf17bf27696e27bfb030"}}}}