{"action":"created","comment":{"url":"https://api.github.com/repos/progrium/dokku/pulls/comments/39913139","id":39913139,"diff_hunk":"@@ -214,6 +214,7 @@ config_unset() {\n     ENV_TEMP=$(echo \"${ENV_TEMP}\" | sed \"/^export $var=/ d\")\n \n     config_write \"$ENV_TEMP\"\n+    [[ \"$var\" == \"NO_VHOST\" ]] && config_set --no-restart $APP NO_VHOST=0 && DOKKU_CONFIG_RESTART=true","path":"plugins/config/functions","position":4,"original_position":4,"commit_id":"08418db8991a463a99771b749a7750867614091b","original_commit_id":"08418db8991a463a99771b749a7750867614091b","user":{"login":"josegonzalez","id":65675,"avatar_url":"https://avatars.githubusercontent.com/u/65675?v=3","gravatar_id":"","url":"https://api.github.com/users/josegonzalez","html_url":"https://github.com/josegonzalez","followers_url":"https://api.github.com/users/josegonzalez/followers","following_url":"https://api.github.com/users/josegonzalez/following{/other_user}","gists_url":"https://api.github.com/users/josegonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/josegonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josegonzalez/subscriptions","organizations_url":"https://api.github.com/users/josegonzalez/orgs","repos_url":"https://api.github.com/users/josegonzalez/repos","events_url":"https://api.github.com/users/josegonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/josegonzalez/received_events","type":"User","site_admin":false},"body":"Why `DOKKU_CONFIG_RESTART=true` here?","created_at":"2015-09-19T00:29:42Z","updated_at":"2015-09-19T00:29:42Z","html_url":"https://github.com/progrium/dokku/pull/1476#discussion_r39913139","pull_request_url":"https://api.github.com/repos/progrium/dokku/pulls/1476","_links":{"self":{"href":"https://api.github.com/repos/progrium/dokku/pulls/comments/39913139"},"html":{"href":"https://github.com/progrium/dokku/pull/1476#discussion_r39913139"},"pull_request":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1476"}}},"pull_request":{"url":"https://api.github.com/repos/progrium/dokku/pulls/1476","id":45362591,"html_url":"https://github.com/progrium/dokku/pull/1476","diff_url":"https://github.com/progrium/dokku/pull/1476.diff","patch_url":"https://github.com/progrium/dokku/pull/1476.patch","issue_url":"https://api.github.com/repos/progrium/dokku/issues/1476","number":1476,"state":"open","locked":false,"title":"nginx proxy without VHOST","user":{"login":"michaelshobbs","id":4491438,"avatar_url":"https://avatars.githubusercontent.com/u/4491438?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelshobbs","html_url":"https://github.com/michaelshobbs","followers_url":"https://api.github.com/users/michaelshobbs/followers","following_url":"https://api.github.com/users/michaelshobbs/following{/other_user}","gists_url":"https://api.github.com/users/michaelshobbs/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelshobbs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelshobbs/subscriptions","organizations_url":"https://api.github.com/users/michaelshobbs/orgs","repos_url":"https://api.github.com/users/michaelshobbs/repos","events_url":"https://api.github.com/users/michaelshobbs/events{/privacy}","received_events_url":"https://api.github.com/users/michaelshobbs/received_events","type":"User","site_admin":false},"body":"closes #1123 #1474 \r\n\r\nexample output with no `$DOKKU_ROOT/VHOST` and an IP in `$DOKKU_ROOT/HOSTNAME` (also can be accomplished by setting `NO_VHOST=1`) \r\nnote: we always use the contents of `$DOKKU_ROOT/HOSTNAME` for urls output in the aforementioned cases\r\n\r\n```\r\n$ git push dokku@dokku.me:node-js-app master\r\nPseudo-terminal will not be allocated because stdin is not a terminal.\r\nCounting objects: 454, done.\r\nDelta compression using up to 8 threads.\r\nCompressing objects: 100% (365/365), done.\r\nWriting objects: 100% (454/454), 218.70 KiB | 0 bytes/s, done.\r\nTotal 454 (delta 79), reused 391 (delta 51)\r\n-----> Cleaning up...\r\n-----> Building node-js-app from herokuish...\r\n-----> Fetching custom buildpack\r\n-----> Node.js app detected\r\n...\r\n-----> All checks successful!\r\n=====> node-js-app container output:\r\n       Node app is running at localhost:5000\r\n=====> end node-js-app container output\r\n-----> Running post-deploy\r\n=====> unsupported vhost config found. disabling vhost support\r\n-----> Setting config vars\r\n       NO_VHOST: 1\r\n-----> no nginx port set. setting to random open high port\r\n-----> Setting config vars\r\n       DOKKU_NGINX_PORT: 22578\r\n-----> Creating http nginx.conf\r\n-----> Running nginx-pre-reload\r\n       Reloading nginx\r\n=====> Application deployed:\r\n       http://10.0.0.2:32824 (container)\r\n       http://10.0.0.2:22578 (nginx)\r\n\r\nTo dokku@dokku.me:node-js-app\r\n * [new branch]      master -> master\r\n```","created_at":"2015-09-18T02:11:59Z","updated_at":"2015-09-19T00:29:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"208b3b2270b516edf43df8d4ec9691253908d08b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/progrium/dokku/pulls/1476/commits","review_comments_url":"https://api.github.com/repos/progrium/dokku/pulls/1476/comments","review_comment_url":"https://api.github.com/repos/progrium/dokku/pulls/comments{/number}","comments_url":"https://api.github.com/repos/progrium/dokku/issues/1476/comments","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/08418db8991a463a99771b749a7750867614091b","head":{"label":"progrium:1123_mh-nginx-novhost","ref":"1123_mh-nginx-novhost","sha":"08418db8991a463a99771b749a7750867614091b","user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"repo":{"id":10567197,"name":"dokku","full_name":"progrium/dokku","owner":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/progrium/dokku","description":"Docker powered mini-Heroku in around 100 lines of Bash","fork":false,"url":"https://api.github.com/repos/progrium/dokku","forks_url":"https://api.github.com/repos/progrium/dokku/forks","keys_url":"https://api.github.com/repos/progrium/dokku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/progrium/dokku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/progrium/dokku/teams","hooks_url":"https://api.github.com/repos/progrium/dokku/hooks","issue_events_url":"https://api.github.com/repos/progrium/dokku/issues/events{/number}","events_url":"https://api.github.com/repos/progrium/dokku/events","assignees_url":"https://api.github.com/repos/progrium/dokku/assignees{/user}","branches_url":"https://api.github.com/repos/progrium/dokku/branches{/branch}","tags_url":"https://api.github.com/repos/progrium/dokku/tags","blobs_url":"https://api.github.com/repos/progrium/dokku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/progrium/dokku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/progrium/dokku/git/refs{/sha}","trees_url":"https://api.github.com/repos/progrium/dokku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/{sha}","languages_url":"https://api.github.com/repos/progrium/dokku/languages","stargazers_url":"https://api.github.com/repos/progrium/dokku/stargazers","contributors_url":"https://api.github.com/repos/progrium/dokku/contributors","subscribers_url":"https://api.github.com/repos/progrium/dokku/subscribers","subscription_url":"https://api.github.com/repos/progrium/dokku/subscription","commits_url":"https://api.github.com/repos/progrium/dokku/commits{/sha}","git_commits_url":"https://api.github.com/repos/progrium/dokku/git/commits{/sha}","comments_url":"https://api.github.com/repos/progrium/dokku/comments{/number}","issue_comment_url":"https://api.github.com/repos/progrium/dokku/issues/comments{/number}","contents_url":"https://api.github.com/repos/progrium/dokku/contents/{+path}","compare_url":"https://api.github.com/repos/progrium/dokku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/progrium/dokku/merges","archive_url":"https://api.github.com/repos/progrium/dokku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/progrium/dokku/downloads","issues_url":"https://api.github.com/repos/progrium/dokku/issues{/number}","pulls_url":"https://api.github.com/repos/progrium/dokku/pulls{/number}","milestones_url":"https://api.github.com/repos/progrium/dokku/milestones{/number}","notifications_url":"https://api.github.com/repos/progrium/dokku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/progrium/dokku/labels{/name}","releases_url":"https://api.github.com/repos/progrium/dokku/releases{/id}","created_at":"2013-06-08T10:26:57Z","updated_at":"2015-09-18T20:06:32Z","pushed_at":"2015-09-19T00:28:42Z","git_url":"git://github.com/progrium/dokku.git","ssh_url":"git@github.com:progrium/dokku.git","clone_url":"https://github.com/progrium/dokku.git","svn_url":"https://github.com/progrium/dokku","homepage":"http://progrium.viewdocs.io/dokku","size":7975,"stargazers_count":10002,"watchers_count":10002,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":840,"mirror_url":null,"open_issues_count":20,"forks":840,"open_issues":20,"watchers":10002,"default_branch":"master"}},"base":{"label":"progrium:master","ref":"master","sha":"bf1349bec8e3db43c673f7891c27bcc18ee887d2","user":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"repo":{"id":10567197,"name":"dokku","full_name":"progrium/dokku","owner":{"login":"progrium","id":647,"avatar_url":"https://avatars.githubusercontent.com/u/647?v=3","gravatar_id":"","url":"https://api.github.com/users/progrium","html_url":"https://github.com/progrium","followers_url":"https://api.github.com/users/progrium/followers","following_url":"https://api.github.com/users/progrium/following{/other_user}","gists_url":"https://api.github.com/users/progrium/gists{/gist_id}","starred_url":"https://api.github.com/users/progrium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/progrium/subscriptions","organizations_url":"https://api.github.com/users/progrium/orgs","repos_url":"https://api.github.com/users/progrium/repos","events_url":"https://api.github.com/users/progrium/events{/privacy}","received_events_url":"https://api.github.com/users/progrium/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/progrium/dokku","description":"Docker powered mini-Heroku in around 100 lines of Bash","fork":false,"url":"https://api.github.com/repos/progrium/dokku","forks_url":"https://api.github.com/repos/progrium/dokku/forks","keys_url":"https://api.github.com/repos/progrium/dokku/keys{/key_id}","collaborators_url":"https://api.github.com/repos/progrium/dokku/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/progrium/dokku/teams","hooks_url":"https://api.github.com/repos/progrium/dokku/hooks","issue_events_url":"https://api.github.com/repos/progrium/dokku/issues/events{/number}","events_url":"https://api.github.com/repos/progrium/dokku/events","assignees_url":"https://api.github.com/repos/progrium/dokku/assignees{/user}","branches_url":"https://api.github.com/repos/progrium/dokku/branches{/branch}","tags_url":"https://api.github.com/repos/progrium/dokku/tags","blobs_url":"https://api.github.com/repos/progrium/dokku/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/progrium/dokku/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/progrium/dokku/git/refs{/sha}","trees_url":"https://api.github.com/repos/progrium/dokku/git/trees{/sha}","statuses_url":"https://api.github.com/repos/progrium/dokku/statuses/{sha}","languages_url":"https://api.github.com/repos/progrium/dokku/languages","stargazers_url":"https://api.github.com/repos/progrium/dokku/stargazers","contributors_url":"https://api.github.com/repos/progrium/dokku/contributors","subscribers_url":"https://api.github.com/repos/progrium/dokku/subscribers","subscription_url":"https://api.github.com/repos/progrium/dokku/subscription","commits_url":"https://api.github.com/repos/progrium/dokku/commits{/sha}","git_commits_url":"https://api.github.com/repos/progrium/dokku/git/commits{/sha}","comments_url":"https://api.github.com/repos/progrium/dokku/comments{/number}","issue_comment_url":"https://api.github.com/repos/progrium/dokku/issues/comments{/number}","contents_url":"https://api.github.com/repos/progrium/dokku/contents/{+path}","compare_url":"https://api.github.com/repos/progrium/dokku/compare/{base}...{head}","merges_url":"https://api.github.com/repos/progrium/dokku/merges","archive_url":"https://api.github.com/repos/progrium/dokku/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/progrium/dokku/downloads","issues_url":"https://api.github.com/repos/progrium/dokku/issues{/number}","pulls_url":"https://api.github.com/repos/progrium/dokku/pulls{/number}","milestones_url":"https://api.github.com/repos/progrium/dokku/milestones{/number}","notifications_url":"https://api.github.com/repos/progrium/dokku/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/progrium/dokku/labels{/name}","releases_url":"https://api.github.com/repos/progrium/dokku/releases{/id}","created_at":"2013-06-08T10:26:57Z","updated_at":"2015-09-18T20:06:32Z","pushed_at":"2015-09-19T00:28:42Z","git_url":"git://github.com/progrium/dokku.git","ssh_url":"git@github.com:progrium/dokku.git","clone_url":"https://github.com/progrium/dokku.git","svn_url":"https://github.com/progrium/dokku","homepage":"http://progrium.viewdocs.io/dokku","size":7975,"stargazers_count":10002,"watchers_count":10002,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":840,"mirror_url":null,"open_issues_count":20,"forks":840,"open_issues":20,"watchers":10002,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1476"},"html":{"href":"https://github.com/progrium/dokku/pull/1476"},"issue":{"href":"https://api.github.com/repos/progrium/dokku/issues/1476"},"comments":{"href":"https://api.github.com/repos/progrium/dokku/issues/1476/comments"},"review_comments":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1476/comments"},"review_comment":{"href":"https://api.github.com/repos/progrium/dokku/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/progrium/dokku/pulls/1476/commits"},"statuses":{"href":"https://api.github.com/repos/progrium/dokku/statuses/08418db8991a463a99771b749a7750867614091b"}}}}