{"action":"created","issue":{"url":"https://api.github.com/repos/DICE-UNC/irods-webdav/issues/5","labels_url":"https://api.github.com/repos/DICE-UNC/irods-webdav/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/DICE-UNC/irods-webdav/issues/5/comments","events_url":"https://api.github.com/repos/DICE-UNC/irods-webdav/issues/5/events","html_url":"https://github.com/DICE-UNC/irods-webdav/pull/5","id":59468084,"number":5,"title":"Fix basic auth rejecting passwords containing colons","user":{"login":"cjsmeele","id":2670982,"avatar_url":"https://avatars.githubusercontent.com/u/2670982?v=3","gravatar_id":"","url":"https://api.github.com/users/cjsmeele","html_url":"https://github.com/cjsmeele","followers_url":"https://api.github.com/users/cjsmeele/followers","following_url":"https://api.github.com/users/cjsmeele/following{/other_user}","gists_url":"https://api.github.com/users/cjsmeele/gists{/gist_id}","starred_url":"https://api.github.com/users/cjsmeele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjsmeele/subscriptions","organizations_url":"https://api.github.com/users/cjsmeele/orgs","repos_url":"https://api.github.com/users/cjsmeele/repos","events_url":"https://api.github.com/users/cjsmeele/events{/privacy}","received_events_url":"https://api.github.com/users/cjsmeele/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-02T11:16:08Z","updated_at":"2015-03-02T12:26:49Z","closed_at":"2015-03-02T12:26:46Z","pull_request":{"url":"https://api.github.com/repos/DICE-UNC/irods-webdav/pulls/5","html_url":"https://github.com/DICE-UNC/irods-webdav/pull/5","diff_url":"https://github.com/DICE-UNC/irods-webdav/pull/5.diff","patch_url":"https://github.com/DICE-UNC/irods-webdav/pull/5.patch"},"body":"Hi again,\r\nWe ran into another problem where passwords containing `:` characters were being rejected by the basic auth parser. It seems that the `user:password` credentials string is being split without a limit, and the code later checks whether it's been split into two parts.\r\nAccording to [RFC 2617](http://www.ietf.org/rfc/rfc2617.txt) (page 6) the password may contain colon characters, but the username may not, so splitting only on the first colon seems to be a correct solution.\r\nHope this helps!"},"comment":{"url":"https://api.github.com/repos/DICE-UNC/irods-webdav/issues/comments/76703446","html_url":"https://github.com/DICE-UNC/irods-webdav/pull/5#issuecomment-76703446","issue_url":"https://api.github.com/repos/DICE-UNC/irods-webdav/issues/5","id":76703446,"user":{"login":"michael-conway","id":1097261,"avatar_url":"https://avatars.githubusercontent.com/u/1097261?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-conway","html_url":"https://github.com/michael-conway","followers_url":"https://api.github.com/users/michael-conway/followers","following_url":"https://api.github.com/users/michael-conway/following{/other_user}","gists_url":"https://api.github.com/users/michael-conway/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-conway/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-conway/subscriptions","organizations_url":"https://api.github.com/users/michael-conway/orgs","repos_url":"https://api.github.com/users/michael-conway/repos","events_url":"https://api.github.com/users/michael-conway/events{/privacy}","received_events_url":"https://api.github.com/users/michael-conway/received_events","type":"User","site_admin":false},"created_at":"2015-03-02T12:26:49Z","updated_at":"2015-03-02T12:26:49Z","body":"excellent!"}}