{"action":"created","issue":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/11436","labels_url":"https://api.github.com/repos/tgstation/-tg-station/issues/11436/labels{/name}","comments_url":"https://api.github.com/repos/tgstation/-tg-station/issues/11436/comments","events_url":"https://api.github.com/repos/tgstation/-tg-station/issues/11436/events","html_url":"https://github.com/tgstation/-tg-station/pull/11436","id":103634539,"number":11436,"title":"Major Cult Refactor","user":{"login":"Xhuis","id":5659269,"avatar_url":"https://avatars.githubusercontent.com/u/5659269?v=3","gravatar_id":"","url":"https://api.github.com/users/Xhuis","html_url":"https://github.com/Xhuis","followers_url":"https://api.github.com/users/Xhuis/followers","following_url":"https://api.github.com/users/Xhuis/following{/other_user}","gists_url":"https://api.github.com/users/Xhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/Xhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Xhuis/subscriptions","organizations_url":"https://api.github.com/users/Xhuis/orgs","repos_url":"https://api.github.com/users/Xhuis/repos","events_url":"https://api.github.com/users/Xhuis/events{/privacy}","received_events_url":"https://api.github.com/users/Xhuis/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Do%20Not%20Merge","name":"Do Not Merge","color":"460606"},{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Refactor","name":"Refactor","color":"ffaa00"},{"url":"https://api.github.com/repos/tgstation/-tg-station/labels/Work%20In%20Progress","name":"Work In Progress","color":"e11d21"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-08-28T02:31:12Z","updated_at":"2015-09-05T16:55:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tgstation/-tg-station/pulls/11436","html_url":"https://github.com/tgstation/-tg-station/pull/11436","diff_url":"https://github.com/tgstation/-tg-station/pull/11436.diff","patch_url":"https://github.com/tgstation/-tg-station/pull/11436.patch"},"body":"The current code for runes is god-awful. Like, seriously terrible. This PR aims to fix that. Rather than having every rune effect defined in a single attack_hand proc, this PR will separate the runes into subtypes, which supports for more modular runes as well as cleans up the code.\r\n\r\nIt also separates invocation into a two different procs. The first of these will determine if the rune can be invoked; if that passes, the second will cause the rune's effects. There is also a third proc that will cause effects if the rune fails to invoke.\r\n\r\nThis is heavily work-in-progress. As it is an almost complete rewrite of the Cult gamemode, it will take some time to finish."},"comment":{"url":"https://api.github.com/repos/tgstation/-tg-station/issues/comments/137976774","html_url":"https://github.com/tgstation/-tg-station/pull/11436#issuecomment-137976774","issue_url":"https://api.github.com/repos/tgstation/-tg-station/issues/11436","id":137976774,"user":{"login":"Shadowlight213","id":9410002,"avatar_url":"https://avatars.githubusercontent.com/u/9410002?v=3","gravatar_id":"","url":"https://api.github.com/users/Shadowlight213","html_url":"https://github.com/Shadowlight213","followers_url":"https://api.github.com/users/Shadowlight213/followers","following_url":"https://api.github.com/users/Shadowlight213/following{/other_user}","gists_url":"https://api.github.com/users/Shadowlight213/gists{/gist_id}","starred_url":"https://api.github.com/users/Shadowlight213/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shadowlight213/subscriptions","organizations_url":"https://api.github.com/users/Shadowlight213/orgs","repos_url":"https://api.github.com/users/Shadowlight213/repos","events_url":"https://api.github.com/users/Shadowlight213/events{/privacy}","received_events_url":"https://api.github.com/users/Shadowlight213/received_events","type":"User","site_admin":false},"created_at":"2015-09-05T16:55:15Z","updated_at":"2015-09-05T16:55:15Z","body":"Wish you could keep the \"I'm here\" in the summon sound. Maybe change how it sounds but keep the words? I'm here has become sort of the classic narnar sound."}}