{"action":"created","issue":{"url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/308","labels_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/308/labels{/name}","comments_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/308/comments","events_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/308/events","html_url":"https://github.com/simple-mvc-framework/framework/pull/308","id":123835675,"number":308,"title":"PHPUnit Testing Base","user":{"login":"tomvlk","id":3877688,"avatar_url":"https://avatars.githubusercontent.com/u/3877688?v=3","gravatar_id":"","url":"https://api.github.com/users/tomvlk","html_url":"https://github.com/tomvlk","followers_url":"https://api.github.com/users/tomvlk/followers","following_url":"https://api.github.com/users/tomvlk/following{/other_user}","gists_url":"https://api.github.com/users/tomvlk/gists{/gist_id}","starred_url":"https://api.github.com/users/tomvlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomvlk/subscriptions","organizations_url":"https://api.github.com/users/tomvlk/orgs","repos_url":"https://api.github.com/users/tomvlk/repos","events_url":"https://api.github.com/users/tomvlk/events{/privacy}","received_events_url":"https://api.github.com/users/tomvlk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-12-24T21:43:27Z","updated_at":"2015-12-24T22:18:22Z","closed_at":"2015-12-24T21:58:18Z","pull_request":{"url":"https://api.github.com/repos/simple-mvc-framework/framework/pulls/308","html_url":"https://github.com/simple-mvc-framework/framework/pull/308","diff_url":"https://github.com/simple-mvc-framework/framework/pull/308.diff","patch_url":"https://github.com/simple-mvc-framework/framework/pull/308.patch"},"body":"This will add the test base for letting PHPUnit run on every pull/commit.\r\nTravis is fully configured, there is already 1 (messy) test case in place, it will test dispatching of the router.\r\n\r\nBut the focus will be more on testing db engines, because that's pretty important, and could be affected by several small changes.\r\nAnd it's not only for testing the functionality right now, but more to maintain the quality of code that will not be touched in a while, but when it does, we are sure it still works (but not always 100% of coarse, you can never be...)..\r\n\r\nFeel free to add comments, suggestions etc. \r\n\r\n@daveismyname Please add the project to https://travis-ci.org so it will start testing on push and pull requests. (By default you will get spam bombed if the 'build' (test) failes, you could turn this off I think)."},"comment":{"url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/comments/167163126","html_url":"https://github.com/simple-mvc-framework/framework/pull/308#issuecomment-167163126","issue_url":"https://api.github.com/repos/simple-mvc-framework/framework/issues/308","id":167163126,"user":{"login":"daveismyname","id":1018170,"avatar_url":"https://avatars.githubusercontent.com/u/1018170?v=3","gravatar_id":"","url":"https://api.github.com/users/daveismyname","html_url":"https://github.com/daveismyname","followers_url":"https://api.github.com/users/daveismyname/followers","following_url":"https://api.github.com/users/daveismyname/following{/other_user}","gists_url":"https://api.github.com/users/daveismyname/gists{/gist_id}","starred_url":"https://api.github.com/users/daveismyname/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daveismyname/subscriptions","organizations_url":"https://api.github.com/users/daveismyname/orgs","repos_url":"https://api.github.com/users/daveismyname/repos","events_url":"https://api.github.com/users/daveismyname/events{/privacy}","received_events_url":"https://api.github.com/users/daveismyname/received_events","type":"User","site_admin":false},"created_at":"2015-12-24T22:18:21Z","updated_at":"2015-12-24T22:18:21Z","body":"Yes, important to spend some time with the family :)"}}