{"action":"closed","number":5598,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5598","id":51792297,"html_url":"https://github.com/ManageIQ/manageiq/pull/5598","diff_url":"https://github.com/ManageIQ/manageiq/pull/5598.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/5598.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5598","number":5598,"state":"closed","locked":false,"title":"Simplify `sort_by{}.first` by replacing it with `min_by{}`","user":{"login":"DNNX","id":447953,"avatar_url":"https://avatars.githubusercontent.com/u/447953?v=3","gravatar_id":"","url":"https://api.github.com/users/DNNX","html_url":"https://github.com/DNNX","followers_url":"https://api.github.com/users/DNNX/followers","following_url":"https://api.github.com/users/DNNX/following{/other_user}","gists_url":"https://api.github.com/users/DNNX/gists{/gist_id}","starred_url":"https://api.github.com/users/DNNX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNNX/subscriptions","organizations_url":"https://api.github.com/users/DNNX/orgs","repos_url":"https://api.github.com/users/DNNX/repos","events_url":"https://api.github.com/users/DNNX/events{/privacy}","received_events_url":"https://api.github.com/users/DNNX/received_events","type":"User","site_admin":false},"body":"Same applies to `sort_by{}.last` =>`max_by`, `sort.first` => `min`, `sort.last` => `max`.\r\n\r\nBesides better readability, it also should improve performance a little.","created_at":"2015-11-25T13:12:40Z","updated_at":"2015-12-01T15:13:34Z","closed_at":"2015-12-01T15:13:34Z","merged_at":"2015-12-01T15:13:34Z","merge_commit_sha":"4cf5f1e44cd7687a5108bd7e56ff2e781b62cfee","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5598/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5598/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/5598/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/88ccc1fa5d805a10641754a9ad18402088311dd2","head":{"label":"DNNX:sort-by-first-last","ref":"sort-by-first-last","sha":"88ccc1fa5d805a10641754a9ad18402088311dd2","user":{"login":"DNNX","id":447953,"avatar_url":"https://avatars.githubusercontent.com/u/447953?v=3","gravatar_id":"","url":"https://api.github.com/users/DNNX","html_url":"https://github.com/DNNX","followers_url":"https://api.github.com/users/DNNX/followers","following_url":"https://api.github.com/users/DNNX/following{/other_user}","gists_url":"https://api.github.com/users/DNNX/gists{/gist_id}","starred_url":"https://api.github.com/users/DNNX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNNX/subscriptions","organizations_url":"https://api.github.com/users/DNNX/orgs","repos_url":"https://api.github.com/users/DNNX/repos","events_url":"https://api.github.com/users/DNNX/events{/privacy}","received_events_url":"https://api.github.com/users/DNNX/received_events","type":"User","site_admin":false},"repo":{"id":43876141,"name":"manageiq","full_name":"DNNX/manageiq","owner":{"login":"DNNX","id":447953,"avatar_url":"https://avatars.githubusercontent.com/u/447953?v=3","gravatar_id":"","url":"https://api.github.com/users/DNNX","html_url":"https://github.com/DNNX","followers_url":"https://api.github.com/users/DNNX/followers","following_url":"https://api.github.com/users/DNNX/following{/other_user}","gists_url":"https://api.github.com/users/DNNX/gists{/gist_id}","starred_url":"https://api.github.com/users/DNNX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DNNX/subscriptions","organizations_url":"https://api.github.com/users/DNNX/orgs","repos_url":"https://api.github.com/users/DNNX/repos","events_url":"https://api.github.com/users/DNNX/events{/privacy}","received_events_url":"https://api.github.com/users/DNNX/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DNNX/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/DNNX/manageiq","forks_url":"https://api.github.com/repos/DNNX/manageiq/forks","keys_url":"https://api.github.com/repos/DNNX/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DNNX/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DNNX/manageiq/teams","hooks_url":"https://api.github.com/repos/DNNX/manageiq/hooks","issue_events_url":"https://api.github.com/repos/DNNX/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/DNNX/manageiq/events","assignees_url":"https://api.github.com/repos/DNNX/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/DNNX/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/DNNX/manageiq/tags","blobs_url":"https://api.github.com/repos/DNNX/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DNNX/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DNNX/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/DNNX/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DNNX/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/DNNX/manageiq/languages","stargazers_url":"https://api.github.com/repos/DNNX/manageiq/stargazers","contributors_url":"https://api.github.com/repos/DNNX/manageiq/contributors","subscribers_url":"https://api.github.com/repos/DNNX/manageiq/subscribers","subscription_url":"https://api.github.com/repos/DNNX/manageiq/subscription","commits_url":"https://api.github.com/repos/DNNX/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/DNNX/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/DNNX/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/DNNX/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/DNNX/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/DNNX/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DNNX/manageiq/merges","archive_url":"https://api.github.com/repos/DNNX/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DNNX/manageiq/downloads","issues_url":"https://api.github.com/repos/DNNX/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/DNNX/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/DNNX/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/DNNX/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DNNX/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/DNNX/manageiq/releases{/id}","created_at":"2015-10-08T09:07:10Z","updated_at":"2015-10-08T09:07:34Z","pushed_at":"2015-11-25T13:12:57Z","git_url":"git://github.com/DNNX/manageiq.git","ssh_url":"git@github.com:DNNX/manageiq.git","clone_url":"https://github.com/DNNX/manageiq.git","svn_url":"https://github.com/DNNX/manageiq","homepage":"manageiq.org","size":96597,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"a47a0c6c369cb80a7501cc76d51231dd130c0418","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Cloud Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","created_at":"2014-06-13T02:31:26Z","updated_at":"2015-11-29T14:49:32Z","pushed_at":"2015-12-01T15:13:34Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":130229,"stargazers_count":171,"watchers_count":171,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":186,"mirror_url":null,"open_issues_count":480,"forks":186,"open_issues":480,"watchers":171,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5598"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/5598"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5598"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/5598/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5598/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/5598/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/88ccc1fa5d805a10641754a9ad18402088311dd2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":6,"additions":7,"deletions":7,"changed_files":7}}