{"action":"created","comment":{"url":"https://api.github.com/repos/wmayner/pyphi/pulls/comments/25475513","id":25475513,"diff_hunk":"@@ -229,11 +231,20 @@ def _evaluate_partition(uncut_subsystem, partition,\n     log.debug(\"Evaluating partition {}...\".format(partition))\n     # Compute forward mip.\n     forward_cut = Cut(partition[0], partition[1])\n+    if not config.MATLAB_APPROX:\n+        cut_mechanisms = utils.split_by_cut(uncut_subsystem, forward_cut)","path":"pyphi/compute.py","position":49,"original_position":49,"commit_id":"3354ca205d3f8797e0ca3365f7ee9daf9f1abcda","original_commit_id":"3354ca205d3f8797e0ca3365f7ee9daf9f1abcda","user":{"login":"wmayner","id":1775632,"avatar_url":"https://avatars.githubusercontent.com/u/1775632?v=3","gravatar_id":"","url":"https://api.github.com/users/wmayner","html_url":"https://github.com/wmayner","followers_url":"https://api.github.com/users/wmayner/followers","following_url":"https://api.github.com/users/wmayner/following{/other_user}","gists_url":"https://api.github.com/users/wmayner/gists{/gist_id}","starred_url":"https://api.github.com/users/wmayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmayner/subscriptions","organizations_url":"https://api.github.com/users/wmayner/orgs","repos_url":"https://api.github.com/users/wmayner/repos","events_url":"https://api.github.com/users/wmayner/events{/privacy}","received_events_url":"https://api.github.com/users/wmayner/received_events","type":"User","site_admin":false},"body":"Let's call the config option `ASSUME_CUTS_CANNOT_CREATE_CONCEPTS` or something like that, since `MATLAB_APPROX` isn't very descriptive… then we can put a note in the docs further explaining it. In fact, maybe we should have a namespace in the config dictionary called `APPROXIMATIONS`, just to make it more explicit that this is not the actual value.","created_at":"2015-02-26T23:19:53Z","updated_at":"2015-02-26T23:19:53Z","html_url":"https://github.com/wmayner/pyphi/pull/5#discussion_r25475513","pull_request_url":"https://api.github.com/repos/wmayner/pyphi/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/wmayner/pyphi/pulls/comments/25475513"},"html":{"href":"https://github.com/wmayner/pyphi/pull/5#discussion_r25475513"},"pull_request":{"href":"https://api.github.com/repos/wmayner/pyphi/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/wmayner/pyphi/pulls/5","id":30110082,"html_url":"https://github.com/wmayner/pyphi/pull/5","diff_url":"https://github.com/wmayner/pyphi/pull/5.diff","patch_url":"https://github.com/wmayner/pyphi/pull/5.patch","issue_url":"https://api.github.com/repos/wmayner/pyphi/issues/5","number":5,"state":"open","locked":false,"title":"Only recheck necessary mechanisms after cut","user":{"login":"slipperyhank","id":8660524,"avatar_url":"https://avatars.githubusercontent.com/u/8660524?v=3","gravatar_id":"","url":"https://api.github.com/users/slipperyhank","html_url":"https://github.com/slipperyhank","followers_url":"https://api.github.com/users/slipperyhank/followers","following_url":"https://api.github.com/users/slipperyhank/following{/other_user}","gists_url":"https://api.github.com/users/slipperyhank/gists{/gist_id}","starred_url":"https://api.github.com/users/slipperyhank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipperyhank/subscriptions","organizations_url":"https://api.github.com/users/slipperyhank/orgs","repos_url":"https://api.github.com/users/slipperyhank/repos","events_url":"https://api.github.com/users/slipperyhank/events{/privacy}","received_events_url":"https://api.github.com/users/slipperyhank/received_events","type":"User","site_admin":false},"body":"Only mechanisms which are split by a cut, or concepts whose purviews are affected are recalculated after a system cut. \r\n\r\nAlso implement matlab approximation option","created_at":"2015-02-26T19:52:05Z","updated_at":"2015-02-26T23:19:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce68a9816ca3877969b69186760515fd648a632b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmayner/pyphi/pulls/5/commits","review_comments_url":"https://api.github.com/repos/wmayner/pyphi/pulls/5/comments","review_comment_url":"https://api.github.com/repos/wmayner/pyphi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmayner/pyphi/issues/5/comments","statuses_url":"https://api.github.com/repos/wmayner/pyphi/statuses/3354ca205d3f8797e0ca3365f7ee9daf9f1abcda","head":{"label":"slipperyhank:develop","ref":"develop","sha":"3354ca205d3f8797e0ca3365f7ee9daf9f1abcda","user":{"login":"slipperyhank","id":8660524,"avatar_url":"https://avatars.githubusercontent.com/u/8660524?v=3","gravatar_id":"","url":"https://api.github.com/users/slipperyhank","html_url":"https://github.com/slipperyhank","followers_url":"https://api.github.com/users/slipperyhank/followers","following_url":"https://api.github.com/users/slipperyhank/following{/other_user}","gists_url":"https://api.github.com/users/slipperyhank/gists{/gist_id}","starred_url":"https://api.github.com/users/slipperyhank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipperyhank/subscriptions","organizations_url":"https://api.github.com/users/slipperyhank/orgs","repos_url":"https://api.github.com/users/slipperyhank/repos","events_url":"https://api.github.com/users/slipperyhank/events{/privacy}","received_events_url":"https://api.github.com/users/slipperyhank/received_events","type":"User","site_admin":false},"repo":{"id":26186867,"name":"pyphi","full_name":"slipperyhank/pyphi","owner":{"login":"slipperyhank","id":8660524,"avatar_url":"https://avatars.githubusercontent.com/u/8660524?v=3","gravatar_id":"","url":"https://api.github.com/users/slipperyhank","html_url":"https://github.com/slipperyhank","followers_url":"https://api.github.com/users/slipperyhank/followers","following_url":"https://api.github.com/users/slipperyhank/following{/other_user}","gists_url":"https://api.github.com/users/slipperyhank/gists{/gist_id}","starred_url":"https://api.github.com/users/slipperyhank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipperyhank/subscriptions","organizations_url":"https://api.github.com/users/slipperyhank/orgs","repos_url":"https://api.github.com/users/slipperyhank/repos","events_url":"https://api.github.com/users/slipperyhank/events{/privacy}","received_events_url":"https://api.github.com/users/slipperyhank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slipperyhank/pyphi","description":"A Python library for computing integrated information.","fork":true,"url":"https://api.github.com/repos/slipperyhank/pyphi","forks_url":"https://api.github.com/repos/slipperyhank/pyphi/forks","keys_url":"https://api.github.com/repos/slipperyhank/pyphi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slipperyhank/pyphi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slipperyhank/pyphi/teams","hooks_url":"https://api.github.com/repos/slipperyhank/pyphi/hooks","issue_events_url":"https://api.github.com/repos/slipperyhank/pyphi/issues/events{/number}","events_url":"https://api.github.com/repos/slipperyhank/pyphi/events","assignees_url":"https://api.github.com/repos/slipperyhank/pyphi/assignees{/user}","branches_url":"https://api.github.com/repos/slipperyhank/pyphi/branches{/branch}","tags_url":"https://api.github.com/repos/slipperyhank/pyphi/tags","blobs_url":"https://api.github.com/repos/slipperyhank/pyphi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slipperyhank/pyphi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slipperyhank/pyphi/git/refs{/sha}","trees_url":"https://api.github.com/repos/slipperyhank/pyphi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slipperyhank/pyphi/statuses/{sha}","languages_url":"https://api.github.com/repos/slipperyhank/pyphi/languages","stargazers_url":"https://api.github.com/repos/slipperyhank/pyphi/stargazers","contributors_url":"https://api.github.com/repos/slipperyhank/pyphi/contributors","subscribers_url":"https://api.github.com/repos/slipperyhank/pyphi/subscribers","subscription_url":"https://api.github.com/repos/slipperyhank/pyphi/subscription","commits_url":"https://api.github.com/repos/slipperyhank/pyphi/commits{/sha}","git_commits_url":"https://api.github.com/repos/slipperyhank/pyphi/git/commits{/sha}","comments_url":"https://api.github.com/repos/slipperyhank/pyphi/comments{/number}","issue_comment_url":"https://api.github.com/repos/slipperyhank/pyphi/issues/comments{/number}","contents_url":"https://api.github.com/repos/slipperyhank/pyphi/contents/{+path}","compare_url":"https://api.github.com/repos/slipperyhank/pyphi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slipperyhank/pyphi/merges","archive_url":"https://api.github.com/repos/slipperyhank/pyphi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slipperyhank/pyphi/downloads","issues_url":"https://api.github.com/repos/slipperyhank/pyphi/issues{/number}","pulls_url":"https://api.github.com/repos/slipperyhank/pyphi/pulls{/number}","milestones_url":"https://api.github.com/repos/slipperyhank/pyphi/milestones{/number}","notifications_url":"https://api.github.com/repos/slipperyhank/pyphi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slipperyhank/pyphi/labels{/name}","releases_url":"https://api.github.com/repos/slipperyhank/pyphi/releases{/id}","created_at":"2014-11-04T20:17:18Z","updated_at":"2015-02-26T19:49:22Z","pushed_at":"2015-02-26T19:49:22Z","git_url":"git://github.com/slipperyhank/pyphi.git","ssh_url":"git@github.com:slipperyhank/pyphi.git","clone_url":"https://github.com/slipperyhank/pyphi.git","svn_url":"https://github.com/slipperyhank/pyphi","homepage":"http://integratedinformationtheory.org","size":1619,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"wmayner:develop","ref":"develop","sha":"9a76801af95cba761c212fc36dee8ca7a6da9d50","user":{"login":"wmayner","id":1775632,"avatar_url":"https://avatars.githubusercontent.com/u/1775632?v=3","gravatar_id":"","url":"https://api.github.com/users/wmayner","html_url":"https://github.com/wmayner","followers_url":"https://api.github.com/users/wmayner/followers","following_url":"https://api.github.com/users/wmayner/following{/other_user}","gists_url":"https://api.github.com/users/wmayner/gists{/gist_id}","starred_url":"https://api.github.com/users/wmayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmayner/subscriptions","organizations_url":"https://api.github.com/users/wmayner/orgs","repos_url":"https://api.github.com/users/wmayner/repos","events_url":"https://api.github.com/users/wmayner/events{/privacy}","received_events_url":"https://api.github.com/users/wmayner/received_events","type":"User","site_admin":false},"repo":{"id":18546477,"name":"pyphi","full_name":"wmayner/pyphi","owner":{"login":"wmayner","id":1775632,"avatar_url":"https://avatars.githubusercontent.com/u/1775632?v=3","gravatar_id":"","url":"https://api.github.com/users/wmayner","html_url":"https://github.com/wmayner","followers_url":"https://api.github.com/users/wmayner/followers","following_url":"https://api.github.com/users/wmayner/following{/other_user}","gists_url":"https://api.github.com/users/wmayner/gists{/gist_id}","starred_url":"https://api.github.com/users/wmayner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmayner/subscriptions","organizations_url":"https://api.github.com/users/wmayner/orgs","repos_url":"https://api.github.com/users/wmayner/repos","events_url":"https://api.github.com/users/wmayner/events{/privacy}","received_events_url":"https://api.github.com/users/wmayner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wmayner/pyphi","description":"A Python library for computing integrated information.","fork":false,"url":"https://api.github.com/repos/wmayner/pyphi","forks_url":"https://api.github.com/repos/wmayner/pyphi/forks","keys_url":"https://api.github.com/repos/wmayner/pyphi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmayner/pyphi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmayner/pyphi/teams","hooks_url":"https://api.github.com/repos/wmayner/pyphi/hooks","issue_events_url":"https://api.github.com/repos/wmayner/pyphi/issues/events{/number}","events_url":"https://api.github.com/repos/wmayner/pyphi/events","assignees_url":"https://api.github.com/repos/wmayner/pyphi/assignees{/user}","branches_url":"https://api.github.com/repos/wmayner/pyphi/branches{/branch}","tags_url":"https://api.github.com/repos/wmayner/pyphi/tags","blobs_url":"https://api.github.com/repos/wmayner/pyphi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmayner/pyphi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmayner/pyphi/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmayner/pyphi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmayner/pyphi/statuses/{sha}","languages_url":"https://api.github.com/repos/wmayner/pyphi/languages","stargazers_url":"https://api.github.com/repos/wmayner/pyphi/stargazers","contributors_url":"https://api.github.com/repos/wmayner/pyphi/contributors","subscribers_url":"https://api.github.com/repos/wmayner/pyphi/subscribers","subscription_url":"https://api.github.com/repos/wmayner/pyphi/subscription","commits_url":"https://api.github.com/repos/wmayner/pyphi/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmayner/pyphi/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmayner/pyphi/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmayner/pyphi/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmayner/pyphi/contents/{+path}","compare_url":"https://api.github.com/repos/wmayner/pyphi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmayner/pyphi/merges","archive_url":"https://api.github.com/repos/wmayner/pyphi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmayner/pyphi/downloads","issues_url":"https://api.github.com/repos/wmayner/pyphi/issues{/number}","pulls_url":"https://api.github.com/repos/wmayner/pyphi/pulls{/number}","milestones_url":"https://api.github.com/repos/wmayner/pyphi/milestones{/number}","notifications_url":"https://api.github.com/repos/wmayner/pyphi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmayner/pyphi/labels{/name}","releases_url":"https://api.github.com/repos/wmayner/pyphi/releases{/id}","created_at":"2014-04-08T05:31:10Z","updated_at":"2015-02-25T22:45:28Z","pushed_at":"2015-02-25T22:45:28Z","git_url":"git://github.com/wmayner/pyphi.git","ssh_url":"git@github.com:wmayner/pyphi.git","clone_url":"https://github.com/wmayner/pyphi.git","svn_url":"https://github.com/wmayner/pyphi","homepage":"http://integratedinformationtheory.org","size":2580,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":1,"forks":3,"open_issues":1,"watchers":5,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wmayner/pyphi/pulls/5"},"html":{"href":"https://github.com/wmayner/pyphi/pull/5"},"issue":{"href":"https://api.github.com/repos/wmayner/pyphi/issues/5"},"comments":{"href":"https://api.github.com/repos/wmayner/pyphi/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/wmayner/pyphi/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/wmayner/pyphi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmayner/pyphi/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/wmayner/pyphi/statuses/3354ca205d3f8797e0ca3365f7ee9daf9f1abcda"}}}}