{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/33102838","id":33102838,"diff_hunk":"@@ -0,0 +1,84 @@\n+<html>\n+    <head>\n+        <link rel=\"stylesheet\" type=\"text/css\" href=\"style.css\">\n+        <script>\n+        \n+            function emitUpdate() {\n+                EventBridge.emitWebEvent(JSON.stringify({\n+                    type: \"update\",\n+                    armsFree: elArmsFree.checked,\n+                    footstepSounds: elFootstepSounds.checked,\n+                    blenderPreRotations: elBlenderPreRotations.checked\n+                }));\n+            }\n+        \n+            function loaded() {\n+                // assign form elements to vars\n+                elPower = document.getElementById(\"power\");\n+                elArmsFree = document.getElementById(\"arms-free\");\n+                elFootstepSounds = document.getElementById(\"footstep-sounds\");\n+                elBlenderPreRotations = document.getElementById(\"bender-pre-rotations\");\n+\n+                if (window.EventBridge !== undefined) {\n+                    EventBridge.scriptEventReceived.connect(function(data) {\n+                        data = JSON.parse(data);\n+                        \n+                        if (data.type == \"update\") {\n+                            if (data.armsFree !== undefined) {\n+                                elArmsFree.checked = data.armsFree == true;","path":"examples/html/walkSettings.html","position":28,"original_position":28,"commit_id":"796d76004ca31f06b383ff989e12abdc1b643639","original_commit_id":"796d76004ca31f06b383ff989e12abdc1b643639","user":{"login":"howard-stearns","id":7015115,"avatar_url":"https://avatars.githubusercontent.com/u/7015115?v=3","gravatar_id":"","url":"https://api.github.com/users/howard-stearns","html_url":"https://github.com/howard-stearns","followers_url":"https://api.github.com/users/howard-stearns/followers","following_url":"https://api.github.com/users/howard-stearns/following{/other_user}","gists_url":"https://api.github.com/users/howard-stearns/gists{/gist_id}","starred_url":"https://api.github.com/users/howard-stearns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howard-stearns/subscriptions","organizations_url":"https://api.github.com/users/howard-stearns/orgs","repos_url":"https://api.github.com/users/howard-stearns/repos","events_url":"https://api.github.com/users/howard-stearns/events{/privacy}","received_events_url":"https://api.github.com/users/howard-stearns/received_events","type":"User","site_admin":false},"body":"Any reason not to just say elArmsFree.checked = data.armsFree?","created_at":"2015-06-23T23:04:32Z","updated_at":"2015-06-23T23:04:32Z","html_url":"https://github.com/highfidelity/hifi/pull/5179#discussion_r33102838","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5179","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/33102838"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5179#discussion_r33102838"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5179"}}},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/5179","id":38207865,"html_url":"https://github.com/highfidelity/hifi/pull/5179","diff_url":"https://github.com/highfidelity/hifi/pull/5179.diff","patch_url":"https://github.com/highfidelity/hifi/pull/5179.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/5179","number":5179,"state":"open","locked":false,"title":"walk.js version 1.25","user":{"login":"DaveDubUK","id":5994985,"avatar_url":"https://avatars.githubusercontent.com/u/5994985?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveDubUK","html_url":"https://github.com/DaveDubUK","followers_url":"https://api.github.com/users/DaveDubUK/followers","following_url":"https://api.github.com/users/DaveDubUK/following{/other_user}","gists_url":"https://api.github.com/users/DaveDubUK/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveDubUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveDubUK/subscriptions","organizations_url":"https://api.github.com/users/DaveDubUK/orgs","repos_url":"https://api.github.com/users/DaveDubUK/repos","events_url":"https://api.github.com/users/DaveDubUK/events{/privacy}","received_events_url":"https://api.github.com/users/DaveDubUK/received_events","type":"User","site_admin":false},"body":"walk.js version 1.25\r\n-------------------------\r\n\r\nRelease notes, June 2015\r\n\r\nThis version of the script has been extensively refactored; simplified, performance optimised and made far easier to read / understand. All known problems due to Interface bugs have been isolated and bug reports submitted.\r\nI am not looking to get paid for this, I just want get the project synced and to get my work 'out there'. \r\n\r\n\r\n**Updated Transitions**\r\nCompared to the current walk script (version 1.1, as found in hifi/examples), the only significant added functionality is the transitions, as already paid for by High Fidelity (worklist https://worklist.net/20186).\r\n\r\n\r\n**Coding Style**\r\nAll points raised by Philip in the code review for the transitions worklist item have been addressed. Further changes in the spirit of Philip's comments and HiFi's coding standards have also been made. Philip's original comments are here: https://github.com/highfidelity/hifi/pull/3987/files#r22338645\r\n    \r\n\r\n**That horrible UI**\r\nThe old UI has been completely removed and replaced with a simple webWindow settings panel.\r\n\r\n\r\n**Footstep sounds**\r\nPlaying footstep sounds (i.e. calling Audio.playSound repeatedly) continues to disrupt the script's smooth execution. This behaviour seems to be due to the varying execution time of Audio.playSound. A bug report, complete with short test script has been submitted here: https://worklist.net/20579\r\n\r\n\r\n**Avatar rotation axis**\r\nRotating an avatar's joints causes the avatar to be displaced from his origin / correct rotation axis. This affects both the current and beta versions of the script (walk.js 1.1 and 1.25) and seems to be an Interface bug. A bug report, complete with test script and movie, has been submitted here: https://worklist.net/20575\r\n  \r\n\r\n**Major optimisations**\r\nThe following functionality in particular has been overhauled (optimised and drastically simplified): \r\n    - existing animation replay code \r\n    - existing animation storage code\r\n    - existing locomotion state detection code (to test transitions)\r\n\r\n\r\n**Avatar compatibility**\r\nThe animations are compatible with Ozan's reference avatar and work well with the Mixamo avatars. There has been a lot of progress in the alpha forums recently towards establishing Avatar creation workflows using open source editors. As a result, there is a (temporary) option in the settings that applies some simple pre-rotations to circumnavigate the current Blender joint orientation issues. However, as can be seen under discussion here: https://alphas.highfidelity.io/t/walk-js-new-avis-physics-and-turn-detection/5460/39 , problems with the standardisation of avatar's shoulder joints are not yet totally resolved.\r\n\r\n\r\nI hope this brings the script up to HiFi standards - if not, please let me know what needs to be done. \r\n\r\n - davedub","created_at":"2015-06-22T08:04:44Z","updated_at":"2015-06-23T23:04:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e3d51e046c36d3f8f4103bb5aad5e2101624127","assignee":{"login":"howard-stearns","id":7015115,"avatar_url":"https://avatars.githubusercontent.com/u/7015115?v=3","gravatar_id":"","url":"https://api.github.com/users/howard-stearns","html_url":"https://github.com/howard-stearns","followers_url":"https://api.github.com/users/howard-stearns/followers","following_url":"https://api.github.com/users/howard-stearns/following{/other_user}","gists_url":"https://api.github.com/users/howard-stearns/gists{/gist_id}","starred_url":"https://api.github.com/users/howard-stearns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howard-stearns/subscriptions","organizations_url":"https://api.github.com/users/howard-stearns/orgs","repos_url":"https://api.github.com/users/howard-stearns/repos","events_url":"https://api.github.com/users/howard-stearns/events{/privacy}","received_events_url":"https://api.github.com/users/howard-stearns/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5179/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/5179/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/5179/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/796d76004ca31f06b383ff989e12abdc1b643639","head":{"label":"DaveDubUK:walk-1.25","ref":"walk-1.25","sha":"796d76004ca31f06b383ff989e12abdc1b643639","user":{"login":"DaveDubUK","id":5994985,"avatar_url":"https://avatars.githubusercontent.com/u/5994985?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveDubUK","html_url":"https://github.com/DaveDubUK","followers_url":"https://api.github.com/users/DaveDubUK/followers","following_url":"https://api.github.com/users/DaveDubUK/following{/other_user}","gists_url":"https://api.github.com/users/DaveDubUK/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveDubUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveDubUK/subscriptions","organizations_url":"https://api.github.com/users/DaveDubUK/orgs","repos_url":"https://api.github.com/users/DaveDubUK/repos","events_url":"https://api.github.com/users/DaveDubUK/events{/privacy}","received_events_url":"https://api.github.com/users/DaveDubUK/received_events","type":"User","site_admin":false},"repo":{"id":27552727,"name":"hifi","full_name":"DaveDubUK/hifi","owner":{"login":"DaveDubUK","id":5994985,"avatar_url":"https://avatars.githubusercontent.com/u/5994985?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveDubUK","html_url":"https://github.com/DaveDubUK","followers_url":"https://api.github.com/users/DaveDubUK/followers","following_url":"https://api.github.com/users/DaveDubUK/following{/other_user}","gists_url":"https://api.github.com/users/DaveDubUK/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveDubUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveDubUK/subscriptions","organizations_url":"https://api.github.com/users/DaveDubUK/orgs","repos_url":"https://api.github.com/users/DaveDubUK/repos","events_url":"https://api.github.com/users/DaveDubUK/events{/privacy}","received_events_url":"https://api.github.com/users/DaveDubUK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DaveDubUK/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  Documentation at http://docs.highfidelity.io  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/DaveDubUK/hifi","forks_url":"https://api.github.com/repos/DaveDubUK/hifi/forks","keys_url":"https://api.github.com/repos/DaveDubUK/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DaveDubUK/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DaveDubUK/hifi/teams","hooks_url":"https://api.github.com/repos/DaveDubUK/hifi/hooks","issue_events_url":"https://api.github.com/repos/DaveDubUK/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/DaveDubUK/hifi/events","assignees_url":"https://api.github.com/repos/DaveDubUK/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/DaveDubUK/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/DaveDubUK/hifi/tags","blobs_url":"https://api.github.com/repos/DaveDubUK/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DaveDubUK/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DaveDubUK/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/DaveDubUK/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DaveDubUK/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/DaveDubUK/hifi/languages","stargazers_url":"https://api.github.com/repos/DaveDubUK/hifi/stargazers","contributors_url":"https://api.github.com/repos/DaveDubUK/hifi/contributors","subscribers_url":"https://api.github.com/repos/DaveDubUK/hifi/subscribers","subscription_url":"https://api.github.com/repos/DaveDubUK/hifi/subscription","commits_url":"https://api.github.com/repos/DaveDubUK/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/DaveDubUK/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/DaveDubUK/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/DaveDubUK/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/DaveDubUK/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/DaveDubUK/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DaveDubUK/hifi/merges","archive_url":"https://api.github.com/repos/DaveDubUK/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DaveDubUK/hifi/downloads","issues_url":"https://api.github.com/repos/DaveDubUK/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/DaveDubUK/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/DaveDubUK/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/DaveDubUK/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DaveDubUK/hifi/labels{/name}","releases_url":"https://api.github.com/repos/DaveDubUK/hifi/releases{/id}","created_at":"2014-12-04T17:57:29Z","updated_at":"2014-12-19T11:30:43Z","pushed_at":"2015-06-22T10:53:26Z","git_url":"git://github.com/DaveDubUK/hifi.git","ssh_url":"git@github.com:DaveDubUK/hifi.git","clone_url":"https://github.com/DaveDubUK/hifi.git","svn_url":"https://github.com/DaveDubUK/hifi","homepage":"","size":159803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"be8ae9580de9e949e73572a0d7ac5e066c73a1ed","user":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"name":"hifi","full_name":"highfidelity/hifi","owner":{"login":"highfidelity","id":1565370,"avatar_url":"https://avatars.githubusercontent.com/u/1565370?v=3","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/highfidelity/hifi","description":"Open source software for shared virtual worlds using HMDs and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.com/jobs  Documentation at http://docs.highfidelity.com  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","created_at":"2012-08-10T18:26:22Z","updated_at":"2015-06-23T21:00:17Z","pushed_at":"2015-06-23T22:55:31Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":213551,"stargazers_count":280,"watchers_count":280,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":158,"mirror_url":null,"open_issues_count":60,"forks":158,"open_issues":60,"watchers":280,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5179"},"html":{"href":"https://github.com/highfidelity/hifi/pull/5179"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5179"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/5179/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5179/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/5179/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/796d76004ca31f06b383ff989e12abdc1b643639"}}}}