{"action":"created","issue":{"url":"https://api.github.com/repos/pburtchaell/react-notification/issues/37","labels_url":"https://api.github.com/repos/pburtchaell/react-notification/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/pburtchaell/react-notification/issues/37/comments","events_url":"https://api.github.com/repos/pburtchaell/react-notification/issues/37/events","html_url":"https://github.com/pburtchaell/react-notification/pull/37","id":113986907,"number":37,"title":"do not set more timeouts when recieving props and clear the timeout w…","user":{"login":"meta-meta","id":2626819,"avatar_url":"https://avatars.githubusercontent.com/u/2626819?v=3","gravatar_id":"","url":"https://api.github.com/users/meta-meta","html_url":"https://github.com/meta-meta","followers_url":"https://api.github.com/users/meta-meta/followers","following_url":"https://api.github.com/users/meta-meta/following{/other_user}","gists_url":"https://api.github.com/users/meta-meta/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-meta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-meta/subscriptions","organizations_url":"https://api.github.com/users/meta-meta/orgs","repos_url":"https://api.github.com/users/meta-meta/repos","events_url":"https://api.github.com/users/meta-meta/events{/privacy}","received_events_url":"https://api.github.com/users/meta-meta/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pburtchaell/react-notification/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-29T06:06:05Z","updated_at":"2015-11-04T06:26:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/pburtchaell/react-notification/pulls/37","html_url":"https://github.com/pburtchaell/react-notification/pull/37","diff_url":"https://github.com/pburtchaell/react-notification/pull/37.diff","patch_url":"https://github.com/pburtchaell/react-notification/pull/37.patch"},"body":"…hen a notification component is unmounted\r\n\r\nI have a need to stack any number of these notifications on the page at once. I have a component containing an array of notification objects in state. The render function of this component maps over the array, rendering Notification components. The onDismiss handler for each Notification updates state with a new array omitting the dismissed notification .\r\n\r\nI pass a style prop into each Notification to update the placement according to where the notification exists in the list.\r\n\r\nThis passing of new props has the side effect of creating a new timeout to call onDismiss, thus my pull request. Essentially I'm seeing a setState getting called on a component that is no longer mounted, producing a warning from React. The proposed change prevents that from happening."},"comment":{"url":"https://api.github.com/repos/pburtchaell/react-notification/issues/comments/153594139","html_url":"https://github.com/pburtchaell/react-notification/pull/37#issuecomment-153594139","issue_url":"https://api.github.com/repos/pburtchaell/react-notification/issues/37","id":153594139,"user":{"login":"meta-meta","id":2626819,"avatar_url":"https://avatars.githubusercontent.com/u/2626819?v=3","gravatar_id":"","url":"https://api.github.com/users/meta-meta","html_url":"https://github.com/meta-meta","followers_url":"https://api.github.com/users/meta-meta/followers","following_url":"https://api.github.com/users/meta-meta/following{/other_user}","gists_url":"https://api.github.com/users/meta-meta/gists{/gist_id}","starred_url":"https://api.github.com/users/meta-meta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meta-meta/subscriptions","organizations_url":"https://api.github.com/users/meta-meta/orgs","repos_url":"https://api.github.com/users/meta-meta/repos","events_url":"https://api.github.com/users/meta-meta/events{/privacy}","received_events_url":"https://api.github.com/users/meta-meta/received_events","type":"User","site_admin":false},"created_at":"2015-11-04T06:26:17Z","updated_at":"2015-11-04T06:26:17Z","body":"Thank you! It's been a busy few days but here it is. Would you be interested in my notification list solution, or is that out of scope?"}}