{"action":"created","comment":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments/31187354","id":31187354,"diff_hunk":"@@ -1060,3 +1071,23 @@ AuthenticationContext.prototype._addClientId = function() {\n     // x-client-Ver \n     return '&x-client-SKU=Js&x-client-Ver=' + this._libVersion();\n };\n+\n+AuthenticationContext.prototype._log = function (resource, message) {\n+    if (!this._supportsLocalStorage()) {\n+        return;\n+    }\n+    \n+    var logEntry = this.CONSTANTS.LOG_ENTRY + resource;\n+    \n+    var correlationId = this.config.correlationId;\n+    var timestamp = new Date().toUTCString();\n+    \n+    var formattedMessage = timestamp + ':' + correlationId + ': ' + message + ';';\n+    \n+    if (this._getItem(logEntry)) {","path":"lib/adal.js","position":65,"original_position":65,"commit_id":"dbb8cc059c3aa8d95f4dc50610353002a45ba7f8","original_commit_id":"dbb8cc059c3aa8d95f4dc50610353002a45ba7f8","user":{"login":"omercs","id":466805,"avatar_url":"https://avatars.githubusercontent.com/u/466805?v=3","gravatar_id":"","url":"https://api.github.com/users/omercs","html_url":"https://github.com/omercs","followers_url":"https://api.github.com/users/omercs/followers","following_url":"https://api.github.com/users/omercs/following{/other_user}","gists_url":"https://api.github.com/users/omercs/gists{/gist_id}","starred_url":"https://api.github.com/users/omercs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omercs/subscriptions","organizations_url":"https://api.github.com/users/omercs/orgs","repos_url":"https://api.github.com/users/omercs/repos","events_url":"https://api.github.com/users/omercs/events{/privacy}","received_events_url":"https://api.github.com/users/omercs/received_events","type":"User","site_admin":false},"body":"We should also print the message to console if console is available","created_at":"2015-05-27T22:28:32Z","updated_at":"2015-05-27T22:28:32Z","html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122#discussion_r31187354","pull_request_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122","_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments/31187354"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122#discussion_r31187354"},"pull_request":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122"}}},"pull_request":{"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122","id":35679040,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122","diff_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122.diff","patch_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122.patch","issue_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/122","number":122,"state":"open","locked":false,"title":"fix issue #119","user":{"login":"weijjia","id":1166233,"avatar_url":"https://avatars.githubusercontent.com/u/1166233?v=3","gravatar_id":"","url":"https://api.github.com/users/weijjia","html_url":"https://github.com/weijjia","followers_url":"https://api.github.com/users/weijjia/followers","following_url":"https://api.github.com/users/weijjia/following{/other_user}","gists_url":"https://api.github.com/users/weijjia/gists{/gist_id}","starred_url":"https://api.github.com/users/weijjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weijjia/subscriptions","organizations_url":"https://api.github.com/users/weijjia/orgs","repos_url":"https://api.github.com/users/weijjia/repos","events_url":"https://api.github.com/users/weijjia/events{/privacy}","received_events_url":"https://api.github.com/users/weijjia/received_events","type":"User","site_admin":false},"body":"address issue 119\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/AzureAD/azure-activedirectory-library-for-js/pull/122%23issuecomment-103229660%22%2C%20%22https%3A//github.com/AzureAD/azure-activedirectory-library-for-js/pull/122%23issuecomment-103668235%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/AzureAD/azure-activedirectory-library-for-js/pull/122%23issuecomment-103229660%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Hi%20__%40weijjia__%2C%20I%27m%20your%20friendly%20neighborhood%20Microsoft%20Open%20Technologies%2C%20Inc.%20Pull%20Request%20Bot%20%28You%20can%20call%20me%20MSOTBOT%29.%20Thanks%20for%20your%20contribution%21%5Cr%5Cn%20%20%20%20%3Cspan%3E%5Cr%5Cn%20%20%20%20%20%20%20%20In%20order%20for%20us%20to%20evaluate%20and%20accept%20your%20PR%2C%20we%20ask%20that%20you%20sign%20a%20contribution%20license%20agreement.%20It%27s%20all%20electronic%20and%20will%20take%20just%20minutes.%20I%20promise%20there%27s%20no%20faxing.%20https%3A//cla2.msopentech.com.%5Cr%5Cn%20%20%20%20%3C/span%3E%5Cr%5Cn%5Cr%5CnTTYL%2C%20MSOTBOT%3B%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222015-05-18T22%3A14%3A45Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/9519461%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/msotclas%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40weijjia%3A%20Build%20is%20failed%20and%20some%20tests%20are%20failing.%20Can%20you%20fix%20those%20and%20resubmit%3F%22%2C%20%22created_at%22%3A%20%222015-05-19T21%3A10%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/466805%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/omercs%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122#issuecomment-103229660'>General Comment</a></b>\n- <a href='https://github.com/msotclas'><img border=0 src='https://avatars.githubusercontent.com/u/9519461?v=3' height=16 width=16'></a> Hi __@weijjia__, I'm your friendly neighborhood Microsoft Open Technologies, Inc. Pull Request Bot (You can call me MSOTBOT). Thanks for your contribution!\n<span>\nIn order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.msopentech.com.\n</span>\nTTYL, MSOTBOT;\n- <a href='https://github.com/omercs'><img border=0 src='https://avatars.githubusercontent.com/u/466805?v=3' height=16 width=16'></a> @weijjia: Build is failed and some tests are failing. Can you fix those and resubmit?\n\n\n<a href='https://www.codereviewhub.com/AzureAD/azure-activedirectory-library-for-js/pull/122?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/AzureAD/azure-activedirectory-library-for-js/pull/122?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-05-18T22:14:42Z","updated_at":"2015-05-27T22:28:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9eb1b96eb700e01f7e85de43674cafeddad4f3d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122/commits","review_comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122/comments","review_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/122/comments","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/dbb8cc059c3aa8d95f4dc50610353002a45ba7f8","head":{"label":"weijjia:fix_logging","ref":"fix_logging","sha":"dbb8cc059c3aa8d95f4dc50610353002a45ba7f8","user":{"login":"weijjia","id":1166233,"avatar_url":"https://avatars.githubusercontent.com/u/1166233?v=3","gravatar_id":"","url":"https://api.github.com/users/weijjia","html_url":"https://github.com/weijjia","followers_url":"https://api.github.com/users/weijjia/followers","following_url":"https://api.github.com/users/weijjia/following{/other_user}","gists_url":"https://api.github.com/users/weijjia/gists{/gist_id}","starred_url":"https://api.github.com/users/weijjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weijjia/subscriptions","organizations_url":"https://api.github.com/users/weijjia/orgs","repos_url":"https://api.github.com/users/weijjia/repos","events_url":"https://api.github.com/users/weijjia/events{/privacy}","received_events_url":"https://api.github.com/users/weijjia/received_events","type":"User","site_admin":false},"repo":{"id":35062975,"name":"azure-activedirectory-library-for-js","full_name":"weijjia/azure-activedirectory-library-for-js","owner":{"login":"weijjia","id":1166233,"avatar_url":"https://avatars.githubusercontent.com/u/1166233?v=3","gravatar_id":"","url":"https://api.github.com/users/weijjia","html_url":"https://github.com/weijjia","followers_url":"https://api.github.com/users/weijjia/followers","following_url":"https://api.github.com/users/weijjia/following{/other_user}","gists_url":"https://api.github.com/users/weijjia/gists{/gist_id}","starred_url":"https://api.github.com/users/weijjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weijjia/subscriptions","organizations_url":"https://api.github.com/users/weijjia/orgs","repos_url":"https://api.github.com/users/weijjia/repos","events_url":"https://api.github.com/users/weijjia/events{/privacy}","received_events_url":"https://api.github.com/users/weijjia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/weijjia/azure-activedirectory-library-for-js","description":"","fork":true,"url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js","forks_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/forks","keys_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/teams","hooks_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/hooks","issue_events_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/issues/events{/number}","events_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/events","assignees_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/assignees{/user}","branches_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/branches{/branch}","tags_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/tags","blobs_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/statuses/{sha}","languages_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/languages","stargazers_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/stargazers","contributors_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/contributors","subscribers_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/subscribers","subscription_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/subscription","commits_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/contents/{+path}","compare_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/merges","archive_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/downloads","issues_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/issues{/number}","pulls_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/pulls{/number}","milestones_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/milestones{/number}","notifications_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/labels{/name}","releases_url":"https://api.github.com/repos/weijjia/azure-activedirectory-library-for-js/releases{/id}","created_at":"2015-05-04T22:17:31Z","updated_at":"2015-05-04T22:17:31Z","pushed_at":"2015-05-20T01:12:25Z","git_url":"git://github.com/weijjia/azure-activedirectory-library-for-js.git","ssh_url":"git@github.com:weijjia/azure-activedirectory-library-for-js.git","clone_url":"https://github.com/weijjia/azure-activedirectory-library-for-js.git","svn_url":"https://github.com/weijjia/azure-activedirectory-library-for-js","homepage":null,"size":1145,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AzureAD:dev","ref":"dev","sha":"1c8df3d4c4474f8938f221c81c5fad2ca132c603","user":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"repo":{"id":19990198,"name":"azure-activedirectory-library-for-js","full_name":"AzureAD/azure-activedirectory-library-for-js","owner":{"login":"AzureAD","id":2966316,"avatar_url":"https://avatars.githubusercontent.com/u/2966316?v=3","gravatar_id":"","url":"https://api.github.com/users/AzureAD","html_url":"https://github.com/AzureAD","followers_url":"https://api.github.com/users/AzureAD/followers","following_url":"https://api.github.com/users/AzureAD/following{/other_user}","gists_url":"https://api.github.com/users/AzureAD/gists{/gist_id}","starred_url":"https://api.github.com/users/AzureAD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzureAD/subscriptions","organizations_url":"https://api.github.com/users/AzureAD/orgs","repos_url":"https://api.github.com/users/AzureAD/repos","events_url":"https://api.github.com/users/AzureAD/events{/privacy}","received_events_url":"https://api.github.com/users/AzureAD/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js","description":"","fork":false,"url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js","forks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/forks","keys_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/teams","hooks_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/hooks","issue_events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/events{/number}","events_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/events","assignees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/assignees{/user}","branches_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/branches{/branch}","tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/tags","blobs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/{sha}","languages_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/languages","stargazers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/stargazers","contributors_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/contributors","subscribers_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/subscribers","subscription_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/subscription","commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/contents/{+path}","compare_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/merges","archive_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/downloads","issues_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues{/number}","pulls_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls{/number}","milestones_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/milestones{/number}","notifications_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/labels{/name}","releases_url":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/releases{/id}","created_at":"2014-05-20T17:21:41Z","updated_at":"2015-05-22T13:01:35Z","pushed_at":"2015-05-22T10:28:04Z","git_url":"git://github.com/AzureAD/azure-activedirectory-library-for-js.git","ssh_url":"git@github.com:AzureAD/azure-activedirectory-library-for-js.git","clone_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js.git","svn_url":"https://github.com/AzureAD/azure-activedirectory-library-for-js","homepage":null,"size":2218,"stargazers_count":53,"watchers_count":53,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":29,"forks":25,"open_issues":29,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122"},"html":{"href":"https://github.com/AzureAD/azure-activedirectory-library-for-js/pull/122"},"issue":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/122"},"comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/issues/122/comments"},"review_comments":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122/comments"},"review_comment":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/pulls/122/commits"},"statuses":{"href":"https://api.github.com/repos/AzureAD/azure-activedirectory-library-for-js/statuses/dbb8cc059c3aa8d95f4dc50610353002a45ba7f8"}}}}