{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/46659992","id":46659992,"diff_hunk":"@@ -372,14 +611,34 @@ TEE_Result elf_load_body(struct elf_load_state *state, vaddr_t vabase)\n \t\treturn res;\n \n \tif (state->shdr) {\n-\t\t/* Process relocation */\n-\t\tfor (n = 0; n < ehdr->e_shnum; n++) {\n-\t\t\tif (state->shdr[n].sh_type == SHT_RELA)\n-\t\t\t\treturn TEE_ERROR_NOT_IMPLEMENTED;\n-\t\t\telse if (state->shdr[n].sh_type == SHT_REL) {\n-\t\t\t\tres = elf_process_rel(state, n, vabase);\n-\t\t\t\tif (res != TEE_SUCCESS)\n-\t\t\t\t\treturn res;\n+\t\tif (state->is_32bit) {\n+\t\t\tElf32_Ehdr *ehdr = state->ehdr;\n+\t\t\tElf32_Shdr *shdr = state->shdr;\n+\n+\t\t\t/* Process relocation */\n+\t\t\tfor (n = 0; n < ehdr->e_shnum; n++) {\n+\t\t\t\tif (shdr[n].sh_type == SHT_RELA)\n+\t\t\t\t\treturn TEE_ERROR_NOT_IMPLEMENTED;\n+\t\t\t\telse if (shdr[n].sh_type == SHT_REL) {\n+\t\t\t\t\tres = e32_process_rel(state, n, vabase);\n+\t\t\t\t\tif (res != TEE_SUCCESS)\n+\t\t\t\t\t\treturn res;\n+\t\t\t\t}\n+\t\t\t}\n+\t\t} else {\n+\t\t\tElf64_Ehdr *ehdr = state->ehdr;\n+\t\t\tElf64_Shdr *shdr = state->shdr;\n+\n+\t\t\t/* Process relocation */\n+\t\t\tfor (n = 0; n < ehdr->e_shnum; n++) {\n+\t\t\t\tif (shdr[n].sh_type == SHT_RELA) {\n+\t\t\t\t\tres = e64_process_rela(state, n,","path":"core/arch/arm/kernel/elf_load.c","position":497,"original_position":497,"commit_id":"f66a1263801358a348eb64fc9aa0b800582d3412","original_commit_id":"f66a1263801358a348eb64fc9aa0b800582d3412","user":{"login":"pascal-brand-st-dev","id":6542303,"avatar_url":"https://avatars.githubusercontent.com/u/6542303?v=3","gravatar_id":"","url":"https://api.github.com/users/pascal-brand-st-dev","html_url":"https://github.com/pascal-brand-st-dev","followers_url":"https://api.github.com/users/pascal-brand-st-dev/followers","following_url":"https://api.github.com/users/pascal-brand-st-dev/following{/other_user}","gists_url":"https://api.github.com/users/pascal-brand-st-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pascal-brand-st-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pascal-brand-st-dev/subscriptions","organizations_url":"https://api.github.com/users/pascal-brand-st-dev/orgs","repos_url":"https://api.github.com/users/pascal-brand-st-dev/repos","events_url":"https://api.github.com/users/pascal-brand-st-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pascal-brand-st-dev/received_events","type":"User","site_admin":false},"body":"same remark as above on the macro, adding the change in the function exx_process_rela","created_at":"2015-12-04T08:46:59Z","updated_at":"2015-12-04T08:46:59Z","html_url":"https://github.com/OP-TEE/optee_os/pull/572#discussion_r46659992","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/46659992"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/572#discussion_r46659992"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572","id":52511510,"html_url":"https://github.com/OP-TEE/optee_os/pull/572","diff_url":"https://github.com/OP-TEE/optee_os/pull/572.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/572.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/572","number":572,"state":"open","locked":false,"title":"Ta64 4","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"body":"This PR finally enables running 64-bit TAs","created_at":"2015-12-03T09:48:08Z","updated_at":"2015-12-04T08:46:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"753d7a9e21924b3536c4605c0cb0f0157f55303a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/572/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/f66a1263801358a348eb64fc9aa0b800582d3412","head":{"label":"jenswi-linaro:ta64-4","ref":"ta64-4","sha":"f66a1263801358a348eb64fc9aa0b800582d3412","user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"repo":{"id":20770355,"name":"optee_os","full_name":"jenswi-linaro/optee_os","owner":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jenswi-linaro/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/jenswi-linaro/optee_os","forks_url":"https://api.github.com/repos/jenswi-linaro/optee_os/forks","keys_url":"https://api.github.com/repos/jenswi-linaro/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenswi-linaro/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenswi-linaro/optee_os/teams","hooks_url":"https://api.github.com/repos/jenswi-linaro/optee_os/hooks","issue_events_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/jenswi-linaro/optee_os/events","assignees_url":"https://api.github.com/repos/jenswi-linaro/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/jenswi-linaro/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/jenswi-linaro/optee_os/tags","blobs_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenswi-linaro/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/jenswi-linaro/optee_os/languages","stargazers_url":"https://api.github.com/repos/jenswi-linaro/optee_os/stargazers","contributors_url":"https://api.github.com/repos/jenswi-linaro/optee_os/contributors","subscribers_url":"https://api.github.com/repos/jenswi-linaro/optee_os/subscribers","subscription_url":"https://api.github.com/repos/jenswi-linaro/optee_os/subscription","commits_url":"https://api.github.com/repos/jenswi-linaro/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenswi-linaro/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenswi-linaro/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenswi-linaro/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/jenswi-linaro/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenswi-linaro/optee_os/merges","archive_url":"https://api.github.com/repos/jenswi-linaro/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenswi-linaro/optee_os/downloads","issues_url":"https://api.github.com/repos/jenswi-linaro/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/jenswi-linaro/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/jenswi-linaro/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/jenswi-linaro/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenswi-linaro/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/jenswi-linaro/optee_os/releases{/id}","created_at":"2014-06-12T14:26:39Z","updated_at":"2015-05-07T19:34:05Z","pushed_at":"2015-12-03T09:45:50Z","git_url":"git://github.com/jenswi-linaro/optee_os.git","ssh_url":"git@github.com:jenswi-linaro/optee_os.git","clone_url":"https://github.com/jenswi-linaro/optee_os.git","svn_url":"https://github.com/jenswi-linaro/optee_os","homepage":null,"size":3826,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"aeb7886322293f2512d2f277edf6d785f570e406","user":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"avatar_url":"https://avatars.githubusercontent.com/u/7488961?v=3","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","created_at":"2014-05-26T17:18:57Z","updated_at":"2015-12-03T20:17:57Z","pushed_at":"2015-12-03T17:59:46Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":7665,"stargazers_count":78,"watchers_count":78,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":24,"forks":77,"open_issues":24,"watchers":78,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/572"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/572"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/f66a1263801358a348eb64fc9aa0b800582d3412"}}}}