{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-router/issues/2003","labels_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2003/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2003/comments","events_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2003/events","html_url":"https://github.com/angular-ui/ui-router/pull/2003","id":82635099,"number":2003,"title":"fix(ui-view): change $viewContentLoading to pair with $viewContentLoaded","user":{"login":"metamatt","id":313893,"avatar_url":"https://avatars.githubusercontent.com/u/313893?v=3","gravatar_id":"","url":"https://api.github.com/users/metamatt","html_url":"https://github.com/metamatt","followers_url":"https://api.github.com/users/metamatt/followers","following_url":"https://api.github.com/users/metamatt/following{/other_user}","gists_url":"https://api.github.com/users/metamatt/gists{/gist_id}","starred_url":"https://api.github.com/users/metamatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metamatt/subscriptions","organizations_url":"https://api.github.com/users/metamatt/orgs","repos_url":"https://api.github.com/users/metamatt/repos","events_url":"https://api.github.com/users/metamatt/events{/privacy}","received_events_url":"https://api.github.com/users/metamatt/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/ui-router/milestones/12","html_url":"https://github.com/angular-ui/ui-router/milestones/0.2.16","labels_url":"https://api.github.com/repos/angular-ui/ui-router/milestones/12/labels","id":1116814,"number":12,"title":"0.2.16","description":"Schedule a release to catch up any bugs fixes in the 0.2.x series","creator":{"login":"christopherthielen","id":2053478,"avatar_url":"https://avatars.githubusercontent.com/u/2053478?v=3","gravatar_id":"","url":"https://api.github.com/users/christopherthielen","html_url":"https://github.com/christopherthielen","followers_url":"https://api.github.com/users/christopherthielen/followers","following_url":"https://api.github.com/users/christopherthielen/following{/other_user}","gists_url":"https://api.github.com/users/christopherthielen/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherthielen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherthielen/subscriptions","organizations_url":"https://api.github.com/users/christopherthielen/orgs","repos_url":"https://api.github.com/users/christopherthielen/repos","events_url":"https://api.github.com/users/christopherthielen/events{/privacy}","received_events_url":"https://api.github.com/users/christopherthielen/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":21,"state":"open","created_at":"2015-05-19T01:17:06Z","updated_at":"2015-10-13T15:31:24Z","due_on":"2015-07-01T05:00:00Z","closed_at":null},"comments":9,"created_at":"2015-05-29T23:55:32Z","updated_at":"2015-10-22T16:50:06Z","closed_at":"2015-08-11T13:26:16Z","pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-router/pulls/2003","html_url":"https://github.com/angular-ui/ui-router/pull/2003","diff_url":"https://github.com/angular-ui/ui-router/pull/2003.diff","patch_url":"https://github.com/angular-ui/ui-router/pull/2003.patch"},"body":"The old $viewContentLoaded event wasn't needed for the one internal\r\nclient (ui-view) because ui-view always ignores that event and acts on\r\na $stateChangeSuccess event that follows right behind anyway.\r\n\r\nAnd it wasn't as useful to external clients as it could be because\r\nit wasn't delivered on every view update -- it was delivered only\r\non state transitions that activate a state defining a view, and\r\ndidn't deal with inheritance.\r\n\r\nAlso, neither $viewContentLoading nor $viewContentLoaded events\r\ncontained the name of the view loading or loaded.\r\n\r\nThis change makes $viewContentLoading and $viewContentLoaded be\r\nemitted always in pairs, before/after updateView does the work of\r\nactually loading the view, and both events include the name of the\r\nview being loaded.\r\n\r\nThis is a breaking change for users of the old $viewContentLoading\r\nevent that relied on it being broadcast from the root scope, the\r\nprecise time it was broadcast, the fact that it wasn't always sent\r\nwhen a view is loaded even if $viewContentLoaded will be sent, or the\r\n\"options\" parameter that was emitted with it. If people rely on any of\r\nthat behavior and we can't break it, then we can restore the old\r\nbehavior but I think there needs to be some other event which is\r\nreliably paired with $viewContentLoaded and contains the view name,\r\nand I can't think of a better name than $viewContentLoading for that\r\nevent.\r\n\r\nCloses #685."},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-router/issues/comments/150287373","html_url":"https://github.com/angular-ui/ui-router/pull/2003#issuecomment-150287373","issue_url":"https://api.github.com/repos/angular-ui/ui-router/issues/2003","id":150287373,"user":{"login":"rcollette","id":136476,"avatar_url":"https://avatars.githubusercontent.com/u/136476?v=3","gravatar_id":"","url":"https://api.github.com/users/rcollette","html_url":"https://github.com/rcollette","followers_url":"https://api.github.com/users/rcollette/followers","following_url":"https://api.github.com/users/rcollette/following{/other_user}","gists_url":"https://api.github.com/users/rcollette/gists{/gist_id}","starred_url":"https://api.github.com/users/rcollette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcollette/subscriptions","organizations_url":"https://api.github.com/users/rcollette/orgs","repos_url":"https://api.github.com/users/rcollette/repos","events_url":"https://api.github.com/users/rcollette/events{/privacy}","received_events_url":"https://api.github.com/users/rcollette/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T16:50:06Z","updated_at":"2015-10-22T16:50:06Z","body":"+1  Need a release.  The lack of consistent event pairs is a problem for me."}}