{"action":"created","issue":{"url":"https://api.github.com/repos/functionaljava/functionaljava/issues/144","labels_url":"https://api.github.com/repos/functionaljava/functionaljava/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/functionaljava/functionaljava/issues/144/comments","events_url":"https://api.github.com/repos/functionaljava/functionaljava/issues/144/events","html_url":"https://github.com/functionaljava/functionaljava/pull/144","id":83441939,"number":144,"title":"Fixed bug in FingerTree.append(). Added PropertyTestRunner","user":{"login":"orionll","id":761899,"avatar_url":"https://avatars.githubusercontent.com/u/761899?v=3","gravatar_id":"","url":"https://api.github.com/users/orionll","html_url":"https://github.com/orionll","followers_url":"https://api.github.com/users/orionll/followers","following_url":"https://api.github.com/users/orionll/following{/other_user}","gists_url":"https://api.github.com/users/orionll/gists{/gist_id}","starred_url":"https://api.github.com/users/orionll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orionll/subscriptions","organizations_url":"https://api.github.com/users/orionll/orgs","repos_url":"https://api.github.com/users/orionll/repos","events_url":"https://api.github.com/users/orionll/events{/privacy}","received_events_url":"https://api.github.com/users/orionll/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-06-01T11:12:57Z","updated_at":"2015-06-04T10:02:22Z","closed_at":"2015-06-04T09:18:05Z","pull_request":{"url":"https://api.github.com/repos/functionaljava/functionaljava/pulls/144","html_url":"https://github.com/functionaljava/functionaljava/pull/144","diff_url":"https://github.com/functionaljava/functionaljava/pull/144.diff","patch_url":"https://github.com/functionaljava/functionaljava/pull/144.patch"},"body":"Guys, I have a suggestion. FunctionalJava has a decent property based testing framework (fj.test), but it is not used in FunctionalJava. Instead, ScalaCheck is used. I think, we should rewrite all properties to fj.test and remove ScalaCheck dependency.\r\n\r\nHere are some advantages of this approach:\r\n* Test classes will be a good example of fj.test usage for programmers that use FunctionalJava.\r\n* It will test fj.test.* classes themselves.\r\n* Programmers will trust fj.test more.\r\n* Scala dependency will be redundant.\r\n\r\nDon't get me wrong. I like Scala, but FunctionalJava is a library for Java and it should use Java as much as possible.\r\n\r\nI've implemented `PropertyTestRunner` which integrates JUnit with fj.test. All classes that are marked with `RunWith(PropertyTestRunner)` will be executed during the Gradle build. `SeqProperties` is an example of a class with properties (you can run it directly from IDEA too).\r\n\r\nI'm open for discussion."},"comment":{"url":"https://api.github.com/repos/functionaljava/functionaljava/issues/comments/108817663","html_url":"https://github.com/functionaljava/functionaljava/pull/144#issuecomment-108817663","issue_url":"https://api.github.com/repos/functionaljava/functionaljava/issues/144","id":108817663,"user":{"login":"mperry","id":641771,"avatar_url":"https://avatars.githubusercontent.com/u/641771?v=3","gravatar_id":"","url":"https://api.github.com/users/mperry","html_url":"https://github.com/mperry","followers_url":"https://api.github.com/users/mperry/followers","following_url":"https://api.github.com/users/mperry/following{/other_user}","gists_url":"https://api.github.com/users/mperry/gists{/gist_id}","starred_url":"https://api.github.com/users/mperry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mperry/subscriptions","organizations_url":"https://api.github.com/users/mperry/orgs","repos_url":"https://api.github.com/users/mperry/repos","events_url":"https://api.github.com/users/mperry/events{/privacy}","received_events_url":"https://api.github.com/users/mperry/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T10:02:22Z","updated_at":"2015-06-04T10:02:22Z","body":"I am going to try to split this out now.  See #147."}}