{"action":"created","comment":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/29541853","id":29541853,"diff_hunk":"@@ -0,0 +1,58 @@\n+#region Copyright & License Information\n+/*\n+ * Copyright 2007-2015 The OpenRA Developers (see AUTHORS)\n+ * This file is part of OpenRA, which is free software. It is made\n+ * available to you under the terms of the GNU General Public License\n+ * as published by the Free Software Foundation. For more information,\n+ * see COPYING.\n+ */\n+#endregion\n+\n+using OpenRA.Graphics;\n+using OpenRA.Mods.Common.Traits;\n+using OpenRA.Traits;\n+\n+namespace OpenRA.Mods.TS.Traits\n+{\n+\t[Desc(\"Rendered together with AttackCharge.\")]\n+\tpublic class WithChargeOverlayInfo : ITraitInfo, Requires<RenderSpritesInfo>\n+\t{\n+\t\t[Desc(\"Sequence name to use\")]\n+\t\tpublic readonly string Sequence = \"active\";\n+\n+\t\t[Desc(\"Custom palette name\")]\n+\t\tpublic readonly string Palette = null;\n+\n+\t\t[Desc(\"Custom palette is a player palette BaseName\")]\n+\t\tpublic readonly bool IsPlayerPalette = false;\n+\n+\t\tpublic object Create(ActorInitializer init) { return new WithChargeOverlay(init, this); }\n+\t}\n+\n+\tpublic class WithChargeOverlay : INotifyCharging","path":"OpenRA.Mods.TS/Traits/Render/WithChargeOverlay.cs","position":32,"original_position":32,"commit_id":"130bfdc2a2afde69124d72a47063aa08ae9b26ed","original_commit_id":"130bfdc2a2afde69124d72a47063aa08ae9b26ed","user":{"login":"pchote","id":167819,"avatar_url":"https://avatars.githubusercontent.com/u/167819?v=3","gravatar_id":"","url":"https://api.github.com/users/pchote","html_url":"https://github.com/pchote","followers_url":"https://api.github.com/users/pchote/followers","following_url":"https://api.github.com/users/pchote/following{/other_user}","gists_url":"https://api.github.com/users/pchote/gists{/gist_id}","starred_url":"https://api.github.com/users/pchote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pchote/subscriptions","organizations_url":"https://api.github.com/users/pchote/orgs","repos_url":"https://api.github.com/users/pchote/repos","events_url":"https://api.github.com/users/pchote/events{/privacy}","received_events_url":"https://api.github.com/users/pchote/received_events","type":"User","site_admin":false},"body":"Modders (and maybe even the RA2 prism towers?) will want support for damaged charging overlays.  I suggest implementing `INotifyDamageStateChanged` now (see `WithIdleOverlay` for more details).","created_at":"2015-05-01T23:56:04Z","updated_at":"2015-05-01T23:56:04Z","html_url":"https://github.com/OpenRA/OpenRA/pull/7982#discussion_r29541853","pull_request_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982","_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments/29541853"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/7982#discussion_r29541853"},"pull_request":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982"}}},"pull_request":{"url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982","id":33616320,"html_url":"https://github.com/OpenRA/OpenRA/pull/7982","diff_url":"https://github.com/OpenRA/OpenRA/pull/7982.diff","patch_url":"https://github.com/OpenRA/OpenRA/pull/7982.patch","issue_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7982","number":7982,"state":"open","locked":false,"title":"Added the Tiberian Sun Nod Obelisk charge animation","user":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=3","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"body":"I was forced to do a lot of cleanup, but that isn't necessarily a bad thing.","created_at":"2015-04-19T09:53:55Z","updated_at":"2015-05-01T23:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6c96f3b1cf8aabf3d63d24f65c115d0cd9fd4c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982/commits","review_comments_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982/comments","review_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/7982/comments","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/130bfdc2a2afde69124d72a47063aa08ae9b26ed","head":{"label":"Mailaender:ts-obelisk","ref":"ts-obelisk","sha":"130bfdc2a2afde69124d72a47063aa08ae9b26ed","user":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=3","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"repo":{"id":3886414,"name":"OpenRA","full_name":"Mailaender/OpenRA","owner":{"login":"Mailaender","id":756669,"avatar_url":"https://avatars.githubusercontent.com/u/756669?v=3","gravatar_id":"","url":"https://api.github.com/users/Mailaender","html_url":"https://github.com/Mailaender","followers_url":"https://api.github.com/users/Mailaender/followers","following_url":"https://api.github.com/users/Mailaender/following{/other_user}","gists_url":"https://api.github.com/users/Mailaender/gists{/gist_id}","starred_url":"https://api.github.com/users/Mailaender/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mailaender/subscriptions","organizations_url":"https://api.github.com/users/Mailaender/orgs","repos_url":"https://api.github.com/users/Mailaender/repos","events_url":"https://api.github.com/users/Mailaender/events{/privacy}","received_events_url":"https://api.github.com/users/Mailaender/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mailaender/OpenRA","description":"An open-source implementation of the Red Alert engine using .NET/mono and OpenGL. Runs on Windows, Linux and OSX.","fork":true,"url":"https://api.github.com/repos/Mailaender/OpenRA","forks_url":"https://api.github.com/repos/Mailaender/OpenRA/forks","keys_url":"https://api.github.com/repos/Mailaender/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mailaender/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mailaender/OpenRA/teams","hooks_url":"https://api.github.com/repos/Mailaender/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/Mailaender/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/Mailaender/OpenRA/events","assignees_url":"https://api.github.com/repos/Mailaender/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/Mailaender/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/Mailaender/OpenRA/tags","blobs_url":"https://api.github.com/repos/Mailaender/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mailaender/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mailaender/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mailaender/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mailaender/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/Mailaender/OpenRA/languages","stargazers_url":"https://api.github.com/repos/Mailaender/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/Mailaender/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/Mailaender/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/Mailaender/OpenRA/subscription","commits_url":"https://api.github.com/repos/Mailaender/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mailaender/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mailaender/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mailaender/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mailaender/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/Mailaender/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mailaender/OpenRA/merges","archive_url":"https://api.github.com/repos/Mailaender/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mailaender/OpenRA/downloads","issues_url":"https://api.github.com/repos/Mailaender/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/Mailaender/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/Mailaender/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/Mailaender/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mailaender/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/Mailaender/OpenRA/releases{/id}","created_at":"2012-03-31T15:36:43Z","updated_at":"2014-12-20T08:50:16Z","pushed_at":"2015-05-01T20:29:52Z","git_url":"git://github.com/Mailaender/OpenRA.git","ssh_url":"git@github.com:Mailaender/OpenRA.git","clone_url":"https://github.com/Mailaender/OpenRA.git","svn_url":"https://github.com/Mailaender/OpenRA","homepage":"http://www.openra.net","size":123848,"stargazers_count":6,"watchers_count":6,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":6,"default_branch":"bleed"}},"base":{"label":"OpenRA:bleed","ref":"bleed","sha":"3cda61a13a031731837f46708c75289a7a4b05f1","user":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"repo":{"id":959908,"name":"OpenRA","full_name":"OpenRA/OpenRA","owner":{"login":"OpenRA","id":409046,"avatar_url":"https://avatars.githubusercontent.com/u/409046?v=3","gravatar_id":"","url":"https://api.github.com/users/OpenRA","html_url":"https://github.com/OpenRA","followers_url":"https://api.github.com/users/OpenRA/followers","following_url":"https://api.github.com/users/OpenRA/following{/other_user}","gists_url":"https://api.github.com/users/OpenRA/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenRA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenRA/subscriptions","organizations_url":"https://api.github.com/users/OpenRA/orgs","repos_url":"https://api.github.com/users/OpenRA/repos","events_url":"https://api.github.com/users/OpenRA/events{/privacy}","received_events_url":"https://api.github.com/users/OpenRA/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OpenRA/OpenRA","description":"An open-source implementation of the Command & Conquer: Red Alert engine using .NET/Mono and OpenGL. Runs on Windows, Linux and Mac OS X.","fork":false,"url":"https://api.github.com/repos/OpenRA/OpenRA","forks_url":"https://api.github.com/repos/OpenRA/OpenRA/forks","keys_url":"https://api.github.com/repos/OpenRA/OpenRA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenRA/OpenRA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenRA/OpenRA/teams","hooks_url":"https://api.github.com/repos/OpenRA/OpenRA/hooks","issue_events_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/events{/number}","events_url":"https://api.github.com/repos/OpenRA/OpenRA/events","assignees_url":"https://api.github.com/repos/OpenRA/OpenRA/assignees{/user}","branches_url":"https://api.github.com/repos/OpenRA/OpenRA/branches{/branch}","tags_url":"https://api.github.com/repos/OpenRA/OpenRA/tags","blobs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenRA/OpenRA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenRA/OpenRA/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenRA/OpenRA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenRA/OpenRA/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenRA/OpenRA/languages","stargazers_url":"https://api.github.com/repos/OpenRA/OpenRA/stargazers","contributors_url":"https://api.github.com/repos/OpenRA/OpenRA/contributors","subscribers_url":"https://api.github.com/repos/OpenRA/OpenRA/subscribers","subscription_url":"https://api.github.com/repos/OpenRA/OpenRA/subscription","commits_url":"https://api.github.com/repos/OpenRA/OpenRA/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenRA/OpenRA/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenRA/OpenRA/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenRA/OpenRA/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenRA/OpenRA/contents/{+path}","compare_url":"https://api.github.com/repos/OpenRA/OpenRA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenRA/OpenRA/merges","archive_url":"https://api.github.com/repos/OpenRA/OpenRA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenRA/OpenRA/downloads","issues_url":"https://api.github.com/repos/OpenRA/OpenRA/issues{/number}","pulls_url":"https://api.github.com/repos/OpenRA/OpenRA/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenRA/OpenRA/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenRA/OpenRA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenRA/OpenRA/labels{/name}","releases_url":"https://api.github.com/repos/OpenRA/OpenRA/releases{/id}","created_at":"2010-10-04T07:38:05Z","updated_at":"2015-05-01T22:24:08Z","pushed_at":"2015-05-01T23:45:07Z","git_url":"git://github.com/OpenRA/OpenRA.git","ssh_url":"git@github.com:OpenRA/OpenRA.git","clone_url":"https://github.com/OpenRA/OpenRA.git","svn_url":"https://github.com/OpenRA/OpenRA","homepage":"http://www.openra.net","size":172321,"stargazers_count":1884,"watchers_count":1884,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":684,"mirror_url":null,"open_issues_count":796,"forks":684,"open_issues":796,"watchers":1884,"default_branch":"bleed"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982"},"html":{"href":"https://github.com/OpenRA/OpenRA/pull/7982"},"issue":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/7982"},"comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/issues/7982/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenRA/OpenRA/pulls/7982/commits"},"statuses":{"href":"https://api.github.com/repos/OpenRA/OpenRA/statuses/130bfdc2a2afde69124d72a47063aa08ae9b26ed"}}}}