{"action":"created","issue":{"url":"https://api.github.com/repos/knockout/knockout/issues/1622","labels_url":"https://api.github.com/repos/knockout/knockout/issues/1622/labels{/name}","comments_url":"https://api.github.com/repos/knockout/knockout/issues/1622/comments","events_url":"https://api.github.com/repos/knockout/knockout/issues/1622/events","html_url":"https://github.com/knockout/knockout/pull/1622","id":49114048,"number":1622,"title":"long chains without overflowing the stack fails on FF 10-23","user":{"login":"brianmhunt","id":135528,"avatar_url":"https://avatars.githubusercontent.com/u/135528?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmhunt","html_url":"https://github.com/brianmhunt","followers_url":"https://api.github.com/users/brianmhunt/followers","following_url":"https://api.github.com/users/brianmhunt/following{/other_user}","gists_url":"https://api.github.com/users/brianmhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmhunt/subscriptions","organizations_url":"https://api.github.com/users/brianmhunt/orgs","repos_url":"https://api.github.com/users/brianmhunt/repos","events_url":"https://api.github.com/users/brianmhunt/events{/privacy}","received_events_url":"https://api.github.com/users/brianmhunt/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/knockout/knockout/labels/affected:%20few","name":"affected: few","color":"b0d8b0"},{"url":"https://api.github.com/repos/knockout/knockout/labels/severity:%20minor","name":"severity: minor","color":"e17d81"},{"url":"https://api.github.com/repos/knockout/knockout/labels/type:%20bug","name":"type: bug","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/knockout/knockout/milestones/8","html_url":"https://github.com/knockout/knockout/milestones/3.4.0","labels_url":"https://api.github.com/repos/knockout/knockout/milestones/8/labels","id":926494,"number":8,"title":"3.4.0","description":null,"creator":{"login":"brianmhunt","id":135528,"avatar_url":"https://avatars.githubusercontent.com/u/135528?v=3","gravatar_id":"","url":"https://api.github.com/users/brianmhunt","html_url":"https://github.com/brianmhunt","followers_url":"https://api.github.com/users/brianmhunt/followers","following_url":"https://api.github.com/users/brianmhunt/following{/other_user}","gists_url":"https://api.github.com/users/brianmhunt/gists{/gist_id}","starred_url":"https://api.github.com/users/brianmhunt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianmhunt/subscriptions","organizations_url":"https://api.github.com/users/brianmhunt/orgs","repos_url":"https://api.github.com/users/brianmhunt/repos","events_url":"https://api.github.com/users/brianmhunt/events{/privacy}","received_events_url":"https://api.github.com/users/brianmhunt/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":34,"state":"open","created_at":"2015-01-08T01:57:00Z","updated_at":"2015-09-15T18:37:31Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2014-11-17T16:42:08Z","updated_at":"2015-09-24T03:33:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/knockout/knockout/pulls/1622","html_url":"https://github.com/knockout/knockout/pull/1622","diff_url":"https://github.com/knockout/knockout/pull/1622.diff","patch_url":"https://github.com/knockout/knockout/pull/1622.patch"},"body":"The test [Dependent Observable Should allow long chains without overflowing the stack](https://github.com/knockout/knockout/blob/05f4cdcbd2ba653f06ec19240fc100056c5e006b/spec/dependentObservableBehaviors.js#L486) fails [on FF 10-23](https://travis-ci.org/brianmhunt/knockout#L654) with `InternalError: too much recusion`.\r\n\r\nNoting: #358 & #359."},"comment":{"url":"https://api.github.com/repos/knockout/knockout/issues/comments/142796647","html_url":"https://github.com/knockout/knockout/pull/1622#issuecomment-142796647","issue_url":"https://api.github.com/repos/knockout/knockout/issues/1622","id":142796647,"user":{"login":"mbest","id":1230364,"avatar_url":"https://avatars.githubusercontent.com/u/1230364?v=3","gravatar_id":"","url":"https://api.github.com/users/mbest","html_url":"https://github.com/mbest","followers_url":"https://api.github.com/users/mbest/followers","following_url":"https://api.github.com/users/mbest/following{/other_user}","gists_url":"https://api.github.com/users/mbest/gists{/gist_id}","starred_url":"https://api.github.com/users/mbest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbest/subscriptions","organizations_url":"https://api.github.com/users/mbest/orgs","repos_url":"https://api.github.com/users/mbest/repos","events_url":"https://api.github.com/users/mbest/events{/privacy}","received_events_url":"https://api.github.com/users/mbest/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T03:33:17Z","updated_at":"2015-09-24T03:33:17Z","body":"I've made a further commit to undo some of my previous changes. This keeps the logic of moving the \"change\" notification to `evaluatePossiblyAsync`, reducing a couple layers of function calls from the recursion. This still requires reducing the depth value in the test to make it pass but allows for a greater depth than doing nothing."}}