{"action":"created","comment":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/30833971","id":30833971,"diff_hunk":"@@ -2441,57 +2497,17 @@ public final Boolean call(T first, T second) {\n     }\n \n     /**\n-     * Returns an Observable that emits a {@code 0L} after the {@code initialDelay} and ever increasing numbers\n-     * after each {@code period} of time thereafter.\n-     * <p>\n-     * <img width=\"640\" height=\"200\" src=\"https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/timer.p.png\" alt=\"\">\n-     * <dl>\n-     *  <dt><b>Backpressure Support:</b></dt>\n-     *  <dd>This operator does not support backpressure as it uses time. If the downstream needs a slower rate\n-     *      it should slow the timer or use something like {@link #onBackpressureDrop}.</dd>\n-     *  <dt><b>Scheduler:</b></dt>\n-     *  <dd>{@code timer} operates by default on the {@code computation} {@link Scheduler}.</dd>\n-     * </dl>\n-     * \n-     * @param initialDelay\n-     *            the initial delay time to wait before emitting the first value of 0L\n-     * @param period\n-     *            the period of time between emissions of the subsequent numbers\n-     * @param unit\n-     *            the time unit for both {@code initialDelay} and {@code period}\n-     * @return an Observable that emits a 0L after the {@code initialDelay} and ever increasing numbers after\n-     *         each {@code period} of time thereafter\n-     * @see <a href=\"http://reactivex.io/documentation/operators/timer.html\">ReactiveX operators documentation: Timer</a>","path":"src/main/java/rx/Observable.java","position":98,"original_position":98,"commit_id":"47f4400a64e01bcc4f7a3c918e2642c5dad4491f","original_commit_id":"47f4400a64e01bcc4f7a3c918e2642c5dad4491f","user":{"login":"DavidMGross","id":4491168,"avatar_url":"https://avatars.githubusercontent.com/u/4491168?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidMGross","html_url":"https://github.com/DavidMGross","followers_url":"https://api.github.com/users/DavidMGross/followers","following_url":"https://api.github.com/users/DavidMGross/following{/other_user}","gists_url":"https://api.github.com/users/DavidMGross/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidMGross/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidMGross/subscriptions","organizations_url":"https://api.github.com/users/DavidMGross/orgs","repos_url":"https://api.github.com/users/DavidMGross/repos","events_url":"https://api.github.com/users/DavidMGross/events{/privacy}","received_events_url":"https://api.github.com/users/DavidMGross/received_events","type":"User","site_admin":false},"body":"I'd recommend leaving the documentation in place even when deprecating the method.","created_at":"2015-05-21T18:46:02Z","updated_at":"2015-05-21T18:46:02Z","html_url":"https://github.com/ReactiveX/RxJava/pull/2975#discussion_r30833971","pull_request_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975","_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments/30833971"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/2975#discussion_r30833971"},"pull_request":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975"}}},"pull_request":{"url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975","id":35855863,"html_url":"https://github.com/ReactiveX/RxJava/pull/2975","diff_url":"https://github.com/ReactiveX/RxJava/pull/2975.diff","patch_url":"https://github.com/ReactiveX/RxJava/pull/2975.patch","issue_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2975","number":2975,"state":"open","locked":false,"title":"Deprecate and rename two timer overloads to interval","user":{"login":"abersnaze","id":406038,"avatar_url":"https://avatars.githubusercontent.com/u/406038?v=3","gravatar_id":"","url":"https://api.github.com/users/abersnaze","html_url":"https://github.com/abersnaze","followers_url":"https://api.github.com/users/abersnaze/followers","following_url":"https://api.github.com/users/abersnaze/following{/other_user}","gists_url":"https://api.github.com/users/abersnaze/gists{/gist_id}","starred_url":"https://api.github.com/users/abersnaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abersnaze/subscriptions","organizations_url":"https://api.github.com/users/abersnaze/orgs","repos_url":"https://api.github.com/users/abersnaze/repos","events_url":"https://api.github.com/users/abersnaze/events{/privacy}","received_events_url":"https://api.github.com/users/abersnaze/received_events","type":"User","site_admin":false},"body":"The existing six methods below didn't make sense and caused some confusion.\r\n\r\n```\r\ntimer(delay, timeUnit[, scheduler]);  --> emits 0 after delay and completes\r\ntimer(delay, period, timeUnit[, scheduler]); --> emits 0 after delay and then i++ after every period forever\r\ninterval(period, timeUnit[, schduler); --> emits i++ after every period forever\r\n```\r\n\r\nI felt that the middle method acted more like the third method `interval` than first method `timer`.  This PR is to make this change.\r\n\r\n```\r\n timer(delay, timeUnit[, scheduler]);  --> emits 0 after delay and completes\r\n+@Deprecated\r\n timer(delay, period, timeUnit[, scheduler]); --> emits 0 after delay and then i++ after every period forever\r\n+interval(delay, period, timeUnit[, scheduler]); --> emits 0 after delay and then i++ after every period forever\r\n interval(period, timeUnit[, schduler); --> emits i++ after every period forever\r\n```\r\n\r\nPS: yes, I understand that we can't delete the deprecated timer method.\r\n@davgross and if this PR is merged will have to change the images.","created_at":"2015-05-20T17:25:56Z","updated_at":"2015-05-21T18:46:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8ab9bcf407848a697efaa4314565a782d224a0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975/commits","review_comments_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975/comments","review_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/2975/comments","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/47f4400a64e01bcc4f7a3c918e2642c5dad4491f","head":{"label":"abersnaze:interval","ref":"interval","sha":"47f4400a64e01bcc4f7a3c918e2642c5dad4491f","user":{"login":"abersnaze","id":406038,"avatar_url":"https://avatars.githubusercontent.com/u/406038?v=3","gravatar_id":"","url":"https://api.github.com/users/abersnaze","html_url":"https://github.com/abersnaze","followers_url":"https://api.github.com/users/abersnaze/followers","following_url":"https://api.github.com/users/abersnaze/following{/other_user}","gists_url":"https://api.github.com/users/abersnaze/gists{/gist_id}","starred_url":"https://api.github.com/users/abersnaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abersnaze/subscriptions","organizations_url":"https://api.github.com/users/abersnaze/orgs","repos_url":"https://api.github.com/users/abersnaze/repos","events_url":"https://api.github.com/users/abersnaze/events{/privacy}","received_events_url":"https://api.github.com/users/abersnaze/received_events","type":"User","site_admin":false},"repo":{"id":7616124,"name":"RxJava","full_name":"abersnaze/RxJava","owner":{"login":"abersnaze","id":406038,"avatar_url":"https://avatars.githubusercontent.com/u/406038?v=3","gravatar_id":"","url":"https://api.github.com/users/abersnaze","html_url":"https://github.com/abersnaze","followers_url":"https://api.github.com/users/abersnaze/followers","following_url":"https://api.github.com/users/abersnaze/following{/other_user}","gists_url":"https://api.github.com/users/abersnaze/gists{/gist_id}","starred_url":"https://api.github.com/users/abersnaze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abersnaze/subscriptions","organizations_url":"https://api.github.com/users/abersnaze/orgs","repos_url":"https://api.github.com/users/abersnaze/repos","events_url":"https://api.github.com/users/abersnaze/events{/privacy}","received_events_url":"https://api.github.com/users/abersnaze/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abersnaze/RxJava","description":"","fork":true,"url":"https://api.github.com/repos/abersnaze/RxJava","forks_url":"https://api.github.com/repos/abersnaze/RxJava/forks","keys_url":"https://api.github.com/repos/abersnaze/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abersnaze/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abersnaze/RxJava/teams","hooks_url":"https://api.github.com/repos/abersnaze/RxJava/hooks","issue_events_url":"https://api.github.com/repos/abersnaze/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/abersnaze/RxJava/events","assignees_url":"https://api.github.com/repos/abersnaze/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/abersnaze/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/abersnaze/RxJava/tags","blobs_url":"https://api.github.com/repos/abersnaze/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abersnaze/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abersnaze/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/abersnaze/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abersnaze/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/abersnaze/RxJava/languages","stargazers_url":"https://api.github.com/repos/abersnaze/RxJava/stargazers","contributors_url":"https://api.github.com/repos/abersnaze/RxJava/contributors","subscribers_url":"https://api.github.com/repos/abersnaze/RxJava/subscribers","subscription_url":"https://api.github.com/repos/abersnaze/RxJava/subscription","commits_url":"https://api.github.com/repos/abersnaze/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/abersnaze/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/abersnaze/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/abersnaze/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/abersnaze/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/abersnaze/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abersnaze/RxJava/merges","archive_url":"https://api.github.com/repos/abersnaze/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abersnaze/RxJava/downloads","issues_url":"https://api.github.com/repos/abersnaze/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/abersnaze/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/abersnaze/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/abersnaze/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abersnaze/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/abersnaze/RxJava/releases{/id}","created_at":"2013-01-15T01:05:07Z","updated_at":"2014-06-30T17:51:06Z","pushed_at":"2015-05-20T17:13:43Z","git_url":"git://github.com/abersnaze/RxJava.git","ssh_url":"git@github.com:abersnaze/RxJava.git","clone_url":"https://github.com/abersnaze/RxJava.git","svn_url":"https://github.com/abersnaze/RxJava","homepage":null,"size":17548,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactiveX:1.x","ref":"1.x","sha":"eccc8c45728df705707b77e91f8db72f44313d71","user":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"repo":{"id":7508411,"name":"RxJava","full_name":"ReactiveX/RxJava","owner":{"login":"ReactiveX","id":6407041,"avatar_url":"https://avatars.githubusercontent.com/u/6407041?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactiveX","html_url":"https://github.com/ReactiveX","followers_url":"https://api.github.com/users/ReactiveX/followers","following_url":"https://api.github.com/users/ReactiveX/following{/other_user}","gists_url":"https://api.github.com/users/ReactiveX/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactiveX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactiveX/subscriptions","organizations_url":"https://api.github.com/users/ReactiveX/orgs","repos_url":"https://api.github.com/users/ReactiveX/repos","events_url":"https://api.github.com/users/ReactiveX/events{/privacy}","received_events_url":"https://api.github.com/users/ReactiveX/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactiveX/RxJava","description":"RxJava – Reactive Extensions for the JVM – a library for composing asynchronous and event-based programs using observable sequences for the Java VM.","fork":false,"url":"https://api.github.com/repos/ReactiveX/RxJava","forks_url":"https://api.github.com/repos/ReactiveX/RxJava/forks","keys_url":"https://api.github.com/repos/ReactiveX/RxJava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactiveX/RxJava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactiveX/RxJava/teams","hooks_url":"https://api.github.com/repos/ReactiveX/RxJava/hooks","issue_events_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/events{/number}","events_url":"https://api.github.com/repos/ReactiveX/RxJava/events","assignees_url":"https://api.github.com/repos/ReactiveX/RxJava/assignees{/user}","branches_url":"https://api.github.com/repos/ReactiveX/RxJava/branches{/branch}","tags_url":"https://api.github.com/repos/ReactiveX/RxJava/tags","blobs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactiveX/RxJava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactiveX/RxJava/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactiveX/RxJava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactiveX/RxJava/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactiveX/RxJava/languages","stargazers_url":"https://api.github.com/repos/ReactiveX/RxJava/stargazers","contributors_url":"https://api.github.com/repos/ReactiveX/RxJava/contributors","subscribers_url":"https://api.github.com/repos/ReactiveX/RxJava/subscribers","subscription_url":"https://api.github.com/repos/ReactiveX/RxJava/subscription","commits_url":"https://api.github.com/repos/ReactiveX/RxJava/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactiveX/RxJava/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactiveX/RxJava/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactiveX/RxJava/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactiveX/RxJava/contents/{+path}","compare_url":"https://api.github.com/repos/ReactiveX/RxJava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactiveX/RxJava/merges","archive_url":"https://api.github.com/repos/ReactiveX/RxJava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactiveX/RxJava/downloads","issues_url":"https://api.github.com/repos/ReactiveX/RxJava/issues{/number}","pulls_url":"https://api.github.com/repos/ReactiveX/RxJava/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactiveX/RxJava/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactiveX/RxJava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactiveX/RxJava/labels{/name}","releases_url":"https://api.github.com/repos/ReactiveX/RxJava/releases{/id}","created_at":"2013-01-08T20:11:48Z","updated_at":"2015-05-21T16:48:57Z","pushed_at":"2015-05-20T23:54:04Z","git_url":"git://github.com/ReactiveX/RxJava.git","ssh_url":"git@github.com:ReactiveX/RxJava.git","clone_url":"https://github.com/ReactiveX/RxJava.git","svn_url":"https://github.com/ReactiveX/RxJava","homepage":"","size":395759,"stargazers_count":5732,"watchers_count":5732,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":794,"mirror_url":null,"open_issues_count":123,"forks":794,"open_issues":123,"watchers":5732,"default_branch":"1.x"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975"},"html":{"href":"https://github.com/ReactiveX/RxJava/pull/2975"},"issue":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/2975"},"comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/issues/2975/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactiveX/RxJava/pulls/2975/commits"},"statuses":{"href":"https://api.github.com/repos/ReactiveX/RxJava/statuses/47f4400a64e01bcc4f7a3c918e2642c5dad4491f"}}}}