{"action":"closed","number":1016,"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/1016","id":46301606,"html_url":"https://github.com/mozilla/treeherder/pull/1016","diff_url":"https://github.com/mozilla/treeherder/pull/1016.diff","patch_url":"https://github.com/mozilla/treeherder/pull/1016.patch","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/1016","number":1016,"state":"closed","locked":false,"title":"Bug 1209079 - Make all dropdowns use a pointer cursor","user":{"login":"tojonmz","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojonmz","html_url":"https://github.com/tojonmz","followers_url":"https://api.github.com/users/tojonmz/followers","following_url":"https://api.github.com/users/tojonmz/following{/other_user}","gists_url":"https://api.github.com/users/tojonmz/gists{/gist_id}","starred_url":"https://api.github.com/users/tojonmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojonmz/subscriptions","organizations_url":"https://api.github.com/users/tojonmz/orgs","repos_url":"https://api.github.com/users/tojonmz/repos","events_url":"https://api.github.com/users/tojonmz/events{/privacy}","received_events_url":"https://api.github.com/users/tojonmz/received_events","type":"User","site_admin":false},"body":"This tweak fixes Bugzilla bug [1209079](https://bugzilla.mozilla.org/show_bug.cgi?id=1209079).\r\n\r\nThis makes all dropdowns present with a pointer cursor, even if they don't contain an `href` in the markup. I don't think we want to stick empty hrefs into the menus to fix them, since you'd get context menus to \"Open this link in a new window\" which don't go anywhere.\r\n\r\nSo instead we add a global property to `treeherder-global.css` which provides `pointer` for:\r\n\r\n* Navbar > Logout\r\n* Pinboard > Save ^\r\n* Info Panel > Retrigger ^\r\n\r\nEverything seems fine in local testing. Other dropdowns which *do* have an href do their own thing, and present with a pointer anyway (Treeherder > Logo menu, Logviewer > Logo menu).\r\n\r\nTested on OSX 10.10.5:\r\nRelease **44.0a1 (2015-09-29)**\r\nChrome Latest Release **45.0.2454.101 (64-bit)**\r\n\r\nAdding @camd for review.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mozilla/treeherder/1016)\n<!-- Reviewable:end -->\n","created_at":"2015-09-29T16:39:12Z","updated_at":"2015-09-29T21:13:13Z","closed_at":"2015-09-29T21:13:13Z","merged_at":"2015-09-29T21:13:13Z","merge_commit_sha":"eae57dd8ff3eb5a5accc052b6429fffd8871b74f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1016/commits","review_comments_url":"https://api.github.com/repos/mozilla/treeherder/pulls/1016/comments","review_comment_url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/1016/comments","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/1804a4fae415dbda27a9b7d9be6ae975a9c25a43","head":{"label":"tojonmz:cursor-pointer-menus","ref":"cursor-pointer-menus","sha":"1804a4fae415dbda27a9b7d9be6ae975a9c25a43","user":{"login":"tojonmz","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojonmz","html_url":"https://github.com/tojonmz","followers_url":"https://api.github.com/users/tojonmz/followers","following_url":"https://api.github.com/users/tojonmz/following{/other_user}","gists_url":"https://api.github.com/users/tojonmz/gists{/gist_id}","starred_url":"https://api.github.com/users/tojonmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojonmz/subscriptions","organizations_url":"https://api.github.com/users/tojonmz/orgs","repos_url":"https://api.github.com/users/tojonmz/repos","events_url":"https://api.github.com/users/tojonmz/events{/privacy}","received_events_url":"https://api.github.com/users/tojonmz/received_events","type":"User","site_admin":false},"repo":{"id":22761777,"name":"treeherder","full_name":"tojonmz/treeherder","owner":{"login":"tojonmz","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojonmz","html_url":"https://github.com/tojonmz","followers_url":"https://api.github.com/users/tojonmz/followers","following_url":"https://api.github.com/users/tojonmz/following{/other_user}","gists_url":"https://api.github.com/users/tojonmz/gists{/gist_id}","starred_url":"https://api.github.com/users/tojonmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojonmz/subscriptions","organizations_url":"https://api.github.com/users/tojonmz/orgs","repos_url":"https://api.github.com/users/tojonmz/repos","events_url":"https://api.github.com/users/tojonmz/events{/privacy}","received_events_url":"https://api.github.com/users/tojonmz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tojonmz/treeherder","description":"The backend of treeherder, a replacement for TBPL. See wiki page for where to file bugs.","fork":true,"url":"https://api.github.com/repos/tojonmz/treeherder","forks_url":"https://api.github.com/repos/tojonmz/treeherder/forks","keys_url":"https://api.github.com/repos/tojonmz/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tojonmz/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tojonmz/treeherder/teams","hooks_url":"https://api.github.com/repos/tojonmz/treeherder/hooks","issue_events_url":"https://api.github.com/repos/tojonmz/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/tojonmz/treeherder/events","assignees_url":"https://api.github.com/repos/tojonmz/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/tojonmz/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/tojonmz/treeherder/tags","blobs_url":"https://api.github.com/repos/tojonmz/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tojonmz/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tojonmz/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/tojonmz/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tojonmz/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/tojonmz/treeherder/languages","stargazers_url":"https://api.github.com/repos/tojonmz/treeherder/stargazers","contributors_url":"https://api.github.com/repos/tojonmz/treeherder/contributors","subscribers_url":"https://api.github.com/repos/tojonmz/treeherder/subscribers","subscription_url":"https://api.github.com/repos/tojonmz/treeherder/subscription","commits_url":"https://api.github.com/repos/tojonmz/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/tojonmz/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/tojonmz/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/tojonmz/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/tojonmz/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/tojonmz/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tojonmz/treeherder/merges","archive_url":"https://api.github.com/repos/tojonmz/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tojonmz/treeherder/downloads","issues_url":"https://api.github.com/repos/tojonmz/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/tojonmz/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/tojonmz/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/tojonmz/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tojonmz/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/tojonmz/treeherder/releases{/id}","created_at":"2014-08-08T15:11:51Z","updated_at":"2015-04-28T21:02:11Z","pushed_at":"2015-09-29T21:06:04Z","git_url":"git://github.com/tojonmz/treeherder.git","ssh_url":"git@github.com:tojonmz/treeherder.git","clone_url":"https://github.com/tojonmz/treeherder.git","svn_url":"https://github.com/tojonmz/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":38270,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"bb7fac66ed6c7c720a86f2063bf751c5a02924a5","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8463294,"name":"treeherder","full_name":"mozilla/treeherder","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/treeherder","description":"A reporting dashboard & service for managing CI data for commits to Mozilla projects","fork":false,"url":"https://api.github.com/repos/mozilla/treeherder","forks_url":"https://api.github.com/repos/mozilla/treeherder/forks","keys_url":"https://api.github.com/repos/mozilla/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/treeherder/teams","hooks_url":"https://api.github.com/repos/mozilla/treeherder/hooks","issue_events_url":"https://api.github.com/repos/mozilla/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/treeherder/events","assignees_url":"https://api.github.com/repos/mozilla/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/treeherder/tags","blobs_url":"https://api.github.com/repos/mozilla/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/treeherder/languages","stargazers_url":"https://api.github.com/repos/mozilla/treeherder/stargazers","contributors_url":"https://api.github.com/repos/mozilla/treeherder/contributors","subscribers_url":"https://api.github.com/repos/mozilla/treeherder/subscribers","subscription_url":"https://api.github.com/repos/mozilla/treeherder/subscription","commits_url":"https://api.github.com/repos/mozilla/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/treeherder/merges","archive_url":"https://api.github.com/repos/mozilla/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/treeherder/downloads","issues_url":"https://api.github.com/repos/mozilla/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/treeherder/releases{/id}","created_at":"2013-02-27T19:17:37Z","updated_at":"2015-09-20T07:28:19Z","pushed_at":"2015-09-29T21:13:11Z","git_url":"git://github.com/mozilla/treeherder.git","ssh_url":"git@github.com:mozilla/treeherder.git","clone_url":"https://github.com/mozilla/treeherder.git","svn_url":"https://github.com/mozilla/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":406975,"stargazers_count":28,"watchers_count":28,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":29,"forks":68,"open_issues":29,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1016"},"html":{"href":"https://github.com/mozilla/treeherder/pull/1016"},"issue":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/1016"},"comments":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/1016/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1016/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/1016/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/treeherder/statuses/1804a4fae415dbda27a9b7d9be6ae975a9c25a43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tojonmz","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojonmz","html_url":"https://github.com/tojonmz","followers_url":"https://api.github.com/users/tojonmz/followers","following_url":"https://api.github.com/users/tojonmz/following{/other_user}","gists_url":"https://api.github.com/users/tojonmz/gists{/gist_id}","starred_url":"https://api.github.com/users/tojonmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojonmz/subscriptions","organizations_url":"https://api.github.com/users/tojonmz/orgs","repos_url":"https://api.github.com/users/tojonmz/repos","events_url":"https://api.github.com/users/tojonmz/events{/privacy}","received_events_url":"https://api.github.com/users/tojonmz/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":4,"deletions":5,"changed_files":2}}