{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/treeherder/issues/1051","labels_url":"https://api.github.com/repos/mozilla/treeherder/issues/1051/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/1051/comments","events_url":"https://api.github.com/repos/mozilla/treeherder/issues/1051/events","html_url":"https://github.com/mozilla/treeherder/pull/1051","id":110707600,"number":1051,"title":"Add integration between autoclassification and manual starring.","user":{"login":"jgraham","id":294864,"avatar_url":"https://avatars.githubusercontent.com/u/294864?v=3","gravatar_id":"","url":"https://api.github.com/users/jgraham","html_url":"https://github.com/jgraham","followers_url":"https://api.github.com/users/jgraham/followers","following_url":"https://api.github.com/users/jgraham/following{/other_user}","gists_url":"https://api.github.com/users/jgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraham/subscriptions","organizations_url":"https://api.github.com/users/jgraham/orgs","repos_url":"https://api.github.com/users/jgraham/repos","events_url":"https://api.github.com/users/jgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jgraham/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-09T17:53:39Z","updated_at":"2015-10-22T10:51:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/1051","html_url":"https://github.com/mozilla/treeherder/pull/1051","diff_url":"https://github.com/mozilla/treeherder/pull/1051.diff","patch_url":"https://github.com/mozilla/treeherder/pull/1051.patch"},"body":"This adds a new FailureClassification for autoclassified\r\nintermittent. When a job is completely classified by the\r\nautoclassifer, and it has the same number of structured and\r\nunstructured error lines, it is marked as an autoclassified\r\nintermittent.\r\n\r\nConversely, when there is exactly one structured and one unstructured\r\nerror line, the autoclassifier did not match the job, but has a\r\ndetector that could match the job, and the job is marked as\r\nintermittent by a human, add a new autoclassification target\r\ncorresponding to the error line.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mozilla/treeherder/1051)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/mozilla/treeherder/issues/comments/150178809","html_url":"https://github.com/mozilla/treeherder/pull/1051#issuecomment-150178809","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/1051","id":150178809,"user":{"login":"maurodoglio","id":508377,"avatar_url":"https://avatars.githubusercontent.com/u/508377?v=3","gravatar_id":"","url":"https://api.github.com/users/maurodoglio","html_url":"https://github.com/maurodoglio","followers_url":"https://api.github.com/users/maurodoglio/followers","following_url":"https://api.github.com/users/maurodoglio/following{/other_user}","gists_url":"https://api.github.com/users/maurodoglio/gists{/gist_id}","starred_url":"https://api.github.com/users/maurodoglio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maurodoglio/subscriptions","organizations_url":"https://api.github.com/users/maurodoglio/orgs","repos_url":"https://api.github.com/users/maurodoglio/repos","events_url":"https://api.github.com/users/maurodoglio/events{/privacy}","received_events_url":"https://api.github.com/users/maurodoglio/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T10:51:55Z","updated_at":"2015-10-22T10:51:55Z","body":"\n\n\n\nReviewed 1 of 9 files at r1, 6 of 10 files at r3, 2 of 2 files at r4, 2 of 2 files at r5.\nReview status: all files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.\n\n---\n\n<sup>**[tests/conftest.py, line 456 \\[r4\\]](https://reviewable.io:443/reviews/mozilla/treeherder/1051#-K1E8wr2UFGeyIRnulMp)** ([raw file](https://github.com/mozilla/treeherder/blob/96d5881419fe5e8b17abf9f9d81973bd88c236f6/tests/conftest.py#L456)):</sup>\nthere's no need to save the repository, it was created with Repository.objects.create() in the test_repository fixture\n<!-- Reviewable comment -K1E8wr2UFGeyIRnulMq:-854146532 -->\n\n---\n\n<sup>**[treeherder/model/derived/jobs.py, line 523 \\[r2\\]](https://reviewable.io:443/reviews/mozilla/treeherder/1051#-K0g-s0ex9gcmxLV3VfN)** ([raw file](https://github.com/mozilla/treeherder/blob/6b08baddd1e0a2045f1ba9555ed5c963aca8a1ed/treeherder/model/derived/jobs.py#L523)):</sup>\nI still don't get it. Why there's a limit of 35 elements when you only need one? There should never be more than one element here. All the bug suggestions should be in the same artifact.\n<!-- Reviewable comment -K1E0PTaKAgEVHK4wfeU:1914473470 -->\n\n---\n\n<sup>**[treeherder/model/models.py, line 611 \\[r4\\]](https://reviewable.io:443/reviews/mozilla/treeherder/1051#-K1E2Phkw09W2uzA4dhP)** ([raw file](https://github.com/mozilla/treeherder/blob/96d5881419fe5e8b17abf9f9d81973bd88c236f6/treeherder/model/models.py#L611)):</sup>\nwhat about renaming this to 'get_best_for_line' ?\n<!-- Reviewable comment -K1E2Phkw09W2uzA4dhQ:235918099 -->\n\n---\n\n<sup>**[treeherder/model/models.py, line 615 \\[r4\\]](https://reviewable.io:443/reviews/mozilla/treeherder/1051#-K1E2ES_D3VIFGKIY2IJ)** ([raw file](https://github.com/mozilla/treeherder/blob/96d5881419fe5e8b17abf9f9d81973bd88c236f6/treeherder/model/models.py#L615)):</sup>\nYou can pass the same arguments directly to .get(). Don't need to use filter here.\n<!-- Reviewable comment -K1E2ES_D3VIFGKIY2IK:-1005156564 -->\n\n---\n\n<sup>**[treeherder/model/models.py, line 725 \\[r4\\]](https://reviewable.io:443/reviews/mozilla/treeherder/1051#-K1E6JIeEIJ2oBn_Ev9-)** ([raw file](https://github.com/mozilla/treeherder/blob/96d5881419fe5e8b17abf9f9d81973bd88c236f6/treeherder/model/models.py#L725)):</sup>\nthis change will probably require a new migration. can you check that using the following command?\n```bash\npython manage.py makemigrations\n```\nIf it does generate a new migration file, you will need to add it to this patch\n<!-- Reviewable comment -K1E6JIeEIJ2oBn_Ev90:2115695825 -->\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/mozilla/treeherder/1051)\n<!-- Sent from Reviewable.io -->\n"}}