{"action":"created","comment":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/47393054","id":47393054,"diff_hunk":"@@ -98,8 +99,10 @@ public ModuleDeploymentId deploy(ModuleDeploymentRequest request) {\n \t\t\t\tworkDir.toFile().deleteOnExit();\r\n \t\t\t}\r\n \t\t\tfor (int i = 0; i < request.getCount(); i++) {\r\n-\t\t\t\tint port = SocketUtils.findAvailableTcpPort(DEFAULT_SERVER_PORT);\r\n-\t\t\t\targs.put(SERVER_PORT_KEY, String.valueOf(port));\r\n+\t\t\t\tif (useDynamicPort) {\r\n+\t\t\t\t\tint port = SocketUtils.findAvailableTcpPort(DEFAULT_SERVER_PORT);\r\n+\t\t\t\t\targs.put(SERVER_PORT_KEY, String.valueOf(port));\r","path":"spring-cloud-dataflow-admin-local/src/main/java/org/springframework/cloud/dataflow/admin/spi/local/OutOfProcessModuleDeployer.java","position":16,"original_position":16,"commit_id":"0f555bf76c375fef63036807806ddc5778c57a55","original_commit_id":"0f555bf76c375fef63036807806ddc5778c57a55","user":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"body":"The qualified value should be put here.","created_at":"2015-12-11T19:20:20Z","updated_at":"2015-12-11T19:20:20Z","html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/225#discussion_r47393054","pull_request_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225","_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments/47393054"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/225#discussion_r47393054"},"pull_request":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225","id":53271641,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/225","diff_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/225.diff","patch_url":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/225.patch","issue_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/225","number":225,"state":"open","locked":false,"title":"Don't override user set port","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-12-10T15:19:38Z","updated_at":"2015-12-11T19:20:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1399d98fe26f17bb5b619985e31b9bd3d101c0c1","assignee":{"login":"mbogoevici","id":159684,"avatar_url":"https://avatars.githubusercontent.com/u/159684?v=3","gravatar_id":"","url":"https://api.github.com/users/mbogoevici","html_url":"https://github.com/mbogoevici","followers_url":"https://api.github.com/users/mbogoevici/followers","following_url":"https://api.github.com/users/mbogoevici/following{/other_user}","gists_url":"https://api.github.com/users/mbogoevici/gists{/gist_id}","starred_url":"https://api.github.com/users/mbogoevici/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbogoevici/subscriptions","organizations_url":"https://api.github.com/users/mbogoevici/orgs","repos_url":"https://api.github.com/users/mbogoevici/repos","events_url":"https://api.github.com/users/mbogoevici/events{/privacy}","received_events_url":"https://api.github.com/users/mbogoevici/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225/commits","review_comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225/comments","review_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/225/comments","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/0f555bf76c375fef63036807806ddc5778c57a55","head":{"label":"ericbottard:UseDynamicPortOutOfProcess","ref":"UseDynamicPortOutOfProcess","sha":"0f555bf76c375fef63036807806ddc5778c57a55","user":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"repo":{"id":40243328,"name":"spring-cloud-dataflow","full_name":"ericbottard/spring-cloud-dataflow","owner":{"login":"ericbottard","id":313494,"avatar_url":"https://avatars.githubusercontent.com/u/313494?v=3","gravatar_id":"","url":"https://api.github.com/users/ericbottard","html_url":"https://github.com/ericbottard","followers_url":"https://api.github.com/users/ericbottard/followers","following_url":"https://api.github.com/users/ericbottard/following{/other_user}","gists_url":"https://api.github.com/users/ericbottard/gists{/gist_id}","starred_url":"https://api.github.com/users/ericbottard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericbottard/subscriptions","organizations_url":"https://api.github.com/users/ericbottard/orgs","repos_url":"https://api.github.com/users/ericbottard/repos","events_url":"https://api.github.com/users/ericbottard/events{/privacy}","received_events_url":"https://api.github.com/users/ericbottard/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericbottard/spring-cloud-dataflow","description":"","fork":true,"url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/ericbottard/spring-cloud-dataflow/releases{/id}","created_at":"2015-08-05T12:13:08Z","updated_at":"2015-09-07T07:14:40Z","pushed_at":"2015-12-11T16:40:58Z","git_url":"git://github.com/ericbottard/spring-cloud-dataflow.git","ssh_url":"git@github.com:ericbottard/spring-cloud-dataflow.git","clone_url":"https://github.com/ericbottard/spring-cloud-dataflow.git","svn_url":"https://github.com/ericbottard/spring-cloud-dataflow","homepage":null,"size":1199,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-cloud:master","ref":"master","sha":"83440f9256b4533d620c268729e663d2bb606fc5","user":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":39469487,"name":"spring-cloud-dataflow","full_name":"spring-cloud/spring-cloud-dataflow","owner":{"login":"spring-cloud","id":7815877,"avatar_url":"https://avatars.githubusercontent.com/u/7815877?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-cloud","html_url":"https://github.com/spring-cloud","followers_url":"https://api.github.com/users/spring-cloud/followers","following_url":"https://api.github.com/users/spring-cloud/following{/other_user}","gists_url":"https://api.github.com/users/spring-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-cloud/subscriptions","organizations_url":"https://api.github.com/users/spring-cloud/orgs","repos_url":"https://api.github.com/users/spring-cloud/repos","events_url":"https://api.github.com/users/spring-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/spring-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-cloud/spring-cloud-dataflow","description":"Spring Cloud Data Flow provides orchestration for data microservices, including both stream and task processing","fork":false,"url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow","forks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/forks","keys_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/teams","hooks_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/hooks","issue_events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/events{/number}","events_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/events","assignees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/assignees{/user}","branches_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/branches{/branch}","tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/tags","blobs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/languages","stargazers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/stargazers","contributors_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contributors","subscribers_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscribers","subscription_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/subscription","commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/contents/{+path}","compare_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/merges","archive_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/downloads","issues_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues{/number}","pulls_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/labels{/name}","releases_url":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/releases{/id}","created_at":"2015-07-21T20:56:11Z","updated_at":"2015-11-20T17:58:34Z","pushed_at":"2015-12-11T16:41:30Z","git_url":"git://github.com/spring-cloud/spring-cloud-dataflow.git","ssh_url":"git@github.com:spring-cloud/spring-cloud-dataflow.git","clone_url":"https://github.com/spring-cloud/spring-cloud-dataflow.git","svn_url":"https://github.com/spring-cloud/spring-cloud-dataflow","homepage":"http://cloud.spring.io/spring-cloud-dataflow/","size":2123,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":32,"mirror_url":null,"open_issues_count":53,"forks":32,"open_issues":53,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225"},"html":{"href":"https://github.com/spring-cloud/spring-cloud-dataflow/pull/225"},"issue":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/225"},"comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/spring-cloud/spring-cloud-dataflow/statuses/0f555bf76c375fef63036807806ddc5778c57a55"}}}}