{"action":"created","comment":{"url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/comments/46319996","id":46319996,"diff_hunk":"@@ -336,14 +321,21 @@ private void setStatusIcons(MessageRecord messageRecord) {\n \n     if      (messageRecord.isFailed())                     setFailedStatusIcons();\n     else if (messageRecord.isPendingInsecureSmsFallback()) setFallbackStatusIcons();\n-    else if (messageRecord.isPending())                    statusManager.displayPending();\n-    else if (messageRecord.isDelivered())                  statusManager.displayDelivered();\n-    else                                                   statusManager.displaySent();\n+    else {","path":"src/org/thoughtcrime/securesms/ConversationItem.java","position":109,"original_position":109,"commit_id":"02f8fc9054ff6df5450ef125f47f3c6f7897dc61","original_commit_id":"02f8fc9054ff6df5450ef125f47f3c6f7897dc61","user":{"login":"moxie0","id":512439,"avatar_url":"https://avatars.githubusercontent.com/u/512439?v=3","gravatar_id":"","url":"https://api.github.com/users/moxie0","html_url":"https://github.com/moxie0","followers_url":"https://api.github.com/users/moxie0/followers","following_url":"https://api.github.com/users/moxie0/following{/other_user}","gists_url":"https://api.github.com/users/moxie0/gists{/gist_id}","starred_url":"https://api.github.com/users/moxie0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxie0/subscriptions","organizations_url":"https://api.github.com/users/moxie0/orgs","repos_url":"https://api.github.com/users/moxie0/repos","events_url":"https://api.github.com/users/moxie0/events{/privacy}","received_events_url":"https://api.github.com/users/moxie0/received_events","type":"User","site_admin":false},"body":"purely stylistic, but if this one has braces the ones above it need them too. alternately inlined else conditions with setOutgoingStatusIcons, setPendingStatusIcons, etc... would work","created_at":"2015-12-01T18:47:06Z","updated_at":"2015-12-01T18:47:06Z","html_url":"https://github.com/WhisperSystems/Signal-Android/pull/4710#discussion_r46319996","pull_request_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710","_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/comments/46319996"},"html":{"href":"https://github.com/WhisperSystems/Signal-Android/pull/4710#discussion_r46319996"},"pull_request":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710"}}},"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710","id":51719755,"html_url":"https://github.com/WhisperSystems/Signal-Android/pull/4710","diff_url":"https://github.com/WhisperSystems/Signal-Android/pull/4710.diff","patch_url":"https://github.com/WhisperSystems/Signal-Android/pull/4710.patch","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/4710","number":4710,"state":"open","locked":false,"title":"Inbox delivery status icons","user":{"login":"haffenloher","id":264472,"avatar_url":"https://avatars.githubusercontent.com/u/264472?v=3","gravatar_id":"","url":"https://api.github.com/users/haffenloher","html_url":"https://github.com/haffenloher","followers_url":"https://api.github.com/users/haffenloher/followers","following_url":"https://api.github.com/users/haffenloher/following{/other_user}","gists_url":"https://api.github.com/users/haffenloher/gists{/gist_id}","starred_url":"https://api.github.com/users/haffenloher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haffenloher/subscriptions","organizations_url":"https://api.github.com/users/haffenloher/orgs","repos_url":"https://api.github.com/users/haffenloher/repos","events_url":"https://api.github.com/users/haffenloher/events{/privacy}","received_events_url":"https://api.github.com/users/haffenloher/received_events","type":"User","site_admin":false},"body":"This is based on @agrajaghh's nice [mockup](https://github.com/WhisperSystems/Signal-Android/pull/3012#issuecomment-94916759).\r\n\r\n:warning: **This upgrades your database!** :warning:\r\nDon't test this on your main device, you won't be able to roll back easily!\r\n\r\nScreenshot:\r\n\r\n![signal inbox status icons](https://cloud.githubusercontent.com/assets/264472/11381043/fdfa0872-92f9-11e5-9a59-486bbb4d48a2.png)\r\n\r\nFixes #1363\r\nFixes #4049","created_at":"2015-11-24T21:29:56Z","updated_at":"2015-12-01T18:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5df62d76ac5767eff160754eea577dd01a632b3e","assignee":{"login":"moxie0","id":512439,"avatar_url":"https://avatars.githubusercontent.com/u/512439?v=3","gravatar_id":"","url":"https://api.github.com/users/moxie0","html_url":"https://github.com/moxie0","followers_url":"https://api.github.com/users/moxie0/followers","following_url":"https://api.github.com/users/moxie0/following{/other_user}","gists_url":"https://api.github.com/users/moxie0/gists{/gist_id}","starred_url":"https://api.github.com/users/moxie0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxie0/subscriptions","organizations_url":"https://api.github.com/users/moxie0/orgs","repos_url":"https://api.github.com/users/moxie0/repos","events_url":"https://api.github.com/users/moxie0/events{/privacy}","received_events_url":"https://api.github.com/users/moxie0/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/4710/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/statuses/02f8fc9054ff6df5450ef125f47f3c6f7897dc61","head":{"label":"haffenloher:inbox_delivery_status","ref":"inbox_delivery_status","sha":"02f8fc9054ff6df5450ef125f47f3c6f7897dc61","user":{"login":"haffenloher","id":264472,"avatar_url":"https://avatars.githubusercontent.com/u/264472?v=3","gravatar_id":"","url":"https://api.github.com/users/haffenloher","html_url":"https://github.com/haffenloher","followers_url":"https://api.github.com/users/haffenloher/followers","following_url":"https://api.github.com/users/haffenloher/following{/other_user}","gists_url":"https://api.github.com/users/haffenloher/gists{/gist_id}","starred_url":"https://api.github.com/users/haffenloher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haffenloher/subscriptions","organizations_url":"https://api.github.com/users/haffenloher/orgs","repos_url":"https://api.github.com/users/haffenloher/repos","events_url":"https://api.github.com/users/haffenloher/events{/privacy}","received_events_url":"https://api.github.com/users/haffenloher/received_events","type":"User","site_admin":false},"repo":{"id":37158530,"name":"TextSecure","full_name":"haffenloher/TextSecure","owner":{"login":"haffenloher","id":264472,"avatar_url":"https://avatars.githubusercontent.com/u/264472?v=3","gravatar_id":"","url":"https://api.github.com/users/haffenloher","html_url":"https://github.com/haffenloher","followers_url":"https://api.github.com/users/haffenloher/followers","following_url":"https://api.github.com/users/haffenloher/following{/other_user}","gists_url":"https://api.github.com/users/haffenloher/gists{/gist_id}","starred_url":"https://api.github.com/users/haffenloher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haffenloher/subscriptions","organizations_url":"https://api.github.com/users/haffenloher/orgs","repos_url":"https://api.github.com/users/haffenloher/repos","events_url":"https://api.github.com/users/haffenloher/events{/privacy}","received_events_url":"https://api.github.com/users/haffenloher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/haffenloher/TextSecure","description":"A private messenger for Android.","fork":true,"url":"https://api.github.com/repos/haffenloher/TextSecure","forks_url":"https://api.github.com/repos/haffenloher/TextSecure/forks","keys_url":"https://api.github.com/repos/haffenloher/TextSecure/keys{/key_id}","collaborators_url":"https://api.github.com/repos/haffenloher/TextSecure/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/haffenloher/TextSecure/teams","hooks_url":"https://api.github.com/repos/haffenloher/TextSecure/hooks","issue_events_url":"https://api.github.com/repos/haffenloher/TextSecure/issues/events{/number}","events_url":"https://api.github.com/repos/haffenloher/TextSecure/events","assignees_url":"https://api.github.com/repos/haffenloher/TextSecure/assignees{/user}","branches_url":"https://api.github.com/repos/haffenloher/TextSecure/branches{/branch}","tags_url":"https://api.github.com/repos/haffenloher/TextSecure/tags","blobs_url":"https://api.github.com/repos/haffenloher/TextSecure/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/haffenloher/TextSecure/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/haffenloher/TextSecure/git/refs{/sha}","trees_url":"https://api.github.com/repos/haffenloher/TextSecure/git/trees{/sha}","statuses_url":"https://api.github.com/repos/haffenloher/TextSecure/statuses/{sha}","languages_url":"https://api.github.com/repos/haffenloher/TextSecure/languages","stargazers_url":"https://api.github.com/repos/haffenloher/TextSecure/stargazers","contributors_url":"https://api.github.com/repos/haffenloher/TextSecure/contributors","subscribers_url":"https://api.github.com/repos/haffenloher/TextSecure/subscribers","subscription_url":"https://api.github.com/repos/haffenloher/TextSecure/subscription","commits_url":"https://api.github.com/repos/haffenloher/TextSecure/commits{/sha}","git_commits_url":"https://api.github.com/repos/haffenloher/TextSecure/git/commits{/sha}","comments_url":"https://api.github.com/repos/haffenloher/TextSecure/comments{/number}","issue_comment_url":"https://api.github.com/repos/haffenloher/TextSecure/issues/comments{/number}","contents_url":"https://api.github.com/repos/haffenloher/TextSecure/contents/{+path}","compare_url":"https://api.github.com/repos/haffenloher/TextSecure/compare/{base}...{head}","merges_url":"https://api.github.com/repos/haffenloher/TextSecure/merges","archive_url":"https://api.github.com/repos/haffenloher/TextSecure/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/haffenloher/TextSecure/downloads","issues_url":"https://api.github.com/repos/haffenloher/TextSecure/issues{/number}","pulls_url":"https://api.github.com/repos/haffenloher/TextSecure/pulls{/number}","milestones_url":"https://api.github.com/repos/haffenloher/TextSecure/milestones{/number}","notifications_url":"https://api.github.com/repos/haffenloher/TextSecure/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/haffenloher/TextSecure/labels{/name}","releases_url":"https://api.github.com/repos/haffenloher/TextSecure/releases{/id}","created_at":"2015-06-09T21:09:06Z","updated_at":"2015-10-23T20:17:12Z","pushed_at":"2015-12-01T00:50:06Z","git_url":"git://github.com/haffenloher/TextSecure.git","ssh_url":"git@github.com:haffenloher/TextSecure.git","clone_url":"https://github.com/haffenloher/TextSecure.git","svn_url":"https://github.com/haffenloher/TextSecure","homepage":"https://whispersystems.org","size":72602,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"WhisperSystems:master","ref":"master","sha":"bde6c9092df8eb99b1b22fadc96b60f2d37d098b","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":2990192,"name":"Signal-Android","full_name":"WhisperSystems/Signal-Android","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars.githubusercontent.com/u/702459?v=3","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-Android","description":"A private messenger for Android.","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-Android","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-Android/releases{/id}","created_at":"2011-12-15T20:01:12Z","updated_at":"2015-12-01T18:40:16Z","pushed_at":"2015-12-01T16:58:06Z","git_url":"git://github.com/WhisperSystems/Signal-Android.git","ssh_url":"git@github.com:WhisperSystems/Signal-Android.git","clone_url":"https://github.com/WhisperSystems/Signal-Android.git","svn_url":"https://github.com/WhisperSystems/Signal-Android","homepage":"https://whispersystems.org","size":96860,"stargazers_count":5057,"watchers_count":5057,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1456,"mirror_url":null,"open_issues_count":576,"forks":1456,"open_issues":576,"watchers":5057,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710"},"html":{"href":"https://github.com/WhisperSystems/Signal-Android/pull/4710"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/4710"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/issues/4710/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/pulls/4710/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Android/statuses/02f8fc9054ff6df5450ef125f47f3c6f7897dc61"}}}}