{"action":"created","comment":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/34664402","id":34664402,"diff_hunk":"@@ -0,0 +1,32 @@\n+<% content_for :alternate_link do %>\n+  <span></span?","path":"app/views/errors/not_found.html.erb","position":2,"original_position":2,"commit_id":"6bac842d6cef10e5c363b74157a5797a66bf7b0d","original_commit_id":"6bac842d6cef10e5c363b74157a5797a66bf7b0d","user":{"login":"asmega","id":92580,"avatar_url":"https://avatars.githubusercontent.com/u/92580?v=3","gravatar_id":"","url":"https://api.github.com/users/asmega","html_url":"https://github.com/asmega","followers_url":"https://api.github.com/users/asmega/followers","following_url":"https://api.github.com/users/asmega/following{/other_user}","gists_url":"https://api.github.com/users/asmega/gists{/gist_id}","starred_url":"https://api.github.com/users/asmega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asmega/subscriptions","organizations_url":"https://api.github.com/users/asmega/orgs","repos_url":"https://api.github.com/users/asmega/repos","events_url":"https://api.github.com/users/asmega/events{/privacy}","received_events_url":"https://api.github.com/users/asmega/received_events","type":"User","site_admin":false},"body":"syntax error","created_at":"2015-07-15T10:13:17Z","updated_at":"2015-07-15T10:13:17Z","html_url":"https://github.com/moneyadviceservice/frontend/pull/1128#discussion_r34664402","pull_request_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128","_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments/34664402"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/1128#discussion_r34664402"},"pull_request":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128"}}},"pull_request":{"url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128","id":39680924,"html_url":"https://github.com/moneyadviceservice/frontend/pull/1128","diff_url":"https://github.com/moneyadviceservice/frontend/pull/1128.diff","patch_url":"https://github.com/moneyadviceservice/frontend/pull/1128.patch","issue_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1128","number":1128,"state":"open","locked":false,"title":"TP- 6454: add tests for 404 page not found errors","user":{"login":"Tr4pSt3R","id":591781,"avatar_url":"https://avatars.githubusercontent.com/u/591781?v=3","gravatar_id":"","url":"https://api.github.com/users/Tr4pSt3R","html_url":"https://github.com/Tr4pSt3R","followers_url":"https://api.github.com/users/Tr4pSt3R/followers","following_url":"https://api.github.com/users/Tr4pSt3R/following{/other_user}","gists_url":"https://api.github.com/users/Tr4pSt3R/gists{/gist_id}","starred_url":"https://api.github.com/users/Tr4pSt3R/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tr4pSt3R/subscriptions","organizations_url":"https://api.github.com/users/Tr4pSt3R/orgs","repos_url":"https://api.github.com/users/Tr4pSt3R/repos","events_url":"https://api.github.com/users/Tr4pSt3R/events{/privacy}","received_events_url":"https://api.github.com/users/Tr4pSt3R/received_events","type":"User","site_admin":false},"body":"* create page not found template\r\n* guard against nil value for locales\r\n* add custom views for 404/500 error pages\r\n* remove routing rule to catch-all unknown routes as 501\r\n  * this will allow 404 error status to be rendered rather than catching all unknown routes and classifying them as :not_implemented (501) status\r\n\r\nrewrite test to pick up routing error\r\n  * tests were previously checking for 501 errors. But the nature of these\r\n errors were more of a 404 'page not found error'.","created_at":"2015-07-10T12:50:20Z","updated_at":"2015-07-15T10:13:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa09238fb2fdc66bb6914bf91f3afdc6e29cd0df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128/commits","review_comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128/comments","review_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1128/comments","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/6bac842d6cef10e5c363b74157a5797a66bf7b0d","head":{"label":"moneyadviceservice:error-page-routing","ref":"error-page-routing","sha":"6bac842d6cef10e5c363b74157a5797a66bf7b0d","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2015-06-15T15:35:39Z","pushed_at":"2015-07-15T10:09:21Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":37252,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":4,"default_branch":"master"}},"base":{"label":"moneyadviceservice:master","ref":"master","sha":"cea80e7cbbc7c6ea4787105c44f80d26da8cf801","user":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"repo":{"id":15315123,"name":"frontend","full_name":"moneyadviceservice/frontend","owner":{"login":"moneyadviceservice","id":2064781,"avatar_url":"https://avatars.githubusercontent.com/u/2064781?v=3","gravatar_id":"","url":"https://api.github.com/users/moneyadviceservice","html_url":"https://github.com/moneyadviceservice","followers_url":"https://api.github.com/users/moneyadviceservice/followers","following_url":"https://api.github.com/users/moneyadviceservice/following{/other_user}","gists_url":"https://api.github.com/users/moneyadviceservice/gists{/gist_id}","starred_url":"https://api.github.com/users/moneyadviceservice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moneyadviceservice/subscriptions","organizations_url":"https://api.github.com/users/moneyadviceservice/orgs","repos_url":"https://api.github.com/users/moneyadviceservice/repos","events_url":"https://api.github.com/users/moneyadviceservice/events{/privacy}","received_events_url":"https://api.github.com/users/moneyadviceservice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/moneyadviceservice/frontend","description":"The Money Advice Service's improved website.","fork":false,"url":"https://api.github.com/repos/moneyadviceservice/frontend","forks_url":"https://api.github.com/repos/moneyadviceservice/frontend/forks","keys_url":"https://api.github.com/repos/moneyadviceservice/frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/moneyadviceservice/frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/moneyadviceservice/frontend/teams","hooks_url":"https://api.github.com/repos/moneyadviceservice/frontend/hooks","issue_events_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/events{/number}","events_url":"https://api.github.com/repos/moneyadviceservice/frontend/events","assignees_url":"https://api.github.com/repos/moneyadviceservice/frontend/assignees{/user}","branches_url":"https://api.github.com/repos/moneyadviceservice/frontend/branches{/branch}","tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/tags","blobs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/moneyadviceservice/frontend/languages","stargazers_url":"https://api.github.com/repos/moneyadviceservice/frontend/stargazers","contributors_url":"https://api.github.com/repos/moneyadviceservice/frontend/contributors","subscribers_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscribers","subscription_url":"https://api.github.com/repos/moneyadviceservice/frontend/subscription","commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/moneyadviceservice/frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/moneyadviceservice/frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/moneyadviceservice/frontend/contents/{+path}","compare_url":"https://api.github.com/repos/moneyadviceservice/frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/moneyadviceservice/frontend/merges","archive_url":"https://api.github.com/repos/moneyadviceservice/frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/moneyadviceservice/frontend/downloads","issues_url":"https://api.github.com/repos/moneyadviceservice/frontend/issues{/number}","pulls_url":"https://api.github.com/repos/moneyadviceservice/frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/moneyadviceservice/frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/moneyadviceservice/frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/moneyadviceservice/frontend/labels{/name}","releases_url":"https://api.github.com/repos/moneyadviceservice/frontend/releases{/id}","created_at":"2013-12-19T15:25:21Z","updated_at":"2015-06-15T15:35:39Z","pushed_at":"2015-07-15T10:09:21Z","git_url":"git://github.com/moneyadviceservice/frontend.git","ssh_url":"git@github.com:moneyadviceservice/frontend.git","clone_url":"https://github.com/moneyadviceservice/frontend.git","svn_url":"https://github.com/moneyadviceservice/frontend","homepage":"https://www.moneyadviceservice.org.uk  ","size":37252,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":14,"forks":5,"open_issues":14,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128"},"html":{"href":"https://github.com/moneyadviceservice/frontend/pull/1128"},"issue":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1128"},"comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/issues/1128/comments"},"review_comments":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128/comments"},"review_comment":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/pulls/1128/commits"},"statuses":{"href":"https://api.github.com/repos/moneyadviceservice/frontend/statuses/6bac842d6cef10e5c363b74157a5797a66bf7b0d"}}}}