{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/47432694","id":47432694,"diff_hunk":"@@ -25,7 +24,6 @@ set(UTILCODE_SOURCES\n   stgpool.cpp\n   stgpooli.cpp\n   stgpoolreadonly.cpp\n-  lazycow.cpp","path":"src/utilcode/CMakeLists.txt","position":12,"original_position":12,"commit_id":"a8b6157fca1c32d246a6a5945ac87321e26331e4","original_commit_id":"a8b6157fca1c32d246a6a5945ac87321e26331e4","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"This highlighted a mismatch between the old msbuild-based scripts and CMakefiles. This should be left in and FEATURE_LAZYCOW defined for x86 and arm instead (on Windows at least) - to match https://github.com/dotnet/coreclr/blob/master/clr.coreclr.props#L68.","created_at":"2015-12-12T15:07:27Z","updated_at":"2015-12-12T15:07:27Z","html_url":"https://github.com/dotnet/coreclr/pull/2320#discussion_r47432694","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2320","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/47432694"},"html":{"href":"https://github.com/dotnet/coreclr/pull/2320#discussion_r47432694"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2320"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/2320","id":53476020,"html_url":"https://github.com/dotnet/coreclr/pull/2320","diff_url":"https://github.com/dotnet/coreclr/pull/2320.diff","patch_url":"https://github.com/dotnet/coreclr/pull/2320.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/2320","number":2320,"state":"open","locked":false,"title":"[WIP] Do not include unnecessary files in build","user":{"login":"mikedn","id":9973420,"avatar_url":"https://avatars.githubusercontent.com/u/9973420?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedn","html_url":"https://github.com/mikedn","followers_url":"https://api.github.com/users/mikedn/followers","following_url":"https://api.github.com/users/mikedn/following{/other_user}","gists_url":"https://api.github.com/users/mikedn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedn/subscriptions","organizations_url":"https://api.github.com/users/mikedn/orgs","repos_url":"https://api.github.com/users/mikedn/repos","events_url":"https://api.github.com/users/mikedn/events{/privacy}","received_events_url":"https://api.github.com/users/mikedn/received_events","type":"User","site_admin":false},"body":"Some files have their contents ifdefed out because some CLR features are not present (and they'll probably never be) in CoreCLR. A few others are DAC and/or arch specific so they have been moved to the appropiate file lists.","created_at":"2015-12-12T13:12:32Z","updated_at":"2015-12-12T15:07:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5b751905aa15c3cb7631e4d4e2604a792bbe30a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2320/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/2320/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/2320/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/a8b6157fca1c32d246a6a5945ac87321e26331e4","head":{"label":"mikedn:lnk4221","ref":"lnk4221","sha":"a8b6157fca1c32d246a6a5945ac87321e26331e4","user":{"login":"mikedn","id":9973420,"avatar_url":"https://avatars.githubusercontent.com/u/9973420?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedn","html_url":"https://github.com/mikedn","followers_url":"https://api.github.com/users/mikedn/followers","following_url":"https://api.github.com/users/mikedn/following{/other_user}","gists_url":"https://api.github.com/users/mikedn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedn/subscriptions","organizations_url":"https://api.github.com/users/mikedn/orgs","repos_url":"https://api.github.com/users/mikedn/repos","events_url":"https://api.github.com/users/mikedn/events{/privacy}","received_events_url":"https://api.github.com/users/mikedn/received_events","type":"User","site_admin":false},"repo":{"id":38843321,"name":"coreclr","full_name":"mikedn/coreclr","owner":{"login":"mikedn","id":9973420,"avatar_url":"https://avatars.githubusercontent.com/u/9973420?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedn","html_url":"https://github.com/mikedn","followers_url":"https://api.github.com/users/mikedn/followers","following_url":"https://api.github.com/users/mikedn/following{/other_user}","gists_url":"https://api.github.com/users/mikedn/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedn/subscriptions","organizations_url":"https://api.github.com/users/mikedn/orgs","repos_url":"https://api.github.com/users/mikedn/repos","events_url":"https://api.github.com/users/mikedn/events{/privacy}","received_events_url":"https://api.github.com/users/mikedn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedn/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/mikedn/coreclr","forks_url":"https://api.github.com/repos/mikedn/coreclr/forks","keys_url":"https://api.github.com/repos/mikedn/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedn/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedn/coreclr/teams","hooks_url":"https://api.github.com/repos/mikedn/coreclr/hooks","issue_events_url":"https://api.github.com/repos/mikedn/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/mikedn/coreclr/events","assignees_url":"https://api.github.com/repos/mikedn/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/mikedn/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/mikedn/coreclr/tags","blobs_url":"https://api.github.com/repos/mikedn/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedn/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedn/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedn/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedn/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedn/coreclr/languages","stargazers_url":"https://api.github.com/repos/mikedn/coreclr/stargazers","contributors_url":"https://api.github.com/repos/mikedn/coreclr/contributors","subscribers_url":"https://api.github.com/repos/mikedn/coreclr/subscribers","subscription_url":"https://api.github.com/repos/mikedn/coreclr/subscription","commits_url":"https://api.github.com/repos/mikedn/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedn/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedn/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedn/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedn/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/mikedn/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedn/coreclr/merges","archive_url":"https://api.github.com/repos/mikedn/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedn/coreclr/downloads","issues_url":"https://api.github.com/repos/mikedn/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/mikedn/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedn/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedn/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedn/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/mikedn/coreclr/releases{/id}","created_at":"2015-07-09T20:23:09Z","updated_at":"2015-09-12T08:38:58Z","pushed_at":"2015-12-12T13:12:12Z","git_url":"git://github.com/mikedn/coreclr.git","ssh_url":"git@github.com:mikedn/coreclr.git","clone_url":"https://github.com/mikedn/coreclr.git","svn_url":"https://github.com/mikedn/coreclr","homepage":"http://dotnet.github.io/core/","size":45719,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"7fded4942276b6a5d7b230cc29fcd2e6fdab979c","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-12-12T13:13:12Z","pushed_at":"2015-12-12T13:12:35Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":49773,"stargazers_count":5513,"watchers_count":5513,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1189,"mirror_url":null,"open_issues_count":398,"forks":1189,"open_issues":398,"watchers":5513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2320"},"html":{"href":"https://github.com/dotnet/coreclr/pull/2320"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/2320"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/2320/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2320/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/2320/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/a8b6157fca1c32d246a6a5945ac87321e26331e4"}}}}