{"action":"created","comment":{"url":"https://api.github.com/repos/jackalope/jackalope/pulls/comments/45711316","id":45711316,"diff_hunk":"@@ -773,9 +785,10 @@ public function getPropertiesValues($nameFilter = null, $dereference = true)\n         $this->checkState();\n \n         // OPTIMIZE: do not create properties in constructor, go over array here\n-        $names = self::filterNames($nameFilter, array_keys($this->properties));\n+        $names = self::filterNames($nameFilter, array_keys($this->propertyValues));\n         $result = array();\n         foreach ($names as $name) {\n+            $this->loadProperty($name);","path":"src/Jackalope/Node.php","position":129,"original_position":129,"commit_id":"2ea24a55b0fc2ffe3ce7344152a421b9478a51c6","original_commit_id":"2ea24a55b0fc2ffe3ce7344152a421b9478a51c6","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"How cheap is it to get the type of a property? At this place there's only the name, so I have to load something either way. I am not sure if this causes a notable performance gain, and therefore is worth the duplication of this logic.","created_at":"2015-11-24T09:20:00Z","updated_at":"2015-11-24T09:20:00Z","html_url":"https://github.com/jackalope/jackalope/pull/304#discussion_r45711316","pull_request_url":"https://api.github.com/repos/jackalope/jackalope/pulls/304","_links":{"self":{"href":"https://api.github.com/repos/jackalope/jackalope/pulls/comments/45711316"},"html":{"href":"https://github.com/jackalope/jackalope/pull/304#discussion_r45711316"},"pull_request":{"href":"https://api.github.com/repos/jackalope/jackalope/pulls/304"}}},"pull_request":{"url":"https://api.github.com/repos/jackalope/jackalope/pulls/304","id":51625843,"html_url":"https://github.com/jackalope/jackalope/pull/304","diff_url":"https://github.com/jackalope/jackalope/pull/304.diff","patch_url":"https://github.com/jackalope/jackalope/pull/304.patch","issue_url":"https://api.github.com/repos/jackalope/jackalope/issues/304","number":304,"state":"open","locked":false,"title":"implemented lazy loading of properties","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"Fixes https://github.com/jackalope/jackalope/issues/303\r\n\r\nTests are running, but I will have a look at the tests of jackalope-doctrine-dbal and jackalope-jackrabbit as well. Will ping here again, when this is done.","created_at":"2015-11-24T07:36:34Z","updated_at":"2015-11-24T09:20:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63577af6fc248e335af661ee9b29555a5e72cc83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jackalope/jackalope/pulls/304/commits","review_comments_url":"https://api.github.com/repos/jackalope/jackalope/pulls/304/comments","review_comment_url":"https://api.github.com/repos/jackalope/jackalope/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jackalope/jackalope/issues/304/comments","statuses_url":"https://api.github.com/repos/jackalope/jackalope/statuses/2ea24a55b0fc2ffe3ce7344152a421b9478a51c6","head":{"label":"danrot:property_lazy_loading","ref":"property_lazy_loading","sha":"2ea24a55b0fc2ffe3ce7344152a421b9478a51c6","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"repo":{"id":30755794,"name":"jackalope","full_name":"danrot/jackalope","owner":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/danrot/jackalope","description":"Jackalope implements the PHPCR API. This modular library contains bindings to store data with the Doctrine DBAL or in the Jackrabbit JCR server part","fork":true,"url":"https://api.github.com/repos/danrot/jackalope","forks_url":"https://api.github.com/repos/danrot/jackalope/forks","keys_url":"https://api.github.com/repos/danrot/jackalope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/danrot/jackalope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/danrot/jackalope/teams","hooks_url":"https://api.github.com/repos/danrot/jackalope/hooks","issue_events_url":"https://api.github.com/repos/danrot/jackalope/issues/events{/number}","events_url":"https://api.github.com/repos/danrot/jackalope/events","assignees_url":"https://api.github.com/repos/danrot/jackalope/assignees{/user}","branches_url":"https://api.github.com/repos/danrot/jackalope/branches{/branch}","tags_url":"https://api.github.com/repos/danrot/jackalope/tags","blobs_url":"https://api.github.com/repos/danrot/jackalope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/danrot/jackalope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/danrot/jackalope/git/refs{/sha}","trees_url":"https://api.github.com/repos/danrot/jackalope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/danrot/jackalope/statuses/{sha}","languages_url":"https://api.github.com/repos/danrot/jackalope/languages","stargazers_url":"https://api.github.com/repos/danrot/jackalope/stargazers","contributors_url":"https://api.github.com/repos/danrot/jackalope/contributors","subscribers_url":"https://api.github.com/repos/danrot/jackalope/subscribers","subscription_url":"https://api.github.com/repos/danrot/jackalope/subscription","commits_url":"https://api.github.com/repos/danrot/jackalope/commits{/sha}","git_commits_url":"https://api.github.com/repos/danrot/jackalope/git/commits{/sha}","comments_url":"https://api.github.com/repos/danrot/jackalope/comments{/number}","issue_comment_url":"https://api.github.com/repos/danrot/jackalope/issues/comments{/number}","contents_url":"https://api.github.com/repos/danrot/jackalope/contents/{+path}","compare_url":"https://api.github.com/repos/danrot/jackalope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/danrot/jackalope/merges","archive_url":"https://api.github.com/repos/danrot/jackalope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/danrot/jackalope/downloads","issues_url":"https://api.github.com/repos/danrot/jackalope/issues{/number}","pulls_url":"https://api.github.com/repos/danrot/jackalope/pulls{/number}","milestones_url":"https://api.github.com/repos/danrot/jackalope/milestones{/number}","notifications_url":"https://api.github.com/repos/danrot/jackalope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/danrot/jackalope/labels{/name}","releases_url":"https://api.github.com/repos/danrot/jackalope/releases{/id}","created_at":"2015-02-13T12:38:14Z","updated_at":"2015-06-02T17:23:17Z","pushed_at":"2015-11-24T07:33:02Z","git_url":"git://github.com/danrot/jackalope.git","ssh_url":"git@github.com:danrot/jackalope.git","clone_url":"https://github.com/danrot/jackalope.git","svn_url":"https://github.com/danrot/jackalope","homepage":"http://jackalope.github.io","size":9677,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jackalope:master","ref":"master","sha":"a4bd18fee1d7d750fdba8bfa32aad1559da32b42","user":{"login":"jackalope","id":70245,"avatar_url":"https://avatars.githubusercontent.com/u/70245?v=3","gravatar_id":"","url":"https://api.github.com/users/jackalope","html_url":"https://github.com/jackalope","followers_url":"https://api.github.com/users/jackalope/followers","following_url":"https://api.github.com/users/jackalope/following{/other_user}","gists_url":"https://api.github.com/users/jackalope/gists{/gist_id}","starred_url":"https://api.github.com/users/jackalope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackalope/subscriptions","organizations_url":"https://api.github.com/users/jackalope/orgs","repos_url":"https://api.github.com/users/jackalope/repos","events_url":"https://api.github.com/users/jackalope/events{/privacy}","received_events_url":"https://api.github.com/users/jackalope/received_events","type":"Organization","site_admin":false},"repo":{"id":563272,"name":"jackalope","full_name":"jackalope/jackalope","owner":{"login":"jackalope","id":70245,"avatar_url":"https://avatars.githubusercontent.com/u/70245?v=3","gravatar_id":"","url":"https://api.github.com/users/jackalope","html_url":"https://github.com/jackalope","followers_url":"https://api.github.com/users/jackalope/followers","following_url":"https://api.github.com/users/jackalope/following{/other_user}","gists_url":"https://api.github.com/users/jackalope/gists{/gist_id}","starred_url":"https://api.github.com/users/jackalope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackalope/subscriptions","organizations_url":"https://api.github.com/users/jackalope/orgs","repos_url":"https://api.github.com/users/jackalope/repos","events_url":"https://api.github.com/users/jackalope/events{/privacy}","received_events_url":"https://api.github.com/users/jackalope/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jackalope/jackalope","description":"Jackalope implements the PHPCR API. This modular library contains bindings to store data with the Doctrine DBAL or in the Jackrabbit JCR server part","fork":false,"url":"https://api.github.com/repos/jackalope/jackalope","forks_url":"https://api.github.com/repos/jackalope/jackalope/forks","keys_url":"https://api.github.com/repos/jackalope/jackalope/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jackalope/jackalope/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jackalope/jackalope/teams","hooks_url":"https://api.github.com/repos/jackalope/jackalope/hooks","issue_events_url":"https://api.github.com/repos/jackalope/jackalope/issues/events{/number}","events_url":"https://api.github.com/repos/jackalope/jackalope/events","assignees_url":"https://api.github.com/repos/jackalope/jackalope/assignees{/user}","branches_url":"https://api.github.com/repos/jackalope/jackalope/branches{/branch}","tags_url":"https://api.github.com/repos/jackalope/jackalope/tags","blobs_url":"https://api.github.com/repos/jackalope/jackalope/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jackalope/jackalope/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jackalope/jackalope/git/refs{/sha}","trees_url":"https://api.github.com/repos/jackalope/jackalope/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jackalope/jackalope/statuses/{sha}","languages_url":"https://api.github.com/repos/jackalope/jackalope/languages","stargazers_url":"https://api.github.com/repos/jackalope/jackalope/stargazers","contributors_url":"https://api.github.com/repos/jackalope/jackalope/contributors","subscribers_url":"https://api.github.com/repos/jackalope/jackalope/subscribers","subscription_url":"https://api.github.com/repos/jackalope/jackalope/subscription","commits_url":"https://api.github.com/repos/jackalope/jackalope/commits{/sha}","git_commits_url":"https://api.github.com/repos/jackalope/jackalope/git/commits{/sha}","comments_url":"https://api.github.com/repos/jackalope/jackalope/comments{/number}","issue_comment_url":"https://api.github.com/repos/jackalope/jackalope/issues/comments{/number}","contents_url":"https://api.github.com/repos/jackalope/jackalope/contents/{+path}","compare_url":"https://api.github.com/repos/jackalope/jackalope/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jackalope/jackalope/merges","archive_url":"https://api.github.com/repos/jackalope/jackalope/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jackalope/jackalope/downloads","issues_url":"https://api.github.com/repos/jackalope/jackalope/issues{/number}","pulls_url":"https://api.github.com/repos/jackalope/jackalope/pulls{/number}","milestones_url":"https://api.github.com/repos/jackalope/jackalope/milestones{/number}","notifications_url":"https://api.github.com/repos/jackalope/jackalope/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jackalope/jackalope/labels{/name}","releases_url":"https://api.github.com/repos/jackalope/jackalope/releases{/id}","created_at":"2010-03-15T13:51:08Z","updated_at":"2015-11-14T20:02:22Z","pushed_at":"2015-11-24T07:36:34Z","git_url":"git://github.com/jackalope/jackalope.git","ssh_url":"git@github.com:jackalope/jackalope.git","clone_url":"https://github.com/jackalope/jackalope.git","svn_url":"https://github.com/jackalope/jackalope","homepage":"http://jackalope.github.io","size":11459,"stargazers_count":189,"watchers_count":189,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":47,"forks":60,"open_issues":47,"watchers":189,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jackalope/jackalope/pulls/304"},"html":{"href":"https://github.com/jackalope/jackalope/pull/304"},"issue":{"href":"https://api.github.com/repos/jackalope/jackalope/issues/304"},"comments":{"href":"https://api.github.com/repos/jackalope/jackalope/issues/304/comments"},"review_comments":{"href":"https://api.github.com/repos/jackalope/jackalope/pulls/304/comments"},"review_comment":{"href":"https://api.github.com/repos/jackalope/jackalope/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jackalope/jackalope/pulls/304/commits"},"statuses":{"href":"https://api.github.com/repos/jackalope/jackalope/statuses/2ea24a55b0fc2ffe3ce7344152a421b9478a51c6"}}}}