{"action":"created","issue":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1687","labels_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1687/labels{/name}","comments_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1687/comments","events_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1687/events","html_url":"https://github.com/MinecraftForge/MinecraftForge/issues/1687","id":56850954,"number":1687,"title":"[1.8] Villager Registry seems to be incomplete","user":{"login":"61352151511","id":2399411,"avatar_url":"https://avatars.githubusercontent.com/u/2399411?v=3","gravatar_id":"","url":"https://api.github.com/users/61352151511","html_url":"https://github.com/61352151511","followers_url":"https://api.github.com/users/61352151511/followers","following_url":"https://api.github.com/users/61352151511/following{/other_user}","gists_url":"https://api.github.com/users/61352151511/gists{/gist_id}","starred_url":"https://api.github.com/users/61352151511/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/61352151511/subscriptions","organizations_url":"https://api.github.com/users/61352151511/orgs","repos_url":"https://api.github.com/users/61352151511/repos","events_url":"https://api.github.com/users/61352151511/events{/privacy}","received_events_url":"https://api.github.com/users/61352151511/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-06T18:47:34Z","updated_at":"2015-03-04T20:25:52Z","closed_at":null,"body":"It seems the villager registry is incomplete, registering custom villager ID's and professions appears to have no effect.\r\n\r\nVillagerRegistry.instance().registerVillagerId(ConfigurationHandler.getVillagerID()); // (65)\r\nDoes keep track of the fact that the ID is registered.\r\nVillagerRegistry.instance().registerVillagerSkin(65, new ResourceLocation(\"zombieinfection\", \"textures/entity/medic.png\"));\r\nNot sure if this works, on the client proxy, any villager spawned from a spawn egg does not have the skin.\r\nVillagerProfession prof = new VillagerProfession(\"zombieinfection:medic\", \"zombieinfection:textures/entity/medic.png\");\r\nVillagerRegistry.instance().register(prof);\r\nAgain not sure if this works, no villagers seem to have the profession or skin. Also can't figure out how one would add custom trades, the .init method for VillagerCareer's takes ITradeList[][] however .init is hidden/not visible.\r\n\r\nThere's two TODO's in VillagerRegistry, not sure if that is what prevents the entire thing from working.\r\n\r\n    public static void setRandomProfession(EntityVillager entity, Random rand)\r\n    {\r\n        //TODO: Grab id range from internal registry\r\n        entity.setProfession(rand.nextInt(5));\r\n    }\r\n\r\n    //TODO: Figure out a good generic system for this. Put on hold for Patches.\r\n\r\nIf this doesn't belong here (Since it may be FML) I'll repost it there."},"comment":{"url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/comments/77239724","html_url":"https://github.com/MinecraftForge/MinecraftForge/issues/1687#issuecomment-77239724","issue_url":"https://api.github.com/repos/MinecraftForge/MinecraftForge/issues/1687","id":77239724,"user":{"login":"Chimaine","id":288147,"avatar_url":"https://avatars.githubusercontent.com/u/288147?v=3","gravatar_id":"","url":"https://api.github.com/users/Chimaine","html_url":"https://github.com/Chimaine","followers_url":"https://api.github.com/users/Chimaine/followers","following_url":"https://api.github.com/users/Chimaine/following{/other_user}","gists_url":"https://api.github.com/users/Chimaine/gists{/gist_id}","starred_url":"https://api.github.com/users/Chimaine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Chimaine/subscriptions","organizations_url":"https://api.github.com/users/Chimaine/orgs","repos_url":"https://api.github.com/users/Chimaine/repos","events_url":"https://api.github.com/users/Chimaine/events{/privacy}","received_events_url":"https://api.github.com/users/Chimaine/received_events","type":"User","site_admin":false},"created_at":"2015-03-04T20:25:52Z","updated_at":"2015-03-04T20:25:52Z","body":"I actually wondered about that when I looked for updating to 1.8. Thought it was intentional. Glad it's not and just want to bump this a bit, because it's one of the things preventing me to upgrade."}}