{"action":"created","issue":{"url":"https://api.github.com/repos/new-xkit/XKit/issues/890","labels_url":"https://api.github.com/repos/new-xkit/XKit/issues/890/labels{/name}","comments_url":"https://api.github.com/repos/new-xkit/XKit/issues/890/comments","events_url":"https://api.github.com/repos/new-xkit/XKit/issues/890/events","html_url":"https://github.com/new-xkit/XKit/pull/890","id":124147275,"number":890,"title":"[gulpfile,css,xkit_preferences] Code style and appearance cleanup.","user":{"login":"nepeat","id":6914822,"avatar_url":"https://avatars.githubusercontent.com/u/6914822?v=3","gravatar_id":"","url":"https://api.github.com/users/nepeat","html_url":"https://github.com/nepeat","followers_url":"https://api.github.com/users/nepeat/followers","following_url":"https://api.github.com/users/nepeat/following{/other_user}","gists_url":"https://api.github.com/users/nepeat/gists{/gist_id}","starred_url":"https://api.github.com/users/nepeat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nepeat/subscriptions","organizations_url":"https://api.github.com/users/nepeat/orgs","repos_url":"https://api.github.com/users/nepeat/repos","events_url":"https://api.github.com/users/nepeat/events{/privacy}","received_events_url":"https://api.github.com/users/nepeat/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/new-xkit/XKit/labels/needs%20review","name":"needs review","color":"e6e6e6"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-12-29T01:04:43Z","updated_at":"2015-12-29T21:56:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/new-xkit/XKit/pulls/890","html_url":"https://github.com/new-xkit/XKit/pull/890","diff_url":"https://github.com/new-xkit/XKit/pull/890.diff","patch_url":"https://github.com/new-xkit/XKit/pull/890.patch"},"body":"Finding what I found in the One Click Postage stylesheets made me check if the same style issues were in the other styles. They were in the other styles and I pain.\r\n\r\n# Changes\r\n* gulpfile\r\n  * Make JSHint stop complaining about 'use strict'.\r\n* xkit_preferences\r\n  * Use borders instead of images to separate columns.\r\n* css\r\n  * Remove excessive trailing newlines before and after braces.\r\n  * Add trailing newlines at the end of every file.\r\n  * Remove trailing tabs and whitespaces at each line.\r\n  * Fix missing semicolons.\r\n  * Remove rules/classes that are duplicated, empty, or do not show.\r\n  * Add on some Firefox and generic vendor prefixing.\r\n  * Fix some newlines to separate rules.\r\n* js\r\n  * Bump up versions of all the changed extensions. (I pain.)\r\n\r\n# Visible Changes\r\n## XKit Preferences\r\n### Before\r\n![Before](https://i.imgur.com/EgDLNCr.png)\r\n### After\r\n![Before](https://i.imgur.com/pyYhoMw.png)"},"comment":{"url":"https://api.github.com/repos/new-xkit/XKit/issues/comments/167886250","html_url":"https://github.com/new-xkit/XKit/pull/890#issuecomment-167886250","issue_url":"https://api.github.com/repos/new-xkit/XKit/issues/890","id":167886250,"user":{"login":"nightpool","id":233815,"avatar_url":"https://avatars.githubusercontent.com/u/233815?v=3","gravatar_id":"","url":"https://api.github.com/users/nightpool","html_url":"https://github.com/nightpool","followers_url":"https://api.github.com/users/nightpool/followers","following_url":"https://api.github.com/users/nightpool/following{/other_user}","gists_url":"https://api.github.com/users/nightpool/gists{/gist_id}","starred_url":"https://api.github.com/users/nightpool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightpool/subscriptions","organizations_url":"https://api.github.com/users/nightpool/orgs","repos_url":"https://api.github.com/users/nightpool/repos","events_url":"https://api.github.com/users/nightpool/events{/privacy}","received_events_url":"https://api.github.com/users/nightpool/received_events","type":"User","site_admin":false},"created_at":"2015-12-29T21:56:16Z","updated_at":"2015-12-29T21:56:16Z","body":"in general, :-1: from me to style changes that aren't associated with a lint. Either we enforce a consistent rule programmatically through linting, or we just don't worry about it (I'm fine with either, and probably prefer the latter for css TBQH) "}}