{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/ezfind/pulls/comments/22764243","id":22764243,"diff_hunk":"@@ -19,6 +19,17 @@ YUI.add('ezfindautocomplete', function (Y) {\n             source: conf.url\n         });\n \n+        // Build Ajax request URL string, passed to AutoComplete as the requestTemplate\n+        var urlString = \"::{query}::\" + conf.resultLimit + \"::\";","path":"design/standard/javascript/ezajax_autocomplete.js","position":5,"original_position":5,"commit_id":"436e169dde02eb41307a3d326baf544629f73a30","original_commit_id":"436e169dde02eb41307a3d326baf544629f73a30","user":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"body":"Ah, now I remember.  The parameter order is \"query::limit::subtree::classes\"\r\n\r\nTo be able to support the classes parameter without the subtree parameter, you must force the extra separator no matter what.  That way you can have \"query::limit::::classes\".\r\n\r\nI guess you could make a small bit of cleanup so if you have neither subtree nor classes, the string is \"query::limit::\" instead of \"query::limit::::\" (or even eliminate the trailing colons altogether), but that isn't much of a win in my opinion (it makes the code harder to read), and this way at least you set a precedent in case there is a need to support 5th and subsequent parameters.","created_at":"2015-01-11T04:18:53Z","updated_at":"2015-01-11T04:18:53Z","html_url":"https://github.com/ezsystems/ezfind/pull/180#discussion_r22764243","pull_request_url":"https://api.github.com/repos/ezsystems/ezfind/pulls/180","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/comments/22764243"},"html":{"href":"https://github.com/ezsystems/ezfind/pull/180#discussion_r22764243"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/180"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/ezfind/pulls/180","id":24189515,"html_url":"https://github.com/ezsystems/ezfind/pull/180","diff_url":"https://github.com/ezsystems/ezfind/pull/180.diff","patch_url":"https://github.com/ezsystems/ezfind/pull/180.patch","issue_url":"https://api.github.com/repos/ezsystems/ezfind/issues/180","number":180,"state":"open","locked":false,"title":"Fix EZP-23617: Add subtree and class filters on eZ Find autocomplete","user":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"body":"Replaces https://github.com/ezsystems/ezfind/pull/106\r\n\r\nNote that this adds the capability to eZ Find. The various templates (object relations, Online Editor) still need to be updated if they want to use it. (Example: https://github.com/ezsystems/ezpublish-legacy/pull/620)","created_at":"2014-11-11T00:23:11Z","updated_at":"2015-01-11T04:18:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ceb6556398d346f50e5ff7806a80b18a7a15fd52","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/ezfind/pulls/180/commits","review_comments_url":"https://api.github.com/repos/ezsystems/ezfind/pulls/180/comments","review_comment_url":"https://api.github.com/repos/ezsystems/ezfind/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/ezfind/issues/180/comments","statuses_url":"https://api.github.com/repos/ezsystems/ezfind/statuses/436e169dde02eb41307a3d326baf544629f73a30","head":{"label":"peterkeung:autocomplete-filters","ref":"autocomplete-filters","sha":"436e169dde02eb41307a3d326baf544629f73a30","user":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"repo":{"id":9919493,"name":"ezfind","full_name":"peterkeung/ezfind","owner":{"login":"peterkeung","id":575638,"avatar_url":"https://avatars.githubusercontent.com/u/575638?v=3","gravatar_id":"","url":"https://api.github.com/users/peterkeung","html_url":"https://github.com/peterkeung","followers_url":"https://api.github.com/users/peterkeung/followers","following_url":"https://api.github.com/users/peterkeung/following{/other_user}","gists_url":"https://api.github.com/users/peterkeung/gists{/gist_id}","starred_url":"https://api.github.com/users/peterkeung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterkeung/subscriptions","organizations_url":"https://api.github.com/users/peterkeung/orgs","repos_url":"https://api.github.com/users/peterkeung/repos","events_url":"https://api.github.com/users/peterkeung/events{/privacy}","received_events_url":"https://api.github.com/users/peterkeung/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterkeung/ezfind","description":"","fork":true,"url":"https://api.github.com/repos/peterkeung/ezfind","forks_url":"https://api.github.com/repos/peterkeung/ezfind/forks","keys_url":"https://api.github.com/repos/peterkeung/ezfind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterkeung/ezfind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterkeung/ezfind/teams","hooks_url":"https://api.github.com/repos/peterkeung/ezfind/hooks","issue_events_url":"https://api.github.com/repos/peterkeung/ezfind/issues/events{/number}","events_url":"https://api.github.com/repos/peterkeung/ezfind/events","assignees_url":"https://api.github.com/repos/peterkeung/ezfind/assignees{/user}","branches_url":"https://api.github.com/repos/peterkeung/ezfind/branches{/branch}","tags_url":"https://api.github.com/repos/peterkeung/ezfind/tags","blobs_url":"https://api.github.com/repos/peterkeung/ezfind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterkeung/ezfind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterkeung/ezfind/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterkeung/ezfind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterkeung/ezfind/statuses/{sha}","languages_url":"https://api.github.com/repos/peterkeung/ezfind/languages","stargazers_url":"https://api.github.com/repos/peterkeung/ezfind/stargazers","contributors_url":"https://api.github.com/repos/peterkeung/ezfind/contributors","subscribers_url":"https://api.github.com/repos/peterkeung/ezfind/subscribers","subscription_url":"https://api.github.com/repos/peterkeung/ezfind/subscription","commits_url":"https://api.github.com/repos/peterkeung/ezfind/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterkeung/ezfind/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterkeung/ezfind/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterkeung/ezfind/issues/comments/{number}","contents_url":"https://api.github.com/repos/peterkeung/ezfind/contents/{+path}","compare_url":"https://api.github.com/repos/peterkeung/ezfind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterkeung/ezfind/merges","archive_url":"https://api.github.com/repos/peterkeung/ezfind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterkeung/ezfind/downloads","issues_url":"https://api.github.com/repos/peterkeung/ezfind/issues{/number}","pulls_url":"https://api.github.com/repos/peterkeung/ezfind/pulls{/number}","milestones_url":"https://api.github.com/repos/peterkeung/ezfind/milestones{/number}","notifications_url":"https://api.github.com/repos/peterkeung/ezfind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterkeung/ezfind/labels{/name}","releases_url":"https://api.github.com/repos/peterkeung/ezfind/releases{/id}","created_at":"2013-05-07T19:09:57Z","updated_at":"2015-01-07T16:11:35Z","pushed_at":"2015-01-07T16:16:31Z","git_url":"git://github.com/peterkeung/ezfind.git","ssh_url":"git@github.com:peterkeung/ezfind.git","clone_url":"https://github.com/peterkeung/ezfind.git","svn_url":"https://github.com/peterkeung/ezfind","homepage":"","size":285425,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"a044741d1c72d3e6754ef3cb757adbfb63501e12","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":1007121,"name":"ezfind","full_name":"ezsystems/ezfind","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/ezfind","description":"","fork":false,"url":"https://api.github.com/repos/ezsystems/ezfind","forks_url":"https://api.github.com/repos/ezsystems/ezfind/forks","keys_url":"https://api.github.com/repos/ezsystems/ezfind/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/ezfind/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/ezfind/teams","hooks_url":"https://api.github.com/repos/ezsystems/ezfind/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/ezfind/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/ezfind/events","assignees_url":"https://api.github.com/repos/ezsystems/ezfind/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/ezfind/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/ezfind/tags","blobs_url":"https://api.github.com/repos/ezsystems/ezfind/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/ezfind/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/ezfind/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/ezfind/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/ezfind/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/ezfind/languages","stargazers_url":"https://api.github.com/repos/ezsystems/ezfind/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/ezfind/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/ezfind/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/ezfind/subscription","commits_url":"https://api.github.com/repos/ezsystems/ezfind/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/ezfind/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/ezfind/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/ezfind/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/ezfind/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/ezfind/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/ezfind/merges","archive_url":"https://api.github.com/repos/ezsystems/ezfind/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/ezfind/downloads","issues_url":"https://api.github.com/repos/ezsystems/ezfind/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/ezfind/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/ezfind/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/ezfind/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/ezfind/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/ezfind/releases{/id}","created_at":"2010-10-19T20:46:09Z","updated_at":"2015-01-08T13:50:13Z","pushed_at":"2015-01-08T13:50:12Z","git_url":"git://github.com/ezsystems/ezfind.git","ssh_url":"git@github.com:ezsystems/ezfind.git","clone_url":"https://github.com/ezsystems/ezfind.git","svn_url":"https://github.com/ezsystems/ezfind","homepage":"","size":285485,"stargazers_count":68,"watchers_count":68,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":27,"forks":71,"open_issues":27,"watchers":68,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/180"},"html":{"href":"https://github.com/ezsystems/ezfind/pull/180"},"issue":{"href":"https://api.github.com/repos/ezsystems/ezfind/issues/180"},"comments":{"href":"https://api.github.com/repos/ezsystems/ezfind/issues/180/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/180/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/ezfind/pulls/180/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/ezfind/statuses/436e169dde02eb41307a3d326baf544629f73a30"}}}}