{"action":"created","issue":{"url":"https://api.github.com/repos/dmgerman/ninka/issues/11","labels_url":"https://api.github.com/repos/dmgerman/ninka/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/dmgerman/ninka/issues/11/comments","events_url":"https://api.github.com/repos/dmgerman/ninka/issues/11/events","html_url":"https://github.com/dmgerman/ninka/issues/11","id":53975640,"number":11,"title":"does not recognize simple/standard AGPL license headers","user":{"login":"zacchiro","id":216766,"avatar_url":"https://avatars.githubusercontent.com/u/216766?v=3","gravatar_id":"","url":"https://api.github.com/users/zacchiro","html_url":"https://github.com/zacchiro","followers_url":"https://api.github.com/users/zacchiro/followers","following_url":"https://api.github.com/users/zacchiro/following{/other_user}","gists_url":"https://api.github.com/users/zacchiro/gists{/gist_id}","starred_url":"https://api.github.com/users/zacchiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zacchiro/subscriptions","organizations_url":"https://api.github.com/users/zacchiro/orgs","repos_url":"https://api.github.com/users/zacchiro/repos","events_url":"https://api.github.com/users/zacchiro/events{/privacy}","received_events_url":"https://api.github.com/users/zacchiro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-01-10T23:36:06Z","updated_at":"2015-01-13T01:35:18Z","closed_at":null,"body":"I've been playing with ninka on a couple of AGPL'd applications. For testing purposes, here are the apps I've used with the corresponding tarballs:\r\n\r\n1. GNU mediagoblin (Git snapshot): http://upsilon.cc/~zack/stuff/mediagoblin-snapshot.tar.gz\r\n2. Debsources (ditto): http://upsilon.cc/~zack/stuff/debsources-snapshot.tar.gz\r\n\r\nas a baseline test, I've also used the following archive (which contains code licensed under a mixture of licenses):\r\n\r\n3. python-debian (0.1.25): http://upsilon.cc/~zack/stuff/python-debian.tar.gz\r\n\r\nI've used the new excel & sqlite wrappers in my tests.\r\n\r\nOn archive (3), ninka seems to work as expected, recognizing various licenses.\r\nOn archive (1) and (2), ninka does not recognize any single AGPL'd file as such, even though the headers in them are fairly explicit and standard, e.g.:\r\n\r\n    # Debsources is free software: you can redistribute it and/or modify it under\r\n    # the terms of the GNU Affero General Public License as published by the Free\r\n    # Software Foundation, either version 3 of the License, or (at your option) any\r\n    # later version.\r\n\r\nIt seems that ninka does some AGPL \"stuff\", as reported in the token dump, but fails to conclude that the file is licensed under AGPL.\r\n\r\nThe problem seems to be specific to AGPL. To verify that I've done the following experiment. I've removed (with \"sed -i\") all occurrences of the string \"Affero \" in a local copy of the Debsources archive, and rerun ninka on the resulting archive. ninka has been immediately able to conclude that most files are licensed under GPL3.\r\n\r\nSo maybe there is a simple AGPL regexp to be tweaked somewhere?\r\n\r\nMany thanks for ninka!\r\nCheers."},"comment":{"url":"https://api.github.com/repos/dmgerman/ninka/issues/comments/69680954","html_url":"https://github.com/dmgerman/ninka/issues/11#issuecomment-69680954","issue_url":"https://api.github.com/repos/dmgerman/ninka/issues/11","id":69680954,"user":{"login":"dmgerman","id":167152,"avatar_url":"https://avatars.githubusercontent.com/u/167152?v=3","gravatar_id":"","url":"https://api.github.com/users/dmgerman","html_url":"https://github.com/dmgerman","followers_url":"https://api.github.com/users/dmgerman/followers","following_url":"https://api.github.com/users/dmgerman/following{/other_user}","gists_url":"https://api.github.com/users/dmgerman/gists{/gist_id}","starred_url":"https://api.github.com/users/dmgerman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmgerman/subscriptions","organizations_url":"https://api.github.com/users/dmgerman/orgs","repos_url":"https://api.github.com/users/dmgerman/repos","events_url":"https://api.github.com/users/dmgerman/events{/privacy}","received_events_url":"https://api.github.com/users/dmgerman/received_events","type":"User","site_admin":false},"created_at":"2015-01-13T01:35:18Z","updated_at":"2015-01-13T01:35:18Z","body":"Well, this is a good question. The license statement you used is not \"standard\". It uses a colon instead of a semicolon.  Change \r\n\r\nDebsources is free software:\r\n\r\nto\r\n\r\nDebsources is free software;\r\n\r\nand the license would be recognized.\r\n\r\n--dmg"}}