{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/44953340","id":44953340,"diff_hunk":"@@ -8475,7 +8475,7 @@ void MethodTableBuilder::SystemVAmd64CheckForPassStructInRegister()\n     // Iterate through the fields and make sure they meet requirements to pass in registers\n     SystemVStructRegisterPassingHelper helper((unsigned int)totalStructSize);\n \n-    if (GetHalfBakedMethodTable()->ClassifyEightBytes(&helper, 0, 0))\n+    if (GetHalfBakedMethodTable()->ClassifyEightBytes(&helper, 0, 0, false))","path":"src/vm/methodtablebuilder.cpp","position":5,"original_position":5,"commit_id":"f8b7b8848dd6c84bc447646099010635ca2fdb39","original_commit_id":"f8b7b8848dd6c84bc447646099010635ca2fdb39","user":{"login":"pgavlin","id":1224093,"avatar_url":"https://avatars.githubusercontent.com/u/1224093?v=3","gravatar_id":"","url":"https://api.github.com/users/pgavlin","html_url":"https://github.com/pgavlin","followers_url":"https://api.github.com/users/pgavlin/followers","following_url":"https://api.github.com/users/pgavlin/following{/other_user}","gists_url":"https://api.github.com/users/pgavlin/gists{/gist_id}","starred_url":"https://api.github.com/users/pgavlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgavlin/subscriptions","organizations_url":"https://api.github.com/users/pgavlin/orgs","repos_url":"https://api.github.com/users/pgavlin/repos","events_url":"https://api.github.com/users/pgavlin/events{/privacy}","received_events_url":"https://api.github.com/users/pgavlin/received_events","type":"User","site_admin":false},"body":"Nit: it would be nice to use a named constant in these two calls instead of `false`/`true`. Something like:\r\n\r\n```\r\nconst bool UseNativeLayout = false;\r\nif (GetHalfBakedMethodTable()->ClassifyEightBytes(&helper, 0, 0, false))\r\n```\r\n\r\nand\r\n\r\n```\r\nconst bool UseNativeLayout = true;\r\nif (GetHalfBakedMethodTable()->ClassifyEightBytes(&helper, 0, 0, true))\r\n```","created_at":"2015-11-16T17:24:13Z","updated_at":"2015-11-16T17:24:13Z","html_url":"https://github.com/dotnet/coreclr/pull/1983#discussion_r44953340","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1983","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/44953340"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1983#discussion_r44953340"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1983"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/1983","id":50020578,"html_url":"https://github.com/dotnet/coreclr/pull/1983","diff_url":"https://github.com/dotnet/coreclr/pull/1983.diff","patch_url":"https://github.com/dotnet/coreclr/pull/1983.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/1983","number":1983,"state":"open","locked":false,"title":"Fixed a bad merge issue.","user":{"login":"LLITCHEV","id":9732688,"avatar_url":"https://avatars.githubusercontent.com/u/9732688?v=3","gravatar_id":"","url":"https://api.github.com/users/LLITCHEV","html_url":"https://github.com/LLITCHEV","followers_url":"https://api.github.com/users/LLITCHEV/followers","following_url":"https://api.github.com/users/LLITCHEV/following{/other_user}","gists_url":"https://api.github.com/users/LLITCHEV/gists{/gist_id}","starred_url":"https://api.github.com/users/LLITCHEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLITCHEV/subscriptions","organizations_url":"https://api.github.com/users/LLITCHEV/orgs","repos_url":"https://api.github.com/users/LLITCHEV/repos","events_url":"https://api.github.com/users/LLITCHEV/events{/privacy}","received_events_url":"https://api.github.com/users/LLITCHEV/received_events","type":"User","site_admin":false},"body":"Sometime ago when the SystemVStructs branch was PRed into master a bad\r\nmerge has occured.","created_at":"2015-11-07T00:14:09Z","updated_at":"2015-11-16T17:24:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"420f4b5b08e712cd86147cac49b2a86df146bc93","assignee":{"login":"LLITCHEV","id":9732688,"avatar_url":"https://avatars.githubusercontent.com/u/9732688?v=3","gravatar_id":"","url":"https://api.github.com/users/LLITCHEV","html_url":"https://github.com/LLITCHEV","followers_url":"https://api.github.com/users/LLITCHEV/followers","following_url":"https://api.github.com/users/LLITCHEV/following{/other_user}","gists_url":"https://api.github.com/users/LLITCHEV/gists{/gist_id}","starred_url":"https://api.github.com/users/LLITCHEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLITCHEV/subscriptions","organizations_url":"https://api.github.com/users/LLITCHEV/orgs","repos_url":"https://api.github.com/users/LLITCHEV/repos","events_url":"https://api.github.com/users/LLITCHEV/events{/privacy}","received_events_url":"https://api.github.com/users/LLITCHEV/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1983/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/1983/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/1983/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/f8b7b8848dd6c84bc447646099010635ca2fdb39","head":{"label":"LLITCHEV:SystemVStructsCleanup","ref":"SystemVStructsCleanup","sha":"f8b7b8848dd6c84bc447646099010635ca2fdb39","user":{"login":"LLITCHEV","id":9732688,"avatar_url":"https://avatars.githubusercontent.com/u/9732688?v=3","gravatar_id":"","url":"https://api.github.com/users/LLITCHEV","html_url":"https://github.com/LLITCHEV","followers_url":"https://api.github.com/users/LLITCHEV/followers","following_url":"https://api.github.com/users/LLITCHEV/following{/other_user}","gists_url":"https://api.github.com/users/LLITCHEV/gists{/gist_id}","starred_url":"https://api.github.com/users/LLITCHEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLITCHEV/subscriptions","organizations_url":"https://api.github.com/users/LLITCHEV/orgs","repos_url":"https://api.github.com/users/LLITCHEV/repos","events_url":"https://api.github.com/users/LLITCHEV/events{/privacy}","received_events_url":"https://api.github.com/users/LLITCHEV/received_events","type":"User","site_admin":false},"repo":{"id":30622011,"name":"coreclr","full_name":"LLITCHEV/coreclr","owner":{"login":"LLITCHEV","id":9732688,"avatar_url":"https://avatars.githubusercontent.com/u/9732688?v=3","gravatar_id":"","url":"https://api.github.com/users/LLITCHEV","html_url":"https://github.com/LLITCHEV","followers_url":"https://api.github.com/users/LLITCHEV/followers","following_url":"https://api.github.com/users/LLITCHEV/following{/other_user}","gists_url":"https://api.github.com/users/LLITCHEV/gists{/gist_id}","starred_url":"https://api.github.com/users/LLITCHEV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLITCHEV/subscriptions","organizations_url":"https://api.github.com/users/LLITCHEV/orgs","repos_url":"https://api.github.com/users/LLITCHEV/repos","events_url":"https://api.github.com/users/LLITCHEV/events{/privacy}","received_events_url":"https://api.github.com/users/LLITCHEV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LLITCHEV/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/LLITCHEV/coreclr","forks_url":"https://api.github.com/repos/LLITCHEV/coreclr/forks","keys_url":"https://api.github.com/repos/LLITCHEV/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLITCHEV/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLITCHEV/coreclr/teams","hooks_url":"https://api.github.com/repos/LLITCHEV/coreclr/hooks","issue_events_url":"https://api.github.com/repos/LLITCHEV/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/LLITCHEV/coreclr/events","assignees_url":"https://api.github.com/repos/LLITCHEV/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/LLITCHEV/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/LLITCHEV/coreclr/tags","blobs_url":"https://api.github.com/repos/LLITCHEV/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLITCHEV/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLITCHEV/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLITCHEV/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLITCHEV/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/LLITCHEV/coreclr/languages","stargazers_url":"https://api.github.com/repos/LLITCHEV/coreclr/stargazers","contributors_url":"https://api.github.com/repos/LLITCHEV/coreclr/contributors","subscribers_url":"https://api.github.com/repos/LLITCHEV/coreclr/subscribers","subscription_url":"https://api.github.com/repos/LLITCHEV/coreclr/subscription","commits_url":"https://api.github.com/repos/LLITCHEV/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLITCHEV/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLITCHEV/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLITCHEV/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLITCHEV/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/LLITCHEV/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLITCHEV/coreclr/merges","archive_url":"https://api.github.com/repos/LLITCHEV/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLITCHEV/coreclr/downloads","issues_url":"https://api.github.com/repos/LLITCHEV/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/LLITCHEV/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/LLITCHEV/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/LLITCHEV/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLITCHEV/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/LLITCHEV/coreclr/releases{/id}","created_at":"2015-02-11T00:22:43Z","updated_at":"2015-09-12T03:59:55Z","pushed_at":"2015-11-16T08:31:02Z","git_url":"git://github.com/LLITCHEV/coreclr.git","ssh_url":"git@github.com:LLITCHEV/coreclr.git","clone_url":"https://github.com/LLITCHEV/coreclr.git","svn_url":"https://github.com/LLITCHEV/coreclr","homepage":"","size":43044,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f8b864158f4e674791706feda765bb90c9003b22","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","created_at":"2015-01-30T22:10:02Z","updated_at":"2015-11-16T17:08:46Z","pushed_at":"2015-11-16T08:31:02Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"http://dotnet.github.io/","size":80894,"stargazers_count":5381,"watchers_count":5381,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1136,"mirror_url":null,"open_issues_count":341,"forks":1136,"open_issues":341,"watchers":5381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1983"},"html":{"href":"https://github.com/dotnet/coreclr/pull/1983"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1983"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/1983/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1983/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/1983/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/f8b7b8848dd6c84bc447646099010635ca2fdb39"}}}}