{"action":"created","comment":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/33349870","id":33349870,"diff_hunk":"@@ -22,3 +22,10 @@\n \n #include \"particles/ionization/byField/BSI/AlgorithmBSI.hpp\"\n #include \"particles/ionization/None/AlgorithmNone.hpp\"\n+\n+namespace picongpu\n+{\n+    /* magic number for ionization probability calculation to reduce computation time */\n+    const float_X PROB_THRESH = 0.1;","path":"src/picongpu/include/simulation_defines/unitless/ionizerConfig.unitless","position":8,"original_position":8,"commit_id":"f9b05ad6d386667b7119dd6100ea2b4d420a70a0","original_commit_id":"f9b05ad6d386667b7119dd6100ea2b4d420a70a0","user":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"body":"Sorry, I rethought the whole thing and came to the conclusion that it's not needed at all. \r\nMulti-Photon ionization (MPI) would require a Poissonian-process-like way of calculating the probability. \r\n```\r\nprobMPI = 1 - exp( - ionization_rate * time_step)\r\n```\r\nBUT tunneling ionization is no Poissonian process, I think. The models tunneling models then just lose their applicability once the probability for ionization reaches 1.\r\n```\r\nprobADK = ionization_rate * time_step\r\n```","created_at":"2015-06-26T12:09:05Z","updated_at":"2015-06-26T12:09:05Z","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/922#discussion_r33349870","pull_request_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922","_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments/33349870"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/922#discussion_r33349870"},"pull_request":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922"}}},"pull_request":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922","id":37460143,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/922","diff_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/922.diff","patch_url":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/922.patch","issue_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/922","number":922,"state":"open","locked":false,"title":"Add ionization model ADK","user":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"body":"Added the first **tunneling ionization** model to PIConGPU. \r\nIt should be used on hydrogen-like atoms and ions and requires a random generator because it uses a Monte-Carlo method.\r\n\r\n~~Do not merge before #874~~\r\n\r\nFeel free to also point out ideas for optimization and better handling of the random numbers. \r\n\r\nOnly the last commits after f030d4532d81686cbdb642735d1a96b0b7db12b0 ( \"Small fixes pointed out by @PrometheusPi\" ) are new ~~while the rest before is from #874~~.","created_at":"2015-06-11T12:57:17Z","updated_at":"2015-06-26T12:09:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a4194c24569cacba7ab10e3f7a9c568a8629b18","assignee":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2","html_url":"https://github.com/ComputationalRadiationPhysics/picongpu/milestones/Open%20Beta","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones/2/labels","id":395839,"number":2,"title":"Open Beta","description":"Tasks to complete until the release of our open beta (version 0.1)\r\n\r\nThe [beta](https://en.wikipedia.org/wiki/Software_release_life_cycle#Beta) release shall be useful for *physicist* that used a Particle-in-Cell code *before*. Experience with *compiling libraries from source* and a *good Linux knowledge* is required for the initial installation.\r\n","creator":{"login":"ax3l","id":1353258,"avatar_url":"https://avatars.githubusercontent.com/u/1353258?v=3","gravatar_id":"","url":"https://api.github.com/users/ax3l","html_url":"https://github.com/ax3l","followers_url":"https://api.github.com/users/ax3l/followers","following_url":"https://api.github.com/users/ax3l/following{/other_user}","gists_url":"https://api.github.com/users/ax3l/gists{/gist_id}","starred_url":"https://api.github.com/users/ax3l/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ax3l/subscriptions","organizations_url":"https://api.github.com/users/ax3l/orgs","repos_url":"https://api.github.com/users/ax3l/repos","events_url":"https://api.github.com/users/ax3l/events{/privacy}","received_events_url":"https://api.github.com/users/ax3l/received_events","type":"User","site_admin":false},"open_issues":101,"closed_issues":741,"state":"open","created_at":"2013-08-06T16:38:57Z","updated_at":"2015-06-25T13:27:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922/commits","review_comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922/comments","review_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/922/comments","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/f9b05ad6d386667b7119dd6100ea2b4d420a70a0","head":{"label":"n01r:topic-ionizationModelADK","ref":"topic-ionizationModelADK","sha":"f9b05ad6d386667b7119dd6100ea2b4d420a70a0","user":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"repo":{"id":12918493,"name":"picongpu","full_name":"n01r/picongpu","owner":{"login":"n01r","id":5416860,"avatar_url":"https://avatars.githubusercontent.com/u/5416860?v=3","gravatar_id":"","url":"https://api.github.com/users/n01r","html_url":"https://github.com/n01r","followers_url":"https://api.github.com/users/n01r/followers","following_url":"https://api.github.com/users/n01r/following{/other_user}","gists_url":"https://api.github.com/users/n01r/gists{/gist_id}","starred_url":"https://api.github.com/users/n01r/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/n01r/subscriptions","organizations_url":"https://api.github.com/users/n01r/orgs","repos_url":"https://api.github.com/users/n01r/repos","events_url":"https://api.github.com/users/n01r/events{/privacy}","received_events_url":"https://api.github.com/users/n01r/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/n01r/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":true,"url":"https://api.github.com/repos/n01r/picongpu","forks_url":"https://api.github.com/repos/n01r/picongpu/forks","keys_url":"https://api.github.com/repos/n01r/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/n01r/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/n01r/picongpu/teams","hooks_url":"https://api.github.com/repos/n01r/picongpu/hooks","issue_events_url":"https://api.github.com/repos/n01r/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/n01r/picongpu/events","assignees_url":"https://api.github.com/repos/n01r/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/n01r/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/n01r/picongpu/tags","blobs_url":"https://api.github.com/repos/n01r/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/n01r/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/n01r/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/n01r/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/n01r/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/n01r/picongpu/languages","stargazers_url":"https://api.github.com/repos/n01r/picongpu/stargazers","contributors_url":"https://api.github.com/repos/n01r/picongpu/contributors","subscribers_url":"https://api.github.com/repos/n01r/picongpu/subscribers","subscription_url":"https://api.github.com/repos/n01r/picongpu/subscription","commits_url":"https://api.github.com/repos/n01r/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/n01r/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/n01r/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/n01r/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/n01r/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/n01r/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/n01r/picongpu/merges","archive_url":"https://api.github.com/repos/n01r/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/n01r/picongpu/downloads","issues_url":"https://api.github.com/repos/n01r/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/n01r/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/n01r/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/n01r/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/n01r/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/n01r/picongpu/releases{/id}","created_at":"2013-09-18T08:57:42Z","updated_at":"2015-01-21T15:16:50Z","pushed_at":"2015-06-22T13:58:19Z","git_url":"git://github.com/n01r/picongpu.git","ssh_url":"git@github.com:n01r/picongpu.git","clone_url":"https://github.com/n01r/picongpu.git","svn_url":"https://github.com/n01r/picongpu","homepage":"http://picongpu.hzdr.de","size":9175,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"dev"}},"base":{"label":"ComputationalRadiationPhysics:dev","ref":"dev","sha":"d1c8c8d57377a3e8bf8dc070807156af742665b2","user":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"repo":{"id":11764461,"name":"picongpu","full_name":"ComputationalRadiationPhysics/picongpu","owner":{"login":"ComputationalRadiationPhysics","id":5120388,"avatar_url":"https://avatars.githubusercontent.com/u/5120388?v=3","gravatar_id":"","url":"https://api.github.com/users/ComputationalRadiationPhysics","html_url":"https://github.com/ComputationalRadiationPhysics","followers_url":"https://api.github.com/users/ComputationalRadiationPhysics/followers","following_url":"https://api.github.com/users/ComputationalRadiationPhysics/following{/other_user}","gists_url":"https://api.github.com/users/ComputationalRadiationPhysics/gists{/gist_id}","starred_url":"https://api.github.com/users/ComputationalRadiationPhysics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ComputationalRadiationPhysics/subscriptions","organizations_url":"https://api.github.com/users/ComputationalRadiationPhysics/orgs","repos_url":"https://api.github.com/users/ComputationalRadiationPhysics/repos","events_url":"https://api.github.com/users/ComputationalRadiationPhysics/events{/privacy}","received_events_url":"https://api.github.com/users/ComputationalRadiationPhysics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ComputationalRadiationPhysics/picongpu","description":"PIConGPU - A particle-in-cell code for GPGPUs","fork":false,"url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu","forks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/forks","keys_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/teams","hooks_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/hooks","issue_events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/events{/number}","events_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/events","assignees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/assignees{/user}","branches_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/branches{/branch}","tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/tags","blobs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/refs{/sha}","trees_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/{sha}","languages_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/languages","stargazers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/stargazers","contributors_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contributors","subscribers_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscribers","subscription_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/subscription","commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/commits{/sha}","git_commits_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/git/commits{/sha}","comments_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/comments{/number}","issue_comment_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/comments{/number}","contents_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/contents/{+path}","compare_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/merges","archive_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/downloads","issues_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues{/number}","pulls_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls{/number}","milestones_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/milestones{/number}","notifications_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/labels{/name}","releases_url":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/releases{/id}","created_at":"2013-07-30T12:28:20Z","updated_at":"2015-06-24T12:24:41Z","pushed_at":"2015-06-25T13:26:50Z","git_url":"git://github.com/ComputationalRadiationPhysics/picongpu.git","ssh_url":"git@github.com:ComputationalRadiationPhysics/picongpu.git","clone_url":"https://github.com/ComputationalRadiationPhysics/picongpu.git","svn_url":"https://github.com/ComputationalRadiationPhysics/picongpu","homepage":"http://picongpu.hzdr.de","size":15576,"stargazers_count":112,"watchers_count":112,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":64,"mirror_url":null,"open_issues_count":154,"forks":64,"open_issues":154,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922"},"html":{"href":"https://github.com/ComputationalRadiationPhysics/picongpu/pull/922"},"issue":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/922"},"comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/issues/922/comments"},"review_comments":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922/comments"},"review_comment":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/pulls/922/commits"},"statuses":{"href":"https://api.github.com/repos/ComputationalRadiationPhysics/picongpu/statuses/f9b05ad6d386667b7119dd6100ea2b4d420a70a0"}}}}