{"action":"created","comment":{"url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/comments/35482555","id":35482555,"diff_hunk":"@@ -0,0 +1,72 @@\n+--- bindings/Makefile.am\t2015-07-10 10:04:18.091199191 +0200\n++++ bindings/Makefile.am\t2015-07-10 10:19:47.047974439 +0200\n+@@ -3,8 +3,10 @@\n+ \tvala\n+ else\n+ SUBDIRS =\t\t\\\n+-\tpython\t\t\\\n+ \tvala\n++if HAS_PYTHON\n++SUBDIRS += python\n++endif\n+ endif\n+ \n+ if HAS_MONO\n+--- configure.ac\t2015-07-16 13:28:41.007502838 +0200\n++++ configure.ac_new\t2015-07-16 13:53:18.118602877 +0200\n+@@ -188,25 +188,37 @@\n+ PYGTK_REQUIRED=2.14.0\n+ PYGOBJECT_REQUIRED=0.22\n+ \n+-AM_PATH_PYTHON(2.3.5)\n+-AM_CHECK_PYTHON_HEADERS(,[AC_MSG_ERROR(could not find Python headers)])\n++AC_ARG_ENABLE([python],\n++\tAC_HELP_STRING([--enable-python], [Enable python for GTK2 build]),,\n++\t[enable_python=yes])\n+ \n+-PKG_CHECK_MODULES(APPINDICATOR_PYTHON,\n++if test x\"$with_gtk\" = \"x3\" ; then\n++\tenable_python=no\n++fi\n++\n++AM_CONDITIONAL(HAS_PYTHON, test x${enable_python} != xno)\n++\n++if test x\"$enable_python\" != x\"no\" ; then\n++\tAM_PATH_PYTHON(2.3.5)\n++\tAM_CHECK_PYTHON_HEADERS(,[AC_MSG_ERROR(could not find Python headers)])\n++\n++\tPKG_CHECK_MODULES(APPINDICATOR_PYTHON,\n+                   [\n+ \t\t\t\t\tpygtk-2.0 >= $PYGTK_REQUIRED\n+ \t\t\t\t\tgtk+-2.0 >= $GTK_REQUIRED_VERSION\n+ \t\t\t\t\tpygobject-2.0 >= $PYGOBJECT_REQUIRED\n+                   ])\n+ \n+-AC_MSG_CHECKING(for pygtk defs)\n+-PYGTK_DEFSDIR=`$PKG_CONFIG --variable=defsdir pygtk-2.0`\n+-AC_SUBST(PYGTK_DEFSDIR)\n+-AC_MSG_RESULT($PYGTK_DEFSDIR)\n+-\n+-AC_MSG_CHECKING(for pygtk codegen)\n+-PYGTK_CODEGEN=\"$PYTHON `$PKG_CONFIG --variable=codegendir pygtk-2.0`/codegen.py\"\n+-AC_SUBST(PYGTK_CODEGEN)\n+-AC_MSG_RESULT($PYGTK_CODEGEN)\n++\tAC_MSG_CHECKING(for pygtk defs)\n++\tPYGTK_DEFSDIR=`$PKG_CONFIG --variable=defsdir pygtk-2.0`\n++\tAC_SUBST(PYGTK_DEFSDIR)\n++\tAC_MSG_RESULT($PYGTK_DEFSDIR)\n++\n++\tAC_MSG_CHECKING(for pygtk codegen)\n++\tPYGTK_CODEGEN=\"$PYTHON `$PKG_CONFIG --variable=codegendir pygtk-2.0`/codegen.py\"\n++\tAC_SUBST(PYGTK_CODEGEN)\n++\tAC_MSG_RESULT($PYGTK_CODEGEN)\n++fi\n+ \n+ #########################\n+ # Check if build tests\n+@@ -278,4 +290,5 @@\n+ \tTests:         $enable_tests\n+ \tMono tests:    $have_nunit\n+ \tgcov:\t       $use_gcov\n++\tPython:        $enable_python","path":"dev-libs/libappindicator/files/libappindicator-12.10.0-conditional-py-bindings.patch","position":71,"original_position":71,"commit_id":"e150c8bf62c42b3b40578b4b82469de8dd59db1a","original_commit_id":"e150c8bf62c42b3b40578b4b82469de8dd59db1a","user":{"login":"mgorny","id":110765,"avatar_url":"https://avatars.githubusercontent.com/u/110765?v=3","gravatar_id":"","url":"https://api.github.com/users/mgorny","html_url":"https://github.com/mgorny","followers_url":"https://api.github.com/users/mgorny/followers","following_url":"https://api.github.com/users/mgorny/following{/other_user}","gists_url":"https://api.github.com/users/mgorny/gists{/gist_id}","starred_url":"https://api.github.com/users/mgorny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgorny/subscriptions","organizations_url":"https://api.github.com/users/mgorny/orgs","repos_url":"https://api.github.com/users/mgorny/repos","events_url":"https://api.github.com/users/mgorny/events{/privacy}","received_events_url":"https://api.github.com/users/mgorny/received_events","type":"User","site_admin":false},"body":"I think printing `Python: no` for GTK+3 can be a bit confusing — users think they are missing something.","created_at":"2015-07-25T12:12:37Z","updated_at":"2015-07-25T12:12:37Z","html_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/168#discussion_r35482555","pull_request_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168","_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/comments/35482555"},"html":{"href":"https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/168#discussion_r35482555"},"pull_request":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168","id":39590319,"html_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/168","diff_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/168.diff","patch_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/168.patch","issue_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues/168","number":168,"state":"open","locked":false,"title":"dev-libs/libappindicator: enable python bindings, fix introspection use flag","user":{"login":"anyc","id":1723735,"avatar_url":"https://avatars.githubusercontent.com/u/1723735?v=3","gravatar_id":"","url":"https://api.github.com/users/anyc","html_url":"https://github.com/anyc","followers_url":"https://api.github.com/users/anyc/followers","following_url":"https://api.github.com/users/anyc/following{/other_user}","gists_url":"https://api.github.com/users/anyc/gists{/gist_id}","starred_url":"https://api.github.com/users/anyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anyc/subscriptions","organizations_url":"https://api.github.com/users/anyc/orgs","repos_url":"https://api.github.com/users/anyc/repos","events_url":"https://api.github.com/users/anyc/events{/privacy}","received_events_url":"https://api.github.com/users/anyc/received_events","type":"User","site_admin":false},"body":"This patch:\r\n* enables the python bindings, required for (GTK) python apps to show a systray icon in newer desktop environments like Plasma 5\r\n* fixes the handling of the introspection use flag - now, a disabled flag disables introspection during configuration and a enabled flag requires gtk+ with introspection as well\r\n\r\nThis pull request would close these bugs:\r\n* https://bugs.gentoo.org/show_bug.cgi?id=554078 \r\n* https://bugs.gentoo.org/show_bug.cgi?id=512976","created_at":"2015-07-09T14:41:09Z","updated_at":"2015-07-25T12:12:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dce29f22e3216732ac31c864f8ecbe487aac3612","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168/commits","review_comments_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168/comments","review_comment_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues/168/comments","statuses_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/statuses/e150c8bf62c42b3b40578b4b82469de8dd59db1a","head":{"label":"anyc:master","ref":"master","sha":"e150c8bf62c42b3b40578b4b82469de8dd59db1a","user":{"login":"anyc","id":1723735,"avatar_url":"https://avatars.githubusercontent.com/u/1723735?v=3","gravatar_id":"","url":"https://api.github.com/users/anyc","html_url":"https://github.com/anyc","followers_url":"https://api.github.com/users/anyc/followers","following_url":"https://api.github.com/users/anyc/following{/other_user}","gists_url":"https://api.github.com/users/anyc/gists{/gist_id}","starred_url":"https://api.github.com/users/anyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anyc/subscriptions","organizations_url":"https://api.github.com/users/anyc/orgs","repos_url":"https://api.github.com/users/anyc/repos","events_url":"https://api.github.com/users/anyc/events{/privacy}","received_events_url":"https://api.github.com/users/anyc/received_events","type":"User","site_admin":false},"repo":{"id":38823743,"name":"gentoo-portage-rsync-mirror","full_name":"anyc/gentoo-portage-rsync-mirror","owner":{"login":"anyc","id":1723735,"avatar_url":"https://avatars.githubusercontent.com/u/1723735?v=3","gravatar_id":"","url":"https://api.github.com/users/anyc","html_url":"https://github.com/anyc","followers_url":"https://api.github.com/users/anyc/followers","following_url":"https://api.github.com/users/anyc/following{/other_user}","gists_url":"https://api.github.com/users/anyc/gists{/gist_id}","starred_url":"https://api.github.com/users/anyc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anyc/subscriptions","organizations_url":"https://api.github.com/users/anyc/orgs","repos_url":"https://api.github.com/users/anyc/repos","events_url":"https://api.github.com/users/anyc/events{/privacy}","received_events_url":"https://api.github.com/users/anyc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anyc/gentoo-portage-rsync-mirror","description":"Git mirror of the official Gentoo ebuild repository (created from rsync)","fork":true,"url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror","forks_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/forks","keys_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/teams","hooks_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/hooks","issue_events_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/issues/events{/number}","events_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/events","assignees_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/assignees{/user}","branches_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/branches{/branch}","tags_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/tags","blobs_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/statuses/{sha}","languages_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/languages","stargazers_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/stargazers","contributors_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/contributors","subscribers_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/subscribers","subscription_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/subscription","commits_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/contents/{+path}","compare_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/merges","archive_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/downloads","issues_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/issues{/number}","pulls_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/pulls{/number}","milestones_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/milestones{/number}","notifications_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/labels{/name}","releases_url":"https://api.github.com/repos/anyc/gentoo-portage-rsync-mirror/releases{/id}","created_at":"2015-07-09T14:00:25Z","updated_at":"2015-07-09T14:05:55Z","pushed_at":"2015-07-16T12:12:13Z","git_url":"git://github.com/anyc/gentoo-portage-rsync-mirror.git","ssh_url":"git@github.com:anyc/gentoo-portage-rsync-mirror.git","clone_url":"https://github.com/anyc/gentoo-portage-rsync-mirror.git","svn_url":"https://github.com/anyc/gentoo-portage-rsync-mirror","homepage":"","size":1204268,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gentoo:master","ref":"master","sha":"955d47cee1a3f897c0ec8fa3b431e8ca0a8eb985","user":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"repo":{"id":29787434,"name":"gentoo-portage-rsync-mirror","full_name":"gentoo/gentoo-portage-rsync-mirror","owner":{"login":"gentoo","id":52242,"avatar_url":"https://avatars.githubusercontent.com/u/52242?v=3","gravatar_id":"","url":"https://api.github.com/users/gentoo","html_url":"https://github.com/gentoo","followers_url":"https://api.github.com/users/gentoo/followers","following_url":"https://api.github.com/users/gentoo/following{/other_user}","gists_url":"https://api.github.com/users/gentoo/gists{/gist_id}","starred_url":"https://api.github.com/users/gentoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gentoo/subscriptions","organizations_url":"https://api.github.com/users/gentoo/orgs","repos_url":"https://api.github.com/users/gentoo/repos","events_url":"https://api.github.com/users/gentoo/events{/privacy}","received_events_url":"https://api.github.com/users/gentoo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror","description":"Git mirror of the official Gentoo ebuild repository (created from rsync)","fork":false,"url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror","forks_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/forks","keys_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/teams","hooks_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/hooks","issue_events_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues/events{/number}","events_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/events","assignees_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/assignees{/user}","branches_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/branches{/branch}","tags_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/tags","blobs_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/git/refs{/sha}","trees_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/statuses/{sha}","languages_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/languages","stargazers_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/stargazers","contributors_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/contributors","subscribers_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/subscribers","subscription_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/subscription","commits_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/commits{/sha}","git_commits_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/git/commits{/sha}","comments_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/comments{/number}","issue_comment_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues/comments{/number}","contents_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/contents/{+path}","compare_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/merges","archive_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/downloads","issues_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues{/number}","pulls_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls{/number}","milestones_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/milestones{/number}","notifications_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/labels{/name}","releases_url":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/releases{/id}","created_at":"2015-01-24T18:48:40Z","updated_at":"2015-07-22T12:22:52Z","pushed_at":"2015-07-25T12:03:09Z","git_url":"git://github.com/gentoo/gentoo-portage-rsync-mirror.git","ssh_url":"git@github.com:gentoo/gentoo-portage-rsync-mirror.git","clone_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror.git","svn_url":"https://github.com/gentoo/gentoo-portage-rsync-mirror","homepage":"","size":1242307,"stargazers_count":76,"watchers_count":76,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":21,"forks":50,"open_issues":21,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168"},"html":{"href":"https://github.com/gentoo/gentoo-portage-rsync-mirror/pull/168"},"issue":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues/168"},"comments":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/gentoo/gentoo-portage-rsync-mirror/statuses/e150c8bf62c42b3b40578b4b82469de8dd59db1a"}}}}