{"action":"created","comment":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/22611130","id":22611130,"diff_hunk":"@@ -73,25 +88,71 @@ public RepeatStatus execute(StepContribution contribution, ChunkContext chunkCon\n \n \t\tString commandClassPath = createClassPath(this.getClass());\n \n-\t\tProcessBuilder pb = new ProcessBuilder(command).redirectErrorStream(true);\n+\t\tFile out = File.createTempFile(commandName + \"-\", \".out\");\n+\t\tstepExecution.getExecutionContext().putString(commandName.toLowerCase() + \".system.out\", out.getAbsolutePath());\n+\t\tlogger.info(commandName + \" system.out: \" + out.getAbsolutePath());\n+\t\tFile err = File.createTempFile(commandName + \"-\", \".err\");","path":"extensions/spring-xd-extension-batch/src/main/java/org/springframework/batch/step/tasklet/x/AbstractProcessBuilderTasklet.java","position":66,"original_position":66,"commit_id":"eafb6aed04e4c5c65e89ee594660a3ce3efaa8ad","original_commit_id":"eafb6aed04e4c5c65e89ee594660a3ce3efaa8ad","user":{"login":"mminella","id":630743,"avatar_url":"https://avatars.githubusercontent.com/u/630743?v=3","gravatar_id":"","url":"https://api.github.com/users/mminella","html_url":"https://github.com/mminella","followers_url":"https://api.github.com/users/mminella/followers","following_url":"https://api.github.com/users/mminella/following{/other_user}","gists_url":"https://api.github.com/users/mminella/gists{/gist_id}","starred_url":"https://api.github.com/users/mminella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminella/subscriptions","organizations_url":"https://api.github.com/users/mminella/orgs","repos_url":"https://api.github.com/users/mminella/repos","events_url":"https://api.github.com/users/mminella/events{/privacy}","received_events_url":"https://api.github.com/users/mminella/received_events","type":"User","site_admin":false},"body":"While temp files are definitely a step in the right direction, is there a reason we can't inject a location for these instead of using temp files?","created_at":"2015-01-07T19:57:17Z","updated_at":"2015-01-07T19:57:17Z","html_url":"https://github.com/spring-projects/spring-xd/pull/1359#discussion_r22611130","pull_request_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359","_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/22611130"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1359#discussion_r22611130"},"pull_request":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359"}}},"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359","id":26982585,"html_url":"https://github.com/spring-projects/spring-xd/pull/1359","diff_url":"https://github.com/spring-projects/spring-xd/pull/1359.diff","patch_url":"https://github.com/spring-projects/spring-xd/pull/1359.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1359","number":1359,"state":"open","locked":false,"title":"[Sprint: 41] XD-2477 Adding stoppable logic to AbstractProcessBuilderTasklet","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"body":"- improving log management using temp files\r\n\r\n- improving exit status handling\r\n\r\n- improving step execution status management when job fails\r\n\r\n- still can't make Sqoop job stoppable due to the fact that the Sqoop mapreduce job keeps running even if launching process is destroyed\r\n\r\n- adding INFO logging for Sqoop tasklet so user can tail Sqoop log for long running jobs","created_at":"2015-01-07T19:51:53Z","updated_at":"2015-01-07T19:57:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7a1bb050b5f8e083f686993f1741e3c565560eed","assignee":{"login":"mminella","id":630743,"avatar_url":"https://avatars.githubusercontent.com/u/630743?v=3","gravatar_id":"","url":"https://api.github.com/users/mminella","html_url":"https://github.com/mminella","followers_url":"https://api.github.com/users/mminella/followers","following_url":"https://api.github.com/users/mminella/following{/other_user}","gists_url":"https://api.github.com/users/mminella/gists{/gist_id}","starred_url":"https://api.github.com/users/mminella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mminella/subscriptions","organizations_url":"https://api.github.com/users/mminella/orgs","repos_url":"https://api.github.com/users/mminella/repos","events_url":"https://api.github.com/users/mminella/events{/privacy}","received_events_url":"https://api.github.com/users/mminella/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/1359/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/eafb6aed04e4c5c65e89ee594660a3ce3efaa8ad","head":{"label":"trisberg:XD-2477","ref":"XD-2477","sha":"eafb6aed04e4c5c65e89ee594660a3ce3efaa8ad","user":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"repo":{"id":17178893,"name":"spring-xd","full_name":"trisberg/spring-xd","owner":{"login":"trisberg","id":78614,"avatar_url":"https://avatars.githubusercontent.com/u/78614?v=3","gravatar_id":"","url":"https://api.github.com/users/trisberg","html_url":"https://github.com/trisberg","followers_url":"https://api.github.com/users/trisberg/followers","following_url":"https://api.github.com/users/trisberg/following{/other_user}","gists_url":"https://api.github.com/users/trisberg/gists{/gist_id}","starred_url":"https://api.github.com/users/trisberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trisberg/subscriptions","organizations_url":"https://api.github.com/users/trisberg/orgs","repos_url":"https://api.github.com/users/trisberg/repos","events_url":"https://api.github.com/users/trisberg/events{/privacy}","received_events_url":"https://api.github.com/users/trisberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trisberg/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":true,"url":"https://api.github.com/repos/trisberg/spring-xd","forks_url":"https://api.github.com/repos/trisberg/spring-xd/forks","keys_url":"https://api.github.com/repos/trisberg/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trisberg/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trisberg/spring-xd/teams","hooks_url":"https://api.github.com/repos/trisberg/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/trisberg/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/trisberg/spring-xd/events","assignees_url":"https://api.github.com/repos/trisberg/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/trisberg/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/trisberg/spring-xd/tags","blobs_url":"https://api.github.com/repos/trisberg/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trisberg/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trisberg/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/trisberg/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trisberg/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/trisberg/spring-xd/languages","stargazers_url":"https://api.github.com/repos/trisberg/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/trisberg/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/trisberg/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/trisberg/spring-xd/subscription","commits_url":"https://api.github.com/repos/trisberg/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/trisberg/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/trisberg/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/trisberg/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/trisberg/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/trisberg/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trisberg/spring-xd/merges","archive_url":"https://api.github.com/repos/trisberg/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trisberg/spring-xd/downloads","issues_url":"https://api.github.com/repos/trisberg/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/trisberg/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/trisberg/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/trisberg/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trisberg/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/trisberg/spring-xd/releases{/id}","created_at":"2014-02-25T16:03:10Z","updated_at":"2015-01-05T19:34:58Z","pushed_at":"2015-01-07T19:50:53Z","git_url":"git://github.com/trisberg/spring-xd.git","ssh_url":"git@github.com:trisberg/spring-xd.git","clone_url":"https://github.com/trisberg/spring-xd.git","svn_url":"https://github.com/trisberg/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":19381,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"a5c066337e0f74a56e7ad985357c8cf35778ed73","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":9349347,"name":"spring-xd","full_name":"spring-projects/spring-xd","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-xd","description":"Spring XD makes it easy to solve common big data problems such as data ingestion and export, real-time analytics, and batch workflow orchestration","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-xd","forks_url":"https://api.github.com/repos/spring-projects/spring-xd/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-xd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-xd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-xd/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-xd/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-xd/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-xd/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-xd/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-xd/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-xd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-xd/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-xd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-xd/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-xd/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-xd/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-xd/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-xd/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-xd/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-xd/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-xd/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-xd/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-xd/issues/comments/{number}","contents_url":"https://api.github.com/repos/spring-projects/spring-xd/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-xd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-xd/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-xd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-xd/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-xd/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-xd/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-xd/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-xd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-xd/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-xd/releases{/id}","created_at":"2013-04-10T15:31:44Z","updated_at":"2015-01-07T15:56:23Z","pushed_at":"2015-01-07T15:56:23Z","git_url":"git://github.com/spring-projects/spring-xd.git","ssh_url":"git@github.com:spring-projects/spring-xd.git","clone_url":"https://github.com/spring-projects/spring-xd.git","svn_url":"https://github.com/spring-projects/spring-xd","homepage":"http://projects.spring.io/spring-xd","size":46968,"stargazers_count":207,"watchers_count":207,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":171,"mirror_url":null,"open_issues_count":23,"forks":171,"open_issues":23,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359"},"html":{"href":"https://github.com/spring-projects/spring-xd/pull/1359"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1359"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/issues/1359/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-xd/pulls/1359/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-xd/statuses/eafb6aed04e4c5c65e89ee594660a3ce3efaa8ad"}}}}