{"action":"created","comment":{"url":"https://api.github.com/repos/etsy/Hound/pulls/comments/23842742","id":23842742,"diff_hunk":"@@ -42,7 +36,11 @@ func HeadHash(dir string) (string, error) {\n }\n \n func Pull(dir string) (string, error) {\n-\tif err := pull(dir); err != nil {\n+\tcmd := exec.Command(\"git\", \"pull\")\n+\tcmd.Dir = dir\n+\tout, err := cmd.CombinedOutput()","path":"src/hound/git/git.go","position":28,"original_position":28,"commit_id":"1290da34d16f83e484d2f79a096208d6bff64e5b","original_commit_id":"1290da34d16f83e484d2f79a096208d6bff64e5b","user":{"login":"kellegous","id":54528,"avatar_url":"https://avatars.githubusercontent.com/u/54528?v=3","gravatar_id":"","url":"https://api.github.com/users/kellegous","html_url":"https://github.com/kellegous","followers_url":"https://api.github.com/users/kellegous/followers","following_url":"https://api.github.com/users/kellegous/following{/other_user}","gists_url":"https://api.github.com/users/kellegous/gists{/gist_id}","starred_url":"https://api.github.com/users/kellegous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellegous/subscriptions","organizations_url":"https://api.github.com/users/kellegous/orgs","repos_url":"https://api.github.com/users/kellegous/repos","events_url":"https://api.github.com/users/kellegous/events{/privacy}","received_events_url":"https://api.github.com/users/kellegous/received_events","type":"User","site_admin":false},"body":"Instead of combining the output, why don't we just give stdout and stderr of the parent process to the child. `cmd.Stdout = os.Stdout` and `cmd.Stderr = os.Stderr`. That way the streams will be intact.","created_at":"2015-01-30T13:46:19Z","updated_at":"2015-01-30T13:46:19Z","html_url":"https://github.com/etsy/Hound/pull/36#discussion_r23842742","pull_request_url":"https://api.github.com/repos/etsy/Hound/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/etsy/Hound/pulls/comments/23842742"},"html":{"href":"https://github.com/etsy/Hound/pull/36#discussion_r23842742"},"pull_request":{"href":"https://api.github.com/repos/etsy/Hound/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/etsy/Hound/pulls/36","id":28290644,"html_url":"https://github.com/etsy/Hound/pull/36","diff_url":"https://github.com/etsy/Hound/pull/36.diff","patch_url":"https://github.com/etsy/Hound/pull/36.patch","issue_url":"https://api.github.com/repos/etsy/Hound/issues/36","number":36,"state":"open","locked":false,"title":"Fixes #33, continue when a repo is empty and just report it","user":{"login":"jklein","id":629982,"avatar_url":"https://avatars.githubusercontent.com/u/629982?v=3","gravatar_id":"","url":"https://api.github.com/users/jklein","html_url":"https://github.com/jklein","followers_url":"https://api.github.com/users/jklein/followers","following_url":"https://api.github.com/users/jklein/following{/other_user}","gists_url":"https://api.github.com/users/jklein/gists{/gist_id}","starred_url":"https://api.github.com/users/jklein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklein/subscriptions","organizations_url":"https://api.github.com/users/jklein/orgs","repos_url":"https://api.github.com/users/jklein/repos","events_url":"https://api.github.com/users/jklein/events{/privacy}","received_events_url":"https://api.github.com/users/jklein/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-01-29T16:05:47Z","updated_at":"2015-01-30T13:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e8884bef8614f379df95277516f5f118a14ac4e","assignee":{"login":"kellegous","id":54528,"avatar_url":"https://avatars.githubusercontent.com/u/54528?v=3","gravatar_id":"","url":"https://api.github.com/users/kellegous","html_url":"https://github.com/kellegous","followers_url":"https://api.github.com/users/kellegous/followers","following_url":"https://api.github.com/users/kellegous/following{/other_user}","gists_url":"https://api.github.com/users/kellegous/gists{/gist_id}","starred_url":"https://api.github.com/users/kellegous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellegous/subscriptions","organizations_url":"https://api.github.com/users/kellegous/orgs","repos_url":"https://api.github.com/users/kellegous/repos","events_url":"https://api.github.com/users/kellegous/events{/privacy}","received_events_url":"https://api.github.com/users/kellegous/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/etsy/Hound/pulls/36/commits","review_comments_url":"https://api.github.com/repos/etsy/Hound/pulls/36/comments","review_comment_url":"https://api.github.com/repos/etsy/Hound/pulls/comments/{number}","comments_url":"https://api.github.com/repos/etsy/Hound/issues/36/comments","statuses_url":"https://api.github.com/repos/etsy/Hound/statuses/1290da34d16f83e484d2f79a096208d6bff64e5b","head":{"label":"etsy:empty_repos","ref":"empty_repos","sha":"1290da34d16f83e484d2f79a096208d6bff64e5b","user":{"login":"etsy","id":193389,"avatar_url":"https://avatars.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"repo":{"id":28930512,"name":"Hound","full_name":"etsy/Hound","owner":{"login":"etsy","id":193389,"avatar_url":"https://avatars.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etsy/Hound","description":"Lightning fast code searching made easy","fork":false,"url":"https://api.github.com/repos/etsy/Hound","forks_url":"https://api.github.com/repos/etsy/Hound/forks","keys_url":"https://api.github.com/repos/etsy/Hound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etsy/Hound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etsy/Hound/teams","hooks_url":"https://api.github.com/repos/etsy/Hound/hooks","issue_events_url":"https://api.github.com/repos/etsy/Hound/issues/events{/number}","events_url":"https://api.github.com/repos/etsy/Hound/events","assignees_url":"https://api.github.com/repos/etsy/Hound/assignees{/user}","branches_url":"https://api.github.com/repos/etsy/Hound/branches{/branch}","tags_url":"https://api.github.com/repos/etsy/Hound/tags","blobs_url":"https://api.github.com/repos/etsy/Hound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etsy/Hound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etsy/Hound/git/refs{/sha}","trees_url":"https://api.github.com/repos/etsy/Hound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etsy/Hound/statuses/{sha}","languages_url":"https://api.github.com/repos/etsy/Hound/languages","stargazers_url":"https://api.github.com/repos/etsy/Hound/stargazers","contributors_url":"https://api.github.com/repos/etsy/Hound/contributors","subscribers_url":"https://api.github.com/repos/etsy/Hound/subscribers","subscription_url":"https://api.github.com/repos/etsy/Hound/subscription","commits_url":"https://api.github.com/repos/etsy/Hound/commits{/sha}","git_commits_url":"https://api.github.com/repos/etsy/Hound/git/commits{/sha}","comments_url":"https://api.github.com/repos/etsy/Hound/comments{/number}","issue_comment_url":"https://api.github.com/repos/etsy/Hound/issues/comments/{number}","contents_url":"https://api.github.com/repos/etsy/Hound/contents/{+path}","compare_url":"https://api.github.com/repos/etsy/Hound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etsy/Hound/merges","archive_url":"https://api.github.com/repos/etsy/Hound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etsy/Hound/downloads","issues_url":"https://api.github.com/repos/etsy/Hound/issues{/number}","pulls_url":"https://api.github.com/repos/etsy/Hound/pulls{/number}","milestones_url":"https://api.github.com/repos/etsy/Hound/milestones{/number}","notifications_url":"https://api.github.com/repos/etsy/Hound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etsy/Hound/labels{/name}","releases_url":"https://api.github.com/repos/etsy/Hound/releases{/id}","created_at":"2015-01-07T19:38:37Z","updated_at":"2015-01-30T13:17:51Z","pushed_at":"2015-01-30T12:59:03Z","git_url":"git://github.com/etsy/Hound.git","ssh_url":"git@github.com:etsy/Hound.git","clone_url":"https://github.com/etsy/Hound.git","svn_url":"https://github.com/etsy/Hound","homepage":"","size":522,"stargazers_count":1174,"watchers_count":1174,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":19,"forks":60,"open_issues":19,"watchers":1174,"default_branch":"master"}},"base":{"label":"etsy:master","ref":"master","sha":"db7061fef69d86bef9c2b54792ee152517f13d32","user":{"login":"etsy","id":193389,"avatar_url":"https://avatars.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"repo":{"id":28930512,"name":"Hound","full_name":"etsy/Hound","owner":{"login":"etsy","id":193389,"avatar_url":"https://avatars.githubusercontent.com/u/193389?v=3","gravatar_id":"","url":"https://api.github.com/users/etsy","html_url":"https://github.com/etsy","followers_url":"https://api.github.com/users/etsy/followers","following_url":"https://api.github.com/users/etsy/following{/other_user}","gists_url":"https://api.github.com/users/etsy/gists{/gist_id}","starred_url":"https://api.github.com/users/etsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etsy/subscriptions","organizations_url":"https://api.github.com/users/etsy/orgs","repos_url":"https://api.github.com/users/etsy/repos","events_url":"https://api.github.com/users/etsy/events{/privacy}","received_events_url":"https://api.github.com/users/etsy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/etsy/Hound","description":"Lightning fast code searching made easy","fork":false,"url":"https://api.github.com/repos/etsy/Hound","forks_url":"https://api.github.com/repos/etsy/Hound/forks","keys_url":"https://api.github.com/repos/etsy/Hound/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etsy/Hound/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etsy/Hound/teams","hooks_url":"https://api.github.com/repos/etsy/Hound/hooks","issue_events_url":"https://api.github.com/repos/etsy/Hound/issues/events{/number}","events_url":"https://api.github.com/repos/etsy/Hound/events","assignees_url":"https://api.github.com/repos/etsy/Hound/assignees{/user}","branches_url":"https://api.github.com/repos/etsy/Hound/branches{/branch}","tags_url":"https://api.github.com/repos/etsy/Hound/tags","blobs_url":"https://api.github.com/repos/etsy/Hound/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etsy/Hound/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etsy/Hound/git/refs{/sha}","trees_url":"https://api.github.com/repos/etsy/Hound/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etsy/Hound/statuses/{sha}","languages_url":"https://api.github.com/repos/etsy/Hound/languages","stargazers_url":"https://api.github.com/repos/etsy/Hound/stargazers","contributors_url":"https://api.github.com/repos/etsy/Hound/contributors","subscribers_url":"https://api.github.com/repos/etsy/Hound/subscribers","subscription_url":"https://api.github.com/repos/etsy/Hound/subscription","commits_url":"https://api.github.com/repos/etsy/Hound/commits{/sha}","git_commits_url":"https://api.github.com/repos/etsy/Hound/git/commits{/sha}","comments_url":"https://api.github.com/repos/etsy/Hound/comments{/number}","issue_comment_url":"https://api.github.com/repos/etsy/Hound/issues/comments/{number}","contents_url":"https://api.github.com/repos/etsy/Hound/contents/{+path}","compare_url":"https://api.github.com/repos/etsy/Hound/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etsy/Hound/merges","archive_url":"https://api.github.com/repos/etsy/Hound/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etsy/Hound/downloads","issues_url":"https://api.github.com/repos/etsy/Hound/issues{/number}","pulls_url":"https://api.github.com/repos/etsy/Hound/pulls{/number}","milestones_url":"https://api.github.com/repos/etsy/Hound/milestones{/number}","notifications_url":"https://api.github.com/repos/etsy/Hound/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etsy/Hound/labels{/name}","releases_url":"https://api.github.com/repos/etsy/Hound/releases{/id}","created_at":"2015-01-07T19:38:37Z","updated_at":"2015-01-30T13:17:51Z","pushed_at":"2015-01-30T12:59:03Z","git_url":"git://github.com/etsy/Hound.git","ssh_url":"git@github.com:etsy/Hound.git","clone_url":"https://github.com/etsy/Hound.git","svn_url":"https://github.com/etsy/Hound","homepage":"","size":522,"stargazers_count":1174,"watchers_count":1174,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":19,"forks":60,"open_issues":19,"watchers":1174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/etsy/Hound/pulls/36"},"html":{"href":"https://github.com/etsy/Hound/pull/36"},"issue":{"href":"https://api.github.com/repos/etsy/Hound/issues/36"},"comments":{"href":"https://api.github.com/repos/etsy/Hound/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/etsy/Hound/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/etsy/Hound/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/etsy/Hound/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/etsy/Hound/statuses/1290da34d16f83e484d2f79a096208d6bff64e5b"}}}}