{"action":"opened","number":369,"pull_request":{"url":"https://api.github.com/repos/Alamofire/Alamofire/pulls/369","id":30502003,"html_url":"https://github.com/Alamofire/Alamofire/pull/369","diff_url":"https://github.com/Alamofire/Alamofire/pull/369.diff","patch_url":"https://github.com/Alamofire/Alamofire/pull/369.patch","issue_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/369","number":369,"state":"open","locked":false,"title":"fix escaping query parameters","user":{"login":"slizeray","id":5292428,"avatar_url":"https://avatars.githubusercontent.com/u/5292428?v=3","gravatar_id":"","url":"https://api.github.com/users/slizeray","html_url":"https://github.com/slizeray","followers_url":"https://api.github.com/users/slizeray/followers","following_url":"https://api.github.com/users/slizeray/following{/other_user}","gists_url":"https://api.github.com/users/slizeray/gists{/gist_id}","starred_url":"https://api.github.com/users/slizeray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slizeray/subscriptions","organizations_url":"https://api.github.com/users/slizeray/orgs","repos_url":"https://api.github.com/users/slizeray/repos","events_url":"https://api.github.com/users/slizeray/events{/privacy}","received_events_url":"https://api.github.com/users/slizeray/received_events","type":"User","site_admin":false},"body":"For escaping the query parameters I propose to use the iOS 7 API and above\r\nstringByAddingPercentEncodingWithAllowedCharacters(NSCharacterSet.URLQueryAllowedCharacterSet())\r\n\r\nThe result is not the same as the current implementation which for instances escapes the / parameter whereas iOS does NOT","created_at":"2015-03-04T20:37:33Z","updated_at":"2015-03-04T20:37:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Alamofire/Alamofire/pulls/369/commits","review_comments_url":"https://api.github.com/repos/Alamofire/Alamofire/pulls/369/comments","review_comment_url":"https://api.github.com/repos/Alamofire/Alamofire/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/369/comments","statuses_url":"https://api.github.com/repos/Alamofire/Alamofire/statuses/ad5d4978bafbac72109084f469a68d7f16ee5639","head":{"label":"slizeray:escapeQuery","ref":"escapeQuery","sha":"ad5d4978bafbac72109084f469a68d7f16ee5639","user":{"login":"slizeray","id":5292428,"avatar_url":"https://avatars.githubusercontent.com/u/5292428?v=3","gravatar_id":"","url":"https://api.github.com/users/slizeray","html_url":"https://github.com/slizeray","followers_url":"https://api.github.com/users/slizeray/followers","following_url":"https://api.github.com/users/slizeray/following{/other_user}","gists_url":"https://api.github.com/users/slizeray/gists{/gist_id}","starred_url":"https://api.github.com/users/slizeray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slizeray/subscriptions","organizations_url":"https://api.github.com/users/slizeray/orgs","repos_url":"https://api.github.com/users/slizeray/repos","events_url":"https://api.github.com/users/slizeray/events{/privacy}","received_events_url":"https://api.github.com/users/slizeray/received_events","type":"User","site_admin":false},"repo":{"id":31664928,"name":"Alamofire","full_name":"slizeray/Alamofire","owner":{"login":"slizeray","id":5292428,"avatar_url":"https://avatars.githubusercontent.com/u/5292428?v=3","gravatar_id":"","url":"https://api.github.com/users/slizeray","html_url":"https://github.com/slizeray","followers_url":"https://api.github.com/users/slizeray/followers","following_url":"https://api.github.com/users/slizeray/following{/other_user}","gists_url":"https://api.github.com/users/slizeray/gists{/gist_id}","starred_url":"https://api.github.com/users/slizeray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slizeray/subscriptions","organizations_url":"https://api.github.com/users/slizeray/orgs","repos_url":"https://api.github.com/users/slizeray/repos","events_url":"https://api.github.com/users/slizeray/events{/privacy}","received_events_url":"https://api.github.com/users/slizeray/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/slizeray/Alamofire","description":"Elegant HTTP Networking in Swift","fork":true,"url":"https://api.github.com/repos/slizeray/Alamofire","forks_url":"https://api.github.com/repos/slizeray/Alamofire/forks","keys_url":"https://api.github.com/repos/slizeray/Alamofire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slizeray/Alamofire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slizeray/Alamofire/teams","hooks_url":"https://api.github.com/repos/slizeray/Alamofire/hooks","issue_events_url":"https://api.github.com/repos/slizeray/Alamofire/issues/events{/number}","events_url":"https://api.github.com/repos/slizeray/Alamofire/events","assignees_url":"https://api.github.com/repos/slizeray/Alamofire/assignees{/user}","branches_url":"https://api.github.com/repos/slizeray/Alamofire/branches{/branch}","tags_url":"https://api.github.com/repos/slizeray/Alamofire/tags","blobs_url":"https://api.github.com/repos/slizeray/Alamofire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slizeray/Alamofire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slizeray/Alamofire/git/refs{/sha}","trees_url":"https://api.github.com/repos/slizeray/Alamofire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slizeray/Alamofire/statuses/{sha}","languages_url":"https://api.github.com/repos/slizeray/Alamofire/languages","stargazers_url":"https://api.github.com/repos/slizeray/Alamofire/stargazers","contributors_url":"https://api.github.com/repos/slizeray/Alamofire/contributors","subscribers_url":"https://api.github.com/repos/slizeray/Alamofire/subscribers","subscription_url":"https://api.github.com/repos/slizeray/Alamofire/subscription","commits_url":"https://api.github.com/repos/slizeray/Alamofire/commits{/sha}","git_commits_url":"https://api.github.com/repos/slizeray/Alamofire/git/commits{/sha}","comments_url":"https://api.github.com/repos/slizeray/Alamofire/comments{/number}","issue_comment_url":"https://api.github.com/repos/slizeray/Alamofire/issues/comments{/number}","contents_url":"https://api.github.com/repos/slizeray/Alamofire/contents/{+path}","compare_url":"https://api.github.com/repos/slizeray/Alamofire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slizeray/Alamofire/merges","archive_url":"https://api.github.com/repos/slizeray/Alamofire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slizeray/Alamofire/downloads","issues_url":"https://api.github.com/repos/slizeray/Alamofire/issues{/number}","pulls_url":"https://api.github.com/repos/slizeray/Alamofire/pulls{/number}","milestones_url":"https://api.github.com/repos/slizeray/Alamofire/milestones{/number}","notifications_url":"https://api.github.com/repos/slizeray/Alamofire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slizeray/Alamofire/labels{/name}","releases_url":"https://api.github.com/repos/slizeray/Alamofire/releases{/id}","created_at":"2015-03-04T15:45:38Z","updated_at":"2015-03-04T15:45:39Z","pushed_at":"2015-03-04T20:29:39Z","git_url":"git://github.com/slizeray/Alamofire.git","ssh_url":"git@github.com:slizeray/Alamofire.git","clone_url":"https://github.com/slizeray/Alamofire.git","svn_url":"https://github.com/slizeray/Alamofire","homepage":"","size":2199,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Alamofire:xcode-6.3","ref":"xcode-6.3","sha":"2f39b8634ab85cd6b3a55bbcfdec8cbb6463a6ee","user":{"login":"Alamofire","id":7774181,"avatar_url":"https://avatars.githubusercontent.com/u/7774181?v=3","gravatar_id":"","url":"https://api.github.com/users/Alamofire","html_url":"https://github.com/Alamofire","followers_url":"https://api.github.com/users/Alamofire/followers","following_url":"https://api.github.com/users/Alamofire/following{/other_user}","gists_url":"https://api.github.com/users/Alamofire/gists{/gist_id}","starred_url":"https://api.github.com/users/Alamofire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alamofire/subscriptions","organizations_url":"https://api.github.com/users/Alamofire/orgs","repos_url":"https://api.github.com/users/Alamofire/repos","events_url":"https://api.github.com/users/Alamofire/events{/privacy}","received_events_url":"https://api.github.com/users/Alamofire/received_events","type":"Organization","site_admin":false},"repo":{"id":22458259,"name":"Alamofire","full_name":"Alamofire/Alamofire","owner":{"login":"Alamofire","id":7774181,"avatar_url":"https://avatars.githubusercontent.com/u/7774181?v=3","gravatar_id":"","url":"https://api.github.com/users/Alamofire","html_url":"https://github.com/Alamofire","followers_url":"https://api.github.com/users/Alamofire/followers","following_url":"https://api.github.com/users/Alamofire/following{/other_user}","gists_url":"https://api.github.com/users/Alamofire/gists{/gist_id}","starred_url":"https://api.github.com/users/Alamofire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alamofire/subscriptions","organizations_url":"https://api.github.com/users/Alamofire/orgs","repos_url":"https://api.github.com/users/Alamofire/repos","events_url":"https://api.github.com/users/Alamofire/events{/privacy}","received_events_url":"https://api.github.com/users/Alamofire/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Alamofire/Alamofire","description":"Elegant HTTP Networking in Swift","fork":false,"url":"https://api.github.com/repos/Alamofire/Alamofire","forks_url":"https://api.github.com/repos/Alamofire/Alamofire/forks","keys_url":"https://api.github.com/repos/Alamofire/Alamofire/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alamofire/Alamofire/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alamofire/Alamofire/teams","hooks_url":"https://api.github.com/repos/Alamofire/Alamofire/hooks","issue_events_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/events{/number}","events_url":"https://api.github.com/repos/Alamofire/Alamofire/events","assignees_url":"https://api.github.com/repos/Alamofire/Alamofire/assignees{/user}","branches_url":"https://api.github.com/repos/Alamofire/Alamofire/branches{/branch}","tags_url":"https://api.github.com/repos/Alamofire/Alamofire/tags","blobs_url":"https://api.github.com/repos/Alamofire/Alamofire/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alamofire/Alamofire/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alamofire/Alamofire/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alamofire/Alamofire/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alamofire/Alamofire/statuses/{sha}","languages_url":"https://api.github.com/repos/Alamofire/Alamofire/languages","stargazers_url":"https://api.github.com/repos/Alamofire/Alamofire/stargazers","contributors_url":"https://api.github.com/repos/Alamofire/Alamofire/contributors","subscribers_url":"https://api.github.com/repos/Alamofire/Alamofire/subscribers","subscription_url":"https://api.github.com/repos/Alamofire/Alamofire/subscription","commits_url":"https://api.github.com/repos/Alamofire/Alamofire/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alamofire/Alamofire/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alamofire/Alamofire/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alamofire/Alamofire/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alamofire/Alamofire/contents/{+path}","compare_url":"https://api.github.com/repos/Alamofire/Alamofire/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alamofire/Alamofire/merges","archive_url":"https://api.github.com/repos/Alamofire/Alamofire/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alamofire/Alamofire/downloads","issues_url":"https://api.github.com/repos/Alamofire/Alamofire/issues{/number}","pulls_url":"https://api.github.com/repos/Alamofire/Alamofire/pulls{/number}","milestones_url":"https://api.github.com/repos/Alamofire/Alamofire/milestones{/number}","notifications_url":"https://api.github.com/repos/Alamofire/Alamofire/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alamofire/Alamofire/labels{/name}","releases_url":"https://api.github.com/repos/Alamofire/Alamofire/releases{/id}","created_at":"2014-07-31T05:56:19Z","updated_at":"2015-03-04T20:31:29Z","pushed_at":"2015-03-02T16:09:17Z","git_url":"git://github.com/Alamofire/Alamofire.git","ssh_url":"git@github.com:Alamofire/Alamofire.git","clone_url":"https://github.com/Alamofire/Alamofire.git","svn_url":"https://github.com/Alamofire/Alamofire","homepage":"","size":2199,"stargazers_count":6976,"watchers_count":6976,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":742,"mirror_url":null,"open_issues_count":22,"forks":742,"open_issues":22,"watchers":6976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Alamofire/Alamofire/pulls/369"},"html":{"href":"https://github.com/Alamofire/Alamofire/pull/369"},"issue":{"href":"https://api.github.com/repos/Alamofire/Alamofire/issues/369"},"comments":{"href":"https://api.github.com/repos/Alamofire/Alamofire/issues/369/comments"},"review_comments":{"href":"https://api.github.com/repos/Alamofire/Alamofire/pulls/369/comments"},"review_comment":{"href":"https://api.github.com/repos/Alamofire/Alamofire/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alamofire/Alamofire/pulls/369/commits"},"statuses":{"href":"https://api.github.com/repos/Alamofire/Alamofire/statuses/ad5d4978bafbac72109084f469a68d7f16ee5639"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":8,"changed_files":2}}