{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/10706","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/10706/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/10706/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/10706/events","html_url":"https://github.com/edx/edx-platform/pull/10706","id":118390018,"number":10706,"title":"Video: Adding closed captioning to the video player (not draggable)","user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-23T14:22:55Z","updated_at":"2015-11-23T17:40:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/10706","html_url":"https://github.com/edx/edx-platform/pull/10706","diff_url":"https://github.com/edx/edx-platform/pull/10706.diff","patch_url":"https://github.com/edx/edx-platform/pull/10706.patch"},"body":"This pull request is the second of two parts and adds closed-captioning to our video player. It is part of [AC-188](https://openedx.atlassian.net/browse/AC-188).\r\n\r\n## Notable changes\r\n\r\n* adds a \"CC\" button to the grouped button container with the transcript and language control\r\n* sets a cookie so the captioning option persists through video viewing across the platform\r\n* allows placement of the captions within the video container for personalization\r\n\r\n## Browsers\r\n\r\nThis has been tested in the following browsers:\r\n\r\n| Platform | Browser | Version | Passed |\r\n|----------|---------|---------|--------|\r\n| Mac  | Chrome | 45  | Yes  |\r\n|          | Safari | 8  | Yes |\r\n|          | Firefox | 40 | Yes |\r\n| Windows | Chrome  | 45 | Yes |\r\n|          | Firefox | 40 | Yes |\r\n|          | IE | 10 | Yes |\r\n|          | IE | 11 | Yes |\r\n\r\n## Sandbox\r\n\r\nhttps://clrux-ac-188.sandbox.edx.org/courses/course-v1:edX+AV101+2015_T3/courseware/C_01/lecture_01/\r\n\r\n## Reviewers\r\n\r\n- [x] Frances (FED and Sass)\r\n- [ ] Mark (Accessibility)\r\n- [ ] Christine (JS + Tests)\r\n- [ ] Carol (Documentation)\r\n- [ ] T&L review (JS + Tests)"},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/159007057","html_url":"https://github.com/edx/edx-platform/pull/10706#issuecomment-159007057","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/10706","id":159007057,"user":{"login":"clrux","id":2112024,"avatar_url":"https://avatars.githubusercontent.com/u/2112024?v=3","gravatar_id":"","url":"https://api.github.com/users/clrux","html_url":"https://github.com/clrux","followers_url":"https://api.github.com/users/clrux/followers","following_url":"https://api.github.com/users/clrux/following{/other_user}","gists_url":"https://api.github.com/users/clrux/gists{/gist_id}","starred_url":"https://api.github.com/users/clrux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clrux/subscriptions","organizations_url":"https://api.github.com/users/clrux/orgs","repos_url":"https://api.github.com/users/clrux/repos","events_url":"https://api.github.com/users/clrux/events{/privacy}","received_events_url":"https://api.github.com/users/clrux/received_events","type":"User","site_admin":false},"created_at":"2015-11-23T17:40:54Z","updated_at":"2015-11-23T17:40:54Z","body":"@cahrens I'm working on the Bok Choy test now; in the process of revamping some of the logic. Appreciate the effort thus far. Maybe we can regroup after the break if I don't figure it out before then."}}