{"action":"created","comment":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/comments/34811005","id":34811005,"diff_hunk":"@@ -644,17 +649,31 @@ void MainWindow::resetWindowTitle()\n bool MainWindow::mayChangeProject(bool stopPlayback)\n {\n \tif( stopPlayback )\n+\t{\n \t\tEngine::getSong()->stop();\n+\t}\n \n-\tif( !Engine::getSong()->isModified() )\n+\tif( !Engine::getSong()->isModified() && !isRecoverSession() )\n \t{\n \t\treturn( true );\n \t}\n \n-\tQMessageBox mb( tr( \"Project not saved\" ),\n-\t\t\t\ttr( \"The current project was modified since \"\n+\t// Separate message strings for modified and recovered files\n+\tQString messageTitleRecovered = tr( \"Recovered project not saved\" );\n+\tQString messageRecovered = tr( \"This project was recovered from the \"\n+\t\t\t\t\t\"previous session. It is currently \"\n+\t\t\t\t\t\"unsaved and will be lost if you don't \"\n+\t\t\t\t\t\"Save it. Do you want to save it now?\" );\n+\n+\tQString messageTitleUnsaved = tr( \"Project not saved\" );","path":"src/gui/MainWindow.cpp","position":58,"original_position":58,"commit_id":"a3d9ff648c3ab32c43fae151938d41ea56a52b49","original_commit_id":"a3d9ff648c3ab32c43fae151938d41ea56a52b49","user":{"login":"zonkmachine","id":6368949,"avatar_url":"https://avatars.githubusercontent.com/u/6368949?v=3","gravatar_id":"","url":"https://api.github.com/users/zonkmachine","html_url":"https://github.com/zonkmachine","followers_url":"https://api.github.com/users/zonkmachine/followers","following_url":"https://api.github.com/users/zonkmachine/following{/other_user}","gists_url":"https://api.github.com/users/zonkmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/zonkmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonkmachine/subscriptions","organizations_url":"https://api.github.com/users/zonkmachine/orgs","repos_url":"https://api.github.com/users/zonkmachine/repos","events_url":"https://api.github.com/users/zonkmachine/events{/privacy}","received_events_url":"https://api.github.com/users/zonkmachine/received_events","type":"User","site_admin":false},"body":"What happens with the already translated string below when I move it to a variable? I didn't change the text. Do I need to do anything to link it to the old string?","created_at":"2015-07-16T16:58:20Z","updated_at":"2015-07-16T16:58:20Z","html_url":"https://github.com/LMMS/lmms/pull/2176#discussion_r34811005","pull_request_url":"https://api.github.com/repos/LMMS/lmms/pulls/2176","_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments/34811005"},"html":{"href":"https://github.com/LMMS/lmms/pull/2176#discussion_r34811005"},"pull_request":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2176"}}},"pull_request":{"url":"https://api.github.com/repos/LMMS/lmms/pulls/2176","id":39638986,"html_url":"https://github.com/LMMS/lmms/pull/2176","diff_url":"https://github.com/LMMS/lmms/pull/2176.diff","patch_url":"https://github.com/LMMS/lmms/pull/2176.patch","issue_url":"https://api.github.com/repos/LMMS/lmms/issues/2176","number":2176,"state":"open","locked":false,"title":"Always ask upon closing when the file is recovered","user":{"login":"zonkmachine","id":6368949,"avatar_url":"https://avatars.githubusercontent.com/u/6368949?v=3","gravatar_id":"","url":"https://api.github.com/users/zonkmachine","html_url":"https://github.com/zonkmachine","followers_url":"https://api.github.com/users/zonkmachine/followers","following_url":"https://api.github.com/users/zonkmachine/following{/other_user}","gists_url":"https://api.github.com/users/zonkmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/zonkmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonkmachine/subscriptions","organizations_url":"https://api.github.com/users/zonkmachine/orgs","repos_url":"https://api.github.com/users/zonkmachine/repos","events_url":"https://api.github.com/users/zonkmachine/events{/privacy}","received_events_url":"https://api.github.com/users/zonkmachine/received_events","type":"User","site_admin":false},"body":"In answer to Issue #2174\r\nThis is a minimum of what probably is needed. I made mayChangeProject() to also check if we're dealing with a recovery file to force the \"Project not saved\" message box.\r\nI think probably we need another message for a recovered file though. I'll think some more.","created_at":"2015-07-09T23:24:25Z","updated_at":"2015-07-16T16:58:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9942571447c75adaa154d848d1bcd476e98daf88","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LMMS/lmms/pulls/2176/commits","review_comments_url":"https://api.github.com/repos/LMMS/lmms/pulls/2176/comments","review_comment_url":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LMMS/lmms/issues/2176/comments","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/a3d9ff648c3ab32c43fae151938d41ea56a52b49","head":{"label":"zonkmachine:recoverFileFix","ref":"recoverFileFix","sha":"a3d9ff648c3ab32c43fae151938d41ea56a52b49","user":{"login":"zonkmachine","id":6368949,"avatar_url":"https://avatars.githubusercontent.com/u/6368949?v=3","gravatar_id":"","url":"https://api.github.com/users/zonkmachine","html_url":"https://github.com/zonkmachine","followers_url":"https://api.github.com/users/zonkmachine/followers","following_url":"https://api.github.com/users/zonkmachine/following{/other_user}","gists_url":"https://api.github.com/users/zonkmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/zonkmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonkmachine/subscriptions","organizations_url":"https://api.github.com/users/zonkmachine/orgs","repos_url":"https://api.github.com/users/zonkmachine/repos","events_url":"https://api.github.com/users/zonkmachine/events{/privacy}","received_events_url":"https://api.github.com/users/zonkmachine/received_events","type":"User","site_admin":false},"repo":{"id":16267835,"name":"lmms","full_name":"zonkmachine/lmms","owner":{"login":"zonkmachine","id":6368949,"avatar_url":"https://avatars.githubusercontent.com/u/6368949?v=3","gravatar_id":"","url":"https://api.github.com/users/zonkmachine","html_url":"https://github.com/zonkmachine","followers_url":"https://api.github.com/users/zonkmachine/followers","following_url":"https://api.github.com/users/zonkmachine/following{/other_user}","gists_url":"https://api.github.com/users/zonkmachine/gists{/gist_id}","starred_url":"https://api.github.com/users/zonkmachine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonkmachine/subscriptions","organizations_url":"https://api.github.com/users/zonkmachine/orgs","repos_url":"https://api.github.com/users/zonkmachine/repos","events_url":"https://api.github.com/users/zonkmachine/events{/privacy}","received_events_url":"https://api.github.com/users/zonkmachine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zonkmachine/lmms","description":"cross-platform music production software","fork":true,"url":"https://api.github.com/repos/zonkmachine/lmms","forks_url":"https://api.github.com/repos/zonkmachine/lmms/forks","keys_url":"https://api.github.com/repos/zonkmachine/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zonkmachine/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zonkmachine/lmms/teams","hooks_url":"https://api.github.com/repos/zonkmachine/lmms/hooks","issue_events_url":"https://api.github.com/repos/zonkmachine/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/zonkmachine/lmms/events","assignees_url":"https://api.github.com/repos/zonkmachine/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/zonkmachine/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/zonkmachine/lmms/tags","blobs_url":"https://api.github.com/repos/zonkmachine/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zonkmachine/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zonkmachine/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/zonkmachine/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zonkmachine/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/zonkmachine/lmms/languages","stargazers_url":"https://api.github.com/repos/zonkmachine/lmms/stargazers","contributors_url":"https://api.github.com/repos/zonkmachine/lmms/contributors","subscribers_url":"https://api.github.com/repos/zonkmachine/lmms/subscribers","subscription_url":"https://api.github.com/repos/zonkmachine/lmms/subscription","commits_url":"https://api.github.com/repos/zonkmachine/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/zonkmachine/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/zonkmachine/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/zonkmachine/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/zonkmachine/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/zonkmachine/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zonkmachine/lmms/merges","archive_url":"https://api.github.com/repos/zonkmachine/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zonkmachine/lmms/downloads","issues_url":"https://api.github.com/repos/zonkmachine/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/zonkmachine/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/zonkmachine/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/zonkmachine/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zonkmachine/lmms/labels{/name}","releases_url":"https://api.github.com/repos/zonkmachine/lmms/releases{/id}","created_at":"2014-01-27T03:01:16Z","updated_at":"2015-06-12T02:33:11Z","pushed_at":"2015-07-14T22:59:21Z","git_url":"git://github.com/zonkmachine/lmms.git","ssh_url":"git@github.com:zonkmachine/lmms.git","clone_url":"https://github.com/zonkmachine/lmms.git","svn_url":"https://github.com/zonkmachine/lmms","homepage":"http://lmms.sourceforge.net/","size":56420,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"LMMS:master","ref":"master","sha":"d9dac72c7f6b43e5499bdda30871256218b7e0a1","user":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"repo":{"id":15778896,"name":"lmms","full_name":"LMMS/lmms","owner":{"login":"LMMS","id":6363159,"avatar_url":"https://avatars.githubusercontent.com/u/6363159?v=3","gravatar_id":"","url":"https://api.github.com/users/LMMS","html_url":"https://github.com/LMMS","followers_url":"https://api.github.com/users/LMMS/followers","following_url":"https://api.github.com/users/LMMS/following{/other_user}","gists_url":"https://api.github.com/users/LMMS/gists{/gist_id}","starred_url":"https://api.github.com/users/LMMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LMMS/subscriptions","organizations_url":"https://api.github.com/users/LMMS/orgs","repos_url":"https://api.github.com/users/LMMS/repos","events_url":"https://api.github.com/users/LMMS/events{/privacy}","received_events_url":"https://api.github.com/users/LMMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LMMS/lmms","description":"cross-platform music production software","fork":false,"url":"https://api.github.com/repos/LMMS/lmms","forks_url":"https://api.github.com/repos/LMMS/lmms/forks","keys_url":"https://api.github.com/repos/LMMS/lmms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LMMS/lmms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LMMS/lmms/teams","hooks_url":"https://api.github.com/repos/LMMS/lmms/hooks","issue_events_url":"https://api.github.com/repos/LMMS/lmms/issues/events{/number}","events_url":"https://api.github.com/repos/LMMS/lmms/events","assignees_url":"https://api.github.com/repos/LMMS/lmms/assignees{/user}","branches_url":"https://api.github.com/repos/LMMS/lmms/branches{/branch}","tags_url":"https://api.github.com/repos/LMMS/lmms/tags","blobs_url":"https://api.github.com/repos/LMMS/lmms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LMMS/lmms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LMMS/lmms/git/refs{/sha}","trees_url":"https://api.github.com/repos/LMMS/lmms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LMMS/lmms/statuses/{sha}","languages_url":"https://api.github.com/repos/LMMS/lmms/languages","stargazers_url":"https://api.github.com/repos/LMMS/lmms/stargazers","contributors_url":"https://api.github.com/repos/LMMS/lmms/contributors","subscribers_url":"https://api.github.com/repos/LMMS/lmms/subscribers","subscription_url":"https://api.github.com/repos/LMMS/lmms/subscription","commits_url":"https://api.github.com/repos/LMMS/lmms/commits{/sha}","git_commits_url":"https://api.github.com/repos/LMMS/lmms/git/commits{/sha}","comments_url":"https://api.github.com/repos/LMMS/lmms/comments{/number}","issue_comment_url":"https://api.github.com/repos/LMMS/lmms/issues/comments{/number}","contents_url":"https://api.github.com/repos/LMMS/lmms/contents/{+path}","compare_url":"https://api.github.com/repos/LMMS/lmms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LMMS/lmms/merges","archive_url":"https://api.github.com/repos/LMMS/lmms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LMMS/lmms/downloads","issues_url":"https://api.github.com/repos/LMMS/lmms/issues{/number}","pulls_url":"https://api.github.com/repos/LMMS/lmms/pulls{/number}","milestones_url":"https://api.github.com/repos/LMMS/lmms/milestones{/number}","notifications_url":"https://api.github.com/repos/LMMS/lmms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LMMS/lmms/labels{/name}","releases_url":"https://api.github.com/repos/LMMS/lmms/releases{/id}","created_at":"2014-01-09T20:43:43Z","updated_at":"2015-07-16T14:58:57Z","pushed_at":"2015-07-16T11:58:59Z","git_url":"git://github.com/LMMS/lmms.git","ssh_url":"git@github.com:LMMS/lmms.git","clone_url":"https://github.com/LMMS/lmms.git","svn_url":"https://github.com/LMMS/lmms","homepage":"http://lmms.io/","size":82110,"stargazers_count":433,"watchers_count":433,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":134,"mirror_url":null,"open_issues_count":430,"forks":134,"open_issues":430,"watchers":433,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2176"},"html":{"href":"https://github.com/LMMS/lmms/pull/2176"},"issue":{"href":"https://api.github.com/repos/LMMS/lmms/issues/2176"},"comments":{"href":"https://api.github.com/repos/LMMS/lmms/issues/2176/comments"},"review_comments":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2176/comments"},"review_comment":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LMMS/lmms/pulls/2176/commits"},"statuses":{"href":"https://api.github.com/repos/LMMS/lmms/statuses/a3d9ff648c3ab32c43fae151938d41ea56a52b49"}}}}