{"action":"created","comment":{"url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/comments/28196977","id":28196977,"diff_hunk":"@@ -11,12 +11,22 @@ clean:\n \trm -fr diff\n \n distclean: clean\n-\trm -fr bin out\n+\trm -fr bin out tmp/.stamp_cargo_regex tmp/regex\n \n diff/chameneos_redux.diff: out/chameneos_redux.txt ref/chameneos_redux.txt\n \tmkdir -p diff\n \tsed -r 's/^[0-9]+/42/' $< | diff -u ref/chameneos_redux.txt - > $@\n \n+bin/regex_dna: src/regex_dna.rs tmp/.stamp_cargo_regex\n+\tmkdir -p bin\n+\t$(RUSTC) $(RUSTC_FLAGS) -L ./tmp/regex/target/release $< -o $@\n+\n+tmp/.stamp_cargo_regex:\n+\tmkdir -p tmp\n+\tgit clone git://github.com/rust-lang/regex tmp/regex","path":"Makefile","position":17,"original_position":17,"commit_id":"c609f95b53523558e696b16561f1a4de05130dca","original_commit_id":"c609f95b53523558e696b16561f1a4de05130dca","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"body":"maybe we should checkout a given tag or download the last version on crates.io? I don't really know, what do you think?","created_at":"2015-04-11T17:49:54Z","updated_at":"2015-04-11T17:49:54Z","html_url":"https://github.com/TeXitoi/benchmarksgame-rs/pull/1#discussion_r28196977","pull_request_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/comments/28196977"},"html":{"href":"https://github.com/TeXitoi/benchmarksgame-rs/pull/1#discussion_r28196977"},"pull_request":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1","id":33106877,"html_url":"https://github.com/TeXitoi/benchmarksgame-rs/pull/1","diff_url":"https://github.com/TeXitoi/benchmarksgame-rs/pull/1.diff","patch_url":"https://github.com/TeXitoi/benchmarksgame-rs/pull/1.patch","issue_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues/1","number":1,"state":"open","locked":false,"title":"fix regex benchmark","user":{"login":"BurntSushi","id":456674,"avatar_url":"https://avatars.githubusercontent.com/u/456674?v=3","gravatar_id":"","url":"https://api.github.com/users/BurntSushi","html_url":"https://github.com/BurntSushi","followers_url":"https://api.github.com/users/BurntSushi/followers","following_url":"https://api.github.com/users/BurntSushi/following{/other_user}","gists_url":"https://api.github.com/users/BurntSushi/gists{/gist_id}","starred_url":"https://api.github.com/users/BurntSushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurntSushi/subscriptions","organizations_url":"https://api.github.com/users/BurntSushi/orgs","repos_url":"https://api.github.com/users/BurntSushi/repos","events_url":"https://api.github.com/users/BurntSushi/events{/privacy}","received_events_url":"https://api.github.com/users/BurntSushi/received_events","type":"User","site_admin":false},"body":"This also notes 4 other benchmarks as broken so that `make` can run (on beta).\r\n\r\nSome of the benchmarks look tricky to update, e.g., `binary_trees` because of its use on `TypedArena`.\r\n\r\nOther benchmarks look easier to update, but they rely on `simd`. @huonw's simd crates might help: http://huonw.github.io/simd/simd/ and http://huonw.github.io/simdty/simdty/ --- I guess you could use a similar technique for `regex`.","created_at":"2015-04-11T17:35:38Z","updated_at":"2015-04-11T17:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0ea1646e5afd072b6d2b464632d897b26a160d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1/commits","review_comments_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1/comments","review_comment_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues/1/comments","statuses_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/statuses/c609f95b53523558e696b16561f1a4de05130dca","head":{"label":"BurntSushi:master","ref":"master","sha":"c609f95b53523558e696b16561f1a4de05130dca","user":{"login":"BurntSushi","id":456674,"avatar_url":"https://avatars.githubusercontent.com/u/456674?v=3","gravatar_id":"","url":"https://api.github.com/users/BurntSushi","html_url":"https://github.com/BurntSushi","followers_url":"https://api.github.com/users/BurntSushi/followers","following_url":"https://api.github.com/users/BurntSushi/following{/other_user}","gists_url":"https://api.github.com/users/BurntSushi/gists{/gist_id}","starred_url":"https://api.github.com/users/BurntSushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurntSushi/subscriptions","organizations_url":"https://api.github.com/users/BurntSushi/orgs","repos_url":"https://api.github.com/users/BurntSushi/repos","events_url":"https://api.github.com/users/BurntSushi/events{/privacy}","received_events_url":"https://api.github.com/users/BurntSushi/received_events","type":"User","site_admin":false},"repo":{"id":33782302,"name":"benchmarksgame-rs","full_name":"BurntSushi/benchmarksgame-rs","owner":{"login":"BurntSushi","id":456674,"avatar_url":"https://avatars.githubusercontent.com/u/456674?v=3","gravatar_id":"","url":"https://api.github.com/users/BurntSushi","html_url":"https://github.com/BurntSushi","followers_url":"https://api.github.com/users/BurntSushi/followers","following_url":"https://api.github.com/users/BurntSushi/following{/other_user}","gists_url":"https://api.github.com/users/BurntSushi/gists{/gist_id}","starred_url":"https://api.github.com/users/BurntSushi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurntSushi/subscriptions","organizations_url":"https://api.github.com/users/BurntSushi/orgs","repos_url":"https://api.github.com/users/BurntSushi/repos","events_url":"https://api.github.com/users/BurntSushi/events{/privacy}","received_events_url":"https://api.github.com/users/BurntSushi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BurntSushi/benchmarksgame-rs","description":"The Computer Language Benchmarks Game: Rust implementations","fork":true,"url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs","forks_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/forks","keys_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/teams","hooks_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/hooks","issue_events_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/issues/events{/number}","events_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/events","assignees_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/assignees{/user}","branches_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/branches{/branch}","tags_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/tags","blobs_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/languages","stargazers_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/stargazers","contributors_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/contributors","subscribers_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/subscribers","subscription_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/subscription","commits_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/contents/{+path}","compare_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/merges","archive_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/downloads","issues_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/issues{/number}","pulls_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/labels{/name}","releases_url":"https://api.github.com/repos/BurntSushi/benchmarksgame-rs/releases{/id}","created_at":"2015-04-11T16:06:02Z","updated_at":"2015-04-11T17:32:45Z","pushed_at":"2015-04-11T17:32:45Z","git_url":"git://github.com/BurntSushi/benchmarksgame-rs.git","ssh_url":"git@github.com:BurntSushi/benchmarksgame-rs.git","clone_url":"https://github.com/BurntSushi/benchmarksgame-rs.git","svn_url":"https://github.com/BurntSushi/benchmarksgame-rs","homepage":"","size":488,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TeXitoi:master","ref":"master","sha":"42388473c3112ef9644f55c2ce98a77220c25ab1","user":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"repo":{"id":29063047,"name":"benchmarksgame-rs","full_name":"TeXitoi/benchmarksgame-rs","owner":{"login":"TeXitoi","id":5787066,"avatar_url":"https://avatars.githubusercontent.com/u/5787066?v=3","gravatar_id":"","url":"https://api.github.com/users/TeXitoi","html_url":"https://github.com/TeXitoi","followers_url":"https://api.github.com/users/TeXitoi/followers","following_url":"https://api.github.com/users/TeXitoi/following{/other_user}","gists_url":"https://api.github.com/users/TeXitoi/gists{/gist_id}","starred_url":"https://api.github.com/users/TeXitoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TeXitoi/subscriptions","organizations_url":"https://api.github.com/users/TeXitoi/orgs","repos_url":"https://api.github.com/users/TeXitoi/repos","events_url":"https://api.github.com/users/TeXitoi/events{/privacy}","received_events_url":"https://api.github.com/users/TeXitoi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TeXitoi/benchmarksgame-rs","description":"The Computer Language Benchmarks Game: Rust implementations","fork":false,"url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs","forks_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/forks","keys_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/teams","hooks_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/hooks","issue_events_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues/events{/number}","events_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/events","assignees_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/assignees{/user}","branches_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/branches{/branch}","tags_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/tags","blobs_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/languages","stargazers_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/stargazers","contributors_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/contributors","subscribers_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/subscribers","subscription_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/subscription","commits_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/contents/{+path}","compare_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/merges","archive_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/downloads","issues_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues{/number}","pulls_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/labels{/name}","releases_url":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/releases{/id}","created_at":"2015-01-10T16:27:19Z","updated_at":"2015-04-10T09:16:53Z","pushed_at":"2015-04-11T17:35:38Z","git_url":"git://github.com/TeXitoi/benchmarksgame-rs.git","ssh_url":"git@github.com:TeXitoi/benchmarksgame-rs.git","clone_url":"https://github.com/TeXitoi/benchmarksgame-rs.git","svn_url":"https://github.com/TeXitoi/benchmarksgame-rs","homepage":"","size":488,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1"},"html":{"href":"https://github.com/TeXitoi/benchmarksgame-rs/pull/1"},"issue":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues/1"},"comments":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/TeXitoi/benchmarksgame-rs/statuses/c609f95b53523558e696b16561f1a4de05130dca"}}}}