{"comment":{"url":"https://api.github.com/repos/shrijeet/thrift-tools/comments/13219253","html_url":"https://github.com/shrijeet/thrift-tools/commit/0ae26d4aff71e92e5eac62144d6aa0e13aa58658#commitcomment-13219253","id":13219253,"user":{"login":"rgs1","id":1349891,"avatar_url":"https://avatars.githubusercontent.com/u/1349891?v=3","gravatar_id":"","url":"https://api.github.com/users/rgs1","html_url":"https://github.com/rgs1","followers_url":"https://api.github.com/users/rgs1/followers","following_url":"https://api.github.com/users/rgs1/following{/other_user}","gists_url":"https://api.github.com/users/rgs1/gists{/gist_id}","starred_url":"https://api.github.com/users/rgs1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgs1/subscriptions","organizations_url":"https://api.github.com/users/rgs1/orgs","repos_url":"https://api.github.com/users/rgs1/repos","events_url":"https://api.github.com/users/rgs1/events{/privacy}","received_events_url":"https://api.github.com/users/rgs1/received_events","type":"User","site_admin":false},"position":76,"line":224,"path":"thrift_tools/thrift_utils.py","commit_id":"0ae26d4aff71e92e5eac62144d6aa0e13aa58658","created_at":"2015-09-14T17:56:13Z","updated_at":"2015-09-14T17:56:13Z","body":"Not a huge deal, but it sounds like readFieldValue (and readFields) belong to ThriftStruct given they transform bytes -> ThriftStruct. \r\n\r\nSo ThriftMessage would become much simpler, with 3 simple tasks:\r\n\r\n* detect the encoding (i.e.: TBinary, TCompact, etc.)\r\n* unpack the message header\r\n* call ThriftStruct.read to deserialize the args \r\n"}}