{"action":"created","issue":{"url":"https://api.github.com/repos/srmagura/goodnight-lead/issues/32","labels_url":"https://api.github.com/repos/srmagura/goodnight-lead/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/srmagura/goodnight-lead/issues/32/comments","events_url":"https://api.github.com/repos/srmagura/goodnight-lead/issues/32/events","html_url":"https://github.com/srmagura/goodnight-lead/issues/32","id":93708191,"number":32,"title":"Divide base.css into smaller files","user":{"login":"srmagura","id":801549,"avatar_url":"https://avatars.githubusercontent.com/u/801549?v=3","gravatar_id":"","url":"https://api.github.com/users/srmagura","html_url":"https://github.com/srmagura","followers_url":"https://api.github.com/users/srmagura/followers","following_url":"https://api.github.com/users/srmagura/following{/other_user}","gists_url":"https://api.github.com/users/srmagura/gists{/gist_id}","starred_url":"https://api.github.com/users/srmagura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srmagura/subscriptions","organizations_url":"https://api.github.com/users/srmagura/orgs","repos_url":"https://api.github.com/users/srmagura/repos","events_url":"https://api.github.com/users/srmagura/events{/privacy}","received_events_url":"https://api.github.com/users/srmagura/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-08T06:30:03Z","updated_at":"2015-07-09T12:56:56Z","closed_at":null,"body":"I think base.css should just be styles that apply site-wide. There are styles in base.css that are only relevant for certain pages, e.g. styles for `.inventory-table` only affect dashboard, styles for `.take-inventory` are only for take-inventory pages, .etc"},"comment":{"url":"https://api.github.com/repos/srmagura/goodnight-lead/issues/comments/119953142","html_url":"https://github.com/srmagura/goodnight-lead/issues/32#issuecomment-119953142","issue_url":"https://api.github.com/repos/srmagura/goodnight-lead/issues/32","id":119953142,"user":{"login":"EricHorton","id":7595920,"avatar_url":"https://avatars.githubusercontent.com/u/7595920?v=3","gravatar_id":"","url":"https://api.github.com/users/EricHorton","html_url":"https://github.com/EricHorton","followers_url":"https://api.github.com/users/EricHorton/followers","following_url":"https://api.github.com/users/EricHorton/following{/other_user}","gists_url":"https://api.github.com/users/EricHorton/gists{/gist_id}","starred_url":"https://api.github.com/users/EricHorton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EricHorton/subscriptions","organizations_url":"https://api.github.com/users/EricHorton/orgs","repos_url":"https://api.github.com/users/EricHorton/repos","events_url":"https://api.github.com/users/EricHorton/events{/privacy}","received_events_url":"https://api.github.com/users/EricHorton/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T12:56:55Z","updated_at":"2015-07-09T12:56:55Z","body":"We could probably go with a sitewide base and smaller files for specific sunsets if needed. \n\nEither way, refactoring will probably take time, regardless of whether or not we stick with standard CSS or use SASS. As this isn't really a customer facing feature, shall we put it on hold until after we have completed site enhancements for the summer? \n\nEric Horton\n\n> On Jul 9, 2015, at 08:47, Sam Magura <notifications@github.com> wrote:\n> \n> I 90% agree that \"The whole point of CSS is to have a single stylesheet\n> that applies to multiple pages.\", though that doesn't mean I want every\n> style rule I write to applied site-wide.\n> \n> A solution would be to have one large base stylesheet that represents\n> styles to be applied site-wide. But when I, or someone else, wants to write\n> styles that should only be applied to a small subset of our pages, we just\n> create a new stylesheet separate from \"base\" and include it in the specific\n> pages. I think this approach captures that good points of both of our\n> designs.\n> \n> I am open to using stricter naming conventions, though learning the new\n> conventions and refactoring the code would take some time.\n> \n> I have never used SASS, but I would be interested in using it. Keep in mind\n> that learning SASS and refactoring the code would take time --- probably\n> more time than we would save by using SASS (in the short term).\n> \n> 2015-07-09 6:12 GMT-04:00 EricHorton <notifications@github.com>:\n> \n> > We can avoid that by following good naming conventions. BEM seems to be\n> > the most popular (\n> > http://csswizardry.com/2013/01/mindbemding-getting-your-head-round-bem-syntax/)\n> > The whole point of CSS is to have a single stylesheet that applies to\n> > multiple pages. Minifying css into a single file to serve up in production\n> > is a pretty common practice because it makes things easier to manage.\n> >\n> > Have you ever used SASS (http://sass-lang.com/guide)? It offers some\n> > features that make css easier.\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <https://github.com/srmagura/goodnight-lead/issues/32#issuecomment-119898741>\n> > .\n> >\n> —\n> Reply to this email directly or view it on GitHub.\n> \n"}}