{"action":"closed","issue":{"url":"https://api.github.com/repos/ebekker/letsencrypt-win/issues/27","labels_url":"https://api.github.com/repos/ebekker/letsencrypt-win/issues/27/labels{/name}","comments_url":"https://api.github.com/repos/ebekker/letsencrypt-win/issues/27/comments","events_url":"https://api.github.com/repos/ebekker/letsencrypt-win/issues/27/events","html_url":"https://github.com/ebekker/letsencrypt-win/issues/27","id":116965930,"number":27,"title":"Bug: GenerateCsr","user":{"login":"matbech","id":6642109,"avatar_url":"https://avatars.githubusercontent.com/u/6642109?v=3","gravatar_id":"","url":"https://api.github.com/users/matbech","html_url":"https://github.com/matbech","followers_url":"https://api.github.com/users/matbech/followers","following_url":"https://api.github.com/users/matbech/following{/other_user}","gists_url":"https://api.github.com/users/matbech/gists{/gist_id}","starred_url":"https://api.github.com/users/matbech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matbech/subscriptions","organizations_url":"https://api.github.com/users/matbech/orgs","repos_url":"https://api.github.com/users/matbech/repos","events_url":"https://api.github.com/users/matbech/events{/privacy}","received_events_url":"https://api.github.com/users/matbech/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-15T01:35:27Z","updated_at":"2015-11-15T12:22:09Z","closed_at":"2015-11-15T12:22:09Z","body":"The GenerateCsr function looks completely wrong:\r\nhttps://github.com/ebekker/letsencrypt-win/blob/master/letsencrypt-win/LetsEncrypt.ACME/PKI/CsrHelper.cs#L73\r\n\r\nFor example:\r\n            if (!string.IsNullOrEmpty(csrDetails.Country            /**/)) xn.Common = csrDetails.Country;          // C;\r\n\r\nshould be:\r\n            if (!string.IsNullOrEmpty(csrDetails.Country            /**/)) xn.Country = csrDetails.Country;          // C;\r\n\r\netc"}}