{"action":"created","issue":{"url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/issues/34","labels_url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/issues/34/comments","events_url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/issues/34/events","html_url":"https://github.com/karma-runner/karma-ie-launcher/pull/34","id":81430990,"number":34,"title":"chore: disable `-extoff` flag to be set by default","user":{"login":"v12","id":1483691,"avatar_url":"https://avatars.githubusercontent.com/u/1483691?v=3","gravatar_id":"","url":"https://api.github.com/users/v12","html_url":"https://github.com/v12","followers_url":"https://api.github.com/users/v12/followers","following_url":"https://api.github.com/users/v12/following{/other_user}","gists_url":"https://api.github.com/users/v12/gists{/gist_id}","starred_url":"https://api.github.com/users/v12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v12/subscriptions","organizations_url":"https://api.github.com/users/v12/orgs","repos_url":"https://api.github.com/users/v12/repos","events_url":"https://api.github.com/users/v12/events{/privacy}","received_events_url":"https://api.github.com/users/v12/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-27T12:37:57Z","updated_at":"2015-05-27T13:31:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/pulls/34","html_url":"https://github.com/karma-runner/karma-ie-launcher/pull/34","diff_url":"https://github.com/karma-runner/karma-ie-launcher/pull/34.diff","patch_url":"https://github.com/karma-runner/karma-ie-launcher/pull/34.patch"},"body":"Resolves #27\r\n\r\nIn many cases IE add-ons are essential for proper application functioning (i.e., parsing XML via [MSXML](https://msdn.microsoft.com/en-us/library/ms763742%28v=vs.85%29.aspx)), so explicitly setting `-extoff` flag makes impossible to run test suites for such apps.\r\n\r\nIf someone requires all add-ons to be switched off by the nature of the case (which is less likely but possible), it can be easily achieved by specifying that flag in `customLaunchers` section of Karma config though:\r\n```javascript\r\nconfig.set({\r\n  browsers: ['IE_no_addons'],\r\n  // ...\r\n  customLaunchers: {\r\n    IE_no_addons: {\r\n      base:  'IE',\r\n      flags: ['-extoff']\r\n    }\r\n  }\r\n});\r\n```\r\n\r\nFeel free to comment :wink: "},"comment":{"url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/issues/comments/105909035","html_url":"https://github.com/karma-runner/karma-ie-launcher/pull/34#issuecomment-105909035","issue_url":"https://api.github.com/repos/karma-runner/karma-ie-launcher/issues/34","id":105909035,"user":{"login":"v12","id":1483691,"avatar_url":"https://avatars.githubusercontent.com/u/1483691?v=3","gravatar_id":"","url":"https://api.github.com/users/v12","html_url":"https://github.com/v12","followers_url":"https://api.github.com/users/v12/followers","following_url":"https://api.github.com/users/v12/following{/other_user}","gists_url":"https://api.github.com/users/v12/gists{/gist_id}","starred_url":"https://api.github.com/users/v12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/v12/subscriptions","organizations_url":"https://api.github.com/users/v12/orgs","repos_url":"https://api.github.com/users/v12/repos","events_url":"https://api.github.com/users/v12/events{/privacy}","received_events_url":"https://api.github.com/users/v12/received_events","type":"User","site_admin":false},"created_at":"2015-05-27T13:31:45Z","updated_at":"2015-05-27T13:31:45Z","body":"I've just added a section to the README that explains what was changed and how to deal with it.\r\n\r\nNot sure about version number though. On the one hand, it is backward compatible change to the API because it won't break anything by running IE with add-ons enabled (they shouldn't have been used if everything worked), but, on the other hand, it can be considered as bug fix. According to semver these require different version increment - minor for the first case and patch for the second. I made an assumption that it requires minor to be bumped. Correct me if I'm wrong :innocent: "}}