{"push_id":917223599,"size":8,"distinct_size":5,"ref":"refs/heads/fix-win-flaky-test-cluster-net-send","head":"0fb7ef2f285321fcb353c2541ce376ec9a7f2900","before":"c3ea84988d538d76356e2643b098e1eba99c80f5","commits":[{"sha":"d09c447ef9a33913d78269329d8a99ea2dffd4c7","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: mark test-debug-no-context is flaky\n\ntest-debug-no-context is flaky on Windows. Mark as such.\n\nRef: https://github.com/nodejs/node/issues/4343\nPR-URL: https://github.com/nodejs/node/pull/4421\nReviewed-By: Brian White <mscdex@mscdex.net>","distinct":false,"url":"https://api.github.com/repos/mscdex/io.js/commits/d09c447ef9a33913d78269329d8a99ea2dffd4c7"},{"sha":"3e648eb2caa48a59be629091da4a2e8537d8d909","author":{"email":"2d64a127ffc94dbe6295928a16bedf8b26814159@gmail.com","name":"James M Snell"},"message":"doc: improve assert.markdown copy\n\nGeneral improvements to assert.markdown copy including\nnew and improved examples\n\nPR-URL: https://github.com/nodejs/node/pull/4360\nReviewed-By: Trevor Norris <trev.norris@gmail.com>","distinct":false,"url":"https://api.github.com/repos/mscdex/io.js/commits/3e648eb2caa48a59be629091da4a2e8537d8d909"},{"sha":"5d6f558ea669507f880e0e50e12e8be50d115d56","author":{"email":"2d64a127ffc94dbe6295928a16bedf8b26814159@gmail.com","name":"James M Snell"},"message":"doc: catch the WORKING_GROUPS.md bootstrap docs up to date\n\n* Link to the separate CODE_OF_CONDUCT.md file in nodejs/node\n* Link to the ModerationPolicy.md file in nodejs/TSC\n\nPR-URL: https://github.com/nodejs/node/pull/4367\nReviewed-By: Trevor Norris <trev.norris@gmail.com>","distinct":false,"url":"https://api.github.com/repos/mscdex/io.js/commits/5d6f558ea669507f880e0e50e12e8be50d115d56"},{"sha":"abe8a344a5c00d25dd8a7b4a77085a2c29a5c0c6","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: remove unused variables form http tests\n\nThe http tests seem especially prone to including unused variables.\nThis change removes them.\n\nPR-URL: https://github.com/nodejs/node/pull/4422\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>","distinct":true,"url":"https://api.github.com/repos/mscdex/io.js/commits/abe8a344a5c00d25dd8a7b4a77085a2c29a5c0c6"},{"sha":"3d2356762296ee6bf8fc98a7d8e4d07cbac278d1","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: remove unused variables from TLS tests\n\nSome of the TLS tests have variables that do not get used. This removes\nthose variables.\n\nPR-URL: https://github.com/nodejs/node/pull/4424\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>","distinct":true,"url":"https://api.github.com/repos/mscdex/io.js/commits/3d2356762296ee6bf8fc98a7d8e4d07cbac278d1"},{"sha":"fd395ba5c9924168880d212bb7b9bd02ceee45f5","author":{"email":"28a7b6144c43947e3f532c033ff42c8a2ae08045@gmail.com","name":"Rich Trott"},"message":"test: remove unused variables from HTTPS tests\n\nPR-URL: https://github.com/nodejs/node/pull/4426\nReviewed-By: Johan Bergström <bugs@bergstroem.nu>","distinct":true,"url":"https://api.github.com/repos/mscdex/io.js/commits/fd395ba5c9924168880d212bb7b9bd02ceee45f5"},{"sha":"30c0062dd2c0d74d7a17d9eaa1e8cfffd5f72a3f","author":{"email":"d8bbf19083844493ef08581d1c38fbc50ba5d18b@mscdex.net","name":"Brian White"},"message":"test: fix flaky child-process-fork-regr-gh-2847\n\nWindows would die with ECONNRESET most times when running\nthis particular test. This commit makes handling these errors\nmore tolerable.\n\nPR-URL: https://github.com/nodejs/node/pull/4442\nReviewed-By: Fedor Indutny <fedor.indutny@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":true,"url":"https://api.github.com/repos/mscdex/io.js/commits/30c0062dd2c0d74d7a17d9eaa1e8cfffd5f72a3f"},{"sha":"0fb7ef2f285321fcb353c2541ce376ec9a7f2900","author":{"email":"d8bbf19083844493ef08581d1c38fbc50ba5d18b@mscdex.net","name":"Brian White"},"message":"test: fix flaky cluster-net-send\n\nBefore this commit, it was possible on Windows for the server's\n'connection' handler to be called *after* the client socket's\n'connect' handler. This caused the 'message' event to be missed\nand the test would never end (timing out in CI). This problem\nwas more easily reproducible on a low resource (slow CPU)\nWindows (2012r2) installation.\n\nThis commit waits until both handlers have been called before\nsending the handle to the master process.\n\nFixes: https://github.com/nodejs/node/issues/3957\nPR-URL: https://github.com/nodejs/node/pull/4444","distinct":true,"url":"https://api.github.com/repos/mscdex/io.js/commits/0fb7ef2f285321fcb353c2541ce376ec9a7f2900"}]}