{"action":"created","comment":{"url":"https://api.github.com/repos/Kdyby/Validator/pulls/comments/45587284","id":45587284,"diff_hunk":"@@ -82,6 +84,17 @@ public function loadConfiguration()\n \t\t\t->setClass('Symfony\\Component\\Validator\\Validator\\ValidatorInterface')\n \t\t\t->setFactory('Symfony\\Component\\Validator\\Validator\\RecursiveValidator');\n \n+\t\tValidators::assertField($config, 'strictEmail', 'boolean');\n+\n+\t\t$builder->addDefinition($this->prefix('constraint.email'))\n+\t\t\t->setClass('Symfony\\Component\\Validator\\Constraints\\EmailValidator')\n+\t\t\t->setArguments(array(","path":"src/Kdyby/Validator/DI/ValidatorExtension.php","position":24,"original_position":24,"commit_id":"4eb0205e02e6ac0ce68fd7b3d42bb3270a47c757","original_commit_id":"ba11293cff6e7cb4a720168942fc895b8384e685","user":{"login":"fprochazka","id":158625,"avatar_url":"https://avatars.githubusercontent.com/u/158625?v=3","gravatar_id":"","url":"https://api.github.com/users/fprochazka","html_url":"https://github.com/fprochazka","followers_url":"https://api.github.com/users/fprochazka/followers","following_url":"https://api.github.com/users/fprochazka/following{/other_user}","gists_url":"https://api.github.com/users/fprochazka/gists{/gist_id}","starred_url":"https://api.github.com/users/fprochazka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fprochazka/subscriptions","organizations_url":"https://api.github.com/users/fprochazka/orgs","repos_url":"https://api.github.com/users/fprochazka/repos","events_url":"https://api.github.com/users/fprochazka/events{/privacy}","received_events_url":"https://api.github.com/users/fprochazka/received_events","type":"User","site_admin":false},"body":"You're right :)","created_at":"2015-11-23T10:15:49Z","updated_at":"2015-11-23T10:15:49Z","html_url":"https://github.com/Kdyby/Validator/pull/22#discussion_r45587284","pull_request_url":"https://api.github.com/repos/Kdyby/Validator/pulls/22","_links":{"self":{"href":"https://api.github.com/repos/Kdyby/Validator/pulls/comments/45587284"},"html":{"href":"https://github.com/Kdyby/Validator/pull/22#discussion_r45587284"},"pull_request":{"href":"https://api.github.com/repos/Kdyby/Validator/pulls/22"}}},"pull_request":{"url":"https://api.github.com/repos/Kdyby/Validator/pulls/22","id":49540030,"html_url":"https://github.com/Kdyby/Validator/pull/22","diff_url":"https://github.com/Kdyby/Validator/pull/22.diff","patch_url":"https://github.com/Kdyby/Validator/pull/22.patch","issue_url":"https://api.github.com/repos/Kdyby/Validator/issues/22","number":22,"state":"open","locked":false,"title":"Add support for strict e-mail","user":{"login":"enumag","id":539462,"avatar_url":"https://avatars.githubusercontent.com/u/539462?v=3","gravatar_id":"","url":"https://api.github.com/users/enumag","html_url":"https://github.com/enumag","followers_url":"https://api.github.com/users/enumag/followers","following_url":"https://api.github.com/users/enumag/following{/other_user}","gists_url":"https://api.github.com/users/enumag/gists{/gist_id}","starred_url":"https://api.github.com/users/enumag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enumag/subscriptions","organizations_url":"https://api.github.com/users/enumag/orgs","repos_url":"https://api.github.com/users/enumag/repos","events_url":"https://api.github.com/users/enumag/events{/privacy}","received_events_url":"https://api.github.com/users/enumag/received_events","type":"User","site_admin":false},"body":"Don't merge yet. I need to test it first.\r\n\r\nI'd like to write a test for this but I'm not sure how because [EmailValidator](https://github.com/symfony/validator/blob/master/Constraints/EmailValidator.php) doesn't have any isStrict method. Is it ok to use reflection to check the private property directly?","created_at":"2015-11-03T10:40:09Z","updated_at":"2015-11-23T10:15:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d27a5a27624330aabf3a02ab70cc87fc1efc0179","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Kdyby/Validator/pulls/22/commits","review_comments_url":"https://api.github.com/repos/Kdyby/Validator/pulls/22/comments","review_comment_url":"https://api.github.com/repos/Kdyby/Validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Kdyby/Validator/issues/22/comments","statuses_url":"https://api.github.com/repos/Kdyby/Validator/statuses/4eb0205e02e6ac0ce68fd7b3d42bb3270a47c757","head":{"label":"Kdyby:strict-email","ref":"strict-email","sha":"4eb0205e02e6ac0ce68fd7b3d42bb3270a47c757","user":{"login":"Kdyby","id":615853,"avatar_url":"https://avatars.githubusercontent.com/u/615853?v=3","gravatar_id":"","url":"https://api.github.com/users/Kdyby","html_url":"https://github.com/Kdyby","followers_url":"https://api.github.com/users/Kdyby/followers","following_url":"https://api.github.com/users/Kdyby/following{/other_user}","gists_url":"https://api.github.com/users/Kdyby/gists{/gist_id}","starred_url":"https://api.github.com/users/Kdyby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kdyby/subscriptions","organizations_url":"https://api.github.com/users/Kdyby/orgs","repos_url":"https://api.github.com/users/Kdyby/repos","events_url":"https://api.github.com/users/Kdyby/events{/privacy}","received_events_url":"https://api.github.com/users/Kdyby/received_events","type":"Organization","site_admin":false},"repo":{"id":11822607,"name":"Validator","full_name":"Kdyby/Validator","owner":{"login":"Kdyby","id":615853,"avatar_url":"https://avatars.githubusercontent.com/u/615853?v=3","gravatar_id":"","url":"https://api.github.com/users/Kdyby","html_url":"https://github.com/Kdyby","followers_url":"https://api.github.com/users/Kdyby/followers","following_url":"https://api.github.com/users/Kdyby/following{/other_user}","gists_url":"https://api.github.com/users/Kdyby/gists{/gist_id}","starred_url":"https://api.github.com/users/Kdyby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kdyby/subscriptions","organizations_url":"https://api.github.com/users/Kdyby/orgs","repos_url":"https://api.github.com/users/Kdyby/repos","events_url":"https://api.github.com/users/Kdyby/events{/privacy}","received_events_url":"https://api.github.com/users/Kdyby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kdyby/Validator","description":"Integration of Symfony/Validator into Nette Framework","fork":false,"url":"https://api.github.com/repos/Kdyby/Validator","forks_url":"https://api.github.com/repos/Kdyby/Validator/forks","keys_url":"https://api.github.com/repos/Kdyby/Validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kdyby/Validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kdyby/Validator/teams","hooks_url":"https://api.github.com/repos/Kdyby/Validator/hooks","issue_events_url":"https://api.github.com/repos/Kdyby/Validator/issues/events{/number}","events_url":"https://api.github.com/repos/Kdyby/Validator/events","assignees_url":"https://api.github.com/repos/Kdyby/Validator/assignees{/user}","branches_url":"https://api.github.com/repos/Kdyby/Validator/branches{/branch}","tags_url":"https://api.github.com/repos/Kdyby/Validator/tags","blobs_url":"https://api.github.com/repos/Kdyby/Validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kdyby/Validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kdyby/Validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kdyby/Validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kdyby/Validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Kdyby/Validator/languages","stargazers_url":"https://api.github.com/repos/Kdyby/Validator/stargazers","contributors_url":"https://api.github.com/repos/Kdyby/Validator/contributors","subscribers_url":"https://api.github.com/repos/Kdyby/Validator/subscribers","subscription_url":"https://api.github.com/repos/Kdyby/Validator/subscription","commits_url":"https://api.github.com/repos/Kdyby/Validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kdyby/Validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kdyby/Validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kdyby/Validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kdyby/Validator/contents/{+path}","compare_url":"https://api.github.com/repos/Kdyby/Validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kdyby/Validator/merges","archive_url":"https://api.github.com/repos/Kdyby/Validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kdyby/Validator/downloads","issues_url":"https://api.github.com/repos/Kdyby/Validator/issues{/number}","pulls_url":"https://api.github.com/repos/Kdyby/Validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Kdyby/Validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Kdyby/Validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kdyby/Validator/labels{/name}","releases_url":"https://api.github.com/repos/Kdyby/Validator/releases{/id}","created_at":"2013-08-01T17:03:33Z","updated_at":"2015-05-29T05:36:11Z","pushed_at":"2015-11-23T08:59:52Z","git_url":"git://github.com/Kdyby/Validator.git","ssh_url":"git@github.com:Kdyby/Validator.git","clone_url":"https://github.com/Kdyby/Validator.git","svn_url":"https://github.com/Kdyby/Validator","homepage":"","size":65,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"base":{"label":"Kdyby:master","ref":"master","sha":"95fa998386f70084b437a32895a6edc47999cd9e","user":{"login":"Kdyby","id":615853,"avatar_url":"https://avatars.githubusercontent.com/u/615853?v=3","gravatar_id":"","url":"https://api.github.com/users/Kdyby","html_url":"https://github.com/Kdyby","followers_url":"https://api.github.com/users/Kdyby/followers","following_url":"https://api.github.com/users/Kdyby/following{/other_user}","gists_url":"https://api.github.com/users/Kdyby/gists{/gist_id}","starred_url":"https://api.github.com/users/Kdyby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kdyby/subscriptions","organizations_url":"https://api.github.com/users/Kdyby/orgs","repos_url":"https://api.github.com/users/Kdyby/repos","events_url":"https://api.github.com/users/Kdyby/events{/privacy}","received_events_url":"https://api.github.com/users/Kdyby/received_events","type":"Organization","site_admin":false},"repo":{"id":11822607,"name":"Validator","full_name":"Kdyby/Validator","owner":{"login":"Kdyby","id":615853,"avatar_url":"https://avatars.githubusercontent.com/u/615853?v=3","gravatar_id":"","url":"https://api.github.com/users/Kdyby","html_url":"https://github.com/Kdyby","followers_url":"https://api.github.com/users/Kdyby/followers","following_url":"https://api.github.com/users/Kdyby/following{/other_user}","gists_url":"https://api.github.com/users/Kdyby/gists{/gist_id}","starred_url":"https://api.github.com/users/Kdyby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kdyby/subscriptions","organizations_url":"https://api.github.com/users/Kdyby/orgs","repos_url":"https://api.github.com/users/Kdyby/repos","events_url":"https://api.github.com/users/Kdyby/events{/privacy}","received_events_url":"https://api.github.com/users/Kdyby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Kdyby/Validator","description":"Integration of Symfony/Validator into Nette Framework","fork":false,"url":"https://api.github.com/repos/Kdyby/Validator","forks_url":"https://api.github.com/repos/Kdyby/Validator/forks","keys_url":"https://api.github.com/repos/Kdyby/Validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Kdyby/Validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Kdyby/Validator/teams","hooks_url":"https://api.github.com/repos/Kdyby/Validator/hooks","issue_events_url":"https://api.github.com/repos/Kdyby/Validator/issues/events{/number}","events_url":"https://api.github.com/repos/Kdyby/Validator/events","assignees_url":"https://api.github.com/repos/Kdyby/Validator/assignees{/user}","branches_url":"https://api.github.com/repos/Kdyby/Validator/branches{/branch}","tags_url":"https://api.github.com/repos/Kdyby/Validator/tags","blobs_url":"https://api.github.com/repos/Kdyby/Validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Kdyby/Validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Kdyby/Validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/Kdyby/Validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Kdyby/Validator/statuses/{sha}","languages_url":"https://api.github.com/repos/Kdyby/Validator/languages","stargazers_url":"https://api.github.com/repos/Kdyby/Validator/stargazers","contributors_url":"https://api.github.com/repos/Kdyby/Validator/contributors","subscribers_url":"https://api.github.com/repos/Kdyby/Validator/subscribers","subscription_url":"https://api.github.com/repos/Kdyby/Validator/subscription","commits_url":"https://api.github.com/repos/Kdyby/Validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/Kdyby/Validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/Kdyby/Validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/Kdyby/Validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/Kdyby/Validator/contents/{+path}","compare_url":"https://api.github.com/repos/Kdyby/Validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Kdyby/Validator/merges","archive_url":"https://api.github.com/repos/Kdyby/Validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Kdyby/Validator/downloads","issues_url":"https://api.github.com/repos/Kdyby/Validator/issues{/number}","pulls_url":"https://api.github.com/repos/Kdyby/Validator/pulls{/number}","milestones_url":"https://api.github.com/repos/Kdyby/Validator/milestones{/number}","notifications_url":"https://api.github.com/repos/Kdyby/Validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Kdyby/Validator/labels{/name}","releases_url":"https://api.github.com/repos/Kdyby/Validator/releases{/id}","created_at":"2013-08-01T17:03:33Z","updated_at":"2015-05-29T05:36:11Z","pushed_at":"2015-11-23T08:59:52Z","git_url":"git://github.com/Kdyby/Validator.git","ssh_url":"git@github.com:Kdyby/Validator.git","clone_url":"https://github.com/Kdyby/Validator.git","svn_url":"https://github.com/Kdyby/Validator","homepage":"","size":65,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Kdyby/Validator/pulls/22"},"html":{"href":"https://github.com/Kdyby/Validator/pull/22"},"issue":{"href":"https://api.github.com/repos/Kdyby/Validator/issues/22"},"comments":{"href":"https://api.github.com/repos/Kdyby/Validator/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/Kdyby/Validator/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/Kdyby/Validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Kdyby/Validator/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/Kdyby/Validator/statuses/4eb0205e02e6ac0ce68fd7b3d42bb3270a47c757"}}}}