{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6099","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6099/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6099/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6099/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6099","id":72784771,"number":6099,"title":"Introduce BitcoinTestFramework.get_node_args.","user":{"login":"domob1812","id":4943644,"avatar_url":"https://avatars.githubusercontent.com/u/4943644?v=3","gravatar_id":"","url":"https://api.github.com/users/domob1812","html_url":"https://github.com/domob1812","followers_url":"https://api.github.com/users/domob1812/followers","following_url":"https://api.github.com/users/domob1812/following{/other_user}","gists_url":"https://api.github.com/users/domob1812/gists{/gist_id}","starred_url":"https://api.github.com/users/domob1812/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domob1812/subscriptions","organizations_url":"https://api.github.com/users/domob1812/orgs","repos_url":"https://api.github.com/users/domob1812/repos","events_url":"https://api.github.com/users/domob1812/events{/privacy}","received_events_url":"https://api.github.com/users/domob1812/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/Tests","name":"Tests","color":"d4c5f9"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-03T10:22:03Z","updated_at":"2015-05-04T07:09:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6099","html_url":"https://github.com/bitcoin/bitcoin/pull/6099","diff_url":"https://github.com/bitcoin/bitcoin/pull/6099.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6099.patch"},"body":"Use a new function in BitcoinTestFramework (get_node_args) to specify which options each node should have.\r\n\r\nI guess this is a matter of taste, but in my opinion this makes the code cleaner (also for future changes to the options).  It would even allow to specify \"general\" options that are set differently for the four nodes (e. g., two could always have -txindex and two not, so that both behaviours can be tested)."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/98604332","html_url":"https://github.com/bitcoin/bitcoin/pull/6099#issuecomment-98604332","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6099","id":98604332,"user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"created_at":"2015-05-04T07:09:30Z","updated_at":"2015-05-04T07:09:30Z","body":"I like test cases to be nitty-gritty and explicit. This makes them easier to understand, or at least, makes it easier to understand what actually happens. Deeper abstractions make it harder to troubleshoot, or for 'outsiders' to change the tests when necessary for code changes.\r\n\r\nSo I also tend towards NACK here. Currently we specify the exact arguments that are fed into bitcoind in every test. This would bury it in more Python syntactic sugar.\r\n"}}