{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/711","labels_url":"https://api.github.com/repos/apache/kafka/issues/711/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/711/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/711/events","html_url":"https://github.com/apache/kafka/pull/711","id":123513992,"number":711,"title":"KAFKA-3029:Marking class org.apache.kafka.common.TopicPartition as serializable","user":{"login":"praveend","id":194470,"avatar_url":"https://avatars.githubusercontent.com/u/194470?v=3","gravatar_id":"","url":"https://api.github.com/users/praveend","html_url":"https://github.com/praveend","followers_url":"https://api.github.com/users/praveend/followers","following_url":"https://api.github.com/users/praveend/following{/other_user}","gists_url":"https://api.github.com/users/praveend/gists{/gist_id}","starred_url":"https://api.github.com/users/praveend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/praveend/subscriptions","organizations_url":"https://api.github.com/users/praveend/orgs","repos_url":"https://api.github.com/users/praveend/repos","events_url":"https://api.github.com/users/praveend/events{/privacy}","received_events_url":"https://api.github.com/users/praveend/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-12-22T16:34:03Z","updated_at":"2015-12-23T18:45:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/711","html_url":"https://github.com/apache/kafka/pull/711","diff_url":"https://github.com/apache/kafka/pull/711.diff","patch_url":"https://github.com/apache/kafka/pull/711.patch"},"body":"Patch for issue KAFKA-3029\r\n\r\nGiven that the fix is trivial no new test case is needed. I have run the test suite using gradle (as mentioned @ https://github.com/apache/kafka/blob/trunk/README.md) and suite runs clean."},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/166968353","html_url":"https://github.com/apache/kafka/pull/711#issuecomment-166968353","issue_url":"https://api.github.com/repos/apache/kafka/issues/711","id":166968353,"user":{"login":"ijuma","id":24747,"avatar_url":"https://avatars.githubusercontent.com/u/24747?v=3","gravatar_id":"","url":"https://api.github.com/users/ijuma","html_url":"https://github.com/ijuma","followers_url":"https://api.github.com/users/ijuma/followers","following_url":"https://api.github.com/users/ijuma/following{/other_user}","gists_url":"https://api.github.com/users/ijuma/gists{/gist_id}","starred_url":"https://api.github.com/users/ijuma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijuma/subscriptions","organizations_url":"https://api.github.com/users/ijuma/orgs","repos_url":"https://api.github.com/users/ijuma/repos","events_url":"https://api.github.com/users/ijuma/events{/privacy}","received_events_url":"https://api.github.com/users/ijuma/received_events","type":"User","site_admin":false},"created_at":"2015-12-23T18:45:31Z","updated_at":"2015-12-23T18:45:31Z","body":"@praveend Understood about clients needing a mechanism to serialize and deserialize such classes. Java Serialization is just one such mechanism, however, there are several others. Personally, I think Java Serialization is not a good mechanism for a number of reasons (compatibility, performance, security, etc.), but I understand that it's very convenient (in the short-term, at least, people often regret using it later). The fact that TopicAndPartition was Serializable was kind of accidental (one sadly gets that automatically when using case classes).\r\n\r\nIf we do decide to support Java Serialization in some of our classes, we should do that with a good understanding of what it means if we need to change them in the future. And we certainly should include test(s) as @ewencp is suggesting."}}