{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/bboreham/weave/pulls/18","id":35409550,"html_url":"https://github.com/bboreham/weave/pull/18","diff_url":"https://github.com/bboreham/weave/pull/18.diff","patch_url":"https://github.com/bboreham/weave/pull/18.patch","issue_url":"https://api.github.com/repos/bboreham/weave/issues/18","number":18,"state":"closed","locked":false,"title":"Review feedback","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"body":"- use gorilla mux for ipam http\r\n- make allocator.Allocate return an error\r\n- change the endpoint for shutdown to DELETE /peer instead of POST /tombstone-self","created_at":"2015-05-14T10:15:45Z","updated_at":"2015-05-14T10:54:18Z","closed_at":"2015-05-14T10:54:18Z","merged_at":"2015-05-14T10:54:18Z","merge_commit_sha":"4f2ec994b359c676cef7dc0f3dfbbf752285192e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bboreham/weave/pulls/18/commits","review_comments_url":"https://api.github.com/repos/bboreham/weave/pulls/18/comments","review_comment_url":"https://api.github.com/repos/bboreham/weave/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bboreham/weave/issues/18/comments","statuses_url":"https://api.github.com/repos/bboreham/weave/statuses/e550788b7f0aac5aed1086ceb19de2894a7a0a31","head":{"label":"tomwilkie:22_ipam","ref":"22_ipam","sha":"e550788b7f0aac5aed1086ceb19de2894a7a0a31","user":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"repo":{"id":32328358,"name":"weave","full_name":"tomwilkie/weave","owner":{"login":"tomwilkie","id":444037,"avatar_url":"https://avatars.githubusercontent.com/u/444037?v=3","gravatar_id":"","url":"https://api.github.com/users/tomwilkie","html_url":"https://github.com/tomwilkie","followers_url":"https://api.github.com/users/tomwilkie/followers","following_url":"https://api.github.com/users/tomwilkie/following{/other_user}","gists_url":"https://api.github.com/users/tomwilkie/gists{/gist_id}","starred_url":"https://api.github.com/users/tomwilkie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomwilkie/subscriptions","organizations_url":"https://api.github.com/users/tomwilkie/orgs","repos_url":"https://api.github.com/users/tomwilkie/repos","events_url":"https://api.github.com/users/tomwilkie/events{/privacy}","received_events_url":"https://api.github.com/users/tomwilkie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tomwilkie/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/tomwilkie/weave","forks_url":"https://api.github.com/repos/tomwilkie/weave/forks","keys_url":"https://api.github.com/repos/tomwilkie/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tomwilkie/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tomwilkie/weave/teams","hooks_url":"https://api.github.com/repos/tomwilkie/weave/hooks","issue_events_url":"https://api.github.com/repos/tomwilkie/weave/issues/events{/number}","events_url":"https://api.github.com/repos/tomwilkie/weave/events","assignees_url":"https://api.github.com/repos/tomwilkie/weave/assignees{/user}","branches_url":"https://api.github.com/repos/tomwilkie/weave/branches{/branch}","tags_url":"https://api.github.com/repos/tomwilkie/weave/tags","blobs_url":"https://api.github.com/repos/tomwilkie/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tomwilkie/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tomwilkie/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/tomwilkie/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tomwilkie/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/tomwilkie/weave/languages","stargazers_url":"https://api.github.com/repos/tomwilkie/weave/stargazers","contributors_url":"https://api.github.com/repos/tomwilkie/weave/contributors","subscribers_url":"https://api.github.com/repos/tomwilkie/weave/subscribers","subscription_url":"https://api.github.com/repos/tomwilkie/weave/subscription","commits_url":"https://api.github.com/repos/tomwilkie/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/tomwilkie/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/tomwilkie/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/tomwilkie/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/tomwilkie/weave/contents/{+path}","compare_url":"https://api.github.com/repos/tomwilkie/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tomwilkie/weave/merges","archive_url":"https://api.github.com/repos/tomwilkie/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tomwilkie/weave/downloads","issues_url":"https://api.github.com/repos/tomwilkie/weave/issues{/number}","pulls_url":"https://api.github.com/repos/tomwilkie/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/tomwilkie/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/tomwilkie/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tomwilkie/weave/labels{/name}","releases_url":"https://api.github.com/repos/tomwilkie/weave/releases{/id}","created_at":"2015-03-16T13:54:30Z","updated_at":"2015-04-30T11:16:24Z","pushed_at":"2015-05-14T10:14:49Z","git_url":"git://github.com/tomwilkie/weave.git","ssh_url":"git@github.com:tomwilkie/weave.git","clone_url":"https://github.com/tomwilkie/weave.git","svn_url":"https://github.com/tomwilkie/weave","homepage":"","size":3422,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bboreham:22_ipam","ref":"22_ipam","sha":"f837c269b2fd972648b250256a718517ddf43003","user":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"repo":{"id":23360369,"name":"weave","full_name":"bboreham/weave","owner":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bboreham/weave","description":"The Docker Network","fork":true,"url":"https://api.github.com/repos/bboreham/weave","forks_url":"https://api.github.com/repos/bboreham/weave/forks","keys_url":"https://api.github.com/repos/bboreham/weave/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bboreham/weave/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bboreham/weave/teams","hooks_url":"https://api.github.com/repos/bboreham/weave/hooks","issue_events_url":"https://api.github.com/repos/bboreham/weave/issues/events{/number}","events_url":"https://api.github.com/repos/bboreham/weave/events","assignees_url":"https://api.github.com/repos/bboreham/weave/assignees{/user}","branches_url":"https://api.github.com/repos/bboreham/weave/branches{/branch}","tags_url":"https://api.github.com/repos/bboreham/weave/tags","blobs_url":"https://api.github.com/repos/bboreham/weave/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bboreham/weave/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bboreham/weave/git/refs{/sha}","trees_url":"https://api.github.com/repos/bboreham/weave/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bboreham/weave/statuses/{sha}","languages_url":"https://api.github.com/repos/bboreham/weave/languages","stargazers_url":"https://api.github.com/repos/bboreham/weave/stargazers","contributors_url":"https://api.github.com/repos/bboreham/weave/contributors","subscribers_url":"https://api.github.com/repos/bboreham/weave/subscribers","subscription_url":"https://api.github.com/repos/bboreham/weave/subscription","commits_url":"https://api.github.com/repos/bboreham/weave/commits{/sha}","git_commits_url":"https://api.github.com/repos/bboreham/weave/git/commits{/sha}","comments_url":"https://api.github.com/repos/bboreham/weave/comments{/number}","issue_comment_url":"https://api.github.com/repos/bboreham/weave/issues/comments{/number}","contents_url":"https://api.github.com/repos/bboreham/weave/contents/{+path}","compare_url":"https://api.github.com/repos/bboreham/weave/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bboreham/weave/merges","archive_url":"https://api.github.com/repos/bboreham/weave/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bboreham/weave/downloads","issues_url":"https://api.github.com/repos/bboreham/weave/issues{/number}","pulls_url":"https://api.github.com/repos/bboreham/weave/pulls{/number}","milestones_url":"https://api.github.com/repos/bboreham/weave/milestones{/number}","notifications_url":"https://api.github.com/repos/bboreham/weave/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bboreham/weave/labels{/name}","releases_url":"https://api.github.com/repos/bboreham/weave/releases{/id}","created_at":"2014-08-26T17:24:12Z","updated_at":"2015-04-17T10:04:44Z","pushed_at":"2015-05-14T10:54:18Z","git_url":"git://github.com/bboreham/weave.git","ssh_url":"git@github.com:bboreham/weave.git","clone_url":"https://github.com/bboreham/weave.git","svn_url":"https://github.com/bboreham/weave","homepage":"","size":7312,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bboreham/weave/pulls/18"},"html":{"href":"https://github.com/bboreham/weave/pull/18"},"issue":{"href":"https://api.github.com/repos/bboreham/weave/issues/18"},"comments":{"href":"https://api.github.com/repos/bboreham/weave/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/bboreham/weave/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/bboreham/weave/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bboreham/weave/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/bboreham/weave/statuses/e550788b7f0aac5aed1086ceb19de2894a7a0a31"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bboreham","id":8125524,"avatar_url":"https://avatars.githubusercontent.com/u/8125524?v=3","gravatar_id":"","url":"https://api.github.com/users/bboreham","html_url":"https://github.com/bboreham","followers_url":"https://api.github.com/users/bboreham/followers","following_url":"https://api.github.com/users/bboreham/following{/other_user}","gists_url":"https://api.github.com/users/bboreham/gists{/gist_id}","starred_url":"https://api.github.com/users/bboreham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bboreham/subscriptions","organizations_url":"https://api.github.com/users/bboreham/orgs","repos_url":"https://api.github.com/users/bboreham/repos","events_url":"https://api.github.com/users/bboreham/events{/privacy}","received_events_url":"https://api.github.com/users/bboreham/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":89,"deletions":128,"changed_files":6}}