{"action":"created","comment":{"url":"https://api.github.com/repos/cantino/huginn/pulls/comments/44862540","id":44862540,"diff_hunk":"@@ -17,7 +17,7 @@ class CommanderAgent < Agent\n \n       * `enable`: Target Agents are enabled (if not) when this agent is triggered.\n \n-      * `configure`: Target Agents have their options updated with the contents of `configure_options`.\n+      * `configure`: Target Agents have their options updated with the contents of `configure_options`. Set `configure_options_nested_array_update_mode` to `merge`(default) or `replace` when configuring arrays that are nested within the `configure_options` hash.","path":"app/models/agents/commander_agent.rb","position":5,"original_position":5,"commit_id":"f0704c5c643c17310d988234d1ec1666b397c56e","original_commit_id":"f0704c5c643c17310d988234d1ec1666b397c56e","user":{"login":"brianpetro","id":1886014,"avatar_url":"https://avatars.githubusercontent.com/u/1886014?v=3","gravatar_id":"","url":"https://api.github.com/users/brianpetro","html_url":"https://github.com/brianpetro","followers_url":"https://api.github.com/users/brianpetro/followers","following_url":"https://api.github.com/users/brianpetro/following{/other_user}","gists_url":"https://api.github.com/users/brianpetro/gists{/gist_id}","starred_url":"https://api.github.com/users/brianpetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianpetro/subscriptions","organizations_url":"https://api.github.com/users/brianpetro/orgs","repos_url":"https://api.github.com/users/brianpetro/repos","events_url":"https://api.github.com/users/brianpetro/events{/privacy}","received_events_url":"https://api.github.com/users/brianpetro/received_events","type":"User","site_admin":false},"body":"When this is combined with my other PR(https://github.com/cantino/huginn/pull/1147), those depending on the deprecated(array) trigger commander agent options [and thus that behavior] will still encounter the same \"replace\" logic they are used to.\r\n\r\nIn this case, we are also protecting newcomers, like myself, from accidental data loss while they are still learning the intricacies of this rather complex software.","created_at":"2015-11-14T19:35:16Z","updated_at":"2015-11-14T19:35:16Z","html_url":"https://github.com/cantino/huginn/pull/1139#discussion_r44862540","pull_request_url":"https://api.github.com/repos/cantino/huginn/pulls/1139","_links":{"self":{"href":"https://api.github.com/repos/cantino/huginn/pulls/comments/44862540"},"html":{"href":"https://github.com/cantino/huginn/pull/1139#discussion_r44862540"},"pull_request":{"href":"https://api.github.com/repos/cantino/huginn/pulls/1139"}}},"pull_request":{"url":"https://api.github.com/repos/cantino/huginn/pulls/1139","id":50202196,"html_url":"https://github.com/cantino/huginn/pull/1139","diff_url":"https://github.com/cantino/huginn/pull/1139.diff","patch_url":"https://github.com/cantino/huginn/pull/1139.patch","issue_url":"https://api.github.com/repos/cantino/huginn/issues/1139","number":1139,"state":"open","locked":false,"title":"Commander agent should be able to configure Trigger agents.","user":{"login":"brianpetro","id":1886014,"avatar_url":"https://avatars.githubusercontent.com/u/1886014?v=3","gravatar_id":"","url":"https://api.github.com/users/brianpetro","html_url":"https://github.com/brianpetro","followers_url":"https://api.github.com/users/brianpetro/followers","following_url":"https://api.github.com/users/brianpetro/following{/other_user}","gists_url":"https://api.github.com/users/brianpetro/gists{/gist_id}","starred_url":"https://api.github.com/users/brianpetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianpetro/subscriptions","organizations_url":"https://api.github.com/users/brianpetro/orgs","repos_url":"https://api.github.com/users/brianpetro/repos","events_url":"https://api.github.com/users/brianpetro/events{/privacy}","received_events_url":"https://api.github.com/users/brianpetro/received_events","type":"User","site_admin":false},"body":"Make commander agent(through AgentControllerConcern) be able to configure options agents with nested hash options(ie trigger agent).","created_at":"2015-11-10T01:16:12Z","updated_at":"2015-11-14T19:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c629ca090b2554ac588f09be52cfcd0b267956e3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cantino/huginn/pulls/1139/commits","review_comments_url":"https://api.github.com/repos/cantino/huginn/pulls/1139/comments","review_comment_url":"https://api.github.com/repos/cantino/huginn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cantino/huginn/issues/1139/comments","statuses_url":"https://api.github.com/repos/cantino/huginn/statuses/f0704c5c643c17310d988234d1ec1666b397c56e","head":{"label":"brianpetro:config_nested_arrays","ref":"config_nested_arrays","sha":"f0704c5c643c17310d988234d1ec1666b397c56e","user":{"login":"brianpetro","id":1886014,"avatar_url":"https://avatars.githubusercontent.com/u/1886014?v=3","gravatar_id":"","url":"https://api.github.com/users/brianpetro","html_url":"https://github.com/brianpetro","followers_url":"https://api.github.com/users/brianpetro/followers","following_url":"https://api.github.com/users/brianpetro/following{/other_user}","gists_url":"https://api.github.com/users/brianpetro/gists{/gist_id}","starred_url":"https://api.github.com/users/brianpetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianpetro/subscriptions","organizations_url":"https://api.github.com/users/brianpetro/orgs","repos_url":"https://api.github.com/users/brianpetro/repos","events_url":"https://api.github.com/users/brianpetro/events{/privacy}","received_events_url":"https://api.github.com/users/brianpetro/received_events","type":"User","site_admin":false},"repo":{"id":44108367,"name":"huginn","full_name":"brianpetro/huginn","owner":{"login":"brianpetro","id":1886014,"avatar_url":"https://avatars.githubusercontent.com/u/1886014?v=3","gravatar_id":"","url":"https://api.github.com/users/brianpetro","html_url":"https://github.com/brianpetro","followers_url":"https://api.github.com/users/brianpetro/followers","following_url":"https://api.github.com/users/brianpetro/following{/other_user}","gists_url":"https://api.github.com/users/brianpetro/gists{/gist_id}","starred_url":"https://api.github.com/users/brianpetro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianpetro/subscriptions","organizations_url":"https://api.github.com/users/brianpetro/orgs","repos_url":"https://api.github.com/users/brianpetro/repos","events_url":"https://api.github.com/users/brianpetro/events{/privacy}","received_events_url":"https://api.github.com/users/brianpetro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianpetro/huginn","description":"Build agents that monitor and act on your behalf.  Your agents are standing by!","fork":true,"url":"https://api.github.com/repos/brianpetro/huginn","forks_url":"https://api.github.com/repos/brianpetro/huginn/forks","keys_url":"https://api.github.com/repos/brianpetro/huginn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianpetro/huginn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianpetro/huginn/teams","hooks_url":"https://api.github.com/repos/brianpetro/huginn/hooks","issue_events_url":"https://api.github.com/repos/brianpetro/huginn/issues/events{/number}","events_url":"https://api.github.com/repos/brianpetro/huginn/events","assignees_url":"https://api.github.com/repos/brianpetro/huginn/assignees{/user}","branches_url":"https://api.github.com/repos/brianpetro/huginn/branches{/branch}","tags_url":"https://api.github.com/repos/brianpetro/huginn/tags","blobs_url":"https://api.github.com/repos/brianpetro/huginn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianpetro/huginn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianpetro/huginn/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianpetro/huginn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianpetro/huginn/statuses/{sha}","languages_url":"https://api.github.com/repos/brianpetro/huginn/languages","stargazers_url":"https://api.github.com/repos/brianpetro/huginn/stargazers","contributors_url":"https://api.github.com/repos/brianpetro/huginn/contributors","subscribers_url":"https://api.github.com/repos/brianpetro/huginn/subscribers","subscription_url":"https://api.github.com/repos/brianpetro/huginn/subscription","commits_url":"https://api.github.com/repos/brianpetro/huginn/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianpetro/huginn/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianpetro/huginn/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianpetro/huginn/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianpetro/huginn/contents/{+path}","compare_url":"https://api.github.com/repos/brianpetro/huginn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianpetro/huginn/merges","archive_url":"https://api.github.com/repos/brianpetro/huginn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianpetro/huginn/downloads","issues_url":"https://api.github.com/repos/brianpetro/huginn/issues{/number}","pulls_url":"https://api.github.com/repos/brianpetro/huginn/pulls{/number}","milestones_url":"https://api.github.com/repos/brianpetro/huginn/milestones{/number}","notifications_url":"https://api.github.com/repos/brianpetro/huginn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianpetro/huginn/labels{/name}","releases_url":"https://api.github.com/repos/brianpetro/huginn/releases{/id}","created_at":"2015-10-12T13:15:13Z","updated_at":"2015-10-12T13:15:15Z","pushed_at":"2015-11-13T22:29:45Z","git_url":"git://github.com/brianpetro/huginn.git","ssh_url":"git@github.com:brianpetro/huginn.git","clone_url":"https://github.com/brianpetro/huginn.git","svn_url":"https://github.com/brianpetro/huginn","homepage":null,"size":5925,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cantino:master","ref":"master","sha":"a4ea6e7f6a43093d8190ca39f5c430ad3f1b11e9","user":{"login":"cantino","id":83835,"avatar_url":"https://avatars.githubusercontent.com/u/83835?v=3","gravatar_id":"","url":"https://api.github.com/users/cantino","html_url":"https://github.com/cantino","followers_url":"https://api.github.com/users/cantino/followers","following_url":"https://api.github.com/users/cantino/following{/other_user}","gists_url":"https://api.github.com/users/cantino/gists{/gist_id}","starred_url":"https://api.github.com/users/cantino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantino/subscriptions","organizations_url":"https://api.github.com/users/cantino/orgs","repos_url":"https://api.github.com/users/cantino/repos","events_url":"https://api.github.com/users/cantino/events{/privacy}","received_events_url":"https://api.github.com/users/cantino/received_events","type":"User","site_admin":false},"repo":{"id":8681349,"name":"huginn","full_name":"cantino/huginn","owner":{"login":"cantino","id":83835,"avatar_url":"https://avatars.githubusercontent.com/u/83835?v=3","gravatar_id":"","url":"https://api.github.com/users/cantino","html_url":"https://github.com/cantino","followers_url":"https://api.github.com/users/cantino/followers","following_url":"https://api.github.com/users/cantino/following{/other_user}","gists_url":"https://api.github.com/users/cantino/gists{/gist_id}","starred_url":"https://api.github.com/users/cantino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cantino/subscriptions","organizations_url":"https://api.github.com/users/cantino/orgs","repos_url":"https://api.github.com/users/cantino/repos","events_url":"https://api.github.com/users/cantino/events{/privacy}","received_events_url":"https://api.github.com/users/cantino/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cantino/huginn","description":"Build agents that monitor and act on your behalf.  Your agents are standing by!","fork":false,"url":"https://api.github.com/repos/cantino/huginn","forks_url":"https://api.github.com/repos/cantino/huginn/forks","keys_url":"https://api.github.com/repos/cantino/huginn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cantino/huginn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cantino/huginn/teams","hooks_url":"https://api.github.com/repos/cantino/huginn/hooks","issue_events_url":"https://api.github.com/repos/cantino/huginn/issues/events{/number}","events_url":"https://api.github.com/repos/cantino/huginn/events","assignees_url":"https://api.github.com/repos/cantino/huginn/assignees{/user}","branches_url":"https://api.github.com/repos/cantino/huginn/branches{/branch}","tags_url":"https://api.github.com/repos/cantino/huginn/tags","blobs_url":"https://api.github.com/repos/cantino/huginn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cantino/huginn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cantino/huginn/git/refs{/sha}","trees_url":"https://api.github.com/repos/cantino/huginn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cantino/huginn/statuses/{sha}","languages_url":"https://api.github.com/repos/cantino/huginn/languages","stargazers_url":"https://api.github.com/repos/cantino/huginn/stargazers","contributors_url":"https://api.github.com/repos/cantino/huginn/contributors","subscribers_url":"https://api.github.com/repos/cantino/huginn/subscribers","subscription_url":"https://api.github.com/repos/cantino/huginn/subscription","commits_url":"https://api.github.com/repos/cantino/huginn/commits{/sha}","git_commits_url":"https://api.github.com/repos/cantino/huginn/git/commits{/sha}","comments_url":"https://api.github.com/repos/cantino/huginn/comments{/number}","issue_comment_url":"https://api.github.com/repos/cantino/huginn/issues/comments{/number}","contents_url":"https://api.github.com/repos/cantino/huginn/contents/{+path}","compare_url":"https://api.github.com/repos/cantino/huginn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cantino/huginn/merges","archive_url":"https://api.github.com/repos/cantino/huginn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cantino/huginn/downloads","issues_url":"https://api.github.com/repos/cantino/huginn/issues{/number}","pulls_url":"https://api.github.com/repos/cantino/huginn/pulls{/number}","milestones_url":"https://api.github.com/repos/cantino/huginn/milestones{/number}","notifications_url":"https://api.github.com/repos/cantino/huginn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cantino/huginn/labels{/name}","releases_url":"https://api.github.com/repos/cantino/huginn/releases{/id}","created_at":"2013-03-10T06:00:31Z","updated_at":"2015-11-14T18:45:13Z","pushed_at":"2015-11-14T16:54:10Z","git_url":"git://github.com/cantino/huginn.git","ssh_url":"git@github.com:cantino/huginn.git","clone_url":"https://github.com/cantino/huginn.git","svn_url":"https://github.com/cantino/huginn","homepage":null,"size":17691,"stargazers_count":10607,"watchers_count":10607,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1159,"mirror_url":null,"open_issues_count":257,"forks":1159,"open_issues":257,"watchers":10607,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cantino/huginn/pulls/1139"},"html":{"href":"https://github.com/cantino/huginn/pull/1139"},"issue":{"href":"https://api.github.com/repos/cantino/huginn/issues/1139"},"comments":{"href":"https://api.github.com/repos/cantino/huginn/issues/1139/comments"},"review_comments":{"href":"https://api.github.com/repos/cantino/huginn/pulls/1139/comments"},"review_comment":{"href":"https://api.github.com/repos/cantino/huginn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cantino/huginn/pulls/1139/commits"},"statuses":{"href":"https://api.github.com/repos/cantino/huginn/statuses/f0704c5c643c17310d988234d1ec1666b397c56e"}}}}