{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12440","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12440/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12440/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12440/events","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12440","id":99829210,"number":12440,"title":"Refactor `pkg/proxy/config`'s ServiceConfigHandler and EndpointsConfigHandler.","user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars.githubusercontent.com/u/917931?v=3","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels/cla:%20yes","name":"cla: yes","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-08-08T19:20:18Z","updated_at":"2015-08-08T19:25:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/12440","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12440","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12440.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12440.patch"},"body":"Refactor `pkg/proxy/config`’s ServiceConfigHandler.OnUpdate and\r\nEndpointsConfigHandler.OnUpdate to different method names as they have\r\ndifferent signatures.\r\n\r\nThis will let the new proxy (https://github.com/GoogleCloudPlatform/kubernetes/issues/3760) implement  both interfaces.\r\n\r\nSince we won’t need a separate loadbalancer structure (load balancing is handled in the proxy rules), we will simply handle both event types from the same object."},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/129039856","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/12440#issuecomment-129039856","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/12440","id":129039856,"user":{"login":"BenTheElder","id":917931,"avatar_url":"https://avatars.githubusercontent.com/u/917931?v=3","gravatar_id":"","url":"https://api.github.com/users/BenTheElder","html_url":"https://github.com/BenTheElder","followers_url":"https://api.github.com/users/BenTheElder/followers","following_url":"https://api.github.com/users/BenTheElder/following{/other_user}","gists_url":"https://api.github.com/users/BenTheElder/gists{/gist_id}","starred_url":"https://api.github.com/users/BenTheElder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenTheElder/subscriptions","organizations_url":"https://api.github.com/users/BenTheElder/orgs","repos_url":"https://api.github.com/users/BenTheElder/repos","events_url":"https://api.github.com/users/BenTheElder/events{/privacy}","received_events_url":"https://api.github.com/users/BenTheElder/received_events","type":"User","site_admin":false},"created_at":"2015-08-08T19:25:20Z","updated_at":"2015-08-08T19:25:20Z","body":"This should help make the next iteration of https://github.com/GoogleCloudPlatform/kubernetes/pull/9210 cleaner and will let us react quicker to endpoint updates (we can just resync the rules on endpoint update events too).\r\n\r\nNo changes to functionality, just renames the `OnUpdate` method in each proxy/config handler to `OnServiceUpdate` and `OnEndpointsUpdate` so that they don't have clashing signatures.\r\n\r\n/cc @thockin "}}