{"action":"closed","number":1231,"pull_request":{"url":"https://api.github.com/repos/neovim/neovim/pulls/1231","id":21688019,"html_url":"https://github.com/neovim/neovim/pull/1231","diff_url":"https://github.com/neovim/neovim/pull/1231.diff","patch_url":"https://github.com/neovim/neovim/pull/1231.patch","issue_url":"https://api.github.com/repos/neovim/neovim/issues/1231","number":1231,"state":"closed","locked":false,"title":"[RFC] Split environment.c out of misc1.c","user":{"login":"bobtwinkles","id":1514748,"avatar_url":"https://avatars.githubusercontent.com/u/1514748?v=3","gravatar_id":"","url":"https://api.github.com/users/bobtwinkles","html_url":"https://github.com/bobtwinkles","followers_url":"https://api.github.com/users/bobtwinkles/followers","following_url":"https://api.github.com/users/bobtwinkles/following{/other_user}","gists_url":"https://api.github.com/users/bobtwinkles/gists{/gist_id}","starred_url":"https://api.github.com/users/bobtwinkles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobtwinkles/subscriptions","organizations_url":"https://api.github.com/users/bobtwinkles/orgs","repos_url":"https://api.github.com/users/bobtwinkles/repos","events_url":"https://api.github.com/users/bobtwinkles/events{/privacy}","received_events_url":"https://api.github.com/users/bobtwinkles/received_events","type":"User","site_admin":false},"body":"In the ongoing effort to reduce the number of loc in misc[12].c,\r\n(see #209) this commit pulls a number of functions related to\r\nreading, writing, and modifying environment variables from misc1.c\r\ninto a new module.\r\nTODO:\r\n  - fix warnings given by clint.py\r\n  - write documentation\r\n  - make sure environment.c is actually the best place for all this\r\n    code, maybe the homedir stuff should go into path.c?\r\n  - write unittests?","created_at":"2014-09-24T01:53:34Z","updated_at":"2015-03-14T06:42:24Z","closed_at":"2015-03-14T06:42:24Z","merged_at":null,"merge_commit_sha":"ab26a86b79e4ea4b91399c237be03de02ea6ec12","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neovim/neovim/pulls/1231/commits","review_comments_url":"https://api.github.com/repos/neovim/neovim/pulls/1231/comments","review_comment_url":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neovim/neovim/issues/1231/comments","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/6c787fe83701b323d480edd56f49b71fb7a7350c","head":{"label":"bobtwinkles:misc-explode","ref":"misc-explode","sha":"6c787fe83701b323d480edd56f49b71fb7a7350c","user":{"login":"bobtwinkles","id":1514748,"avatar_url":"https://avatars.githubusercontent.com/u/1514748?v=3","gravatar_id":"","url":"https://api.github.com/users/bobtwinkles","html_url":"https://github.com/bobtwinkles","followers_url":"https://api.github.com/users/bobtwinkles/followers","following_url":"https://api.github.com/users/bobtwinkles/following{/other_user}","gists_url":"https://api.github.com/users/bobtwinkles/gists{/gist_id}","starred_url":"https://api.github.com/users/bobtwinkles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobtwinkles/subscriptions","organizations_url":"https://api.github.com/users/bobtwinkles/orgs","repos_url":"https://api.github.com/users/bobtwinkles/repos","events_url":"https://api.github.com/users/bobtwinkles/events{/privacy}","received_events_url":"https://api.github.com/users/bobtwinkles/received_events","type":"User","site_admin":false},"repo":{"id":24392893,"name":"neovim","full_name":"bobtwinkles/neovim","owner":{"login":"bobtwinkles","id":1514748,"avatar_url":"https://avatars.githubusercontent.com/u/1514748?v=3","gravatar_id":"","url":"https://api.github.com/users/bobtwinkles","html_url":"https://github.com/bobtwinkles","followers_url":"https://api.github.com/users/bobtwinkles/followers","following_url":"https://api.github.com/users/bobtwinkles/following{/other_user}","gists_url":"https://api.github.com/users/bobtwinkles/gists{/gist_id}","starred_url":"https://api.github.com/users/bobtwinkles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobtwinkles/subscriptions","organizations_url":"https://api.github.com/users/bobtwinkles/orgs","repos_url":"https://api.github.com/users/bobtwinkles/repos","events_url":"https://api.github.com/users/bobtwinkles/events{/privacy}","received_events_url":"https://api.github.com/users/bobtwinkles/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bobtwinkles/neovim","description":"vim for the 21st century","fork":true,"url":"https://api.github.com/repos/bobtwinkles/neovim","forks_url":"https://api.github.com/repos/bobtwinkles/neovim/forks","keys_url":"https://api.github.com/repos/bobtwinkles/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bobtwinkles/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bobtwinkles/neovim/teams","hooks_url":"https://api.github.com/repos/bobtwinkles/neovim/hooks","issue_events_url":"https://api.github.com/repos/bobtwinkles/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/bobtwinkles/neovim/events","assignees_url":"https://api.github.com/repos/bobtwinkles/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/bobtwinkles/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/bobtwinkles/neovim/tags","blobs_url":"https://api.github.com/repos/bobtwinkles/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bobtwinkles/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bobtwinkles/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/bobtwinkles/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bobtwinkles/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/bobtwinkles/neovim/languages","stargazers_url":"https://api.github.com/repos/bobtwinkles/neovim/stargazers","contributors_url":"https://api.github.com/repos/bobtwinkles/neovim/contributors","subscribers_url":"https://api.github.com/repos/bobtwinkles/neovim/subscribers","subscription_url":"https://api.github.com/repos/bobtwinkles/neovim/subscription","commits_url":"https://api.github.com/repos/bobtwinkles/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/bobtwinkles/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/bobtwinkles/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/bobtwinkles/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/bobtwinkles/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/bobtwinkles/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bobtwinkles/neovim/merges","archive_url":"https://api.github.com/repos/bobtwinkles/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bobtwinkles/neovim/downloads","issues_url":"https://api.github.com/repos/bobtwinkles/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/bobtwinkles/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/bobtwinkles/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/bobtwinkles/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bobtwinkles/neovim/labels{/name}","releases_url":"https://api.github.com/repos/bobtwinkles/neovim/releases{/id}","created_at":"2014-09-23T23:15:58Z","updated_at":"2014-10-04T19:27:35Z","pushed_at":"2015-03-14T06:36:08Z","git_url":"git://github.com/bobtwinkles/neovim.git","ssh_url":"git@github.com:bobtwinkles/neovim.git","clone_url":"https://github.com/bobtwinkles/neovim.git","svn_url":"https://github.com/bobtwinkles/neovim","homepage":"http://neovim.org/","size":22002,"stargazers_count":0,"watchers_count":0,"language":"VimL","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neovim:master","ref":"master","sha":"60e5d8d1ccd5a07038138f18752620edebeb8a3d","user":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"repo":{"id":16408992,"name":"neovim","full_name":"neovim/neovim","owner":{"login":"neovim","id":6471485,"avatar_url":"https://avatars.githubusercontent.com/u/6471485?v=3","gravatar_id":"","url":"https://api.github.com/users/neovim","html_url":"https://github.com/neovim","followers_url":"https://api.github.com/users/neovim/followers","following_url":"https://api.github.com/users/neovim/following{/other_user}","gists_url":"https://api.github.com/users/neovim/gists{/gist_id}","starred_url":"https://api.github.com/users/neovim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neovim/subscriptions","organizations_url":"https://api.github.com/users/neovim/orgs","repos_url":"https://api.github.com/users/neovim/repos","events_url":"https://api.github.com/users/neovim/events{/privacy}","received_events_url":"https://api.github.com/users/neovim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neovim/neovim","description":"vim out of the box","fork":false,"url":"https://api.github.com/repos/neovim/neovim","forks_url":"https://api.github.com/repos/neovim/neovim/forks","keys_url":"https://api.github.com/repos/neovim/neovim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neovim/neovim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neovim/neovim/teams","hooks_url":"https://api.github.com/repos/neovim/neovim/hooks","issue_events_url":"https://api.github.com/repos/neovim/neovim/issues/events{/number}","events_url":"https://api.github.com/repos/neovim/neovim/events","assignees_url":"https://api.github.com/repos/neovim/neovim/assignees{/user}","branches_url":"https://api.github.com/repos/neovim/neovim/branches{/branch}","tags_url":"https://api.github.com/repos/neovim/neovim/tags","blobs_url":"https://api.github.com/repos/neovim/neovim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neovim/neovim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neovim/neovim/git/refs{/sha}","trees_url":"https://api.github.com/repos/neovim/neovim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neovim/neovim/statuses/{sha}","languages_url":"https://api.github.com/repos/neovim/neovim/languages","stargazers_url":"https://api.github.com/repos/neovim/neovim/stargazers","contributors_url":"https://api.github.com/repos/neovim/neovim/contributors","subscribers_url":"https://api.github.com/repos/neovim/neovim/subscribers","subscription_url":"https://api.github.com/repos/neovim/neovim/subscription","commits_url":"https://api.github.com/repos/neovim/neovim/commits{/sha}","git_commits_url":"https://api.github.com/repos/neovim/neovim/git/commits{/sha}","comments_url":"https://api.github.com/repos/neovim/neovim/comments{/number}","issue_comment_url":"https://api.github.com/repos/neovim/neovim/issues/comments{/number}","contents_url":"https://api.github.com/repos/neovim/neovim/contents/{+path}","compare_url":"https://api.github.com/repos/neovim/neovim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neovim/neovim/merges","archive_url":"https://api.github.com/repos/neovim/neovim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neovim/neovim/downloads","issues_url":"https://api.github.com/repos/neovim/neovim/issues{/number}","pulls_url":"https://api.github.com/repos/neovim/neovim/pulls{/number}","milestones_url":"https://api.github.com/repos/neovim/neovim/milestones{/number}","notifications_url":"https://api.github.com/repos/neovim/neovim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neovim/neovim/labels{/name}","releases_url":"https://api.github.com/repos/neovim/neovim/releases{/id}","created_at":"2014-01-31T13:39:22Z","updated_at":"2015-03-14T01:01:26Z","pushed_at":"2015-03-13T21:29:47Z","git_url":"git://github.com/neovim/neovim.git","ssh_url":"git@github.com:neovim/neovim.git","clone_url":"https://github.com/neovim/neovim.git","svn_url":"https://github.com/neovim/neovim","homepage":"http://neovim.org","size":52894,"stargazers_count":12360,"watchers_count":12360,"language":"VimL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":824,"mirror_url":null,"open_issues_count":390,"forks":824,"open_issues":390,"watchers":12360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1231"},"html":{"href":"https://github.com/neovim/neovim/pull/1231"},"issue":{"href":"https://api.github.com/repos/neovim/neovim/issues/1231"},"comments":{"href":"https://api.github.com/repos/neovim/neovim/issues/1231/comments"},"review_comments":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1231/comments"},"review_comment":{"href":"https://api.github.com/repos/neovim/neovim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neovim/neovim/pulls/1231/commits"},"statuses":{"href":"https://api.github.com/repos/neovim/neovim/statuses/6c787fe83701b323d480edd56f49b71fb7a7350c"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":15,"review_comments":3,"commits":5,"additions":757,"deletions":644,"changed_files":14}}