{"action":"created","comment":{"url":"https://api.github.com/repos/robotology/stereo-vision/pulls/comments/42374516","id":42374516,"diff_hunk":"@@ -411,9 +417,19 @@ bool SFM::updateModule()\n             \n     if (outDisp.getOutputCount()>0)\n     {\n-        outputD=stereo->getDisparity();\n+        outputD = stereo->getDisparity();\n         ImageOf<PixelMono> &outim=outDisp.prepare();\n-        outim.wrapIplImage(&outputD);\n+        if (doBLF)\n+        {\n+            IplImage* outputDpt = &outputD;","path":"modules/SFM/SFM.cpp","position":23,"original_position":23,"commit_id":"52dc566803d6b59108266be71475da86e537b89c","original_commit_id":"52dc566803d6b59108266be71475da86e537b89c","user":{"login":"vtikha","id":4537987,"avatar_url":"https://avatars.githubusercontent.com/u/4537987?v=3","gravatar_id":"","url":"https://api.github.com/users/vtikha","html_url":"https://github.com/vtikha","followers_url":"https://api.github.com/users/vtikha/followers","following_url":"https://api.github.com/users/vtikha/following{/other_user}","gists_url":"https://api.github.com/users/vtikha/gists{/gist_id}","starred_url":"https://api.github.com/users/vtikha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vtikha/subscriptions","organizations_url":"https://api.github.com/users/vtikha/orgs","repos_url":"https://api.github.com/users/vtikha/repos","events_url":"https://api.github.com/users/vtikha/events{/privacy}","received_events_url":"https://api.github.com/users/vtikha/received_events","type":"User","site_admin":false},"body":"@tanismar don't you need a `cvReleaseImage(&outputDpt);` when you have finished with this?","created_at":"2015-10-19T14:07:29Z","updated_at":"2015-10-19T14:07:29Z","html_url":"https://github.com/robotology/stereo-vision/pull/7#discussion_r42374516","pull_request_url":"https://api.github.com/repos/robotology/stereo-vision/pulls/7","_links":{"self":{"href":"https://api.github.com/repos/robotology/stereo-vision/pulls/comments/42374516"},"html":{"href":"https://github.com/robotology/stereo-vision/pull/7#discussion_r42374516"},"pull_request":{"href":"https://api.github.com/repos/robotology/stereo-vision/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/robotology/stereo-vision/pulls/7","id":48075103,"html_url":"https://github.com/robotology/stereo-vision/pull/7","diff_url":"https://github.com/robotology/stereo-vision/pull/7.diff","patch_url":"https://github.com/robotology/stereo-vision/pull/7.patch","issue_url":"https://api.github.com/repos/robotology/stereo-vision/issues/7","number":7,"state":"open","locked":false,"title":"Bilateral filter on disparity image","user":{"login":"tanismar","id":4818225,"avatar_url":"https://avatars.githubusercontent.com/u/4818225?v=3","gravatar_id":"","url":"https://api.github.com/users/tanismar","html_url":"https://github.com/tanismar","followers_url":"https://api.github.com/users/tanismar/followers","following_url":"https://api.github.com/users/tanismar/following{/other_user}","gists_url":"https://api.github.com/users/tanismar/gists{/gist_id}","starred_url":"https://api.github.com/users/tanismar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanismar/subscriptions","organizations_url":"https://api.github.com/users/tanismar/orgs","repos_url":"https://api.github.com/users/tanismar/repos","events_url":"https://api.github.com/users/tanismar/events{/privacy}","received_events_url":"https://api.github.com/users/tanismar/received_events","type":"User","site_admin":false},"body":"Implemented the option of processing the output disparity image with a fast edge-preserving bilateral filter in order to reduce noise (based on http://people.csail.mit.edu/sparis/bf/). Filter parameters as well as activation of the filter can be controlled by rpc, with added commands bilatfilt (sigmaColor sigmaSpace) and doBLF (bool), respectively. Speed is reduced for small values of the parameters, but for default and seemingly more useful ones (around 10.0 10.0) speed reduction is minimal. ","created_at":"2015-10-19T14:00:17Z","updated_at":"2015-10-19T14:07:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eade4ee997230bd010c25ccfec796e2fe387ac6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robotology/stereo-vision/pulls/7/commits","review_comments_url":"https://api.github.com/repos/robotology/stereo-vision/pulls/7/comments","review_comment_url":"https://api.github.com/repos/robotology/stereo-vision/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/stereo-vision/issues/7/comments","statuses_url":"https://api.github.com/repos/robotology/stereo-vision/statuses/52dc566803d6b59108266be71475da86e537b89c","head":{"label":"tanismar:master","ref":"master","sha":"52dc566803d6b59108266be71475da86e537b89c","user":{"login":"tanismar","id":4818225,"avatar_url":"https://avatars.githubusercontent.com/u/4818225?v=3","gravatar_id":"","url":"https://api.github.com/users/tanismar","html_url":"https://github.com/tanismar","followers_url":"https://api.github.com/users/tanismar/followers","following_url":"https://api.github.com/users/tanismar/following{/other_user}","gists_url":"https://api.github.com/users/tanismar/gists{/gist_id}","starred_url":"https://api.github.com/users/tanismar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanismar/subscriptions","organizations_url":"https://api.github.com/users/tanismar/orgs","repos_url":"https://api.github.com/users/tanismar/repos","events_url":"https://api.github.com/users/tanismar/events{/privacy}","received_events_url":"https://api.github.com/users/tanismar/received_events","type":"User","site_admin":false},"repo":{"id":44390052,"name":"stereo-vision","full_name":"tanismar/stereo-vision","owner":{"login":"tanismar","id":4818225,"avatar_url":"https://avatars.githubusercontent.com/u/4818225?v=3","gravatar_id":"","url":"https://api.github.com/users/tanismar","html_url":"https://github.com/tanismar","followers_url":"https://api.github.com/users/tanismar/followers","following_url":"https://api.github.com/users/tanismar/following{/other_user}","gists_url":"https://api.github.com/users/tanismar/gists{/gist_id}","starred_url":"https://api.github.com/users/tanismar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanismar/subscriptions","organizations_url":"https://api.github.com/users/tanismar/orgs","repos_url":"https://api.github.com/users/tanismar/repos","events_url":"https://api.github.com/users/tanismar/events{/privacy}","received_events_url":"https://api.github.com/users/tanismar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tanismar/stereo-vision","description":"Repository containing apps for stereo vision","fork":true,"url":"https://api.github.com/repos/tanismar/stereo-vision","forks_url":"https://api.github.com/repos/tanismar/stereo-vision/forks","keys_url":"https://api.github.com/repos/tanismar/stereo-vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanismar/stereo-vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanismar/stereo-vision/teams","hooks_url":"https://api.github.com/repos/tanismar/stereo-vision/hooks","issue_events_url":"https://api.github.com/repos/tanismar/stereo-vision/issues/events{/number}","events_url":"https://api.github.com/repos/tanismar/stereo-vision/events","assignees_url":"https://api.github.com/repos/tanismar/stereo-vision/assignees{/user}","branches_url":"https://api.github.com/repos/tanismar/stereo-vision/branches{/branch}","tags_url":"https://api.github.com/repos/tanismar/stereo-vision/tags","blobs_url":"https://api.github.com/repos/tanismar/stereo-vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanismar/stereo-vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanismar/stereo-vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanismar/stereo-vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanismar/stereo-vision/statuses/{sha}","languages_url":"https://api.github.com/repos/tanismar/stereo-vision/languages","stargazers_url":"https://api.github.com/repos/tanismar/stereo-vision/stargazers","contributors_url":"https://api.github.com/repos/tanismar/stereo-vision/contributors","subscribers_url":"https://api.github.com/repos/tanismar/stereo-vision/subscribers","subscription_url":"https://api.github.com/repos/tanismar/stereo-vision/subscription","commits_url":"https://api.github.com/repos/tanismar/stereo-vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanismar/stereo-vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanismar/stereo-vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanismar/stereo-vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanismar/stereo-vision/contents/{+path}","compare_url":"https://api.github.com/repos/tanismar/stereo-vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanismar/stereo-vision/merges","archive_url":"https://api.github.com/repos/tanismar/stereo-vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanismar/stereo-vision/downloads","issues_url":"https://api.github.com/repos/tanismar/stereo-vision/issues{/number}","pulls_url":"https://api.github.com/repos/tanismar/stereo-vision/pulls{/number}","milestones_url":"https://api.github.com/repos/tanismar/stereo-vision/milestones{/number}","notifications_url":"https://api.github.com/repos/tanismar/stereo-vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanismar/stereo-vision/labels{/name}","releases_url":"https://api.github.com/repos/tanismar/stereo-vision/releases{/id}","created_at":"2015-10-16T14:24:03Z","updated_at":"2015-10-16T14:24:04Z","pushed_at":"2015-10-19T13:39:56Z","git_url":"git://github.com/tanismar/stereo-vision.git","ssh_url":"git@github.com:tanismar/stereo-vision.git","clone_url":"https://github.com/tanismar/stereo-vision.git","svn_url":"https://github.com/tanismar/stereo-vision","homepage":"","size":1405,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotology:master","ref":"master","sha":"38de063bff58fe55ed4bfcb78cfb9eea8874e81f","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":20917225,"name":"stereo-vision","full_name":"robotology/stereo-vision","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars.githubusercontent.com/u/1587191?v=3","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/stereo-vision","description":"Repository containing apps for stereo vision","fork":false,"url":"https://api.github.com/repos/robotology/stereo-vision","forks_url":"https://api.github.com/repos/robotology/stereo-vision/forks","keys_url":"https://api.github.com/repos/robotology/stereo-vision/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/stereo-vision/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/stereo-vision/teams","hooks_url":"https://api.github.com/repos/robotology/stereo-vision/hooks","issue_events_url":"https://api.github.com/repos/robotology/stereo-vision/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/stereo-vision/events","assignees_url":"https://api.github.com/repos/robotology/stereo-vision/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/stereo-vision/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/stereo-vision/tags","blobs_url":"https://api.github.com/repos/robotology/stereo-vision/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/stereo-vision/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/stereo-vision/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/stereo-vision/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/stereo-vision/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/stereo-vision/languages","stargazers_url":"https://api.github.com/repos/robotology/stereo-vision/stargazers","contributors_url":"https://api.github.com/repos/robotology/stereo-vision/contributors","subscribers_url":"https://api.github.com/repos/robotology/stereo-vision/subscribers","subscription_url":"https://api.github.com/repos/robotology/stereo-vision/subscription","commits_url":"https://api.github.com/repos/robotology/stereo-vision/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/stereo-vision/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/stereo-vision/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/stereo-vision/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/stereo-vision/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/stereo-vision/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/stereo-vision/merges","archive_url":"https://api.github.com/repos/robotology/stereo-vision/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/stereo-vision/downloads","issues_url":"https://api.github.com/repos/robotology/stereo-vision/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/stereo-vision/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/stereo-vision/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/stereo-vision/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/stereo-vision/labels{/name}","releases_url":"https://api.github.com/repos/robotology/stereo-vision/releases{/id}","created_at":"2014-06-17T09:13:37Z","updated_at":"2015-04-22T23:09:21Z","pushed_at":"2015-10-19T14:00:17Z","git_url":"git://github.com/robotology/stereo-vision.git","ssh_url":"git@github.com:robotology/stereo-vision.git","clone_url":"https://github.com/robotology/stereo-vision.git","svn_url":"https://github.com/robotology/stereo-vision","homepage":"","size":1801,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5,"mirror_url":null,"open_issues_count":2,"forks":5,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/stereo-vision/pulls/7"},"html":{"href":"https://github.com/robotology/stereo-vision/pull/7"},"issue":{"href":"https://api.github.com/repos/robotology/stereo-vision/issues/7"},"comments":{"href":"https://api.github.com/repos/robotology/stereo-vision/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/stereo-vision/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/stereo-vision/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/stereo-vision/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/stereo-vision/statuses/52dc566803d6b59108266be71475da86e537b89c"}}}}