{"action":"created","issue":{"url":"https://api.github.com/repos/n1k0/backbone-events-standalone/issues/15","labels_url":"https://api.github.com/repos/n1k0/backbone-events-standalone/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/n1k0/backbone-events-standalone/issues/15/comments","events_url":"https://api.github.com/repos/n1k0/backbone-events-standalone/issues/15/events","html_url":"https://github.com/n1k0/backbone-events-standalone/pull/15","id":111824086,"number":15,"title":"Update to Backbone v1.2.3","user":{"login":"suprememoocow","id":594566,"avatar_url":"https://avatars.githubusercontent.com/u/594566?v=3","gravatar_id":"","url":"https://api.github.com/users/suprememoocow","html_url":"https://github.com/suprememoocow","followers_url":"https://api.github.com/users/suprememoocow/followers","following_url":"https://api.github.com/users/suprememoocow/following{/other_user}","gists_url":"https://api.github.com/users/suprememoocow/gists{/gist_id}","starred_url":"https://api.github.com/users/suprememoocow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suprememoocow/subscriptions","organizations_url":"https://api.github.com/users/suprememoocow/orgs","repos_url":"https://api.github.com/users/suprememoocow/repos","events_url":"https://api.github.com/users/suprememoocow/events{/privacy}","received_events_url":"https://api.github.com/users/suprememoocow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-10-16T12:44:08Z","updated_at":"2015-12-02T10:22:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/n1k0/backbone-events-standalone/pulls/15","html_url":"https://github.com/n1k0/backbone-events-standalone/pull/15","diff_url":"https://github.com/n1k0/backbone-events-standalone/pull/15.diff","patch_url":"https://github.com/n1k0/backbone-events-standalone/pull/15.patch"},"body":"First off, is this project being actively maintained? It's not clear from the repo.\r\n\r\nI've updated the Backbone Events implementation to match that of Backbone v1.2.3. \r\n\r\nI've chosen to keep the actual backbone events implementation exactly the same (line for line) as in Backbone. This means that updating it in future will be slightly easier.\r\n\r\nI've also switched the miniscore implementation for individual methods from lodash. While this means that the resulting output size is bigger than before (15k vs 10k), the implementation methods are better tested and better supported across a wide range of browsers.\r\n\r\nAdditionally, if the application is already using lodash and browserify or webpack, the actual lodash code will be shared between the library and the application, resulting in a smaller codesize than the current implementation.\r\n\r\nObviously, in order to do this, I've needed to switch to commonjs modules and to webpack to package the library. The output (`.min.js`) is still a UMD module however.\r\n\r\nI'd love to hear your feedback.\r\n"},"comment":{"url":"https://api.github.com/repos/n1k0/backbone-events-standalone/issues/comments/161249457","html_url":"https://github.com/n1k0/backbone-events-standalone/pull/15#issuecomment-161249457","issue_url":"https://api.github.com/repos/n1k0/backbone-events-standalone/issues/15","id":161249457,"user":{"login":"suprememoocow","id":594566,"avatar_url":"https://avatars.githubusercontent.com/u/594566?v=3","gravatar_id":"","url":"https://api.github.com/users/suprememoocow","html_url":"https://github.com/suprememoocow","followers_url":"https://api.github.com/users/suprememoocow/followers","following_url":"https://api.github.com/users/suprememoocow/following{/other_user}","gists_url":"https://api.github.com/users/suprememoocow/gists{/gist_id}","starred_url":"https://api.github.com/users/suprememoocow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suprememoocow/subscriptions","organizations_url":"https://api.github.com/users/suprememoocow/orgs","repos_url":"https://api.github.com/users/suprememoocow/repos","events_url":"https://api.github.com/users/suprememoocow/events{/privacy}","received_events_url":"https://api.github.com/users/suprememoocow/received_events","type":"User","site_admin":false},"created_at":"2015-12-02T10:22:44Z","updated_at":"2015-12-02T10:22:44Z","body":"@n1k0 thank you!\r\n\r\n@dirkbonhomme would mind reviewing this PR and providing some feedback? How do you feel about switching the internals to lodash?"}}