{"action":"created","issue":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/251","labels_url":"https://api.github.com/repos/01org/parameter-framework/issues/251/labels{/name}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/251/comments","events_url":"https://api.github.com/repos/01org/parameter-framework/issues/251/events","html_url":"https://github.com/01org/parameter-framework/pull/251","id":108291978,"number":251,"title":"Allows exportDomainsWithSettingsXML command with no file path","user":{"login":"louizo","id":12612524,"avatar_url":"https://avatars.githubusercontent.com/u/12612524?v=3","gravatar_id":"","url":"https://api.github.com/users/louizo","html_url":"https://github.com/louizo","followers_url":"https://api.github.com/users/louizo/followers","following_url":"https://api.github.com/users/louizo/following{/other_user}","gists_url":"https://api.github.com/users/louizo/gists{/gist_id}","starred_url":"https://api.github.com/users/louizo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louizo/subscriptions","organizations_url":"https://api.github.com/users/louizo/orgs","repos_url":"https://api.github.com/users/louizo/repos","events_url":"https://api.github.com/users/louizo/events{/privacy}","received_events_url":"https://api.github.com/users/louizo/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/01org/parameter-framework/labels/resubmit","name":"resubmit","color":"eb6420"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/01org/parameter-framework/milestones/4","html_url":"https://github.com/01org/parameter-framework/milestones/Version%203.1","labels_url":"https://api.github.com/repos/01org/parameter-framework/milestones/4/labels","id":1334582,"number":4,"title":"Version 3.1","description":"","creator":{"login":"dawagner","id":6430928,"avatar_url":"https://avatars.githubusercontent.com/u/6430928?v=3","gravatar_id":"","url":"https://api.github.com/users/dawagner","html_url":"https://github.com/dawagner","followers_url":"https://api.github.com/users/dawagner/followers","following_url":"https://api.github.com/users/dawagner/following{/other_user}","gists_url":"https://api.github.com/users/dawagner/gists{/gist_id}","starred_url":"https://api.github.com/users/dawagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawagner/subscriptions","organizations_url":"https://api.github.com/users/dawagner/orgs","repos_url":"https://api.github.com/users/dawagner/repos","events_url":"https://api.github.com/users/dawagner/events{/privacy}","received_events_url":"https://api.github.com/users/dawagner/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2015-10-02T09:25:53Z","updated_at":"2015-10-06T09:59:20Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-09-25T09:28:51Z","updated_at":"2015-10-07T09:17:25Z","closed_at":"2015-10-06T09:59:20Z","pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/251","html_url":"https://github.com/01org/parameter-framework/pull/251","diff_url":"https://github.com/01org/parameter-framework/pull/251.diff","patch_url":"https://github.com/01org/parameter-framework/pull/251.patch"},"body":"Currently, the exportDomainsWIthSettingsXML command expects the file path\r\nto be passed as parameter, as an absolute path.\r\n\r\nThe default file path mentioned in ParameterFrameworkConfiguration.xml file\r\nis used if there is no command argument. If this path is a relative one,\r\nit is converted into absolute path before being provided to\r\nParameterManager.\r\n\r\nSigned-off-by: Thierry Quervel <thierry.quervel@intel.com>\r\n\r\nConflicts:\r\n\tparameter/ParameterMgr.cpp\n<a href='#crh-start'></a><a href='#crh-data-%7B%22approved%22%3A%20%7B%22https%3A//github.com/louizo%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12612524%3Fv%3D3%22%7D%7D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/251%23issuecomment-143169846%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3Ashipit%3A%22%2C%20%22created_at%22%3A%20%222015-09-25T09%3A30%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12612524%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/louizo%22%7D%7D%2C%20%7B%22body%22%3A%20%22quick%20test%20%26%20working%20fine%20on%20linux.%5Cr%5Cn%22%2C%20%22created_at%22%3A%20%222015-09-25T10%3A50%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12612524%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/louizo%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%20%22%2C%20%22created_at%22%3A%20%222015-09-28T09%3A32%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%209b9c0676a694d9f3fe64eabcc3cd491b4c0a832e%20parameter/ParameterMgr.cpp%2038%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/251%23discussion_r40528778%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22After%20rebase%5Cr%5Cn%20CXmlDocSource%3A%3AmkURI%28_strXmlConfigurationUri%2C%20pConfigurableDomainsFileLocation-%3EgetUri%28%29%29%22%2C%20%22created_at%22%3A%20%222015-09-28T08%3A40%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/12096004%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/miguelgaio%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20parameter/ParameterMgr.cpp%3AL1503-1538%22%7D%7D%2C%20%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/251%23issuecomment-143169846%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/251%23issuecomment-143185997%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/251%23discussion_r40528778%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/251%23issuecomment-143690781%22%5D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n\n<img src='http://www.codereviewhub.com/site/github-approved-avatar.png'><a href='https://github.com/louizo'><img src='https://avatars.githubusercontent.com/u/12612524?v=3' width=34 height=34></a>\n\n- [ ] <a href='#crh-comment-Pull 9b9c0676a694d9f3fe64eabcc3cd491b4c0a832e parameter/ParameterMgr.cpp 38'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/251#discussion_r40528778'>File: parameter/ParameterMgr.cpp:L1503-1538</a></b>\n- <a href='https://github.com/miguelgaio'><img border=0 src='https://avatars.githubusercontent.com/u/12096004?v=3' height=16 width=16'></a> After rebase\nCXmlDocSource::mkURI(_strXmlConfigurationUri, pConfigurableDomainsFileLocation->getUri())\n- [x] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/251#issuecomment-143169846'>General Comment</a></b>\n- <a href='https://github.com/louizo'><img border=0 src='https://avatars.githubusercontent.com/u/12612524?v=3' height=16 width=16'></a> :shipit:\n- <a href='https://github.com/louizo'><img border=0 src='https://avatars.githubusercontent.com/u/12612524?v=3' height=16 width=16'></a> quick test & working fine on linux.\n\n\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/251?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/251?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/251?approve=0'><img src='http://www.codereviewhub.com/site/github-undo-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/251'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/01org/parameter-framework/issues/comments/146128716","html_url":"https://github.com/01org/parameter-framework/pull/251#issuecomment-146128716","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/251","id":146128716,"user":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"created_at":"2015-10-07T09:17:25Z","updated_at":"2015-10-07T09:17:25Z","body":"@louizo Please resubmit against `serialization_api` branch."}}