{"action":"opened","number":578,"pull_request":{"url":"https://api.github.com/repos/SickRage/SickRage/pulls/578","id":54597657,"html_url":"https://github.com/SickRage/SickRage/pull/578","diff_url":"https://github.com/SickRage/SickRage/pull/578.diff","patch_url":"https://github.com/SickRage/SickRage/pull/578.patch","issue_url":"https://api.github.com/repos/SickRage/SickRage/issues/578","number":578,"state":"open","locked":false,"title":"Fixed logging for calls to TVShow.wantEpisode","user":{"login":"Amadeus-","id":2244392,"avatar_url":"https://avatars.githubusercontent.com/u/2244392?v=3","gravatar_id":"","url":"https://api.github.com/users/Amadeus-","html_url":"https://github.com/Amadeus-","followers_url":"https://api.github.com/users/Amadeus-/followers","following_url":"https://api.github.com/users/Amadeus-/following{/other_user}","gists_url":"https://api.github.com/users/Amadeus-/gists{/gist_id}","starred_url":"https://api.github.com/users/Amadeus-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amadeus-/subscriptions","organizations_url":"https://api.github.com/users/Amadeus-/orgs","repos_url":"https://api.github.com/users/Amadeus-/repos","events_url":"https://api.github.com/users/Amadeus-/events{/privacy}","received_events_url":"https://api.github.com/users/Amadeus-/received_events","type":"User","site_admin":false},"body":"The wantEpisode method of the TVShow class currently returns false for several reasons; however, in some instances across SR, when the function returned false, a log entry was added indicating that it was because the quality was incorrect.\r\n\r\nThis commit adjusts wantEpisode so that it creates detailed INFO log messages on a false return. This commit also removes the bogus log messages from the calling function.\r\n\r\nSo, previously, the log would have looked like this: http://www.hastebin.com/ivebafuyoc.vbs But, with this commit, the log file will look like this: http://hastebin.com/vapapovodo.vbs As you can see, the first one gives the quality as the reason for all of the false returns ...while the second log snippet gives the actual reason for each.","created_at":"2015-12-26T06:00:33Z","updated_at":"2015-12-26T06:00:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SickRage/SickRage/pulls/578/commits","review_comments_url":"https://api.github.com/repos/SickRage/SickRage/pulls/578/comments","review_comment_url":"https://api.github.com/repos/SickRage/SickRage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SickRage/SickRage/issues/578/comments","statuses_url":"https://api.github.com/repos/SickRage/SickRage/statuses/f2eb56e0839aad7a3899586f1371c3eb160f1526","head":{"label":"Amadeus-:LogClarification1","ref":"LogClarification1","sha":"f2eb56e0839aad7a3899586f1371c3eb160f1526","user":{"login":"Amadeus-","id":2244392,"avatar_url":"https://avatars.githubusercontent.com/u/2244392?v=3","gravatar_id":"","url":"https://api.github.com/users/Amadeus-","html_url":"https://github.com/Amadeus-","followers_url":"https://api.github.com/users/Amadeus-/followers","following_url":"https://api.github.com/users/Amadeus-/following{/other_user}","gists_url":"https://api.github.com/users/Amadeus-/gists{/gist_id}","starred_url":"https://api.github.com/users/Amadeus-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amadeus-/subscriptions","organizations_url":"https://api.github.com/users/Amadeus-/orgs","repos_url":"https://api.github.com/users/Amadeus-/repos","events_url":"https://api.github.com/users/Amadeus-/events{/privacy}","received_events_url":"https://api.github.com/users/Amadeus-/received_events","type":"User","site_admin":false},"repo":{"id":46255269,"name":"SickRage","full_name":"Amadeus-/SickRage","owner":{"login":"Amadeus-","id":2244392,"avatar_url":"https://avatars.githubusercontent.com/u/2244392?v=3","gravatar_id":"","url":"https://api.github.com/users/Amadeus-","html_url":"https://github.com/Amadeus-","followers_url":"https://api.github.com/users/Amadeus-/followers","following_url":"https://api.github.com/users/Amadeus-/following{/other_user}","gists_url":"https://api.github.com/users/Amadeus-/gists{/gist_id}","starred_url":"https://api.github.com/users/Amadeus-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Amadeus-/subscriptions","organizations_url":"https://api.github.com/users/Amadeus-/orgs","repos_url":"https://api.github.com/users/Amadeus-/repos","events_url":"https://api.github.com/users/Amadeus-/events{/privacy}","received_events_url":"https://api.github.com/users/Amadeus-/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Amadeus-/SickRage","description":"SickRage Reincarnate","fork":true,"url":"https://api.github.com/repos/Amadeus-/SickRage","forks_url":"https://api.github.com/repos/Amadeus-/SickRage/forks","keys_url":"https://api.github.com/repos/Amadeus-/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Amadeus-/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Amadeus-/SickRage/teams","hooks_url":"https://api.github.com/repos/Amadeus-/SickRage/hooks","issue_events_url":"https://api.github.com/repos/Amadeus-/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/Amadeus-/SickRage/events","assignees_url":"https://api.github.com/repos/Amadeus-/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/Amadeus-/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/Amadeus-/SickRage/tags","blobs_url":"https://api.github.com/repos/Amadeus-/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Amadeus-/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Amadeus-/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Amadeus-/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Amadeus-/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/Amadeus-/SickRage/languages","stargazers_url":"https://api.github.com/repos/Amadeus-/SickRage/stargazers","contributors_url":"https://api.github.com/repos/Amadeus-/SickRage/contributors","subscribers_url":"https://api.github.com/repos/Amadeus-/SickRage/subscribers","subscription_url":"https://api.github.com/repos/Amadeus-/SickRage/subscription","commits_url":"https://api.github.com/repos/Amadeus-/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Amadeus-/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Amadeus-/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Amadeus-/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Amadeus-/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/Amadeus-/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Amadeus-/SickRage/merges","archive_url":"https://api.github.com/repos/Amadeus-/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Amadeus-/SickRage/downloads","issues_url":"https://api.github.com/repos/Amadeus-/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/Amadeus-/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/Amadeus-/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/Amadeus-/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Amadeus-/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/Amadeus-/SickRage/releases{/id}","created_at":"2015-11-16T06:02:09Z","updated_at":"2015-11-16T06:02:18Z","pushed_at":"2015-12-26T05:59:21Z","git_url":"git://github.com/Amadeus-/SickRage.git","ssh_url":"git@github.com:Amadeus-/SickRage.git","clone_url":"https://github.com/Amadeus-/SickRage.git","svn_url":"https://github.com/Amadeus-/SickRage","homepage":"","size":43400,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SickRage:develop","ref":"develop","sha":"5f6569f78bde76ebb89193d114c69b671bf334e2","user":{"login":"SickRage","id":15840255,"avatar_url":"https://avatars.githubusercontent.com/u/15840255?v=3","gravatar_id":"","url":"https://api.github.com/users/SickRage","html_url":"https://github.com/SickRage","followers_url":"https://api.github.com/users/SickRage/followers","following_url":"https://api.github.com/users/SickRage/following{/other_user}","gists_url":"https://api.github.com/users/SickRage/gists{/gist_id}","starred_url":"https://api.github.com/users/SickRage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickRage/subscriptions","organizations_url":"https://api.github.com/users/SickRage/orgs","repos_url":"https://api.github.com/users/SickRage/repos","events_url":"https://api.github.com/users/SickRage/events{/privacy}","received_events_url":"https://api.github.com/users/SickRage/received_events","type":"Organization","site_admin":false},"repo":{"id":46151823,"name":"SickRage","full_name":"SickRage/SickRage","owner":{"login":"SickRage","id":15840255,"avatar_url":"https://avatars.githubusercontent.com/u/15840255?v=3","gravatar_id":"","url":"https://api.github.com/users/SickRage","html_url":"https://github.com/SickRage","followers_url":"https://api.github.com/users/SickRage/followers","following_url":"https://api.github.com/users/SickRage/following{/other_user}","gists_url":"https://api.github.com/users/SickRage/gists{/gist_id}","starred_url":"https://api.github.com/users/SickRage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SickRage/subscriptions","organizations_url":"https://api.github.com/users/SickRage/orgs","repos_url":"https://api.github.com/users/SickRage/repos","events_url":"https://api.github.com/users/SickRage/events{/privacy}","received_events_url":"https://api.github.com/users/SickRage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SickRage/SickRage","description":"The new home of the SickRage community","fork":false,"url":"https://api.github.com/repos/SickRage/SickRage","forks_url":"https://api.github.com/repos/SickRage/SickRage/forks","keys_url":"https://api.github.com/repos/SickRage/SickRage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SickRage/SickRage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SickRage/SickRage/teams","hooks_url":"https://api.github.com/repos/SickRage/SickRage/hooks","issue_events_url":"https://api.github.com/repos/SickRage/SickRage/issues/events{/number}","events_url":"https://api.github.com/repos/SickRage/SickRage/events","assignees_url":"https://api.github.com/repos/SickRage/SickRage/assignees{/user}","branches_url":"https://api.github.com/repos/SickRage/SickRage/branches{/branch}","tags_url":"https://api.github.com/repos/SickRage/SickRage/tags","blobs_url":"https://api.github.com/repos/SickRage/SickRage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SickRage/SickRage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SickRage/SickRage/git/refs{/sha}","trees_url":"https://api.github.com/repos/SickRage/SickRage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SickRage/SickRage/statuses/{sha}","languages_url":"https://api.github.com/repos/SickRage/SickRage/languages","stargazers_url":"https://api.github.com/repos/SickRage/SickRage/stargazers","contributors_url":"https://api.github.com/repos/SickRage/SickRage/contributors","subscribers_url":"https://api.github.com/repos/SickRage/SickRage/subscribers","subscription_url":"https://api.github.com/repos/SickRage/SickRage/subscription","commits_url":"https://api.github.com/repos/SickRage/SickRage/commits{/sha}","git_commits_url":"https://api.github.com/repos/SickRage/SickRage/git/commits{/sha}","comments_url":"https://api.github.com/repos/SickRage/SickRage/comments{/number}","issue_comment_url":"https://api.github.com/repos/SickRage/SickRage/issues/comments{/number}","contents_url":"https://api.github.com/repos/SickRage/SickRage/contents/{+path}","compare_url":"https://api.github.com/repos/SickRage/SickRage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SickRage/SickRage/merges","archive_url":"https://api.github.com/repos/SickRage/SickRage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SickRage/SickRage/downloads","issues_url":"https://api.github.com/repos/SickRage/SickRage/issues{/number}","pulls_url":"https://api.github.com/repos/SickRage/SickRage/pulls{/number}","milestones_url":"https://api.github.com/repos/SickRage/SickRage/milestones{/number}","notifications_url":"https://api.github.com/repos/SickRage/SickRage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SickRage/SickRage/labels{/name}","releases_url":"https://api.github.com/repos/SickRage/SickRage/releases{/id}","created_at":"2015-11-13T23:01:22Z","updated_at":"2015-12-25T18:43:12Z","pushed_at":"2015-12-26T05:57:25Z","git_url":"git://github.com/SickRage/SickRage.git","ssh_url":"git@github.com:SickRage/SickRage.git","clone_url":"https://github.com/SickRage/SickRage.git","svn_url":"https://github.com/SickRage/SickRage","homepage":"https://sickrage.github.io","size":43650,"stargazers_count":178,"watchers_count":178,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":8,"forks":62,"open_issues":8,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/578"},"html":{"href":"https://github.com/SickRage/SickRage/pull/578"},"issue":{"href":"https://api.github.com/repos/SickRage/SickRage/issues/578"},"comments":{"href":"https://api.github.com/repos/SickRage/SickRage/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SickRage/SickRage/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/SickRage/SickRage/statuses/f2eb56e0839aad7a3899586f1371c3eb160f1526"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":17,"deletions":13,"changed_files":4}}