{"action":"created","comment":{"url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/comments/38919949","id":38919949,"diff_hunk":"@@ -201,6 +201,12 @@ def mark_as_complete\n             @experiment.progress_bar_update(@simulation_run.index, 'error')\n           else\n             @experiment.progress_bar_update(@simulation_run.index, 'done')\n+            # Increment finished simulation counter in simulation manager record","path":"app/controllers/simulations_controller.rb","position":4,"original_position":4,"commit_id":"0e3ed98e638ea206833543b23c4f530e7fc29fc4","original_commit_id":"0e3ed98e638ea206833543b23c4f530e7fc29fc4","user":{"login":"mpaciore","id":3855041,"avatar_url":"https://avatars.githubusercontent.com/u/3855041?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaciore","html_url":"https://github.com/mpaciore","followers_url":"https://api.github.com/users/mpaciore/followers","following_url":"https://api.github.com/users/mpaciore/following{/other_user}","gists_url":"https://api.github.com/users/mpaciore/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaciore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaciore/subscriptions","organizations_url":"https://api.github.com/users/mpaciore/orgs","repos_url":"https://api.github.com/users/mpaciore/repos","events_url":"https://api.github.com/users/mpaciore/events{/privacy}","received_events_url":"https://api.github.com/users/mpaciore/received_events","type":"User","site_admin":false},"body":"Ustawienie nie powinno być zależne od tego ifa. Jeżeli params[:status] == 'error', to i tak symulacja jest skończona, nie będzie powtarzana i tylko na pasku będzie czerwona. Jeżeli jej nie policzysz to nie doliczysz się do 100%.\r\nPrawdopodobnie nie ma wtedy sensownych wyników, ale to nas nie interesuje.","created_at":"2015-09-08T12:38:44Z","updated_at":"2015-09-08T12:38:44Z","html_url":"https://github.com/Scalarm/scalarm_experiment_manager/pull/92#discussion_r38919949","pull_request_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92","_links":{"self":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/comments/38919949"},"html":{"href":"https://github.com/Scalarm/scalarm_experiment_manager/pull/92#discussion_r38919949"},"pull_request":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92"}}},"pull_request":{"url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92","id":42006113,"html_url":"https://github.com/Scalarm/scalarm_experiment_manager/pull/92","diff_url":"https://github.com/Scalarm/scalarm_experiment_manager/pull/92.diff","patch_url":"https://github.com/Scalarm/scalarm_experiment_manager/pull/92.patch","issue_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/92","number":92,"state":"open","locked":false,"title":"WSS-17 Extension of statistics module","user":{"login":"mwrona","id":3709316,"avatar_url":"https://avatars.githubusercontent.com/u/3709316?v=3","gravatar_id":"","url":"https://api.github.com/users/mwrona","html_url":"https://github.com/mwrona","followers_url":"https://api.github.com/users/mwrona/followers","following_url":"https://api.github.com/users/mwrona/following{/other_user}","gists_url":"https://api.github.com/users/mwrona/gists{/gist_id}","starred_url":"https://api.github.com/users/mwrona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwrona/subscriptions","organizations_url":"https://api.github.com/users/mwrona/orgs","repos_url":"https://api.github.com/users/mwrona/repos","events_url":"https://api.github.com/users/mwrona/events{/privacy}","received_events_url":"https://api.github.com/users/mwrona/received_events","type":"User","site_admin":false},"body":"Otwarte do dyskusji.\r\n\r\nCzy na tę chwile potrzebujemy coś więcej niż trzy parametry które tutaj podałem?\r\nDodatkowo, wnoszę propozycję o zmianę nazwy na ExperimentStatistics. Uzasadniam to tym że teraz będą tutaj głównie metody związane ze stanem konkretnego eksperymentu. Jeśli w przyszłości zajdzie potrzeba dodania statystyk np. infrastruktury można to zrobić w osobnym module. Prawdopodobnie lista działających na rzecz eksperymentu workerów powinna trafić tutaj z modułu zasobów, ponieważ te dane będą potrzebne do obliczenia system_throughput.","created_at":"2015-08-10T10:29:33Z","updated_at":"2015-09-08T12:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76d3a951e51ece9d3aa27b404867180868a21204","assignee":{"login":"mpaciore","id":3855041,"avatar_url":"https://avatars.githubusercontent.com/u/3855041?v=3","gravatar_id":"","url":"https://api.github.com/users/mpaciore","html_url":"https://github.com/mpaciore","followers_url":"https://api.github.com/users/mpaciore/followers","following_url":"https://api.github.com/users/mpaciore/following{/other_user}","gists_url":"https://api.github.com/users/mpaciore/gists{/gist_id}","starred_url":"https://api.github.com/users/mpaciore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpaciore/subscriptions","organizations_url":"https://api.github.com/users/mpaciore/orgs","repos_url":"https://api.github.com/users/mpaciore/repos","events_url":"https://api.github.com/users/mpaciore/events{/privacy}","received_events_url":"https://api.github.com/users/mpaciore/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92/commits","review_comments_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92/comments","review_comment_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/92/comments","statuses_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/statuses/0e3ed98e638ea206833543b23c4f530e7fc29fc4","head":{"label":"Scalarm:WSS-17","ref":"WSS-17","sha":"0e3ed98e638ea206833543b23c4f530e7fc29fc4","user":{"login":"Scalarm","id":4244361,"avatar_url":"https://avatars.githubusercontent.com/u/4244361?v=3","gravatar_id":"","url":"https://api.github.com/users/Scalarm","html_url":"https://github.com/Scalarm","followers_url":"https://api.github.com/users/Scalarm/followers","following_url":"https://api.github.com/users/Scalarm/following{/other_user}","gists_url":"https://api.github.com/users/Scalarm/gists{/gist_id}","starred_url":"https://api.github.com/users/Scalarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scalarm/subscriptions","organizations_url":"https://api.github.com/users/Scalarm/orgs","repos_url":"https://api.github.com/users/Scalarm/repos","events_url":"https://api.github.com/users/Scalarm/events{/privacy}","received_events_url":"https://api.github.com/users/Scalarm/received_events","type":"Organization","site_admin":false},"repo":{"id":7915145,"name":"scalarm_experiment_manager","full_name":"Scalarm/scalarm_experiment_manager","owner":{"login":"Scalarm","id":4244361,"avatar_url":"https://avatars.githubusercontent.com/u/4244361?v=3","gravatar_id":"","url":"https://api.github.com/users/Scalarm","html_url":"https://github.com/Scalarm","followers_url":"https://api.github.com/users/Scalarm/followers","following_url":"https://api.github.com/users/Scalarm/following{/other_user}","gists_url":"https://api.github.com/users/Scalarm/gists{/gist_id}","starred_url":"https://api.github.com/users/Scalarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scalarm/subscriptions","organizations_url":"https://api.github.com/users/Scalarm/orgs","repos_url":"https://api.github.com/users/Scalarm/repos","events_url":"https://api.github.com/users/Scalarm/events{/privacy}","received_events_url":"https://api.github.com/users/Scalarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scalarm/scalarm_experiment_manager","description":"Scalarm Experiment Manager is the main component of the Scalarm platform for data farming.","fork":false,"url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager","forks_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/forks","keys_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/teams","hooks_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/hooks","issue_events_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/events{/number}","events_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/events","assignees_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/assignees{/user}","branches_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/branches{/branch}","tags_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/tags","blobs_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/languages","stargazers_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/stargazers","contributors_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/contributors","subscribers_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/subscribers","subscription_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/subscription","commits_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/contents/{+path}","compare_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/merges","archive_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/downloads","issues_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues{/number}","pulls_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/labels{/name}","releases_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/releases{/id}","created_at":"2013-01-30T13:34:10Z","updated_at":"2015-04-20T15:56:04Z","pushed_at":"2015-09-08T12:09:24Z","git_url":"git://github.com/Scalarm/scalarm_experiment_manager.git","ssh_url":"git@github.com:Scalarm/scalarm_experiment_manager.git","clone_url":"https://github.com/Scalarm/scalarm_experiment_manager.git","svn_url":"https://github.com/Scalarm/scalarm_experiment_manager","homepage":null,"size":41865,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"base":{"label":"Scalarm:WSS-master","ref":"WSS-master","sha":"67186547e8e135457f953bb57a04d84fa3d9060a","user":{"login":"Scalarm","id":4244361,"avatar_url":"https://avatars.githubusercontent.com/u/4244361?v=3","gravatar_id":"","url":"https://api.github.com/users/Scalarm","html_url":"https://github.com/Scalarm","followers_url":"https://api.github.com/users/Scalarm/followers","following_url":"https://api.github.com/users/Scalarm/following{/other_user}","gists_url":"https://api.github.com/users/Scalarm/gists{/gist_id}","starred_url":"https://api.github.com/users/Scalarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scalarm/subscriptions","organizations_url":"https://api.github.com/users/Scalarm/orgs","repos_url":"https://api.github.com/users/Scalarm/repos","events_url":"https://api.github.com/users/Scalarm/events{/privacy}","received_events_url":"https://api.github.com/users/Scalarm/received_events","type":"Organization","site_admin":false},"repo":{"id":7915145,"name":"scalarm_experiment_manager","full_name":"Scalarm/scalarm_experiment_manager","owner":{"login":"Scalarm","id":4244361,"avatar_url":"https://avatars.githubusercontent.com/u/4244361?v=3","gravatar_id":"","url":"https://api.github.com/users/Scalarm","html_url":"https://github.com/Scalarm","followers_url":"https://api.github.com/users/Scalarm/followers","following_url":"https://api.github.com/users/Scalarm/following{/other_user}","gists_url":"https://api.github.com/users/Scalarm/gists{/gist_id}","starred_url":"https://api.github.com/users/Scalarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scalarm/subscriptions","organizations_url":"https://api.github.com/users/Scalarm/orgs","repos_url":"https://api.github.com/users/Scalarm/repos","events_url":"https://api.github.com/users/Scalarm/events{/privacy}","received_events_url":"https://api.github.com/users/Scalarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Scalarm/scalarm_experiment_manager","description":"Scalarm Experiment Manager is the main component of the Scalarm platform for data farming.","fork":false,"url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager","forks_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/forks","keys_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/teams","hooks_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/hooks","issue_events_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/events{/number}","events_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/events","assignees_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/assignees{/user}","branches_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/branches{/branch}","tags_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/tags","blobs_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/statuses/{sha}","languages_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/languages","stargazers_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/stargazers","contributors_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/contributors","subscribers_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/subscribers","subscription_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/subscription","commits_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/contents/{+path}","compare_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/merges","archive_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/downloads","issues_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues{/number}","pulls_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls{/number}","milestones_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/milestones{/number}","notifications_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/labels{/name}","releases_url":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/releases{/id}","created_at":"2013-01-30T13:34:10Z","updated_at":"2015-04-20T15:56:04Z","pushed_at":"2015-09-08T12:09:24Z","git_url":"git://github.com/Scalarm/scalarm_experiment_manager.git","ssh_url":"git@github.com:Scalarm/scalarm_experiment_manager.git","clone_url":"https://github.com/Scalarm/scalarm_experiment_manager.git","svn_url":"https://github.com/Scalarm/scalarm_experiment_manager","homepage":null,"size":41865,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92"},"html":{"href":"https://github.com/Scalarm/scalarm_experiment_manager/pull/92"},"issue":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/92"},"comments":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/issues/92/comments"},"review_comments":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92/comments"},"review_comment":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/pulls/92/commits"},"statuses":{"href":"https://api.github.com/repos/Scalarm/scalarm_experiment_manager/statuses/0e3ed98e638ea206833543b23c4f530e7fc29fc4"}}}}