{"action":"created","issue":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/31262","labels_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/31262/labels{/name}","comments_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/31262/comments","events_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/31262/events","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/31262","id":112509468,"number":31262,"title":"Lps 58134","user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-21T04:19:45Z","updated_at":"2015-10-21T16:27:47Z","closed_at":"2015-10-21T05:12:35Z","pull_request":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/pulls/31262","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/31262","diff_url":"https://github.com/brianchandotcom/liferay-portal/pull/31262.diff","patch_url":"https://github.com/brianchandotcom/liferay-portal/pull/31262.patch"},"body":"@csierra please see my commit message at https://github.com/brianchandotcom/liferay-portal/commit/8924b0354d00e6344052826c5c0e432b83b3d19d\r\n\r\nSo even with this fix, it only lower the chance of seeing a real race condition, it does not eliminate it.\r\n\r\nWe should avoid doing this kind of System.out/System.err swapping at all cost for production code.\r\n\r\nI don't know what was the original requirement that led you to this solution. Please fill me in about why we need this, I will try to find out a way to avoid doing this."},"comment":{"url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/comments/149952189","html_url":"https://github.com/brianchandotcom/liferay-portal/pull/31262#issuecomment-149952189","issue_url":"https://api.github.com/repos/brianchandotcom/liferay-portal/issues/31262","id":149952189,"user":{"login":"shuyangzhou","id":173369,"avatar_url":"https://avatars.githubusercontent.com/u/173369?v=3","gravatar_id":"","url":"https://api.github.com/users/shuyangzhou","html_url":"https://github.com/shuyangzhou","followers_url":"https://api.github.com/users/shuyangzhou/followers","following_url":"https://api.github.com/users/shuyangzhou/following{/other_user}","gists_url":"https://api.github.com/users/shuyangzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/shuyangzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shuyangzhou/subscriptions","organizations_url":"https://api.github.com/users/shuyangzhou/orgs","repos_url":"https://api.github.com/users/shuyangzhou/repos","events_url":"https://api.github.com/users/shuyangzhou/events{/privacy}","received_events_url":"https://api.github.com/users/shuyangzhou/received_events","type":"User","site_admin":false},"created_at":"2015-10-21T16:27:47Z","updated_at":"2015-10-21T16:27:47Z","body":"@csierra\r\n\r\nDoes offline here mean running out side portal jvm?\r\nOr it just means it runs before portal start to receive requests?\r\n\r\nIf it is out side portal jvm, and we have control over everything, this is fine, but we should move it close to it usage. Currently it is a kernel util, which can be used for wrong purpose in the future.\r\n\r\nIf it is just before request serving, then it is not ok, we have to remove it. As portal is not ready, does not mean other webapps in the same appserver are not ready. They could race with us.\r\n\r\nCan you show me a usage of it? What exact output we are trying to collect here?\r\n\r\nThanks\r\n\r\nShuyang"}}