{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rkt/pulls/comments/43110142","id":43110142,"diff_hunk":"@@ -0,0 +1,58 @@\n+#!/usr/bin/env bash\n+set -ex\n+\n+MODIFY=${MODIFY:-\"\"}\n+FLAGS=${FLAGS:-\"\"}\n+IMG=${IMG:-\"debian\"}\n+IMGVERSION=${VERSION:-\"sid\"}\n+DOCKERIMG=\"$IMG:$IMGVERSION\"\n+ACIFILE=${ACIFILE:-\"$IMG-$IMGVERSION.aci\"}\n+OUTACI=\"rkt-builder.aci\"\n+BUILDDIR=/opt/build-rkt\n+SRC_DIR=/opt/rkt\n+ACI_GOPATH=/go\n+VERSION=${VERSION:-\"v0.10.0\"}\n+# if [ `expr match $VERSION '.*git$'` -gt 0 ]; then\n+#     VERSION=\"$VERSION$(git rev-parse --short HEAD 2>/dev/null)$(git diff-index --quiet HEAD 2>/dev/null || echo -dirty)\"\n+# fi\n+echo \"Version: $VERSION\"\n+\n+echo \"Building $ACIFILE\"\n+\n+which docker2aci || go get github.com/appc/docker2aci\n+if ! [ -e \"$ACIFILE\" ]; then","path":"scripts/acbuild-rkt-builder.sh","position":23,"original_position":23,"commit_id":"aae4ba88c2d898cb5b885066ab9c230d80cf9943","original_commit_id":"aae4ba88c2d898cb5b885066ab9c230d80cf9943","user":{"login":"krnowak","id":96081,"avatar_url":"https://avatars.githubusercontent.com/u/96081?v=3","gravatar_id":"","url":"https://api.github.com/users/krnowak","html_url":"https://github.com/krnowak","followers_url":"https://api.github.com/users/krnowak/followers","following_url":"https://api.github.com/users/krnowak/following{/other_user}","gists_url":"https://api.github.com/users/krnowak/gists{/gist_id}","starred_url":"https://api.github.com/users/krnowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krnowak/subscriptions","organizations_url":"https://api.github.com/users/krnowak/orgs","repos_url":"https://api.github.com/users/krnowak/repos","events_url":"https://api.github.com/users/krnowak/events{/privacy}","received_events_url":"https://api.github.com/users/krnowak/received_events","type":"User","site_admin":false},"body":"Heh, I see this form for the first time (not that I read tons of bash, though). How about `if [ ! -e \"$ACIFILE\" ]; then`?","created_at":"2015-10-27T11:34:47Z","updated_at":"2015-10-27T11:34:47Z","html_url":"https://github.com/coreos/rkt/pull/1681#discussion_r43110142","pull_request_url":"https://api.github.com/repos/coreos/rkt/pulls/1681","_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments/43110142"},"html":{"href":"https://github.com/coreos/rkt/pull/1681#discussion_r43110142"},"pull_request":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1681"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rkt/pulls/1681","id":48672387,"html_url":"https://github.com/coreos/rkt/pull/1681","diff_url":"https://github.com/coreos/rkt/pull/1681.diff","patch_url":"https://github.com/coreos/rkt/pull/1681.patch","issue_url":"https://api.github.com/repos/coreos/rkt/issues/1681","number":1681,"state":"open","locked":false,"title":"Support building rkt inside rkt container","user":{"login":"ecnahc515","id":1400401,"avatar_url":"https://avatars.githubusercontent.com/u/1400401?v=3","gravatar_id":"","url":"https://api.github.com/users/ecnahc515","html_url":"https://github.com/ecnahc515","followers_url":"https://api.github.com/users/ecnahc515/followers","following_url":"https://api.github.com/users/ecnahc515/following{/other_user}","gists_url":"https://api.github.com/users/ecnahc515/gists{/gist_id}","starred_url":"https://api.github.com/users/ecnahc515/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecnahc515/subscriptions","organizations_url":"https://api.github.com/users/ecnahc515/orgs","repos_url":"https://api.github.com/users/ecnahc515/repos","events_url":"https://api.github.com/users/ecnahc515/events{/privacy}","received_events_url":"https://api.github.com/users/ecnahc515/received_events","type":"User","site_admin":false},"body":"This adds some new scripts and documentation details on how to use `acbuild` to create an ACI which has all build-time dependencies for compiling rkt, as well as how to use said image to compile rkt and output the result into a volume.\r\n\r\nVagrant still builds in the VM, not in a container, it would be slower to do it in a container because the image would need to be built first, but once we can pull in the builder image, it should be switched to use that & rkt for builds. Also, when rkt is being built in vagrant, the it now logs to `/vagrant/rkt-build.log`, because vagrant was printing the wget progress bar terribly (one line per dot blink), so if it looks like nothing is happening during the build, that's why.\r\n\r\nFixes #844 ","created_at":"2015-10-25T05:33:31Z","updated_at":"2015-10-27T11:34:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41ec1b2d85ecd80549efa0e198aa449100015bcd","assignee":null,"milestone":{"url":"https://api.github.com/repos/coreos/rkt/milestones/24","html_url":"https://github.com/coreos/rkt/milestones/v0.11.0","labels_url":"https://api.github.com/repos/coreos/rkt/milestones/24/labels","id":1360014,"number":24,"title":"v0.11.0","description":"","creator":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":6,"state":"open","created_at":"2015-10-16T18:28:50Z","updated_at":"2015-10-26T17:14:27Z","due_on":"2015-11-04T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/coreos/rkt/pulls/1681/commits","review_comments_url":"https://api.github.com/repos/coreos/rkt/pulls/1681/comments","review_comment_url":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/rkt/issues/1681/comments","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/aae4ba88c2d898cb5b885066ab9c230d80cf9943","head":{"label":"ecnahc515:rkt_acbuild","ref":"rkt_acbuild","sha":"aae4ba88c2d898cb5b885066ab9c230d80cf9943","user":{"login":"ecnahc515","id":1400401,"avatar_url":"https://avatars.githubusercontent.com/u/1400401?v=3","gravatar_id":"","url":"https://api.github.com/users/ecnahc515","html_url":"https://github.com/ecnahc515","followers_url":"https://api.github.com/users/ecnahc515/followers","following_url":"https://api.github.com/users/ecnahc515/following{/other_user}","gists_url":"https://api.github.com/users/ecnahc515/gists{/gist_id}","starred_url":"https://api.github.com/users/ecnahc515/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecnahc515/subscriptions","organizations_url":"https://api.github.com/users/ecnahc515/orgs","repos_url":"https://api.github.com/users/ecnahc515/repos","events_url":"https://api.github.com/users/ecnahc515/events{/privacy}","received_events_url":"https://api.github.com/users/ecnahc515/received_events","type":"User","site_admin":false},"repo":{"id":44897362,"name":"rkt","full_name":"ecnahc515/rkt","owner":{"login":"ecnahc515","id":1400401,"avatar_url":"https://avatars.githubusercontent.com/u/1400401?v=3","gravatar_id":"","url":"https://api.github.com/users/ecnahc515","html_url":"https://github.com/ecnahc515","followers_url":"https://api.github.com/users/ecnahc515/followers","following_url":"https://api.github.com/users/ecnahc515/following{/other_user}","gists_url":"https://api.github.com/users/ecnahc515/gists{/gist_id}","starred_url":"https://api.github.com/users/ecnahc515/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecnahc515/subscriptions","organizations_url":"https://api.github.com/users/ecnahc515/orgs","repos_url":"https://api.github.com/users/ecnahc515/repos","events_url":"https://api.github.com/users/ecnahc515/events{/privacy}","received_events_url":"https://api.github.com/users/ecnahc515/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ecnahc515/rkt","description":"rkt is an App Container runtime for Linux","fork":true,"url":"https://api.github.com/repos/ecnahc515/rkt","forks_url":"https://api.github.com/repos/ecnahc515/rkt/forks","keys_url":"https://api.github.com/repos/ecnahc515/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ecnahc515/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ecnahc515/rkt/teams","hooks_url":"https://api.github.com/repos/ecnahc515/rkt/hooks","issue_events_url":"https://api.github.com/repos/ecnahc515/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/ecnahc515/rkt/events","assignees_url":"https://api.github.com/repos/ecnahc515/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/ecnahc515/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/ecnahc515/rkt/tags","blobs_url":"https://api.github.com/repos/ecnahc515/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ecnahc515/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ecnahc515/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ecnahc515/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ecnahc515/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/ecnahc515/rkt/languages","stargazers_url":"https://api.github.com/repos/ecnahc515/rkt/stargazers","contributors_url":"https://api.github.com/repos/ecnahc515/rkt/contributors","subscribers_url":"https://api.github.com/repos/ecnahc515/rkt/subscribers","subscription_url":"https://api.github.com/repos/ecnahc515/rkt/subscription","commits_url":"https://api.github.com/repos/ecnahc515/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ecnahc515/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ecnahc515/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ecnahc515/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ecnahc515/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/ecnahc515/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ecnahc515/rkt/merges","archive_url":"https://api.github.com/repos/ecnahc515/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ecnahc515/rkt/downloads","issues_url":"https://api.github.com/repos/ecnahc515/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/ecnahc515/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/ecnahc515/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/ecnahc515/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ecnahc515/rkt/labels{/name}","releases_url":"https://api.github.com/repos/ecnahc515/rkt/releases{/id}","created_at":"2015-10-25T05:08:38Z","updated_at":"2015-10-25T05:08:40Z","pushed_at":"2015-10-26T18:01:45Z","git_url":"git://github.com/ecnahc515/rkt.git","ssh_url":"git@github.com:ecnahc515/rkt.git","clone_url":"https://github.com/ecnahc515/rkt.git","svn_url":"https://github.com/ecnahc515/rkt","homepage":"","size":16922,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"774b4964487a62aa08d2a79fe978ab9dd6da36d5","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rkt","full_name":"coreos/rkt","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rkt","description":"rkt is an App Container runtime for Linux","fork":false,"url":"https://api.github.com/repos/coreos/rkt","forks_url":"https://api.github.com/repos/coreos/rkt/forks","keys_url":"https://api.github.com/repos/coreos/rkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rkt/teams","hooks_url":"https://api.github.com/repos/coreos/rkt/hooks","issue_events_url":"https://api.github.com/repos/coreos/rkt/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rkt/events","assignees_url":"https://api.github.com/repos/coreos/rkt/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rkt/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rkt/tags","blobs_url":"https://api.github.com/repos/coreos/rkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rkt/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rkt/languages","stargazers_url":"https://api.github.com/repos/coreos/rkt/stargazers","contributors_url":"https://api.github.com/repos/coreos/rkt/contributors","subscribers_url":"https://api.github.com/repos/coreos/rkt/subscribers","subscription_url":"https://api.github.com/repos/coreos/rkt/subscription","commits_url":"https://api.github.com/repos/coreos/rkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/rkt/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rkt/merges","archive_url":"https://api.github.com/repos/coreos/rkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rkt/downloads","issues_url":"https://api.github.com/repos/coreos/rkt/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rkt/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rkt/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rkt/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rkt/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-10-27T11:13:34Z","pushed_at":"2015-10-27T11:00:13Z","git_url":"git://github.com/coreos/rkt.git","ssh_url":"git@github.com:coreos/rkt.git","clone_url":"https://github.com/coreos/rkt.git","svn_url":"https://github.com/coreos/rkt","homepage":"","size":28169,"stargazers_count":4776,"watchers_count":4776,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":402,"mirror_url":null,"open_issues_count":187,"forks":402,"open_issues":187,"watchers":4776,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1681"},"html":{"href":"https://github.com/coreos/rkt/pull/1681"},"issue":{"href":"https://api.github.com/repos/coreos/rkt/issues/1681"},"comments":{"href":"https://api.github.com/repos/coreos/rkt/issues/1681/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1681/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/rkt/pulls/1681/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rkt/statuses/aae4ba88c2d898cb5b885066ab9c230d80cf9943"}}}}