{"action":"created","issue":{"url":"https://api.github.com/repos/etorreborre/specs2/issues/417","labels_url":"https://api.github.com/repos/etorreborre/specs2/issues/417/labels{/name}","comments_url":"https://api.github.com/repos/etorreborre/specs2/issues/417/comments","events_url":"https://api.github.com/repos/etorreborre/specs2/issues/417/events","html_url":"https://github.com/etorreborre/specs2/pull/417","id":108496833,"number":417,"title":"Only fail on a future if Await.result timeouts","user":{"login":"knutwalker","id":633183,"avatar_url":"https://avatars.githubusercontent.com/u/633183?v=3","gravatar_id":"","url":"https://api.github.com/users/knutwalker","html_url":"https://github.com/knutwalker","followers_url":"https://api.github.com/users/knutwalker/followers","following_url":"https://api.github.com/users/knutwalker/following{/other_user}","gists_url":"https://api.github.com/users/knutwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/knutwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knutwalker/subscriptions","organizations_url":"https://api.github.com/users/knutwalker/orgs","repos_url":"https://api.github.com/users/knutwalker/repos","events_url":"https://api.github.com/users/knutwalker/events{/privacy}","received_events_url":"https://api.github.com/users/knutwalker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-26T21:26:37Z","updated_at":"2015-09-28T00:03:35Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/etorreborre/specs2/pulls/417","html_url":"https://github.com/etorreborre/specs2/pull/417","diff_url":"https://github.com/etorreborre/specs2/pull/417.diff","patch_url":"https://github.com/etorreborre/specs2/pull/417.patch"},"body":"This seems like an unnecessary check, but if the Future fails with some `T <: TimeoutException`, this exception would be swallowed and wrongly reported as a Failure.\r\nI got this recently when trying to test some akka ask behavior and they fail with a [AskTimoeutException](https://github.com/akka/akka/blob/v2.3.14/akka-actor/src/main/scala/akka/pattern/AskSupport.scala#L21). Using `await`, I couldn't test that this particular Exception was failing the Future.\r\nThe proposed fix only works for actual subclasses, not if some other code fails with a `TimeoutExeption` directly."},"comment":{"url":"https://api.github.com/repos/etorreborre/specs2/issues/comments/143605838","html_url":"https://github.com/etorreborre/specs2/pull/417#issuecomment-143605838","issue_url":"https://api.github.com/repos/etorreborre/specs2/issues/417","id":143605838,"user":{"login":"etorreborre","id":10988,"avatar_url":"https://avatars.githubusercontent.com/u/10988?v=3","gravatar_id":"","url":"https://api.github.com/users/etorreborre","html_url":"https://github.com/etorreborre","followers_url":"https://api.github.com/users/etorreborre/followers","following_url":"https://api.github.com/users/etorreborre/following{/other_user}","gists_url":"https://api.github.com/users/etorreborre/gists{/gist_id}","starred_url":"https://api.github.com/users/etorreborre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etorreborre/subscriptions","organizations_url":"https://api.github.com/users/etorreborre/orgs","repos_url":"https://api.github.com/users/etorreborre/repos","events_url":"https://api.github.com/users/etorreborre/events{/privacy}","received_events_url":"https://api.github.com/users/etorreborre/received_events","type":"User","site_admin":false},"created_at":"2015-09-28T00:03:35Z","updated_at":"2015-09-28T00:03:35Z","body":"Great, thanks!"}}