{"action":"created","comment":{"url":"https://api.github.com/repos/ufz/ogs/pulls/comments/28496256","id":28496256,"diff_hunk":"@@ -119,6 +123,17 @@ MeshLib::Mesh* MeshIO::loadMeshFromFile(const std::string& file_name)\n \t\tMeshLib::Mesh* mesh (new MeshLib::Mesh(BaseLib::extractBaseNameWithoutExtension(\n \t\t                                               file_name), nodes, elements));\n \n+\t\tboost::optional<MeshLib::PropertyVector<int> &> opt_material_ids(\n+\t\t\tmesh->getProperties().createNewPropertyVector<int>(\n+\t\t\t\t\"MaterialIDs\", MeshLib::MeshItemType::Cell, 1)\n+\t\t);\n+\t\tif (!opt_material_ids) {\n+\t\t\tWARN(\"No material ids read.\");","path":"FileIO/Legacy/MeshIO.cpp","position":36,"original_position":36,"commit_id":"065a20d2aaaa6e225cbc30745134a8ae9d822aaf","original_commit_id":"065a20d2aaaa6e225cbc30745134a8ae9d822aaf","user":{"login":"rinkk","id":798445,"avatar_url":"https://avatars.githubusercontent.com/u/798445?v=3","gravatar_id":"","url":"https://api.github.com/users/rinkk","html_url":"https://github.com/rinkk","followers_url":"https://api.github.com/users/rinkk/followers","following_url":"https://api.github.com/users/rinkk/following{/other_user}","gists_url":"https://api.github.com/users/rinkk/gists{/gist_id}","starred_url":"https://api.github.com/users/rinkk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rinkk/subscriptions","organizations_url":"https://api.github.com/users/rinkk/orgs","repos_url":"https://api.github.com/users/rinkk/repos","events_url":"https://api.github.com/users/rinkk/events{/privacy}","received_events_url":"https://api.github.com/users/rinkk/received_events","type":"User","site_admin":false},"body":"is this possible? and if so, is it still a valid mesh file?","created_at":"2015-04-16T09:42:52Z","updated_at":"2015-04-16T09:42:52Z","html_url":"https://github.com/ufz/ogs/pull/644#discussion_r28496256","pull_request_url":"https://api.github.com/repos/ufz/ogs/pulls/644","_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments/28496256"},"html":{"href":"https://github.com/ufz/ogs/pull/644#discussion_r28496256"},"pull_request":{"href":"https://api.github.com/repos/ufz/ogs/pulls/644"}}},"pull_request":{"url":"https://api.github.com/repos/ufz/ogs/pulls/644","id":33352687,"html_url":"https://github.com/ufz/ogs/pull/644","diff_url":"https://github.com/ufz/ogs/pull/644.diff","patch_url":"https://github.com/ufz/ogs/pull/644.patch","issue_url":"https://api.github.com/repos/ufz/ogs/issues/644","number":644,"state":"open","locked":false,"title":"MeshIO using new Properties and PropertyVector.","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"body":"Reading material ids of elements from the old ogs mesh file format (*.msh) into the new data structures.","created_at":"2015-04-15T13:11:56Z","updated_at":"2015-04-16T09:42:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"424c96150936b88983ee6acdab3d181d2829d0cf","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ufz/ogs/pulls/644/commits","review_comments_url":"https://api.github.com/repos/ufz/ogs/pulls/644/comments","review_comment_url":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ufz/ogs/issues/644/comments","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/065a20d2aaaa6e225cbc30745134a8ae9d822aaf","head":{"label":"TomFischer:MeshIOUsingNewPropertiesImpl","ref":"MeshIOUsingNewPropertiesImpl","sha":"065a20d2aaaa6e225cbc30745134a8ae9d822aaf","user":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"repo":{"id":6882427,"name":"ogs","full_name":"TomFischer/ogs","owner":{"login":"TomFischer","id":800065,"avatar_url":"https://avatars.githubusercontent.com/u/800065?v=3","gravatar_id":"","url":"https://api.github.com/users/TomFischer","html_url":"https://github.com/TomFischer","followers_url":"https://api.github.com/users/TomFischer/followers","following_url":"https://api.github.com/users/TomFischer/following{/other_user}","gists_url":"https://api.github.com/users/TomFischer/gists{/gist_id}","starred_url":"https://api.github.com/users/TomFischer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TomFischer/subscriptions","organizations_url":"https://api.github.com/users/TomFischer/orgs","repos_url":"https://api.github.com/users/TomFischer/repos","events_url":"https://api.github.com/users/TomFischer/events{/privacy}","received_events_url":"https://api.github.com/users/TomFischer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TomFischer/ogs","description":"OGS source code","fork":true,"url":"https://api.github.com/repos/TomFischer/ogs","forks_url":"https://api.github.com/repos/TomFischer/ogs/forks","keys_url":"https://api.github.com/repos/TomFischer/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TomFischer/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TomFischer/ogs/teams","hooks_url":"https://api.github.com/repos/TomFischer/ogs/hooks","issue_events_url":"https://api.github.com/repos/TomFischer/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/TomFischer/ogs/events","assignees_url":"https://api.github.com/repos/TomFischer/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/TomFischer/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/TomFischer/ogs/tags","blobs_url":"https://api.github.com/repos/TomFischer/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TomFischer/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TomFischer/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/TomFischer/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TomFischer/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/TomFischer/ogs/languages","stargazers_url":"https://api.github.com/repos/TomFischer/ogs/stargazers","contributors_url":"https://api.github.com/repos/TomFischer/ogs/contributors","subscribers_url":"https://api.github.com/repos/TomFischer/ogs/subscribers","subscription_url":"https://api.github.com/repos/TomFischer/ogs/subscription","commits_url":"https://api.github.com/repos/TomFischer/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/TomFischer/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/TomFischer/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/TomFischer/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/TomFischer/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/TomFischer/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TomFischer/ogs/merges","archive_url":"https://api.github.com/repos/TomFischer/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TomFischer/ogs/downloads","issues_url":"https://api.github.com/repos/TomFischer/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/TomFischer/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/TomFischer/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/TomFischer/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TomFischer/ogs/labels{/name}","releases_url":"https://api.github.com/repos/TomFischer/ogs/releases{/id}","created_at":"2012-11-27T11:49:36Z","updated_at":"2015-04-16T08:38:50Z","pushed_at":"2015-04-16T08:41:17Z","git_url":"git://github.com/TomFischer/ogs.git","ssh_url":"git@github.com:TomFischer/ogs.git","clone_url":"https://github.com/TomFischer/ogs.git","svn_url":"https://github.com/TomFischer/ogs","homepage":"www.opengeosys.org","size":11927,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ufz:master","ref":"master","sha":"7d6bd359d44c0b11a242eadd8b319a180f84c862","user":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"repo":{"id":1701384,"name":"ogs","full_name":"ufz/ogs","owner":{"login":"ufz","id":767517,"avatar_url":"https://avatars.githubusercontent.com/u/767517?v=3","gravatar_id":"","url":"https://api.github.com/users/ufz","html_url":"https://github.com/ufz","followers_url":"https://api.github.com/users/ufz/followers","following_url":"https://api.github.com/users/ufz/following{/other_user}","gists_url":"https://api.github.com/users/ufz/gists{/gist_id}","starred_url":"https://api.github.com/users/ufz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ufz/subscriptions","organizations_url":"https://api.github.com/users/ufz/orgs","repos_url":"https://api.github.com/users/ufz/repos","events_url":"https://api.github.com/users/ufz/events{/privacy}","received_events_url":"https://api.github.com/users/ufz/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ufz/ogs","description":"OGS source code","fork":false,"url":"https://api.github.com/repos/ufz/ogs","forks_url":"https://api.github.com/repos/ufz/ogs/forks","keys_url":"https://api.github.com/repos/ufz/ogs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ufz/ogs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ufz/ogs/teams","hooks_url":"https://api.github.com/repos/ufz/ogs/hooks","issue_events_url":"https://api.github.com/repos/ufz/ogs/issues/events{/number}","events_url":"https://api.github.com/repos/ufz/ogs/events","assignees_url":"https://api.github.com/repos/ufz/ogs/assignees{/user}","branches_url":"https://api.github.com/repos/ufz/ogs/branches{/branch}","tags_url":"https://api.github.com/repos/ufz/ogs/tags","blobs_url":"https://api.github.com/repos/ufz/ogs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ufz/ogs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ufz/ogs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ufz/ogs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ufz/ogs/statuses/{sha}","languages_url":"https://api.github.com/repos/ufz/ogs/languages","stargazers_url":"https://api.github.com/repos/ufz/ogs/stargazers","contributors_url":"https://api.github.com/repos/ufz/ogs/contributors","subscribers_url":"https://api.github.com/repos/ufz/ogs/subscribers","subscription_url":"https://api.github.com/repos/ufz/ogs/subscription","commits_url":"https://api.github.com/repos/ufz/ogs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ufz/ogs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ufz/ogs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ufz/ogs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ufz/ogs/contents/{+path}","compare_url":"https://api.github.com/repos/ufz/ogs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ufz/ogs/merges","archive_url":"https://api.github.com/repos/ufz/ogs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ufz/ogs/downloads","issues_url":"https://api.github.com/repos/ufz/ogs/issues{/number}","pulls_url":"https://api.github.com/repos/ufz/ogs/pulls{/number}","milestones_url":"https://api.github.com/repos/ufz/ogs/milestones{/number}","notifications_url":"https://api.github.com/repos/ufz/ogs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ufz/ogs/labels{/name}","releases_url":"https://api.github.com/repos/ufz/ogs/releases{/id}","created_at":"2011-05-04T14:09:57Z","updated_at":"2015-04-16T08:37:24Z","pushed_at":"2015-04-16T08:42:49Z","git_url":"git://github.com/ufz/ogs.git","ssh_url":"git@github.com:ufz/ogs.git","clone_url":"https://github.com/ufz/ogs.git","svn_url":"https://github.com/ufz/ogs","homepage":"www.opengeosys.org","size":15085,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":46,"forks":33,"open_issues":46,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ufz/ogs/pulls/644"},"html":{"href":"https://github.com/ufz/ogs/pull/644"},"issue":{"href":"https://api.github.com/repos/ufz/ogs/issues/644"},"comments":{"href":"https://api.github.com/repos/ufz/ogs/issues/644/comments"},"review_comments":{"href":"https://api.github.com/repos/ufz/ogs/pulls/644/comments"},"review_comment":{"href":"https://api.github.com/repos/ufz/ogs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ufz/ogs/pulls/644/commits"},"statuses":{"href":"https://api.github.com/repos/ufz/ogs/statuses/065a20d2aaaa6e225cbc30745134a8ae9d822aaf"}}}}