{"action":"created","comment":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/31679089","id":31679089,"diff_hunk":"@@ -0,0 +1,57 @@\n+package gobblin.test.setup.config;\n+\n+import gobblin.test.execution.TestHarnessExecutor;\n+\n+\n+/**\n+ * An interface for parsing the config data for test harness. \n+ * This interface is allows to parse and validate the config setting\n+ * \n+ * @author sveerama\n+ *\n+ * @param <I> Input folder where the config (JSON/YAML) is stored\n+ * @param <C> The reader of the input for the config\n+ */\n+\n+/* (c) 2014 LinkedIn Corp. All rights reserved.\n+*\n+* Licensed under the Apache License, Version 2.0 (the \"License\"); you may not use\n+* this file except in compliance with the License. You may obtain a copy of the\n+* License at  http://www.apache.org/licenses/LICENSE-2.0\n+*\n+* Unless required by applicable law or agreed to in writing, software distributed\n+* under the License is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR\n+* CONDITIONS OF ANY KIND, either express or implied.\n+*/\n+public interface TestHarnessLauncher<I, C> extends ConfigStepsGenerator<C>, TestHarnessExecutor<C> {","path":"gobblin-test-harness/src/main/java/gobblin/test/setup/config/TestHarnessLauncher.java","position":26,"original_position":26,"commit_id":"f19905f98410de7339308099ecf4fb17e3faf49e","original_commit_id":"f19905f98410de7339308099ecf4fb17e3faf49e","user":{"login":"suvodeep-pyne","id":2577714,"avatar_url":"https://avatars.githubusercontent.com/u/2577714?v=3","gravatar_id":"","url":"https://api.github.com/users/suvodeep-pyne","html_url":"https://github.com/suvodeep-pyne","followers_url":"https://api.github.com/users/suvodeep-pyne/followers","following_url":"https://api.github.com/users/suvodeep-pyne/following{/other_user}","gists_url":"https://api.github.com/users/suvodeep-pyne/gists{/gist_id}","starred_url":"https://api.github.com/users/suvodeep-pyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suvodeep-pyne/subscriptions","organizations_url":"https://api.github.com/users/suvodeep-pyne/orgs","repos_url":"https://api.github.com/users/suvodeep-pyne/repos","events_url":"https://api.github.com/users/suvodeep-pyne/events{/privacy}","received_events_url":"https://api.github.com/users/suvodeep-pyne/received_events","type":"User","site_admin":false},"body":"One suggestion is to actually nail down the config file instead of generifying it. The user can store in whatever format he wants and its his responsibility to feed in the information as a config which can be a simple properties object or even a hadoop config. This config can be used to execute the test harness. If the Config is an unqualified generic then, how do we plan to read the config in the framework ?\r\n\r\n","created_at":"2015-06-03T22:53:57Z","updated_at":"2015-06-03T22:53:57Z","html_url":"https://github.com/linkedin/gobblin/pull/153#discussion_r31679089","pull_request_url":"https://api.github.com/repos/linkedin/gobblin/pulls/153","_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments/31679089"},"html":{"href":"https://github.com/linkedin/gobblin/pull/153#discussion_r31679089"},"pull_request":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/153"}}},"pull_request":{"url":"https://api.github.com/repos/linkedin/gobblin/pulls/153","id":36767246,"html_url":"https://github.com/linkedin/gobblin/pull/153","diff_url":"https://github.com/linkedin/gobblin/pull/153.diff","patch_url":"https://github.com/linkedin/gobblin/pull/153.patch","issue_url":"https://api.github.com/repos/linkedin/gobblin/issues/153","number":153,"state":"open","locked":false,"title":"Checkin for the test harness interfaces","user":{"login":"swami-veeramani","id":12701725,"avatar_url":"https://avatars.githubusercontent.com/u/12701725?v=3","gravatar_id":"","url":"https://api.github.com/users/swami-veeramani","html_url":"https://github.com/swami-veeramani","followers_url":"https://api.github.com/users/swami-veeramani/followers","following_url":"https://api.github.com/users/swami-veeramani/following{/other_user}","gists_url":"https://api.github.com/users/swami-veeramani/gists{/gist_id}","starred_url":"https://api.github.com/users/swami-veeramani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swami-veeramani/subscriptions","organizations_url":"https://api.github.com/users/swami-veeramani/orgs","repos_url":"https://api.github.com/users/swami-veeramani/repos","events_url":"https://api.github.com/users/swami-veeramani/events{/privacy}","received_events_url":"https://api.github.com/users/swami-veeramani/received_events","type":"User","site_admin":false},"body":"Interfaces created for the config reading and config setup creation steps\r\n2. The operator interface for each task\r\n3. The Configreader will read the config create a properties file and then ConfigStepsGenerator will generate individual steps based on the config.\r\n4. Step is made of 1 or more setup operators.\r\n5. Operator is individual task\r\n6. ValidationRule will take Input and output and verify if the rule is passed or failed\r\n7. TestHarnessExecutor launched individual test job based on the config","created_at":"2015-06-02T19:54:09Z","updated_at":"2015-06-03T22:53:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9538456349f2774fdb151d810fe4641901a79ba3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/linkedin/gobblin/pulls/153/commits","review_comments_url":"https://api.github.com/repos/linkedin/gobblin/pulls/153/comments","review_comment_url":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkedin/gobblin/issues/153/comments","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/f19905f98410de7339308099ecf4fb17e3faf49e","head":{"label":"swami-veeramani:master","ref":"master","sha":"f19905f98410de7339308099ecf4fb17e3faf49e","user":{"login":"swami-veeramani","id":12701725,"avatar_url":"https://avatars.githubusercontent.com/u/12701725?v=3","gravatar_id":"","url":"https://api.github.com/users/swami-veeramani","html_url":"https://github.com/swami-veeramani","followers_url":"https://api.github.com/users/swami-veeramani/followers","following_url":"https://api.github.com/users/swami-veeramani/following{/other_user}","gists_url":"https://api.github.com/users/swami-veeramani/gists{/gist_id}","starred_url":"https://api.github.com/users/swami-veeramani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swami-veeramani/subscriptions","organizations_url":"https://api.github.com/users/swami-veeramani/orgs","repos_url":"https://api.github.com/users/swami-veeramani/repos","events_url":"https://api.github.com/users/swami-veeramani/events{/privacy}","received_events_url":"https://api.github.com/users/swami-veeramani/received_events","type":"User","site_admin":false},"repo":{"id":36680891,"name":"gobblin","full_name":"swami-veeramani/gobblin","owner":{"login":"swami-veeramani","id":12701725,"avatar_url":"https://avatars.githubusercontent.com/u/12701725?v=3","gravatar_id":"","url":"https://api.github.com/users/swami-veeramani","html_url":"https://github.com/swami-veeramani","followers_url":"https://api.github.com/users/swami-veeramani/followers","following_url":"https://api.github.com/users/swami-veeramani/following{/other_user}","gists_url":"https://api.github.com/users/swami-veeramani/gists{/gist_id}","starred_url":"https://api.github.com/users/swami-veeramani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swami-veeramani/subscriptions","organizations_url":"https://api.github.com/users/swami-veeramani/orgs","repos_url":"https://api.github.com/users/swami-veeramani/repos","events_url":"https://api.github.com/users/swami-veeramani/events{/privacy}","received_events_url":"https://api.github.com/users/swami-veeramani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/swami-veeramani/gobblin","description":"","fork":true,"url":"https://api.github.com/repos/swami-veeramani/gobblin","forks_url":"https://api.github.com/repos/swami-veeramani/gobblin/forks","keys_url":"https://api.github.com/repos/swami-veeramani/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/swami-veeramani/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/swami-veeramani/gobblin/teams","hooks_url":"https://api.github.com/repos/swami-veeramani/gobblin/hooks","issue_events_url":"https://api.github.com/repos/swami-veeramani/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/swami-veeramani/gobblin/events","assignees_url":"https://api.github.com/repos/swami-veeramani/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/swami-veeramani/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/swami-veeramani/gobblin/tags","blobs_url":"https://api.github.com/repos/swami-veeramani/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/swami-veeramani/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/swami-veeramani/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/swami-veeramani/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/swami-veeramani/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/swami-veeramani/gobblin/languages","stargazers_url":"https://api.github.com/repos/swami-veeramani/gobblin/stargazers","contributors_url":"https://api.github.com/repos/swami-veeramani/gobblin/contributors","subscribers_url":"https://api.github.com/repos/swami-veeramani/gobblin/subscribers","subscription_url":"https://api.github.com/repos/swami-veeramani/gobblin/subscription","commits_url":"https://api.github.com/repos/swami-veeramani/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/swami-veeramani/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/swami-veeramani/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/swami-veeramani/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/swami-veeramani/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/swami-veeramani/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/swami-veeramani/gobblin/merges","archive_url":"https://api.github.com/repos/swami-veeramani/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/swami-veeramani/gobblin/downloads","issues_url":"https://api.github.com/repos/swami-veeramani/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/swami-veeramani/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/swami-veeramani/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/swami-veeramani/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/swami-veeramani/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/swami-veeramani/gobblin/releases{/id}","created_at":"2015-06-01T18:41:37Z","updated_at":"2015-06-01T18:41:38Z","pushed_at":"2015-06-03T18:47:45Z","git_url":"git://github.com/swami-veeramani/gobblin.git","ssh_url":"git@github.com:swami-veeramani/gobblin.git","clone_url":"https://github.com/swami-veeramani/gobblin.git","svn_url":"https://github.com/swami-veeramani/gobblin","homepage":null,"size":77116,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"linkedin:master","ref":"master","sha":"1feac0d861950c2e91e7570df0245974c2642f2a","user":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"repo":{"id":27392543,"name":"gobblin","full_name":"linkedin/gobblin","owner":{"login":"linkedin","id":357098,"avatar_url":"https://avatars.githubusercontent.com/u/357098?v=3","gravatar_id":"","url":"https://api.github.com/users/linkedin","html_url":"https://github.com/linkedin","followers_url":"https://api.github.com/users/linkedin/followers","following_url":"https://api.github.com/users/linkedin/following{/other_user}","gists_url":"https://api.github.com/users/linkedin/gists{/gist_id}","starred_url":"https://api.github.com/users/linkedin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkedin/subscriptions","organizations_url":"https://api.github.com/users/linkedin/orgs","repos_url":"https://api.github.com/users/linkedin/repos","events_url":"https://api.github.com/users/linkedin/events{/privacy}","received_events_url":"https://api.github.com/users/linkedin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkedin/gobblin","description":"","fork":false,"url":"https://api.github.com/repos/linkedin/gobblin","forks_url":"https://api.github.com/repos/linkedin/gobblin/forks","keys_url":"https://api.github.com/repos/linkedin/gobblin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkedin/gobblin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkedin/gobblin/teams","hooks_url":"https://api.github.com/repos/linkedin/gobblin/hooks","issue_events_url":"https://api.github.com/repos/linkedin/gobblin/issues/events{/number}","events_url":"https://api.github.com/repos/linkedin/gobblin/events","assignees_url":"https://api.github.com/repos/linkedin/gobblin/assignees{/user}","branches_url":"https://api.github.com/repos/linkedin/gobblin/branches{/branch}","tags_url":"https://api.github.com/repos/linkedin/gobblin/tags","blobs_url":"https://api.github.com/repos/linkedin/gobblin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkedin/gobblin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkedin/gobblin/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkedin/gobblin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkedin/gobblin/statuses/{sha}","languages_url":"https://api.github.com/repos/linkedin/gobblin/languages","stargazers_url":"https://api.github.com/repos/linkedin/gobblin/stargazers","contributors_url":"https://api.github.com/repos/linkedin/gobblin/contributors","subscribers_url":"https://api.github.com/repos/linkedin/gobblin/subscribers","subscription_url":"https://api.github.com/repos/linkedin/gobblin/subscription","commits_url":"https://api.github.com/repos/linkedin/gobblin/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkedin/gobblin/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkedin/gobblin/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkedin/gobblin/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkedin/gobblin/contents/{+path}","compare_url":"https://api.github.com/repos/linkedin/gobblin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkedin/gobblin/merges","archive_url":"https://api.github.com/repos/linkedin/gobblin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkedin/gobblin/downloads","issues_url":"https://api.github.com/repos/linkedin/gobblin/issues{/number}","pulls_url":"https://api.github.com/repos/linkedin/gobblin/pulls{/number}","milestones_url":"https://api.github.com/repos/linkedin/gobblin/milestones{/number}","notifications_url":"https://api.github.com/repos/linkedin/gobblin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkedin/gobblin/labels{/name}","releases_url":"https://api.github.com/repos/linkedin/gobblin/releases{/id}","created_at":"2014-12-01T18:10:50Z","updated_at":"2015-06-03T00:25:50Z","pushed_at":"2015-06-03T18:47:46Z","git_url":"git://github.com/linkedin/gobblin.git","ssh_url":"git@github.com:linkedin/gobblin.git","clone_url":"https://github.com/linkedin/gobblin.git","svn_url":"https://github.com/linkedin/gobblin","homepage":null,"size":157195,"stargazers_count":43,"watchers_count":43,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":4,"forks":28,"open_issues":4,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/153"},"html":{"href":"https://github.com/linkedin/gobblin/pull/153"},"issue":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/153"},"comments":{"href":"https://api.github.com/repos/linkedin/gobblin/issues/153/comments"},"review_comments":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/153/comments"},"review_comment":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkedin/gobblin/pulls/153/commits"},"statuses":{"href":"https://api.github.com/repos/linkedin/gobblin/statuses/f19905f98410de7339308099ecf4fb17e3faf49e"}}}}