{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/buck/pulls/comments/33982552","id":33982552,"diff_hunk":"@@ -0,0 +1,92 @@\n+/*\n+ * Copyright 2015-present Facebook, Inc.\n+ *\n+ * Licensed under the Apache License, Version 2.0 (the \"License\"); you may\n+ * not use this file except in compliance with the License. You may obtain\n+ * a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ */\n+\n+package com.facebook.buck.android;\n+\n+import com.facebook.buck.event.BuckEventBus;\n+import com.facebook.buck.rules.InstallableApk;\n+import com.facebook.buck.step.ExecutionContext;\n+import com.facebook.buck.step.Step;\n+import com.facebook.buck.util.Console;\n+import com.google.common.base.Optional;\n+\n+import com.android.ddmlib.IDevice;\n+\n+public class ApkInstallStep implements Step {\n+\n+  private final InstallableApk installableApk;\n+\n+  public ApkInstallStep(InstallableApk apk) {\n+    this.installableApk = apk;\n+  }\n+\n+  public ApkInstallStep(AndroidInstrumentationApk apk) {\n+    this.installableApk = apk;\n+  }","path":"src/com/facebook/buck/android/ApkInstallStep.java","position":38,"original_position":38,"commit_id":"374da781a56782485481056302114b5a3dc5428a","original_commit_id":"374da781a56782485481056302114b5a3dc5428a","user":{"login":"tgummerer","id":191004,"avatar_url":"https://avatars.githubusercontent.com/u/191004?v=3","gravatar_id":"","url":"https://api.github.com/users/tgummerer","html_url":"https://github.com/tgummerer","followers_url":"https://api.github.com/users/tgummerer/followers","following_url":"https://api.github.com/users/tgummerer/following{/other_user}","gists_url":"https://api.github.com/users/tgummerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgummerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgummerer/subscriptions","organizations_url":"https://api.github.com/users/tgummerer/orgs","repos_url":"https://api.github.com/users/tgummerer/repos","events_url":"https://api.github.com/users/tgummerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgummerer/received_events","type":"User","site_admin":false},"body":"Heh yes, I think just removing the second constructor would work.  Not sure what I was thinking there.  I think I still prefer `InstallableApk` over `AndroidBinary`, as that will cover an `apk_genrule()` as well.","created_at":"2015-07-06T21:08:32Z","updated_at":"2015-07-06T21:08:32Z","html_url":"https://github.com/facebook/buck/pull/368#discussion_r33982552","pull_request_url":"https://api.github.com/repos/facebook/buck/pulls/368","_links":{"self":{"href":"https://api.github.com/repos/facebook/buck/pulls/comments/33982552"},"html":{"href":"https://github.com/facebook/buck/pull/368#discussion_r33982552"},"pull_request":{"href":"https://api.github.com/repos/facebook/buck/pulls/368"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/buck/pulls/368","id":39035580,"html_url":"https://github.com/facebook/buck/pull/368","diff_url":"https://github.com/facebook/buck/pull/368.diff","patch_url":"https://github.com/facebook/buck/pull/368.patch","issue_url":"https://api.github.com/repos/facebook/buck/issues/368","number":368,"state":"open","locked":false,"title":"Android instrumentation test","user":{"login":"tgummerer","id":191004,"avatar_url":"https://avatars.githubusercontent.com/u/191004?v=3","gravatar_id":"","url":"https://api.github.com/users/tgummerer","html_url":"https://github.com/tgummerer","followers_url":"https://api.github.com/users/tgummerer/followers","following_url":"https://api.github.com/users/tgummerer/following{/other_user}","gists_url":"https://api.github.com/users/tgummerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgummerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgummerer/subscriptions","organizations_url":"https://api.github.com/users/tgummerer/orgs","repos_url":"https://api.github.com/users/tgummerer/repos","events_url":"https://api.github.com/users/tgummerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgummerer/received_events","type":"User","site_admin":false},"body":"This is the first version of the android instrumentation test rule, discussed in #305.\r\n\r\nThe first commit (786c1ab) is the same as in #358, and is included here, because removing it would cause some conflicts.\r\n\r\nI'm not sure about the 2nd and 3rd commit, (ba95887 and 207fcca).  Those changes are so `android_instrumentation_test` doesn't post any output, but I'm not sure whether that is required or not for the tests.\r\n\r\nThe pull request is also still missing a documentation update, which I'm still working on.  There are also no new tests, but I don't know how to add them, as all parts have different behaviour with attached devices vs. no attached devices.","created_at":"2015-07-01T23:30:27Z","updated_at":"2015-07-06T21:08:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae84abd924f436c342e7b00d39042b95d7018862","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/buck/pulls/368/commits","review_comments_url":"https://api.github.com/repos/facebook/buck/pulls/368/comments","review_comment_url":"https://api.github.com/repos/facebook/buck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/buck/issues/368/comments","statuses_url":"https://api.github.com/repos/facebook/buck/statuses/374da781a56782485481056302114b5a3dc5428a","head":{"label":"tgummerer:android-instrumentation-test","ref":"android-instrumentation-test","sha":"374da781a56782485481056302114b5a3dc5428a","user":{"login":"tgummerer","id":191004,"avatar_url":"https://avatars.githubusercontent.com/u/191004?v=3","gravatar_id":"","url":"https://api.github.com/users/tgummerer","html_url":"https://github.com/tgummerer","followers_url":"https://api.github.com/users/tgummerer/followers","following_url":"https://api.github.com/users/tgummerer/following{/other_user}","gists_url":"https://api.github.com/users/tgummerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgummerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgummerer/subscriptions","organizations_url":"https://api.github.com/users/tgummerer/orgs","repos_url":"https://api.github.com/users/tgummerer/repos","events_url":"https://api.github.com/users/tgummerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgummerer/received_events","type":"User","site_admin":false},"repo":{"id":35726556,"name":"buck","full_name":"tgummerer/buck","owner":{"login":"tgummerer","id":191004,"avatar_url":"https://avatars.githubusercontent.com/u/191004?v=3","gravatar_id":"","url":"https://api.github.com/users/tgummerer","html_url":"https://github.com/tgummerer","followers_url":"https://api.github.com/users/tgummerer/followers","following_url":"https://api.github.com/users/tgummerer/following{/other_user}","gists_url":"https://api.github.com/users/tgummerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgummerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgummerer/subscriptions","organizations_url":"https://api.github.com/users/tgummerer/orgs","repos_url":"https://api.github.com/users/tgummerer/repos","events_url":"https://api.github.com/users/tgummerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgummerer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tgummerer/buck","description":"A build system that encourages the creation of small, reusable modules.","fork":true,"url":"https://api.github.com/repos/tgummerer/buck","forks_url":"https://api.github.com/repos/tgummerer/buck/forks","keys_url":"https://api.github.com/repos/tgummerer/buck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tgummerer/buck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tgummerer/buck/teams","hooks_url":"https://api.github.com/repos/tgummerer/buck/hooks","issue_events_url":"https://api.github.com/repos/tgummerer/buck/issues/events{/number}","events_url":"https://api.github.com/repos/tgummerer/buck/events","assignees_url":"https://api.github.com/repos/tgummerer/buck/assignees{/user}","branches_url":"https://api.github.com/repos/tgummerer/buck/branches{/branch}","tags_url":"https://api.github.com/repos/tgummerer/buck/tags","blobs_url":"https://api.github.com/repos/tgummerer/buck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tgummerer/buck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tgummerer/buck/git/refs{/sha}","trees_url":"https://api.github.com/repos/tgummerer/buck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tgummerer/buck/statuses/{sha}","languages_url":"https://api.github.com/repos/tgummerer/buck/languages","stargazers_url":"https://api.github.com/repos/tgummerer/buck/stargazers","contributors_url":"https://api.github.com/repos/tgummerer/buck/contributors","subscribers_url":"https://api.github.com/repos/tgummerer/buck/subscribers","subscription_url":"https://api.github.com/repos/tgummerer/buck/subscription","commits_url":"https://api.github.com/repos/tgummerer/buck/commits{/sha}","git_commits_url":"https://api.github.com/repos/tgummerer/buck/git/commits{/sha}","comments_url":"https://api.github.com/repos/tgummerer/buck/comments{/number}","issue_comment_url":"https://api.github.com/repos/tgummerer/buck/issues/comments{/number}","contents_url":"https://api.github.com/repos/tgummerer/buck/contents/{+path}","compare_url":"https://api.github.com/repos/tgummerer/buck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tgummerer/buck/merges","archive_url":"https://api.github.com/repos/tgummerer/buck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tgummerer/buck/downloads","issues_url":"https://api.github.com/repos/tgummerer/buck/issues{/number}","pulls_url":"https://api.github.com/repos/tgummerer/buck/pulls{/number}","milestones_url":"https://api.github.com/repos/tgummerer/buck/milestones{/number}","notifications_url":"https://api.github.com/repos/tgummerer/buck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tgummerer/buck/labels{/name}","releases_url":"https://api.github.com/repos/tgummerer/buck/releases{/id}","created_at":"2015-05-16T14:22:35Z","updated_at":"2015-05-16T14:22:42Z","pushed_at":"2015-07-02T22:45:28Z","git_url":"git://github.com/tgummerer/buck.git","ssh_url":"git@github.com:tgummerer/buck.git","clone_url":"https://github.com/tgummerer/buck.git","svn_url":"https://github.com/tgummerer/buck","homepage":"http://facebook.github.io/buck/","size":261310,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"b3e7ec19f083c29a75693be96e14612059555267","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":9504214,"name":"buck","full_name":"facebook/buck","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/buck","description":"A build system that encourages the creation of small, reusable modules.","fork":false,"url":"https://api.github.com/repos/facebook/buck","forks_url":"https://api.github.com/repos/facebook/buck/forks","keys_url":"https://api.github.com/repos/facebook/buck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/buck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/buck/teams","hooks_url":"https://api.github.com/repos/facebook/buck/hooks","issue_events_url":"https://api.github.com/repos/facebook/buck/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/buck/events","assignees_url":"https://api.github.com/repos/facebook/buck/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/buck/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/buck/tags","blobs_url":"https://api.github.com/repos/facebook/buck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/buck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/buck/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/buck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/buck/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/buck/languages","stargazers_url":"https://api.github.com/repos/facebook/buck/stargazers","contributors_url":"https://api.github.com/repos/facebook/buck/contributors","subscribers_url":"https://api.github.com/repos/facebook/buck/subscribers","subscription_url":"https://api.github.com/repos/facebook/buck/subscription","commits_url":"https://api.github.com/repos/facebook/buck/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/buck/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/buck/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/buck/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/buck/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/buck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/buck/merges","archive_url":"https://api.github.com/repos/facebook/buck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/buck/downloads","issues_url":"https://api.github.com/repos/facebook/buck/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/buck/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/buck/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/buck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/buck/labels{/name}","releases_url":"https://api.github.com/repos/facebook/buck/releases{/id}","created_at":"2013-04-17T18:12:18Z","updated_at":"2015-07-06T12:56:34Z","pushed_at":"2015-07-06T21:06:52Z","git_url":"git://github.com/facebook/buck.git","ssh_url":"git@github.com:facebook/buck.git","clone_url":"https://github.com/facebook/buck.git","svn_url":"https://github.com/facebook/buck","homepage":"http://buckbuild.com","size":268795,"stargazers_count":1462,"watchers_count":1462,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":254,"mirror_url":null,"open_issues_count":55,"forks":254,"open_issues":55,"watchers":1462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/buck/pulls/368"},"html":{"href":"https://github.com/facebook/buck/pull/368"},"issue":{"href":"https://api.github.com/repos/facebook/buck/issues/368"},"comments":{"href":"https://api.github.com/repos/facebook/buck/issues/368/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/buck/pulls/368/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/buck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/buck/pulls/368/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/buck/statuses/374da781a56782485481056302114b5a3dc5428a"}}}}