{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/suse-xsl/issues/96","labels_url":"https://api.github.com/repos/openSUSE/suse-xsl/issues/96/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/suse-xsl/issues/96/comments","events_url":"https://api.github.com/repos/openSUSE/suse-xsl/issues/96/events","html_url":"https://github.com/openSUSE/suse-xsl/issues/96","id":116595628,"number":96,"title":"Remove the SUSE address from the stylesheets themselves","user":{"login":"sknorr","id":5476547,"avatar_url":"https://avatars.githubusercontent.com/u/5476547?v=3","gravatar_id":"","url":"https://api.github.com/users/sknorr","html_url":"https://github.com/sknorr","followers_url":"https://api.github.com/users/sknorr/followers","following_url":"https://api.github.com/users/sknorr/following{/other_user}","gists_url":"https://api.github.com/users/sknorr/gists{/gist_id}","starred_url":"https://api.github.com/users/sknorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sknorr/subscriptions","organizations_url":"https://api.github.com/users/sknorr/orgs","repos_url":"https://api.github.com/users/sknorr/repos","events_url":"https://api.github.com/users/sknorr/events{/privacy}","received_events_url":"https://api.github.com/users/sknorr/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/openSUSE/suse-xsl/labels/bug","name":"bug","color":"B70736"},{"url":"https://api.github.com/repos/openSUSE/suse-xsl/labels/pdf","name":"pdf","color":"d4c5f9"},{"url":"https://api.github.com/repos/openSUSE/suse-xsl/labels/suse2013","name":"suse2013","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-12T17:13:32Z","updated_at":"2015-11-13T10:08:55Z","closed_at":null,"body":"Currently, the address of SUSE is added to our PDF books through the stylesheets. Hindsight 20/20 says this is a dumb idea:\r\n-   If someone else wants to use our stylesheets, they automatically get a SUSE address in there\r\n-   If SUSE's address changes, we have to get a new stylesheets package out instead of being able to fix the affected books (see issue #34 and [bsc#929630](https://bugzilla.suse.com/show_bug.cgi?id=929630))\r\n\r\nIf we want to keep the address, it might be good to look at two possible solutions:\r\n\r\n1.  DB5's `<address/>` element (see [TDG](http://docbook.org/tdg5/en/html/address.html)), nested within the `<info/>` element of the set or book. The only drawback I see is that the `<address/>` element is usually formatted verbatim (a bit undesirable for formatting reasons). Also, I am not sure if that address is automatically output then somewhere (undesirable, but we can obviously work around that in the stylesheets).\r\n1.  Use the DocManager to roll our own solution."},"comment":{"url":"https://api.github.com/repos/openSUSE/suse-xsl/issues/comments/156384551","html_url":"https://github.com/openSUSE/suse-xsl/issues/96#issuecomment-156384551","issue_url":"https://api.github.com/repos/openSUSE/suse-xsl/issues/96","id":156384551,"user":{"login":"sknorr","id":5476547,"avatar_url":"https://avatars.githubusercontent.com/u/5476547?v=3","gravatar_id":"","url":"https://api.github.com/users/sknorr","html_url":"https://github.com/sknorr","followers_url":"https://api.github.com/users/sknorr/followers","following_url":"https://api.github.com/users/sknorr/following{/other_user}","gists_url":"https://api.github.com/users/sknorr/gists{/gist_id}","starred_url":"https://api.github.com/users/sknorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sknorr/subscriptions","organizations_url":"https://api.github.com/users/sknorr/orgs","repos_url":"https://api.github.com/users/sknorr/repos","events_url":"https://api.github.com/users/sknorr/events{/privacy}","received_events_url":"https://api.github.com/users/sknorr/received_events","type":"User","site_admin":false},"created_at":"2015-11-13T10:08:55Z","updated_at":"2015-11-13T10:08:55Z","body":"The parameter? That is true, however, parameters always feel a bit volatile, since it is so easy to forget/accidentally remove them.\r\n\r\nI think it is also a bit of coding hygiene. And after thinking about it and seeing the issues with our current approach, I think the books are the best place for this.\r\n\r\nSure, we also have SUSE logos in our stylesheets, but I think the more we can put in the books themselves, the better, right?"}}