{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/23631278","id":23631278,"diff_hunk":"@@ -283,6 +283,8 @@ type LivenessProbe struct {\n \tExec *ExecAction `json:\"exec,omitempty\"`\n \t// Length of time before health checking is activated.  In seconds.\n \tInitialDelaySeconds int64 `json:\"initialDelaySeconds,omitempty\"`\n+\t// Length of time before health checking times out.  In seconds.\n+\tTimeoutSecs int64 `json:\"timeoutSecs,omitempty\"`","path":"pkg/api/types.go","position":5,"original_position":5,"commit_id":"273283da83c9a84dcf28fc0062f72a0f0d96c389","original_commit_id":"8d27529d873c88975f577d5fce4173b57a9f068a","user":{"login":"bgrant0607","id":7725777,"avatar_url":"https://avatars.githubusercontent.com/u/7725777?v=3","gravatar_id":"","url":"https://api.github.com/users/bgrant0607","html_url":"https://github.com/bgrant0607","followers_url":"https://api.github.com/users/bgrant0607/followers","following_url":"https://api.github.com/users/bgrant0607/following{/other_user}","gists_url":"https://api.github.com/users/bgrant0607/gists{/gist_id}","starred_url":"https://api.github.com/users/bgrant0607/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgrant0607/subscriptions","organizations_url":"https://api.github.com/users/bgrant0607/orgs","repos_url":"https://api.github.com/users/bgrant0607/repos","events_url":"https://api.github.com/users/bgrant0607/events{/privacy}","received_events_url":"https://api.github.com/users/bgrant0607/received_events","type":"User","site_admin":false},"body":"We're not going to probe, kill, and restart a container in less than a second. That could lead to all sorts of problems. Seconds seems fine.\r\n\r\nSeconds should be spelled out. ","created_at":"2015-01-27T18:44:46Z","updated_at":"2015-01-27T18:44:46Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3593#discussion_r23631278","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/23631278"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3593#discussion_r23631278"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593","id":27552349,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3593","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3593.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3593.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3593","number":3593,"state":"open","locked":false,"title":"Add timeouts to HealthChecks and retry checks","user":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"body":"Fixes issue #3532. Added timeouts for HTTP and TCP checks\r\nand enabled HealthCheck to check health#maxRetries times\r\nbefore declaring Unhealthy.","created_at":"2015-01-17T05:12:24Z","updated_at":"2015-01-27T18:44:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0512de18bbd1c1e049ede8ff139ccb09f1a98605","assignee":{"login":"thockin","id":5595220,"avatar_url":"https://avatars.githubusercontent.com/u/5595220?v=3","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3593/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/273283da83c9a84dcf28fc0062f72a0f0d96c389","head":{"label":"commonlisp:master","ref":"master","sha":"273283da83c9a84dcf28fc0062f72a0f0d96c389","user":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"repo":{"id":27325550,"name":"kubernetes","full_name":"commonlisp/kubernetes","owner":{"login":"commonlisp","id":1171230,"avatar_url":"https://avatars.githubusercontent.com/u/1171230?v=3","gravatar_id":"","url":"https://api.github.com/users/commonlisp","html_url":"https://github.com/commonlisp","followers_url":"https://api.github.com/users/commonlisp/followers","following_url":"https://api.github.com/users/commonlisp/following{/other_user}","gists_url":"https://api.github.com/users/commonlisp/gists{/gist_id}","starred_url":"https://api.github.com/users/commonlisp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/commonlisp/subscriptions","organizations_url":"https://api.github.com/users/commonlisp/orgs","repos_url":"https://api.github.com/users/commonlisp/repos","events_url":"https://api.github.com/users/commonlisp/events{/privacy}","received_events_url":"https://api.github.com/users/commonlisp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/commonlisp/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/commonlisp/kubernetes","forks_url":"https://api.github.com/repos/commonlisp/kubernetes/forks","keys_url":"https://api.github.com/repos/commonlisp/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/commonlisp/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/commonlisp/kubernetes/teams","hooks_url":"https://api.github.com/repos/commonlisp/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/commonlisp/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/commonlisp/kubernetes/events","assignees_url":"https://api.github.com/repos/commonlisp/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/commonlisp/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/commonlisp/kubernetes/tags","blobs_url":"https://api.github.com/repos/commonlisp/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/commonlisp/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/commonlisp/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/commonlisp/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/commonlisp/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/commonlisp/kubernetes/languages","stargazers_url":"https://api.github.com/repos/commonlisp/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/commonlisp/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/commonlisp/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/commonlisp/kubernetes/subscription","commits_url":"https://api.github.com/repos/commonlisp/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/commonlisp/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/commonlisp/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/commonlisp/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/commonlisp/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/commonlisp/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/commonlisp/kubernetes/merges","archive_url":"https://api.github.com/repos/commonlisp/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/commonlisp/kubernetes/downloads","issues_url":"https://api.github.com/repos/commonlisp/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/commonlisp/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/commonlisp/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/commonlisp/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/commonlisp/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/commonlisp/kubernetes/releases{/id}","created_at":"2014-11-30T05:24:35Z","updated_at":"2015-01-27T04:58:52Z","pushed_at":"2015-01-27T04:58:52Z","git_url":"git://github.com/commonlisp/kubernetes.git","ssh_url":"git@github.com:commonlisp/kubernetes.git","clone_url":"https://github.com/commonlisp/kubernetes.git","svn_url":"https://github.com/commonlisp/kubernetes","homepage":null,"size":24736,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"d78d3e69c3774f7b50bf197c546adcde6e52a8bd","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments/{number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-01-27T18:27:17Z","pushed_at":"2015-01-27T18:09:06Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":62818,"stargazers_count":5927,"watchers_count":5927,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":997,"mirror_url":null,"open_issues_count":638,"forks":997,"open_issues":638,"watchers":5927,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/3593"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3593"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/3593/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/3593/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/273283da83c9a84dcf28fc0062f72a0f0d96c389"}}}}