{"action":"created","comment":{"url":"https://api.github.com/repos/python-excel/xlrd/pulls/comments/46750186","id":46750186,"diff_hunk":"@@ -14,6 +14,13 @@ def setUp(self):\n         self.book = xlrd.open_workbook(from_this_dir('profiles.xls'), formatting_info=True)\r\n         self.sheet = self.book.sheet_by_name('PROFILEDEF')\r\n         \r\n+    def test_empty_cell(self):\r\n+        sheet = self.book.sheet_by_name('TRAVERSALCHAINAGE')\r\n+        cell = sheet.cell(0, 0)\r\n+        self.assertEqual(cell.ctype, xlrd.book.XL_CELL_EMPTY)\r\n+        self.assertEqual(cell.value, '')\r","path":"tests/test_cell.py","position":8,"original_position":8,"commit_id":"28e806951f0889bafae697c88aa12e8a0ec134ad","original_commit_id":"28e806951f0889bafae697c88aa12e8a0ec134ad","user":{"login":"vadmium","id":1024659,"avatar_url":"https://avatars.githubusercontent.com/u/1024659?v=3","gravatar_id":"","url":"https://api.github.com/users/vadmium","html_url":"https://github.com/vadmium","followers_url":"https://api.github.com/users/vadmium/followers","following_url":"https://api.github.com/users/vadmium/following{/other_user}","gists_url":"https://api.github.com/users/vadmium/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmium/subscriptions","organizations_url":"https://api.github.com/users/vadmium/orgs","repos_url":"https://api.github.com/users/vadmium/repos","events_url":"https://api.github.com/users/vadmium/events{/privacy}","received_events_url":"https://api.github.com/users/vadmium/received_events","type":"User","site_admin":false},"body":"Maybe I’m missing something, but isn’t comparing to an empty string ('') in Python 2 going to succeed for either kind of string? If you need to ensure it is a Unicode string maybe you should also do self.assertIsInstance(cell.value, unicode), or whatever the time machine equivalent is.","created_at":"2015-12-05T01:03:12Z","updated_at":"2015-12-05T01:03:12Z","html_url":"https://github.com/python-excel/xlrd/pull/160#discussion_r46750186","pull_request_url":"https://api.github.com/repos/python-excel/xlrd/pulls/160","_links":{"self":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/comments/46750186"},"html":{"href":"https://github.com/python-excel/xlrd/pull/160#discussion_r46750186"},"pull_request":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/160"}}},"pull_request":{"url":"https://api.github.com/repos/python-excel/xlrd/pulls/160","id":52679940,"html_url":"https://github.com/python-excel/xlrd/pull/160","diff_url":"https://github.com/python-excel/xlrd/pull/160.diff","patch_url":"https://github.com/python-excel/xlrd/pull/160.patch","issue_url":"https://api.github.com/repos/python-excel/xlrd/issues/160","number":160,"state":"closed","locked":false,"title":"Add test case for empty cell #159","user":{"login":"vog","id":412749,"avatar_url":"https://avatars.githubusercontent.com/u/412749?v=3","gravatar_id":"","url":"https://api.github.com/users/vog","html_url":"https://github.com/vog","followers_url":"https://api.github.com/users/vog/followers","following_url":"https://api.github.com/users/vog/following{/other_user}","gists_url":"https://api.github.com/users/vog/gists{/gist_id}","starred_url":"https://api.github.com/users/vog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vog/subscriptions","organizations_url":"https://api.github.com/users/vog/orgs","repos_url":"https://api.github.com/users/vog/repos","events_url":"https://api.github.com/users/vog/events{/privacy}","received_events_url":"https://api.github.com/users/vog/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-04T15:09:16Z","updated_at":"2015-12-05T01:03:12Z","closed_at":"2015-12-04T15:42:56Z","merged_at":"2015-12-04T15:42:56Z","merge_commit_sha":"6ac6cd2d4b29cd13013615f608d76f41058b8553","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/python-excel/xlrd/pulls/160/commits","review_comments_url":"https://api.github.com/repos/python-excel/xlrd/pulls/160/comments","review_comment_url":"https://api.github.com/repos/python-excel/xlrd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-excel/xlrd/issues/160/comments","statuses_url":"https://api.github.com/repos/python-excel/xlrd/statuses/28e806951f0889bafae697c88aa12e8a0ec134ad","head":{"label":"m-click:add_test_empty_cell","ref":"add_test_empty_cell","sha":"28e806951f0889bafae697c88aa12e8a0ec134ad","user":{"login":"m-click","id":1712981,"avatar_url":"https://avatars.githubusercontent.com/u/1712981?v=3","gravatar_id":"","url":"https://api.github.com/users/m-click","html_url":"https://github.com/m-click","followers_url":"https://api.github.com/users/m-click/followers","following_url":"https://api.github.com/users/m-click/following{/other_user}","gists_url":"https://api.github.com/users/m-click/gists{/gist_id}","starred_url":"https://api.github.com/users/m-click/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-click/subscriptions","organizations_url":"https://api.github.com/users/m-click/orgs","repos_url":"https://api.github.com/users/m-click/repos","events_url":"https://api.github.com/users/m-click/events{/privacy}","received_events_url":"https://api.github.com/users/m-click/received_events","type":"Organization","site_admin":false},"repo":{"id":47410656,"name":"xlrd","full_name":"m-click/xlrd","owner":{"login":"m-click","id":1712981,"avatar_url":"https://avatars.githubusercontent.com/u/1712981?v=3","gravatar_id":"","url":"https://api.github.com/users/m-click","html_url":"https://github.com/m-click","followers_url":"https://api.github.com/users/m-click/followers","following_url":"https://api.github.com/users/m-click/following{/other_user}","gists_url":"https://api.github.com/users/m-click/gists{/gist_id}","starred_url":"https://api.github.com/users/m-click/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-click/subscriptions","organizations_url":"https://api.github.com/users/m-click/orgs","repos_url":"https://api.github.com/users/m-click/repos","events_url":"https://api.github.com/users/m-click/events{/privacy}","received_events_url":"https://api.github.com/users/m-click/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m-click/xlrd","description":"Library for developers to extract data from Microsoft Excel (tm) spreadsheet files","fork":true,"url":"https://api.github.com/repos/m-click/xlrd","forks_url":"https://api.github.com/repos/m-click/xlrd/forks","keys_url":"https://api.github.com/repos/m-click/xlrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m-click/xlrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m-click/xlrd/teams","hooks_url":"https://api.github.com/repos/m-click/xlrd/hooks","issue_events_url":"https://api.github.com/repos/m-click/xlrd/issues/events{/number}","events_url":"https://api.github.com/repos/m-click/xlrd/events","assignees_url":"https://api.github.com/repos/m-click/xlrd/assignees{/user}","branches_url":"https://api.github.com/repos/m-click/xlrd/branches{/branch}","tags_url":"https://api.github.com/repos/m-click/xlrd/tags","blobs_url":"https://api.github.com/repos/m-click/xlrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m-click/xlrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m-click/xlrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/m-click/xlrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m-click/xlrd/statuses/{sha}","languages_url":"https://api.github.com/repos/m-click/xlrd/languages","stargazers_url":"https://api.github.com/repos/m-click/xlrd/stargazers","contributors_url":"https://api.github.com/repos/m-click/xlrd/contributors","subscribers_url":"https://api.github.com/repos/m-click/xlrd/subscribers","subscription_url":"https://api.github.com/repos/m-click/xlrd/subscription","commits_url":"https://api.github.com/repos/m-click/xlrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/m-click/xlrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/m-click/xlrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/m-click/xlrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/m-click/xlrd/contents/{+path}","compare_url":"https://api.github.com/repos/m-click/xlrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m-click/xlrd/merges","archive_url":"https://api.github.com/repos/m-click/xlrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m-click/xlrd/downloads","issues_url":"https://api.github.com/repos/m-click/xlrd/issues{/number}","pulls_url":"https://api.github.com/repos/m-click/xlrd/pulls{/number}","milestones_url":"https://api.github.com/repos/m-click/xlrd/milestones{/number}","notifications_url":"https://api.github.com/repos/m-click/xlrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m-click/xlrd/labels{/name}","releases_url":"https://api.github.com/repos/m-click/xlrd/releases{/id}","created_at":"2015-12-04T15:04:34Z","updated_at":"2015-12-04T15:04:35Z","pushed_at":"2015-12-04T18:47:20Z","git_url":"git://github.com/m-click/xlrd.git","ssh_url":"git@github.com:m-click/xlrd.git","clone_url":"https://github.com/m-click/xlrd.git","svn_url":"https://github.com/m-click/xlrd","homepage":"http://www.python-excel.org/","size":2869,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"python-excel:master","ref":"master","sha":"6e077d6ca7afba0b66a6f3809d464c21a8ecde4c","user":{"login":"python-excel","id":1507022,"avatar_url":"https://avatars.githubusercontent.com/u/1507022?v=3","gravatar_id":"","url":"https://api.github.com/users/python-excel","html_url":"https://github.com/python-excel","followers_url":"https://api.github.com/users/python-excel/followers","following_url":"https://api.github.com/users/python-excel/following{/other_user}","gists_url":"https://api.github.com/users/python-excel/gists{/gist_id}","starred_url":"https://api.github.com/users/python-excel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-excel/subscriptions","organizations_url":"https://api.github.com/users/python-excel/orgs","repos_url":"https://api.github.com/users/python-excel/repos","events_url":"https://api.github.com/users/python-excel/events{/privacy}","received_events_url":"https://api.github.com/users/python-excel/received_events","type":"Organization","site_admin":false},"repo":{"id":3645885,"name":"xlrd","full_name":"python-excel/xlrd","owner":{"login":"python-excel","id":1507022,"avatar_url":"https://avatars.githubusercontent.com/u/1507022?v=3","gravatar_id":"","url":"https://api.github.com/users/python-excel","html_url":"https://github.com/python-excel","followers_url":"https://api.github.com/users/python-excel/followers","following_url":"https://api.github.com/users/python-excel/following{/other_user}","gists_url":"https://api.github.com/users/python-excel/gists{/gist_id}","starred_url":"https://api.github.com/users/python-excel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-excel/subscriptions","organizations_url":"https://api.github.com/users/python-excel/orgs","repos_url":"https://api.github.com/users/python-excel/repos","events_url":"https://api.github.com/users/python-excel/events{/privacy}","received_events_url":"https://api.github.com/users/python-excel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-excel/xlrd","description":"Library for developers to extract data from Microsoft Excel (tm) spreadsheet files","fork":false,"url":"https://api.github.com/repos/python-excel/xlrd","forks_url":"https://api.github.com/repos/python-excel/xlrd/forks","keys_url":"https://api.github.com/repos/python-excel/xlrd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-excel/xlrd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-excel/xlrd/teams","hooks_url":"https://api.github.com/repos/python-excel/xlrd/hooks","issue_events_url":"https://api.github.com/repos/python-excel/xlrd/issues/events{/number}","events_url":"https://api.github.com/repos/python-excel/xlrd/events","assignees_url":"https://api.github.com/repos/python-excel/xlrd/assignees{/user}","branches_url":"https://api.github.com/repos/python-excel/xlrd/branches{/branch}","tags_url":"https://api.github.com/repos/python-excel/xlrd/tags","blobs_url":"https://api.github.com/repos/python-excel/xlrd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-excel/xlrd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-excel/xlrd/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-excel/xlrd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-excel/xlrd/statuses/{sha}","languages_url":"https://api.github.com/repos/python-excel/xlrd/languages","stargazers_url":"https://api.github.com/repos/python-excel/xlrd/stargazers","contributors_url":"https://api.github.com/repos/python-excel/xlrd/contributors","subscribers_url":"https://api.github.com/repos/python-excel/xlrd/subscribers","subscription_url":"https://api.github.com/repos/python-excel/xlrd/subscription","commits_url":"https://api.github.com/repos/python-excel/xlrd/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-excel/xlrd/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-excel/xlrd/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-excel/xlrd/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-excel/xlrd/contents/{+path}","compare_url":"https://api.github.com/repos/python-excel/xlrd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-excel/xlrd/merges","archive_url":"https://api.github.com/repos/python-excel/xlrd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-excel/xlrd/downloads","issues_url":"https://api.github.com/repos/python-excel/xlrd/issues{/number}","pulls_url":"https://api.github.com/repos/python-excel/xlrd/pulls{/number}","milestones_url":"https://api.github.com/repos/python-excel/xlrd/milestones{/number}","notifications_url":"https://api.github.com/repos/python-excel/xlrd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-excel/xlrd/labels{/name}","releases_url":"https://api.github.com/repos/python-excel/xlrd/releases{/id}","created_at":"2012-03-07T04:50:48Z","updated_at":"2015-12-04T01:09:27Z","pushed_at":"2015-12-04T18:47:20Z","git_url":"git://github.com/python-excel/xlrd.git","ssh_url":"git@github.com:python-excel/xlrd.git","clone_url":"https://github.com/python-excel/xlrd.git","svn_url":"https://github.com/python-excel/xlrd","homepage":"http://www.python-excel.org/","size":3177,"stargazers_count":647,"watchers_count":647,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":50,"forks":168,"open_issues":50,"watchers":647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/160"},"html":{"href":"https://github.com/python-excel/xlrd/pull/160"},"issue":{"href":"https://api.github.com/repos/python-excel/xlrd/issues/160"},"comments":{"href":"https://api.github.com/repos/python-excel/xlrd/issues/160/comments"},"review_comments":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/160/comments"},"review_comment":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-excel/xlrd/pulls/160/commits"},"statuses":{"href":"https://api.github.com/repos/python-excel/xlrd/statuses/28e806951f0889bafae697c88aa12e8a0ec134ad"}}}}