{"action":"created","issue":{"url":"https://api.github.com/repos/jghibiki/mopey/issues/61","labels_url":"https://api.github.com/repos/jghibiki/mopey/issues/61/labels{/name}","comments_url":"https://api.github.com/repos/jghibiki/mopey/issues/61/comments","events_url":"https://api.github.com/repos/jghibiki/mopey/issues/61/events","html_url":"https://github.com/jghibiki/mopey/issues/61","id":102164886,"number":61,"title":"Service Code Review","user":{"login":"jghibiki","id":6537066,"avatar_url":"https://avatars.githubusercontent.com/u/6537066?v=3","gravatar_id":"","url":"https://api.github.com/users/jghibiki","html_url":"https://github.com/jghibiki","followers_url":"https://api.github.com/users/jghibiki/followers","following_url":"https://api.github.com/users/jghibiki/following{/other_user}","gists_url":"https://api.github.com/users/jghibiki/gists{/gist_id}","starred_url":"https://api.github.com/users/jghibiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jghibiki/subscriptions","organizations_url":"https://api.github.com/users/jghibiki/orgs","repos_url":"https://api.github.com/users/jghibiki/repos","events_url":"https://api.github.com/users/jghibiki/events{/privacy}","received_events_url":"https://api.github.com/users/jghibiki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-20T15:25:32Z","updated_at":"2015-08-20T15:25:56Z","closed_at":null,"body":"- [ ] Break logic out into methods instead of one giant loop of code. Makes the code much more readable.\r\n\r\n---------------------------------------\r\n\r\n- [ ] Additionally, all fun and games aside ```DJPon3``` is not an appropriate name for variables and there are no ```turntables```. ```SYSTEM``` would be a logical username and would help prevent admins from tampering with it without instruction not to. Any justification for why we would leave ```DJPon3```?\r\n\r\n--------------------------------------------\r\n\r\n- [ ] What is the purpose of the ```sys.stdout.flush()``` I don't have a problem with it as long as it doesn't mess with the docker-compose logging, and by that I mean creates large gaps that you have to scroll past because it is the equivalent of calling ```clear``` in a terminal.\r\n\r\n------------------------------------------------------\r\n\r\n- [ ] There is the issue #59 which needs to be fixed as it could be a pretty simple but irritating bug when the timing issue happens.\r\n\r\n-------------------------------------------------------------\r\n\r\n- [ ] Try to use comments that actually help others - not just yourself - figure out what went wrong:\r\n```python\r\nprint \"Token verification failed, retrieving new token\"\r\n```\r\ninstead of \r\n``` python\r\nprint \"DJPon3's turntable broke down. fixing...\"\r\n```\r\n\r\n------------------------------------------------------------------------\r\n\r\n- [ ] [This call](https://github.com/jghibiki/mopey/blob/master/service/src/Service.py#L31) should be placed right after receiving the api token as there are currently several api calls that in the future will likely require an admin.\r\n\r\n------------------------------------------------------------------------------\r\n\r\n- [ ] issue #60 "},"comment":{"url":"https://api.github.com/repos/jghibiki/mopey/issues/comments/133049041","html_url":"https://github.com/jghibiki/mopey/issues/61#issuecomment-133049041","issue_url":"https://api.github.com/repos/jghibiki/mopey/issues/61","id":133049041,"user":{"login":"jghibiki","id":6537066,"avatar_url":"https://avatars.githubusercontent.com/u/6537066?v=3","gravatar_id":"","url":"https://api.github.com/users/jghibiki","html_url":"https://github.com/jghibiki","followers_url":"https://api.github.com/users/jghibiki/followers","following_url":"https://api.github.com/users/jghibiki/following{/other_user}","gists_url":"https://api.github.com/users/jghibiki/gists{/gist_id}","starred_url":"https://api.github.com/users/jghibiki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jghibiki/subscriptions","organizations_url":"https://api.github.com/users/jghibiki/orgs","repos_url":"https://api.github.com/users/jghibiki/repos","events_url":"https://api.github.com/users/jghibiki/events{/privacy}","received_events_url":"https://api.github.com/users/jghibiki/received_events","type":"User","site_admin":false},"created_at":"2015-08-20T15:25:56Z","updated_at":"2015-08-20T15:25:56Z","body":"As each issue is resolved i will check it off."}}