{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-ora2/issues/768","labels_url":"https://api.github.com/repos/edx/edx-ora2/issues/768/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-ora2/issues/768/comments","events_url":"https://api.github.com/repos/edx/edx-ora2/issues/768/events","html_url":"https://github.com/edx/edx-ora2/pull/768","id":116593176,"number":768,"title":"Staff assessment api test additions","user":{"login":"efischer19","id":7373924,"avatar_url":"https://avatars.githubusercontent.com/u/7373924?v=3","gravatar_id":"","url":"https://api.github.com/users/efischer19","html_url":"https://github.com/efischer19","followers_url":"https://api.github.com/users/efischer19/followers","following_url":"https://api.github.com/users/efischer19/following{/other_user}","gists_url":"https://api.github.com/users/efischer19/gists{/gist_id}","starred_url":"https://api.github.com/users/efischer19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efischer19/subscriptions","organizations_url":"https://api.github.com/users/efischer19/orgs","repos_url":"https://api.github.com/users/efischer19/repos","events_url":"https://api.github.com/users/efischer19/events{/privacy}","received_events_url":"https://api.github.com/users/efischer19/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-12T17:02:00Z","updated_at":"2015-11-12T19:49:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-ora2/pulls/768","html_url":"https://github.com/edx/edx-ora2/pull/768","diff_url":"https://github.com/edx/edx-ora2/pull/768.diff","patch_url":"https://github.com/edx/edx-ora2/pull/768.patch"},"body":"Increasing test coverage. Making this a separate PR so as not to interfere with ongoing review. I won't be changing behavior in any way, just writing some tests based on the following:\r\n\r\n| Name | Stmts | Miss | Branch | Branch Misses | Cover | Missing |\r\n|---|---|---|---|---|---|---|\r\n| staff_assessment_mixin | 56 | 17 | 8 | 0 | 73% | 81-89, 99-112 |\r\n| api.staff | 60 | ~~21~~ 0 | 6 | ~~1~~ 0 | ~~67~~ ~~70~~ ~~82~~ 100% | ~~58~~, ~~120-126~~, ~~157-160~~, ~~223-~~~~231-236~~ |\r\n| workflow.models | 257 | 19 | 98 | 15 | 90% | 247-248, 357-361, 442, 474-475, 517-521, 544-549, 711, 718 |\r\n\r\nAttack plan:\r\n* ~~staff api~~:\r\n  * ~~add a staff grade required test~~ or two\r\n  * ~~add invalid rubric and invalid rubric selection tests~~\r\n  * ~~mock out some database error~~\r\n    * ~~get latest staff assessment~~\r\n    * ~~get scores by criteria~~\r\n    * ~~create_assessment~~\r\n* staff mixin:\r\n  * leave for later front-end tests\r\n* workflow models:\r\n  * get_score and skip over non-existent staff assessment\r\n  * staff_score_exists True, somehow\r\n  * something about get_score not getting a staff score #248\r\n  * backwards-compatible mock None #357-361\r\n  * non related, but could get us to 100% coverage:\r\n    * cancel workflow that already has score\r\n    * databaseerrors in workflow cancellation, get by uuid\r\n    * get nonexistent workflow by uuid\r\n    * unicode methods of cancellation object"},"comment":{"url":"https://api.github.com/repos/edx/edx-ora2/issues/comments/156215354","html_url":"https://github.com/edx/edx-ora2/pull/768#issuecomment-156215354","issue_url":"https://api.github.com/repos/edx/edx-ora2/issues/768","id":156215354,"user":{"login":"dianakhuang","id":2952947,"avatar_url":"https://avatars.githubusercontent.com/u/2952947?v=3","gravatar_id":"","url":"https://api.github.com/users/dianakhuang","html_url":"https://github.com/dianakhuang","followers_url":"https://api.github.com/users/dianakhuang/followers","following_url":"https://api.github.com/users/dianakhuang/following{/other_user}","gists_url":"https://api.github.com/users/dianakhuang/gists{/gist_id}","starred_url":"https://api.github.com/users/dianakhuang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dianakhuang/subscriptions","organizations_url":"https://api.github.com/users/dianakhuang/orgs","repos_url":"https://api.github.com/users/dianakhuang/repos","events_url":"https://api.github.com/users/dianakhuang/events{/privacy}","received_events_url":"https://api.github.com/users/dianakhuang/received_events","type":"User","site_admin":false},"created_at":"2015-11-12T19:49:20Z","updated_at":"2015-11-12T19:49:20Z","body":":+1:"}}