{"action":"created","issue":{"url":"https://api.github.com/repos/michaelsauter/crane/issues/176","labels_url":"https://api.github.com/repos/michaelsauter/crane/issues/176/labels{/name}","comments_url":"https://api.github.com/repos/michaelsauter/crane/issues/176/comments","events_url":"https://api.github.com/repos/michaelsauter/crane/issues/176/events","html_url":"https://github.com/michaelsauter/crane/pull/176","id":67197079,"number":176,"title":"Add default-env parameter","user":{"login":"williamhogman","id":143746,"avatar_url":"https://avatars.githubusercontent.com/u/143746?v=3","gravatar_id":"","url":"https://api.github.com/users/williamhogman","html_url":"https://github.com/williamhogman","followers_url":"https://api.github.com/users/williamhogman/followers","following_url":"https://api.github.com/users/williamhogman/following{/other_user}","gists_url":"https://api.github.com/users/williamhogman/gists{/gist_id}","starred_url":"https://api.github.com/users/williamhogman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamhogman/subscriptions","organizations_url":"https://api.github.com/users/williamhogman/orgs","repos_url":"https://api.github.com/users/williamhogman/repos","events_url":"https://api.github.com/users/williamhogman/events{/privacy}","received_events_url":"https://api.github.com/users/williamhogman/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-04-08T19:05:45Z","updated_at":"2015-04-10T14:14:38Z","closed_at":"2015-04-10T14:14:38Z","pull_request":{"url":"https://api.github.com/repos/michaelsauter/crane/pulls/176","html_url":"https://github.com/michaelsauter/crane/pull/176","diff_url":"https://github.com/michaelsauter/crane/pull/176.diff","patch_url":"https://github.com/michaelsauter/crane/pull/176.patch"},"body":"Hello there!\r\n\r\nFirst of, thanks for an awesome project, as a developer using docker daily crane really makes my life easier.\r\n\r\nThis commit adds a parameter by the name ```env-default```. The purpose of ```env-default``` is to provide a means by which developers can set reasonable defaults in crane.yaml (e.g development settings) while still allowing these to be overridden manually using environment variables. While it is certainly possible to achieve this by other means they would require either preprocessing crane.yaml or wrapping crane with another tool setting environment variables, which seems needlessly complex.\r\n\r\nFinally, I wasn't sure about unit-tests so I haven't included any. I'm happy to write them if you could point me towards an existing test-case in the code-base that I could adapt to my code.\r\n\r\nAll the best,\r\n/will"},"comment":{"url":"https://api.github.com/repos/michaelsauter/crane/issues/comments/91571709","html_url":"https://github.com/michaelsauter/crane/pull/176#issuecomment-91571709","issue_url":"https://api.github.com/repos/michaelsauter/crane/issues/176","id":91571709,"user":{"login":"williamhogman","id":143746,"avatar_url":"https://avatars.githubusercontent.com/u/143746?v=3","gravatar_id":"","url":"https://api.github.com/users/williamhogman","html_url":"https://github.com/williamhogman","followers_url":"https://api.github.com/users/williamhogman/followers","following_url":"https://api.github.com/users/williamhogman/following{/other_user}","gists_url":"https://api.github.com/users/williamhogman/gists{/gist_id}","starred_url":"https://api.github.com/users/williamhogman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williamhogman/subscriptions","organizations_url":"https://api.github.com/users/williamhogman/orgs","repos_url":"https://api.github.com/users/williamhogman/repos","events_url":"https://api.github.com/users/williamhogman/events{/privacy}","received_events_url":"https://api.github.com/users/williamhogman/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T14:14:38Z","updated_at":"2015-04-10T14:14:38Z","body":"@michaelsauter We figured out a way of solving that didn't involve having to use bash for templating crane.yml. Thanks a ton for the help :+1: "}}