{"action":"created","comment":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/46917574","id":46917574,"diff_hunk":"@@ -49,6 +50,30 @@ class RouterCachingService\n     protected $systemLogger;\n \n     /**\n+     * @Flow\\Inject\n+     * @var ObjectManagerInterface\n+     */\n+    protected $objectManager;\n+\n+    /**\n+     * @Flow\\InjectConfiguration(\"mvc.routes\")\n+     * @var array\n+     */\n+    protected $routingSettings;\n+\n+    /**\n+     * @return void\n+     */\n+    public function initializeObject()\n+    {\n+        // flush routing caches if in Development context & routing settings changed\n+        if ($this->objectManager->getContext()->isDevelopment() && $this->routeCache->get('routingSettings') !== $this->routingSettings) {","path":"TYPO3.Flow/Classes/TYPO3/Flow/Mvc/Routing/RouterCachingService.php","position":29,"original_position":29,"commit_id":"69ba68369a63cb1e7756c4b8aa67947d87f24169","original_commit_id":"69ba68369a63cb1e7756c4b8aa67947d87f24169","user":{"login":"aertmann","id":903567,"avatar_url":"https://avatars.githubusercontent.com/u/903567?v=3","gravatar_id":"","url":"https://api.github.com/users/aertmann","html_url":"https://github.com/aertmann","followers_url":"https://api.github.com/users/aertmann/followers","following_url":"https://api.github.com/users/aertmann/following{/other_user}","gists_url":"https://api.github.com/users/aertmann/gists{/gist_id}","starred_url":"https://api.github.com/users/aertmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aertmann/subscriptions","organizations_url":"https://api.github.com/users/aertmann/orgs","repos_url":"https://api.github.com/users/aertmann/repos","events_url":"https://api.github.com/users/aertmann/events{/privacy}","received_events_url":"https://api.github.com/users/aertmann/received_events","type":"User","site_admin":false},"body":"not sure if it's any problem, but it will flush the empty caches on first request","created_at":"2015-12-08T05:56:04Z","updated_at":"2015-12-08T05:56:04Z","html_url":"https://github.com/neos/flow-development-collection/pull/129#discussion_r46917574","pull_request_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/129","_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments/46917574"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/129#discussion_r46917574"},"pull_request":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/129"}}},"pull_request":{"url":"https://api.github.com/repos/neos/flow-development-collection/pulls/129","id":50640823,"html_url":"https://github.com/neos/flow-development-collection/pull/129","diff_url":"https://github.com/neos/flow-development-collection/pull/129.diff","patch_url":"https://github.com/neos/flow-development-collection/pull/129.patch","issue_url":"https://api.github.com/repos/neos/flow-development-collection/issues/129","number":129,"state":"open","locked":false,"title":"[FEATURE] Routes via Settings","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"body":"This change allows routes to be included via `Settings.yaml` like follows::\r\n\r\n    TYPO3:\r\n      Flow:\r\n        mvc:\r\n          routes:\r\n            'Some.Package': TRUE\r\n\r\nThis would append the main `Routes.yaml` from the package\r\n``Some.Package`` (including its subroutes, if any) to existing\r\nroute definitions.\r\n\r\nIt's also possible to specify the order in relation to other packages::\r\n\r\n    TYPO3:\r\n      Flow:\r\n        mvc:\r\n          routes:\r\n            'SomeOther.Package':\r\n              position: 'before Some.Package'\r\n\r\nThis will add the ``SomeOther.Package`` routes *before* the routes\r\nof ``Some.Package`` (if those are included).\r\n\r\n*NOTE:* Routes included via main `Configuration/Routes.yaml` will\r\n*always* be included first, it's not possible to add routes before or\r\nin between those via the new setting.\r\nThus it's recommended to remove the main `Routes.yaml` and include\r\nroutes via `Settings.yaml` instead.\r\n\r\nFor the Flow Routes this could look like::\r\n\r\n    TYPO3:\r\n      Flow:\r\n        mvc:\r\n          routes:\r\n            'TYPO3.Flow':\r\n              position: 'start'\r\n\r\nResolves: FLOW-411","created_at":"2015-11-13T13:30:39Z","updated_at":"2015-12-08T05:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d3bf7d446828b7528d28f6a684ad241212ceb66","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/129/commits","review_comments_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/129/comments","review_comment_url":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/issues/129/comments","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/69ba68369a63cb1e7756c4b8aa67947d87f24169","head":{"label":"bwaidelich:routes-in-settings","ref":"routes-in-settings","sha":"69ba68369a63cb1e7756c4b8aa67947d87f24169","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"repo":{"id":41787828,"name":"flow-development-collection","full_name":"bwaidelich/flow-development-collection","owner":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bwaidelich/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":true,"url":"https://api.github.com/repos/bwaidelich/flow-development-collection","forks_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/forks","keys_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/events","assignees_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/merges","archive_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/bwaidelich/flow-development-collection/releases{/id}","created_at":"2015-09-02T07:54:57Z","updated_at":"2015-09-02T07:55:04Z","pushed_at":"2015-12-02T14:45:39Z","git_url":"git://github.com/bwaidelich/flow-development-collection.git","ssh_url":"git@github.com:bwaidelich/flow-development-collection.git","clone_url":"https://github.com/bwaidelich/flow-development-collection.git","svn_url":"https://github.com/bwaidelich/flow-development-collection","homepage":null,"size":33361,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:master","ref":"master","sha":"184bab54be15d0f172be1a158a16ea2fd891ed28","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40963991,"name":"flow-development-collection","full_name":"neos/flow-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/flow-development-collection","description":"The unified repository containing the Flow core packages, used for Flow development.","fork":false,"url":"https://api.github.com/repos/neos/flow-development-collection","forks_url":"https://api.github.com/repos/neos/flow-development-collection/forks","keys_url":"https://api.github.com/repos/neos/flow-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/flow-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/flow-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/flow-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/flow-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/flow-development-collection/events","assignees_url":"https://api.github.com/repos/neos/flow-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/flow-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/flow-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/flow-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/flow-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/flow-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/flow-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/flow-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/flow-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/flow-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/flow-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/flow-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/flow-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/flow-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/flow-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/flow-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/flow-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/flow-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/flow-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/flow-development-collection/merges","archive_url":"https://api.github.com/repos/neos/flow-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/flow-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/flow-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/flow-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/flow-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/flow-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/flow-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/flow-development-collection/releases{/id}","created_at":"2015-08-18T09:48:13Z","updated_at":"2015-12-02T05:37:17Z","pushed_at":"2015-12-07T17:45:22Z","git_url":"git://github.com/neos/flow-development-collection.git","ssh_url":"git@github.com:neos/flow-development-collection.git","clone_url":"https://github.com/neos/flow-development-collection.git","svn_url":"https://github.com/neos/flow-development-collection","homepage":"http://flow.typo3.org/","size":34059,"stargazers_count":26,"watchers_count":26,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":35,"forks":39,"open_issues":35,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/129"},"html":{"href":"https://github.com/neos/flow-development-collection/pull/129"},"issue":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/129"},"comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/issues/129/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/129/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/flow-development-collection/pulls/129/commits"},"statuses":{"href":"https://api.github.com/repos/neos/flow-development-collection/statuses/69ba68369a63cb1e7756c4b8aa67947d87f24169"}}}}