{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/30373016","id":30373016,"diff_hunk":"@@ -9,41 +9,52 @@\n # @DESCRIPTION:\n # Name of the Go package unpacked to ${S}, this is required.\n \n-[[ ${EAPI} != \"5\" ]] && die \"Only EAPI=5 is supported\"\n+[[ ${EAPI} != \"5\" ]] && die \"${ECLASS}: Only EAPI=5 is supported\"\n \n inherit flag-o-matic multiprocessing toolchain-funcs\n \n DEPEND=\"dev-lang/go\"\n \n+# @FUNCTION: go_get_arch\n+# @USAGE: export GOARCH=$(go_get_arch)\n+go_get_arch() {","path":"eclass/coreos-go.eclass","position":13,"original_position":13,"commit_id":"aefa4253e0df4cf1e350b6464aa800a1dc6e8756","original_commit_id":"aefa4253e0df4cf1e350b6464aa800a1dc6e8756","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"If we wrap it with go_get_arch() then if an arch is added that doesn't match we only need to fix  go_get_arch() and not all the ebuilds that use $ARCH directly.  What do you think?","created_at":"2015-05-14T23:13:35Z","updated_at":"2015-05-14T23:13:35Z","html_url":"https://github.com/coreos/coreos-overlay/pull/1257#discussion_r30373016","pull_request_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257","_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments/30373016"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/1257#discussion_r30373016"},"pull_request":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257","id":35470993,"html_url":"https://github.com/coreos/coreos-overlay/pull/1257","diff_url":"https://github.com/coreos/coreos-overlay/pull/1257.diff","patch_url":"https://github.com/coreos/coreos-overlay/pull/1257.patch","issue_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/1257","number":1257,"state":"open","locked":false,"title":"eclass/coreos-go: Updates for arm64","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"body":"This is the first set of patches toward adding go language support for arm64 builds.\r\n\r\nThis updates the coreos-go eclass to use the GOARCH environment variable which sets the target machine architecture.  GOARCH defaults to the host machine architecture, so has been working correctly for amd64 builds, but did not generate the correct binaries for arm64.\r\n\r\napp-admin/sdnotify-proxy needed an update to build for arm64, so I took the opportunity to convert it to use the coreos-go eclass.  It can now be used as a test case for the coreos-go eclass.\r\n\r\nAlso included in the series are a few minor enhancements to the coreos-go eclass and app-admin/sdnotify-proxy.  Please consider.\r\n\r\n-Geoff","created_at":"2015-05-14T22:58:59Z","updated_at":"2015-05-14T23:13:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c05008160b0840ef234d817b4ac621ce94a9104","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257/commits","review_comments_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257/comments","review_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/1257/comments","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/aefa4253e0df4cf1e350b6464aa800a1dc6e8756","head":{"label":"glevand:for-merge-1","ref":"for-merge-1","sha":"aefa4253e0df4cf1e350b6464aa800a1dc6e8756","user":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"repo":{"id":32751511,"name":"coreos--coreos-overlay","full_name":"glevand/coreos--coreos-overlay","owner":{"login":"glevand","id":10858804,"avatar_url":"https://avatars.githubusercontent.com/u/10858804?v=3","gravatar_id":"","url":"https://api.github.com/users/glevand","html_url":"https://github.com/glevand","followers_url":"https://api.github.com/users/glevand/followers","following_url":"https://api.github.com/users/glevand/following{/other_user}","gists_url":"https://api.github.com/users/glevand/gists{/gist_id}","starred_url":"https://api.github.com/users/glevand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glevand/subscriptions","organizations_url":"https://api.github.com/users/glevand/orgs","repos_url":"https://api.github.com/users/glevand/repos","events_url":"https://api.github.com/users/glevand/events{/privacy}","received_events_url":"https://api.github.com/users/glevand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glevand/coreos--coreos-overlay","description":"CoreOS arm64 port","fork":true,"url":"https://api.github.com/repos/glevand/coreos--coreos-overlay","forks_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/forks","keys_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/teams","hooks_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/events","assignees_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/tags","blobs_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/subscription","commits_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/merges","archive_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/downloads","issues_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/glevand/coreos--coreos-overlay/releases{/id}","created_at":"2015-03-23T18:39:29Z","updated_at":"2015-05-08T19:51:14Z","pushed_at":"2015-05-14T22:44:28Z","git_url":"git://github.com/glevand/coreos--coreos-overlay.git","ssh_url":"git@github.com:glevand/coreos--coreos-overlay.git","clone_url":"https://github.com/glevand/coreos--coreos-overlay.git","svn_url":"https://github.com/glevand/coreos--coreos-overlay","homepage":"","size":8106,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"4eeb91c60012f278e95b8d5c5a9b80b394b9065b","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":8488820,"name":"coreos-overlay","full_name":"coreos/coreos-overlay","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/coreos-overlay","description":"Custom ebuilds for CoreOS","fork":false,"url":"https://api.github.com/repos/coreos/coreos-overlay","forks_url":"https://api.github.com/repos/coreos/coreos-overlay/forks","keys_url":"https://api.github.com/repos/coreos/coreos-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/coreos-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/coreos-overlay/teams","hooks_url":"https://api.github.com/repos/coreos/coreos-overlay/hooks","issue_events_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/coreos-overlay/events","assignees_url":"https://api.github.com/repos/coreos/coreos-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/coreos-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/coreos-overlay/tags","blobs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/coreos-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/coreos-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/coreos-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/coreos-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/coreos-overlay/languages","stargazers_url":"https://api.github.com/repos/coreos/coreos-overlay/stargazers","contributors_url":"https://api.github.com/repos/coreos/coreos-overlay/contributors","subscribers_url":"https://api.github.com/repos/coreos/coreos-overlay/subscribers","subscription_url":"https://api.github.com/repos/coreos/coreos-overlay/subscription","commits_url":"https://api.github.com/repos/coreos/coreos-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/coreos-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/coreos-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/coreos-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/coreos-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/coreos-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/coreos-overlay/merges","archive_url":"https://api.github.com/repos/coreos/coreos-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/coreos-overlay/downloads","issues_url":"https://api.github.com/repos/coreos/coreos-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/coreos-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/coreos-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/coreos-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/coreos-overlay/labels{/name}","releases_url":"https://api.github.com/repos/coreos/coreos-overlay/releases{/id}","created_at":"2013-02-28T21:43:07Z","updated_at":"2015-05-12T18:14:37Z","pushed_at":"2015-05-14T22:58:59Z","git_url":"git://github.com/coreos/coreos-overlay.git","ssh_url":"git@github.com:coreos/coreos-overlay.git","clone_url":"https://github.com/coreos/coreos-overlay.git","svn_url":"https://github.com/coreos/coreos-overlay","homepage":"http://coreos.com/docs/sdk/","size":16012,"stargazers_count":105,"watchers_count":105,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":33,"forks":79,"open_issues":33,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257"},"html":{"href":"https://github.com/coreos/coreos-overlay/pull/1257"},"issue":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/1257"},"comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/issues/1257/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/coreos-overlay/pulls/1257/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/coreos-overlay/statuses/aefa4253e0df4cf1e350b6464aa800a1dc6e8756"}}}}