{"action":"closed","number":33,"pull_request":{"url":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/33","id":43720381,"html_url":"https://github.com/bibliocoll/JournalTouch/pull/33","diff_url":"https://github.com/bibliocoll/JournalTouch/pull/33.diff","patch_url":"https://github.com/bibliocoll/JournalTouch/pull/33.patch","issue_url":"https://api.github.com/repos/bibliocoll/JournalTouch/issues/33","number":33,"state":"closed","locked":false,"title":"Some refactoring (new release)","user":{"login":"tzeumer","id":119825,"avatar_url":"https://avatars.githubusercontent.com/u/119825?v=3","gravatar_id":"","url":"https://api.github.com/users/tzeumer","html_url":"https://github.com/tzeumer","followers_url":"https://api.github.com/users/tzeumer/followers","following_url":"https://api.github.com/users/tzeumer/following{/other_user}","gists_url":"https://api.github.com/users/tzeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/tzeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzeumer/subscriptions","organizations_url":"https://api.github.com/users/tzeumer/orgs","repos_url":"https://api.github.com/users/tzeumer/repos","events_url":"https://api.github.com/users/tzeumer/events{/privacy}","received_events_url":"https://api.github.com/users/tzeumer/received_events","type":"User","site_admin":false},"body":"I made some major changes to the folder structure, that (imho) make a lot more sense. Yet, coming from an old version, this would require moving some files by hand.\r\n\r\nI also refactored class.getJournalInfos to make much more sense by removing the part that updates the input.csv. This part is now moved to admin\\services\\class.UpdateInputCsv.php. Also the old service for the premium toc has moved there. And I renamed it, so it is clear that it only is uses for JournalToc Premium. Both moves might require to adjust existing crons. \r\n\r\nIt also (mostly) resolves the caching issue regarding sanitizing the input, even though improvment is yet possible. Refers to this (at least in regard of a bootstrap file) https://github.com/bibliocoll/JournalTouch/issues/32\r\n\r\nThe language switch does work as discussed here https://github.com/bibliocoll/JournalTouch/issues/27\r\n\r\nI did not yet remove the list view as discussed here https://github.com/bibliocoll/JournalTouch/issues/26 and prepared here https://github.com/tzeumer/JournalTouch/tree/pr-replace_listview. My Solution isn't perfect in desing, but it is the way we were thinking about it. Yet, my test data includes about thousand journals and doing such a toggle kills the browser. So, I think this isn't a good option. \r\nIF you really think the list view is useful, I think the best way would be to make it optional via config.php. Maybe you have better \"user data\", because you seem to know some live installations of JournalTouch.\r\nBut at this point, I don't really see a reason for loading data twice for a view no one will ever use...\r\n\r\nOk, so much for now :)\r\n\r\nPS: I also added individual Branches for each mentioned change in my repository.","created_at":"2015-08-30T20:59:57Z","updated_at":"2015-08-31T10:36:56Z","closed_at":"2015-08-31T10:36:56Z","merged_at":null,"merge_commit_sha":"a2304c01cf00513b63f289acd553663b474fab06","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/33/commits","review_comments_url":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/33/comments","review_comment_url":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bibliocoll/JournalTouch/issues/33/comments","statuses_url":"https://api.github.com/repos/bibliocoll/JournalTouch/statuses/45fff0a7c03fd6d2d47ec9d05f4d352f512ae561","head":{"label":"tzeumer:new_release","ref":"new_release","sha":"45fff0a7c03fd6d2d47ec9d05f4d352f512ae561","user":{"login":"tzeumer","id":119825,"avatar_url":"https://avatars.githubusercontent.com/u/119825?v=3","gravatar_id":"","url":"https://api.github.com/users/tzeumer","html_url":"https://github.com/tzeumer","followers_url":"https://api.github.com/users/tzeumer/followers","following_url":"https://api.github.com/users/tzeumer/following{/other_user}","gists_url":"https://api.github.com/users/tzeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/tzeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzeumer/subscriptions","organizations_url":"https://api.github.com/users/tzeumer/orgs","repos_url":"https://api.github.com/users/tzeumer/repos","events_url":"https://api.github.com/users/tzeumer/events{/privacy}","received_events_url":"https://api.github.com/users/tzeumer/received_events","type":"User","site_admin":false},"repo":{"id":20533919,"name":"JournalTouch","full_name":"tzeumer/JournalTouch","owner":{"login":"tzeumer","id":119825,"avatar_url":"https://avatars.githubusercontent.com/u/119825?v=3","gravatar_id":"","url":"https://api.github.com/users/tzeumer","html_url":"https://github.com/tzeumer","followers_url":"https://api.github.com/users/tzeumer/followers","following_url":"https://api.github.com/users/tzeumer/following{/other_user}","gists_url":"https://api.github.com/users/tzeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/tzeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tzeumer/subscriptions","organizations_url":"https://api.github.com/users/tzeumer/orgs","repos_url":"https://api.github.com/users/tzeumer/repos","events_url":"https://api.github.com/users/tzeumer/events{/privacy}","received_events_url":"https://api.github.com/users/tzeumer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tzeumer/JournalTouch","description":"JournalTouch provides a touch-optimized interface for browsing current jounal tables of contents in Responsive Design. Fun!","fork":true,"url":"https://api.github.com/repos/tzeumer/JournalTouch","forks_url":"https://api.github.com/repos/tzeumer/JournalTouch/forks","keys_url":"https://api.github.com/repos/tzeumer/JournalTouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tzeumer/JournalTouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tzeumer/JournalTouch/teams","hooks_url":"https://api.github.com/repos/tzeumer/JournalTouch/hooks","issue_events_url":"https://api.github.com/repos/tzeumer/JournalTouch/issues/events{/number}","events_url":"https://api.github.com/repos/tzeumer/JournalTouch/events","assignees_url":"https://api.github.com/repos/tzeumer/JournalTouch/assignees{/user}","branches_url":"https://api.github.com/repos/tzeumer/JournalTouch/branches{/branch}","tags_url":"https://api.github.com/repos/tzeumer/JournalTouch/tags","blobs_url":"https://api.github.com/repos/tzeumer/JournalTouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tzeumer/JournalTouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tzeumer/JournalTouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/tzeumer/JournalTouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tzeumer/JournalTouch/statuses/{sha}","languages_url":"https://api.github.com/repos/tzeumer/JournalTouch/languages","stargazers_url":"https://api.github.com/repos/tzeumer/JournalTouch/stargazers","contributors_url":"https://api.github.com/repos/tzeumer/JournalTouch/contributors","subscribers_url":"https://api.github.com/repos/tzeumer/JournalTouch/subscribers","subscription_url":"https://api.github.com/repos/tzeumer/JournalTouch/subscription","commits_url":"https://api.github.com/repos/tzeumer/JournalTouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/tzeumer/JournalTouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/tzeumer/JournalTouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/tzeumer/JournalTouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/tzeumer/JournalTouch/contents/{+path}","compare_url":"https://api.github.com/repos/tzeumer/JournalTouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tzeumer/JournalTouch/merges","archive_url":"https://api.github.com/repos/tzeumer/JournalTouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tzeumer/JournalTouch/downloads","issues_url":"https://api.github.com/repos/tzeumer/JournalTouch/issues{/number}","pulls_url":"https://api.github.com/repos/tzeumer/JournalTouch/pulls{/number}","milestones_url":"https://api.github.com/repos/tzeumer/JournalTouch/milestones{/number}","notifications_url":"https://api.github.com/repos/tzeumer/JournalTouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tzeumer/JournalTouch/labels{/name}","releases_url":"https://api.github.com/repos/tzeumer/JournalTouch/releases{/id}","created_at":"2014-06-05T17:11:58Z","updated_at":"2015-08-20T18:38:37Z","pushed_at":"2015-08-30T20:42:48Z","git_url":"git://github.com/tzeumer/JournalTouch.git","ssh_url":"git@github.com:tzeumer/JournalTouch.git","clone_url":"https://github.com/tzeumer/JournalTouch.git","svn_url":"https://github.com/tzeumer/JournalTouch","homepage":"","size":2789,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bibliocoll:master","ref":"master","sha":"cfd45b59ee61d7adedfb7d45c18e824600f97358","user":{"login":"bibliocoll","id":3585764,"avatar_url":"https://avatars.githubusercontent.com/u/3585764?v=3","gravatar_id":"","url":"https://api.github.com/users/bibliocoll","html_url":"https://github.com/bibliocoll","followers_url":"https://api.github.com/users/bibliocoll/followers","following_url":"https://api.github.com/users/bibliocoll/following{/other_user}","gists_url":"https://api.github.com/users/bibliocoll/gists{/gist_id}","starred_url":"https://api.github.com/users/bibliocoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bibliocoll/subscriptions","organizations_url":"https://api.github.com/users/bibliocoll/orgs","repos_url":"https://api.github.com/users/bibliocoll/repos","events_url":"https://api.github.com/users/bibliocoll/events{/privacy}","received_events_url":"https://api.github.com/users/bibliocoll/received_events","type":"Organization","site_admin":false},"repo":{"id":19529387,"name":"JournalTouch","full_name":"bibliocoll/JournalTouch","owner":{"login":"bibliocoll","id":3585764,"avatar_url":"https://avatars.githubusercontent.com/u/3585764?v=3","gravatar_id":"","url":"https://api.github.com/users/bibliocoll","html_url":"https://github.com/bibliocoll","followers_url":"https://api.github.com/users/bibliocoll/followers","following_url":"https://api.github.com/users/bibliocoll/following{/other_user}","gists_url":"https://api.github.com/users/bibliocoll/gists{/gist_id}","starred_url":"https://api.github.com/users/bibliocoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bibliocoll/subscriptions","organizations_url":"https://api.github.com/users/bibliocoll/orgs","repos_url":"https://api.github.com/users/bibliocoll/repos","events_url":"https://api.github.com/users/bibliocoll/events{/privacy}","received_events_url":"https://api.github.com/users/bibliocoll/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bibliocoll/JournalTouch","description":"JournalTouch provides a touch-optimized interface for browsing current jounal tables of contents in Responsive Design. Fun!","fork":false,"url":"https://api.github.com/repos/bibliocoll/JournalTouch","forks_url":"https://api.github.com/repos/bibliocoll/JournalTouch/forks","keys_url":"https://api.github.com/repos/bibliocoll/JournalTouch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bibliocoll/JournalTouch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bibliocoll/JournalTouch/teams","hooks_url":"https://api.github.com/repos/bibliocoll/JournalTouch/hooks","issue_events_url":"https://api.github.com/repos/bibliocoll/JournalTouch/issues/events{/number}","events_url":"https://api.github.com/repos/bibliocoll/JournalTouch/events","assignees_url":"https://api.github.com/repos/bibliocoll/JournalTouch/assignees{/user}","branches_url":"https://api.github.com/repos/bibliocoll/JournalTouch/branches{/branch}","tags_url":"https://api.github.com/repos/bibliocoll/JournalTouch/tags","blobs_url":"https://api.github.com/repos/bibliocoll/JournalTouch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bibliocoll/JournalTouch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bibliocoll/JournalTouch/git/refs{/sha}","trees_url":"https://api.github.com/repos/bibliocoll/JournalTouch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bibliocoll/JournalTouch/statuses/{sha}","languages_url":"https://api.github.com/repos/bibliocoll/JournalTouch/languages","stargazers_url":"https://api.github.com/repos/bibliocoll/JournalTouch/stargazers","contributors_url":"https://api.github.com/repos/bibliocoll/JournalTouch/contributors","subscribers_url":"https://api.github.com/repos/bibliocoll/JournalTouch/subscribers","subscription_url":"https://api.github.com/repos/bibliocoll/JournalTouch/subscription","commits_url":"https://api.github.com/repos/bibliocoll/JournalTouch/commits{/sha}","git_commits_url":"https://api.github.com/repos/bibliocoll/JournalTouch/git/commits{/sha}","comments_url":"https://api.github.com/repos/bibliocoll/JournalTouch/comments{/number}","issue_comment_url":"https://api.github.com/repos/bibliocoll/JournalTouch/issues/comments{/number}","contents_url":"https://api.github.com/repos/bibliocoll/JournalTouch/contents/{+path}","compare_url":"https://api.github.com/repos/bibliocoll/JournalTouch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bibliocoll/JournalTouch/merges","archive_url":"https://api.github.com/repos/bibliocoll/JournalTouch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bibliocoll/JournalTouch/downloads","issues_url":"https://api.github.com/repos/bibliocoll/JournalTouch/issues{/number}","pulls_url":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls{/number}","milestones_url":"https://api.github.com/repos/bibliocoll/JournalTouch/milestones{/number}","notifications_url":"https://api.github.com/repos/bibliocoll/JournalTouch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bibliocoll/JournalTouch/labels{/name}","releases_url":"https://api.github.com/repos/bibliocoll/JournalTouch/releases{/id}","created_at":"2014-05-07T09:56:04Z","updated_at":"2015-08-21T08:56:46Z","pushed_at":"2015-08-30T21:00:00Z","git_url":"git://github.com/bibliocoll/JournalTouch.git","ssh_url":"git@github.com:bibliocoll/JournalTouch.git","clone_url":"https://github.com/bibliocoll/JournalTouch.git","svn_url":"https://github.com/bibliocoll/JournalTouch","homepage":"","size":3010,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":12,"forks":4,"open_issues":12,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/33"},"html":{"href":"https://github.com/bibliocoll/JournalTouch/pull/33"},"issue":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/issues/33"},"comments":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/bibliocoll/JournalTouch/statuses/45fff0a7c03fd6d2d47ec9d05f4d352f512ae561"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":33,"additions":98,"deletions":550,"changed_files":330}}