{"action":"closed","number":1720,"pull_request":{"url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/1720","id":27908141,"html_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/1720","diff_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/1720.diff","patch_url":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/1720.patch","issue_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/1720","number":1720,"state":"closed","locked":false,"title":"Apdat changes on the new API onXWalkReady()","user":{"login":"halton","id":433218,"avatar_url":"https://avatars.githubusercontent.com/u/433218?v=3","gravatar_id":"","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"body":"Crosswalk environment is not available under two scenarios:\r\n* Shared mode: Need download from app store like Google Play\r\n* CrosswalkMini: The libxwalkcore.so is compressed with lzma, need to\r\n  decompress it first.\r\n\r\norg.xwalk.core.XWalkActivity.onXWalkReady() is introduced by for the\r\npurpose of do XWalkView related things after Crosswalk environment is\r\navailable to use . Refer to PR\r\nhttps://github.com/crosswalk-project/crosswalk/pull/2780\r\n\r\nChanges need to be adapt this new API:\r\n* XWalkView initialized code moved from onCreate() to onXWalkReady().\r\n* Activity should inheriate from org.xwalk.core.XWalkActivity\r\ninstead of android.app.Activity.\r\n* In AndroidManifest.xml, android:name should change to\r\n  org.xwalk.core.XWalkApplication.\r\n\r\nXWalkBaseActivity.java is not needed anymore because compiler will\r\nreport onXWalkReady() need to be implemented. We move the deceleration\r\nof mXWalkView into activities where this var is needed.","created_at":"2015-01-23T08:32:28Z","updated_at":"2015-01-23T08:38:11Z","closed_at":"2015-01-23T08:38:11Z","merged_at":"2015-01-23T08:38:11Z","merge_commit_sha":"03fb0f476423df33e1e208ef70ef3a8c79c257dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/1720/commits","review_comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/1720/comments","review_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/comments/{number}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/1720/comments","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/statuses/145b0d45ce495befe45741e6242bf6b14eb92556","head":{"label":"halton:adapt_onXWalkReady","ref":"adapt_onXWalkReady","sha":"145b0d45ce495befe45741e6242bf6b14eb92556","user":{"login":"halton","id":433218,"avatar_url":"https://avatars.githubusercontent.com/u/433218?v=3","gravatar_id":"","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"repo":{"id":29723691,"name":"crosswalk-test-suite","full_name":"halton/crosswalk-test-suite","owner":{"login":"halton","id":433218,"avatar_url":"https://avatars.githubusercontent.com/u/433218?v=3","gravatar_id":"","url":"https://api.github.com/users/halton","html_url":"https://github.com/halton","followers_url":"https://api.github.com/users/halton/followers","following_url":"https://api.github.com/users/halton/following{/other_user}","gists_url":"https://api.github.com/users/halton/gists{/gist_id}","starred_url":"https://api.github.com/users/halton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halton/subscriptions","organizations_url":"https://api.github.com/users/halton/orgs","repos_url":"https://api.github.com/users/halton/repos","events_url":"https://api.github.com/users/halton/events{/privacy}","received_events_url":"https://api.github.com/users/halton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/halton/crosswalk-test-suite","description":"","fork":true,"url":"https://api.github.com/repos/halton/crosswalk-test-suite","forks_url":"https://api.github.com/repos/halton/crosswalk-test-suite/forks","keys_url":"https://api.github.com/repos/halton/crosswalk-test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/halton/crosswalk-test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/halton/crosswalk-test-suite/teams","hooks_url":"https://api.github.com/repos/halton/crosswalk-test-suite/hooks","issue_events_url":"https://api.github.com/repos/halton/crosswalk-test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/halton/crosswalk-test-suite/events","assignees_url":"https://api.github.com/repos/halton/crosswalk-test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/halton/crosswalk-test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/halton/crosswalk-test-suite/tags","blobs_url":"https://api.github.com/repos/halton/crosswalk-test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/halton/crosswalk-test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/halton/crosswalk-test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/halton/crosswalk-test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/halton/crosswalk-test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/halton/crosswalk-test-suite/languages","stargazers_url":"https://api.github.com/repos/halton/crosswalk-test-suite/stargazers","contributors_url":"https://api.github.com/repos/halton/crosswalk-test-suite/contributors","subscribers_url":"https://api.github.com/repos/halton/crosswalk-test-suite/subscribers","subscription_url":"https://api.github.com/repos/halton/crosswalk-test-suite/subscription","commits_url":"https://api.github.com/repos/halton/crosswalk-test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/halton/crosswalk-test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/halton/crosswalk-test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/halton/crosswalk-test-suite/issues/comments/{number}","contents_url":"https://api.github.com/repos/halton/crosswalk-test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/halton/crosswalk-test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/halton/crosswalk-test-suite/merges","archive_url":"https://api.github.com/repos/halton/crosswalk-test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/halton/crosswalk-test-suite/downloads","issues_url":"https://api.github.com/repos/halton/crosswalk-test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/halton/crosswalk-test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/halton/crosswalk-test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/halton/crosswalk-test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/halton/crosswalk-test-suite/labels{/name}","releases_url":"https://api.github.com/repos/halton/crosswalk-test-suite/releases{/id}","created_at":"2015-01-23T08:30:34Z","updated_at":"2015-01-23T08:31:17Z","pushed_at":"2015-01-23T08:32:09Z","git_url":"git://github.com/halton/crosswalk-test-suite.git","ssh_url":"git@github.com:halton/crosswalk-test-suite.git","clone_url":"https://github.com/halton/crosswalk-test-suite.git","svn_url":"https://github.com/halton/crosswalk-test-suite","homepage":null,"size":139613,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crosswalk-project:Crosswalk-mini","ref":"Crosswalk-mini","sha":"0a19634e2784261ce830eaca2a2a2378ea1b3562","user":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":17703190,"name":"crosswalk-test-suite","full_name":"crosswalk-project/crosswalk-test-suite","owner":{"login":"crosswalk-project","id":4867377,"avatar_url":"https://avatars.githubusercontent.com/u/4867377?v=3","gravatar_id":"","url":"https://api.github.com/users/crosswalk-project","html_url":"https://github.com/crosswalk-project","followers_url":"https://api.github.com/users/crosswalk-project/followers","following_url":"https://api.github.com/users/crosswalk-project/following{/other_user}","gists_url":"https://api.github.com/users/crosswalk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crosswalk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crosswalk-project/subscriptions","organizations_url":"https://api.github.com/users/crosswalk-project/orgs","repos_url":"https://api.github.com/users/crosswalk-project/repos","events_url":"https://api.github.com/users/crosswalk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crosswalk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crosswalk-project/crosswalk-test-suite","description":"","fork":false,"url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite","forks_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/forks","keys_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/teams","hooks_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/hooks","issue_events_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/events{/number}","events_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/events","assignees_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/assignees{/user}","branches_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/branches{/branch}","tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/tags","blobs_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/refs{/sha}","trees_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/statuses/{sha}","languages_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/languages","stargazers_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/stargazers","contributors_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/contributors","subscribers_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/subscribers","subscription_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/subscription","commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/commits{/sha}","git_commits_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/git/commits{/sha}","comments_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/comments{/number}","issue_comment_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/comments/{number}","contents_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/contents/{+path}","compare_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/merges","archive_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/downloads","issues_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues{/number}","pulls_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls{/number}","milestones_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/milestones{/number}","notifications_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/labels{/name}","releases_url":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/releases{/id}","created_at":"2014-03-13T08:33:13Z","updated_at":"2015-01-23T07:25:42Z","pushed_at":"2015-01-23T08:38:11Z","git_url":"git://github.com/crosswalk-project/crosswalk-test-suite.git","ssh_url":"git@github.com:crosswalk-project/crosswalk-test-suite.git","clone_url":"https://github.com/crosswalk-project/crosswalk-test-suite.git","svn_url":"https://github.com/crosswalk-project/crosswalk-test-suite","homepage":null,"size":139613,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":20,"forks":59,"open_issues":20,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/1720"},"html":{"href":"https://github.com/crosswalk-project/crosswalk-test-suite/pull/1720"},"issue":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/1720"},"comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/issues/1720/comments"},"review_comments":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/1720/comments"},"review_comment":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/pulls/1720/commits"},"statuses":{"href":"https://api.github.com/repos/crosswalk-project/crosswalk-test-suite/statuses/145b0d45ce495befe45741e6242bf6b14eb92556"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jennycao","id":714708,"avatar_url":"https://avatars.githubusercontent.com/u/714708?v=3","gravatar_id":"","url":"https://api.github.com/users/jennycao","html_url":"https://github.com/jennycao","followers_url":"https://api.github.com/users/jennycao/followers","following_url":"https://api.github.com/users/jennycao/following{/other_user}","gists_url":"https://api.github.com/users/jennycao/gists{/gist_id}","starred_url":"https://api.github.com/users/jennycao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennycao/subscriptions","organizations_url":"https://api.github.com/users/jennycao/orgs","repos_url":"https://api.github.com/users/jennycao/repos","events_url":"https://api.github.com/users/jennycao/events{/privacy}","received_events_url":"https://api.github.com/users/jennycao/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":102,"deletions":40,"changed_files":17}}