{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6954","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6954/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6954/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6954/events","html_url":"https://github.com/bitcoin/bitcoin/pull/6954","id":115367941,"number":6954,"title":"Switch to libsecp256k1-based ECDSA validation","user":{"login":"sipa","id":548488,"avatar_url":"https://avatars.githubusercontent.com/u/548488?v=3","gravatar_id":"","url":"https://api.github.com/users/sipa","html_url":"https://github.com/sipa","followers_url":"https://api.github.com/users/sipa/followers","following_url":"https://api.github.com/users/sipa/following{/other_user}","gists_url":"https://api.github.com/users/sipa/gists{/gist_id}","starred_url":"https://api.github.com/users/sipa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sipa/subscriptions","organizations_url":"https://api.github.com/users/sipa/orgs","repos_url":"https://api.github.com/users/sipa/repos","events_url":"https://api.github.com/users/sipa/events{/privacy}","received_events_url":"https://api.github.com/users/sipa/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/UTXO%20Db%20and%20Indexes","name":"UTXO Db and Indexes","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/19","html_url":"https://github.com/bitcoin/bitcoin/milestones/0.12.0","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones/19/labels","id":1092458,"number":19,"title":"0.12.0","description":"","creator":{"login":"laanwj","id":126646,"avatar_url":"https://avatars.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":9,"state":"open","created_at":"2015-05-01T12:31:35Z","updated_at":"2015-11-10T14:32:15Z","due_on":null,"closed_at":null},"comments":23,"created_at":"2015-11-05T20:32:01Z","updated_at":"2015-11-11T01:30:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/6954","html_url":"https://github.com/bitcoin/bitcoin/pull/6954","diff_url":"https://github.com/bitcoin/bitcoin/pull/6954.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/6954.patch"},"body":"This updates the libsecp256k1 subtree to upstream master, and switches ECDSA validation to it.\r\n\r\nPractical upshot:\r\n* Signature validation is anywhere between 3 and 7 times faster.\r\n* Consensus code no longer depends on OpenSSL or its signature parser.\r\n* Removes linking with OpenSSL from libconsensus.\r\n\r\nLibsecp256k1 itself has not had a stable release, but we're very close to that. This PR is effectively a preview, with the intention of switching to the released version before the Bitcoin Core 0.12 release.\r\n\r\nThe past months libsecp256k1 has undergone very extensive testing and validation, though some of that work is still under review. This includes:\r\n* Very high branch coverage (which required generating a trillion random test vectors and strip them down to the 32 which collectively give the highest coverage for the scalar arithmetic code)\r\n* Formal proofs for the group laws using SAGE, and human-verifiable proof annotations for the field arithmetic logic.\r\n* Test code that generates random valid DER signatures, fuzzes them, and compares the result of parsing them internally and using OpenSSL - which turned up a set of (to me) previously unknown behaviour in OpenSSL's parser.\r\n* The ability to compile in a test mode which switches to a slightly different curve (one constant change), resulting in a group of only 139 points instead of around 2<sup>256</sup>, allowing exhaustive testing of nearly all code.\r\n\r\nThe above things are planned to be finished before final release, as well as some API changes - though probably none that affect Bitcoin's usage.\r\n\r\nThanks to everyone who contributed so far (including but not limited to @gmaxwell, @apoelstra, @peterdettman, @theuni, @luke-jr, ...)."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/155625688","html_url":"https://github.com/bitcoin/bitcoin/pull/6954#issuecomment-155625688","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/6954","id":155625688,"user":{"login":"gmaxwell","id":858454,"avatar_url":"https://avatars.githubusercontent.com/u/858454?v=3","gravatar_id":"","url":"https://api.github.com/users/gmaxwell","html_url":"https://github.com/gmaxwell","followers_url":"https://api.github.com/users/gmaxwell/followers","following_url":"https://api.github.com/users/gmaxwell/following{/other_user}","gists_url":"https://api.github.com/users/gmaxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaxwell/subscriptions","organizations_url":"https://api.github.com/users/gmaxwell/orgs","repos_url":"https://api.github.com/users/gmaxwell/repos","events_url":"https://api.github.com/users/gmaxwell/events{/privacy}","received_events_url":"https://api.github.com/users/gmaxwell/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T01:30:59Z","updated_at":"2015-11-11T01:30:59Z","body":"This needs more people to review the integration code before it can be merged. (Enough benchmarks.)"}}