{"action":"created","issue":{"url":"https://api.github.com/repos/mohayonao/CoffeeCollider/issues/83","labels_url":"https://api.github.com/repos/mohayonao/CoffeeCollider/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/mohayonao/CoffeeCollider/issues/83/comments","events_url":"https://api.github.com/repos/mohayonao/CoffeeCollider/issues/83/events","html_url":"https://github.com/mohayonao/CoffeeCollider/pull/83","id":110510334,"number":83,"title":"Upped dependency versions to work with node v4.1.2","user":{"login":"RobertBrewitz","id":40758,"avatar_url":"https://avatars.githubusercontent.com/u/40758?v=3","gravatar_id":"","url":"https://api.github.com/users/RobertBrewitz","html_url":"https://github.com/RobertBrewitz","followers_url":"https://api.github.com/users/RobertBrewitz/followers","following_url":"https://api.github.com/users/RobertBrewitz/following{/other_user}","gists_url":"https://api.github.com/users/RobertBrewitz/gists{/gist_id}","starred_url":"https://api.github.com/users/RobertBrewitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobertBrewitz/subscriptions","organizations_url":"https://api.github.com/users/RobertBrewitz/orgs","repos_url":"https://api.github.com/users/RobertBrewitz/repos","events_url":"https://api.github.com/users/RobertBrewitz/events{/privacy}","received_events_url":"https://api.github.com/users/RobertBrewitz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-08T18:07:56Z","updated_at":"2015-10-09T00:33:30Z","closed_at":"2015-10-09T00:33:16Z","pull_request":{"url":"https://api.github.com/repos/mohayonao/CoffeeCollider/pulls/83","html_url":"https://github.com/mohayonao/CoffeeCollider/pull/83","diff_url":"https://github.com/mohayonao/CoffeeCollider/pull/83.diff","patch_url":"https://github.com/mohayonao/CoffeeCollider/pull/83.patch"},"body":"Tests pass and example works.\r\n\r\nDue to the following:\r\n\r\n> ws@0.4.32 install /usr/local/lib/node_modules/coffee-collider/node_modules/ws\r\n> (node-gyp rebuild 2> builderror.log) || (exit 0)\r\n\r\n  CXX(target) Release/obj.target/bufferutil/src/bufferutil.o\r\n\r\n> speaker@0.0.10 install /usr/local/lib/node_modules/coffee-collider/node_modules/speaker\r\n> node-gyp rebuild\r\n\r\n  CC(target) Release/obj.target/output/deps/mpg123/src/output/coreaudio.o\r\n  LIBTOOL-STATIC Release/liboutput.a\r\n  CXX(target) Release/obj.target/binding/src/binding.o\r\nIn file included from ../src/binding.cc:6:\r\n../src/node_pointer.h:23:9: error: unexpected namespace name 'Buffer': expected expression\r\n  node::Buffer *buf = node::Buffer::New((char *)ptr, length, wrap_pointer_cb, user_data);\r\n        ^\r\n../src/node_pointer.h:23:17: error: use of undeclared identifier 'buf'\r\n  node::Buffer *buf = node::Buffer::New((char *)ptr, length, wrap_pointer_cb, user_data);\r\n                ^\r\n../src/node_pointer.h:23:23: error: no matching function for call to 'New'\r\n  node::Buffer *buf = node::Buffer::New((char *)ptr, length, wrap_pointer_cb, user_data);\r\n                      ^~~~~~~~~~~~~~~~~\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/node_buffer.h:31:40: note: candidate function not viable: requires at most 3 arguments, but 4 were provided\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,\r\n                                       ^\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/node_buffer.h:43:40: note: candidate function not viable: requires 3 arguments, but 4 were provided\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,\r\n                                       ^\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/node_buffer.h:36:40: note: candidate function not viable: requires 5 arguments, but 4 were provided\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate,\r\n                                       ^\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/node_buffer.h:28:40: note: candidate function not viable: requires 2 arguments, but 4 were provided\r\nNODE_EXTERN v8::MaybeLocal<v8::Object> New(v8::Isolate* isolate, size_t length);\r\n                                       ^\r\nIn file included from ../src/binding.cc:6:\r\n../src/node_pointer.h:24:10: error: use of undeclared identifier 'buf'\r\n  return buf->handle_;\r\n         ^\r\n../src/binding.cc:17:3: error: unknown type name 'uv_work_t'\r\n  uv_work_t req;\r\n  ^\r\n../src/binding.cc:25:27: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?\r\nHandle<Value> Open (const Arguments& args) {\r\n                          ^~~~~~~~~\r\n                          v8::internal::Arguments\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/v8.h:139:7: note: 'v8::internal::Arguments' declared here\r\nclass Arguments;\r\n      ^\r\n../src/binding.cc:26:15: error: calling a protected constructor of class 'v8::HandleScope'\r\n  HandleScope scope;\r\n              ^\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/v8.h:885:13: note: declared protected here\r\n  V8_INLINE HandleScope() {}\r\n            ^\r\n../src/binding.cc:28:77: error: type 'const v8::internal::Arguments' does not provide a subscript operator\r\n  audio_output_t *ao = reinterpret_cast<audio_output_t *>(UnwrapPointer(args[0]));\r\n                                                                        ~~~~^~\r\n../src/binding.cc:31:30: error: type 'const v8::internal::Arguments' does not provide a subscript operator\r\n  Local<Object> format = args[1]->ToObject();\r\n                         ~~~~^~\r\n../src/binding.cc:33:38: error: no member named 'NewSymbol' in 'v8::String'\r\n  ao->channels = format->Get(String::NewSymbol(\"channels\"))->Int32Value(); /* channels */\r\n                             ~~~~~~~~^\r\n../src/binding.cc:34:34: error: no member named 'NewSymbol' in 'v8::String'\r\n  ao->rate = format->Get(String::NewSymbol(\"sampleRate\"))->Int32Value(); /* sample rate */\r\n                         ~~~~~~~~^\r\n../src/binding.cc:36:38: error: no member named 'NewSymbol' in 'v8::String'\r\n  int bitDepth = format->Get(String::NewSymbol(\"bitDepth\"))->Int32Value();\r\n                             ~~~~~~~~^\r\n../src/binding.cc:37:39: error: no member named 'NewSymbol' in 'v8::String'\r\n  bool isSigned = format->Get(String::NewSymbol(\"signed\"))->BooleanValue();\r\n                              ~~~~~~~~^\r\n../src/binding.cc:38:38: error: no member named 'NewSymbol' in 'v8::String'\r\n  bool isFloat = format->Get(String::NewSymbol(\"float\"))->BooleanValue();\r\n                             ~~~~~~~~^\r\n../src/binding.cc:72:16: error: no member named 'Close' in 'v8::HandleScope'\r\n  return scope.Close(Integer::New(r));\r\n         ~~~~~ ^\r\n../src/binding.cc:72:36: error: too few arguments to function call, expected 2, have 1\r\n  return scope.Close(Integer::New(r));\r\n                     ~~~~~~~~~~~~  ^\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/v8.h:2499:3: note: 'New' declared here\r\n  static Local<Integer> New(Isolate* isolate, int32_t value);\r\n  ^\r\n../src/binding.cc:75:19: error: unknown type name 'uv_work_t'\r\nvoid write_async (uv_work_t *);\r\n                  ^\r\n../src/binding.cc:76:19: error: unknown type name 'uv_work_t'\r\nvoid write_after (uv_work_t *);\r\n                  ^\r\n../src/binding.cc:78:28: error: unknown type name 'Arguments'; did you mean 'v8::internal::Arguments'?\r\nHandle<Value> Write (const Arguments& args) {\r\n                           ^~~~~~~~~\r\n                           v8::internal::Arguments\r\n/Users/robertbrewitzborg/.node-gyp/4.1.2/include/node/v8.h:139:7: note: 'v8::internal::Arguments' declared here\r\nclass Arguments;\r\n      ^\r\nfatal error: too many errors emitted, stopping now [-ferror-limit=]\r\n20 errors generated.\r\nmake: *** [Release/obj.target/binding/src/binding.o] Error 1\r\ngyp ERR! build error \r\ngyp ERR! stack Error: `make` failed with exit code: 2\r\ngyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:270:23)\r\ngyp ERR! stack     at emitTwo (events.js:87:13)\r\ngyp ERR! stack     at ChildProcess.emit (events.js:172:7)\r\ngyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:200:12)\r\ngyp ERR! System Darwin 14.5.0\r\ngyp ERR! command \"/usr/local/bin/node\" \"/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js\" \"rebuild\"\r\ngyp ERR! cwd /usr/local/lib/node_modules/coffee-collider/node_modules/speaker\r\ngyp ERR! node -v v4.1.2\r\ngyp ERR! node-gyp -v v3.0.3\r\ngyp ERR! not ok \r\nnpm ERR! Darwin 14.5.0\r\nnpm ERR! argv \"/usr/local/bin/node\" \"/usr/local/bin/npm\" \"install\" \"-g\" \"coffee-collider\"\r\nnpm ERR! node v4.1.2\r\nnpm ERR! npm  v2.14.4\r\nnpm ERR! code ELIFECYCLE\r\n\r\nnpm ERR! speaker@0.0.10 install: `node-gyp rebuild`\r\nnpm ERR! Exit status 1\r\nnpm ERR! \r\nnpm ERR! Failed at the speaker@0.0.10 install script 'node-gyp rebuild'.\r\nnpm ERR! This is most likely a problem with the speaker package,\r\nnpm ERR! not with npm itself.\r\nnpm ERR! Tell the author that this fails on your system:\r\nnpm ERR!     node-gyp rebuild\r\nnpm ERR! You can get their info via:\r\nnpm ERR!     npm owner ls speaker\r\nnpm ERR! There is likely additional logging output above.\r\n\r\nnpm ERR! Please include the following file with any support request:\r\nnpm ERR!     /Users/robertbrewitzborg/npm-debug.log"},"comment":{"url":"https://api.github.com/repos/mohayonao/CoffeeCollider/issues/comments/146725683","html_url":"https://github.com/mohayonao/CoffeeCollider/pull/83#issuecomment-146725683","issue_url":"https://api.github.com/repos/mohayonao/CoffeeCollider/issues/83","id":146725683,"user":{"login":"mohayonao","id":158075,"avatar_url":"https://avatars.githubusercontent.com/u/158075?v=3","gravatar_id":"","url":"https://api.github.com/users/mohayonao","html_url":"https://github.com/mohayonao","followers_url":"https://api.github.com/users/mohayonao/followers","following_url":"https://api.github.com/users/mohayonao/following{/other_user}","gists_url":"https://api.github.com/users/mohayonao/gists{/gist_id}","starred_url":"https://api.github.com/users/mohayonao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mohayonao/subscriptions","organizations_url":"https://api.github.com/users/mohayonao/orgs","repos_url":"https://api.github.com/users/mohayonao/repos","events_url":"https://api.github.com/users/mohayonao/events{/privacy}","received_events_url":"https://api.github.com/users/mohayonao/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T00:33:30Z","updated_at":"2015-10-09T00:33:30Z","body":"thanks :+1: "}}