{"action":"opened","number":442,"pull_request":{"url":"https://api.github.com/repos/owncloud/News-Android-App/pulls/442","id":50842297,"html_url":"https://github.com/owncloud/News-Android-App/pull/442","diff_url":"https://github.com/owncloud/News-Android-App/pull/442.diff","patch_url":"https://github.com/owncloud/News-Android-App/pull/442.patch","issue_url":"https://api.github.com/repos/owncloud/News-Android-App/issues/442","number":442,"state":"open","locked":false,"title":"ui and ux enhancements regarding NewsDetail-ContextDialog","user":{"login":"b3nson","id":1008399,"avatar_url":"https://avatars.githubusercontent.com/u/1008399?v=3","gravatar_id":"","url":"https://api.github.com/users/b3nson","html_url":"https://github.com/b3nson","followers_url":"https://api.github.com/users/b3nson/followers","following_url":"https://api.github.com/users/b3nson/following{/other_user}","gists_url":"https://api.github.com/users/b3nson/gists{/gist_id}","starred_url":"https://api.github.com/users/b3nson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b3nson/subscriptions","organizations_url":"https://api.github.com/users/b3nson/orgs","repos_url":"https://api.github.com/users/b3nson/repos","events_url":"https://api.github.com/users/b3nson/events{/privacy}","received_events_url":"https://api.github.com/users/b3nson/received_events","type":"User","site_admin":false},"body":"##### NEW:\r\n* improved layout of the contextDialog (margins/paddings) (see screenshots below)\r\n* omit alt-text from dialog if empty or same as imagename (see screenshots below)\r\n* hide the dialog immediately after \"Download Image\" pressed (dismiss on download-success/error)\r\n* refactored all UI-strings to strings.xml for better internationalization\r\n* gain control over sort-order of dialog-list-items (HashMap -> LinkedHashMap). Now, order is order of insertion (`mMenuItems.put(xyz)`), was not the case with `mMenuItems = HashMap``\r\n* Fixed bug where app crashes when certain relative image-links appear on a website viewed in internal browser (e.g. on heise-website)\r\n\r\n\r\n##### TO DO:\r\n* Colors of dialog and items do not follow the different themes (dark/light) correctly.\r\n (Should it??? the OptionsMenu (top-right) also stays dark in light-theme... on purpose?)\r\n\r\n\r\n![andr-4 4_mi4_compare](https://cloud.githubusercontent.com/assets/1008399/11189445/64dea64e-8c90-11e5-8c14-2a8ddf0eae1e.png)\r\n`Android KitKat 4.4.4:  before – after`\r\n`a slightly clearer, more harmonic arrangement`\r\n\r\n\r\n![andr-6 0_nexus7-compare](https://cloud.githubusercontent.com/assets/1008399/11189509/bf99aea8-8c90-11e5-8426-62b3236da2c1.png)\r\n\r\n`Android Marshmallow 6.0:  before – after`\r\n`Alt-Text is omitted because it's identical to Image-Filename`\r\n\r\n\r\n\r\nThe numerous language-string.xml-file are in the commit, because i refactor-renamed a key-name. Not sure whether they should have been committed here?!","created_at":"2015-11-16T17:47:53Z","updated_at":"2015-11-16T17:47:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/News-Android-App/pulls/442/commits","review_comments_url":"https://api.github.com/repos/owncloud/News-Android-App/pulls/442/comments","review_comment_url":"https://api.github.com/repos/owncloud/News-Android-App/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/News-Android-App/issues/442/comments","statuses_url":"https://api.github.com/repos/owncloud/News-Android-App/statuses/d90dabaad649370a4f36b6d32770d914b726dbbf","head":{"label":"b3nson:uitweaks-imagedialog","ref":"uitweaks-imagedialog","sha":"d90dabaad649370a4f36b6d32770d914b726dbbf","user":{"login":"b3nson","id":1008399,"avatar_url":"https://avatars.githubusercontent.com/u/1008399?v=3","gravatar_id":"","url":"https://api.github.com/users/b3nson","html_url":"https://github.com/b3nson","followers_url":"https://api.github.com/users/b3nson/followers","following_url":"https://api.github.com/users/b3nson/following{/other_user}","gists_url":"https://api.github.com/users/b3nson/gists{/gist_id}","starred_url":"https://api.github.com/users/b3nson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b3nson/subscriptions","organizations_url":"https://api.github.com/users/b3nson/orgs","repos_url":"https://api.github.com/users/b3nson/repos","events_url":"https://api.github.com/users/b3nson/events{/privacy}","received_events_url":"https://api.github.com/users/b3nson/received_events","type":"User","site_admin":false},"repo":{"id":45529012,"name":"News-Android-App","full_name":"b3nson/News-Android-App","owner":{"login":"b3nson","id":1008399,"avatar_url":"https://avatars.githubusercontent.com/u/1008399?v=3","gravatar_id":"","url":"https://api.github.com/users/b3nson","html_url":"https://github.com/b3nson","followers_url":"https://api.github.com/users/b3nson/followers","following_url":"https://api.github.com/users/b3nson/following{/other_user}","gists_url":"https://api.github.com/users/b3nson/gists{/gist_id}","starred_url":"https://api.github.com/users/b3nson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b3nson/subscriptions","organizations_url":"https://api.github.com/users/b3nson/orgs","repos_url":"https://api.github.com/users/b3nson/repos","events_url":"https://api.github.com/users/b3nson/events{/privacy}","received_events_url":"https://api.github.com/users/b3nson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/b3nson/News-Android-App","description":"","fork":true,"url":"https://api.github.com/repos/b3nson/News-Android-App","forks_url":"https://api.github.com/repos/b3nson/News-Android-App/forks","keys_url":"https://api.github.com/repos/b3nson/News-Android-App/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b3nson/News-Android-App/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b3nson/News-Android-App/teams","hooks_url":"https://api.github.com/repos/b3nson/News-Android-App/hooks","issue_events_url":"https://api.github.com/repos/b3nson/News-Android-App/issues/events{/number}","events_url":"https://api.github.com/repos/b3nson/News-Android-App/events","assignees_url":"https://api.github.com/repos/b3nson/News-Android-App/assignees{/user}","branches_url":"https://api.github.com/repos/b3nson/News-Android-App/branches{/branch}","tags_url":"https://api.github.com/repos/b3nson/News-Android-App/tags","blobs_url":"https://api.github.com/repos/b3nson/News-Android-App/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b3nson/News-Android-App/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b3nson/News-Android-App/git/refs{/sha}","trees_url":"https://api.github.com/repos/b3nson/News-Android-App/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b3nson/News-Android-App/statuses/{sha}","languages_url":"https://api.github.com/repos/b3nson/News-Android-App/languages","stargazers_url":"https://api.github.com/repos/b3nson/News-Android-App/stargazers","contributors_url":"https://api.github.com/repos/b3nson/News-Android-App/contributors","subscribers_url":"https://api.github.com/repos/b3nson/News-Android-App/subscribers","subscription_url":"https://api.github.com/repos/b3nson/News-Android-App/subscription","commits_url":"https://api.github.com/repos/b3nson/News-Android-App/commits{/sha}","git_commits_url":"https://api.github.com/repos/b3nson/News-Android-App/git/commits{/sha}","comments_url":"https://api.github.com/repos/b3nson/News-Android-App/comments{/number}","issue_comment_url":"https://api.github.com/repos/b3nson/News-Android-App/issues/comments{/number}","contents_url":"https://api.github.com/repos/b3nson/News-Android-App/contents/{+path}","compare_url":"https://api.github.com/repos/b3nson/News-Android-App/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b3nson/News-Android-App/merges","archive_url":"https://api.github.com/repos/b3nson/News-Android-App/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b3nson/News-Android-App/downloads","issues_url":"https://api.github.com/repos/b3nson/News-Android-App/issues{/number}","pulls_url":"https://api.github.com/repos/b3nson/News-Android-App/pulls{/number}","milestones_url":"https://api.github.com/repos/b3nson/News-Android-App/milestones{/number}","notifications_url":"https://api.github.com/repos/b3nson/News-Android-App/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b3nson/News-Android-App/labels{/name}","releases_url":"https://api.github.com/repos/b3nson/News-Android-App/releases{/id}","created_at":"2015-11-04T09:37:51Z","updated_at":"2015-11-04T09:37:56Z","pushed_at":"2015-11-16T17:05:27Z","git_url":"git://github.com/b3nson/News-Android-App.git","ssh_url":"git@github.com:b3nson/News-Android-App.git","clone_url":"https://github.com/b3nson/News-Android-App.git","svn_url":"https://github.com/b3nson/News-Android-App","homepage":null,"size":122511,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"c1dee0a040e12840f94abf0b37c573100831d2c9","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":10296149,"name":"News-Android-App","full_name":"owncloud/News-Android-App","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/News-Android-App","description":"","fork":false,"url":"https://api.github.com/repos/owncloud/News-Android-App","forks_url":"https://api.github.com/repos/owncloud/News-Android-App/forks","keys_url":"https://api.github.com/repos/owncloud/News-Android-App/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/News-Android-App/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/News-Android-App/teams","hooks_url":"https://api.github.com/repos/owncloud/News-Android-App/hooks","issue_events_url":"https://api.github.com/repos/owncloud/News-Android-App/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/News-Android-App/events","assignees_url":"https://api.github.com/repos/owncloud/News-Android-App/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/News-Android-App/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/News-Android-App/tags","blobs_url":"https://api.github.com/repos/owncloud/News-Android-App/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/News-Android-App/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/News-Android-App/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/News-Android-App/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/News-Android-App/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/News-Android-App/languages","stargazers_url":"https://api.github.com/repos/owncloud/News-Android-App/stargazers","contributors_url":"https://api.github.com/repos/owncloud/News-Android-App/contributors","subscribers_url":"https://api.github.com/repos/owncloud/News-Android-App/subscribers","subscription_url":"https://api.github.com/repos/owncloud/News-Android-App/subscription","commits_url":"https://api.github.com/repos/owncloud/News-Android-App/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/News-Android-App/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/News-Android-App/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/News-Android-App/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/News-Android-App/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/News-Android-App/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/News-Android-App/merges","archive_url":"https://api.github.com/repos/owncloud/News-Android-App/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/News-Android-App/downloads","issues_url":"https://api.github.com/repos/owncloud/News-Android-App/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/News-Android-App/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/News-Android-App/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/News-Android-App/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/News-Android-App/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/News-Android-App/releases{/id}","created_at":"2013-05-26T09:54:08Z","updated_at":"2015-11-16T02:42:23Z","pushed_at":"2015-11-16T16:07:12Z","git_url":"git://github.com/owncloud/News-Android-App.git","ssh_url":"git@github.com:owncloud/News-Android-App.git","clone_url":"https://github.com/owncloud/News-Android-App.git","svn_url":"https://github.com/owncloud/News-Android-App","homepage":null,"size":122695,"stargazers_count":241,"watchers_count":241,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"open_issues_count":61,"forks":118,"open_issues":61,"watchers":241,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/News-Android-App/pulls/442"},"html":{"href":"https://github.com/owncloud/News-Android-App/pull/442"},"issue":{"href":"https://api.github.com/repos/owncloud/News-Android-App/issues/442"},"comments":{"href":"https://api.github.com/repos/owncloud/News-Android-App/issues/442/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/News-Android-App/pulls/442/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/News-Android-App/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/News-Android-App/pulls/442/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/News-Android-App/statuses/d90dabaad649370a4f36b6d32770d914b726dbbf"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":110,"deletions":101,"changed_files":13}}