{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/39447206","id":39447206,"diff_hunk":"@@ -4,7 +4,8 @@\n             \"underscore\",\n             \"underscore.string\",\n             \"backbone\",\n-            \"text!common/templates/components/system-feedback.underscore\"],\n+            \"text!common/templates/components/system-feedback.underscore\",\n+            \"jquery.ui.selectable\"],","path":"common/static/common/js/components/views/feedback.js","position":6,"original_position":6,"commit_id":"952cc48becbdf2b48c7a85a5d590953bed64e15b","original_commit_id":"952cc48becbdf2b48c7a85a5d590953bed64e15b","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"I didn't realize that you'd bundled it separately from JQuery UI itself. Will it be a problem to load this and the full JQuery UI bundle on the same page?","created_at":"2015-09-14T21:06:54Z","updated_at":"2015-09-14T21:06:54Z","html_url":"https://github.com/edx/edx-platform/pull/9506#discussion_r39447206","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/9506","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/39447206"},"html":{"href":"https://github.com/edx/edx-platform/pull/9506#discussion_r39447206"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9506"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/9506","id":43558739,"html_url":"https://github.com/edx/edx-platform/pull/9506","diff_url":"https://github.com/edx/edx-platform/pull/9506.diff","patch_url":"https://github.com/edx/edx-platform/pull/9506.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/9506","number":9506,"state":"open","locked":false,"title":"Manage focus on delete component modal","user":{"login":"clytwynec","id":3818105,"avatar_url":"https://avatars.githubusercontent.com/u/3818105?v=3","gravatar_id":"","url":"https://api.github.com/users/clytwynec","html_url":"https://github.com/clytwynec","followers_url":"https://api.github.com/users/clytwynec/followers","following_url":"https://api.github.com/users/clytwynec/following{/other_user}","gists_url":"https://api.github.com/users/clytwynec/gists{/gist_id}","starred_url":"https://api.github.com/users/clytwynec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clytwynec/subscriptions","organizations_url":"https://api.github.com/users/clytwynec/orgs","repos_url":"https://api.github.com/users/clytwynec/repos","events_url":"https://api.github.com/users/clytwynec/events{/privacy}","received_events_url":"https://api.github.com/users/clytwynec/received_events","type":"User","site_admin":false},"body":"## Overview\r\n \r\nThis is for [AC-157](https://openedx.atlassian.net/browse/AC-157)\r\n\r\n### Major changes\r\n\r\nUpdates the modal confirmation dialog to follow [WAI-ARIA best practices for modal dialogs](http://www.w3.org/TR/wai-aria-practices/#modal_dialog).  Previously, the focus wasn't being sent to the dialog in when it opened, so navigating to it with a keyboard required tabbing through the whole page.\r\n\r\n## Browsers\r\n\r\nThis work was checked in the following browsers:\r\n\r\n| Platform | Browser | Version | Passed |\r\n|----------|---------|---------|--------|\r\n| Mac      | Chrome  | 45      |  Yes     |\r\n|          | Safari  | 7       |  Yes   |\r\n|          | Firefox | 24      |   Yes   |\r\n| Windows  | Chrome  |45     |  Yes    |\r\n|          | Firefox | 40      |  Yes    |\r\n|          | IE      | 10      |   Yes    |\r\n\r\nNote that on windows, there is some strange behavior with the modal in Chrome if NVDA is in use, but works when it is not.  From what I can tell, NVDA only claims to be compatible with Firefox and IE.\r\n\r\n## Sandbox\r\nstudio: studio-clytwynec.sandbox.edx.org\r\nlms: clytwynec.sandbox.edx.org\r\n\r\n## Reviewers\r\n\r\nThe following reviewers need to provide thumbs before this work can be merged.\r\n\r\n- [ ] @clrux \r\n- [ ] @andy-armstrong \r\n","created_at":"2015-08-27T19:49:07Z","updated_at":"2015-09-14T21:06:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73de1f24e3d05da3b0729c8f257377d2cc3c4e6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/9506/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/9506/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/9506/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/952cc48becbdf2b48c7a85a5d590953bed64e15b","head":{"label":"edx:clytwynec/AC-157","ref":"clytwynec/AC-157","sha":"952cc48becbdf2b48c7a85a5d590953bed64e15b","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-14T20:09:33Z","pushed_at":"2015-09-14T21:05:56Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2110792,"stargazers_count":2118,"watchers_count":2118,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1265,"mirror_url":null,"open_issues_count":159,"forks":1265,"open_issues":159,"watchers":2118,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"12c9d6b52f87cd293de9b2b9dfb3d899e19d5a58","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-09-14T20:09:33Z","pushed_at":"2015-09-14T21:05:56Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":2110792,"stargazers_count":2118,"watchers_count":2118,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1265,"mirror_url":null,"open_issues_count":159,"forks":1265,"open_issues":159,"watchers":2118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9506"},"html":{"href":"https://github.com/edx/edx-platform/pull/9506"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9506"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/9506/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9506/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/9506/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/952cc48becbdf2b48c7a85a5d590953bed64e15b"}}}}