{"action":"created","comment":{"url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/comments/22734300","id":22734300,"diff_hunk":"@@ -1220,6 +1220,11 @@ else if (typeof define === 'function' && define.amd) {\n \n                     self.createLink(this, target, button);\n                 }\n+                else if (e.keyCode === 27) {\n+                    e.preventDefault();\n+                    self.showToolbarActions();\n+                    restoreSelection.call(self, self.savedSelection);","path":"src/js/medium-editor.js","position":7,"original_position":7,"commit_id":"25403fec115d561675c34ba58c09c7b0352c95cd","original_commit_id":"25403fec115d561675c34ba58c09c7b0352c95cd","user":{"login":"nmielnik","id":2444240,"avatar_url":"https://avatars.githubusercontent.com/u/2444240?v=3","gravatar_id":"","url":"https://api.github.com/users/nmielnik","html_url":"https://github.com/nmielnik","followers_url":"https://api.github.com/users/nmielnik/followers","following_url":"https://api.github.com/users/nmielnik/following{/other_user}","gists_url":"https://api.github.com/users/nmielnik/gists{/gist_id}","starred_url":"https://api.github.com/users/nmielnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmielnik/subscriptions","organizations_url":"https://api.github.com/users/nmielnik/orgs","repos_url":"https://api.github.com/users/nmielnik/repos","events_url":"https://api.github.com/users/nmielnik/events{/privacy}","received_events_url":"https://api.github.com/users/nmielnik/received_events","type":"User","site_admin":false},"body":"Agreed, there was actually a typo in my first sentence.  I'm not saying ESC should behave differently than you described, I was suggesting that ESC share a code path with ENTER/RETURN.","created_at":"2015-01-09T18:48:15Z","updated_at":"2015-01-09T18:48:15Z","html_url":"https://github.com/daviferreira/medium-editor/pull/360#discussion_r22734300","pull_request_url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360","_links":{"self":{"href":"https://api.github.com/repos/daviferreira/medium-editor/pulls/comments/22734300"},"html":{"href":"https://github.com/daviferreira/medium-editor/pull/360#discussion_r22734300"},"pull_request":{"href":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360"}}},"pull_request":{"url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360","id":27049374,"html_url":"https://github.com/daviferreira/medium-editor/pull/360","diff_url":"https://github.com/daviferreira/medium-editor/pull/360.diff","patch_url":"https://github.com/daviferreira/medium-editor/pull/360.patch","issue_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/360","number":360,"state":"open","locked":false,"title":"Handle ESC key in link editor","user":{"login":"jbellsey","id":1831399,"avatar_url":"https://avatars.githubusercontent.com/u/1831399?v=3","gravatar_id":"","url":"https://api.github.com/users/jbellsey","html_url":"https://github.com/jbellsey","followers_url":"https://api.github.com/users/jbellsey/followers","following_url":"https://api.github.com/users/jbellsey/following{/other_user}","gists_url":"https://api.github.com/users/jbellsey/gists{/gist_id}","starred_url":"https://api.github.com/users/jbellsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbellsey/subscriptions","organizations_url":"https://api.github.com/users/jbellsey/orgs","repos_url":"https://api.github.com/users/jbellsey/repos","events_url":"https://api.github.com/users/jbellsey/events{/privacy}","received_events_url":"https://api.github.com/users/jbellsey/received_events","type":"User","site_admin":false},"body":"When the link editor is open, let the user hit ESC to close it and return to the main toolbar (just like the X button)","created_at":"2015-01-08T18:37:51Z","updated_at":"2015-01-09T18:48:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbd8b62acbd73be216dda759f0950e0e6b8a776a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360/commits","review_comments_url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360/comments","review_comment_url":"https://api.github.com/repos/daviferreira/medium-editor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/360/comments","statuses_url":"https://api.github.com/repos/daviferreira/medium-editor/statuses/25403fec115d561675c34ba58c09c7b0352c95cd","head":{"label":"jbellsey:master","ref":"master","sha":"25403fec115d561675c34ba58c09c7b0352c95cd","user":{"login":"jbellsey","id":1831399,"avatar_url":"https://avatars.githubusercontent.com/u/1831399?v=3","gravatar_id":"","url":"https://api.github.com/users/jbellsey","html_url":"https://github.com/jbellsey","followers_url":"https://api.github.com/users/jbellsey/followers","following_url":"https://api.github.com/users/jbellsey/following{/other_user}","gists_url":"https://api.github.com/users/jbellsey/gists{/gist_id}","starred_url":"https://api.github.com/users/jbellsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbellsey/subscriptions","organizations_url":"https://api.github.com/users/jbellsey/orgs","repos_url":"https://api.github.com/users/jbellsey/repos","events_url":"https://api.github.com/users/jbellsey/events{/privacy}","received_events_url":"https://api.github.com/users/jbellsey/received_events","type":"User","site_admin":false},"repo":{"id":28979701,"name":"medium-editor","full_name":"jbellsey/medium-editor","owner":{"login":"jbellsey","id":1831399,"avatar_url":"https://avatars.githubusercontent.com/u/1831399?v=3","gravatar_id":"","url":"https://api.github.com/users/jbellsey","html_url":"https://github.com/jbellsey","followers_url":"https://api.github.com/users/jbellsey/followers","following_url":"https://api.github.com/users/jbellsey/following{/other_user}","gists_url":"https://api.github.com/users/jbellsey/gists{/gist_id}","starred_url":"https://api.github.com/users/jbellsey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbellsey/subscriptions","organizations_url":"https://api.github.com/users/jbellsey/orgs","repos_url":"https://api.github.com/users/jbellsey/repos","events_url":"https://api.github.com/users/jbellsey/events{/privacy}","received_events_url":"https://api.github.com/users/jbellsey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbellsey/medium-editor","description":"Medium.com WYSIWYG editor clone.","fork":true,"url":"https://api.github.com/repos/jbellsey/medium-editor","forks_url":"https://api.github.com/repos/jbellsey/medium-editor/forks","keys_url":"https://api.github.com/repos/jbellsey/medium-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbellsey/medium-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbellsey/medium-editor/teams","hooks_url":"https://api.github.com/repos/jbellsey/medium-editor/hooks","issue_events_url":"https://api.github.com/repos/jbellsey/medium-editor/issues/events{/number}","events_url":"https://api.github.com/repos/jbellsey/medium-editor/events","assignees_url":"https://api.github.com/repos/jbellsey/medium-editor/assignees{/user}","branches_url":"https://api.github.com/repos/jbellsey/medium-editor/branches{/branch}","tags_url":"https://api.github.com/repos/jbellsey/medium-editor/tags","blobs_url":"https://api.github.com/repos/jbellsey/medium-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbellsey/medium-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbellsey/medium-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbellsey/medium-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbellsey/medium-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/jbellsey/medium-editor/languages","stargazers_url":"https://api.github.com/repos/jbellsey/medium-editor/stargazers","contributors_url":"https://api.github.com/repos/jbellsey/medium-editor/contributors","subscribers_url":"https://api.github.com/repos/jbellsey/medium-editor/subscribers","subscription_url":"https://api.github.com/repos/jbellsey/medium-editor/subscription","commits_url":"https://api.github.com/repos/jbellsey/medium-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbellsey/medium-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbellsey/medium-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbellsey/medium-editor/issues/comments/{number}","contents_url":"https://api.github.com/repos/jbellsey/medium-editor/contents/{+path}","compare_url":"https://api.github.com/repos/jbellsey/medium-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbellsey/medium-editor/merges","archive_url":"https://api.github.com/repos/jbellsey/medium-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbellsey/medium-editor/downloads","issues_url":"https://api.github.com/repos/jbellsey/medium-editor/issues{/number}","pulls_url":"https://api.github.com/repos/jbellsey/medium-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/jbellsey/medium-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/jbellsey/medium-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbellsey/medium-editor/labels{/name}","releases_url":"https://api.github.com/repos/jbellsey/medium-editor/releases{/id}","created_at":"2015-01-08T18:28:15Z","updated_at":"2015-01-08T18:36:45Z","pushed_at":"2015-01-08T18:36:45Z","git_url":"git://github.com/jbellsey/medium-editor.git","ssh_url":"git@github.com:jbellsey/medium-editor.git","clone_url":"https://github.com/jbellsey/medium-editor.git","svn_url":"https://github.com/jbellsey/medium-editor","homepage":"http://daviferreira.github.io/medium-editor/","size":4922,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"daviferreira:master","ref":"master","sha":"b8199504979172291f7c2c1ac7029c97ed891d3e","user":{"login":"daviferreira","id":38787,"avatar_url":"https://avatars.githubusercontent.com/u/38787?v=3","gravatar_id":"","url":"https://api.github.com/users/daviferreira","html_url":"https://github.com/daviferreira","followers_url":"https://api.github.com/users/daviferreira/followers","following_url":"https://api.github.com/users/daviferreira/following{/other_user}","gists_url":"https://api.github.com/users/daviferreira/gists{/gist_id}","starred_url":"https://api.github.com/users/daviferreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviferreira/subscriptions","organizations_url":"https://api.github.com/users/daviferreira/orgs","repos_url":"https://api.github.com/users/daviferreira/repos","events_url":"https://api.github.com/users/daviferreira/events{/privacy}","received_events_url":"https://api.github.com/users/daviferreira/received_events","type":"User","site_admin":false},"repo":{"id":10365411,"name":"medium-editor","full_name":"daviferreira/medium-editor","owner":{"login":"daviferreira","id":38787,"avatar_url":"https://avatars.githubusercontent.com/u/38787?v=3","gravatar_id":"","url":"https://api.github.com/users/daviferreira","html_url":"https://github.com/daviferreira","followers_url":"https://api.github.com/users/daviferreira/followers","following_url":"https://api.github.com/users/daviferreira/following{/other_user}","gists_url":"https://api.github.com/users/daviferreira/gists{/gist_id}","starred_url":"https://api.github.com/users/daviferreira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviferreira/subscriptions","organizations_url":"https://api.github.com/users/daviferreira/orgs","repos_url":"https://api.github.com/users/daviferreira/repos","events_url":"https://api.github.com/users/daviferreira/events{/privacy}","received_events_url":"https://api.github.com/users/daviferreira/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daviferreira/medium-editor","description":"Medium.com WYSIWYG editor clone.","fork":false,"url":"https://api.github.com/repos/daviferreira/medium-editor","forks_url":"https://api.github.com/repos/daviferreira/medium-editor/forks","keys_url":"https://api.github.com/repos/daviferreira/medium-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daviferreira/medium-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daviferreira/medium-editor/teams","hooks_url":"https://api.github.com/repos/daviferreira/medium-editor/hooks","issue_events_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/events{/number}","events_url":"https://api.github.com/repos/daviferreira/medium-editor/events","assignees_url":"https://api.github.com/repos/daviferreira/medium-editor/assignees{/user}","branches_url":"https://api.github.com/repos/daviferreira/medium-editor/branches{/branch}","tags_url":"https://api.github.com/repos/daviferreira/medium-editor/tags","blobs_url":"https://api.github.com/repos/daviferreira/medium-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daviferreira/medium-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daviferreira/medium-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/daviferreira/medium-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daviferreira/medium-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/daviferreira/medium-editor/languages","stargazers_url":"https://api.github.com/repos/daviferreira/medium-editor/stargazers","contributors_url":"https://api.github.com/repos/daviferreira/medium-editor/contributors","subscribers_url":"https://api.github.com/repos/daviferreira/medium-editor/subscribers","subscription_url":"https://api.github.com/repos/daviferreira/medium-editor/subscription","commits_url":"https://api.github.com/repos/daviferreira/medium-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/daviferreira/medium-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/daviferreira/medium-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/daviferreira/medium-editor/issues/comments/{number}","contents_url":"https://api.github.com/repos/daviferreira/medium-editor/contents/{+path}","compare_url":"https://api.github.com/repos/daviferreira/medium-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daviferreira/medium-editor/merges","archive_url":"https://api.github.com/repos/daviferreira/medium-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daviferreira/medium-editor/downloads","issues_url":"https://api.github.com/repos/daviferreira/medium-editor/issues{/number}","pulls_url":"https://api.github.com/repos/daviferreira/medium-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/daviferreira/medium-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/daviferreira/medium-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daviferreira/medium-editor/labels{/name}","releases_url":"https://api.github.com/repos/daviferreira/medium-editor/releases{/id}","created_at":"2013-05-29T17:40:11Z","updated_at":"2015-01-09T17:18:18Z","pushed_at":"2015-01-06T19:42:55Z","git_url":"git://github.com/daviferreira/medium-editor.git","ssh_url":"git@github.com:daviferreira/medium-editor.git","clone_url":"https://github.com/daviferreira/medium-editor.git","svn_url":"https://github.com/daviferreira/medium-editor","homepage":"http://daviferreira.github.io/medium-editor/","size":4922,"stargazers_count":4305,"watchers_count":4305,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":495,"mirror_url":null,"open_issues_count":94,"forks":495,"open_issues":94,"watchers":4305,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360"},"html":{"href":"https://github.com/daviferreira/medium-editor/pull/360"},"issue":{"href":"https://api.github.com/repos/daviferreira/medium-editor/issues/360"},"comments":{"href":"https://api.github.com/repos/daviferreira/medium-editor/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/daviferreira/medium-editor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/daviferreira/medium-editor/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/daviferreira/medium-editor/statuses/25403fec115d561675c34ba58c09c7b0352c95cd"}}}}