{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/24968490","id":24968490,"diff_hunk":"@@ -54,13 +54,23 @@\n @RunWith(HazelcastParallelClassRunner.class)\n @Category(QuickTest.class)\n public class ClientMapBasicTest {\n+    private static final String KEY = \"key\";\n+    private static final String OLD_VALUE = \"oldValue\";\n+    private static final String NEW_VALUE = \"newValue\";\n \n-    static HazelcastInstance client;\n-    static HazelcastInstance server;\n+    private static HazelcastInstance client;\n+    private static HazelcastInstance server1;\n+    private static HazelcastInstance server2;\n+    private static HazelcastInstance server3;\n+\n+    private String randomMapName = randomString();","path":"hazelcast-client/src/test/java/com/hazelcast/client/map/ClientMapBasicTest.java","position":15,"original_position":15,"commit_id":"8b1ec73eacba266d7f77c45b659e44373c1537f9","original_commit_id":"8b1ec73eacba266d7f77c45b659e44373c1537f9","user":{"login":"pveentjer","id":105243,"avatar_url":"https://avatars.githubusercontent.com/u/105243?v=3","gravatar_id":"","url":"https://api.github.com/users/pveentjer","html_url":"https://github.com/pveentjer","followers_url":"https://api.github.com/users/pveentjer/followers","following_url":"https://api.github.com/users/pveentjer/following{/other_user}","gists_url":"https://api.github.com/users/pveentjer/gists{/gist_id}","starred_url":"https://api.github.com/users/pveentjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pveentjer/subscriptions","organizations_url":"https://api.github.com/users/pveentjer/orgs","repos_url":"https://api.github.com/users/pveentjer/repos","events_url":"https://api.github.com/users/pveentjer/events{/privacy}","received_events_url":"https://api.github.com/users/pveentjer/received_events","type":"User","site_admin":false},"body":"I don't think this is going to work because the test is executed in parallel. So who is going to guarantee that this field isn't shared between threads? So I think this is broken.","created_at":"2015-02-19T06:38:16Z","updated_at":"2015-02-19T06:38:16Z","html_url":"https://github.com/hazelcast/hazelcast/pull/4638#discussion_r24968490","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/24968490"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4638#discussion_r24968490"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638","id":29537514,"html_url":"https://github.com/hazelcast/hazelcast/pull/4638","diff_url":"https://github.com/hazelcast/hazelcast/pull/4638.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/4638.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4638","number":4638,"state":"open","locked":false,"title":"Fixes and cleanup of client map tests.","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"body":"* Fixed ClientMapBasicTest.testValues() which didn't check for the result size (just the content, which is not the same if elements are duplicated in result).\r\n* Fixed ClientMapBasicTest.testValues_withPredicate() which was copied from testKeySet_withPredicate(), but not adapted to use IMap.values().\r\n* Changed ClientMapBasicTest to use 3 member nodes instead of 1. Adapted testMapStatistics_withClientOperations() to deal with multiple members.\r\n* Cleanup of ClientMapBasicTest and ClientTxnMapTest.\r\n\r\nThis PR prepares upcoming changes on IMap.values(), keySet() and entrySet(). Separate PR was made to keep review efforts low.","created_at":"2015-02-18T16:07:05Z","updated_at":"2015-02-19T06:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43991b2ea3cb6afca2fa45c496997cc883c2c045","assignee":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55/labels","id":819785,"number":55,"title":"3.5","description":null,"creator":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":155,"state":"open","created_at":"2014-10-09T13:04:53Z","updated_at":"2015-02-18T19:35:08Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4638/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/8b1ec73eacba266d7f77c45b659e44373c1537f9","head":{"label":"Donnerbart:testCleanupClientBaseMapAndTxn","ref":"testCleanupClientBaseMapAndTxn","sha":"8b1ec73eacba266d7f77c45b659e44373c1537f9","user":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"repo":{"id":13138412,"name":"hazelcast","full_name":"Donnerbart/hazelcast","owner":{"login":"Donnerbart","id":4196298,"avatar_url":"https://avatars.githubusercontent.com/u/4196298?v=3","gravatar_id":"","url":"https://api.github.com/users/Donnerbart","html_url":"https://github.com/Donnerbart","followers_url":"https://api.github.com/users/Donnerbart/followers","following_url":"https://api.github.com/users/Donnerbart/following{/other_user}","gists_url":"https://api.github.com/users/Donnerbart/gists{/gist_id}","starred_url":"https://api.github.com/users/Donnerbart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Donnerbart/subscriptions","organizations_url":"https://api.github.com/users/Donnerbart/orgs","repos_url":"https://api.github.com/users/Donnerbart/repos","events_url":"https://api.github.com/users/Donnerbart/events{/privacy}","received_events_url":"https://api.github.com/users/Donnerbart/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Donnerbart/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/Donnerbart/hazelcast","forks_url":"https://api.github.com/repos/Donnerbart/hazelcast/forks","keys_url":"https://api.github.com/repos/Donnerbart/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Donnerbart/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Donnerbart/hazelcast/teams","hooks_url":"https://api.github.com/repos/Donnerbart/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/Donnerbart/hazelcast/events","assignees_url":"https://api.github.com/repos/Donnerbart/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/Donnerbart/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/tags","blobs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Donnerbart/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/Donnerbart/hazelcast/languages","stargazers_url":"https://api.github.com/repos/Donnerbart/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/Donnerbart/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/Donnerbart/hazelcast/subscription","commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/Donnerbart/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/Donnerbart/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/Donnerbart/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/Donnerbart/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Donnerbart/hazelcast/merges","archive_url":"https://api.github.com/repos/Donnerbart/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Donnerbart/hazelcast/downloads","issues_url":"https://api.github.com/repos/Donnerbart/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/Donnerbart/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/Donnerbart/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/Donnerbart/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Donnerbart/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/Donnerbart/hazelcast/releases{/id}","created_at":"2013-09-27T01:15:56Z","updated_at":"2015-02-17T13:52:32Z","pushed_at":"2015-02-18T16:13:17Z","git_url":"git://github.com/Donnerbart/hazelcast.git","ssh_url":"git@github.com:Donnerbart/hazelcast.git","clone_url":"https://github.com/Donnerbart/hazelcast.git","svn_url":"https://github.com/Donnerbart/hazelcast","homepage":"www.hazelcast.com","size":60609,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"c9786f9e3792d43c530031f5e3de861c6e439146","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-02-18T14:31:49Z","pushed_at":"2015-02-18T14:31:49Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":118526,"stargazers_count":1030,"watchers_count":1030,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":476,"mirror_url":null,"open_issues_count":378,"forks":476,"open_issues":378,"watchers":1030,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4638"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4638"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4638/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4638/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/8b1ec73eacba266d7f77c45b659e44373c1537f9"}}}}