{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/34593591","id":34593591,"diff_hunk":"@@ -0,0 +1,381 @@\n+import {DOM} from 'angular2/src/dom/dom_adapter';\n+import {isPresent, isBlank, BaseException, isArray} from 'angular2/src/facade/lang';\n+import {ListWrapper} from 'angular2/src/facade/collection';\n+\n+import {DomProtoView, DomProtoViewRef, resolveInternalDomProtoView} from './proto_view';\n+import {DomElementBinder} from './element_binder';\n+import {RenderProtoViewMergeMapping, RenderProtoViewRef, ViewType} from '../../api';\n+import {\n+  NG_BINDING_CLASS,\n+  NG_CONTENT_ELEMENT_NAME,\n+  ClonedProtoView,\n+  cloneAndQueryProtoView,\n+  queryBoundElements,\n+  queryBoundTextNodeIndices,\n+  NG_SHADOW_ROOT_ELEMENT_NAME,\n+  isElementWithTag\n+} from '../util';\n+import {CssSelector} from '../compiler/selector';\n+\n+const NOT_MATCHABLE_SELECTOR = '_not-matchable_';\n+\n+export function mergeProtoViewsRecursively(protoViewRefs: List<RenderProtoViewRef | List<any>>):\n+    RenderProtoViewMergeMapping[] {\n+  var targetReversed = [];\n+  _mergeProtoViewsRecursively(protoViewRefs, targetReversed);\n+  targetReversed.reverse();\n+  return targetReversed;\n+}\n+\n+function _mergeProtoViewsRecursively(protoViewRefs: List<RenderProtoViewRef | List<any>>,\n+                                     targetReversed: RenderProtoViewMergeMapping[]):\n+    RenderProtoViewRef {\n+  var resolvedProtoViewRefs = protoViewRefs.map((entry) => {\n+    if (isArray(entry)) {\n+      return _mergeProtoViewsRecursively(<List<any>>entry, targetReversed);\n+    } else {\n+      return entry;\n+    }\n+  });\n+  var mapping = mergeProtoViews(resolvedProtoViewRefs);\n+  targetReversed.push(mapping);\n+  return mapping.mergedProtoViewRef;\n+}\n+\n+export function mergeProtoViews(protoViewRefs: RenderProtoViewRef[]): RenderProtoViewMergeMapping {\n+  var hostProtoView = resolveInternalDomProtoView(protoViewRefs[0]);\n+\n+  var mergeableProtoViews: DomProtoView[] = [];\n+  var hostElementIndices: number[] = [];\n+\n+  mergeableProtoViews.push(hostProtoView);\n+  var protoViewIdx = 1;\n+  for (var i = 0; i < hostProtoView.elementBinders.length; i++) {\n+    var binder = hostProtoView.elementBinders[i];\n+    if (binder.hasNestedProtoView) {\n+      var nestedProtoViewRef = protoViewRefs[protoViewIdx++];\n+      if (isPresent(nestedProtoViewRef)) {\n+        mergeableProtoViews.push(resolveInternalDomProtoView(nestedProtoViewRef));\n+        hostElementIndices.push(i);\n+      }\n+    }\n+  }\n+  return _mergeProtoViews(mergeableProtoViews, hostElementIndices);\n+}\n+\n+\n+function _mergeProtoViews(mergeableProtoViews: DomProtoView[], hostElementIndices: number[]):\n+    RenderProtoViewMergeMapping {\n+  var clonedProtoViews: ClonedProtoView[] =\n+      mergeableProtoViews.map(domProtoView => cloneAndQueryProtoView(domProtoView, false));\n+  var hostProtoView: ClonedProtoView = clonedProtoViews[0];\n+\n+  // index bound elements and bound text nodes\n+  var elementBinderByElement: Map<Element, DomElementBinder> =\n+      indexElementBindersByElement(clonedProtoViews);\n+  var nestedProtoViewByHostElement: Map<Element, ClonedProtoView> =\n+      indexProtoViewsByHostElement(clonedProtoViews, hostElementIndices);\n+  var boundTextNodeMap: Map<Node, any> = indexBoundTextNodes(clonedProtoViews);\n+\n+\n+  // modify fragments","path":"modules/angular2/src/render/dom/view/proto_view_merger.ts","position":81,"original_position":81,"commit_id":"3d16356cf422ae20226aea4c82bd029f3c5530af","original_commit_id":"3d16356cf422ae20226aea4c82bd029f3c5530af","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"modify `hostProtoView`","created_at":"2015-07-14T17:17:07Z","updated_at":"2015-07-14T17:17:07Z","html_url":"https://github.com/angular/angular/pull/2839#discussion_r34593591","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/2839","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/34593591"},"html":{"href":"https://github.com/angular/angular/pull/2839#discussion_r34593591"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/2839"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/2839","id":39036374,"html_url":"https://github.com/angular/angular/pull/2839","diff_url":"https://github.com/angular/angular/pull/2839.diff","patch_url":"https://github.com/angular/angular/pull/2839.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/2839","number":2839,"state":"open","locked":false,"title":"feat(compiler): content projection during compile","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"body":"Closes #2529\r\n\r\nBREAKING CHANGES:\r\n- shadow dom emulation no longer\r\n  supports the `<content>` tag. Use the new `<ng-content>` instead\r\n  (works with all shadow dom strategies).\r\n- removed `DomRenderer.setViewRootNodes` and `AppViewManager.getComponentView`\r\n  -> use `DomRenderer.getNativeElementSync(elementRef)` and change shadow dom directly\r\n- the `Renderer` interface has changed:\r\n  * `createView` now also has to support sub views\r\n  * the notion of a container has been removed. Instead, the renderer has\r\n    to implement methods to attach views next to elements or other views.\r\n  * a RenderView now contains multiple RenderFragments. Fragments\r\n    are used to move DOM nodes around.\r\n\r\nInternal changes:\r\n- ProtoViews always have a `<template>` element as root\r\n  * needed for storing subviews\r\n  * we have less chunks of DOM to clone now\r\n- eemove fake ElementBinder / Bound element for root text bindings\r\n  and model them explicitly. This removes a lot of special cases we had!\r\n- some methods in AppViewManager (create, hydrate, dehydrate) are iterative now\r\n  * now possible as we have all child AppViews / ElementRefs already in an array!","created_at":"2015-07-01T23:46:03Z","updated_at":"2015-07-14T17:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"52557cf2260132107660a1097de1e72dccd1c1ca","assignee":{"login":"vsavkin","id":35996,"avatar_url":"https://avatars.githubusercontent.com/u/35996?v=3","gravatar_id":"","url":"https://api.github.com/users/vsavkin","html_url":"https://github.com/vsavkin","followers_url":"https://api.github.com/users/vsavkin/followers","following_url":"https://api.github.com/users/vsavkin/following{/other_user}","gists_url":"https://api.github.com/users/vsavkin/gists{/gist_id}","starred_url":"https://api.github.com/users/vsavkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsavkin/subscriptions","organizations_url":"https://api.github.com/users/vsavkin/orgs","repos_url":"https://api.github.com/users/vsavkin/repos","events_url":"https://api.github.com/users/vsavkin/events{/privacy}","received_events_url":"https://api.github.com/users/vsavkin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/2839/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/2839/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/2839/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/3d16356cf422ae20226aea4c82bd029f3c5530af","head":{"label":"tbosch:render-project","ref":"render-project","sha":"3d16356cf422ae20226aea4c82bd029f3c5530af","user":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"repo":{"id":24733374,"name":"angular","full_name":"tbosch/angular","owner":{"login":"tbosch","id":690815,"avatar_url":"https://avatars.githubusercontent.com/u/690815?v=3","gravatar_id":"","url":"https://api.github.com/users/tbosch","html_url":"https://github.com/tbosch","followers_url":"https://api.github.com/users/tbosch/followers","following_url":"https://api.github.com/users/tbosch/following{/other_user}","gists_url":"https://api.github.com/users/tbosch/gists{/gist_id}","starred_url":"https://api.github.com/users/tbosch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbosch/subscriptions","organizations_url":"https://api.github.com/users/tbosch/orgs","repos_url":"https://api.github.com/users/tbosch/repos","events_url":"https://api.github.com/users/tbosch/events{/privacy}","received_events_url":"https://api.github.com/users/tbosch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tbosch/angular","description":"","fork":true,"url":"https://api.github.com/repos/tbosch/angular","forks_url":"https://api.github.com/repos/tbosch/angular/forks","keys_url":"https://api.github.com/repos/tbosch/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tbosch/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tbosch/angular/teams","hooks_url":"https://api.github.com/repos/tbosch/angular/hooks","issue_events_url":"https://api.github.com/repos/tbosch/angular/issues/events{/number}","events_url":"https://api.github.com/repos/tbosch/angular/events","assignees_url":"https://api.github.com/repos/tbosch/angular/assignees{/user}","branches_url":"https://api.github.com/repos/tbosch/angular/branches{/branch}","tags_url":"https://api.github.com/repos/tbosch/angular/tags","blobs_url":"https://api.github.com/repos/tbosch/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tbosch/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tbosch/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/tbosch/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tbosch/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/tbosch/angular/languages","stargazers_url":"https://api.github.com/repos/tbosch/angular/stargazers","contributors_url":"https://api.github.com/repos/tbosch/angular/contributors","subscribers_url":"https://api.github.com/repos/tbosch/angular/subscribers","subscription_url":"https://api.github.com/repos/tbosch/angular/subscription","commits_url":"https://api.github.com/repos/tbosch/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/tbosch/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/tbosch/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/tbosch/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/tbosch/angular/contents/{+path}","compare_url":"https://api.github.com/repos/tbosch/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tbosch/angular/merges","archive_url":"https://api.github.com/repos/tbosch/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tbosch/angular/downloads","issues_url":"https://api.github.com/repos/tbosch/angular/issues{/number}","pulls_url":"https://api.github.com/repos/tbosch/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/tbosch/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/tbosch/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tbosch/angular/labels{/name}","releases_url":"https://api.github.com/repos/tbosch/angular/releases{/id}","created_at":"2014-10-02T19:30:59Z","updated_at":"2015-06-02T21:15:59Z","pushed_at":"2015-07-14T00:33:28Z","git_url":"git://github.com/tbosch/angular.git","ssh_url":"git@github.com:tbosch/angular.git","clone_url":"https://github.com/tbosch/angular.git","svn_url":"https://github.com/tbosch/angular","homepage":null,"size":11118,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"5677bf73ca63c4d4c8e03cfcb4dfd115d2d72a39","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-07-14T16:20:31Z","pushed_at":"2015-07-14T16:55:00Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":34407,"stargazers_count":4200,"watchers_count":4200,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1094,"mirror_url":null,"open_issues_count":374,"forks":1094,"open_issues":374,"watchers":4200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/2839"},"html":{"href":"https://github.com/angular/angular/pull/2839"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/2839"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/2839/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/2839/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/2839/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/3d16356cf422ae20226aea4c82bd029f3c5530af"}}}}