{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2828","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2828/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2828/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2828/events","html_url":"https://github.com/FreeRDP/FreeRDP/issues/2828","id":100020697,"number":2828,"title":"TLS 1.2","user":{"login":"lemonmojo","id":186198,"avatar_url":"https://avatars.githubusercontent.com/u/186198?v=3","gravatar_id":"","url":"https://api.github.com/users/lemonmojo","html_url":"https://github.com/lemonmojo","followers_url":"https://api.github.com/users/lemonmojo/followers","following_url":"https://api.github.com/users/lemonmojo/following{/other_user}","gists_url":"https://api.github.com/users/lemonmojo/gists{/gist_id}","starred_url":"https://api.github.com/users/lemonmojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemonmojo/subscriptions","organizations_url":"https://api.github.com/users/lemonmojo/orgs","repos_url":"https://api.github.com/users/lemonmojo/repos","events_url":"https://api.github.com/users/lemonmojo/events{/privacy}","received_events_url":"https://api.github.com/users/lemonmojo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones/7","html_url":"https://github.com/FreeRDP/FreeRDP/milestones/2.0","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones/7/labels","id":1156911,"number":7,"title":"2.0","description":"","creator":{"login":"hardening","id":3237998,"avatar_url":"https://avatars.githubusercontent.com/u/3237998?v=3","gravatar_id":"","url":"https://api.github.com/users/hardening","html_url":"https://github.com/hardening","followers_url":"https://api.github.com/users/hardening/followers","following_url":"https://api.github.com/users/hardening/following{/other_user}","gists_url":"https://api.github.com/users/hardening/gists{/gist_id}","starred_url":"https://api.github.com/users/hardening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hardening/subscriptions","organizations_url":"https://api.github.com/users/hardening/orgs","repos_url":"https://api.github.com/users/hardening/repos","events_url":"https://api.github.com/users/hardening/events{/privacy}","received_events_url":"https://api.github.com/users/hardening/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":2,"state":"open","created_at":"2015-06-09T14:22:29Z","updated_at":"2015-12-10T08:15:09Z","due_on":null,"closed_at":null},"comments":21,"created_at":"2015-08-10T09:42:04Z","updated_at":"2015-12-11T15:26:37Z","closed_at":null,"body":"I'm currently trying to get a TLS 1.2 only connection working using FreeRDP.\r\nThe target machine is Windows Server 2012 R2 Core and I've deselected TLS 1.0 and TLS 1.1 using IIS Crypto (https://www.nartac.com/Products/IISCrypto).\r\n\r\nI'm able to connect from a Windows 8.1 box using mstsc and I've verified that TLS 1.2 is indeed being used by enabling Schannel logging on the target machine (https://support.microsoft.com/en-us/kb/260729).\r\n\r\nUnfortunately, I can't say the same about FreeRDP. Just compiled master with OpenSSL 1.0.2d (also tried 1.0.2a) and here's the output I get when trying to connect: https://gist.github.com/lemonmojo/a6f7f3b7680555b2bd1a\r\n\r\nOn the server there are no Schannel related event entries so it seems to fail early on."},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/163963477","html_url":"https://github.com/FreeRDP/FreeRDP/issues/2828#issuecomment-163963477","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/2828","id":163963477,"user":{"login":"zonywhoop","id":960482,"avatar_url":"https://avatars.githubusercontent.com/u/960482?v=3","gravatar_id":"","url":"https://api.github.com/users/zonywhoop","html_url":"https://github.com/zonywhoop","followers_url":"https://api.github.com/users/zonywhoop/followers","following_url":"https://api.github.com/users/zonywhoop/following{/other_user}","gists_url":"https://api.github.com/users/zonywhoop/gists{/gist_id}","starred_url":"https://api.github.com/users/zonywhoop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zonywhoop/subscriptions","organizations_url":"https://api.github.com/users/zonywhoop/orgs","repos_url":"https://api.github.com/users/zonywhoop/repos","events_url":"https://api.github.com/users/zonywhoop/events{/privacy}","received_events_url":"https://api.github.com/users/zonywhoop/received_events","type":"User","site_admin":false},"created_at":"2015-12-11T15:26:37Z","updated_at":"2015-12-11T15:26:37Z","body":"Just for reference, I'm using RoyalTSX with the SSLv23_client_method enabled and connecting to servers using 2008 through 2012R2 and clients using Windows 7 - 10 with no problems.  This is both in environments where we enforce TLS 1.2 (and disable all others) and where no changes have been made to Windows.\n\nJust my bitcoin :)\n\n--\nEd McLain\ned@edmclain.com\n\n\n\n\n> On Dec 11, 2015, at 9:21 AM, Bernhard Miklautz <notifications@github.com> wrote:\n> \n> @imp1sh <https://github.com/imp1sh> if you \"just\" can provide a solution that satisfies everyone we'll gladly accept it ;). Joke beside. Just wildly changing the client method without in depth testing might break connections to other and/or old servers. The main problem is that most currently servers use TLS < 1.2 changing the client method to SSLv23_client_method should basically work but isn't tested in depth (yet). And since TLS < 1.2 is the (unfortunately) majority at the moment it's still better to have some people that get their hands dirty than a lot of ...\n> If it's really such a big problem for you to apply this patch I gladly prepare a special branch where this is applied -( until it was tested and added on master).\n> \n> —\n> Reply to this email directly or view it on GitHub <https://github.com/FreeRDP/FreeRDP/issues/2828#issuecomment-163961955>.\n> \n\n"}}