{"action":"created","comment":{"url":"https://api.github.com/repos/radare/radare2/pulls/comments/37700237","id":37700237,"diff_hunk":"@@ -183,15 +183,9 @@ static int esil_internal_carry_check (RAnalEsil *esil, ut8 bit) {\n \n static int esil_internal_parity_check (RAnalEsil *esil) {\n \t// Set if the number of set bits in the least significant byte is a multiple of 2.\n-\tint bits = 1;\n-\tbits ^= esil->cur & (ut64)   1;\n-\tbits ^= esil->cur & (ut64) ( 1 << 1 );\n-\tbits ^= esil->cur & (ut64) ( 1 << 2 );\n-\tbits ^= esil->cur & (ut64) ( 1 << 3 );\n-\tbits ^= esil->cur & (ut64) ( 1 << 4 );\n-\tbits ^= esil->cur & (ut64) ( 1 << 5 );\n-\tbits ^= esil->cur & (ut64) ( 1 << 6 );\n-\tbits ^= esil->cur & (ut64) ( 1 << 7 );\n+\tint i, bits = 0;\n+\tfor (i = 0; i < 8; i++)\n+\t\tbits ^= ((esil->cur & (1<<i))>>i);","path":"libr/anal/esil.c","position":15,"original_position":15,"commit_id":"108f678ae8f8fba3f724de9be95f6fd55dc89ca3","original_commit_id":"108f678ae8f8fba3f724de9be95f6fd55dc89ca3","user":{"login":"ret2libc","id":562321,"avatar_url":"https://avatars.githubusercontent.com/u/562321?v=3","gravatar_id":"","url":"https://api.github.com/users/ret2libc","html_url":"https://github.com/ret2libc","followers_url":"https://api.github.com/users/ret2libc/followers","following_url":"https://api.github.com/users/ret2libc/following{/other_user}","gists_url":"https://api.github.com/users/ret2libc/gists{/gist_id}","starred_url":"https://api.github.com/users/ret2libc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ret2libc/subscriptions","organizations_url":"https://api.github.com/users/ret2libc/orgs","repos_url":"https://api.github.com/users/ret2libc/repos","events_url":"https://api.github.com/users/ret2libc/events{/privacy}","received_events_url":"https://api.github.com/users/ret2libc/received_events","type":"User","site_admin":false},"body":"spaces around operators.\r\n```bits ^= ((esil->cur & (1 << i)) >> i);```","created_at":"2015-08-22T22:02:50Z","updated_at":"2015-08-22T22:02:50Z","html_url":"https://github.com/radare/radare2/pull/3140#discussion_r37700237","pull_request_url":"https://api.github.com/repos/radare/radare2/pulls/3140","_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments/37700237"},"html":{"href":"https://github.com/radare/radare2/pull/3140#discussion_r37700237"},"pull_request":{"href":"https://api.github.com/repos/radare/radare2/pulls/3140"}}},"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/3140","id":43110970,"html_url":"https://github.com/radare/radare2/pull/3140","diff_url":"https://github.com/radare/radare2/pull/3140.diff","patch_url":"https://github.com/radare/radare2/pull/3140.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/3140","number":3140,"state":"open","locked":false,"title":"fix esil-paritiy-stuff","user":{"login":"condret","id":5904302,"avatar_url":"https://avatars.githubusercontent.com/u/5904302?v=3","gravatar_id":"","url":"https://api.github.com/users/condret","html_url":"https://github.com/condret","followers_url":"https://api.github.com/users/condret/followers","following_url":"https://api.github.com/users/condret/following{/other_user}","gists_url":"https://api.github.com/users/condret/gists{/gist_id}","starred_url":"https://api.github.com/users/condret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/condret/subscriptions","organizations_url":"https://api.github.com/users/condret/orgs","repos_url":"https://api.github.com/users/condret/repos","events_url":"https://api.github.com/users/condret/events{/privacy}","received_events_url":"https://api.github.com/users/condret/received_events","type":"User","site_admin":false},"body":"my attempt to fix dat","created_at":"2015-08-22T21:53:17Z","updated_at":"2015-08-22T22:02:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f0057a766c928b024903325f630fe9e3fd6b324","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/3140/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/3140/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/3140/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/108f678ae8f8fba3f724de9be95f6fd55dc89ca3","head":{"label":"condret:master","ref":"master","sha":"108f678ae8f8fba3f724de9be95f6fd55dc89ca3","user":{"login":"condret","id":5904302,"avatar_url":"https://avatars.githubusercontent.com/u/5904302?v=3","gravatar_id":"","url":"https://api.github.com/users/condret","html_url":"https://github.com/condret","followers_url":"https://api.github.com/users/condret/followers","following_url":"https://api.github.com/users/condret/following{/other_user}","gists_url":"https://api.github.com/users/condret/gists{/gist_id}","starred_url":"https://api.github.com/users/condret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/condret/subscriptions","organizations_url":"https://api.github.com/users/condret/orgs","repos_url":"https://api.github.com/users/condret/repos","events_url":"https://api.github.com/users/condret/events{/privacy}","received_events_url":"https://api.github.com/users/condret/received_events","type":"User","site_admin":false},"repo":{"id":23113503,"name":"radare2","full_name":"condret/radare2","owner":{"login":"condret","id":5904302,"avatar_url":"https://avatars.githubusercontent.com/u/5904302?v=3","gravatar_id":"","url":"https://api.github.com/users/condret","html_url":"https://github.com/condret","followers_url":"https://api.github.com/users/condret/followers","following_url":"https://api.github.com/users/condret/following{/other_user}","gists_url":"https://api.github.com/users/condret/gists{/gist_id}","starred_url":"https://api.github.com/users/condret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/condret/subscriptions","organizations_url":"https://api.github.com/users/condret/orgs","repos_url":"https://api.github.com/users/condret/repos","events_url":"https://api.github.com/users/condret/events{/privacy}","received_events_url":"https://api.github.com/users/condret/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/condret/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/condret/radare2","forks_url":"https://api.github.com/repos/condret/radare2/forks","keys_url":"https://api.github.com/repos/condret/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/condret/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/condret/radare2/teams","hooks_url":"https://api.github.com/repos/condret/radare2/hooks","issue_events_url":"https://api.github.com/repos/condret/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/condret/radare2/events","assignees_url":"https://api.github.com/repos/condret/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/condret/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/condret/radare2/tags","blobs_url":"https://api.github.com/repos/condret/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/condret/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/condret/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/condret/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/condret/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/condret/radare2/languages","stargazers_url":"https://api.github.com/repos/condret/radare2/stargazers","contributors_url":"https://api.github.com/repos/condret/radare2/contributors","subscribers_url":"https://api.github.com/repos/condret/radare2/subscribers","subscription_url":"https://api.github.com/repos/condret/radare2/subscription","commits_url":"https://api.github.com/repos/condret/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/condret/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/condret/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/condret/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/condret/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/condret/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/condret/radare2/merges","archive_url":"https://api.github.com/repos/condret/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/condret/radare2/downloads","issues_url":"https://api.github.com/repos/condret/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/condret/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/condret/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/condret/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/condret/radare2/labels{/name}","releases_url":"https://api.github.com/repos/condret/radare2/releases{/id}","created_at":"2014-08-19T14:36:41Z","updated_at":"2015-04-29T16:31:59Z","pushed_at":"2015-08-22T21:52:05Z","git_url":"git://github.com/condret/radare2.git","ssh_url":"git@github.com:condret/radare2.git","clone_url":"https://github.com/condret/radare2.git","svn_url":"https://github.com/condret/radare2","homepage":"http://www.radare.org/","size":51925,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"00256ad1e5b5a323381bdbf5ecb3034a22bd45e3","user":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars.githubusercontent.com/u/917142?v=3","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","created_at":"2012-07-03T07:42:26Z","updated_at":"2015-08-22T14:48:34Z","pushed_at":"2015-08-22T21:53:17Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":83067,"stargazers_count":1524,"watchers_count":1524,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":327,"mirror_url":null,"open_issues_count":511,"forks":327,"open_issues":511,"watchers":1524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/3140"},"html":{"href":"https://github.com/radare/radare2/pull/3140"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/3140"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/3140/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/3140/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/3140/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/108f678ae8f8fba3f724de9be95f6fd55dc89ca3"}}}}