{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/32758971","id":32758971,"diff_hunk":"@@ -0,0 +1,184 @@\n+\"use strict\";\n+(function (root, factory) {\n+    if (typeof define === \"function\" && define.amd) {\n+        define([\"d3\", \"../common/SVGWidget\", \"./XYAxis\", \"../api/INDChart\", \"css!./Scatter\"], factory);\n+    } else {\n+        root.chart_Column = factory(root.d3, root.common_SVGWidget, root.chart_XYAxis, root.api_INDChart);\n+    }\n+}(this, function (d3, SVGWidget, XYAxis, INDChart) {\n+    function Scatter(target) {\n+        XYAxis.call(this);\n+        INDChart.call(this);\n+    }\n+    Scatter.prototype = Object.create(XYAxis.prototype);\n+    Scatter.prototype._class += \" chart_Scatter\";\n+    Scatter.prototype.implements(INDChart.prototype);\n+\n+    Scatter.prototype.publish(\"paletteID\", \"default\", \"set\", \"Palette ID\", Scatter.prototype._palette.switch(),{tags:['Basic','Shared']});\n+    Scatter.prototype.publish(\"pointShape\", \"cross\", \"set\", \"Shape of the data points\", [\"circle\", \"rectangle\", \"cross\"]);\n+    Scatter.prototype.publish(\"pointSize\", 8, \"number\", \"Point Size\");\n+\n+    Scatter.prototype.updateChart = function (domNode, element, margin, width, height) {\n+        var context = this;\n+\n+        this._palette = this._palette.switch(this.paletteID());\n+\n+        if (this._prevPointShape !== this.pointSize()) {","path":"src/chart/Scatter.js","position":26,"original_position":26,"commit_id":"1f34d85097429c3e792da77cd421795f3ef390b8","original_commit_id":"1f34d85097429c3e792da77cd421795f3ef390b8","user":{"login":"GordonSmith","id":966863,"avatar_url":"https://avatars.githubusercontent.com/u/966863?v=3","gravatar_id":"","url":"https://api.github.com/users/GordonSmith","html_url":"https://github.com/GordonSmith","followers_url":"https://api.github.com/users/GordonSmith/followers","following_url":"https://api.github.com/users/GordonSmith/following{/other_user}","gists_url":"https://api.github.com/users/GordonSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/GordonSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GordonSmith/subscriptions","organizations_url":"https://api.github.com/users/GordonSmith/orgs","repos_url":"https://api.github.com/users/GordonSmith/repos","events_url":"https://api.github.com/users/GordonSmith/events{/privacy}","received_events_url":"https://api.github.com/users/GordonSmith/received_events","type":"User","site_admin":false},"body":"Should be ```pointShape()```","created_at":"2015-06-18T18:00:08Z","updated_at":"2015-06-18T18:00:08Z","html_url":"https://github.com/hpcc-systems/Visualization/pull/504#discussion_r32758971","pull_request_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments/32758971"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/504#discussion_r32758971"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504"}}},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504","id":38016780,"html_url":"https://github.com/hpcc-systems/Visualization/pull/504","diff_url":"https://github.com/hpcc-systems/Visualization/pull/504.diff","patch_url":"https://github.com/hpcc-systems/Visualization/pull/504.patch","issue_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/504","number":504,"state":"open","locked":false,"title":"GH-495 Adds the Scatter Chart","user":{"login":"anmoljagetia","id":6505326,"avatar_url":"https://avatars.githubusercontent.com/u/6505326?v=3","gravatar_id":"","url":"https://api.github.com/users/anmoljagetia","html_url":"https://github.com/anmoljagetia","followers_url":"https://api.github.com/users/anmoljagetia/followers","following_url":"https://api.github.com/users/anmoljagetia/following{/other_user}","gists_url":"https://api.github.com/users/anmoljagetia/gists{/gist_id}","starred_url":"https://api.github.com/users/anmoljagetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmoljagetia/subscriptions","organizations_url":"https://api.github.com/users/anmoljagetia/orgs","repos_url":"https://api.github.com/users/anmoljagetia/repos","events_url":"https://api.github.com/users/anmoljagetia/events{/privacy}","received_events_url":"https://api.github.com/users/anmoljagetia/received_events","type":"User","site_admin":false},"body":"@GordonSmith @mlzummo Please review.\r\n\r\nDemo at : http://rawgit.com/anmoljagetia/Visualization/scatterPlot/demos/dermatology.html?src/chart/Scatter\r\nFixed GH-495\r\nSigned-off-by: Anmol Jagetia <anmoljagetia@gmail.com>\r\n\r\n","created_at":"2015-06-18T15:05:49Z","updated_at":"2015-06-18T18:00:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"247ab2789ad384bf467d2b38bb9d8278aa7c045c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/504/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/1f34d85097429c3e792da77cd421795f3ef390b8","head":{"label":"anmoljagetia:scatterPlot","ref":"scatterPlot","sha":"1f34d85097429c3e792da77cd421795f3ef390b8","user":{"login":"anmoljagetia","id":6505326,"avatar_url":"https://avatars.githubusercontent.com/u/6505326?v=3","gravatar_id":"","url":"https://api.github.com/users/anmoljagetia","html_url":"https://github.com/anmoljagetia","followers_url":"https://api.github.com/users/anmoljagetia/followers","following_url":"https://api.github.com/users/anmoljagetia/following{/other_user}","gists_url":"https://api.github.com/users/anmoljagetia/gists{/gist_id}","starred_url":"https://api.github.com/users/anmoljagetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmoljagetia/subscriptions","organizations_url":"https://api.github.com/users/anmoljagetia/orgs","repos_url":"https://api.github.com/users/anmoljagetia/repos","events_url":"https://api.github.com/users/anmoljagetia/events{/privacy}","received_events_url":"https://api.github.com/users/anmoljagetia/received_events","type":"User","site_admin":false},"repo":{"id":35345351,"name":"Visualization","full_name":"anmoljagetia/Visualization","owner":{"login":"anmoljagetia","id":6505326,"avatar_url":"https://avatars.githubusercontent.com/u/6505326?v=3","gravatar_id":"","url":"https://api.github.com/users/anmoljagetia","html_url":"https://github.com/anmoljagetia","followers_url":"https://api.github.com/users/anmoljagetia/followers","following_url":"https://api.github.com/users/anmoljagetia/following{/other_user}","gists_url":"https://api.github.com/users/anmoljagetia/gists{/gist_id}","starred_url":"https://api.github.com/users/anmoljagetia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anmoljagetia/subscriptions","organizations_url":"https://api.github.com/users/anmoljagetia/orgs","repos_url":"https://api.github.com/users/anmoljagetia/repos","events_url":"https://api.github.com/users/anmoljagetia/events{/privacy}","received_events_url":"https://api.github.com/users/anmoljagetia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anmoljagetia/Visualization","description":"Common Visualization Components","fork":true,"url":"https://api.github.com/repos/anmoljagetia/Visualization","forks_url":"https://api.github.com/repos/anmoljagetia/Visualization/forks","keys_url":"https://api.github.com/repos/anmoljagetia/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anmoljagetia/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anmoljagetia/Visualization/teams","hooks_url":"https://api.github.com/repos/anmoljagetia/Visualization/hooks","issue_events_url":"https://api.github.com/repos/anmoljagetia/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/anmoljagetia/Visualization/events","assignees_url":"https://api.github.com/repos/anmoljagetia/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/anmoljagetia/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/anmoljagetia/Visualization/tags","blobs_url":"https://api.github.com/repos/anmoljagetia/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anmoljagetia/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anmoljagetia/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/anmoljagetia/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anmoljagetia/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/anmoljagetia/Visualization/languages","stargazers_url":"https://api.github.com/repos/anmoljagetia/Visualization/stargazers","contributors_url":"https://api.github.com/repos/anmoljagetia/Visualization/contributors","subscribers_url":"https://api.github.com/repos/anmoljagetia/Visualization/subscribers","subscription_url":"https://api.github.com/repos/anmoljagetia/Visualization/subscription","commits_url":"https://api.github.com/repos/anmoljagetia/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/anmoljagetia/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/anmoljagetia/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/anmoljagetia/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/anmoljagetia/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/anmoljagetia/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anmoljagetia/Visualization/merges","archive_url":"https://api.github.com/repos/anmoljagetia/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anmoljagetia/Visualization/downloads","issues_url":"https://api.github.com/repos/anmoljagetia/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/anmoljagetia/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/anmoljagetia/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/anmoljagetia/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anmoljagetia/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/anmoljagetia/Visualization/releases{/id}","created_at":"2015-05-09T21:01:51Z","updated_at":"2015-05-09T21:01:52Z","pushed_at":"2015-06-18T16:20:58Z","git_url":"git://github.com/anmoljagetia/Visualization.git","ssh_url":"git@github.com:anmoljagetia/Visualization.git","clone_url":"https://github.com/anmoljagetia/Visualization.git","svn_url":"https://github.com/anmoljagetia/Visualization","homepage":"","size":4563,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master1"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"bafeccc4007b97363d43e91194ccc80f1a78288e","user":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":22117259,"name":"Visualization","full_name":"hpcc-systems/Visualization","owner":{"login":"hpcc-systems","id":900867,"avatar_url":"https://avatars.githubusercontent.com/u/900867?v=3","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpcc-systems/Visualization","description":"Common Visualization Components","fork":false,"url":"https://api.github.com/repos/hpcc-systems/Visualization","forks_url":"https://api.github.com/repos/hpcc-systems/Visualization/forks","keys_url":"https://api.github.com/repos/hpcc-systems/Visualization/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/Visualization/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/Visualization/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/Visualization/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/Visualization/events","assignees_url":"https://api.github.com/repos/hpcc-systems/Visualization/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/Visualization/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/Visualization/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/Visualization/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/Visualization/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/Visualization/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/Visualization/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/Visualization/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/Visualization/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/Visualization/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/Visualization/merges","archive_url":"https://api.github.com/repos/hpcc-systems/Visualization/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/Visualization/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/Visualization/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/Visualization/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/Visualization/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/Visualization/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/Visualization/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/Visualization/releases{/id}","created_at":"2014-07-22T19:13:04Z","updated_at":"2015-06-07T23:12:01Z","pushed_at":"2015-06-18T17:58:13Z","git_url":"git://github.com/hpcc-systems/Visualization.git","ssh_url":"git@github.com:hpcc-systems/Visualization.git","clone_url":"https://github.com/hpcc-systems/Visualization.git","svn_url":"https://github.com/hpcc-systems/Visualization","homepage":"","size":14281,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":34,"forks":18,"open_issues":34,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504"},"html":{"href":"https://github.com/hpcc-systems/Visualization/pull/504"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/504"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/Visualization/statuses/1f34d85097429c3e792da77cd421795f3ef390b8"}}}}