{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/344","labels_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/344/comments","events_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/344/events","html_url":"https://github.com/angular-ui/ui-sortable/pull/344","id":64568415,"number":344,"title":"feat(sortable): allow extra element before/after ng-repeat","user":{"login":"tepez","id":3265649,"avatar_url":"https://avatars.githubusercontent.com/u/3265649?v=3","gravatar_id":"","url":"https://api.github.com/users/tepez","html_url":"https://github.com/tepez","followers_url":"https://api.github.com/users/tepez/followers","following_url":"https://api.github.com/users/tepez/following{/other_user}","gists_url":"https://api.github.com/users/tepez/gists{/gist_id}","starred_url":"https://api.github.com/users/tepez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tepez/subscriptions","organizations_url":"https://api.github.com/users/tepez/orgs","repos_url":"https://api.github.com/users/tepez/repos","events_url":"https://api.github.com/users/tepez/events{/privacy}","received_events_url":"https://api.github.com/users/tepez/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular-ui/ui-sortable/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/milestones/4","html_url":"https://github.com/angular-ui/ui-sortable/milestones/v0.14.x","labels_url":"https://api.github.com/repos/angular-ui/ui-sortable/milestones/4/labels","id":759650,"number":4,"title":"v0.14.x","description":"","creator":{"login":"thgreasi","id":1295829,"avatar_url":"https://avatars.githubusercontent.com/u/1295829?v=3","gravatar_id":"","url":"https://api.github.com/users/thgreasi","html_url":"https://github.com/thgreasi","followers_url":"https://api.github.com/users/thgreasi/followers","following_url":"https://api.github.com/users/thgreasi/following{/other_user}","gists_url":"https://api.github.com/users/thgreasi/gists{/gist_id}","starred_url":"https://api.github.com/users/thgreasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thgreasi/subscriptions","organizations_url":"https://api.github.com/users/thgreasi/orgs","repos_url":"https://api.github.com/users/thgreasi/repos","events_url":"https://api.github.com/users/thgreasi/events{/privacy}","received_events_url":"https://api.github.com/users/thgreasi/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":3,"state":"open","created_at":"2014-08-20T07:22:24Z","updated_at":"2015-04-04T10:01:18Z","due_on":null,"closed_at":null},"comments":14,"created_at":"2015-03-26T16:07:40Z","updated_at":"2015-04-11T20:16:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/pulls/344","html_url":"https://github.com/angular-ui/ui-sortable/pull/344","diff_url":"https://github.com/angular-ui/ui-sortable/pull/344.diff","patch_url":"https://github.com/angular-ui/ui-sortable/pull/344.patch"},"body":"This fix allows to have extra elements before/after ng-repeat  (only if they are not ng-repeat themselves).\r\n\r\nSee demonstration at: http://codepen.io/anon/pen/VYgOLv\r\n\r\nIt passes all the original tests. To test that it works with added items, I duplicated `sortable.e2e.spec.js` into `sortable.e2e.extraElements.spec.js` and added a dummy `div` before and after the `ng-repeat` in every test.\r\n\r\nFixes #41, Fixed #177, Fixed #98 and Fixes #207 \r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/comments/91921079","html_url":"https://github.com/angular-ui/ui-sortable/pull/344#issuecomment-91921079","issue_url":"https://api.github.com/repos/angular-ui/ui-sortable/issues/344","id":91921079,"user":{"login":"thgreasi","id":1295829,"avatar_url":"https://avatars.githubusercontent.com/u/1295829?v=3","gravatar_id":"","url":"https://api.github.com/users/thgreasi","html_url":"https://github.com/thgreasi","followers_url":"https://api.github.com/users/thgreasi/followers","following_url":"https://api.github.com/users/thgreasi/following{/other_user}","gists_url":"https://api.github.com/users/thgreasi/gists{/gist_id}","starred_url":"https://api.github.com/users/thgreasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thgreasi/subscriptions","organizations_url":"https://api.github.com/users/thgreasi/orgs","repos_url":"https://api.github.com/users/thgreasi/repos","events_url":"https://api.github.com/users/thgreasi/events{/privacy}","received_events_url":"https://api.github.com/users/thgreasi/received_events","type":"User","site_admin":false},"created_at":"2015-04-11T20:16:57Z","updated_at":"2015-04-11T20:16:57Z","body":"@tepez Yea, I'm really sorry about that....\r\nI realized that you already had that test-case (and [how the trick is done](https://github.com/tepez/ui-sortable/blob/8ec7b039062e5cf5ec805d5c7114698d6c8c9f9c/src/sortable.js#L70)) this afternoon.\r\n\r\nI'm really sorry for the inconvenience. I think that this is in good shape to be merged as soon as the tests pass.\r\n\r\n[I have made some commits](https://github.com/tepez/ui-sortable/pull/1) that fixes the failing tests cases (wanted to keep track of all this in one PR).\r\nIt also includes some refactoring so that we can at some point get rid of `sortable.e2e.extraElements.spec.js` and run all the spec files both for the simple and the case that extra elements also exist.\r\n\r\nLastly, an option like `ui-items` (a selector that would match DOM elements with `ng-model` items) would allow for greater control, but I guess we should open a new issue for that."}}