{"comment":{"url":"https://api.github.com/repos/lslah/HTF/comments/14303436","html_url":"https://github.com/lslah/HTF/commit/9388e47d1ae587a1db9e771bf6024f68cd58eb66#commitcomment-14303436","id":14303436,"user":{"login":"skogsbaer","id":567524,"avatar_url":"https://avatars.githubusercontent.com/u/567524?v=3","gravatar_id":"","url":"https://api.github.com/users/skogsbaer","html_url":"https://github.com/skogsbaer","followers_url":"https://api.github.com/users/skogsbaer/followers","following_url":"https://api.github.com/users/skogsbaer/following{/other_user}","gists_url":"https://api.github.com/users/skogsbaer/gists{/gist_id}","starred_url":"https://api.github.com/users/skogsbaer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skogsbaer/subscriptions","organizations_url":"https://api.github.com/users/skogsbaer/orgs","repos_url":"https://api.github.com/users/skogsbaer/repos","events_url":"https://api.github.com/users/skogsbaer/events{/privacy}","received_events_url":"https://api.github.com/users/skogsbaer/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"9388e47d1ae587a1db9e771bf6024f68cd58eb66","created_at":"2015-11-10T14:28:38Z","updated_at":"2015-11-10T14:28:38Z","body":"Your patch looks good, thanks a lot.\r\n\r\nOne suggestion: the --deterministic flag was already weird (in the sense: how can test ran in parallel be deterministic?), but with your shuffle option, it get's even more complicated.\r\n\r\nMy suggestion would be to drop the --deterministic flag and implement the following behaviour:\r\n\r\n| --shuffle | --threads |  behaviour\r\n|------------|--------------|--------------------------------------\r\n| no         | no            | run tests sequentially, without shuffling (this is deterministic)\r\n|------------|--------------|--------------------------------------\r\n|  yes       |  no           |  shuffle test order, run sequentially\r\n|------------|--------------|--------------------------------------\r\n|  no        |  yes          |  run in parallel, don't shuffle\r\n|------------|--------------|--------------------------------------\r\n|  yes        |  yes        |  run tests in parallel, shuffle\r\n\r\nWould you mind updating your PR accordingly?"}}