{"action":"created","issue":{"url":"https://api.github.com/repos/TES5Edit/TES5Edit/issues/228","labels_url":"https://api.github.com/repos/TES5Edit/TES5Edit/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/TES5Edit/TES5Edit/issues/228/comments","events_url":"https://api.github.com/repos/TES5Edit/TES5Edit/issues/228/events","html_url":"https://github.com/TES5Edit/TES5Edit/issues/228","id":119025768,"number":228,"title":"FO4Edit: More Check for Error crashes on PACK","user":{"login":"fireundubh","id":1261664,"avatar_url":"https://avatars.githubusercontent.com/u/1261664?v=3","gravatar_id":"","url":"https://api.github.com/users/fireundubh","html_url":"https://github.com/fireundubh","followers_url":"https://api.github.com/users/fireundubh/followers","following_url":"https://api.github.com/users/fireundubh/following{/other_user}","gists_url":"https://api.github.com/users/fireundubh/gists{/gist_id}","starred_url":"https://api.github.com/users/fireundubh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fireundubh/subscriptions","organizations_url":"https://api.github.com/users/fireundubh/orgs","repos_url":"https://api.github.com/users/fireundubh/repos","events_url":"https://api.github.com/users/fireundubh/events{/privacy}","received_events_url":"https://api.github.com/users/fireundubh/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-11-26T11:21:04Z","updated_at":"2015-11-26T12:40:44Z","closed_at":"2015-11-26T12:40:44Z","body":"Here are two crashes related to PACK enumeration.\r\n\r\n### Target Data Type needs a 9th member to prevent crash\r\n\r\n```delphi\r\n  wbTargetData := wbStruct('Target Data', [\r\n    wbInteger('Type', itS32, wbEnum([\r\n      {0} 'Specific Reference',\r\n      {1} 'Object ID',\r\n      {2} 'Object Type',\r\n      {3} 'Linked Reference',\r\n      {4} 'Ref Alias',\r\n      {5} 'Unknown 5',\r\n      {6} 'Self',\r\n      {7} 'Keyword',\r\n      {8} 'Unknown 8'  // add this\r\n    ]), cpNormal, False, nil, nil, 2),\r\n```\r\n\r\n### PLDT Type needs a 15th member to prevent crash\r\n\r\nExample affected record: `DN054ZekeGunnerAttackPackage [PACK:00119B0F]`\r\n\r\n```delphi\r\n  wbPLDT := wbStruct(PLDT, 'Location', [\r\n    wbInteger('Type', itS32, wbLocationEnum),\r\n    wbUnion('Location Value', wbTypeDecider, [\r\n      {0} wbFormIDCkNoReach('Reference', [NULL, DOOR, PLYR, ACHR, REFR, PGRE, PHZD, PMIS, PARW, PBAR, PBEA, PCON, PFLA]),\r\n      {1} wbFormIDCkNoReach('Cell', [NULL, CELL]),\r\n      {2} wbByteArray('Near Package Start Location', 4, cpIgnore),\r\n      {3} wbByteArray('Near Editor Location', 4, cpIgnore),\r\n      {4} wbFormIDCkNoReach('Object ID', [NULL, ACTI, DOOR, STAT, MSTT, FURN, SPEL, SCRL, NPC_, CONT, ARMO, AMMO, MISC, WEAP, BOOK, KEYM, ALCH, LIGH, FACT, FLST, IDLM, SHOU]),\r\n      {5} wbInteger('Object Type', itU32, wbObjectTypeEnum),\r\n      {6} wbFormIDCk('Keyword', [NULL, KYWD]),\r\n      {7} wbByteArray('Unused', 4, cpIgnore),\r\n      {8} wbInteger('Alias', itS32, wbPackageLocationAliasToStr, wbStrToAlias),\r\n      {9} wbInteger('Reference', itS32, wbPackageLocationAliasToStr, wbStrToAlias),\r\n     {10} wbByteArray('Unknown', 4, cpIgnore),\r\n     {11} wbByteArray('Unknown', 4, cpIgnore),\r\n     {12} wbByteArray('Unknown', 4, cpIgnore),\r\n     {13} wbByteArray('Unknown', 4),\r\n     {14} wbByteArray('Unknown', 4) // add this\r\n    ]),\r\n    wbInteger('Radius', itS32),\r\n    wbUnknown\r\n  ]);\r\n```\r\n\r\n### CTDA Related\r\n\r\nAffected records:\r\n* `MS09Mission01ReinforcementsPatrol [PACK:0019A7F9]`\r\n* `RETravelKMK_BoSM02ClarkeFlee [PACK:0014DCF3]`\r\n\r\nThere are probably more.\r\n\r\n### Unknown Causes\r\n\r\nAffected records:\r\n* `MinFlareGunGroupMovementDog [PACK:001D2745]`\r\n* `MinRadiantOwned04ReturnToBase [PACK:000E61C6]`\r\n* `MinRandomPatrolGroupMovement [PACK:0015CE50]`\r\n* `MinRandomPatrolGroupMovementDog [PACK:001D2744]`\r\n* `RESceneKMK09GroupMovement [PACK:001B224C]`\r\n* `RESceneKMK09GroupMovementPrisoner [PACK:001B224F]`\r\n* `RESceneKMK09GroupMovementPrisonerCombat [PACK:00217A9C]`\r\n* `RESceneSC03_SupermutantRaidersHeadHome [PACK:00118B27]`\r\n* `RETravel01GroupMovement [PACK:0006BA61]`\r\n* `RETravel01GroupMovementWeaponOut [PACK:0006BA60]`\r\n* `RETravel03GroupMovementWeaponOut [PACK:0002F61A]`\r\n* `RETravelCT07_GroupMovement [PACK:0018F68E]`\r\n* `RETravelDL01GroupMovement [PACK:0002F813]`\r\n* `RETravelDL01GroupMovementGlowingOne [PACK:001860A3]`\r\n* `RETravelKMK07_BOSGroupMovement [PACK:00142416]`\r\n\r\nThere are definitely more."},"comment":{"url":"https://api.github.com/repos/TES5Edit/TES5Edit/issues/comments/159902582","html_url":"https://github.com/TES5Edit/TES5Edit/issues/228#issuecomment-159902582","issue_url":"https://api.github.com/repos/TES5Edit/TES5Edit/issues/228","id":159902582,"user":{"login":"zilav","id":495493,"avatar_url":"https://avatars.githubusercontent.com/u/495493?v=3","gravatar_id":"","url":"https://api.github.com/users/zilav","html_url":"https://github.com/zilav","followers_url":"https://api.github.com/users/zilav/followers","following_url":"https://api.github.com/users/zilav/following{/other_user}","gists_url":"https://api.github.com/users/zilav/gists{/gist_id}","starred_url":"https://api.github.com/users/zilav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilav/subscriptions","organizations_url":"https://api.github.com/users/zilav/orgs","repos_url":"https://api.github.com/users/zilav/repos","events_url":"https://api.github.com/users/zilav/events{/privacy}","received_events_url":"https://api.github.com/users/zilav/received_events","type":"User","site_admin":false},"created_at":"2015-11-26T12:40:44Z","updated_at":"2015-11-26T12:40:44Z","body":"Updated, thanks."}}