{"action":"created","comment":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/40300125","id":40300125,"diff_hunk":"@@ -233,18 +277,33 @@ class PackedGuid\n         ByteBuffer _packedGuid;\n };\n \n-template<HighGuid high>\n-class ObjectGuidGenerator\n+\n+class ObjectGuidGeneratorBase\n {\n-    public:\n-        explicit ObjectGuidGenerator(uint32 start = 1) : _nextGuid(start) { }\n+public:\n+    ObjectGuidGeneratorBase(ObjectGuid::LowType start = 1) : _nextGuid(start) { }\n \n-        void Set(uint32 val) { _nextGuid = val; }\n-        uint32 Generate();\n-        uint32 GetNextAfterMaxUsed() const { return _nextGuid; }\n+    virtual void Set(uint32 val) { _nextGuid = val; }\n+    virtual ObjectGuid::LowType Generate() = 0;\n+    ObjectGuid::LowType GetNextAfterMaxUsed() const { return _nextGuid; }\n \n-    private:\n-        uint32 _nextGuid;\n+protected:\n+    static void HandleCounterOverflow(HighGuid high);\n+    uint64 _nextGuid;","path":"src/server/game/Entities/Object/ObjectGuid.h","position":226,"original_position":226,"commit_id":"dcb7082277447c21b11c4a1d59f105fa342c172e","original_commit_id":"dcb7082277447c21b11c4a1d59f105fa342c172e","user":{"login":"pete318","id":173349,"avatar_url":"https://avatars.githubusercontent.com/u/173349?v=3","gravatar_id":"","url":"https://api.github.com/users/pete318","html_url":"https://github.com/pete318","followers_url":"https://api.github.com/users/pete318/followers","following_url":"https://api.github.com/users/pete318/following{/other_user}","gists_url":"https://api.github.com/users/pete318/gists{/gist_id}","starred_url":"https://api.github.com/users/pete318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pete318/subscriptions","organizations_url":"https://api.github.com/users/pete318/orgs","repos_url":"https://api.github.com/users/pete318/repos","events_url":"https://api.github.com/users/pete318/events{/privacy}","received_events_url":"https://api.github.com/users/pete318/received_events","type":"User","site_admin":false},"body":"Didn't know all had been changed in 6.x. So, probably the same should be done in 3.3.5. Again not important, but would reduce this kind of mistake in backports.","created_at":"2015-09-24T09:26:57Z","updated_at":"2015-09-24T09:26:57Z","html_url":"https://github.com/TrinityCore/TrinityCore/pull/15313#discussion_r40300125","pull_request_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313","_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments/40300125"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15313#discussion_r40300125"},"pull_request":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313"}}},"pull_request":{"url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313","id":42878822,"html_url":"https://github.com/TrinityCore/TrinityCore/pull/15313","diff_url":"https://github.com/TrinityCore/TrinityCore/pull/15313.diff","patch_url":"https://github.com/TrinityCore/TrinityCore/pull/15313.patch","issue_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15313","number":15313,"state":"closed","locked":false,"title":"[3.3.5/Core/Map] map local guids 6.x -> 3.3.5","user":{"login":"pete318","id":173349,"avatar_url":"https://avatars.githubusercontent.com/u/173349?v=3","gravatar_id":"","url":"https://api.github.com/users/pete318","html_url":"https://github.com/pete318","followers_url":"https://api.github.com/users/pete318/followers","following_url":"https://api.github.com/users/pete318/following{/other_user}","gists_url":"https://api.github.com/users/pete318/gists{/gist_id}","starred_url":"https://api.github.com/users/pete318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pete318/subscriptions","organizations_url":"https://api.github.com/users/pete318/orgs","repos_url":"https://api.github.com/users/pete318/repos","events_url":"https://api.github.com/users/pete318/events{/privacy}","received_events_url":"https://api.github.com/users/pete318/received_events","type":"User","site_admin":false},"body":"Implemented:\r\n* https://github.com/TrinityCore/TrinityCore/commit/ca83e14f8b141fab0a13e08f48fca6c1ace0c4c7 Core/Entities: Reworked guid scopes\r\n* https://github.com/TrinityCore/TrinityCore/commit/ee1c1b97be4492ecabe8b15ea6323fc37e4eaa8c Core/Maps: Fixed invalid iterator usage\r\n* https://github.com/TrinityCore/TrinityCore/commit/18e4ab6911468b829b0fc768e532a770263c3717 Core/Maps: Fixed crash in Map::SendObjectUpdates\r\n* https://github.com/TrinityCore/TrinityCore/commit/bf37446b3c2ed73b4d3aa9e227d3eff5c53b378b Core/GameObjects: Fixed GameObjectAddon loading\r\n* https://github.com/TrinityCore/TrinityCore/commit/cb854a2b7bb7bd96cf9c4d1daf3789f797bf4db8 Core/Maps: Removed dbguid/spawnid grid searchers\r\n\r\nImplementing the following:\r\n* This adds separate (per map) guid sequences depending on object type\r\n* Ported map object container from cmangos/mangos-wotlk@a2d396e\r\n* Added type container visitor for TypeUnorderedMapContainer\r\n* Implemented helper function to erase unique pairs from multimap containers\r\n* Moved object storage of all objects except players and transports to map level\r\n* Added containers linking database spawn id with creature/gameobject in world\r\n* Renamed DBTableGuid to spawnId\r\n* Added a separate spawn id sequence generator for creatures and gameobjects - this will be used in db tables\r\n* Moved building SMSG_UPDATE_OBJECT - updatefields changes broadcast to map update\r\n\r\nAlso added:\r\n* Added new function to return but not increment guid\r\n* Adjusted .debug loadcells to show low guid in map before/after load\r\n* Added debug messages for creature spawn/destroy, for map guid debugging\r\n\r\nAdded for 3.3.5 (from 6.x) to facilitate these changes, specifically guid traits:\r\n* Changed HIGHGUID_xxx to HighGuid class (HighGuid::xxx)\r\n* guid generator switched from uint32 counters, to a template class based on HighGuid type.","created_at":"2015-08-20T00:06:45Z","updated_at":"2015-09-24T09:26:57Z","closed_at":"2015-09-23T18:21:20Z","merged_at":"2015-09-23T18:21:20Z","merge_commit_sha":"11ffabf3bf40cc81e9a94afce83967d2874f5083","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313/commits","review_comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313/comments","review_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15313/comments","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/dcb7082277447c21b11c4a1d59f105fa342c172e","head":{"label":"pete318:map_local_guid_335","ref":"map_local_guid_335","sha":"dcb7082277447c21b11c4a1d59f105fa342c172e","user":{"login":"pete318","id":173349,"avatar_url":"https://avatars.githubusercontent.com/u/173349?v=3","gravatar_id":"","url":"https://api.github.com/users/pete318","html_url":"https://github.com/pete318","followers_url":"https://api.github.com/users/pete318/followers","following_url":"https://api.github.com/users/pete318/following{/other_user}","gists_url":"https://api.github.com/users/pete318/gists{/gist_id}","starred_url":"https://api.github.com/users/pete318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pete318/subscriptions","organizations_url":"https://api.github.com/users/pete318/orgs","repos_url":"https://api.github.com/users/pete318/repos","events_url":"https://api.github.com/users/pete318/events{/privacy}","received_events_url":"https://api.github.com/users/pete318/received_events","type":"User","site_admin":false},"repo":{"id":27044842,"name":"TrinityCore","full_name":"pete318/TrinityCore","owner":{"login":"pete318","id":173349,"avatar_url":"https://avatars.githubusercontent.com/u/173349?v=3","gravatar_id":"","url":"https://api.github.com/users/pete318","html_url":"https://github.com/pete318","followers_url":"https://api.github.com/users/pete318/followers","following_url":"https://api.github.com/users/pete318/following{/other_user}","gists_url":"https://api.github.com/users/pete318/gists{/gist_id}","starred_url":"https://api.github.com/users/pete318/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pete318/subscriptions","organizations_url":"https://api.github.com/users/pete318/orgs","repos_url":"https://api.github.com/users/pete318/repos","events_url":"https://api.github.com/users/pete318/events{/privacy}","received_events_url":"https://api.github.com/users/pete318/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pete318/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":true,"url":"https://api.github.com/repos/pete318/TrinityCore","forks_url":"https://api.github.com/repos/pete318/TrinityCore/forks","keys_url":"https://api.github.com/repos/pete318/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pete318/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pete318/TrinityCore/teams","hooks_url":"https://api.github.com/repos/pete318/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/pete318/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/pete318/TrinityCore/events","assignees_url":"https://api.github.com/repos/pete318/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/pete318/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/pete318/TrinityCore/tags","blobs_url":"https://api.github.com/repos/pete318/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pete318/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pete318/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/pete318/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pete318/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/pete318/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/pete318/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/pete318/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/pete318/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/pete318/TrinityCore/subscription","commits_url":"https://api.github.com/repos/pete318/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/pete318/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/pete318/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/pete318/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/pete318/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/pete318/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pete318/TrinityCore/merges","archive_url":"https://api.github.com/repos/pete318/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pete318/TrinityCore/downloads","issues_url":"https://api.github.com/repos/pete318/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/pete318/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/pete318/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/pete318/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pete318/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/pete318/TrinityCore/releases{/id}","created_at":"2014-11-23T19:41:06Z","updated_at":"2014-12-10T07:43:53Z","pushed_at":"2015-09-23T20:04:03Z","git_url":"git://github.com/pete318/TrinityCore.git","ssh_url":"git@github.com:pete318/TrinityCore.git","clone_url":"https://github.com/pete318/TrinityCore.git","svn_url":"https://github.com/pete318/TrinityCore","homepage":"http://www.trinitycore.org","size":370260,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.3.5"}},"base":{"label":"TrinityCore:3.3.5","ref":"3.3.5","sha":"0427870585f873b724b068541a933cdd68fa35a0","user":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"repo":{"id":1204412,"name":"TrinityCore","full_name":"TrinityCore/TrinityCore","owner":{"login":"TrinityCore","id":539602,"avatar_url":"https://avatars.githubusercontent.com/u/539602?v=3","gravatar_id":"","url":"https://api.github.com/users/TrinityCore","html_url":"https://github.com/TrinityCore","followers_url":"https://api.github.com/users/TrinityCore/followers","following_url":"https://api.github.com/users/TrinityCore/following{/other_user}","gists_url":"https://api.github.com/users/TrinityCore/gists{/gist_id}","starred_url":"https://api.github.com/users/TrinityCore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrinityCore/subscriptions","organizations_url":"https://api.github.com/users/TrinityCore/orgs","repos_url":"https://api.github.com/users/TrinityCore/repos","events_url":"https://api.github.com/users/TrinityCore/events{/privacy}","received_events_url":"https://api.github.com/users/TrinityCore/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrinityCore/TrinityCore","description":"TrinityCore Open Source MMO Framework","fork":false,"url":"https://api.github.com/repos/TrinityCore/TrinityCore","forks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/forks","keys_url":"https://api.github.com/repos/TrinityCore/TrinityCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrinityCore/TrinityCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrinityCore/TrinityCore/teams","hooks_url":"https://api.github.com/repos/TrinityCore/TrinityCore/hooks","issue_events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/events{/number}","events_url":"https://api.github.com/repos/TrinityCore/TrinityCore/events","assignees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/assignees{/user}","branches_url":"https://api.github.com/repos/TrinityCore/TrinityCore/branches{/branch}","tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/tags","blobs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/{sha}","languages_url":"https://api.github.com/repos/TrinityCore/TrinityCore/languages","stargazers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/stargazers","contributors_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contributors","subscribers_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscribers","subscription_url":"https://api.github.com/repos/TrinityCore/TrinityCore/subscription","commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrinityCore/TrinityCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrinityCore/TrinityCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrinityCore/TrinityCore/contents/{+path}","compare_url":"https://api.github.com/repos/TrinityCore/TrinityCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrinityCore/TrinityCore/merges","archive_url":"https://api.github.com/repos/TrinityCore/TrinityCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrinityCore/TrinityCore/downloads","issues_url":"https://api.github.com/repos/TrinityCore/TrinityCore/issues{/number}","pulls_url":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls{/number}","milestones_url":"https://api.github.com/repos/TrinityCore/TrinityCore/milestones{/number}","notifications_url":"https://api.github.com/repos/TrinityCore/TrinityCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrinityCore/TrinityCore/labels{/name}","releases_url":"https://api.github.com/repos/TrinityCore/TrinityCore/releases{/id}","created_at":"2010-12-28T23:40:07Z","updated_at":"2015-09-24T02:53:15Z","pushed_at":"2015-09-24T02:24:25Z","git_url":"git://github.com/TrinityCore/TrinityCore.git","ssh_url":"git@github.com:TrinityCore/TrinityCore.git","clone_url":"https://github.com/TrinityCore/TrinityCore.git","svn_url":"https://github.com/TrinityCore/TrinityCore","homepage":"http://www.trinitycore.org","size":861284,"stargazers_count":2963,"watchers_count":2963,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3126,"mirror_url":null,"open_issues_count":1176,"forks":3126,"open_issues":1176,"watchers":2963,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313"},"html":{"href":"https://github.com/TrinityCore/TrinityCore/pull/15313"},"issue":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15313"},"comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/issues/15313/comments"},"review_comments":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313/comments"},"review_comment":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/pulls/15313/commits"},"statuses":{"href":"https://api.github.com/repos/TrinityCore/TrinityCore/statuses/dcb7082277447c21b11c4a1d59f105fa342c172e"}}}}