{"action":"created","comment":{"url":"https://api.github.com/repos/chef/oc_erchef/pulls/comments/25345773","id":25345773,"diff_hunk":"@@ -15,46 +15,122 @@\n %% \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n %% KIND, either express or implied.  See the License for the\n %% specific language governing permissions and limitations\n-%% under the License.\n+%% under the License.es","path":"apps/chef_objects/test/chef_key_tests.erl","position":14,"original_position":14,"commit_id":"490e7a9f149d93ce734c3c0ed12424145523b825","original_commit_id":"490e7a9f149d93ce734c3c0ed12424145523b825","user":{"login":"stevendanna","id":852371,"avatar_url":"https://avatars.githubusercontent.com/u/852371?v=3","gravatar_id":"","url":"https://api.github.com/users/stevendanna","html_url":"https://github.com/stevendanna","followers_url":"https://api.github.com/users/stevendanna/followers","following_url":"https://api.github.com/users/stevendanna/following{/other_user}","gists_url":"https://api.github.com/users/stevendanna/gists{/gist_id}","starred_url":"https://api.github.com/users/stevendanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stevendanna/subscriptions","organizations_url":"https://api.github.com/users/stevendanna/orgs","repos_url":"https://api.github.com/users/stevendanna/repos","events_url":"https://api.github.com/users/stevendanna/events{/privacy}","received_events_url":"https://api.github.com/users/stevendanna/received_events","type":"User","site_admin":false},"body":"whoops","created_at":"2015-02-25T15:04:51Z","updated_at":"2015-02-25T15:04:51Z","html_url":"https://github.com/chef/oc_erchef/pull/97#discussion_r25345773","pull_request_url":"https://api.github.com/repos/chef/oc_erchef/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/chef/oc_erchef/pulls/comments/25345773"},"html":{"href":"https://github.com/chef/oc_erchef/pull/97#discussion_r25345773"},"pull_request":{"href":"https://api.github.com/repos/chef/oc_erchef/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/chef/oc_erchef/pulls/97","id":29924529,"html_url":"https://github.com/chef/oc_erchef/pull/97","diff_url":"https://github.com/chef/oc_erchef/pull/97.diff","patch_url":"https://github.com/chef/oc_erchef/pull/97.patch","issue_url":"https://api.github.com/repos/chef/oc_erchef/issues/97","number":97,"state":"open","locked":false,"title":"Keys api - POST support","user":{"login":"marcparadise","id":1130204,"avatar_url":"https://avatars.githubusercontent.com/u/1130204?v=3","gravatar_id":"","url":"https://api.github.com/users/marcparadise","html_url":"https://github.com/marcparadise","followers_url":"https://api.github.com/users/marcparadise/followers","following_url":"https://api.github.com/users/marcparadise/following{/other_user}","gists_url":"https://api.github.com/users/marcparadise/gists{/gist_id}","starred_url":"https://api.github.com/users/marcparadise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcparadise/subscriptions","organizations_url":"https://api.github.com/users/marcparadise/orgs","repos_url":"https://api.github.com/users/marcparadise/repos","events_url":"https://api.github.com/users/marcparadise/events{/privacy}","received_events_url":"https://api.github.com/users/marcparadise/received_events","type":"User","site_admin":false},"body":"This PR is primarily to include support for POSTing to create a new client or user keys. \r\n\r\nAlso included: \r\n* adding support for `updated_at` and `last_updated_by` fields to chef_key\r\n* chef user minor refactor of shared validation behaviors \r\n* new optional callback mechanism by which a resource can provide the correct arguments \r\n  to oc_chef_wm_routes:route based on state and object data \r\n* further fixes and level up of integration tests \r\n* action tracking for keys activity \r\n* some bare-bones RAML docs for keys API\r\n* fix in catch-all logging in oc_chef_wm_base:finish_request so that we don't crash lager anymore \r\n\r\nping @chef/lob \r\n\r\nTODO: \r\n\r\n- [x] fix new actions test to account for new fields and field names\r\n- [x] Eunit tests (specifically what #keys_state.type is)","created_at":"2015-02-24T18:50:58Z","updated_at":"2015-02-25T15:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e70729302cf3fc3c76840adb25f46009c4d84ec","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef/oc_erchef/pulls/97/commits","review_comments_url":"https://api.github.com/repos/chef/oc_erchef/pulls/97/comments","review_comment_url":"https://api.github.com/repos/chef/oc_erchef/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef/oc_erchef/issues/97/comments","statuses_url":"https://api.github.com/repos/chef/oc_erchef/statuses/490e7a9f149d93ce734c3c0ed12424145523b825","head":{"label":"chef:keys-api-POST","ref":"keys-api-POST","sha":"490e7a9f149d93ce734c3c0ed12424145523b825","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":5407868,"name":"oc_erchef","full_name":"chef/oc_erchef","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/oc_erchef","description":"Chef Server (12.0 and later)","fork":false,"url":"https://api.github.com/repos/chef/oc_erchef","forks_url":"https://api.github.com/repos/chef/oc_erchef/forks","keys_url":"https://api.github.com/repos/chef/oc_erchef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/oc_erchef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/oc_erchef/teams","hooks_url":"https://api.github.com/repos/chef/oc_erchef/hooks","issue_events_url":"https://api.github.com/repos/chef/oc_erchef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/oc_erchef/events","assignees_url":"https://api.github.com/repos/chef/oc_erchef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/oc_erchef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/oc_erchef/tags","blobs_url":"https://api.github.com/repos/chef/oc_erchef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/oc_erchef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/oc_erchef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/oc_erchef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/oc_erchef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/oc_erchef/languages","stargazers_url":"https://api.github.com/repos/chef/oc_erchef/stargazers","contributors_url":"https://api.github.com/repos/chef/oc_erchef/contributors","subscribers_url":"https://api.github.com/repos/chef/oc_erchef/subscribers","subscription_url":"https://api.github.com/repos/chef/oc_erchef/subscription","commits_url":"https://api.github.com/repos/chef/oc_erchef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/oc_erchef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/oc_erchef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/oc_erchef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/oc_erchef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/oc_erchef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/oc_erchef/merges","archive_url":"https://api.github.com/repos/chef/oc_erchef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/oc_erchef/downloads","issues_url":"https://api.github.com/repos/chef/oc_erchef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/oc_erchef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/oc_erchef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/oc_erchef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/oc_erchef/labels{/name}","releases_url":"https://api.github.com/repos/chef/oc_erchef/releases{/id}","created_at":"2012-08-14T03:21:06Z","updated_at":"2015-02-24T21:56:27Z","pushed_at":"2015-02-25T01:50:13Z","git_url":"git://github.com/chef/oc_erchef.git","ssh_url":"git@github.com:chef/oc_erchef.git","clone_url":"https://github.com/chef/oc_erchef.git","svn_url":"https://github.com/chef/oc_erchef","homepage":"https://github.com/opscode/chef-server","size":8327,"stargazers_count":2,"watchers_count":2,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"chef:master","ref":"master","sha":"213d792ef8611230f0bb0213797f34f6842ebbe1","user":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"repo":{"id":5407868,"name":"oc_erchef","full_name":"chef/oc_erchef","owner":{"login":"chef","id":29740,"avatar_url":"https://avatars.githubusercontent.com/u/29740?v=3","gravatar_id":"","url":"https://api.github.com/users/chef","html_url":"https://github.com/chef","followers_url":"https://api.github.com/users/chef/followers","following_url":"https://api.github.com/users/chef/following{/other_user}","gists_url":"https://api.github.com/users/chef/gists{/gist_id}","starred_url":"https://api.github.com/users/chef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef/subscriptions","organizations_url":"https://api.github.com/users/chef/orgs","repos_url":"https://api.github.com/users/chef/repos","events_url":"https://api.github.com/users/chef/events{/privacy}","received_events_url":"https://api.github.com/users/chef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef/oc_erchef","description":"Chef Server (12.0 and later)","fork":false,"url":"https://api.github.com/repos/chef/oc_erchef","forks_url":"https://api.github.com/repos/chef/oc_erchef/forks","keys_url":"https://api.github.com/repos/chef/oc_erchef/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef/oc_erchef/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef/oc_erchef/teams","hooks_url":"https://api.github.com/repos/chef/oc_erchef/hooks","issue_events_url":"https://api.github.com/repos/chef/oc_erchef/issues/events{/number}","events_url":"https://api.github.com/repos/chef/oc_erchef/events","assignees_url":"https://api.github.com/repos/chef/oc_erchef/assignees{/user}","branches_url":"https://api.github.com/repos/chef/oc_erchef/branches{/branch}","tags_url":"https://api.github.com/repos/chef/oc_erchef/tags","blobs_url":"https://api.github.com/repos/chef/oc_erchef/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef/oc_erchef/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef/oc_erchef/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef/oc_erchef/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef/oc_erchef/statuses/{sha}","languages_url":"https://api.github.com/repos/chef/oc_erchef/languages","stargazers_url":"https://api.github.com/repos/chef/oc_erchef/stargazers","contributors_url":"https://api.github.com/repos/chef/oc_erchef/contributors","subscribers_url":"https://api.github.com/repos/chef/oc_erchef/subscribers","subscription_url":"https://api.github.com/repos/chef/oc_erchef/subscription","commits_url":"https://api.github.com/repos/chef/oc_erchef/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef/oc_erchef/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef/oc_erchef/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef/oc_erchef/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef/oc_erchef/contents/{+path}","compare_url":"https://api.github.com/repos/chef/oc_erchef/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef/oc_erchef/merges","archive_url":"https://api.github.com/repos/chef/oc_erchef/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef/oc_erchef/downloads","issues_url":"https://api.github.com/repos/chef/oc_erchef/issues{/number}","pulls_url":"https://api.github.com/repos/chef/oc_erchef/pulls{/number}","milestones_url":"https://api.github.com/repos/chef/oc_erchef/milestones{/number}","notifications_url":"https://api.github.com/repos/chef/oc_erchef/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef/oc_erchef/labels{/name}","releases_url":"https://api.github.com/repos/chef/oc_erchef/releases{/id}","created_at":"2012-08-14T03:21:06Z","updated_at":"2015-02-24T21:56:27Z","pushed_at":"2015-02-25T01:50:13Z","git_url":"git://github.com/chef/oc_erchef.git","ssh_url":"git@github.com:chef/oc_erchef.git","clone_url":"https://github.com/chef/oc_erchef.git","svn_url":"https://github.com/chef/oc_erchef","homepage":"https://github.com/opscode/chef-server","size":8327,"stargazers_count":2,"watchers_count":2,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":3,"forks":4,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef/oc_erchef/pulls/97"},"html":{"href":"https://github.com/chef/oc_erchef/pull/97"},"issue":{"href":"https://api.github.com/repos/chef/oc_erchef/issues/97"},"comments":{"href":"https://api.github.com/repos/chef/oc_erchef/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/chef/oc_erchef/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/chef/oc_erchef/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef/oc_erchef/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/chef/oc_erchef/statuses/490e7a9f149d93ce734c3c0ed12424145523b825"}}}}