{"action":"closed","number":914,"pull_request":{"url":"https://api.github.com/repos/mozilla/fireplace/pulls/914","id":27512999,"html_url":"https://github.com/mozilla/fireplace/pull/914","diff_url":"https://github.com/mozilla/fireplace/pull/914.diff","patch_url":"https://github.com/mozilla/fireplace/pull/914.patch","issue_url":"https://api.github.com/repos/mozilla/fireplace/issues/914","number":914,"state":"closed","locked":false,"title":"Fix blocked payment window (1122243)","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"body":"This opens a popup for the payment when logged out. This is done as part of the click to the button so the popup isn't blocked.. The login window will then sit over the top of this. \r\n\r\nIf the login fails the payment window will be closed too.\r\n\r\nThis can't close the payment window when the login window is closed because afaict the deferred login isn't being rejected in this scenario.\r\n\r\nr? @kumar303 ","created_at":"2015-01-16T15:33:28Z","updated_at":"2015-01-16T19:17:38Z","closed_at":"2015-01-16T19:17:38Z","merged_at":"2015-01-16T19:17:38Z","merge_commit_sha":"04723a8a38c1a5d60e722fd67eabe2572ac79d2a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/fireplace/pulls/914/commits","review_comments_url":"https://api.github.com/repos/mozilla/fireplace/pulls/914/comments","review_comment_url":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mozilla/fireplace/issues/914/comments","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/4c5c8ef289581bd9707a2d4b9ec4197ecb723a26","head":{"label":"muffinresearch:fix-blocked-payment-popup-1122243","ref":"fix-blocked-payment-popup-1122243","sha":"4c5c8ef289581bd9707a2d4b9ec4197ecb723a26","user":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"repo":{"id":8063241,"name":"fireplace","full_name":"muffinresearch/fireplace","owner":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muffinresearch/fireplace","description":"A clandestine operation to make @krupa happy","fork":true,"url":"https://api.github.com/repos/muffinresearch/fireplace","forks_url":"https://api.github.com/repos/muffinresearch/fireplace/forks","keys_url":"https://api.github.com/repos/muffinresearch/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muffinresearch/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muffinresearch/fireplace/teams","hooks_url":"https://api.github.com/repos/muffinresearch/fireplace/hooks","issue_events_url":"https://api.github.com/repos/muffinresearch/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/muffinresearch/fireplace/events","assignees_url":"https://api.github.com/repos/muffinresearch/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/muffinresearch/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/muffinresearch/fireplace/tags","blobs_url":"https://api.github.com/repos/muffinresearch/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muffinresearch/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muffinresearch/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/muffinresearch/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muffinresearch/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/muffinresearch/fireplace/languages","stargazers_url":"https://api.github.com/repos/muffinresearch/fireplace/stargazers","contributors_url":"https://api.github.com/repos/muffinresearch/fireplace/contributors","subscribers_url":"https://api.github.com/repos/muffinresearch/fireplace/subscribers","subscription_url":"https://api.github.com/repos/muffinresearch/fireplace/subscription","commits_url":"https://api.github.com/repos/muffinresearch/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/muffinresearch/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/muffinresearch/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/muffinresearch/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/muffinresearch/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/muffinresearch/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muffinresearch/fireplace/merges","archive_url":"https://api.github.com/repos/muffinresearch/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muffinresearch/fireplace/downloads","issues_url":"https://api.github.com/repos/muffinresearch/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/muffinresearch/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/muffinresearch/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/muffinresearch/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muffinresearch/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/muffinresearch/fireplace/releases{/id}","created_at":"2013-02-07T00:15:49Z","updated_at":"2014-08-04T16:56:42Z","pushed_at":"2015-01-16T18:47:17Z","git_url":"git://github.com/muffinresearch/fireplace.git","ssh_url":"git@github.com:muffinresearch/fireplace.git","clone_url":"https://github.com/muffinresearch/fireplace.git","svn_url":"https://github.com/muffinresearch/fireplace","homepage":"https://marketplace.firefox.com/","size":20063,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"4c08d8fba3fb347da378951c8cd01b9a553c40ea","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8046076,"name":"fireplace","full_name":"mozilla/fireplace","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/fireplace","description":"Frontend for the Firefox Marketplace","fork":false,"url":"https://api.github.com/repos/mozilla/fireplace","forks_url":"https://api.github.com/repos/mozilla/fireplace/forks","keys_url":"https://api.github.com/repos/mozilla/fireplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/fireplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/fireplace/teams","hooks_url":"https://api.github.com/repos/mozilla/fireplace/hooks","issue_events_url":"https://api.github.com/repos/mozilla/fireplace/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/fireplace/events","assignees_url":"https://api.github.com/repos/mozilla/fireplace/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/fireplace/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/fireplace/tags","blobs_url":"https://api.github.com/repos/mozilla/fireplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/fireplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/fireplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/fireplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/fireplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/fireplace/languages","stargazers_url":"https://api.github.com/repos/mozilla/fireplace/stargazers","contributors_url":"https://api.github.com/repos/mozilla/fireplace/contributors","subscribers_url":"https://api.github.com/repos/mozilla/fireplace/subscribers","subscription_url":"https://api.github.com/repos/mozilla/fireplace/subscription","commits_url":"https://api.github.com/repos/mozilla/fireplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/fireplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/fireplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/fireplace/issues/comments/{number}","contents_url":"https://api.github.com/repos/mozilla/fireplace/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/fireplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/fireplace/merges","archive_url":"https://api.github.com/repos/mozilla/fireplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/fireplace/downloads","issues_url":"https://api.github.com/repos/mozilla/fireplace/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/fireplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/fireplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/fireplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/fireplace/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/fireplace/releases{/id}","created_at":"2013-02-06T06:41:06Z","updated_at":"2015-01-16T18:04:35Z","pushed_at":"2015-01-16T19:17:38Z","git_url":"git://github.com/mozilla/fireplace.git","ssh_url":"git@github.com:mozilla/fireplace.git","clone_url":"https://github.com/mozilla/fireplace.git","svn_url":"https://github.com/mozilla/fireplace","homepage":"https://marketplace.firefox.com/","size":82020,"stargazers_count":49,"watchers_count":49,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":4,"forks":94,"open_issues":4,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/914"},"html":{"href":"https://github.com/mozilla/fireplace/pull/914"},"issue":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/914"},"comments":{"href":"https://api.github.com/repos/mozilla/fireplace/issues/914/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/914/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mozilla/fireplace/pulls/914/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/fireplace/statuses/4c5c8ef289581bd9707a2d4b9ec4197ecb723a26"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"commits":2,"additions":15,"deletions":1,"changed_files":2}}