{"action":"created","comment":{"url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/comments/42304944","id":42304944,"diff_hunk":"@@ -345,12 +345,59 @@ def owners_votes\n   # Get a list of this User's Votes for this Observation.\n   def users_votes(user)\n     result = []\n-    for n in namings\n+    namings.each do |n|\n       if v = n.users_vote(user)\n         result << v\n       end\n     end\n-    return result\n+    result\n+  end\n+\n+  # list of Owners's \"favorite\" votes for this Observation","path":"app/models/observation.rb","position":14,"original_position":14,"commit_id":"c01102f13ccbd6109b609a000c6d8bf48d54ca76","original_commit_id":"c01102f13ccbd6109b609a000c6d8bf48d54ca76","user":{"login":"JoeCohen","id":45460,"avatar_url":"https://avatars.githubusercontent.com/u/45460?v=3","gravatar_id":"","url":"https://api.github.com/users/JoeCohen","html_url":"https://github.com/JoeCohen","followers_url":"https://api.github.com/users/JoeCohen/followers","following_url":"https://api.github.com/users/JoeCohen/following{/other_user}","gists_url":"https://api.github.com/users/JoeCohen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeCohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeCohen/subscriptions","organizations_url":"https://api.github.com/users/JoeCohen/orgs","repos_url":"https://api.github.com/users/JoeCohen/repos","events_url":"https://api.github.com/users/JoeCohen/events{/privacy}","received_events_url":"https://api.github.com/users/JoeCohen/received_events","type":"User","site_admin":false},"body":"Will remove most comments in this section.  \r\nPlease feel free to remove more or to restore any which I removed;  someone who did not write the code is probably better judge of whether the code is self-explanatory. ","created_at":"2015-10-17T03:01:46Z","updated_at":"2015-10-17T03:01:46Z","html_url":"https://github.com/MushroomObserver/mushroom-observer/pull/187#discussion_r42304944","pull_request_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187","_links":{"self":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/comments/42304944"},"html":{"href":"https://github.com/MushroomObserver/mushroom-observer/pull/187#discussion_r42304944"},"pull_request":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187"}}},"pull_request":{"url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187","id":47383555,"html_url":"https://github.com/MushroomObserver/mushroom-observer/pull/187","diff_url":"https://github.com/MushroomObserver/mushroom-observer/pull/187.diff","patch_url":"https://github.com/MushroomObserver/mushroom-observer/pull/187.patch","issue_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/187","number":187,"state":"closed","locked":false,"title":"Observer ID","user":{"login":"JoeCohen","id":45460,"avatar_url":"https://avatars.githubusercontent.com/u/45460?v=3","gravatar_id":"","url":"https://api.github.com/users/JoeCohen","html_url":"https://github.com/JoeCohen","followers_url":"https://api.github.com/users/JoeCohen/followers","following_url":"https://api.github.com/users/JoeCohen/following{/other_user}","gists_url":"https://api.github.com/users/JoeCohen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeCohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeCohen/subscriptions","organizations_url":"https://api.github.com/users/JoeCohen/orgs","repos_url":"https://api.github.com/users/JoeCohen/repos","events_url":"https://api.github.com/users/JoeCohen/events{/privacy}","received_events_url":"https://api.github.com/users/JoeCohen/received_events","type":"User","site_admin":false},"body":"Conditionally displays Observer ID on Observation pages\r\n\r\n* Delivers [Pivotal #104964854](https://www.pivotaltracker.com/story/show/104964854)\r\n* Requires `rake db:migrate` (because of new user option) and `rake lang:update`\r\n* If User opted to View Observer ID, shows Observer's ID if:\r\n  * Observer has a single name preference, different from consensus, and not \"Fungi\"; and  Observer is sufficiently confident.\r\n  * \"sufficiently confident\" is defined in the Vote model in owner_id_min_confidence\r\n  * As a starting point, I set it to the minimum_positive_vote. \r\n* Please note:\r\n  * There's a fair bit of refactoring of show_observation view files, so there's potential for conflict with pending Pull Requests.\r\n  * Within the code, Observer ID is referred to as \"owner_id\".","created_at":"2015-10-12T03:32:17Z","updated_at":"2015-10-17T03:01:46Z","closed_at":"2015-10-15T15:17:15Z","merged_at":null,"merge_commit_sha":"6d5f356a6862707e813e841c85cf86163c299935","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187/commits","review_comments_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187/comments","review_comment_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/187/comments","statuses_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/statuses/c01102f13ccbd6109b609a000c6d8bf48d54ca76","head":{"label":"JoeCohen:observer_id","ref":"observer_id","sha":"c01102f13ccbd6109b609a000c6d8bf48d54ca76","user":{"login":"JoeCohen","id":45460,"avatar_url":"https://avatars.githubusercontent.com/u/45460?v=3","gravatar_id":"","url":"https://api.github.com/users/JoeCohen","html_url":"https://github.com/JoeCohen","followers_url":"https://api.github.com/users/JoeCohen/followers","following_url":"https://api.github.com/users/JoeCohen/following{/other_user}","gists_url":"https://api.github.com/users/JoeCohen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeCohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeCohen/subscriptions","organizations_url":"https://api.github.com/users/JoeCohen/orgs","repos_url":"https://api.github.com/users/JoeCohen/repos","events_url":"https://api.github.com/users/JoeCohen/events{/privacy}","received_events_url":"https://api.github.com/users/JoeCohen/received_events","type":"User","site_admin":false},"repo":{"id":26510020,"name":"mushroom-observer","full_name":"JoeCohen/mushroom-observer","owner":{"login":"JoeCohen","id":45460,"avatar_url":"https://avatars.githubusercontent.com/u/45460?v=3","gravatar_id":"","url":"https://api.github.com/users/JoeCohen","html_url":"https://github.com/JoeCohen","followers_url":"https://api.github.com/users/JoeCohen/followers","following_url":"https://api.github.com/users/JoeCohen/following{/other_user}","gists_url":"https://api.github.com/users/JoeCohen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoeCohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoeCohen/subscriptions","organizations_url":"https://api.github.com/users/JoeCohen/orgs","repos_url":"https://api.github.com/users/JoeCohen/repos","events_url":"https://api.github.com/users/JoeCohen/events{/privacy}","received_events_url":"https://api.github.com/users/JoeCohen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JoeCohen/mushroom-observer","description":"A website for sharing observations of mushrooms.","fork":true,"url":"https://api.github.com/repos/JoeCohen/mushroom-observer","forks_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/forks","keys_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/teams","hooks_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/hooks","issue_events_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/issues/events{/number}","events_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/events","assignees_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/assignees{/user}","branches_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/branches{/branch}","tags_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/tags","blobs_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/git/refs{/sha}","trees_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/statuses/{sha}","languages_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/languages","stargazers_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/stargazers","contributors_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/contributors","subscribers_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/subscribers","subscription_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/subscription","commits_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/commits{/sha}","git_commits_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/git/commits{/sha}","comments_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/comments{/number}","issue_comment_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/issues/comments{/number}","contents_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/contents/{+path}","compare_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/merges","archive_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/downloads","issues_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/issues{/number}","pulls_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/pulls{/number}","milestones_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/milestones{/number}","notifications_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/labels{/name}","releases_url":"https://api.github.com/repos/JoeCohen/mushroom-observer/releases{/id}","created_at":"2014-11-11T23:30:53Z","updated_at":"2015-02-04T21:29:02Z","pushed_at":"2015-10-13T14:45:02Z","git_url":"git://github.com/JoeCohen/mushroom-observer.git","ssh_url":"git@github.com:JoeCohen/mushroom-observer.git","clone_url":"https://github.com/JoeCohen/mushroom-observer.git","svn_url":"https://github.com/JoeCohen/mushroom-observer","homepage":"http://mushroomobserver.org","size":54177,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MushroomObserver:master","ref":"master","sha":"7c3f76481fdf1bd165914d9d062369370d4d95a8","user":{"login":"MushroomObserver","id":3212163,"avatar_url":"https://avatars.githubusercontent.com/u/3212163?v=3","gravatar_id":"","url":"https://api.github.com/users/MushroomObserver","html_url":"https://github.com/MushroomObserver","followers_url":"https://api.github.com/users/MushroomObserver/followers","following_url":"https://api.github.com/users/MushroomObserver/following{/other_user}","gists_url":"https://api.github.com/users/MushroomObserver/gists{/gist_id}","starred_url":"https://api.github.com/users/MushroomObserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MushroomObserver/subscriptions","organizations_url":"https://api.github.com/users/MushroomObserver/orgs","repos_url":"https://api.github.com/users/MushroomObserver/repos","events_url":"https://api.github.com/users/MushroomObserver/events{/privacy}","received_events_url":"https://api.github.com/users/MushroomObserver/received_events","type":"Organization","site_admin":false},"repo":{"id":7514061,"name":"mushroom-observer","full_name":"MushroomObserver/mushroom-observer","owner":{"login":"MushroomObserver","id":3212163,"avatar_url":"https://avatars.githubusercontent.com/u/3212163?v=3","gravatar_id":"","url":"https://api.github.com/users/MushroomObserver","html_url":"https://github.com/MushroomObserver","followers_url":"https://api.github.com/users/MushroomObserver/followers","following_url":"https://api.github.com/users/MushroomObserver/following{/other_user}","gists_url":"https://api.github.com/users/MushroomObserver/gists{/gist_id}","starred_url":"https://api.github.com/users/MushroomObserver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MushroomObserver/subscriptions","organizations_url":"https://api.github.com/users/MushroomObserver/orgs","repos_url":"https://api.github.com/users/MushroomObserver/repos","events_url":"https://api.github.com/users/MushroomObserver/events{/privacy}","received_events_url":"https://api.github.com/users/MushroomObserver/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MushroomObserver/mushroom-observer","description":"A website for sharing observations of mushrooms.","fork":false,"url":"https://api.github.com/repos/MushroomObserver/mushroom-observer","forks_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/forks","keys_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/teams","hooks_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/hooks","issue_events_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/events{/number}","events_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/events","assignees_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/assignees{/user}","branches_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/branches{/branch}","tags_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/tags","blobs_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/git/refs{/sha}","trees_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/statuses/{sha}","languages_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/languages","stargazers_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/stargazers","contributors_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/contributors","subscribers_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/subscribers","subscription_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/subscription","commits_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/commits{/sha}","git_commits_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/git/commits{/sha}","comments_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/comments{/number}","issue_comment_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/comments{/number}","contents_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/contents/{+path}","compare_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/merges","archive_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/downloads","issues_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues{/number}","pulls_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls{/number}","milestones_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/milestones{/number}","notifications_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/labels{/name}","releases_url":"https://api.github.com/repos/MushroomObserver/mushroom-observer/releases{/id}","created_at":"2013-01-09T03:17:31Z","updated_at":"2015-07-30T23:47:16Z","pushed_at":"2015-10-13T14:58:25Z","git_url":"git://github.com/MushroomObserver/mushroom-observer.git","ssh_url":"git@github.com:MushroomObserver/mushroom-observer.git","clone_url":"https://github.com/MushroomObserver/mushroom-observer.git","svn_url":"https://github.com/MushroomObserver/mushroom-observer","homepage":"http://mushroomobserver.org","size":55705,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":4,"forks":8,"open_issues":4,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187"},"html":{"href":"https://github.com/MushroomObserver/mushroom-observer/pull/187"},"issue":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/187"},"comments":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/issues/187/comments"},"review_comments":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187/comments"},"review_comment":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/pulls/187/commits"},"statuses":{"href":"https://api.github.com/repos/MushroomObserver/mushroom-observer/statuses/c01102f13ccbd6109b609a000c6d8bf48d54ca76"}}}}