{"action":"created","comment":{"url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/comments/28751993","id":28751993,"diff_hunk":"@@ -193,10 +193,12 @@ def __str__(self):\n             retval += '\\n%post'\n         elif self.type == constants.KS_SCRIPT_TRACEBACK:\n             retval += '\\n%traceback'\n+        elif self.type == constants.KS_SCRIPT_PREINSTALL:\n+            retval += '\\n%pre-install'\n \n         if self.interp != \"/bin/sh\" and self.interp != \"\":\n             retval += \" --interpreter=%s\" % self.interp\n-        if self.type == constants.KS_SCRIPT_POST and not self.inChroot:\n+        if self.type in [constants.KS_SCRIPT_POST, constants.KS_SCRIPT_PREINSTALL] and not self.inChroot:","path":"pykickstart/parser.py","position":28,"original_position":28,"commit_id":"f79639f28cbb04073548b15c7c7a1abda8f5c044","original_commit_id":"f79639f28cbb04073548b15c7c7a1abda8f5c044","user":{"login":"vpodzime","id":1044278,"avatar_url":"https://avatars.githubusercontent.com/u/1044278?v=3","gravatar_id":"","url":"https://api.github.com/users/vpodzime","html_url":"https://github.com/vpodzime","followers_url":"https://api.github.com/users/vpodzime/followers","following_url":"https://api.github.com/users/vpodzime/following{/other_user}","gists_url":"https://api.github.com/users/vpodzime/gists{/gist_id}","starred_url":"https://api.github.com/users/vpodzime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpodzime/subscriptions","organizations_url":"https://api.github.com/users/vpodzime/orgs","repos_url":"https://api.github.com/users/vpodzime/repos","events_url":"https://api.github.com/users/vpodzime/events{/privacy}","received_events_url":"https://api.github.com/users/vpodzime/received_events","type":"User","site_admin":false},"body":"This seems to be not aligned with ``Like %pre these scripts do not run in the chrooted environment.``.","created_at":"2015-04-21T06:04:28Z","updated_at":"2015-04-21T06:04:28Z","html_url":"https://github.com/rhinstaller/pykickstart/pull/10#discussion_r28751993","pull_request_url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/comments/28751993"},"html":{"href":"https://github.com/rhinstaller/pykickstart/pull/10#discussion_r28751993"},"pull_request":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10","id":33714053,"html_url":"https://github.com/rhinstaller/pykickstart/pull/10","diff_url":"https://github.com/rhinstaller/pykickstart/pull/10.diff","patch_url":"https://github.com/rhinstaller/pykickstart/pull/10.patch","issue_url":"https://api.github.com/repos/rhinstaller/pykickstart/issues/10","number":10,"state":"open","locked":false,"title":"Add %pre-install section to be used after mounting filesystems","user":{"login":"bcl","id":212092,"avatar_url":"https://avatars.githubusercontent.com/u/212092?v=3","gravatar_id":"","url":"https://api.github.com/users/bcl","html_url":"https://github.com/bcl","followers_url":"https://api.github.com/users/bcl/followers","following_url":"https://api.github.com/users/bcl/following{/other_user}","gists_url":"https://api.github.com/users/bcl/gists{/gist_id}","starred_url":"https://api.github.com/users/bcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcl/subscriptions","organizations_url":"https://api.github.com/users/bcl/orgs","repos_url":"https://api.github.com/users/bcl/repos","events_url":"https://api.github.com/users/bcl/events{/privacy}","received_events_url":"https://api.github.com/users/bcl/received_events","type":"User","site_admin":false},"body":"This adds support for a %pre-install section which will be executed\r\nafter all the filesystems have been setup and mounted. It runs without\r\nchroot.","created_at":"2015-04-20T22:52:08Z","updated_at":"2015-04-21T06:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fa352067656e870f7f61c0df8990b768b8118585","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10/commits","review_comments_url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10/comments","review_comment_url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rhinstaller/pykickstart/issues/10/comments","statuses_url":"https://api.github.com/repos/rhinstaller/pykickstart/statuses/f79639f28cbb04073548b15c7c7a1abda8f5c044","head":{"label":"bcl:master-pre-install","ref":"master-pre-install","sha":"f79639f28cbb04073548b15c7c7a1abda8f5c044","user":{"login":"bcl","id":212092,"avatar_url":"https://avatars.githubusercontent.com/u/212092?v=3","gravatar_id":"","url":"https://api.github.com/users/bcl","html_url":"https://github.com/bcl","followers_url":"https://api.github.com/users/bcl/followers","following_url":"https://api.github.com/users/bcl/following{/other_user}","gists_url":"https://api.github.com/users/bcl/gists{/gist_id}","starred_url":"https://api.github.com/users/bcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcl/subscriptions","organizations_url":"https://api.github.com/users/bcl/orgs","repos_url":"https://api.github.com/users/bcl/repos","events_url":"https://api.github.com/users/bcl/events{/privacy}","received_events_url":"https://api.github.com/users/bcl/received_events","type":"User","site_admin":false},"repo":{"id":32098881,"name":"pykickstart","full_name":"bcl/pykickstart","owner":{"login":"bcl","id":212092,"avatar_url":"https://avatars.githubusercontent.com/u/212092?v=3","gravatar_id":"","url":"https://api.github.com/users/bcl","html_url":"https://github.com/bcl","followers_url":"https://api.github.com/users/bcl/followers","following_url":"https://api.github.com/users/bcl/following{/other_user}","gists_url":"https://api.github.com/users/bcl/gists{/gist_id}","starred_url":"https://api.github.com/users/bcl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcl/subscriptions","organizations_url":"https://api.github.com/users/bcl/orgs","repos_url":"https://api.github.com/users/bcl/repos","events_url":"https://api.github.com/users/bcl/events{/privacy}","received_events_url":"https://api.github.com/users/bcl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcl/pykickstart","description":"python module for parsing and writing kickstart configs","fork":true,"url":"https://api.github.com/repos/bcl/pykickstart","forks_url":"https://api.github.com/repos/bcl/pykickstart/forks","keys_url":"https://api.github.com/repos/bcl/pykickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcl/pykickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcl/pykickstart/teams","hooks_url":"https://api.github.com/repos/bcl/pykickstart/hooks","issue_events_url":"https://api.github.com/repos/bcl/pykickstart/issues/events{/number}","events_url":"https://api.github.com/repos/bcl/pykickstart/events","assignees_url":"https://api.github.com/repos/bcl/pykickstart/assignees{/user}","branches_url":"https://api.github.com/repos/bcl/pykickstart/branches{/branch}","tags_url":"https://api.github.com/repos/bcl/pykickstart/tags","blobs_url":"https://api.github.com/repos/bcl/pykickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcl/pykickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcl/pykickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcl/pykickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcl/pykickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/bcl/pykickstart/languages","stargazers_url":"https://api.github.com/repos/bcl/pykickstart/stargazers","contributors_url":"https://api.github.com/repos/bcl/pykickstart/contributors","subscribers_url":"https://api.github.com/repos/bcl/pykickstart/subscribers","subscription_url":"https://api.github.com/repos/bcl/pykickstart/subscription","commits_url":"https://api.github.com/repos/bcl/pykickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcl/pykickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcl/pykickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcl/pykickstart/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcl/pykickstart/contents/{+path}","compare_url":"https://api.github.com/repos/bcl/pykickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcl/pykickstart/merges","archive_url":"https://api.github.com/repos/bcl/pykickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcl/pykickstart/downloads","issues_url":"https://api.github.com/repos/bcl/pykickstart/issues{/number}","pulls_url":"https://api.github.com/repos/bcl/pykickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/bcl/pykickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/bcl/pykickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcl/pykickstart/labels{/name}","releases_url":"https://api.github.com/repos/bcl/pykickstart/releases{/id}","created_at":"2015-03-12T19:53:50Z","updated_at":"2015-04-20T19:05:59Z","pushed_at":"2015-04-20T22:51:41Z","git_url":"git://github.com/bcl/pykickstart.git","ssh_url":"git@github.com:bcl/pykickstart.git","clone_url":"https://github.com/bcl/pykickstart.git","svn_url":"https://github.com/bcl/pykickstart","homepage":null,"size":1875,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rhinstaller:master","ref":"master","sha":"b2d57ee0a3f016681fc02baa91810e7da0b234b3","user":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"repo":{"id":25171011,"name":"pykickstart","full_name":"rhinstaller/pykickstart","owner":{"login":"rhinstaller","id":10549274,"avatar_url":"https://avatars.githubusercontent.com/u/10549274?v=3","gravatar_id":"","url":"https://api.github.com/users/rhinstaller","html_url":"https://github.com/rhinstaller","followers_url":"https://api.github.com/users/rhinstaller/followers","following_url":"https://api.github.com/users/rhinstaller/following{/other_user}","gists_url":"https://api.github.com/users/rhinstaller/gists{/gist_id}","starred_url":"https://api.github.com/users/rhinstaller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhinstaller/subscriptions","organizations_url":"https://api.github.com/users/rhinstaller/orgs","repos_url":"https://api.github.com/users/rhinstaller/repos","events_url":"https://api.github.com/users/rhinstaller/events{/privacy}","received_events_url":"https://api.github.com/users/rhinstaller/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rhinstaller/pykickstart","description":"python module for parsing and writing kickstart configs","fork":false,"url":"https://api.github.com/repos/rhinstaller/pykickstart","forks_url":"https://api.github.com/repos/rhinstaller/pykickstart/forks","keys_url":"https://api.github.com/repos/rhinstaller/pykickstart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rhinstaller/pykickstart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rhinstaller/pykickstart/teams","hooks_url":"https://api.github.com/repos/rhinstaller/pykickstart/hooks","issue_events_url":"https://api.github.com/repos/rhinstaller/pykickstart/issues/events{/number}","events_url":"https://api.github.com/repos/rhinstaller/pykickstart/events","assignees_url":"https://api.github.com/repos/rhinstaller/pykickstart/assignees{/user}","branches_url":"https://api.github.com/repos/rhinstaller/pykickstart/branches{/branch}","tags_url":"https://api.github.com/repos/rhinstaller/pykickstart/tags","blobs_url":"https://api.github.com/repos/rhinstaller/pykickstart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rhinstaller/pykickstart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rhinstaller/pykickstart/git/refs{/sha}","trees_url":"https://api.github.com/repos/rhinstaller/pykickstart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rhinstaller/pykickstart/statuses/{sha}","languages_url":"https://api.github.com/repos/rhinstaller/pykickstart/languages","stargazers_url":"https://api.github.com/repos/rhinstaller/pykickstart/stargazers","contributors_url":"https://api.github.com/repos/rhinstaller/pykickstart/contributors","subscribers_url":"https://api.github.com/repos/rhinstaller/pykickstart/subscribers","subscription_url":"https://api.github.com/repos/rhinstaller/pykickstart/subscription","commits_url":"https://api.github.com/repos/rhinstaller/pykickstart/commits{/sha}","git_commits_url":"https://api.github.com/repos/rhinstaller/pykickstart/git/commits{/sha}","comments_url":"https://api.github.com/repos/rhinstaller/pykickstart/comments{/number}","issue_comment_url":"https://api.github.com/repos/rhinstaller/pykickstart/issues/comments{/number}","contents_url":"https://api.github.com/repos/rhinstaller/pykickstart/contents/{+path}","compare_url":"https://api.github.com/repos/rhinstaller/pykickstart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rhinstaller/pykickstart/merges","archive_url":"https://api.github.com/repos/rhinstaller/pykickstart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rhinstaller/pykickstart/downloads","issues_url":"https://api.github.com/repos/rhinstaller/pykickstart/issues{/number}","pulls_url":"https://api.github.com/repos/rhinstaller/pykickstart/pulls{/number}","milestones_url":"https://api.github.com/repos/rhinstaller/pykickstart/milestones{/number}","notifications_url":"https://api.github.com/repos/rhinstaller/pykickstart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rhinstaller/pykickstart/labels{/name}","releases_url":"https://api.github.com/repos/rhinstaller/pykickstart/releases{/id}","created_at":"2014-10-13T18:09:33Z","updated_at":"2015-04-17T21:27:27Z","pushed_at":"2015-04-20T22:52:10Z","git_url":"git://github.com/rhinstaller/pykickstart.git","ssh_url":"git@github.com:rhinstaller/pykickstart.git","clone_url":"https://github.com/rhinstaller/pykickstart.git","svn_url":"https://github.com/rhinstaller/pykickstart","homepage":null,"size":2737,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":4,"forks":6,"open_issues":4,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10"},"html":{"href":"https://github.com/rhinstaller/pykickstart/pull/10"},"issue":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/issues/10"},"comments":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/rhinstaller/pykickstart/statuses/f79639f28cbb04073548b15c7c7a1abda8f5c044"}}}}