{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/sublimehq/Packages/pulls/4","id":37820949,"html_url":"https://github.com/sublimehq/Packages/pull/4","diff_url":"https://github.com/sublimehq/Packages/pull/4.diff","patch_url":"https://github.com/sublimehq/Packages/pull/4.patch","issue_url":"https://api.github.com/repos/sublimehq/Packages/issues/4","number":4,"state":"closed","locked":false,"title":"Add figure and figcaption HTML elements to completion","user":{"login":"kleinfreund","id":5774638,"avatar_url":"https://avatars.githubusercontent.com/u/5774638?v=3","gravatar_id":"","url":"https://api.github.com/users/kleinfreund","html_url":"https://github.com/kleinfreund","followers_url":"https://api.github.com/users/kleinfreund/followers","following_url":"https://api.github.com/users/kleinfreund/following{/other_user}","gists_url":"https://api.github.com/users/kleinfreund/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinfreund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinfreund/subscriptions","organizations_url":"https://api.github.com/users/kleinfreund/orgs","repos_url":"https://api.github.com/users/kleinfreund/repos","events_url":"https://api.github.com/users/kleinfreund/events{/privacy}","received_events_url":"https://api.github.com/users/kleinfreund/received_events","type":"User","site_admin":false},"body":"This aims at adding the HTML `figure` and `figcaption` elements to the completion file. This is merely a draft, because I have some questions.\r\n\r\nAccording to the Mozilla Developer Network, both elements ([figure](https://developer.mozilla.org/en/docs/Web/HTML/Element/figure#Attributes), [figcaption](https://developer.mozilla.org/en/docs/Web/HTML/Element/figcaption#Attributes)) only include the [global attributes](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes)\r\n\r\nI included the ones not marked as experimental but I left out all the event handler attributes, because that would add quite a mess and I'm not sure what's the policy here.\r\n\r\nThat said, there evolves a bigger question.\r\n\r\n> Global attributes are attributes common to all HTML elements; they can be used on all elements, though the attributes may have no effect on some elements.\r\n\r\nShould there not be a default list of attributes (the global ones) that are allowed on all elements? Then we would not need to include them for each element like it's done in the file.\r\n\r\nApart from this, I did not test this locally, yet. Is there something else I need to take care of?","created_at":"2015-06-16T17:37:23Z","updated_at":"2015-06-16T22:28:52Z","closed_at":"2015-06-16T22:28:52Z","merged_at":"2015-06-16T22:28:52Z","merge_commit_sha":"e93a979c83e36c39ab5723a8e88dcceb315bccc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sublimehq/Packages/pulls/4/commits","review_comments_url":"https://api.github.com/repos/sublimehq/Packages/pulls/4/comments","review_comment_url":"https://api.github.com/repos/sublimehq/Packages/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sublimehq/Packages/issues/4/comments","statuses_url":"https://api.github.com/repos/sublimehq/Packages/statuses/c8c60a63b8eb3dfe1ad746887da19ebb2a58239b","head":{"label":"kleinfreund:patch-1","ref":"patch-1","sha":"c8c60a63b8eb3dfe1ad746887da19ebb2a58239b","user":{"login":"kleinfreund","id":5774638,"avatar_url":"https://avatars.githubusercontent.com/u/5774638?v=3","gravatar_id":"","url":"https://api.github.com/users/kleinfreund","html_url":"https://github.com/kleinfreund","followers_url":"https://api.github.com/users/kleinfreund/followers","following_url":"https://api.github.com/users/kleinfreund/following{/other_user}","gists_url":"https://api.github.com/users/kleinfreund/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinfreund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinfreund/subscriptions","organizations_url":"https://api.github.com/users/kleinfreund/orgs","repos_url":"https://api.github.com/users/kleinfreund/repos","events_url":"https://api.github.com/users/kleinfreund/events{/privacy}","received_events_url":"https://api.github.com/users/kleinfreund/received_events","type":"User","site_admin":false},"repo":{"id":37545227,"name":"Packages","full_name":"kleinfreund/Packages","owner":{"login":"kleinfreund","id":5774638,"avatar_url":"https://avatars.githubusercontent.com/u/5774638?v=3","gravatar_id":"","url":"https://api.github.com/users/kleinfreund","html_url":"https://github.com/kleinfreund","followers_url":"https://api.github.com/users/kleinfreund/followers","following_url":"https://api.github.com/users/kleinfreund/following{/other_user}","gists_url":"https://api.github.com/users/kleinfreund/gists{/gist_id}","starred_url":"https://api.github.com/users/kleinfreund/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kleinfreund/subscriptions","organizations_url":"https://api.github.com/users/kleinfreund/orgs","repos_url":"https://api.github.com/users/kleinfreund/repos","events_url":"https://api.github.com/users/kleinfreund/events{/privacy}","received_events_url":"https://api.github.com/users/kleinfreund/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kleinfreund/Packages","description":"","fork":true,"url":"https://api.github.com/repos/kleinfreund/Packages","forks_url":"https://api.github.com/repos/kleinfreund/Packages/forks","keys_url":"https://api.github.com/repos/kleinfreund/Packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kleinfreund/Packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kleinfreund/Packages/teams","hooks_url":"https://api.github.com/repos/kleinfreund/Packages/hooks","issue_events_url":"https://api.github.com/repos/kleinfreund/Packages/issues/events{/number}","events_url":"https://api.github.com/repos/kleinfreund/Packages/events","assignees_url":"https://api.github.com/repos/kleinfreund/Packages/assignees{/user}","branches_url":"https://api.github.com/repos/kleinfreund/Packages/branches{/branch}","tags_url":"https://api.github.com/repos/kleinfreund/Packages/tags","blobs_url":"https://api.github.com/repos/kleinfreund/Packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kleinfreund/Packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kleinfreund/Packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/kleinfreund/Packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kleinfreund/Packages/statuses/{sha}","languages_url":"https://api.github.com/repos/kleinfreund/Packages/languages","stargazers_url":"https://api.github.com/repos/kleinfreund/Packages/stargazers","contributors_url":"https://api.github.com/repos/kleinfreund/Packages/contributors","subscribers_url":"https://api.github.com/repos/kleinfreund/Packages/subscribers","subscription_url":"https://api.github.com/repos/kleinfreund/Packages/subscription","commits_url":"https://api.github.com/repos/kleinfreund/Packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/kleinfreund/Packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/kleinfreund/Packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/kleinfreund/Packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/kleinfreund/Packages/contents/{+path}","compare_url":"https://api.github.com/repos/kleinfreund/Packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kleinfreund/Packages/merges","archive_url":"https://api.github.com/repos/kleinfreund/Packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kleinfreund/Packages/downloads","issues_url":"https://api.github.com/repos/kleinfreund/Packages/issues{/number}","pulls_url":"https://api.github.com/repos/kleinfreund/Packages/pulls{/number}","milestones_url":"https://api.github.com/repos/kleinfreund/Packages/milestones{/number}","notifications_url":"https://api.github.com/repos/kleinfreund/Packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kleinfreund/Packages/labels{/name}","releases_url":"https://api.github.com/repos/kleinfreund/Packages/releases{/id}","created_at":"2015-06-16T17:28:08Z","updated_at":"2015-06-16T17:28:10Z","pushed_at":"2015-06-16T17:36:46Z","git_url":"git://github.com/kleinfreund/Packages.git","ssh_url":"git@github.com:kleinfreund/Packages.git","clone_url":"https://github.com/kleinfreund/Packages.git","svn_url":"https://github.com/kleinfreund/Packages","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sublimehq:master","ref":"master","sha":"971e6ea0ac3d5b72709c3286265187f585d68ca9","user":{"login":"sublimehq","id":1161584,"avatar_url":"https://avatars.githubusercontent.com/u/1161584?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimehq","html_url":"https://github.com/sublimehq","followers_url":"https://api.github.com/users/sublimehq/followers","following_url":"https://api.github.com/users/sublimehq/following{/other_user}","gists_url":"https://api.github.com/users/sublimehq/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimehq/subscriptions","organizations_url":"https://api.github.com/users/sublimehq/orgs","repos_url":"https://api.github.com/users/sublimehq/repos","events_url":"https://api.github.com/users/sublimehq/events{/privacy}","received_events_url":"https://api.github.com/users/sublimehq/received_events","type":"User","site_admin":false},"repo":{"id":37357499,"name":"Packages","full_name":"sublimehq/Packages","owner":{"login":"sublimehq","id":1161584,"avatar_url":"https://avatars.githubusercontent.com/u/1161584?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimehq","html_url":"https://github.com/sublimehq","followers_url":"https://api.github.com/users/sublimehq/followers","following_url":"https://api.github.com/users/sublimehq/following{/other_user}","gists_url":"https://api.github.com/users/sublimehq/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimehq/subscriptions","organizations_url":"https://api.github.com/users/sublimehq/orgs","repos_url":"https://api.github.com/users/sublimehq/repos","events_url":"https://api.github.com/users/sublimehq/events{/privacy}","received_events_url":"https://api.github.com/users/sublimehq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sublimehq/Packages","description":"","fork":false,"url":"https://api.github.com/repos/sublimehq/Packages","forks_url":"https://api.github.com/repos/sublimehq/Packages/forks","keys_url":"https://api.github.com/repos/sublimehq/Packages/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sublimehq/Packages/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sublimehq/Packages/teams","hooks_url":"https://api.github.com/repos/sublimehq/Packages/hooks","issue_events_url":"https://api.github.com/repos/sublimehq/Packages/issues/events{/number}","events_url":"https://api.github.com/repos/sublimehq/Packages/events","assignees_url":"https://api.github.com/repos/sublimehq/Packages/assignees{/user}","branches_url":"https://api.github.com/repos/sublimehq/Packages/branches{/branch}","tags_url":"https://api.github.com/repos/sublimehq/Packages/tags","blobs_url":"https://api.github.com/repos/sublimehq/Packages/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sublimehq/Packages/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sublimehq/Packages/git/refs{/sha}","trees_url":"https://api.github.com/repos/sublimehq/Packages/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sublimehq/Packages/statuses/{sha}","languages_url":"https://api.github.com/repos/sublimehq/Packages/languages","stargazers_url":"https://api.github.com/repos/sublimehq/Packages/stargazers","contributors_url":"https://api.github.com/repos/sublimehq/Packages/contributors","subscribers_url":"https://api.github.com/repos/sublimehq/Packages/subscribers","subscription_url":"https://api.github.com/repos/sublimehq/Packages/subscription","commits_url":"https://api.github.com/repos/sublimehq/Packages/commits{/sha}","git_commits_url":"https://api.github.com/repos/sublimehq/Packages/git/commits{/sha}","comments_url":"https://api.github.com/repos/sublimehq/Packages/comments{/number}","issue_comment_url":"https://api.github.com/repos/sublimehq/Packages/issues/comments{/number}","contents_url":"https://api.github.com/repos/sublimehq/Packages/contents/{+path}","compare_url":"https://api.github.com/repos/sublimehq/Packages/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sublimehq/Packages/merges","archive_url":"https://api.github.com/repos/sublimehq/Packages/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sublimehq/Packages/downloads","issues_url":"https://api.github.com/repos/sublimehq/Packages/issues{/number}","pulls_url":"https://api.github.com/repos/sublimehq/Packages/pulls{/number}","milestones_url":"https://api.github.com/repos/sublimehq/Packages/milestones{/number}","notifications_url":"https://api.github.com/repos/sublimehq/Packages/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sublimehq/Packages/labels{/name}","releases_url":"https://api.github.com/repos/sublimehq/Packages/releases{/id}","created_at":"2015-06-13T04:17:44Z","updated_at":"2015-06-16T21:25:35Z","pushed_at":"2015-06-16T22:28:52Z","git_url":"git://github.com/sublimehq/Packages.git","ssh_url":"git@github.com:sublimehq/Packages.git","clone_url":"https://github.com/sublimehq/Packages.git","svn_url":"https://github.com/sublimehq/Packages","homepage":null,"size":0,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/4"},"html":{"href":"https://github.com/sublimehq/Packages/pull/4"},"issue":{"href":"https://api.github.com/repos/sublimehq/Packages/issues/4"},"comments":{"href":"https://api.github.com/repos/sublimehq/Packages/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sublimehq/Packages/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/sublimehq/Packages/statuses/c8c60a63b8eb3dfe1ad746887da19ebb2a58239b"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sublimehq","id":1161584,"avatar_url":"https://avatars.githubusercontent.com/u/1161584?v=3","gravatar_id":"","url":"https://api.github.com/users/sublimehq","html_url":"https://github.com/sublimehq","followers_url":"https://api.github.com/users/sublimehq/followers","following_url":"https://api.github.com/users/sublimehq/following{/other_user}","gists_url":"https://api.github.com/users/sublimehq/gists{/gist_id}","starred_url":"https://api.github.com/users/sublimehq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sublimehq/subscriptions","organizations_url":"https://api.github.com/users/sublimehq/orgs","repos_url":"https://api.github.com/users/sublimehq/repos","events_url":"https://api.github.com/users/sublimehq/events{/privacy}","received_events_url":"https://api.github.com/users/sublimehq/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"commits":1,"additions":3,"deletions":2,"changed_files":1}}