{"action":"closed","issue":{"url":"https://api.github.com/repos/kardianos/vendor-spec/issues/5","labels_url":"https://api.github.com/repos/kardianos/vendor-spec/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/kardianos/vendor-spec/issues/5/comments","events_url":"https://api.github.com/repos/kardianos/vendor-spec/issues/5/events","html_url":"https://github.com/kardianos/vendor-spec/issues/5","id":73805744,"number":5,"title":"spec: Package.Version should be Package.Revision","user":{"login":"davecheney","id":7171,"avatar_url":"https://avatars.githubusercontent.com/u/7171?v=3","gravatar_id":"","url":"https://api.github.com/users/davecheney","html_url":"https://github.com/davecheney","followers_url":"https://api.github.com/users/davecheney/followers","following_url":"https://api.github.com/users/davecheney/following{/other_user}","gists_url":"https://api.github.com/users/davecheney/gists{/gist_id}","starred_url":"https://api.github.com/users/davecheney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davecheney/subscriptions","organizations_url":"https://api.github.com/users/davecheney/orgs","repos_url":"https://api.github.com/users/davecheney/repos","events_url":"https://api.github.com/users/davecheney/events{/privacy}","received_events_url":"https://api.github.com/users/davecheney/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-07T02:13:13Z","updated_at":"2015-05-07T03:48:55Z","closed_at":"2015-05-07T03:48:55Z","body":"From the proposed spec\r\n```\r\n        // The version of the package. This field must be persisted by all\r\n        // tools, but not all tools will interpret this field.\r\n        // The value of Version should be a single value that can be used\r\n        // to fetch the same or similar version.\r\n        // Examples: \"abc104...438ade0\", \"v1.3.5\"\r\n        Version string\r\n```\r\nI believe this is incorrect. \r\n\r\nGo packages do not currently have versions, at least not in the way that npm packages, cpan modules, maven jars, or python eggs, have versions.\r\n\r\nGo packages may live in source control and that source control system may defined a _revision_ which identifies the particular copy of the source of that package at a point in time -- which is what this field is capturing.\r\n\r\nI'm not saying that Go packages shouldn't have versions, but I am certain that they don't have a version at the moment and the spec should instead capture the _revision_.\r\n\r\n/cc @kardianos @jbuberel "}}