{"action":"created","comment":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/comments/40622316","id":40622316,"diff_hunk":"@@ -788,7 +788,8 @@ int binarySearch(T needle, RandomAccessIterator start, RandomAccessIterator end,\n     int l = 0;\n     int r = end - start - 1;\n     while (l <= r) {\n-        int mid = l + (r - l) / 2;","path":"src/core/types.h","position":4,"original_position":4,"commit_id":"d2a56108524a3d4d3606a782b66f5ec5223cf234","original_commit_id":"d2a56108524a3d4d3606a782b66f5ec5223cf234","user":{"login":"corona10","id":5110323,"avatar_url":"https://avatars.githubusercontent.com/u/5110323?v=3","gravatar_id":"","url":"https://api.github.com/users/corona10","html_url":"https://github.com/corona10","followers_url":"https://api.github.com/users/corona10/followers","following_url":"https://api.github.com/users/corona10/following{/other_user}","gists_url":"https://api.github.com/users/corona10/gists{/gist_id}","starred_url":"https://api.github.com/users/corona10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corona10/subscriptions","organizations_url":"https://api.github.com/users/corona10/orgs","repos_url":"https://api.github.com/users/corona10/repos","events_url":"https://api.github.com/users/corona10/events{/privacy}","received_events_url":"https://api.github.com/users/corona10/received_events","type":"User","site_admin":false},"body":"@Daetalus l + (r - l) can be overflow if needle value is right-end near value,  l and r can be large\r\nhow about read this article \r\n\r\nhttp://googleresearch.blogspot.kr/2006/06/extra-extra-read-all-about-it-nearly.html","created_at":"2015-09-29T00:21:15Z","updated_at":"2015-09-29T00:21:15Z","html_url":"https://github.com/dropbox/pyston/pull/938#discussion_r40622316","pull_request_url":"https://api.github.com/repos/dropbox/pyston/pulls/938","_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments/40622316"},"html":{"href":"https://github.com/dropbox/pyston/pull/938#discussion_r40622316"},"pull_request":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/938"}}},"pull_request":{"url":"https://api.github.com/repos/dropbox/pyston/pulls/938","id":46168970,"html_url":"https://github.com/dropbox/pyston/pull/938","diff_url":"https://github.com/dropbox/pyston/pull/938.diff","patch_url":"https://github.com/dropbox/pyston/pull/938.patch","issue_url":"https://api.github.com/repos/dropbox/pyston/issues/938","number":938,"state":"open","locked":false,"title":"Some fix of Ellpisis","user":{"login":"corona10","id":5110323,"avatar_url":"https://avatars.githubusercontent.com/u/5110323?v=3","gravatar_id":"","url":"https://api.github.com/users/corona10","html_url":"https://github.com/corona10","followers_url":"https://api.github.com/users/corona10/followers","following_url":"https://api.github.com/users/corona10/following{/other_user}","gists_url":"https://api.github.com/users/corona10/gists{/gist_id}","starred_url":"https://api.github.com/users/corona10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corona10/subscriptions","organizations_url":"https://api.github.com/users/corona10/orgs","repos_url":"https://api.github.com/users/corona10/repos","events_url":"https://api.github.com/users/corona10/events{/privacy}","received_events_url":"https://api.github.com/users/corona10/received_events","type":"User","site_admin":false},"body":"* prevent overflow while calculating mid value (src/core/types.h)\r\n*  some fix of Ellipsis\r\n*  add Ellipsis test\r\n\r\nbefore fixing  code\r\n```\r\nclass TestEllipsis(object):\r\n   def __getitem__(self, item):\r\n      if item is Ellipsis:\r\n         return \"Ellipsis\"\r\n      else:\r\n         return \"return %r items\" % item\r\n\r\nprint Ellipsis\r\nv = Ellipsis\r\nprint v\r\nprint type(v)\r\nx = TestEllipsis()\r\nprint x[2]\r\nprint x[...]\r\n```\r\nresults as \r\n\r\n```\r\n<ellipsis object at 0x127000c4a8>\r\n<ellipsis object at 0x127000c4a8>\r\n<type 'ellipsis'>\r\nreturn 2 items\r\n../../src/codegen/ast_interpreter.cpp:552: pyston::Value pyston::<anonymous namespace>::ASTInterpreter::visit_slice(pyston::AST_slice *): Assertion `0' failed: not implemented\r\nSomeone called abort!\r\nTraceback (most recent call last):\r\n  File \"ellipsis_getname.py\", line 16, in <module>:\r\n    print x[...]\r\n```\r\n\r\nbut now \r\n\r\n```\r\nEllipsis\r\nEllipsis\r\n<type 'ellipsis'>\r\nreturn 2 items\r\nreturn Ellipsis items  ==> this should be Ellipsis it will fix at future..\r\n```\r\n","created_at":"2015-09-28T15:13:55Z","updated_at":"2015-09-29T00:21:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"26116a4de72841120ebcee27e1ac23a943166731","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dropbox/pyston/pulls/938/commits","review_comments_url":"https://api.github.com/repos/dropbox/pyston/pulls/938/comments","review_comment_url":"https://api.github.com/repos/dropbox/pyston/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dropbox/pyston/issues/938/comments","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/d2a56108524a3d4d3606a782b66f5ec5223cf234","head":{"label":"corona10:fix","ref":"fix","sha":"d2a56108524a3d4d3606a782b66f5ec5223cf234","user":{"login":"corona10","id":5110323,"avatar_url":"https://avatars.githubusercontent.com/u/5110323?v=3","gravatar_id":"","url":"https://api.github.com/users/corona10","html_url":"https://github.com/corona10","followers_url":"https://api.github.com/users/corona10/followers","following_url":"https://api.github.com/users/corona10/following{/other_user}","gists_url":"https://api.github.com/users/corona10/gists{/gist_id}","starred_url":"https://api.github.com/users/corona10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corona10/subscriptions","organizations_url":"https://api.github.com/users/corona10/orgs","repos_url":"https://api.github.com/users/corona10/repos","events_url":"https://api.github.com/users/corona10/events{/privacy}","received_events_url":"https://api.github.com/users/corona10/received_events","type":"User","site_admin":false},"repo":{"id":39628753,"name":"pyston","full_name":"corona10/pyston","owner":{"login":"corona10","id":5110323,"avatar_url":"https://avatars.githubusercontent.com/u/5110323?v=3","gravatar_id":"","url":"https://api.github.com/users/corona10","html_url":"https://github.com/corona10","followers_url":"https://api.github.com/users/corona10/followers","following_url":"https://api.github.com/users/corona10/following{/other_user}","gists_url":"https://api.github.com/users/corona10/gists{/gist_id}","starred_url":"https://api.github.com/users/corona10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/corona10/subscriptions","organizations_url":"https://api.github.com/users/corona10/orgs","repos_url":"https://api.github.com/users/corona10/repos","events_url":"https://api.github.com/users/corona10/events{/privacy}","received_events_url":"https://api.github.com/users/corona10/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/corona10/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":true,"url":"https://api.github.com/repos/corona10/pyston","forks_url":"https://api.github.com/repos/corona10/pyston/forks","keys_url":"https://api.github.com/repos/corona10/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/corona10/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/corona10/pyston/teams","hooks_url":"https://api.github.com/repos/corona10/pyston/hooks","issue_events_url":"https://api.github.com/repos/corona10/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/corona10/pyston/events","assignees_url":"https://api.github.com/repos/corona10/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/corona10/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/corona10/pyston/tags","blobs_url":"https://api.github.com/repos/corona10/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/corona10/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/corona10/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/corona10/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/corona10/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/corona10/pyston/languages","stargazers_url":"https://api.github.com/repos/corona10/pyston/stargazers","contributors_url":"https://api.github.com/repos/corona10/pyston/contributors","subscribers_url":"https://api.github.com/repos/corona10/pyston/subscribers","subscription_url":"https://api.github.com/repos/corona10/pyston/subscription","commits_url":"https://api.github.com/repos/corona10/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/corona10/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/corona10/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/corona10/pyston/issues/comments{/number}","contents_url":"https://api.github.com/repos/corona10/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/corona10/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/corona10/pyston/merges","archive_url":"https://api.github.com/repos/corona10/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/corona10/pyston/downloads","issues_url":"https://api.github.com/repos/corona10/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/corona10/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/corona10/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/corona10/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/corona10/pyston/labels{/name}","releases_url":"https://api.github.com/repos/corona10/pyston/releases{/id}","created_at":"2015-07-24T11:19:24Z","updated_at":"2015-07-24T11:19:33Z","pushed_at":"2015-09-28T15:08:28Z","git_url":"git://github.com/corona10/pyston.git","ssh_url":"git@github.com:corona10/pyston.git","clone_url":"https://github.com/corona10/pyston.git","svn_url":"https://github.com/corona10/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":28306,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dropbox:master","ref":"master","sha":"ac69cfef0621dbc8901175e84fa2b5cb5781a646","user":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"repo":{"id":18320947,"name":"pyston","full_name":"dropbox/pyston","owner":{"login":"dropbox","id":559357,"avatar_url":"https://avatars.githubusercontent.com/u/559357?v=3","gravatar_id":"","url":"https://api.github.com/users/dropbox","html_url":"https://github.com/dropbox","followers_url":"https://api.github.com/users/dropbox/followers","following_url":"https://api.github.com/users/dropbox/following{/other_user}","gists_url":"https://api.github.com/users/dropbox/gists{/gist_id}","starred_url":"https://api.github.com/users/dropbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dropbox/subscriptions","organizations_url":"https://api.github.com/users/dropbox/orgs","repos_url":"https://api.github.com/users/dropbox/repos","events_url":"https://api.github.com/users/dropbox/events{/privacy}","received_events_url":"https://api.github.com/users/dropbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dropbox/pyston","description":"An open-source Python implementation using JIT techniques. ","fork":false,"url":"https://api.github.com/repos/dropbox/pyston","forks_url":"https://api.github.com/repos/dropbox/pyston/forks","keys_url":"https://api.github.com/repos/dropbox/pyston/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dropbox/pyston/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dropbox/pyston/teams","hooks_url":"https://api.github.com/repos/dropbox/pyston/hooks","issue_events_url":"https://api.github.com/repos/dropbox/pyston/issues/events{/number}","events_url":"https://api.github.com/repos/dropbox/pyston/events","assignees_url":"https://api.github.com/repos/dropbox/pyston/assignees{/user}","branches_url":"https://api.github.com/repos/dropbox/pyston/branches{/branch}","tags_url":"https://api.github.com/repos/dropbox/pyston/tags","blobs_url":"https://api.github.com/repos/dropbox/pyston/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dropbox/pyston/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dropbox/pyston/git/refs{/sha}","trees_url":"https://api.github.com/repos/dropbox/pyston/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dropbox/pyston/statuses/{sha}","languages_url":"https://api.github.com/repos/dropbox/pyston/languages","stargazers_url":"https://api.github.com/repos/dropbox/pyston/stargazers","contributors_url":"https://api.github.com/repos/dropbox/pyston/contributors","subscribers_url":"https://api.github.com/repos/dropbox/pyston/subscribers","subscription_url":"https://api.github.com/repos/dropbox/pyston/subscription","commits_url":"https://api.github.com/repos/dropbox/pyston/commits{/sha}","git_commits_url":"https://api.github.com/repos/dropbox/pyston/git/commits{/sha}","comments_url":"https://api.github.com/repos/dropbox/pyston/comments{/number}","issue_comment_url":"https://api.github.com/repos/dropbox/pyston/issues/comments{/number}","contents_url":"https://api.github.com/repos/dropbox/pyston/contents/{+path}","compare_url":"https://api.github.com/repos/dropbox/pyston/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dropbox/pyston/merges","archive_url":"https://api.github.com/repos/dropbox/pyston/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dropbox/pyston/downloads","issues_url":"https://api.github.com/repos/dropbox/pyston/issues{/number}","pulls_url":"https://api.github.com/repos/dropbox/pyston/pulls{/number}","milestones_url":"https://api.github.com/repos/dropbox/pyston/milestones{/number}","notifications_url":"https://api.github.com/repos/dropbox/pyston/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dropbox/pyston/labels{/name}","releases_url":"https://api.github.com/repos/dropbox/pyston/releases{/id}","created_at":"2014-04-01T07:17:20Z","updated_at":"2015-09-28T19:48:23Z","pushed_at":"2015-09-28T18:02:21Z","git_url":"git://github.com/dropbox/pyston.git","ssh_url":"git@github.com:dropbox/pyston.git","clone_url":"https://github.com/dropbox/pyston.git","svn_url":"https://github.com/dropbox/pyston","homepage":"https://tech.dropbox.com/2014/04/introducing-pyston-an-upcoming-jit-based-python-implementation/","size":39890,"stargazers_count":3162,"watchers_count":3162,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":77,"forks":222,"open_issues":77,"watchers":3162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/938"},"html":{"href":"https://github.com/dropbox/pyston/pull/938"},"issue":{"href":"https://api.github.com/repos/dropbox/pyston/issues/938"},"comments":{"href":"https://api.github.com/repos/dropbox/pyston/issues/938/comments"},"review_comments":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/938/comments"},"review_comment":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dropbox/pyston/pulls/938/commits"},"statuses":{"href":"https://api.github.com/repos/dropbox/pyston/statuses/d2a56108524a3d4d3606a782b66f5ec5223cf234"}}}}