{"action":"created","issue":{"url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/issues/11","labels_url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/issues/11/comments","events_url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/issues/11/events","html_url":"https://github.com/angular-ui/ui-scrollpoint/pull/11","id":120089213,"number":11,"title":"refactoring ui-scrollpoint structure","user":{"login":"plong0","id":584954,"avatar_url":"https://avatars.githubusercontent.com/u/584954?v=3","gravatar_id":"","url":"https://api.github.com/users/plong0","html_url":"https://github.com/plong0","followers_url":"https://api.github.com/users/plong0/followers","following_url":"https://api.github.com/users/plong0/following{/other_user}","gists_url":"https://api.github.com/users/plong0/gists{/gist_id}","starred_url":"https://api.github.com/users/plong0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plong0/subscriptions","organizations_url":"https://api.github.com/users/plong0/orgs","repos_url":"https://api.github.com/users/plong0/repos","events_url":"https://api.github.com/users/plong0/events{/privacy}","received_events_url":"https://api.github.com/users/plong0/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-12-03T03:53:08Z","updated_at":"2015-12-09T01:36:21Z","closed_at":"2015-12-09T01:33:02Z","pull_request":{"url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/pulls/11","html_url":"https://github.com/angular-ui/ui-scrollpoint/pull/11","diff_url":"https://github.com/angular-ui/ui-scrollpoint/pull/11.diff","patch_url":"https://github.com/angular-ui/ui-scrollpoint/pull/11.patch"},"body":"- rebuilt ui-scrollpoint using extendable controller\r\n- redesigned demo\r\n- replaced ui-scrollpoint-bottom with configurable ui-scrollpoint-edge\r\n\r\nadded element.ready(function({ })) wrappers in unit tests\r\n\r\n**Important Changes**\r\n- replace `ui-scrollpoint-bottom` with `ui-scrollpoint-edge=\"bottom\"`\r\n- `ui-scrollpoint-action` callback parameters reversed\r\n  - old: `function(element, distance)`\r\n  - new: `function(distance, element, edge)`\r\n\r\n**Enhancements**\r\n- `edge` parameter for action callbacks - `\"top\"` or `\"bottom\"` depending which edge of the target the scrollpoint hit\r\n- multiple edges per scrollpoint.\r\n  - ex. `ui-scrollpoint-edge=\"['top','bottom']\"` to trigger when scrollpoint hits top or bottom of its target\r\n- mapping edge of screen to edge of element.\r\n  - ex. `ui-scrollpoint-edge=\"{top: 'bottom'}\"` triggers when the bottom of the element hits the top edge of target\r\n-  `ui-scrollpoint-edge=\"view\"` to trigger when element scrolls out of view (equivalent to `ui-scrollpoint-edge=\"{top: 'bottom', bottom: 'top'}\"`"},"comment":{"url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/issues/comments/163078592","html_url":"https://github.com/angular-ui/ui-scrollpoint/pull/11#issuecomment-163078592","issue_url":"https://api.github.com/repos/angular-ui/ui-scrollpoint/issues/11","id":163078592,"user":{"login":"PowerKiKi","id":72603,"avatar_url":"https://avatars.githubusercontent.com/u/72603?v=3","gravatar_id":"","url":"https://api.github.com/users/PowerKiKi","html_url":"https://github.com/PowerKiKi","followers_url":"https://api.github.com/users/PowerKiKi/followers","following_url":"https://api.github.com/users/PowerKiKi/following{/other_user}","gists_url":"https://api.github.com/users/PowerKiKi/gists{/gist_id}","starred_url":"https://api.github.com/users/PowerKiKi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PowerKiKi/subscriptions","organizations_url":"https://api.github.com/users/PowerKiKi/orgs","repos_url":"https://api.github.com/users/PowerKiKi/repos","events_url":"https://api.github.com/users/PowerKiKi/events{/privacy}","received_events_url":"https://api.github.com/users/PowerKiKi/received_events","type":"User","site_admin":false},"created_at":"2015-12-09T01:36:21Z","updated_at":"2015-12-09T01:36:21Z","body":"Thanks ! Releasing as 2.0.0 since there is a BC break."}}