{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/123","labels_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/123/comments","events_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/123/events","html_url":"https://github.com/ansible/ansible-modules-core/pull/123","id":44753575,"number":123,"title":"Restart Docker container when volumes, ports, or env vars have been changed","user":{"login":"aaronfeng","id":4152,"avatar_url":"https://avatars.githubusercontent.com/u/4152?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronfeng","html_url":"https://github.com/aaronfeng","followers_url":"https://api.github.com/users/aaronfeng/followers","following_url":"https://api.github.com/users/aaronfeng/following{/other_user}","gists_url":"https://api.github.com/users/aaronfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronfeng/subscriptions","organizations_url":"https://api.github.com/users/aaronfeng/orgs","repos_url":"https://api.github.com/users/aaronfeng/repos","events_url":"https://api.github.com/users/aaronfeng/events{/privacy}","received_events_url":"https://api.github.com/users/aaronfeng/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/cloud","name":"cloud","color":"c7def8"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/feature_pull_request","name":"feature_pull_request","color":"009800"},{"url":"https://api.github.com/repos/ansible/ansible-modules-core/labels/P2","name":"P2","color":"fad8c7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":14,"created_at":"2014-10-03T00:04:28Z","updated_at":"2015-01-29T14:38:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/pulls/123","html_url":"https://github.com/ansible/ansible-modules-core/pull/123","diff_url":"https://github.com/ansible/ansible-modules-core/pull/123.diff","patch_url":"https://github.com/ansible/ansible-modules-core/pull/123.patch"},"body":"The current implementation only restarts the running container if the image:tag combo is different for named containers.\r\n\r\nThis PR will also restart the container if volumes, ports, and env vars do not match current state of Ansible.  This is desirable for development for ease of restarting the containers while tweaking the parameters.  It is also beneficial for production since those parameters can evolve over time.\r\n\r\nI know this PR is also missing other potential important parameters such as links.  I have no problem adding further support for other fields, but I want to make sure this will be accepted by upstream.  With that said, I do think this PR provides value as it and other parameters can be part of another PR.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/comments/72034761","html_url":"https://github.com/ansible/ansible-modules-core/pull/123#issuecomment-72034761","issue_url":"https://api.github.com/repos/ansible/ansible-modules-core/issues/123","id":72034761,"user":{"login":"aaronfeng","id":4152,"avatar_url":"https://avatars.githubusercontent.com/u/4152?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronfeng","html_url":"https://github.com/aaronfeng","followers_url":"https://api.github.com/users/aaronfeng/followers","following_url":"https://api.github.com/users/aaronfeng/following{/other_user}","gists_url":"https://api.github.com/users/aaronfeng/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronfeng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronfeng/subscriptions","organizations_url":"https://api.github.com/users/aaronfeng/orgs","repos_url":"https://api.github.com/users/aaronfeng/repos","events_url":"https://api.github.com/users/aaronfeng/events{/privacy}","received_events_url":"https://api.github.com/users/aaronfeng/received_events","type":"User","site_admin":false},"created_at":"2015-01-29T14:38:58Z","updated_at":"2015-01-29T14:38:58Z","body":"@abadger I see the other PR as orthogonal to this one since they don't accomplish the same thing.  This PR will detect if the container configuration has been changed.  If so, restart it.\r\n\r\nWhat's the timeline for this PR to be merged?"}}