{"action":"created","comment":{"url":"https://api.github.com/repos/valhalla/mjolnir/pulls/comments/33145325","id":33145325,"diff_hunk":"@@ -533,101 +542,338 @@ uint32_t GetBestNonFerryClass(const std::map<Edge, size_t>& edges) {\n   return bestrc;\n }\n \n+// NodeLabel - for simple shortest path","path":"src/mjolnir/graphbuilder.cc","position":89,"original_position":89,"commit_id":"08bd72802566317d2e52bd06d9ab73c3fb64ec34","original_commit_id":"08bd72802566317d2e52bd06d9ab73c3fb64ec34","user":{"login":"kevinkreiser","id":697548,"avatar_url":"https://avatars.githubusercontent.com/u/697548?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinkreiser","html_url":"https://github.com/kevinkreiser","followers_url":"https://api.github.com/users/kevinkreiser/followers","following_url":"https://api.github.com/users/kevinkreiser/following{/other_user}","gists_url":"https://api.github.com/users/kevinkreiser/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkreiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkreiser/subscriptions","organizations_url":"https://api.github.com/users/kevinkreiser/orgs","repos_url":"https://api.github.com/users/kevinkreiser/repos","events_url":"https://api.github.com/users/kevinkreiser/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkreiser/received_events","type":"User","site_admin":false},"body":"we should start moving massive bits of entact functionality out of graphbuilder and into their own files, just for sanities sake","created_at":"2015-06-24T13:12:42Z","updated_at":"2015-06-24T13:12:42Z","html_url":"https://github.com/valhalla/mjolnir/pull/264#discussion_r33145325","pull_request_url":"https://api.github.com/repos/valhalla/mjolnir/pulls/264","_links":{"self":{"href":"https://api.github.com/repos/valhalla/mjolnir/pulls/comments/33145325"},"html":{"href":"https://github.com/valhalla/mjolnir/pull/264#discussion_r33145325"},"pull_request":{"href":"https://api.github.com/repos/valhalla/mjolnir/pulls/264"}}},"pull_request":{"url":"https://api.github.com/repos/valhalla/mjolnir/pulls/264","id":38439583,"html_url":"https://github.com/valhalla/mjolnir/pull/264","diff_url":"https://github.com/valhalla/mjolnir/pull/264.diff","patch_url":"https://github.com/valhalla/mjolnir/pull/264.patch","issue_url":"https://api.github.com/repos/valhalla/mjolnir/issues/264","number":264,"state":"open","locked":false,"title":"ReclassifyFerryConnections","user":{"login":"dnesbitt61","id":1838768,"avatar_url":"https://avatars.githubusercontent.com/u/1838768?v=3","gravatar_id":"","url":"https://api.github.com/users/dnesbitt61","html_url":"https://github.com/dnesbitt61","followers_url":"https://api.github.com/users/dnesbitt61/followers","following_url":"https://api.github.com/users/dnesbitt61/following{/other_user}","gists_url":"https://api.github.com/users/dnesbitt61/gists{/gist_id}","starred_url":"https://api.github.com/users/dnesbitt61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnesbitt61/subscriptions","organizations_url":"https://api.github.com/users/dnesbitt61/orgs","repos_url":"https://api.github.com/users/dnesbitt61/repos","events_url":"https://api.github.com/users/dnesbitt61/events{/privacy}","received_events_url":"https://api.github.com/users/dnesbitt61/received_events","type":"User","site_admin":false},"body":"Reclassifiies edges so we get a highway path from roads to the ferry. Computes shortest path and considers driveability (to or from the ferry). Short ferries are skipped - they are likely to be river crossings where bridges are likely to be better alternatives.  Adds only 1-2 minutes to planet processing.\r\n\r\nThis fixes the Vancouver/Victoria ferry case and English Channel crossings (though not all have been tested).","created_at":"2015-06-24T13:06:59Z","updated_at":"2015-06-24T13:12:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b68b3cacb28afd93c72900ebe20d3c6115ff51b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/valhalla/mjolnir/pulls/264/commits","review_comments_url":"https://api.github.com/repos/valhalla/mjolnir/pulls/264/comments","review_comment_url":"https://api.github.com/repos/valhalla/mjolnir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/valhalla/mjolnir/issues/264/comments","statuses_url":"https://api.github.com/repos/valhalla/mjolnir/statuses/08bd72802566317d2e52bd06d9ab73c3fb64ec34","head":{"label":"valhalla:dwn","ref":"dwn","sha":"08bd72802566317d2e52bd06d9ab73c3fb64ec34","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":28186451,"name":"mjolnir","full_name":"valhalla/mjolnir","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/mjolnir","description":"Applications suited to creating tiled routing data","fork":false,"url":"https://api.github.com/repos/valhalla/mjolnir","forks_url":"https://api.github.com/repos/valhalla/mjolnir/forks","keys_url":"https://api.github.com/repos/valhalla/mjolnir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/mjolnir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/mjolnir/teams","hooks_url":"https://api.github.com/repos/valhalla/mjolnir/hooks","issue_events_url":"https://api.github.com/repos/valhalla/mjolnir/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/mjolnir/events","assignees_url":"https://api.github.com/repos/valhalla/mjolnir/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/mjolnir/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/mjolnir/tags","blobs_url":"https://api.github.com/repos/valhalla/mjolnir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/mjolnir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/mjolnir/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/mjolnir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/mjolnir/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/mjolnir/languages","stargazers_url":"https://api.github.com/repos/valhalla/mjolnir/stargazers","contributors_url":"https://api.github.com/repos/valhalla/mjolnir/contributors","subscribers_url":"https://api.github.com/repos/valhalla/mjolnir/subscribers","subscription_url":"https://api.github.com/repos/valhalla/mjolnir/subscription","commits_url":"https://api.github.com/repos/valhalla/mjolnir/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/mjolnir/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/mjolnir/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/mjolnir/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/mjolnir/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/mjolnir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/mjolnir/merges","archive_url":"https://api.github.com/repos/valhalla/mjolnir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/mjolnir/downloads","issues_url":"https://api.github.com/repos/valhalla/mjolnir/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/mjolnir/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/mjolnir/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/mjolnir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/mjolnir/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/mjolnir/releases{/id}","created_at":"2014-12-18T14:22:06Z","updated_at":"2015-06-09T14:40:45Z","pushed_at":"2015-06-24T13:07:00Z","git_url":"git://github.com/valhalla/mjolnir.git","ssh_url":"git@github.com:valhalla/mjolnir.git","clone_url":"https://github.com/valhalla/mjolnir.git","svn_url":"https://github.com/valhalla/mjolnir","homepage":null,"size":7653,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"valhalla:master","ref":"master","sha":"2b6930cb1262455ac21bcc4ff4275851bcedce32","user":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"repo":{"id":28186451,"name":"mjolnir","full_name":"valhalla/mjolnir","owner":{"login":"valhalla","id":10232331,"avatar_url":"https://avatars.githubusercontent.com/u/10232331?v=3","gravatar_id":"","url":"https://api.github.com/users/valhalla","html_url":"https://github.com/valhalla","followers_url":"https://api.github.com/users/valhalla/followers","following_url":"https://api.github.com/users/valhalla/following{/other_user}","gists_url":"https://api.github.com/users/valhalla/gists{/gist_id}","starred_url":"https://api.github.com/users/valhalla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valhalla/subscriptions","organizations_url":"https://api.github.com/users/valhalla/orgs","repos_url":"https://api.github.com/users/valhalla/repos","events_url":"https://api.github.com/users/valhalla/events{/privacy}","received_events_url":"https://api.github.com/users/valhalla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/valhalla/mjolnir","description":"Applications suited to creating tiled routing data","fork":false,"url":"https://api.github.com/repos/valhalla/mjolnir","forks_url":"https://api.github.com/repos/valhalla/mjolnir/forks","keys_url":"https://api.github.com/repos/valhalla/mjolnir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valhalla/mjolnir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valhalla/mjolnir/teams","hooks_url":"https://api.github.com/repos/valhalla/mjolnir/hooks","issue_events_url":"https://api.github.com/repos/valhalla/mjolnir/issues/events{/number}","events_url":"https://api.github.com/repos/valhalla/mjolnir/events","assignees_url":"https://api.github.com/repos/valhalla/mjolnir/assignees{/user}","branches_url":"https://api.github.com/repos/valhalla/mjolnir/branches{/branch}","tags_url":"https://api.github.com/repos/valhalla/mjolnir/tags","blobs_url":"https://api.github.com/repos/valhalla/mjolnir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valhalla/mjolnir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valhalla/mjolnir/git/refs{/sha}","trees_url":"https://api.github.com/repos/valhalla/mjolnir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valhalla/mjolnir/statuses/{sha}","languages_url":"https://api.github.com/repos/valhalla/mjolnir/languages","stargazers_url":"https://api.github.com/repos/valhalla/mjolnir/stargazers","contributors_url":"https://api.github.com/repos/valhalla/mjolnir/contributors","subscribers_url":"https://api.github.com/repos/valhalla/mjolnir/subscribers","subscription_url":"https://api.github.com/repos/valhalla/mjolnir/subscription","commits_url":"https://api.github.com/repos/valhalla/mjolnir/commits{/sha}","git_commits_url":"https://api.github.com/repos/valhalla/mjolnir/git/commits{/sha}","comments_url":"https://api.github.com/repos/valhalla/mjolnir/comments{/number}","issue_comment_url":"https://api.github.com/repos/valhalla/mjolnir/issues/comments{/number}","contents_url":"https://api.github.com/repos/valhalla/mjolnir/contents/{+path}","compare_url":"https://api.github.com/repos/valhalla/mjolnir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valhalla/mjolnir/merges","archive_url":"https://api.github.com/repos/valhalla/mjolnir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valhalla/mjolnir/downloads","issues_url":"https://api.github.com/repos/valhalla/mjolnir/issues{/number}","pulls_url":"https://api.github.com/repos/valhalla/mjolnir/pulls{/number}","milestones_url":"https://api.github.com/repos/valhalla/mjolnir/milestones{/number}","notifications_url":"https://api.github.com/repos/valhalla/mjolnir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valhalla/mjolnir/labels{/name}","releases_url":"https://api.github.com/repos/valhalla/mjolnir/releases{/id}","created_at":"2014-12-18T14:22:06Z","updated_at":"2015-06-09T14:40:45Z","pushed_at":"2015-06-24T13:07:00Z","git_url":"git://github.com/valhalla/mjolnir.git","ssh_url":"git@github.com:valhalla/mjolnir.git","clone_url":"https://github.com/valhalla/mjolnir.git","svn_url":"https://github.com/valhalla/mjolnir","homepage":null,"size":7653,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/valhalla/mjolnir/pulls/264"},"html":{"href":"https://github.com/valhalla/mjolnir/pull/264"},"issue":{"href":"https://api.github.com/repos/valhalla/mjolnir/issues/264"},"comments":{"href":"https://api.github.com/repos/valhalla/mjolnir/issues/264/comments"},"review_comments":{"href":"https://api.github.com/repos/valhalla/mjolnir/pulls/264/comments"},"review_comment":{"href":"https://api.github.com/repos/valhalla/mjolnir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/valhalla/mjolnir/pulls/264/commits"},"statuses":{"href":"https://api.github.com/repos/valhalla/mjolnir/statuses/08bd72802566317d2e52bd06d9ab73c3fb64ec34"}}}}