{"action":"created","issue":{"url":"https://api.github.com/repos/phrack/ShootOFF/issues/230","labels_url":"https://api.github.com/repos/phrack/ShootOFF/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/phrack/ShootOFF/issues/230/comments","events_url":"https://api.github.com/repos/phrack/ShootOFF/issues/230/events","html_url":"https://github.com/phrack/ShootOFF/pull/230","id":108790643,"number":230,"title":"New shot detection","user":{"login":"cbdmaul","id":5543934,"avatar_url":"https://avatars.githubusercontent.com/u/5543934?v=3","gravatar_id":"","url":"https://api.github.com/users/cbdmaul","html_url":"https://github.com/cbdmaul","followers_url":"https://api.github.com/users/cbdmaul/followers","following_url":"https://api.github.com/users/cbdmaul/following{/other_user}","gists_url":"https://api.github.com/users/cbdmaul/gists{/gist_id}","starred_url":"https://api.github.com/users/cbdmaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbdmaul/subscriptions","organizations_url":"https://api.github.com/users/cbdmaul/orgs","repos_url":"https://api.github.com/users/cbdmaul/repos","events_url":"https://api.github.com/users/cbdmaul/events{/privacy}","received_events_url":"https://api.github.com/users/cbdmaul/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-09-29T04:05:38Z","updated_at":"2015-09-29T14:31:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phrack/ShootOFF/pulls/230","html_url":"https://github.com/phrack/ShootOFF/pull/230","diff_url":"https://github.com/phrack/ShootOFF/pull/230.diff","patch_url":"https://github.com/phrack/ShootOFF/pull/230.patch"},"body":"I'm probably supposed to put something useful for you here.\r\n\r\nHere's a recipe for meatloaf:\r\n\r\n    Preheat oven to 350 degrees F (175 degrees C).\r\n    In a large bowl, combine the beef, egg, onion, milk and bread OR cracker crumbs. Season with salt and pepper to taste and place in a lightly greased 5x9 inch loaf pan, OR form into a loaf and place in a lightly greased 9x13 inch baking dish.\r\n    In a separate small bowl, combine the brown sugar, mustard and ketchup. Mix well and pour over the meatloaf.\r\n    Bake at 350 degrees F (175 degrees C) for 1 hour.\r\n"},"comment":{"url":"https://api.github.com/repos/phrack/ShootOFF/issues/comments/144078113","html_url":"https://github.com/phrack/ShootOFF/pull/230#issuecomment-144078113","issue_url":"https://api.github.com/repos/phrack/ShootOFF/issues/230","id":144078113,"user":{"login":"cbdmaul","id":5543934,"avatar_url":"https://avatars.githubusercontent.com/u/5543934?v=3","gravatar_id":"","url":"https://api.github.com/users/cbdmaul","html_url":"https://github.com/cbdmaul","followers_url":"https://api.github.com/users/cbdmaul/followers","following_url":"https://api.github.com/users/cbdmaul/following{/other_user}","gists_url":"https://api.github.com/users/cbdmaul/gists{/gist_id}","starred_url":"https://api.github.com/users/cbdmaul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbdmaul/subscriptions","organizations_url":"https://api.github.com/users/cbdmaul/orgs","repos_url":"https://api.github.com/users/cbdmaul/repos","events_url":"https://api.github.com/users/cbdmaul/events{/privacy}","received_events_url":"https://api.github.com/users/cbdmaul/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T14:31:04Z","updated_at":"2015-09-29T14:31:04Z","body":"I will do 3 and 5 tonight.\r\n\r\nFor 4, I have not marked any of the shots in the new testcases, only the count and color.  How about if I clean up one test file for you to refactor and leave the rest for after the refactoring is done? Then I can just edit them to match the right way the first time.\r\n\r\nI think the refactoring should include continue on errors for test cases, it would make it much easier to tweak / refine shot detection in the future.\r\n\r\nBy the way, you should test what I have now because I fixed a bug which forced me to change the shot detection threshold for cluster connectedness.  I based the change on the test case results not any real world testing.  Make sure there aren't any new unexpected false negatives (missing shots).  It is easy to fix if it is."}}