{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/sot/agasc/pulls/4","id":27583864,"html_url":"https://github.com/sot/agasc/pull/4","diff_url":"https://github.com/sot/agasc/pull/4.diff","patch_url":"https://github.com/sot/agasc/pull/4.patch","issue_url":"https://api.github.com/repos/sot/agasc/issues/4","number":4,"state":"closed","locked":false,"title":"Remove package data and fix bug in proper motion correction","user":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?v=3","gravatar_id":"","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"body":"This changes where the miniagasc.h5 file is located to better support conda skare.\r\n\r\nIt also fixes an apparent bug in the proper motion correction where the RA term is not divided by cos(Dec).  As I understand the PM_RA value is in milliarcsec / year, i.e. a normal angular distance.  It looks like the same issue is in Ska-Agasc.\r\n\r\nThis PR also adds *_PMCORR values to the output of `agasc.get_star()`.\r\n\r\nIt's not ideal to wrap up these unrelated fixes, but I want the PM fix in conda and I don't see a good reason to not put the conda-driven changes into Ska flight.\r\n\r\n@jeanconn ","created_at":"2015-01-19T03:52:38Z","updated_at":"2015-04-08T00:59:02Z","closed_at":"2015-04-08T00:59:00Z","merged_at":"2015-04-08T00:59:00Z","merge_commit_sha":"6af1763c2a181fd650c1bd8ee8184b571651ff0f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sot/agasc/pulls/4/commits","review_comments_url":"https://api.github.com/repos/sot/agasc/pulls/4/comments","review_comment_url":"https://api.github.com/repos/sot/agasc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sot/agasc/issues/4/comments","statuses_url":"https://api.github.com/repos/sot/agasc/statuses/011b21c499eb24c60f118efad23957bd994b5a1a","head":{"label":"sot:conda","ref":"conda","sha":"011b21c499eb24c60f118efad23957bd994b5a1a","user":{"login":"sot","id":781587,"avatar_url":"https://avatars.githubusercontent.com/u/781587?v=3","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"repo":{"id":10041146,"name":"agasc","full_name":"sot/agasc","owner":{"login":"sot","id":781587,"avatar_url":"https://avatars.githubusercontent.com/u/781587?v=3","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sot/agasc","description":"Access the Chandra AGASC star catalog","fork":false,"url":"https://api.github.com/repos/sot/agasc","forks_url":"https://api.github.com/repos/sot/agasc/forks","keys_url":"https://api.github.com/repos/sot/agasc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sot/agasc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sot/agasc/teams","hooks_url":"https://api.github.com/repos/sot/agasc/hooks","issue_events_url":"https://api.github.com/repos/sot/agasc/issues/events{/number}","events_url":"https://api.github.com/repos/sot/agasc/events","assignees_url":"https://api.github.com/repos/sot/agasc/assignees{/user}","branches_url":"https://api.github.com/repos/sot/agasc/branches{/branch}","tags_url":"https://api.github.com/repos/sot/agasc/tags","blobs_url":"https://api.github.com/repos/sot/agasc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sot/agasc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sot/agasc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sot/agasc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sot/agasc/statuses/{sha}","languages_url":"https://api.github.com/repos/sot/agasc/languages","stargazers_url":"https://api.github.com/repos/sot/agasc/stargazers","contributors_url":"https://api.github.com/repos/sot/agasc/contributors","subscribers_url":"https://api.github.com/repos/sot/agasc/subscribers","subscription_url":"https://api.github.com/repos/sot/agasc/subscription","commits_url":"https://api.github.com/repos/sot/agasc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sot/agasc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sot/agasc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sot/agasc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sot/agasc/contents/{+path}","compare_url":"https://api.github.com/repos/sot/agasc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sot/agasc/merges","archive_url":"https://api.github.com/repos/sot/agasc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sot/agasc/downloads","issues_url":"https://api.github.com/repos/sot/agasc/issues{/number}","pulls_url":"https://api.github.com/repos/sot/agasc/pulls{/number}","milestones_url":"https://api.github.com/repos/sot/agasc/milestones{/number}","notifications_url":"https://api.github.com/repos/sot/agasc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sot/agasc/labels{/name}","releases_url":"https://api.github.com/repos/sot/agasc/releases{/id}","created_at":"2013-05-13T20:56:22Z","updated_at":"2015-04-08T00:59:01Z","pushed_at":"2015-04-08T00:59:01Z","git_url":"git://github.com/sot/agasc.git","ssh_url":"git@github.com:sot/agasc.git","clone_url":"https://github.com/sot/agasc.git","svn_url":"https://github.com/sot/agasc","homepage":"http://cxc.cfa.harvard.edu/mta/ASPECT/tool_doc/agasc/","size":240,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"sot:master","ref":"master","sha":"6701048ee23cbffc612ac019d719e6b73c755889","user":{"login":"sot","id":781587,"avatar_url":"https://avatars.githubusercontent.com/u/781587?v=3","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"repo":{"id":10041146,"name":"agasc","full_name":"sot/agasc","owner":{"login":"sot","id":781587,"avatar_url":"https://avatars.githubusercontent.com/u/781587?v=3","gravatar_id":"","url":"https://api.github.com/users/sot","html_url":"https://github.com/sot","followers_url":"https://api.github.com/users/sot/followers","following_url":"https://api.github.com/users/sot/following{/other_user}","gists_url":"https://api.github.com/users/sot/gists{/gist_id}","starred_url":"https://api.github.com/users/sot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sot/subscriptions","organizations_url":"https://api.github.com/users/sot/orgs","repos_url":"https://api.github.com/users/sot/repos","events_url":"https://api.github.com/users/sot/events{/privacy}","received_events_url":"https://api.github.com/users/sot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sot/agasc","description":"Access the Chandra AGASC star catalog","fork":false,"url":"https://api.github.com/repos/sot/agasc","forks_url":"https://api.github.com/repos/sot/agasc/forks","keys_url":"https://api.github.com/repos/sot/agasc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sot/agasc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sot/agasc/teams","hooks_url":"https://api.github.com/repos/sot/agasc/hooks","issue_events_url":"https://api.github.com/repos/sot/agasc/issues/events{/number}","events_url":"https://api.github.com/repos/sot/agasc/events","assignees_url":"https://api.github.com/repos/sot/agasc/assignees{/user}","branches_url":"https://api.github.com/repos/sot/agasc/branches{/branch}","tags_url":"https://api.github.com/repos/sot/agasc/tags","blobs_url":"https://api.github.com/repos/sot/agasc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sot/agasc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sot/agasc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sot/agasc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sot/agasc/statuses/{sha}","languages_url":"https://api.github.com/repos/sot/agasc/languages","stargazers_url":"https://api.github.com/repos/sot/agasc/stargazers","contributors_url":"https://api.github.com/repos/sot/agasc/contributors","subscribers_url":"https://api.github.com/repos/sot/agasc/subscribers","subscription_url":"https://api.github.com/repos/sot/agasc/subscription","commits_url":"https://api.github.com/repos/sot/agasc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sot/agasc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sot/agasc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sot/agasc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sot/agasc/contents/{+path}","compare_url":"https://api.github.com/repos/sot/agasc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sot/agasc/merges","archive_url":"https://api.github.com/repos/sot/agasc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sot/agasc/downloads","issues_url":"https://api.github.com/repos/sot/agasc/issues{/number}","pulls_url":"https://api.github.com/repos/sot/agasc/pulls{/number}","milestones_url":"https://api.github.com/repos/sot/agasc/milestones{/number}","notifications_url":"https://api.github.com/repos/sot/agasc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sot/agasc/labels{/name}","releases_url":"https://api.github.com/repos/sot/agasc/releases{/id}","created_at":"2013-05-13T20:56:22Z","updated_at":"2015-04-08T00:59:01Z","pushed_at":"2015-04-08T00:59:01Z","git_url":"git://github.com/sot/agasc.git","ssh_url":"git@github.com:sot/agasc.git","clone_url":"https://github.com/sot/agasc.git","svn_url":"https://github.com/sot/agasc","homepage":"http://cxc.cfa.harvard.edu/mta/ASPECT/tool_doc/agasc/","size":240,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sot/agasc/pulls/4"},"html":{"href":"https://github.com/sot/agasc/pull/4"},"issue":{"href":"https://api.github.com/repos/sot/agasc/issues/4"},"comments":{"href":"https://api.github.com/repos/sot/agasc/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/sot/agasc/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/sot/agasc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sot/agasc/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/sot/agasc/statuses/011b21c499eb24c60f118efad23957bd994b5a1a"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"taldcroft","id":348089,"avatar_url":"https://avatars.githubusercontent.com/u/348089?v=3","gravatar_id":"","url":"https://api.github.com/users/taldcroft","html_url":"https://github.com/taldcroft","followers_url":"https://api.github.com/users/taldcroft/followers","following_url":"https://api.github.com/users/taldcroft/following{/other_user}","gists_url":"https://api.github.com/users/taldcroft/gists{/gist_id}","starred_url":"https://api.github.com/users/taldcroft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taldcroft/subscriptions","organizations_url":"https://api.github.com/users/taldcroft/orgs","repos_url":"https://api.github.com/users/taldcroft/repos","events_url":"https://api.github.com/users/taldcroft/events{/privacy}","received_events_url":"https://api.github.com/users/taldcroft/received_events","type":"User","site_admin":false},"comments":4,"review_comments":0,"commits":5,"additions":56,"deletions":37,"changed_files":8}}