{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/comments/29886375","id":29886375,"diff_hunk":"@@ -55,13 +66,16 @@ trait UnmappedBAMService extends HttpService {\n     new ApiResponse(code = 500, message = \"Vault Internal Error\")\n   ))\n   def ingestRoute = {\n-    path(\"ubams\") {\n+    pathVersion(ApiPrefix) { version =>\n       post {\n-        commonNameFromCookie { commonName =>\n+        commonNameFromCookie() { commonName =>","path":"src/main/scala/org/broadinstitute/dsde/vault/datamanagement/services/UnmappedBAMService.scala","position":64,"original_position":64,"commit_id":"56c703bdd26ada5bf85597ccdbea29661f3184fc","original_commit_id":"56c703bdd26ada5bf85597ccdbea29661f3184fc","user":{"login":"kshakir","id":791985,"avatar_url":"https://avatars.githubusercontent.com/u/791985?v=3","gravatar_id":"","url":"https://api.github.com/users/kshakir","html_url":"https://github.com/kshakir","followers_url":"https://api.github.com/users/kshakir/followers","following_url":"https://api.github.com/users/kshakir/following{/other_user}","gists_url":"https://api.github.com/users/kshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/kshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshakir/subscriptions","organizations_url":"https://api.github.com/users/kshakir/orgs","repos_url":"https://api.github.com/users/kshakir/repos","events_url":"https://api.github.com/users/kshakir/events{/privacy}","received_events_url":"https://api.github.com/users/kshakir/received_events","type":"User","site_admin":false},"body":"Nope, the `(())` are just to avoid compiler warnings. When there's no warning, no foul, and the compiler has been able to locate the correct method: http://stackoverflow.com/a/25354165/3320205","created_at":"2015-05-07T19:19:34Z","updated_at":"2015-05-07T19:19:34Z","html_url":"https://github.com/broadinstitute/vault-datamanagement/pull/29#discussion_r29886375","pull_request_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/comments/29886375"},"html":{"href":"https://github.com/broadinstitute/vault-datamanagement/pull/29#discussion_r29886375"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29","id":34865248,"html_url":"https://github.com/broadinstitute/vault-datamanagement/pull/29","diff_url":"https://github.com/broadinstitute/vault-datamanagement/pull/29.diff","patch_url":"https://github.com/broadinstitute/vault-datamanagement/pull/29.patch","issue_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/29","number":29,"state":"open","locked":false,"title":"First pass of route versioning.","user":{"login":"kshakir","id":791985,"avatar_url":"https://avatars.githubusercontent.com/u/791985?v=3","gravatar_id":"","url":"https://api.github.com/users/kshakir","html_url":"https://github.com/kshakir","followers_url":"https://api.github.com/users/kshakir/followers","following_url":"https://api.github.com/users/kshakir/following{/other_user}","gists_url":"https://api.github.com/users/kshakir/gists{/gist_id}","starred_url":"https://api.github.com/users/kshakir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshakir/subscriptions","organizations_url":"https://api.github.com/users/kshakir/orgs","repos_url":"https://api.github.com/users/kshakir/repos","events_url":"https://api.github.com/users/kshakir/events{/privacy}","received_events_url":"https://api.github.com/users/kshakir/received_events","type":"User","site_admin":false},"body":"For now, all versions default to the same implementations.","created_at":"2015-05-06T22:04:34Z","updated_at":"2015-05-07T19:19:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75d4b8846f85f334e3231827910a086eac397662","assignee":{"login":"jmthibault79","id":2701406,"avatar_url":"https://avatars.githubusercontent.com/u/2701406?v=3","gravatar_id":"","url":"https://api.github.com/users/jmthibault79","html_url":"https://github.com/jmthibault79","followers_url":"https://api.github.com/users/jmthibault79/followers","following_url":"https://api.github.com/users/jmthibault79/following{/other_user}","gists_url":"https://api.github.com/users/jmthibault79/gists{/gist_id}","starred_url":"https://api.github.com/users/jmthibault79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmthibault79/subscriptions","organizations_url":"https://api.github.com/users/jmthibault79/orgs","repos_url":"https://api.github.com/users/jmthibault79/repos","events_url":"https://api.github.com/users/jmthibault79/events{/privacy}","received_events_url":"https://api.github.com/users/jmthibault79/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/29/comments","statuses_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/statuses/56c703bdd26ada5bf85597ccdbea29661f3184fc","head":{"label":"broadinstitute:ks_route_versioning","ref":"ks_route_versioning","sha":"56c703bdd26ada5bf85597ccdbea29661f3184fc","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":31208477,"name":"vault-datamanagement","full_name":"broadinstitute/vault-datamanagement","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-datamanagement","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-datamanagement","forks_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/releases{/id}","created_at":"2015-02-23T13:10:03Z","updated_at":"2015-03-27T20:16:24Z","pushed_at":"2015-05-07T16:54:15Z","git_url":"git://github.com/broadinstitute/vault-datamanagement.git","ssh_url":"git@github.com:broadinstitute/vault-datamanagement.git","clone_url":"https://github.com/broadinstitute/vault-datamanagement.git","svn_url":"https://github.com/broadinstitute/vault-datamanagement","homepage":null,"size":962,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"3d70edb3261b97fe35bf1b19158d345e6bca550e","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":31208477,"name":"vault-datamanagement","full_name":"broadinstitute/vault-datamanagement","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars.githubusercontent.com/u/393552?v=3","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/vault-datamanagement","description":"","fork":false,"url":"https://api.github.com/repos/broadinstitute/vault-datamanagement","forks_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/forks","keys_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/teams","hooks_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/events","assignees_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/tags","blobs_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/subscription","commits_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/merges","archive_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/downloads","issues_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/vault-datamanagement/releases{/id}","created_at":"2015-02-23T13:10:03Z","updated_at":"2015-03-27T20:16:24Z","pushed_at":"2015-05-07T16:54:15Z","git_url":"git://github.com/broadinstitute/vault-datamanagement.git","ssh_url":"git@github.com:broadinstitute/vault-datamanagement.git","clone_url":"https://github.com/broadinstitute/vault-datamanagement.git","svn_url":"https://github.com/broadinstitute/vault-datamanagement","homepage":null,"size":962,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29"},"html":{"href":"https://github.com/broadinstitute/vault-datamanagement/pull/29"},"issue":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/29"},"comments":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/vault-datamanagement/statuses/56c703bdd26ada5bf85597ccdbea29661f3184fc"}}}}