{"action":"created","comment":{"url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments/41709624","id":41709624,"diff_hunk":"@@ -28,6 +28,15 @@ def self.run(params)\n         command << \" ~/Library/Keychains/#{escaped_name}\"\n \n         commands << Fastlane::Actions.sh(command, log: false)\n+\n+        if params[:add_to_search_list]\n+          keychains = []\n+          keychains += Fastlane::Actions.sh(\"security list-keychains -d user\", log: false).shellsplit unless Helper.test?\n+          keychains << File.expand_path(params[:name], \"~/Library/Keychains\")\n+          keychains.uniq!","path":"lib/fastlane/actions/create_keychain.rb","position":9,"original_position":9,"commit_id":"8d7146b9afa01d82114e31786622aa6caad222d7","original_commit_id":"8d7146b9afa01d82114e31786622aa6caad222d7","user":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"body":"Why `uniq!`? Could you add a comment to the code explaining that?","created_at":"2015-10-11T12:03:03Z","updated_at":"2015-10-11T12:03:03Z","html_url":"https://github.com/KrauseFx/fastlane/pull/668#discussion_r41709624","pull_request_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668","_links":{"self":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments/41709624"},"html":{"href":"https://github.com/KrauseFx/fastlane/pull/668#discussion_r41709624"},"pull_request":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668"}}},"pull_request":{"url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668","id":46941600,"html_url":"https://github.com/KrauseFx/fastlane/pull/668","diff_url":"https://github.com/KrauseFx/fastlane/pull/668.diff","patch_url":"https://github.com/KrauseFx/fastlane/pull/668.patch","issue_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/668","number":668,"state":"open","locked":false,"title":"Add created keychain to search list in create_keychain action","user":{"login":"baarde","id":1251082,"avatar_url":"https://avatars.githubusercontent.com/u/1251082?v=3","gravatar_id":"","url":"https://api.github.com/users/baarde","html_url":"https://github.com/baarde","followers_url":"https://api.github.com/users/baarde/followers","following_url":"https://api.github.com/users/baarde/following{/other_user}","gists_url":"https://api.github.com/users/baarde/gists{/gist_id}","starred_url":"https://api.github.com/users/baarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baarde/subscriptions","organizations_url":"https://api.github.com/users/baarde/orgs","repos_url":"https://api.github.com/users/baarde/repos","events_url":"https://api.github.com/users/baarde/events{/privacy}","received_events_url":"https://api.github.com/users/baarde/received_events","type":"User","site_admin":false},"body":"New keychains need to be added to the search list if you want `codesign` to find the identities they contain. I don't know any reason not to add the new keychain to the search list, so I think this should be done by default.","created_at":"2015-10-06T18:45:32Z","updated_at":"2015-10-11T12:03:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"403d631303ac14f0cbaece5a4b21ec185e583199","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668/commits","review_comments_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668/comments","review_comment_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/668/comments","statuses_url":"https://api.github.com/repos/KrauseFx/fastlane/statuses/8d7146b9afa01d82114e31786622aa6caad222d7","head":{"label":"baarde:feature/create_keychain_in_search_list","ref":"feature/create_keychain_in_search_list","sha":"8d7146b9afa01d82114e31786622aa6caad222d7","user":{"login":"baarde","id":1251082,"avatar_url":"https://avatars.githubusercontent.com/u/1251082?v=3","gravatar_id":"","url":"https://api.github.com/users/baarde","html_url":"https://github.com/baarde","followers_url":"https://api.github.com/users/baarde/followers","following_url":"https://api.github.com/users/baarde/following{/other_user}","gists_url":"https://api.github.com/users/baarde/gists{/gist_id}","starred_url":"https://api.github.com/users/baarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baarde/subscriptions","organizations_url":"https://api.github.com/users/baarde/orgs","repos_url":"https://api.github.com/users/baarde/repos","events_url":"https://api.github.com/users/baarde/events{/privacy}","received_events_url":"https://api.github.com/users/baarde/received_events","type":"User","site_admin":false},"repo":{"id":43767089,"name":"fastlane","full_name":"baarde/fastlane","owner":{"login":"baarde","id":1251082,"avatar_url":"https://avatars.githubusercontent.com/u/1251082?v=3","gravatar_id":"","url":"https://api.github.com/users/baarde","html_url":"https://github.com/baarde","followers_url":"https://api.github.com/users/baarde/followers","following_url":"https://api.github.com/users/baarde/following{/other_user}","gists_url":"https://api.github.com/users/baarde/gists{/gist_id}","starred_url":"https://api.github.com/users/baarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baarde/subscriptions","organizations_url":"https://api.github.com/users/baarde/orgs","repos_url":"https://api.github.com/users/baarde/repos","events_url":"https://api.github.com/users/baarde/events{/privacy}","received_events_url":"https://api.github.com/users/baarde/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/baarde/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":true,"url":"https://api.github.com/repos/baarde/fastlane","forks_url":"https://api.github.com/repos/baarde/fastlane/forks","keys_url":"https://api.github.com/repos/baarde/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baarde/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baarde/fastlane/teams","hooks_url":"https://api.github.com/repos/baarde/fastlane/hooks","issue_events_url":"https://api.github.com/repos/baarde/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/baarde/fastlane/events","assignees_url":"https://api.github.com/repos/baarde/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/baarde/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/baarde/fastlane/tags","blobs_url":"https://api.github.com/repos/baarde/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baarde/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baarde/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/baarde/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baarde/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/baarde/fastlane/languages","stargazers_url":"https://api.github.com/repos/baarde/fastlane/stargazers","contributors_url":"https://api.github.com/repos/baarde/fastlane/contributors","subscribers_url":"https://api.github.com/repos/baarde/fastlane/subscribers","subscription_url":"https://api.github.com/repos/baarde/fastlane/subscription","commits_url":"https://api.github.com/repos/baarde/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/baarde/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/baarde/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/baarde/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/baarde/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/baarde/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baarde/fastlane/merges","archive_url":"https://api.github.com/repos/baarde/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baarde/fastlane/downloads","issues_url":"https://api.github.com/repos/baarde/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/baarde/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/baarde/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/baarde/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baarde/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/baarde/fastlane/releases{/id}","created_at":"2015-10-06T17:38:57Z","updated_at":"2015-10-06T17:38:59Z","pushed_at":"2015-10-07T07:53:59Z","git_url":"git://github.com/baarde/fastlane.git","ssh_url":"git@github.com:baarde/fastlane.git","clone_url":"https://github.com/baarde/fastlane.git","svn_url":"https://github.com/baarde/fastlane","homepage":"https://fastlane.tools","size":2857,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"KrauseFx:master","ref":"master","sha":"c7f92247fcfffa30b171bf2c4cc3b7b3497e1c1b","user":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"repo":{"id":27442967,"name":"fastlane","full_name":"KrauseFx/fastlane","owner":{"login":"KrauseFx","id":869950,"avatar_url":"https://avatars.githubusercontent.com/u/869950?v=3","gravatar_id":"","url":"https://api.github.com/users/KrauseFx","html_url":"https://github.com/KrauseFx","followers_url":"https://api.github.com/users/KrauseFx/followers","following_url":"https://api.github.com/users/KrauseFx/following{/other_user}","gists_url":"https://api.github.com/users/KrauseFx/gists{/gist_id}","starred_url":"https://api.github.com/users/KrauseFx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrauseFx/subscriptions","organizations_url":"https://api.github.com/users/KrauseFx/orgs","repos_url":"https://api.github.com/users/KrauseFx/repos","events_url":"https://api.github.com/users/KrauseFx/events{/privacy}","received_events_url":"https://api.github.com/users/KrauseFx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KrauseFx/fastlane","description":"Connect all iOS deployment tools into one streamlined workflow","fork":false,"url":"https://api.github.com/repos/KrauseFx/fastlane","forks_url":"https://api.github.com/repos/KrauseFx/fastlane/forks","keys_url":"https://api.github.com/repos/KrauseFx/fastlane/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KrauseFx/fastlane/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KrauseFx/fastlane/teams","hooks_url":"https://api.github.com/repos/KrauseFx/fastlane/hooks","issue_events_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/events{/number}","events_url":"https://api.github.com/repos/KrauseFx/fastlane/events","assignees_url":"https://api.github.com/repos/KrauseFx/fastlane/assignees{/user}","branches_url":"https://api.github.com/repos/KrauseFx/fastlane/branches{/branch}","tags_url":"https://api.github.com/repos/KrauseFx/fastlane/tags","blobs_url":"https://api.github.com/repos/KrauseFx/fastlane/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KrauseFx/fastlane/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KrauseFx/fastlane/git/refs{/sha}","trees_url":"https://api.github.com/repos/KrauseFx/fastlane/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KrauseFx/fastlane/statuses/{sha}","languages_url":"https://api.github.com/repos/KrauseFx/fastlane/languages","stargazers_url":"https://api.github.com/repos/KrauseFx/fastlane/stargazers","contributors_url":"https://api.github.com/repos/KrauseFx/fastlane/contributors","subscribers_url":"https://api.github.com/repos/KrauseFx/fastlane/subscribers","subscription_url":"https://api.github.com/repos/KrauseFx/fastlane/subscription","commits_url":"https://api.github.com/repos/KrauseFx/fastlane/commits{/sha}","git_commits_url":"https://api.github.com/repos/KrauseFx/fastlane/git/commits{/sha}","comments_url":"https://api.github.com/repos/KrauseFx/fastlane/comments{/number}","issue_comment_url":"https://api.github.com/repos/KrauseFx/fastlane/issues/comments{/number}","contents_url":"https://api.github.com/repos/KrauseFx/fastlane/contents/{+path}","compare_url":"https://api.github.com/repos/KrauseFx/fastlane/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KrauseFx/fastlane/merges","archive_url":"https://api.github.com/repos/KrauseFx/fastlane/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KrauseFx/fastlane/downloads","issues_url":"https://api.github.com/repos/KrauseFx/fastlane/issues{/number}","pulls_url":"https://api.github.com/repos/KrauseFx/fastlane/pulls{/number}","milestones_url":"https://api.github.com/repos/KrauseFx/fastlane/milestones{/number}","notifications_url":"https://api.github.com/repos/KrauseFx/fastlane/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KrauseFx/fastlane/labels{/name}","releases_url":"https://api.github.com/repos/KrauseFx/fastlane/releases{/id}","created_at":"2014-12-02T17:00:38Z","updated_at":"2015-10-11T01:22:31Z","pushed_at":"2015-10-11T11:59:34Z","git_url":"git://github.com/KrauseFx/fastlane.git","ssh_url":"git@github.com:KrauseFx/fastlane.git","clone_url":"https://github.com/KrauseFx/fastlane.git","svn_url":"https://github.com/KrauseFx/fastlane","homepage":"https://fastlane.tools","size":7114,"stargazers_count":3586,"watchers_count":3586,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":319,"mirror_url":null,"open_issues_count":99,"forks":319,"open_issues":99,"watchers":3586,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668"},"html":{"href":"https://github.com/KrauseFx/fastlane/pull/668"},"issue":{"href":"https://api.github.com/repos/KrauseFx/fastlane/issues/668"},"comments":{"href":"https://api.github.com/repos/KrauseFx/fastlane/issues/668/comments"},"review_comments":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668/comments"},"review_comment":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KrauseFx/fastlane/pulls/668/commits"},"statuses":{"href":"https://api.github.com/repos/KrauseFx/fastlane/statuses/8d7146b9afa01d82114e31786622aa6caad222d7"}}}}