{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments/46960859","id":46960859,"diff_hunk":"@@ -72,77 +71,54 @@\n         }\n       };\n \n-  private static final Function<GeneratedMessage, Object> ROW_RESULT_CONVERTER =\n-      new Function<GeneratedMessage, Object>() {\n-\n-        @Override\n-        public Object apply(GeneratedMessage response) {\n-          if (response instanceof com.google.bigtable.v1.Row) {\n-            return Adapters.ROW_ADAPTER.adaptResponse((com.google.bigtable.v1.Row) response);\n-          } else {\n-            return new Result();\n-          }\n-        }\n-      };\n-\n   /**\n    * A callback for ListenableFutures issued as a result of an RPC\n-   * @param <R>\n-   * @param <T> The response messsage type.\n    */\n-  static class RpcResultFutureCallback<R, T extends GeneratedMessage>\n-      implements FutureCallback<T> {\n-\n+  static class RpcResultFutureCallback<T> implements FutureCallback<GeneratedMessage> {\n     private final Row row;\n-    private final Batch.Callback<R> callback;\n+    private final Batch.Callback<T> callback;\n     private final int index;\n     private final Object[] resultsArray;\n-    private final SettableFuture<Object> resultFuture;\n-    private final Function<T, Object> adapter;\n+    private final SettableFuture<Result> resultFuture;","path":"bigtable-hbase/src/main/java/com/google/cloud/bigtable/hbase/BatchExecutor.java","position":41,"original_position":41,"commit_id":"464fe0fffe6686bb77bbe7c6c72c02fc393e9e16","original_commit_id":"464fe0fffe6686bb77bbe7c6c72c02fc393e9e16","user":{"login":"kevinsi4508","id":11320261,"avatar_url":"https://avatars.githubusercontent.com/u/11320261?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsi4508","html_url":"https://github.com/kevinsi4508","followers_url":"https://api.github.com/users/kevinsi4508/followers","following_url":"https://api.github.com/users/kevinsi4508/following{/other_user}","gists_url":"https://api.github.com/users/kevinsi4508/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsi4508/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsi4508/subscriptions","organizations_url":"https://api.github.com/users/kevinsi4508/orgs","repos_url":"https://api.github.com/users/kevinsi4508/repos","events_url":"https://api.github.com/users/kevinsi4508/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsi4508/received_events","type":"User","site_admin":false},"body":"Why do we need both resultsArray  and resultFuture?","created_at":"2015-12-08T14:47:07Z","updated_at":"2015-12-08T14:47:07Z","html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/589#discussion_r46960859","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments/46960859"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/589#discussion_r46960859"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589","id":52866486,"html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/589","diff_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/589.diff","patch_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/589.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/589","number":589,"state":"open","locked":false,"title":"Fixing an issue with Callbacks not being called in batch operations.","user":{"login":"sduskis","id":99305,"avatar_url":"https://avatars.githubusercontent.com/u/99305?v=3","gravatar_id":"","url":"https://api.github.com/users/sduskis","html_url":"https://github.com/sduskis","followers_url":"https://api.github.com/users/sduskis/followers","following_url":"https://api.github.com/users/sduskis/following{/other_user}","gists_url":"https://api.github.com/users/sduskis/gists{/gist_id}","starred_url":"https://api.github.com/users/sduskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sduskis/subscriptions","organizations_url":"https://api.github.com/users/sduskis/orgs","repos_url":"https://api.github.com/users/sduskis/repos","events_url":"https://api.github.com/users/sduskis/events{/privacy}","received_events_url":"https://api.github.com/users/sduskis/received_events","type":"User","site_admin":false},"body":"Refactoring BatchExecutor.  It wasn't handling Callbacks correctly.","created_at":"2015-12-07T16:27:09Z","updated_at":"2015-12-08T14:47:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28134f6a87be5add08a9e66fb071e15af0f22e6a","assignee":{"login":"kevinsi4508","id":11320261,"avatar_url":"https://avatars.githubusercontent.com/u/11320261?v=3","gravatar_id":"","url":"https://api.github.com/users/kevinsi4508","html_url":"https://github.com/kevinsi4508","followers_url":"https://api.github.com/users/kevinsi4508/followers","following_url":"https://api.github.com/users/kevinsi4508/following{/other_user}","gists_url":"https://api.github.com/users/kevinsi4508/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinsi4508/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinsi4508/subscriptions","organizations_url":"https://api.github.com/users/kevinsi4508/orgs","repos_url":"https://api.github.com/users/kevinsi4508/repos","events_url":"https://api.github.com/users/kevinsi4508/events{/privacy}","received_events_url":"https://api.github.com/users/kevinsi4508/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/589/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/statuses/464fe0fffe6686bb77bbe7c6c72c02fc393e9e16","head":{"label":"sduskis:fix_warnings","ref":"fix_warnings","sha":"464fe0fffe6686bb77bbe7c6c72c02fc393e9e16","user":{"login":"sduskis","id":99305,"avatar_url":"https://avatars.githubusercontent.com/u/99305?v=3","gravatar_id":"","url":"https://api.github.com/users/sduskis","html_url":"https://github.com/sduskis","followers_url":"https://api.github.com/users/sduskis/followers","following_url":"https://api.github.com/users/sduskis/following{/other_user}","gists_url":"https://api.github.com/users/sduskis/gists{/gist_id}","starred_url":"https://api.github.com/users/sduskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sduskis/subscriptions","organizations_url":"https://api.github.com/users/sduskis/orgs","repos_url":"https://api.github.com/users/sduskis/repos","events_url":"https://api.github.com/users/sduskis/events{/privacy}","received_events_url":"https://api.github.com/users/sduskis/received_events","type":"User","site_admin":false},"repo":{"id":35497990,"name":"cloud-bigtable-client","full_name":"sduskis/cloud-bigtable-client","owner":{"login":"sduskis","id":99305,"avatar_url":"https://avatars.githubusercontent.com/u/99305?v=3","gravatar_id":"","url":"https://api.github.com/users/sduskis","html_url":"https://github.com/sduskis","followers_url":"https://api.github.com/users/sduskis/followers","following_url":"https://api.github.com/users/sduskis/following{/other_user}","gists_url":"https://api.github.com/users/sduskis/gists{/gist_id}","starred_url":"https://api.github.com/users/sduskis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sduskis/subscriptions","organizations_url":"https://api.github.com/users/sduskis/orgs","repos_url":"https://api.github.com/users/sduskis/repos","events_url":"https://api.github.com/users/sduskis/events{/privacy}","received_events_url":"https://api.github.com/users/sduskis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sduskis/cloud-bigtable-client","description":"HBase client extension to access Google Cloud Bigtable","fork":true,"url":"https://api.github.com/repos/sduskis/cloud-bigtable-client","forks_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/forks","keys_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/teams","hooks_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/hooks","issue_events_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/issues/events{/number}","events_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/events","assignees_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/assignees{/user}","branches_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/branches{/branch}","tags_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/tags","blobs_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/statuses/{sha}","languages_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/languages","stargazers_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/stargazers","contributors_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/contributors","subscribers_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/subscribers","subscription_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/subscription","commits_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/contents/{+path}","compare_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/merges","archive_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/downloads","issues_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/issues{/number}","pulls_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/pulls{/number}","milestones_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/milestones{/number}","notifications_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/labels{/name}","releases_url":"https://api.github.com/repos/sduskis/cloud-bigtable-client/releases{/id}","created_at":"2015-05-12T15:56:54Z","updated_at":"2015-05-12T15:58:10Z","pushed_at":"2015-12-07T19:48:46Z","git_url":"git://github.com/sduskis/cloud-bigtable-client.git","ssh_url":"git@github.com:sduskis/cloud-bigtable-client.git","clone_url":"https://github.com/sduskis/cloud-bigtable-client.git","svn_url":"https://github.com/sduskis/cloud-bigtable-client","homepage":"","size":4672,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"177d3b9164005bf7e34a6431bc0b7b4f449420a7","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":18442381,"name":"cloud-bigtable-client","full_name":"GoogleCloudPlatform/cloud-bigtable-client","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client","description":"HBase client extension to access Google Cloud Bigtable","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/releases{/id}","created_at":"2014-04-04T14:54:35Z","updated_at":"2015-12-01T12:04:22Z","pushed_at":"2015-12-07T17:09:37Z","git_url":"git://github.com/GoogleCloudPlatform/cloud-bigtable-client.git","ssh_url":"git@github.com:GoogleCloudPlatform/cloud-bigtable-client.git","clone_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client.git","svn_url":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client","homepage":"","size":11482,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":14,"forks":26,"open_issues":14,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589"},"html":{"href":"https://github.com/GoogleCloudPlatform/cloud-bigtable-client/pull/589"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/589"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/issues/589/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/pulls/589/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/cloud-bigtable-client/statuses/464fe0fffe6686bb77bbe7c6c72c02fc393e9e16"}}}}