{"action":"closed","number":58,"pull_request":{"url":"https://api.github.com/repos/alphagov/cf-terraform/pulls/58","id":49447487,"html_url":"https://github.com/alphagov/cf-terraform/pull/58","diff_url":"https://github.com/alphagov/cf-terraform/pull/58.diff","patch_url":"https://github.com/alphagov/cf-terraform/pull/58.patch","issue_url":"https://api.github.com/repos/alphagov/cf-terraform/issues/58","number":58,"state":"closed","locked":false,"title":"[#107186556] Minor fixes and clean-up of build process.","user":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"body":"https://www.pivotaltracker.com/n/projects/1275640/stories/107186556\r\n\r\n# What \r\n\r\nClean up some random things:\r\n * Although is nice to have a clean output, having info the commands exectued\r\nwould help troubleshooting, specially when running on jenkins.\r\n * Delete obsolete targets in Makefile\r\n * Allow use DNS to connect to the bastion, even if the terraform state is not missing. That is useful to troubleshooting and maintain the trial and ci environments.\r\n\r\n# How to test it?\r\n\r\n * Just check that the normal deployments work and the commands are print.\r\n * Do `make ssh-aws DEPLOY_ENV=randomname` and check that it tries to ssh to the DNS name `randomname-bastion.cf.paas.alphagov.co.uk`\r\n\r\n# who can review this\r\n\r\nAnyone but @keymon","created_at":"2015-11-02T15:49:53Z","updated_at":"2015-11-03T16:14:49Z","closed_at":"2015-11-03T16:14:49Z","merged_at":"2015-11-03T16:14:49Z","merge_commit_sha":"acb21a982f33310a656349441c3a3c9ad21f3b3f","assignee":{"login":"combor","id":163394,"avatar_url":"https://avatars.githubusercontent.com/u/163394?v=3","gravatar_id":"","url":"https://api.github.com/users/combor","html_url":"https://github.com/combor","followers_url":"https://api.github.com/users/combor/followers","following_url":"https://api.github.com/users/combor/following{/other_user}","gists_url":"https://api.github.com/users/combor/gists{/gist_id}","starred_url":"https://api.github.com/users/combor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combor/subscriptions","organizations_url":"https://api.github.com/users/combor/orgs","repos_url":"https://api.github.com/users/combor/repos","events_url":"https://api.github.com/users/combor/events{/privacy}","received_events_url":"https://api.github.com/users/combor/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/cf-terraform/pulls/58/commits","review_comments_url":"https://api.github.com/repos/alphagov/cf-terraform/pulls/58/comments","review_comment_url":"https://api.github.com/repos/alphagov/cf-terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/cf-terraform/issues/58/comments","statuses_url":"https://api.github.com/repos/alphagov/cf-terraform/statuses/f1ce3c9b01cb792943aa6f2f78300bd860b089e1","head":{"label":"alphagov:bugfix/107186556_fix_build_when_bastion_changes","ref":"bugfix/107186556_fix_build_when_bastion_changes","sha":"f1ce3c9b01cb792943aa6f2f78300bd860b089e1","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":40550513,"name":"cf-terraform","full_name":"alphagov/cf-terraform","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/cf-terraform","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/cf-terraform","forks_url":"https://api.github.com/repos/alphagov/cf-terraform/forks","keys_url":"https://api.github.com/repos/alphagov/cf-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/cf-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/cf-terraform/teams","hooks_url":"https://api.github.com/repos/alphagov/cf-terraform/hooks","issue_events_url":"https://api.github.com/repos/alphagov/cf-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/cf-terraform/events","assignees_url":"https://api.github.com/repos/alphagov/cf-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/cf-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/cf-terraform/tags","blobs_url":"https://api.github.com/repos/alphagov/cf-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/cf-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/cf-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/cf-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/cf-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/cf-terraform/languages","stargazers_url":"https://api.github.com/repos/alphagov/cf-terraform/stargazers","contributors_url":"https://api.github.com/repos/alphagov/cf-terraform/contributors","subscribers_url":"https://api.github.com/repos/alphagov/cf-terraform/subscribers","subscription_url":"https://api.github.com/repos/alphagov/cf-terraform/subscription","commits_url":"https://api.github.com/repos/alphagov/cf-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/cf-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/cf-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/cf-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/cf-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/cf-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/cf-terraform/merges","archive_url":"https://api.github.com/repos/alphagov/cf-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/cf-terraform/downloads","issues_url":"https://api.github.com/repos/alphagov/cf-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/cf-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/cf-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/cf-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/cf-terraform/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/cf-terraform/releases{/id}","created_at":"2015-08-11T15:42:03Z","updated_at":"2015-09-22T15:23:01Z","pushed_at":"2015-11-03T16:14:49Z","git_url":"git://github.com/alphagov/cf-terraform.git","ssh_url":"git@github.com:alphagov/cf-terraform.git","clone_url":"https://github.com/alphagov/cf-terraform.git","svn_url":"https://github.com/alphagov/cf-terraform","homepage":null,"size":1892,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"a738a2f9a78b9ebdf8543be3e237e7fd76946cfb","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":40550513,"name":"cf-terraform","full_name":"alphagov/cf-terraform","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/cf-terraform","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/cf-terraform","forks_url":"https://api.github.com/repos/alphagov/cf-terraform/forks","keys_url":"https://api.github.com/repos/alphagov/cf-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/cf-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/cf-terraform/teams","hooks_url":"https://api.github.com/repos/alphagov/cf-terraform/hooks","issue_events_url":"https://api.github.com/repos/alphagov/cf-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/cf-terraform/events","assignees_url":"https://api.github.com/repos/alphagov/cf-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/cf-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/cf-terraform/tags","blobs_url":"https://api.github.com/repos/alphagov/cf-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/cf-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/cf-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/cf-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/cf-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/cf-terraform/languages","stargazers_url":"https://api.github.com/repos/alphagov/cf-terraform/stargazers","contributors_url":"https://api.github.com/repos/alphagov/cf-terraform/contributors","subscribers_url":"https://api.github.com/repos/alphagov/cf-terraform/subscribers","subscription_url":"https://api.github.com/repos/alphagov/cf-terraform/subscription","commits_url":"https://api.github.com/repos/alphagov/cf-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/cf-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/cf-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/cf-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/cf-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/cf-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/cf-terraform/merges","archive_url":"https://api.github.com/repos/alphagov/cf-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/cf-terraform/downloads","issues_url":"https://api.github.com/repos/alphagov/cf-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/cf-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/cf-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/cf-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/cf-terraform/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/cf-terraform/releases{/id}","created_at":"2015-08-11T15:42:03Z","updated_at":"2015-09-22T15:23:01Z","pushed_at":"2015-11-03T16:14:49Z","git_url":"git://github.com/alphagov/cf-terraform.git","ssh_url":"git@github.com:alphagov/cf-terraform.git","clone_url":"https://github.com/alphagov/cf-terraform.git","svn_url":"https://github.com/alphagov/cf-terraform","homepage":null,"size":1892,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/cf-terraform/pulls/58"},"html":{"href":"https://github.com/alphagov/cf-terraform/pull/58"},"issue":{"href":"https://api.github.com/repos/alphagov/cf-terraform/issues/58"},"comments":{"href":"https://api.github.com/repos/alphagov/cf-terraform/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/cf-terraform/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/cf-terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/cf-terraform/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/cf-terraform/statuses/f1ce3c9b01cb792943aa6f2f78300bd860b089e1"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"combor","id":163394,"avatar_url":"https://avatars.githubusercontent.com/u/163394?v=3","gravatar_id":"","url":"https://api.github.com/users/combor","html_url":"https://github.com/combor","followers_url":"https://api.github.com/users/combor/followers","following_url":"https://api.github.com/users/combor/following{/other_user}","gists_url":"https://api.github.com/users/combor/gists{/gist_id}","starred_url":"https://api.github.com/users/combor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combor/subscriptions","organizations_url":"https://api.github.com/users/combor/orgs","repos_url":"https://api.github.com/users/combor/repos","events_url":"https://api.github.com/users/combor/events{/privacy}","received_events_url":"https://api.github.com/users/combor/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":7,"additions":90,"deletions":20,"changed_files":4}}