{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/8455","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8455/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8455/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8455/events","html_url":"https://github.com/cms-sw/cmssw/pull/8455","id":63540386,"number":8455,"title":"Fastsim New CFG structure (preparations for premixing)","user":{"login":"lveldere","id":5065551,"avatar_url":"https://avatars.githubusercontent.com/u/5065551?v=3","gravatar_id":"","url":"https://api.github.com/users/lveldere","html_url":"https://github.com/lveldere","followers_url":"https://api.github.com/users/lveldere/followers","following_url":"https://api.github.com/users/lveldere/following{/other_user}","gists_url":"https://api.github.com/users/lveldere/gists{/gist_id}","starred_url":"https://api.github.com/users/lveldere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lveldere/subscriptions","organizations_url":"https://api.github.com/users/lveldere/orgs","repos_url":"https://api.github.com/users/lveldere/repos","events_url":"https://api.github.com/users/lveldere/events{/privacy}","received_events_url":"https://api.github.com/users/lveldere/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/core-pending","name":"core-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/fastsim-pending","name":"fastsim-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/operations-pending","name":"operations-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pdmv-pending","name":"pdmv-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":270,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-03-23T15:41:37Z","due_on":"2015-03-02T23:00:00Z","closed_at":null},"comments":15,"created_at":"2015-03-22T14:52:14Z","updated_at":"2015-03-23T16:37:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/8455","html_url":"https://github.com/cms-sw/cmssw/pull/8455","diff_url":"https://github.com/cms-sw/cmssw/pull/8455.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/8455.patch"},"body":"This PR superseeds #8414\r\n\r\nThe FastSim cfg structure was altered,\r\nto better resemble the standard cfg structure.\r\nThis will increase maintainability on long term,\r\nand on short term it is a necessary step in the preparation for premixing.\r\n\r\n### Changes\r\n- **cmsDriver**: the FASTSIM, deprecated since a long time, is removed from ConfigBuilder\r\n- **cmsDriver & runTheMatrix**:  FastSim has now the following steps in cmsDriver GEN,SIM,RECOBEFMIX,DIGI,L1,L1Reco,RECO,EI,HLT:@frozen25ns,VALIDATION all FastSim runTheMatrix workflows are migrated accordingly\r\n- **HLT**:  L1 and L1Reco step are moved outside the HLT step and are now separate steps in FastSim\r\n- **HLT**: clones of collections are replaced with EDAliases\r\n- **HLT DQM / Validation**: to avoid crahses in runTheMatrix workflows the inputlabel for SimVertices consumed by HLTriggerOffline/Btag is made configurable\r\n- **L1/DIGI**: packing and unpacking of calorimeter digis is removed and in order not to change any of the default InputTags, EDAliases are used to mimic the presense of post pack/unpack digi collections\r\n- **FASTSIM**: unnecessary dependence of FamosProducer on BeamSpot is removed \r\n- **unit tests**: outdated fastsim unit tests are removed from addOnTest.py\r\n- **Mixing**: reco track accumulator includes MVA values in mixing \r\n- **Mixing**: firstStepPrimaryVertices including PU tracks is emulated by reconstructing it from all  \r\ngeneralTracks since after mixing no initialStepTrack collection is available.\r\n- **MIxing**: DataMixingModule can be configured to use RecoTrackAccumulator to mix tracker information\r\n\r\n### TODO after this PR\r\n- **HLT** cfg needs a more permanent solution which does not require to import the menu inside a wrapper in FastSimulation/Configuration (see e.g. FastSimulation/Configuration/python/HLT_GRun_Famos_cff.py)\r\n  discussion initiated in #8414\r\n- **HLT** rare segfualt in L2muons\r\n- **tracking** Perhaps a cleaner solution is needed on long term to delete the modules from full iteratitve tracking from the Reconstrion cfg\r\n- **FASTSIM** Remove all FastSim cfg and other code that has become obsolete\r\n\r\n### Tests\r\n\r\n- runTheMatrix.py -l 5.1,135.1,135.8,25400\r\n- wf 135.1 with 1000 events, sanity checks for distributions of main physics objects\r\n- detailed comparison of old dumped cfg vs new dumped cfg \r\n"},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/85084767","html_url":"https://github.com/cms-sw/cmssw/pull/8455#issuecomment-85084767","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/8455","id":85084767,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T16:37:37Z","updated_at":"2015-03-23T16:37:37Z","body":"Pull request #8455 was updated. @civanch, @Dr15Jones, @lveldere, @danduggan, @boudoul, @ssekmen, @mdhildreth, @cmsbuild, @srimanob, @nclopezo, @deguio, @franzoni, @ktf, @davidlange6 can you please check and sign again."}}