{"action":"created","comment":{"url":"https://api.github.com/repos/baidu/tera/pulls/comments/40282424","id":40282424,"diff_hunk":"@@ -2286,7 +2286,7 @@ int main(int argc, char* argv[]) {\n \n     int ret = 0;\n     ErrorCode error_code;\n-    Client* client = Client::NewClient();\n+    Client* client = Client::NewClient(FLAGS_flagfile, NULL);\n ","path":"src/teracli_main.cc","position":6,"original_position":6,"commit_id":"4311c408757b987e4c539f1e227b8555cdeb6ff8","original_commit_id":"4311c408757b987e4c539f1e227b8555cdeb6ff8","user":{"login":"lylei","id":2767333,"avatar_url":"https://avatars.githubusercontent.com/u/2767333?v=3","gravatar_id":"","url":"https://api.github.com/users/lylei","html_url":"https://github.com/lylei","followers_url":"https://api.github.com/users/lylei/followers","following_url":"https://api.github.com/users/lylei/following{/other_user}","gists_url":"https://api.github.com/users/lylei/gists{/gist_id}","starred_url":"https://api.github.com/users/lylei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lylei/subscriptions","organizations_url":"https://api.github.com/users/lylei/orgs","repos_url":"https://api.github.com/users/lylei/repos","events_url":"https://api.github.com/users/lylei/events{/privacy}","received_events_url":"https://api.github.com/users/lylei/received_events","type":"User","site_admin":false},"body":"感觉有点无关，不过那个第二个参数是`err`，感觉完全木有用啊","created_at":"2015-09-24T03:21:04Z","updated_at":"2015-09-24T03:21:04Z","html_url":"https://github.com/baidu/tera/pull/350#discussion_r40282424","pull_request_url":"https://api.github.com/repos/baidu/tera/pulls/350","_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments/40282424"},"html":{"href":"https://github.com/baidu/tera/pull/350#discussion_r40282424"},"pull_request":{"href":"https://api.github.com/repos/baidu/tera/pulls/350"}}},"pull_request":{"url":"https://api.github.com/repos/baidu/tera/pulls/350","id":45746152,"html_url":"https://github.com/baidu/tera/pull/350","diff_url":"https://github.com/baidu/tera/pull/350.diff","patch_url":"https://github.com/baidu/tera/pull/350.patch","issue_url":"https://api.github.com/repos/baidu/tera/issues/350","number":350,"state":"open","locked":false,"title":"issue=#344 support-gflags-native-users","user":{"login":"taocp","id":5194281,"avatar_url":"https://avatars.githubusercontent.com/u/5194281?v=3","gravatar_id":"","url":"https://api.github.com/users/taocp","html_url":"https://github.com/taocp","followers_url":"https://api.github.com/users/taocp/followers","following_url":"https://api.github.com/users/taocp/following{/other_user}","gists_url":"https://api.github.com/users/taocp/gists{/gist_id}","starred_url":"https://api.github.com/users/taocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taocp/subscriptions","organizations_url":"https://api.github.com/users/taocp/orgs","repos_url":"https://api.github.com/users/taocp/repos","events_url":"https://api.github.com/users/taocp/events{/privacy}","received_events_url":"https://api.github.com/users/taocp/received_events","type":"User","site_admin":false},"body":"#344 \r\n\r\n1. teracli在命令行指定flagfile的功能从sdk挪到了teracli_main.cc，更合理\r\n\r\n1. sdk不再修改全局变量 FLAGS_flagfile，不影响tera用户自己使用glfags","created_at":"2015-09-23T06:05:18Z","updated_at":"2015-09-24T03:21:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e8acd6fc0973a2a05a7c5168e84fbed21373cc4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/baidu/tera/pulls/350/commits","review_comments_url":"https://api.github.com/repos/baidu/tera/pulls/350/comments","review_comment_url":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}","comments_url":"https://api.github.com/repos/baidu/tera/issues/350/comments","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/4311c408757b987e4c539f1e227b8555cdeb6ff8","head":{"label":"taocp:support-gflags-native-users","ref":"support-gflags-native-users","sha":"4311c408757b987e4c539f1e227b8555cdeb6ff8","user":{"login":"taocp","id":5194281,"avatar_url":"https://avatars.githubusercontent.com/u/5194281?v=3","gravatar_id":"","url":"https://api.github.com/users/taocp","html_url":"https://github.com/taocp","followers_url":"https://api.github.com/users/taocp/followers","following_url":"https://api.github.com/users/taocp/following{/other_user}","gists_url":"https://api.github.com/users/taocp/gists{/gist_id}","starred_url":"https://api.github.com/users/taocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taocp/subscriptions","organizations_url":"https://api.github.com/users/taocp/orgs","repos_url":"https://api.github.com/users/taocp/repos","events_url":"https://api.github.com/users/taocp/events{/privacy}","received_events_url":"https://api.github.com/users/taocp/received_events","type":"User","site_admin":false},"repo":{"id":32839075,"name":"tera","full_name":"taocp/tera","owner":{"login":"taocp","id":5194281,"avatar_url":"https://avatars.githubusercontent.com/u/5194281?v=3","gravatar_id":"","url":"https://api.github.com/users/taocp","html_url":"https://github.com/taocp","followers_url":"https://api.github.com/users/taocp/followers","following_url":"https://api.github.com/users/taocp/following{/other_user}","gists_url":"https://api.github.com/users/taocp/gists{/gist_id}","starred_url":"https://api.github.com/users/taocp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taocp/subscriptions","organizations_url":"https://api.github.com/users/taocp/orgs","repos_url":"https://api.github.com/users/taocp/repos","events_url":"https://api.github.com/users/taocp/events{/privacy}","received_events_url":"https://api.github.com/users/taocp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/taocp/tera","description":"A distributed table storage system.","fork":true,"url":"https://api.github.com/repos/taocp/tera","forks_url":"https://api.github.com/repos/taocp/tera/forks","keys_url":"https://api.github.com/repos/taocp/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/taocp/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/taocp/tera/teams","hooks_url":"https://api.github.com/repos/taocp/tera/hooks","issue_events_url":"https://api.github.com/repos/taocp/tera/issues/events{/number}","events_url":"https://api.github.com/repos/taocp/tera/events","assignees_url":"https://api.github.com/repos/taocp/tera/assignees{/user}","branches_url":"https://api.github.com/repos/taocp/tera/branches{/branch}","tags_url":"https://api.github.com/repos/taocp/tera/tags","blobs_url":"https://api.github.com/repos/taocp/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/taocp/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/taocp/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/taocp/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/taocp/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/taocp/tera/languages","stargazers_url":"https://api.github.com/repos/taocp/tera/stargazers","contributors_url":"https://api.github.com/repos/taocp/tera/contributors","subscribers_url":"https://api.github.com/repos/taocp/tera/subscribers","subscription_url":"https://api.github.com/repos/taocp/tera/subscription","commits_url":"https://api.github.com/repos/taocp/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/taocp/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/taocp/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/taocp/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/taocp/tera/contents/{+path}","compare_url":"https://api.github.com/repos/taocp/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/taocp/tera/merges","archive_url":"https://api.github.com/repos/taocp/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/taocp/tera/downloads","issues_url":"https://api.github.com/repos/taocp/tera/issues{/number}","pulls_url":"https://api.github.com/repos/taocp/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/taocp/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/taocp/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/taocp/tera/labels{/name}","releases_url":"https://api.github.com/repos/taocp/tera/releases{/id}","created_at":"2015-03-25T02:57:20Z","updated_at":"2015-05-05T11:37:02Z","pushed_at":"2015-09-23T08:27:59Z","git_url":"git://github.com/taocp/tera.git","ssh_url":"git@github.com:taocp/tera.git","clone_url":"https://github.com/taocp/tera.git","svn_url":"https://github.com/taocp/tera","homepage":"","size":12192,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"baidu:master","ref":"master","sha":"776c00552793eb00e823f0914db826be691b8170","user":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"repo":{"id":18129915,"name":"tera","full_name":"baidu/tera","owner":{"login":"baidu","id":13245940,"avatar_url":"https://avatars.githubusercontent.com/u/13245940?v=3","gravatar_id":"","url":"https://api.github.com/users/baidu","html_url":"https://github.com/baidu","followers_url":"https://api.github.com/users/baidu/followers","following_url":"https://api.github.com/users/baidu/following{/other_user}","gists_url":"https://api.github.com/users/baidu/gists{/gist_id}","starred_url":"https://api.github.com/users/baidu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baidu/subscriptions","organizations_url":"https://api.github.com/users/baidu/orgs","repos_url":"https://api.github.com/users/baidu/repos","events_url":"https://api.github.com/users/baidu/events{/privacy}","received_events_url":"https://api.github.com/users/baidu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/baidu/tera","description":"A distributed, elastic, structured database.","fork":false,"url":"https://api.github.com/repos/baidu/tera","forks_url":"https://api.github.com/repos/baidu/tera/forks","keys_url":"https://api.github.com/repos/baidu/tera/keys{/key_id}","collaborators_url":"https://api.github.com/repos/baidu/tera/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/baidu/tera/teams","hooks_url":"https://api.github.com/repos/baidu/tera/hooks","issue_events_url":"https://api.github.com/repos/baidu/tera/issues/events{/number}","events_url":"https://api.github.com/repos/baidu/tera/events","assignees_url":"https://api.github.com/repos/baidu/tera/assignees{/user}","branches_url":"https://api.github.com/repos/baidu/tera/branches{/branch}","tags_url":"https://api.github.com/repos/baidu/tera/tags","blobs_url":"https://api.github.com/repos/baidu/tera/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/baidu/tera/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/baidu/tera/git/refs{/sha}","trees_url":"https://api.github.com/repos/baidu/tera/git/trees{/sha}","statuses_url":"https://api.github.com/repos/baidu/tera/statuses/{sha}","languages_url":"https://api.github.com/repos/baidu/tera/languages","stargazers_url":"https://api.github.com/repos/baidu/tera/stargazers","contributors_url":"https://api.github.com/repos/baidu/tera/contributors","subscribers_url":"https://api.github.com/repos/baidu/tera/subscribers","subscription_url":"https://api.github.com/repos/baidu/tera/subscription","commits_url":"https://api.github.com/repos/baidu/tera/commits{/sha}","git_commits_url":"https://api.github.com/repos/baidu/tera/git/commits{/sha}","comments_url":"https://api.github.com/repos/baidu/tera/comments{/number}","issue_comment_url":"https://api.github.com/repos/baidu/tera/issues/comments{/number}","contents_url":"https://api.github.com/repos/baidu/tera/contents/{+path}","compare_url":"https://api.github.com/repos/baidu/tera/compare/{base}...{head}","merges_url":"https://api.github.com/repos/baidu/tera/merges","archive_url":"https://api.github.com/repos/baidu/tera/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/baidu/tera/downloads","issues_url":"https://api.github.com/repos/baidu/tera/issues{/number}","pulls_url":"https://api.github.com/repos/baidu/tera/pulls{/number}","milestones_url":"https://api.github.com/repos/baidu/tera/milestones{/number}","notifications_url":"https://api.github.com/repos/baidu/tera/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/baidu/tera/labels{/name}","releases_url":"https://api.github.com/repos/baidu/tera/releases{/id}","created_at":"2014-03-26T07:22:05Z","updated_at":"2015-09-20T12:11:20Z","pushed_at":"2015-09-24T02:17:35Z","git_url":"git://github.com/baidu/tera.git","ssh_url":"git@github.com:baidu/tera.git","clone_url":"https://github.com/baidu/tera.git","svn_url":"https://github.com/baidu/tera","homepage":"","size":15853,"stargazers_count":285,"watchers_count":285,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":89,"mirror_url":null,"open_issues_count":47,"forks":89,"open_issues":47,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/baidu/tera/pulls/350"},"html":{"href":"https://github.com/baidu/tera/pull/350"},"issue":{"href":"https://api.github.com/repos/baidu/tera/issues/350"},"comments":{"href":"https://api.github.com/repos/baidu/tera/issues/350/comments"},"review_comments":{"href":"https://api.github.com/repos/baidu/tera/pulls/350/comments"},"review_comment":{"href":"https://api.github.com/repos/baidu/tera/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/baidu/tera/pulls/350/commits"},"statuses":{"href":"https://api.github.com/repos/baidu/tera/statuses/4311c408757b987e4c539f1e227b8555cdeb6ff8"}}}}