{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/33041628","id":33041628,"diff_hunk":"@@ -17,7 +17,7 @@ def clean_test_files():\n     \"\"\"\n     Clean fixture files used by tests and .pyc files\n     \"\"\"\n-    sh(\"git clean -fqdx test_root/logs test_root/data test_root/staticfiles test_root/uploads\")\n+    sh(\"git clean -fqdx test_root/logs test_root/data test_root/uploads\")","path":"pavelib/utils/test/utils.py","position":5,"original_position":5,"commit_id":"2814c87abe3bb60305647727434846e8a7adfa75","original_commit_id":"d7c8d8a604423221752c49638ea57a243c8197f1","user":{"login":"benpatterson","id":2004678,"avatar_url":"https://avatars.githubusercontent.com/u/2004678?v=3","gravatar_id":"","url":"https://api.github.com/users/benpatterson","html_url":"https://github.com/benpatterson","followers_url":"https://api.github.com/users/benpatterson/followers","following_url":"https://api.github.com/users/benpatterson/following{/other_user}","gists_url":"https://api.github.com/users/benpatterson/gists{/gist_id}","starred_url":"https://api.github.com/users/benpatterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benpatterson/subscriptions","organizations_url":"https://api.github.com/users/benpatterson/orgs","repos_url":"https://api.github.com/users/benpatterson/repos","events_url":"https://api.github.com/users/benpatterson/events{/privacy}","received_events_url":"https://api.github.com/users/benpatterson/received_events","type":"User","site_admin":false},"body":"Ah, so if I interpret that correctly, using fasttest might mean we end up looking at the *wrong* files? (The non-optimized ones?) @andy-armstrong can you clarify?","created_at":"2015-06-23T13:44:43Z","updated_at":"2015-06-23T13:44:43Z","html_url":"https://github.com/edx/edx-platform/pull/8529#discussion_r33041628","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/8529","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/33041628"},"html":{"href":"https://github.com/edx/edx-platform/pull/8529#discussion_r33041628"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8529"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/8529","id":37736737,"html_url":"https://github.com/edx/edx-platform/pull/8529","diff_url":"https://github.com/edx/edx-platform/pull/8529.diff","patch_url":"https://github.com/edx/edx-platform/pull/8529.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/8529","number":8529,"state":"open","locked":false,"title":"Update Bok Choy to run against optimized static files","user":{"login":"andy-armstrong","id":5985072,"avatar_url":"https://avatars.githubusercontent.com/u/5985072?v=3","gravatar_id":"","url":"https://api.github.com/users/andy-armstrong","html_url":"https://github.com/andy-armstrong","followers_url":"https://api.github.com/users/andy-armstrong/followers","following_url":"https://api.github.com/users/andy-armstrong/following{/other_user}","gists_url":"https://api.github.com/users/andy-armstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-armstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-armstrong/subscriptions","organizations_url":"https://api.github.com/users/andy-armstrong/orgs","repos_url":"https://api.github.com/users/andy-armstrong/repos","events_url":"https://api.github.com/users/andy-armstrong/events{/privacy}","received_events_url":"https://api.github.com/users/andy-armstrong/received_events","type":"User","site_admin":false},"body":"https://openedx.atlassian.net/browse/TNL-2465\r\n\r\nThis PR changes Bok Choy so that it runs against optimized static files so that the behavior is closer to production. As a performance optimization, we decided to not use 'Uglify' as part of the optimization step, as that is by far the slowest part of ``collectstatic``.\r\n\r\nNote: it didn't seem possible to both generate optimized assets and serve those files from a single settings file. At @cpennington's suggestion, I broke ``bok_choy.py`` into two files: a new ``bok_choy_static.py`` used only when calling ``collectstatic``, and then the original file that is used when running the servers.\r\n\r\n@cpennington @jzoldak @cahrens please review.\r\n\r\nFYI: @benpatterson @wedaly @dan-f @peter-fogg @benmcmorran @dianakhuang","created_at":"2015-06-15T21:19:23Z","updated_at":"2015-06-23T13:44:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c5c4b0de1304f7570a1b14ed7e23020a2a61576","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/8529/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/8529/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/8529/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/2814c87abe3bb60305647727434846e8a7adfa75","head":{"label":"edx:andya/bokchoy-asset-pipeline","ref":"andya/bokchoy-asset-pipeline","sha":"2814c87abe3bb60305647727434846e8a7adfa75","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-06-23T12:14:11Z","pushed_at":"2015-06-23T13:40:55Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":1925704,"stargazers_count":2001,"watchers_count":2001,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1148,"mirror_url":null,"open_issues_count":166,"forks":1148,"open_issues":166,"watchers":2001,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"44e13af6be68c89a72ac633b65c237a4afc156ab","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"The Open edX platform, the software that powers edX!","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-06-23T12:14:11Z","pushed_at":"2015-06-23T13:40:55Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://open.edx.org/","size":1925704,"stargazers_count":2001,"watchers_count":2001,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1148,"mirror_url":null,"open_issues_count":166,"forks":1148,"open_issues":166,"watchers":2001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8529"},"html":{"href":"https://github.com/edx/edx-platform/pull/8529"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8529"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/8529/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8529/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/8529/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/2814c87abe3bb60305647727434846e8a7adfa75"}}}}