{"push_id":831910083,"size":48,"distinct_size":17,"ref":"refs/heads/tidy-lib","head":"1352d0680655974958e97b7d1fbf4ca3aff148d2","before":"d60f67ddda09cb7426b9e8f3c29920600ddcdcc6","commits":[{"sha":"4ebf64565abaed041cfde2f68568b8db08a2f969","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Make prison_data_production.yml canonical\n\nSo the prison data only has to be managed in a single file.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/4ebf64565abaed041cfde2f68568b8db08a2f969"},{"sha":"7251df53d859cd3ce434e6d006b7a2572f8540ed","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Change prison_data from a hash to an array\n\nThe previous version was a hash keyed by the prison name.  This made it\ndifficult to detect duplication in tests and impossible to detect it at\nruntime. Making it an array of hashes simplifies the process\nconsiderably.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/7251df53d859cd3ce434e6d006b7a2572f8540ed"},{"sha":"4b21e647f5c4312e5dae74ed1b1a6893bd5c1703","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Change the way prison data is accessed.\n\nPreviously, it had been loaded into Rails.configuration as a hash and\naccessed as a hash.  This commit changes that such that all access now\n*must* be done using the Prison model and its instances.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/4b21e647f5c4312e5dae74ed1b1a6893bd5c1703"},{"sha":"1622a4e6dc2cc029f773632fae7844e81e4b5c72","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Use the new prisoner object for validations\n\nThis was relying on the old prison data hash.  This change abstracts\nthat away into methods on the prison object.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/1622a4e6dc2cc029f773632fae7844e81e4b5c72"},{"sha":"2973c5f25b90dff9f8471cbc7fb2121bd3500fbc","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Use the Prison model for this\n\nThis validator and its spec were doing low-rent dependency injection on\nthe prison data hash.  This changes it so you pass in just the name of\nthe prison, which is used to find the correct prison model.  All other\naccess is done via an instance of that object.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/2973c5f25b90dff9f8471cbc7fb2121bd3500fbc"},{"sha":"6951b9734d229afc0a2fe53573955f5b1df5be33","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Port old format changes to Wandsworth unbookable\n\nKylie added these to the two yaml files currently used for production. I\nmerged those changes to master and ported them over to the new-format\nfiles.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/6951b9734d229afc0a2fe53573955f5b1df5be33"},{"sha":"954b7413e387db750a67071a4e98297507c58f68","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Make prison_data_spec conform to prison model\n\nThis was looking at the in-memory hash previously.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/954b7413e387db750a67071a4e98297507c58f68"},{"sha":"5764c169e54a7ab01a1dd9c69c11f4cdd58877f4","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Make visitor_mailer_spec shorter and use Prison\n\nI broke out the =~ 100 lines of let definitions and hooks into a shared\nconcern.  The spec, proper is still over 300 lines long (!!!), but this\nhelped clear it up a bit.  It really needs to be broken down into a\nnumber of much shorter, clearer specs, but that was outside the scope of\nthis excercise.  I changed it to use the Prison model instead of the old\nprison_data hash.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/5764c169e54a7ab01a1dd9c69c11f4cdd58877f4"},{"sha":"07ff40badb7b7921753d8d68af5e9575acefe729","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Fix the failing confirmation_controller spec\n\nThis was being caused by the `new.html.haml` view using the old\nprison_data object.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/07ff40badb7b7921753d8d68af5e9575acefe729"},{"sha":"bc5179ab7b37832b4a1fe2ad61cddc433dc2a7a8","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Add Prison.enabled to get only enabled prisons\n\nThis is not being done with a scope (default_scope, even) owing to the\nfact this is not an ActiveRecord model.  It is needed, however, as I\nfind myself continually iterating over the enabled prisons.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/bc5179ab7b37832b4a1fe2ad61cddc433dc2a7a8"},{"sha":"289e77a17d4b0c1123acc8a7827c9c9ae96dcfa0","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Make static_controller.rb use the Prison model\n\nPreviously, it was using the prison_data hash.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/289e77a17d4b0c1123acc8a7827c9c9ae96dcfa0"},{"sha":"029b8af91258f3a342e4970468f726f19957d921","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Use the same email in test as in production\n\nSpecs perviously used the staging verison of the prison_data hash. This\nhad a different email address from the production version.  This has\nchanged now that we have a canonical record.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/029b8af91258f3a342e4970468f726f19957d921"},{"sha":"393c6bb142d7b5b3188fc5f4098032ab4f555e4e","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Make edit.html.haml use the Prison model\n\nIt was calling the 'reasons' key on the old data structure.  This fixes\nthe resulting NoMehtodError.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/393c6bb142d7b5b3188fc5f4098032ab4f555e4e"},{"sha":"e7d2af7062de9cc7c5e1b515f4fd8c1e9b79f39e","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Reset Prison collection after each run\n\nThis is complicated by the fact that it is an in-memory array and so we\ncan't just wrap it in a transaction and be done with it. It's not really\nas elegant a solution as I would like, but at least it only uses the\navailable methods...","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/e7d2af7062de9cc7c5e1b515f4fd8c1e9b79f39e"},{"sha":"17039fc2eaef6c94461480f4087df2612b839c00","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Make the intent of the spec clearer\n\nIt was failing in this iteration owing to the fact that the passing and\nfailing tests were grouped in the same `it` block. It is unclear why\nthey were passing on master as they should not have been.  Overall, the\nintent behind the spec was obscured by the wording of the blocks and\nthis made bottoming the problem more difficult. I broke the passing and\nfailing versions out into their own specs to ensure that the data set\nunder test was not being handed off between them.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/17039fc2eaef6c94461480f4087df2612b839c00"},{"sha":"65c931e41b96d057be7dc1654e3d13d4ceeecc04","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Fix intermittent failing spec\n\nThis was failing because some other spec it altering the slots such that\nthe keys become symbols. They probably always should be, but I'll leave\nthat as a task for later.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/65c931e41b96d057be7dc1654e3d13d4ceeecc04"},{"sha":"7899a2d87972eebaa13445fbb8ff5cb9be6885c3","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Remove confusing, failing spec ahead of refactor\n\nThe original docuemntation run for this spec reads:\n\n```\nVisitorsDetailsController behaves like a visitor data manipulator with\ninvalid data given only a single child visitor when the prison assumes\neach adult to be some other age an adult with three people over seat age\nthreshold rejects the booking request\n```\n\nThe data structure being sent included a 19 year old visitor *and* three\n10 year old visitors.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/7899a2d87972eebaa13445fbb8ff5cb9be6885c3"},{"sha":"bc438ca3157d58e6ee203fd304c981dc652f68e8","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Replace configuration.nomis_ids with class method\n\nThe Rails.confiuration.nomis_ids array was the last thing relying on the\nraw data hash.  Removing this means that all access to prison data\n*should* now be done via the `Prison' model.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/bc438ca3157d58e6ee203fd304c981dc652f68e8"},{"sha":"82e2a068bd8087269589c3d4f5bcc16b6c64732a","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Clean up rubocop issues\n\nA few cropped up.  This sorts them.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/82e2a068bd8087269589c3d4f5bcc16b6c64732a"},{"sha":"31a04c8236ec54b8c3fe5e28aaaa03e68e888333","author":{"email":"1554dc8c01e026eaffd7614989b1c49b75633447@gmail.com","name":"Todd Tyree"},"message":"Use Virtus for attributes. Cleanup other lint.\n\nAs per @threedaymonk's comments on the PR.","distinct":false,"url":"https://api.github.com/repos/ministryofjustice/prison-visits/commits/31a04c8236ec54b8c3fe5e28aaaa03e68e888333"}]}