{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/661","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/661/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/661/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/661/events","html_url":"https://github.com/facebook/rocksdb/pull/661","id":96001058,"number":661,"title":"fix bugs in VersionSet::LogAndApply() to make it more robust","user":{"login":"qinzuoyan","id":528445,"avatar_url":"https://avatars.githubusercontent.com/u/528445?v=3","gravatar_id":"","url":"https://api.github.com/users/qinzuoyan","html_url":"https://github.com/qinzuoyan","followers_url":"https://api.github.com/users/qinzuoyan/followers","following_url":"https://api.github.com/users/qinzuoyan/following{/other_user}","gists_url":"https://api.github.com/users/qinzuoyan/gists{/gist_id}","starred_url":"https://api.github.com/users/qinzuoyan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qinzuoyan/subscriptions","organizations_url":"https://api.github.com/users/qinzuoyan/orgs","repos_url":"https://api.github.com/users/qinzuoyan/repos","events_url":"https://api.github.com/users/qinzuoyan/events{/privacy}","received_events_url":"https://api.github.com/users/qinzuoyan/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-20T07:10:16Z","updated_at":"2015-07-20T19:40:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/661","html_url":"https://github.com/facebook/rocksdb/pull/661","diff_url":"https://github.com/facebook/rocksdb/pull/661.diff","patch_url":"https://github.com/facebook/rocksdb/pull/661.patch"},"body":"1, if the param new_descriptor_log is true, new manifest file number may re-use and overwrite the old one, which is an unexpected behavior.\r\n2, check s.ok() to avoid unnecessary invoking of v->PrepareApply().\r\n3, add current_file_updated flag for assert.\r\n4, fix incorrect log printing when deleting manifest file."},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/123002355","html_url":"https://github.com/facebook/rocksdb/pull/661#issuecomment-123002355","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/661","id":123002355,"user":{"login":"siying","id":5334567,"avatar_url":"https://avatars.githubusercontent.com/u/5334567?v=3","gravatar_id":"","url":"https://api.github.com/users/siying","html_url":"https://github.com/siying","followers_url":"https://api.github.com/users/siying/followers","following_url":"https://api.github.com/users/siying/following{/other_user}","gists_url":"https://api.github.com/users/siying/gists{/gist_id}","starred_url":"https://api.github.com/users/siying/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siying/subscriptions","organizations_url":"https://api.github.com/users/siying/orgs","repos_url":"https://api.github.com/users/siying/repos","events_url":"https://api.github.com/users/siying/events{/privacy}","received_events_url":"https://api.github.com/users/siying/received_events","type":"User","site_admin":false},"created_at":"2015-07-20T19:40:08Z","updated_at":"2015-07-20T19:40:08Z","body":"Thank you for your contribution! Reading from the changes, it does look like you find a bug and have a right fix for it. Let me reproduce it in a unit test to double check that. Will merge once it is verified by a unit test."}}