{"action":"created","comment":{"url":"https://api.github.com/repos/gearpump/gearpump/pulls/comments/43371832","id":43371832,"diff_hunk":"@@ -98,6 +85,7 @@ private[appmaster] class TaskManager(\n         val resourceRequestDetail = subDAGManager.executorFailed(executorId)\n         executorManager ! StartExecutors(resourceRequestDetail.requests, resourceRequestDetail.jar)\n       } else {\n+        appMaster ! ShutdownApplication(appId)","path":"streaming/src/main/scala/io/gearpump/streaming/appmaster/TaskManager.scala","position":72,"original_position":72,"commit_id":"0e4ef7935e9ed69963cc46319a811e25bd24dbbb","original_commit_id":"0e4ef7935e9ed69963cc46319a811e25bd24dbbb","user":{"login":"clockfly","id":2595532,"avatar_url":"https://avatars.githubusercontent.com/u/2595532?v=3","gravatar_id":"","url":"https://api.github.com/users/clockfly","html_url":"https://github.com/clockfly","followers_url":"https://api.github.com/users/clockfly/followers","following_url":"https://api.github.com/users/clockfly/following{/other_user}","gists_url":"https://api.github.com/users/clockfly/gists{/gist_id}","starred_url":"https://api.github.com/users/clockfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockfly/subscriptions","organizations_url":"https://api.github.com/users/clockfly/orgs","repos_url":"https://api.github.com/users/clockfly/repos","events_url":"https://api.github.com/users/clockfly/events{/privacy}","received_events_url":"https://api.github.com/users/clockfly/received_events","type":"User","site_admin":false},"body":"instead of telling AppMaster to shutdown, maybe it is better to tell AppMaster what is going wrong. It is AppMaster's responsibility to decide how to react to that error.","created_at":"2015-10-29T10:59:51Z","updated_at":"2015-10-29T10:59:51Z","html_url":"https://github.com/gearpump/gearpump/pull/1500#discussion_r43371832","pull_request_url":"https://api.github.com/repos/gearpump/gearpump/pulls/1500","_links":{"self":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/comments/43371832"},"html":{"href":"https://github.com/gearpump/gearpump/pull/1500#discussion_r43371832"},"pull_request":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1500"}}},"pull_request":{"url":"https://api.github.com/repos/gearpump/gearpump/pulls/1500","id":49108031,"html_url":"https://github.com/gearpump/gearpump/pull/1500","diff_url":"https://github.com/gearpump/gearpump/pull/1500.diff","patch_url":"https://github.com/gearpump/gearpump/pull/1500.patch","issue_url":"https://api.github.com/repos/gearpump/gearpump/issues/1500","number":1500,"state":"open","locked":false,"title":"fix #1485 no more pending messages in ExpressTransport","user":{"login":"huafengw","id":5011399,"avatar_url":"https://avatars.githubusercontent.com/u/5011399?v=3","gravatar_id":"","url":"https://api.github.com/users/huafengw","html_url":"https://github.com/huafengw","followers_url":"https://api.github.com/users/huafengw/followers","following_url":"https://api.github.com/users/huafengw/following{/other_user}","gists_url":"https://api.github.com/users/huafengw/gists{/gist_id}","starred_url":"https://api.github.com/users/huafengw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huafengw/subscriptions","organizations_url":"https://api.github.com/users/huafengw/orgs","repos_url":"https://api.github.com/users/huafengw/repos","events_url":"https://api.github.com/users/huafengw/events{/privacy}","received_events_url":"https://api.github.com/users/huafengw/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-10-29T07:57:28Z","updated_at":"2015-10-29T10:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cab16d09330bc088312cb3f8fd8adf28a4e58819","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gearpump/gearpump/pulls/1500/commits","review_comments_url":"https://api.github.com/repos/gearpump/gearpump/pulls/1500/comments","review_comment_url":"https://api.github.com/repos/gearpump/gearpump/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gearpump/gearpump/issues/1500/comments","statuses_url":"https://api.github.com/repos/gearpump/gearpump/statuses/0e4ef7935e9ed69963cc46319a811e25bd24dbbb","head":{"label":"huafengw:fix#1485","ref":"fix#1485","sha":"0e4ef7935e9ed69963cc46319a811e25bd24dbbb","user":{"login":"huafengw","id":5011399,"avatar_url":"https://avatars.githubusercontent.com/u/5011399?v=3","gravatar_id":"","url":"https://api.github.com/users/huafengw","html_url":"https://github.com/huafengw","followers_url":"https://api.github.com/users/huafengw/followers","following_url":"https://api.github.com/users/huafengw/following{/other_user}","gists_url":"https://api.github.com/users/huafengw/gists{/gist_id}","starred_url":"https://api.github.com/users/huafengw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huafengw/subscriptions","organizations_url":"https://api.github.com/users/huafengw/orgs","repos_url":"https://api.github.com/users/huafengw/repos","events_url":"https://api.github.com/users/huafengw/events{/privacy}","received_events_url":"https://api.github.com/users/huafengw/received_events","type":"User","site_admin":false},"repo":{"id":23856462,"name":"gearpump","full_name":"huafengw/gearpump","owner":{"login":"huafengw","id":5011399,"avatar_url":"https://avatars.githubusercontent.com/u/5011399?v=3","gravatar_id":"","url":"https://api.github.com/users/huafengw","html_url":"https://github.com/huafengw","followers_url":"https://api.github.com/users/huafengw/followers","following_url":"https://api.github.com/users/huafengw/following{/other_user}","gists_url":"https://api.github.com/users/huafengw/gists{/gist_id}","starred_url":"https://api.github.com/users/huafengw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huafengw/subscriptions","organizations_url":"https://api.github.com/users/huafengw/orgs","repos_url":"https://api.github.com/users/huafengw/repos","events_url":"https://api.github.com/users/huafengw/events{/privacy}","received_events_url":"https://api.github.com/users/huafengw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huafengw/gearpump","description":"gearpump","fork":true,"url":"https://api.github.com/repos/huafengw/gearpump","forks_url":"https://api.github.com/repos/huafengw/gearpump/forks","keys_url":"https://api.github.com/repos/huafengw/gearpump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huafengw/gearpump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huafengw/gearpump/teams","hooks_url":"https://api.github.com/repos/huafengw/gearpump/hooks","issue_events_url":"https://api.github.com/repos/huafengw/gearpump/issues/events{/number}","events_url":"https://api.github.com/repos/huafengw/gearpump/events","assignees_url":"https://api.github.com/repos/huafengw/gearpump/assignees{/user}","branches_url":"https://api.github.com/repos/huafengw/gearpump/branches{/branch}","tags_url":"https://api.github.com/repos/huafengw/gearpump/tags","blobs_url":"https://api.github.com/repos/huafengw/gearpump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huafengw/gearpump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huafengw/gearpump/git/refs{/sha}","trees_url":"https://api.github.com/repos/huafengw/gearpump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huafengw/gearpump/statuses/{sha}","languages_url":"https://api.github.com/repos/huafengw/gearpump/languages","stargazers_url":"https://api.github.com/repos/huafengw/gearpump/stargazers","contributors_url":"https://api.github.com/repos/huafengw/gearpump/contributors","subscribers_url":"https://api.github.com/repos/huafengw/gearpump/subscribers","subscription_url":"https://api.github.com/repos/huafengw/gearpump/subscription","commits_url":"https://api.github.com/repos/huafengw/gearpump/commits{/sha}","git_commits_url":"https://api.github.com/repos/huafengw/gearpump/git/commits{/sha}","comments_url":"https://api.github.com/repos/huafengw/gearpump/comments{/number}","issue_comment_url":"https://api.github.com/repos/huafengw/gearpump/issues/comments{/number}","contents_url":"https://api.github.com/repos/huafengw/gearpump/contents/{+path}","compare_url":"https://api.github.com/repos/huafengw/gearpump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huafengw/gearpump/merges","archive_url":"https://api.github.com/repos/huafengw/gearpump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huafengw/gearpump/downloads","issues_url":"https://api.github.com/repos/huafengw/gearpump/issues{/number}","pulls_url":"https://api.github.com/repos/huafengw/gearpump/pulls{/number}","milestones_url":"https://api.github.com/repos/huafengw/gearpump/milestones{/number}","notifications_url":"https://api.github.com/repos/huafengw/gearpump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huafengw/gearpump/labels{/name}","releases_url":"https://api.github.com/repos/huafengw/gearpump/releases{/id}","created_at":"2014-09-10T01:32:11Z","updated_at":"2015-05-06T02:33:39Z","pushed_at":"2015-10-29T08:54:46Z","git_url":"git://github.com/huafengw/gearpump.git","ssh_url":"git@github.com:huafengw/gearpump.git","clone_url":"https://github.com/huafengw/gearpump.git","svn_url":"https://github.com/huafengw/gearpump","homepage":"","size":13551,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"gearpump:master","ref":"master","sha":"385de16b38432f10aa5925eba667f8cd29ed9870","user":{"login":"gearpump","id":8586929,"avatar_url":"https://avatars.githubusercontent.com/u/8586929?v=3","gravatar_id":"","url":"https://api.github.com/users/gearpump","html_url":"https://github.com/gearpump","followers_url":"https://api.github.com/users/gearpump/followers","following_url":"https://api.github.com/users/gearpump/following{/other_user}","gists_url":"https://api.github.com/users/gearpump/gists{/gist_id}","starred_url":"https://api.github.com/users/gearpump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gearpump/subscriptions","organizations_url":"https://api.github.com/users/gearpump/orgs","repos_url":"https://api.github.com/users/gearpump/repos","events_url":"https://api.github.com/users/gearpump/events{/privacy}","received_events_url":"https://api.github.com/users/gearpump/received_events","type":"Organization","site_admin":false},"repo":{"id":22139167,"name":"gearpump","full_name":"gearpump/gearpump","owner":{"login":"gearpump","id":8586929,"avatar_url":"https://avatars.githubusercontent.com/u/8586929?v=3","gravatar_id":"","url":"https://api.github.com/users/gearpump","html_url":"https://github.com/gearpump","followers_url":"https://api.github.com/users/gearpump/followers","following_url":"https://api.github.com/users/gearpump/following{/other_user}","gists_url":"https://api.github.com/users/gearpump/gists{/gist_id}","starred_url":"https://api.github.com/users/gearpump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gearpump/subscriptions","organizations_url":"https://api.github.com/users/gearpump/orgs","repos_url":"https://api.github.com/users/gearpump/repos","events_url":"https://api.github.com/users/gearpump/events{/privacy}","received_events_url":"https://api.github.com/users/gearpump/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gearpump/gearpump","description":"Lightweight real-time big data streaming engine","fork":false,"url":"https://api.github.com/repos/gearpump/gearpump","forks_url":"https://api.github.com/repos/gearpump/gearpump/forks","keys_url":"https://api.github.com/repos/gearpump/gearpump/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gearpump/gearpump/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gearpump/gearpump/teams","hooks_url":"https://api.github.com/repos/gearpump/gearpump/hooks","issue_events_url":"https://api.github.com/repos/gearpump/gearpump/issues/events{/number}","events_url":"https://api.github.com/repos/gearpump/gearpump/events","assignees_url":"https://api.github.com/repos/gearpump/gearpump/assignees{/user}","branches_url":"https://api.github.com/repos/gearpump/gearpump/branches{/branch}","tags_url":"https://api.github.com/repos/gearpump/gearpump/tags","blobs_url":"https://api.github.com/repos/gearpump/gearpump/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gearpump/gearpump/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gearpump/gearpump/git/refs{/sha}","trees_url":"https://api.github.com/repos/gearpump/gearpump/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gearpump/gearpump/statuses/{sha}","languages_url":"https://api.github.com/repos/gearpump/gearpump/languages","stargazers_url":"https://api.github.com/repos/gearpump/gearpump/stargazers","contributors_url":"https://api.github.com/repos/gearpump/gearpump/contributors","subscribers_url":"https://api.github.com/repos/gearpump/gearpump/subscribers","subscription_url":"https://api.github.com/repos/gearpump/gearpump/subscription","commits_url":"https://api.github.com/repos/gearpump/gearpump/commits{/sha}","git_commits_url":"https://api.github.com/repos/gearpump/gearpump/git/commits{/sha}","comments_url":"https://api.github.com/repos/gearpump/gearpump/comments{/number}","issue_comment_url":"https://api.github.com/repos/gearpump/gearpump/issues/comments{/number}","contents_url":"https://api.github.com/repos/gearpump/gearpump/contents/{+path}","compare_url":"https://api.github.com/repos/gearpump/gearpump/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gearpump/gearpump/merges","archive_url":"https://api.github.com/repos/gearpump/gearpump/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gearpump/gearpump/downloads","issues_url":"https://api.github.com/repos/gearpump/gearpump/issues{/number}","pulls_url":"https://api.github.com/repos/gearpump/gearpump/pulls{/number}","milestones_url":"https://api.github.com/repos/gearpump/gearpump/milestones{/number}","notifications_url":"https://api.github.com/repos/gearpump/gearpump/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gearpump/gearpump/labels{/name}","releases_url":"https://api.github.com/repos/gearpump/gearpump/releases{/id}","created_at":"2014-07-23T08:55:26Z","updated_at":"2015-10-27T09:25:08Z","pushed_at":"2015-10-29T08:54:47Z","git_url":"git://github.com/gearpump/gearpump.git","ssh_url":"git@github.com:gearpump/gearpump.git","clone_url":"https://github.com/gearpump/gearpump.git","svn_url":"https://github.com/gearpump/gearpump","homepage":"http://gearpump.io","size":21122,"stargazers_count":344,"watchers_count":344,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"open_issues_count":50,"forks":77,"open_issues":50,"watchers":344,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1500"},"html":{"href":"https://github.com/gearpump/gearpump/pull/1500"},"issue":{"href":"https://api.github.com/repos/gearpump/gearpump/issues/1500"},"comments":{"href":"https://api.github.com/repos/gearpump/gearpump/issues/1500/comments"},"review_comments":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1500/comments"},"review_comment":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gearpump/gearpump/pulls/1500/commits"},"statuses":{"href":"https://api.github.com/repos/gearpump/gearpump/statuses/0e4ef7935e9ed69963cc46319a811e25bd24dbbb"}}}}