{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/11205","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/11205/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/11205/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/11205/events","html_url":"https://github.com/JuliaLang/julia/pull/11205","id":74554915,"number":11205,"title":"Fix GC_VERIFY and two gc write barrier issue. Thanks @carnaval","user":{"login":"yuyichao","id":712232,"avatar_url":"https://avatars.githubusercontent.com/u/712232?v=3","gravatar_id":"","url":"https://api.github.com/users/yuyichao","html_url":"https://github.com/yuyichao","followers_url":"https://api.github.com/users/yuyichao/followers","following_url":"https://api.github.com/users/yuyichao/following{/other_user}","gists_url":"https://api.github.com/users/yuyichao/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyichao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyichao/subscriptions","organizations_url":"https://api.github.com/users/yuyichao/orgs","repos_url":"https://api.github.com/users/yuyichao/repos","events_url":"https://api.github.com/users/yuyichao/events{/privacy}","received_events_url":"https://api.github.com/users/yuyichao/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-09T01:38:13Z","updated_at":"2015-05-09T08:31:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/11205","html_url":"https://github.com/JuliaLang/julia/pull/11205","diff_url":"https://github.com/JuliaLang/julia/pull/11205.diff","patch_url":"https://github.com/JuliaLang/julia/pull/11205.patch"},"body":"This PR and 871f059e2beca9af66ae6706d082f5badca76b35 were the result of a hours long debuging using always-full-gc approach this afternoon as mentioned in #11151. @carnaval did most of the work and my job was mainly learning, moral support, and providing a system that is somehow more vulnerable to GC issues....\r\n\r\n@carnaval: I know you said you want to forget about this for the weekend, but could you do a last check of the codegen fix. IMHO, from the comment in this function, `needroots` feels like the proper value to decide whether a barrier to use than or'ing if any of the privious fields needs root. (Also, shouldn't the fields after a certain field rather than before it determines if it needs root, if not only the field itself)\r\n"},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/100448255","html_url":"https://github.com/JuliaLang/julia/pull/11205#issuecomment-100448255","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/11205","id":100448255,"user":{"login":"tkelman","id":5934628,"avatar_url":"https://avatars.githubusercontent.com/u/5934628?v=3","gravatar_id":"","url":"https://api.github.com/users/tkelman","html_url":"https://github.com/tkelman","followers_url":"https://api.github.com/users/tkelman/followers","following_url":"https://api.github.com/users/tkelman/following{/other_user}","gists_url":"https://api.github.com/users/tkelman/gists{/gist_id}","starred_url":"https://api.github.com/users/tkelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkelman/subscriptions","organizations_url":"https://api.github.com/users/tkelman/orgs","repos_url":"https://api.github.com/users/tkelman/repos","events_url":"https://api.github.com/users/tkelman/events{/privacy}","received_events_url":"https://api.github.com/users/tkelman/received_events","type":"User","site_admin":false},"created_at":"2015-05-09T08:31:18Z","updated_at":"2015-05-09T08:31:18Z","body":"Sanitizers too maybe? Might be overkill at that point and/or not play well with everything else being turned on all at the same time."}}