{"action":"created","issue":{"url":"https://api.github.com/repos/datastax/nodejs-driver/issues/87","labels_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/87/labels{/name}","comments_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/87/comments","events_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/87/events","html_url":"https://github.com/datastax/nodejs-driver/pull/87","id":106463298,"number":87,"title":"Manual paging","user":{"login":"krassif","id":1796368,"avatar_url":"https://avatars.githubusercontent.com/u/1796368?v=3","gravatar_id":"","url":"https://api.github.com/users/krassif","html_url":"https://github.com/krassif","followers_url":"https://api.github.com/users/krassif/followers","following_url":"https://api.github.com/users/krassif/following{/other_user}","gists_url":"https://api.github.com/users/krassif/gists{/gist_id}","starred_url":"https://api.github.com/users/krassif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krassif/subscriptions","organizations_url":"https://api.github.com/users/krassif/orgs","repos_url":"https://api.github.com/users/krassif/repos","events_url":"https://api.github.com/users/krassif/events{/privacy}","received_events_url":"https://api.github.com/users/krassif/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jorgebay","id":2931196,"avatar_url":"https://avatars.githubusercontent.com/u/2931196?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgebay","html_url":"https://github.com/jorgebay","followers_url":"https://api.github.com/users/jorgebay/followers","following_url":"https://api.github.com/users/jorgebay/following{/other_user}","gists_url":"https://api.github.com/users/jorgebay/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebay/subscriptions","organizations_url":"https://api.github.com/users/jorgebay/orgs","repos_url":"https://api.github.com/users/jorgebay/repos","events_url":"https://api.github.com/users/jorgebay/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebay/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-09-15T02:15:33Z","updated_at":"2015-09-18T08:53:08Z","closed_at":"2015-09-18T08:53:08Z","pull_request":{"url":"https://api.github.com/repos/datastax/nodejs-driver/pulls/87","html_url":"https://github.com/datastax/nodejs-driver/pull/87","diff_url":"https://github.com/datastax/nodejs-driver/pull/87.diff","patch_url":"https://github.com/datastax/nodejs-driver/pull/87.patch"},"body":"Hi Jorge,\r\n\r\nBeen time since the manual-paging in the eachRow. In addition, we now have throttling in stream.\r\nHopefully, this concludes the manual paging work.\r\n\r\nPlease review and make these part of the official driver release - tired of using two different driver versions in Peerbelt.\r\n\r\nLet me know your thoughts, comments.\r\n\r\nThank you,\r\n-Krassi\r\n\r\n--\r\nThe manual-paging branch is too far behind and the Pull Request looked terrible with 90 or so files to be considered. Closed it and open this one instead.\r\n\r\nPerhaps, you can recreate the branch if we need to work there?!\r\n\r\n--\r\nfeat: support for manual paging:\r\n\tin eachRow via fetchSize option spec, resulting in a nextPage method attached to the resultStats in callback(err, resultStats)\r\n\tin stream, implicitly via the nodejs stream implementation, or again via fetchSize option spec\r\n\r\nfix: according to https://nodejs.org/api/stream.html#stream_readable_push_chunk_encoding:\r\n\t\"if push() returns false, then we need to stop reading from source\", i.e. this.paused = !this.push(this.buffer.shift());"},"comment":{"url":"https://api.github.com/repos/datastax/nodejs-driver/issues/comments/141384826","html_url":"https://github.com/datastax/nodejs-driver/pull/87#issuecomment-141384826","issue_url":"https://api.github.com/repos/datastax/nodejs-driver/issues/87","id":141384826,"user":{"login":"jorgebay","id":2931196,"avatar_url":"https://avatars.githubusercontent.com/u/2931196?v=3","gravatar_id":"","url":"https://api.github.com/users/jorgebay","html_url":"https://github.com/jorgebay","followers_url":"https://api.github.com/users/jorgebay/followers","following_url":"https://api.github.com/users/jorgebay/following{/other_user}","gists_url":"https://api.github.com/users/jorgebay/gists{/gist_id}","starred_url":"https://api.github.com/users/jorgebay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jorgebay/subscriptions","organizations_url":"https://api.github.com/users/jorgebay/orgs","repos_url":"https://api.github.com/users/jorgebay/repos","events_url":"https://api.github.com/users/jorgebay/events{/privacy}","received_events_url":"https://api.github.com/users/jorgebay/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T08:53:08Z","updated_at":"2015-09-18T08:53:08Z","body":"I'm closing this one (master local branch) in favour of #89 "}}