{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/6673","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/6673/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6673/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/6673/events","html_url":"https://github.com/xbmc/xbmc/pull/6673","id":60463507,"number":6673,"title":"[win32] improvements to make-addons.bat","user":{"login":"Montellese","id":75864,"avatar_url":"https://avatars.githubusercontent.com/u/75864?v=3","gravatar_id":"","url":"https://api.github.com/users/Montellese","html_url":"https://github.com/Montellese","followers_url":"https://api.github.com/users/Montellese/followers","following_url":"https://api.github.com/users/Montellese/following{/other_user}","gists_url":"https://api.github.com/users/Montellese/gists{/gist_id}","starred_url":"https://api.github.com/users/Montellese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Montellese/subscriptions","organizations_url":"https://api.github.com/users/Montellese/orgs","repos_url":"https://api.github.com/users/Montellese/repos","events_url":"https://api.github.com/users/Montellese/events{/privacy}","received_events_url":"https://api.github.com/users/Montellese/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-03-10T08:03:22Z","updated_at":"2015-03-10T21:25:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6673","html_url":"https://github.com/xbmc/xbmc/pull/6673","diff_url":"https://github.com/xbmc/xbmc/pull/6673.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6673.patch"},"body":"These three commits add a few improvements to WIN32's buildstep script `make-addons.bat` which we use to build binary addons.\r\n* Possibility to call `make-addons.bat` and pass in the names of multiple binary addons to be built (e.g. `make-addons.bat pvr.demo pvr.vdr.vnsi`). Right now it's only possible to specify a single binary addon to be built.\r\n* `make-addons.bat` doesn't abort anymore if building a single binary addon fails. This is only true for the actual build process. If there's a problem in our (not the binary addon's) buildsystem it will fail completely.\r\n* Successfully built binary addons are written into `project/cmake/addons/.success` and failed ones are written into `project/cmake/addons/.failure`.\r\n\r\n@Memphiz: Let me know if the `.success` and `.failure` file-based approach with one binary addon name/ID per line works for you on jenkins. The files are deleted with every call to `make-addons.bat` and then created when building the addons. If all addons fail to build there's no `.success` and if all addons build fine there's no `.failure` but that could be adjusted that the files always exist but are empty if that's easier for you."},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/78151834","html_url":"https://github.com/xbmc/xbmc/pull/6673#issuecomment-78151834","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6673","id":78151834,"user":{"login":"Memphiz","id":701326,"avatar_url":"https://avatars.githubusercontent.com/u/701326?v=3","gravatar_id":"","url":"https://api.github.com/users/Memphiz","html_url":"https://github.com/Memphiz","followers_url":"https://api.github.com/users/Memphiz/followers","following_url":"https://api.github.com/users/Memphiz/following{/other_user}","gists_url":"https://api.github.com/users/Memphiz/gists{/gist_id}","starred_url":"https://api.github.com/users/Memphiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Memphiz/subscriptions","organizations_url":"https://api.github.com/users/Memphiz/orgs","repos_url":"https://api.github.com/users/Memphiz/repos","events_url":"https://api.github.com/users/Memphiz/events{/privacy}","received_events_url":"https://api.github.com/users/Memphiz/received_events","type":"User","site_admin":false},"created_at":"2015-03-10T21:25:48Z","updated_at":"2015-03-10T21:25:48Z","body":"yes thats all handled. I check for existence of those files before putting its contents to the build result"}}