{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/pandora/pulls/comments/26199880","id":26199880,"diff_hunk":"@@ -17,8 +17,12 @@ logging:\n       customFields:\n         appname: notifications\n redis:\n-  # The redis server's address; required.\n+  # The redis server's address in format: host:port; required.\n   endpoint: localhost:6379\n+  # Password - id needed for authorization; default: \"\"\n+  password:\n+  # URI scheme for redis connection; default: \"redis\"\n+  scheme: redis","path":"service/notifications/src/main/resources/notifications.yaml.sample","position":10,"original_position":10,"commit_id":"107768f68417921a314626b55e6ef12ee409c85f","original_commit_id":"107768f68417921a314626b55e6ef12ee409c85f","user":{"login":"kvas-damian","id":2725894,"avatar_url":"https://avatars.githubusercontent.com/u/2725894?v=3","gravatar_id":"","url":"https://api.github.com/users/kvas-damian","html_url":"https://github.com/kvas-damian","followers_url":"https://api.github.com/users/kvas-damian/followers","following_url":"https://api.github.com/users/kvas-damian/following{/other_user}","gists_url":"https://api.github.com/users/kvas-damian/gists{/gist_id}","starred_url":"https://api.github.com/users/kvas-damian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kvas-damian/subscriptions","organizations_url":"https://api.github.com/users/kvas-damian/orgs","repos_url":"https://api.github.com/users/kvas-damian/repos","events_url":"https://api.github.com/users/kvas-damian/events{/privacy}","received_events_url":"https://api.github.com/users/kvas-damian/received_events","type":"User","site_admin":false},"body":"IMO we should decide on one format.\r\nOr we use full URI as a one field in config or we provide password in separate field and start using ```JedisPool``` contstructor that uses password as a parameter.\r\n\r\nCurrent solution mixes those two which can be confusing in future.\r\n\r\n@rafalkalinski what do you think?","created_at":"2015-03-11T09:59:12Z","updated_at":"2015-03-11T09:59:12Z","html_url":"https://github.com/Wikia/pandora/pull/82#discussion_r26199880","pull_request_url":"https://api.github.com/repos/Wikia/pandora/pulls/82","_links":{"self":{"href":"https://api.github.com/repos/Wikia/pandora/pulls/comments/26199880"},"html":{"href":"https://github.com/Wikia/pandora/pull/82#discussion_r26199880"},"pull_request":{"href":"https://api.github.com/repos/Wikia/pandora/pulls/82"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/pandora/pulls/82","id":30903742,"html_url":"https://github.com/Wikia/pandora/pull/82","diff_url":"https://github.com/Wikia/pandora/pull/82.diff","patch_url":"https://github.com/Wikia/pandora/pull/82.patch","issue_url":"https://api.github.com/repos/Wikia/pandora/issues/82","number":82,"state":"open","locked":false,"title":"connection to redis with authentication","user":{"login":"rafalkalinski","id":783239,"avatar_url":"https://avatars.githubusercontent.com/u/783239?v=3","gravatar_id":"","url":"https://api.github.com/users/rafalkalinski","html_url":"https://github.com/rafalkalinski","followers_url":"https://api.github.com/users/rafalkalinski/followers","following_url":"https://api.github.com/users/rafalkalinski/following{/other_user}","gists_url":"https://api.github.com/users/rafalkalinski/gists{/gist_id}","starred_url":"https://api.github.com/users/rafalkalinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafalkalinski/subscriptions","organizations_url":"https://api.github.com/users/rafalkalinski/orgs","repos_url":"https://api.github.com/users/rafalkalinski/repos","events_url":"https://api.github.com/users/rafalkalinski/events{/privacy}","received_events_url":"https://api.github.com/users/rafalkalinski/received_events","type":"User","site_admin":false},"body":"A couple of new methods and properties to allow using password for Auth field when conencting to redis.","created_at":"2015-03-10T23:40:16Z","updated_at":"2015-03-11T09:59:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd256534aa0dc9f4b6ca26e0dc8f7525d7c08972","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/pandora/pulls/82/commits","review_comments_url":"https://api.github.com/repos/Wikia/pandora/pulls/82/comments","review_comment_url":"https://api.github.com/repos/Wikia/pandora/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/pandora/issues/82/comments","statuses_url":"https://api.github.com/repos/Wikia/pandora/statuses/107768f68417921a314626b55e6ef12ee409c85f","head":{"label":"Wikia:notifications_redis_authorisation","ref":"notifications_redis_authorisation","sha":"107768f68417921a314626b55e6ef12ee409c85f","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":26663749,"name":"pandora","full_name":"Wikia/pandora","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/pandora","description":"API Service","fork":false,"url":"https://api.github.com/repos/Wikia/pandora","forks_url":"https://api.github.com/repos/Wikia/pandora/forks","keys_url":"https://api.github.com/repos/Wikia/pandora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/pandora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/pandora/teams","hooks_url":"https://api.github.com/repos/Wikia/pandora/hooks","issue_events_url":"https://api.github.com/repos/Wikia/pandora/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/pandora/events","assignees_url":"https://api.github.com/repos/Wikia/pandora/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/pandora/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/pandora/tags","blobs_url":"https://api.github.com/repos/Wikia/pandora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/pandora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/pandora/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/pandora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/pandora/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/pandora/languages","stargazers_url":"https://api.github.com/repos/Wikia/pandora/stargazers","contributors_url":"https://api.github.com/repos/Wikia/pandora/contributors","subscribers_url":"https://api.github.com/repos/Wikia/pandora/subscribers","subscription_url":"https://api.github.com/repos/Wikia/pandora/subscription","commits_url":"https://api.github.com/repos/Wikia/pandora/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/pandora/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/pandora/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/pandora/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/pandora/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/pandora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/pandora/merges","archive_url":"https://api.github.com/repos/Wikia/pandora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/pandora/downloads","issues_url":"https://api.github.com/repos/Wikia/pandora/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/pandora/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/pandora/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/pandora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/pandora/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/pandora/releases{/id}","created_at":"2014-11-15T00:29:06Z","updated_at":"2015-03-10T16:50:30Z","pushed_at":"2015-03-11T09:47:49Z","git_url":"git://github.com/Wikia/pandora.git","ssh_url":"git@github.com:Wikia/pandora.git","clone_url":"https://github.com/Wikia/pandora.git","svn_url":"https://github.com/Wikia/pandora","homepage":null,"size":3570,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"Wikia:notifications","ref":"notifications","sha":"eaf6384b8e5738ff1d12424ae86211fd3664919c","user":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":26663749,"name":"pandora","full_name":"Wikia/pandora","owner":{"login":"Wikia","id":1171011,"avatar_url":"https://avatars.githubusercontent.com/u/1171011?v=3","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/pandora","description":"API Service","fork":false,"url":"https://api.github.com/repos/Wikia/pandora","forks_url":"https://api.github.com/repos/Wikia/pandora/forks","keys_url":"https://api.github.com/repos/Wikia/pandora/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/pandora/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/pandora/teams","hooks_url":"https://api.github.com/repos/Wikia/pandora/hooks","issue_events_url":"https://api.github.com/repos/Wikia/pandora/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/pandora/events","assignees_url":"https://api.github.com/repos/Wikia/pandora/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/pandora/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/pandora/tags","blobs_url":"https://api.github.com/repos/Wikia/pandora/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/pandora/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/pandora/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/pandora/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/pandora/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/pandora/languages","stargazers_url":"https://api.github.com/repos/Wikia/pandora/stargazers","contributors_url":"https://api.github.com/repos/Wikia/pandora/contributors","subscribers_url":"https://api.github.com/repos/Wikia/pandora/subscribers","subscription_url":"https://api.github.com/repos/Wikia/pandora/subscription","commits_url":"https://api.github.com/repos/Wikia/pandora/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/pandora/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/pandora/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/pandora/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/pandora/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/pandora/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/pandora/merges","archive_url":"https://api.github.com/repos/Wikia/pandora/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/pandora/downloads","issues_url":"https://api.github.com/repos/Wikia/pandora/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/pandora/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/pandora/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/pandora/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/pandora/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/pandora/releases{/id}","created_at":"2014-11-15T00:29:06Z","updated_at":"2015-03-10T16:50:30Z","pushed_at":"2015-03-11T09:47:49Z","git_url":"git://github.com/Wikia/pandora.git","ssh_url":"git@github.com:Wikia/pandora.git","clone_url":"https://github.com/Wikia/pandora.git","svn_url":"https://github.com/Wikia/pandora","homepage":null,"size":3570,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/pandora/pulls/82"},"html":{"href":"https://github.com/Wikia/pandora/pull/82"},"issue":{"href":"https://api.github.com/repos/Wikia/pandora/issues/82"},"comments":{"href":"https://api.github.com/repos/Wikia/pandora/issues/82/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/pandora/pulls/82/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/pandora/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/pandora/pulls/82/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/pandora/statuses/107768f68417921a314626b55e6ef12ee409c85f"}}}}