{"action":"created","comment":{"url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments/26349437","id":26349437,"diff_hunk":"@@ -231,19 +251,13 @@ private Directory attachDownloadsDirectory() {\n \t\treturn directory;\n \t}\n \n-\tprivate void attachReports(RootRouter router)\n-\t\t\tthrows ConfigurationException, ValidationException {\n+\tprivate void attachReports(RootRouter router) throws ConfigurationException, ValidationException {\n \t\trouter.attach(\"/reports\", new ReportRouter(getContext(), router.getApplication()));\n \t}","path":"jar-service/src/main/java/com/sixsq/slipstream/application/RootApplication.java","position":148,"original_position":148,"commit_id":"3b5c60473e94e6470e2fcdc9807adf445344fc26","original_commit_id":"3b5c60473e94e6470e2fcdc9807adf445344fc26","user":{"login":"konstan","id":353767,"avatar_url":"https://avatars.githubusercontent.com/u/353767?v=3","gravatar_id":"","url":"https://api.github.com/users/konstan","html_url":"https://github.com/konstan","followers_url":"https://api.github.com/users/konstan/followers","following_url":"https://api.github.com/users/konstan/following{/other_user}","gists_url":"https://api.github.com/users/konstan/gists{/gist_id}","starred_url":"https://api.github.com/users/konstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konstan/subscriptions","organizations_url":"https://api.github.com/users/konstan/orgs","repos_url":"https://api.github.com/users/konstan/repos","events_url":"https://api.github.com/users/konstan/events{/privacy}","received_events_url":"https://api.github.com/users/konstan/received_events","type":"User","site_admin":false},"body":"Shouldn't attachReports() follow the introduced pattern and use guardAndAttach() as well?","created_at":"2015-03-12T22:08:41Z","updated_at":"2015-03-12T22:08:41Z","html_url":"https://github.com/slipstream/SlipStreamServer/pull/257#discussion_r26349437","pull_request_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257","_links":{"self":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments/26349437"},"html":{"href":"https://github.com/slipstream/SlipStreamServer/pull/257#discussion_r26349437"},"pull_request":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257"}}},"pull_request":{"url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257","id":30363120,"html_url":"https://github.com/slipstream/SlipStreamServer/pull/257","diff_url":"https://github.com/slipstream/SlipStreamServer/pull/257.diff","patch_url":"https://github.com/slipstream/SlipStreamServer/pull/257.patch","issue_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/257","number":257,"state":"open","locked":false,"title":"Fix #235: /configuration resource doesn't support basic authentication","user":{"login":"schaubl","id":2462866,"avatar_url":"https://avatars.githubusercontent.com/u/2462866?v=3","gravatar_id":"","url":"https://api.github.com/users/schaubl","html_url":"https://github.com/schaubl","followers_url":"https://api.github.com/users/schaubl/followers","following_url":"https://api.github.com/users/schaubl/following{/other_user}","gists_url":"https://api.github.com/users/schaubl/gists{/gist_id}","starred_url":"https://api.github.com/users/schaubl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schaubl/subscriptions","organizations_url":"https://api.github.com/users/schaubl/orgs","repos_url":"https://api.github.com/users/schaubl/repos","events_url":"https://api.github.com/users/schaubl/events{/privacy}","received_events_url":"https://api.github.com/users/schaubl/received_events","type":"User","site_admin":false},"body":"Refactored the RootApplication to make sure all resources are using the same method to attach authenticators.\r\nCorresponding issue #235.","created_at":"2015-03-03T10:48:52Z","updated_at":"2015-03-12T22:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a5223c4f030c95588fc7b2ec45de857ad35de2d","assignee":{"login":"konstan","id":353767,"avatar_url":"https://avatars.githubusercontent.com/u/353767?v=3","gravatar_id":"","url":"https://api.github.com/users/konstan","html_url":"https://github.com/konstan","followers_url":"https://api.github.com/users/konstan/followers","following_url":"https://api.github.com/users/konstan/following{/other_user}","gists_url":"https://api.github.com/users/konstan/gists{/gist_id}","starred_url":"https://api.github.com/users/konstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konstan/subscriptions","organizations_url":"https://api.github.com/users/konstan/orgs","repos_url":"https://api.github.com/users/konstan/repos","events_url":"https://api.github.com/users/konstan/events{/privacy}","received_events_url":"https://api.github.com/users/konstan/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones/9","html_url":"https://github.com/slipstream/SlipStreamServer/milestones/v2.5.0","labels_url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones/9/labels","id":1001823,"number":9,"title":"v2.5.0","description":"Milestone for sprint with target version 2.5.0 (weeks 10 and 11)","creator":{"login":"rbf","id":807084,"avatar_url":"https://avatars.githubusercontent.com/u/807084?v=3","gravatar_id":"","url":"https://api.github.com/users/rbf","html_url":"https://github.com/rbf","followers_url":"https://api.github.com/users/rbf/followers","following_url":"https://api.github.com/users/rbf/following{/other_user}","gists_url":"https://api.github.com/users/rbf/gists{/gist_id}","starred_url":"https://api.github.com/users/rbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbf/subscriptions","organizations_url":"https://api.github.com/users/rbf/orgs","repos_url":"https://api.github.com/users/rbf/repos","events_url":"https://api.github.com/users/rbf/events{/privacy}","received_events_url":"https://api.github.com/users/rbf/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":5,"state":"open","created_at":"2015-03-02T13:17:21Z","updated_at":"2015-03-12T21:57:27Z","due_on":"2015-03-13T12:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257/commits","review_comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257/comments","review_comment_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/257/comments","statuses_url":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/3b5c60473e94e6470e2fcdc9807adf445344fc26","head":{"label":"slipstream:issue_#235","ref":"issue_#235","sha":"3b5c60473e94e6470e2fcdc9807adf445344fc26","user":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"repo":{"id":8266573,"name":"SlipStreamServer","full_name":"slipstream/SlipStreamServer","owner":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slipstream/SlipStreamServer","description":"SlipStream RESTful web service","fork":false,"url":"https://api.github.com/repos/slipstream/SlipStreamServer","forks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/forks","keys_url":"https://api.github.com/repos/slipstream/SlipStreamServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slipstream/SlipStreamServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slipstream/SlipStreamServer/teams","hooks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/hooks","issue_events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/events{/number}","events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/events","assignees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/assignees{/user}","branches_url":"https://api.github.com/repos/slipstream/SlipStreamServer/branches{/branch}","tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/tags","blobs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/{sha}","languages_url":"https://api.github.com/repos/slipstream/SlipStreamServer/languages","stargazers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/stargazers","contributors_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contributors","subscribers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscribers","subscription_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscription","commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contents/{+path}","compare_url":"https://api.github.com/repos/slipstream/SlipStreamServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slipstream/SlipStreamServer/merges","archive_url":"https://api.github.com/repos/slipstream/SlipStreamServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slipstream/SlipStreamServer/downloads","issues_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues{/number}","pulls_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls{/number}","milestones_url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones{/number}","notifications_url":"https://api.github.com/repos/slipstream/SlipStreamServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slipstream/SlipStreamServer/labels{/name}","releases_url":"https://api.github.com/repos/slipstream/SlipStreamServer/releases{/id}","created_at":"2013-02-18T10:48:52Z","updated_at":"2015-03-12T13:06:05Z","pushed_at":"2015-03-12T21:44:57Z","git_url":"git://github.com/slipstream/SlipStreamServer.git","ssh_url":"git@github.com:slipstream/SlipStreamServer.git","clone_url":"https://github.com/slipstream/SlipStreamServer.git","svn_url":"https://github.com/slipstream/SlipStreamServer","homepage":null,"size":11645,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":127,"forks":5,"open_issues":127,"watchers":2,"default_branch":"master"}},"base":{"label":"slipstream:master","ref":"master","sha":"63ac47189617b5d33d1758b544c9bfd15d66ad12","user":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"repo":{"id":8266573,"name":"SlipStreamServer","full_name":"slipstream/SlipStreamServer","owner":{"login":"slipstream","id":3378685,"avatar_url":"https://avatars.githubusercontent.com/u/3378685?v=3","gravatar_id":"","url":"https://api.github.com/users/slipstream","html_url":"https://github.com/slipstream","followers_url":"https://api.github.com/users/slipstream/followers","following_url":"https://api.github.com/users/slipstream/following{/other_user}","gists_url":"https://api.github.com/users/slipstream/gists{/gist_id}","starred_url":"https://api.github.com/users/slipstream/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slipstream/subscriptions","organizations_url":"https://api.github.com/users/slipstream/orgs","repos_url":"https://api.github.com/users/slipstream/repos","events_url":"https://api.github.com/users/slipstream/events{/privacy}","received_events_url":"https://api.github.com/users/slipstream/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slipstream/SlipStreamServer","description":"SlipStream RESTful web service","fork":false,"url":"https://api.github.com/repos/slipstream/SlipStreamServer","forks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/forks","keys_url":"https://api.github.com/repos/slipstream/SlipStreamServer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slipstream/SlipStreamServer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slipstream/SlipStreamServer/teams","hooks_url":"https://api.github.com/repos/slipstream/SlipStreamServer/hooks","issue_events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/events{/number}","events_url":"https://api.github.com/repos/slipstream/SlipStreamServer/events","assignees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/assignees{/user}","branches_url":"https://api.github.com/repos/slipstream/SlipStreamServer/branches{/branch}","tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/tags","blobs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/refs{/sha}","trees_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/{sha}","languages_url":"https://api.github.com/repos/slipstream/SlipStreamServer/languages","stargazers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/stargazers","contributors_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contributors","subscribers_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscribers","subscription_url":"https://api.github.com/repos/slipstream/SlipStreamServer/subscription","commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/commits{/sha}","git_commits_url":"https://api.github.com/repos/slipstream/SlipStreamServer/git/commits{/sha}","comments_url":"https://api.github.com/repos/slipstream/SlipStreamServer/comments{/number}","issue_comment_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/comments{/number}","contents_url":"https://api.github.com/repos/slipstream/SlipStreamServer/contents/{+path}","compare_url":"https://api.github.com/repos/slipstream/SlipStreamServer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slipstream/SlipStreamServer/merges","archive_url":"https://api.github.com/repos/slipstream/SlipStreamServer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slipstream/SlipStreamServer/downloads","issues_url":"https://api.github.com/repos/slipstream/SlipStreamServer/issues{/number}","pulls_url":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls{/number}","milestones_url":"https://api.github.com/repos/slipstream/SlipStreamServer/milestones{/number}","notifications_url":"https://api.github.com/repos/slipstream/SlipStreamServer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slipstream/SlipStreamServer/labels{/name}","releases_url":"https://api.github.com/repos/slipstream/SlipStreamServer/releases{/id}","created_at":"2013-02-18T10:48:52Z","updated_at":"2015-03-12T13:06:05Z","pushed_at":"2015-03-12T21:44:57Z","git_url":"git://github.com/slipstream/SlipStreamServer.git","ssh_url":"git@github.com:slipstream/SlipStreamServer.git","clone_url":"https://github.com/slipstream/SlipStreamServer.git","svn_url":"https://github.com/slipstream/SlipStreamServer","homepage":null,"size":11645,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":127,"forks":5,"open_issues":127,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257"},"html":{"href":"https://github.com/slipstream/SlipStreamServer/pull/257"},"issue":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/257"},"comments":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/slipstream/SlipStreamServer/statuses/3b5c60473e94e6470e2fcdc9807adf445344fc26"}}}}