{"action":"created","issue":{"url":"https://api.github.com/repos/ethereum/web3.js/issues/245","labels_url":"https://api.github.com/repos/ethereum/web3.js/issues/245/labels{/name}","comments_url":"https://api.github.com/repos/ethereum/web3.js/issues/245/comments","events_url":"https://api.github.com/repos/ethereum/web3.js/issues/245/events","html_url":"https://github.com/ethereum/web3.js/pull/245","id":90609151,"number":245,"title":"Add possible callback to filters","user":{"login":"frozeman","id":232662,"avatar_url":"https://avatars.githubusercontent.com/u/232662?v=3","gravatar_id":"","url":"https://api.github.com/users/frozeman","html_url":"https://github.com/frozeman","followers_url":"https://api.github.com/users/frozeman/followers","following_url":"https://api.github.com/users/frozeman/following{/other_user}","gists_url":"https://api.github.com/users/frozeman/gists{/gist_id}","starred_url":"https://api.github.com/users/frozeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frozeman/subscriptions","organizations_url":"https://api.github.com/users/frozeman/orgs","repos_url":"https://api.github.com/users/frozeman/repos","events_url":"https://api.github.com/users/frozeman/events{/privacy}","received_events_url":"https://api.github.com/users/frozeman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-06-24T08:30:26Z","updated_at":"2015-06-24T09:44:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ethereum/web3.js/pulls/245","html_url":"https://github.com/ethereum/web3.js/pull/245","diff_url":"https://github.com/ethereum/web3.js/pull/245.diff","patch_url":"https://github.com/ethereum/web3.js/pull/245.patch"},"body":"This PR allows to pass in a callback directly to the filter to start watching.\r\n\r\nThis is mostly a convenient feature and a common mistake by developers, but should be allowed:\r\n\r\n```js\r\n\r\nweb3.eth.filter({toBlock: 'pending'}, function(e, log){\r\n\r\n})\r\n\r\n// works also for events\r\n\r\nmycontract.MyEvent({}, {toBlock: 'pending'}, function(e, log){\r\n\r\n})\r\n\r\n```"},"comment":{"url":"https://api.github.com/repos/ethereum/web3.js/issues/comments/114808152","html_url":"https://github.com/ethereum/web3.js/pull/245#issuecomment-114808152","issue_url":"https://api.github.com/repos/ethereum/web3.js/issues/245","id":114808152,"user":{"login":"debris","id":2613714,"avatar_url":"https://avatars.githubusercontent.com/u/2613714?v=3","gravatar_id":"","url":"https://api.github.com/users/debris","html_url":"https://github.com/debris","followers_url":"https://api.github.com/users/debris/followers","following_url":"https://api.github.com/users/debris/following{/other_user}","gists_url":"https://api.github.com/users/debris/gists{/gist_id}","starred_url":"https://api.github.com/users/debris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/debris/subscriptions","organizations_url":"https://api.github.com/users/debris/orgs","repos_url":"https://api.github.com/users/debris/repos","events_url":"https://api.github.com/users/debris/events{/privacy}","received_events_url":"https://api.github.com/users/debris/received_events","type":"User","site_admin":false},"created_at":"2015-06-24T09:44:07Z","updated_at":"2015-06-24T09:44:07Z","body":"It's good PR. It simplifies few dirties functions that we had. All the issues are minor and we should merge pr as soon as they are fixed :+1: "}}