{"action":"closed","number":12470,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/12470","id":37997737,"html_url":"https://github.com/modxcms/revolution/pull/12470","diff_url":"https://github.com/modxcms/revolution/pull/12470.diff","patch_url":"https://github.com/modxcms/revolution/pull/12470.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/12470","number":12470,"state":"closed","locked":false,"title":"Enhance and fix configcheck","user":{"login":"inreti","id":2852461,"avatar_url":"https://avatars.githubusercontent.com/u/2852461?v=3","gravatar_id":"","url":"https://api.github.com/users/inreti","html_url":"https://github.com/inreti","followers_url":"https://api.github.com/users/inreti/followers","following_url":"https://api.github.com/users/inreti/following{/other_user}","gists_url":"https://api.github.com/users/inreti/gists{/gist_id}","starred_url":"https://api.github.com/users/inreti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inreti/subscriptions","organizations_url":"https://api.github.com/users/inreti/orgs","repos_url":"https://api.github.com/users/inreti/repos","events_url":"https://api.github.com/users/inreti/events{/privacy}","received_events_url":"https://api.github.com/users/inreti/received_events","type":"User","site_admin":false},"body":"### What does it do ?\r\nIt adds a rule for the configuration check. This rule checks if the PHP version is outdated. The version to check can be set by system setting 'configcheck_min_phpversion', default is 5.3, which is the version MODX is supposed to support now.\r\nA small html bug is also fixed, and styling in the widget is beautified. \r\n\r\n### Why is it needed ?\r\nMODX does not check the PHP version. At least (if not becoming a requirement), it should warn the admins about their outdated environment. This helps to secure MODX sites in the wild.\r\nIt also may reduce support load - the warning message could be enhanced maybe with concrete advices for problems with specific versions. \r\n\r\n![screenshot from 2015-06-15 15 01 15](https://cloud.githubusercontent.com/assets/2852461/8160375/6afcb722-136f-11e5-9c1c-9583017d1f6c.png)\r\n*(Note: versions in the screenshot are only for testing purpose. Default min version is 5.3 in the code)*","created_at":"2015-06-18T11:46:12Z","updated_at":"2015-06-23T10:56:56Z","closed_at":"2015-06-23T10:56:56Z","merged_at":"2015-06-23T10:56:56Z","merge_commit_sha":"804a6f34096ae568daa9634e2d68eb6141e601df","assignee":{"login":"theboxer","id":845220,"avatar_url":"https://avatars.githubusercontent.com/u/845220?v=3","gravatar_id":"","url":"https://api.github.com/users/theboxer","html_url":"https://github.com/theboxer","followers_url":"https://api.github.com/users/theboxer/followers","following_url":"https://api.github.com/users/theboxer/following{/other_user}","gists_url":"https://api.github.com/users/theboxer/gists{/gist_id}","starred_url":"https://api.github.com/users/theboxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theboxer/subscriptions","organizations_url":"https://api.github.com/users/theboxer/orgs","repos_url":"https://api.github.com/users/theboxer/repos","events_url":"https://api.github.com/users/theboxer/events{/privacy}","received_events_url":"https://api.github.com/users/theboxer/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/modxcms/revolution/milestones/57","html_url":"https://github.com/modxcms/revolution/milestones/v2.4.0-pl","labels_url":"https://api.github.com/repos/modxcms/revolution/milestones/57/labels","id":723777,"number":57,"title":"v2.4.0-pl","description":"Features for the next minor release of MODX Revolution 2.x","creator":{"login":"opengeek","id":232812,"avatar_url":"https://avatars.githubusercontent.com/u/232812?v=3","gravatar_id":"","url":"https://api.github.com/users/opengeek","html_url":"https://github.com/opengeek","followers_url":"https://api.github.com/users/opengeek/followers","following_url":"https://api.github.com/users/opengeek/following{/other_user}","gists_url":"https://api.github.com/users/opengeek/gists{/gist_id}","starred_url":"https://api.github.com/users/opengeek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opengeek/subscriptions","organizations_url":"https://api.github.com/users/opengeek/orgs","repos_url":"https://api.github.com/users/opengeek/repos","events_url":"https://api.github.com/users/opengeek/events{/privacy}","received_events_url":"https://api.github.com/users/opengeek/received_events","type":"User","site_admin":false},"open_issues":39,"closed_issues":69,"state":"open","created_at":"2014-07-17T05:06:15Z","updated_at":"2015-06-23T10:56:56Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/12470/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/12470/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/12470/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/47aa419f8b4173fcf28e99435c41160df008ba43","head":{"label":"inreti:fix_configcheck","ref":"fix_configcheck","sha":"47aa419f8b4173fcf28e99435c41160df008ba43","user":{"login":"inreti","id":2852461,"avatar_url":"https://avatars.githubusercontent.com/u/2852461?v=3","gravatar_id":"","url":"https://api.github.com/users/inreti","html_url":"https://github.com/inreti","followers_url":"https://api.github.com/users/inreti/followers","following_url":"https://api.github.com/users/inreti/following{/other_user}","gists_url":"https://api.github.com/users/inreti/gists{/gist_id}","starred_url":"https://api.github.com/users/inreti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inreti/subscriptions","organizations_url":"https://api.github.com/users/inreti/orgs","repos_url":"https://api.github.com/users/inreti/repos","events_url":"https://api.github.com/users/inreti/events{/privacy}","received_events_url":"https://api.github.com/users/inreti/received_events","type":"User","site_admin":false},"repo":{"id":14309731,"name":"revolution","full_name":"inreti/revolution","owner":{"login":"inreti","id":2852461,"avatar_url":"https://avatars.githubusercontent.com/u/2852461?v=3","gravatar_id":"","url":"https://api.github.com/users/inreti","html_url":"https://github.com/inreti","followers_url":"https://api.github.com/users/inreti/followers","following_url":"https://api.github.com/users/inreti/following{/other_user}","gists_url":"https://api.github.com/users/inreti/gists{/gist_id}","starred_url":"https://api.github.com/users/inreti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inreti/subscriptions","organizations_url":"https://api.github.com/users/inreti/orgs","repos_url":"https://api.github.com/users/inreti/repos","events_url":"https://api.github.com/users/inreti/events{/privacy}","received_events_url":"https://api.github.com/users/inreti/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/inreti/revolution","description":"MODx Revolution - Content Application Platform","fork":true,"url":"https://api.github.com/repos/inreti/revolution","forks_url":"https://api.github.com/repos/inreti/revolution/forks","keys_url":"https://api.github.com/repos/inreti/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inreti/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inreti/revolution/teams","hooks_url":"https://api.github.com/repos/inreti/revolution/hooks","issue_events_url":"https://api.github.com/repos/inreti/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/inreti/revolution/events","assignees_url":"https://api.github.com/repos/inreti/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/inreti/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/inreti/revolution/tags","blobs_url":"https://api.github.com/repos/inreti/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inreti/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inreti/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/inreti/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inreti/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/inreti/revolution/languages","stargazers_url":"https://api.github.com/repos/inreti/revolution/stargazers","contributors_url":"https://api.github.com/repos/inreti/revolution/contributors","subscribers_url":"https://api.github.com/repos/inreti/revolution/subscribers","subscription_url":"https://api.github.com/repos/inreti/revolution/subscription","commits_url":"https://api.github.com/repos/inreti/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/inreti/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/inreti/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/inreti/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/inreti/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/inreti/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inreti/revolution/merges","archive_url":"https://api.github.com/repos/inreti/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inreti/revolution/downloads","issues_url":"https://api.github.com/repos/inreti/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/inreti/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/inreti/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/inreti/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inreti/revolution/labels{/name}","releases_url":"https://api.github.com/repos/inreti/revolution/releases{/id}","created_at":"2013-11-11T18:47:20Z","updated_at":"2015-06-15T09:57:17Z","pushed_at":"2015-06-18T11:37:49Z","git_url":"git://github.com/inreti/revolution.git","ssh_url":"git@github.com:inreti/revolution.git","clone_url":"https://github.com/inreti/revolution.git","svn_url":"https://github.com/inreti/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":44181,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"modxcms:develop","ref":"develop","sha":"a23107b5288f86e86b45c0f60df9ea6b2e4f7f1c","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars.githubusercontent.com/u/232723?v=3","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Application Platform","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","created_at":"2010-07-29T21:03:57Z","updated_at":"2015-06-22T16:07:18Z","pushed_at":"2015-06-23T10:56:54Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"http://rtfm.modx.com/revolution/2.x/","size":76981,"stargazers_count":687,"watchers_count":687,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":344,"mirror_url":null,"open_issues_count":949,"forks":344,"open_issues":949,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12470"},"html":{"href":"https://github.com/modxcms/revolution/pull/12470"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12470"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/12470/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12470/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/12470/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/47aa419f8b4173fcf28e99435c41160df008ba43"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"theboxer","id":845220,"avatar_url":"https://avatars.githubusercontent.com/u/845220?v=3","gravatar_id":"","url":"https://api.github.com/users/theboxer","html_url":"https://github.com/theboxer","followers_url":"https://api.github.com/users/theboxer/followers","following_url":"https://api.github.com/users/theboxer/following{/other_user}","gists_url":"https://api.github.com/users/theboxer/gists{/gist_id}","starred_url":"https://api.github.com/users/theboxer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theboxer/subscriptions","organizations_url":"https://api.github.com/users/theboxer/orgs","repos_url":"https://api.github.com/users/theboxer/repos","events_url":"https://api.github.com/users/theboxer/events{/privacy}","received_events_url":"https://api.github.com/users/theboxer/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":8,"additions":41,"deletions":11,"changed_files":3}}