{"action":"created","issue":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/6608","labels_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6608/labels{/name}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6608/comments","events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6608/events","html_url":"https://github.com/joomla/joomla-cms/pull/6608","id":65080664,"number":6608,"title":"Remove code that should be handled via session handlers","user":{"login":"mbabker","id":368545,"avatar_url":"https://avatars.githubusercontent.com/u/368545?v=3","gravatar_id":"","url":"https://api.github.com/users/mbabker","html_url":"https://github.com/mbabker","followers_url":"https://api.github.com/users/mbabker/followers","following_url":"https://api.github.com/users/mbabker/following{/other_user}","gists_url":"https://api.github.com/users/mbabker/gists{/gist_id}","starred_url":"https://api.github.com/users/mbabker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbabker/subscriptions","organizations_url":"https://api.github.com/users/mbabker/orgs","repos_url":"https://api.github.com/users/mbabker/repos","events_url":"https://api.github.com/users/mbabker/events{/privacy}","received_events_url":"https://api.github.com/users/mbabker/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/joomla/joomla-cms/labels/PR-staging","name":"PR-staging","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-03-29T17:31:30Z","updated_at":"2015-06-16T15:21:58Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/6608","html_url":"https://github.com/joomla/joomla-cms/pull/6608","diff_url":"https://github.com/joomla/joomla-cms/pull/6608.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/6608.patch"},"body":"In our application class exists code to clean up dead session data from the database.  This same code exists in the database session handler and is registered to PHP's session management API.  This PR removes the lines from the application class and leaves garbage collection of session data to the session API.\r\n\r\n### Testing Instructions\r\nSo this one's a little more difficult to test.  You'll probably want to manipulate your session configs (see http://php.net/manual/en/function.session-set-save-handler.php and specifically the settings around the `gc` config).  The `gc` callable is called on a randomized basis, so manipulating the settings will make it more controlled.  With the patch applied, expired session data should still be removed from the database; however instead of the application doing it on pretty much every request on an even numbered second, it'll be left to PHP to decide when it's called."},"comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments/112469045","html_url":"https://github.com/joomla/joomla-cms/pull/6608#issuecomment-112469045","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/6608","id":112469045,"user":{"login":"dgt41","id":3889375,"avatar_url":"https://avatars.githubusercontent.com/u/3889375?v=3","gravatar_id":"","url":"https://api.github.com/users/dgt41","html_url":"https://github.com/dgt41","followers_url":"https://api.github.com/users/dgt41/followers","following_url":"https://api.github.com/users/dgt41/following{/other_user}","gists_url":"https://api.github.com/users/dgt41/gists{/gist_id}","starred_url":"https://api.github.com/users/dgt41/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgt41/subscriptions","organizations_url":"https://api.github.com/users/dgt41/orgs","repos_url":"https://api.github.com/users/dgt41/repos","events_url":"https://api.github.com/users/dgt41/events{/privacy}","received_events_url":"https://api.github.com/users/dgt41/received_events","type":"User","site_admin":false},"created_at":"2015-06-16T15:21:58Z","updated_at":"2015-06-16T15:21:58Z","body":"@mbabker some more infos on testing will be really appreciated.\r\nI changed my php.ini to \r\n```ini\r\n[Session]\r\nsession.save_handler = files\r\nsession.save_path = /Applications/MAMP/tmp/php\r\nsession.use_cookies = 1\r\nsession.name = PHPSESSID\r\nsession.auto_start = 0\r\nsession.cookie_lifetime = 0\r\nsession.cookie_path = /\r\nsession.cookie_domain =\r\nsession.serialize_handler = php\r\n\r\nsession.gc_probability = 1\r\nsession.gc_divisor     = 200\r\nsession.gc_maxlifetime = 1440\r\n\r\nsession.bug_compat_42 = 1\r\nsession.bug_compat_warn = 1\r\nsession.referer_check =\r\nsession.entropy_length = 0\r\nsession.entropy_file =\r\nsession.cache_limiter = nocache\r\nsession.cache_expire = 180\r\nsession.use_trans_sid = 0\r\nurl_rewriter.tags = \"a=href,area=href,frame=src,input=src,form=,fieldset=\"\r\n```\r\nbut cannot figure out how to confirm that the session is not updated. PHPMyAmin?"}}