{"action":"created","comment":{"url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments/35578797","id":35578797,"diff_hunk":"@@ -109,9 +109,10 @@ bool Window::configExitGL()\n bool Window::processEvent( const eq::Event& event )\n {\n     seq::Renderer* const renderer = getRenderer();\n-    if( renderer->processEvent( event ))\n-        return true;\n-    return eq::Window::processEvent( event );\n+    \n+    bool successProcess = renderer->processEvent( event );\n+\n+    return eq::Window::processEvent( event ) || successProcess;","path":"seq/detail/window.cpp","position":10,"original_position":10,"commit_id":"89db3a04b73c95c4dcbd1bf51ebc170d45454b93","original_commit_id":"89db3a04b73c95c4dcbd1bf51ebc170d45454b93","user":{"login":"tribal-tec","id":701401,"avatar_url":"https://avatars.githubusercontent.com/u/701401?v=3","gravatar_id":"","url":"https://api.github.com/users/tribal-tec","html_url":"https://github.com/tribal-tec","followers_url":"https://api.github.com/users/tribal-tec/followers","following_url":"https://api.github.com/users/tribal-tec/following{/other_user}","gists_url":"https://api.github.com/users/tribal-tec/gists{/gist_id}","starred_url":"https://api.github.com/users/tribal-tec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tribal-tec/subscriptions","organizations_url":"https://api.github.com/users/tribal-tec/orgs","repos_url":"https://api.github.com/users/tribal-tec/repos","events_url":"https://api.github.com/users/tribal-tec/events{/privacy}","received_events_url":"https://api.github.com/users/tribal-tec/received_events","type":"User","site_admin":false},"body":"I'm not sure about that. That potentially means that one event is handled twice. According to the documentation of Renderer::processEvent(), it should return false if the event is not handled by the renderer, hence it will be forwarded to eq::Window. ","created_at":"2015-07-27T19:55:14Z","updated_at":"2015-07-27T19:55:14Z","html_url":"https://github.com/Eyescale/Equalizer/pull/478#discussion_r35578797","pull_request_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478","_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments/35578797"},"html":{"href":"https://github.com/Eyescale/Equalizer/pull/478#discussion_r35578797"},"pull_request":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478"}}},"pull_request":{"url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478","id":40940756,"html_url":"https://github.com/Eyescale/Equalizer/pull/478","diff_url":"https://github.com/Eyescale/Equalizer/pull/478.diff","patch_url":"https://github.com/Eyescale/Equalizer/pull/478.patch","issue_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/478","number":478,"state":"open","locked":false,"title":"Forward to base window otherwise events are not working properly.","user":{"login":"PetrosKataras","id":1078053,"avatar_url":"https://avatars.githubusercontent.com/u/1078053?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrosKataras","html_url":"https://github.com/PetrosKataras","followers_url":"https://api.github.com/users/PetrosKataras/followers","following_url":"https://api.github.com/users/PetrosKataras/following{/other_user}","gists_url":"https://api.github.com/users/PetrosKataras/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrosKataras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrosKataras/subscriptions","organizations_url":"https://api.github.com/users/PetrosKataras/orgs","repos_url":"https://api.github.com/users/PetrosKataras/repos","events_url":"https://api.github.com/users/PetrosKataras/events{/privacy}","received_events_url":"https://api.github.com/users/PetrosKataras/received_events","type":"User","site_admin":false},"body":"Fixes petroskataras/stardust#2 .","created_at":"2015-07-27T19:38:54Z","updated_at":"2015-07-27T19:55:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6fdb61cd189f9e94d278cfaebede3296cb4f51a8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478/commits","review_comments_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478/comments","review_comment_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/478/comments","statuses_url":"https://api.github.com/repos/Eyescale/Equalizer/statuses/89db3a04b73c95c4dcbd1bf51ebc170d45454b93","head":{"label":"PetrosKataras:master","ref":"master","sha":"89db3a04b73c95c4dcbd1bf51ebc170d45454b93","user":{"login":"PetrosKataras","id":1078053,"avatar_url":"https://avatars.githubusercontent.com/u/1078053?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrosKataras","html_url":"https://github.com/PetrosKataras","followers_url":"https://api.github.com/users/PetrosKataras/followers","following_url":"https://api.github.com/users/PetrosKataras/following{/other_user}","gists_url":"https://api.github.com/users/PetrosKataras/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrosKataras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrosKataras/subscriptions","organizations_url":"https://api.github.com/users/PetrosKataras/orgs","repos_url":"https://api.github.com/users/PetrosKataras/repos","events_url":"https://api.github.com/users/PetrosKataras/events{/privacy}","received_events_url":"https://api.github.com/users/PetrosKataras/received_events","type":"User","site_admin":false},"repo":{"id":32669973,"name":"Equalizer","full_name":"PetrosKataras/Equalizer","owner":{"login":"PetrosKataras","id":1078053,"avatar_url":"https://avatars.githubusercontent.com/u/1078053?v=3","gravatar_id":"","url":"https://api.github.com/users/PetrosKataras","html_url":"https://github.com/PetrosKataras","followers_url":"https://api.github.com/users/PetrosKataras/followers","following_url":"https://api.github.com/users/PetrosKataras/following{/other_user}","gists_url":"https://api.github.com/users/PetrosKataras/gists{/gist_id}","starred_url":"https://api.github.com/users/PetrosKataras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PetrosKataras/subscriptions","organizations_url":"https://api.github.com/users/PetrosKataras/orgs","repos_url":"https://api.github.com/users/PetrosKataras/repos","events_url":"https://api.github.com/users/PetrosKataras/events{/privacy}","received_events_url":"https://api.github.com/users/PetrosKataras/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PetrosKataras/Equalizer","description":"Equalizer is the standard middleware to create and deploy parallel OpenGL-based applications. It enables applications to benefit from multiple graphics cards, processors and computers to scale the rendering performance, visual quality and display size. An Equalizer application runs unmodified on any visualization system, from a simple workstation to large scale graphics clusters, multi-GPU workstations and Virtual Reality installations.  ","fork":true,"url":"https://api.github.com/repos/PetrosKataras/Equalizer","forks_url":"https://api.github.com/repos/PetrosKataras/Equalizer/forks","keys_url":"https://api.github.com/repos/PetrosKataras/Equalizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PetrosKataras/Equalizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PetrosKataras/Equalizer/teams","hooks_url":"https://api.github.com/repos/PetrosKataras/Equalizer/hooks","issue_events_url":"https://api.github.com/repos/PetrosKataras/Equalizer/issues/events{/number}","events_url":"https://api.github.com/repos/PetrosKataras/Equalizer/events","assignees_url":"https://api.github.com/repos/PetrosKataras/Equalizer/assignees{/user}","branches_url":"https://api.github.com/repos/PetrosKataras/Equalizer/branches{/branch}","tags_url":"https://api.github.com/repos/PetrosKataras/Equalizer/tags","blobs_url":"https://api.github.com/repos/PetrosKataras/Equalizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PetrosKataras/Equalizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PetrosKataras/Equalizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/PetrosKataras/Equalizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PetrosKataras/Equalizer/statuses/{sha}","languages_url":"https://api.github.com/repos/PetrosKataras/Equalizer/languages","stargazers_url":"https://api.github.com/repos/PetrosKataras/Equalizer/stargazers","contributors_url":"https://api.github.com/repos/PetrosKataras/Equalizer/contributors","subscribers_url":"https://api.github.com/repos/PetrosKataras/Equalizer/subscribers","subscription_url":"https://api.github.com/repos/PetrosKataras/Equalizer/subscription","commits_url":"https://api.github.com/repos/PetrosKataras/Equalizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/PetrosKataras/Equalizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/PetrosKataras/Equalizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/PetrosKataras/Equalizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/PetrosKataras/Equalizer/contents/{+path}","compare_url":"https://api.github.com/repos/PetrosKataras/Equalizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PetrosKataras/Equalizer/merges","archive_url":"https://api.github.com/repos/PetrosKataras/Equalizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PetrosKataras/Equalizer/downloads","issues_url":"https://api.github.com/repos/PetrosKataras/Equalizer/issues{/number}","pulls_url":"https://api.github.com/repos/PetrosKataras/Equalizer/pulls{/number}","milestones_url":"https://api.github.com/repos/PetrosKataras/Equalizer/milestones{/number}","notifications_url":"https://api.github.com/repos/PetrosKataras/Equalizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PetrosKataras/Equalizer/labels{/name}","releases_url":"https://api.github.com/repos/PetrosKataras/Equalizer/releases{/id}","created_at":"2015-03-22T09:49:23Z","updated_at":"2015-05-03T12:52:31Z","pushed_at":"2015-07-27T19:31:25Z","git_url":"git://github.com/PetrosKataras/Equalizer.git","ssh_url":"git@github.com:PetrosKataras/Equalizer.git","clone_url":"https://github.com/PetrosKataras/Equalizer.git","svn_url":"https://github.com/PetrosKataras/Equalizer","homepage":"http://www.equalizergraphics.com","size":65423,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Eyescale:master","ref":"master","sha":"139fe839274a9525b0f17404e8c94ae53b4e3628","user":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"repo":{"id":1536948,"name":"Equalizer","full_name":"Eyescale/Equalizer","owner":{"login":"Eyescale","id":354955,"avatar_url":"https://avatars.githubusercontent.com/u/354955?v=3","gravatar_id":"","url":"https://api.github.com/users/Eyescale","html_url":"https://github.com/Eyescale","followers_url":"https://api.github.com/users/Eyescale/followers","following_url":"https://api.github.com/users/Eyescale/following{/other_user}","gists_url":"https://api.github.com/users/Eyescale/gists{/gist_id}","starred_url":"https://api.github.com/users/Eyescale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eyescale/subscriptions","organizations_url":"https://api.github.com/users/Eyescale/orgs","repos_url":"https://api.github.com/users/Eyescale/repos","events_url":"https://api.github.com/users/Eyescale/events{/privacy}","received_events_url":"https://api.github.com/users/Eyescale/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Eyescale/Equalizer","description":"Equalizer is the standard middleware to create and deploy parallel OpenGL-based applications. It enables applications to benefit from multiple graphics cards, processors and computers to scale the rendering performance, visual quality and display size. An Equalizer application runs unmodified on any visualization system, from a simple workstation to large scale graphics clusters, multi-GPU workstations and Virtual Reality installations.  ","fork":false,"url":"https://api.github.com/repos/Eyescale/Equalizer","forks_url":"https://api.github.com/repos/Eyescale/Equalizer/forks","keys_url":"https://api.github.com/repos/Eyescale/Equalizer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eyescale/Equalizer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eyescale/Equalizer/teams","hooks_url":"https://api.github.com/repos/Eyescale/Equalizer/hooks","issue_events_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/events{/number}","events_url":"https://api.github.com/repos/Eyescale/Equalizer/events","assignees_url":"https://api.github.com/repos/Eyescale/Equalizer/assignees{/user}","branches_url":"https://api.github.com/repos/Eyescale/Equalizer/branches{/branch}","tags_url":"https://api.github.com/repos/Eyescale/Equalizer/tags","blobs_url":"https://api.github.com/repos/Eyescale/Equalizer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eyescale/Equalizer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eyescale/Equalizer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eyescale/Equalizer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eyescale/Equalizer/statuses/{sha}","languages_url":"https://api.github.com/repos/Eyescale/Equalizer/languages","stargazers_url":"https://api.github.com/repos/Eyescale/Equalizer/stargazers","contributors_url":"https://api.github.com/repos/Eyescale/Equalizer/contributors","subscribers_url":"https://api.github.com/repos/Eyescale/Equalizer/subscribers","subscription_url":"https://api.github.com/repos/Eyescale/Equalizer/subscription","commits_url":"https://api.github.com/repos/Eyescale/Equalizer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eyescale/Equalizer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eyescale/Equalizer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eyescale/Equalizer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eyescale/Equalizer/contents/{+path}","compare_url":"https://api.github.com/repos/Eyescale/Equalizer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eyescale/Equalizer/merges","archive_url":"https://api.github.com/repos/Eyescale/Equalizer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eyescale/Equalizer/downloads","issues_url":"https://api.github.com/repos/Eyescale/Equalizer/issues{/number}","pulls_url":"https://api.github.com/repos/Eyescale/Equalizer/pulls{/number}","milestones_url":"https://api.github.com/repos/Eyescale/Equalizer/milestones{/number}","notifications_url":"https://api.github.com/repos/Eyescale/Equalizer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eyescale/Equalizer/labels{/name}","releases_url":"https://api.github.com/repos/Eyescale/Equalizer/releases{/id}","created_at":"2011-03-28T14:41:53Z","updated_at":"2015-05-17T13:06:09Z","pushed_at":"2015-07-27T19:38:55Z","git_url":"git://github.com/Eyescale/Equalizer.git","ssh_url":"git@github.com:Eyescale/Equalizer.git","clone_url":"https://github.com/Eyescale/Equalizer.git","svn_url":"https://github.com/Eyescale/Equalizer","homepage":"http://www.equalizergraphics.com","size":77699,"stargazers_count":94,"watchers_count":94,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":56,"forks":63,"open_issues":56,"watchers":94,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478"},"html":{"href":"https://github.com/Eyescale/Equalizer/pull/478"},"issue":{"href":"https://api.github.com/repos/Eyescale/Equalizer/issues/478"},"comments":{"href":"https://api.github.com/repos/Eyescale/Equalizer/issues/478/comments"},"review_comments":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478/comments"},"review_comment":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Eyescale/Equalizer/pulls/478/commits"},"statuses":{"href":"https://api.github.com/repos/Eyescale/Equalizer/statuses/89db3a04b73c95c4dcbd1bf51ebc170d45454b93"}}}}