{"action":"created","comment":{"url":"https://api.github.com/repos/Patternslib/Patterns/pulls/comments/39947425","id":39947425,"diff_hunk":"@@ -37,7 +37,7 @@ define([\n \n     var _ = {\n         name: \"inject\",\n-        trigger: \"a.pat-inject, form.pat-inject, .pat-subform.pat-inject\",\n+        trigger: \".ui-button.pat-inject, a.pat-inject, form.pat-inject, .pat-subform.pat-inject\",\n         init: function inject_init($el, opts) {","path":"src/pat/inject/inject.js","position":6,"original_position":6,"commit_id":"57124f8d810b85e7aeccdaf242cf334e7e41e863","original_commit_id":"57124f8d810b85e7aeccdaf242cf334e7e41e863","user":{"login":"jcbrand","id":683911,"avatar_url":"https://avatars.githubusercontent.com/u/683911?v=3","gravatar_id":"","url":"https://api.github.com/users/jcbrand","html_url":"https://github.com/jcbrand","followers_url":"https://api.github.com/users/jcbrand/followers","following_url":"https://api.github.com/users/jcbrand/following{/other_user}","gists_url":"https://api.github.com/users/jcbrand/gists{/gist_id}","starred_url":"https://api.github.com/users/jcbrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcbrand/subscriptions","organizations_url":"https://api.github.com/users/jcbrand/orgs","repos_url":"https://api.github.com/users/jcbrand/repos","events_url":"https://api.github.com/users/jcbrand/events{/privacy}","received_events_url":"https://api.github.com/users/jcbrand/received_events","type":"User","site_admin":false},"body":"The use of `.ui-button` here bothers me. AFAIK this is not a Patternslib class and it's not documented anywhere either. There's nothing intuitive about it.\r\n\r\nWhat kind of markup are you trying to support here?","created_at":"2015-09-21T07:59:02Z","updated_at":"2015-09-21T07:59:02Z","html_url":"https://github.com/Patternslib/Patterns/pull/413#discussion_r39947425","pull_request_url":"https://api.github.com/repos/Patternslib/Patterns/pulls/413","_links":{"self":{"href":"https://api.github.com/repos/Patternslib/Patterns/pulls/comments/39947425"},"html":{"href":"https://github.com/Patternslib/Patterns/pull/413#discussion_r39947425"},"pull_request":{"href":"https://api.github.com/repos/Patternslib/Patterns/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/Patternslib/Patterns/pulls/413","id":45496216,"html_url":"https://github.com/Patternslib/Patterns/pull/413","diff_url":"https://github.com/Patternslib/Patterns/pull/413.diff","patch_url":"https://github.com/Patternslib/Patterns/pull/413.patch","issue_url":"https://api.github.com/repos/Patternslib/Patterns/issues/413","number":413,"state":"open","locked":false,"title":"tooltip and inject changes","user":{"login":"garbas","id":20208,"avatar_url":"https://avatars.githubusercontent.com/u/20208?v=3","gravatar_id":"","url":"https://api.github.com/users/garbas","html_url":"https://github.com/garbas","followers_url":"https://api.github.com/users/garbas/followers","following_url":"https://api.github.com/users/garbas/following{/other_user}","gists_url":"https://api.github.com/users/garbas/gists{/gist_id}","starred_url":"https://api.github.com/users/garbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbas/subscriptions","organizations_url":"https://api.github.com/users/garbas/orgs","repos_url":"https://api.github.com/users/garbas/repos","events_url":"https://api.github.com/users/garbas/events{/privacy}","received_events_url":"https://api.github.com/users/garbas/received_events","type":"User","site_admin":false},"body":"i would love to get some comments what i'm doing is in line with patternslib plans.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/patternslib/patterns/413)\n<!-- Reviewable:end -->\n","created_at":"2015-09-20T13:19:30Z","updated_at":"2015-09-21T07:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c26003195a6d86b460d162703ca674ef3d68d4f0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Patternslib/Patterns/pulls/413/commits","review_comments_url":"https://api.github.com/repos/Patternslib/Patterns/pulls/413/comments","review_comment_url":"https://api.github.com/repos/Patternslib/Patterns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Patternslib/Patterns/issues/413/comments","statuses_url":"https://api.github.com/repos/Patternslib/Patterns/statuses/57124f8d810b85e7aeccdaf242cf334e7e41e863","head":{"label":"garbas:master","ref":"master","sha":"57124f8d810b85e7aeccdaf242cf334e7e41e863","user":{"login":"garbas","id":20208,"avatar_url":"https://avatars.githubusercontent.com/u/20208?v=3","gravatar_id":"","url":"https://api.github.com/users/garbas","html_url":"https://github.com/garbas","followers_url":"https://api.github.com/users/garbas/followers","following_url":"https://api.github.com/users/garbas/following{/other_user}","gists_url":"https://api.github.com/users/garbas/gists{/gist_id}","starred_url":"https://api.github.com/users/garbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbas/subscriptions","organizations_url":"https://api.github.com/users/garbas/orgs","repos_url":"https://api.github.com/users/garbas/repos","events_url":"https://api.github.com/users/garbas/events{/privacy}","received_events_url":"https://api.github.com/users/garbas/received_events","type":"User","site_admin":false},"repo":{"id":8260446,"name":"Patterns","full_name":"garbas/Patterns","owner":{"login":"garbas","id":20208,"avatar_url":"https://avatars.githubusercontent.com/u/20208?v=3","gravatar_id":"","url":"https://api.github.com/users/garbas","html_url":"https://github.com/garbas","followers_url":"https://api.github.com/users/garbas/followers","following_url":"https://api.github.com/users/garbas/following{/other_user}","gists_url":"https://api.github.com/users/garbas/gists{/gist_id}","starred_url":"https://api.github.com/users/garbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbas/subscriptions","organizations_url":"https://api.github.com/users/garbas/orgs","repos_url":"https://api.github.com/users/garbas/repos","events_url":"https://api.github.com/users/garbas/events{/privacy}","received_events_url":"https://api.github.com/users/garbas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garbas/Patterns","description":"Library for quickly applying rich interaction patterns without the need to write any JavaScript.","fork":true,"url":"https://api.github.com/repos/garbas/Patterns","forks_url":"https://api.github.com/repos/garbas/Patterns/forks","keys_url":"https://api.github.com/repos/garbas/Patterns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garbas/Patterns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garbas/Patterns/teams","hooks_url":"https://api.github.com/repos/garbas/Patterns/hooks","issue_events_url":"https://api.github.com/repos/garbas/Patterns/issues/events{/number}","events_url":"https://api.github.com/repos/garbas/Patterns/events","assignees_url":"https://api.github.com/repos/garbas/Patterns/assignees{/user}","branches_url":"https://api.github.com/repos/garbas/Patterns/branches{/branch}","tags_url":"https://api.github.com/repos/garbas/Patterns/tags","blobs_url":"https://api.github.com/repos/garbas/Patterns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garbas/Patterns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garbas/Patterns/git/refs{/sha}","trees_url":"https://api.github.com/repos/garbas/Patterns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garbas/Patterns/statuses/{sha}","languages_url":"https://api.github.com/repos/garbas/Patterns/languages","stargazers_url":"https://api.github.com/repos/garbas/Patterns/stargazers","contributors_url":"https://api.github.com/repos/garbas/Patterns/contributors","subscribers_url":"https://api.github.com/repos/garbas/Patterns/subscribers","subscription_url":"https://api.github.com/repos/garbas/Patterns/subscription","commits_url":"https://api.github.com/repos/garbas/Patterns/commits{/sha}","git_commits_url":"https://api.github.com/repos/garbas/Patterns/git/commits{/sha}","comments_url":"https://api.github.com/repos/garbas/Patterns/comments{/number}","issue_comment_url":"https://api.github.com/repos/garbas/Patterns/issues/comments{/number}","contents_url":"https://api.github.com/repos/garbas/Patterns/contents/{+path}","compare_url":"https://api.github.com/repos/garbas/Patterns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garbas/Patterns/merges","archive_url":"https://api.github.com/repos/garbas/Patterns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garbas/Patterns/downloads","issues_url":"https://api.github.com/repos/garbas/Patterns/issues{/number}","pulls_url":"https://api.github.com/repos/garbas/Patterns/pulls{/number}","milestones_url":"https://api.github.com/repos/garbas/Patterns/milestones{/number}","notifications_url":"https://api.github.com/repos/garbas/Patterns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garbas/Patterns/labels{/name}","releases_url":"https://api.github.com/repos/garbas/Patterns/releases{/id}","created_at":"2013-02-18T02:41:54Z","updated_at":"2015-09-08T14:39:31Z","pushed_at":"2015-09-20T13:13:39Z","git_url":"git://github.com/garbas/Patterns.git","ssh_url":"git@github.com:garbas/Patterns.git","clone_url":"https://github.com/garbas/Patterns.git","svn_url":"https://github.com/garbas/Patterns","homepage":"http://patternslib.com","size":43882,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Patternslib:master","ref":"master","sha":"6872c52f00d9aca1b31d3e7ce8ef918f349da8e1","user":{"login":"Patternslib","id":2392399,"avatar_url":"https://avatars.githubusercontent.com/u/2392399?v=3","gravatar_id":"","url":"https://api.github.com/users/Patternslib","html_url":"https://github.com/Patternslib","followers_url":"https://api.github.com/users/Patternslib/followers","following_url":"https://api.github.com/users/Patternslib/following{/other_user}","gists_url":"https://api.github.com/users/Patternslib/gists{/gist_id}","starred_url":"https://api.github.com/users/Patternslib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patternslib/subscriptions","organizations_url":"https://api.github.com/users/Patternslib/orgs","repos_url":"https://api.github.com/users/Patternslib/repos","events_url":"https://api.github.com/users/Patternslib/events{/privacy}","received_events_url":"https://api.github.com/users/Patternslib/received_events","type":"Organization","site_admin":false},"repo":{"id":2066292,"name":"Patterns","full_name":"Patternslib/Patterns","owner":{"login":"Patternslib","id":2392399,"avatar_url":"https://avatars.githubusercontent.com/u/2392399?v=3","gravatar_id":"","url":"https://api.github.com/users/Patternslib","html_url":"https://github.com/Patternslib","followers_url":"https://api.github.com/users/Patternslib/followers","following_url":"https://api.github.com/users/Patternslib/following{/other_user}","gists_url":"https://api.github.com/users/Patternslib/gists{/gist_id}","starred_url":"https://api.github.com/users/Patternslib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patternslib/subscriptions","organizations_url":"https://api.github.com/users/Patternslib/orgs","repos_url":"https://api.github.com/users/Patternslib/repos","events_url":"https://api.github.com/users/Patternslib/events{/privacy}","received_events_url":"https://api.github.com/users/Patternslib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Patternslib/Patterns","description":"Library for quickly applying rich interaction patterns without the need to write any JavaScript.","fork":false,"url":"https://api.github.com/repos/Patternslib/Patterns","forks_url":"https://api.github.com/repos/Patternslib/Patterns/forks","keys_url":"https://api.github.com/repos/Patternslib/Patterns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Patternslib/Patterns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Patternslib/Patterns/teams","hooks_url":"https://api.github.com/repos/Patternslib/Patterns/hooks","issue_events_url":"https://api.github.com/repos/Patternslib/Patterns/issues/events{/number}","events_url":"https://api.github.com/repos/Patternslib/Patterns/events","assignees_url":"https://api.github.com/repos/Patternslib/Patterns/assignees{/user}","branches_url":"https://api.github.com/repos/Patternslib/Patterns/branches{/branch}","tags_url":"https://api.github.com/repos/Patternslib/Patterns/tags","blobs_url":"https://api.github.com/repos/Patternslib/Patterns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Patternslib/Patterns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Patternslib/Patterns/git/refs{/sha}","trees_url":"https://api.github.com/repos/Patternslib/Patterns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Patternslib/Patterns/statuses/{sha}","languages_url":"https://api.github.com/repos/Patternslib/Patterns/languages","stargazers_url":"https://api.github.com/repos/Patternslib/Patterns/stargazers","contributors_url":"https://api.github.com/repos/Patternslib/Patterns/contributors","subscribers_url":"https://api.github.com/repos/Patternslib/Patterns/subscribers","subscription_url":"https://api.github.com/repos/Patternslib/Patterns/subscription","commits_url":"https://api.github.com/repos/Patternslib/Patterns/commits{/sha}","git_commits_url":"https://api.github.com/repos/Patternslib/Patterns/git/commits{/sha}","comments_url":"https://api.github.com/repos/Patternslib/Patterns/comments{/number}","issue_comment_url":"https://api.github.com/repos/Patternslib/Patterns/issues/comments{/number}","contents_url":"https://api.github.com/repos/Patternslib/Patterns/contents/{+path}","compare_url":"https://api.github.com/repos/Patternslib/Patterns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Patternslib/Patterns/merges","archive_url":"https://api.github.com/repos/Patternslib/Patterns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Patternslib/Patterns/downloads","issues_url":"https://api.github.com/repos/Patternslib/Patterns/issues{/number}","pulls_url":"https://api.github.com/repos/Patternslib/Patterns/pulls{/number}","milestones_url":"https://api.github.com/repos/Patternslib/Patterns/milestones{/number}","notifications_url":"https://api.github.com/repos/Patternslib/Patterns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Patternslib/Patterns/labels{/name}","releases_url":"https://api.github.com/repos/Patternslib/Patterns/releases{/id}","created_at":"2011-07-18T13:05:37Z","updated_at":"2015-08-04T15:14:27Z","pushed_at":"2015-09-20T13:20:11Z","git_url":"git://github.com/Patternslib/Patterns.git","ssh_url":"git@github.com:Patternslib/Patterns.git","clone_url":"https://github.com/Patternslib/Patterns.git","svn_url":"https://github.com/Patternslib/Patterns","homepage":"http://patternslib.com","size":53589,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":26,"forks":22,"open_issues":26,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Patternslib/Patterns/pulls/413"},"html":{"href":"https://github.com/Patternslib/Patterns/pull/413"},"issue":{"href":"https://api.github.com/repos/Patternslib/Patterns/issues/413"},"comments":{"href":"https://api.github.com/repos/Patternslib/Patterns/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/Patternslib/Patterns/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/Patternslib/Patterns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Patternslib/Patterns/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/Patternslib/Patterns/statuses/57124f8d810b85e7aeccdaf242cf334e7e41e863"}}}}