{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/39772248","id":39772248,"diff_hunk":"@@ -44,11 +40,17 @@ match the last ip to see if it is in defined network\n =cut\n \n sub match {\n-    my ($self,$data) = @_;\n-    my $last_ip = $data->{last_ip} if exists $data->{last_ip};\n-    return defined $last_ip && $self->value->contains(NetAddr::IP->new($last_ip));\n+    my ($self,$ip) = @_;\n+    return 0 unless defined $ip;\n+    my $ip_addr;\n+    eval {\n+        $ip_addr = NetAddr::IP->new($ip);\n+    };\n+    return 0 unless defined $ip_addr;","path":"lib/pf/condition/network.pm","position":63,"original_position":63,"commit_id":"59c2578093ae0f3ea7f2025ad9b9de080bbe5976","original_commit_id":"59c2578093ae0f3ea7f2025ad9b9de080bbe5976","user":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"body":"$FALSE","created_at":"2015-09-17T17:16:33Z","updated_at":"2015-09-17T17:16:33Z","html_url":"https://github.com/inverse-inc/packetfence/pull/594#discussion_r39772248","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/39772248"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/594#discussion_r39772248"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594","id":36154914,"html_url":"https://github.com/inverse-inc/packetfence/pull/594","diff_url":"https://github.com/inverse-inc/packetfence/pull/594.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/594.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/594","number":594,"state":"open","locked":false,"title":"The new filter engine","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"body":"Description\r\n-----------\r\nA generalize filtering engine\r\n\r\nImpacts\r\n-------\r\nProfile filters, vlan filters, apache filters\r\n\r\nNEWS file entries\r\n-------\r\nNew Features\r\n++++++++++++\r\n\r\nEnhancements\r\n++++++++++++\r\n* Move filtering of profile to the filter engine\r\n\r\nBug Fixes\r\n+++++++++\r\n\r\nDelete branch after merge\r\n-------------------------\r\nNO\r\n\r\nUPGRADE NOTES\r\n-------------------------\r\nThe profile filter format must be the following.\r\ntype:data\r\nWill no longer support filters with just data\r\n\r\nGood filter format\r\n\r\n```\r\n[bob]\r\n...\r\nfilter=ssid:bob,ssid:bobby,ssid:robert\r\n...\r\n```\r\nBad filter format\r\n\r\n```\r\n[bob]\r\n...\r\nfilter=bob,bobby,robert\r\n...\r\n```\r\n\r\n","created_at":"2015-05-25T19:35:48Z","updated_at":"2015-09-17T17:16:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4ea605d8cfefc2163b022b95ba7fbbd8a9842f0","assignee":{"login":"julsemaan","id":3857942,"avatar_url":"https://avatars.githubusercontent.com/u/3857942?v=3","gravatar_id":"","url":"https://api.github.com/users/julsemaan","html_url":"https://github.com/julsemaan","followers_url":"https://api.github.com/users/julsemaan/followers","following_url":"https://api.github.com/users/julsemaan/following{/other_user}","gists_url":"https://api.github.com/users/julsemaan/gists{/gist_id}","starred_url":"https://api.github.com/users/julsemaan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julsemaan/subscriptions","organizations_url":"https://api.github.com/users/julsemaan/orgs","repos_url":"https://api.github.com/users/julsemaan/repos","events_url":"https://api.github.com/users/julsemaan/events{/privacy}","received_events_url":"https://api.github.com/users/julsemaan/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/9","html_url":"https://github.com/inverse-inc/packetfence/milestones/PacketFence-5.4","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones/9/labels","id":1185948,"number":9,"title":"PacketFence-5.4","description":"","creator":{"login":"louismunro","id":193997,"avatar_url":"https://avatars.githubusercontent.com/u/193997?v=3","gravatar_id":"","url":"https://api.github.com/users/louismunro","html_url":"https://github.com/louismunro","followers_url":"https://api.github.com/users/louismunro/followers","following_url":"https://api.github.com/users/louismunro/following{/other_user}","gists_url":"https://api.github.com/users/louismunro/gists{/gist_id}","starred_url":"https://api.github.com/users/louismunro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louismunro/subscriptions","organizations_url":"https://api.github.com/users/louismunro/orgs","repos_url":"https://api.github.com/users/louismunro/repos","events_url":"https://api.github.com/users/louismunro/events{/privacy}","received_events_url":"https://api.github.com/users/louismunro/received_events","type":"User","site_admin":false},"open_issues":67,"closed_issues":31,"state":"open","created_at":"2015-06-29T19:23:15Z","updated_at":"2015-09-17T16:20:13Z","due_on":"2015-09-14T04:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/594/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/59c2578093ae0f3ea7f2025ad9b9de080bbe5976","head":{"label":"jrouzierinverse:feature/filter-engine","ref":"feature/filter-engine","sha":"59c2578093ae0f3ea7f2025ad9b9de080bbe5976","user":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"repo":{"id":6552051,"name":"packetfence","full_name":"jrouzierinverse/packetfence","owner":{"login":"jrouzierinverse","id":2727473,"avatar_url":"https://avatars.githubusercontent.com/u/2727473?v=3","gravatar_id":"","url":"https://api.github.com/users/jrouzierinverse","html_url":"https://github.com/jrouzierinverse","followers_url":"https://api.github.com/users/jrouzierinverse/followers","following_url":"https://api.github.com/users/jrouzierinverse/following{/other_user}","gists_url":"https://api.github.com/users/jrouzierinverse/gists{/gist_id}","starred_url":"https://api.github.com/users/jrouzierinverse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrouzierinverse/subscriptions","organizations_url":"https://api.github.com/users/jrouzierinverse/orgs","repos_url":"https://api.github.com/users/jrouzierinverse/repos","events_url":"https://api.github.com/users/jrouzierinverse/events{/privacy}","received_events_url":"https://api.github.com/users/jrouzierinverse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jrouzierinverse/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/jrouzierinverse/packetfence","forks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/forks","keys_url":"https://api.github.com/repos/jrouzierinverse/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jrouzierinverse/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jrouzierinverse/packetfence/teams","hooks_url":"https://api.github.com/repos/jrouzierinverse/packetfence/hooks","issue_events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/jrouzierinverse/packetfence/events","assignees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/jrouzierinverse/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/tags","blobs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jrouzierinverse/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/jrouzierinverse/packetfence/languages","stargazers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/stargazers","contributors_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contributors","subscribers_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscribers","subscription_url":"https://api.github.com/repos/jrouzierinverse/packetfence/subscription","commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/jrouzierinverse/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/jrouzierinverse/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/jrouzierinverse/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/jrouzierinverse/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jrouzierinverse/packetfence/merges","archive_url":"https://api.github.com/repos/jrouzierinverse/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jrouzierinverse/packetfence/downloads","issues_url":"https://api.github.com/repos/jrouzierinverse/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/jrouzierinverse/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/jrouzierinverse/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/jrouzierinverse/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jrouzierinverse/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/jrouzierinverse/packetfence/releases{/id}","created_at":"2012-11-05T21:28:44Z","updated_at":"2014-09-04T14:49:59Z","pushed_at":"2015-09-17T17:11:31Z","git_url":"git://github.com/jrouzierinverse/packetfence.git","ssh_url":"git@github.com:jrouzierinverse/packetfence.git","clone_url":"https://github.com/jrouzierinverse/packetfence.git","svn_url":"https://github.com/jrouzierinverse/packetfence","homepage":"http://www.packetfence.org","size":140893,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"e20796266851fdb4da52f61b587c057cf8a716ea","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","created_at":"2012-03-01T20:21:13Z","updated_at":"2015-09-15T13:15:00Z","pushed_at":"2015-09-17T15:21:30Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"http://www.packetfence.org","size":164961,"stargazers_count":132,"watchers_count":132,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":184,"forks":67,"open_issues":184,"watchers":132,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/594"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/594"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/594/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/594/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/59c2578093ae0f3ea7f2025ad9b9de080bbe5976"}}}}