{"action":"opened","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3038","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3038/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3038/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3038/events","html_url":"https://github.com/ManageIQ/manageiq/issues/3038","id":84080781,"number":3038,"title":"Fix deprecation warning in test: depot_hash method is deprecated.  Please use attributes and authentications of the instance instead","user":{"login":"jrafanie","id":19339,"avatar_url":"https://avatars.githubusercontent.com/u/19339?v=3","gravatar_id":"","url":"https://api.github.com/users/jrafanie","html_url":"https://github.com/jrafanie","followers_url":"https://api.github.com/users/jrafanie/followers","following_url":"https://api.github.com/users/jrafanie/following{/other_user}","gists_url":"https://api.github.com/users/jrafanie/gists{/gist_id}","starred_url":"https://api.github.com/users/jrafanie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrafanie/subscriptions","organizations_url":"https://api.github.com/users/jrafanie/orgs","repos_url":"https://api.github.com/users/jrafanie/repos","events_url":"https://api.github.com/users/jrafanie/events{/privacy}","received_events_url":"https://api.github.com/users/jrafanie/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/cleanup/rubocop","name":"cleanup/rubocop","color":"fef2c0"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/test","name":"test","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-06-02T15:49:18Z","updated_at":"2015-06-02T15:49:18Z","closed_at":null,"body":"We need to fix up the calling code and tests to not call these deprecated methods aded here: https://github.com/ManageIQ/manageiq/commit/0d86e9ce0c968422cf6deb2140173ce9f9fc6533\r\n\r\nI don't really understand the interface the deprecation warning is suggesting.\r\n\r\nAdditionally, the message is losing the right caller because it's going through try which inserts a line into the caller array.\r\n\r\n```\r\n[DEPRECATION] depot_hash method is deprecated.  Please use attributes and authentications of the instance instead.  At /home/travis/build/ManageIQ/manageiq/vmdb/vendor/bundle/ruby/2.0.0/bundler/gems/rails-4842a8377644/activesupport/lib/active_support/core_ext/object/try.rb:36:in `try'\r\n[DEPRECATION] depot_hash method is deprecated.  Please use attributes and authentications of the instance instead.  At /home/travis/build/ManageIQ/manageiq/vmdb/app/models/log_file.rb:55:in `upload'\r\n[DEPRECATION] depot_hash method is deprecated.  Please use attributes and authentications of the instance instead.  At /home/travis/build/ManageIQ/manageiq/vmdb/vendor/bundle/ruby/2.0.0/bundler/gems/rails-4842a8377644/activesupport/lib/active_support/core_ext/object/try.rb:36:in `try'\r\n```\r\n\r\nFor example, the caller for one of these is using try :\r\n\r\n```\r\n[\r\n  \"../code/manageiq/vmdb/app/models/file_depot.rb:37:in `depot_hash'\",\r\n  \"../.gem/ruby/2.1.6/bundler/gems/rails-4842a8377644/activesupport/lib/active_support/core_ext/object/try.rb:36:in `try'\",\r\n  \"../code/manageiq/vmdb/app/models/miq_server/log_management.rb:247:in `get_log_depot_settings'\",\r\n  \"../code/manageiq/vmdb/app/models/miq_server/log_management.rb:243:in `log_depot_configured?'\",\r\n  \"../code/manageiq/vmdb/app/models/miq_server/log_management.rb:129:in `post_logs'\",\r\n  \"../code/manageiq/vmdb/app/models/miq_queue.rb:356:in `block in deliver'\",\r\n  \"../.rubies/ruby-2.1.6/lib/ruby/2.1.0/timeout.rb:91:in `block in timeout'\",\r\n  \"../.rubies/ruby-2.1.6/lib/ruby/2.1.0/timeout.rb:35:in `block in catch'\",\r\n  \"../.rubies/ruby-2.1.6/lib/ruby/2.1.0/timeout.rb:35:in `catch'\",\r\n  \"../.rubies/ruby-2.1.6/lib/ruby/2.1.0/timeout.rb:35:in `catch'\",\r\n  \"../.rubies/ruby-2.1.6/lib/ruby/2.1.0/timeout.rb:106:in `timeout'\",\r\n  \"../code/manageiq/vmdb/app/models/miq_queue.rb:352:in `deliver'\",\r\n  ...,\r\n  \"../code/manageiq/vmdb/spec/models/log_file_spec.rb:110:in `block (6 levels) in <top (required)>'\"\"\r\n  ...\r\n]\r\n```\r\n\r\ncc @brandondunne"}}