{"action":"created","comment":{"url":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments/34661632","id":34661632,"diff_hunk":"@@ -1769,8 +1769,13 @@ def handle_url_build_error(self, error, endpoint, values):\n                 rv = handler(error, endpoint, values)\n                 if rv is not None:\n                     return rv\n-            except BuildError as error:\n-                pass\n+            except BuildError as e:\n+                \"\"\"We can't directly save the BuildError in error because the python3 execution model changed.","path":"flask/app.py","position":7,"original_position":7,"commit_id":"0a4edb7bc7f636c27dcda71c3ca1b053165af4f7","original_commit_id":"0a4edb7bc7f636c27dcda71c3ca1b053165af4f7","user":{"login":"untitaker","id":837573,"avatar_url":"https://avatars.githubusercontent.com/u/837573?v=3","gravatar_id":"","url":"https://api.github.com/users/untitaker","html_url":"https://github.com/untitaker","followers_url":"https://api.github.com/users/untitaker/followers","following_url":"https://api.github.com/users/untitaker/following{/other_user}","gists_url":"https://api.github.com/users/untitaker/gists{/gist_id}","starred_url":"https://api.github.com/users/untitaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/untitaker/subscriptions","organizations_url":"https://api.github.com/users/untitaker/orgs","repos_url":"https://api.github.com/users/untitaker/repos","events_url":"https://api.github.com/users/untitaker/events{/privacy}","received_events_url":"https://api.github.com/users/untitaker/received_events","type":"User","site_admin":false},"body":"Use a normal comment here.","created_at":"2015-07-15T09:37:09Z","updated_at":"2015-07-15T09:37:09Z","html_url":"https://github.com/mitsuhiko/flask/pull/1533#discussion_r34661632","pull_request_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533","_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments/34661632"},"html":{"href":"https://github.com/mitsuhiko/flask/pull/1533#discussion_r34661632"},"pull_request":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533"}}},"pull_request":{"url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533","id":39973955,"html_url":"https://github.com/mitsuhiko/flask/pull/1533","diff_url":"https://github.com/mitsuhiko/flask/pull/1533.diff","patch_url":"https://github.com/mitsuhiko/flask/pull/1533.patch","issue_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1533","number":1533,"state":"open","locked":false,"title":"fix UnboundLocalError in handle_url_build_error","user":{"login":"lobeck","id":424923,"avatar_url":"https://avatars.githubusercontent.com/u/424923?v=3","gravatar_id":"","url":"https://api.github.com/users/lobeck","html_url":"https://github.com/lobeck","followers_url":"https://api.github.com/users/lobeck/followers","following_url":"https://api.github.com/users/lobeck/following{/other_user}","gists_url":"https://api.github.com/users/lobeck/gists{/gist_id}","starred_url":"https://api.github.com/users/lobeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobeck/subscriptions","organizations_url":"https://api.github.com/users/lobeck/orgs","repos_url":"https://api.github.com/users/lobeck/repos","events_url":"https://api.github.com/users/lobeck/events{/privacy}","received_events_url":"https://api.github.com/users/lobeck/received_events","type":"User","site_admin":false},"body":"- caused by changes in the execution model of python 3 where the alias of an except clause is cleared on exit of the except\r\n\r\n- tested with python 2.7.10 and 3.4.3","created_at":"2015-07-14T23:23:05Z","updated_at":"2015-07-15T09:37:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92ff3bdbf30fef28de44b7e433c5661503b05a1a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533/commits","review_comments_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533/comments","review_comment_url":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mitsuhiko/flask/issues/1533/comments","statuses_url":"https://api.github.com/repos/mitsuhiko/flask/statuses/0a4edb7bc7f636c27dcda71c3ca1b053165af4f7","head":{"label":"lobeck:fix_unboundlocalerror_for_handle_build_error","ref":"fix_unboundlocalerror_for_handle_build_error","sha":"0a4edb7bc7f636c27dcda71c3ca1b053165af4f7","user":{"login":"lobeck","id":424923,"avatar_url":"https://avatars.githubusercontent.com/u/424923?v=3","gravatar_id":"","url":"https://api.github.com/users/lobeck","html_url":"https://github.com/lobeck","followers_url":"https://api.github.com/users/lobeck/followers","following_url":"https://api.github.com/users/lobeck/following{/other_user}","gists_url":"https://api.github.com/users/lobeck/gists{/gist_id}","starred_url":"https://api.github.com/users/lobeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobeck/subscriptions","organizations_url":"https://api.github.com/users/lobeck/orgs","repos_url":"https://api.github.com/users/lobeck/repos","events_url":"https://api.github.com/users/lobeck/events{/privacy}","received_events_url":"https://api.github.com/users/lobeck/received_events","type":"User","site_admin":false},"repo":{"id":39105075,"name":"flask","full_name":"lobeck/flask","owner":{"login":"lobeck","id":424923,"avatar_url":"https://avatars.githubusercontent.com/u/424923?v=3","gravatar_id":"","url":"https://api.github.com/users/lobeck","html_url":"https://github.com/lobeck","followers_url":"https://api.github.com/users/lobeck/followers","following_url":"https://api.github.com/users/lobeck/following{/other_user}","gists_url":"https://api.github.com/users/lobeck/gists{/gist_id}","starred_url":"https://api.github.com/users/lobeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lobeck/subscriptions","organizations_url":"https://api.github.com/users/lobeck/orgs","repos_url":"https://api.github.com/users/lobeck/repos","events_url":"https://api.github.com/users/lobeck/events{/privacy}","received_events_url":"https://api.github.com/users/lobeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lobeck/flask","description":"A microframework based on Werkzeug, Jinja2 and good intentions","fork":true,"url":"https://api.github.com/repos/lobeck/flask","forks_url":"https://api.github.com/repos/lobeck/flask/forks","keys_url":"https://api.github.com/repos/lobeck/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lobeck/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lobeck/flask/teams","hooks_url":"https://api.github.com/repos/lobeck/flask/hooks","issue_events_url":"https://api.github.com/repos/lobeck/flask/issues/events{/number}","events_url":"https://api.github.com/repos/lobeck/flask/events","assignees_url":"https://api.github.com/repos/lobeck/flask/assignees{/user}","branches_url":"https://api.github.com/repos/lobeck/flask/branches{/branch}","tags_url":"https://api.github.com/repos/lobeck/flask/tags","blobs_url":"https://api.github.com/repos/lobeck/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lobeck/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lobeck/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/lobeck/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lobeck/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/lobeck/flask/languages","stargazers_url":"https://api.github.com/repos/lobeck/flask/stargazers","contributors_url":"https://api.github.com/repos/lobeck/flask/contributors","subscribers_url":"https://api.github.com/repos/lobeck/flask/subscribers","subscription_url":"https://api.github.com/repos/lobeck/flask/subscription","commits_url":"https://api.github.com/repos/lobeck/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/lobeck/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/lobeck/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/lobeck/flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/lobeck/flask/contents/{+path}","compare_url":"https://api.github.com/repos/lobeck/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lobeck/flask/merges","archive_url":"https://api.github.com/repos/lobeck/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lobeck/flask/downloads","issues_url":"https://api.github.com/repos/lobeck/flask/issues{/number}","pulls_url":"https://api.github.com/repos/lobeck/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/lobeck/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/lobeck/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lobeck/flask/labels{/name}","releases_url":"https://api.github.com/repos/lobeck/flask/releases{/id}","created_at":"2015-07-14T23:11:55Z","updated_at":"2015-07-14T23:11:58Z","pushed_at":"2015-07-14T23:22:17Z","git_url":"git://github.com/lobeck/flask.git","ssh_url":"git@github.com:lobeck/flask.git","clone_url":"https://github.com/lobeck/flask.git","svn_url":"https://github.com/lobeck/flask","homepage":"http://flask.pocoo.org/","size":16321,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mitsuhiko:master","ref":"master","sha":"671c1ee0022ebc561a86e7c18ba97b2b81c24ead","user":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=3","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"repo":{"id":596892,"name":"flask","full_name":"mitsuhiko/flask","owner":{"login":"mitsuhiko","id":7396,"avatar_url":"https://avatars.githubusercontent.com/u/7396?v=3","gravatar_id":"","url":"https://api.github.com/users/mitsuhiko","html_url":"https://github.com/mitsuhiko","followers_url":"https://api.github.com/users/mitsuhiko/followers","following_url":"https://api.github.com/users/mitsuhiko/following{/other_user}","gists_url":"https://api.github.com/users/mitsuhiko/gists{/gist_id}","starred_url":"https://api.github.com/users/mitsuhiko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitsuhiko/subscriptions","organizations_url":"https://api.github.com/users/mitsuhiko/orgs","repos_url":"https://api.github.com/users/mitsuhiko/repos","events_url":"https://api.github.com/users/mitsuhiko/events{/privacy}","received_events_url":"https://api.github.com/users/mitsuhiko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mitsuhiko/flask","description":"A microframework based on Werkzeug, Jinja2 and good intentions","fork":false,"url":"https://api.github.com/repos/mitsuhiko/flask","forks_url":"https://api.github.com/repos/mitsuhiko/flask/forks","keys_url":"https://api.github.com/repos/mitsuhiko/flask/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitsuhiko/flask/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitsuhiko/flask/teams","hooks_url":"https://api.github.com/repos/mitsuhiko/flask/hooks","issue_events_url":"https://api.github.com/repos/mitsuhiko/flask/issues/events{/number}","events_url":"https://api.github.com/repos/mitsuhiko/flask/events","assignees_url":"https://api.github.com/repos/mitsuhiko/flask/assignees{/user}","branches_url":"https://api.github.com/repos/mitsuhiko/flask/branches{/branch}","tags_url":"https://api.github.com/repos/mitsuhiko/flask/tags","blobs_url":"https://api.github.com/repos/mitsuhiko/flask/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitsuhiko/flask/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitsuhiko/flask/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitsuhiko/flask/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitsuhiko/flask/statuses/{sha}","languages_url":"https://api.github.com/repos/mitsuhiko/flask/languages","stargazers_url":"https://api.github.com/repos/mitsuhiko/flask/stargazers","contributors_url":"https://api.github.com/repos/mitsuhiko/flask/contributors","subscribers_url":"https://api.github.com/repos/mitsuhiko/flask/subscribers","subscription_url":"https://api.github.com/repos/mitsuhiko/flask/subscription","commits_url":"https://api.github.com/repos/mitsuhiko/flask/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitsuhiko/flask/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitsuhiko/flask/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitsuhiko/flask/issues/comments{/number}","contents_url":"https://api.github.com/repos/mitsuhiko/flask/contents/{+path}","compare_url":"https://api.github.com/repos/mitsuhiko/flask/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitsuhiko/flask/merges","archive_url":"https://api.github.com/repos/mitsuhiko/flask/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitsuhiko/flask/downloads","issues_url":"https://api.github.com/repos/mitsuhiko/flask/issues{/number}","pulls_url":"https://api.github.com/repos/mitsuhiko/flask/pulls{/number}","milestones_url":"https://api.github.com/repos/mitsuhiko/flask/milestones{/number}","notifications_url":"https://api.github.com/repos/mitsuhiko/flask/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitsuhiko/flask/labels{/name}","releases_url":"https://api.github.com/repos/mitsuhiko/flask/releases{/id}","created_at":"2010-04-06T11:11:59Z","updated_at":"2015-07-15T08:43:16Z","pushed_at":"2015-07-14T23:23:05Z","git_url":"git://github.com/mitsuhiko/flask.git","ssh_url":"git@github.com:mitsuhiko/flask.git","clone_url":"https://github.com/mitsuhiko/flask.git","svn_url":"https://github.com/mitsuhiko/flask","homepage":"http://flask.pocoo.org/","size":16321,"stargazers_count":14818,"watchers_count":14818,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4374,"mirror_url":null,"open_issues_count":157,"forks":4374,"open_issues":157,"watchers":14818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533"},"html":{"href":"https://github.com/mitsuhiko/flask/pull/1533"},"issue":{"href":"https://api.github.com/repos/mitsuhiko/flask/issues/1533"},"comments":{"href":"https://api.github.com/repos/mitsuhiko/flask/issues/1533/comments"},"review_comments":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533/comments"},"review_comment":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mitsuhiko/flask/pulls/1533/commits"},"statuses":{"href":"https://api.github.com/repos/mitsuhiko/flask/statuses/0a4edb7bc7f636c27dcda71c3ca1b053165af4f7"}}}}