{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/36422222","id":36422222,"diff_hunk":"@@ -78,13 +81,18 @@ DiscreteNucleationInserter::threadJoin(const UserObject &y)\n {\n   // combine _local_nucleus_list entries from all threads on the current process\n   const DiscreteNucleationInserter & uo = static_cast<const DiscreteNucleationInserter &>(y);\n-  _local_nucleus_list.insert(_local_nucleus_list.end(), uo._local_nucleus_list.begin(), uo._local_nucleus_list.end());\n+  _global_nucleus_list.insert(_global_nucleus_list.end(), uo._local_nucleus_list.begin(), uo._local_nucleus_list.end());\n+  _changes_made += uo._changes_made;\n }\n \n void\n DiscreteNucleationInserter::finalize()\n {\n-  // here we need to combine all _local_nucleus_list into a the _global_nucleus_list\n-  _global_nucleus_list = _local_nucleus_list;\n+  // add the _local_nucleus_list of thread zero\n+  _global_nucleus_list.insert(_global_nucleus_list.end(), _local_nucleus_list.begin(), _local_nucleus_list.end());\n+  // combine _global_nucleus_lists from all MPI ranks\n   _communicator.allgather(_global_nucleus_list);","path":"modules/phase_field/src/userobjects/DiscreteNucleationInserter.C","position":27,"original_position":27,"commit_id":"30cd03924adf4b35fa0741dd2b1052cb333daabc","original_commit_id":"30cd03924adf4b35fa0741dd2b1052cb333daabc","user":{"login":"jwpeterson","id":1775907,"avatar_url":"https://avatars.githubusercontent.com/u/1775907?v=3","gravatar_id":"","url":"https://api.github.com/users/jwpeterson","html_url":"https://github.com/jwpeterson","followers_url":"https://api.github.com/users/jwpeterson/followers","following_url":"https://api.github.com/users/jwpeterson/following{/other_user}","gists_url":"https://api.github.com/users/jwpeterson/gists{/gist_id}","starred_url":"https://api.github.com/users/jwpeterson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwpeterson/subscriptions","organizations_url":"https://api.github.com/users/jwpeterson/orgs","repos_url":"https://api.github.com/users/jwpeterson/repos","events_url":"https://api.github.com/users/jwpeterson/events{/privacy}","received_events_url":"https://api.github.com/users/jwpeterson/received_events","type":"User","site_admin":false},"body":"> Idk what is installed on hpcbuild?\r\n\r\nIt depends on the module you had loaded.\r\n\r\n> On the Mac I'm using the redistributable.\r\n\r\nAgain, it depends on the module, the redistributable contains both MPIs.\r\n","created_at":"2015-08-06T14:43:53Z","updated_at":"2015-08-06T14:43:53Z","html_url":"https://github.com/idaholab/moose/pull/5513#discussion_r36422222","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/5513","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/36422222"},"html":{"href":"https://github.com/idaholab/moose/pull/5513#discussion_r36422222"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5513"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/5513","id":41606677,"html_url":"https://github.com/idaholab/moose/pull/5513","diff_url":"https://github.com/idaholab/moose/pull/5513.diff","patch_url":"https://github.com/idaholab/moose/pull/5513.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/5513","number":5513,"state":"open","locked":false,"title":"Fix parallel communication issues in DiscreteNucleation","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"body":"The discrete nucleation system updates a nucleus map on demand, iff changes were made to either nucleus list or mesh. The changes flag for the nucleus list was not gathered across MPI tasks (and threads) so the update was only triggered in the domain where the change occurred. However, changes in neighboring domains can affect a local domain (if the nuclei have large radii).\r\n\r\nThe Map user object was also missing a zeroing of a vector which is has to be performed for each element.\r\n\r\nCloses #5512","created_at":"2015-08-04T19:19:01Z","updated_at":"2015-08-06T14:43:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"44314efa33a314b966e0fc42169eb9cf64ddbfe3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/5513/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/5513/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/5513/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/30cd03924adf4b35fa0741dd2b1052cb333daabc","head":{"label":"dschwen:parallelnucl_5512","ref":"parallelnucl_5512","sha":"30cd03924adf4b35fa0741dd2b1052cb333daabc","user":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"repo":{"id":17870930,"name":"moose","full_name":"dschwen/moose","owner":{"login":"dschwen","id":202302,"avatar_url":"https://avatars.githubusercontent.com/u/202302?v=3","gravatar_id":"","url":"https://api.github.com/users/dschwen","html_url":"https://github.com/dschwen","followers_url":"https://api.github.com/users/dschwen/followers","following_url":"https://api.github.com/users/dschwen/following{/other_user}","gists_url":"https://api.github.com/users/dschwen/gists{/gist_id}","starred_url":"https://api.github.com/users/dschwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschwen/subscriptions","organizations_url":"https://api.github.com/users/dschwen/orgs","repos_url":"https://api.github.com/users/dschwen/repos","events_url":"https://api.github.com/users/dschwen/events{/privacy}","received_events_url":"https://api.github.com/users/dschwen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dschwen/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/dschwen/moose","forks_url":"https://api.github.com/repos/dschwen/moose/forks","keys_url":"https://api.github.com/repos/dschwen/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dschwen/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dschwen/moose/teams","hooks_url":"https://api.github.com/repos/dschwen/moose/hooks","issue_events_url":"https://api.github.com/repos/dschwen/moose/issues/events{/number}","events_url":"https://api.github.com/repos/dschwen/moose/events","assignees_url":"https://api.github.com/repos/dschwen/moose/assignees{/user}","branches_url":"https://api.github.com/repos/dschwen/moose/branches{/branch}","tags_url":"https://api.github.com/repos/dschwen/moose/tags","blobs_url":"https://api.github.com/repos/dschwen/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dschwen/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dschwen/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/dschwen/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dschwen/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/dschwen/moose/languages","stargazers_url":"https://api.github.com/repos/dschwen/moose/stargazers","contributors_url":"https://api.github.com/repos/dschwen/moose/contributors","subscribers_url":"https://api.github.com/repos/dschwen/moose/subscribers","subscription_url":"https://api.github.com/repos/dschwen/moose/subscription","commits_url":"https://api.github.com/repos/dschwen/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/dschwen/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/dschwen/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/dschwen/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/dschwen/moose/contents/{+path}","compare_url":"https://api.github.com/repos/dschwen/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dschwen/moose/merges","archive_url":"https://api.github.com/repos/dschwen/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dschwen/moose/downloads","issues_url":"https://api.github.com/repos/dschwen/moose/issues{/number}","pulls_url":"https://api.github.com/repos/dschwen/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/dschwen/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/dschwen/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dschwen/moose/labels{/name}","releases_url":"https://api.github.com/repos/dschwen/moose/releases{/id}","created_at":"2014-03-18T15:25:39Z","updated_at":"2015-04-23T01:28:39Z","pushed_at":"2015-08-05T15:18:50Z","git_url":"git://github.com/dschwen/moose.git","ssh_url":"git@github.com:dschwen/moose.git","clone_url":"https://github.com/dschwen/moose.git","svn_url":"https://github.com/dschwen/moose","homepage":null,"size":113560,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"5f8333a369ab352b2454de241e7f897acee7d0c5","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2015-08-04T17:55:16Z","pushed_at":"2015-08-05T22:44:23Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":132937,"stargazers_count":92,"watchers_count":92,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":150,"mirror_url":null,"open_issues_count":473,"forks":150,"open_issues":473,"watchers":92,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5513"},"html":{"href":"https://github.com/idaholab/moose/pull/5513"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/5513"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/5513/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5513/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5513/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/30cd03924adf4b35fa0741dd2b1052cb333daabc"}}}}