{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/basecrm/basecrm-java/pulls/4","id":46016558,"html_url":"https://github.com/basecrm/basecrm-java/pull/4","diff_url":"https://github.com/basecrm/basecrm-java/pull/4.diff","patch_url":"https://github.com/basecrm/basecrm-java/pull/4.patch","issue_url":"https://api.github.com/repos/basecrm/basecrm-java/issues/4","number":4,"state":"open","locked":false,"title":"extract builder from jersey http client","user":{"login":"pawelgocek","id":5902736,"avatar_url":"https://avatars.githubusercontent.com/u/5902736?v=3","gravatar_id":"","url":"https://api.github.com/users/pawelgocek","html_url":"https://github.com/pawelgocek","followers_url":"https://api.github.com/users/pawelgocek/followers","following_url":"https://api.github.com/users/pawelgocek/following{/other_user}","gists_url":"https://api.github.com/users/pawelgocek/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelgocek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelgocek/subscriptions","organizations_url":"https://api.github.com/users/pawelgocek/orgs","repos_url":"https://api.github.com/users/pawelgocek/repos","events_url":"https://api.github.com/users/pawelgocek/events{/privacy}","received_events_url":"https://api.github.com/users/pawelgocek/received_events","type":"User","site_admin":false},"body":"When extending com.getbase.http.hersey.HttpClient you would like to override createJerseyClient to provide your own configuration (e.g. add filters, setup some custom properties, etc). In current implementation when you extend the class you effectively cannot pass any other arguments to this method as it is called by super constructor before you can store any additional parameters. Fix for this would be to extract abstraction responsible for client configuration and build. This however breaks current API. Let me know what you think. (other option - extending Configuration - is problematic due to necessary casting in createJerseyClient and because public static final class Builder is defined in Configuration).","created_at":"2015-09-25T14:16:26Z","updated_at":"2015-09-25T14:16:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/basecrm/basecrm-java/pulls/4/commits","review_comments_url":"https://api.github.com/repos/basecrm/basecrm-java/pulls/4/comments","review_comment_url":"https://api.github.com/repos/basecrm/basecrm-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basecrm/basecrm-java/issues/4/comments","statuses_url":"https://api.github.com/repos/basecrm/basecrm-java/statuses/999054d59e3314687cb049f4dbb058d8e6b8a2fa","head":{"label":"basecrm:extracted-client-builder","ref":"extracted-client-builder","sha":"999054d59e3314687cb049f4dbb058d8e6b8a2fa","user":{"login":"basecrm","id":2480621,"avatar_url":"https://avatars.githubusercontent.com/u/2480621?v=3","gravatar_id":"","url":"https://api.github.com/users/basecrm","html_url":"https://github.com/basecrm","followers_url":"https://api.github.com/users/basecrm/followers","following_url":"https://api.github.com/users/basecrm/following{/other_user}","gists_url":"https://api.github.com/users/basecrm/gists{/gist_id}","starred_url":"https://api.github.com/users/basecrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecrm/subscriptions","organizations_url":"https://api.github.com/users/basecrm/orgs","repos_url":"https://api.github.com/users/basecrm/repos","events_url":"https://api.github.com/users/basecrm/events{/privacy}","received_events_url":"https://api.github.com/users/basecrm/received_events","type":"Organization","site_admin":false},"repo":{"id":34998423,"name":"basecrm-java","full_name":"basecrm/basecrm-java","owner":{"login":"basecrm","id":2480621,"avatar_url":"https://avatars.githubusercontent.com/u/2480621?v=3","gravatar_id":"","url":"https://api.github.com/users/basecrm","html_url":"https://github.com/basecrm","followers_url":"https://api.github.com/users/basecrm/followers","following_url":"https://api.github.com/users/basecrm/following{/other_user}","gists_url":"https://api.github.com/users/basecrm/gists{/gist_id}","starred_url":"https://api.github.com/users/basecrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecrm/subscriptions","organizations_url":"https://api.github.com/users/basecrm/orgs","repos_url":"https://api.github.com/users/basecrm/repos","events_url":"https://api.github.com/users/basecrm/events{/privacy}","received_events_url":"https://api.github.com/users/basecrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basecrm/basecrm-java","description":"BaseCRM API Client for Java","fork":false,"url":"https://api.github.com/repos/basecrm/basecrm-java","forks_url":"https://api.github.com/repos/basecrm/basecrm-java/forks","keys_url":"https://api.github.com/repos/basecrm/basecrm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basecrm/basecrm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basecrm/basecrm-java/teams","hooks_url":"https://api.github.com/repos/basecrm/basecrm-java/hooks","issue_events_url":"https://api.github.com/repos/basecrm/basecrm-java/issues/events{/number}","events_url":"https://api.github.com/repos/basecrm/basecrm-java/events","assignees_url":"https://api.github.com/repos/basecrm/basecrm-java/assignees{/user}","branches_url":"https://api.github.com/repos/basecrm/basecrm-java/branches{/branch}","tags_url":"https://api.github.com/repos/basecrm/basecrm-java/tags","blobs_url":"https://api.github.com/repos/basecrm/basecrm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basecrm/basecrm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basecrm/basecrm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/basecrm/basecrm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basecrm/basecrm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/basecrm/basecrm-java/languages","stargazers_url":"https://api.github.com/repos/basecrm/basecrm-java/stargazers","contributors_url":"https://api.github.com/repos/basecrm/basecrm-java/contributors","subscribers_url":"https://api.github.com/repos/basecrm/basecrm-java/subscribers","subscription_url":"https://api.github.com/repos/basecrm/basecrm-java/subscription","commits_url":"https://api.github.com/repos/basecrm/basecrm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/basecrm/basecrm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/basecrm/basecrm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/basecrm/basecrm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/basecrm/basecrm-java/contents/{+path}","compare_url":"https://api.github.com/repos/basecrm/basecrm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basecrm/basecrm-java/merges","archive_url":"https://api.github.com/repos/basecrm/basecrm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basecrm/basecrm-java/downloads","issues_url":"https://api.github.com/repos/basecrm/basecrm-java/issues{/number}","pulls_url":"https://api.github.com/repos/basecrm/basecrm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/basecrm/basecrm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/basecrm/basecrm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basecrm/basecrm-java/labels{/name}","releases_url":"https://api.github.com/repos/basecrm/basecrm-java/releases{/id}","created_at":"2015-05-03T19:45:34Z","updated_at":"2015-05-08T10:19:37Z","pushed_at":"2015-09-25T14:09:45Z","git_url":"git://github.com/basecrm/basecrm-java.git","ssh_url":"git@github.com:basecrm/basecrm-java.git","clone_url":"https://github.com/basecrm/basecrm-java.git","svn_url":"https://github.com/basecrm/basecrm-java","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"basecrm:master","ref":"master","sha":"88ee19c4e6cc18af429fdea96e93869e8c8d8004","user":{"login":"basecrm","id":2480621,"avatar_url":"https://avatars.githubusercontent.com/u/2480621?v=3","gravatar_id":"","url":"https://api.github.com/users/basecrm","html_url":"https://github.com/basecrm","followers_url":"https://api.github.com/users/basecrm/followers","following_url":"https://api.github.com/users/basecrm/following{/other_user}","gists_url":"https://api.github.com/users/basecrm/gists{/gist_id}","starred_url":"https://api.github.com/users/basecrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecrm/subscriptions","organizations_url":"https://api.github.com/users/basecrm/orgs","repos_url":"https://api.github.com/users/basecrm/repos","events_url":"https://api.github.com/users/basecrm/events{/privacy}","received_events_url":"https://api.github.com/users/basecrm/received_events","type":"Organization","site_admin":false},"repo":{"id":34998423,"name":"basecrm-java","full_name":"basecrm/basecrm-java","owner":{"login":"basecrm","id":2480621,"avatar_url":"https://avatars.githubusercontent.com/u/2480621?v=3","gravatar_id":"","url":"https://api.github.com/users/basecrm","html_url":"https://github.com/basecrm","followers_url":"https://api.github.com/users/basecrm/followers","following_url":"https://api.github.com/users/basecrm/following{/other_user}","gists_url":"https://api.github.com/users/basecrm/gists{/gist_id}","starred_url":"https://api.github.com/users/basecrm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecrm/subscriptions","organizations_url":"https://api.github.com/users/basecrm/orgs","repos_url":"https://api.github.com/users/basecrm/repos","events_url":"https://api.github.com/users/basecrm/events{/privacy}","received_events_url":"https://api.github.com/users/basecrm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basecrm/basecrm-java","description":"BaseCRM API Client for Java","fork":false,"url":"https://api.github.com/repos/basecrm/basecrm-java","forks_url":"https://api.github.com/repos/basecrm/basecrm-java/forks","keys_url":"https://api.github.com/repos/basecrm/basecrm-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basecrm/basecrm-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basecrm/basecrm-java/teams","hooks_url":"https://api.github.com/repos/basecrm/basecrm-java/hooks","issue_events_url":"https://api.github.com/repos/basecrm/basecrm-java/issues/events{/number}","events_url":"https://api.github.com/repos/basecrm/basecrm-java/events","assignees_url":"https://api.github.com/repos/basecrm/basecrm-java/assignees{/user}","branches_url":"https://api.github.com/repos/basecrm/basecrm-java/branches{/branch}","tags_url":"https://api.github.com/repos/basecrm/basecrm-java/tags","blobs_url":"https://api.github.com/repos/basecrm/basecrm-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basecrm/basecrm-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basecrm/basecrm-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/basecrm/basecrm-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basecrm/basecrm-java/statuses/{sha}","languages_url":"https://api.github.com/repos/basecrm/basecrm-java/languages","stargazers_url":"https://api.github.com/repos/basecrm/basecrm-java/stargazers","contributors_url":"https://api.github.com/repos/basecrm/basecrm-java/contributors","subscribers_url":"https://api.github.com/repos/basecrm/basecrm-java/subscribers","subscription_url":"https://api.github.com/repos/basecrm/basecrm-java/subscription","commits_url":"https://api.github.com/repos/basecrm/basecrm-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/basecrm/basecrm-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/basecrm/basecrm-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/basecrm/basecrm-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/basecrm/basecrm-java/contents/{+path}","compare_url":"https://api.github.com/repos/basecrm/basecrm-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basecrm/basecrm-java/merges","archive_url":"https://api.github.com/repos/basecrm/basecrm-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basecrm/basecrm-java/downloads","issues_url":"https://api.github.com/repos/basecrm/basecrm-java/issues{/number}","pulls_url":"https://api.github.com/repos/basecrm/basecrm-java/pulls{/number}","milestones_url":"https://api.github.com/repos/basecrm/basecrm-java/milestones{/number}","notifications_url":"https://api.github.com/repos/basecrm/basecrm-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basecrm/basecrm-java/labels{/name}","releases_url":"https://api.github.com/repos/basecrm/basecrm-java/releases{/id}","created_at":"2015-05-03T19:45:34Z","updated_at":"2015-05-08T10:19:37Z","pushed_at":"2015-09-25T14:09:45Z","git_url":"git://github.com/basecrm/basecrm-java.git","ssh_url":"git@github.com:basecrm/basecrm-java.git","clone_url":"https://github.com/basecrm/basecrm-java.git","svn_url":"https://github.com/basecrm/basecrm-java","homepage":null,"size":272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":4,"forks":1,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basecrm/basecrm-java/pulls/4"},"html":{"href":"https://github.com/basecrm/basecrm-java/pull/4"},"issue":{"href":"https://api.github.com/repos/basecrm/basecrm-java/issues/4"},"comments":{"href":"https://api.github.com/repos/basecrm/basecrm-java/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/basecrm/basecrm-java/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/basecrm/basecrm-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basecrm/basecrm-java/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/basecrm/basecrm-java/statuses/999054d59e3314687cb049f4dbb058d8e6b8a2fa"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":38,"deletions":25,"changed_files":2}}