{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9099","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9099/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9099/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9099/events","html_url":"https://github.com/cms-sw/cmssw/pull/9099","id":76674500,"number":9099,"title":"Add protection againt NaNs for IP significance histograms in Tracking DQM","user":{"login":"makortel","id":33993,"avatar_url":"https://avatars.githubusercontent.com/u/33993?v=3","gravatar_id":"","url":"https://api.github.com/users/makortel","html_url":"https://github.com/makortel","followers_url":"https://api.github.com/users/makortel/followers","following_url":"https://api.github.com/users/makortel/following{/other_user}","gists_url":"https://api.github.com/users/makortel/gists{/gist_id}","starred_url":"https://api.github.com/users/makortel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/makortel/subscriptions","organizations_url":"https://api.github.com/users/makortel/orgs","repos_url":"https://api.github.com/users/makortel/repos","events_url":"https://api.github.com/users/makortel/events{/privacy}","received_events_url":"https://api.github.com/users/makortel/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fef2c0"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/dqm-pending","name":"dqm-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":588,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-05-18T11:44:03Z","due_on":"2015-03-02T23:00:00Z","closed_at":null},"comments":2,"created_at":"2015-05-15T09:58:30Z","updated_at":"2015-05-18T12:47:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9099","html_url":"https://github.com/cms-sw/cmssw/pull/9099","diff_url":"https://github.com/cms-sw/cmssw/pull/9099.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9099.patch"},"body":"In some cases `IPTools::signed*ImpactParameter*()`can return invalid result, in which case the existing code fills the histogram with NaN (0/0). This PR adds protection against it.\r\n\r\nTested in CMSSW_7_5_X_2015-05-12-2300. Only expected change is no NaNs in these two histograms (would be visible e.g. in `Mean()` if anywhere), e.g. limited matrix shows no difference.\r\n\r\n@rovere @VinInn "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/103049111","html_url":"https://github.com/cms-sw/cmssw/pull/9099#issuecomment-103049111","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9099","id":103049111,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T12:47:11Z","updated_at":"2015-05-18T12:47:11Z","body":"+1\nTested at: e2701547c1f5c3f810351a3fe755d5293d7aaf3a\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-9099/4750/summary.html"}}