{"action":"closed","number":868,"pull_request":{"url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/868","id":36157571,"html_url":"https://github.com/cucumber/cucumber-jvm/pull/868","diff_url":"https://github.com/cucumber/cucumber-jvm/pull/868.diff","patch_url":"https://github.com/cucumber/cucumber-jvm/pull/868.patch","issue_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/868","number":868,"state":"closed","locked":false,"title":"Cucumber scala tweaks","user":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?v=3","gravatar_id":"","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"body":"Made some changes as to how the cucumber-scala artifacts are created. \r\n\r\nSpecifically, now it's a hierarchy of maven poms, with a second aggregator used to build the individual projects, and the shared sources moved into a sources directory.\r\n\r\nAdditionally I'm using `pluginManagement` to avoid copy/pasta for the plugins that generate the I18n sources and the actual building of scala itself. The only dependencies listed in the scala_<version> projects are the scala versions themselves. This is far more scalable than \"current\" and \"previous\" we had before, and it makes it easier to know obviously which version of scala we're building against.\r\n\r\nI also fixed one compile time flag, since it was talking about using scala 2.9 and we're only building for 2.10 and above. \r\n\r\nFinally, I added the milestone of scala 2.12 in there, because I wanted to see it build us an artifact for it :D","created_at":"2015-05-25T20:59:18Z","updated_at":"2015-05-29T01:38:45Z","closed_at":"2015-05-29T01:38:45Z","merged_at":"2015-05-29T01:38:45Z","merge_commit_sha":"ef34d9504243df15a465417aab7bdb5b44ac36c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/868/commits","review_comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/868/comments","review_comment_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/868/comments","statuses_url":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/942ae1ccc3fdef47ccaf9a0a108394557f02aeb3","head":{"label":"dkowis:cucumber-scala-tweaks","ref":"cucumber-scala-tweaks","sha":"942ae1ccc3fdef47ccaf9a0a108394557f02aeb3","user":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?v=3","gravatar_id":"","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"repo":{"id":2352530,"name":"cucumber-jvm","full_name":"dkowis/cucumber-jvm","owner":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?v=3","gravatar_id":"","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dkowis/cucumber-jvm","description":"Cucumber for the JVM (successor of Cuke4Duke)","fork":true,"url":"https://api.github.com/repos/dkowis/cucumber-jvm","forks_url":"https://api.github.com/repos/dkowis/cucumber-jvm/forks","keys_url":"https://api.github.com/repos/dkowis/cucumber-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dkowis/cucumber-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dkowis/cucumber-jvm/teams","hooks_url":"https://api.github.com/repos/dkowis/cucumber-jvm/hooks","issue_events_url":"https://api.github.com/repos/dkowis/cucumber-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/dkowis/cucumber-jvm/events","assignees_url":"https://api.github.com/repos/dkowis/cucumber-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/dkowis/cucumber-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/dkowis/cucumber-jvm/tags","blobs_url":"https://api.github.com/repos/dkowis/cucumber-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dkowis/cucumber-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dkowis/cucumber-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dkowis/cucumber-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dkowis/cucumber-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dkowis/cucumber-jvm/languages","stargazers_url":"https://api.github.com/repos/dkowis/cucumber-jvm/stargazers","contributors_url":"https://api.github.com/repos/dkowis/cucumber-jvm/contributors","subscribers_url":"https://api.github.com/repos/dkowis/cucumber-jvm/subscribers","subscription_url":"https://api.github.com/repos/dkowis/cucumber-jvm/subscription","commits_url":"https://api.github.com/repos/dkowis/cucumber-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dkowis/cucumber-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dkowis/cucumber-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dkowis/cucumber-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dkowis/cucumber-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/dkowis/cucumber-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dkowis/cucumber-jvm/merges","archive_url":"https://api.github.com/repos/dkowis/cucumber-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dkowis/cucumber-jvm/downloads","issues_url":"https://api.github.com/repos/dkowis/cucumber-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/dkowis/cucumber-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dkowis/cucumber-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dkowis/cucumber-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dkowis/cucumber-jvm/labels{/name}","releases_url":"https://api.github.com/repos/dkowis/cucumber-jvm/releases{/id}","created_at":"2011-09-09T00:45:28Z","updated_at":"2015-05-25T20:27:35Z","pushed_at":"2015-05-25T23:05:05Z","git_url":"git://github.com/dkowis/cucumber-jvm.git","ssh_url":"git@github.com:dkowis/cucumber-jvm.git","clone_url":"https://github.com/dkowis/cucumber-jvm.git","svn_url":"https://github.com/dkowis/cucumber-jvm","homepage":"","size":15030,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"cucumber:master","ref":"master","sha":"f3a73d5ed4be3262ee6279d90d793af48ce50f61","user":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"repo":{"id":1962219,"name":"cucumber-jvm","full_name":"cucumber/cucumber-jvm","owner":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cucumber/cucumber-jvm","description":"Cucumber for the JVM","fork":false,"url":"https://api.github.com/repos/cucumber/cucumber-jvm","forks_url":"https://api.github.com/repos/cucumber/cucumber-jvm/forks","keys_url":"https://api.github.com/repos/cucumber/cucumber-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cucumber/cucumber-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cucumber/cucumber-jvm/teams","hooks_url":"https://api.github.com/repos/cucumber/cucumber-jvm/hooks","issue_events_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/cucumber/cucumber-jvm/events","assignees_url":"https://api.github.com/repos/cucumber/cucumber-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/cucumber/cucumber-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/cucumber/cucumber-jvm/tags","blobs_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/cucumber/cucumber-jvm/languages","stargazers_url":"https://api.github.com/repos/cucumber/cucumber-jvm/stargazers","contributors_url":"https://api.github.com/repos/cucumber/cucumber-jvm/contributors","subscribers_url":"https://api.github.com/repos/cucumber/cucumber-jvm/subscribers","subscription_url":"https://api.github.com/repos/cucumber/cucumber-jvm/subscription","commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cucumber/cucumber-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/cucumber/cucumber-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cucumber/cucumber-jvm/merges","archive_url":"https://api.github.com/repos/cucumber/cucumber-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cucumber/cucumber-jvm/downloads","issues_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/cucumber/cucumber-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/cucumber/cucumber-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cucumber/cucumber-jvm/labels{/name}","releases_url":"https://api.github.com/repos/cucumber/cucumber-jvm/releases{/id}","created_at":"2011-06-27T19:49:46Z","updated_at":"2015-05-28T07:48:02Z","pushed_at":"2015-05-29T01:38:46Z","git_url":"git://github.com/cucumber/cucumber-jvm.git","ssh_url":"git@github.com:cucumber/cucumber-jvm.git","clone_url":"https://github.com/cucumber/cucumber-jvm.git","svn_url":"https://github.com/cucumber/cucumber-jvm","homepage":"http://cukes.info","size":33494,"stargazers_count":1021,"watchers_count":1021,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":830,"mirror_url":null,"open_issues_count":106,"forks":830,"open_issues":106,"watchers":1021,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/868"},"html":{"href":"https://github.com/cucumber/cucumber-jvm/pull/868"},"issue":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/868"},"comments":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/868/comments"},"review_comments":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/868/comments"},"review_comment":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/868/commits"},"statuses":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/942ae1ccc3fdef47ccaf9a0a108394557f02aeb3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dkowis","id":28048,"avatar_url":"https://avatars.githubusercontent.com/u/28048?v=3","gravatar_id":"","url":"https://api.github.com/users/dkowis","html_url":"https://github.com/dkowis","followers_url":"https://api.github.com/users/dkowis/followers","following_url":"https://api.github.com/users/dkowis/following{/other_user}","gists_url":"https://api.github.com/users/dkowis/gists{/gist_id}","starred_url":"https://api.github.com/users/dkowis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkowis/subscriptions","organizations_url":"https://api.github.com/users/dkowis/orgs","repos_url":"https://api.github.com/users/dkowis/repos","events_url":"https://api.github.com/users/dkowis/events{/privacy}","received_events_url":"https://api.github.com/users/dkowis/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":5,"additions":242,"deletions":224,"changed_files":24}}