{"action":"created","comment":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/31853406","id":31853406,"diff_hunk":"@@ -54,157 +63,211 @@ public DocumentRuby document() {\n \n     @Override\n     public DocumentRuby getDocument() {\n-        return this.abstractNode.getDocument();\n+        return (DocumentRuby) NodeConverter.createASTNode(getRubyProperty(\"document\"));\n+    }\n+\n+    public IRubyObject getRubyObject() {\n+        return rubyNode;","path":"asciidoctorj-core/src/main/java/org/asciidoctor/ast/AbstractNodeImpl.java","position":76,"original_position":76,"commit_id":"65276b8276d7898ab9d231ca381cc3c83ba7d93b","original_commit_id":"65276b8276d7898ab9d231ca381cc3c83ba7d93b","user":{"login":"mojavelinux","id":79351,"avatar_url":"https://avatars.githubusercontent.com/u/79351?v=3","gravatar_id":"","url":"https://api.github.com/users/mojavelinux","html_url":"https://github.com/mojavelinux","followers_url":"https://api.github.com/users/mojavelinux/followers","following_url":"https://api.github.com/users/mojavelinux/following{/other_user}","gists_url":"https://api.github.com/users/mojavelinux/gists{/gist_id}","starred_url":"https://api.github.com/users/mojavelinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mojavelinux/subscriptions","organizations_url":"https://api.github.com/users/mojavelinux/orgs","repos_url":"https://api.github.com/users/mojavelinux/repos","events_url":"https://api.github.com/users/mojavelinux/events{/privacy}","received_events_url":"https://api.github.com/users/mojavelinux/received_events","type":"User","site_admin":false},"body":"Ah, that makes sense. Then I suppose it's good. :+1: ","created_at":"2015-06-05T21:30:27Z","updated_at":"2015-06-05T21:30:27Z","html_url":"https://github.com/asciidoctor/asciidoctorj/pull/317#discussion_r31853406","pull_request_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317","_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments/31853406"},"html":{"href":"https://github.com/asciidoctor/asciidoctorj/pull/317#discussion_r31853406"},"pull_request":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317","id":36211285,"html_url":"https://github.com/asciidoctor/asciidoctorj/pull/317","diff_url":"https://github.com/asciidoctor/asciidoctorj/pull/317.diff","patch_url":"https://github.com/asciidoctor/asciidoctorj/pull/317.patch","issue_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/317","number":317,"state":"open","locked":false,"title":"Cache Java AST nodes at Ruby nodes to always convert every Ruby node …","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"body":"…to the same Java node\r\n\r\nWith this PR the NodeConverter will first ask the NodeCache if there is already a Java Node for the given Ruby node.\r\nThe NodeCache caches such information in the new member `@asciidoctorj_cache` that is a RubyHash and will contain the Java object under the key `:asciidoctorj_node`.\r\n\r\nAdditionally I changed the methods like getDocument(), getParent() & findBy() to always invoke the NodeConverter when returning a node.","created_at":"2015-05-26T14:59:14Z","updated_at":"2015-06-05T21:30:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3ec9f4115d46bdeb9aadb92437d88d4c0866cd99","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317/commits","review_comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317/comments","review_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/317/comments","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/65276b8276d7898ab9d231ca381cc3c83ba7d93b","head":{"label":"robertpanzer:NodeCaching","ref":"NodeCaching","sha":"65276b8276d7898ab9d231ca381cc3c83ba7d93b","user":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"repo":{"id":27998582,"name":"asciidoctorj","full_name":"robertpanzer/asciidoctorj","owner":{"login":"robertpanzer","id":1163662,"avatar_url":"https://avatars.githubusercontent.com/u/1163662?v=3","gravatar_id":"","url":"https://api.github.com/users/robertpanzer","html_url":"https://github.com/robertpanzer","followers_url":"https://api.github.com/users/robertpanzer/followers","following_url":"https://api.github.com/users/robertpanzer/following{/other_user}","gists_url":"https://api.github.com/users/robertpanzer/gists{/gist_id}","starred_url":"https://api.github.com/users/robertpanzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertpanzer/subscriptions","organizations_url":"https://api.github.com/users/robertpanzer/orgs","repos_url":"https://api.github.com/users/robertpanzer/repos","events_url":"https://api.github.com/users/robertpanzer/events{/privacy}","received_events_url":"https://api.github.com/users/robertpanzer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertpanzer/asciidoctorj","description":"Java bindings for Asciidoctor. Asciidoctor on the JVM!","fork":true,"url":"https://api.github.com/repos/robertpanzer/asciidoctorj","forks_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/forks","keys_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/teams","hooks_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/hooks","issue_events_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/issues/events{/number}","events_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/events","assignees_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/assignees{/user}","branches_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/branches{/branch}","tags_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/tags","blobs_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/statuses/{sha}","languages_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/languages","stargazers_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/stargazers","contributors_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/contributors","subscribers_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/subscribers","subscription_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/subscription","commits_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/contents/{+path}","compare_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/merges","archive_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/downloads","issues_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/issues{/number}","pulls_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/pulls{/number}","milestones_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/milestones{/number}","notifications_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/labels{/name}","releases_url":"https://api.github.com/repos/robertpanzer/asciidoctorj/releases{/id}","created_at":"2014-12-14T15:33:22Z","updated_at":"2015-05-05T14:13:31Z","pushed_at":"2015-06-05T15:42:32Z","git_url":"git://github.com/robertpanzer/asciidoctorj.git","ssh_url":"git@github.com:robertpanzer/asciidoctorj.git","clone_url":"https://github.com/robertpanzer/asciidoctorj.git","svn_url":"https://github.com/robertpanzer/asciidoctorj","homepage":"http://asciidoctor.org","size":2148,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciidoctor:asciidoctorj-1.6.0","ref":"asciidoctorj-1.6.0","sha":"0d0dd34b45c9eae785a9bbf545ab5e433e266094","user":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"repo":{"id":8862411,"name":"asciidoctorj","full_name":"asciidoctor/asciidoctorj","owner":{"login":"asciidoctor","id":3137042,"avatar_url":"https://avatars.githubusercontent.com/u/3137042?v=3","gravatar_id":"","url":"https://api.github.com/users/asciidoctor","html_url":"https://github.com/asciidoctor","followers_url":"https://api.github.com/users/asciidoctor/followers","following_url":"https://api.github.com/users/asciidoctor/following{/other_user}","gists_url":"https://api.github.com/users/asciidoctor/gists{/gist_id}","starred_url":"https://api.github.com/users/asciidoctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciidoctor/subscriptions","organizations_url":"https://api.github.com/users/asciidoctor/orgs","repos_url":"https://api.github.com/users/asciidoctor/repos","events_url":"https://api.github.com/users/asciidoctor/events{/privacy}","received_events_url":"https://api.github.com/users/asciidoctor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/asciidoctor/asciidoctorj","description":":coffee: Java bindings for Asciidoctor. Asciidoctor on the JVM!","fork":false,"url":"https://api.github.com/repos/asciidoctor/asciidoctorj","forks_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/forks","keys_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/teams","hooks_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/hooks","issue_events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/events{/number}","events_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/events","assignees_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/assignees{/user}","branches_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/branches{/branch}","tags_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/tags","blobs_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/{sha}","languages_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/languages","stargazers_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/stargazers","contributors_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/contributors","subscribers_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/subscribers","subscription_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/subscription","commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/comments{/number}","contents_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/contents/{+path}","compare_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/merges","archive_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/downloads","issues_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues{/number}","pulls_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls{/number}","milestones_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/milestones{/number}","notifications_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/labels{/name}","releases_url":"https://api.github.com/repos/asciidoctor/asciidoctorj/releases{/id}","created_at":"2013-03-18T19:36:27Z","updated_at":"2015-06-03T16:07:45Z","pushed_at":"2015-06-05T07:42:32Z","git_url":"git://github.com/asciidoctor/asciidoctorj.git","ssh_url":"git@github.com:asciidoctor/asciidoctorj.git","clone_url":"https://github.com/asciidoctor/asciidoctorj.git","svn_url":"https://github.com/asciidoctor/asciidoctorj","homepage":"http://asciidoctor.org","size":3581,"stargazers_count":122,"watchers_count":122,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"open_issues_count":50,"forks":50,"open_issues":50,"watchers":122,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317"},"html":{"href":"https://github.com/asciidoctor/asciidoctorj/pull/317"},"issue":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/317"},"comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/asciidoctor/asciidoctorj/statuses/65276b8276d7898ab9d231ca381cc3c83ba7d93b"}}}}