{"action":"created","issue":{"url":"https://api.github.com/repos/opf/openproject/issues/2662","labels_url":"https://api.github.com/repos/opf/openproject/issues/2662/labels{/name}","comments_url":"https://api.github.com/repos/opf/openproject/issues/2662/comments","events_url":"https://api.github.com/repos/opf/openproject/issues/2662/events","html_url":"https://github.com/opf/openproject/pull/2662","id":59932236,"number":2662,"title":"17419 Date range picker in place editor","user":{"login":"hirtie-maxim","id":6662687,"avatar_url":"https://avatars.githubusercontent.com/u/6662687?v=3","gravatar_id":"","url":"https://api.github.com/users/hirtie-maxim","html_url":"https://github.com/hirtie-maxim","followers_url":"https://api.github.com/users/hirtie-maxim/followers","following_url":"https://api.github.com/users/hirtie-maxim/following{/other_user}","gists_url":"https://api.github.com/users/hirtie-maxim/gists{/gist_id}","starred_url":"https://api.github.com/users/hirtie-maxim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hirtie-maxim/subscriptions","organizations_url":"https://api.github.com/users/hirtie-maxim/orgs","repos_url":"https://api.github.com/users/hirtie-maxim/repos","events_url":"https://api.github.com/users/hirtie-maxim/events{/privacy}","received_events_url":"https://api.github.com/users/hirtie-maxim/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-03-05T10:23:34Z","updated_at":"2015-03-11T14:01:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/2662","html_url":"https://github.com/opf/openproject/pull/2662","diff_url":"https://github.com/opf/openproject/pull/2662.diff","patch_url":"https://github.com/opf/openproject/pull/2662.patch"},"body":" [``* `#18939` Date picker inplace editor``](http://community.openproject.org/work_packages/18939)"},"comment":{"url":"https://api.github.com/repos/opf/openproject/issues/comments/78267835","html_url":"https://github.com/opf/openproject/pull/2662#issuecomment-78267835","issue_url":"https://api.github.com/repos/opf/openproject/issues/2662","id":78267835,"user":{"login":"ulferts","id":617519,"avatar_url":"https://avatars.githubusercontent.com/u/617519?v=3","gravatar_id":"","url":"https://api.github.com/users/ulferts","html_url":"https://github.com/ulferts","followers_url":"https://api.github.com/users/ulferts/followers","following_url":"https://api.github.com/users/ulferts/following{/other_user}","gists_url":"https://api.github.com/users/ulferts/gists{/gist_id}","starred_url":"https://api.github.com/users/ulferts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulferts/subscriptions","organizations_url":"https://api.github.com/users/ulferts/orgs","repos_url":"https://api.github.com/users/ulferts/repos","events_url":"https://api.github.com/users/ulferts/events{/privacy}","received_events_url":"https://api.github.com/users/ulferts/received_events","type":"User","site_admin":false},"created_at":"2015-03-11T14:01:05Z","updated_at":"2015-03-11T14:01:05Z","body":"@hirtie-maxim not looking at the code in my review I noticed the following:\r\n* cannot change first day of the week (Sunday, Saturday, Monday). This should be configurable via the setting in \"Modules\" -> \"Administration\" -> \"Settings\" -> \"Display\"\r\n* cannot set the values to null. Once you have start/end date set to anything, you can not choose to set them to null again.\r\n* When no date is set, the value is displayed as \"Invalid date - invalid date\". This should read \"No start date set - No end date set\". \r\n* I can always only set ranges, not individual dates for example when I only want to specify the start or end date. This might break the idea of having one field with a date range picker.\r\n* The calendar week is not displayed.\r\n* I checked with PM and the requirement is to always display the dates in the format YYYY/MM/DD in while in edit mode. When in show mode, the display should be according to the settings in the admin section. Currently this admin setting is used for both which I personally find more desirable."}}