{"action":"created","issue":{"url":"https://api.github.com/repos/bslatkin/effectivepython/issues/19","labels_url":"https://api.github.com/repos/bslatkin/effectivepython/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/bslatkin/effectivepython/issues/19/comments","events_url":"https://api.github.com/repos/bslatkin/effectivepython/issues/19/events","html_url":"https://github.com/bslatkin/effectivepython/issues/19","id":80298732,"number":19,"title":"Item 33, p. 104 - BrokenDictionaryDB does nothing with __init__ parameters","user":{"login":"yangmillstheory","id":2729079,"avatar_url":"https://avatars.githubusercontent.com/u/2729079?v=3","gravatar_id":"","url":"https://api.github.com/users/yangmillstheory","html_url":"https://github.com/yangmillstheory","followers_url":"https://api.github.com/users/yangmillstheory/followers","following_url":"https://api.github.com/users/yangmillstheory/following{/other_user}","gists_url":"https://api.github.com/users/yangmillstheory/gists{/gist_id}","starred_url":"https://api.github.com/users/yangmillstheory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yangmillstheory/subscriptions","organizations_url":"https://api.github.com/users/yangmillstheory/orgs","repos_url":"https://api.github.com/users/yangmillstheory/repos","events_url":"https://api.github.com/users/yangmillstheory/events{/privacy}","received_events_url":"https://api.github.com/users/yangmillstheory/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-24T23:01:26Z","updated_at":"2015-05-25T17:18:15Z","closed_at":null,"body":"I think the infinite recursion example directly following the class definition will still work, but is the intent of the constructor to set the incoming `data` parameter to `self._data`?"},"comment":{"url":"https://api.github.com/repos/bslatkin/effectivepython/issues/comments/105272198","html_url":"https://github.com/bslatkin/effectivepython/issues/19#issuecomment-105272198","issue_url":"https://api.github.com/repos/bslatkin/effectivepython/issues/19","id":105272198,"user":{"login":"bslatkin","id":68086,"avatar_url":"https://avatars.githubusercontent.com/u/68086?v=3","gravatar_id":"","url":"https://api.github.com/users/bslatkin","html_url":"https://github.com/bslatkin","followers_url":"https://api.github.com/users/bslatkin/followers","following_url":"https://api.github.com/users/bslatkin/following{/other_user}","gists_url":"https://api.github.com/users/bslatkin/gists{/gist_id}","starred_url":"https://api.github.com/users/bslatkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bslatkin/subscriptions","organizations_url":"https://api.github.com/users/bslatkin/orgs","repos_url":"https://api.github.com/users/bslatkin/repos","events_url":"https://api.github.com/users/bslatkin/events{/privacy}","received_events_url":"https://api.github.com/users/bslatkin/received_events","type":"User","site_admin":false},"created_at":"2015-05-25T17:18:15Z","updated_at":"2015-05-25T17:18:15Z","body":"I think you mean this:\r\n\r\n```\r\nclass BrokenDictionaryDB(object):\r\n    def __init__(self, data):\r\n        self._data = {}\r\n```\r\n\r\nShould instead be:\r\n\r\n```\r\nclass BrokenDictionaryDB(object):\r\n    def __init__(self, data):\r\n        self._data = data\r\n```\r\n\r\nIs that right?"}}