{"action":"closed","number":111,"pull_request":{"url":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/111","id":45231751,"html_url":"https://github.com/PHPAuth/PHPAuth/pull/111","diff_url":"https://github.com/PHPAuth/PHPAuth/pull/111.diff","patch_url":"https://github.com/PHPAuth/PHPAuth/pull/111.patch","issue_url":"https://api.github.com/repos/PHPAuth/PHPAuth/issues/111","number":111,"state":"closed","locked":false,"title":"Inefficient count system","user":{"login":"bugada","id":4438193,"avatar_url":"https://avatars.githubusercontent.com/u/4438193?v=3","gravatar_id":"","url":"https://api.github.com/users/bugada","html_url":"https://github.com/bugada","followers_url":"https://api.github.com/users/bugada/followers","following_url":"https://api.github.com/users/bugada/following{/other_user}","gists_url":"https://api.github.com/users/bugada/gists{/gist_id}","starred_url":"https://api.github.com/users/bugada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugada/subscriptions","organizations_url":"https://api.github.com/users/bugada/orgs","repos_url":"https://api.github.com/users/bugada/repos","events_url":"https://api.github.com/users/bugada/events{/privacy}","received_events_url":"https://api.github.com/users/bugada/received_events","type":"User","site_admin":false},"body":"Better use select count(*) instead of $query->rowCount() when not using others fetched params.\n<a href='#crh-start'></a><a href='#crh-data-%7B%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n<a href='https://www.codereviewhub.com/PHPAuth/PHPAuth/pull/111?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/PHPAuth/PHPAuth/pull/111'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>","created_at":"2015-09-16T22:23:20Z","updated_at":"2015-09-16T23:05:11Z","closed_at":"2015-09-16T23:05:11Z","merged_at":"2015-09-16T23:05:11Z","merge_commit_sha":"4158f26d86e1e0f6fa6a2aa78e4f53ac2be32451","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/111/commits","review_comments_url":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/111/comments","review_comment_url":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHPAuth/PHPAuth/issues/111/comments","statuses_url":"https://api.github.com/repos/PHPAuth/PHPAuth/statuses/64428cb5e89ed77f1b720ac98655314318869a23","head":{"label":"bugada:master","ref":"master","sha":"64428cb5e89ed77f1b720ac98655314318869a23","user":{"login":"bugada","id":4438193,"avatar_url":"https://avatars.githubusercontent.com/u/4438193?v=3","gravatar_id":"","url":"https://api.github.com/users/bugada","html_url":"https://github.com/bugada","followers_url":"https://api.github.com/users/bugada/followers","following_url":"https://api.github.com/users/bugada/following{/other_user}","gists_url":"https://api.github.com/users/bugada/gists{/gist_id}","starred_url":"https://api.github.com/users/bugada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugada/subscriptions","organizations_url":"https://api.github.com/users/bugada/orgs","repos_url":"https://api.github.com/users/bugada/repos","events_url":"https://api.github.com/users/bugada/events{/privacy}","received_events_url":"https://api.github.com/users/bugada/received_events","type":"User","site_admin":false},"repo":{"id":42616211,"name":"PHPAuth","full_name":"bugada/PHPAuth","owner":{"login":"bugada","id":4438193,"avatar_url":"https://avatars.githubusercontent.com/u/4438193?v=3","gravatar_id":"","url":"https://api.github.com/users/bugada","html_url":"https://github.com/bugada","followers_url":"https://api.github.com/users/bugada/followers","following_url":"https://api.github.com/users/bugada/following{/other_user}","gists_url":"https://api.github.com/users/bugada/gists{/gist_id}","starred_url":"https://api.github.com/users/bugada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bugada/subscriptions","organizations_url":"https://api.github.com/users/bugada/orgs","repos_url":"https://api.github.com/users/bugada/repos","events_url":"https://api.github.com/users/bugada/events{/privacy}","received_events_url":"https://api.github.com/users/bugada/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bugada/PHPAuth","description":"  PHPAuth is a secure PHP Authentication class that easily integrates into any site. ","fork":true,"url":"https://api.github.com/repos/bugada/PHPAuth","forks_url":"https://api.github.com/repos/bugada/PHPAuth/forks","keys_url":"https://api.github.com/repos/bugada/PHPAuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bugada/PHPAuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bugada/PHPAuth/teams","hooks_url":"https://api.github.com/repos/bugada/PHPAuth/hooks","issue_events_url":"https://api.github.com/repos/bugada/PHPAuth/issues/events{/number}","events_url":"https://api.github.com/repos/bugada/PHPAuth/events","assignees_url":"https://api.github.com/repos/bugada/PHPAuth/assignees{/user}","branches_url":"https://api.github.com/repos/bugada/PHPAuth/branches{/branch}","tags_url":"https://api.github.com/repos/bugada/PHPAuth/tags","blobs_url":"https://api.github.com/repos/bugada/PHPAuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bugada/PHPAuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bugada/PHPAuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/bugada/PHPAuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bugada/PHPAuth/statuses/{sha}","languages_url":"https://api.github.com/repos/bugada/PHPAuth/languages","stargazers_url":"https://api.github.com/repos/bugada/PHPAuth/stargazers","contributors_url":"https://api.github.com/repos/bugada/PHPAuth/contributors","subscribers_url":"https://api.github.com/repos/bugada/PHPAuth/subscribers","subscription_url":"https://api.github.com/repos/bugada/PHPAuth/subscription","commits_url":"https://api.github.com/repos/bugada/PHPAuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/bugada/PHPAuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/bugada/PHPAuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/bugada/PHPAuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/bugada/PHPAuth/contents/{+path}","compare_url":"https://api.github.com/repos/bugada/PHPAuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bugada/PHPAuth/merges","archive_url":"https://api.github.com/repos/bugada/PHPAuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bugada/PHPAuth/downloads","issues_url":"https://api.github.com/repos/bugada/PHPAuth/issues{/number}","pulls_url":"https://api.github.com/repos/bugada/PHPAuth/pulls{/number}","milestones_url":"https://api.github.com/repos/bugada/PHPAuth/milestones{/number}","notifications_url":"https://api.github.com/repos/bugada/PHPAuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bugada/PHPAuth/labels{/name}","releases_url":"https://api.github.com/repos/bugada/PHPAuth/releases{/id}","created_at":"2015-09-16T22:12:11Z","updated_at":"2015-09-16T22:12:11Z","pushed_at":"2015-09-16T22:21:22Z","git_url":"git://github.com/bugada/PHPAuth.git","ssh_url":"git@github.com:bugada/PHPAuth.git","clone_url":"https://github.com/bugada/PHPAuth.git","svn_url":"https://github.com/bugada/PHPAuth","homepage":"https://phpauth.github.io/PHPAuth","size":1479,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PHPAuth:master","ref":"master","sha":"ec04f0b2b2a20f482a28c5a1ac26f1b10d853adf","user":{"login":"PHPAuth","id":6495869,"avatar_url":"https://avatars.githubusercontent.com/u/6495869?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPAuth","html_url":"https://github.com/PHPAuth","followers_url":"https://api.github.com/users/PHPAuth/followers","following_url":"https://api.github.com/users/PHPAuth/following{/other_user}","gists_url":"https://api.github.com/users/PHPAuth/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPAuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPAuth/subscriptions","organizations_url":"https://api.github.com/users/PHPAuth/orgs","repos_url":"https://api.github.com/users/PHPAuth/repos","events_url":"https://api.github.com/users/PHPAuth/events{/privacy}","received_events_url":"https://api.github.com/users/PHPAuth/received_events","type":"Organization","site_admin":false},"repo":{"id":16240483,"name":"PHPAuth","full_name":"PHPAuth/PHPAuth","owner":{"login":"PHPAuth","id":6495869,"avatar_url":"https://avatars.githubusercontent.com/u/6495869?v=3","gravatar_id":"","url":"https://api.github.com/users/PHPAuth","html_url":"https://github.com/PHPAuth","followers_url":"https://api.github.com/users/PHPAuth/followers","following_url":"https://api.github.com/users/PHPAuth/following{/other_user}","gists_url":"https://api.github.com/users/PHPAuth/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPAuth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPAuth/subscriptions","organizations_url":"https://api.github.com/users/PHPAuth/orgs","repos_url":"https://api.github.com/users/PHPAuth/repos","events_url":"https://api.github.com/users/PHPAuth/events{/privacy}","received_events_url":"https://api.github.com/users/PHPAuth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PHPAuth/PHPAuth","description":"  PHPAuth is a secure PHP Authentication class that easily integrates into any site. ","fork":false,"url":"https://api.github.com/repos/PHPAuth/PHPAuth","forks_url":"https://api.github.com/repos/PHPAuth/PHPAuth/forks","keys_url":"https://api.github.com/repos/PHPAuth/PHPAuth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPAuth/PHPAuth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPAuth/PHPAuth/teams","hooks_url":"https://api.github.com/repos/PHPAuth/PHPAuth/hooks","issue_events_url":"https://api.github.com/repos/PHPAuth/PHPAuth/issues/events{/number}","events_url":"https://api.github.com/repos/PHPAuth/PHPAuth/events","assignees_url":"https://api.github.com/repos/PHPAuth/PHPAuth/assignees{/user}","branches_url":"https://api.github.com/repos/PHPAuth/PHPAuth/branches{/branch}","tags_url":"https://api.github.com/repos/PHPAuth/PHPAuth/tags","blobs_url":"https://api.github.com/repos/PHPAuth/PHPAuth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPAuth/PHPAuth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPAuth/PHPAuth/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPAuth/PHPAuth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPAuth/PHPAuth/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPAuth/PHPAuth/languages","stargazers_url":"https://api.github.com/repos/PHPAuth/PHPAuth/stargazers","contributors_url":"https://api.github.com/repos/PHPAuth/PHPAuth/contributors","subscribers_url":"https://api.github.com/repos/PHPAuth/PHPAuth/subscribers","subscription_url":"https://api.github.com/repos/PHPAuth/PHPAuth/subscription","commits_url":"https://api.github.com/repos/PHPAuth/PHPAuth/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPAuth/PHPAuth/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPAuth/PHPAuth/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPAuth/PHPAuth/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHPAuth/PHPAuth/contents/{+path}","compare_url":"https://api.github.com/repos/PHPAuth/PHPAuth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPAuth/PHPAuth/merges","archive_url":"https://api.github.com/repos/PHPAuth/PHPAuth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPAuth/PHPAuth/downloads","issues_url":"https://api.github.com/repos/PHPAuth/PHPAuth/issues{/number}","pulls_url":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPAuth/PHPAuth/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPAuth/PHPAuth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPAuth/PHPAuth/labels{/name}","releases_url":"https://api.github.com/repos/PHPAuth/PHPAuth/releases{/id}","created_at":"2014-01-25T21:34:44Z","updated_at":"2015-09-11T21:55:41Z","pushed_at":"2015-09-16T23:05:12Z","git_url":"git://github.com/PHPAuth/PHPAuth.git","ssh_url":"git@github.com:PHPAuth/PHPAuth.git","clone_url":"https://github.com/PHPAuth/PHPAuth.git","svn_url":"https://github.com/PHPAuth/PHPAuth","homepage":"https://phpauth.github.io/PHPAuth","size":1479,"stargazers_count":76,"watchers_count":76,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":12,"forks":55,"open_issues":12,"watchers":76,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/111"},"html":{"href":"https://github.com/PHPAuth/PHPAuth/pull/111"},"issue":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/issues/111"},"comments":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/PHPAuth/PHPAuth/statuses/64428cb5e89ed77f1b720ac98655314318869a23"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Conver","id":6231022,"avatar_url":"https://avatars.githubusercontent.com/u/6231022?v=3","gravatar_id":"","url":"https://api.github.com/users/Conver","html_url":"https://github.com/Conver","followers_url":"https://api.github.com/users/Conver/followers","following_url":"https://api.github.com/users/Conver/following{/other_user}","gists_url":"https://api.github.com/users/Conver/gists{/gist_id}","starred_url":"https://api.github.com/users/Conver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Conver/subscriptions","organizations_url":"https://api.github.com/users/Conver/orgs","repos_url":"https://api.github.com/users/Conver/repos","events_url":"https://api.github.com/users/Conver/events{/privacy}","received_events_url":"https://api.github.com/users/Conver/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":7,"deletions":7,"changed_files":1}}