{"action":"created","comment":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/comments/27848269","id":27848269,"diff_hunk":"@@ -283,8 +283,13 @@ static ResultCode ArbitrateAddress(Handle handle, u32 address, u32 type, u32 val\n     if (arbiter == nullptr)\n         return ERR_INVALID_HANDLE;\n \n-    return arbiter->ArbitrateAddress(static_cast<Kernel::ArbitrationType>(type),\n-            address, value, nanoseconds);\n+    auto res = arbiter->ArbitrateAddress(static_cast<Kernel::ArbitrationType>(type),\n+                                         address, value, nanoseconds);\n+\n+    if (res == RESULT_SUCCESS)\n+        HLE::Reschedule(__func__);","path":"src/core/hle/svc.cpp","position":10,"original_position":10,"commit_id":"37e3f107a3ef4ecd316f0a3d84334adfb4031c65","original_commit_id":"37e3f107a3ef4ecd316f0a3d84334adfb4031c65","user":{"login":"Subv","id":357072,"avatar_url":"https://avatars.githubusercontent.com/u/357072?v=3","gravatar_id":"","url":"https://api.github.com/users/Subv","html_url":"https://github.com/Subv","followers_url":"https://api.github.com/users/Subv/followers","following_url":"https://api.github.com/users/Subv/following{/other_user}","gists_url":"https://api.github.com/users/Subv/gists{/gist_id}","starred_url":"https://api.github.com/users/Subv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subv/subscriptions","organizations_url":"https://api.github.com/users/Subv/orgs","repos_url":"https://api.github.com/users/Subv/repos","events_url":"https://api.github.com/users/Subv/events{/privacy}","received_events_url":"https://api.github.com/users/Subv/received_events","type":"User","site_admin":false},"body":"You're now rescheduling twice when this is called, i suggest removing the Reschedule calls from inside ArbitrateAddress","created_at":"2015-04-07T02:47:31Z","updated_at":"2015-04-07T02:47:31Z","html_url":"https://github.com/citra-emu/citra/pull/683#discussion_r27848269","pull_request_url":"https://api.github.com/repos/citra-emu/citra/pulls/683","_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments/27848269"},"html":{"href":"https://github.com/citra-emu/citra/pull/683#discussion_r27848269"},"pull_request":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/683"}}},"pull_request":{"url":"https://api.github.com/repos/citra-emu/citra/pulls/683","id":32658920,"html_url":"https://github.com/citra-emu/citra/pull/683","diff_url":"https://github.com/citra-emu/citra/pull/683.diff","patch_url":"https://github.com/citra-emu/citra/pull/683.patch","issue_url":"https://api.github.com/repos/citra-emu/citra/issues/683","number":683,"state":"open","locked":false,"title":"Thread priority and scheduler improvements","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"body":"Adds support for priority boosting for starved threads, priority inheritance for mutexes, some additional (verified) error codes on svcCreateThread, and some additional bug fixes/improvements. I've written some hardware tests that I'll publish at a later time that verify these changes. Some outstanding things for my next PR:\r\n* Identify any other scenarios (other than a mutex wait) that might cause priority inheritance (and implement)\r\n* Implement kernel reschedule on other SVCs as appropriate\r\n* RE other error codes that are used and implement","created_at":"2015-04-06T02:24:28Z","updated_at":"2015-04-07T02:47:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c8e73d5aea8d62fb71089e09e954ad8de17dde4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/citra-emu/citra/pulls/683/commits","review_comments_url":"https://api.github.com/repos/citra-emu/citra/pulls/683/comments","review_comment_url":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/citra-emu/citra/issues/683/comments","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/37e3f107a3ef4ecd316f0a3d84334adfb4031c65","head":{"label":"bunnei:thread-priority","ref":"thread-priority","sha":"37e3f107a3ef4ecd316f0a3d84334adfb4031c65","user":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"repo":{"id":19964905,"name":"citra","full_name":"bunnei/citra","owner":{"login":"bunnei","id":6956688,"avatar_url":"https://avatars.githubusercontent.com/u/6956688?v=3","gravatar_id":"","url":"https://api.github.com/users/bunnei","html_url":"https://github.com/bunnei","followers_url":"https://api.github.com/users/bunnei/followers","following_url":"https://api.github.com/users/bunnei/following{/other_user}","gists_url":"https://api.github.com/users/bunnei/gists{/gist_id}","starred_url":"https://api.github.com/users/bunnei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bunnei/subscriptions","organizations_url":"https://api.github.com/users/bunnei/orgs","repos_url":"https://api.github.com/users/bunnei/repos","events_url":"https://api.github.com/users/bunnei/events{/privacy}","received_events_url":"https://api.github.com/users/bunnei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bunnei/citra","description":"Nintendo 3DS emulator/debugger","fork":true,"url":"https://api.github.com/repos/bunnei/citra","forks_url":"https://api.github.com/repos/bunnei/citra/forks","keys_url":"https://api.github.com/repos/bunnei/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bunnei/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bunnei/citra/teams","hooks_url":"https://api.github.com/repos/bunnei/citra/hooks","issue_events_url":"https://api.github.com/repos/bunnei/citra/issues/events{/number}","events_url":"https://api.github.com/repos/bunnei/citra/events","assignees_url":"https://api.github.com/repos/bunnei/citra/assignees{/user}","branches_url":"https://api.github.com/repos/bunnei/citra/branches{/branch}","tags_url":"https://api.github.com/repos/bunnei/citra/tags","blobs_url":"https://api.github.com/repos/bunnei/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bunnei/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bunnei/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/bunnei/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bunnei/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/bunnei/citra/languages","stargazers_url":"https://api.github.com/repos/bunnei/citra/stargazers","contributors_url":"https://api.github.com/repos/bunnei/citra/contributors","subscribers_url":"https://api.github.com/repos/bunnei/citra/subscribers","subscription_url":"https://api.github.com/repos/bunnei/citra/subscription","commits_url":"https://api.github.com/repos/bunnei/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/bunnei/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/bunnei/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/bunnei/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/bunnei/citra/contents/{+path}","compare_url":"https://api.github.com/repos/bunnei/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bunnei/citra/merges","archive_url":"https://api.github.com/repos/bunnei/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bunnei/citra/downloads","issues_url":"https://api.github.com/repos/bunnei/citra/issues{/number}","pulls_url":"https://api.github.com/repos/bunnei/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/bunnei/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/bunnei/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bunnei/citra/labels{/name}","releases_url":"https://api.github.com/repos/bunnei/citra/releases{/id}","created_at":"2014-05-20T02:28:14Z","updated_at":"2015-03-20T17:20:59Z","pushed_at":"2015-04-07T02:24:38Z","git_url":"git://github.com/bunnei/citra.git","ssh_url":"git@github.com:bunnei/citra.git","clone_url":"https://github.com/bunnei/citra.git","svn_url":"https://github.com/bunnei/citra","homepage":null,"size":9509,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":0,"forks":12,"open_issues":0,"watchers":49,"default_branch":"master"}},"base":{"label":"citra-emu:master","ref":"master","sha":"11bd6024fb2d09b11df3ef12f7188a5b3be5c577","user":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":19866730,"name":"citra","full_name":"citra-emu/citra","owner":{"login":"citra-emu","id":7605670,"avatar_url":"https://avatars.githubusercontent.com/u/7605670?v=3","gravatar_id":"","url":"https://api.github.com/users/citra-emu","html_url":"https://github.com/citra-emu","followers_url":"https://api.github.com/users/citra-emu/followers","following_url":"https://api.github.com/users/citra-emu/following{/other_user}","gists_url":"https://api.github.com/users/citra-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/citra-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/citra-emu/subscriptions","organizations_url":"https://api.github.com/users/citra-emu/orgs","repos_url":"https://api.github.com/users/citra-emu/repos","events_url":"https://api.github.com/users/citra-emu/events{/privacy}","received_events_url":"https://api.github.com/users/citra-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/citra-emu/citra","description":"Nintendo 3DS emulator/debugger","fork":false,"url":"https://api.github.com/repos/citra-emu/citra","forks_url":"https://api.github.com/repos/citra-emu/citra/forks","keys_url":"https://api.github.com/repos/citra-emu/citra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/citra-emu/citra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/citra-emu/citra/teams","hooks_url":"https://api.github.com/repos/citra-emu/citra/hooks","issue_events_url":"https://api.github.com/repos/citra-emu/citra/issues/events{/number}","events_url":"https://api.github.com/repos/citra-emu/citra/events","assignees_url":"https://api.github.com/repos/citra-emu/citra/assignees{/user}","branches_url":"https://api.github.com/repos/citra-emu/citra/branches{/branch}","tags_url":"https://api.github.com/repos/citra-emu/citra/tags","blobs_url":"https://api.github.com/repos/citra-emu/citra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/citra-emu/citra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/citra-emu/citra/git/refs{/sha}","trees_url":"https://api.github.com/repos/citra-emu/citra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/citra-emu/citra/statuses/{sha}","languages_url":"https://api.github.com/repos/citra-emu/citra/languages","stargazers_url":"https://api.github.com/repos/citra-emu/citra/stargazers","contributors_url":"https://api.github.com/repos/citra-emu/citra/contributors","subscribers_url":"https://api.github.com/repos/citra-emu/citra/subscribers","subscription_url":"https://api.github.com/repos/citra-emu/citra/subscription","commits_url":"https://api.github.com/repos/citra-emu/citra/commits{/sha}","git_commits_url":"https://api.github.com/repos/citra-emu/citra/git/commits{/sha}","comments_url":"https://api.github.com/repos/citra-emu/citra/comments{/number}","issue_comment_url":"https://api.github.com/repos/citra-emu/citra/issues/comments{/number}","contents_url":"https://api.github.com/repos/citra-emu/citra/contents/{+path}","compare_url":"https://api.github.com/repos/citra-emu/citra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/citra-emu/citra/merges","archive_url":"https://api.github.com/repos/citra-emu/citra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/citra-emu/citra/downloads","issues_url":"https://api.github.com/repos/citra-emu/citra/issues{/number}","pulls_url":"https://api.github.com/repos/citra-emu/citra/pulls{/number}","milestones_url":"https://api.github.com/repos/citra-emu/citra/milestones{/number}","notifications_url":"https://api.github.com/repos/citra-emu/citra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/citra-emu/citra/labels{/name}","releases_url":"https://api.github.com/repos/citra-emu/citra/releases{/id}","created_at":"2014-05-16T18:33:15Z","updated_at":"2015-04-07T01:22:00Z","pushed_at":"2015-04-07T02:24:39Z","git_url":"git://github.com/citra-emu/citra.git","ssh_url":"git@github.com:citra-emu/citra.git","clone_url":"https://github.com/citra-emu/citra.git","svn_url":"https://github.com/citra-emu/citra","homepage":null,"size":21304,"stargazers_count":737,"watchers_count":737,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"open_issues_count":41,"forks":184,"open_issues":41,"watchers":737,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/683"},"html":{"href":"https://github.com/citra-emu/citra/pull/683"},"issue":{"href":"https://api.github.com/repos/citra-emu/citra/issues/683"},"comments":{"href":"https://api.github.com/repos/citra-emu/citra/issues/683/comments"},"review_comments":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/683/comments"},"review_comment":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/citra-emu/citra/pulls/683/commits"},"statuses":{"href":"https://api.github.com/repos/citra-emu/citra/statuses/37e3f107a3ef4ecd316f0a3d84334adfb4031c65"}}}}