{"action":"created","comment":{"url":"https://api.github.com/repos/ajvb/kala/pulls/comments/37600611","id":37600611,"diff_hunk":"@@ -115,6 +115,18 @@ func (c *MemoryJobCache) Delete(id string) {\n \tc.jobs.Lock.Lock()\n \tdefer c.jobs.Lock.Unlock()\n \n+\tj := c.jobs.Jobs[id]\n+\tif j == nil {\n+\t\t// TODO\n+\t\t//return nil, JobDoesntExistErr\n+\t\treturn\n+\t}\n+\n+\t// TODO return error\n+\tc.jobs.Lock.Unlock()","path":"job/cache.go","position":12,"original_position":12,"commit_id":"9f6eba5771797b504d07dae05e8260c066cdfc38","original_commit_id":"9f6eba5771797b504d07dae05e8260c066cdfc38","user":{"login":"elimisteve","id":139603,"avatar_url":"https://avatars.githubusercontent.com/u/139603?v=3","gravatar_id":"","url":"https://api.github.com/users/elimisteve","html_url":"https://github.com/elimisteve","followers_url":"https://api.github.com/users/elimisteve/followers","following_url":"https://api.github.com/users/elimisteve/following{/other_user}","gists_url":"https://api.github.com/users/elimisteve/gists{/gist_id}","starred_url":"https://api.github.com/users/elimisteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elimisteve/subscriptions","organizations_url":"https://api.github.com/users/elimisteve/orgs","repos_url":"https://api.github.com/users/elimisteve/repos","events_url":"https://api.github.com/users/elimisteve/events{/privacy}","received_events_url":"https://api.github.com/users/elimisteve/received_events","type":"User","site_admin":false},"body":"@ajvb There are almost certainly too many locks in this program. Think about how you can use channels to simplify all this; it's getting too hard to get right IMO.","created_at":"2015-08-21T02:01:23Z","updated_at":"2015-08-21T02:01:23Z","html_url":"https://github.com/ajvb/kala/pull/60#discussion_r37600611","pull_request_url":"https://api.github.com/repos/ajvb/kala/pulls/60","_links":{"self":{"href":"https://api.github.com/repos/ajvb/kala/pulls/comments/37600611"},"html":{"href":"https://github.com/ajvb/kala/pull/60#discussion_r37600611"},"pull_request":{"href":"https://api.github.com/repos/ajvb/kala/pulls/60"}}},"pull_request":{"url":"https://api.github.com/repos/ajvb/kala/pulls/60","id":42996748,"html_url":"https://github.com/ajvb/kala/pull/60","diff_url":"https://github.com/ajvb/kala/pull/60.diff","patch_url":"https://github.com/ajvb/kala/pull/60.patch","issue_url":"https://api.github.com/repos/ajvb/kala/issues/60","number":60,"state":"open","locked":false,"title":"Add more dependency chain tests 44","user":{"login":"ajvb","id":1144310,"avatar_url":"https://avatars.githubusercontent.com/u/1144310?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvb","html_url":"https://github.com/ajvb","followers_url":"https://api.github.com/users/ajvb/followers","following_url":"https://api.github.com/users/ajvb/following{/other_user}","gists_url":"https://api.github.com/users/ajvb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvb/subscriptions","organizations_url":"https://api.github.com/users/ajvb/orgs","repos_url":"https://api.github.com/users/ajvb/repos","events_url":"https://api.github.com/users/ajvb/events{/privacy}","received_events_url":"https://api.github.com/users/ajvb/received_events","type":"User","site_admin":false},"body":"Related to #44","created_at":"2015-08-21T01:43:32Z","updated_at":"2015-08-21T02:01:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3693db2eedbba7560b714e937870c21d8de93871","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ajvb/kala/pulls/60/commits","review_comments_url":"https://api.github.com/repos/ajvb/kala/pulls/60/comments","review_comment_url":"https://api.github.com/repos/ajvb/kala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ajvb/kala/issues/60/comments","statuses_url":"https://api.github.com/repos/ajvb/kala/statuses/9f6eba5771797b504d07dae05e8260c066cdfc38","head":{"label":"ajvb:add_more_dependency_chain_tests_44","ref":"add_more_dependency_chain_tests_44","sha":"9f6eba5771797b504d07dae05e8260c066cdfc38","user":{"login":"ajvb","id":1144310,"avatar_url":"https://avatars.githubusercontent.com/u/1144310?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvb","html_url":"https://github.com/ajvb","followers_url":"https://api.github.com/users/ajvb/followers","following_url":"https://api.github.com/users/ajvb/following{/other_user}","gists_url":"https://api.github.com/users/ajvb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvb/subscriptions","organizations_url":"https://api.github.com/users/ajvb/orgs","repos_url":"https://api.github.com/users/ajvb/repos","events_url":"https://api.github.com/users/ajvb/events{/privacy}","received_events_url":"https://api.github.com/users/ajvb/received_events","type":"User","site_admin":false},"repo":{"id":32500617,"name":"kala","full_name":"ajvb/kala","owner":{"login":"ajvb","id":1144310,"avatar_url":"https://avatars.githubusercontent.com/u/1144310?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvb","html_url":"https://github.com/ajvb","followers_url":"https://api.github.com/users/ajvb/followers","following_url":"https://api.github.com/users/ajvb/following{/other_user}","gists_url":"https://api.github.com/users/ajvb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvb/subscriptions","organizations_url":"https://api.github.com/users/ajvb/orgs","repos_url":"https://api.github.com/users/ajvb/repos","events_url":"https://api.github.com/users/ajvb/events{/privacy}","received_events_url":"https://api.github.com/users/ajvb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajvb/kala","description":"Modern Job Scheduler","fork":false,"url":"https://api.github.com/repos/ajvb/kala","forks_url":"https://api.github.com/repos/ajvb/kala/forks","keys_url":"https://api.github.com/repos/ajvb/kala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajvb/kala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajvb/kala/teams","hooks_url":"https://api.github.com/repos/ajvb/kala/hooks","issue_events_url":"https://api.github.com/repos/ajvb/kala/issues/events{/number}","events_url":"https://api.github.com/repos/ajvb/kala/events","assignees_url":"https://api.github.com/repos/ajvb/kala/assignees{/user}","branches_url":"https://api.github.com/repos/ajvb/kala/branches{/branch}","tags_url":"https://api.github.com/repos/ajvb/kala/tags","blobs_url":"https://api.github.com/repos/ajvb/kala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajvb/kala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajvb/kala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajvb/kala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajvb/kala/statuses/{sha}","languages_url":"https://api.github.com/repos/ajvb/kala/languages","stargazers_url":"https://api.github.com/repos/ajvb/kala/stargazers","contributors_url":"https://api.github.com/repos/ajvb/kala/contributors","subscribers_url":"https://api.github.com/repos/ajvb/kala/subscribers","subscription_url":"https://api.github.com/repos/ajvb/kala/subscription","commits_url":"https://api.github.com/repos/ajvb/kala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajvb/kala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajvb/kala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajvb/kala/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajvb/kala/contents/{+path}","compare_url":"https://api.github.com/repos/ajvb/kala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajvb/kala/merges","archive_url":"https://api.github.com/repos/ajvb/kala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajvb/kala/downloads","issues_url":"https://api.github.com/repos/ajvb/kala/issues{/number}","pulls_url":"https://api.github.com/repos/ajvb/kala/pulls{/number}","milestones_url":"https://api.github.com/repos/ajvb/kala/milestones{/number}","notifications_url":"https://api.github.com/repos/ajvb/kala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajvb/kala/labels{/name}","releases_url":"https://api.github.com/repos/ajvb/kala/releases{/id}","created_at":"2015-03-19T04:24:19Z","updated_at":"2015-08-20T21:00:57Z","pushed_at":"2015-08-21T01:43:32Z","git_url":"git://github.com/ajvb/kala.git","ssh_url":"git@github.com:ajvb/kala.git","clone_url":"https://github.com/ajvb/kala.git","svn_url":"https://github.com/ajvb/kala","homepage":"","size":967,"stargazers_count":665,"watchers_count":665,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":17,"forks":20,"open_issues":17,"watchers":665,"default_branch":"master"}},"base":{"label":"ajvb:master","ref":"master","sha":"b8318490c3c397046313782303a9053be3fa7bc4","user":{"login":"ajvb","id":1144310,"avatar_url":"https://avatars.githubusercontent.com/u/1144310?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvb","html_url":"https://github.com/ajvb","followers_url":"https://api.github.com/users/ajvb/followers","following_url":"https://api.github.com/users/ajvb/following{/other_user}","gists_url":"https://api.github.com/users/ajvb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvb/subscriptions","organizations_url":"https://api.github.com/users/ajvb/orgs","repos_url":"https://api.github.com/users/ajvb/repos","events_url":"https://api.github.com/users/ajvb/events{/privacy}","received_events_url":"https://api.github.com/users/ajvb/received_events","type":"User","site_admin":false},"repo":{"id":32500617,"name":"kala","full_name":"ajvb/kala","owner":{"login":"ajvb","id":1144310,"avatar_url":"https://avatars.githubusercontent.com/u/1144310?v=3","gravatar_id":"","url":"https://api.github.com/users/ajvb","html_url":"https://github.com/ajvb","followers_url":"https://api.github.com/users/ajvb/followers","following_url":"https://api.github.com/users/ajvb/following{/other_user}","gists_url":"https://api.github.com/users/ajvb/gists{/gist_id}","starred_url":"https://api.github.com/users/ajvb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajvb/subscriptions","organizations_url":"https://api.github.com/users/ajvb/orgs","repos_url":"https://api.github.com/users/ajvb/repos","events_url":"https://api.github.com/users/ajvb/events{/privacy}","received_events_url":"https://api.github.com/users/ajvb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajvb/kala","description":"Modern Job Scheduler","fork":false,"url":"https://api.github.com/repos/ajvb/kala","forks_url":"https://api.github.com/repos/ajvb/kala/forks","keys_url":"https://api.github.com/repos/ajvb/kala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajvb/kala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajvb/kala/teams","hooks_url":"https://api.github.com/repos/ajvb/kala/hooks","issue_events_url":"https://api.github.com/repos/ajvb/kala/issues/events{/number}","events_url":"https://api.github.com/repos/ajvb/kala/events","assignees_url":"https://api.github.com/repos/ajvb/kala/assignees{/user}","branches_url":"https://api.github.com/repos/ajvb/kala/branches{/branch}","tags_url":"https://api.github.com/repos/ajvb/kala/tags","blobs_url":"https://api.github.com/repos/ajvb/kala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajvb/kala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajvb/kala/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajvb/kala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajvb/kala/statuses/{sha}","languages_url":"https://api.github.com/repos/ajvb/kala/languages","stargazers_url":"https://api.github.com/repos/ajvb/kala/stargazers","contributors_url":"https://api.github.com/repos/ajvb/kala/contributors","subscribers_url":"https://api.github.com/repos/ajvb/kala/subscribers","subscription_url":"https://api.github.com/repos/ajvb/kala/subscription","commits_url":"https://api.github.com/repos/ajvb/kala/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajvb/kala/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajvb/kala/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajvb/kala/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajvb/kala/contents/{+path}","compare_url":"https://api.github.com/repos/ajvb/kala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajvb/kala/merges","archive_url":"https://api.github.com/repos/ajvb/kala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajvb/kala/downloads","issues_url":"https://api.github.com/repos/ajvb/kala/issues{/number}","pulls_url":"https://api.github.com/repos/ajvb/kala/pulls{/number}","milestones_url":"https://api.github.com/repos/ajvb/kala/milestones{/number}","notifications_url":"https://api.github.com/repos/ajvb/kala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajvb/kala/labels{/name}","releases_url":"https://api.github.com/repos/ajvb/kala/releases{/id}","created_at":"2015-03-19T04:24:19Z","updated_at":"2015-08-20T21:00:57Z","pushed_at":"2015-08-21T01:43:32Z","git_url":"git://github.com/ajvb/kala.git","ssh_url":"git@github.com:ajvb/kala.git","clone_url":"https://github.com/ajvb/kala.git","svn_url":"https://github.com/ajvb/kala","homepage":"","size":967,"stargazers_count":665,"watchers_count":665,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":17,"forks":20,"open_issues":17,"watchers":665,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ajvb/kala/pulls/60"},"html":{"href":"https://github.com/ajvb/kala/pull/60"},"issue":{"href":"https://api.github.com/repos/ajvb/kala/issues/60"},"comments":{"href":"https://api.github.com/repos/ajvb/kala/issues/60/comments"},"review_comments":{"href":"https://api.github.com/repos/ajvb/kala/pulls/60/comments"},"review_comment":{"href":"https://api.github.com/repos/ajvb/kala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ajvb/kala/pulls/60/commits"},"statuses":{"href":"https://api.github.com/repos/ajvb/kala/statuses/9f6eba5771797b504d07dae05e8260c066cdfc38"}}}}