{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/454","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/454/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/454/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/454/events","html_url":"https://github.com/vufind-org/vufind/pull/454","id":103818151,"number":454,"title":"Complete W3C validation of Vufind on Bootstrap3","user":{"login":"samueloph","id":2778482,"avatar_url":"https://avatars.githubusercontent.com/u/2778482?v=3","gravatar_id":"","url":"https://api.github.com/users/samueloph","html_url":"https://github.com/samueloph","followers_url":"https://api.github.com/users/samueloph/followers","following_url":"https://api.github.com/users/samueloph/following{/other_user}","gists_url":"https://api.github.com/users/samueloph/gists{/gist_id}","starred_url":"https://api.github.com/users/samueloph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueloph/subscriptions","organizations_url":"https://api.github.com/users/samueloph/orgs","repos_url":"https://api.github.com/users/samueloph/repos","events_url":"https://api.github.com/users/samueloph/events{/privacy}","received_events_url":"https://api.github.com/users/samueloph/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-29T00:49:15Z","updated_at":"2015-09-02T19:27:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/454","html_url":"https://github.com/vufind-org/vufind/pull/454","diff_url":"https://github.com/vufind-org/vufind/pull/454.diff","patch_url":"https://github.com/vufind-org/vufind/pull/454.patch"},"body":"Following this PR are a few changes in Vufind that make it validate without errors or warnings on the W3C validator (https://validator.w3.org/).\r\n\r\nI'd like to receive some opinions on the changes I made, specially on https://github.com/vufind-org/vufind/commit/31388de47f18320101b114fe4410f629f6bf796a and https://github.com/vufind-org/vufind/commit/c35270b24680b30850428d5abb2b50c0ec21df88 cause I think somebody could come up with a best solution.\r\n\r\nThere are currently one problem on the page that logged users see (that one where it shows their favorites, etc), It looks like that page is calling the searchtab twice, as seen in this error:\r\nError: Duplicate ID searchForm_lookfor.\r\n\r\nThis was the same problem faced on https://github.com/vufind-org/vufind/commit/c35270b24680b30850428d5abb2b50c0ec21df88, and I fixed it by disabling the top search bar, the unavailable error does the same thing, so i thought it would be a nice fix in this case [vufind/themes/bootstrap3/templates/error/unavailable.phtml], don't know how to fix the user page, though.\r\n\r\nAny views on how to solve the favorite issue or a better approach to any of the commits?\r\n\r\nThe homepage and advanced search are already being validated nicely:\r\n\r\nBEFORE: (not really before, this print is with a few fixes already committed)\r\n![screenshot from 2015-08-25 17-31-20](https://cloud.githubusercontent.com/assets/2778482/9559679/ddd9989e-4dcd-11e5-8e26-4dfc3a91630c.png)\r\n\r\nAFTER:\r\n![screenshot from 2015-08-28 21-27-10](https://cloud.githubusercontent.com/assets/2778482/9559687/f4c99e14-4dcd-11e5-9366-298ecce360d9.png)\r\n\r\nThe fixes are basic things, they include changing some ARIA's role positions or even deleting them (when don't needed).\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/137220682","html_url":"https://github.com/vufind-org/vufind/pull/454#issuecomment-137220682","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/454","id":137220682,"user":{"login":"samueloph","id":2778482,"avatar_url":"https://avatars.githubusercontent.com/u/2778482?v=3","gravatar_id":"","url":"https://api.github.com/users/samueloph","html_url":"https://github.com/samueloph","followers_url":"https://api.github.com/users/samueloph/followers","following_url":"https://api.github.com/users/samueloph/following{/other_user}","gists_url":"https://api.github.com/users/samueloph/gists{/gist_id}","starred_url":"https://api.github.com/users/samueloph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samueloph/subscriptions","organizations_url":"https://api.github.com/users/samueloph/orgs","repos_url":"https://api.github.com/users/samueloph/repos","events_url":"https://api.github.com/users/samueloph/events{/privacy}","received_events_url":"https://api.github.com/users/samueloph/received_events","type":"User","site_admin":false},"created_at":"2015-09-02T19:27:22Z","updated_at":"2015-09-02T19:27:22Z","body":"Thanks @demiankatz.\r\n\r\nI will definitely do that.\r\n\r\nI sure hope to keep on contributing with the project (I'm still going to work on that daterange's facet config).\r\n\r\nIn the next 20 hours[max] you should have a new clean PR with the fixes."}}