{"action":"opened","issue":{"url":"https://api.github.com/repos/rubinius/rubinius/issues/3384","labels_url":"https://api.github.com/repos/rubinius/rubinius/issues/3384/labels{/name}","comments_url":"https://api.github.com/repos/rubinius/rubinius/issues/3384/comments","events_url":"https://api.github.com/repos/rubinius/rubinius/issues/3384/events","html_url":"https://github.com/rubinius/rubinius/issues/3384","id":72413172,"number":3384,"title":"Two errors (and fixes) when compiling v2.5.3","user":{"login":"ff2000","id":1973708,"avatar_url":"https://avatars.githubusercontent.com/u/1973708?v=3","gravatar_id":"","url":"https://api.github.com/users/ff2000","html_url":"https://github.com/ff2000","followers_url":"https://api.github.com/users/ff2000/followers","following_url":"https://api.github.com/users/ff2000/following{/other_user}","gists_url":"https://api.github.com/users/ff2000/gists{/gist_id}","starred_url":"https://api.github.com/users/ff2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ff2000/subscriptions","organizations_url":"https://api.github.com/users/ff2000/orgs","repos_url":"https://api.github.com/users/ff2000/repos","events_url":"https://api.github.com/users/ff2000/events{/privacy}","received_events_url":"https://api.github.com/users/ff2000/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-05-01T11:32:49Z","updated_at":"2015-05-01T11:32:49Z","closed_at":null,"body":"=== 1 ===\r\nvm/builtin/jit.cpp:44:55: error: member access into incomplete type 'rubinius::Configuration'\r\n    return Integer::from(state, state->shared().config.jit_threshold_compile);\r\n[and some more places]\r\n\r\n=== 2 ===\r\nvm/signal.cpp:112:34: error: use of undeclared identifier 'RBX_LLVM_VERSION'\r\n    function(\"llvm version: %s\", RBX_LLVM_VERSION);\r\n                                 ^\r\n1 error generated.\r\n\r\n=== patch ===\r\ndiff --git a/vm/builtin/jit.cpp b/vm/builtin/jit.cpp\r\nindex 4963ab0..c4d48d7 100644\r\n--- a/vm/builtin/jit.cpp\r\n+++ b/vm/builtin/jit.cpp\r\n@@ -1,6 +1,7 @@\r\n #include \"builtin/block_environment.hpp\"\r\n #include \"builtin/jit.hpp\"\r\n #include \"builtin/list.hpp\"\r\n+#include \"configuration.hpp\"\r\n \r\n #include \"ontology.hpp\"\r\n \r\ndiff --git a/vm/signal.cpp b/vm/signal.cpp\r\nindex 25729dd..9f1b190 100644\r\n--- a/vm/signal.cpp\r\n+++ b/vm/signal.cpp\r\n@@ -109,7 +109,9 @@ namespace rubinius {\r\n     function(\"ruby version: %s\", RBX_RUBY_VERSION);\r\n     function(\"release date: %s\", RBX_RELEASE_DATE);\r\n     function(\"build revision: %s\", RBX_BUILD_REV);\r\n+#if ENABLE_LLVM\r\n     function(\"llvm version: %s\", RBX_LLVM_VERSION);\r\n+#endif\r\n     function(\"jit status: %s\",\r\n         CBOOL(signal_thread_->shared().env()->state->globals().jit.get()->enabled())\r\n         ? \"enabled\" : \"disabled\");\r\n\r\n======\r\n(I hope it's OK to post the patch here. I currently want to get things running and forking/PR takes some time. Nevertheless if you wish so I will create a PR later)\r\n\r\nThis is compilation with LLVM turned off as I only have 3.6.0 installed and rubinius restricts to <=3.5.0.\r\nAre there plans to support llvm-3.6.0/upcoming 3.7.0? What needs to be done in rubinius?"}}