{"action":"closed","number":885,"pull_request":{"url":"https://api.github.com/repos/igraph/igraph/pulls/885","id":47342641,"html_url":"https://github.com/igraph/igraph/pull/885","diff_url":"https://github.com/igraph/igraph/pull/885.diff","patch_url":"https://github.com/igraph/igraph/pull/885.patch","issue_url":"https://api.github.com/repos/igraph/igraph/issues/885","number":885,"state":"closed","locked":false,"title":"Fix igraph_lcf_vector","user":{"login":"szhorvat","id":1212871,"avatar_url":"https://avatars.githubusercontent.com/u/1212871?v=3","gravatar_id":"","url":"https://api.github.com/users/szhorvat","html_url":"https://github.com/szhorvat","followers_url":"https://api.github.com/users/szhorvat/followers","following_url":"https://api.github.com/users/szhorvat/following{/other_user}","gists_url":"https://api.github.com/users/szhorvat/gists{/gist_id}","starred_url":"https://api.github.com/users/szhorvat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szhorvat/subscriptions","organizations_url":"https://api.github.com/users/szhorvat/orgs","repos_url":"https://api.github.com/users/szhorvat/repos","events_url":"https://api.github.com/users/szhorvat/events{/privacy}","received_events_url":"https://api.github.com/users/szhorvat/received_events","type":"User","site_admin":false},"body":"For some inputs, `igraph_lcf_vector` was returning results that did not agree with the description at [MathWorld](http://mathworld.wolfram.com/LCFNotation.html), or with networkx's implementation.  One example is `shifts=[3,-2]`, `repeats=4`, `n=8`.  It also crashed for some inputs, see #880 \r\n\r\nThis patch fixes these problems and ensures that no multiple or loop edges are returned.","created_at":"2015-10-10T10:16:15Z","updated_at":"2015-10-14T13:35:49Z","closed_at":"2015-10-14T13:35:49Z","merged_at":"2015-10-14T13:35:49Z","merge_commit_sha":"3ab51590f1cf91abb72ca47d1b6c9b476fe6e0d1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/igraph/igraph/pulls/885/commits","review_comments_url":"https://api.github.com/repos/igraph/igraph/pulls/885/comments","review_comment_url":"https://api.github.com/repos/igraph/igraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/igraph/igraph/issues/885/comments","statuses_url":"https://api.github.com/repos/igraph/igraph/statuses/6a98be5f9285f4392c18dda13ba6cd2636854c64","head":{"label":"szhorvat:patch-6","ref":"patch-6","sha":"6a98be5f9285f4392c18dda13ba6cd2636854c64","user":{"login":"szhorvat","id":1212871,"avatar_url":"https://avatars.githubusercontent.com/u/1212871?v=3","gravatar_id":"","url":"https://api.github.com/users/szhorvat","html_url":"https://github.com/szhorvat","followers_url":"https://api.github.com/users/szhorvat/followers","following_url":"https://api.github.com/users/szhorvat/following{/other_user}","gists_url":"https://api.github.com/users/szhorvat/gists{/gist_id}","starred_url":"https://api.github.com/users/szhorvat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szhorvat/subscriptions","organizations_url":"https://api.github.com/users/szhorvat/orgs","repos_url":"https://api.github.com/users/szhorvat/repos","events_url":"https://api.github.com/users/szhorvat/events{/privacy}","received_events_url":"https://api.github.com/users/szhorvat/received_events","type":"User","site_admin":false},"repo":{"id":41759179,"name":"igraph","full_name":"szhorvat/igraph","owner":{"login":"szhorvat","id":1212871,"avatar_url":"https://avatars.githubusercontent.com/u/1212871?v=3","gravatar_id":"","url":"https://api.github.com/users/szhorvat","html_url":"https://github.com/szhorvat","followers_url":"https://api.github.com/users/szhorvat/followers","following_url":"https://api.github.com/users/szhorvat/following{/other_user}","gists_url":"https://api.github.com/users/szhorvat/gists{/gist_id}","starred_url":"https://api.github.com/users/szhorvat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szhorvat/subscriptions","organizations_url":"https://api.github.com/users/szhorvat/orgs","repos_url":"https://api.github.com/users/szhorvat/repos","events_url":"https://api.github.com/users/szhorvat/events{/privacy}","received_events_url":"https://api.github.com/users/szhorvat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szhorvat/igraph","description":"Library for the analysis of networks","fork":true,"url":"https://api.github.com/repos/szhorvat/igraph","forks_url":"https://api.github.com/repos/szhorvat/igraph/forks","keys_url":"https://api.github.com/repos/szhorvat/igraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szhorvat/igraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szhorvat/igraph/teams","hooks_url":"https://api.github.com/repos/szhorvat/igraph/hooks","issue_events_url":"https://api.github.com/repos/szhorvat/igraph/issues/events{/number}","events_url":"https://api.github.com/repos/szhorvat/igraph/events","assignees_url":"https://api.github.com/repos/szhorvat/igraph/assignees{/user}","branches_url":"https://api.github.com/repos/szhorvat/igraph/branches{/branch}","tags_url":"https://api.github.com/repos/szhorvat/igraph/tags","blobs_url":"https://api.github.com/repos/szhorvat/igraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szhorvat/igraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szhorvat/igraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/szhorvat/igraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szhorvat/igraph/statuses/{sha}","languages_url":"https://api.github.com/repos/szhorvat/igraph/languages","stargazers_url":"https://api.github.com/repos/szhorvat/igraph/stargazers","contributors_url":"https://api.github.com/repos/szhorvat/igraph/contributors","subscribers_url":"https://api.github.com/repos/szhorvat/igraph/subscribers","subscription_url":"https://api.github.com/repos/szhorvat/igraph/subscription","commits_url":"https://api.github.com/repos/szhorvat/igraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/szhorvat/igraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/szhorvat/igraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/szhorvat/igraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/szhorvat/igraph/contents/{+path}","compare_url":"https://api.github.com/repos/szhorvat/igraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szhorvat/igraph/merges","archive_url":"https://api.github.com/repos/szhorvat/igraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szhorvat/igraph/downloads","issues_url":"https://api.github.com/repos/szhorvat/igraph/issues{/number}","pulls_url":"https://api.github.com/repos/szhorvat/igraph/pulls{/number}","milestones_url":"https://api.github.com/repos/szhorvat/igraph/milestones{/number}","notifications_url":"https://api.github.com/repos/szhorvat/igraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szhorvat/igraph/labels{/name}","releases_url":"https://api.github.com/repos/szhorvat/igraph/releases{/id}","created_at":"2015-09-01T19:38:31Z","updated_at":"2015-09-01T19:38:37Z","pushed_at":"2015-10-14T12:29:17Z","git_url":"git://github.com/szhorvat/igraph.git","ssh_url":"git@github.com:szhorvat/igraph.git","clone_url":"https://github.com/szhorvat/igraph.git","svn_url":"https://github.com/szhorvat/igraph","homepage":"http://igraph.org","size":112912,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"igraph:master","ref":"master","sha":"708928cd566c6b81ae8d9e0f2592201eec63e2a9","user":{"login":"igraph","id":3735184,"avatar_url":"https://avatars.githubusercontent.com/u/3735184?v=3","gravatar_id":"","url":"https://api.github.com/users/igraph","html_url":"https://github.com/igraph","followers_url":"https://api.github.com/users/igraph/followers","following_url":"https://api.github.com/users/igraph/following{/other_user}","gists_url":"https://api.github.com/users/igraph/gists{/gist_id}","starred_url":"https://api.github.com/users/igraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igraph/subscriptions","organizations_url":"https://api.github.com/users/igraph/orgs","repos_url":"https://api.github.com/users/igraph/repos","events_url":"https://api.github.com/users/igraph/events{/privacy}","received_events_url":"https://api.github.com/users/igraph/received_events","type":"Organization","site_admin":false},"repo":{"id":8546198,"name":"igraph","full_name":"igraph/igraph","owner":{"login":"igraph","id":3735184,"avatar_url":"https://avatars.githubusercontent.com/u/3735184?v=3","gravatar_id":"","url":"https://api.github.com/users/igraph","html_url":"https://github.com/igraph","followers_url":"https://api.github.com/users/igraph/followers","following_url":"https://api.github.com/users/igraph/following{/other_user}","gists_url":"https://api.github.com/users/igraph/gists{/gist_id}","starred_url":"https://api.github.com/users/igraph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igraph/subscriptions","organizations_url":"https://api.github.com/users/igraph/orgs","repos_url":"https://api.github.com/users/igraph/repos","events_url":"https://api.github.com/users/igraph/events{/privacy}","received_events_url":"https://api.github.com/users/igraph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/igraph/igraph","description":"Library for the analysis of networks","fork":false,"url":"https://api.github.com/repos/igraph/igraph","forks_url":"https://api.github.com/repos/igraph/igraph/forks","keys_url":"https://api.github.com/repos/igraph/igraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/igraph/igraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/igraph/igraph/teams","hooks_url":"https://api.github.com/repos/igraph/igraph/hooks","issue_events_url":"https://api.github.com/repos/igraph/igraph/issues/events{/number}","events_url":"https://api.github.com/repos/igraph/igraph/events","assignees_url":"https://api.github.com/repos/igraph/igraph/assignees{/user}","branches_url":"https://api.github.com/repos/igraph/igraph/branches{/branch}","tags_url":"https://api.github.com/repos/igraph/igraph/tags","blobs_url":"https://api.github.com/repos/igraph/igraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/igraph/igraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/igraph/igraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/igraph/igraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/igraph/igraph/statuses/{sha}","languages_url":"https://api.github.com/repos/igraph/igraph/languages","stargazers_url":"https://api.github.com/repos/igraph/igraph/stargazers","contributors_url":"https://api.github.com/repos/igraph/igraph/contributors","subscribers_url":"https://api.github.com/repos/igraph/igraph/subscribers","subscription_url":"https://api.github.com/repos/igraph/igraph/subscription","commits_url":"https://api.github.com/repos/igraph/igraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/igraph/igraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/igraph/igraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/igraph/igraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/igraph/igraph/contents/{+path}","compare_url":"https://api.github.com/repos/igraph/igraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/igraph/igraph/merges","archive_url":"https://api.github.com/repos/igraph/igraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/igraph/igraph/downloads","issues_url":"https://api.github.com/repos/igraph/igraph/issues{/number}","pulls_url":"https://api.github.com/repos/igraph/igraph/pulls{/number}","milestones_url":"https://api.github.com/repos/igraph/igraph/milestones{/number}","notifications_url":"https://api.github.com/repos/igraph/igraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/igraph/igraph/labels{/name}","releases_url":"https://api.github.com/repos/igraph/igraph/releases{/id}","created_at":"2013-03-04T02:00:01Z","updated_at":"2015-10-11T04:41:06Z","pushed_at":"2015-10-14T13:35:49Z","git_url":"git://github.com/igraph/igraph.git","ssh_url":"git@github.com:igraph/igraph.git","clone_url":"https://github.com/igraph/igraph.git","svn_url":"https://github.com/igraph/igraph","homepage":"http://igraph.org","size":121837,"stargazers_count":335,"watchers_count":335,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":95,"mirror_url":null,"open_issues_count":163,"forks":95,"open_issues":163,"watchers":335,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/igraph/igraph/pulls/885"},"html":{"href":"https://github.com/igraph/igraph/pull/885"},"issue":{"href":"https://api.github.com/repos/igraph/igraph/issues/885"},"comments":{"href":"https://api.github.com/repos/igraph/igraph/issues/885/comments"},"review_comments":{"href":"https://api.github.com/repos/igraph/igraph/pulls/885/comments"},"review_comment":{"href":"https://api.github.com/repos/igraph/igraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/igraph/igraph/pulls/885/commits"},"statuses":{"href":"https://api.github.com/repos/igraph/igraph/statuses/6a98be5f9285f4392c18dda13ba6cd2636854c64"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ntamas","id":195637,"avatar_url":"https://avatars.githubusercontent.com/u/195637?v=3","gravatar_id":"","url":"https://api.github.com/users/ntamas","html_url":"https://github.com/ntamas","followers_url":"https://api.github.com/users/ntamas/followers","following_url":"https://api.github.com/users/ntamas/following{/other_user}","gists_url":"https://api.github.com/users/ntamas/gists{/gist_id}","starred_url":"https://api.github.com/users/ntamas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntamas/subscriptions","organizations_url":"https://api.github.com/users/ntamas/orgs","repos_url":"https://api.github.com/users/ntamas/repos","events_url":"https://api.github.com/users/ntamas/events{/privacy}","received_events_url":"https://api.github.com/users/ntamas/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":38,"deletions":7,"changed_files":2}}