{"action":"created","comment":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/24495843","id":24495843,"diff_hunk":"@@ -98,6 +98,87 @@ def __repr__(self):\n     dotted_string = utils.read_only_property(\"_dotted_string\")\n \n \n+class Name(object):\n+    def __init__(self, attributes):\n+        self._attributes = attributes\n+\n+    def _filter_attr_list(self, oid):\n+        return [i for i in self._attributes if i.oid == oid]\n+\n+    @property\n+    def common_name(self):\n+        return self._filter_attr_list(OID_COMMON_NAME)\n+\n+    @property\n+    def country_name(self):\n+        return self._filter_attr_list(OID_COUNTRY_NAME)\n+\n+    @property\n+    def locality_name(self):\n+        return self._filter_attr_list(OID_LOCALITY_NAME)\n+\n+    @property\n+    def state_or_province_name(self):\n+        return self._filter_attr_list(OID_STATE_OR_PROVINCE_NAME)\n+\n+    @property\n+    def organization_name(self):\n+        return self._filter_attr_list(OID_ORGANIZATION_NAME)\n+\n+    @property\n+    def organizational_unit_name(self):\n+        return self._filter_attr_list(OID_ORGANIZATIONAL_UNIT_NAME)\n+\n+    @property\n+    def serial_number(self):\n+        return self._filter_attr_list(OID_SERIAL_NUMBER)\n+\n+    @property\n+    def surname(self):\n+        return self._filter_attr_list(OID_SURNAME)\n+\n+    @property\n+    def given_name(self):\n+        return self._filter_attr_list(OID_GIVEN_NAME)\n+\n+    @property\n+    def title(self):\n+        return self._filter_attr_list(OID_TITLE)\n+\n+    @property\n+    def generation_qualifier(self):\n+        return self._filter_attr_list(OID_GENERATION_QUALIFIER)\n+\n+    @property\n+    def dn_qualifier(self):\n+        return self._filter_attr_list(OID_DN_QUALIFIER)\n+\n+    @property\n+    def pseudonym(self):\n+        return self._filter_attr_list(OID_PSEUDONYM)\n+\n+    @property\n+    def domain_component(self):\n+        return self._filter_attr_list(OID_DOMAIN_COMPONENT)\n+\n+    @property\n+    def email_address(self):\n+        return self._filter_attr_list(OID_EMAIL_ADDRESS)\n+\n+    @property\n+    def attributes(self):\n+        return self._attributes[:]","path":"src/cryptography/x509.py","position":73,"original_position":73,"commit_id":"42200c350ef28f877ff435ddf67e4783c6d2cc6d","original_commit_id":"42200c350ef28f877ff435ddf67e4783c6d2cc6d","user":{"login":"alex","id":772,"avatar_url":"https://avatars.githubusercontent.com/u/772?v=3","gravatar_id":"","url":"https://api.github.com/users/alex","html_url":"https://github.com/alex","followers_url":"https://api.github.com/users/alex/followers","following_url":"https://api.github.com/users/alex/following{/other_user}","gists_url":"https://api.github.com/users/alex/gists{/gist_id}","starred_url":"https://api.github.com/users/alex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex/subscriptions","organizations_url":"https://api.github.com/users/alex/orgs","repos_url":"https://api.github.com/users/alex/repos","events_url":"https://api.github.com/users/alex/events{/privacy}","received_events_url":"https://api.github.com/users/alex/received_events","type":"User","site_admin":false},"body":"So, thinking outloud here, is there a reason we really need to have all these properties? Is `cert.issuer.common_names` significantly better than `cert.issuer.get_attributes_for_oid(OID_COMMON_NAME)`?\r\n\r\n(Thinking outloud, I'm not sure!)","created_at":"2015-02-11T13:58:14Z","updated_at":"2015-02-11T13:58:14Z","html_url":"https://github.com/pyca/cryptography/pull/1612#discussion_r24495843","pull_request_url":"https://api.github.com/repos/pyca/cryptography/pulls/1612","_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/24495843"},"html":{"href":"https://github.com/pyca/cryptography/pull/1612#discussion_r24495843"},"pull_request":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/1612"}}},"pull_request":{"url":"https://api.github.com/repos/pyca/cryptography/pulls/1612","id":27039718,"html_url":"https://github.com/pyca/cryptography/pull/1612","diff_url":"https://github.com/pyca/cryptography/pull/1612.diff","patch_url":"https://github.com/pyca/cryptography/pull/1612.patch","issue_url":"https://api.github.com/repos/pyca/cryptography/issues/1612","number":1612,"state":"open","locked":false,"title":"X509 distinguished name parsing support in the OpenSSL backend","user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"body":"Support distiguished names (issuer/subject). Work items:\r\n\r\n- [x] Test all supported OIDs (subject & issuer)\r\n- [x] Test unsupported OID (subject & issuer)\r\n- [x] Test attribute values outside ASCII charset\r\n- [x] Add changelog entry\r\n- [ ] Add examples to docs\r\n\r\nFixes #1569, depends on #1632 and #1645","created_at":"2015-01-08T16:24:46Z","updated_at":"2015-02-11T13:58:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3024b6de59537f4a26d52417f64dcb7b2095e1c9","assignee":null,"milestone":{"url":"https://api.github.com/repos/pyca/cryptography/milestones/9","labels_url":"https://api.github.com/repos/pyca/cryptography/milestones/9/labels","id":902741,"number":9,"title":"Eighth Release","description":"","creator":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":53,"state":"open","created_at":"2014-12-13T19:19:14Z","updated_at":"2015-01-29T15:45:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pyca/cryptography/pulls/1612/commits","review_comments_url":"https://api.github.com/repos/pyca/cryptography/pulls/1612/comments","review_comment_url":"https://api.github.com/repos/pyca/cryptography/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pyca/cryptography/issues/1612/comments","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/42200c350ef28f877ff435ddf67e4783c6d2cc6d","head":{"label":"reaperhulk:x509-dn","ref":"x509-dn","sha":"42200c350ef28f877ff435ddf67e4783c6d2cc6d","user":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"repo":{"id":12704352,"name":"cryptography","full_name":"reaperhulk/cryptography","owner":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reaperhulk/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":true,"url":"https://api.github.com/repos/reaperhulk/cryptography","forks_url":"https://api.github.com/repos/reaperhulk/cryptography/forks","keys_url":"https://api.github.com/repos/reaperhulk/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reaperhulk/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reaperhulk/cryptography/teams","hooks_url":"https://api.github.com/repos/reaperhulk/cryptography/hooks","issue_events_url":"https://api.github.com/repos/reaperhulk/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/reaperhulk/cryptography/events","assignees_url":"https://api.github.com/repos/reaperhulk/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/reaperhulk/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/reaperhulk/cryptography/tags","blobs_url":"https://api.github.com/repos/reaperhulk/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reaperhulk/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reaperhulk/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/reaperhulk/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reaperhulk/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/reaperhulk/cryptography/languages","stargazers_url":"https://api.github.com/repos/reaperhulk/cryptography/stargazers","contributors_url":"https://api.github.com/repos/reaperhulk/cryptography/contributors","subscribers_url":"https://api.github.com/repos/reaperhulk/cryptography/subscribers","subscription_url":"https://api.github.com/repos/reaperhulk/cryptography/subscription","commits_url":"https://api.github.com/repos/reaperhulk/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/reaperhulk/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/reaperhulk/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/reaperhulk/cryptography/issues/comments/{number}","contents_url":"https://api.github.com/repos/reaperhulk/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/reaperhulk/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reaperhulk/cryptography/merges","archive_url":"https://api.github.com/repos/reaperhulk/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reaperhulk/cryptography/downloads","issues_url":"https://api.github.com/repos/reaperhulk/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/reaperhulk/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/reaperhulk/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/reaperhulk/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reaperhulk/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/reaperhulk/cryptography/releases{/id}","created_at":"2013-09-09T14:59:27Z","updated_at":"2015-01-18T22:30:49Z","pushed_at":"2015-02-11T04:40:57Z","git_url":"git://github.com/reaperhulk/cryptography.git","ssh_url":"git@github.com:reaperhulk/cryptography.git","clone_url":"https://github.com/reaperhulk/cryptography.git","svn_url":"https://github.com/reaperhulk/cryptography","homepage":"","size":29115,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"c39abdbca387fe923a410478af1abb37561a7220","user":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":11939484,"name":"cryptography","full_name":"pyca/cryptography","owner":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/cryptography","description":"cryptography is a package designed to expose cryptographic primitives and recipes to Python developers.","fork":false,"url":"https://api.github.com/repos/pyca/cryptography","forks_url":"https://api.github.com/repos/pyca/cryptography/forks","keys_url":"https://api.github.com/repos/pyca/cryptography/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/cryptography/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/cryptography/teams","hooks_url":"https://api.github.com/repos/pyca/cryptography/hooks","issue_events_url":"https://api.github.com/repos/pyca/cryptography/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/cryptography/events","assignees_url":"https://api.github.com/repos/pyca/cryptography/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/cryptography/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/cryptography/tags","blobs_url":"https://api.github.com/repos/pyca/cryptography/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/cryptography/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/cryptography/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/cryptography/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/cryptography/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/cryptography/languages","stargazers_url":"https://api.github.com/repos/pyca/cryptography/stargazers","contributors_url":"https://api.github.com/repos/pyca/cryptography/contributors","subscribers_url":"https://api.github.com/repos/pyca/cryptography/subscribers","subscription_url":"https://api.github.com/repos/pyca/cryptography/subscription","commits_url":"https://api.github.com/repos/pyca/cryptography/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/cryptography/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/cryptography/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/cryptography/issues/comments/{number}","contents_url":"https://api.github.com/repos/pyca/cryptography/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/cryptography/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/cryptography/merges","archive_url":"https://api.github.com/repos/pyca/cryptography/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/cryptography/downloads","issues_url":"https://api.github.com/repos/pyca/cryptography/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/cryptography/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/cryptography/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/cryptography/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/cryptography/labels{/name}","releases_url":"https://api.github.com/repos/pyca/cryptography/releases{/id}","created_at":"2013-08-07T02:23:38Z","updated_at":"2015-02-11T12:20:28Z","pushed_at":"2015-02-11T01:04:10Z","git_url":"git://github.com/pyca/cryptography.git","ssh_url":"git@github.com:pyca/cryptography.git","clone_url":"https://github.com/pyca/cryptography.git","svn_url":"https://github.com/pyca/cryptography","homepage":"https://cryptography.io/","size":37350,"stargazers_count":594,"watchers_count":594,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":121,"mirror_url":null,"open_issues_count":86,"forks":121,"open_issues":86,"watchers":594,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/1612"},"html":{"href":"https://github.com/pyca/cryptography/pull/1612"},"issue":{"href":"https://api.github.com/repos/pyca/cryptography/issues/1612"},"comments":{"href":"https://api.github.com/repos/pyca/cryptography/issues/1612/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/1612/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pyca/cryptography/pulls/1612/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/cryptography/statuses/42200c350ef28f877ff435ddf67e4783c6d2cc6d"}}}}