{"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/97","id":32631426,"html_url":"https://github.com/onepiecejs/nodejs-cantas/pull/97","diff_url":"https://github.com/onepiecejs/nodejs-cantas/pull/97.diff","patch_url":"https://github.com/onepiecejs/nodejs-cantas/pull/97.patch","issue_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues/97","number":97,"state":"closed","locked":false,"title":"fix #94","user":{"login":"tkdchen","id":919706,"avatar_url":"https://avatars.githubusercontent.com/u/919706?v=3","gravatar_id":"","url":"https://api.github.com/users/tkdchen","html_url":"https://github.com/tkdchen","followers_url":"https://api.github.com/users/tkdchen/followers","following_url":"https://api.github.com/users/tkdchen/following{/other_user}","gists_url":"https://api.github.com/users/tkdchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkdchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkdchen/subscriptions","organizations_url":"https://api.github.com/users/tkdchen/orgs","repos_url":"https://api.github.com/users/tkdchen/repos","events_url":"https://api.github.com/users/tkdchen/events{/privacy}","received_events_url":"https://api.github.com/users/tkdchen/received_events","type":"User","site_admin":false},"body":"Empty password, where an empty string is stored in the password field of each\r\nUser document, has potential security problem. Set unusable password to newly\r\ncreated user when using Kerberos and RemoteUser strategy.\r\n\r\nThe idea of setting unusable password is borrowed from django.contrib.auth.\r\nAlgorithm pbkdf2 is adapted as the default cryption algorithm. Due to the\r\nlimitation of old version of nodejs that we have to support, sha1 is used for\r\nnow instead of sha256. This can be changed in the future once Cantas moves to\r\nmost latest version.\r\n\r\nAlthough this patch is for setting unusable password, the solution also allows\r\nto encrypt an user's password before storing into database in a normal\r\nauthentication use case.","created_at":"2015-04-04T09:34:59Z","updated_at":"2015-04-10T00:33:22Z","closed_at":"2015-04-10T00:33:22Z","merged_at":null,"merge_commit_sha":"baa907c3751d8e3829c2b3b52676c50010b36dfe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/97/commits","review_comments_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/97/comments","review_comment_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues/97/comments","statuses_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/statuses/892a192aa81f2941a9b36f9e34b3314f4e253660","head":{"label":"tkdchen:fix-#94-set-unusable-password","ref":"fix-#94-set-unusable-password","sha":"892a192aa81f2941a9b36f9e34b3314f4e253660","user":{"login":"tkdchen","id":919706,"avatar_url":"https://avatars.githubusercontent.com/u/919706?v=3","gravatar_id":"","url":"https://api.github.com/users/tkdchen","html_url":"https://github.com/tkdchen","followers_url":"https://api.github.com/users/tkdchen/followers","following_url":"https://api.github.com/users/tkdchen/following{/other_user}","gists_url":"https://api.github.com/users/tkdchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkdchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkdchen/subscriptions","organizations_url":"https://api.github.com/users/tkdchen/orgs","repos_url":"https://api.github.com/users/tkdchen/repos","events_url":"https://api.github.com/users/tkdchen/events{/privacy}","received_events_url":"https://api.github.com/users/tkdchen/received_events","type":"User","site_admin":false},"repo":{"id":14643262,"name":"nodejs-cantas","full_name":"tkdchen/nodejs-cantas","owner":{"login":"tkdchen","id":919706,"avatar_url":"https://avatars.githubusercontent.com/u/919706?v=3","gravatar_id":"","url":"https://api.github.com/users/tkdchen","html_url":"https://github.com/tkdchen","followers_url":"https://api.github.com/users/tkdchen/followers","following_url":"https://api.github.com/users/tkdchen/following{/other_user}","gists_url":"https://api.github.com/users/tkdchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkdchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkdchen/subscriptions","organizations_url":"https://api.github.com/users/tkdchen/orgs","repos_url":"https://api.github.com/users/tkdchen/repos","events_url":"https://api.github.com/users/tkdchen/events{/privacy}","received_events_url":"https://api.github.com/users/tkdchen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkdchen/nodejs-cantas","description":"Cantas is a real-time collaborative web application.","fork":true,"url":"https://api.github.com/repos/tkdchen/nodejs-cantas","forks_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/forks","keys_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/teams","hooks_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/hooks","issue_events_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/issues/events{/number}","events_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/events","assignees_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/assignees{/user}","branches_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/branches{/branch}","tags_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/tags","blobs_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/statuses/{sha}","languages_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/languages","stargazers_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/stargazers","contributors_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/contributors","subscribers_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/subscribers","subscription_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/subscription","commits_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/contents/{+path}","compare_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/merges","archive_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/downloads","issues_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/issues{/number}","pulls_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/pulls{/number}","milestones_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/milestones{/number}","notifications_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/labels{/name}","releases_url":"https://api.github.com/repos/tkdchen/nodejs-cantas/releases{/id}","created_at":"2013-11-23T14:01:23Z","updated_at":"2015-04-10T00:33:05Z","pushed_at":"2015-04-10T00:33:05Z","git_url":"git://github.com/tkdchen/nodejs-cantas.git","ssh_url":"git@github.com:tkdchen/nodejs-cantas.git","clone_url":"https://github.com/tkdchen/nodejs-cantas.git","svn_url":"https://github.com/tkdchen/nodejs-cantas","homepage":null,"size":5580,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onepiecejs:master","ref":"master","sha":"e73b27ecb7caad2b6eac1778bfbece5fdc914e75","user":{"login":"onepiecejs","id":5965637,"avatar_url":"https://avatars.githubusercontent.com/u/5965637?v=3","gravatar_id":"","url":"https://api.github.com/users/onepiecejs","html_url":"https://github.com/onepiecejs","followers_url":"https://api.github.com/users/onepiecejs/followers","following_url":"https://api.github.com/users/onepiecejs/following{/other_user}","gists_url":"https://api.github.com/users/onepiecejs/gists{/gist_id}","starred_url":"https://api.github.com/users/onepiecejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onepiecejs/subscriptions","organizations_url":"https://api.github.com/users/onepiecejs/orgs","repos_url":"https://api.github.com/users/onepiecejs/repos","events_url":"https://api.github.com/users/onepiecejs/events{/privacy}","received_events_url":"https://api.github.com/users/onepiecejs/received_events","type":"Organization","site_admin":false},"repo":{"id":14622577,"name":"nodejs-cantas","full_name":"onepiecejs/nodejs-cantas","owner":{"login":"onepiecejs","id":5965637,"avatar_url":"https://avatars.githubusercontent.com/u/5965637?v=3","gravatar_id":"","url":"https://api.github.com/users/onepiecejs","html_url":"https://github.com/onepiecejs","followers_url":"https://api.github.com/users/onepiecejs/followers","following_url":"https://api.github.com/users/onepiecejs/following{/other_user}","gists_url":"https://api.github.com/users/onepiecejs/gists{/gist_id}","starred_url":"https://api.github.com/users/onepiecejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onepiecejs/subscriptions","organizations_url":"https://api.github.com/users/onepiecejs/orgs","repos_url":"https://api.github.com/users/onepiecejs/repos","events_url":"https://api.github.com/users/onepiecejs/events{/privacy}","received_events_url":"https://api.github.com/users/onepiecejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onepiecejs/nodejs-cantas","description":"Cantas is a real-time collaborative web application. Official repository","fork":false,"url":"https://api.github.com/repos/onepiecejs/nodejs-cantas","forks_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/forks","keys_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/teams","hooks_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/hooks","issue_events_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues/events{/number}","events_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/events","assignees_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/assignees{/user}","branches_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/branches{/branch}","tags_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/tags","blobs_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/git/refs{/sha}","trees_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/statuses/{sha}","languages_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/languages","stargazers_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/stargazers","contributors_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/contributors","subscribers_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/subscribers","subscription_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/subscription","commits_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/commits{/sha}","git_commits_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/git/commits{/sha}","comments_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/comments{/number}","issue_comment_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues/comments{/number}","contents_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/contents/{+path}","compare_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/merges","archive_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/downloads","issues_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues{/number}","pulls_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls{/number}","milestones_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/milestones{/number}","notifications_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/labels{/name}","releases_url":"https://api.github.com/repos/onepiecejs/nodejs-cantas/releases{/id}","created_at":"2013-11-22T16:19:33Z","updated_at":"2015-04-10T00:31:35Z","pushed_at":"2015-04-10T00:31:35Z","git_url":"git://github.com/onepiecejs/nodejs-cantas.git","ssh_url":"git@github.com:onepiecejs/nodejs-cantas.git","clone_url":"https://github.com/onepiecejs/nodejs-cantas.git","svn_url":"https://github.com/onepiecejs/nodejs-cantas","homepage":"","size":6101,"stargazers_count":148,"watchers_count":148,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":34,"forks":59,"open_issues":34,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/97"},"html":{"href":"https://github.com/onepiecejs/nodejs-cantas/pull/97"},"issue":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues/97"},"comments":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/onepiecejs/nodejs-cantas/statuses/892a192aa81f2941a9b36f9e34b3314f4e253660"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":1,"review_comments":11,"commits":2,"additions":307,"deletions":12,"changed_files":8}}