{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/47397048","id":47397048,"diff_hunk":"@@ -364,6 +368,53 @@ public abstract OutputStream create(String path, short replication, int blockSiz\n   public abstract String[] list(String path) throws IOException;\n \n   /**\n+   * Returns an array of strings naming the files and directories in the directory denoted by this\n+   * abstract pathname, and all of its subdirectories.\n+   *\n+   * <p>\n+   * If this abstract pathname does not denote a directory, then this method returns {@code null}.\n+   * Otherwise an array of strings is returned, one for each file or directory in the directory and\n+   * its subdirectories. Names denoting the directory itself and the directory's parent directory\n+   * are not included in the result. Each string is a path relative to the given directory.\n+   *\n+   * <p>\n+   * There is no guarantee that the name strings in the resulting array will appear in any specific\n+   * order; they are not, in particular, guaranteed to appear in alphabetical order.\n+   *\n+   * @param path the path to list\n+   * @return An array of strings naming the files and directories in the directory denoted by this\n+   *         abstract pathname and its subdirectories. The array will be empty if the directory is\n+   *         empty. Returns {@code null} if this abstract pathname does not denote a directory, or\n+   *         if an I/O error occurs.","path":"common/src/main/java/tachyon/underfs/UnderFileSystem.java","position":40,"original_position":40,"commit_id":"f60fee495460d2789046722f1f17b2fa4c07fa68","original_commit_id":"f60fee495460d2789046722f1f17b2fa4c07fa68","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"I think this is just following the contract of `list`","created_at":"2015-12-11T19:49:54Z","updated_at":"2015-12-11T19:49:54Z","html_url":"https://github.com/amplab/tachyon/pull/2256#discussion_r47397048","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/2256","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/47397048"},"html":{"href":"https://github.com/amplab/tachyon/pull/2256#discussion_r47397048"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2256"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/2256","id":53433216,"html_url":"https://github.com/amplab/tachyon/pull/2256","diff_url":"https://github.com/amplab/tachyon/pull/2256.diff","patch_url":"https://github.com/amplab/tachyon/pull/2256.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/2256","number":2256,"state":"open","locked":false,"title":"[TACHYON-1399] Implemented listRecursive","user":{"login":"manugoyal","id":628968,"avatar_url":"https://avatars.githubusercontent.com/u/628968?v=3","gravatar_id":"","url":"https://api.github.com/users/manugoyal","html_url":"https://github.com/manugoyal","followers_url":"https://api.github.com/users/manugoyal/followers","following_url":"https://api.github.com/users/manugoyal/following{/other_user}","gists_url":"https://api.github.com/users/manugoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/manugoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugoyal/subscriptions","organizations_url":"https://api.github.com/users/manugoyal/orgs","repos_url":"https://api.github.com/users/manugoyal/repos","events_url":"https://api.github.com/users/manugoyal/events{/privacy}","received_events_url":"https://api.github.com/users/manugoyal/received_events","type":"User","site_admin":false},"body":"Turns out the version of Hadoop we support doesn't have any mechanism\r\nfor listing recursively, so all underfs's use the default\r\nimplementation.","created_at":"2015-12-11T19:24:45Z","updated_at":"2015-12-11T19:49:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ae353564c6c94b6b0fcfe554b8bef52ee14ddbb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/2256/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/2256/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/2256/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/f60fee495460d2789046722f1f17b2fa4c07fa68","head":{"label":"manugoyal:underfs-lsr","ref":"underfs-lsr","sha":"f60fee495460d2789046722f1f17b2fa4c07fa68","user":{"login":"manugoyal","id":628968,"avatar_url":"https://avatars.githubusercontent.com/u/628968?v=3","gravatar_id":"","url":"https://api.github.com/users/manugoyal","html_url":"https://github.com/manugoyal","followers_url":"https://api.github.com/users/manugoyal/followers","following_url":"https://api.github.com/users/manugoyal/following{/other_user}","gists_url":"https://api.github.com/users/manugoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/manugoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugoyal/subscriptions","organizations_url":"https://api.github.com/users/manugoyal/orgs","repos_url":"https://api.github.com/users/manugoyal/repos","events_url":"https://api.github.com/users/manugoyal/events{/privacy}","received_events_url":"https://api.github.com/users/manugoyal/received_events","type":"User","site_admin":false},"repo":{"id":16339378,"name":"tachyon","full_name":"manugoyal/tachyon","owner":{"login":"manugoyal","id":628968,"avatar_url":"https://avatars.githubusercontent.com/u/628968?v=3","gravatar_id":"","url":"https://api.github.com/users/manugoyal","html_url":"https://github.com/manugoyal","followers_url":"https://api.github.com/users/manugoyal/followers","following_url":"https://api.github.com/users/manugoyal/following{/other_user}","gists_url":"https://api.github.com/users/manugoyal/gists{/gist_id}","starred_url":"https://api.github.com/users/manugoyal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manugoyal/subscriptions","organizations_url":"https://api.github.com/users/manugoyal/orgs","repos_url":"https://api.github.com/users/manugoyal/repos","events_url":"https://api.github.com/users/manugoyal/events{/privacy}","received_events_url":"https://api.github.com/users/manugoyal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manugoyal/tachyon","description":"Reliable File Sharing at Memory Speed Across Cluster Frameworks","fork":true,"url":"https://api.github.com/repos/manugoyal/tachyon","forks_url":"https://api.github.com/repos/manugoyal/tachyon/forks","keys_url":"https://api.github.com/repos/manugoyal/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manugoyal/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manugoyal/tachyon/teams","hooks_url":"https://api.github.com/repos/manugoyal/tachyon/hooks","issue_events_url":"https://api.github.com/repos/manugoyal/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/manugoyal/tachyon/events","assignees_url":"https://api.github.com/repos/manugoyal/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/manugoyal/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/manugoyal/tachyon/tags","blobs_url":"https://api.github.com/repos/manugoyal/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manugoyal/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manugoyal/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/manugoyal/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manugoyal/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/manugoyal/tachyon/languages","stargazers_url":"https://api.github.com/repos/manugoyal/tachyon/stargazers","contributors_url":"https://api.github.com/repos/manugoyal/tachyon/contributors","subscribers_url":"https://api.github.com/repos/manugoyal/tachyon/subscribers","subscription_url":"https://api.github.com/repos/manugoyal/tachyon/subscription","commits_url":"https://api.github.com/repos/manugoyal/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/manugoyal/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/manugoyal/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/manugoyal/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/manugoyal/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/manugoyal/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manugoyal/tachyon/merges","archive_url":"https://api.github.com/repos/manugoyal/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manugoyal/tachyon/downloads","issues_url":"https://api.github.com/repos/manugoyal/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/manugoyal/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/manugoyal/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/manugoyal/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manugoyal/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/manugoyal/tachyon/releases{/id}","created_at":"2014-01-29T08:35:14Z","updated_at":"2014-07-17T03:07:23Z","pushed_at":"2015-12-11T19:26:10Z","git_url":"git://github.com/manugoyal/tachyon.git","ssh_url":"git@github.com:manugoyal/tachyon.git","clone_url":"https://github.com/manugoyal/tachyon.git","svn_url":"https://github.com/manugoyal/tachyon","homepage":"http://tachyon-project.org","size":32239,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:master","ref":"master","sha":"6630f4ac718700955a11db9119e7b3149ede83ef","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":"Memory Centric Reliable Distributed Storage","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-12-11T19:28:57Z","pushed_at":"2015-12-11T19:29:58Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":40885,"stargazers_count":1797,"watchers_count":1797,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":711,"mirror_url":null,"open_issues_count":28,"forks":711,"open_issues":28,"watchers":1797,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2256"},"html":{"href":"https://github.com/amplab/tachyon/pull/2256"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2256"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/2256/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2256/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/2256/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/f60fee495460d2789046722f1f17b2fa4c07fa68"}}}}