{"action":"created","comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/41360629","id":41360629,"diff_hunk":"@@ -786,7 +786,8 @@ public function processFilter()\n         }\n \n         $filters = $this->context->cookie->getFamily($prefix.$this->list_id.'Filter_');\n-        $definition = ObjectModel::getDefinition($this->className);\n+        if (isset($this->className) && $this->className) ","path":"classes/controller/AdminController.php","position":5,"original_position":5,"commit_id":"c74614f0fe9232876dc9f1f69acba68503d6306d","original_commit_id":"c74614f0fe9232876dc9f1f69acba68503d6306d","user":{"login":"gRoussac","id":3099551,"avatar_url":"https://avatars.githubusercontent.com/u/3099551?v=3","gravatar_id":"","url":"https://api.github.com/users/gRoussac","html_url":"https://github.com/gRoussac","followers_url":"https://api.github.com/users/gRoussac/followers","following_url":"https://api.github.com/users/gRoussac/following{/other_user}","gists_url":"https://api.github.com/users/gRoussac/gists{/gist_id}","starred_url":"https://api.github.com/users/gRoussac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gRoussac/subscriptions","organizations_url":"https://api.github.com/users/gRoussac/orgs","repos_url":"https://api.github.com/users/gRoussac/repos","events_url":"https://api.github.com/users/gRoussac/events{/privacy}","received_events_url":"https://api.github.com/users/gRoussac/received_events","type":"User","site_admin":false},"body":"Thak you for your dedication and help.\r\n\r\nhttps://github.com/PrestaShop/PrestaShop/pull/4195/files\r\n\r\nRegards","created_at":"2015-10-07T07:49:24Z","updated_at":"2015-10-07T07:49:24Z","html_url":"https://github.com/PrestaShop/PrestaShop/pull/4006#discussion_r41360629","pull_request_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006","_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments/41360629"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/4006#discussion_r41360629"},"pull_request":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006"}}},"pull_request":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006","id":45186059,"html_url":"https://github.com/PrestaShop/PrestaShop/pull/4006","diff_url":"https://github.com/PrestaShop/PrestaShop/pull/4006.diff","patch_url":"https://github.com/PrestaShop/PrestaShop/pull/4006.patch","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4006","number":4006,"state":"closed","locked":false,"title":"[*] BO Some controllers may want to use Filters without an objectModel","user":{"login":"hiousi","id":176594,"avatar_url":"https://avatars.githubusercontent.com/u/176594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiousi","html_url":"https://github.com/hiousi","followers_url":"https://api.github.com/users/hiousi/followers","following_url":"https://api.github.com/users/hiousi/following{/other_user}","gists_url":"https://api.github.com/users/hiousi/gists{/gist_id}","starred_url":"https://api.github.com/users/hiousi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiousi/subscriptions","organizations_url":"https://api.github.com/users/hiousi/orgs","repos_url":"https://api.github.com/users/hiousi/repos","events_url":"https://api.github.com/users/hiousi/events{/privacy}","received_events_url":"https://api.github.com/users/hiousi/received_events","type":"User","site_admin":false},"body":"Some modules may want to use Filters without an objectModel.\r\nIn that case $this->className is not set but ObjectModel::getDefinition requires it.","created_at":"2015-09-16T15:25:55Z","updated_at":"2015-10-07T07:49:24Z","closed_at":"2015-09-16T15:26:48Z","merged_at":"2015-09-16T15:26:48Z","merge_commit_sha":"6dcbf4e55fc667c118629ed49da2750477c19664","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006/commits","review_comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006/comments","review_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4006/comments","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/c74614f0fe9232876dc9f1f69acba68503d6306d","head":{"label":"hiousi:patch-2","ref":"patch-2","sha":"c74614f0fe9232876dc9f1f69acba68503d6306d","user":{"login":"hiousi","id":176594,"avatar_url":"https://avatars.githubusercontent.com/u/176594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiousi","html_url":"https://github.com/hiousi","followers_url":"https://api.github.com/users/hiousi/followers","following_url":"https://api.github.com/users/hiousi/following{/other_user}","gists_url":"https://api.github.com/users/hiousi/gists{/gist_id}","starred_url":"https://api.github.com/users/hiousi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiousi/subscriptions","organizations_url":"https://api.github.com/users/hiousi/orgs","repos_url":"https://api.github.com/users/hiousi/repos","events_url":"https://api.github.com/users/hiousi/events{/privacy}","received_events_url":"https://api.github.com/users/hiousi/received_events","type":"User","site_admin":false},"repo":{"id":12756476,"name":"PrestaShop","full_name":"hiousi/PrestaShop","owner":{"login":"hiousi","id":176594,"avatar_url":"https://avatars.githubusercontent.com/u/176594?v=3","gravatar_id":"","url":"https://api.github.com/users/hiousi","html_url":"https://github.com/hiousi","followers_url":"https://api.github.com/users/hiousi/followers","following_url":"https://api.github.com/users/hiousi/following{/other_user}","gists_url":"https://api.github.com/users/hiousi/gists{/gist_id}","starred_url":"https://api.github.com/users/hiousi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiousi/subscriptions","organizations_url":"https://api.github.com/users/hiousi/orgs","repos_url":"https://api.github.com/users/hiousi/repos","events_url":"https://api.github.com/users/hiousi/events{/privacy}","received_events_url":"https://api.github.com/users/hiousi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiousi/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":true,"url":"https://api.github.com/repos/hiousi/PrestaShop","forks_url":"https://api.github.com/repos/hiousi/PrestaShop/forks","keys_url":"https://api.github.com/repos/hiousi/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiousi/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiousi/PrestaShop/teams","hooks_url":"https://api.github.com/repos/hiousi/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/hiousi/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/hiousi/PrestaShop/events","assignees_url":"https://api.github.com/repos/hiousi/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/hiousi/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/hiousi/PrestaShop/tags","blobs_url":"https://api.github.com/repos/hiousi/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiousi/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiousi/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiousi/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiousi/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/hiousi/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/hiousi/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/hiousi/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/hiousi/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/hiousi/PrestaShop/subscription","commits_url":"https://api.github.com/repos/hiousi/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiousi/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiousi/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiousi/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiousi/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/hiousi/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiousi/PrestaShop/merges","archive_url":"https://api.github.com/repos/hiousi/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiousi/PrestaShop/downloads","issues_url":"https://api.github.com/repos/hiousi/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/hiousi/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/hiousi/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/hiousi/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiousi/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/hiousi/PrestaShop/releases{/id}","created_at":"2013-09-11T13:04:22Z","updated_at":"2014-08-21T08:35:34Z","pushed_at":"2015-10-03T14:19:04Z","git_url":"git://github.com/hiousi/PrestaShop.git","ssh_url":"git@github.com:hiousi/PrestaShop.git","clone_url":"https://github.com/hiousi/PrestaShop.git","svn_url":"https://github.com/hiousi/PrestaShop","homepage":"http://www.prestashop.com/","size":213024,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"1.6.1.x"}},"base":{"label":"PrestaShop:1.6.1.x","ref":"1.6.1.x","sha":"75d7c80d64be322ede3fe8825455e2eeee865ea4","user":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"repo":{"id":6763587,"name":"PrestaShop","full_name":"PrestaShop/PrestaShop","owner":{"login":"PrestaShop","id":2815696,"avatar_url":"https://avatars.githubusercontent.com/u/2815696?v=3","gravatar_id":"","url":"https://api.github.com/users/PrestaShop","html_url":"https://github.com/PrestaShop","followers_url":"https://api.github.com/users/PrestaShop/followers","following_url":"https://api.github.com/users/PrestaShop/following{/other_user}","gists_url":"https://api.github.com/users/PrestaShop/gists{/gist_id}","starred_url":"https://api.github.com/users/PrestaShop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PrestaShop/subscriptions","organizations_url":"https://api.github.com/users/PrestaShop/orgs","repos_url":"https://api.github.com/users/PrestaShop/repos","events_url":"https://api.github.com/users/PrestaShop/events{/privacy}","received_events_url":"https://api.github.com/users/PrestaShop/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PrestaShop/PrestaShop","description":"PrestaShop offers a free, fully scalable, Open-source e-commerce solution.","fork":false,"url":"https://api.github.com/repos/PrestaShop/PrestaShop","forks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/forks","keys_url":"https://api.github.com/repos/PrestaShop/PrestaShop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PrestaShop/PrestaShop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PrestaShop/PrestaShop/teams","hooks_url":"https://api.github.com/repos/PrestaShop/PrestaShop/hooks","issue_events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/events{/number}","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/events","assignees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/assignees{/user}","branches_url":"https://api.github.com/repos/PrestaShop/PrestaShop/branches{/branch}","tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/tags","blobs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/refs{/sha}","trees_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/{sha}","languages_url":"https://api.github.com/repos/PrestaShop/PrestaShop/languages","stargazers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/stargazers","contributors_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contributors","subscribers_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscribers","subscription_url":"https://api.github.com/repos/PrestaShop/PrestaShop/subscription","commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/commits{/sha}","git_commits_url":"https://api.github.com/repos/PrestaShop/PrestaShop/git/commits{/sha}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/comments{/number}","issue_comment_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments{/number}","contents_url":"https://api.github.com/repos/PrestaShop/PrestaShop/contents/{+path}","compare_url":"https://api.github.com/repos/PrestaShop/PrestaShop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PrestaShop/PrestaShop/merges","archive_url":"https://api.github.com/repos/PrestaShop/PrestaShop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PrestaShop/PrestaShop/downloads","issues_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues{/number}","pulls_url":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls{/number}","milestones_url":"https://api.github.com/repos/PrestaShop/PrestaShop/milestones{/number}","notifications_url":"https://api.github.com/repos/PrestaShop/PrestaShop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels{/name}","releases_url":"https://api.github.com/repos/PrestaShop/PrestaShop/releases{/id}","created_at":"2012-11-19T16:41:31Z","updated_at":"2015-10-06T17:12:03Z","pushed_at":"2015-10-07T07:48:55Z","git_url":"git://github.com/PrestaShop/PrestaShop.git","ssh_url":"git@github.com:PrestaShop/PrestaShop.git","clone_url":"https://github.com/PrestaShop/PrestaShop.git","svn_url":"https://github.com/PrestaShop/PrestaShop","homepage":"http://www.prestashop.com/","size":326681,"stargazers_count":1429,"watchers_count":1429,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1580,"mirror_url":null,"open_issues_count":376,"forks":1580,"open_issues":376,"watchers":1429,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006"},"html":{"href":"https://github.com/PrestaShop/PrestaShop/pull/4006"},"issue":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4006"},"comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/4006/comments"},"review_comments":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006/comments"},"review_comment":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/pulls/4006/commits"},"statuses":{"href":"https://api.github.com/repos/PrestaShop/PrestaShop/statuses/c74614f0fe9232876dc9f1f69acba68503d6306d"}}}}