{"push_id":547667388,"size":1,"distinct_size":1,"ref":"refs/heads/RELENG_2_2","head":"5b7c33fc7e68339e45f3bb2b59580d00c9eda0eb","before":"8d4e768a27523134bd5a4afe99f9b0bb9aae61a4","commits":[{"sha":"5b7c33fc7e68339e45f3bb2b59580d00c9eda0eb","author":{"email":"545605536038c5fc1fd68bbfa4d633a0a6400978@inf.org","name":"Phil Davis"},"message":"Firewall Rules Apply be friendly to other languages\n\nForum: https://forum.pfsense.org/index.php?topic=86808.0\nRedmine: https://redmine.pfsense.org/issues/3886\n\nprint_info_box_np() when called with just the first $msg parameter has some rough tests to decide if the \"Apply\" button should be displayed. It checks if the translation of \"apply\", \"save\" or \"create\" appears in the $msg string (which is a translated string itself). If the $msg string did not translate, and thus remains in English, but gettext(\"apply\") does translate then the e.g. Turkish word for \"apply\" is not going to appear in the English $msg string. So things go wrong.\n\nprint_info_box_np already has extra parameters to tell it explicitly $showapply - and for this stuff we know we want the apply button, regardless of how the various text string translations work out. Thus I have provided those parameters here.\n\nI also changed the construction of the text to pass as $msg, breaking it up like in firewall_aliases.php - this means that the string \"You must apply the changes in order for them to take effect.\" translates and you get at least that Turkish displayed.\n\nIMHO it would be beneficial to change lots of these print_info_box_np calls to explicitly set $showapply=true - that will ensure that the apply button shows (and thus the user can perform the needed actions) regardless of how well/not well the translation of the text turns out.","distinct":true,"url":"https://api.github.com/repos/pfsense/pfsense/commits/5b7c33fc7e68339e45f3bb2b59580d00c9eda0eb"}]}