{"action":"created","issue":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/563","labels_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/563/labels{/name}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/563/comments","events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/563/events","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/563","id":63313665,"number":563,"title":"Finalized game saving + some more","user":{"login":"hwoarangmy","id":7493706,"avatar_url":"https://avatars.githubusercontent.com/u/7493706?v=3","gravatar_id":"","url":"https://api.github.com/users/hwoarangmy","html_url":"https://github.com/hwoarangmy","followers_url":"https://api.github.com/users/hwoarangmy/followers","following_url":"https://api.github.com/users/hwoarangmy/following{/other_user}","gists_url":"https://api.github.com/users/hwoarangmy/gists{/gist_id}","starred_url":"https://api.github.com/users/hwoarangmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwoarangmy/subscriptions","organizations_url":"https://api.github.com/users/hwoarangmy/orgs","repos_url":"https://api.github.com/users/hwoarangmy/repos","events_url":"https://api.github.com/users/hwoarangmy/events{/privacy}","received_events_url":"https://api.github.com/users/hwoarangmy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":30,"created_at":"2015-03-20T21:40:16Z","updated_at":"2015-03-23T15:20:59Z","closed_at":"2015-03-23T10:57:30Z","pull_request":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/563","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/563","diff_url":"https://github.com/OpenDungeons/OpenDungeons/pull/563.diff","patch_url":"https://github.com/OpenDungeons/OpenDungeons/pull/563.patch"},"body":"Sorry for this big (game breaker) PR but I had to mess with saving and repairing rooms (because they both need to know deleted tiles from building, they were tied).\r\nConcerning game saving, basically, the server now reminds tile states for each human player (including building).\r\nMoreover, buildings are removed from gamemap only when not used anymore (if a player sees an enemy building, looses vision and the building gets destroyed by someone else, the building will be removed from the gamemap only when the player will get vision again - and see it has been destroyed).\r\n\r\nBuilding tiles are displayed at map load. Traps and just like persistent objects (dungeon temple and portal).\r\n\r\n@oyvindln I've played a bit with memory. I tried to pay attention but if you could have a look with valgrind, it would be nice.\r\n\r\n@akien-mga If nobody sees any obvious regression/problem with this PR, I propose we use my repo as it is right now for the next testing version\r\n\r\nfixes #560 \r\nfixes #531 "},"comment":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/comments/85047260","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/563#issuecomment-85047260","issue_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/563","id":85047260,"user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"created_at":"2015-03-23T15:20:59Z","updated_at":"2015-03-23T15:20:59Z","body":"@hwoarangmy If you want to make a Windows snapshot, I think now that this one has been merged would be a good time. So either a snapshot from OpenDungeons/development, or from your branch at fcb47b3.\r\nI'll install my Mageia 4 VM in the meantime since I can't build the current master branch with the old gcc from Mageia 3."}}