{"action":"closed","number":4886,"pull_request":{"url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4886","id":39549589,"html_url":"https://github.com/DynamoDS/Dynamo/pull/4886","diff_url":"https://github.com/DynamoDS/Dynamo/pull/4886.diff","patch_url":"https://github.com/DynamoDS/Dynamo/pull/4886.patch","issue_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4886","number":4886,"state":"closed","locked":false,"title":"Fix unit test failures","user":{"login":"riteshchandawar","id":5109531,"avatar_url":"https://avatars.githubusercontent.com/u/5109531?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshchandawar","html_url":"https://github.com/riteshchandawar","followers_url":"https://api.github.com/users/riteshchandawar/followers","following_url":"https://api.github.com/users/riteshchandawar/following{/other_user}","gists_url":"https://api.github.com/users/riteshchandawar/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshchandawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshchandawar/subscriptions","organizations_url":"https://api.github.com/users/riteshchandawar/orgs","repos_url":"https://api.github.com/users/riteshchandawar/repos","events_url":"https://api.github.com/users/riteshchandawar/events{/privacy}","received_events_url":"https://api.github.com/users/riteshchandawar/received_events","type":"User","site_admin":false},"body":"### Purpose\r\n\r\nThis pull request is meant to fix the test failures (by reverting #4783).\r\n\r\n### Declarations\r\n\r\nCheck these if you believe they are true\r\n\r\n- [x] The code base is in a better state after this PR\r\n- [x] The level of testing this PR includes is appropriate\r\n- [ ] User facing strings, if any, are extracted into `*.resx` files\r\n\r\n### Reviewers\r\n\r\nHi @Benglin, PTAL.\r\n\r\n### FYIs\r\n\r\n@marimano, this reverts your recent pull request, you may have to rework that now :)\r\n","created_at":"2015-07-09T05:37:39Z","updated_at":"2015-07-09T05:37:47Z","closed_at":"2015-07-09T05:37:46Z","merged_at":"2015-07-09T05:37:46Z","merge_commit_sha":"c31ee2c1b6ce7efeadfeca8663024bd05f6eee22","assignee":{"login":"Benglin","id":5086849,"avatar_url":"https://avatars.githubusercontent.com/u/5086849?v=3","gravatar_id":"","url":"https://api.github.com/users/Benglin","html_url":"https://github.com/Benglin","followers_url":"https://api.github.com/users/Benglin/followers","following_url":"https://api.github.com/users/Benglin/following{/other_user}","gists_url":"https://api.github.com/users/Benglin/gists{/gist_id}","starred_url":"https://api.github.com/users/Benglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benglin/subscriptions","organizations_url":"https://api.github.com/users/Benglin/orgs","repos_url":"https://api.github.com/users/Benglin/repos","events_url":"https://api.github.com/users/Benglin/events{/privacy}","received_events_url":"https://api.github.com/users/Benglin/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4886/commits","review_comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4886/comments","review_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4886/comments","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/ae2e4e4c88e1dea8aff89c919e6245e4af3e38bb","head":{"label":"riteshchandawar:myMaster","ref":"myMaster","sha":"ae2e4e4c88e1dea8aff89c919e6245e4af3e38bb","user":{"login":"riteshchandawar","id":5109531,"avatar_url":"https://avatars.githubusercontent.com/u/5109531?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshchandawar","html_url":"https://github.com/riteshchandawar","followers_url":"https://api.github.com/users/riteshchandawar/followers","following_url":"https://api.github.com/users/riteshchandawar/following{/other_user}","gists_url":"https://api.github.com/users/riteshchandawar/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshchandawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshchandawar/subscriptions","organizations_url":"https://api.github.com/users/riteshchandawar/orgs","repos_url":"https://api.github.com/users/riteshchandawar/repos","events_url":"https://api.github.com/users/riteshchandawar/events{/privacy}","received_events_url":"https://api.github.com/users/riteshchandawar/received_events","type":"User","site_admin":false},"repo":{"id":11729494,"name":"Dynamo","full_name":"riteshchandawar/Dynamo","owner":{"login":"riteshchandawar","id":5109531,"avatar_url":"https://avatars.githubusercontent.com/u/5109531?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshchandawar","html_url":"https://github.com/riteshchandawar","followers_url":"https://api.github.com/users/riteshchandawar/followers","following_url":"https://api.github.com/users/riteshchandawar/following{/other_user}","gists_url":"https://api.github.com/users/riteshchandawar/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshchandawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshchandawar/subscriptions","organizations_url":"https://api.github.com/users/riteshchandawar/orgs","repos_url":"https://api.github.com/users/riteshchandawar/repos","events_url":"https://api.github.com/users/riteshchandawar/events{/privacy}","received_events_url":"https://api.github.com/users/riteshchandawar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/riteshchandawar/Dynamo","description":"Visual Programming For Revit","fork":true,"url":"https://api.github.com/repos/riteshchandawar/Dynamo","forks_url":"https://api.github.com/repos/riteshchandawar/Dynamo/forks","keys_url":"https://api.github.com/repos/riteshchandawar/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/riteshchandawar/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/riteshchandawar/Dynamo/teams","hooks_url":"https://api.github.com/repos/riteshchandawar/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/riteshchandawar/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/riteshchandawar/Dynamo/events","assignees_url":"https://api.github.com/repos/riteshchandawar/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/riteshchandawar/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/riteshchandawar/Dynamo/tags","blobs_url":"https://api.github.com/repos/riteshchandawar/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/riteshchandawar/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/riteshchandawar/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/riteshchandawar/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/riteshchandawar/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/riteshchandawar/Dynamo/languages","stargazers_url":"https://api.github.com/repos/riteshchandawar/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/riteshchandawar/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/riteshchandawar/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/riteshchandawar/Dynamo/subscription","commits_url":"https://api.github.com/repos/riteshchandawar/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/riteshchandawar/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/riteshchandawar/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/riteshchandawar/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/riteshchandawar/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/riteshchandawar/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/riteshchandawar/Dynamo/merges","archive_url":"https://api.github.com/repos/riteshchandawar/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/riteshchandawar/Dynamo/downloads","issues_url":"https://api.github.com/repos/riteshchandawar/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/riteshchandawar/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/riteshchandawar/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/riteshchandawar/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/riteshchandawar/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/riteshchandawar/Dynamo/releases{/id}","created_at":"2013-07-29T02:25:24Z","updated_at":"2014-06-23T03:47:31Z","pushed_at":"2015-07-09T05:34:23Z","git_url":"git://github.com/riteshchandawar/Dynamo.git","ssh_url":"git@github.com:riteshchandawar/Dynamo.git","clone_url":"https://github.com/riteshchandawar/Dynamo.git","svn_url":"https://github.com/riteshchandawar/Dynamo","homepage":"http://dynamobim.org","size":820857,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DynamoDS:master","ref":"master","sha":"dd78ab686df0b72c05083d58ebe3d84bdabb903f","user":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"repo":{"id":3395179,"name":"Dynamo","full_name":"DynamoDS/Dynamo","owner":{"login":"DynamoDS","id":6528209,"avatar_url":"https://avatars.githubusercontent.com/u/6528209?v=3","gravatar_id":"","url":"https://api.github.com/users/DynamoDS","html_url":"https://github.com/DynamoDS","followers_url":"https://api.github.com/users/DynamoDS/followers","following_url":"https://api.github.com/users/DynamoDS/following{/other_user}","gists_url":"https://api.github.com/users/DynamoDS/gists{/gist_id}","starred_url":"https://api.github.com/users/DynamoDS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DynamoDS/subscriptions","organizations_url":"https://api.github.com/users/DynamoDS/orgs","repos_url":"https://api.github.com/users/DynamoDS/repos","events_url":"https://api.github.com/users/DynamoDS/events{/privacy}","received_events_url":"https://api.github.com/users/DynamoDS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DynamoDS/Dynamo","description":"Visual Programming","fork":false,"url":"https://api.github.com/repos/DynamoDS/Dynamo","forks_url":"https://api.github.com/repos/DynamoDS/Dynamo/forks","keys_url":"https://api.github.com/repos/DynamoDS/Dynamo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DynamoDS/Dynamo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DynamoDS/Dynamo/teams","hooks_url":"https://api.github.com/repos/DynamoDS/Dynamo/hooks","issue_events_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/events{/number}","events_url":"https://api.github.com/repos/DynamoDS/Dynamo/events","assignees_url":"https://api.github.com/repos/DynamoDS/Dynamo/assignees{/user}","branches_url":"https://api.github.com/repos/DynamoDS/Dynamo/branches{/branch}","tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/tags","blobs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/refs{/sha}","trees_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/{sha}","languages_url":"https://api.github.com/repos/DynamoDS/Dynamo/languages","stargazers_url":"https://api.github.com/repos/DynamoDS/Dynamo/stargazers","contributors_url":"https://api.github.com/repos/DynamoDS/Dynamo/contributors","subscribers_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscribers","subscription_url":"https://api.github.com/repos/DynamoDS/Dynamo/subscription","commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/commits{/sha}","git_commits_url":"https://api.github.com/repos/DynamoDS/Dynamo/git/commits{/sha}","comments_url":"https://api.github.com/repos/DynamoDS/Dynamo/comments{/number}","issue_comment_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues/comments{/number}","contents_url":"https://api.github.com/repos/DynamoDS/Dynamo/contents/{+path}","compare_url":"https://api.github.com/repos/DynamoDS/Dynamo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DynamoDS/Dynamo/merges","archive_url":"https://api.github.com/repos/DynamoDS/Dynamo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DynamoDS/Dynamo/downloads","issues_url":"https://api.github.com/repos/DynamoDS/Dynamo/issues{/number}","pulls_url":"https://api.github.com/repos/DynamoDS/Dynamo/pulls{/number}","milestones_url":"https://api.github.com/repos/DynamoDS/Dynamo/milestones{/number}","notifications_url":"https://api.github.com/repos/DynamoDS/Dynamo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DynamoDS/Dynamo/labels{/name}","releases_url":"https://api.github.com/repos/DynamoDS/Dynamo/releases{/id}","created_at":"2012-02-09T07:35:33Z","updated_at":"2015-07-08T07:57:19Z","pushed_at":"2015-07-09T05:37:47Z","git_url":"git://github.com/DynamoDS/Dynamo.git","ssh_url":"git@github.com:DynamoDS/Dynamo.git","clone_url":"https://github.com/DynamoDS/Dynamo.git","svn_url":"https://github.com/DynamoDS/Dynamo","homepage":"http://dynamobim.org","size":989929,"stargazers_count":239,"watchers_count":239,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":180,"mirror_url":null,"open_issues_count":665,"forks":180,"open_issues":665,"watchers":239,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4886"},"html":{"href":"https://github.com/DynamoDS/Dynamo/pull/4886"},"issue":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4886"},"comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/issues/4886/comments"},"review_comments":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4886/comments"},"review_comment":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/pulls/4886/commits"},"statuses":{"href":"https://api.github.com/repos/DynamoDS/Dynamo/statuses/ae2e4e4c88e1dea8aff89c919e6245e4af3e38bb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"riteshchandawar","id":5109531,"avatar_url":"https://avatars.githubusercontent.com/u/5109531?v=3","gravatar_id":"","url":"https://api.github.com/users/riteshchandawar","html_url":"https://github.com/riteshchandawar","followers_url":"https://api.github.com/users/riteshchandawar/followers","following_url":"https://api.github.com/users/riteshchandawar/following{/other_user}","gists_url":"https://api.github.com/users/riteshchandawar/gists{/gist_id}","starred_url":"https://api.github.com/users/riteshchandawar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riteshchandawar/subscriptions","organizations_url":"https://api.github.com/users/riteshchandawar/orgs","repos_url":"https://api.github.com/users/riteshchandawar/repos","events_url":"https://api.github.com/users/riteshchandawar/events{/privacy}","received_events_url":"https://api.github.com/users/riteshchandawar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":2,"additions":1,"deletions":6,"changed_files":2}}