{"action":"created","issue":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/419","labels_url":"https://api.github.com/repos/vufind-org/vufind/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/vufind-org/vufind/issues/419/comments","events_url":"https://api.github.com/repos/vufind-org/vufind/issues/419/events","html_url":"https://github.com/vufind-org/vufind/pull/419","id":96490471,"number":419,"title":"Feature/third text domain translations","user":{"login":"guenterh","id":1825990,"avatar_url":"https://avatars.githubusercontent.com/u/1825990?v=3","gravatar_id":"","url":"https://api.github.com/users/guenterh","html_url":"https://github.com/guenterh","followers_url":"https://api.github.com/users/guenterh/followers","following_url":"https://api.github.com/users/guenterh/following{/other_user}","gists_url":"https://api.github.com/users/guenterh/gists{/gist_id}","starred_url":"https://api.github.com/users/guenterh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guenterh/subscriptions","organizations_url":"https://api.github.com/users/guenterh/orgs","repos_url":"https://api.github.com/users/guenterh/repos","events_url":"https://api.github.com/users/guenterh/events{/privacy}","received_events_url":"https://api.github.com/users/guenterh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-22T07:05:56Z","updated_at":"2015-07-22T18:31:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vufind-org/vufind/pulls/419","html_url":"https://github.com/vufind-org/vufind/pull/419","diff_url":"https://github.com/vufind-org/vufind/pull/419.diff","patch_url":"https://github.com/vufind-org/vufind/pull/419.patch"},"body":"This pull request is a replacement for\r\nhttps://github.com/vufind-org/vufind/pull/177\r\nAnyway the discussion thread in the older pull request is still worthwhile.\r\n\r\nAs mentioned in the discussion list: this new starter should be the base (or at least provider of ideas)  for a joined implementation of the multi domain translation feature.\r\n\r\nSome details on the current code:\r\n\r\n- Bootstrapper\r\nparsing of configured locations with directories containing TextDomains for translation\r\n\r\n\r\n- ExtendedIni type:\r\nis now able to load flat (default) TextDomain (as in the past)\r\nand dedicated TextDomains\r\n\r\n\r\n- TranslatorAwareTrait\r\nnew: handling of types (arrays) containing the string to be translated and the TextDoamin the string is part of\r\nquestion: naming and relation to translateString (default VF behaviour)?\r\n\r\n- Translate ViewHelper\r\nis now able to start the translation process for strings part of a dedicated TextDomain\r\n\r\n\r\n- Solr Results\r\nhandling of facet translation (part of specialized TextDomain) with utility method\r\n(I was surprised that Summon doesn't know facet translation - at least what I have seen looking into the code)\r\n\r\n\r\n- new (not part of translation enhancement but something which is heavily required by our librarians and now functionality of swissbib...)\r\nif this won't be part of the core we have to overwrite the functionality only for this (so would be nice...)\r\nfunctionality: possibility to customize the facet list length for dedicated facets\r\n\r\nfacet_limit        = 30     ; how many values should we show for each facet?\r\n;taylor the list displayed as default for dedicated facets\r\nfacet_limit_format         = 5\r\nfacet_limit_language       = 7\r\n\r\nif this functionality will be part of VF it has to be added for other targets too (beside SOLR one view we are running is using Summon) - not dine so far because I don't know if it is accepted by the community\r\n"},"comment":{"url":"https://api.github.com/repos/vufind-org/vufind/issues/comments/123818671","html_url":"https://github.com/vufind-org/vufind/pull/419#issuecomment-123818671","issue_url":"https://api.github.com/repos/vufind-org/vufind/issues/419","id":123818671,"user":{"login":"demiankatz","id":309069,"avatar_url":"https://avatars.githubusercontent.com/u/309069?v=3","gravatar_id":"","url":"https://api.github.com/users/demiankatz","html_url":"https://github.com/demiankatz","followers_url":"https://api.github.com/users/demiankatz/followers","following_url":"https://api.github.com/users/demiankatz/following{/other_user}","gists_url":"https://api.github.com/users/demiankatz/gists{/gist_id}","starred_url":"https://api.github.com/users/demiankatz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/demiankatz/subscriptions","organizations_url":"https://api.github.com/users/demiankatz/orgs","repos_url":"https://api.github.com/users/demiankatz/repos","events_url":"https://api.github.com/users/demiankatz/events{/privacy}","received_events_url":"https://api.github.com/users/demiankatz/received_events","type":"User","site_admin":false},"created_at":"2015-07-22T18:31:37Z","updated_at":"2015-07-22T18:31:37Z","body":"First update: I've implemented the facet limit by field functionality you need, both for Solr and for Summon. See these commits: https://github.com/vufind-org/vufind/commit/fbad2f0e4be8512ecefafad97c9682150de4c5c0, https://github.com/vufind-org/vufind/commit/cf885897112b28d82c415c72fda55c85f18fe817. Note that I changed the configuration key to an array to make the configuration easier to work with. Hopefully this won't be a major inconvenience for you. A significant benefit is that now the data is retrieved with the correct number of values, so you don't need to do any extra work in the templates.\r\n\r\nIf this works for you, I'd recommend merging the latest master into this branch and removing the code related to this new feature -- that way we can focus on the text domain stuff which is really key to this pull request.\r\n\r\nAnother side note: you mention that Summon does not support facet translation, but this is incorrect. If you set up the `translated_facets` setting in the `[Advanced_Facet_Settings]` section of Summon.ini, translation will be applied (I just tried it on my test server to confirm). However, Summon uses many strings which are not found in VuFind's language files -- perhaps this is the reason it appears that no translation is occurring. You may just need to add some additional translations!"}}