{"action":"closed","number":220,"pull_request":{"url":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/220","id":36030854,"html_url":"https://github.com/gerstrong/Commander-Genius/pull/220","diff_url":"https://github.com/gerstrong/Commander-Genius/pull/220.diff","patch_url":"https://github.com/gerstrong/Commander-Genius/pull/220.patch","issue_url":"https://api.github.com/repos/gerstrong/Commander-Genius/issues/220","number":220,"state":"closed","locked":false,"title":"fix lintian warnings, typos","user":{"login":"a-detiste","id":7994192,"avatar_url":"https://avatars.githubusercontent.com/u/7994192?v=3","gravatar_id":"","url":"https://api.github.com/users/a-detiste","html_url":"https://github.com/a-detiste","followers_url":"https://api.github.com/users/a-detiste/followers","following_url":"https://api.github.com/users/a-detiste/following{/other_user}","gists_url":"https://api.github.com/users/a-detiste/gists{/gist_id}","starred_url":"https://api.github.com/users/a-detiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-detiste/subscriptions","organizations_url":"https://api.github.com/users/a-detiste/orgs","repos_url":"https://api.github.com/users/a-detiste/repos","events_url":"https://api.github.com/users/a-detiste/events{/privacy}","received_events_url":"https://api.github.com/users/a-detiste/received_events","type":"User","site_admin":false},"body":"This is just non-intrusive ground work to include CG in Debian?\r\n\r\nThis solves these lintian warnings:\r\n\r\n```\r\nI: commandergenius: spelling-error-in-binary usr/games/CGeniusExe throught through\r\nI: commandergenius: spelling-error-in-binary usr/games/CGeniusExe sucessfully successfully\r\nW: commandergenius: description-too-long\r\nE: commandergenius: extended-description-is-empty\r\n```\r\n\r\n---\r\n\r\nNow for the remaining ones:\r\n\r\n`W: commandergenius: binary-without-manpage usr/games/CGeniusExe`\r\n\r\nWould you accept to ship a manpage upstream if I provide one ?\r\nWhat are the accepted command-line parameters ?  \r\nI tried `-v / --version / -h / --help` with no luck.\r\n\r\n---\r\n\r\n```\r\nE: commandergenius: unstripped-binary-or-object usr/games/CGeniusExe\r\nE: commandergenius: missing-dependency-on-libc needed by usr/games/CGeniusExe\r\nE: commandergenius: changelog-file-missing-in-native-package\r\nE: commandergenius: no-copyright-file\r\nW: commandergenius: hardening-no-relro usr/games/CGeniusExe\r\nI: commandergenius: no-md5sums-control-file\r\nI: commandergenius: hardening-no-fortify-functions usr/games/CGeniusExe\r\nX: commandergenius: missing-dependency-on-libstdc++ needed by usr/games/CGeniusExe\r\n```\r\n\r\nMost of these warning would likely disappear if you switched to DebHelper 9:\r\n(Launchpad can handle this)\r\nhttps://wiki.debian.org/IntroDebianPackaging\r\n\r\nI can provide a P.R. for that too, but I can't test it in launchpad myself.\r\n\r\n----\r\n\r\n```\r\nI: commandergenius: arch-dep-package-has-big-usr-share 14353kB 80%\r\n```\r\n\r\nThe original shareware data will likely not be shipped in the Debian\r\npackage, only the GPL-3 CG bits.  \r\nBut there is a dedicated tool to handle this problem: `game-data-packager` .\r\n\r\nI filed and will most likely handle this game request:\r\nhttps://bugs.debian.org/cgi-bin/bugreport.cgi?bug=786501\r\n\r\n----\r\n\r\n```\r\nI: commandergenius: desktop-entry-lacks-keywords-entry usr/share/applications/cgenius.desktop\r\n```\r\n\r\nWorthless warning","created_at":"2015-05-22T13:31:32Z","updated_at":"2015-05-22T14:54:48Z","closed_at":"2015-05-22T14:54:48Z","merged_at":"2015-05-22T14:54:48Z","merge_commit_sha":"54ad6dbbce667c4f71153103550049f97b13f252","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/220/commits","review_comments_url":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/220/comments","review_comment_url":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gerstrong/Commander-Genius/issues/220/comments","statuses_url":"https://api.github.com/repos/gerstrong/Commander-Genius/statuses/1e3f1f36f98d9ddaf78459560a6a5cc20738be74","head":{"label":"a-detiste:master","ref":"master","sha":"1e3f1f36f98d9ddaf78459560a6a5cc20738be74","user":{"login":"a-detiste","id":7994192,"avatar_url":"https://avatars.githubusercontent.com/u/7994192?v=3","gravatar_id":"","url":"https://api.github.com/users/a-detiste","html_url":"https://github.com/a-detiste","followers_url":"https://api.github.com/users/a-detiste/followers","following_url":"https://api.github.com/users/a-detiste/following{/other_user}","gists_url":"https://api.github.com/users/a-detiste/gists{/gist_id}","starred_url":"https://api.github.com/users/a-detiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-detiste/subscriptions","organizations_url":"https://api.github.com/users/a-detiste/orgs","repos_url":"https://api.github.com/users/a-detiste/repos","events_url":"https://api.github.com/users/a-detiste/events{/privacy}","received_events_url":"https://api.github.com/users/a-detiste/received_events","type":"User","site_admin":false},"repo":{"id":36072739,"name":"Commander-Genius","full_name":"a-detiste/Commander-Genius","owner":{"login":"a-detiste","id":7994192,"avatar_url":"https://avatars.githubusercontent.com/u/7994192?v=3","gravatar_id":"","url":"https://api.github.com/users/a-detiste","html_url":"https://github.com/a-detiste","followers_url":"https://api.github.com/users/a-detiste/followers","following_url":"https://api.github.com/users/a-detiste/following{/other_user}","gists_url":"https://api.github.com/users/a-detiste/gists{/gist_id}","starred_url":"https://api.github.com/users/a-detiste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-detiste/subscriptions","organizations_url":"https://api.github.com/users/a-detiste/orgs","repos_url":"https://api.github.com/users/a-detiste/repos","events_url":"https://api.github.com/users/a-detiste/events{/privacy}","received_events_url":"https://api.github.com/users/a-detiste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-detiste/Commander-Genius","description":"Modern Interpreter for the Commander Keen Games (Vorticon and Galaxy Games) ","fork":true,"url":"https://api.github.com/repos/a-detiste/Commander-Genius","forks_url":"https://api.github.com/repos/a-detiste/Commander-Genius/forks","keys_url":"https://api.github.com/repos/a-detiste/Commander-Genius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-detiste/Commander-Genius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-detiste/Commander-Genius/teams","hooks_url":"https://api.github.com/repos/a-detiste/Commander-Genius/hooks","issue_events_url":"https://api.github.com/repos/a-detiste/Commander-Genius/issues/events{/number}","events_url":"https://api.github.com/repos/a-detiste/Commander-Genius/events","assignees_url":"https://api.github.com/repos/a-detiste/Commander-Genius/assignees{/user}","branches_url":"https://api.github.com/repos/a-detiste/Commander-Genius/branches{/branch}","tags_url":"https://api.github.com/repos/a-detiste/Commander-Genius/tags","blobs_url":"https://api.github.com/repos/a-detiste/Commander-Genius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-detiste/Commander-Genius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-detiste/Commander-Genius/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-detiste/Commander-Genius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-detiste/Commander-Genius/statuses/{sha}","languages_url":"https://api.github.com/repos/a-detiste/Commander-Genius/languages","stargazers_url":"https://api.github.com/repos/a-detiste/Commander-Genius/stargazers","contributors_url":"https://api.github.com/repos/a-detiste/Commander-Genius/contributors","subscribers_url":"https://api.github.com/repos/a-detiste/Commander-Genius/subscribers","subscription_url":"https://api.github.com/repos/a-detiste/Commander-Genius/subscription","commits_url":"https://api.github.com/repos/a-detiste/Commander-Genius/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-detiste/Commander-Genius/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-detiste/Commander-Genius/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-detiste/Commander-Genius/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-detiste/Commander-Genius/contents/{+path}","compare_url":"https://api.github.com/repos/a-detiste/Commander-Genius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-detiste/Commander-Genius/merges","archive_url":"https://api.github.com/repos/a-detiste/Commander-Genius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-detiste/Commander-Genius/downloads","issues_url":"https://api.github.com/repos/a-detiste/Commander-Genius/issues{/number}","pulls_url":"https://api.github.com/repos/a-detiste/Commander-Genius/pulls{/number}","milestones_url":"https://api.github.com/repos/a-detiste/Commander-Genius/milestones{/number}","notifications_url":"https://api.github.com/repos/a-detiste/Commander-Genius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-detiste/Commander-Genius/labels{/name}","releases_url":"https://api.github.com/repos/a-detiste/Commander-Genius/releases{/id}","created_at":"2015-05-22T13:06:49Z","updated_at":"2015-05-22T13:06:56Z","pushed_at":"2015-05-22T13:21:10Z","git_url":"git://github.com/a-detiste/Commander-Genius.git","ssh_url":"git@github.com:a-detiste/Commander-Genius.git","clone_url":"https://github.com/a-detiste/Commander-Genius.git","svn_url":"https://github.com/a-detiste/Commander-Genius","homepage":"http://clonekeenplus.sourceforge.net/","size":139687,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gerstrong:master","ref":"master","sha":"819a60d58080cec42611fedb9c1658600b1ef137","user":{"login":"gerstrong","id":314853,"avatar_url":"https://avatars.githubusercontent.com/u/314853?v=3","gravatar_id":"","url":"https://api.github.com/users/gerstrong","html_url":"https://github.com/gerstrong","followers_url":"https://api.github.com/users/gerstrong/followers","following_url":"https://api.github.com/users/gerstrong/following{/other_user}","gists_url":"https://api.github.com/users/gerstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/gerstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerstrong/subscriptions","organizations_url":"https://api.github.com/users/gerstrong/orgs","repos_url":"https://api.github.com/users/gerstrong/repos","events_url":"https://api.github.com/users/gerstrong/events{/privacy}","received_events_url":"https://api.github.com/users/gerstrong/received_events","type":"User","site_admin":false},"repo":{"id":3074022,"name":"Commander-Genius","full_name":"gerstrong/Commander-Genius","owner":{"login":"gerstrong","id":314853,"avatar_url":"https://avatars.githubusercontent.com/u/314853?v=3","gravatar_id":"","url":"https://api.github.com/users/gerstrong","html_url":"https://github.com/gerstrong","followers_url":"https://api.github.com/users/gerstrong/followers","following_url":"https://api.github.com/users/gerstrong/following{/other_user}","gists_url":"https://api.github.com/users/gerstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/gerstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerstrong/subscriptions","organizations_url":"https://api.github.com/users/gerstrong/orgs","repos_url":"https://api.github.com/users/gerstrong/repos","events_url":"https://api.github.com/users/gerstrong/events{/privacy}","received_events_url":"https://api.github.com/users/gerstrong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gerstrong/Commander-Genius","description":"Modern Interpreter for the Commander Keen Games (Vorticon and Galaxy Games) ","fork":false,"url":"https://api.github.com/repos/gerstrong/Commander-Genius","forks_url":"https://api.github.com/repos/gerstrong/Commander-Genius/forks","keys_url":"https://api.github.com/repos/gerstrong/Commander-Genius/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gerstrong/Commander-Genius/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gerstrong/Commander-Genius/teams","hooks_url":"https://api.github.com/repos/gerstrong/Commander-Genius/hooks","issue_events_url":"https://api.github.com/repos/gerstrong/Commander-Genius/issues/events{/number}","events_url":"https://api.github.com/repos/gerstrong/Commander-Genius/events","assignees_url":"https://api.github.com/repos/gerstrong/Commander-Genius/assignees{/user}","branches_url":"https://api.github.com/repos/gerstrong/Commander-Genius/branches{/branch}","tags_url":"https://api.github.com/repos/gerstrong/Commander-Genius/tags","blobs_url":"https://api.github.com/repos/gerstrong/Commander-Genius/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gerstrong/Commander-Genius/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gerstrong/Commander-Genius/git/refs{/sha}","trees_url":"https://api.github.com/repos/gerstrong/Commander-Genius/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gerstrong/Commander-Genius/statuses/{sha}","languages_url":"https://api.github.com/repos/gerstrong/Commander-Genius/languages","stargazers_url":"https://api.github.com/repos/gerstrong/Commander-Genius/stargazers","contributors_url":"https://api.github.com/repos/gerstrong/Commander-Genius/contributors","subscribers_url":"https://api.github.com/repos/gerstrong/Commander-Genius/subscribers","subscription_url":"https://api.github.com/repos/gerstrong/Commander-Genius/subscription","commits_url":"https://api.github.com/repos/gerstrong/Commander-Genius/commits{/sha}","git_commits_url":"https://api.github.com/repos/gerstrong/Commander-Genius/git/commits{/sha}","comments_url":"https://api.github.com/repos/gerstrong/Commander-Genius/comments{/number}","issue_comment_url":"https://api.github.com/repos/gerstrong/Commander-Genius/issues/comments{/number}","contents_url":"https://api.github.com/repos/gerstrong/Commander-Genius/contents/{+path}","compare_url":"https://api.github.com/repos/gerstrong/Commander-Genius/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gerstrong/Commander-Genius/merges","archive_url":"https://api.github.com/repos/gerstrong/Commander-Genius/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gerstrong/Commander-Genius/downloads","issues_url":"https://api.github.com/repos/gerstrong/Commander-Genius/issues{/number}","pulls_url":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls{/number}","milestones_url":"https://api.github.com/repos/gerstrong/Commander-Genius/milestones{/number}","notifications_url":"https://api.github.com/repos/gerstrong/Commander-Genius/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gerstrong/Commander-Genius/labels{/name}","releases_url":"https://api.github.com/repos/gerstrong/Commander-Genius/releases{/id}","created_at":"2011-12-30T10:58:40Z","updated_at":"2015-04-23T15:26:41Z","pushed_at":"2015-05-22T14:54:48Z","git_url":"git://github.com/gerstrong/Commander-Genius.git","ssh_url":"git@github.com:gerstrong/Commander-Genius.git","clone_url":"https://github.com/gerstrong/Commander-Genius.git","svn_url":"https://github.com/gerstrong/Commander-Genius","homepage":"http://clonekeenplus.sourceforge.net/","size":139687,"stargazers_count":44,"watchers_count":44,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":16,"forks":12,"open_issues":16,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/220"},"html":{"href":"https://github.com/gerstrong/Commander-Genius/pull/220"},"issue":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/issues/220"},"comments":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/gerstrong/Commander-Genius/statuses/1e3f1f36f98d9ddaf78459560a6a5cc20738be74"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gerstrong","id":314853,"avatar_url":"https://avatars.githubusercontent.com/u/314853?v=3","gravatar_id":"","url":"https://api.github.com/users/gerstrong","html_url":"https://github.com/gerstrong","followers_url":"https://api.github.com/users/gerstrong/followers","following_url":"https://api.github.com/users/gerstrong/following{/other_user}","gists_url":"https://api.github.com/users/gerstrong/gists{/gist_id}","starred_url":"https://api.github.com/users/gerstrong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gerstrong/subscriptions","organizations_url":"https://api.github.com/users/gerstrong/orgs","repos_url":"https://api.github.com/users/gerstrong/repos","events_url":"https://api.github.com/users/gerstrong/events{/privacy}","received_events_url":"https://api.github.com/users/gerstrong/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":19,"deletions":7,"changed_files":5}}