{"action":"created","issue":{"url":"https://api.github.com/repos/request/request/issues/1346","labels_url":"https://api.github.com/repos/request/request/issues/1346/labels{/name}","comments_url":"https://api.github.com/repos/request/request/issues/1346/comments","events_url":"https://api.github.com/repos/request/request/issues/1346/events","html_url":"https://github.com/request/request/pull/1346","id":53830705,"number":1346,"title":"getProxyFromURI Extraction Refactor","user":{"login":"seanstrom","id":2845768,"avatar_url":"https://avatars.githubusercontent.com/u/2845768?v=3","gravatar_id":"","url":"https://api.github.com/users/seanstrom","html_url":"https://github.com/seanstrom","followers_url":"https://api.github.com/users/seanstrom/followers","following_url":"https://api.github.com/users/seanstrom/following{/other_user}","gists_url":"https://api.github.com/users/seanstrom/gists{/gist_id}","starred_url":"https://api.github.com/users/seanstrom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seanstrom/subscriptions","organizations_url":"https://api.github.com/users/seanstrom/orgs","repos_url":"https://api.github.com/users/seanstrom/repos","events_url":"https://api.github.com/users/seanstrom/events{/privacy}","received_events_url":"https://api.github.com/users/seanstrom/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-01-09T03:40:34Z","updated_at":"2015-01-12T22:55:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/request/request/pulls/1346","html_url":"https://github.com/request/request/pull/1346","diff_url":"https://github.com/request/request/pull/1346.diff","patch_url":"https://github.com/request/request/pull/1346.patch"},"body":"The getProxyFromURI function seems like a good candidate to remove from the\r\nrequest.js file. That file is bloated and this fits well as a module.\r\n\r\nThis is still in need of a few more changes, but I figured people can start reviewing.\r\n\r\n@simov @FredKSchott @nylen review?"},"comment":{"url":"https://api.github.com/repos/request/request/issues/comments/69663647","html_url":"https://github.com/request/request/pull/1346#issuecomment-69663647","issue_url":"https://api.github.com/repos/request/request/issues/1346","id":69663647,"user":{"login":"simov","id":1694112,"avatar_url":"https://avatars.githubusercontent.com/u/1694112?v=3","gravatar_id":"","url":"https://api.github.com/users/simov","html_url":"https://github.com/simov","followers_url":"https://api.github.com/users/simov/followers","following_url":"https://api.github.com/users/simov/following{/other_user}","gists_url":"https://api.github.com/users/simov/gists{/gist_id}","starred_url":"https://api.github.com/users/simov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simov/subscriptions","organizations_url":"https://api.github.com/users/simov/orgs","repos_url":"https://api.github.com/users/simov/repos","events_url":"https://api.github.com/users/simov/events{/privacy}","received_events_url":"https://api.github.com/users/simov/received_events","type":"User","site_admin":false},"created_at":"2015-01-12T22:55:49Z","updated_at":"2015-01-12T22:55:49Z","body":"The functions per code was exactly as your statement a few post above, when you said that you sometimes overly engineer things and rather decouple them - just a point of view.\r\n\r\nSo how the added complexity can be justified?\r\n\r\nAs for explaining me the encapsulation and stuff - do we really need that in this case?\r\n\r\nHopefully I'm not getting too annoying, but you asked me in the first place :)"}}