{"push_id":894525595,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"6e06dcb6d31b5e8b5ae8799e52779b4845799bad","before":"7f362a983372affc0bd1cec84d4b76340f654b80","commits":[{"sha":"c0d7296d30e3ae630c63cc78a40f19eb77e24b09","author":{"email":"65e093fb55df3aea2281cbef9309c530c18aba77@feth.com","name":"Joscha Feth"},"message":"fix: determine port correctly for HTTPs resources","distinct":true,"url":"https://api.github.com/repos/cgiffard/node-simplecrawler/commits/c0d7296d30e3ae630c63cc78a40f19eb77e24b09"},{"sha":"3de0e9e2a5d361413c8b30638be982a1af389dc7","author":{"email":"00a01bc96b0eb2470e2e984031dd42cfc1384ce0@gmail.com","name":"Fan Jin"},"message":"I saw a process.nextTick right after crawler.emit(\"fetchstart\"), I think yeah this gives user time to change the request options.\nThen I think wait isn't `.emit` and `.on` are all synchronoous?\nSo I don't understand why do we need the process.nextTick() after fetchstart.\n\nIn the start() function of crawler.js I see in the end there's a process.nextTick, and that is used for collecting user custom options before we start even if we call the start() before those custom options.\nBut the crawler.interval cannot get picked up this way. Maybe I'm wrong but should the run loop(setTimeout part) inside nextTick aswell?\n\nThe resource here was decleared but never used in the function, this\nleads ```js\nif (resources.reduce(function(prev, current) {\n    return prev || current === URL;\n}, false)) {\n    return list;\n}```  malfunctioning? I change it with list so that this function\ncan work again.","distinct":true,"url":"https://api.github.com/repos/cgiffard/node-simplecrawler/commits/3de0e9e2a5d361413c8b30638be982a1af389dc7"},{"sha":"6e06dcb6d31b5e8b5ae8799e52779b4845799bad","author":{"email":"f487c7598f046a9a67757788cf85ee89028a1b14@fredrik.computer","name":"Fredrik Ekelund"},"message":"Merge pull request #196 from bfwg/master\n\n1. Wait to set the main crawl interval until the next tick. We currently wait for the next tick to make the first crawler request to enable the dev to change settings directly after having started the crawler.\r\n2. On line 513, resources is used, but that array will always be empty, so we're really looking to use list instead. Changed that.\r\n3. In the fetchQueueItem method, the event listeners on clientRequest are registered inside of a process.nextTick call. According to the inline documentation, the function should return the crawler object for chaining, which it currently does not, since the return is being done inside of the process.nextTick call. So the process.nextTick call was removed there as well.","distinct":true,"url":"https://api.github.com/repos/cgiffard/node-simplecrawler/commits/6e06dcb6d31b5e8b5ae8799e52779b4845799bad"}]}