{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/41502380","id":41502380,"diff_hunk":"@@ -151,30 +152,53 @@ bool CBoot::LoadMapFromFilename()\n // It does not initialize the hardware or anything else like BS1 does.\n bool CBoot::Load_BS2(const std::string& _rBootROMFilename)\n {\n-\tconst u32 USA = 0x1FCE3FD6;\n+\t/* Adler32 Hashes\n+\tconst u32 USA_v1_0 = 0x1FCE3FD6;\n \tconst u32 USA_v1_1 = 0x4D5935D1;\n-\tconst u32 JAP = 0x87424396;\n-\tconst u32 PAL = 0xA0EA7341;\n+\tconst u32 USA_v1_2 = 0xDF6CF65B;\n+\tconst u32 JAP_v1_0 = 0xB2FCDB25;\n+\tconst u32 JAP_v1_1 = 0x46E899DB;\n+\tconst u32 JAP_unknown = 0x87424396;\n+\tconst u32 PAL_v1_0 = 0xAF912C43;\n+\tconst u32 PAL_unknown = 0xA0EA7341;","path":"Source/Core/Core/Boot/Boot.cpp","position":28,"original_position":28,"commit_id":"54c656d3f2780db5d95d4e94363cced1274beb6d","original_commit_id":"54c656d3f2780db5d95d4e94363cced1274beb6d","user":{"login":"lioncash","id":712067,"avatar_url":"https://avatars.githubusercontent.com/u/712067?v=3","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"This code should be removed if it isn't going to be used.","created_at":"2015-10-08T11:32:31Z","updated_at":"2015-10-08T11:32:31Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/3152#discussion_r41502380","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/41502380"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3152#discussion_r41502380"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152","id":47135027,"html_url":"https://github.com/dolphin-emu/dolphin/pull/3152","diff_url":"https://github.com/dolphin-emu/dolphin/pull/3152.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/3152.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3152","number":3152,"state":"open","locked":false,"title":"Use CRC32 for IPL checks and update hashes","user":{"login":"ShadowsFriend","id":105785,"avatar_url":"https://avatars.githubusercontent.com/u/105785?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowsFriend","html_url":"https://github.com/ShadowsFriend","followers_url":"https://api.github.com/users/ShadowsFriend/followers","following_url":"https://api.github.com/users/ShadowsFriend/following{/other_user}","gists_url":"https://api.github.com/users/ShadowsFriend/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowsFriend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowsFriend/subscriptions","organizations_url":"https://api.github.com/users/ShadowsFriend/orgs","repos_url":"https://api.github.com/users/ShadowsFriend/repos","events_url":"https://api.github.com/users/ShadowsFriend/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowsFriend/received_events","type":"User","site_admin":false},"body":"This changes the hashing algorithm from Adler32 to CRC32 for it\r\nis more widely used and therefore makes it easier to verify hashes.\r\nFor example the Redump database does provide CRC32 hashes, while it\r\ndoesn't have Adler32 ones.\r\nAdditionally adds new hashes from the bugtracker and the forums and\r\nremoves unknown ones.\r\nShould fix issues https://bugs.dolphin-emu.org/issues/7035 and https://bugs.dolphin-emu.org/issues/8936.","created_at":"2015-10-08T10:20:33Z","updated_at":"2015-10-08T11:32:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aecd5fc60758391e2be140317e26fce35ecafac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3152/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/54c656d3f2780db5d95d4e94363cced1274beb6d","head":{"label":"ShadowsFriend:ipl_checksum","ref":"ipl_checksum","sha":"54c656d3f2780db5d95d4e94363cced1274beb6d","user":{"login":"ShadowsFriend","id":105785,"avatar_url":"https://avatars.githubusercontent.com/u/105785?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowsFriend","html_url":"https://github.com/ShadowsFriend","followers_url":"https://api.github.com/users/ShadowsFriend/followers","following_url":"https://api.github.com/users/ShadowsFriend/following{/other_user}","gists_url":"https://api.github.com/users/ShadowsFriend/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowsFriend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowsFriend/subscriptions","organizations_url":"https://api.github.com/users/ShadowsFriend/orgs","repos_url":"https://api.github.com/users/ShadowsFriend/repos","events_url":"https://api.github.com/users/ShadowsFriend/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowsFriend/received_events","type":"User","site_admin":false},"repo":{"id":43683517,"name":"dolphin","full_name":"ShadowsFriend/dolphin","owner":{"login":"ShadowsFriend","id":105785,"avatar_url":"https://avatars.githubusercontent.com/u/105785?v=3","gravatar_id":"","url":"https://api.github.com/users/ShadowsFriend","html_url":"https://github.com/ShadowsFriend","followers_url":"https://api.github.com/users/ShadowsFriend/followers","following_url":"https://api.github.com/users/ShadowsFriend/following{/other_user}","gists_url":"https://api.github.com/users/ShadowsFriend/gists{/gist_id}","starred_url":"https://api.github.com/users/ShadowsFriend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShadowsFriend/subscriptions","organizations_url":"https://api.github.com/users/ShadowsFriend/orgs","repos_url":"https://api.github.com/users/ShadowsFriend/repos","events_url":"https://api.github.com/users/ShadowsFriend/events{/privacy}","received_events_url":"https://api.github.com/users/ShadowsFriend/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShadowsFriend/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/ShadowsFriend/dolphin","forks_url":"https://api.github.com/repos/ShadowsFriend/dolphin/forks","keys_url":"https://api.github.com/repos/ShadowsFriend/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShadowsFriend/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShadowsFriend/dolphin/teams","hooks_url":"https://api.github.com/repos/ShadowsFriend/dolphin/hooks","issue_events_url":"https://api.github.com/repos/ShadowsFriend/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/ShadowsFriend/dolphin/events","assignees_url":"https://api.github.com/repos/ShadowsFriend/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/ShadowsFriend/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/ShadowsFriend/dolphin/tags","blobs_url":"https://api.github.com/repos/ShadowsFriend/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShadowsFriend/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShadowsFriend/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShadowsFriend/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShadowsFriend/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/ShadowsFriend/dolphin/languages","stargazers_url":"https://api.github.com/repos/ShadowsFriend/dolphin/stargazers","contributors_url":"https://api.github.com/repos/ShadowsFriend/dolphin/contributors","subscribers_url":"https://api.github.com/repos/ShadowsFriend/dolphin/subscribers","subscription_url":"https://api.github.com/repos/ShadowsFriend/dolphin/subscription","commits_url":"https://api.github.com/repos/ShadowsFriend/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShadowsFriend/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShadowsFriend/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShadowsFriend/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShadowsFriend/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/ShadowsFriend/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShadowsFriend/dolphin/merges","archive_url":"https://api.github.com/repos/ShadowsFriend/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShadowsFriend/dolphin/downloads","issues_url":"https://api.github.com/repos/ShadowsFriend/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/ShadowsFriend/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/ShadowsFriend/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/ShadowsFriend/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShadowsFriend/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/ShadowsFriend/dolphin/releases{/id}","created_at":"2015-10-05T12:42:11Z","updated_at":"2015-10-05T12:42:50Z","pushed_at":"2015-10-08T10:11:46Z","git_url":"git://github.com/ShadowsFriend/dolphin.git","ssh_url":"git@github.com:ShadowsFriend/dolphin.git","clone_url":"https://github.com/ShadowsFriend/dolphin.git","svn_url":"https://github.com/ShadowsFriend/dolphin","homepage":"https://dolphin-emu.org/","size":226151,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"ec28d7df924f427fc9ae4830c520aaf121cb3713","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-10-08T03:19:39Z","pushed_at":"2015-10-08T10:20:33Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":311723,"stargazers_count":1696,"watchers_count":1696,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":525,"mirror_url":null,"open_issues_count":84,"forks":525,"open_issues":84,"watchers":1696,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/3152"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3152"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/3152/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/3152/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/54c656d3f2780db5d95d4e94363cced1274beb6d"}}}}