{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/oauthenticator/pulls/comments/36237524","id":36237524,"diff_hunk":"@@ -21,10 +21,16 @@\n \n from traitlets import Unicode, Set\n \n+# Support github.com and github enterprise installations\n+GITHUB_HOST = os.environ.get('GITHUB_HOST', 'github.com')","path":"oauthenticator.py","position":5,"original_position":5,"commit_id":"8e5d74ea3e288ee8f60e09f392ac63eadef29a51","original_commit_id":"8e5d74ea3e288ee8f60e09f392ac63eadef29a51","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"This should use `get('GITHUB_HOST') or 'github.com'` to handle the `GITHUB_HOST=''` case, which should behave the same as being unset.","created_at":"2015-08-04T20:30:54Z","updated_at":"2015-08-04T20:30:54Z","html_url":"https://github.com/jupyter/oauthenticator/pull/10#discussion_r36237524","pull_request_url":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/jupyter/oauthenticator/pulls/comments/36237524"},"html":{"href":"https://github.com/jupyter/oauthenticator/pull/10#discussion_r36237524"},"pull_request":{"href":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10","id":41607592,"html_url":"https://github.com/jupyter/oauthenticator/pull/10","diff_url":"https://github.com/jupyter/oauthenticator/pull/10.diff","patch_url":"https://github.com/jupyter/oauthenticator/pull/10.patch","issue_url":"https://api.github.com/repos/jupyter/oauthenticator/issues/10","number":10,"state":"open","locked":false,"title":"Adding support for GitHub Enterprise","user":{"login":"cmclaughlin","id":1061109,"avatar_url":"https://avatars.githubusercontent.com/u/1061109?v=3","gravatar_id":"","url":"https://api.github.com/users/cmclaughlin","html_url":"https://github.com/cmclaughlin","followers_url":"https://api.github.com/users/cmclaughlin/followers","following_url":"https://api.github.com/users/cmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/cmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/cmclaughlin/orgs","repos_url":"https://api.github.com/users/cmclaughlin/repos","events_url":"https://api.github.com/users/cmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/cmclaughlin/received_events","type":"User","site_admin":false},"body":"I added support for a new GITHUB_HOST environment variable so we can use our GitHub Enterprise instance for jupyterhub auth.","created_at":"2015-08-04T19:27:48Z","updated_at":"2015-08-04T20:30:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"705c75192e2d699aa08a128b85ce037f3cbd6072","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10/commits","review_comments_url":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10/comments","review_comment_url":"https://api.github.com/repos/jupyter/oauthenticator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/oauthenticator/issues/10/comments","statuses_url":"https://api.github.com/repos/jupyter/oauthenticator/statuses/8e5d74ea3e288ee8f60e09f392ac63eadef29a51","head":{"label":"cmclaughlin:master","ref":"master","sha":"8e5d74ea3e288ee8f60e09f392ac63eadef29a51","user":{"login":"cmclaughlin","id":1061109,"avatar_url":"https://avatars.githubusercontent.com/u/1061109?v=3","gravatar_id":"","url":"https://api.github.com/users/cmclaughlin","html_url":"https://github.com/cmclaughlin","followers_url":"https://api.github.com/users/cmclaughlin/followers","following_url":"https://api.github.com/users/cmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/cmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/cmclaughlin/orgs","repos_url":"https://api.github.com/users/cmclaughlin/repos","events_url":"https://api.github.com/users/cmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/cmclaughlin/received_events","type":"User","site_admin":false},"repo":{"id":40151605,"name":"oauthenticator","full_name":"cmclaughlin/oauthenticator","owner":{"login":"cmclaughlin","id":1061109,"avatar_url":"https://avatars.githubusercontent.com/u/1061109?v=3","gravatar_id":"","url":"https://api.github.com/users/cmclaughlin","html_url":"https://github.com/cmclaughlin","followers_url":"https://api.github.com/users/cmclaughlin/followers","following_url":"https://api.github.com/users/cmclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/cmclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/cmclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmclaughlin/subscriptions","organizations_url":"https://api.github.com/users/cmclaughlin/orgs","repos_url":"https://api.github.com/users/cmclaughlin/repos","events_url":"https://api.github.com/users/cmclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/cmclaughlin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmclaughlin/oauthenticator","description":"GitHub OAuth + JupyterHub Authenticator = OAuthenticator","fork":true,"url":"https://api.github.com/repos/cmclaughlin/oauthenticator","forks_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/forks","keys_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/teams","hooks_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/hooks","issue_events_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/issues/events{/number}","events_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/events","assignees_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/assignees{/user}","branches_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/branches{/branch}","tags_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/tags","blobs_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/languages","stargazers_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/stargazers","contributors_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/contributors","subscribers_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/subscribers","subscription_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/subscription","commits_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/contents/{+path}","compare_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/merges","archive_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/downloads","issues_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/issues{/number}","pulls_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/labels{/name}","releases_url":"https://api.github.com/repos/cmclaughlin/oauthenticator/releases{/id}","created_at":"2015-08-03T22:46:53Z","updated_at":"2015-08-03T22:46:53Z","pushed_at":"2015-08-04T19:19:10Z","git_url":"git://github.com/cmclaughlin/oauthenticator.git","ssh_url":"git@github.com:cmclaughlin/oauthenticator.git","clone_url":"https://github.com/cmclaughlin/oauthenticator.git","svn_url":"https://github.com/cmclaughlin/oauthenticator","homepage":"","size":247,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"37f66a0b25f01bab685d91d224664e1e375c2b4d","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":24390283,"name":"oauthenticator","full_name":"jupyter/oauthenticator","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/oauthenticator","description":"GitHub OAuth + JupyterHub Authenticator = OAuthenticator","fork":false,"url":"https://api.github.com/repos/jupyter/oauthenticator","forks_url":"https://api.github.com/repos/jupyter/oauthenticator/forks","keys_url":"https://api.github.com/repos/jupyter/oauthenticator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/oauthenticator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/oauthenticator/teams","hooks_url":"https://api.github.com/repos/jupyter/oauthenticator/hooks","issue_events_url":"https://api.github.com/repos/jupyter/oauthenticator/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/oauthenticator/events","assignees_url":"https://api.github.com/repos/jupyter/oauthenticator/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/oauthenticator/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/oauthenticator/tags","blobs_url":"https://api.github.com/repos/jupyter/oauthenticator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/oauthenticator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/oauthenticator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/oauthenticator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/oauthenticator/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/oauthenticator/languages","stargazers_url":"https://api.github.com/repos/jupyter/oauthenticator/stargazers","contributors_url":"https://api.github.com/repos/jupyter/oauthenticator/contributors","subscribers_url":"https://api.github.com/repos/jupyter/oauthenticator/subscribers","subscription_url":"https://api.github.com/repos/jupyter/oauthenticator/subscription","commits_url":"https://api.github.com/repos/jupyter/oauthenticator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/oauthenticator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/oauthenticator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/oauthenticator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/oauthenticator/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/oauthenticator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/oauthenticator/merges","archive_url":"https://api.github.com/repos/jupyter/oauthenticator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/oauthenticator/downloads","issues_url":"https://api.github.com/repos/jupyter/oauthenticator/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/oauthenticator/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/oauthenticator/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/oauthenticator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/oauthenticator/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/oauthenticator/releases{/id}","created_at":"2014-09-23T21:37:06Z","updated_at":"2015-06-26T19:49:03Z","pushed_at":"2015-08-04T19:27:49Z","git_url":"git://github.com/jupyter/oauthenticator.git","ssh_url":"git@github.com:jupyter/oauthenticator.git","clone_url":"https://github.com/jupyter/oauthenticator.git","svn_url":"https://github.com/jupyter/oauthenticator","homepage":"","size":247,"stargazers_count":19,"watchers_count":19,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16,"mirror_url":null,"open_issues_count":3,"forks":16,"open_issues":3,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10"},"html":{"href":"https://github.com/jupyter/oauthenticator/pull/10"},"issue":{"href":"https://api.github.com/repos/jupyter/oauthenticator/issues/10"},"comments":{"href":"https://api.github.com/repos/jupyter/oauthenticator/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/oauthenticator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/oauthenticator/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/oauthenticator/statuses/8e5d74ea3e288ee8f60e09f392ac63eadef29a51"}}}}