{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/16430","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/16430/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/16430/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/16430/events","html_url":"https://github.com/rust-lang/rust/issues/16430","id":40001993,"number":16430,"title":"Test harness should not fail!() when some tests fail","user":{"login":"SimonSapin","id":291359,"avatar_url":"https://avatars.githubusercontent.com/u/291359?v=3","gravatar_id":"","url":"https://api.github.com/users/SimonSapin","html_url":"https://github.com/SimonSapin","followers_url":"https://api.github.com/users/SimonSapin/followers","following_url":"https://api.github.com/users/SimonSapin/following{/other_user}","gists_url":"https://api.github.com/users/SimonSapin/gists{/gist_id}","starred_url":"https://api.github.com/users/SimonSapin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SimonSapin/subscriptions","organizations_url":"https://api.github.com/users/SimonSapin/orgs","repos_url":"https://api.github.com/users/SimonSapin/repos","events_url":"https://api.github.com/users/SimonSapin/events{/privacy}","received_events_url":"https://api.github.com/users/SimonSapin/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/rust-lang/rust/labels/A-libs","name":"A-libs","color":"d7e102"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2014-08-11T21:21:29Z","updated_at":"2015-01-27T16:44:12Z","closed_at":null,"body":"`src/libtest/lib.rs` currently contains [`fail!(\"Some tests failed\")`](https://github.com/rust-lang/rust/blob/6faad3ec3aba8e9ea7c68331b7c6561890929658/src/libtest/lib.rs#L242)\r\n\r\nThis causes the output to have an extraneous line when some tests fail:\r\n```\r\ntask '<main>' failed at 'Some tests failed', rust/src/libtest/lib.rs:242\r\n```\r\n\r\nThis is only mildly annoying, but it gets especially noisy when the `RUST_BACKTRACE` environment variable is used since it prints an additional (and uninteresting) stack trace.\r\n\r\nThe test harness should not use `fail!()` in this case, and find some other way to make the program’s exit code be non-zero."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/71680932","html_url":"https://github.com/rust-lang/rust/issues/16430#issuecomment-71680932","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/16430","id":71680932,"user":{"login":"steveklabnik","id":27786,"avatar_url":"https://avatars.githubusercontent.com/u/27786?v=3","gravatar_id":"","url":"https://api.github.com/users/steveklabnik","html_url":"https://github.com/steveklabnik","followers_url":"https://api.github.com/users/steveklabnik/followers","following_url":"https://api.github.com/users/steveklabnik/following{/other_user}","gists_url":"https://api.github.com/users/steveklabnik/gists{/gist_id}","starred_url":"https://api.github.com/users/steveklabnik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveklabnik/subscriptions","organizations_url":"https://api.github.com/users/steveklabnik/orgs","repos_url":"https://api.github.com/users/steveklabnik/repos","events_url":"https://api.github.com/users/steveklabnik/events{/privacy}","received_events_url":"https://api.github.com/users/steveklabnik/received_events","type":"User","site_admin":false},"created_at":"2015-01-27T16:44:12Z","updated_at":"2015-01-27T16:44:12Z","body":"Is this a backcompat issue? I'm not sure. I don't think we're making any guarantees about test being stable, are we?"}}