{"action":"created","comment":{"url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/comments/29046514","id":29046514,"diff_hunk":"@@ -103,25 +105,27 @@ def test_verify_request_common_via_proxy(self):\n         headers = dict()\n         headers['X-Forwarded-Proto'] = 'https'\n         orig_url = 'https://localhost:5000/?'\n-        consumers, method, url, verify_params, params = \\\n+        consumers, method, url, verify_params, _ = (\n             self.generate_oauth_request(url_to_sign=orig_url)\n+        )\n         ret = verify_request_common(consumers, url, method,\n                                     headers, verify_params)\n         self.assertTrue(ret)\n \n-    def test_verify_request_common_no_auth_fields(self):\n+    def test_verify_request_common_no_oauth_fields(self):\n         \"\"\"\n         verify_request_common fails on missing authentication\n         \"\"\"\n         headers = dict()\n-        consumers, method, url, verify_params, params = \\\n+        consumers, method, url, _, params = (\n             self.generate_oauth_request()\n+        )\n         ret = False\n         try:\n             ret = verify_request_common(consumers, url, method,\n                                         headers, params)\n         except LTIException:\n-            self.assertTrue(True)\n+            self.assertTrue(True)  # pylint: disable=redundant-unittest-assert","path":"pylti/tests/test_common.py","position":91,"original_position":91,"commit_id":"181a9fc9fa5e80c8f49ff9b22c929901daa7699b","original_commit_id":"181a9fc9fa5e80c8f49ff9b22c929901daa7699b","user":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"body":"@symbolist sure","created_at":"2015-04-24T13:09:53Z","updated_at":"2015-04-24T13:09:53Z","html_url":"https://github.com/amir-qayyum-arbisoft/pylti/pull/1#discussion_r29046514","pull_request_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/comments/29046514"},"html":{"href":"https://github.com/amir-qayyum-arbisoft/pylti/pull/1#discussion_r29046514"},"pull_request":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1","id":33257195,"html_url":"https://github.com/amir-qayyum-arbisoft/pylti/pull/1","diff_url":"https://github.com/amir-qayyum-arbisoft/pylti/pull/1.diff","patch_url":"https://github.com/amir-qayyum-arbisoft/pylti/pull/1.patch","issue_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/1","number":1,"state":"open","locked":false,"title":"Fix pylint issues","user":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"body":"In this PR i fixed pylint related issues in pylti","created_at":"2015-04-14T13:31:59Z","updated_at":"2015-04-24T13:09:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a74781e511a16310cfbda8271628c36463899dd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1/commits","review_comments_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1/comments","review_comment_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/1/comments","statuses_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/statuses/181a9fc9fa5e80c8f49ff9b22c929901daa7699b","head":{"label":"amir-qayyum-arbisoft:fix_pylint_issues","ref":"fix_pylint_issues","sha":"181a9fc9fa5e80c8f49ff9b22c929901daa7699b","user":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"repo":{"id":33927081,"name":"pylti","full_name":"amir-qayyum-arbisoft/pylti","owner":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amir-qayyum-arbisoft/pylti","description":"PyLTI implementation","fork":true,"url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti","forks_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/forks","keys_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/teams","hooks_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/hooks","issue_events_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/events{/number}","events_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/events","assignees_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/assignees{/user}","branches_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/branches{/branch}","tags_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/tags","blobs_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/refs{/sha}","trees_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/statuses/{sha}","languages_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/languages","stargazers_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/stargazers","contributors_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/contributors","subscribers_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/subscribers","subscription_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/subscription","commits_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/commits{/sha}","git_commits_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/commits{/sha}","comments_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/comments{/number}","issue_comment_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/comments{/number}","contents_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/contents/{+path}","compare_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/merges","archive_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/downloads","issues_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues{/number}","pulls_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls{/number}","milestones_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/milestones{/number}","notifications_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/labels{/name}","releases_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/releases{/id}","created_at":"2015-04-14T11:08:11Z","updated_at":"2015-04-16T09:56:33Z","pushed_at":"2015-04-24T11:35:31Z","git_url":"git://github.com/amir-qayyum-arbisoft/pylti.git","ssh_url":"git@github.com:amir-qayyum-arbisoft/pylti.git","clone_url":"https://github.com/amir-qayyum-arbisoft/pylti.git","svn_url":"https://github.com/amir-qayyum-arbisoft/pylti","homepage":null,"size":1949,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"amir-qayyum-arbisoft:master","ref":"master","sha":"a8af2c877484b4ea30a288b07290344f71a0431a","user":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"repo":{"id":33927081,"name":"pylti","full_name":"amir-qayyum-arbisoft/pylti","owner":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/amir-qayyum-arbisoft/pylti","description":"PyLTI implementation","fork":true,"url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti","forks_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/forks","keys_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/teams","hooks_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/hooks","issue_events_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/events{/number}","events_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/events","assignees_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/assignees{/user}","branches_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/branches{/branch}","tags_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/tags","blobs_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/refs{/sha}","trees_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/statuses/{sha}","languages_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/languages","stargazers_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/stargazers","contributors_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/contributors","subscribers_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/subscribers","subscription_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/subscription","commits_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/commits{/sha}","git_commits_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/git/commits{/sha}","comments_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/comments{/number}","issue_comment_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/comments{/number}","contents_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/contents/{+path}","compare_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/merges","archive_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/downloads","issues_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues{/number}","pulls_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls{/number}","milestones_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/milestones{/number}","notifications_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/labels{/name}","releases_url":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/releases{/id}","created_at":"2015-04-14T11:08:11Z","updated_at":"2015-04-16T09:56:33Z","pushed_at":"2015-04-24T11:35:31Z","git_url":"git://github.com/amir-qayyum-arbisoft/pylti.git","ssh_url":"git@github.com:amir-qayyum-arbisoft/pylti.git","clone_url":"https://github.com/amir-qayyum-arbisoft/pylti.git","svn_url":"https://github.com/amir-qayyum-arbisoft/pylti","homepage":null,"size":1949,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1"},"html":{"href":"https://github.com/amir-qayyum-arbisoft/pylti/pull/1"},"issue":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/1"},"comments":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/amir-qayyum-arbisoft/pylti/statuses/181a9fc9fa5e80c8f49ff9b22c929901daa7699b"}}}}