{"action":"closed","number":190,"pull_request":{"url":"https://api.github.com/repos/pbhogan/InControl/pulls/190","id":29347393,"html_url":"https://github.com/pbhogan/InControl/pull/190","diff_url":"https://github.com/pbhogan/InControl/pull/190.diff","patch_url":"https://github.com/pbhogan/InControl/pull/190.patch","issue_url":"https://api.github.com/repos/pbhogan/InControl/issues/190","number":190,"state":"closed","locked":false,"title":"Allows use of two controllers with the same name by exposing the joystic...","user":{"login":"mrkake","id":438139,"avatar_url":"https://avatars.githubusercontent.com/u/438139?v=3","gravatar_id":"","url":"https://api.github.com/users/mrkake","html_url":"https://github.com/mrkake","followers_url":"https://api.github.com/users/mrkake/followers","following_url":"https://api.github.com/users/mrkake/following{/other_user}","gists_url":"https://api.github.com/users/mrkake/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkake/subscriptions","organizations_url":"https://api.github.com/users/mrkake/orgs","repos_url":"https://api.github.com/users/mrkake/repos","events_url":"https://api.github.com/users/mrkake/events{/privacy}","received_events_url":"https://api.github.com/users/mrkake/received_events","type":"User","site_admin":false},"body":"I'm not sure if there is a reason this was not done. I made this change in the source for the game I am working on and everything works fine. Basically, this exposes the JoystickId from UnityInputDevice.cs inside InputDevice.cs so that it can be seen from inside your game, and you can use it to identify the controller instead of (or in addition to) the usual Name field. It also requires adding the field to XInputDevice, so I passed the field through to the DeviceIndex which seems to represent basically the same thing, therefore it would give a reasonable value for this as well.\r\n\r\nI think this change is safe but it would be great if it could be reviewed. It will solve a whole lot of problems with having multiples of the same type of controller connected at the same time.","created_at":"2015-02-16T03:00:30Z","updated_at":"2015-02-16T03:08:37Z","closed_at":"2015-02-16T03:08:37Z","merged_at":null,"merge_commit_sha":"041598b9082018be707a43c109cfef08d01fc0cc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pbhogan/InControl/pulls/190/commits","review_comments_url":"https://api.github.com/repos/pbhogan/InControl/pulls/190/comments","review_comment_url":"https://api.github.com/repos/pbhogan/InControl/pulls/comments/{number}","comments_url":"https://api.github.com/repos/pbhogan/InControl/issues/190/comments","statuses_url":"https://api.github.com/repos/pbhogan/InControl/statuses/eebd36938a672084a4271bbff289dbc6b403bec1","head":{"label":"mrkake:bugfix/multiple_same_controllers","ref":"bugfix/multiple_same_controllers","sha":"eebd36938a672084a4271bbff289dbc6b403bec1","user":{"login":"mrkake","id":438139,"avatar_url":"https://avatars.githubusercontent.com/u/438139?v=3","gravatar_id":"","url":"https://api.github.com/users/mrkake","html_url":"https://github.com/mrkake","followers_url":"https://api.github.com/users/mrkake/followers","following_url":"https://api.github.com/users/mrkake/following{/other_user}","gists_url":"https://api.github.com/users/mrkake/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkake/subscriptions","organizations_url":"https://api.github.com/users/mrkake/orgs","repos_url":"https://api.github.com/users/mrkake/repos","events_url":"https://api.github.com/users/mrkake/events{/privacy}","received_events_url":"https://api.github.com/users/mrkake/received_events","type":"User","site_admin":false},"repo":{"id":30851122,"name":"InControl","full_name":"mrkake/InControl","owner":{"login":"mrkake","id":438139,"avatar_url":"https://avatars.githubusercontent.com/u/438139?v=3","gravatar_id":"","url":"https://api.github.com/users/mrkake","html_url":"https://github.com/mrkake","followers_url":"https://api.github.com/users/mrkake/followers","following_url":"https://api.github.com/users/mrkake/following{/other_user}","gists_url":"https://api.github.com/users/mrkake/gists{/gist_id}","starred_url":"https://api.github.com/users/mrkake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrkake/subscriptions","organizations_url":"https://api.github.com/users/mrkake/orgs","repos_url":"https://api.github.com/users/mrkake/repos","events_url":"https://api.github.com/users/mrkake/events{/privacy}","received_events_url":"https://api.github.com/users/mrkake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrkake/InControl","description":"An input manager for Unity that tames the cross-platform controller beast.","fork":true,"url":"https://api.github.com/repos/mrkake/InControl","forks_url":"https://api.github.com/repos/mrkake/InControl/forks","keys_url":"https://api.github.com/repos/mrkake/InControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrkake/InControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrkake/InControl/teams","hooks_url":"https://api.github.com/repos/mrkake/InControl/hooks","issue_events_url":"https://api.github.com/repos/mrkake/InControl/issues/events{/number}","events_url":"https://api.github.com/repos/mrkake/InControl/events","assignees_url":"https://api.github.com/repos/mrkake/InControl/assignees{/user}","branches_url":"https://api.github.com/repos/mrkake/InControl/branches{/branch}","tags_url":"https://api.github.com/repos/mrkake/InControl/tags","blobs_url":"https://api.github.com/repos/mrkake/InControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrkake/InControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrkake/InControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrkake/InControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrkake/InControl/statuses/{sha}","languages_url":"https://api.github.com/repos/mrkake/InControl/languages","stargazers_url":"https://api.github.com/repos/mrkake/InControl/stargazers","contributors_url":"https://api.github.com/repos/mrkake/InControl/contributors","subscribers_url":"https://api.github.com/repos/mrkake/InControl/subscribers","subscription_url":"https://api.github.com/repos/mrkake/InControl/subscription","commits_url":"https://api.github.com/repos/mrkake/InControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrkake/InControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrkake/InControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrkake/InControl/issues/comments/{number}","contents_url":"https://api.github.com/repos/mrkake/InControl/contents/{+path}","compare_url":"https://api.github.com/repos/mrkake/InControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrkake/InControl/merges","archive_url":"https://api.github.com/repos/mrkake/InControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrkake/InControl/downloads","issues_url":"https://api.github.com/repos/mrkake/InControl/issues{/number}","pulls_url":"https://api.github.com/repos/mrkake/InControl/pulls{/number}","milestones_url":"https://api.github.com/repos/mrkake/InControl/milestones{/number}","notifications_url":"https://api.github.com/repos/mrkake/InControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrkake/InControl/labels{/name}","releases_url":"https://api.github.com/repos/mrkake/InControl/releases{/id}","created_at":"2015-02-16T02:40:40Z","updated_at":"2015-02-16T02:40:41Z","pushed_at":"2015-02-16T02:41:26Z","git_url":"git://github.com/mrkake/InControl.git","ssh_url":"git@github.com:mrkake/InControl.git","clone_url":"https://github.com/mrkake/InControl.git","svn_url":"https://github.com/mrkake/InControl","homepage":"http://u3d.as/6mr","size":10579,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pbhogan:develop","ref":"develop","sha":"17aad0c895e7d0414d89e27b4d365dd42945fce2","user":{"login":"pbhogan","id":3558,"avatar_url":"https://avatars.githubusercontent.com/u/3558?v=3","gravatar_id":"","url":"https://api.github.com/users/pbhogan","html_url":"https://github.com/pbhogan","followers_url":"https://api.github.com/users/pbhogan/followers","following_url":"https://api.github.com/users/pbhogan/following{/other_user}","gists_url":"https://api.github.com/users/pbhogan/gists{/gist_id}","starred_url":"https://api.github.com/users/pbhogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbhogan/subscriptions","organizations_url":"https://api.github.com/users/pbhogan/orgs","repos_url":"https://api.github.com/users/pbhogan/repos","events_url":"https://api.github.com/users/pbhogan/events{/privacy}","received_events_url":"https://api.github.com/users/pbhogan/received_events","type":"User","site_admin":false},"repo":{"id":11491130,"name":"InControl","full_name":"pbhogan/InControl","owner":{"login":"pbhogan","id":3558,"avatar_url":"https://avatars.githubusercontent.com/u/3558?v=3","gravatar_id":"","url":"https://api.github.com/users/pbhogan","html_url":"https://github.com/pbhogan","followers_url":"https://api.github.com/users/pbhogan/followers","following_url":"https://api.github.com/users/pbhogan/following{/other_user}","gists_url":"https://api.github.com/users/pbhogan/gists{/gist_id}","starred_url":"https://api.github.com/users/pbhogan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbhogan/subscriptions","organizations_url":"https://api.github.com/users/pbhogan/orgs","repos_url":"https://api.github.com/users/pbhogan/repos","events_url":"https://api.github.com/users/pbhogan/events{/privacy}","received_events_url":"https://api.github.com/users/pbhogan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbhogan/InControl","description":"An input manager for Unity that tames the cross-platform controller beast.","fork":false,"url":"https://api.github.com/repos/pbhogan/InControl","forks_url":"https://api.github.com/repos/pbhogan/InControl/forks","keys_url":"https://api.github.com/repos/pbhogan/InControl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbhogan/InControl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbhogan/InControl/teams","hooks_url":"https://api.github.com/repos/pbhogan/InControl/hooks","issue_events_url":"https://api.github.com/repos/pbhogan/InControl/issues/events{/number}","events_url":"https://api.github.com/repos/pbhogan/InControl/events","assignees_url":"https://api.github.com/repos/pbhogan/InControl/assignees{/user}","branches_url":"https://api.github.com/repos/pbhogan/InControl/branches{/branch}","tags_url":"https://api.github.com/repos/pbhogan/InControl/tags","blobs_url":"https://api.github.com/repos/pbhogan/InControl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbhogan/InControl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbhogan/InControl/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbhogan/InControl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbhogan/InControl/statuses/{sha}","languages_url":"https://api.github.com/repos/pbhogan/InControl/languages","stargazers_url":"https://api.github.com/repos/pbhogan/InControl/stargazers","contributors_url":"https://api.github.com/repos/pbhogan/InControl/contributors","subscribers_url":"https://api.github.com/repos/pbhogan/InControl/subscribers","subscription_url":"https://api.github.com/repos/pbhogan/InControl/subscription","commits_url":"https://api.github.com/repos/pbhogan/InControl/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbhogan/InControl/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbhogan/InControl/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbhogan/InControl/issues/comments/{number}","contents_url":"https://api.github.com/repos/pbhogan/InControl/contents/{+path}","compare_url":"https://api.github.com/repos/pbhogan/InControl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbhogan/InControl/merges","archive_url":"https://api.github.com/repos/pbhogan/InControl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbhogan/InControl/downloads","issues_url":"https://api.github.com/repos/pbhogan/InControl/issues{/number}","pulls_url":"https://api.github.com/repos/pbhogan/InControl/pulls{/number}","milestones_url":"https://api.github.com/repos/pbhogan/InControl/milestones{/number}","notifications_url":"https://api.github.com/repos/pbhogan/InControl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbhogan/InControl/labels{/name}","releases_url":"https://api.github.com/repos/pbhogan/InControl/releases{/id}","created_at":"2013-07-18T00:56:48Z","updated_at":"2015-02-15T05:50:07Z","pushed_at":"2015-02-15T02:24:00Z","git_url":"git://github.com/pbhogan/InControl.git","ssh_url":"git@github.com:pbhogan/InControl.git","clone_url":"https://github.com/pbhogan/InControl.git","svn_url":"https://github.com/pbhogan/InControl","homepage":"http://u3d.as/6mr","size":10579,"stargazers_count":373,"watchers_count":373,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"open_issues_count":13,"forks":80,"open_issues":13,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pbhogan/InControl/pulls/190"},"html":{"href":"https://github.com/pbhogan/InControl/pull/190"},"issue":{"href":"https://api.github.com/repos/pbhogan/InControl/issues/190"},"comments":{"href":"https://api.github.com/repos/pbhogan/InControl/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/pbhogan/InControl/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/pbhogan/InControl/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/pbhogan/InControl/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/pbhogan/InControl/statuses/eebd36938a672084a4271bbff289dbc6b403bec1"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":8,"deletions":1,"changed_files":3}}