{"action":"created","comment":{"url":"https://api.github.com/repos/joblib/joblib/pulls/comments/47257474","id":47257474,"diff_hunk":"@@ -10,6 +10,10 @@\n import sys\n import io\n import os\n+import subprocess\n+from threading import Timer\n+import re","path":"joblib/test/test_parallel.py","position":6,"original_position":6,"commit_id":"16d5857fa88b5234128112d6a7c4691ceb9048ab","original_commit_id":"16d5857fa88b5234128112d6a7c4691ceb9048ab","user":{"login":"aabadie","id":1375137,"avatar_url":"https://avatars.githubusercontent.com/u/1375137?v=3","gravatar_id":"","url":"https://api.github.com/users/aabadie","html_url":"https://github.com/aabadie","followers_url":"https://api.github.com/users/aabadie/followers","following_url":"https://api.github.com/users/aabadie/following{/other_user}","gists_url":"https://api.github.com/users/aabadie/gists{/gist_id}","starred_url":"https://api.github.com/users/aabadie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aabadie/subscriptions","organizations_url":"https://api.github.com/users/aabadie/orgs","repos_url":"https://api.github.com/users/aabadie/repos","events_url":"https://api.github.com/users/aabadie/events{/privacy}","received_events_url":"https://api.github.com/users/aabadie/received_events","type":"User","site_admin":false},"body":"I would switch the 2 lines above. `import re` first then `from threading import Timer`","created_at":"2015-12-10T17:37:05Z","updated_at":"2015-12-10T17:37:05Z","html_url":"https://github.com/joblib/joblib/pull/282#discussion_r47257474","pull_request_url":"https://api.github.com/repos/joblib/joblib/pulls/282","_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments/47257474"},"html":{"href":"https://github.com/joblib/joblib/pull/282#discussion_r47257474"},"pull_request":{"href":"https://api.github.com/repos/joblib/joblib/pulls/282"}}},"pull_request":{"url":"https://api.github.com/repos/joblib/joblib/pulls/282","id":53263540,"html_url":"https://github.com/joblib/joblib/pull/282","diff_url":"https://github.com/joblib/joblib/pull/282.diff","patch_url":"https://github.com/joblib/joblib/pull/282.patch","issue_url":"https://api.github.com/repos/joblib/joblib/issues/282","number":282,"state":"open","locked":false,"title":"[MRG] Add test for Parallel with interactively defined function","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"body":"This functionality was broken when we changed the default process start method for 3.4+ to be forksever as mentioned in https://github.com/joblib/joblib/issues/263.\r\n\r\nNow at least there is a test for it.","created_at":"2015-12-10T14:17:34Z","updated_at":"2015-12-10T17:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55fe847b03c70b38d13fff63dd887cd33c57819c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/joblib/joblib/pulls/282/commits","review_comments_url":"https://api.github.com/repos/joblib/joblib/pulls/282/comments","review_comment_url":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joblib/joblib/issues/282/comments","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/16d5857fa88b5234128112d6a7c4691ceb9048ab","head":{"label":"lesteve:parallel-test-with-interactively-defined-functions","ref":"parallel-test-with-interactively-defined-functions","sha":"16d5857fa88b5234128112d6a7c4691ceb9048ab","user":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"repo":{"id":31776372,"name":"joblib","full_name":"lesteve/joblib","owner":{"login":"lesteve","id":1680079,"avatar_url":"https://avatars.githubusercontent.com/u/1680079?v=3","gravatar_id":"","url":"https://api.github.com/users/lesteve","html_url":"https://github.com/lesteve","followers_url":"https://api.github.com/users/lesteve/followers","following_url":"https://api.github.com/users/lesteve/following{/other_user}","gists_url":"https://api.github.com/users/lesteve/gists{/gist_id}","starred_url":"https://api.github.com/users/lesteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesteve/subscriptions","organizations_url":"https://api.github.com/users/lesteve/orgs","repos_url":"https://api.github.com/users/lesteve/repos","events_url":"https://api.github.com/users/lesteve/events{/privacy}","received_events_url":"https://api.github.com/users/lesteve/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lesteve/joblib","description":"Python function as pipeline jobs.","fork":true,"url":"https://api.github.com/repos/lesteve/joblib","forks_url":"https://api.github.com/repos/lesteve/joblib/forks","keys_url":"https://api.github.com/repos/lesteve/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lesteve/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lesteve/joblib/teams","hooks_url":"https://api.github.com/repos/lesteve/joblib/hooks","issue_events_url":"https://api.github.com/repos/lesteve/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/lesteve/joblib/events","assignees_url":"https://api.github.com/repos/lesteve/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/lesteve/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/lesteve/joblib/tags","blobs_url":"https://api.github.com/repos/lesteve/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lesteve/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lesteve/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/lesteve/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lesteve/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/lesteve/joblib/languages","stargazers_url":"https://api.github.com/repos/lesteve/joblib/stargazers","contributors_url":"https://api.github.com/repos/lesteve/joblib/contributors","subscribers_url":"https://api.github.com/repos/lesteve/joblib/subscribers","subscription_url":"https://api.github.com/repos/lesteve/joblib/subscription","commits_url":"https://api.github.com/repos/lesteve/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/lesteve/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/lesteve/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/lesteve/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/lesteve/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/lesteve/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lesteve/joblib/merges","archive_url":"https://api.github.com/repos/lesteve/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lesteve/joblib/downloads","issues_url":"https://api.github.com/repos/lesteve/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/lesteve/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/lesteve/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/lesteve/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lesteve/joblib/labels{/name}","releases_url":"https://api.github.com/repos/lesteve/joblib/releases{/id}","created_at":"2015-03-06T15:49:01Z","updated_at":"2015-04-30T13:42:37Z","pushed_at":"2015-12-10T15:13:02Z","git_url":"git://github.com/lesteve/joblib.git","ssh_url":"git@github.com:lesteve/joblib.git","clone_url":"https://github.com/lesteve/joblib.git","svn_url":"https://github.com/lesteve/joblib","homepage":"http://packages.python.org/joblib/","size":2374,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joblib:master","ref":"master","sha":"5b7741b3946140c1d98a945aa8c2b7577b1c536d","user":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"repo":{"id":654608,"name":"joblib","full_name":"joblib/joblib","owner":{"login":"joblib","id":332661,"avatar_url":"https://avatars.githubusercontent.com/u/332661?v=3","gravatar_id":"","url":"https://api.github.com/users/joblib","html_url":"https://github.com/joblib","followers_url":"https://api.github.com/users/joblib/followers","following_url":"https://api.github.com/users/joblib/following{/other_user}","gists_url":"https://api.github.com/users/joblib/gists{/gist_id}","starred_url":"https://api.github.com/users/joblib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joblib/subscriptions","organizations_url":"https://api.github.com/users/joblib/orgs","repos_url":"https://api.github.com/users/joblib/repos","events_url":"https://api.github.com/users/joblib/events{/privacy}","received_events_url":"https://api.github.com/users/joblib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joblib/joblib","description":"Python function as pipeline jobs.","fork":false,"url":"https://api.github.com/repos/joblib/joblib","forks_url":"https://api.github.com/repos/joblib/joblib/forks","keys_url":"https://api.github.com/repos/joblib/joblib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joblib/joblib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joblib/joblib/teams","hooks_url":"https://api.github.com/repos/joblib/joblib/hooks","issue_events_url":"https://api.github.com/repos/joblib/joblib/issues/events{/number}","events_url":"https://api.github.com/repos/joblib/joblib/events","assignees_url":"https://api.github.com/repos/joblib/joblib/assignees{/user}","branches_url":"https://api.github.com/repos/joblib/joblib/branches{/branch}","tags_url":"https://api.github.com/repos/joblib/joblib/tags","blobs_url":"https://api.github.com/repos/joblib/joblib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joblib/joblib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joblib/joblib/git/refs{/sha}","trees_url":"https://api.github.com/repos/joblib/joblib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joblib/joblib/statuses/{sha}","languages_url":"https://api.github.com/repos/joblib/joblib/languages","stargazers_url":"https://api.github.com/repos/joblib/joblib/stargazers","contributors_url":"https://api.github.com/repos/joblib/joblib/contributors","subscribers_url":"https://api.github.com/repos/joblib/joblib/subscribers","subscription_url":"https://api.github.com/repos/joblib/joblib/subscription","commits_url":"https://api.github.com/repos/joblib/joblib/commits{/sha}","git_commits_url":"https://api.github.com/repos/joblib/joblib/git/commits{/sha}","comments_url":"https://api.github.com/repos/joblib/joblib/comments{/number}","issue_comment_url":"https://api.github.com/repos/joblib/joblib/issues/comments{/number}","contents_url":"https://api.github.com/repos/joblib/joblib/contents/{+path}","compare_url":"https://api.github.com/repos/joblib/joblib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joblib/joblib/merges","archive_url":"https://api.github.com/repos/joblib/joblib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joblib/joblib/downloads","issues_url":"https://api.github.com/repos/joblib/joblib/issues{/number}","pulls_url":"https://api.github.com/repos/joblib/joblib/pulls{/number}","milestones_url":"https://api.github.com/repos/joblib/joblib/milestones{/number}","notifications_url":"https://api.github.com/repos/joblib/joblib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joblib/joblib/labels{/name}","releases_url":"https://api.github.com/repos/joblib/joblib/releases{/id}","created_at":"2010-05-07T06:48:26Z","updated_at":"2015-12-08T11:46:45Z","pushed_at":"2015-12-10T17:31:06Z","git_url":"git://github.com/joblib/joblib.git","ssh_url":"git@github.com:joblib/joblib.git","clone_url":"https://github.com/joblib/joblib.git","svn_url":"https://github.com/joblib/joblib","homepage":"http://packages.python.org/joblib/","size":2862,"stargazers_count":446,"watchers_count":446,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"open_issues_count":88,"forks":94,"open_issues":88,"watchers":446,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joblib/joblib/pulls/282"},"html":{"href":"https://github.com/joblib/joblib/pull/282"},"issue":{"href":"https://api.github.com/repos/joblib/joblib/issues/282"},"comments":{"href":"https://api.github.com/repos/joblib/joblib/issues/282/comments"},"review_comments":{"href":"https://api.github.com/repos/joblib/joblib/pulls/282/comments"},"review_comment":{"href":"https://api.github.com/repos/joblib/joblib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joblib/joblib/pulls/282/commits"},"statuses":{"href":"https://api.github.com/repos/joblib/joblib/statuses/16d5857fa88b5234128112d6a7c4691ceb9048ab"}}}}