{"action":"created","comment":{"url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/comments/29821665","id":29821665,"diff_hunk":"@@ -102,6 +103,27 @@ class XmppEngineImpl : public XmppEngine {\n     lang_ = lang;\n   }\n \n+  //! Sets connection port\n+  virtual void SetSocketServer(const std::string& server, int port) {\n+    connection_server_ = server;\n+    connection_port_ = port;\n+\n+    std::string hostname = tls_server_hostname_;\n+    if (hostname.empty())\n+      hostname = this->user_jid_.domain();\n+\n+    // If not language is specified, the spec says use *\n+    std::string lang = lang_;\n+    if (lang.length() == 0)\n+      lang = \"*\";","path":"talk/xmpp/xmppengineimpl.h","position":24,"original_position":24,"commit_id":"cdb34dd38f0763aca77c1ebfe515f0ab35607e36","original_commit_id":"cdb34dd38f0763aca77c1ebfe515f0ab35607e36","user":{"login":"DinhNguyenCat","id":11747333,"avatar_url":"https://avatars.githubusercontent.com/u/11747333?v=3","gravatar_id":"","url":"https://api.github.com/users/DinhNguyenCat","html_url":"https://github.com/DinhNguyenCat","followers_url":"https://api.github.com/users/DinhNguyenCat/followers","following_url":"https://api.github.com/users/DinhNguyenCat/following{/other_user}","gists_url":"https://api.github.com/users/DinhNguyenCat/gists{/gist_id}","starred_url":"https://api.github.com/users/DinhNguyenCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DinhNguyenCat/subscriptions","organizations_url":"https://api.github.com/users/DinhNguyenCat/orgs","repos_url":"https://api.github.com/users/DinhNguyenCat/repos","events_url":"https://api.github.com/users/DinhNguyenCat/events{/privacy}","received_events_url":"https://api.github.com/users/DinhNguyenCat/received_events","type":"User","site_admin":false},"body":"Hi @dscherba,\r\n\r\nIn the original code of WebRTC, I saw that they usually didn't use braces in one line if command. You can easily see it in the code.","created_at":"2015-05-07T03:10:26Z","updated_at":"2015-05-07T03:10:26Z","html_url":"https://github.com/PersonifyInc/webrtc/pull/3#discussion_r29821665","pull_request_url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/comments/29821665"},"html":{"href":"https://github.com/PersonifyInc/webrtc/pull/3#discussion_r29821665"},"pull_request":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3","id":33945983,"html_url":"https://github.com/PersonifyInc/webrtc/pull/3","diff_url":"https://github.com/PersonifyInc/webrtc/pull/3.diff","patch_url":"https://github.com/PersonifyInc/webrtc/pull/3.patch","issue_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues/3","number":3,"state":"open","locked":false,"title":"[DO NOT MERGE]CHAT-2219: Modify libjingle to support BOSH in Webrtc XMPP stack","user":{"login":"DinhNguyenCat","id":11747333,"avatar_url":"https://avatars.githubusercontent.com/u/11747333?v=3","gravatar_id":"","url":"https://api.github.com/users/DinhNguyenCat","html_url":"https://github.com/DinhNguyenCat","followers_url":"https://api.github.com/users/DinhNguyenCat/followers","following_url":"https://api.github.com/users/DinhNguyenCat/following{/other_user}","gists_url":"https://api.github.com/users/DinhNguyenCat/gists{/gist_id}","starred_url":"https://api.github.com/users/DinhNguyenCat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DinhNguyenCat/subscriptions","organizations_url":"https://api.github.com/users/DinhNguyenCat/orgs","repos_url":"https://api.github.com/users/DinhNguyenCat/repos","events_url":"https://api.github.com/users/DinhNguyenCat/events{/privacy}","received_events_url":"https://api.github.com/users/DinhNguyenCat/received_events","type":"User","site_admin":false},"body":"//cc: @dscherba @digitalmouse12 @willkelleher \r\n\r\nintroduce a singleton object simplebosh to wrap all outgoing xmpp xml message into a suitable http request.\r\nThis object also parse the incoming http message to get the xml content to process.\r\nTwo class util and tag is used to support simplebosh object to do its functionality.","created_at":"2015-04-23T11:22:47Z","updated_at":"2015-05-07T03:10:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d491d5ac25e36135194d40b91383e338a186b0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3/commits","review_comments_url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3/comments","review_comment_url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues/3/comments","statuses_url":"https://api.github.com/repos/PersonifyInc/webrtc/statuses/cdb34dd38f0763aca77c1ebfe515f0ab35607e36","head":{"label":"PersonifyInc:CHAT-2219-add-bosh-to-webrtc","ref":"CHAT-2219-add-bosh-to-webrtc","sha":"cdb34dd38f0763aca77c1ebfe515f0ab35607e36","user":{"login":"PersonifyInc","id":784032,"avatar_url":"https://avatars.githubusercontent.com/u/784032?v=3","gravatar_id":"","url":"https://api.github.com/users/PersonifyInc","html_url":"https://github.com/PersonifyInc","followers_url":"https://api.github.com/users/PersonifyInc/followers","following_url":"https://api.github.com/users/PersonifyInc/following{/other_user}","gists_url":"https://api.github.com/users/PersonifyInc/gists{/gist_id}","starred_url":"https://api.github.com/users/PersonifyInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PersonifyInc/subscriptions","organizations_url":"https://api.github.com/users/PersonifyInc/orgs","repos_url":"https://api.github.com/users/PersonifyInc/repos","events_url":"https://api.github.com/users/PersonifyInc/events{/privacy}","received_events_url":"https://api.github.com/users/PersonifyInc/received_events","type":"Organization","site_admin":false},"repo":{"id":12657120,"name":"webrtc","full_name":"PersonifyInc/webrtc","owner":{"login":"PersonifyInc","id":784032,"avatar_url":"https://avatars.githubusercontent.com/u/784032?v=3","gravatar_id":"","url":"https://api.github.com/users/PersonifyInc","html_url":"https://github.com/PersonifyInc","followers_url":"https://api.github.com/users/PersonifyInc/followers","following_url":"https://api.github.com/users/PersonifyInc/following{/other_user}","gists_url":"https://api.github.com/users/PersonifyInc/gists{/gist_id}","starred_url":"https://api.github.com/users/PersonifyInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PersonifyInc/subscriptions","organizations_url":"https://api.github.com/users/PersonifyInc/orgs","repos_url":"https://api.github.com/users/PersonifyInc/repos","events_url":"https://api.github.com/users/PersonifyInc/events{/privacy}","received_events_url":"https://api.github.com/users/PersonifyInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PersonifyInc/webrtc","description":"Fork webrtc's SVN repo","fork":false,"url":"https://api.github.com/repos/PersonifyInc/webrtc","forks_url":"https://api.github.com/repos/PersonifyInc/webrtc/forks","keys_url":"https://api.github.com/repos/PersonifyInc/webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PersonifyInc/webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PersonifyInc/webrtc/teams","hooks_url":"https://api.github.com/repos/PersonifyInc/webrtc/hooks","issue_events_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/PersonifyInc/webrtc/events","assignees_url":"https://api.github.com/repos/PersonifyInc/webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/PersonifyInc/webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/PersonifyInc/webrtc/tags","blobs_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PersonifyInc/webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/PersonifyInc/webrtc/languages","stargazers_url":"https://api.github.com/repos/PersonifyInc/webrtc/stargazers","contributors_url":"https://api.github.com/repos/PersonifyInc/webrtc/contributors","subscribers_url":"https://api.github.com/repos/PersonifyInc/webrtc/subscribers","subscription_url":"https://api.github.com/repos/PersonifyInc/webrtc/subscription","commits_url":"https://api.github.com/repos/PersonifyInc/webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/PersonifyInc/webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/PersonifyInc/webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/PersonifyInc/webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PersonifyInc/webrtc/merges","archive_url":"https://api.github.com/repos/PersonifyInc/webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PersonifyInc/webrtc/downloads","issues_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/PersonifyInc/webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/PersonifyInc/webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PersonifyInc/webrtc/labels{/name}","releases_url":"https://api.github.com/repos/PersonifyInc/webrtc/releases{/id}","created_at":"2013-09-07T00:03:07Z","updated_at":"2014-12-16T16:47:06Z","pushed_at":"2015-04-28T19:22:07Z","git_url":"git://github.com/PersonifyInc/webrtc.git","ssh_url":"git@github.com:PersonifyInc/webrtc.git","clone_url":"https://github.com/PersonifyInc/webrtc.git","svn_url":"https://github.com/PersonifyInc/webrtc","homepage":null,"size":93805,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"PersonifyInc:master","ref":"master","sha":"a45987cf06e0f42920d5657f4a96bf7fcd48ebdb","user":{"login":"PersonifyInc","id":784032,"avatar_url":"https://avatars.githubusercontent.com/u/784032?v=3","gravatar_id":"","url":"https://api.github.com/users/PersonifyInc","html_url":"https://github.com/PersonifyInc","followers_url":"https://api.github.com/users/PersonifyInc/followers","following_url":"https://api.github.com/users/PersonifyInc/following{/other_user}","gists_url":"https://api.github.com/users/PersonifyInc/gists{/gist_id}","starred_url":"https://api.github.com/users/PersonifyInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PersonifyInc/subscriptions","organizations_url":"https://api.github.com/users/PersonifyInc/orgs","repos_url":"https://api.github.com/users/PersonifyInc/repos","events_url":"https://api.github.com/users/PersonifyInc/events{/privacy}","received_events_url":"https://api.github.com/users/PersonifyInc/received_events","type":"Organization","site_admin":false},"repo":{"id":12657120,"name":"webrtc","full_name":"PersonifyInc/webrtc","owner":{"login":"PersonifyInc","id":784032,"avatar_url":"https://avatars.githubusercontent.com/u/784032?v=3","gravatar_id":"","url":"https://api.github.com/users/PersonifyInc","html_url":"https://github.com/PersonifyInc","followers_url":"https://api.github.com/users/PersonifyInc/followers","following_url":"https://api.github.com/users/PersonifyInc/following{/other_user}","gists_url":"https://api.github.com/users/PersonifyInc/gists{/gist_id}","starred_url":"https://api.github.com/users/PersonifyInc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PersonifyInc/subscriptions","organizations_url":"https://api.github.com/users/PersonifyInc/orgs","repos_url":"https://api.github.com/users/PersonifyInc/repos","events_url":"https://api.github.com/users/PersonifyInc/events{/privacy}","received_events_url":"https://api.github.com/users/PersonifyInc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PersonifyInc/webrtc","description":"Fork webrtc's SVN repo","fork":false,"url":"https://api.github.com/repos/PersonifyInc/webrtc","forks_url":"https://api.github.com/repos/PersonifyInc/webrtc/forks","keys_url":"https://api.github.com/repos/PersonifyInc/webrtc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PersonifyInc/webrtc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PersonifyInc/webrtc/teams","hooks_url":"https://api.github.com/repos/PersonifyInc/webrtc/hooks","issue_events_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues/events{/number}","events_url":"https://api.github.com/repos/PersonifyInc/webrtc/events","assignees_url":"https://api.github.com/repos/PersonifyInc/webrtc/assignees{/user}","branches_url":"https://api.github.com/repos/PersonifyInc/webrtc/branches{/branch}","tags_url":"https://api.github.com/repos/PersonifyInc/webrtc/tags","blobs_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/refs{/sha}","trees_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PersonifyInc/webrtc/statuses/{sha}","languages_url":"https://api.github.com/repos/PersonifyInc/webrtc/languages","stargazers_url":"https://api.github.com/repos/PersonifyInc/webrtc/stargazers","contributors_url":"https://api.github.com/repos/PersonifyInc/webrtc/contributors","subscribers_url":"https://api.github.com/repos/PersonifyInc/webrtc/subscribers","subscription_url":"https://api.github.com/repos/PersonifyInc/webrtc/subscription","commits_url":"https://api.github.com/repos/PersonifyInc/webrtc/commits{/sha}","git_commits_url":"https://api.github.com/repos/PersonifyInc/webrtc/git/commits{/sha}","comments_url":"https://api.github.com/repos/PersonifyInc/webrtc/comments{/number}","issue_comment_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues/comments{/number}","contents_url":"https://api.github.com/repos/PersonifyInc/webrtc/contents/{+path}","compare_url":"https://api.github.com/repos/PersonifyInc/webrtc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PersonifyInc/webrtc/merges","archive_url":"https://api.github.com/repos/PersonifyInc/webrtc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PersonifyInc/webrtc/downloads","issues_url":"https://api.github.com/repos/PersonifyInc/webrtc/issues{/number}","pulls_url":"https://api.github.com/repos/PersonifyInc/webrtc/pulls{/number}","milestones_url":"https://api.github.com/repos/PersonifyInc/webrtc/milestones{/number}","notifications_url":"https://api.github.com/repos/PersonifyInc/webrtc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PersonifyInc/webrtc/labels{/name}","releases_url":"https://api.github.com/repos/PersonifyInc/webrtc/releases{/id}","created_at":"2013-09-07T00:03:07Z","updated_at":"2014-12-16T16:47:06Z","pushed_at":"2015-04-28T19:22:07Z","git_url":"git://github.com/PersonifyInc/webrtc.git","ssh_url":"git@github.com:PersonifyInc/webrtc.git","clone_url":"https://github.com/PersonifyInc/webrtc.git","svn_url":"https://github.com/PersonifyInc/webrtc","homepage":null,"size":93805,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3"},"html":{"href":"https://github.com/PersonifyInc/webrtc/pull/3"},"issue":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/issues/3"},"comments":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/PersonifyInc/webrtc/statuses/cdb34dd38f0763aca77c1ebfe515f0ab35607e36"}}}}