{"action":"opened","number":106,"pull_request":{"url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/106","id":30681425,"html_url":"https://github.com/RobotWebTools/ros3djs/pull/106","diff_url":"https://github.com/RobotWebTools/ros3djs/pull/106.diff","patch_url":"https://github.com/RobotWebTools/ros3djs/pull/106.patch","issue_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/106","number":106,"state":"open","locked":false,"title":"Update to THREE r70 and some major fixes","user":{"login":"psoetens","id":29791,"avatar_url":"https://avatars.githubusercontent.com/u/29791?v=3","gravatar_id":"","url":"https://api.github.com/users/psoetens","html_url":"https://github.com/psoetens","followers_url":"https://api.github.com/users/psoetens/followers","following_url":"https://api.github.com/users/psoetens/following{/other_user}","gists_url":"https://api.github.com/users/psoetens/gists{/gist_id}","starred_url":"https://api.github.com/users/psoetens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psoetens/subscriptions","organizations_url":"https://api.github.com/users/psoetens/orgs","repos_url":"https://api.github.com/users/psoetens/repos","events_url":"https://api.github.com/users/psoetens/events{/privacy}","received_events_url":"https://api.github.com/users/psoetens/received_events","type":"User","site_admin":false},"body":"This pull request is the result of 2 months coding against ros3djs, and fixing issues on the go. Finally, it also upgrades the codebase to THREE r70, which had quite some API changes since r63.\r\n\r\nApart from the modification of some default values, which could lead to discussion, I believe this patch series fixes a considerable number of issues in the ros3djs codebase, while maintaining compatibility.\r\n\r\nFor example, most objects now have management code to cleanly cleanup TFClient subscriptions if they're no longer needed, such that the tf_web_republisher is updated.\r\n\r\nAlso, zooming is now more responsive. I had to disable the highlighter rendering since this was not working well in r70. Someone should re-enable it and test it.\r\n\r\nFinally, a new PointCloud object was added which is an alternative to DepthCloud when the cloudsize < 320x240, but this is still in development.\r\n\r\nOne incompatibility is that for DepthCloud.js, we changed the distance from 0-4m to 0-2m and use each RGB channels for depth values. The result is a 6x better resolution (2x3), but it requires an update to the depthcloud_encoder as well (pull request will be created). I however seriously doubt anyone was using this code (due to serious issues in the web_video_server mp4 streaming).\r\n","created_at":"2015-03-06T21:33:00Z","updated_at":"2015-03-06T21:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/106/commits","review_comments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/106/comments","review_comment_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/106/comments","statuses_url":"https://api.github.com/repos/RobotWebTools/ros3djs/statuses/db3cec7a500ef6b6f12b21c6c52afd86b49ccec7","head":{"label":"psoetens:indigo-devel","ref":"indigo-devel","sha":"db3cec7a500ef6b6f12b21c6c52afd86b49ccec7","user":{"login":"psoetens","id":29791,"avatar_url":"https://avatars.githubusercontent.com/u/29791?v=3","gravatar_id":"","url":"https://api.github.com/users/psoetens","html_url":"https://github.com/psoetens","followers_url":"https://api.github.com/users/psoetens/followers","following_url":"https://api.github.com/users/psoetens/following{/other_user}","gists_url":"https://api.github.com/users/psoetens/gists{/gist_id}","starred_url":"https://api.github.com/users/psoetens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psoetens/subscriptions","organizations_url":"https://api.github.com/users/psoetens/orgs","repos_url":"https://api.github.com/users/psoetens/repos","events_url":"https://api.github.com/users/psoetens/events{/privacy}","received_events_url":"https://api.github.com/users/psoetens/received_events","type":"User","site_admin":false},"repo":{"id":31788412,"name":"ros3djs","full_name":"psoetens/ros3djs","owner":{"login":"psoetens","id":29791,"avatar_url":"https://avatars.githubusercontent.com/u/29791?v=3","gravatar_id":"","url":"https://api.github.com/users/psoetens","html_url":"https://github.com/psoetens","followers_url":"https://api.github.com/users/psoetens/followers","following_url":"https://api.github.com/users/psoetens/following{/other_user}","gists_url":"https://api.github.com/users/psoetens/gists{/gist_id}","starred_url":"https://api.github.com/users/psoetens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psoetens/subscriptions","organizations_url":"https://api.github.com/users/psoetens/orgs","repos_url":"https://api.github.com/users/psoetens/repos","events_url":"https://api.github.com/users/psoetens/events{/privacy}","received_events_url":"https://api.github.com/users/psoetens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/psoetens/ros3djs","description":"3D Visualization Library for use with the ROS JavaScript Libraries","fork":true,"url":"https://api.github.com/repos/psoetens/ros3djs","forks_url":"https://api.github.com/repos/psoetens/ros3djs/forks","keys_url":"https://api.github.com/repos/psoetens/ros3djs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psoetens/ros3djs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psoetens/ros3djs/teams","hooks_url":"https://api.github.com/repos/psoetens/ros3djs/hooks","issue_events_url":"https://api.github.com/repos/psoetens/ros3djs/issues/events{/number}","events_url":"https://api.github.com/repos/psoetens/ros3djs/events","assignees_url":"https://api.github.com/repos/psoetens/ros3djs/assignees{/user}","branches_url":"https://api.github.com/repos/psoetens/ros3djs/branches{/branch}","tags_url":"https://api.github.com/repos/psoetens/ros3djs/tags","blobs_url":"https://api.github.com/repos/psoetens/ros3djs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psoetens/ros3djs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psoetens/ros3djs/git/refs{/sha}","trees_url":"https://api.github.com/repos/psoetens/ros3djs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psoetens/ros3djs/statuses/{sha}","languages_url":"https://api.github.com/repos/psoetens/ros3djs/languages","stargazers_url":"https://api.github.com/repos/psoetens/ros3djs/stargazers","contributors_url":"https://api.github.com/repos/psoetens/ros3djs/contributors","subscribers_url":"https://api.github.com/repos/psoetens/ros3djs/subscribers","subscription_url":"https://api.github.com/repos/psoetens/ros3djs/subscription","commits_url":"https://api.github.com/repos/psoetens/ros3djs/commits{/sha}","git_commits_url":"https://api.github.com/repos/psoetens/ros3djs/git/commits{/sha}","comments_url":"https://api.github.com/repos/psoetens/ros3djs/comments{/number}","issue_comment_url":"https://api.github.com/repos/psoetens/ros3djs/issues/comments{/number}","contents_url":"https://api.github.com/repos/psoetens/ros3djs/contents/{+path}","compare_url":"https://api.github.com/repos/psoetens/ros3djs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psoetens/ros3djs/merges","archive_url":"https://api.github.com/repos/psoetens/ros3djs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psoetens/ros3djs/downloads","issues_url":"https://api.github.com/repos/psoetens/ros3djs/issues{/number}","pulls_url":"https://api.github.com/repos/psoetens/ros3djs/pulls{/number}","milestones_url":"https://api.github.com/repos/psoetens/ros3djs/milestones{/number}","notifications_url":"https://api.github.com/repos/psoetens/ros3djs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psoetens/ros3djs/labels{/name}","releases_url":"https://api.github.com/repos/psoetens/ros3djs/releases{/id}","created_at":"2015-03-06T20:48:12Z","updated_at":"2015-03-06T20:48:13Z","pushed_at":"2015-03-06T21:25:14Z","git_url":"git://github.com/psoetens/ros3djs.git","ssh_url":"git@github.com:psoetens/ros3djs.git","clone_url":"https://github.com/psoetens/ros3djs.git","svn_url":"https://github.com/psoetens/ros3djs","homepage":"http://robotwebtools.org/","size":3110,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RobotWebTools:develop","ref":"develop","sha":"3671349148f30f90bcf795386586acc8b666d877","user":{"login":"RobotWebTools","id":1491238,"avatar_url":"https://avatars.githubusercontent.com/u/1491238?v=3","gravatar_id":"","url":"https://api.github.com/users/RobotWebTools","html_url":"https://github.com/RobotWebTools","followers_url":"https://api.github.com/users/RobotWebTools/followers","following_url":"https://api.github.com/users/RobotWebTools/following{/other_user}","gists_url":"https://api.github.com/users/RobotWebTools/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotWebTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotWebTools/subscriptions","organizations_url":"https://api.github.com/users/RobotWebTools/orgs","repos_url":"https://api.github.com/users/RobotWebTools/repos","events_url":"https://api.github.com/users/RobotWebTools/events{/privacy}","received_events_url":"https://api.github.com/users/RobotWebTools/received_events","type":"Organization","site_admin":false},"repo":{"id":8788891,"name":"ros3djs","full_name":"RobotWebTools/ros3djs","owner":{"login":"RobotWebTools","id":1491238,"avatar_url":"https://avatars.githubusercontent.com/u/1491238?v=3","gravatar_id":"","url":"https://api.github.com/users/RobotWebTools","html_url":"https://github.com/RobotWebTools","followers_url":"https://api.github.com/users/RobotWebTools/followers","following_url":"https://api.github.com/users/RobotWebTools/following{/other_user}","gists_url":"https://api.github.com/users/RobotWebTools/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotWebTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotWebTools/subscriptions","organizations_url":"https://api.github.com/users/RobotWebTools/orgs","repos_url":"https://api.github.com/users/RobotWebTools/repos","events_url":"https://api.github.com/users/RobotWebTools/events{/privacy}","received_events_url":"https://api.github.com/users/RobotWebTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RobotWebTools/ros3djs","description":"3D Visualization Library for use with the ROS JavaScript Libraries","fork":false,"url":"https://api.github.com/repos/RobotWebTools/ros3djs","forks_url":"https://api.github.com/repos/RobotWebTools/ros3djs/forks","keys_url":"https://api.github.com/repos/RobotWebTools/ros3djs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobotWebTools/ros3djs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobotWebTools/ros3djs/teams","hooks_url":"https://api.github.com/repos/RobotWebTools/ros3djs/hooks","issue_events_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/events{/number}","events_url":"https://api.github.com/repos/RobotWebTools/ros3djs/events","assignees_url":"https://api.github.com/repos/RobotWebTools/ros3djs/assignees{/user}","branches_url":"https://api.github.com/repos/RobotWebTools/ros3djs/branches{/branch}","tags_url":"https://api.github.com/repos/RobotWebTools/ros3djs/tags","blobs_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobotWebTools/ros3djs/statuses/{sha}","languages_url":"https://api.github.com/repos/RobotWebTools/ros3djs/languages","stargazers_url":"https://api.github.com/repos/RobotWebTools/ros3djs/stargazers","contributors_url":"https://api.github.com/repos/RobotWebTools/ros3djs/contributors","subscribers_url":"https://api.github.com/repos/RobotWebTools/ros3djs/subscribers","subscription_url":"https://api.github.com/repos/RobotWebTools/ros3djs/subscription","commits_url":"https://api.github.com/repos/RobotWebTools/ros3djs/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobotWebTools/ros3djs/contents/{+path}","compare_url":"https://api.github.com/repos/RobotWebTools/ros3djs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobotWebTools/ros3djs/merges","archive_url":"https://api.github.com/repos/RobotWebTools/ros3djs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobotWebTools/ros3djs/downloads","issues_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues{/number}","pulls_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls{/number}","milestones_url":"https://api.github.com/repos/RobotWebTools/ros3djs/milestones{/number}","notifications_url":"https://api.github.com/repos/RobotWebTools/ros3djs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobotWebTools/ros3djs/labels{/name}","releases_url":"https://api.github.com/repos/RobotWebTools/ros3djs/releases{/id}","created_at":"2013-03-15T00:52:55Z","updated_at":"2015-02-22T15:50:30Z","pushed_at":"2015-02-13T18:41:48Z","git_url":"git://github.com/RobotWebTools/ros3djs.git","ssh_url":"git@github.com:RobotWebTools/ros3djs.git","clone_url":"https://github.com/RobotWebTools/ros3djs.git","svn_url":"https://github.com/RobotWebTools/ros3djs","homepage":"http://robotwebtools.org/","size":3743,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":12,"forks":29,"open_issues":12,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/106"},"html":{"href":"https://github.com/RobotWebTools/ros3djs/pull/106"},"issue":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/106"},"comments":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/statuses/db3cec7a500ef6b6f12b21c6c52afd86b49ccec7"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":18,"additions":278,"deletions":86,"changed_files":17}}