{"push_id":752427299,"size":30,"distinct_size":0,"ref":"refs/heads/upstream-master","head":"68f934355a2fef8e12ae78719a715efb37a0b031","before":"f5d072ae6c8186b58e38f73f9c906a715cbf3645","commits":[{"sha":"eb8e3b4c7a5f4d3054f4a79ad7559928e841e57f","author":{"email":"9174ef3e93199eb9960513de3be6e82218a49db6@skunkwerks.at","name":"Dave Cottlehuber"},"message":"Fix shared library names on OSX\n\n- OSX format is libname.major.minor.patch.dylib\n- closes #666","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/eb8e3b4c7a5f4d3054f4a79ad7559928e841e57f"},{"sha":"3a1d4e6c9f1a8d24c84152039b7342643509a219","author":{"email":"e363a170056789af5295e3062579e8b8a22461d8@fb.com","name":"Yueh-Hsuan Chiang"},"message":"Merge pull request #670 from skunkwerks/fix_osx_shared_library_names\n\nFix shared library names on OSX","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/3a1d4e6c9f1a8d24c84152039b7342643509a219"},{"sha":"102ac118b26a8906f95f57975b6ae1f3a17c30c5","author":{"email":"e363a170056789af5295e3062579e8b8a22461d8@fb.com","name":"Yueh-Hsuan Chiang"},"message":"Update JAVA-HISTORY.md for v3.13\n\nSummary: Update JAVA-HISTORY.md for v3.13\n\nTest Plan: no code change.\n\nReviewers: igor, anthony, IslamAbdelRahman, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D43539","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/102ac118b26a8906f95f57975b6ae1f3a17c30c5"},{"sha":"c45a57b41e1a62a953c7a02135979c0e86b2faa9","author":{"email":"0eeeb6e978dc270843efa667faa0368536372756@gmail.com","name":"Islam AbdelRahman"},"message":"Support delete rate limiting\n\nSummary:\nIntroduce DeleteScheduler that allow enforcing a rate limit on file deletion\nInstead of deleting files immediately, files are moved to trash directory and deleted in a background thread that apply sleep penalty between deletes if needed.\n\nI have updated PurgeObsoleteFiles and PurgeObsoleteWALFiles to use the delete_scheduler instead of env_->DeleteFile\n\nTest Plan:\nadded delete_scheduler_test\nexisting unit tests\n\nReviewers: kradhakrishnan, anthony, rven, yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43221","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/c45a57b41e1a62a953c7a02135979c0e86b2faa9"},{"sha":"5dc3e6881a0a074ab570b4835c20e0d30e0b59f3","author":{"email":"5e18920209a4cd606e3313601e55b3e7d65ab4e9@fb.com","name":"Ari Ekmekji"},"message":"Update Tests To Enable Subcompactions\n\nSummary:\nUpdated DBTest DBCompactionTest and CompactionJobStatsTest\nto run compaction-related tests once with subcompactions enabled and\nonce disabled using the TEST_P test type in the Google Test suite.\n\nTest Plan: ./db_test  ./db_compaction-test  ./compaction_job_stats_test\n\nReviewers: sdong, igor, anthony, yhchiang\n\nReviewed By: yhchiang\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D43443","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/5dc3e6881a0a074ab570b4835c20e0d30e0b59f3"},{"sha":"e06cf1a0986e18e5f92f66135a24655b6f329ec9","author":{"email":"fb156494e3523efe08867a7b5fc60bf06d6d6678@fb.com","name":"Mike Kolupaev"},"message":"[wal changes 3/3] method in DB to sync WAL without blocking writers\n\nSummary:\nSubj. We really need this feature.\n\nPrevious diff D40899 has most of the changes to make this possible, this diff just adds the method.\n\nTest Plan: `make check`, the new test fails without this diff; ran with ASAN, TSAN and valgrind.\n\nReviewers: igor, rven, IslamAbdelRahman, anthony, kradhakrishnan, tnovak, yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: MarkCallaghan, maykov, hermanlee4, yoshinorim, tnovak, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D40905","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/e06cf1a0986e18e5f92f66135a24655b6f329ec9"},{"sha":"c4650710294e3b4a57361a7df7c397e042d051ec","author":{"email":"1ecdc35cf7b88536a46b917735c0b197cc73668f@fb.com","name":"Andres Notzli"},"message":"Removing duplicate code\n\nSummary:\nWhile working on https://reviews.facebook.net/D43179 , I found\nduplicate code in the tests. This patch removes it.\n\nTest Plan: make clean all check\n\nReviewers: igor, sdong, rven, anthony, yhchiang\n\nReviewed By: yhchiang\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D43263","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/c4650710294e3b4a57361a7df7c397e042d051ec"},{"sha":"8e01bd1144abc43ebe68d8ea7393a3f1a31abd06","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"Fix misplaced position for reversing iterator direction while current key is a merge\n\nSummary:\nWhile doing forward iterating, if current key is merge, internal iterator position is placed to the next key. If Prev() is called now, needs to do extra Prev() to recover the location.\nThis is second attempt of fixing after reverting ec70fea4c4025351190eba7a02bd09bb5f083790. This time shrink the fix to only merge key is the current key and avoid the reseeking logic for max_iterating skipping\n\nTest Plan: enable the two disabled tests and make sure they pass\n\nReviewers: rven, IslamAbdelRahman, kradhakrishnan, tnovak, yhchiang\n\nReviewed By: yhchiang\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43557","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/8e01bd1144abc43ebe68d8ea7393a3f1a31abd06"},{"sha":"bd2fc5f5fbe637bfacb0813be52aa9a8bc48b70c","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Fix TSAN for delete_scheduler_test\n\nSummary: Fixing TSAN false positive and relaxing the conditions when we are running under TSAN\n\nTest Plan: COMPILE_WITH_TSAN=1 make -j64 delete_scheduler_test && ./delete_scheduler_test\n\nReviewers: yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43593","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/bd2fc5f5fbe637bfacb0813be52aa9a8bc48b70c"},{"sha":"9aec75fbb932fa7e1782436d28e490c554788608","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Enable DBTest.FlushSchedule under TSAN\n\nSummary: This patch will fix the false positive of DBTest.FlushSchedule under TSAN, we dont need to disable this test\n\nTest Plan: COMPILE_WITH_TSAN=1 make -j64 db_test && ./db_test --gtest_filter=\"DBTest.FlushSchedule\"\n\nReviewers: yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43599","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/9aec75fbb932fa7e1782436d28e490c554788608"},{"sha":"8ecb51a7e96cedcbe30a5a12f830a994c3d814fe","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"\"make commit-prereq\" should clean up rocksjava properly\n\nSummary: \"make commit-prereq\" fails to clean up java, which can cause rocksjava failure.\n\nTest Plan: Run commit-prepreq\n\nReviewers: IslamAbdelRahman, rven, kradhakrishnan, yhchiang\n\nReviewed By: yhchiang\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43575","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/8ecb51a7e96cedcbe30a5a12f830a994c3d814fe"},{"sha":"3ae386eafe2eeca911b20642048a7ae490020ace","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"Add statistic histogram \"rocksdb.sst.read.micros\"\n\nSummary: Measure read latency histogram and put in statistics. Compaction inputs are excluded from it when possible (unfortunately usually no possible as we usually take table reader from table cache.\n\nTest Plan:\nRun db_bench and it shows the stats, like:\n\nrocksdb.sst.read.micros statistics Percentiles :=> 50 : 1.238522 95 : 2.529740 99 : 3.912180\n\nReviewers: kradhakrishnan, rven, anthony, IslamAbdelRahman, MarkCallaghan, yhchiang\n\nReviewed By: yhchiang\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43275","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/3ae386eafe2eeca911b20642048a7ae490020ace"},{"sha":"7ccd1c80a7ab2d4bda2c5b8d111b8e58373458ed","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"Add two unit tests for SyncWAL()\n\nSummary:\nAdd two unit tests for SyncWAL(). One makes sure SyncWAL() doesn't block writes in the other thread. Another one makes sure SyncWAL() doesn't wait ongoing writes to finish before being executed.\n\nCreate a new test file db_wal_test and move two WAL related tests from db_test to here.\n\nTest Plan: Run the new tests\n\nReviewers: IslamAbdelRahman, rven, kradhakrishnan, kolmike, tnovak, yhchiang\n\nReviewed By: yhchiang\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43605","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/7ccd1c80a7ab2d4bda2c5b8d111b8e58373458ed"},{"sha":"960d936e8332546bd8a91cb0b0c3d06604368e83","author":{"email":"ed1215c0fddcf745750ccaf03b798589cd8f3fbe@devvm1501.prn1.facebook.com","name":"Poornima Chozhiyath Raman"},"message":"Add function 'GetInfoLogList()'\n\nSummary: The list of info log files of a db can be obtained using the new function.\n\nTest Plan: New test in db_test.cc passed.\n\nReviewers: yhchiang, IslamAbdelRahman, sdong\n\nReviewed By: sdong\n\nSubscribers: IslamAbdelRahman, leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D41715","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/960d936e8332546bd8a91cb0b0c3d06604368e83"},{"sha":"7d364d0d9402be99dc24cc845d37a0cd0949d3c2","author":{"email":"ed1215c0fddcf745750ccaf03b798589cd8f3fbe@devvm1501.prn1.facebook.com","name":"Poornima Chozhiyath Raman"},"message":"Fix build failure\n\nSummary: fix the build failure\n\nTest Plan: make all\n\nReviewers: sdong, IslamAbdelRahman\n\nReviewed By: IslamAbdelRahman\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D43623","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/7d364d0d9402be99dc24cc845d37a0cd0949d3c2"},{"sha":"fca88f8e169e0f52ea426e99c56c95e4760868ca","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"valgrind_check to exit on test failures\n\nSummary: Currently, valgrind_check doesn't fail on test failures, which creates confusion. valgrind_check should fail if test fails.\n\nTest Plan: Manually change tests to return test failure or cause memory leak and see valgrind_check has the correct behavior.\n\nReviewers: anthony, yhchiang, IslamAbdelRahman, igor, kradhakrishnan, rven\n\nReviewed By: rven\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43629","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/fca88f8e169e0f52ea426e99c56c95e4760868ca"},{"sha":"29b028b0edacf6d8545251dfed22700f469d513a","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Make DeleteScheduler tests more reliable\n\nSummary: Update DeleteScheduler tests so that they verify the used penalties for waiting instead of measuring the time spent which is not reliable\n\nTest Plan:\nmake -j64 delete_scheduler_test && ./delete_scheduler_test\nCOMPILE_WITH_TSAN=1 make -j64 delete_scheduler_test && ./delete_scheduler_test\nCOMPILE_WITH_ASAN=1 make -j64 delete_scheduler_test && ./delete_scheduler_test\n\nmake -j64 db_test && ./db_test --gtest_filter=\"DBTest.RateLimitedDelete:DBTest.DeleteSchedulerMultipleDBPaths\"\nCOMPILE_WITH_TSAN=1 make -j64 db_test && ./db_test --gtest_filter=\"DBTest.RateLimitedDelete:DBTest.DeleteSchedulerMultipleDBPaths\"\nCOMPILE_WITH_ASAN=1 make -j64 db_test && ./db_test --gtest_filter=\"DBTest.RateLimitedDelete:DBTest.DeleteSchedulerMultipleDBPaths\"\n\nReviewers: yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43635","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/29b028b0edacf6d8545251dfed22700f469d513a"},{"sha":"c7742452ebd6c096fc727fa1bd21804e8cea2b20","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"Add Statistics.getHistogramString() to print more detailed outputs of a histogram\n\nSummary:\nProvide a way for users to know more detailed ditribution of a histogram metrics. Example outputs:\n\nManually add statement\n  fprintf(stdout, \"%s\\n\", dbstats->getHistogramString(SST_READ_MICROS).c_str());\nWill print out something like:\n\nCount: 989151  Average: 1.7659  StdDev: 1.52\nMin: 0.0000  Median: 1.2071  Max: 860.0000\nPercentiles: P50: 1.21 P75: 1.70 P99: 5.12 P99.9: 13.67 P99.99: 21.70\n------------------------------------------------------\n[       0,       1 )   390839  39.513%  39.513% ########\n[       1,       2 )   500918  50.641%  90.154% ##########\n[       2,       3 )    79358   8.023%  98.177% ##\n[       3,       4 )     6297   0.637%  98.813%\n[       4,       5 )     1712   0.173%  98.986%\n[       5,       6 )     1134   0.115%  99.101%\n[       6,       7 )     1222   0.124%  99.224%\n[       7,       8 )     1529   0.155%  99.379%\n[       8,       9 )     1264   0.128%  99.507%\n[       9,      10 )      988   0.100%  99.607%\n[      10,      12 )     1378   0.139%  99.746%\n[      12,      14 )     1828   0.185%  99.931%\n[      14,      16 )      410   0.041%  99.972%\n[      16,      18 )       72   0.007%  99.980%\n[      18,      20 )       67   0.007%  99.986%\n[      20,      25 )      106   0.011%  99.997%\n[      25,      30 )       24   0.002%  99.999%\n[      30,      35 )        1   0.000% 100.000%\n[     250,     300 )        2   0.000% 100.000%\n[     300,     350 )        1   0.000% 100.000%\n[     800,     900 )        1   0.000% 100.000%\n\nTest Plan: Manually add a print in db_bench and make sure it prints out as expected. Will add some codes to cover the function\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43611","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/c7742452ebd6c096fc727fa1bd21804e8cea2b20"},{"sha":"48e6e9aa82946c9cb91fecd47c67c59a40ceac69","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"Add util/delete_scheduler_impl.cc to CMakeLists.txt\n\nSummary: util/delete_scheduler_impl.cc is missing CMakeLists.txt, which fails Windows build. Add it.\n\nTest Plan: Build in both of Windows and Linux\n\nReviewers: anthony, rven, yhchiang, IslamAbdelRahman\n\nReviewed By: IslamAbdelRahman\n\nSubscribers: leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D43641","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/48e6e9aa82946c9cb91fecd47c67c59a40ceac69"},{"sha":"d7314ba7594f29db58eb3ccd5e16b53b98b5e7cd","author":{"email":"a27884a205c28e99df76dbb0d834084a9a704cba@gmail.com","name":"Andres Noetzli"},"message":"Fixing endless loop if seeking to end of key with seq num 0\n\nSummary:\nWhen seeking to the last occurrence of a key with sequence number 0, db_iter\nends up in an endless loop because it seeks to type kValueTypeForSeek\nwhich is larger than kTypeDeletion/kTypeValue. Added test case that triggers\nthe behavior.\n\nTest Plan: make clean all check\n\nReviewers: igor, rven, anthony, yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D43653","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/d7314ba7594f29db58eb3ccd5e16b53b98b5e7cd"}]}