{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14677","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14677/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14677/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14677/events","html_url":"https://github.com/kubernetes/kubernetes/issues/14677","id":108732780,"number":14677,"title":"hack/verify-godeps.sh fails on master","user":{"login":"karlkfi","id":3980984,"avatar_url":"https://avatars.githubusercontent.com/u/3980984?v=3","gravatar_id":"","url":"https://api.github.com/users/karlkfi","html_url":"https://github.com/karlkfi","followers_url":"https://api.github.com/users/karlkfi/followers","following_url":"https://api.github.com/users/karlkfi/following{/other_user}","gists_url":"https://api.github.com/users/karlkfi/gists{/gist_id}","starred_url":"https://api.github.com/users/karlkfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karlkfi/subscriptions","organizations_url":"https://api.github.com/users/karlkfi/orgs","repos_url":"https://api.github.com/users/karlkfi/repos","events_url":"https://api.github.com/users/karlkfi/events{/privacy}","received_events_url":"https://api.github.com/users/karlkfi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/test","name":"area/test","color":"fad8c7"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21"},{"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/P0","name":"priority/P0","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"eparis","id":8093535,"avatar_url":"https://avatars.githubusercontent.com/u/8093535?v=3","gravatar_id":"","url":"https://api.github.com/users/eparis","html_url":"https://github.com/eparis","followers_url":"https://api.github.com/users/eparis/followers","following_url":"https://api.github.com/users/eparis/following{/other_user}","gists_url":"https://api.github.com/users/eparis/gists{/gist_id}","starred_url":"https://api.github.com/users/eparis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eparis/subscriptions","organizations_url":"https://api.github.com/users/eparis/orgs","repos_url":"https://api.github.com/users/eparis/repos","events_url":"https://api.github.com/users/eparis/events{/privacy}","received_events_url":"https://api.github.com/users/eparis/received_events","type":"User","site_admin":false},"milestone":null,"comments":30,"created_at":"2015-09-28T19:45:48Z","updated_at":"2015-09-29T16:00:25Z","closed_at":null,"body":"`hack/verify-godeps.sh` is run as part of Shippable and seems to be failing on any PRs that change Godeps.\r\n\r\n```\r\n$ hack/verify-godeps.sh\r\nStarting to download all kubernetes godeps. This takes a while\r\nDownload finished\r\nYour Godeps.json is different:\r\n--- /go/src/github.com/GoogleCloudPlatform/kubernetes/Godeps/Godeps.json\t2015-09-28 19:28:55.000000000 +0000\r\n+++ /tmp/gopath.bycPi4/src/k8s.io/kubernetes/Godeps/Godeps.json\t2015-09-28 19:41:46.681006178 +0000\r\n@@ -578,15 +577,15 @@\r\n \t\t},\r\n \t\t{\r\n \t\t\t\"ImportPath\": \"golang.org/x/net/context\",\r\n-\t\t\t\"Rev\": \"cbcac7bb8415db9b6cb4d1ebab1dc9afbd688b97\"\r\n+\t\t\t\"Rev\": \"c2528b2dd8352441850638a8bb678c2ad056fd3e\"\r\n \t\t},\r\n \t\t{\r\n \t\t\t\"ImportPath\": \"golang.org/x/net/html\",\r\n-\t\t\t\"Rev\": \"cbcac7bb8415db9b6cb4d1ebab1dc9afbd688b97\"\r\n+\t\t\t\"Rev\": \"c2528b2dd8352441850638a8bb678c2ad056fd3e\"\r\n \t\t},\r\n \t\t{\r\n \t\t\t\"ImportPath\": \"golang.org/x/net/websocket\",\r\n-\t\t\t\"Rev\": \"cbcac7bb8415db9b6cb4d1ebab1dc9afbd688b97\"\r\n+\t\t\t\"Rev\": \"c2528b2dd8352441850638a8bb678c2ad056fd3e\"\r\n \t\t},\r\n \t\t{\r\n \t\t\t\"ImportPath\": \"golang.org/x/oauth2\",\r\nRemoving /tmp/gopath.bycPi4\r\n```\r\n\r\nI was able to reproduce on master by removing the early exit when no Godeps changes are shown by `git diff`: https://github.com/kubernetes/kubernetes/blob/master/hack/verify-godeps.sh#L44-L46"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/144103297","html_url":"https://github.com/kubernetes/kubernetes/issues/14677#issuecomment-144103297","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/14677","id":144103297,"user":{"login":"ncdc","id":354,"avatar_url":"https://avatars.githubusercontent.com/u/354?v=3","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T16:00:25Z","updated_at":"2015-09-29T16:00:25Z","body":"I have identified what I believe to be the actual root cause. When `go get -d` initially downloads `google.golang.org/api/compute/v1`, its HEAD pulls in `golang.org/x/net/context/ctxhttp`. That directory isn't currently vendored by our copy of `golang.org/x/net` revision cbcac7b. As a result, `go get` pulls down an update for `golang.org/x/net`, fixing its detached head during the process. This is unfortunate, as presumably the rev of `google.golang.org/api/compute/v1` in our Godeps.json is probably compatible with the rev of `golang.org/x/net` in there as well, but because `go get -d` pulls down the HEAD of the former, it's forced to do the same for the latter."}}