{"action":"created","comment":{"url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments/23295076","id":23295076,"diff_hunk":"@@ -50,17 +50,17 @@ public void startExecutionUnit(ExecutionUnitRunner executionUnitRunner, RunNotif\n         executionUnitNotifier.fireTestStarted();\n     }\n \n-    public void finishExecutionUnit() {\n+    public void skipExecutionUnitIfIgnored() {\n         if (ignoredStep) {\n             executionUnitNotifier.fireTestIgnored();\n         }\n-        executionUnitNotifier.fireTestFinished();","path":"junit/src/main/java/cucumber/runtime/junit/JUnitReporter.java","position":9,"original_position":9,"commit_id":"02cfd4882c4ff0f186e93c54482d5be1de58f9dc","original_commit_id":"02cfd4882c4ff0f186e93c54482d5be1de58f9dc","user":{"login":"brasmusson","id":2105308,"avatar_url":"https://avatars.githubusercontent.com/u/2105308?v=3","gravatar_id":"","url":"https://api.github.com/users/brasmusson","html_url":"https://github.com/brasmusson","followers_url":"https://api.github.com/users/brasmusson/followers","following_url":"https://api.github.com/users/brasmusson/following{/other_user}","gists_url":"https://api.github.com/users/brasmusson/gists{/gist_id}","starred_url":"https://api.github.com/users/brasmusson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brasmusson/subscriptions","organizations_url":"https://api.github.com/users/brasmusson/orgs","repos_url":"https://api.github.com/users/brasmusson/repos","events_url":"https://api.github.com/users/brasmusson/events{/privacy}","received_events_url":"https://api.github.com/users/brasmusson/received_events","type":"User","site_admin":false},"body":"This was the only fireTestFinished() on the executionUnitNotifier (all others are on the stepNotifier), now the scenario (or in JUnit terms the test suite) will not be finished. The log for the [picocontainer tests](https://travis-ci.org/cucumber/cucumber-jvm/jobs/47766656) visualize this clearly (line 5758).","created_at":"2015-01-21T12:21:41Z","updated_at":"2015-01-21T12:21:41Z","html_url":"https://github.com/cucumber/cucumber-jvm/pull/825#discussion_r23295076","pull_request_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825","_links":{"self":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments/23295076"},"html":{"href":"https://github.com/cucumber/cucumber-jvm/pull/825#discussion_r23295076"},"pull_request":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825"}}},"pull_request":{"url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825","id":27297821,"html_url":"https://github.com/cucumber/cucumber-jvm/pull/825","diff_url":"https://github.com/cucumber/cucumber-jvm/pull/825.diff","patch_url":"https://github.com/cucumber/cucumber-jvm/pull/825.patch","issue_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/825","number":825,"state":"open","locked":false,"title":"Fix test cases execution time in reports","user":{"login":"clicman","id":1079535,"avatar_url":"https://avatars.githubusercontent.com/u/1079535?v=3","gravatar_id":"","url":"https://api.github.com/users/clicman","html_url":"https://github.com/clicman","followers_url":"https://api.github.com/users/clicman/followers","following_url":"https://api.github.com/users/clicman/following{/other_user}","gists_url":"https://api.github.com/users/clicman/gists{/gist_id}","starred_url":"https://api.github.com/users/clicman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicman/subscriptions","organizations_url":"https://api.github.com/users/clicman/orgs","repos_url":"https://api.github.com/users/clicman/repos","events_url":"https://api.github.com/users/clicman/events{/privacy}","received_events_url":"https://api.github.com/users/clicman/received_events","type":"User","site_admin":false},"body":"This is bug fix for test steps execution time. It was fired fireTestStarted event after test was performed. \r\nI was moved event at the start of step execution. Now timings calculated right.\r\n\r\nIn tests I was just removed fireTestStarted execution verification because it not performed in that places.","created_at":"2015-01-13T19:34:57Z","updated_at":"2015-01-21T12:21:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c165162f03d544a1df3dae14f4b2cb2c6f90f6c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825/commits","review_comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825/comments","review_comment_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments/{number}","comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/825/comments","statuses_url":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/02cfd4882c4ff0f186e93c54482d5be1de58f9dc","head":{"label":"clicman:master","ref":"master","sha":"02cfd4882c4ff0f186e93c54482d5be1de58f9dc","user":{"login":"clicman","id":1079535,"avatar_url":"https://avatars.githubusercontent.com/u/1079535?v=3","gravatar_id":"","url":"https://api.github.com/users/clicman","html_url":"https://github.com/clicman","followers_url":"https://api.github.com/users/clicman/followers","following_url":"https://api.github.com/users/clicman/following{/other_user}","gists_url":"https://api.github.com/users/clicman/gists{/gist_id}","starred_url":"https://api.github.com/users/clicman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicman/subscriptions","organizations_url":"https://api.github.com/users/clicman/orgs","repos_url":"https://api.github.com/users/clicman/repos","events_url":"https://api.github.com/users/clicman/events{/privacy}","received_events_url":"https://api.github.com/users/clicman/received_events","type":"User","site_admin":false},"repo":{"id":29206081,"name":"cucumber-jvm","full_name":"clicman/cucumber-jvm","owner":{"login":"clicman","id":1079535,"avatar_url":"https://avatars.githubusercontent.com/u/1079535?v=3","gravatar_id":"","url":"https://api.github.com/users/clicman","html_url":"https://github.com/clicman","followers_url":"https://api.github.com/users/clicman/followers","following_url":"https://api.github.com/users/clicman/following{/other_user}","gists_url":"https://api.github.com/users/clicman/gists{/gist_id}","starred_url":"https://api.github.com/users/clicman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clicman/subscriptions","organizations_url":"https://api.github.com/users/clicman/orgs","repos_url":"https://api.github.com/users/clicman/repos","events_url":"https://api.github.com/users/clicman/events{/privacy}","received_events_url":"https://api.github.com/users/clicman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clicman/cucumber-jvm","description":"Cucumber for the JVM","fork":true,"url":"https://api.github.com/repos/clicman/cucumber-jvm","forks_url":"https://api.github.com/repos/clicman/cucumber-jvm/forks","keys_url":"https://api.github.com/repos/clicman/cucumber-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clicman/cucumber-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clicman/cucumber-jvm/teams","hooks_url":"https://api.github.com/repos/clicman/cucumber-jvm/hooks","issue_events_url":"https://api.github.com/repos/clicman/cucumber-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/clicman/cucumber-jvm/events","assignees_url":"https://api.github.com/repos/clicman/cucumber-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/clicman/cucumber-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/clicman/cucumber-jvm/tags","blobs_url":"https://api.github.com/repos/clicman/cucumber-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clicman/cucumber-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clicman/cucumber-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/clicman/cucumber-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clicman/cucumber-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/clicman/cucumber-jvm/languages","stargazers_url":"https://api.github.com/repos/clicman/cucumber-jvm/stargazers","contributors_url":"https://api.github.com/repos/clicman/cucumber-jvm/contributors","subscribers_url":"https://api.github.com/repos/clicman/cucumber-jvm/subscribers","subscription_url":"https://api.github.com/repos/clicman/cucumber-jvm/subscription","commits_url":"https://api.github.com/repos/clicman/cucumber-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/clicman/cucumber-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/clicman/cucumber-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/clicman/cucumber-jvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/clicman/cucumber-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/clicman/cucumber-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clicman/cucumber-jvm/merges","archive_url":"https://api.github.com/repos/clicman/cucumber-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clicman/cucumber-jvm/downloads","issues_url":"https://api.github.com/repos/clicman/cucumber-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/clicman/cucumber-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/clicman/cucumber-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/clicman/cucumber-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clicman/cucumber-jvm/labels{/name}","releases_url":"https://api.github.com/repos/clicman/cucumber-jvm/releases{/id}","created_at":"2015-01-13T19:08:55Z","updated_at":"2015-01-21T11:08:56Z","pushed_at":"2015-01-21T11:08:54Z","git_url":"git://github.com/clicman/cucumber-jvm.git","ssh_url":"git@github.com:clicman/cucumber-jvm.git","clone_url":"https://github.com/clicman/cucumber-jvm.git","svn_url":"https://github.com/clicman/cucumber-jvm","homepage":"http://cukes.info","size":15810,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cucumber:master","ref":"master","sha":"9274a80e9ab5b34f57786c3ddd6f222bd80dc5b6","user":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"repo":{"id":1962219,"name":"cucumber-jvm","full_name":"cucumber/cucumber-jvm","owner":{"login":"cucumber","id":320565,"avatar_url":"https://avatars.githubusercontent.com/u/320565?v=3","gravatar_id":"","url":"https://api.github.com/users/cucumber","html_url":"https://github.com/cucumber","followers_url":"https://api.github.com/users/cucumber/followers","following_url":"https://api.github.com/users/cucumber/following{/other_user}","gists_url":"https://api.github.com/users/cucumber/gists{/gist_id}","starred_url":"https://api.github.com/users/cucumber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cucumber/subscriptions","organizations_url":"https://api.github.com/users/cucumber/orgs","repos_url":"https://api.github.com/users/cucumber/repos","events_url":"https://api.github.com/users/cucumber/events{/privacy}","received_events_url":"https://api.github.com/users/cucumber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cucumber/cucumber-jvm","description":"Cucumber for the JVM","fork":false,"url":"https://api.github.com/repos/cucumber/cucumber-jvm","forks_url":"https://api.github.com/repos/cucumber/cucumber-jvm/forks","keys_url":"https://api.github.com/repos/cucumber/cucumber-jvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cucumber/cucumber-jvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cucumber/cucumber-jvm/teams","hooks_url":"https://api.github.com/repos/cucumber/cucumber-jvm/hooks","issue_events_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/events{/number}","events_url":"https://api.github.com/repos/cucumber/cucumber-jvm/events","assignees_url":"https://api.github.com/repos/cucumber/cucumber-jvm/assignees{/user}","branches_url":"https://api.github.com/repos/cucumber/cucumber-jvm/branches{/branch}","tags_url":"https://api.github.com/repos/cucumber/cucumber-jvm/tags","blobs_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/{sha}","languages_url":"https://api.github.com/repos/cucumber/cucumber-jvm/languages","stargazers_url":"https://api.github.com/repos/cucumber/cucumber-jvm/stargazers","contributors_url":"https://api.github.com/repos/cucumber/cucumber-jvm/contributors","subscribers_url":"https://api.github.com/repos/cucumber/cucumber-jvm/subscribers","subscription_url":"https://api.github.com/repos/cucumber/cucumber-jvm/subscription","commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cucumber/cucumber-jvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cucumber/cucumber-jvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/comments/{number}","contents_url":"https://api.github.com/repos/cucumber/cucumber-jvm/contents/{+path}","compare_url":"https://api.github.com/repos/cucumber/cucumber-jvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cucumber/cucumber-jvm/merges","archive_url":"https://api.github.com/repos/cucumber/cucumber-jvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cucumber/cucumber-jvm/downloads","issues_url":"https://api.github.com/repos/cucumber/cucumber-jvm/issues{/number}","pulls_url":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls{/number}","milestones_url":"https://api.github.com/repos/cucumber/cucumber-jvm/milestones{/number}","notifications_url":"https://api.github.com/repos/cucumber/cucumber-jvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cucumber/cucumber-jvm/labels{/name}","releases_url":"https://api.github.com/repos/cucumber/cucumber-jvm/releases{/id}","created_at":"2011-06-27T19:49:46Z","updated_at":"2015-01-19T18:56:36Z","pushed_at":"2015-01-19T18:56:36Z","git_url":"git://github.com/cucumber/cucumber-jvm.git","ssh_url":"git@github.com:cucumber/cucumber-jvm.git","clone_url":"https://github.com/cucumber/cucumber-jvm.git","svn_url":"https://github.com/cucumber/cucumber-jvm","homepage":"http://cukes.info","size":31001,"stargazers_count":935,"watchers_count":935,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":749,"mirror_url":null,"open_issues_count":103,"forks":749,"open_issues":103,"watchers":935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825"},"html":{"href":"https://github.com/cucumber/cucumber-jvm/pull/825"},"issue":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/825"},"comments":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/issues/825/comments"},"review_comments":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825/comments"},"review_comment":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/pulls/825/commits"},"statuses":{"href":"https://api.github.com/repos/cucumber/cucumber-jvm/statuses/02cfd4882c4ff0f186e93c54482d5be1de58f9dc"}}}}