{"action":"closed","number":191,"pull_request":{"url":"https://api.github.com/repos/mozilla/oghliner/pulls/191","id":50708284,"html_url":"https://github.com/mozilla/oghliner/pull/191","diff_url":"https://github.com/mozilla/oghliner/pull/191.diff","patch_url":"https://github.com/mozilla/oghliner/pull/191.patch","issue_url":"https://api.github.com/repos/mozilla/oghliner/issues/191","number":191,"state":"closed","locked":false,"title":"New template","user":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"body":"This version only adds a new template for sw-precahe (avoiding the cache per resource approach of the original template). The main problem here is how to keep the two cache versions until activation has been done as sw-precache does not identify the new worker as it does `cacheVersion` in pr #188.\r\n\r\nThe proposal use a temporal _new_ cache to populate it during installation. During activation, the contents of this _new_ cache are moved to the current. Personally, I don't like this solution as if for some reason, the activation process gets interrupted, the contents can be lost or be only partially updated. This can not occur in pr #188.\r\n\r\nAnother problem is that we need to keep the hashes as part of the actual code (not commentaries as in pr #188) because we need to retain the fingerprint of the content being cache in order to produce a byte-level change when updating the resources. In the pr #188 this is addressed by including a hash of all content hashes.","created_at":"2015-11-14T00:11:26Z","updated_at":"2015-11-19T19:33:24Z","closed_at":"2015-11-19T19:33:23Z","merged_at":null,"merge_commit_sha":"ae8af16d31321856d13319ca67bd21e4bb865567","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/oghliner/pulls/191/commits","review_comments_url":"https://api.github.com/repos/mozilla/oghliner/pulls/191/comments","review_comment_url":"https://api.github.com/repos/mozilla/oghliner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/oghliner/issues/191/comments","statuses_url":"https://api.github.com/repos/mozilla/oghliner/statuses/9219bd9c4cf39d40e79b36b280a0bc5689fae975","head":{"label":"delapuente:new-template-for-sw-preache","ref":"new-template-for-sw-preache","sha":"9219bd9c4cf39d40e79b36b280a0bc5689fae975","user":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"repo":{"id":44406164,"name":"oghliner","full_name":"delapuente/oghliner","owner":{"login":"delapuente","id":757942,"avatar_url":"https://avatars.githubusercontent.com/u/757942?v=3","gravatar_id":"","url":"https://api.github.com/users/delapuente","html_url":"https://github.com/delapuente","followers_url":"https://api.github.com/users/delapuente/followers","following_url":"https://api.github.com/users/delapuente/following{/other_user}","gists_url":"https://api.github.com/users/delapuente/gists{/gist_id}","starred_url":"https://api.github.com/users/delapuente/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delapuente/subscriptions","organizations_url":"https://api.github.com/users/delapuente/orgs","repos_url":"https://api.github.com/users/delapuente/repos","events_url":"https://api.github.com/users/delapuente/events{/privacy}","received_events_url":"https://api.github.com/users/delapuente/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/delapuente/oghliner","description":"template and tool for deploying Offline Web Apps to GitHub Pages","fork":true,"url":"https://api.github.com/repos/delapuente/oghliner","forks_url":"https://api.github.com/repos/delapuente/oghliner/forks","keys_url":"https://api.github.com/repos/delapuente/oghliner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/delapuente/oghliner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/delapuente/oghliner/teams","hooks_url":"https://api.github.com/repos/delapuente/oghliner/hooks","issue_events_url":"https://api.github.com/repos/delapuente/oghliner/issues/events{/number}","events_url":"https://api.github.com/repos/delapuente/oghliner/events","assignees_url":"https://api.github.com/repos/delapuente/oghliner/assignees{/user}","branches_url":"https://api.github.com/repos/delapuente/oghliner/branches{/branch}","tags_url":"https://api.github.com/repos/delapuente/oghliner/tags","blobs_url":"https://api.github.com/repos/delapuente/oghliner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/delapuente/oghliner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/delapuente/oghliner/git/refs{/sha}","trees_url":"https://api.github.com/repos/delapuente/oghliner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/delapuente/oghliner/statuses/{sha}","languages_url":"https://api.github.com/repos/delapuente/oghliner/languages","stargazers_url":"https://api.github.com/repos/delapuente/oghliner/stargazers","contributors_url":"https://api.github.com/repos/delapuente/oghliner/contributors","subscribers_url":"https://api.github.com/repos/delapuente/oghliner/subscribers","subscription_url":"https://api.github.com/repos/delapuente/oghliner/subscription","commits_url":"https://api.github.com/repos/delapuente/oghliner/commits{/sha}","git_commits_url":"https://api.github.com/repos/delapuente/oghliner/git/commits{/sha}","comments_url":"https://api.github.com/repos/delapuente/oghliner/comments{/number}","issue_comment_url":"https://api.github.com/repos/delapuente/oghliner/issues/comments{/number}","contents_url":"https://api.github.com/repos/delapuente/oghliner/contents/{+path}","compare_url":"https://api.github.com/repos/delapuente/oghliner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/delapuente/oghliner/merges","archive_url":"https://api.github.com/repos/delapuente/oghliner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/delapuente/oghliner/downloads","issues_url":"https://api.github.com/repos/delapuente/oghliner/issues{/number}","pulls_url":"https://api.github.com/repos/delapuente/oghliner/pulls{/number}","milestones_url":"https://api.github.com/repos/delapuente/oghliner/milestones{/number}","notifications_url":"https://api.github.com/repos/delapuente/oghliner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/delapuente/oghliner/labels{/name}","releases_url":"https://api.github.com/repos/delapuente/oghliner/releases{/id}","created_at":"2015-10-16T19:26:00Z","updated_at":"2015-10-16T19:26:01Z","pushed_at":"2015-11-19T01:32:30Z","git_url":"git://github.com/delapuente/oghliner.git","ssh_url":"git@github.com:delapuente/oghliner.git","clone_url":"https://github.com/delapuente/oghliner.git","svn_url":"https://github.com/delapuente/oghliner","homepage":"https://mozilla.github.io/oghliner/","size":592,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"22e935832e0fb6cf46093dfd2a44914bae331e8a","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":42184542,"name":"oghliner","full_name":"mozilla/oghliner","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/oghliner","description":"template and tool for deploying Offline Web Apps to GitHub Pages","fork":false,"url":"https://api.github.com/repos/mozilla/oghliner","forks_url":"https://api.github.com/repos/mozilla/oghliner/forks","keys_url":"https://api.github.com/repos/mozilla/oghliner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/oghliner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/oghliner/teams","hooks_url":"https://api.github.com/repos/mozilla/oghliner/hooks","issue_events_url":"https://api.github.com/repos/mozilla/oghliner/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/oghliner/events","assignees_url":"https://api.github.com/repos/mozilla/oghliner/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/oghliner/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/oghliner/tags","blobs_url":"https://api.github.com/repos/mozilla/oghliner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/oghliner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/oghliner/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/oghliner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/oghliner/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/oghliner/languages","stargazers_url":"https://api.github.com/repos/mozilla/oghliner/stargazers","contributors_url":"https://api.github.com/repos/mozilla/oghliner/contributors","subscribers_url":"https://api.github.com/repos/mozilla/oghliner/subscribers","subscription_url":"https://api.github.com/repos/mozilla/oghliner/subscription","commits_url":"https://api.github.com/repos/mozilla/oghliner/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/oghliner/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/oghliner/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/oghliner/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/oghliner/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/oghliner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/oghliner/merges","archive_url":"https://api.github.com/repos/mozilla/oghliner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/oghliner/downloads","issues_url":"https://api.github.com/repos/mozilla/oghliner/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/oghliner/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/oghliner/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/oghliner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/oghliner/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/oghliner/releases{/id}","created_at":"2015-09-09T14:42:56Z","updated_at":"2015-11-17T00:25:06Z","pushed_at":"2015-11-19T19:32:36Z","git_url":"git://github.com/mozilla/oghliner.git","ssh_url":"git@github.com:mozilla/oghliner.git","clone_url":"https://github.com/mozilla/oghliner.git","svn_url":"https://github.com/mozilla/oghliner","homepage":"https://mozilla.github.io/oghliner/","size":634,"stargazers_count":11,"watchers_count":11,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":7,"mirror_url":null,"open_issues_count":34,"forks":7,"open_issues":34,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/oghliner/pulls/191"},"html":{"href":"https://github.com/mozilla/oghliner/pull/191"},"issue":{"href":"https://api.github.com/repos/mozilla/oghliner/issues/191"},"comments":{"href":"https://api.github.com/repos/mozilla/oghliner/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/oghliner/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/oghliner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/oghliner/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/oghliner/statuses/9219bd9c4cf39d40e79b36b280a0bc5689fae975"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"commits":1,"additions":172,"deletions":1,"changed_files":3}}