{"action":"closed","number":834,"pull_request":{"url":"https://api.github.com/repos/spring-projects/spring-framework/pulls/834","id":39627963,"html_url":"https://github.com/spring-projects/spring-framework/pull/834","diff_url":"https://github.com/spring-projects/spring-framework/pull/834.diff","patch_url":"https://github.com/spring-projects/spring-framework/pull/834.patch","issue_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/834","number":834,"state":"closed","locked":false,"title":"DelegatingFilterProxy looks at \"registered\" WebApplicationContexts","user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"body":"Previously when users registered an additional Filter in the\r\nDispatcherServlet the DelegatingFilterProxy would not find it unless\r\nthe context attribute was set. The value for which was difficult to\r\nremember and added quite a bit of additional \"if\" statements to setting\r\nup Spring Security successfully.\r\n\r\nThis change allows registering additional known WebApplicationContext\r\ninstances. The DispatcherServlet uses this mechanism to register its\r\ncontext. With that change DelegatingFilterProxy searches for the first\r\nregistered WebApplicationContext that contains the bean name.\r\n\r\nThis change also sets up the ability for Spring Security to lookup\r\nBeans defined in the child context within the Tag libs.\r\n\r\nIssue: SPR-13191","created_at":"2015-07-09T21:02:25Z","updated_at":"2015-10-27T19:13:44Z","closed_at":"2015-10-27T19:13:44Z","merged_at":null,"merge_commit_sha":"c69bf57bb4de9c3c8aa5242c12e26df91cfbda0c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spring-projects/spring-framework/pulls/834/commits","review_comments_url":"https://api.github.com/repos/spring-projects/spring-framework/pulls/834/comments","review_comment_url":"https://api.github.com/repos/spring-projects/spring-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/834/comments","statuses_url":"https://api.github.com/repos/spring-projects/spring-framework/statuses/e8047f20f864ae78ba41461d5a8e22a9c72b01e1","head":{"label":"rwinch:SPR-13191","ref":"SPR-13191","sha":"e8047f20f864ae78ba41461d5a8e22a9c72b01e1","user":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"repo":{"id":4966545,"name":"spring-framework","full_name":"rwinch/spring-framework","owner":{"login":"rwinch","id":362503,"avatar_url":"https://avatars.githubusercontent.com/u/362503?v=3","gravatar_id":"","url":"https://api.github.com/users/rwinch","html_url":"https://github.com/rwinch","followers_url":"https://api.github.com/users/rwinch/followers","following_url":"https://api.github.com/users/rwinch/following{/other_user}","gists_url":"https://api.github.com/users/rwinch/gists{/gist_id}","starred_url":"https://api.github.com/users/rwinch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwinch/subscriptions","organizations_url":"https://api.github.com/users/rwinch/orgs","repos_url":"https://api.github.com/users/rwinch/repos","events_url":"https://api.github.com/users/rwinch/events{/privacy}","received_events_url":"https://api.github.com/users/rwinch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwinch/spring-framework","description":"The Spring Framework","fork":true,"url":"https://api.github.com/repos/rwinch/spring-framework","forks_url":"https://api.github.com/repos/rwinch/spring-framework/forks","keys_url":"https://api.github.com/repos/rwinch/spring-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwinch/spring-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwinch/spring-framework/teams","hooks_url":"https://api.github.com/repos/rwinch/spring-framework/hooks","issue_events_url":"https://api.github.com/repos/rwinch/spring-framework/issues/events{/number}","events_url":"https://api.github.com/repos/rwinch/spring-framework/events","assignees_url":"https://api.github.com/repos/rwinch/spring-framework/assignees{/user}","branches_url":"https://api.github.com/repos/rwinch/spring-framework/branches{/branch}","tags_url":"https://api.github.com/repos/rwinch/spring-framework/tags","blobs_url":"https://api.github.com/repos/rwinch/spring-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwinch/spring-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwinch/spring-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwinch/spring-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwinch/spring-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/rwinch/spring-framework/languages","stargazers_url":"https://api.github.com/repos/rwinch/spring-framework/stargazers","contributors_url":"https://api.github.com/repos/rwinch/spring-framework/contributors","subscribers_url":"https://api.github.com/repos/rwinch/spring-framework/subscribers","subscription_url":"https://api.github.com/repos/rwinch/spring-framework/subscription","commits_url":"https://api.github.com/repos/rwinch/spring-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwinch/spring-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwinch/spring-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwinch/spring-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwinch/spring-framework/contents/{+path}","compare_url":"https://api.github.com/repos/rwinch/spring-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwinch/spring-framework/merges","archive_url":"https://api.github.com/repos/rwinch/spring-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwinch/spring-framework/downloads","issues_url":"https://api.github.com/repos/rwinch/spring-framework/issues{/number}","pulls_url":"https://api.github.com/repos/rwinch/spring-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/rwinch/spring-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/rwinch/spring-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwinch/spring-framework/labels{/name}","releases_url":"https://api.github.com/repos/rwinch/spring-framework/releases{/id}","created_at":"2012-07-09T23:47:22Z","updated_at":"2014-01-21T13:49:20Z","pushed_at":"2015-07-23T17:05:41Z","git_url":"git://github.com/rwinch/spring-framework.git","ssh_url":"git@github.com:rwinch/spring-framework.git","clone_url":"https://github.com/rwinch/spring-framework.git","svn_url":"https://github.com/rwinch/spring-framework","homepage":"http://springsource.org/spring-framework","size":88186,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"spring-projects:master","ref":"master","sha":"cd9b3903a743eb7656c41390a77b7be7c12f6a5f","user":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":1148753,"name":"spring-framework","full_name":"spring-projects/spring-framework","owner":{"login":"spring-projects","id":317776,"avatar_url":"https://avatars.githubusercontent.com/u/317776?v=3","gravatar_id":"","url":"https://api.github.com/users/spring-projects","html_url":"https://github.com/spring-projects","followers_url":"https://api.github.com/users/spring-projects/followers","following_url":"https://api.github.com/users/spring-projects/following{/other_user}","gists_url":"https://api.github.com/users/spring-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/spring-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spring-projects/subscriptions","organizations_url":"https://api.github.com/users/spring-projects/orgs","repos_url":"https://api.github.com/users/spring-projects/repos","events_url":"https://api.github.com/users/spring-projects/events{/privacy}","received_events_url":"https://api.github.com/users/spring-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spring-projects/spring-framework","description":"The Spring Framework","fork":false,"url":"https://api.github.com/repos/spring-projects/spring-framework","forks_url":"https://api.github.com/repos/spring-projects/spring-framework/forks","keys_url":"https://api.github.com/repos/spring-projects/spring-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spring-projects/spring-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spring-projects/spring-framework/teams","hooks_url":"https://api.github.com/repos/spring-projects/spring-framework/hooks","issue_events_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/events{/number}","events_url":"https://api.github.com/repos/spring-projects/spring-framework/events","assignees_url":"https://api.github.com/repos/spring-projects/spring-framework/assignees{/user}","branches_url":"https://api.github.com/repos/spring-projects/spring-framework/branches{/branch}","tags_url":"https://api.github.com/repos/spring-projects/spring-framework/tags","blobs_url":"https://api.github.com/repos/spring-projects/spring-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spring-projects/spring-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spring-projects/spring-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/spring-projects/spring-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spring-projects/spring-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/spring-projects/spring-framework/languages","stargazers_url":"https://api.github.com/repos/spring-projects/spring-framework/stargazers","contributors_url":"https://api.github.com/repos/spring-projects/spring-framework/contributors","subscribers_url":"https://api.github.com/repos/spring-projects/spring-framework/subscribers","subscription_url":"https://api.github.com/repos/spring-projects/spring-framework/subscription","commits_url":"https://api.github.com/repos/spring-projects/spring-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/spring-projects/spring-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/spring-projects/spring-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/spring-projects/spring-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/spring-projects/spring-framework/contents/{+path}","compare_url":"https://api.github.com/repos/spring-projects/spring-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spring-projects/spring-framework/merges","archive_url":"https://api.github.com/repos/spring-projects/spring-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spring-projects/spring-framework/downloads","issues_url":"https://api.github.com/repos/spring-projects/spring-framework/issues{/number}","pulls_url":"https://api.github.com/repos/spring-projects/spring-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/spring-projects/spring-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/spring-projects/spring-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spring-projects/spring-framework/labels{/name}","releases_url":"https://api.github.com/repos/spring-projects/spring-framework/releases{/id}","created_at":"2010-12-08T04:04:45Z","updated_at":"2015-10-27T17:37:31Z","pushed_at":"2015-10-27T14:11:00Z","git_url":"git://github.com/spring-projects/spring-framework.git","ssh_url":"git@github.com:spring-projects/spring-framework.git","clone_url":"https://github.com/spring-projects/spring-framework.git","svn_url":"https://github.com/spring-projects/spring-framework","homepage":"http://projects.spring.io/spring-framework","size":316168,"stargazers_count":6817,"watchers_count":6817,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":5843,"mirror_url":null,"open_issues_count":101,"forks":5843,"open_issues":101,"watchers":6817,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spring-projects/spring-framework/pulls/834"},"html":{"href":"https://github.com/spring-projects/spring-framework/pull/834"},"issue":{"href":"https://api.github.com/repos/spring-projects/spring-framework/issues/834"},"comments":{"href":"https://api.github.com/repos/spring-projects/spring-framework/issues/834/comments"},"review_comments":{"href":"https://api.github.com/repos/spring-projects/spring-framework/pulls/834/comments"},"review_comment":{"href":"https://api.github.com/repos/spring-projects/spring-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spring-projects/spring-framework/pulls/834/commits"},"statuses":{"href":"https://api.github.com/repos/spring-projects/spring-framework/statuses/e8047f20f864ae78ba41461d5a8e22a9c72b01e1"}},"merged":false,"mergeable":false,"mergeable_state":"dirty","merged_by":null,"comments":2,"review_comments":7,"commits":2,"additions":454,"deletions":16,"changed_files":11}}