{"comment":{"url":"https://api.github.com/repos/osu-mist/evals/comments/11273347","html_url":"https://github.com/osu-mist/evals/commit/315bd74ed0c57397c474c0b85746152134b4718a#commitcomment-11273347","id":11273347,"user":{"login":"browtayl","id":8976764,"avatar_url":"https://avatars.githubusercontent.com/u/8976764?v=3","gravatar_id":"","url":"https://api.github.com/users/browtayl","html_url":"https://github.com/browtayl","followers_url":"https://api.github.com/users/browtayl/followers","following_url":"https://api.github.com/users/browtayl/following{/other_user}","gists_url":"https://api.github.com/users/browtayl/gists{/gist_id}","starred_url":"https://api.github.com/users/browtayl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/browtayl/subscriptions","organizations_url":"https://api.github.com/users/browtayl/orgs","repos_url":"https://api.github.com/users/browtayl/repos","events_url":"https://api.github.com/users/browtayl/events{/privacy}","received_events_url":"https://api.github.com/users/browtayl/received_events","type":"User","site_admin":false},"position":5,"line":1040,"path":"docroot/WEB-INF/src/edu/osu/cws/evals/models/Appraisal.java","commit_id":"315bd74ed0c57397c474c0b85746152134b4718a","created_at":"2015-05-19T23:09:45Z","updated_at":"2015-05-19T23:09:45Z","body":"i interpret the following block to imply that \"the employee review due status _does not become overdue_ after due date\". i assume the logic for expiration is handled below.\r\n\r\nthe behavior of this method would be clearer if the multiple if/return blocks were combined somehow. looking at the code gives little assurance that all cases are handled appropriately.\r\n\r\ni looked at the javadoc to better understand this method but the return value is unspecified."}}