{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/33489056","id":33489056,"diff_hunk":"@@ -2676,7 +2675,7 @@ var ConversationView = {\n       return;\n     }\n \n-    if (!contacts || !contacts.length) {","path":"apps/sms/views/conversation/js/conversation.js","position":41,"original_position":41,"commit_id":"762767d53e34ab2908238ba38cdd953a71a8276f","original_commit_id":"762767d53e34ab2908238ba38cdd953a71a8276f","user":{"login":"anu7495","id":10097603,"avatar_url":"https://avatars.githubusercontent.com/u/10097603?v=3","gravatar_id":"","url":"https://api.github.com/users/anu7495","html_url":"https://github.com/anu7495","followers_url":"https://api.github.com/users/anu7495/followers","following_url":"https://api.github.com/users/anu7495/following{/other_user}","gists_url":"https://api.github.com/users/anu7495/gists{/gist_id}","starred_url":"https://api.github.com/users/anu7495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anu7495/subscriptions","organizations_url":"https://api.github.com/users/anu7495/orgs","repos_url":"https://api.github.com/users/anu7495/repos","events_url":"https://api.github.com/users/anu7495/events{/privacy}","received_events_url":"https://api.github.com/users/anu7495/received_events","type":"User","site_admin":false},"body":"I changed the return value to empty array for ConversationView.searchContact\r\nconversation_test.js  & conversation_integration_test.js give no errors after that.\r\nDo i need to check for somethings else? \r\n","created_at":"2015-06-29T17:29:02Z","updated_at":"2015-06-29T17:29:02Z","html_url":"https://github.com/mozilla-b2g/gaia/pull/30730#discussion_r33489056","pull_request_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments/33489056"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30730#discussion_r33489056"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730","id":38720081,"html_url":"https://github.com/mozilla-b2g/gaia/pull/30730","diff_url":"https://github.com/mozilla-b2g/gaia/pull/30730.diff","patch_url":"https://github.com/mozilla-b2g/gaia/pull/30730.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30730","number":30730,"state":"open","locked":false,"title":"Bug 1153888 - [Messages] Contacts.findBy and other Contacts.* functio…","user":{"login":"anu7495","id":10097603,"avatar_url":"https://avatars.githubusercontent.com/u/10097603?v=3","gravatar_id":"","url":"https://api.github.com/users/anu7495","html_url":"https://github.com/anu7495","followers_url":"https://api.github.com/users/anu7495/followers","following_url":"https://api.github.com/users/anu7495/following{/other_user}","gists_url":"https://api.github.com/users/anu7495/gists{/gist_id}","starred_url":"https://api.github.com/users/anu7495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anu7495/subscriptions","organizations_url":"https://api.github.com/users/anu7495/orgs","repos_url":"https://api.github.com/users/anu7495/repos","events_url":"https://api.github.com/users/anu7495/events{/privacy}","received_events_url":"https://api.github.com/users/anu7495/received_events","type":"User","site_admin":false},"body":"…ns should never return null r=anu7495","created_at":"2015-06-28T04:45:34Z","updated_at":"2015-06-29T17:29:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf9edf1b69c2a09610e5a005d6918e1398547f28","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30730/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/762767d53e34ab2908238ba38cdd953a71a8276f","head":{"label":"anu7495:my-code-fix","ref":"my-code-fix","sha":"762767d53e34ab2908238ba38cdd953a71a8276f","user":{"login":"anu7495","id":10097603,"avatar_url":"https://avatars.githubusercontent.com/u/10097603?v=3","gravatar_id":"","url":"https://api.github.com/users/anu7495","html_url":"https://github.com/anu7495","followers_url":"https://api.github.com/users/anu7495/followers","following_url":"https://api.github.com/users/anu7495/following{/other_user}","gists_url":"https://api.github.com/users/anu7495/gists{/gist_id}","starred_url":"https://api.github.com/users/anu7495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anu7495/subscriptions","organizations_url":"https://api.github.com/users/anu7495/orgs","repos_url":"https://api.github.com/users/anu7495/repos","events_url":"https://api.github.com/users/anu7495/events{/privacy}","received_events_url":"https://api.github.com/users/anu7495/received_events","type":"User","site_admin":false},"repo":{"id":37930343,"name":"gaia","full_name":"anu7495/gaia","owner":{"login":"anu7495","id":10097603,"avatar_url":"https://avatars.githubusercontent.com/u/10097603?v=3","gravatar_id":"","url":"https://api.github.com/users/anu7495","html_url":"https://github.com/anu7495","followers_url":"https://api.github.com/users/anu7495/followers","following_url":"https://api.github.com/users/anu7495/following{/other_user}","gists_url":"https://api.github.com/users/anu7495/gists{/gist_id}","starred_url":"https://api.github.com/users/anu7495/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anu7495/subscriptions","organizations_url":"https://api.github.com/users/anu7495/orgs","repos_url":"https://api.github.com/users/anu7495/repos","events_url":"https://api.github.com/users/anu7495/events{/privacy}","received_events_url":"https://api.github.com/users/anu7495/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/anu7495/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":true,"url":"https://api.github.com/repos/anu7495/gaia","forks_url":"https://api.github.com/repos/anu7495/gaia/forks","keys_url":"https://api.github.com/repos/anu7495/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anu7495/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anu7495/gaia/teams","hooks_url":"https://api.github.com/repos/anu7495/gaia/hooks","issue_events_url":"https://api.github.com/repos/anu7495/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/anu7495/gaia/events","assignees_url":"https://api.github.com/repos/anu7495/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/anu7495/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/anu7495/gaia/tags","blobs_url":"https://api.github.com/repos/anu7495/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anu7495/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anu7495/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/anu7495/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anu7495/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/anu7495/gaia/languages","stargazers_url":"https://api.github.com/repos/anu7495/gaia/stargazers","contributors_url":"https://api.github.com/repos/anu7495/gaia/contributors","subscribers_url":"https://api.github.com/repos/anu7495/gaia/subscribers","subscription_url":"https://api.github.com/repos/anu7495/gaia/subscription","commits_url":"https://api.github.com/repos/anu7495/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/anu7495/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/anu7495/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/anu7495/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/anu7495/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/anu7495/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anu7495/gaia/merges","archive_url":"https://api.github.com/repos/anu7495/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anu7495/gaia/downloads","issues_url":"https://api.github.com/repos/anu7495/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/anu7495/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/anu7495/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/anu7495/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anu7495/gaia/labels{/name}","releases_url":"https://api.github.com/repos/anu7495/gaia/releases{/id}","created_at":"2015-06-23T16:19:39Z","updated_at":"2015-06-23T16:20:10Z","pushed_at":"2015-06-28T04:43:55Z","git_url":"git://github.com/anu7495/gaia.git","ssh_url":"git@github.com:anu7495/gaia.git","clone_url":"https://github.com/anu7495/gaia.git","svn_url":"https://github.com/anu7495/gaia","homepage":"https://wiki.mozilla.org/B2G","size":939927,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"39b3989a5f4c0580642dd34d6a2c43cbfdb6b6c1","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":2317369,"name":"gaia","full_name":"mozilla-b2g/gaia","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/gaia","description":"Gaia is a HTML5-based Phone UI for the Boot 2 Gecko Project. NOTE: For details of what branches are used for what releases, see","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/gaia","forks_url":"https://api.github.com/repos/mozilla-b2g/gaia/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/gaia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/gaia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/gaia/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/gaia/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/gaia/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/gaia/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/gaia/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/gaia/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/gaia/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/gaia/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/gaia/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/gaia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/gaia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/gaia/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/gaia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/gaia/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/gaia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/gaia/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/gaia/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/gaia/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/gaia/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/gaia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/gaia/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/gaia/releases{/id}","created_at":"2011-09-03T01:38:46Z","updated_at":"2015-06-28T20:18:03Z","pushed_at":"2015-06-29T17:18:56Z","git_url":"git://github.com/mozilla-b2g/gaia.git","ssh_url":"git@github.com:mozilla-b2g/gaia.git","clone_url":"https://github.com/mozilla-b2g/gaia.git","svn_url":"https://github.com/mozilla-b2g/gaia","homepage":"https://wiki.mozilla.org/B2G","size":1645686,"stargazers_count":1947,"watchers_count":1947,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2358,"mirror_url":null,"open_issues_count":1047,"forks":2358,"open_issues":1047,"watchers":1947,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730"},"html":{"href":"https://github.com/mozilla-b2g/gaia/pull/30730"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30730"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/issues/30730/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/pulls/30730/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/gaia/statuses/762767d53e34ab2908238ba38cdd953a71a8276f"}}}}