{"push_id":640203550,"size":12,"distinct_size":12,"ref":"refs/heads/known_address_tests","head":"c0b57def7f716d5502bf514728f1bfdb97951f1b","before":"fa8f5d0b0819ad3a50b433f8b88e61d2af6448cb","commits":[{"sha":"5131b5e39057b28d8e7f58805dfd63b71fbe9cb7","author":{"email":"c3d3100ac1d259bc987fcc245095221cd7e91753@conformal.com","name":"Josh Rickmar"},"message":"Fix a typo.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/5131b5e39057b28d8e7f58805dfd63b71fbe9cb7"},{"sha":"de12e101e1c1b217f04a71854005729e9cfb586d","author":{"email":"c3d3100ac1d259bc987fcc245095221cd7e91753@conformal.com","name":"Josh Rickmar"},"message":"Fix typo and clean up comments for godoc.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/de12e101e1c1b217f04a71854005729e9cfb586d"},{"sha":"bec90e253c284f1692429d2e3c05fe586363c35e","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Remove unneeded param from NewScript.\n\nThis commit removes the unnecessary sigScript parameter from the\ntxscript.NewScript function.  This has bothered me for a while because it\ncan and really should be obtained from the provided transaction and input\nindex.  The way it was, the passed script could technically be different\nthan what is in the transaction.  Obviously that would be an improper use\nof the API, but it's safer and more convenient to simply pull it from the\nprovided transaction and index.\n\nAlso, since the function signature is changing anyways, make the input\nindex parameter come after the transaction which it references.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/bec90e253c284f1692429d2e3c05fe586363c35e"},{"sha":"0f8d90086acd68585b904bb5f8d718b4c316f370","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Separate reference tests into own file.\n\nThis commit separates the test functions and associated helper functions\nwhich are used to execute the reference transaction and script tests from\nBitcoin Core into a separate file named reference_test.go.\n\nAlso, add a few comments and fix a couple of typos along the way.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/0f8d90086acd68585b904bb5f8d718b4c316f370"},{"sha":"8dd7412a8469b2ebf768d85033b99bf339260336","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Rename Script to Engine.\n\nThis commit renames the Script type to Engine to better reflect its\npurpose.  It also renames the NewScript function to NewEngine to match.\n\nThis is being done because name Script for the engine is confusing since\nit implies it is an actual script rather than the execution environment\nfor the script.  It also paves the way for eventually supplying a\nParsedScript type which will be less likely to be confused with the\nexecution environment.\n\nWhile moving the code, some additional variable names and comments have\nbeen updated to better match the style used throughout the rest of the\ncode base.  In addition, an attempt has been made to use consistent naming\nof the engine as 'vm' instead of using different variables names as it was\npreviously.\n\nFinally, the relevant engine code has been moved into a new file named\nengine.go and related tests moved to engine_test.go.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/8dd7412a8469b2ebf768d85033b99bf339260336"},{"sha":"3fc244430933e69c079abd7c7f90d0be0d14fc6d","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Separate signing code.\n\nThis commit separate the transaction signing code into sign.go and the\nrelated tests into sign_test.go.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/3fc244430933e69c079abd7c7f90d0be0d14fc6d"},{"sha":"43c053bbfe03cbcc2b72bbad25853bdcfdd86fb9","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Move error definitions to error.go.\n\nThis is more consistent with the rest of the code base and also will make\nit easier to improve the errors to provide more details at a later date.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/43c053bbfe03cbcc2b72bbad25853bdcfdd86fb9"},{"sha":"0baac031295aaf8ee59b197fd10569145da444a3","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Store flags in instance versus bools.\n\nRather than storing a separate bool for whether or not each flag is set in\nevery script engine instance, store the flags and check if the relevant\nflag is set from each specific location.\n\nThis reduces the memory needed by each script engine instance and means\nfuture flags will not require new fields.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/0baac031295aaf8ee59b197fd10569145da444a3"},{"sha":"d6f2b092c0e45f004dd2c5e121c414263c71bea4","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Define opcodes in hex and sync BC opcodes.\n\nThis commit modifies the definition of the opcodes to their hex\ncounterparts rather than decimal since it is far more common to see\nscripts in hex.  This makes it easier when manually looking at script\ndumps to correlate opcodes.  However, since there are also cases where it\nis useful to see the decimal value of the opcode, the decimal value has\nbeen left as a comment.  Obviously converting the numbers is trivial, but\nit is handy when looking at the opcode definitions to already have it\nthere.\n\nIn addition, it syncs the opcodes with the latest Bitcoin Core internal\nopcodes for completeness and modifies the tests accordingly.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/d6f2b092c0e45f004dd2c5e121c414263c71bea4"},{"sha":"d251208f1fdba57cb78228555c80f8069529f669","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Convert opcode map to an array.\n\nThis commit converts the opcode map to an array to improve performance.\n\nBenchmark of executing a standard p2pk transaction:\n\nNew: BenchmarkExecute            2000            784349 ns/op\nOld: BenchmarkExecute            2000            792600 ns/op\n\nThe time is dominated by the signature checking as expected, however there\nis still an increase in speed.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/d251208f1fdba57cb78228555c80f8069529f669"},{"sha":"d66593bbfdba86e3e67273000b4c3f8b132a15b3","author":{"email":"40f085f3e2c05dc127b0a330228985d077d6c8f7@conformal.com","name":"Dave Collins"},"message":"txscript: Add exported opcode name to value map.\n\nThis commit exports a new map named OpcodeByName which can be used to\nlookup an opcode value given a human-readable opcode name.\n\nIt also modifies the test function which does short form parsing to use\nthe new map instead of the internal array.\n\nCloses #267.","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/d66593bbfdba86e3e67273000b4c3f8b132a15b3"},{"sha":"c0b57def7f716d5502bf514728f1bfdb97951f1b","author":{"email":"69237f2a5aa1faa7323b7a01e92590ca03d8cffc@thingobjectentity.net","name":"Daniel Krawisz"},"message":"Added tests for addrmgr.KnownAddress\n\nAdjusted tests in response to redefinition of KnownAddress.chance","distinct":true,"url":"https://api.github.com/repos/DanielKrawisz/btcd/commits/c0b57def7f716d5502bf514728f1bfdb97951f1b"}]}