{"action":"created","comment":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/45255665","id":45255665,"diff_hunk":"@@ -588,14 +614,46 @@ def test_default_confederation_peers\n     bgp.destroy\n   end\n \n-  def test_set_get_log_neighbor_changes\n-    skip(XR_SUPPORTED_BROKEN) if platform == :ios_xr\n-    %w(test_default test_vrf).each do |t|\n-      if t == 'test_default'\n-        bgp = setup_default\n+  def test_log_neighbor_changes_default\n+    log_neighbor_changes(setup_default)\n+  end\n+\n+  def test_log_neighbor_changes_vrf\n+    log_neighbor_changes(setup_vrf)\n+  end\n+\n+  def log_neighbor_changes(bgp)\n+    if platform == :ios_xr\n+      @device.cmd('term width 300')\n+      # Lets assert based on XR standard output if a command is not found\n+      pattern = 'No such configuration item'\n+\n+      if @vrf == 'default'\n+        vrf_str = ''\n       else\n-        bgp = setup_vrf\n+        vrf_str = \"vrf #{@vrf}\"\n       end\n+\n+      # Test default\n+      s = @device.cmd(\"show running-config router bgp #{@asnum} \" \\\n+                      \"#{vrf_str} bgp log neighbor changes disable\")\n+      assert_match(pattern, s,\n+                   'bgp log_neighbor_changes disable should not be enabled')\n+\n+      # Disable log neighbors\n+      bgp.log_neighbor_changes = false\n+      s = @device.cmd(\"show running-config router bgp #{@asnum} \" \\\n+                      \"#{vrf_str} bgp log neighbor changes disable\")\n+      refute_match(pattern, s,\n+                   'bgp log_neighbor_changes disable should be enabled')\n+\n+      # Enable log neighbors\n+      bgp.log_neighbor_changes = true\n+      s = @device.cmd(\"show running-config router bgp #{@asnum} \" \\\n+                      \"#{vrf_str} bgp log neighbor changes disable\")\n+      assert_match(pattern, s,\n+                   'bgp log_neighbor_changes disable should not be enabled')\n+    else\n       bgp.log_neighbor_changes = true\n       assert(bgp.log_neighbor_changes,","path":"tests/test_router_bgp.rb","position":154,"original_position":154,"commit_id":"297d1859bce0b26cb7a06678b9f9d96ca2eb02b9","original_commit_id":"297d1859bce0b26cb7a06678b9f9d96ca2eb02b9","user":{"login":"RichWellum","id":10466025,"avatar_url":"https://avatars.githubusercontent.com/u/10466025?v=3","gravatar_id":"","url":"https://api.github.com/users/RichWellum","html_url":"https://github.com/RichWellum","followers_url":"https://api.github.com/users/RichWellum/followers","following_url":"https://api.github.com/users/RichWellum/following{/other_user}","gists_url":"https://api.github.com/users/RichWellum/gists{/gist_id}","starred_url":"https://api.github.com/users/RichWellum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichWellum/subscriptions","organizations_url":"https://api.github.com/users/RichWellum/orgs","repos_url":"https://api.github.com/users/RichWellum/repos","events_url":"https://api.github.com/users/RichWellum/events{/privacy}","received_events_url":"https://api.github.com/users/RichWellum/received_events","type":"User","site_admin":false},"body":"And nexus is the reverse in these cases - doesn't check the running config? Curious if there is any recommendation - do both if applicable?","created_at":"2015-11-18T20:30:22Z","updated_at":"2015-11-18T20:30:22Z","html_url":"https://github.com/cisco/cisco-network-node-utils/pull/91#discussion_r45255665","pull_request_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91","_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments/45255665"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/91#discussion_r45255665"},"pull_request":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91","id":51018695,"html_url":"https://github.com/cisco/cisco-network-node-utils/pull/91","diff_url":"https://github.com/cisco/cisco-network-node-utils/pull/91.diff","patch_url":"https://github.com/cisco/cisco-network-node-utils/pull/91.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/91","number":91,"state":"open","locked":false,"title":"Feature/grpc bgp fin","user":{"login":"RichWellum","id":10466025,"avatar_url":"https://avatars.githubusercontent.com/u/10466025?v=3","gravatar_id":"","url":"https://api.github.com/users/RichWellum","html_url":"https://github.com/RichWellum","followers_url":"https://api.github.com/users/RichWellum/followers","following_url":"https://api.github.com/users/RichWellum/following{/other_user}","gists_url":"https://api.github.com/users/RichWellum/gists{/gist_id}","starred_url":"https://api.github.com/users/RichWellum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RichWellum/subscriptions","organizations_url":"https://api.github.com/users/RichWellum/orgs","repos_url":"https://api.github.com/users/RichWellum/repos","events_url":"https://api.github.com/users/RichWellum/events{/privacy}","received_events_url":"https://api.github.com/users/RichWellum/received_events","type":"User","site_admin":false},"body":"Node Utils for remaining missing BGP global properties - log neighbor changes and bgp keep alive timers.\r\n\r\nSome default mini tests failing due to recent changes - fixed those.\r\n\r\nRubocop happy on all ruby files.\r\n\r\nMinitest pass on NX and XR.\r\n\r\nApplied the below manifest and toggled the log_neighbor_changes property - verified that they were applied to my router and that they were omniwhatitsname.\r\n\r\n```puppet\r\nnode 'default' {\r\n  cisco_bgp { 'default_vrf_global':\r\n    ensure                                 => present,\r\n    asn                                    => 55,\r\n    vrf                                    => 'default',\r\n    router_id                              => '1.1.1.1',\r\n\r\n    confederation_id                       => '33',\r\n    cluster_id                             => '55',\r\n    graceful_restart_timers_restart        => '131',\r\n    graceful_restart_timers_stalepath_time => '311',\r\n    bestpath_med_confed                    => true,\r\n    graceful_restart => true,\r\n    enforce_first_as                       => true,\r\n    log_neighbor_changes                   => false,\r\n}\r\n  cisco_bgp { 'vrf_blue':\r\n    ensure                                 => present,\r\n    asn                                    => 55,\r\n    vrf                                    => 'blue',\r\n    router_id                              => '192.168.0.66',\r\n\r\n    # Best Path Properties\r\n    bestpath_always_compare_med            => true,\r\n    bestpath_aspath_multipath_relax        => true,\r\n    bestpath_compare_routerid              => true,\r\n    bestpath_cost_community_ignore         => true,\r\n\r\n    # Timer Properties\r\n    timer_bgp_keepalive                    => '46',\r\n    timer_bgp_holdtime                     => '111',\r\n\r\n    enforce_first_as                       => true,\r\n    log_neighbor_changes                   => false,\r\n    }\r\n  }\r\n```","created_at":"2015-11-17T23:04:17Z","updated_at":"2015-11-18T20:30:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"879b98329323d85a60ffa2ef20073abb43fa587c","assignee":{"login":"glennmatthews","id":5603551,"avatar_url":"https://avatars.githubusercontent.com/u/5603551?v=3","gravatar_id":"","url":"https://api.github.com/users/glennmatthews","html_url":"https://github.com/glennmatthews","followers_url":"https://api.github.com/users/glennmatthews/followers","following_url":"https://api.github.com/users/glennmatthews/following{/other_user}","gists_url":"https://api.github.com/users/glennmatthews/gists{/gist_id}","starred_url":"https://api.github.com/users/glennmatthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glennmatthews/subscriptions","organizations_url":"https://api.github.com/users/glennmatthews/orgs","repos_url":"https://api.github.com/users/glennmatthews/repos","events_url":"https://api.github.com/users/glennmatthews/events{/privacy}","received_events_url":"https://api.github.com/users/glennmatthews/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/91/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/297d1859bce0b26cb7a06678b9f9d96ca2eb02b9","head":{"label":"cisco:feature/grpc-bgp-fin","ref":"feature/grpc-bgp-fin","sha":"297d1859bce0b26cb7a06678b9f9d96ca2eb02b9","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-11-12T06:34:19Z","pushed_at":"2015-11-18T19:37:10Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":1886,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":7,"default_branch":"develop"}},"base":{"label":"cisco:feature/grpc","ref":"feature/grpc","sha":"8a9c7eda71cc634c03bc519d12f0ef32c00ded96","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565196,"name":"cisco-network-node-utils","full_name":"cisco/cisco-network-node-utils","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-node-utils","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-node-utils","forks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-node-utils/releases{/id}","created_at":"2015-07-23T12:07:39Z","updated_at":"2015-11-12T06:34:19Z","pushed_at":"2015-11-18T19:37:10Z","git_url":"git://github.com/cisco/cisco-network-node-utils.git","ssh_url":"git@github.com:cisco/cisco-network-node-utils.git","clone_url":"https://github.com/cisco/cisco-network-node-utils.git","svn_url":"https://github.com/cisco/cisco-network-node-utils","homepage":null,"size":1886,"stargazers_count":7,"watchers_count":7,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":6,"forks":23,"open_issues":6,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91"},"html":{"href":"https://github.com/cisco/cisco-network-node-utils/pull/91"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/91"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-node-utils/statuses/297d1859bce0b26cb7a06678b9f9d96ca2eb02b9"}}}}