{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/8069","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/8069/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/8069/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/8069/events","html_url":"https://github.com/xbmc/xbmc/pull/8069","id":106862561,"number":8069,"title":"[music] When adding a new music directory, ask the user about the con…","user":{"login":"Razzeee","id":5943908,"avatar_url":"https://avatars.githubusercontent.com/u/5943908?v=3","gravatar_id":"","url":"https://api.github.com/users/Razzeee","html_url":"https://github.com/Razzeee","followers_url":"https://api.github.com/users/Razzeee/followers","following_url":"https://api.github.com/users/Razzeee/following{/other_user}","gists_url":"https://api.github.com/users/Razzeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Razzeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Razzeee/subscriptions","organizations_url":"https://api.github.com/users/Razzeee/orgs","repos_url":"https://api.github.com/users/Razzeee/repos","events_url":"https://api.github.com/users/Razzeee/events{/privacy}","received_events_url":"https://api.github.com/users/Razzeee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/xbmc/xbmc/labels/Improvement","name":"Improvement","color":"0b02e1"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-09-16T20:57:50Z","updated_at":"2015-09-17T08:40:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/8069","html_url":"https://github.com/xbmc/xbmc/pull/8069","diff_url":"https://github.com/xbmc/xbmc/pull/8069.diff","patch_url":"https://github.com/xbmc/xbmc/pull/8069.patch"},"body":"…tent and if he wants to scan it\r\n\r\nhttps://github.com/xbmc/xbmc/pull/8048#issuecomment-140036382 is now obsolete.\r\n\r\nThis will show the GUIDialogContentSettings (scraper selection), when an user is adding a new directory as music source.\r\nOnly tested on windows so far, will need tests on all platforms, as I changed a bunch of path handling stuff.\r\n\r\nKind of technical details:\r\n- This converts VFS paths in the content table to absolute paths\r\n- Disables the context menu entry for genres and folders that might contain albums/artists (just set these when you setup the folders)\r\n- One central place for the GUIDialogContentSettings call handled like in the videodb\r\n- Users can now select at will if they want to use an artist or album scraper\r\n- After the scraper is set, it will ask if you want to scan"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/141006936","html_url":"https://github.com/xbmc/xbmc/pull/8069#issuecomment-141006936","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/8069","id":141006936,"user":{"login":"DaveTBlake","id":13371422,"avatar_url":"https://avatars.githubusercontent.com/u/13371422?v=3","gravatar_id":"","url":"https://api.github.com/users/DaveTBlake","html_url":"https://github.com/DaveTBlake","followers_url":"https://api.github.com/users/DaveTBlake/followers","following_url":"https://api.github.com/users/DaveTBlake/following{/other_user}","gists_url":"https://api.github.com/users/DaveTBlake/gists{/gist_id}","starred_url":"https://api.github.com/users/DaveTBlake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DaveTBlake/subscriptions","organizations_url":"https://api.github.com/users/DaveTBlake/orgs","repos_url":"https://api.github.com/users/DaveTBlake/repos","events_url":"https://api.github.com/users/DaveTBlake/events{/privacy}","received_events_url":"https://api.github.com/users/DaveTBlake/received_events","type":"User","site_admin":false},"created_at":"2015-09-17T08:40:12Z","updated_at":"2015-09-17T08:40:12Z","body":"@MartijnKaijser since my main use is music library, video I am happy to work from files/folders so have never tagged videos or scanned or scraped a video lib, I don't really understand I what making music behave like video entails. I know there is the wish to integrate music videos, but given the different nature of music I am not sure music users want the libraries to look the same.\r\n\r\nAll I am saying is have the ability to set the scraper on every source, but for ease (fewer button to press) just default to a default setting initially.\r\n\r\n>If the scraper misidentifies an artist/album then this needs to be solved and not by donig a lot of manual labour to not set content or change scraper for that albums. That's just plain wrong.\r\n\r\nHow does a user \"solve\" a misidentification? Initially you may not even notice that the scraper has run, deleted artists and replaced them with those of another album. Or it sticks you in an infinite loop because it can't find the album/artist (there is a PR to fix this longstanding bug).There are users that manually use sql to set the scraped date to stop the scraper all together. When scraping works it is invisible and wonderful, but when it doesn't it is a user nightmare that many can't even work around. That I plain wrong I agree, but untill we can be sure the scraper works 100% we have to leave users a way out."}}