{"action":"created","comment":{"url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments/48557694","id":48557694,"diff_hunk":"@@ -131,35 +132,63 @@ class scpr.ListenLive\n \n                         @_triton = obj\n \n-                        # is there an ad there for us?\n-                        if ad = obj?.VAST?.Ad?.InLine\n-                            # is there a preroll?\n-                            if (preroll = ad.Creatives?.Creative?[0]?.Linear) && !_timedOut\n-                                # yes... play it\n-                                media = preroll.MediaFiles.MediaFile.toString()\n-                                @player.jPlayer(\"setMedia\",mp3:media).jPlayer(\"play\")\n-\n-                                @_impressionURL = ad.Impression.toString()\n-\n-                            else\n-                                _playStream()\n-\n-                            # is there a visual?\n-                            if companions = ad.Creatives?.Creative?[1]?.CompanionAds?.Companion\n+                        class AdResponse","path":"app/assets/javascripts/listen_live.js.coffee","position":50,"original_position":50,"commit_id":"03615e87d641c417b4a14379dc30eb3757226ee6","original_commit_id":"03615e87d641c417b4a14379dc30eb3757226ee6","user":{"login":"ewr","id":204350,"avatar_url":"https://avatars.githubusercontent.com/u/204350?v=3","gravatar_id":"","url":"https://api.github.com/users/ewr","html_url":"https://github.com/ewr","followers_url":"https://api.github.com/users/ewr/followers","following_url":"https://api.github.com/users/ewr/following{/other_user}","gists_url":"https://api.github.com/users/ewr/gists{/gist_id}","starred_url":"https://api.github.com/users/ewr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ewr/subscriptions","organizations_url":"https://api.github.com/users/ewr/orgs","repos_url":"https://api.github.com/users/ewr/repos","events_url":"https://api.github.com/users/ewr/events{/privacy}","received_events_url":"https://api.github.com/users/ewr/received_events","type":"User","site_admin":false},"body":"This shouldn't be sitting in the middle of a function. It's fine to have it sit inside the ListenLive class.","created_at":"2015-12-29T17:59:59Z","updated_at":"2015-12-29T17:59:59Z","html_url":"https://github.com/SCPR/SCPRv4/pull/403#discussion_r48557694","pull_request_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403","_links":{"self":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments/48557694"},"html":{"href":"https://github.com/SCPR/SCPRv4/pull/403#discussion_r48557694"},"pull_request":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403"}}},"pull_request":{"url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403","id":54671336,"html_url":"https://github.com/SCPR/SCPRv4/pull/403","diff_url":"https://github.com/SCPR/SCPRv4/pull/403.diff","patch_url":"https://github.com/SCPR/SCPRv4/pull/403.patch","issue_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/403","number":403,"state":"open","locked":false,"title":"Add DAAST support to live stream","user":{"login":"Ravenstine","id":5193330,"avatar_url":"https://avatars.githubusercontent.com/u/5193330?v=3","gravatar_id":"","url":"https://api.github.com/users/Ravenstine","html_url":"https://github.com/Ravenstine","followers_url":"https://api.github.com/users/Ravenstine/followers","following_url":"https://api.github.com/users/Ravenstine/following{/other_user}","gists_url":"https://api.github.com/users/Ravenstine/gists{/gist_id}","starred_url":"https://api.github.com/users/Ravenstine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ravenstine/subscriptions","organizations_url":"https://api.github.com/users/Ravenstine/orgs","repos_url":"https://api.github.com/users/Ravenstine/repos","events_url":"https://api.github.com/users/Ravenstine/events{/privacy}","received_events_url":"https://api.github.com/users/Ravenstine/received_events","type":"User","site_admin":false},"body":"Issue #396 \r\n\r\nIntended to add support in the live stream code for both DAAST and VAST responses for preroll.\r\n\r\nNote that lines 117 - 119 are incorrect and that will be fixed soon.","created_at":"2015-12-28T17:41:39Z","updated_at":"2015-12-29T17:59:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab6d94d791dc2d00e54d8a9dc5ff8a3d6348304d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403/commits","review_comments_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403/comments","review_comment_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/403/comments","statuses_url":"https://api.github.com/repos/SCPR/SCPRv4/statuses/03615e87d641c417b4a14379dc30eb3757226ee6","head":{"label":"SCPR:daast","ref":"daast","sha":"03615e87d641c417b4a14379dc30eb3757226ee6","user":{"login":"SCPR","id":855010,"avatar_url":"https://avatars.githubusercontent.com/u/855010?v=3","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"repo":{"id":2558636,"name":"SCPRv4","full_name":"SCPR/SCPRv4","owner":{"login":"SCPR","id":855010,"avatar_url":"https://avatars.githubusercontent.com/u/855010?v=3","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SCPR/SCPRv4","description":"KPCC on Rails","fork":false,"url":"https://api.github.com/repos/SCPR/SCPRv4","forks_url":"https://api.github.com/repos/SCPR/SCPRv4/forks","keys_url":"https://api.github.com/repos/SCPR/SCPRv4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCPR/SCPRv4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCPR/SCPRv4/teams","hooks_url":"https://api.github.com/repos/SCPR/SCPRv4/hooks","issue_events_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/events{/number}","events_url":"https://api.github.com/repos/SCPR/SCPRv4/events","assignees_url":"https://api.github.com/repos/SCPR/SCPRv4/assignees{/user}","branches_url":"https://api.github.com/repos/SCPR/SCPRv4/branches{/branch}","tags_url":"https://api.github.com/repos/SCPR/SCPRv4/tags","blobs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCPR/SCPRv4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCPR/SCPRv4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCPR/SCPRv4/statuses/{sha}","languages_url":"https://api.github.com/repos/SCPR/SCPRv4/languages","stargazers_url":"https://api.github.com/repos/SCPR/SCPRv4/stargazers","contributors_url":"https://api.github.com/repos/SCPR/SCPRv4/contributors","subscribers_url":"https://api.github.com/repos/SCPR/SCPRv4/subscribers","subscription_url":"https://api.github.com/repos/SCPR/SCPRv4/subscription","commits_url":"https://api.github.com/repos/SCPR/SCPRv4/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCPR/SCPRv4/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCPR/SCPRv4/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCPR/SCPRv4/contents/{+path}","compare_url":"https://api.github.com/repos/SCPR/SCPRv4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCPR/SCPRv4/merges","archive_url":"https://api.github.com/repos/SCPR/SCPRv4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCPR/SCPRv4/downloads","issues_url":"https://api.github.com/repos/SCPR/SCPRv4/issues{/number}","pulls_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls{/number}","milestones_url":"https://api.github.com/repos/SCPR/SCPRv4/milestones{/number}","notifications_url":"https://api.github.com/repos/SCPR/SCPRv4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCPR/SCPRv4/labels{/name}","releases_url":"https://api.github.com/repos/SCPR/SCPRv4/releases{/id}","created_at":"2011-10-11T22:05:04Z","updated_at":"2015-10-09T09:57:46Z","pushed_at":"2015-12-28T23:26:41Z","git_url":"git://github.com/SCPR/SCPRv4.git","ssh_url":"git@github.com:SCPR/SCPRv4.git","clone_url":"https://github.com/SCPR/SCPRv4.git","svn_url":"https://github.com/SCPR/SCPRv4","homepage":"http://www.scpr.org","size":41287,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":24,"forks":5,"open_issues":24,"watchers":13,"default_branch":"master"}},"base":{"label":"SCPR:master","ref":"master","sha":"3bb73f1492212121d997b5f4ed578510b276b358","user":{"login":"SCPR","id":855010,"avatar_url":"https://avatars.githubusercontent.com/u/855010?v=3","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"repo":{"id":2558636,"name":"SCPRv4","full_name":"SCPR/SCPRv4","owner":{"login":"SCPR","id":855010,"avatar_url":"https://avatars.githubusercontent.com/u/855010?v=3","gravatar_id":"","url":"https://api.github.com/users/SCPR","html_url":"https://github.com/SCPR","followers_url":"https://api.github.com/users/SCPR/followers","following_url":"https://api.github.com/users/SCPR/following{/other_user}","gists_url":"https://api.github.com/users/SCPR/gists{/gist_id}","starred_url":"https://api.github.com/users/SCPR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SCPR/subscriptions","organizations_url":"https://api.github.com/users/SCPR/orgs","repos_url":"https://api.github.com/users/SCPR/repos","events_url":"https://api.github.com/users/SCPR/events{/privacy}","received_events_url":"https://api.github.com/users/SCPR/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SCPR/SCPRv4","description":"KPCC on Rails","fork":false,"url":"https://api.github.com/repos/SCPR/SCPRv4","forks_url":"https://api.github.com/repos/SCPR/SCPRv4/forks","keys_url":"https://api.github.com/repos/SCPR/SCPRv4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SCPR/SCPRv4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SCPR/SCPRv4/teams","hooks_url":"https://api.github.com/repos/SCPR/SCPRv4/hooks","issue_events_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/events{/number}","events_url":"https://api.github.com/repos/SCPR/SCPRv4/events","assignees_url":"https://api.github.com/repos/SCPR/SCPRv4/assignees{/user}","branches_url":"https://api.github.com/repos/SCPR/SCPRv4/branches{/branch}","tags_url":"https://api.github.com/repos/SCPR/SCPRv4/tags","blobs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SCPR/SCPRv4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SCPR/SCPRv4/git/refs{/sha}","trees_url":"https://api.github.com/repos/SCPR/SCPRv4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SCPR/SCPRv4/statuses/{sha}","languages_url":"https://api.github.com/repos/SCPR/SCPRv4/languages","stargazers_url":"https://api.github.com/repos/SCPR/SCPRv4/stargazers","contributors_url":"https://api.github.com/repos/SCPR/SCPRv4/contributors","subscribers_url":"https://api.github.com/repos/SCPR/SCPRv4/subscribers","subscription_url":"https://api.github.com/repos/SCPR/SCPRv4/subscription","commits_url":"https://api.github.com/repos/SCPR/SCPRv4/commits{/sha}","git_commits_url":"https://api.github.com/repos/SCPR/SCPRv4/git/commits{/sha}","comments_url":"https://api.github.com/repos/SCPR/SCPRv4/comments{/number}","issue_comment_url":"https://api.github.com/repos/SCPR/SCPRv4/issues/comments{/number}","contents_url":"https://api.github.com/repos/SCPR/SCPRv4/contents/{+path}","compare_url":"https://api.github.com/repos/SCPR/SCPRv4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SCPR/SCPRv4/merges","archive_url":"https://api.github.com/repos/SCPR/SCPRv4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SCPR/SCPRv4/downloads","issues_url":"https://api.github.com/repos/SCPR/SCPRv4/issues{/number}","pulls_url":"https://api.github.com/repos/SCPR/SCPRv4/pulls{/number}","milestones_url":"https://api.github.com/repos/SCPR/SCPRv4/milestones{/number}","notifications_url":"https://api.github.com/repos/SCPR/SCPRv4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SCPR/SCPRv4/labels{/name}","releases_url":"https://api.github.com/repos/SCPR/SCPRv4/releases{/id}","created_at":"2011-10-11T22:05:04Z","updated_at":"2015-10-09T09:57:46Z","pushed_at":"2015-12-28T23:26:41Z","git_url":"git://github.com/SCPR/SCPRv4.git","ssh_url":"git@github.com:SCPR/SCPRv4.git","clone_url":"https://github.com/SCPR/SCPRv4.git","svn_url":"https://github.com/SCPR/SCPRv4","homepage":"http://www.scpr.org","size":41287,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":24,"forks":5,"open_issues":24,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403"},"html":{"href":"https://github.com/SCPR/SCPRv4/pull/403"},"issue":{"href":"https://api.github.com/repos/SCPR/SCPRv4/issues/403"},"comments":{"href":"https://api.github.com/repos/SCPR/SCPRv4/issues/403/comments"},"review_comments":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403/comments"},"review_comment":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SCPR/SCPRv4/pulls/403/commits"},"statuses":{"href":"https://api.github.com/repos/SCPR/SCPRv4/statuses/03615e87d641c417b4a14379dc30eb3757226ee6"}}}}