{"action":"created","issue":{"url":"https://api.github.com/repos/atom/find-and-replace/issues/420","labels_url":"https://api.github.com/repos/atom/find-and-replace/issues/420/labels{/name}","comments_url":"https://api.github.com/repos/atom/find-and-replace/issues/420/comments","events_url":"https://api.github.com/repos/atom/find-and-replace/issues/420/events","html_url":"https://github.com/atom/find-and-replace/pull/420","id":91722448,"number":420,"title":"Implemented optional regular expressions for path field in project search","user":{"login":"kylegoetz","id":8161573,"avatar_url":"https://avatars.githubusercontent.com/u/8161573?v=3","gravatar_id":"","url":"https://api.github.com/users/kylegoetz","html_url":"https://github.com/kylegoetz","followers_url":"https://api.github.com/users/kylegoetz/followers","following_url":"https://api.github.com/users/kylegoetz/following{/other_user}","gists_url":"https://api.github.com/users/kylegoetz/gists{/gist_id}","starred_url":"https://api.github.com/users/kylegoetz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylegoetz/subscriptions","organizations_url":"https://api.github.com/users/kylegoetz/orgs","repos_url":"https://api.github.com/users/kylegoetz/repos","events_url":"https://api.github.com/users/kylegoetz/events{/privacy}","received_events_url":"https://api.github.com/users/kylegoetz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/atom/find-and-replace/labels/needs-review","name":"needs-review","color":"bfe5bf"},{"url":"https://api.github.com/repos/atom/find-and-replace/labels/requires-changes","name":"requires-changes","color":"fef2c0"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-29T07:26:03Z","updated_at":"2015-08-07T00:47:15Z","closed_at":"2015-08-07T00:47:15Z","pull_request":{"url":"https://api.github.com/repos/atom/find-and-replace/pulls/420","html_url":"https://github.com/atom/find-and-replace/pull/420","diff_url":"https://github.com/atom/find-and-replace/pull/420.diff","patch_url":"https://github.com/atom/find-and-replace/pull/420.patch"},"body":"When you do project search, now there is a regular expressions toggle button for the path field. It behaves as before with the button disabled, but with it enabled, it does a JavaScript RegExp.test to evaluate of the regex is contained in the path.\r\n\r\nAs of now, the flow is as follows:\r\n\r\n1. perform scan as implemented in main branch (if regexp is turned on for path, then treat the path field as empty)\r\n2. once results roll in, test path for conformity with regexp if turned on, and add to results if the path contains the regular expression\r\n\r\nThe code could be sped up by altering atom.workspace.scan to receive the path regular expression, but this was a faster and more contained way for me to add the much-requested regular expression support to path field in project search. If scan() were modified, then it would build a directory list to scan that only included things that passed the path regexp test. For now, it scans every path and only after finding results does it test for conformity with regexp.\r\n\r\nAll that being said, for the team working just on find-and-replace, this is a self-contained solution."},"comment":{"url":"https://api.github.com/repos/atom/find-and-replace/issues/comments/128550829","html_url":"https://github.com/atom/find-and-replace/pull/420#issuecomment-128550829","issue_url":"https://api.github.com/repos/atom/find-and-replace/issues/420","id":128550829,"user":{"login":"benogle","id":69169,"avatar_url":"https://avatars.githubusercontent.com/u/69169?v=3","gravatar_id":"","url":"https://api.github.com/users/benogle","html_url":"https://github.com/benogle","followers_url":"https://api.github.com/users/benogle/followers","following_url":"https://api.github.com/users/benogle/following{/other_user}","gists_url":"https://api.github.com/users/benogle/gists{/gist_id}","starred_url":"https://api.github.com/users/benogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benogle/subscriptions","organizations_url":"https://api.github.com/users/benogle/orgs","repos_url":"https://api.github.com/users/benogle/repos","events_url":"https://api.github.com/users/benogle/events{/privacy}","received_events_url":"https://api.github.com/users/benogle/received_events","type":"User","site_admin":true},"created_at":"2015-08-07T00:47:15Z","updated_at":"2015-08-07T00:47:15Z","body":"Closing this as we should only support one type of globbing syntax."}}