{"action":"closed","issue":{"url":"https://api.github.com/repos/borgbackup/borg/issues/391","labels_url":"https://api.github.com/repos/borgbackup/borg/issues/391/labels{/name}","comments_url":"https://api.github.com/repos/borgbackup/borg/issues/391/comments","events_url":"https://api.github.com/repos/borgbackup/borg/issues/391/events","html_url":"https://github.com/borgbackup/borg/issues/391","id":115743223,"number":391,"title":"compiler warnings","user":{"login":"ThomasWaldmann","id":356103,"avatar_url":"https://avatars.githubusercontent.com/u/356103?v=3","gravatar_id":"","url":"https://api.github.com/users/ThomasWaldmann","html_url":"https://github.com/ThomasWaldmann","followers_url":"https://api.github.com/users/ThomasWaldmann/followers","following_url":"https://api.github.com/users/ThomasWaldmann/following{/other_user}","gists_url":"https://api.github.com/users/ThomasWaldmann/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasWaldmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasWaldmann/subscriptions","organizations_url":"https://api.github.com/users/ThomasWaldmann/orgs","repos_url":"https://api.github.com/users/ThomasWaldmann/repos","events_url":"https://api.github.com/users/ThomasWaldmann/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasWaldmann/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/borgbackup/borg/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-11-08T16:33:55Z","updated_at":"2015-11-22T13:15:24Z","closed_at":"2015-11-22T13:15:24Z","body":"Some likely harmless compiler warnings, but nevertheless, we should try to avoid them:\r\n```\r\n    building 'borg.compress' extension\r\n    gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/usr/include -I/usr/include -I/usr/local/include/python3.5m -c borg/compress.c -o build/temp.linux-x86_64-3.5/borg/compress.o\r\n    gcc -pthread -shared build/temp.linux-x86_64-3.5/borg/compress.o -L/usr/lib -L/usr/lib -llz4 -o build/lib.linux-x86_64-3.5/borg/compress.cpython-35m-x86_64-linux-gnu.so\r\n    building 'borg.crypto' extension\r\n    gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/usr/include -I/usr/include -I/usr/local/include/python3.5m -c borg/crypto.c -o build/temp.linux-x86_64-3.5/borg/crypto.o\r\n    gcc -pthread -shared build/temp.linux-x86_64-3.5/borg/crypto.o -L/usr/lib -L/usr/lib -lcrypto -o build/lib.linux-x86_64-3.5/borg/crypto.cpython-35m-x86_64-linux-gnu.so\r\n    building 'borg.chunker' extension\r\n    gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/usr/local/include/python3.5m -c borg/chunker.c -o build/temp.linux-x86_64-3.5/borg/chunker.o\r\n    In file included from borg/chunker.c:241:0:\r\n    borg/_chunker.c: In function ‘chunker_process’:\r\n    borg/_chunker.c:237:24: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n         while(c->remaining > c->window_size && ((sum & chunk_mask) || n < min_size)) {\r\n                            ^\r\n    borg/_chunker.c:237:69: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n         while(c->remaining > c->window_size && ((sum & chunk_mask) || n < min_size)) {\r\n                                                                         ^\r\n    gcc -pthread -shared build/temp.linux-x86_64-3.5/borg/chunker.o -o build/lib.linux-x86_64-3.5/borg/chunker.cpython-35m-x86_64-linux-gnu.so\r\n    building 'borg.hashindex' extension\r\n    gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/usr/local/include/python3.5m -c borg/hashindex.c -o build/temp.linux-x86_64-3.5/borg/hashindex.o\r\n    In file included from borg/hashindex.c:239:0:\r\n    borg/_hashindex.c: In function ‘hashindex_read’:\r\n    borg/_hashindex.c:174:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n         if(length != sizeof(HashHeader) + buckets_length) {\r\n                   ^\r\n    borg/_hashindex.c: In function ‘hashindex_write’:\r\n    borg/_hashindex.c:278:54: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]\r\n         if(fwrite(index->buckets, 1, buckets_length, fd) != buckets_length) {\r\n                                                          ^\r\n    gcc -pthread -shared build/temp.linux-x86_64-3.5/borg/hashindex.o -o build/lib.linux-x86_64-3.5/borg/hashindex.cpython-35m-x86_64-linux-gnu.so\r\n    building 'borg.platform_linux' extension\r\n    gcc -pthread -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -Wstrict-prototypes -fPIC -I/usr/local/include/python3.5m -c borg/platform_linux.c -o build/temp.linux-x86_64-3.5/borg/platform_linux.o\r\n    gcc -pthread -shared build/temp.linux-x86_64-3.5/borg/platform_linux.o -lacl -o build/lib.linux-x86_64-3.5/borg/platform_linux.cpython-35m-x86_64-linux-gnu.so\r\n```"}}