{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/1527","labels_url":"https://api.github.com/repos/uProxy/uproxy/issues/1527/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy/issues/1527/comments","events_url":"https://api.github.com/repos/uProxy/uproxy/issues/1527/events","html_url":"https://github.com/uProxy/uproxy/pull/1527","id":75717705,"number":1527,"title":"Advanced settings panel","user":{"login":"jsarapata","id":10854798,"avatar_url":"https://avatars.githubusercontent.com/u/10854798?v=3","gravatar_id":"","url":"https://api.github.com/users/jsarapata","html_url":"https://github.com/jsarapata","followers_url":"https://api.github.com/users/jsarapata/followers","following_url":"https://api.github.com/users/jsarapata/following{/other_user}","gists_url":"https://api.github.com/users/jsarapata/gists{/gist_id}","starred_url":"https://api.github.com/users/jsarapata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsarapata/subscriptions","organizations_url":"https://api.github.com/users/jsarapata/orgs","repos_url":"https://api.github.com/users/jsarapata/repos","events_url":"https://api.github.com/users/jsarapata/events{/privacy}","received_events_url":"https://api.github.com/users/jsarapata/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-05-12T19:51:53Z","updated_at":"2015-05-15T15:03:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy/pulls/1527","html_url":"https://github.com/uProxy/uproxy/pull/1527","diff_url":"https://github.com/uProxy/uproxy/pull/1527.diff","patch_url":"https://github.com/uProxy/uproxy/pull/1527.patch"},"body":"This change allows setting the console filtering level in both Firefox and Chrome to address Issue #1369. More specifically, the changes include:\r\n1) Adding a consoleFilter field to our global settings, propagating it, and making it active.\r\n2) Creating an advanced settings panel that gives full ability to edit the JSON of our global settings.\r\n3) Removing the STUN server settings and advanced setting pane in our basic settings. These are subsumed by the advanced settings pane, which will come up when you click on advanced settings.\r\n4) As long as I was editing settings.html, I replaced \" by ' everywhere.\r\n5) As long as I was editing uproxy_core_api.ts, I moved some type definitions to uProxy coding standards by removing the space in ': <type>'\r\n\r\nThere are a couple issues with the code.\r\n1) The advanced settings panel comes up fine, but if you edit the text block at all, an extraneous scrollbar appears on the entire panel. If anybody knows how to fix this, I'd be grateful.\r\n2) I'm not sure if this gets saved or if we we need a Restore Factory Settings capability.\r\n\r\nThe basic screen is:\r\n![image](https://cloud.githubusercontent.com/assets/10854798/7596921/6d168cb6-f8be-11e4-8e24-5062d2ec8943.png)\r\n\r\nAfter you set the text, it looks like(notice the extra scrollbar): \r\n![image](https://cloud.githubusercontent.com/assets/10854798/7596942/910fb1d8-f8be-11e4-8977-693c34b85115.png)\r\n\r\nIf you try entering bad JSON:\r\n![image](https://cloud.githubusercontent.com/assets/10854798/7596969/c47248b0-f8be-11e4-9ddb-b24577597324.png)\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy/1527)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy/issues/comments/102424060","html_url":"https://github.com/uProxy/uproxy/pull/1527#issuecomment-102424060","issue_url":"https://api.github.com/repos/uProxy/uproxy/issues/1527","id":102424060,"user":{"login":"jsarapata","id":10854798,"avatar_url":"https://avatars.githubusercontent.com/u/10854798?v=3","gravatar_id":"","url":"https://api.github.com/users/jsarapata","html_url":"https://github.com/jsarapata","followers_url":"https://api.github.com/users/jsarapata/followers","following_url":"https://api.github.com/users/jsarapata/following{/other_user}","gists_url":"https://api.github.com/users/jsarapata/gists{/gist_id}","starred_url":"https://api.github.com/users/jsarapata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsarapata/subscriptions","organizations_url":"https://api.github.com/users/jsarapata/orgs","repos_url":"https://api.github.com/users/jsarapata/repos","events_url":"https://api.github.com/users/jsarapata/events{/privacy}","received_events_url":"https://api.github.com/users/jsarapata/received_events","type":"User","site_admin":false},"created_at":"2015-05-15T15:03:57Z","updated_at":"2015-05-15T15:03:57Z","body":"@jpevarnek, mainly because I didn't consider that people would resize the uProxy window. I futzed around with flex and couldn't get anything that behaved reasonably. I think this is a combination of my lack of CSS experience, and paper-autogrow-textarea being flaky. In particular, it doesn't create the mirror area until you type in the box, and the mirror area seems to be pretty flaky.\r\n\r\nAssuming you don't mind, I am reverting to 'overflow: auto' and will file a separate bug against both feedback and advanced settings. My reasons are that it is primarily cosmetic, effects both components, and will probably take an hour or two of play, along with filing possible bugs against Polymer."}}