{"action":"created","comment":{"url":"https://api.github.com/repos/strands-project/strands_executive/pulls/comments/27177076","id":27177076,"diff_hunk":"@@ -49,7 +45,7 @@ def execute(self, goal):\n         rospy.loginfo(\"target wait time: %s\" % datetime.fromtimestamp(target.secs))\t\n \n         # how often to provide feedback \n-        feedback_secs = 5\n+        feedback_secs = 5.0","path":"wait_action/scripts/wait_node.py","position":49,"original_position":49,"commit_id":"084382563fe8c411b862aabae1fdbf36abaddb09","original_commit_id":"084382563fe8c411b862aabae1fdbf36abaddb09","user":{"login":"marc-hanheide","id":1153084,"avatar_url":"https://avatars.githubusercontent.com/u/1153084?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-hanheide","html_url":"https://github.com/marc-hanheide","followers_url":"https://api.github.com/users/marc-hanheide/followers","following_url":"https://api.github.com/users/marc-hanheide/following{/other_user}","gists_url":"https://api.github.com/users/marc-hanheide/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-hanheide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-hanheide/subscriptions","organizations_url":"https://api.github.com/users/marc-hanheide/orgs","repos_url":"https://api.github.com/users/marc-hanheide/repos","events_url":"https://api.github.com/users/marc-hanheide/events{/privacy}","received_events_url":"https://api.github.com/users/marc-hanheide/received_events","type":"User","site_admin":false},"body":"there was a div by zero for short durations. This fixes it.","created_at":"2015-03-25T23:34:46Z","updated_at":"2015-03-25T23:34:46Z","html_url":"https://github.com/strands-project/strands_executive/pull/141#discussion_r27177076","pull_request_url":"https://api.github.com/repos/strands-project/strands_executive/pulls/141","_links":{"self":{"href":"https://api.github.com/repos/strands-project/strands_executive/pulls/comments/27177076"},"html":{"href":"https://github.com/strands-project/strands_executive/pull/141#discussion_r27177076"},"pull_request":{"href":"https://api.github.com/repos/strands-project/strands_executive/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/strands-project/strands_executive/pulls/141","id":31976730,"html_url":"https://github.com/strands-project/strands_executive/pull/141","diff_url":"https://github.com/strands-project/strands_executive/pull/141.diff","patch_url":"https://github.com/strands-project/strands_executive/pull/141.patch","issue_url":"https://api.github.com/repos/strands-project/strands_executive/issues/141","number":141,"state":"open","locked":false,"title":"Abstract task","user":{"login":"marc-hanheide","id":1153084,"avatar_url":"https://avatars.githubusercontent.com/u/1153084?v=3","gravatar_id":"","url":"https://api.github.com/users/marc-hanheide","html_url":"https://github.com/marc-hanheide","followers_url":"https://api.github.com/users/marc-hanheide/followers","following_url":"https://api.github.com/users/marc-hanheide/following{/other_user}","gists_url":"https://api.github.com/users/marc-hanheide/gists{/gist_id}","starred_url":"https://api.github.com/users/marc-hanheide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc-hanheide/subscriptions","organizations_url":"https://api.github.com/users/marc-hanheide/orgs","repos_url":"https://api.github.com/users/marc-hanheide/repos","events_url":"https://api.github.com/users/marc-hanheide/events{/privacy}","received_events_url":"https://api.github.com/users/marc-hanheide/received_events","type":"User","site_admin":false},"body":"This is adding a new class `AbstractTaskServer` that other actionlib servers that implement schedulable tasks *should* use. The rationale is that the abstract class also offers an `<actionname>_create` service that routines can call to create a suitable `Task` object. So it offer a factory service. The idea here is that for instance the `gcal_routine` can then call this factory to automatically create a suitable task object just from a given name. The task objects created by the factory service should have all fields populated with useful defaults, so that in most cases on can simply send this to the `task_executor`. \r\nI have refactored `wait_action` to actually use the new base class. Another nice side effect of this is that it also make sure that the correct `<actionname>_interuptible` service is made available. \r\n\r\nPlease @hawesie let me know what you think and if this is acceptable.","created_at":"2015-03-25T23:32:49Z","updated_at":"2015-03-25T23:34:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1753599e5106d7d7a9edd5d698771e4b7091d325","assignee":{"login":"hawesie","id":927289,"avatar_url":"https://avatars.githubusercontent.com/u/927289?v=3","gravatar_id":"","url":"https://api.github.com/users/hawesie","html_url":"https://github.com/hawesie","followers_url":"https://api.github.com/users/hawesie/followers","following_url":"https://api.github.com/users/hawesie/following{/other_user}","gists_url":"https://api.github.com/users/hawesie/gists{/gist_id}","starred_url":"https://api.github.com/users/hawesie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hawesie/subscriptions","organizations_url":"https://api.github.com/users/hawesie/orgs","repos_url":"https://api.github.com/users/hawesie/repos","events_url":"https://api.github.com/users/hawesie/events{/privacy}","received_events_url":"https://api.github.com/users/hawesie/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/strands-project/strands_executive/pulls/141/commits","review_comments_url":"https://api.github.com/repos/strands-project/strands_executive/pulls/141/comments","review_comment_url":"https://api.github.com/repos/strands-project/strands_executive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strands-project/strands_executive/issues/141/comments","statuses_url":"https://api.github.com/repos/strands-project/strands_executive/statuses/084382563fe8c411b862aabae1fdbf36abaddb09","head":{"label":"strands-project:abstract_task","ref":"abstract_task","sha":"084382563fe8c411b862aabae1fdbf36abaddb09","user":{"login":"strands-project","id":3989374,"avatar_url":"https://avatars.githubusercontent.com/u/3989374?v=3","gravatar_id":"","url":"https://api.github.com/users/strands-project","html_url":"https://github.com/strands-project","followers_url":"https://api.github.com/users/strands-project/followers","following_url":"https://api.github.com/users/strands-project/following{/other_user}","gists_url":"https://api.github.com/users/strands-project/gists{/gist_id}","starred_url":"https://api.github.com/users/strands-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strands-project/subscriptions","organizations_url":"https://api.github.com/users/strands-project/orgs","repos_url":"https://api.github.com/users/strands-project/repos","events_url":"https://api.github.com/users/strands-project/events{/privacy}","received_events_url":"https://api.github.com/users/strands-project/received_events","type":"Organization","site_admin":false},"repo":{"id":16800584,"name":"strands_executive","full_name":"strands-project/strands_executive","owner":{"login":"strands-project","id":3989374,"avatar_url":"https://avatars.githubusercontent.com/u/3989374?v=3","gravatar_id":"","url":"https://api.github.com/users/strands-project","html_url":"https://github.com/strands-project","followers_url":"https://api.github.com/users/strands-project/followers","following_url":"https://api.github.com/users/strands-project/following{/other_user}","gists_url":"https://api.github.com/users/strands-project/gists{/gist_id}","starred_url":"https://api.github.com/users/strands-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strands-project/subscriptions","organizations_url":"https://api.github.com/users/strands-project/orgs","repos_url":"https://api.github.com/users/strands-project/repos","events_url":"https://api.github.com/users/strands-project/events{/privacy}","received_events_url":"https://api.github.com/users/strands-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strands-project/strands_executive","description":"Executive control code for STRANDS robots.","fork":false,"url":"https://api.github.com/repos/strands-project/strands_executive","forks_url":"https://api.github.com/repos/strands-project/strands_executive/forks","keys_url":"https://api.github.com/repos/strands-project/strands_executive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strands-project/strands_executive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strands-project/strands_executive/teams","hooks_url":"https://api.github.com/repos/strands-project/strands_executive/hooks","issue_events_url":"https://api.github.com/repos/strands-project/strands_executive/issues/events{/number}","events_url":"https://api.github.com/repos/strands-project/strands_executive/events","assignees_url":"https://api.github.com/repos/strands-project/strands_executive/assignees{/user}","branches_url":"https://api.github.com/repos/strands-project/strands_executive/branches{/branch}","tags_url":"https://api.github.com/repos/strands-project/strands_executive/tags","blobs_url":"https://api.github.com/repos/strands-project/strands_executive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strands-project/strands_executive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strands-project/strands_executive/git/refs{/sha}","trees_url":"https://api.github.com/repos/strands-project/strands_executive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strands-project/strands_executive/statuses/{sha}","languages_url":"https://api.github.com/repos/strands-project/strands_executive/languages","stargazers_url":"https://api.github.com/repos/strands-project/strands_executive/stargazers","contributors_url":"https://api.github.com/repos/strands-project/strands_executive/contributors","subscribers_url":"https://api.github.com/repos/strands-project/strands_executive/subscribers","subscription_url":"https://api.github.com/repos/strands-project/strands_executive/subscription","commits_url":"https://api.github.com/repos/strands-project/strands_executive/commits{/sha}","git_commits_url":"https://api.github.com/repos/strands-project/strands_executive/git/commits{/sha}","comments_url":"https://api.github.com/repos/strands-project/strands_executive/comments{/number}","issue_comment_url":"https://api.github.com/repos/strands-project/strands_executive/issues/comments{/number}","contents_url":"https://api.github.com/repos/strands-project/strands_executive/contents/{+path}","compare_url":"https://api.github.com/repos/strands-project/strands_executive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strands-project/strands_executive/merges","archive_url":"https://api.github.com/repos/strands-project/strands_executive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strands-project/strands_executive/downloads","issues_url":"https://api.github.com/repos/strands-project/strands_executive/issues{/number}","pulls_url":"https://api.github.com/repos/strands-project/strands_executive/pulls{/number}","milestones_url":"https://api.github.com/repos/strands-project/strands_executive/milestones{/number}","notifications_url":"https://api.github.com/repos/strands-project/strands_executive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strands-project/strands_executive/labels{/name}","releases_url":"https://api.github.com/repos/strands-project/strands_executive/releases{/id}","created_at":"2014-02-13T11:18:02Z","updated_at":"2015-03-23T23:55:59Z","pushed_at":"2015-03-25T23:32:50Z","git_url":"git://github.com/strands-project/strands_executive.git","ssh_url":"git@github.com:strands-project/strands_executive.git","clone_url":"https://github.com/strands-project/strands_executive.git","svn_url":"https://github.com/strands-project/strands_executive","homepage":null,"size":18843,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":18,"forks":9,"open_issues":18,"watchers":0,"default_branch":"hydro-release"}},"base":{"label":"strands-project:hydro-release","ref":"hydro-release","sha":"012724449326f5e5fc25c90bd025e8919a0508f7","user":{"login":"strands-project","id":3989374,"avatar_url":"https://avatars.githubusercontent.com/u/3989374?v=3","gravatar_id":"","url":"https://api.github.com/users/strands-project","html_url":"https://github.com/strands-project","followers_url":"https://api.github.com/users/strands-project/followers","following_url":"https://api.github.com/users/strands-project/following{/other_user}","gists_url":"https://api.github.com/users/strands-project/gists{/gist_id}","starred_url":"https://api.github.com/users/strands-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strands-project/subscriptions","organizations_url":"https://api.github.com/users/strands-project/orgs","repos_url":"https://api.github.com/users/strands-project/repos","events_url":"https://api.github.com/users/strands-project/events{/privacy}","received_events_url":"https://api.github.com/users/strands-project/received_events","type":"Organization","site_admin":false},"repo":{"id":16800584,"name":"strands_executive","full_name":"strands-project/strands_executive","owner":{"login":"strands-project","id":3989374,"avatar_url":"https://avatars.githubusercontent.com/u/3989374?v=3","gravatar_id":"","url":"https://api.github.com/users/strands-project","html_url":"https://github.com/strands-project","followers_url":"https://api.github.com/users/strands-project/followers","following_url":"https://api.github.com/users/strands-project/following{/other_user}","gists_url":"https://api.github.com/users/strands-project/gists{/gist_id}","starred_url":"https://api.github.com/users/strands-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strands-project/subscriptions","organizations_url":"https://api.github.com/users/strands-project/orgs","repos_url":"https://api.github.com/users/strands-project/repos","events_url":"https://api.github.com/users/strands-project/events{/privacy}","received_events_url":"https://api.github.com/users/strands-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strands-project/strands_executive","description":"Executive control code for STRANDS robots.","fork":false,"url":"https://api.github.com/repos/strands-project/strands_executive","forks_url":"https://api.github.com/repos/strands-project/strands_executive/forks","keys_url":"https://api.github.com/repos/strands-project/strands_executive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strands-project/strands_executive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strands-project/strands_executive/teams","hooks_url":"https://api.github.com/repos/strands-project/strands_executive/hooks","issue_events_url":"https://api.github.com/repos/strands-project/strands_executive/issues/events{/number}","events_url":"https://api.github.com/repos/strands-project/strands_executive/events","assignees_url":"https://api.github.com/repos/strands-project/strands_executive/assignees{/user}","branches_url":"https://api.github.com/repos/strands-project/strands_executive/branches{/branch}","tags_url":"https://api.github.com/repos/strands-project/strands_executive/tags","blobs_url":"https://api.github.com/repos/strands-project/strands_executive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strands-project/strands_executive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strands-project/strands_executive/git/refs{/sha}","trees_url":"https://api.github.com/repos/strands-project/strands_executive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strands-project/strands_executive/statuses/{sha}","languages_url":"https://api.github.com/repos/strands-project/strands_executive/languages","stargazers_url":"https://api.github.com/repos/strands-project/strands_executive/stargazers","contributors_url":"https://api.github.com/repos/strands-project/strands_executive/contributors","subscribers_url":"https://api.github.com/repos/strands-project/strands_executive/subscribers","subscription_url":"https://api.github.com/repos/strands-project/strands_executive/subscription","commits_url":"https://api.github.com/repos/strands-project/strands_executive/commits{/sha}","git_commits_url":"https://api.github.com/repos/strands-project/strands_executive/git/commits{/sha}","comments_url":"https://api.github.com/repos/strands-project/strands_executive/comments{/number}","issue_comment_url":"https://api.github.com/repos/strands-project/strands_executive/issues/comments{/number}","contents_url":"https://api.github.com/repos/strands-project/strands_executive/contents/{+path}","compare_url":"https://api.github.com/repos/strands-project/strands_executive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strands-project/strands_executive/merges","archive_url":"https://api.github.com/repos/strands-project/strands_executive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strands-project/strands_executive/downloads","issues_url":"https://api.github.com/repos/strands-project/strands_executive/issues{/number}","pulls_url":"https://api.github.com/repos/strands-project/strands_executive/pulls{/number}","milestones_url":"https://api.github.com/repos/strands-project/strands_executive/milestones{/number}","notifications_url":"https://api.github.com/repos/strands-project/strands_executive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strands-project/strands_executive/labels{/name}","releases_url":"https://api.github.com/repos/strands-project/strands_executive/releases{/id}","created_at":"2014-02-13T11:18:02Z","updated_at":"2015-03-23T23:55:59Z","pushed_at":"2015-03-25T23:32:50Z","git_url":"git://github.com/strands-project/strands_executive.git","ssh_url":"git@github.com:strands-project/strands_executive.git","clone_url":"https://github.com/strands-project/strands_executive.git","svn_url":"https://github.com/strands-project/strands_executive","homepage":null,"size":18843,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":18,"forks":9,"open_issues":18,"watchers":0,"default_branch":"hydro-release"}},"_links":{"self":{"href":"https://api.github.com/repos/strands-project/strands_executive/pulls/141"},"html":{"href":"https://github.com/strands-project/strands_executive/pull/141"},"issue":{"href":"https://api.github.com/repos/strands-project/strands_executive/issues/141"},"comments":{"href":"https://api.github.com/repos/strands-project/strands_executive/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/strands-project/strands_executive/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/strands-project/strands_executive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strands-project/strands_executive/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/strands-project/strands_executive/statuses/084382563fe8c411b862aabae1fdbf36abaddb09"}}}}