{"action":"created","issue":{"url":"https://api.github.com/repos/mono/monodevelop/issues/754","labels_url":"https://api.github.com/repos/mono/monodevelop/issues/754/labels{/name}","comments_url":"https://api.github.com/repos/mono/monodevelop/issues/754/comments","events_url":"https://api.github.com/repos/mono/monodevelop/issues/754/events","html_url":"https://github.com/mono/monodevelop/pull/754","id":59355011,"number":754,"title":"[Core/Ide] Sanitize file:// URIs in FilePath ctor","user":{"login":"knocte","id":331303,"avatar_url":"https://avatars.githubusercontent.com/u/331303?v=3","gravatar_id":"","url":"https://api.github.com/users/knocte","html_url":"https://github.com/knocte","followers_url":"https://api.github.com/users/knocte/followers","following_url":"https://api.github.com/users/knocte/following{/other_user}","gists_url":"https://api.github.com/users/knocte/gists{/gist_id}","starred_url":"https://api.github.com/users/knocte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knocte/subscriptions","organizations_url":"https://api.github.com/users/knocte/orgs","repos_url":"https://api.github.com/users/knocte/repos","events_url":"https://api.github.com/users/knocte/events{/privacy}","received_events_url":"https://api.github.com/users/knocte/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-28T19:42:19Z","updated_at":"2015-03-12T09:55:30Z","closed_at":"2015-03-12T09:55:27Z","pull_request":{"url":"https://api.github.com/repos/mono/monodevelop/pulls/754","html_url":"https://github.com/mono/monodevelop/pull/754","diff_url":"https://github.com/mono/monodevelop/pull/754.diff","patch_url":"https://github.com/mono/monodevelop/pull/754.patch"},"body":"This file:/// translation pattern happens in many places:\r\n\r\n if (filename.StartsWith (\"file://\", StringComparison.Ordinal))\r\n     filename = new Uri(filename).LocalPath;\r\n\r\nAll of them use strings for paths, which is a smell\r\n(http://c2.com/cgi/wiki?PrimitiveObsession) so we can kill two\r\nbirds with one stone if we change them to use FilePath instead,\r\nand move this path sanitization to the FilePath ctor."},"comment":{"url":"https://api.github.com/repos/mono/monodevelop/issues/comments/78451088","html_url":"https://github.com/mono/monodevelop/pull/754#issuecomment-78451088","issue_url":"https://api.github.com/repos/mono/monodevelop/issues/754","id":78451088,"user":{"login":"slluis","id":260349,"avatar_url":"https://avatars.githubusercontent.com/u/260349?v=3","gravatar_id":"","url":"https://api.github.com/users/slluis","html_url":"https://github.com/slluis","followers_url":"https://api.github.com/users/slluis/followers","following_url":"https://api.github.com/users/slluis/following{/other_user}","gists_url":"https://api.github.com/users/slluis/gists{/gist_id}","starred_url":"https://api.github.com/users/slluis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slluis/subscriptions","organizations_url":"https://api.github.com/users/slluis/orgs","repos_url":"https://api.github.com/users/slluis/repos","events_url":"https://api.github.com/users/slluis/events{/privacy}","received_events_url":"https://api.github.com/users/slluis/received_events","type":"User","site_admin":false},"created_at":"2015-03-12T09:55:30Z","updated_at":"2015-03-12T09:55:30Z","body":"Thanks!"}}