{"action":"created","comment":{"url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/comments/43453688","id":43453688,"diff_hunk":"@@ -91,6 +104,41 @@ public InitialDirContext createUserContext(String principal, String credentials)\n     return createInitialDirContext(principal, credentials, false);\n   }\n \n+  private InitialDirContext createInitialDirContextUsingGssapi(String principal, String credentials, final boolean pooling) throws NamingException {\n+\t  Configuration.setConfiguration(new Krb5LoginConfiguration());\n+\t  //Configuration.getConfiguration();\n+\t  InitialDirContext initialDirContext = null;\n+\t  LoginContext lc = null;\n+\t  try {\n+\t\t  lc = new LoginContext(getClass().getName(), new CallbackHandlerImpl(principal, credentials));","path":"src/main/java/org/sonar/plugins/ldap/LdapContextFactory.java","position":44,"original_position":44,"commit_id":"588ded9b27ecc2eb381ac9019175215093f22f7b","original_commit_id":"588ded9b27ecc2eb381ac9019175215093f22f7b","user":{"login":"simonbrandhof","id":414010,"avatar_url":"https://avatars.githubusercontent.com/u/414010?v=3","gravatar_id":"","url":"https://api.github.com/users/simonbrandhof","html_url":"https://github.com/simonbrandhof","followers_url":"https://api.github.com/users/simonbrandhof/followers","following_url":"https://api.github.com/users/simonbrandhof/following{/other_user}","gists_url":"https://api.github.com/users/simonbrandhof/gists{/gist_id}","starred_url":"https://api.github.com/users/simonbrandhof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonbrandhof/subscriptions","organizations_url":"https://api.github.com/users/simonbrandhof/orgs","repos_url":"https://api.github.com/users/simonbrandhof/repos","events_url":"https://api.github.com/users/simonbrandhof/events{/privacy}","received_events_url":"https://api.github.com/users/simonbrandhof/received_events","type":"User","site_admin":false},"body":"Tabulations must be replaced by 2-whitespaces.","created_at":"2015-10-29T22:40:38Z","updated_at":"2015-10-29T22:40:38Z","html_url":"https://github.com/SonarCommunity/sonar-ldap/pull/9#discussion_r43453688","pull_request_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/comments/43453688"},"html":{"href":"https://github.com/SonarCommunity/sonar-ldap/pull/9#discussion_r43453688"},"pull_request":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9","id":47582741,"html_url":"https://github.com/SonarCommunity/sonar-ldap/pull/9","diff_url":"https://github.com/SonarCommunity/sonar-ldap/pull/9.diff","patch_url":"https://github.com/SonarCommunity/sonar-ldap/pull/9.patch","issue_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues/9","number":9,"state":"open","locked":false,"title":"Gssapi fix","user":{"login":"BobSilent","id":13506173,"avatar_url":"https://avatars.githubusercontent.com/u/13506173?v=3","gravatar_id":"","url":"https://api.github.com/users/BobSilent","html_url":"https://github.com/BobSilent","followers_url":"https://api.github.com/users/BobSilent/followers","following_url":"https://api.github.com/users/BobSilent/following{/other_user}","gists_url":"https://api.github.com/users/BobSilent/gists{/gist_id}","starred_url":"https://api.github.com/users/BobSilent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobSilent/subscriptions","organizations_url":"https://api.github.com/users/BobSilent/orgs","repos_url":"https://api.github.com/users/BobSilent/repos","events_url":"https://api.github.com/users/BobSilent/events{/privacy}","received_events_url":"https://api.github.com/users/BobSilent/received_events","type":"User","site_admin":false},"body":"Fix authenticate for GSSAPI Usage, issue was introduced with multiple ldap server handling: In case of GSSAPI Usage only check password with GSSAPI and not also with bind.\r\n\r\nAlso in case of GSSAPI Usage the InitialDirContext is created by GSSAPI and not via Bind\r\n\r\n","created_at":"2015-10-13T20:17:16Z","updated_at":"2015-10-29T22:40:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46073393207c256f528b1602ba6b0a273e81cf69","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9/commits","review_comments_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9/comments","review_comment_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues/9/comments","statuses_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/statuses/588ded9b27ecc2eb381ac9019175215093f22f7b","head":{"label":"BobSilent:gssapi_fix","ref":"gssapi_fix","sha":"588ded9b27ecc2eb381ac9019175215093f22f7b","user":{"login":"BobSilent","id":13506173,"avatar_url":"https://avatars.githubusercontent.com/u/13506173?v=3","gravatar_id":"","url":"https://api.github.com/users/BobSilent","html_url":"https://github.com/BobSilent","followers_url":"https://api.github.com/users/BobSilent/followers","following_url":"https://api.github.com/users/BobSilent/following{/other_user}","gists_url":"https://api.github.com/users/BobSilent/gists{/gist_id}","starred_url":"https://api.github.com/users/BobSilent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobSilent/subscriptions","organizations_url":"https://api.github.com/users/BobSilent/orgs","repos_url":"https://api.github.com/users/BobSilent/repos","events_url":"https://api.github.com/users/BobSilent/events{/privacy}","received_events_url":"https://api.github.com/users/BobSilent/received_events","type":"User","site_admin":false},"repo":{"id":44158936,"name":"sonar-ldap","full_name":"BobSilent/sonar-ldap","owner":{"login":"BobSilent","id":13506173,"avatar_url":"https://avatars.githubusercontent.com/u/13506173?v=3","gravatar_id":"","url":"https://api.github.com/users/BobSilent","html_url":"https://github.com/BobSilent","followers_url":"https://api.github.com/users/BobSilent/followers","following_url":"https://api.github.com/users/BobSilent/following{/other_user}","gists_url":"https://api.github.com/users/BobSilent/gists{/gist_id}","starred_url":"https://api.github.com/users/BobSilent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobSilent/subscriptions","organizations_url":"https://api.github.com/users/BobSilent/orgs","repos_url":"https://api.github.com/users/BobSilent/repos","events_url":"https://api.github.com/users/BobSilent/events{/privacy}","received_events_url":"https://api.github.com/users/BobSilent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BobSilent/sonar-ldap","description":"LDAP Plugin for SonarQube","fork":true,"url":"https://api.github.com/repos/BobSilent/sonar-ldap","forks_url":"https://api.github.com/repos/BobSilent/sonar-ldap/forks","keys_url":"https://api.github.com/repos/BobSilent/sonar-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BobSilent/sonar-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BobSilent/sonar-ldap/teams","hooks_url":"https://api.github.com/repos/BobSilent/sonar-ldap/hooks","issue_events_url":"https://api.github.com/repos/BobSilent/sonar-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/BobSilent/sonar-ldap/events","assignees_url":"https://api.github.com/repos/BobSilent/sonar-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/BobSilent/sonar-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/BobSilent/sonar-ldap/tags","blobs_url":"https://api.github.com/repos/BobSilent/sonar-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BobSilent/sonar-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BobSilent/sonar-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/BobSilent/sonar-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BobSilent/sonar-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/BobSilent/sonar-ldap/languages","stargazers_url":"https://api.github.com/repos/BobSilent/sonar-ldap/stargazers","contributors_url":"https://api.github.com/repos/BobSilent/sonar-ldap/contributors","subscribers_url":"https://api.github.com/repos/BobSilent/sonar-ldap/subscribers","subscription_url":"https://api.github.com/repos/BobSilent/sonar-ldap/subscription","commits_url":"https://api.github.com/repos/BobSilent/sonar-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/BobSilent/sonar-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/BobSilent/sonar-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/BobSilent/sonar-ldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/BobSilent/sonar-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/BobSilent/sonar-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BobSilent/sonar-ldap/merges","archive_url":"https://api.github.com/repos/BobSilent/sonar-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BobSilent/sonar-ldap/downloads","issues_url":"https://api.github.com/repos/BobSilent/sonar-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/BobSilent/sonar-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/BobSilent/sonar-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/BobSilent/sonar-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BobSilent/sonar-ldap/labels{/name}","releases_url":"https://api.github.com/repos/BobSilent/sonar-ldap/releases{/id}","created_at":"2015-10-13T07:16:33Z","updated_at":"2015-10-13T07:16:34Z","pushed_at":"2015-10-13T15:25:57Z","git_url":"git://github.com/BobSilent/sonar-ldap.git","ssh_url":"git@github.com:BobSilent/sonar-ldap.git","clone_url":"https://github.com/BobSilent/sonar-ldap.git","svn_url":"https://github.com/BobSilent/sonar-ldap","homepage":"http://docs.sonarqube.org/display/PLUG/LDAP+Plugin","size":439,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SonarCommunity:master","ref":"master","sha":"3e15352426c3eedb1eff40ec61c8f65c24183ffd","user":{"login":"SonarCommunity","id":1303819,"avatar_url":"https://avatars.githubusercontent.com/u/1303819?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarCommunity","html_url":"https://github.com/SonarCommunity","followers_url":"https://api.github.com/users/SonarCommunity/followers","following_url":"https://api.github.com/users/SonarCommunity/following{/other_user}","gists_url":"https://api.github.com/users/SonarCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarCommunity/subscriptions","organizations_url":"https://api.github.com/users/SonarCommunity/orgs","repos_url":"https://api.github.com/users/SonarCommunity/repos","events_url":"https://api.github.com/users/SonarCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/SonarCommunity/received_events","type":"Organization","site_admin":false},"repo":{"id":4673630,"name":"sonar-ldap","full_name":"SonarCommunity/sonar-ldap","owner":{"login":"SonarCommunity","id":1303819,"avatar_url":"https://avatars.githubusercontent.com/u/1303819?v=3","gravatar_id":"","url":"https://api.github.com/users/SonarCommunity","html_url":"https://github.com/SonarCommunity","followers_url":"https://api.github.com/users/SonarCommunity/followers","following_url":"https://api.github.com/users/SonarCommunity/following{/other_user}","gists_url":"https://api.github.com/users/SonarCommunity/gists{/gist_id}","starred_url":"https://api.github.com/users/SonarCommunity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SonarCommunity/subscriptions","organizations_url":"https://api.github.com/users/SonarCommunity/orgs","repos_url":"https://api.github.com/users/SonarCommunity/repos","events_url":"https://api.github.com/users/SonarCommunity/events{/privacy}","received_events_url":"https://api.github.com/users/SonarCommunity/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SonarCommunity/sonar-ldap","description":"LDAP Plugin for SonarQube","fork":false,"url":"https://api.github.com/repos/SonarCommunity/sonar-ldap","forks_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/forks","keys_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/teams","hooks_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/hooks","issue_events_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues/events{/number}","events_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/events","assignees_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/assignees{/user}","branches_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/branches{/branch}","tags_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/tags","blobs_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/git/refs{/sha}","trees_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/statuses/{sha}","languages_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/languages","stargazers_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/stargazers","contributors_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/contributors","subscribers_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/subscribers","subscription_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/subscription","commits_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/commits{/sha}","git_commits_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/git/commits{/sha}","comments_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/comments{/number}","issue_comment_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues/comments{/number}","contents_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/contents/{+path}","compare_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/merges","archive_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/downloads","issues_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues{/number}","pulls_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls{/number}","milestones_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/milestones{/number}","notifications_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/labels{/name}","releases_url":"https://api.github.com/repos/SonarCommunity/sonar-ldap/releases{/id}","created_at":"2012-06-15T09:47:37Z","updated_at":"2015-10-05T17:13:11Z","pushed_at":"2015-10-29T22:24:13Z","git_url":"git://github.com/SonarCommunity/sonar-ldap.git","ssh_url":"git@github.com:SonarCommunity/sonar-ldap.git","clone_url":"https://github.com/SonarCommunity/sonar-ldap.git","svn_url":"https://github.com/SonarCommunity/sonar-ldap","homepage":"http://docs.sonarqube.org/display/PLUG/LDAP+Plugin","size":998,"stargazers_count":11,"watchers_count":11,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":4,"forks":17,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9"},"html":{"href":"https://github.com/SonarCommunity/sonar-ldap/pull/9"},"issue":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues/9"},"comments":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/SonarCommunity/sonar-ldap/statuses/588ded9b27ecc2eb381ac9019175215093f22f7b"}}}}