{"action":"created","comment":{"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/comments/47231317","id":47231317,"diff_hunk":"@@ -181,12 +176,11 @@ $.extend( SELF.prototype, {\n \t},\n \n \t/**\n-\t * @param {string} languageCode\n \t * @param {wikibase.datamodel.MultiTerm} aliases\n \t * @return {boolean}\n \t */\n-\thasAliases: function( languageCode, aliases ) {\n-\t\treturn this._aliases.hasItem( languageCode, aliases );\n+\thasAliases: function( aliases ) {","path":"src/Fingerprint.js","position":98,"original_position":98,"commit_id":"a15bb45cda01b78b824a324533e7ed1021c823b0","original_commit_id":"a15bb45cda01b78b824a324533e7ed1021c823b0","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"body":"Same here.","created_at":"2015-12-10T14:25:41Z","updated_at":"2015-12-10T14:25:41Z","html_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/40#discussion_r47231317","pull_request_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40","_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/comments/47231317"},"html":{"href":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/40#discussion_r47231317"},"pull_request":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40"}}},"pull_request":{"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40","id":53249814,"html_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/40","diff_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/40.diff","patch_url":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/40.patch","issue_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/40","number":40,"state":"open","locked":false,"title":"Remove weirdness from Fingerprint methods","user":{"login":"Benestar","id":2998254,"avatar_url":"https://avatars.githubusercontent.com/u/2998254?v=3","gravatar_id":"","url":"https://api.github.com/users/Benestar","html_url":"https://github.com/Benestar","followers_url":"https://api.github.com/users/Benestar/followers","following_url":"https://api.github.com/users/Benestar/following{/other_user}","gists_url":"https://api.github.com/users/Benestar/gists{/gist_id}","starred_url":"https://api.github.com/users/Benestar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Benestar/subscriptions","organizations_url":"https://api.github.com/users/Benestar/orgs","repos_url":"https://api.github.com/users/Benestar/repos","events_url":"https://api.github.com/users/Benestar/events{/privacy}","received_events_url":"https://api.github.com/users/Benestar/received_events","type":"User","site_admin":false},"body":"Methods to add, set or remove terms and multiterms from a Fingerprint do\r\nnot require a language code to be passed together with the term because\r\nthe language can be derived from the term object. In the current state\r\nthere can be inconsistencies in the datamodel allowing a wrong language\r\ncode to be set for a term in another language.\r\n\r\n**Note:** Tests need to be updated. This is a breaking change!","created_at":"2015-12-10T12:04:37Z","updated_at":"2015-12-10T14:25:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1986a3279aed219a2d4477df94c9a24f7bd141ad","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40/commits","review_comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40/comments","review_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/40/comments","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/a15bb45cda01b78b824a324533e7ed1021c823b0","head":{"label":"wmde:fingerprint-weirdness","ref":"fingerprint-weirdness","sha":"a15bb45cda01b78b824a324533e7ed1021c823b0","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":20956401,"name":"WikibaseDataModelJavaScript","full_name":"wmde/WikibaseDataModelJavaScript","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModelJavaScript","description":"JavaScript implementation of the Wikibase data model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/releases{/id}","created_at":"2014-06-18T09:16:29Z","updated_at":"2015-04-29T01:25:43Z","pushed_at":"2015-12-10T13:57:55Z","git_url":"git://github.com/wmde/WikibaseDataModelJavaScript.git","ssh_url":"git@github.com:wmde/WikibaseDataModelJavaScript.git","clone_url":"https://github.com/wmde/WikibaseDataModelJavaScript.git","svn_url":"https://github.com/wmde/WikibaseDataModelJavaScript","homepage":"http://wikiba.se","size":320,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"base":{"label":"wmde:master","ref":"master","sha":"54c89dd4cda78fd5f110e7ea415c25beabb24d1f","user":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"repo":{"id":20956401,"name":"WikibaseDataModelJavaScript","full_name":"wmde/WikibaseDataModelJavaScript","owner":{"login":"wmde","id":664724,"avatar_url":"https://avatars.githubusercontent.com/u/664724?v=3","gravatar_id":"","url":"https://api.github.com/users/wmde","html_url":"https://github.com/wmde","followers_url":"https://api.github.com/users/wmde/followers","following_url":"https://api.github.com/users/wmde/following{/other_user}","gists_url":"https://api.github.com/users/wmde/gists{/gist_id}","starred_url":"https://api.github.com/users/wmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmde/subscriptions","organizations_url":"https://api.github.com/users/wmde/orgs","repos_url":"https://api.github.com/users/wmde/repos","events_url":"https://api.github.com/users/wmde/events{/privacy}","received_events_url":"https://api.github.com/users/wmde/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wmde/WikibaseDataModelJavaScript","description":"JavaScript implementation of the Wikibase data model","fork":false,"url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript","forks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/forks","keys_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/teams","hooks_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/hooks","issue_events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/events{/number}","events_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/events","assignees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/assignees{/user}","branches_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/branches{/branch}","tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/tags","blobs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/{sha}","languages_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/languages","stargazers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/stargazers","contributors_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contributors","subscribers_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscribers","subscription_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/subscription","commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/contents/{+path}","compare_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/merges","archive_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/downloads","issues_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues{/number}","pulls_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls{/number}","milestones_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/milestones{/number}","notifications_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/labels{/name}","releases_url":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/releases{/id}","created_at":"2014-06-18T09:16:29Z","updated_at":"2015-04-29T01:25:43Z","pushed_at":"2015-12-10T13:57:55Z","git_url":"git://github.com/wmde/WikibaseDataModelJavaScript.git","ssh_url":"git@github.com:wmde/WikibaseDataModelJavaScript.git","clone_url":"https://github.com/wmde/WikibaseDataModelJavaScript.git","svn_url":"https://github.com/wmde/WikibaseDataModelJavaScript","homepage":"http://wikiba.se","size":320,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40"},"html":{"href":"https://github.com/wmde/WikibaseDataModelJavaScript/pull/40"},"issue":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/40"},"comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/wmde/WikibaseDataModelJavaScript/statuses/a15bb45cda01b78b824a324533e7ed1021c823b0"}}}}