{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/10986","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10986/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10986/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10986/events","html_url":"https://github.com/elastic/elasticsearch/pull/10986","id":73344022,"number":10986,"title":"Add pid file to Environment","user":{"login":"tlrx","id":642733,"avatar_url":"https://avatars.githubusercontent.com/u/642733?v=3","gravatar_id":"","url":"https://api.github.com/users/tlrx","html_url":"https://github.com/tlrx","followers_url":"https://api.github.com/users/tlrx/followers","following_url":"https://api.github.com/users/tlrx/following{/other_user}","gists_url":"https://api.github.com/users/tlrx/gists{/gist_id}","starred_url":"https://api.github.com/users/tlrx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlrx/subscriptions","organizations_url":"https://api.github.com/users/tlrx/orgs","repos_url":"https://api.github.com/users/tlrx/repos","events_url":"https://api.github.com/users/tlrx/events{/privacy}","received_events_url":"https://api.github.com/users/tlrx/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v2.0.0","name":"v2.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-05-05T15:20:37Z","updated_at":"2015-05-05T16:30:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10986","html_url":"https://github.com/elastic/elasticsearch/pull/10986","diff_url":"https://github.com/elastic/elasticsearch/pull/10986.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/10986.patch"},"body":"This commit adds the path of the PID file to the Environment. It also add it to the Security Manager since the PID file is deleted by a shutdown hook when the JVM is exited."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/99133005","html_url":"https://github.com/elastic/elasticsearch/pull/10986#issuecomment-99133005","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10986","id":99133005,"user":{"login":"rmuir","id":504194,"avatar_url":"https://avatars.githubusercontent.com/u/504194?v=3","gravatar_id":"","url":"https://api.github.com/users/rmuir","html_url":"https://github.com/rmuir","followers_url":"https://api.github.com/users/rmuir/followers","following_url":"https://api.github.com/users/rmuir/following{/other_user}","gists_url":"https://api.github.com/users/rmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/rmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmuir/subscriptions","organizations_url":"https://api.github.com/users/rmuir/orgs","repos_url":"https://api.github.com/users/rmuir/repos","events_url":"https://api.github.com/users/rmuir/events{/privacy}","received_events_url":"https://api.github.com/users/rmuir/received_events","type":"User","site_admin":false},"created_at":"2015-05-05T16:30:48Z","updated_at":"2015-05-05T16:30:48Z","body":"Looks good. When pushing, can we add a small javadoc for the Environment.pidFile() that mentions it returns null if no pid file is configured? Other paths do not return null, but here callers need to check."}}