{"action":"closed","number":887,"pull_request":{"url":"https://api.github.com/repos/ruby/ruby/pulls/887","id":34345921,"html_url":"https://github.com/ruby/ruby/pull/887","diff_url":"https://github.com/ruby/ruby/pull/887.diff","patch_url":"https://github.com/ruby/ruby/pull/887.patch","issue_url":"https://api.github.com/repos/ruby/ruby/issues/887","number":887,"state":"closed","locked":false,"title":"Implement HttpOnly flag for cookies.","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"body":"This is really missing in the `CGI::Cookie`.\r\n\r\nhttps://www.owasp.org/index.php/HttpOnly\r\n\r\nIn a follow-up PR I would like to add the flag to the cookies generated by `CGI::Session`.","created_at":"2015-04-29T09:30:46Z","updated_at":"2015-05-11T13:57:51Z","closed_at":"2015-05-11T13:57:51Z","merged_at":null,"merge_commit_sha":"a731594a77ecb383bf43413f551bfa00c9b86b7b","assignee":{"login":"xibbar","id":25030,"avatar_url":"https://avatars.githubusercontent.com/u/25030?v=3","gravatar_id":"","url":"https://api.github.com/users/xibbar","html_url":"https://github.com/xibbar","followers_url":"https://api.github.com/users/xibbar/followers","following_url":"https://api.github.com/users/xibbar/following{/other_user}","gists_url":"https://api.github.com/users/xibbar/gists{/gist_id}","starred_url":"https://api.github.com/users/xibbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xibbar/subscriptions","organizations_url":"https://api.github.com/users/xibbar/orgs","repos_url":"https://api.github.com/users/xibbar/repos","events_url":"https://api.github.com/users/xibbar/events{/privacy}","received_events_url":"https://api.github.com/users/xibbar/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/ruby/ruby/pulls/887/commits","review_comments_url":"https://api.github.com/repos/ruby/ruby/pulls/887/comments","review_comment_url":"https://api.github.com/repos/ruby/ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruby/ruby/issues/887/comments","statuses_url":"https://api.github.com/repos/ruby/ruby/statuses/bf1734f515518e9d74e81e4f86d874f5c24df280","head":{"label":"martinpovolny:http_only_cookies","ref":"http_only_cookies","sha":"bf1734f515518e9d74e81e4f86d874f5c24df280","user":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"repo":{"id":34783177,"name":"ruby","full_name":"martinpovolny/ruby","owner":{"login":"martinpovolny","id":51095,"avatar_url":"https://avatars.githubusercontent.com/u/51095?v=3","gravatar_id":"","url":"https://api.github.com/users/martinpovolny","html_url":"https://github.com/martinpovolny","followers_url":"https://api.github.com/users/martinpovolny/followers","following_url":"https://api.github.com/users/martinpovolny/following{/other_user}","gists_url":"https://api.github.com/users/martinpovolny/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpovolny/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpovolny/subscriptions","organizations_url":"https://api.github.com/users/martinpovolny/orgs","repos_url":"https://api.github.com/users/martinpovolny/repos","events_url":"https://api.github.com/users/martinpovolny/events{/privacy}","received_events_url":"https://api.github.com/users/martinpovolny/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinpovolny/ruby","description":"The Ruby Programming Language","fork":true,"url":"https://api.github.com/repos/martinpovolny/ruby","forks_url":"https://api.github.com/repos/martinpovolny/ruby/forks","keys_url":"https://api.github.com/repos/martinpovolny/ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinpovolny/ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinpovolny/ruby/teams","hooks_url":"https://api.github.com/repos/martinpovolny/ruby/hooks","issue_events_url":"https://api.github.com/repos/martinpovolny/ruby/issues/events{/number}","events_url":"https://api.github.com/repos/martinpovolny/ruby/events","assignees_url":"https://api.github.com/repos/martinpovolny/ruby/assignees{/user}","branches_url":"https://api.github.com/repos/martinpovolny/ruby/branches{/branch}","tags_url":"https://api.github.com/repos/martinpovolny/ruby/tags","blobs_url":"https://api.github.com/repos/martinpovolny/ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinpovolny/ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinpovolny/ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinpovolny/ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinpovolny/ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/martinpovolny/ruby/languages","stargazers_url":"https://api.github.com/repos/martinpovolny/ruby/stargazers","contributors_url":"https://api.github.com/repos/martinpovolny/ruby/contributors","subscribers_url":"https://api.github.com/repos/martinpovolny/ruby/subscribers","subscription_url":"https://api.github.com/repos/martinpovolny/ruby/subscription","commits_url":"https://api.github.com/repos/martinpovolny/ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinpovolny/ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinpovolny/ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinpovolny/ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinpovolny/ruby/contents/{+path}","compare_url":"https://api.github.com/repos/martinpovolny/ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinpovolny/ruby/merges","archive_url":"https://api.github.com/repos/martinpovolny/ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinpovolny/ruby/downloads","issues_url":"https://api.github.com/repos/martinpovolny/ruby/issues{/number}","pulls_url":"https://api.github.com/repos/martinpovolny/ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/martinpovolny/ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/martinpovolny/ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinpovolny/ruby/labels{/name}","releases_url":"https://api.github.com/repos/martinpovolny/ruby/releases{/id}","created_at":"2015-04-29T08:52:48Z","updated_at":"2015-04-29T08:53:07Z","pushed_at":"2015-05-01T05:48:41Z","git_url":"git://github.com/martinpovolny/ruby.git","ssh_url":"git@github.com:martinpovolny/ruby.git","clone_url":"https://github.com/martinpovolny/ruby.git","svn_url":"https://github.com/martinpovolny/ruby","homepage":"http://www.ruby-lang.org/","size":183570,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"ruby:trunk","ref":"trunk","sha":"55851c982d6d2b50bcdea652e3fb5a5b961bf0c6","user":{"login":"ruby","id":210414,"avatar_url":"https://avatars.githubusercontent.com/u/210414?v=3","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"repo":{"id":538746,"name":"ruby","full_name":"ruby/ruby","owner":{"login":"ruby","id":210414,"avatar_url":"https://avatars.githubusercontent.com/u/210414?v=3","gravatar_id":"","url":"https://api.github.com/users/ruby","html_url":"https://github.com/ruby","followers_url":"https://api.github.com/users/ruby/followers","following_url":"https://api.github.com/users/ruby/following{/other_user}","gists_url":"https://api.github.com/users/ruby/gists{/gist_id}","starred_url":"https://api.github.com/users/ruby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruby/subscriptions","organizations_url":"https://api.github.com/users/ruby/orgs","repos_url":"https://api.github.com/users/ruby/repos","events_url":"https://api.github.com/users/ruby/events{/privacy}","received_events_url":"https://api.github.com/users/ruby/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ruby/ruby","description":"The Ruby Programming Language","fork":false,"url":"https://api.github.com/repos/ruby/ruby","forks_url":"https://api.github.com/repos/ruby/ruby/forks","keys_url":"https://api.github.com/repos/ruby/ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruby/ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruby/ruby/teams","hooks_url":"https://api.github.com/repos/ruby/ruby/hooks","issue_events_url":"https://api.github.com/repos/ruby/ruby/issues/events{/number}","events_url":"https://api.github.com/repos/ruby/ruby/events","assignees_url":"https://api.github.com/repos/ruby/ruby/assignees{/user}","branches_url":"https://api.github.com/repos/ruby/ruby/branches{/branch}","tags_url":"https://api.github.com/repos/ruby/ruby/tags","blobs_url":"https://api.github.com/repos/ruby/ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruby/ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruby/ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruby/ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruby/ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/ruby/ruby/languages","stargazers_url":"https://api.github.com/repos/ruby/ruby/stargazers","contributors_url":"https://api.github.com/repos/ruby/ruby/contributors","subscribers_url":"https://api.github.com/repos/ruby/ruby/subscribers","subscription_url":"https://api.github.com/repos/ruby/ruby/subscription","commits_url":"https://api.github.com/repos/ruby/ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruby/ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruby/ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruby/ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruby/ruby/contents/{+path}","compare_url":"https://api.github.com/repos/ruby/ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruby/ruby/merges","archive_url":"https://api.github.com/repos/ruby/ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruby/ruby/downloads","issues_url":"https://api.github.com/repos/ruby/ruby/issues{/number}","pulls_url":"https://api.github.com/repos/ruby/ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/ruby/ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/ruby/ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruby/ruby/labels{/name}","releases_url":"https://api.github.com/repos/ruby/ruby/releases{/id}","created_at":"2010-02-27T15:55:23Z","updated_at":"2015-05-11T12:03:48Z","pushed_at":"2015-05-11T02:16:23Z","git_url":"git://github.com/ruby/ruby.git","ssh_url":"git@github.com:ruby/ruby.git","clone_url":"https://github.com/ruby/ruby.git","svn_url":"https://github.com/ruby/ruby","homepage":"http://www.ruby-lang.org/","size":273712,"stargazers_count":7364,"watchers_count":7364,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2220,"mirror_url":null,"open_issues_count":76,"forks":2220,"open_issues":76,"watchers":7364,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/ruby/ruby/pulls/887"},"html":{"href":"https://github.com/ruby/ruby/pull/887"},"issue":{"href":"https://api.github.com/repos/ruby/ruby/issues/887"},"comments":{"href":"https://api.github.com/repos/ruby/ruby/issues/887/comments"},"review_comments":{"href":"https://api.github.com/repos/ruby/ruby/pulls/887/comments"},"review_comment":{"href":"https://api.github.com/repos/ruby/ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruby/ruby/pulls/887/commits"},"statuses":{"href":"https://api.github.com/repos/ruby/ruby/statuses/bf1734f515518e9d74e81e4f86d874f5c24df280"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":4,"commits":1,"additions":42,"deletions":21,"changed_files":2}}