{"action":"created","comment":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/38058068","id":38058068,"diff_hunk":"@@ -2242,12 +2267,15 @@ extension type (Supported Group Extension):\n The client MUST supply a \"supported_groups\" extension containing at\n least one group for each key exchange algorithm (currently\n DHE and ECDHE) for which it offers a cipher suite.\n-If the client does not supply a \"supported_groups\" extension with a\n-compatible group, the server MUST NOT negotiate a cipher suite of the\n-relevant type.  For instance, if a client supplies only ECDHE groups,\n-the server MUST NOT negotiate finite field Diffie-Hellman.  If no\n-acceptable group can be selected across all cipher suites, then the\n-server MUST generate a fatal \"handshake_failure\" alert.\n+Servers receiving a TLS 1.3 ClientHello without this extension yet\n+offering either DHE or ECDHE cipher suites MUST send a\n+\"missing_extension\" alert message and close the connection.","path":"draft-ietf-tls-tls13.md","position":171,"original_position":171,"commit_id":"7b116fbc80d38e4ac0f2994bcff9a0ff77c9ff4e","original_commit_id":"7b116fbc80d38e4ac0f2994bcff9a0ff77c9ff4e","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"body":"I disagree with that. If the extension is mandatory to send, then a hello without it is essentially malformed. Not requiring it to check if it's not negotiating (EC)DHE at the moment might be ok, if that's what you mean.","created_at":"2015-08-27T02:51:56Z","updated_at":"2015-08-27T02:51:56Z","html_url":"https://github.com/tlswg/tls13-spec/pull/201#discussion_r38058068","pull_request_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments/38058068"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/201#discussion_r38058068"},"pull_request":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201","id":40165974,"html_url":"https://github.com/tlswg/tls13-spec/pull/201","diff_url":"https://github.com/tlswg/tls13-spec/pull/201.diff","patch_url":"https://github.com/tlswg/tls13-spec/pull/201.patch","issue_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/201","number":201,"state":"open","locked":false,"title":"MTI Extensions (incl. issue #116)","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"body":"This is a set of changes covering mailing list discussions about error alerts, certificate acceptance, SHA-1 deprecation, as well as including some recommendations about curves. There's also quite a few other little fixes mixed in there, including some cleanups in RFC2119 language. The alerts list has been fully updated to include all standardized alerts (PSK alert is needed for new PSK extension, in particular). This also adds RFC 5746 (\"renegotiation_info\" info extension) to the list of newly obsoleted RFCs, as renegotiation has already been removed completely thus making it no longer applicable as of this new TLS version.\r\n\r\nPR #169 has the discussed change to certificate ordering requirements, however it is waiting on @seanturner to assess consensus so I'm not including it here.","created_at":"2015-07-16T19:25:58Z","updated_at":"2015-08-27T02:51:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f9e3ed033699ba5011274234e6c4694148536021","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201/commits","review_comments_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201/comments","review_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/201/comments","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/7b116fbc80d38e4ac0f2994bcff9a0ff77c9ff4e","head":{"label":"davegarrett:alertsandcerts","ref":"alertsandcerts","sha":"7b116fbc80d38e4ac0f2994bcff9a0ff77c9ff4e","user":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"repo":{"id":28255281,"name":"tls13-spec","full_name":"davegarrett/tls13-spec","owner":{"login":"davegarrett","id":8292199,"avatar_url":"https://avatars.githubusercontent.com/u/8292199?v=3","gravatar_id":"","url":"https://api.github.com/users/davegarrett","html_url":"https://github.com/davegarrett","followers_url":"https://api.github.com/users/davegarrett/followers","following_url":"https://api.github.com/users/davegarrett/following{/other_user}","gists_url":"https://api.github.com/users/davegarrett/gists{/gist_id}","starred_url":"https://api.github.com/users/davegarrett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davegarrett/subscriptions","organizations_url":"https://api.github.com/users/davegarrett/orgs","repos_url":"https://api.github.com/users/davegarrett/repos","events_url":"https://api.github.com/users/davegarrett/events{/privacy}","received_events_url":"https://api.github.com/users/davegarrett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davegarrett/tls13-spec","description":"TLS 1.3 Specification","fork":true,"url":"https://api.github.com/repos/davegarrett/tls13-spec","forks_url":"https://api.github.com/repos/davegarrett/tls13-spec/forks","keys_url":"https://api.github.com/repos/davegarrett/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davegarrett/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davegarrett/tls13-spec/teams","hooks_url":"https://api.github.com/repos/davegarrett/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/davegarrett/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/davegarrett/tls13-spec/events","assignees_url":"https://api.github.com/repos/davegarrett/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/davegarrett/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/davegarrett/tls13-spec/tags","blobs_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davegarrett/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/davegarrett/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/davegarrett/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/davegarrett/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/davegarrett/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/davegarrett/tls13-spec/subscription","commits_url":"https://api.github.com/repos/davegarrett/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/davegarrett/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/davegarrett/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/davegarrett/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/davegarrett/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/davegarrett/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davegarrett/tls13-spec/merges","archive_url":"https://api.github.com/repos/davegarrett/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davegarrett/tls13-spec/downloads","issues_url":"https://api.github.com/repos/davegarrett/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/davegarrett/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/davegarrett/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/davegarrett/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davegarrett/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/davegarrett/tls13-spec/releases{/id}","created_at":"2014-12-20T03:19:02Z","updated_at":"2015-05-06T04:39:23Z","pushed_at":"2015-08-27T02:05:53Z","git_url":"git://github.com/davegarrett/tls13-spec.git","ssh_url":"git@github.com:davegarrett/tls13-spec.git","clone_url":"https://github.com/davegarrett/tls13-spec.git","svn_url":"https://github.com/davegarrett/tls13-spec","homepage":null,"size":1971,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tlswg:master","ref":"master","sha":"32d62f7e3518b1184c116b68f61cf9a49050a484","user":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"repo":{"id":18887842,"name":"tls13-spec","full_name":"tlswg/tls13-spec","owner":{"login":"tlswg","id":6699659,"avatar_url":"https://avatars.githubusercontent.com/u/6699659?v=3","gravatar_id":"","url":"https://api.github.com/users/tlswg","html_url":"https://github.com/tlswg","followers_url":"https://api.github.com/users/tlswg/followers","following_url":"https://api.github.com/users/tlswg/following{/other_user}","gists_url":"https://api.github.com/users/tlswg/gists{/gist_id}","starred_url":"https://api.github.com/users/tlswg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tlswg/subscriptions","organizations_url":"https://api.github.com/users/tlswg/orgs","repos_url":"https://api.github.com/users/tlswg/repos","events_url":"https://api.github.com/users/tlswg/events{/privacy}","received_events_url":"https://api.github.com/users/tlswg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tlswg/tls13-spec","description":"TLS 1.3 Specification","fork":false,"url":"https://api.github.com/repos/tlswg/tls13-spec","forks_url":"https://api.github.com/repos/tlswg/tls13-spec/forks","keys_url":"https://api.github.com/repos/tlswg/tls13-spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tlswg/tls13-spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tlswg/tls13-spec/teams","hooks_url":"https://api.github.com/repos/tlswg/tls13-spec/hooks","issue_events_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/events{/number}","events_url":"https://api.github.com/repos/tlswg/tls13-spec/events","assignees_url":"https://api.github.com/repos/tlswg/tls13-spec/assignees{/user}","branches_url":"https://api.github.com/repos/tlswg/tls13-spec/branches{/branch}","tags_url":"https://api.github.com/repos/tlswg/tls13-spec/tags","blobs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tlswg/tls13-spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tlswg/tls13-spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/tlswg/tls13-spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tlswg/tls13-spec/statuses/{sha}","languages_url":"https://api.github.com/repos/tlswg/tls13-spec/languages","stargazers_url":"https://api.github.com/repos/tlswg/tls13-spec/stargazers","contributors_url":"https://api.github.com/repos/tlswg/tls13-spec/contributors","subscribers_url":"https://api.github.com/repos/tlswg/tls13-spec/subscribers","subscription_url":"https://api.github.com/repos/tlswg/tls13-spec/subscription","commits_url":"https://api.github.com/repos/tlswg/tls13-spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/tlswg/tls13-spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/tlswg/tls13-spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/tlswg/tls13-spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/tlswg/tls13-spec/contents/{+path}","compare_url":"https://api.github.com/repos/tlswg/tls13-spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tlswg/tls13-spec/merges","archive_url":"https://api.github.com/repos/tlswg/tls13-spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tlswg/tls13-spec/downloads","issues_url":"https://api.github.com/repos/tlswg/tls13-spec/issues{/number}","pulls_url":"https://api.github.com/repos/tlswg/tls13-spec/pulls{/number}","milestones_url":"https://api.github.com/repos/tlswg/tls13-spec/milestones{/number}","notifications_url":"https://api.github.com/repos/tlswg/tls13-spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tlswg/tls13-spec/labels{/name}","releases_url":"https://api.github.com/repos/tlswg/tls13-spec/releases{/id}","created_at":"2014-04-17T17:52:32Z","updated_at":"2015-08-19T17:42:58Z","pushed_at":"2015-08-27T02:05:54Z","git_url":"git://github.com/tlswg/tls13-spec.git","ssh_url":"git@github.com:tlswg/tls13-spec.git","clone_url":"https://github.com/tlswg/tls13-spec.git","svn_url":"https://github.com/tlswg/tls13-spec","homepage":null,"size":3107,"stargazers_count":81,"watchers_count":81,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":28,"mirror_url":null,"open_issues_count":75,"forks":28,"open_issues":75,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201"},"html":{"href":"https://github.com/tlswg/tls13-spec/pull/201"},"issue":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/201"},"comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tlswg/tls13-spec/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/tlswg/tls13-spec/statuses/7b116fbc80d38e4ac0f2994bcff9a0ff77c9ff4e"}}}}