{"action":"created","issue":{"url":"https://api.github.com/repos/layerhq/Atlas-iOS/issues/886","labels_url":"https://api.github.com/repos/layerhq/Atlas-iOS/issues/886/labels{/name}","comments_url":"https://api.github.com/repos/layerhq/Atlas-iOS/issues/886/comments","events_url":"https://api.github.com/repos/layerhq/Atlas-iOS/issues/886/events","html_url":"https://github.com/layerhq/Atlas-iOS/pull/886","id":93392226,"number":886,"title":"Avatar Items","user":{"login":"andrewcopp","id":1331900,"avatar_url":"https://avatars.githubusercontent.com/u/1331900?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewcopp","html_url":"https://github.com/andrewcopp","followers_url":"https://api.github.com/users/andrewcopp/followers","following_url":"https://api.github.com/users/andrewcopp/following{/other_user}","gists_url":"https://api.github.com/users/andrewcopp/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewcopp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewcopp/subscriptions","organizations_url":"https://api.github.com/users/andrewcopp/orgs","repos_url":"https://api.github.com/users/andrewcopp/repos","events_url":"https://api.github.com/users/andrewcopp/events{/privacy}","received_events_url":"https://api.github.com/users/andrewcopp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-06T22:30:23Z","updated_at":"2015-07-09T21:38:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/layerhq/Atlas-iOS/pulls/886","html_url":"https://github.com/layerhq/Atlas-iOS/pull/886","diff_url":"https://github.com/layerhq/Atlas-iOS/pull/886.diff","patch_url":"https://github.com/layerhq/Atlas-iOS/pull/886.patch"},"body":"I know this violates your merge vs. rebase philosophy but I wanted to submit it and start getting feedback.\r\n\r\nOur team needs to be able to display avatars for all participants. I tried to do it in a way that wouldn't affect existing users. Please let me know what you think."},"comment":{"url":"https://api.github.com/repos/layerhq/Atlas-iOS/issues/comments/120150791","html_url":"https://github.com/layerhq/Atlas-iOS/pull/886#issuecomment-120150791","issue_url":"https://api.github.com/repos/layerhq/Atlas-iOS/issues/886","id":120150791,"user":{"login":"kmahal","id":1753989,"avatar_url":"https://avatars.githubusercontent.com/u/1753989?v=3","gravatar_id":"","url":"https://api.github.com/users/kmahal","html_url":"https://github.com/kmahal","followers_url":"https://api.github.com/users/kmahal/followers","following_url":"https://api.github.com/users/kmahal/following{/other_user}","gists_url":"https://api.github.com/users/kmahal/gists{/gist_id}","starred_url":"https://api.github.com/users/kmahal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmahal/subscriptions","organizations_url":"https://api.github.com/users/kmahal/orgs","repos_url":"https://api.github.com/users/kmahal/repos","events_url":"https://api.github.com/users/kmahal/events{/privacy}","received_events_url":"https://api.github.com/users/kmahal/received_events","type":"User","site_admin":false},"created_at":"2015-07-09T21:38:06Z","updated_at":"2015-07-09T21:38:06Z","body":"@andrewcopp overall the structure looks good.  If you see https://github.com/layerhq/Atlas-iOS/pull/861 they implement it similarly.  Because both subclasses can have avatar items, a lot of the common logic is moved to `ATLMessageCollectionViewCell` (the superclass), with just the specific layout constraints applied in the `lyr_CommonInit`.  The superclass can then change constraints in `- (void)shouldDisplayAvatarItem:(BOOL)shouldDisplayAvatarItem`.  Your `ATLAvatarItemDisplayFrequency` implementation looks solid.  Once this other PR gets refined and merged down (still has comments on it) then we can put your changes on top as well."}}