{"action":"created","issue":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/167","labels_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/167/labels{/name}","comments_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/167/comments","events_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/167/events","html_url":"https://github.com/solarkennedy/puppet-consul/pull/167","id":100676921,"number":167,"title":"Fix url upgrade and downgrade","user":{"login":"asasfu","id":11634602,"avatar_url":"https://avatars.githubusercontent.com/u/11634602?v=3","gravatar_id":"","url":"https://api.github.com/users/asasfu","html_url":"https://github.com/asasfu","followers_url":"https://api.github.com/users/asasfu/followers","following_url":"https://api.github.com/users/asasfu/following{/other_user}","gists_url":"https://api.github.com/users/asasfu/gists{/gist_id}","starred_url":"https://api.github.com/users/asasfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasfu/subscriptions","organizations_url":"https://api.github.com/users/asasfu/orgs","repos_url":"https://api.github.com/users/asasfu/repos","events_url":"https://api.github.com/users/asasfu/events{/privacy}","received_events_url":"https://api.github.com/users/asasfu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-13T02:30:49Z","updated_at":"2015-08-13T05:06:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/pulls/167","html_url":"https://github.com/solarkennedy/puppet-consul/pull/167","diff_url":"https://github.com/solarkennedy/puppet-consul/pull/167.diff","patch_url":"https://github.com/solarkennedy/puppet-consul/pull/167.patch"},"body":"This would allow support of upgrading and downgrading via URL method.  Version would be a required parameter only to upgrade or downgrade, if not supplied the file will just be for example, '_redhat_amd64.zip', not an issue.\r\n\r\nI have had talks with puppetlabs devs and puppetlabs-transition module is meant to help with this but it is still version 0.1.0 and I haven't seen it be maintained since earlier this year; so in the mean time I decided to go with the ruby calls.  I haven't tested yet if the transition module supports overrides like:\r\nService { provider => 'systemd' } or not.  In this current iteration I've not put support in here for it either, only conditional logic to support init_style changing the provider on the ruby call in the case of two unsupported distros in puppet 3.x\r\nI accept discussions on this of course.  We can also instead of a ruby call, use the slightly slower call of:\r\npuppet resource service consul provider=systemd ensure=stopped\r\n\r\nCheers,\r\n\r\nAdam"},"comment":{"url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/comments/130536765","html_url":"https://github.com/solarkennedy/puppet-consul/pull/167#issuecomment-130536765","issue_url":"https://api.github.com/repos/solarkennedy/puppet-consul/issues/167","id":130536765,"user":{"login":"asasfu","id":11634602,"avatar_url":"https://avatars.githubusercontent.com/u/11634602?v=3","gravatar_id":"","url":"https://api.github.com/users/asasfu","html_url":"https://github.com/asasfu","followers_url":"https://api.github.com/users/asasfu/followers","following_url":"https://api.github.com/users/asasfu/following{/other_user}","gists_url":"https://api.github.com/users/asasfu/gists{/gist_id}","starred_url":"https://api.github.com/users/asasfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asasfu/subscriptions","organizations_url":"https://api.github.com/users/asasfu/orgs","repos_url":"https://api.github.com/users/asasfu/repos","events_url":"https://api.github.com/users/asasfu/events{/privacy}","received_events_url":"https://api.github.com/users/asasfu/received_events","type":"User","site_admin":false},"created_at":"2015-08-13T05:06:39Z","updated_at":"2015-08-13T05:06:39Z","body":"Love it or leave it, I just gotta say puppet's versioncmp is a pain in the ass when they switched over to 4.x.  Plus I needed that ENV['PUPPET_VERSION'] in the init_spec for my fact puppetversion.\r\nEither way, feel free to discuss this stuff with me.  I know it looks ugly but it really does work.  Could probably use some rspec tests, not 100% sure what to write for those specific cases, something like var should equal 'certain text'..."}}