{"action":"created","issue":{"url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13","labels_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13/labels{/name}","comments_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13/comments","events_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13/events","html_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13","id":64726146,"number":13,"title":"[FIXED JENKINS-27637] Refactor the plugin to use new model field databinding","user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2015-03-27T09:23:15Z","updated_at":"2015-03-30T19:58:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/pulls/13","html_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13","diff_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13.diff","patch_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13.patch"},"body":"[JENKINS-27637](https://issues.jenkins-ci.org/browse/JENKINS-27637)\r\n\r\nCurrent implementation use Jenkins old style for databinding:\r\n\r\n```\r\n<f:entry title=\"Database\" help=\"/plugin/synergy/database.html\">\r\n\t\t<f:textbox name=\"synergy.database\" value=\"${scm.database}\" />\r\n</f:entry>\r\n```\r\nI just refactored this to use instead field argument:\r\n\r\n```\r\n<f:entry field=\"database\" title=\"Database\" help=\"${descriptor.getHelpFile('database')}\">\r\n\t\t<f:textbox />\r\n\t</f:entry>\r\n```\r\n\r\nAlso deleted all the:\r\n\r\n```\r\npublic Publisher newInstance(StaplerRequest req, JSONObject formData) throws FormException {\r\n...\r\n\r\nThe old databinding style makes not to save some fields correctly in new Jenkins installations.\r\n\r\nWhen this pull request is merged, I will create a new one to update pom.xml to a newer Jenkins version>1.424\r\n\r\n@reviewbybees\r\n@ndeloof\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/comments/87809563","html_url":"https://github.com/jenkinsci/synergy_scm-plugin/pull/13#issuecomment-87809563","issue_url":"https://api.github.com/repos/jenkinsci/synergy_scm-plugin/issues/13","id":87809563,"user":{"login":"fbelzunc","id":3898648,"avatar_url":"https://avatars.githubusercontent.com/u/3898648?v=3","gravatar_id":"","url":"https://api.github.com/users/fbelzunc","html_url":"https://github.com/fbelzunc","followers_url":"https://api.github.com/users/fbelzunc/followers","following_url":"https://api.github.com/users/fbelzunc/following{/other_user}","gists_url":"https://api.github.com/users/fbelzunc/gists{/gist_id}","starred_url":"https://api.github.com/users/fbelzunc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbelzunc/subscriptions","organizations_url":"https://api.github.com/users/fbelzunc/orgs","repos_url":"https://api.github.com/users/fbelzunc/repos","events_url":"https://api.github.com/users/fbelzunc/events{/privacy}","received_events_url":"https://api.github.com/users/fbelzunc/received_events","type":"User","site_admin":false},"created_at":"2015-03-30T19:58:40Z","updated_at":"2015-03-30T19:58:40Z","body":"@jglick I think it is fine now. Have I your `ok`?\r\n@angelakim I guess we will need to wait a little bit to see if the plugin maintainers show up."}}