{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/41129287","id":41129287,"diff_hunk":"@@ -39,7 +39,7 @@ class CaloHitID {\n   int          theTrackID;\n   int          theTimeSliceID;\n   uint16_t     theDepth;\n-  int          timeSliceUnit;\n+  double       timeSliceUnit;","path":"SimG4CMS/Calo/interface/CaloHitID.h","position":16,"original_position":16,"commit_id":"e7b85f630853ccc27b5b10000df89609518eb065","original_commit_id":"e7b85f630853ccc27b5b10000df89609518eb065","user":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars.githubusercontent.com/u/5033146?v=3","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"body":"It is better be a double (in any case this is a transient object)\n________________________________\nFrom: David Lange [notifications@github.com]\nSent: 04 October 2015 19:27\nTo: cms-sw/cmssw\nCc: Sunanda Banerjee\nSubject: Re: [cmssw] bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device (#11498)\n\n\nIn SimG4CMS/Calo/interface/CaloHitID.h<https://github.com/cms-sw/cmssw/pull/11498#discussion_r41099973>:\n\n> @@ -39,7 +39,7 @@ class CaloHitID {\n>    int          theTrackID;\n>    int          theTimeSliceID;\n>    uint16_t     theDepth;\n> -  int          timeSliceUnit;\n> +  double       timeSliceUnit;\n\n\n@bsunanda<https://github.com/bsunanda> - could this be a float?\n\n—\nReply to this email directly or view it on GitHub<https://github.com/cms-sw/cmssw/pull/11498/files#r41099973>.\n","created_at":"2015-10-05T10:27:06Z","updated_at":"2015-10-05T10:27:06Z","html_url":"https://github.com/cms-sw/cmssw/pull/11498#discussion_r41129287","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/41129287"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11498#discussion_r41129287"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498","id":46061295,"html_url":"https://github.com/cms-sw/cmssw/pull/11498","diff_url":"https://github.com/cms-sw/cmssw/pull/11498.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/11498.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11498","number":11498,"state":"open","locked":false,"title":"bsunanda:Run2-hcx31 Add simulation code for HGCal and single layer fast timing device","user":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars.githubusercontent.com/u/5033146?v=3","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"body":"Code of detectors only for Phase 2.","created_at":"2015-09-25T21:41:08Z","updated_at":"2015-10-05T10:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"502f8963b1e3039feed7800ab0a04b2100954566","assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_6_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/55/labels","id":1176788,"number":55,"title":"Next CMSSW_7_6_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":72,"closed_issues":817,"state":"open","created_at":"2015-06-23T07:27:04Z","updated_at":"2015-10-05T10:25:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/11498/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/e7b85f630853ccc27b5b10000df89609518eb065","head":{"label":"bsunanda:Run2-hcx31","ref":"Run2-hcx31","sha":"e7b85f630853ccc27b5b10000df89609518eb065","user":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars.githubusercontent.com/u/5033146?v=3","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"repo":{"id":11500018,"name":"cmssw","full_name":"bsunanda/cmssw","owner":{"login":"bsunanda","id":5033146,"avatar_url":"https://avatars.githubusercontent.com/u/5033146?v=3","gravatar_id":"","url":"https://api.github.com/users/bsunanda","html_url":"https://github.com/bsunanda","followers_url":"https://api.github.com/users/bsunanda/followers","following_url":"https://api.github.com/users/bsunanda/following{/other_user}","gists_url":"https://api.github.com/users/bsunanda/gists{/gist_id}","starred_url":"https://api.github.com/users/bsunanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsunanda/subscriptions","organizations_url":"https://api.github.com/users/bsunanda/orgs","repos_url":"https://api.github.com/users/bsunanda/repos","events_url":"https://api.github.com/users/bsunanda/events{/privacy}","received_events_url":"https://api.github.com/users/bsunanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bsunanda/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/bsunanda/cmssw","forks_url":"https://api.github.com/repos/bsunanda/cmssw/forks","keys_url":"https://api.github.com/repos/bsunanda/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bsunanda/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bsunanda/cmssw/teams","hooks_url":"https://api.github.com/repos/bsunanda/cmssw/hooks","issue_events_url":"https://api.github.com/repos/bsunanda/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/bsunanda/cmssw/events","assignees_url":"https://api.github.com/repos/bsunanda/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/bsunanda/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/bsunanda/cmssw/tags","blobs_url":"https://api.github.com/repos/bsunanda/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bsunanda/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bsunanda/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/bsunanda/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bsunanda/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/bsunanda/cmssw/languages","stargazers_url":"https://api.github.com/repos/bsunanda/cmssw/stargazers","contributors_url":"https://api.github.com/repos/bsunanda/cmssw/contributors","subscribers_url":"https://api.github.com/repos/bsunanda/cmssw/subscribers","subscription_url":"https://api.github.com/repos/bsunanda/cmssw/subscription","commits_url":"https://api.github.com/repos/bsunanda/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/bsunanda/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/bsunanda/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/bsunanda/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/bsunanda/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/bsunanda/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bsunanda/cmssw/merges","archive_url":"https://api.github.com/repos/bsunanda/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bsunanda/cmssw/downloads","issues_url":"https://api.github.com/repos/bsunanda/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/bsunanda/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/bsunanda/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/bsunanda/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bsunanda/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/bsunanda/cmssw/releases{/id}","created_at":"2013-07-18T10:17:16Z","updated_at":"2014-06-25T09:42:43Z","pushed_at":"2015-10-05T09:40:52Z","git_url":"git://github.com/bsunanda/cmssw.git","ssh_url":"git@github.com:bsunanda/cmssw.git","clone_url":"https://github.com/bsunanda/cmssw.git","svn_url":"https://github.com/bsunanda/cmssw","homepage":"cms-sw.github.io/cmssw","size":804401,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:CMSSW_7_6_X","ref":"CMSSW_7_6_X","sha":"8c7990744325344965fc4fe15cfc52a59a549243","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","created_at":"2013-06-26T14:09:07Z","updated_at":"2015-10-05T02:56:38Z","pushed_at":"2015-10-05T10:26:26Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1297626,"stargazers_count":263,"watchers_count":263,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1579,"mirror_url":null,"open_issues_count":267,"forks":1579,"open_issues":267,"watchers":263,"default_branch":"CMSSW_7_6_X"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/11498"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11498"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/11498/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/11498/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/e7b85f630853ccc27b5b10000df89609518eb065"}}}}