{"action":"closed","number":1081,"pull_request":{"url":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1081","id":37200295,"html_url":"https://github.com/libgit2/libgit2sharp/pull/1081","diff_url":"https://github.com/libgit2/libgit2sharp/pull/1081.diff","patch_url":"https://github.com/libgit2/libgit2sharp/pull/1081.patch","issue_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1081","number":1081,"state":"closed","locked":false,"title":"Fixes Coverity NullReferenceException Issues","user":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"body":"The new-again Coverity scanning has started to bear fruit. Here are some of the NRE issues identified by the scan. Minor fixes, low risk. **Not sure if I'm throwing the correct exception types** here (/CC @nulltoken).\r\n\r\n1. Do not assume disk reads always succeed, check results before processing.\r\n2. Verify parameters being using.\r\n3. There's more than one kind of `null` when dealing with p/invoke and handles.\r\n4. Better to give specific exceptions than general exceptions when reading in bad data.","created_at":"2015-06-08T21:56:06Z","updated_at":"2015-06-09T07:28:36Z","closed_at":"2015-06-09T07:28:36Z","merged_at":"2015-06-09T07:28:36Z","merge_commit_sha":"78748f3268bae5f98e33c81377fef51273680078","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1081/commits","review_comments_url":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1081/comments","review_comment_url":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1081/comments","statuses_url":"https://api.github.com/repos/libgit2/libgit2sharp/statuses/fba0a7352d795cc81f995fb1db10778d9bfe8ba5","head":{"label":"whoisj:fix-coverity-nre-issues","ref":"fix-coverity-nre-issues","sha":"fba0a7352d795cc81f995fb1db10778d9bfe8ba5","user":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"repo":{"id":34470330,"name":"libgit2sharp","full_name":"whoisj/libgit2sharp","owner":{"login":"whoisj","id":11578325,"avatar_url":"https://avatars.githubusercontent.com/u/11578325?v=3","gravatar_id":"","url":"https://api.github.com/users/whoisj","html_url":"https://github.com/whoisj","followers_url":"https://api.github.com/users/whoisj/followers","following_url":"https://api.github.com/users/whoisj/following{/other_user}","gists_url":"https://api.github.com/users/whoisj/gists{/gist_id}","starred_url":"https://api.github.com/users/whoisj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whoisj/subscriptions","organizations_url":"https://api.github.com/users/whoisj/orgs","repos_url":"https://api.github.com/users/whoisj/repos","events_url":"https://api.github.com/users/whoisj/events{/privacy}","received_events_url":"https://api.github.com/users/whoisj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/whoisj/libgit2sharp","description":"Git + .Net/Mono = ❤","fork":true,"url":"https://api.github.com/repos/whoisj/libgit2sharp","forks_url":"https://api.github.com/repos/whoisj/libgit2sharp/forks","keys_url":"https://api.github.com/repos/whoisj/libgit2sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/whoisj/libgit2sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/whoisj/libgit2sharp/teams","hooks_url":"https://api.github.com/repos/whoisj/libgit2sharp/hooks","issue_events_url":"https://api.github.com/repos/whoisj/libgit2sharp/issues/events{/number}","events_url":"https://api.github.com/repos/whoisj/libgit2sharp/events","assignees_url":"https://api.github.com/repos/whoisj/libgit2sharp/assignees{/user}","branches_url":"https://api.github.com/repos/whoisj/libgit2sharp/branches{/branch}","tags_url":"https://api.github.com/repos/whoisj/libgit2sharp/tags","blobs_url":"https://api.github.com/repos/whoisj/libgit2sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/whoisj/libgit2sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/whoisj/libgit2sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/whoisj/libgit2sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/whoisj/libgit2sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/whoisj/libgit2sharp/languages","stargazers_url":"https://api.github.com/repos/whoisj/libgit2sharp/stargazers","contributors_url":"https://api.github.com/repos/whoisj/libgit2sharp/contributors","subscribers_url":"https://api.github.com/repos/whoisj/libgit2sharp/subscribers","subscription_url":"https://api.github.com/repos/whoisj/libgit2sharp/subscription","commits_url":"https://api.github.com/repos/whoisj/libgit2sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/whoisj/libgit2sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/whoisj/libgit2sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/whoisj/libgit2sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/whoisj/libgit2sharp/contents/{+path}","compare_url":"https://api.github.com/repos/whoisj/libgit2sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/whoisj/libgit2sharp/merges","archive_url":"https://api.github.com/repos/whoisj/libgit2sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/whoisj/libgit2sharp/downloads","issues_url":"https://api.github.com/repos/whoisj/libgit2sharp/issues{/number}","pulls_url":"https://api.github.com/repos/whoisj/libgit2sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/whoisj/libgit2sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/whoisj/libgit2sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/whoisj/libgit2sharp/labels{/name}","releases_url":"https://api.github.com/repos/whoisj/libgit2sharp/releases{/id}","created_at":"2015-04-23T17:12:28Z","updated_at":"2015-04-30T21:31:57Z","pushed_at":"2015-06-08T23:04:16Z","git_url":"git://github.com/whoisj/libgit2sharp.git","ssh_url":"git@github.com:whoisj/libgit2sharp.git","clone_url":"https://github.com/whoisj/libgit2sharp.git","svn_url":"https://github.com/whoisj/libgit2sharp","homepage":"http://libgit2.github.com","size":142742,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"vNext"}},"base":{"label":"libgit2:vNext","ref":"vNext","sha":"7cb2d7ee2c316c5f59b51053fbf7fbf6aa526d49","user":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"repo":{"id":1415168,"name":"libgit2sharp","full_name":"libgit2/libgit2sharp","owner":{"login":"libgit2","id":394745,"avatar_url":"https://avatars.githubusercontent.com/u/394745?v=3","gravatar_id":"","url":"https://api.github.com/users/libgit2","html_url":"https://github.com/libgit2","followers_url":"https://api.github.com/users/libgit2/followers","following_url":"https://api.github.com/users/libgit2/following{/other_user}","gists_url":"https://api.github.com/users/libgit2/gists{/gist_id}","starred_url":"https://api.github.com/users/libgit2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libgit2/subscriptions","organizations_url":"https://api.github.com/users/libgit2/orgs","repos_url":"https://api.github.com/users/libgit2/repos","events_url":"https://api.github.com/users/libgit2/events{/privacy}","received_events_url":"https://api.github.com/users/libgit2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/libgit2/libgit2sharp","description":"Git + .NET/Mono = ❤","fork":false,"url":"https://api.github.com/repos/libgit2/libgit2sharp","forks_url":"https://api.github.com/repos/libgit2/libgit2sharp/forks","keys_url":"https://api.github.com/repos/libgit2/libgit2sharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libgit2/libgit2sharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libgit2/libgit2sharp/teams","hooks_url":"https://api.github.com/repos/libgit2/libgit2sharp/hooks","issue_events_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/events{/number}","events_url":"https://api.github.com/repos/libgit2/libgit2sharp/events","assignees_url":"https://api.github.com/repos/libgit2/libgit2sharp/assignees{/user}","branches_url":"https://api.github.com/repos/libgit2/libgit2sharp/branches{/branch}","tags_url":"https://api.github.com/repos/libgit2/libgit2sharp/tags","blobs_url":"https://api.github.com/repos/libgit2/libgit2sharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libgit2/libgit2sharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libgit2/libgit2sharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/libgit2/libgit2sharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libgit2/libgit2sharp/statuses/{sha}","languages_url":"https://api.github.com/repos/libgit2/libgit2sharp/languages","stargazers_url":"https://api.github.com/repos/libgit2/libgit2sharp/stargazers","contributors_url":"https://api.github.com/repos/libgit2/libgit2sharp/contributors","subscribers_url":"https://api.github.com/repos/libgit2/libgit2sharp/subscribers","subscription_url":"https://api.github.com/repos/libgit2/libgit2sharp/subscription","commits_url":"https://api.github.com/repos/libgit2/libgit2sharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/libgit2/libgit2sharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/libgit2/libgit2sharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/libgit2/libgit2sharp/contents/{+path}","compare_url":"https://api.github.com/repos/libgit2/libgit2sharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libgit2/libgit2sharp/merges","archive_url":"https://api.github.com/repos/libgit2/libgit2sharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libgit2/libgit2sharp/downloads","issues_url":"https://api.github.com/repos/libgit2/libgit2sharp/issues{/number}","pulls_url":"https://api.github.com/repos/libgit2/libgit2sharp/pulls{/number}","milestones_url":"https://api.github.com/repos/libgit2/libgit2sharp/milestones{/number}","notifications_url":"https://api.github.com/repos/libgit2/libgit2sharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libgit2/libgit2sharp/labels{/name}","releases_url":"https://api.github.com/repos/libgit2/libgit2sharp/releases{/id}","created_at":"2011-02-26T16:44:49Z","updated_at":"2015-06-09T07:25:56Z","pushed_at":"2015-06-09T07:28:36Z","git_url":"git://github.com/libgit2/libgit2sharp.git","ssh_url":"git@github.com:libgit2/libgit2sharp.git","clone_url":"https://github.com/libgit2/libgit2sharp.git","svn_url":"https://github.com/libgit2/libgit2sharp","homepage":"http://libgit2.github.com","size":237519,"stargazers_count":787,"watchers_count":787,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":326,"mirror_url":null,"open_issues_count":142,"forks":326,"open_issues":142,"watchers":787,"default_branch":"vNext"}},"_links":{"self":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1081"},"html":{"href":"https://github.com/libgit2/libgit2sharp/pull/1081"},"issue":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1081"},"comments":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/issues/1081/comments"},"review_comments":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1081/comments"},"review_comment":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/pulls/1081/commits"},"statuses":{"href":"https://api.github.com/repos/libgit2/libgit2sharp/statuses/fba0a7352d795cc81f995fb1db10778d9bfe8ba5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"nulltoken","id":92363,"avatar_url":"https://avatars.githubusercontent.com/u/92363?v=3","gravatar_id":"","url":"https://api.github.com/users/nulltoken","html_url":"https://github.com/nulltoken","followers_url":"https://api.github.com/users/nulltoken/followers","following_url":"https://api.github.com/users/nulltoken/following{/other_user}","gists_url":"https://api.github.com/users/nulltoken/gists{/gist_id}","starred_url":"https://api.github.com/users/nulltoken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nulltoken/subscriptions","organizations_url":"https://api.github.com/users/nulltoken/orgs","repos_url":"https://api.github.com/users/nulltoken/repos","events_url":"https://api.github.com/users/nulltoken/events{/privacy}","received_events_url":"https://api.github.com/users/nulltoken/received_events","type":"User","site_admin":false},"comments":2,"review_comments":7,"commits":2,"additions":11,"deletions":2,"changed_files":2}}