{"action":"created","comment":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/31373290","id":31373290,"diff_hunk":"@@ -65,10 +65,11 @@ void _gnix_convert_key_to_mhdl(\n \t\tIN    gnix_mr_key_t *key,\n \t\tINOUT gni_mem_handle_t *mhdl)\n {\n-\tuint64_t va = (uint64_t) __sign_extend(key->pfn << PAGE_SHIFT,\n-\t\t\tGNIX_MR_VA_BITS);\n+\tuint64_t va = key->pfn;\n \tuint8_t flags = 0;\n \n+\tva = (uint64_t) __sign_extend(va << PAGE_SHIFT, GNIX_MR_VA_BITS);\n+\n \tif (key->flags & GNIX_MR_FLAG_READONLY)","path":"prov/gni/src/gnix_mr.c","position":11,"original_position":11,"commit_id":"09dcd28cb38018557d3c018412dc790a9e3d69f6","original_commit_id":"09dcd28cb38018557d3c018412dc790a9e3d69f6","user":{"login":"sungeunchoi","id":4294511,"avatar_url":"https://avatars.githubusercontent.com/u/4294511?v=3","gravatar_id":"","url":"https://api.github.com/users/sungeunchoi","html_url":"https://github.com/sungeunchoi","followers_url":"https://api.github.com/users/sungeunchoi/followers","following_url":"https://api.github.com/users/sungeunchoi/following{/other_user}","gists_url":"https://api.github.com/users/sungeunchoi/gists{/gist_id}","starred_url":"https://api.github.com/users/sungeunchoi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sungeunchoi/subscriptions","organizations_url":"https://api.github.com/users/sungeunchoi/orgs","repos_url":"https://api.github.com/users/sungeunchoi/repos","events_url":"https://api.github.com/users/sungeunchoi/events{/privacy}","received_events_url":"https://api.github.com/users/sungeunchoi/received_events","type":"User","site_admin":false},"body":"Ah thanks for the clarification.  Can you add a comment so that no one changes it back?","created_at":"2015-05-29T23:31:23Z","updated_at":"2015-05-29T23:31:23Z","html_url":"https://github.com/ofi-cray/libfabric-cray/pull/196#discussion_r31373290","pull_request_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196","_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments/31373290"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/196#discussion_r31373290"},"pull_request":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196"}}},"pull_request":{"url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196","id":36532411,"html_url":"https://github.com/ofi-cray/libfabric-cray/pull/196","diff_url":"https://github.com/ofi-cray/libfabric-cray/pull/196.diff","patch_url":"https://github.com/ofi-cray/libfabric-cray/pull/196.patch","issue_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/196","number":196,"state":"open","locked":false,"title":"Initial RMA work","user":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"body":"Here is my initial RMA commit for early review.\r\n\r\n@jswaro @sungeunchoi @hppritcha","created_at":"2015-05-29T18:29:43Z","updated_at":"2015-05-29T23:31:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8949ae5126901b64b8e2793f3266bafeba08fda1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196/commits","review_comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196/comments","review_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/196/comments","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/09dcd28cb38018557d3c018412dc790a9e3d69f6","head":{"label":"ztiffany:rma","ref":"rma","sha":"09dcd28cb38018557d3c018412dc790a9e3d69f6","user":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"repo":{"id":32935123,"name":"libfabric-cray","full_name":"ztiffany/libfabric-cray","owner":{"login":"ztiffany","id":10633253,"avatar_url":"https://avatars.githubusercontent.com/u/10633253?v=3","gravatar_id":"","url":"https://api.github.com/users/ztiffany","html_url":"https://github.com/ztiffany","followers_url":"https://api.github.com/users/ztiffany/followers","following_url":"https://api.github.com/users/ztiffany/following{/other_user}","gists_url":"https://api.github.com/users/ztiffany/gists{/gist_id}","starred_url":"https://api.github.com/users/ztiffany/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ztiffany/subscriptions","organizations_url":"https://api.github.com/users/ztiffany/orgs","repos_url":"https://api.github.com/users/ztiffany/repos","events_url":"https://api.github.com/users/ztiffany/events{/privacy}","received_events_url":"https://api.github.com/users/ztiffany/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ztiffany/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ztiffany/libfabric-cray","forks_url":"https://api.github.com/repos/ztiffany/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ztiffany/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ztiffany/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ztiffany/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ztiffany/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ztiffany/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ztiffany/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ztiffany/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ztiffany/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ztiffany/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ztiffany/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ztiffany/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ztiffany/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ztiffany/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ztiffany/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ztiffany/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ztiffany/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ztiffany/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ztiffany/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ztiffany/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ztiffany/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ztiffany/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ztiffany/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ztiffany/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ztiffany/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ztiffany/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ztiffany/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ztiffany/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ztiffany/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ztiffany/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ztiffany/libfabric-cray/releases{/id}","created_at":"2015-03-26T15:19:55Z","updated_at":"2015-03-26T15:19:56Z","pushed_at":"2015-05-29T18:26:06Z","git_url":"git://github.com/ztiffany/libfabric-cray.git","ssh_url":"git@github.com:ztiffany/libfabric-cray.git","clone_url":"https://github.com/ztiffany/libfabric-cray.git","svn_url":"https://github.com/ztiffany/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":6302,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofi-cray:master","ref":"master","sha":"c23201bddc9c547e8997b46e485a48e2054fab3c","user":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"repo":{"id":29607348,"name":"libfabric-cray","full_name":"ofi-cray/libfabric-cray","owner":{"login":"ofi-cray","id":10637979,"avatar_url":"https://avatars.githubusercontent.com/u/10637979?v=3","gravatar_id":"","url":"https://api.github.com/users/ofi-cray","html_url":"https://github.com/ofi-cray","followers_url":"https://api.github.com/users/ofi-cray/followers","following_url":"https://api.github.com/users/ofi-cray/following{/other_user}","gists_url":"https://api.github.com/users/ofi-cray/gists{/gist_id}","starred_url":"https://api.github.com/users/ofi-cray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofi-cray/subscriptions","organizations_url":"https://api.github.com/users/ofi-cray/orgs","repos_url":"https://api.github.com/users/ofi-cray/repos","events_url":"https://api.github.com/users/ofi-cray/events{/privacy}","received_events_url":"https://api.github.com/users/ofi-cray/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofi-cray/libfabric-cray","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/ofi-cray/libfabric-cray","forks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/forks","keys_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/teams","hooks_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/hooks","issue_events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/events{/number}","events_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/events","assignees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/assignees{/user}","branches_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/branches{/branch}","tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/tags","blobs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/{sha}","languages_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/languages","stargazers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/stargazers","contributors_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contributors","subscribers_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscribers","subscription_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/subscription","commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/contents/{+path}","compare_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/merges","archive_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/downloads","issues_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues{/number}","pulls_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls{/number}","milestones_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/milestones{/number}","notifications_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/labels{/name}","releases_url":"https://api.github.com/repos/ofi-cray/libfabric-cray/releases{/id}","created_at":"2015-01-21T19:30:52Z","updated_at":"2015-05-12T21:53:26Z","pushed_at":"2015-05-29T21:13:03Z","git_url":"git://github.com/ofi-cray/libfabric-cray.git","ssh_url":"git@github.com:ofi-cray/libfabric-cray.git","clone_url":"https://github.com/ofi-cray/libfabric-cray.git","svn_url":"https://github.com/ofi-cray/libfabric-cray","homepage":"http://ofiwg.github.io/libfabric/","size":11881,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":30,"forks":3,"open_issues":30,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196"},"html":{"href":"https://github.com/ofi-cray/libfabric-cray/pull/196"},"issue":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/196"},"comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/issues/196/comments"},"review_comments":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196/comments"},"review_comment":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/pulls/196/commits"},"statuses":{"href":"https://api.github.com/repos/ofi-cray/libfabric-cray/statuses/09dcd28cb38018557d3c018412dc790a9e3d69f6"}}}}