{"action":"created","issue":{"url":"https://api.github.com/repos/videojs/video.js/issues/1932","labels_url":"https://api.github.com/repos/videojs/video.js/issues/1932/labels{/name}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/1932/comments","events_url":"https://api.github.com/repos/videojs/video.js/issues/1932/events","html_url":"https://github.com/videojs/video.js/pull/1932","id":60043949,"number":1932,"title":"Research Spike: Switching buttons to use the button element","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/videojs/video.js/labels/confirmed","name":"confirmed","color":"00CC00"},{"url":"https://api.github.com/repos/videojs/video.js/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/videojs/video.js/milestones/4","html_url":"https://github.com/videojs/video.js/milestones/v5.0.0","labels_url":"https://api.github.com/repos/videojs/video.js/milestones/4/labels","id":496725,"number":4,"title":"v5.0.0","description":"","creator":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":2,"state":"open","created_at":"2013-11-26T00:05:50Z","updated_at":"2015-03-06T01:11:46Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-03-06T01:11:33Z","updated_at":"2015-03-16T20:06:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/1932","html_url":"https://github.com/videojs/video.js/pull/1932","diff_url":"https://github.com/videojs/video.js/pull/1932.diff","patch_url":"https://github.com/videojs/video.js/pull/1932.patch"},"body":"For v5.0 we've been discussing switching to `<button>` instead of `<div>` for all the UI buttons. The general opinion among usability experts is that `<button>` is still better than `<div>` even with all the accessibility enhancements you can do (e.g. ARIA) because certain screen readers still won't support the enhanced divs. A [comment on css-tricks](https://css-tricks.com/use-button-element/#comment-1068889) confirms this for the Nuance Natural Speak app at least, though it would be great to have more specific examples if anyone knows of a resource or has details on specific screen readers to add here.\r\n\r\nThis PR has the very minimum required to switch to buttons so that they still look right in all browsers. Tested so far in IE8, IE11, Chrome, Firefox, and Safari Desktop.\r\n\r\nThis does not consider additional specificity that will be need to protect the buttons from being affected by external styles. The next steps will be to add additional property settings and a more specific scope. We at least need enough to be safe within a framework like Foundation that [adds a ton of styles to the base button element](https://github.com/zurb/foundation/blob/af84aa4153d5ee25197ec9f38b735072d80fd316/scss/foundation/components/_buttons.scss#L213).\r\n\r\nRelated issues: #841, #1499, #1880\r\nRelated contributors: @gdkraus, @OwenEdwards, @baloneysandwiches, @karlgroves\r\n"},"comment":{"url":"https://api.github.com/repos/videojs/video.js/issues/comments/81908326","html_url":"https://github.com/videojs/video.js/pull/1932#issuecomment-81908326","issue_url":"https://api.github.com/repos/videojs/video.js/issues/1932","id":81908326,"user":{"login":"dmlap","id":56667,"avatar_url":"https://avatars.githubusercontent.com/u/56667?v=3","gravatar_id":"","url":"https://api.github.com/users/dmlap","html_url":"https://github.com/dmlap","followers_url":"https://api.github.com/users/dmlap/followers","following_url":"https://api.github.com/users/dmlap/following{/other_user}","gists_url":"https://api.github.com/users/dmlap/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlap/subscriptions","organizations_url":"https://api.github.com/users/dmlap/orgs","repos_url":"https://api.github.com/users/dmlap/repos","events_url":"https://api.github.com/users/dmlap/events{/privacy}","received_events_url":"https://api.github.com/users/dmlap/received_events","type":"User","site_admin":false},"created_at":"2015-03-16T20:06:27Z","updated_at":"2015-03-16T20:06:27Z","body":"lgtm"}}