{"action":"created","comment":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/23767248","id":23767248,"diff_hunk":"@@ -446,6 +446,11 @@ AppendToDefines(HAVE_DECL_ISNAN)\n CHECK_CXX_SYMBOL_EXISTS(signgam \"cmath\" HAVE_DECL_SIGNGAM)\n AppendToDefines(HAVE_DECL_SIGNGAM)\n \n+CHECK_CXX_SYMBOL_EXISTS(fdopen \"stdio.h\" HAVE_FDOPEN)\n+IF(HAVE_FDOPEN)\n+    LIST(APPEND DEFINES HAVE_FDOPEN)\n+ENDIF()","path":"CMakeLists.txt","position":7,"original_position":7,"commit_id":"8079fb02fb3f2e06b636bcdc3f32b56aaecb21b1","original_commit_id":"8079fb02fb3f2e06b636bcdc3f32b56aaecb21b1","user":{"login":"iglesias","id":1158006,"avatar_url":"https://avatars.githubusercontent.com/u/1158006?v=3","gravatar_id":"","url":"https://api.github.com/users/iglesias","html_url":"https://github.com/iglesias","followers_url":"https://api.github.com/users/iglesias/followers","following_url":"https://api.github.com/users/iglesias/following{/other_user}","gists_url":"https://api.github.com/users/iglesias/gists{/gist_id}","starred_url":"https://api.github.com/users/iglesias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iglesias/subscriptions","organizations_url":"https://api.github.com/users/iglesias/orgs","repos_url":"https://api.github.com/users/iglesias/repos","events_url":"https://api.github.com/users/iglesias/events{/privacy}","received_events_url":"https://api.github.com/users/iglesias/received_events","type":"User","site_admin":false},"body":"What about `AppendToDefines(HAVE_FDOPEN)` instead of this if? It is more succint :)","created_at":"2015-01-29T13:37:39Z","updated_at":"2015-01-29T13:37:39Z","html_url":"https://github.com/shogun-toolbox/shogun/pull/2684#discussion_r23767248","pull_request_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684","_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/23767248"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/2684#discussion_r23767248"},"pull_request":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684"}}},"pull_request":{"url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684","id":28267607,"html_url":"https://github.com/shogun-toolbox/shogun/pull/2684","diff_url":"https://github.com/shogun-toolbox/shogun/pull/2684.diff","patch_url":"https://github.com/shogun-toolbox/shogun/pull/2684.patch","issue_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/2684","number":2684,"state":"open","locked":false,"title":"Optional fdopen calls","user":{"login":"lisitsyn","id":424629,"avatar_url":"https://avatars.githubusercontent.com/u/424629?v=3","gravatar_id":"","url":"https://api.github.com/users/lisitsyn","html_url":"https://github.com/lisitsyn","followers_url":"https://api.github.com/users/lisitsyn/followers","following_url":"https://api.github.com/users/lisitsyn/following{/other_user}","gists_url":"https://api.github.com/users/lisitsyn/gists{/gist_id}","starred_url":"https://api.github.com/users/lisitsyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisitsyn/subscriptions","organizations_url":"https://api.github.com/users/lisitsyn/orgs","repos_url":"https://api.github.com/users/lisitsyn/repos","events_url":"https://api.github.com/users/lisitsyn/events{/privacy}","received_events_url":"https://api.github.com/users/lisitsyn/received_events","type":"User","site_admin":false},"body":"POSIX C and ANSI C differs in their support of the fdopen function.\r\n\r\nAdded cmake check and ifdef for these fdopen calls\r\n\r\nRelates #2380","created_at":"2015-01-29T10:24:24Z","updated_at":"2015-01-29T13:37:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aeb2c0ff784e491761d5b285d6b7957228c445d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684/commits","review_comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684/comments","review_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/{number}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/2684/comments","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/8079fb02fb3f2e06b636bcdc3f32b56aaecb21b1","head":{"label":"lisitsyn:bugfix/cygwin_fdopen","ref":"bugfix/cygwin_fdopen","sha":"8079fb02fb3f2e06b636bcdc3f32b56aaecb21b1","user":{"login":"lisitsyn","id":424629,"avatar_url":"https://avatars.githubusercontent.com/u/424629?v=3","gravatar_id":"","url":"https://api.github.com/users/lisitsyn","html_url":"https://github.com/lisitsyn","followers_url":"https://api.github.com/users/lisitsyn/followers","following_url":"https://api.github.com/users/lisitsyn/following{/other_user}","gists_url":"https://api.github.com/users/lisitsyn/gists{/gist_id}","starred_url":"https://api.github.com/users/lisitsyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisitsyn/subscriptions","organizations_url":"https://api.github.com/users/lisitsyn/orgs","repos_url":"https://api.github.com/users/lisitsyn/repos","events_url":"https://api.github.com/users/lisitsyn/events{/privacy}","received_events_url":"https://api.github.com/users/lisitsyn/received_events","type":"User","site_admin":false},"repo":{"id":26868719,"name":"shogun","full_name":"lisitsyn/shogun","owner":{"login":"lisitsyn","id":424629,"avatar_url":"https://avatars.githubusercontent.com/u/424629?v=3","gravatar_id":"","url":"https://api.github.com/users/lisitsyn","html_url":"https://github.com/lisitsyn","followers_url":"https://api.github.com/users/lisitsyn/followers","following_url":"https://api.github.com/users/lisitsyn/following{/other_user}","gists_url":"https://api.github.com/users/lisitsyn/gists{/gist_id}","starred_url":"https://api.github.com/users/lisitsyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lisitsyn/subscriptions","organizations_url":"https://api.github.com/users/lisitsyn/orgs","repos_url":"https://api.github.com/users/lisitsyn/repos","events_url":"https://api.github.com/users/lisitsyn/events{/privacy}","received_events_url":"https://api.github.com/users/lisitsyn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lisitsyn/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":true,"url":"https://api.github.com/repos/lisitsyn/shogun","forks_url":"https://api.github.com/repos/lisitsyn/shogun/forks","keys_url":"https://api.github.com/repos/lisitsyn/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lisitsyn/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lisitsyn/shogun/teams","hooks_url":"https://api.github.com/repos/lisitsyn/shogun/hooks","issue_events_url":"https://api.github.com/repos/lisitsyn/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/lisitsyn/shogun/events","assignees_url":"https://api.github.com/repos/lisitsyn/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/lisitsyn/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/lisitsyn/shogun/tags","blobs_url":"https://api.github.com/repos/lisitsyn/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lisitsyn/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lisitsyn/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/lisitsyn/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lisitsyn/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/lisitsyn/shogun/languages","stargazers_url":"https://api.github.com/repos/lisitsyn/shogun/stargazers","contributors_url":"https://api.github.com/repos/lisitsyn/shogun/contributors","subscribers_url":"https://api.github.com/repos/lisitsyn/shogun/subscribers","subscription_url":"https://api.github.com/repos/lisitsyn/shogun/subscription","commits_url":"https://api.github.com/repos/lisitsyn/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/lisitsyn/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/lisitsyn/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/lisitsyn/shogun/issues/comments/{number}","contents_url":"https://api.github.com/repos/lisitsyn/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/lisitsyn/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lisitsyn/shogun/merges","archive_url":"https://api.github.com/repos/lisitsyn/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lisitsyn/shogun/downloads","issues_url":"https://api.github.com/repos/lisitsyn/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/lisitsyn/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/lisitsyn/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/lisitsyn/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lisitsyn/shogun/labels{/name}","releases_url":"https://api.github.com/repos/lisitsyn/shogun/releases{/id}","created_at":"2014-11-19T15:52:03Z","updated_at":"2015-01-27T19:44:45Z","pushed_at":"2015-01-29T10:20:08Z","git_url":"git://github.com/lisitsyn/shogun.git","ssh_url":"git@github.com:lisitsyn/shogun.git","clone_url":"https://github.com/lisitsyn/shogun.git","svn_url":"https://github.com/lisitsyn/shogun","homepage":"http://www.shogun-toolbox.org","size":50397,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"shogun-toolbox:develop","ref":"develop","sha":"abcf0ef6b428607b2948e78a3fb18464da6398ab","user":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars.githubusercontent.com/u/690673?v=3","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"repo":{"id":1555094,"name":"shogun","full_name":"shogun-toolbox/shogun","owner":{"login":"shogun-toolbox","id":690673,"avatar_url":"https://avatars.githubusercontent.com/u/690673?v=3","gravatar_id":"","url":"https://api.github.com/users/shogun-toolbox","html_url":"https://github.com/shogun-toolbox","followers_url":"https://api.github.com/users/shogun-toolbox/followers","following_url":"https://api.github.com/users/shogun-toolbox/following{/other_user}","gists_url":"https://api.github.com/users/shogun-toolbox/gists{/gist_id}","starred_url":"https://api.github.com/users/shogun-toolbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shogun-toolbox/subscriptions","organizations_url":"https://api.github.com/users/shogun-toolbox/orgs","repos_url":"https://api.github.com/users/shogun-toolbox/repos","events_url":"https://api.github.com/users/shogun-toolbox/events{/privacy}","received_events_url":"https://api.github.com/users/shogun-toolbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shogun-toolbox/shogun","description":"The Shogun Machine Learning Toolbox (Source Code)","fork":false,"url":"https://api.github.com/repos/shogun-toolbox/shogun","forks_url":"https://api.github.com/repos/shogun-toolbox/shogun/forks","keys_url":"https://api.github.com/repos/shogun-toolbox/shogun/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shogun-toolbox/shogun/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shogun-toolbox/shogun/teams","hooks_url":"https://api.github.com/repos/shogun-toolbox/shogun/hooks","issue_events_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/events{/number}","events_url":"https://api.github.com/repos/shogun-toolbox/shogun/events","assignees_url":"https://api.github.com/repos/shogun-toolbox/shogun/assignees{/user}","branches_url":"https://api.github.com/repos/shogun-toolbox/shogun/branches{/branch}","tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/tags","blobs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/refs{/sha}","trees_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/{sha}","languages_url":"https://api.github.com/repos/shogun-toolbox/shogun/languages","stargazers_url":"https://api.github.com/repos/shogun-toolbox/shogun/stargazers","contributors_url":"https://api.github.com/repos/shogun-toolbox/shogun/contributors","subscribers_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscribers","subscription_url":"https://api.github.com/repos/shogun-toolbox/shogun/subscription","commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/commits{/sha}","git_commits_url":"https://api.github.com/repos/shogun-toolbox/shogun/git/commits{/sha}","comments_url":"https://api.github.com/repos/shogun-toolbox/shogun/comments{/number}","issue_comment_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues/comments/{number}","contents_url":"https://api.github.com/repos/shogun-toolbox/shogun/contents/{+path}","compare_url":"https://api.github.com/repos/shogun-toolbox/shogun/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shogun-toolbox/shogun/merges","archive_url":"https://api.github.com/repos/shogun-toolbox/shogun/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shogun-toolbox/shogun/downloads","issues_url":"https://api.github.com/repos/shogun-toolbox/shogun/issues{/number}","pulls_url":"https://api.github.com/repos/shogun-toolbox/shogun/pulls{/number}","milestones_url":"https://api.github.com/repos/shogun-toolbox/shogun/milestones{/number}","notifications_url":"https://api.github.com/repos/shogun-toolbox/shogun/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shogun-toolbox/shogun/labels{/name}","releases_url":"https://api.github.com/repos/shogun-toolbox/shogun/releases{/id}","created_at":"2011-04-01T10:44:32Z","updated_at":"2015-01-27T04:02:40Z","pushed_at":"2015-01-26T18:48:01Z","git_url":"git://github.com/shogun-toolbox/shogun.git","ssh_url":"git@github.com:shogun-toolbox/shogun.git","clone_url":"https://github.com/shogun-toolbox/shogun.git","svn_url":"https://github.com/shogun-toolbox/shogun","homepage":"http://www.shogun-toolbox.org","size":191113,"stargazers_count":644,"watchers_count":644,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":399,"mirror_url":null,"open_issues_count":318,"forks":399,"open_issues":318,"watchers":644,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684"},"html":{"href":"https://github.com/shogun-toolbox/shogun/pull/2684"},"issue":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/2684"},"comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/issues/2684/comments"},"review_comments":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684/comments"},"review_comment":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/pulls/2684/commits"},"statuses":{"href":"https://api.github.com/repos/shogun-toolbox/shogun/statuses/8079fb02fb3f2e06b636bcdc3f32b56aaecb21b1"}}}}