{"action":"opened","number":17,"pull_request":{"url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/17","id":50046294,"html_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/17","diff_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/17.diff","patch_url":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/17.patch","issue_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/17","number":17,"state":"open","locked":false,"title":"Added a way to derive from ElasticsearchSink class so that customized…","user":{"login":"konste","id":2653844,"avatar_url":"https://avatars.githubusercontent.com/u/2653844?v=3","gravatar_id":"","url":"https://api.github.com/users/konste","html_url":"https://github.com/konste","followers_url":"https://api.github.com/users/konste/followers","following_url":"https://api.github.com/users/konste/following{/other_user}","gists_url":"https://api.github.com/users/konste/gists{/gist_id}","starred_url":"https://api.github.com/users/konste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konste/subscriptions","organizations_url":"https://api.github.com/users/konste/orgs","repos_url":"https://api.github.com/users/konste/repos","events_url":"https://api.github.com/users/konste/events{/privacy}","received_events_url":"https://api.github.com/users/konste/received_events","type":"User","site_admin":false},"body":"… EmitBatch method would be able to analyse Elasticsearch response and get specific errors in case emit was unsuccessful.\r\n\r\nUnfortunately existing call _state.Client.Bulk(payload); does not allow to check Elasticsearch response in any way. I have split EmitBatch to two methods:\r\nEmitBatchChecked does what EmitBatch did, but returns ES response.\r\nExisting EmitBatch just calls EmitBatchChecked and drops return value.\r\n\r\nClass which overrides ElasticsearchSink may override EmitBatch to call base class EmitBatchChecked, but then do necessary ES response analysis.\r\n\r\nKonstantin","created_at":"2015-11-07T21:54:49Z","updated_at":"2015-11-07T21:54:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/17/commits","review_comments_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/17/comments","review_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/17/comments","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/statuses/e285ff579006e67652566a970e2a790662641cd9","head":{"label":"konste:master","ref":"master","sha":"e285ff579006e67652566a970e2a790662641cd9","user":{"login":"konste","id":2653844,"avatar_url":"https://avatars.githubusercontent.com/u/2653844?v=3","gravatar_id":"","url":"https://api.github.com/users/konste","html_url":"https://github.com/konste","followers_url":"https://api.github.com/users/konste/followers","following_url":"https://api.github.com/users/konste/following{/other_user}","gists_url":"https://api.github.com/users/konste/gists{/gist_id}","starred_url":"https://api.github.com/users/konste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konste/subscriptions","organizations_url":"https://api.github.com/users/konste/orgs","repos_url":"https://api.github.com/users/konste/repos","events_url":"https://api.github.com/users/konste/events{/privacy}","received_events_url":"https://api.github.com/users/konste/received_events","type":"User","site_admin":false},"repo":{"id":45752963,"name":"serilog-sinks-elasticsearch","full_name":"konste/serilog-sinks-elasticsearch","owner":{"login":"konste","id":2653844,"avatar_url":"https://avatars.githubusercontent.com/u/2653844?v=3","gravatar_id":"","url":"https://api.github.com/users/konste","html_url":"https://github.com/konste","followers_url":"https://api.github.com/users/konste/followers","following_url":"https://api.github.com/users/konste/following{/other_user}","gists_url":"https://api.github.com/users/konste/gists{/gist_id}","starred_url":"https://api.github.com/users/konste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konste/subscriptions","organizations_url":"https://api.github.com/users/konste/orgs","repos_url":"https://api.github.com/users/konste/repos","events_url":"https://api.github.com/users/konste/events{/privacy}","received_events_url":"https://api.github.com/users/konste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/konste/serilog-sinks-elasticsearch","description":"A Serilog sink that writes events to Elasticsearch","fork":true,"url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch","forks_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/forks","keys_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/teams","hooks_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/events","assignees_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/tags","blobs_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/subscription","commits_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/merges","archive_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/downloads","issues_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/konste/serilog-sinks-elasticsearch/releases{/id}","created_at":"2015-11-07T20:19:20Z","updated_at":"2015-11-07T20:19:21Z","pushed_at":"2015-11-07T21:47:53Z","git_url":"git://github.com/konste/serilog-sinks-elasticsearch.git","ssh_url":"git@github.com:konste/serilog-sinks-elasticsearch.git","clone_url":"https://github.com/konste/serilog-sinks-elasticsearch.git","svn_url":"https://github.com/konste/serilog-sinks-elasticsearch","homepage":null,"size":533,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"serilog:master","ref":"master","sha":"c5d626142081c79fc3d767bcf833f48ef57d5be9","user":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"repo":{"id":31184546,"name":"serilog-sinks-elasticsearch","full_name":"serilog/serilog-sinks-elasticsearch","owner":{"login":"serilog","id":5691010,"avatar_url":"https://avatars.githubusercontent.com/u/5691010?v=3","gravatar_id":"","url":"https://api.github.com/users/serilog","html_url":"https://github.com/serilog","followers_url":"https://api.github.com/users/serilog/followers","following_url":"https://api.github.com/users/serilog/following{/other_user}","gists_url":"https://api.github.com/users/serilog/gists{/gist_id}","starred_url":"https://api.github.com/users/serilog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serilog/subscriptions","organizations_url":"https://api.github.com/users/serilog/orgs","repos_url":"https://api.github.com/users/serilog/repos","events_url":"https://api.github.com/users/serilog/events{/privacy}","received_events_url":"https://api.github.com/users/serilog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/serilog/serilog-sinks-elasticsearch","description":"A Serilog sink that writes events to Elasticsearch","fork":false,"url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch","forks_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/forks","keys_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/teams","hooks_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/events","assignees_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/tags","blobs_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/languages","stargazers_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/subscription","commits_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/merges","archive_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/downloads","issues_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/releases{/id}","created_at":"2015-02-22T22:47:26Z","updated_at":"2015-10-21T08:35:56Z","pushed_at":"2015-10-30T23:27:40Z","git_url":"git://github.com/serilog/serilog-sinks-elasticsearch.git","ssh_url":"git@github.com:serilog/serilog-sinks-elasticsearch.git","clone_url":"https://github.com/serilog/serilog-sinks-elasticsearch.git","svn_url":"https://github.com/serilog/serilog-sinks-elasticsearch","homepage":null,"size":533,"stargazers_count":15,"watchers_count":15,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/17"},"html":{"href":"https://github.com/serilog/serilog-sinks-elasticsearch/pull/17"},"issue":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/17"},"comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/serilog/serilog-sinks-elasticsearch/statuses/e285ff579006e67652566a970e2a790662641cd9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":15,"deletions":3,"changed_files":1}}