{"action":"created","comment":{"url":"https://api.github.com/repos/robfig/cron/pulls/comments/46085845","id":46085845,"diff_hunk":"@@ -180,6 +180,9 @@ func (c *Cron) run() {\n \n // Stop the cron scheduler.","path":"cron.go","position":2,"original_position":2,"commit_id":"08e70034aaf8cfd74b3367e9c4f5830f390d17f6","original_commit_id":"08e70034aaf8cfd74b3367e9c4f5830f390d17f6","user":{"login":"shurcooL","id":1924134,"avatar_url":"https://avatars.githubusercontent.com/u/1924134?v=3","gravatar_id":"","url":"https://api.github.com/users/shurcooL","html_url":"https://github.com/shurcooL","followers_url":"https://api.github.com/users/shurcooL/followers","following_url":"https://api.github.com/users/shurcooL/following{/other_user}","gists_url":"https://api.github.com/users/shurcooL/gists{/gist_id}","starred_url":"https://api.github.com/users/shurcooL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shurcooL/subscriptions","organizations_url":"https://api.github.com/users/shurcooL/orgs","repos_url":"https://api.github.com/users/shurcooL/repos","events_url":"https://api.github.com/users/shurcooL/events{/privacy}","received_events_url":"https://api.github.com/users/shurcooL/received_events","type":"User","site_admin":false},"body":"I suggest documenting the behavior of Stop if it's not already running. Something like this:\r\n\r\n```\r\n// Stop the cron scheduler, if it's running. Otherwise this does nothing.\r\n```\r\n\r\nPeople should know what happen if they call Stop just by reading the docs, without having to look at the code (the implementation details). IMO it's worthwhile to document how Stop behaves if it's not running, whether it be a fatal error or a harmless no-op (which it it will be now).","created_at":"2015-11-28T23:49:15Z","updated_at":"2015-11-28T23:49:15Z","html_url":"https://github.com/robfig/cron/pull/36#discussion_r46085845","pull_request_url":"https://api.github.com/repos/robfig/cron/pulls/36","_links":{"self":{"href":"https://api.github.com/repos/robfig/cron/pulls/comments/46085845"},"html":{"href":"https://github.com/robfig/cron/pull/36#discussion_r46085845"},"pull_request":{"href":"https://api.github.com/repos/robfig/cron/pulls/36"}}},"pull_request":{"url":"https://api.github.com/repos/robfig/cron/pulls/36","id":52046837,"html_url":"https://github.com/robfig/cron/pull/36","diff_url":"https://github.com/robfig/cron/pull/36.diff","patch_url":"https://github.com/robfig/cron/pull/36.patch","issue_url":"https://api.github.com/repos/robfig/cron/issues/36","number":36,"state":"open","locked":false,"title":"Return on Stop if cron is not running","user":{"login":"bruth","id":515142,"avatar_url":"https://avatars.githubusercontent.com/u/515142?v=3","gravatar_id":"","url":"https://api.github.com/users/bruth","html_url":"https://github.com/bruth","followers_url":"https://api.github.com/users/bruth/followers","following_url":"https://api.github.com/users/bruth/following{/other_user}","gists_url":"https://api.github.com/users/bruth/gists{/gist_id}","starred_url":"https://api.github.com/users/bruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruth/subscriptions","organizations_url":"https://api.github.com/users/bruth/orgs","repos_url":"https://api.github.com/users/bruth/repos","events_url":"https://api.github.com/users/bruth/events{/privacy}","received_events_url":"https://api.github.com/users/bruth/received_events","type":"User","site_admin":false},"body":"Fix #35\r\n\r\nSigned-off-by: Byron Ruth <b@devel.io>","created_at":"2015-11-28T19:34:15Z","updated_at":"2015-11-28T23:49:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eb19f3b2251c290903dea1cdcdcea41402bd5e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/robfig/cron/pulls/36/commits","review_comments_url":"https://api.github.com/repos/robfig/cron/pulls/36/comments","review_comment_url":"https://api.github.com/repos/robfig/cron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robfig/cron/issues/36/comments","statuses_url":"https://api.github.com/repos/robfig/cron/statuses/08e70034aaf8cfd74b3367e9c4f5830f390d17f6","head":{"label":"bruth:issue-35","ref":"issue-35","sha":"08e70034aaf8cfd74b3367e9c4f5830f390d17f6","user":{"login":"bruth","id":515142,"avatar_url":"https://avatars.githubusercontent.com/u/515142?v=3","gravatar_id":"","url":"https://api.github.com/users/bruth","html_url":"https://github.com/bruth","followers_url":"https://api.github.com/users/bruth/followers","following_url":"https://api.github.com/users/bruth/following{/other_user}","gists_url":"https://api.github.com/users/bruth/gists{/gist_id}","starred_url":"https://api.github.com/users/bruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruth/subscriptions","organizations_url":"https://api.github.com/users/bruth/orgs","repos_url":"https://api.github.com/users/bruth/repos","events_url":"https://api.github.com/users/bruth/events{/privacy}","received_events_url":"https://api.github.com/users/bruth/received_events","type":"User","site_admin":false},"repo":{"id":46792676,"name":"cron","full_name":"bruth/cron","owner":{"login":"bruth","id":515142,"avatar_url":"https://avatars.githubusercontent.com/u/515142?v=3","gravatar_id":"","url":"https://api.github.com/users/bruth","html_url":"https://github.com/bruth","followers_url":"https://api.github.com/users/bruth/followers","following_url":"https://api.github.com/users/bruth/following{/other_user}","gists_url":"https://api.github.com/users/bruth/gists{/gist_id}","starred_url":"https://api.github.com/users/bruth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bruth/subscriptions","organizations_url":"https://api.github.com/users/bruth/orgs","repos_url":"https://api.github.com/users/bruth/repos","events_url":"https://api.github.com/users/bruth/events{/privacy}","received_events_url":"https://api.github.com/users/bruth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bruth/cron","description":"a cron library for go","fork":true,"url":"https://api.github.com/repos/bruth/cron","forks_url":"https://api.github.com/repos/bruth/cron/forks","keys_url":"https://api.github.com/repos/bruth/cron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bruth/cron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bruth/cron/teams","hooks_url":"https://api.github.com/repos/bruth/cron/hooks","issue_events_url":"https://api.github.com/repos/bruth/cron/issues/events{/number}","events_url":"https://api.github.com/repos/bruth/cron/events","assignees_url":"https://api.github.com/repos/bruth/cron/assignees{/user}","branches_url":"https://api.github.com/repos/bruth/cron/branches{/branch}","tags_url":"https://api.github.com/repos/bruth/cron/tags","blobs_url":"https://api.github.com/repos/bruth/cron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bruth/cron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bruth/cron/git/refs{/sha}","trees_url":"https://api.github.com/repos/bruth/cron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bruth/cron/statuses/{sha}","languages_url":"https://api.github.com/repos/bruth/cron/languages","stargazers_url":"https://api.github.com/repos/bruth/cron/stargazers","contributors_url":"https://api.github.com/repos/bruth/cron/contributors","subscribers_url":"https://api.github.com/repos/bruth/cron/subscribers","subscription_url":"https://api.github.com/repos/bruth/cron/subscription","commits_url":"https://api.github.com/repos/bruth/cron/commits{/sha}","git_commits_url":"https://api.github.com/repos/bruth/cron/git/commits{/sha}","comments_url":"https://api.github.com/repos/bruth/cron/comments{/number}","issue_comment_url":"https://api.github.com/repos/bruth/cron/issues/comments{/number}","contents_url":"https://api.github.com/repos/bruth/cron/contents/{+path}","compare_url":"https://api.github.com/repos/bruth/cron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bruth/cron/merges","archive_url":"https://api.github.com/repos/bruth/cron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bruth/cron/downloads","issues_url":"https://api.github.com/repos/bruth/cron/issues{/number}","pulls_url":"https://api.github.com/repos/bruth/cron/pulls{/number}","milestones_url":"https://api.github.com/repos/bruth/cron/milestones{/number}","notifications_url":"https://api.github.com/repos/bruth/cron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bruth/cron/labels{/name}","releases_url":"https://api.github.com/repos/bruth/cron/releases{/id}","created_at":"2015-11-24T13:15:51Z","updated_at":"2015-11-24T13:15:52Z","pushed_at":"2015-11-28T19:33:59Z","git_url":"git://github.com/bruth/cron.git","ssh_url":"git@github.com:bruth/cron.git","clone_url":"https://github.com/bruth/cron.git","svn_url":"https://github.com/bruth/cron","homepage":null,"size":57,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robfig:master","ref":"master","sha":"e4280929dd5d1064616a07bc7912264525e845e5","user":{"login":"robfig","id":536325,"avatar_url":"https://avatars.githubusercontent.com/u/536325?v=3","gravatar_id":"","url":"https://api.github.com/users/robfig","html_url":"https://github.com/robfig","followers_url":"https://api.github.com/users/robfig/followers","following_url":"https://api.github.com/users/robfig/following{/other_user}","gists_url":"https://api.github.com/users/robfig/gists{/gist_id}","starred_url":"https://api.github.com/users/robfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfig/subscriptions","organizations_url":"https://api.github.com/users/robfig/orgs","repos_url":"https://api.github.com/users/robfig/repos","events_url":"https://api.github.com/users/robfig/events{/privacy}","received_events_url":"https://api.github.com/users/robfig/received_events","type":"User","site_admin":false},"repo":{"id":4925652,"name":"cron","full_name":"robfig/cron","owner":{"login":"robfig","id":536325,"avatar_url":"https://avatars.githubusercontent.com/u/536325?v=3","gravatar_id":"","url":"https://api.github.com/users/robfig","html_url":"https://github.com/robfig","followers_url":"https://api.github.com/users/robfig/followers","following_url":"https://api.github.com/users/robfig/following{/other_user}","gists_url":"https://api.github.com/users/robfig/gists{/gist_id}","starred_url":"https://api.github.com/users/robfig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robfig/subscriptions","organizations_url":"https://api.github.com/users/robfig/orgs","repos_url":"https://api.github.com/users/robfig/repos","events_url":"https://api.github.com/users/robfig/events{/privacy}","received_events_url":"https://api.github.com/users/robfig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robfig/cron","description":"a cron library for go","fork":false,"url":"https://api.github.com/repos/robfig/cron","forks_url":"https://api.github.com/repos/robfig/cron/forks","keys_url":"https://api.github.com/repos/robfig/cron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robfig/cron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robfig/cron/teams","hooks_url":"https://api.github.com/repos/robfig/cron/hooks","issue_events_url":"https://api.github.com/repos/robfig/cron/issues/events{/number}","events_url":"https://api.github.com/repos/robfig/cron/events","assignees_url":"https://api.github.com/repos/robfig/cron/assignees{/user}","branches_url":"https://api.github.com/repos/robfig/cron/branches{/branch}","tags_url":"https://api.github.com/repos/robfig/cron/tags","blobs_url":"https://api.github.com/repos/robfig/cron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robfig/cron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robfig/cron/git/refs{/sha}","trees_url":"https://api.github.com/repos/robfig/cron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robfig/cron/statuses/{sha}","languages_url":"https://api.github.com/repos/robfig/cron/languages","stargazers_url":"https://api.github.com/repos/robfig/cron/stargazers","contributors_url":"https://api.github.com/repos/robfig/cron/contributors","subscribers_url":"https://api.github.com/repos/robfig/cron/subscribers","subscription_url":"https://api.github.com/repos/robfig/cron/subscription","commits_url":"https://api.github.com/repos/robfig/cron/commits{/sha}","git_commits_url":"https://api.github.com/repos/robfig/cron/git/commits{/sha}","comments_url":"https://api.github.com/repos/robfig/cron/comments{/number}","issue_comment_url":"https://api.github.com/repos/robfig/cron/issues/comments{/number}","contents_url":"https://api.github.com/repos/robfig/cron/contents/{+path}","compare_url":"https://api.github.com/repos/robfig/cron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robfig/cron/merges","archive_url":"https://api.github.com/repos/robfig/cron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robfig/cron/downloads","issues_url":"https://api.github.com/repos/robfig/cron/issues{/number}","pulls_url":"https://api.github.com/repos/robfig/cron/pulls{/number}","milestones_url":"https://api.github.com/repos/robfig/cron/milestones{/number}","notifications_url":"https://api.github.com/repos/robfig/cron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robfig/cron/labels{/name}","releases_url":"https://api.github.com/repos/robfig/cron/releases{/id}","created_at":"2012-07-06T14:06:34Z","updated_at":"2015-11-28T14:58:56Z","pushed_at":"2015-11-28T19:34:17Z","git_url":"git://github.com/robfig/cron.git","ssh_url":"git@github.com:robfig/cron.git","clone_url":"https://github.com/robfig/cron.git","svn_url":"https://github.com/robfig/cron","homepage":null,"size":406,"stargazers_count":627,"watchers_count":627,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":173,"mirror_url":null,"open_issues_count":14,"forks":173,"open_issues":14,"watchers":627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robfig/cron/pulls/36"},"html":{"href":"https://github.com/robfig/cron/pull/36"},"issue":{"href":"https://api.github.com/repos/robfig/cron/issues/36"},"comments":{"href":"https://api.github.com/repos/robfig/cron/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/robfig/cron/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/robfig/cron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robfig/cron/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/robfig/cron/statuses/08e70034aaf8cfd74b3367e9c4f5830f390d17f6"}}}}