{"action":"created","comment":{"url":"https://api.github.com/repos/atom/settings-view/pulls/comments/27616787","id":27616787,"diff_hunk":"@@ -68,6 +68,9 @@ class PackageCard extends View\n     if atom.packages.isBundledPackage(@pack.name) and @type is 'theme'\n       @statusIndicator.hide()\n \n+    unless @hasSettings(@pack)\n+      @settingsButton.hide()","path":"lib/package-card.coffee","position":5,"original_position":5,"commit_id":"adaf8177f8150045b3002911e487457f6d8fdc62","original_commit_id":"adaf8177f8150045b3002911e487457f6d8fdc62","user":{"login":"jlord","id":1305617,"avatar_url":"https://avatars.githubusercontent.com/u/1305617?v=3","gravatar_id":"","url":"https://api.github.com/users/jlord","html_url":"https://github.com/jlord","followers_url":"https://api.github.com/users/jlord/followers","following_url":"https://api.github.com/users/jlord/following{/other_user}","gists_url":"https://api.github.com/users/jlord/gists{/gist_id}","starred_url":"https://api.github.com/users/jlord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlord/subscriptions","organizations_url":"https://api.github.com/users/jlord/orgs","repos_url":"https://api.github.com/users/jlord/repos","events_url":"https://api.github.com/users/jlord/events{/privacy}","received_events_url":"https://api.github.com/users/jlord/received_events","type":"User","site_admin":true},"body":"was just talking with @simurai and let's use `.remove()` here because it will help the button styles round corners correctly when one button is left. ","created_at":"2015-04-01T22:05:52Z","updated_at":"2015-04-01T22:05:52Z","html_url":"https://github.com/atom/settings-view/pull/443#discussion_r27616787","pull_request_url":"https://api.github.com/repos/atom/settings-view/pulls/443","_links":{"self":{"href":"https://api.github.com/repos/atom/settings-view/pulls/comments/27616787"},"html":{"href":"https://github.com/atom/settings-view/pull/443#discussion_r27616787"},"pull_request":{"href":"https://api.github.com/repos/atom/settings-view/pulls/443"}}},"pull_request":{"url":"https://api.github.com/repos/atom/settings-view/pulls/443","id":31945013,"html_url":"https://github.com/atom/settings-view/pull/443","diff_url":"https://github.com/atom/settings-view/pull/443.diff","patch_url":"https://github.com/atom/settings-view/pull/443.patch","issue_url":"https://api.github.com/repos/atom/settings-view/issues/443","number":443,"state":"open","locked":false,"title":"Settings indicator","user":{"login":"mnquintana","id":823545,"avatar_url":"https://avatars.githubusercontent.com/u/823545?v=3","gravatar_id":"","url":"https://api.github.com/users/mnquintana","html_url":"https://github.com/mnquintana","followers_url":"https://api.github.com/users/mnquintana/followers","following_url":"https://api.github.com/users/mnquintana/following{/other_user}","gists_url":"https://api.github.com/users/mnquintana/gists{/gist_id}","starred_url":"https://api.github.com/users/mnquintana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnquintana/subscriptions","organizations_url":"https://api.github.com/users/mnquintana/orgs","repos_url":"https://api.github.com/users/mnquintana/repos","events_url":"https://api.github.com/users/mnquintana/events{/privacy}","received_events_url":"https://api.github.com/users/mnquintana/received_events","type":"User","site_admin":false},"body":"Resolves #355 \r\n\r\n![image](https://cloud.githubusercontent.com/assets/823545/6830494/68e48a42-d2f0-11e4-99db-b55ea37d7f19.png)\r\n\r\nI kept the style of the settings button as-is, but we could remove the text if that would be better. Personally, I think we should keep it for clarity. (Maybe remove it on smaller viewport widths?)\r\n\r\nI could also add the \"scroll to settings\" behavior to this PR as well - let me know if you think that would be best.\r\n\r\n/cc @thedaniel @simurai @zephraph","created_at":"2015-03-25T17:20:41Z","updated_at":"2015-04-01T22:05:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b103e0d62633bbf2eea676c9b5661e0f43d9dd1c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/settings-view/pulls/443/commits","review_comments_url":"https://api.github.com/repos/atom/settings-view/pulls/443/comments","review_comment_url":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/settings-view/issues/443/comments","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/adaf8177f8150045b3002911e487457f6d8fdc62","head":{"label":"mnquintana:settings-indicator","ref":"settings-indicator","sha":"adaf8177f8150045b3002911e487457f6d8fdc62","user":{"login":"mnquintana","id":823545,"avatar_url":"https://avatars.githubusercontent.com/u/823545?v=3","gravatar_id":"","url":"https://api.github.com/users/mnquintana","html_url":"https://github.com/mnquintana","followers_url":"https://api.github.com/users/mnquintana/followers","following_url":"https://api.github.com/users/mnquintana/following{/other_user}","gists_url":"https://api.github.com/users/mnquintana/gists{/gist_id}","starred_url":"https://api.github.com/users/mnquintana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnquintana/subscriptions","organizations_url":"https://api.github.com/users/mnquintana/orgs","repos_url":"https://api.github.com/users/mnquintana/repos","events_url":"https://api.github.com/users/mnquintana/events{/privacy}","received_events_url":"https://api.github.com/users/mnquintana/received_events","type":"User","site_admin":false},"repo":{"id":29405056,"name":"settings-view","full_name":"mnquintana/settings-view","owner":{"login":"mnquintana","id":823545,"avatar_url":"https://avatars.githubusercontent.com/u/823545?v=3","gravatar_id":"","url":"https://api.github.com/users/mnquintana","html_url":"https://github.com/mnquintana","followers_url":"https://api.github.com/users/mnquintana/followers","following_url":"https://api.github.com/users/mnquintana/following{/other_user}","gists_url":"https://api.github.com/users/mnquintana/gists{/gist_id}","starred_url":"https://api.github.com/users/mnquintana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mnquintana/subscriptions","organizations_url":"https://api.github.com/users/mnquintana/orgs","repos_url":"https://api.github.com/users/mnquintana/repos","events_url":"https://api.github.com/users/mnquintana/events{/privacy}","received_events_url":"https://api.github.com/users/mnquintana/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mnquintana/settings-view","description":"Edit Atom settings","fork":true,"url":"https://api.github.com/repos/mnquintana/settings-view","forks_url":"https://api.github.com/repos/mnquintana/settings-view/forks","keys_url":"https://api.github.com/repos/mnquintana/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mnquintana/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mnquintana/settings-view/teams","hooks_url":"https://api.github.com/repos/mnquintana/settings-view/hooks","issue_events_url":"https://api.github.com/repos/mnquintana/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/mnquintana/settings-view/events","assignees_url":"https://api.github.com/repos/mnquintana/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/mnquintana/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/mnquintana/settings-view/tags","blobs_url":"https://api.github.com/repos/mnquintana/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mnquintana/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mnquintana/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/mnquintana/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mnquintana/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/mnquintana/settings-view/languages","stargazers_url":"https://api.github.com/repos/mnquintana/settings-view/stargazers","contributors_url":"https://api.github.com/repos/mnquintana/settings-view/contributors","subscribers_url":"https://api.github.com/repos/mnquintana/settings-view/subscribers","subscription_url":"https://api.github.com/repos/mnquintana/settings-view/subscription","commits_url":"https://api.github.com/repos/mnquintana/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/mnquintana/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/mnquintana/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/mnquintana/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/mnquintana/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/mnquintana/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mnquintana/settings-view/merges","archive_url":"https://api.github.com/repos/mnquintana/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mnquintana/settings-view/downloads","issues_url":"https://api.github.com/repos/mnquintana/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/mnquintana/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/mnquintana/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/mnquintana/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mnquintana/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/mnquintana/settings-view/releases{/id}","created_at":"2015-01-17T20:46:09Z","updated_at":"2015-03-13T13:02:18Z","pushed_at":"2015-03-25T17:55:34Z","git_url":"git://github.com/mnquintana/settings-view.git","ssh_url":"git@github.com:mnquintana/settings-view.git","clone_url":"https://github.com/mnquintana/settings-view.git","svn_url":"https://github.com/mnquintana/settings-view","homepage":null,"size":922,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"a314e02734ac761c8b86b3af22ba2f506fb0dca0","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":12090329,"name":"settings-view","full_name":"atom/settings-view","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/settings-view","description":"Edit Atom settings","fork":false,"url":"https://api.github.com/repos/atom/settings-view","forks_url":"https://api.github.com/repos/atom/settings-view/forks","keys_url":"https://api.github.com/repos/atom/settings-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/settings-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/settings-view/teams","hooks_url":"https://api.github.com/repos/atom/settings-view/hooks","issue_events_url":"https://api.github.com/repos/atom/settings-view/issues/events{/number}","events_url":"https://api.github.com/repos/atom/settings-view/events","assignees_url":"https://api.github.com/repos/atom/settings-view/assignees{/user}","branches_url":"https://api.github.com/repos/atom/settings-view/branches{/branch}","tags_url":"https://api.github.com/repos/atom/settings-view/tags","blobs_url":"https://api.github.com/repos/atom/settings-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/settings-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/settings-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/settings-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/settings-view/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/settings-view/languages","stargazers_url":"https://api.github.com/repos/atom/settings-view/stargazers","contributors_url":"https://api.github.com/repos/atom/settings-view/contributors","subscribers_url":"https://api.github.com/repos/atom/settings-view/subscribers","subscription_url":"https://api.github.com/repos/atom/settings-view/subscription","commits_url":"https://api.github.com/repos/atom/settings-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/settings-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/settings-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/settings-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/settings-view/contents/{+path}","compare_url":"https://api.github.com/repos/atom/settings-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/settings-view/merges","archive_url":"https://api.github.com/repos/atom/settings-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/settings-view/downloads","issues_url":"https://api.github.com/repos/atom/settings-view/issues{/number}","pulls_url":"https://api.github.com/repos/atom/settings-view/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/settings-view/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/settings-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/settings-view/labels{/name}","releases_url":"https://api.github.com/repos/atom/settings-view/releases{/id}","created_at":"2013-08-13T19:16:23Z","updated_at":"2015-04-01T19:24:05Z","pushed_at":"2015-04-01T19:24:05Z","git_url":"git://github.com/atom/settings-view.git","ssh_url":"git@github.com:atom/settings-view.git","clone_url":"https://github.com/atom/settings-view.git","svn_url":"https://github.com/atom/settings-view","homepage":null,"size":4038,"stargazers_count":41,"watchers_count":41,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":46,"mirror_url":null,"open_issues_count":91,"forks":46,"open_issues":91,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/settings-view/pulls/443"},"html":{"href":"https://github.com/atom/settings-view/pull/443"},"issue":{"href":"https://api.github.com/repos/atom/settings-view/issues/443"},"comments":{"href":"https://api.github.com/repos/atom/settings-view/issues/443/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/settings-view/pulls/443/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/settings-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/settings-view/pulls/443/commits"},"statuses":{"href":"https://api.github.com/repos/atom/settings-view/statuses/adaf8177f8150045b3002911e487457f6d8fdc62"}}}}