{"action":"closed","number":216,"pull_request":{"url":"https://api.github.com/repos/kbandla/dpkt/pulls/216","id":42772222,"html_url":"https://github.com/kbandla/dpkt/pull/216","diff_url":"https://github.com/kbandla/dpkt/pull/216.diff","patch_url":"https://github.com/kbandla/dpkt/pull/216.patch","issue_url":"https://api.github.com/repos/kbandla/dpkt/issues/216","number":216,"state":"closed","locked":false,"title":"Fix #91: Fragment offset values for IP packets incorrect.","user":{"login":"sunhao2014","id":5916357,"avatar_url":"https://avatars.githubusercontent.com/u/5916357?v=3","gravatar_id":"","url":"https://api.github.com/users/sunhao2014","html_url":"https://github.com/sunhao2014","followers_url":"https://api.github.com/users/sunhao2014/followers","following_url":"https://api.github.com/users/sunhao2014/following{/other_user}","gists_url":"https://api.github.com/users/sunhao2014/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhao2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhao2014/subscriptions","organizations_url":"https://api.github.com/users/sunhao2014/orgs","repos_url":"https://api.github.com/users/sunhao2014/repos","events_url":"https://api.github.com/users/sunhao2014/events{/privacy}","received_events_url":"https://api.github.com/users/sunhao2014/received_events","type":"User","site_admin":false},"body":"Please check out #91 to have a look at the original issue.\r\n\r\nThe reason why we have this problem is in `ip.py`, there is a composite attribute `off`, it contains 4 IP fragmentation related attributes, respectively `rf`, `df`, `mf` and `offset`. Just like the strategy we deal with `_v_hl`, I added setters and getters to those attributes together with the test case.","created_at":"2015-08-19T02:57:11Z","updated_at":"2015-11-10T14:34:31Z","closed_at":"2015-11-10T14:34:31Z","merged_at":"2015-11-10T14:34:31Z","merge_commit_sha":"769fd2f950f1591081329491ef6839507bcc1b67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/kbandla/dpkt/pulls/216/commits","review_comments_url":"https://api.github.com/repos/kbandla/dpkt/pulls/216/comments","review_comment_url":"https://api.github.com/repos/kbandla/dpkt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kbandla/dpkt/issues/216/comments","statuses_url":"https://api.github.com/repos/kbandla/dpkt/statuses/611e222e67d4b802b35114d30336eb315bda57bf","head":{"label":"kbandla:fix-#91","ref":"fix-#91","sha":"611e222e67d4b802b35114d30336eb315bda57bf","user":{"login":"kbandla","id":200847,"avatar_url":"https://avatars.githubusercontent.com/u/200847?v=3","gravatar_id":"","url":"https://api.github.com/users/kbandla","html_url":"https://github.com/kbandla","followers_url":"https://api.github.com/users/kbandla/followers","following_url":"https://api.github.com/users/kbandla/following{/other_user}","gists_url":"https://api.github.com/users/kbandla/gists{/gist_id}","starred_url":"https://api.github.com/users/kbandla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbandla/subscriptions","organizations_url":"https://api.github.com/users/kbandla/orgs","repos_url":"https://api.github.com/users/kbandla/repos","events_url":"https://api.github.com/users/kbandla/events{/privacy}","received_events_url":"https://api.github.com/users/kbandla/received_events","type":"User","site_admin":false},"repo":{"id":4576441,"name":"dpkt","full_name":"kbandla/dpkt","owner":{"login":"kbandla","id":200847,"avatar_url":"https://avatars.githubusercontent.com/u/200847?v=3","gravatar_id":"","url":"https://api.github.com/users/kbandla","html_url":"https://github.com/kbandla","followers_url":"https://api.github.com/users/kbandla/followers","following_url":"https://api.github.com/users/kbandla/following{/other_user}","gists_url":"https://api.github.com/users/kbandla/gists{/gist_id}","starred_url":"https://api.github.com/users/kbandla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbandla/subscriptions","organizations_url":"https://api.github.com/users/kbandla/orgs","repos_url":"https://api.github.com/users/kbandla/repos","events_url":"https://api.github.com/users/kbandla/events{/privacy}","received_events_url":"https://api.github.com/users/kbandla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbandla/dpkt","description":"fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols","fork":false,"url":"https://api.github.com/repos/kbandla/dpkt","forks_url":"https://api.github.com/repos/kbandla/dpkt/forks","keys_url":"https://api.github.com/repos/kbandla/dpkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbandla/dpkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbandla/dpkt/teams","hooks_url":"https://api.github.com/repos/kbandla/dpkt/hooks","issue_events_url":"https://api.github.com/repos/kbandla/dpkt/issues/events{/number}","events_url":"https://api.github.com/repos/kbandla/dpkt/events","assignees_url":"https://api.github.com/repos/kbandla/dpkt/assignees{/user}","branches_url":"https://api.github.com/repos/kbandla/dpkt/branches{/branch}","tags_url":"https://api.github.com/repos/kbandla/dpkt/tags","blobs_url":"https://api.github.com/repos/kbandla/dpkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbandla/dpkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbandla/dpkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbandla/dpkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbandla/dpkt/statuses/{sha}","languages_url":"https://api.github.com/repos/kbandla/dpkt/languages","stargazers_url":"https://api.github.com/repos/kbandla/dpkt/stargazers","contributors_url":"https://api.github.com/repos/kbandla/dpkt/contributors","subscribers_url":"https://api.github.com/repos/kbandla/dpkt/subscribers","subscription_url":"https://api.github.com/repos/kbandla/dpkt/subscription","commits_url":"https://api.github.com/repos/kbandla/dpkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbandla/dpkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbandla/dpkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbandla/dpkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbandla/dpkt/contents/{+path}","compare_url":"https://api.github.com/repos/kbandla/dpkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbandla/dpkt/merges","archive_url":"https://api.github.com/repos/kbandla/dpkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbandla/dpkt/downloads","issues_url":"https://api.github.com/repos/kbandla/dpkt/issues{/number}","pulls_url":"https://api.github.com/repos/kbandla/dpkt/pulls{/number}","milestones_url":"https://api.github.com/repos/kbandla/dpkt/milestones{/number}","notifications_url":"https://api.github.com/repos/kbandla/dpkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbandla/dpkt/labels{/name}","releases_url":"https://api.github.com/repos/kbandla/dpkt/releases{/id}","created_at":"2012-06-06T18:39:31Z","updated_at":"2015-11-09T15:40:13Z","pushed_at":"2015-11-10T14:34:31Z","git_url":"git://github.com/kbandla/dpkt.git","ssh_url":"git@github.com:kbandla/dpkt.git","clone_url":"https://github.com/kbandla/dpkt.git","svn_url":"https://github.com/kbandla/dpkt","homepage":"","size":1287,"stargazers_count":149,"watchers_count":149,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":59,"forks":45,"open_issues":59,"watchers":149,"default_branch":"master"}},"base":{"label":"kbandla:master","ref":"master","sha":"1e9600f00b253b07cea8ace88e152b08a5f7cb99","user":{"login":"kbandla","id":200847,"avatar_url":"https://avatars.githubusercontent.com/u/200847?v=3","gravatar_id":"","url":"https://api.github.com/users/kbandla","html_url":"https://github.com/kbandla","followers_url":"https://api.github.com/users/kbandla/followers","following_url":"https://api.github.com/users/kbandla/following{/other_user}","gists_url":"https://api.github.com/users/kbandla/gists{/gist_id}","starred_url":"https://api.github.com/users/kbandla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbandla/subscriptions","organizations_url":"https://api.github.com/users/kbandla/orgs","repos_url":"https://api.github.com/users/kbandla/repos","events_url":"https://api.github.com/users/kbandla/events{/privacy}","received_events_url":"https://api.github.com/users/kbandla/received_events","type":"User","site_admin":false},"repo":{"id":4576441,"name":"dpkt","full_name":"kbandla/dpkt","owner":{"login":"kbandla","id":200847,"avatar_url":"https://avatars.githubusercontent.com/u/200847?v=3","gravatar_id":"","url":"https://api.github.com/users/kbandla","html_url":"https://github.com/kbandla","followers_url":"https://api.github.com/users/kbandla/followers","following_url":"https://api.github.com/users/kbandla/following{/other_user}","gists_url":"https://api.github.com/users/kbandla/gists{/gist_id}","starred_url":"https://api.github.com/users/kbandla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbandla/subscriptions","organizations_url":"https://api.github.com/users/kbandla/orgs","repos_url":"https://api.github.com/users/kbandla/repos","events_url":"https://api.github.com/users/kbandla/events{/privacy}","received_events_url":"https://api.github.com/users/kbandla/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kbandla/dpkt","description":"fast, simple packet creation / parsing, with definitions for the basic TCP/IP protocols","fork":false,"url":"https://api.github.com/repos/kbandla/dpkt","forks_url":"https://api.github.com/repos/kbandla/dpkt/forks","keys_url":"https://api.github.com/repos/kbandla/dpkt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kbandla/dpkt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kbandla/dpkt/teams","hooks_url":"https://api.github.com/repos/kbandla/dpkt/hooks","issue_events_url":"https://api.github.com/repos/kbandla/dpkt/issues/events{/number}","events_url":"https://api.github.com/repos/kbandla/dpkt/events","assignees_url":"https://api.github.com/repos/kbandla/dpkt/assignees{/user}","branches_url":"https://api.github.com/repos/kbandla/dpkt/branches{/branch}","tags_url":"https://api.github.com/repos/kbandla/dpkt/tags","blobs_url":"https://api.github.com/repos/kbandla/dpkt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kbandla/dpkt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kbandla/dpkt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kbandla/dpkt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kbandla/dpkt/statuses/{sha}","languages_url":"https://api.github.com/repos/kbandla/dpkt/languages","stargazers_url":"https://api.github.com/repos/kbandla/dpkt/stargazers","contributors_url":"https://api.github.com/repos/kbandla/dpkt/contributors","subscribers_url":"https://api.github.com/repos/kbandla/dpkt/subscribers","subscription_url":"https://api.github.com/repos/kbandla/dpkt/subscription","commits_url":"https://api.github.com/repos/kbandla/dpkt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kbandla/dpkt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kbandla/dpkt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kbandla/dpkt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kbandla/dpkt/contents/{+path}","compare_url":"https://api.github.com/repos/kbandla/dpkt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kbandla/dpkt/merges","archive_url":"https://api.github.com/repos/kbandla/dpkt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kbandla/dpkt/downloads","issues_url":"https://api.github.com/repos/kbandla/dpkt/issues{/number}","pulls_url":"https://api.github.com/repos/kbandla/dpkt/pulls{/number}","milestones_url":"https://api.github.com/repos/kbandla/dpkt/milestones{/number}","notifications_url":"https://api.github.com/repos/kbandla/dpkt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kbandla/dpkt/labels{/name}","releases_url":"https://api.github.com/repos/kbandla/dpkt/releases{/id}","created_at":"2012-06-06T18:39:31Z","updated_at":"2015-11-09T15:40:13Z","pushed_at":"2015-11-10T14:34:31Z","git_url":"git://github.com/kbandla/dpkt.git","ssh_url":"git@github.com:kbandla/dpkt.git","clone_url":"https://github.com/kbandla/dpkt.git","svn_url":"https://github.com/kbandla/dpkt","homepage":"","size":1287,"stargazers_count":149,"watchers_count":149,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":59,"forks":45,"open_issues":59,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kbandla/dpkt/pulls/216"},"html":{"href":"https://github.com/kbandla/dpkt/pull/216"},"issue":{"href":"https://api.github.com/repos/kbandla/dpkt/issues/216"},"comments":{"href":"https://api.github.com/repos/kbandla/dpkt/issues/216/comments"},"review_comments":{"href":"https://api.github.com/repos/kbandla/dpkt/pulls/216/comments"},"review_comment":{"href":"https://api.github.com/repos/kbandla/dpkt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kbandla/dpkt/pulls/216/commits"},"statuses":{"href":"https://api.github.com/repos/kbandla/dpkt/statuses/611e222e67d4b802b35114d30336eb315bda57bf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"sunhao2014","id":5916357,"avatar_url":"https://avatars.githubusercontent.com/u/5916357?v=3","gravatar_id":"","url":"https://api.github.com/users/sunhao2014","html_url":"https://github.com/sunhao2014","followers_url":"https://api.github.com/users/sunhao2014/followers","following_url":"https://api.github.com/users/sunhao2014/following{/other_user}","gists_url":"https://api.github.com/users/sunhao2014/gists{/gist_id}","starred_url":"https://api.github.com/users/sunhao2014/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunhao2014/subscriptions","organizations_url":"https://api.github.com/users/sunhao2014/orgs","repos_url":"https://api.github.com/users/sunhao2014/repos","events_url":"https://api.github.com/users/sunhao2014/events{/privacy}","received_events_url":"https://api.github.com/users/sunhao2014/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":55,"deletions":0,"changed_files":1}}