{"action":"created","comment":{"url":"https://api.github.com/repos/FAForever/fa/pulls/comments/47400236","id":47400236,"diff_hunk":"@@ -101,6 +101,10 @@ CollisionBeam = Class(moho.CollisionBeamEntity) {\n             if radius and radius > 0 then\n                 if not damageData.DoTTime or damageData.DoTTime <= 0 then\n                     DamageArea(instigator, self:GetPosition(1), radius, damage, damageData.DamageType or 'Normal', damageData.DamageFriendly or false)\n+                    -- Do non-AOE damage to the target if a missile to make beams kill missiles","path":"lua/sim/CollisionBeam.lua","position":4,"original_position":4,"commit_id":"63f1e76234077cb52b1445767f12929fa1857266","original_commit_id":"63f1e76234077cb52b1445767f12929fa1857266","user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"body":"This whole thing happened in the first place because the engine DamageArea function disregards all projectile entities in the radius. That's why the Cybran TMD, which uses a beam, has no radius, so it uses DoDamage instead, which is allowed to do the job.","created_at":"2015-12-11T20:18:57Z","updated_at":"2015-12-11T20:18:57Z","html_url":"https://github.com/FAForever/fa/pull/1053#discussion_r47400236","pull_request_url":"https://api.github.com/repos/FAForever/fa/pulls/1053","_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments/47400236"},"html":{"href":"https://github.com/FAForever/fa/pull/1053#discussion_r47400236"},"pull_request":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1053"}}},"pull_request":{"url":"https://api.github.com/repos/FAForever/fa/pulls/1053","id":53204474,"html_url":"https://github.com/FAForever/fa/pull/1053","diff_url":"https://github.com/FAForever/fa/pull/1053.diff","patch_url":"https://github.com/FAForever/fa/pull/1053.patch","issue_url":"https://api.github.com/repos/FAForever/fa/issues/1053","number":1053,"state":"closed","locked":false,"title":"Have beams kill missiles","user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"body":"Asked Zock what to be done, wants consistent behaviour. Quick aeolus polls had most saying impact should happen and missile should die to the beam.\r\n\r\nFixes #628","created_at":"2015-12-10T01:33:16Z","updated_at":"2015-12-11T20:18:57Z","closed_at":"2015-12-10T01:45:06Z","merged_at":"2015-12-10T01:45:06Z","merge_commit_sha":"06d2bcad30d15c9dfb948ace6103469d5a32e29f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/FAForever/fa/pulls/1053/commits","review_comments_url":"https://api.github.com/repos/FAForever/fa/pulls/1053/comments","review_comment_url":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FAForever/fa/issues/1053/comments","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/63f1e76234077cb52b1445767f12929fa1857266","head":{"label":"aeoncleanse:enhancement_MissileBeams","ref":"enhancement_MissileBeams","sha":"63f1e76234077cb52b1445767f12929fa1857266","user":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"repo":{"id":25368939,"name":"fa","full_name":"aeoncleanse/fa","owner":{"login":"aeoncleanse","id":8494967,"avatar_url":"https://avatars.githubusercontent.com/u/8494967?v=3","gravatar_id":"","url":"https://api.github.com/users/aeoncleanse","html_url":"https://github.com/aeoncleanse","followers_url":"https://api.github.com/users/aeoncleanse/followers","following_url":"https://api.github.com/users/aeoncleanse/following{/other_user}","gists_url":"https://api.github.com/users/aeoncleanse/gists{/gist_id}","starred_url":"https://api.github.com/users/aeoncleanse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aeoncleanse/subscriptions","organizations_url":"https://api.github.com/users/aeoncleanse/orgs","repos_url":"https://api.github.com/users/aeoncleanse/repos","events_url":"https://api.github.com/users/aeoncleanse/events{/privacy}","received_events_url":"https://api.github.com/users/aeoncleanse/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aeoncleanse/fa","description":"Lua code for FAF","fork":true,"url":"https://api.github.com/repos/aeoncleanse/fa","forks_url":"https://api.github.com/repos/aeoncleanse/fa/forks","keys_url":"https://api.github.com/repos/aeoncleanse/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aeoncleanse/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aeoncleanse/fa/teams","hooks_url":"https://api.github.com/repos/aeoncleanse/fa/hooks","issue_events_url":"https://api.github.com/repos/aeoncleanse/fa/issues/events{/number}","events_url":"https://api.github.com/repos/aeoncleanse/fa/events","assignees_url":"https://api.github.com/repos/aeoncleanse/fa/assignees{/user}","branches_url":"https://api.github.com/repos/aeoncleanse/fa/branches{/branch}","tags_url":"https://api.github.com/repos/aeoncleanse/fa/tags","blobs_url":"https://api.github.com/repos/aeoncleanse/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aeoncleanse/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aeoncleanse/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/aeoncleanse/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aeoncleanse/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/aeoncleanse/fa/languages","stargazers_url":"https://api.github.com/repos/aeoncleanse/fa/stargazers","contributors_url":"https://api.github.com/repos/aeoncleanse/fa/contributors","subscribers_url":"https://api.github.com/repos/aeoncleanse/fa/subscribers","subscription_url":"https://api.github.com/repos/aeoncleanse/fa/subscription","commits_url":"https://api.github.com/repos/aeoncleanse/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/aeoncleanse/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/aeoncleanse/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/aeoncleanse/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/aeoncleanse/fa/contents/{+path}","compare_url":"https://api.github.com/repos/aeoncleanse/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aeoncleanse/fa/merges","archive_url":"https://api.github.com/repos/aeoncleanse/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aeoncleanse/fa/downloads","issues_url":"https://api.github.com/repos/aeoncleanse/fa/issues{/number}","pulls_url":"https://api.github.com/repos/aeoncleanse/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/aeoncleanse/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/aeoncleanse/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aeoncleanse/fa/labels{/name}","releases_url":"https://api.github.com/repos/aeoncleanse/fa/releases{/id}","created_at":"2014-10-17T17:21:41Z","updated_at":"2015-03-01T17:57:19Z","pushed_at":"2015-12-11T14:42:05Z","git_url":"git://github.com/aeoncleanse/fa.git","ssh_url":"git@github.com:aeoncleanse/fa.git","clone_url":"https://github.com/aeoncleanse/fa.git","svn_url":"https://github.com/aeoncleanse/fa","homepage":"","size":109133,"stargazers_count":0,"watchers_count":0,"language":"Lua","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"FAForever:release/3652","ref":"release/3652","sha":"1b8ab395ac76b594c02a3a92e1c30d36af4950b3","user":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"repo":{"id":24403473,"name":"fa","full_name":"FAForever/fa","owner":{"login":"FAForever","id":8887184,"avatar_url":"https://avatars.githubusercontent.com/u/8887184?v=3","gravatar_id":"","url":"https://api.github.com/users/FAForever","html_url":"https://github.com/FAForever","followers_url":"https://api.github.com/users/FAForever/followers","following_url":"https://api.github.com/users/FAForever/following{/other_user}","gists_url":"https://api.github.com/users/FAForever/gists{/gist_id}","starred_url":"https://api.github.com/users/FAForever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FAForever/subscriptions","organizations_url":"https://api.github.com/users/FAForever/orgs","repos_url":"https://api.github.com/users/FAForever/repos","events_url":"https://api.github.com/users/FAForever/events{/privacy}","received_events_url":"https://api.github.com/users/FAForever/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FAForever/fa","description":"Lua code for FAF","fork":false,"url":"https://api.github.com/repos/FAForever/fa","forks_url":"https://api.github.com/repos/FAForever/fa/forks","keys_url":"https://api.github.com/repos/FAForever/fa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FAForever/fa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FAForever/fa/teams","hooks_url":"https://api.github.com/repos/FAForever/fa/hooks","issue_events_url":"https://api.github.com/repos/FAForever/fa/issues/events{/number}","events_url":"https://api.github.com/repos/FAForever/fa/events","assignees_url":"https://api.github.com/repos/FAForever/fa/assignees{/user}","branches_url":"https://api.github.com/repos/FAForever/fa/branches{/branch}","tags_url":"https://api.github.com/repos/FAForever/fa/tags","blobs_url":"https://api.github.com/repos/FAForever/fa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FAForever/fa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FAForever/fa/git/refs{/sha}","trees_url":"https://api.github.com/repos/FAForever/fa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FAForever/fa/statuses/{sha}","languages_url":"https://api.github.com/repos/FAForever/fa/languages","stargazers_url":"https://api.github.com/repos/FAForever/fa/stargazers","contributors_url":"https://api.github.com/repos/FAForever/fa/contributors","subscribers_url":"https://api.github.com/repos/FAForever/fa/subscribers","subscription_url":"https://api.github.com/repos/FAForever/fa/subscription","commits_url":"https://api.github.com/repos/FAForever/fa/commits{/sha}","git_commits_url":"https://api.github.com/repos/FAForever/fa/git/commits{/sha}","comments_url":"https://api.github.com/repos/FAForever/fa/comments{/number}","issue_comment_url":"https://api.github.com/repos/FAForever/fa/issues/comments{/number}","contents_url":"https://api.github.com/repos/FAForever/fa/contents/{+path}","compare_url":"https://api.github.com/repos/FAForever/fa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FAForever/fa/merges","archive_url":"https://api.github.com/repos/FAForever/fa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FAForever/fa/downloads","issues_url":"https://api.github.com/repos/FAForever/fa/issues{/number}","pulls_url":"https://api.github.com/repos/FAForever/fa/pulls{/number}","milestones_url":"https://api.github.com/repos/FAForever/fa/milestones{/number}","notifications_url":"https://api.github.com/repos/FAForever/fa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FAForever/fa/labels{/name}","releases_url":"https://api.github.com/repos/FAForever/fa/releases{/id}","created_at":"2014-09-24T06:34:12Z","updated_at":"2015-12-06T09:16:51Z","pushed_at":"2015-12-11T15:35:03Z","git_url":"git://github.com/FAForever/fa.git","ssh_url":"git@github.com:FAForever/fa.git","clone_url":"https://github.com/FAForever/fa.git","svn_url":"https://github.com/FAForever/fa","homepage":"","size":118588,"stargazers_count":28,"watchers_count":28,"language":"Lua","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":135,"forks":39,"open_issues":135,"watchers":28,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1053"},"html":{"href":"https://github.com/FAForever/fa/pull/1053"},"issue":{"href":"https://api.github.com/repos/FAForever/fa/issues/1053"},"comments":{"href":"https://api.github.com/repos/FAForever/fa/issues/1053/comments"},"review_comments":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1053/comments"},"review_comment":{"href":"https://api.github.com/repos/FAForever/fa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FAForever/fa/pulls/1053/commits"},"statuses":{"href":"https://api.github.com/repos/FAForever/fa/statuses/63f1e76234077cb52b1445767f12929fa1857266"}}}}