{"comment":{"url":"https://api.github.com/repos/QuantConnect/Lean/comments/14599402","html_url":"https://github.com/QuantConnect/Lean/commit/a4a195880e2726514144a4e415a39e99b571d2df#commitcomment-14599402","id":14599402,"user":{"login":"mchandschuh","id":531416,"avatar_url":"https://avatars.githubusercontent.com/u/531416?v=3","gravatar_id":"","url":"https://api.github.com/users/mchandschuh","html_url":"https://github.com/mchandschuh","followers_url":"https://api.github.com/users/mchandschuh/followers","following_url":"https://api.github.com/users/mchandschuh/following{/other_user}","gists_url":"https://api.github.com/users/mchandschuh/gists{/gist_id}","starred_url":"https://api.github.com/users/mchandschuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mchandschuh/subscriptions","organizations_url":"https://api.github.com/users/mchandschuh/orgs","repos_url":"https://api.github.com/users/mchandschuh/repos","events_url":"https://api.github.com/users/mchandschuh/events{/privacy}","received_events_url":"https://api.github.com/users/mchandschuh/received_events","type":"User","site_admin":false},"position":321,"line":321,"path":"Common/Securities/SecurityIdentifier.cs","commit_id":"a4a195880e2726514144a4e415a39e99b571d2df","created_at":"2015-11-24T20:15:15Z","updated_at":"2015-11-24T20:15:15Z","body":"I'm open to suggestions as to the form/shape of the factory class and it's methods. Are you recommending a simple transplant of these static Generate methods to a different static class? Or are you recommending to creating potentially an interface `ISecurityIdentifierFactory` and then have various implementations for `EquitySecurityIdentifierFactory` `ForexSecurityIdentifierFactory`, ect...\r\n\r\nI'm slightly hesitant to the idea and it's potential uses/advantages in the code base, but as always, open to suggestions!"}}