{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/evancz/elm-effects/pulls/13","id":43587653,"html_url":"https://github.com/evancz/elm-effects/pull/13","diff_url":"https://github.com/evancz/elm-effects/pull/13.diff","patch_url":"https://github.com/evancz/elm-effects/pull/13.patch","issue_url":"https://api.github.com/repos/evancz/elm-effects/issues/13","number":13,"state":"closed","locked":false,"title":"Expose requestAnimationFrame(), so that other packages can build on it.","user":{"login":"rgrempel","id":64381,"avatar_url":"https://avatars.githubusercontent.com/u/64381?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrempel","html_url":"https://github.com/rgrempel","followers_url":"https://api.github.com/users/rgrempel/followers","following_url":"https://api.github.com/users/rgrempel/following{/other_user}","gists_url":"https://api.github.com/users/rgrempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrempel/subscriptions","organizations_url":"https://api.github.com/users/rgrempel/orgs","repos_url":"https://api.github.com/users/rgrempel/repos","events_url":"https://api.github.com/users/rgrempel/events{/privacy}","received_events_url":"https://api.github.com/users/rgrempel/received_events","type":"User","site_admin":false},"body":"The purpose of this pull request would be to expose the native `requestAnimationFrame` function, so that it is possible for other packages to build on `requestAnimationFrame` without themselves needing to include native modules directly.\r\n\r\nThis is the general approach suggested by @laszlopandy in [his comment](https://github.com/elm-lang/package.elm-lang.org/issues/71) on the native review request for [rgrempel/elm-ticker](https://github.com/rgrempel/elm-ticker).\r\n\r\nNote that @laszlopandy suggests building on top of [jwmerrill/elm-animation-frame](https://github.com/jwmerrill/elm-animation-frame). However, that would require a larger change -- essentially, duplicating [src/Native/Effects.js](https://github.com/evancz/elm-effects/blob/master/src/Native/Effects.js) from elm-effects. By way of contrast, all that is required in order to build on top of elm-effects is to expose the existing `requestAnimationFrame` function.\r\n\r\nIf this is not desirable, then I can submit a pull request to jwmerrill/elm-animation-frame instead, with the larger change mentioned above.","created_at":"2015-08-28T02:24:31Z","updated_at":"2015-09-26T02:08:52Z","closed_at":"2015-09-26T02:08:52Z","merged_at":null,"merge_commit_sha":"30cea69271c730dac2061bf599d61d03fa057d40","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/evancz/elm-effects/pulls/13/commits","review_comments_url":"https://api.github.com/repos/evancz/elm-effects/pulls/13/comments","review_comment_url":"https://api.github.com/repos/evancz/elm-effects/pulls/comments{/number}","comments_url":"https://api.github.com/repos/evancz/elm-effects/issues/13/comments","statuses_url":"https://api.github.com/repos/evancz/elm-effects/statuses/788c303b67d7b9006a1f2f8f3ca74efe9b848138","head":{"label":"rgrempel:expose-request-animation-frame","ref":"expose-request-animation-frame","sha":"788c303b67d7b9006a1f2f8f3ca74efe9b848138","user":{"login":"rgrempel","id":64381,"avatar_url":"https://avatars.githubusercontent.com/u/64381?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrempel","html_url":"https://github.com/rgrempel","followers_url":"https://api.github.com/users/rgrempel/followers","following_url":"https://api.github.com/users/rgrempel/following{/other_user}","gists_url":"https://api.github.com/users/rgrempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrempel/subscriptions","organizations_url":"https://api.github.com/users/rgrempel/orgs","repos_url":"https://api.github.com/users/rgrempel/repos","events_url":"https://api.github.com/users/rgrempel/events{/privacy}","received_events_url":"https://api.github.com/users/rgrempel/received_events","type":"User","site_admin":false},"repo":{"id":41520615,"name":"elm-effects","full_name":"rgrempel/elm-effects","owner":{"login":"rgrempel","id":64381,"avatar_url":"https://avatars.githubusercontent.com/u/64381?v=3","gravatar_id":"","url":"https://api.github.com/users/rgrempel","html_url":"https://github.com/rgrempel","followers_url":"https://api.github.com/users/rgrempel/followers","following_url":"https://api.github.com/users/rgrempel/following{/other_user}","gists_url":"https://api.github.com/users/rgrempel/gists{/gist_id}","starred_url":"https://api.github.com/users/rgrempel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgrempel/subscriptions","organizations_url":"https://api.github.com/users/rgrempel/orgs","repos_url":"https://api.github.com/users/rgrempel/repos","events_url":"https://api.github.com/users/rgrempel/events{/privacy}","received_events_url":"https://api.github.com/users/rgrempel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rgrempel/elm-effects","description":"Bring effects like HTTP and animations into your Elm Architecture app","fork":true,"url":"https://api.github.com/repos/rgrempel/elm-effects","forks_url":"https://api.github.com/repos/rgrempel/elm-effects/forks","keys_url":"https://api.github.com/repos/rgrempel/elm-effects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgrempel/elm-effects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgrempel/elm-effects/teams","hooks_url":"https://api.github.com/repos/rgrempel/elm-effects/hooks","issue_events_url":"https://api.github.com/repos/rgrempel/elm-effects/issues/events{/number}","events_url":"https://api.github.com/repos/rgrempel/elm-effects/events","assignees_url":"https://api.github.com/repos/rgrempel/elm-effects/assignees{/user}","branches_url":"https://api.github.com/repos/rgrempel/elm-effects/branches{/branch}","tags_url":"https://api.github.com/repos/rgrempel/elm-effects/tags","blobs_url":"https://api.github.com/repos/rgrempel/elm-effects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgrempel/elm-effects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgrempel/elm-effects/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgrempel/elm-effects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgrempel/elm-effects/statuses/{sha}","languages_url":"https://api.github.com/repos/rgrempel/elm-effects/languages","stargazers_url":"https://api.github.com/repos/rgrempel/elm-effects/stargazers","contributors_url":"https://api.github.com/repos/rgrempel/elm-effects/contributors","subscribers_url":"https://api.github.com/repos/rgrempel/elm-effects/subscribers","subscription_url":"https://api.github.com/repos/rgrempel/elm-effects/subscription","commits_url":"https://api.github.com/repos/rgrempel/elm-effects/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgrempel/elm-effects/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgrempel/elm-effects/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgrempel/elm-effects/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgrempel/elm-effects/contents/{+path}","compare_url":"https://api.github.com/repos/rgrempel/elm-effects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgrempel/elm-effects/merges","archive_url":"https://api.github.com/repos/rgrempel/elm-effects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgrempel/elm-effects/downloads","issues_url":"https://api.github.com/repos/rgrempel/elm-effects/issues{/number}","pulls_url":"https://api.github.com/repos/rgrempel/elm-effects/pulls{/number}","milestones_url":"https://api.github.com/repos/rgrempel/elm-effects/milestones{/number}","notifications_url":"https://api.github.com/repos/rgrempel/elm-effects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgrempel/elm-effects/labels{/name}","releases_url":"https://api.github.com/repos/rgrempel/elm-effects/releases{/id}","created_at":"2015-08-28T01:46:52Z","updated_at":"2015-08-28T01:46:53Z","pushed_at":"2015-08-28T02:08:53Z","git_url":"git://github.com/rgrempel/elm-effects.git","ssh_url":"git@github.com:rgrempel/elm-effects.git","clone_url":"https://github.com/rgrempel/elm-effects.git","svn_url":"https://github.com/rgrempel/elm-effects","homepage":"https://github.com/evancz/elm-architecture-tutorial","size":418,"stargazers_count":0,"watchers_count":0,"language":"Elm","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"evancz:master","ref":"master","sha":"80f435ef89544d61bb80342f133361311f4cf03f","user":{"login":"evancz","id":1658058,"avatar_url":"https://avatars.githubusercontent.com/u/1658058?v=3","gravatar_id":"","url":"https://api.github.com/users/evancz","html_url":"https://github.com/evancz","followers_url":"https://api.github.com/users/evancz/followers","following_url":"https://api.github.com/users/evancz/following{/other_user}","gists_url":"https://api.github.com/users/evancz/gists{/gist_id}","starred_url":"https://api.github.com/users/evancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evancz/subscriptions","organizations_url":"https://api.github.com/users/evancz/orgs","repos_url":"https://api.github.com/users/evancz/repos","events_url":"https://api.github.com/users/evancz/events{/privacy}","received_events_url":"https://api.github.com/users/evancz/received_events","type":"User","site_admin":false},"repo":{"id":39857363,"name":"elm-effects","full_name":"evancz/elm-effects","owner":{"login":"evancz","id":1658058,"avatar_url":"https://avatars.githubusercontent.com/u/1658058?v=3","gravatar_id":"","url":"https://api.github.com/users/evancz","html_url":"https://github.com/evancz","followers_url":"https://api.github.com/users/evancz/followers","following_url":"https://api.github.com/users/evancz/following{/other_user}","gists_url":"https://api.github.com/users/evancz/gists{/gist_id}","starred_url":"https://api.github.com/users/evancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evancz/subscriptions","organizations_url":"https://api.github.com/users/evancz/orgs","repos_url":"https://api.github.com/users/evancz/repos","events_url":"https://api.github.com/users/evancz/events{/privacy}","received_events_url":"https://api.github.com/users/evancz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evancz/elm-effects","description":"Bring effects like HTTP and animations into your Elm Architecture app","fork":false,"url":"https://api.github.com/repos/evancz/elm-effects","forks_url":"https://api.github.com/repos/evancz/elm-effects/forks","keys_url":"https://api.github.com/repos/evancz/elm-effects/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evancz/elm-effects/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evancz/elm-effects/teams","hooks_url":"https://api.github.com/repos/evancz/elm-effects/hooks","issue_events_url":"https://api.github.com/repos/evancz/elm-effects/issues/events{/number}","events_url":"https://api.github.com/repos/evancz/elm-effects/events","assignees_url":"https://api.github.com/repos/evancz/elm-effects/assignees{/user}","branches_url":"https://api.github.com/repos/evancz/elm-effects/branches{/branch}","tags_url":"https://api.github.com/repos/evancz/elm-effects/tags","blobs_url":"https://api.github.com/repos/evancz/elm-effects/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evancz/elm-effects/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evancz/elm-effects/git/refs{/sha}","trees_url":"https://api.github.com/repos/evancz/elm-effects/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evancz/elm-effects/statuses/{sha}","languages_url":"https://api.github.com/repos/evancz/elm-effects/languages","stargazers_url":"https://api.github.com/repos/evancz/elm-effects/stargazers","contributors_url":"https://api.github.com/repos/evancz/elm-effects/contributors","subscribers_url":"https://api.github.com/repos/evancz/elm-effects/subscribers","subscription_url":"https://api.github.com/repos/evancz/elm-effects/subscription","commits_url":"https://api.github.com/repos/evancz/elm-effects/commits{/sha}","git_commits_url":"https://api.github.com/repos/evancz/elm-effects/git/commits{/sha}","comments_url":"https://api.github.com/repos/evancz/elm-effects/comments{/number}","issue_comment_url":"https://api.github.com/repos/evancz/elm-effects/issues/comments{/number}","contents_url":"https://api.github.com/repos/evancz/elm-effects/contents/{+path}","compare_url":"https://api.github.com/repos/evancz/elm-effects/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evancz/elm-effects/merges","archive_url":"https://api.github.com/repos/evancz/elm-effects/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evancz/elm-effects/downloads","issues_url":"https://api.github.com/repos/evancz/elm-effects/issues{/number}","pulls_url":"https://api.github.com/repos/evancz/elm-effects/pulls{/number}","milestones_url":"https://api.github.com/repos/evancz/elm-effects/milestones{/number}","notifications_url":"https://api.github.com/repos/evancz/elm-effects/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evancz/elm-effects/labels{/name}","releases_url":"https://api.github.com/repos/evancz/elm-effects/releases{/id}","created_at":"2015-07-28T20:56:10Z","updated_at":"2015-09-21T22:23:23Z","pushed_at":"2015-09-26T02:06:24Z","git_url":"git://github.com/evancz/elm-effects.git","ssh_url":"git@github.com:evancz/elm-effects.git","clone_url":"https://github.com/evancz/elm-effects.git","svn_url":"https://github.com/evancz/elm-effects","homepage":"https://github.com/evancz/elm-architecture-tutorial","size":566,"stargazers_count":19,"watchers_count":19,"language":"Elm","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":7,"forks":7,"open_issues":7,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/evancz/elm-effects/pulls/13"},"html":{"href":"https://github.com/evancz/elm-effects/pull/13"},"issue":{"href":"https://api.github.com/repos/evancz/elm-effects/issues/13"},"comments":{"href":"https://api.github.com/repos/evancz/elm-effects/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/evancz/elm-effects/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/evancz/elm-effects/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/evancz/elm-effects/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/evancz/elm-effects/statuses/788c303b67d7b9006a1f2f8f3ca74efe9b848138"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":7,"review_comments":0,"commits":1,"additions":14,"deletions":0,"changed_files":1}}