{"action":"created","issue":{"url":"https://api.github.com/repos/DataValues/Time/issues/33","labels_url":"https://api.github.com/repos/DataValues/Time/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/DataValues/Time/issues/33/comments","events_url":"https://api.github.com/repos/DataValues/Time/issues/33/events","html_url":"https://github.com/DataValues/Time/pull/33","id":56530678,"number":33,"title":"Enforce minimal year padding to 4 digits","user":{"login":"thiemowmde","id":6576639,"avatar_url":"https://avatars.githubusercontent.com/u/6576639?v=3","gravatar_id":"","url":"https://api.github.com/users/thiemowmde","html_url":"https://github.com/thiemowmde","followers_url":"https://api.github.com/users/thiemowmde/followers","following_url":"https://api.github.com/users/thiemowmde/following{/other_user}","gists_url":"https://api.github.com/users/thiemowmde/gists{/gist_id}","starred_url":"https://api.github.com/users/thiemowmde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiemowmde/subscriptions","organizations_url":"https://api.github.com/users/thiemowmde/orgs","repos_url":"https://api.github.com/users/thiemowmde/repos","events_url":"https://api.github.com/users/thiemowmde/events{/privacy}","received_events_url":"https://api.github.com/users/thiemowmde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-04T14:11:42Z","updated_at":"2015-02-04T14:24:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/DataValues/Time/pulls/33","html_url":"https://github.com/DataValues/Time/pull/33","diff_url":"https://github.com/DataValues/Time/pull/33.diff","patch_url":"https://github.com/DataValues/Time/pull/33.patch"},"body":"This implements an enforced padding to 4 digits for the year. This is the most minimal compromise. Look at how the `DateTimeParser` is implemented: It uses PHP's internal DateTime parser and needs to pad (and cut) the year to 4 digits to do this. An enforced padding to 4 digits is not crucial in this class but very convenient for almost all (external) use cases.\r\n\r\nWe can easily increase this to 16 digits later, depending on the outcome of the discussion at [T66084](https://phabricator.wikimedia.org/T66084) and related Phabricator tasks.\r\n\r\nThis also adds a test to ensure more than 16 digits for the year are not accepted.\r\n\r\nThe 1st commit is crucial, the 2nd is only a style change.\r\n\r\nBug: [T66084](https://phabricator.wikimedia.org/T66084)"},"comment":{"url":"https://api.github.com/repos/DataValues/Time/issues/comments/72861865","html_url":"https://github.com/DataValues/Time/pull/33#issuecomment-72861865","issue_url":"https://api.github.com/repos/DataValues/Time/issues/33","id":72861865,"user":{"login":"addshore","id":3308769,"avatar_url":"https://avatars.githubusercontent.com/u/3308769?v=3","gravatar_id":"","url":"https://api.github.com/users/addshore","html_url":"https://github.com/addshore","followers_url":"https://api.github.com/users/addshore/followers","following_url":"https://api.github.com/users/addshore/following{/other_user}","gists_url":"https://api.github.com/users/addshore/gists{/gist_id}","starred_url":"https://api.github.com/users/addshore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addshore/subscriptions","organizations_url":"https://api.github.com/users/addshore/orgs","repos_url":"https://api.github.com/users/addshore/repos","events_url":"https://api.github.com/users/addshore/events{/privacy}","received_events_url":"https://api.github.com/users/addshore/received_events","type":"User","site_admin":false},"created_at":"2015-02-04T14:24:13Z","updated_at":"2015-02-04T14:24:13Z","body":"Looks fine to me,\r\nI just restarted the hhvm job on travis https://travis-ci.org/DataValues/Time/jobs/49459959"}}