{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/13","id":46258739,"html_url":"https://github.com/guardian/riffraff-artifact/pull/13","diff_url":"https://github.com/guardian/riffraff-artifact/pull/13.diff","patch_url":"https://github.com/guardian/riffraff-artifact/pull/13.patch","issue_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues/13","number":13,"state":"closed","locked":false,"title":"Swap upload ordering","user":{"login":"rich-nguyen","id":4549425,"avatar_url":"https://avatars.githubusercontent.com/u/4549425?v=3","gravatar_id":"","url":"https://api.github.com/users/rich-nguyen","html_url":"https://github.com/rich-nguyen","followers_url":"https://api.github.com/users/rich-nguyen/followers","following_url":"https://api.github.com/users/rich-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/rich-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-nguyen/subscriptions","organizations_url":"https://api.github.com/users/rich-nguyen/orgs","repos_url":"https://api.github.com/users/rich-nguyen/repos","events_url":"https://api.github.com/users/rich-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/rich-nguyen/received_events","type":"User","site_admin":false},"body":"Firstly, this fix is a little speculative. But we've been [seeing issues](https://riffraff.gutools.co.uk/deployment/view/44d666e5-4ae6-48f7-9498-a857883fc446) where the riff raff project is continuously deploying, and reports an S3 404 because the artifact is missing.\r\n\r\nGiven that the build manifest is detected (and uploaded) first, the larger artifact upload may be too slow. So let's do the artifact upload first.\r\n\r\n[update] Yep, riffraff continuous deployment works reliably with this change.","created_at":"2015-09-29T10:14:30Z","updated_at":"2015-09-29T12:03:37Z","closed_at":"2015-09-29T12:03:37Z","merged_at":"2015-09-29T12:03:37Z","merge_commit_sha":"02d301113317a42f6d21bb33d1d2f540a81fc0ac","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/13/commits","review_comments_url":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/13/comments","review_comment_url":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues/13/comments","statuses_url":"https://api.github.com/repos/guardian/riffraff-artifact/statuses/342e9302c22257b53fb9b90d73801781dfcfd627","head":{"label":"guardian:upload-ordering","ref":"upload-ordering","sha":"342e9302c22257b53fb9b90d73801781dfcfd627","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":24724253,"name":"riffraff-artifact","full_name":"guardian/riffraff-artifact","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/riffraff-artifact","description":"SBT plugin for creating RiffRaff deployable artifacts","fork":false,"url":"https://api.github.com/repos/guardian/riffraff-artifact","forks_url":"https://api.github.com/repos/guardian/riffraff-artifact/forks","keys_url":"https://api.github.com/repos/guardian/riffraff-artifact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/riffraff-artifact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/riffraff-artifact/teams","hooks_url":"https://api.github.com/repos/guardian/riffraff-artifact/hooks","issue_events_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/riffraff-artifact/events","assignees_url":"https://api.github.com/repos/guardian/riffraff-artifact/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/riffraff-artifact/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/riffraff-artifact/tags","blobs_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/riffraff-artifact/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/riffraff-artifact/languages","stargazers_url":"https://api.github.com/repos/guardian/riffraff-artifact/stargazers","contributors_url":"https://api.github.com/repos/guardian/riffraff-artifact/contributors","subscribers_url":"https://api.github.com/repos/guardian/riffraff-artifact/subscribers","subscription_url":"https://api.github.com/repos/guardian/riffraff-artifact/subscription","commits_url":"https://api.github.com/repos/guardian/riffraff-artifact/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/riffraff-artifact/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/riffraff-artifact/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/riffraff-artifact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/riffraff-artifact/merges","archive_url":"https://api.github.com/repos/guardian/riffraff-artifact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/riffraff-artifact/downloads","issues_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/riffraff-artifact/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/riffraff-artifact/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/riffraff-artifact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/riffraff-artifact/labels{/name}","releases_url":"https://api.github.com/repos/guardian/riffraff-artifact/releases{/id}","created_at":"2014-10-02T15:18:23Z","updated_at":"2015-05-06T15:52:57Z","pushed_at":"2015-09-29T12:03:37Z","git_url":"git://github.com/guardian/riffraff-artifact.git","ssh_url":"git@github.com:guardian/riffraff-artifact.git","clone_url":"https://github.com/guardian/riffraff-artifact.git","svn_url":"https://github.com/guardian/riffraff-artifact","homepage":null,"size":338,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"guardian:master","ref":"master","sha":"ddf358b4e613f3e424d4f0e35166d04ef0cb99ae","user":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"repo":{"id":24724253,"name":"riffraff-artifact","full_name":"guardian/riffraff-artifact","owner":{"login":"guardian","id":164318,"avatar_url":"https://avatars.githubusercontent.com/u/164318?v=3","gravatar_id":"","url":"https://api.github.com/users/guardian","html_url":"https://github.com/guardian","followers_url":"https://api.github.com/users/guardian/followers","following_url":"https://api.github.com/users/guardian/following{/other_user}","gists_url":"https://api.github.com/users/guardian/gists{/gist_id}","starred_url":"https://api.github.com/users/guardian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guardian/subscriptions","organizations_url":"https://api.github.com/users/guardian/orgs","repos_url":"https://api.github.com/users/guardian/repos","events_url":"https://api.github.com/users/guardian/events{/privacy}","received_events_url":"https://api.github.com/users/guardian/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/guardian/riffraff-artifact","description":"SBT plugin for creating RiffRaff deployable artifacts","fork":false,"url":"https://api.github.com/repos/guardian/riffraff-artifact","forks_url":"https://api.github.com/repos/guardian/riffraff-artifact/forks","keys_url":"https://api.github.com/repos/guardian/riffraff-artifact/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guardian/riffraff-artifact/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guardian/riffraff-artifact/teams","hooks_url":"https://api.github.com/repos/guardian/riffraff-artifact/hooks","issue_events_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues/events{/number}","events_url":"https://api.github.com/repos/guardian/riffraff-artifact/events","assignees_url":"https://api.github.com/repos/guardian/riffraff-artifact/assignees{/user}","branches_url":"https://api.github.com/repos/guardian/riffraff-artifact/branches{/branch}","tags_url":"https://api.github.com/repos/guardian/riffraff-artifact/tags","blobs_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/refs{/sha}","trees_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guardian/riffraff-artifact/statuses/{sha}","languages_url":"https://api.github.com/repos/guardian/riffraff-artifact/languages","stargazers_url":"https://api.github.com/repos/guardian/riffraff-artifact/stargazers","contributors_url":"https://api.github.com/repos/guardian/riffraff-artifact/contributors","subscribers_url":"https://api.github.com/repos/guardian/riffraff-artifact/subscribers","subscription_url":"https://api.github.com/repos/guardian/riffraff-artifact/subscription","commits_url":"https://api.github.com/repos/guardian/riffraff-artifact/commits{/sha}","git_commits_url":"https://api.github.com/repos/guardian/riffraff-artifact/git/commits{/sha}","comments_url":"https://api.github.com/repos/guardian/riffraff-artifact/comments{/number}","issue_comment_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues/comments{/number}","contents_url":"https://api.github.com/repos/guardian/riffraff-artifact/contents/{+path}","compare_url":"https://api.github.com/repos/guardian/riffraff-artifact/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guardian/riffraff-artifact/merges","archive_url":"https://api.github.com/repos/guardian/riffraff-artifact/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guardian/riffraff-artifact/downloads","issues_url":"https://api.github.com/repos/guardian/riffraff-artifact/issues{/number}","pulls_url":"https://api.github.com/repos/guardian/riffraff-artifact/pulls{/number}","milestones_url":"https://api.github.com/repos/guardian/riffraff-artifact/milestones{/number}","notifications_url":"https://api.github.com/repos/guardian/riffraff-artifact/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guardian/riffraff-artifact/labels{/name}","releases_url":"https://api.github.com/repos/guardian/riffraff-artifact/releases{/id}","created_at":"2014-10-02T15:18:23Z","updated_at":"2015-05-06T15:52:57Z","pushed_at":"2015-09-29T12:03:37Z","git_url":"git://github.com/guardian/riffraff-artifact.git","ssh_url":"git@github.com:guardian/riffraff-artifact.git","clone_url":"https://github.com/guardian/riffraff-artifact.git","svn_url":"https://github.com/guardian/riffraff-artifact","homepage":null,"size":338,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/13"},"html":{"href":"https://github.com/guardian/riffraff-artifact/pull/13"},"issue":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/issues/13"},"comments":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/guardian/riffraff-artifact/statuses/342e9302c22257b53fb9b90d73801781dfcfd627"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"rich-nguyen","id":4549425,"avatar_url":"https://avatars.githubusercontent.com/u/4549425?v=3","gravatar_id":"","url":"https://api.github.com/users/rich-nguyen","html_url":"https://github.com/rich-nguyen","followers_url":"https://api.github.com/users/rich-nguyen/followers","following_url":"https://api.github.com/users/rich-nguyen/following{/other_user}","gists_url":"https://api.github.com/users/rich-nguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/rich-nguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rich-nguyen/subscriptions","organizations_url":"https://api.github.com/users/rich-nguyen/orgs","repos_url":"https://api.github.com/users/rich-nguyen/repos","events_url":"https://api.github.com/users/rich-nguyen/events{/privacy}","received_events_url":"https://api.github.com/users/rich-nguyen/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":2,"additions":5,"deletions":5,"changed_files":2}}