{"action":"created","issue":{"url":"https://api.github.com/repos/dib-lab/khmer/issues/1159","labels_url":"https://api.github.com/repos/dib-lab/khmer/issues/1159/labels{/name}","comments_url":"https://api.github.com/repos/dib-lab/khmer/issues/1159/comments","events_url":"https://api.github.com/repos/dib-lab/khmer/issues/1159/events","html_url":"https://github.com/dib-lab/khmer/pull/1159","id":93853546,"number":1159,"title":"Escape incorrect signature as hex values","user":{"login":"luizirber","id":6642,"avatar_url":"https://avatars.githubusercontent.com/u/6642?v=3","gravatar_id":"","url":"https://api.github.com/users/luizirber","html_url":"https://github.com/luizirber","followers_url":"https://api.github.com/users/luizirber/followers","following_url":"https://api.github.com/users/luizirber/following{/other_user}","gists_url":"https://api.github.com/users/luizirber/gists{/gist_id}","starred_url":"https://api.github.com/users/luizirber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luizirber/subscriptions","organizations_url":"https://api.github.com/users/luizirber/orgs","repos_url":"https://api.github.com/users/luizirber/repos","events_url":"https://api.github.com/users/luizirber/events{/privacy}","received_events_url":"https://api.github.com/users/luizirber/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-07-08T18:08:33Z","updated_at":"2015-07-08T20:09:50Z","closed_at":"2015-07-08T19:48:44Z","pull_request":{"url":"https://api.github.com/repos/dib-lab/khmer/pulls/1159","html_url":"https://github.com/dib-lab/khmer/pull/1159","diff_url":"https://github.com/dib-lab/khmer/pull/1159.diff","patch_url":"https://github.com/dib-lab/khmer/pull/1159.patch"},"body":"`test_labelhash.py:test_load_wrong_filetype` is failing sometimes. It is somewhat hard to reproduce, but the issue is that the file signature can contain unprintable characters and the Python exception (`OSError`) is not being built properly.\r\n\r\nThis PR just print the char[4] string in hexadecimal. It is a bit weird, because the error message says it should be 'OXLI', which is not hexadecimal...\r\n\r\nPrevious (and this is non-deterministic, file signature can be different values):\r\n`Incorrect file signature >a (m while reading labels/tags from tests/test-data/all-A.fa Should be: OXLI`\r\nNow:\r\n`Incorrect file signature 0x3e612028 while reading labels/tags from tests/test-data/all-A.fa Should be: OXLI`\r\n"},"comment":{"url":"https://api.github.com/repos/dib-lab/khmer/issues/comments/119717168","html_url":"https://github.com/dib-lab/khmer/pull/1159#issuecomment-119717168","issue_url":"https://api.github.com/repos/dib-lab/khmer/issues/1159","id":119717168,"user":{"login":"ctb","id":51016,"avatar_url":"https://avatars.githubusercontent.com/u/51016?v=3","gravatar_id":"","url":"https://api.github.com/users/ctb","html_url":"https://github.com/ctb","followers_url":"https://api.github.com/users/ctb/followers","following_url":"https://api.github.com/users/ctb/following{/other_user}","gists_url":"https://api.github.com/users/ctb/gists{/gist_id}","starred_url":"https://api.github.com/users/ctb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ctb/subscriptions","organizations_url":"https://api.github.com/users/ctb/orgs","repos_url":"https://api.github.com/users/ctb/repos","events_url":"https://api.github.com/users/ctb/events{/privacy}","received_events_url":"https://api.github.com/users/ctb/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T20:09:50Z","updated_at":"2015-07-08T20:09:50Z","body":"On Wed, Jul 08, 2015 at 12:56:09PM -0700, Luiz Irber wrote:\n> There is a lot of copy-and-paste on the save/load code over\n> {labelhash,hashbits,counting,subset,hashtable}.cc, maybe move most of it to\n> hashtable.cc?\n\nPlease file an issue!\n"}}