{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/28315155","id":28315155,"diff_hunk":"@@ -98,15 +95,6 @@ class GeneralizationAcrossTime(object):\n             Duration of each classifier (in seconds). By default, equals one\n             time sample.\n         If None, empty dict. Defaults to None.\n-    predict_type : {'predict', 'predict_proba', 'decision_function'}\n-        Indicates the type of prediction:\n-            'predict' : generates a categorical estimate of each trial.\n-\n-            'predict_proba' : generates a probabilistic estimate of each trial.\n-\n-            'decision_function' : generates a continuous non-probabilistic\n-                estimate of each trial.\n-        Default: 'predict'","path":"mne/decoding/time_gen.py","position":22,"original_position":22,"commit_id":"5c69fbb98c9c59efa6d05ece1ecd0dfd799d5a91","original_commit_id":"5c69fbb98c9c59efa6d05ece1ecd0dfd799d5a91","user":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"body":"not sure, predict proba is a more common use case, not? We should directly support it via the API in a dumb non-expert way.","created_at":"2015-04-14T10:16:55Z","updated_at":"2015-04-14T10:16:55Z","html_url":"https://github.com/mne-tools/mne-python/pull/1965#discussion_r28315155","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/28315155"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/1965#discussion_r28315155"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965","id":33239633,"html_url":"https://github.com/mne-tools/mne-python/pull/1965","diff_url":"https://github.com/mne-tools/mne-python/pull/1965.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/1965.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1965","number":1965,"state":"open","locked":false,"title":"WIP: simplifying gat","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"body":"Following https://github.com/mne-tools/mne-python/issues/1964,  I propose to\r\n1.    Drop the 'predict_type' option. If users want to use a decision_function or a predict_proba (or anything else we currently don't support) they could easily make their own classifier with a inherited class: e.g.\r\n\r\n```\r\nfrom sklearn.svm import SVC\r\nclass my_SVC(SVC):\r\n    def predict(self, x):\r\n        probas = super(my_SVC, self).predict_proba(x)\r\n        return probas[:,0]\r\n```\r\n\r\n2.  Drop the automatic definition of the scorer (AUC if predict_type is probabilistic, Accuracy if discrete, Least Square if Regression etc...) and let the user takes care of this by defining the scorer him/herself.\r\n","created_at":"2015-04-14T09:22:10Z","updated_at":"2015-04-14T10:16:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22ef81da74840b3fa47dcd9506156c507d6c70f4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/1965/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/5c69fbb98c9c59efa6d05ece1ecd0dfd799d5a91","head":{"label":"kingjr:simplifying_gat","ref":"simplifying_gat","sha":"5c69fbb98c9c59efa6d05ece1ecd0dfd799d5a91","user":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"repo":{"id":19731468,"name":"mne-python","full_name":"kingjr/mne-python","owner":{"login":"kingjr","id":4881164,"avatar_url":"https://avatars.githubusercontent.com/u/4881164?v=3","gravatar_id":"","url":"https://api.github.com/users/kingjr","html_url":"https://github.com/kingjr","followers_url":"https://api.github.com/users/kingjr/followers","following_url":"https://api.github.com/users/kingjr/following{/other_user}","gists_url":"https://api.github.com/users/kingjr/gists{/gist_id}","starred_url":"https://api.github.com/users/kingjr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kingjr/subscriptions","organizations_url":"https://api.github.com/users/kingjr/orgs","repos_url":"https://api.github.com/users/kingjr/repos","events_url":"https://api.github.com/users/kingjr/events{/privacy}","received_events_url":"https://api.github.com/users/kingjr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kingjr/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":true,"url":"https://api.github.com/repos/kingjr/mne-python","forks_url":"https://api.github.com/repos/kingjr/mne-python/forks","keys_url":"https://api.github.com/repos/kingjr/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kingjr/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kingjr/mne-python/teams","hooks_url":"https://api.github.com/repos/kingjr/mne-python/hooks","issue_events_url":"https://api.github.com/repos/kingjr/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/kingjr/mne-python/events","assignees_url":"https://api.github.com/repos/kingjr/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/kingjr/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/kingjr/mne-python/tags","blobs_url":"https://api.github.com/repos/kingjr/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kingjr/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kingjr/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/kingjr/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kingjr/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/kingjr/mne-python/languages","stargazers_url":"https://api.github.com/repos/kingjr/mne-python/stargazers","contributors_url":"https://api.github.com/repos/kingjr/mne-python/contributors","subscribers_url":"https://api.github.com/repos/kingjr/mne-python/subscribers","subscription_url":"https://api.github.com/repos/kingjr/mne-python/subscription","commits_url":"https://api.github.com/repos/kingjr/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/kingjr/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/kingjr/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/kingjr/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/kingjr/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/kingjr/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kingjr/mne-python/merges","archive_url":"https://api.github.com/repos/kingjr/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kingjr/mne-python/downloads","issues_url":"https://api.github.com/repos/kingjr/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/kingjr/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/kingjr/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/kingjr/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kingjr/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/kingjr/mne-python/releases{/id}","created_at":"2014-05-13T08:28:44Z","updated_at":"2014-06-02T12:58:51Z","pushed_at":"2015-04-14T09:19:17Z","git_url":"git://github.com/kingjr/mne-python.git","ssh_url":"git@github.com:kingjr/mne-python.git","clone_url":"https://github.com/kingjr/mne-python.git","svn_url":"https://github.com/kingjr/mne-python","homepage":"http://martinos.org/mne/","size":75452,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"a4f58192d9b24ed1303d3cafd9ef448bf7217af6","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","created_at":"2011-01-28T03:31:13Z","updated_at":"2015-04-13T20:12:48Z","pushed_at":"2015-04-14T09:22:10Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":166349,"stargazers_count":124,"watchers_count":124,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":138,"forks":110,"open_issues":138,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/1965"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/1965"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/1965/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/1965/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/5c69fbb98c9c59efa6d05ece1ecd0dfd799d5a91"}}}}