{"action":"created","issue":{"url":"https://api.github.com/repos/hillmanov/gulp-manifest/issues/34","labels_url":"https://api.github.com/repos/hillmanov/gulp-manifest/issues/34/labels{/name}","comments_url":"https://api.github.com/repos/hillmanov/gulp-manifest/issues/34/comments","events_url":"https://api.github.com/repos/hillmanov/gulp-manifest/issues/34/events","html_url":"https://github.com/hillmanov/gulp-manifest/issues/34","id":105199316,"number":34,"title":"Broken paths","user":{"login":"satya164","id":1174278,"avatar_url":"https://avatars.githubusercontent.com/u/1174278?v=3","gravatar_id":"","url":"https://api.github.com/users/satya164","html_url":"https://github.com/satya164","followers_url":"https://api.github.com/users/satya164/followers","following_url":"https://api.github.com/users/satya164/following{/other_user}","gists_url":"https://api.github.com/users/satya164/gists{/gist_id}","starred_url":"https://api.github.com/users/satya164/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satya164/subscriptions","organizations_url":"https://api.github.com/users/satya164/orgs","repos_url":"https://api.github.com/users/satya164/repos","events_url":"https://api.github.com/users/satya164/events{/privacy}","received_events_url":"https://api.github.com/users/satya164/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-07T11:31:24Z","updated_at":"2015-09-07T17:38:52Z","closed_at":null,"body":"The generated manifest file no longer generates correct paths. for example, I've files under, `/public/s/`, when I run `gulp-manifest` with the options\r\n\r\n```\r\n      {\r\n\t\tbasePath: \"public\",\r\n\t\tnetwork: [ \"*\" ],\r\n\t\ttimestamp: true,\r\n\t\tfilename: \"manifest.appcache\"\r\n\t}\r\n```\r\n\r\nIt produces,\r\n\r\n```\r\nCACHE MANIFEST\r\n# Time: Mon Sep 07 2015 11:24:43 GMT+0000 (UTC)\r\n\r\n\r\nCACHE:\r\nscrollback-logo-dark.png\r\nscrollback-logo-dark@2x.png\r\nscrollback-logo-white.png\r\nscrollback-logo-white@2x.png\r\nscrollback-logo.png\r\nscrollback-logo@2x.png\r\nfonts/icons.eot\r\nfonts/icons.svg\r\nfonts/icons.ttf\r\nfonts/icons.woff\r\nscripts/app.bundle.min.js\r\nstyles/embed.min.css\r\nstyles/style.min.css\r\n\r\n\r\nNETWORK:\r\n*\r\n```\r\n\r\nIt should produce this,\r\n\r\n```\r\nCACHE MANIFEST\r\n# Time: Mon Sep 07 2015 11:29:40 GMT+0000 (UTC)\r\n\r\n\r\nCACHE:\r\n/s/assets/logo/scrollback-logo-dark.png\r\n/s/assets/logo/scrollback-logo-dark@2x.png\r\n/s/assets/logo/scrollback-logo-white.png\r\n/s/assets/logo/scrollback-logo-white@2x.png\r\n/s/assets/logo/scrollback-logo.png\r\n/s/assets/logo/scrollback-logo@2x.png\r\n/s/dist/fonts/icons.eot\r\n/s/dist/fonts/icons.svg\r\n/s/dist/fonts/icons.ttf\r\n/s/dist/fonts/icons.woff\r\n/s/dist/scripts/app.bundle.min.js\r\n/s/dist/styles/embed.min.css\r\n/s/dist/styles/style.min.css\r\n\r\n\r\nNETWORK:\r\n*\r\n```\r\n\r\nThe absence of the paths is a biggie for me, which means cache will no longer work :(\r\n\r\nThis basically reverts https://github.com/hillmanov/gulp-manifest/pull/17 which is a genuine case.\r\n\r\nI think the commit https://github.com/hillmanov/gulp-manifest/commit/4962ce06bb1fa66b6ef4fc9df443c8bf7fd77b3f is the culprit.\r\n\r\nCan we please revert that commit, since it's a breaking change and doesn't provide any additional features, while breaking the existing ones."},"comment":{"url":"https://api.github.com/repos/hillmanov/gulp-manifest/issues/comments/138347096","html_url":"https://github.com/hillmanov/gulp-manifest/issues/34#issuecomment-138347096","issue_url":"https://api.github.com/repos/hillmanov/gulp-manifest/issues/34","id":138347096,"user":{"login":"gronke","id":473924,"avatar_url":"https://avatars.githubusercontent.com/u/473924?v=3","gravatar_id":"","url":"https://api.github.com/users/gronke","html_url":"https://github.com/gronke","followers_url":"https://api.github.com/users/gronke/followers","following_url":"https://api.github.com/users/gronke/following{/other_user}","gists_url":"https://api.github.com/users/gronke/gists{/gist_id}","starred_url":"https://api.github.com/users/gronke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gronke/subscriptions","organizations_url":"https://api.github.com/users/gronke/orgs","repos_url":"https://api.github.com/users/gronke/repos","events_url":"https://api.github.com/users/gronke/events{/privacy}","received_events_url":"https://api.github.com/users/gronke/received_events","type":"User","site_admin":false},"created_at":"2015-09-07T17:38:52Z","updated_at":"2015-09-07T17:38:52Z","body":"@satya164 sorry for breaking your config. I'm working on this issue right now and as first step writing more unit tests to drill down what's going wrong.\r\n\r\nCould you please share your Gulp task beginning from `gulp.src`?"}}