{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/18","id":47432812,"html_url":"https://github.com/cisco/cisco-network-puppet-module/pull/18","diff_url":"https://github.com/cisco/cisco-network-puppet-module/pull/18.diff","patch_url":"https://github.com/cisco/cisco-network-puppet-module/pull/18.patch","issue_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/18","number":18,"state":"closed","locked":false,"title":"Tri-state prop changes","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"body":"Change these props to use tri-state values\r\n  additional-paths [receive | send] [disable]\r\n  soft-reconfiguration inbound\r\n\r\nThis is for CSCuw40269.\r\nI originally implemented these properties as multiple boolean properties (e.g.: cap_add_paths_send & cap_add_paths_send_disable); Jie had the same problem with log_neighbor_changes but coded it as a tri-state instead (:enable, :disable, :inherit). The team voted for the tri-states so this is just converting my props over to do the same. On the plus side it's reduced a lot of puppet code.\r\n\r\nI also changed the prop names from cap_add_paths_* to additional_paths_* to match what bgp_af used.\r\n\r\nThis change is dependent on similar changes in node_utils.\r\nBeaker, rubocop are clean.","created_at":"2015-10-12T15:29:06Z","updated_at":"2015-10-13T20:25:27Z","closed_at":"2015-10-13T20:25:27Z","merged_at":null,"merge_commit_sha":"bcc768866d403079dd8139ad847511f13d0141e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/18/commits","review_comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/18/comments","review_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/18/comments","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/2f90763c0d89603eebdd995409b0169b51b728ce","head":{"label":"chrisvanheuveln:nbr_af_tri_states","ref":"nbr_af_tri_states","sha":"2f90763c0d89603eebdd995409b0169b51b728ce","user":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"repo":{"id":43703033,"name":"cisco-network-puppet-module","full_name":"chrisvanheuveln/cisco-network-puppet-module","owner":{"login":"chrisvanheuveln","id":12087548,"avatar_url":"https://avatars.githubusercontent.com/u/12087548?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvanheuveln","html_url":"https://github.com/chrisvanheuveln","followers_url":"https://api.github.com/users/chrisvanheuveln/followers","following_url":"https://api.github.com/users/chrisvanheuveln/following{/other_user}","gists_url":"https://api.github.com/users/chrisvanheuveln/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvanheuveln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvanheuveln/subscriptions","organizations_url":"https://api.github.com/users/chrisvanheuveln/orgs","repos_url":"https://api.github.com/users/chrisvanheuveln/repos","events_url":"https://api.github.com/users/chrisvanheuveln/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvanheuveln/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrisvanheuveln/cisco-network-puppet-module","description":"nbr_af mods","fork":true,"url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/chrisvanheuveln/cisco-network-puppet-module/releases{/id}","created_at":"2015-10-05T17:54:41Z","updated_at":"2015-10-07T16:55:24Z","pushed_at":"2015-10-13T20:22:10Z","git_url":"git://github.com/chrisvanheuveln/cisco-network-puppet-module.git","ssh_url":"git@github.com:chrisvanheuveln/cisco-network-puppet-module.git","clone_url":"https://github.com/chrisvanheuveln/cisco-network-puppet-module.git","svn_url":"https://github.com/chrisvanheuveln/cisco-network-puppet-module","homepage":"","size":745,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cisco:feature/bgp","ref":"feature/bgp","sha":"1da3cf8e3f4d3ed4e4781aa01fb15ad8092e8aad","user":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"repo":{"id":39565139,"name":"cisco-network-puppet-module","full_name":"cisco/cisco-network-puppet-module","owner":{"login":"cisco","id":1376999,"avatar_url":"https://avatars.githubusercontent.com/u/1376999?v=3","gravatar_id":"","url":"https://api.github.com/users/cisco","html_url":"https://github.com/cisco","followers_url":"https://api.github.com/users/cisco/followers","following_url":"https://api.github.com/users/cisco/following{/other_user}","gists_url":"https://api.github.com/users/cisco/gists{/gist_id}","starred_url":"https://api.github.com/users/cisco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cisco/subscriptions","organizations_url":"https://api.github.com/users/cisco/orgs","repos_url":"https://api.github.com/users/cisco/repos","events_url":"https://api.github.com/users/cisco/events{/privacy}","received_events_url":"https://api.github.com/users/cisco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cisco/cisco-network-puppet-module","description":"","fork":false,"url":"https://api.github.com/repos/cisco/cisco-network-puppet-module","forks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/forks","keys_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/teams","hooks_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/hooks","issue_events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/events{/number}","events_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/events","assignees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/assignees{/user}","branches_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/branches{/branch}","tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/tags","blobs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/refs{/sha}","trees_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/{sha}","languages_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/languages","stargazers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/stargazers","contributors_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contributors","subscribers_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscribers","subscription_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/subscription","commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/commits{/sha}","git_commits_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/git/commits{/sha}","comments_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/comments{/number}","issue_comment_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/comments{/number}","contents_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/contents/{+path}","compare_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/merges","archive_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/downloads","issues_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues{/number}","pulls_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls{/number}","milestones_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/milestones{/number}","notifications_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/labels{/name}","releases_url":"https://api.github.com/repos/cisco/cisco-network-puppet-module/releases{/id}","created_at":"2015-07-23T12:06:48Z","updated_at":"2015-10-10T01:12:11Z","pushed_at":"2015-10-13T20:22:11Z","git_url":"git://github.com/cisco/cisco-network-puppet-module.git","ssh_url":"git@github.com:cisco/cisco-network-puppet-module.git","clone_url":"https://github.com/cisco/cisco-network-puppet-module.git","svn_url":"https://github.com/cisco/cisco-network-puppet-module","homepage":null,"size":1243,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":1,"forks":14,"open_issues":1,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/18"},"html":{"href":"https://github.com/cisco/cisco-network-puppet-module/pull/18"},"issue":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/18"},"comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/cisco/cisco-network-puppet-module/statuses/2f90763c0d89603eebdd995409b0169b51b728ce"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":7,"commits":2,"additions":147,"deletions":224,"changed_files":5}}