{"action":"created","issue":{"url":"https://api.github.com/repos/google/closure-library/issues/335","labels_url":"https://api.github.com/repos/google/closure-library/issues/335/labels{/name}","comments_url":"https://api.github.com/repos/google/closure-library/issues/335/comments","events_url":"https://api.github.com/repos/google/closure-library/issues/335/events","html_url":"https://github.com/google/closure-library/pull/335","id":40760176,"number":335,"title":"Handle Multiple Number Groupings","user":{"login":"jvu","id":2966460,"avatar_url":"https://avatars.githubusercontent.com/u/2966460?v=3","gravatar_id":"","url":"https://api.github.com/users/jvu","html_url":"https://github.com/jvu","followers_url":"https://api.github.com/users/jvu/followers","following_url":"https://api.github.com/users/jvu/following{/other_user}","gists_url":"https://api.github.com/users/jvu/gists{/gist_id}","starred_url":"https://api.github.com/users/jvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvu/subscriptions","organizations_url":"https://api.github.com/users/jvu/orgs","repos_url":"https://api.github.com/users/jvu/repos","events_url":"https://api.github.com/users/jvu/events{/privacy}","received_events_url":"https://api.github.com/users/jvu/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/closure-library/labels/CLA:%20no","name":"CLA: no","color":"f7c6c7"},{"url":"https://api.github.com/repos/google/closure-library/labels/Needs%20Reviewer","name":"Needs Reviewer","color":"006b75"},{"url":"https://api.github.com/repos/google/closure-library/labels/P2%20-%20Normal","name":"P2 - Normal","color":"fbca04"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":64,"created_at":"2014-08-21T00:20:12Z","updated_at":"2015-09-15T21:34:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/closure-library/pulls/335","html_url":"https://github.com/google/closure-library/pull/335","diff_url":"https://github.com/google/closure-library/pull/335.diff","patch_url":"https://github.com/google/closure-library/pull/335.patch"},"body":"Our Globalization Engineering team at PayPal found a bug that is affecting those in India. Since the number grouping \"#,##,###\" isn't supported, our team found it was necessary to put in a bit of time and development to support users in India. Please see <b>Indian comma placement</b> found under <a href=\"http://en.wikipedia.org/wiki/Indian_rupee\">Wikipedia's Indian rupee</a>.\r\n\r\nThe pull request includes code development and tests that supports (1) the Indian comma placement for the number grouping \"#,##,###\"; and (2) other future number groupings. The hope for (2) is that regardless of how absurd the number grouping might turn out, it will be supported in Google Closure.\r\n\r\nPlease contact me, <b>John Vu</b> at <a href=\"mailto:jovu@paypal.com\">jovu@paypal.com</a>, if you have any questions.\r\n\r\nP.S. This is my first time contributing to an open-source project so please let me know if there's anything else I should do aside from your <a href=\"https://github.com/google/closure-library/blob/master/CONTRIBUTING\">guidelines for contributing</a>."},"comment":{"url":"https://api.github.com/repos/google/closure-library/issues/comments/140553634","html_url":"https://github.com/google/closure-library/pull/335#issuecomment-140553634","issue_url":"https://api.github.com/repos/google/closure-library/issues/335","id":140553634,"user":{"login":"joeltine","id":13138272,"avatar_url":"https://avatars.githubusercontent.com/u/13138272?v=3","gravatar_id":"","url":"https://api.github.com/users/joeltine","html_url":"https://github.com/joeltine","followers_url":"https://api.github.com/users/joeltine/followers","following_url":"https://api.github.com/users/joeltine/following{/other_user}","gists_url":"https://api.github.com/users/joeltine/gists{/gist_id}","starred_url":"https://api.github.com/users/joeltine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeltine/subscriptions","organizations_url":"https://api.github.com/users/joeltine/orgs","repos_url":"https://api.github.com/users/joeltine/repos","events_url":"https://api.github.com/users/joeltine/events{/privacy}","received_events_url":"https://api.github.com/users/joeltine/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T21:34:05Z","updated_at":"2015-09-15T21:34:05Z","body":"One a side note, I'd recommend compiling/linting before pushing new changes to this PR. Will help you iterate faster. Take a look at https://github.com/google/closure-library/blob/master/scripts/ci/compile_closure.sh for a command to compile."}}