{"action":"created","comment":{"url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/comments/32881971","id":32881971,"diff_hunk":"@@ -119,74 +119,78 @@\n   end\n \n   describe \"received message methods\" do\n-    let(:response_attributes) {{\n+    let(:response_attributes) do\n+      {\n         \"SenderId\" => \"123456789012\",\n         \"SentTimestamp\" => Time.now.to_i.to_s,\n         \"ApproximateReceivedCount\" => \"12\",\n         \"ApproximateFirstReceiveTimestamp\" => (Time.now + 12).to_i.to_s,\n-      }}\n+      }\n+    end\n \n-      let(:response_message) { {\n+    let(:response_message) do\n+      {\n         :message_id => 12345,\n         :md5_of_body => \"mmmddd555\",\n-        :body => {:subject => \"foo\", :body => {:bar => \"baz\"}}.to_json,\n+        :body => { :subject => \"foo\", :body => { :bar => \"baz\" } }.to_json,\n         :receipt_handle => \"HANDLE\",\n         :attributes => response_attributes,\n-      } }\n+      }\n+    end\n \n-      before :each do\n-        response = AWS::SQS::Client.new.stub_for(:receive_message)\n-        response.data[:messages] = [response_message]\n-        AWS::SQS::Client::V20121105.any_instance.stub(:receive_message).and_return(response)\n-        AWS::SQS::Queue.any_instance.stub(:verify_receive_message_checksum).and_return([])\n-      end\n+    before :each do\n+      response = AWS::SQS::Client.new.stub_for(:receive_message)\n+      response.data[:messages] = [response_message]\n+      allow_any_instance_of(AWS::SQS::Client::V20121105).to receive(:receive_message).and_return(response)\n+      allow_any_instance_of(AWS::SQS::Queue).to receive(:verify_receive_message_checksum).and_return([])\n+    end\n \n     it \"should set the visibility timeout when extend is called\" do\n       expect_any_instance_of(AWS::SQS::ReceivedMessage).to receive(:visibility_timeout=).with(10)\n       expect_any_instance_of(AWS::SQS::ReceivedMessage).to receive(:visibility_timeout=).with(0)\n       aws_sqs_queue.pop do |message|\n         message.extend_timeout(10)\n-        message.total_timeout.should eq(10)\n+        expect(message.total_timeout).to eq(10)\n         message.return_to_queue\n-        message.total_timeout.should eq(10)\n+        expect(message.total_timeout).to eq(10)\n       end\n     end\n   end\n \n   describe \"#construct_message_from\" do\n     context \"when the item is directly published to AWS::SQS\" do\n-      let(:sqs_message){ OpenStruct.new(:body => {'subject' => 'foo', 'body' => 'bar'}.to_json) }\n+      let(:sqs_message) { OpenStruct.new(:body => { 'subject' => 'foo', 'body' => 'bar' }.to_json) }\n \n       it \"should return a message\" do\n         result = aws_sqs_queue.construct_message_from(sqs_message)\n-        result.subject.should eq('foo')\n-        result.body.should eq('bar')\n+        expect(result.subject).to eq('foo')\n+        expect(result.body).to eq('bar')\n       end\n     end\n \n     context \"when the item is published through AWS::SNS\" do\n-      let(:sqs_message){ OpenStruct.new(:body => {\"Type\" => \"Notification\", \"Message\" => {'subject' => 'foo', 'body' => 'bar'}.to_json}.to_json) }\n+      let(:sqs_message) { OpenStruct.new(:body => { \"Type\" => \"Notification\", \"Message\" => { 'subject' => 'foo', 'body' => 'bar' }.to_json }.to_json) }","path":"spec/lib/dispatch-rider/queue_services/aws_sqs_spec.rb","position":117,"original_position":117,"commit_id":"66b33362e6ffcafc9e790bb6c7c823d46b53bc52","original_commit_id":"66b33362e6ffcafc9e790bb6c7c823d46b53bc52","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [151/120]<br>Use the new Ruby 1.9 hash syntax.","created_at":"2015-06-20T04:14:53Z","updated_at":"2015-06-20T04:14:53Z","html_url":"https://github.com/payrollhero/dispatch-rider/pull/63#discussion_r32881971","pull_request_url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63","_links":{"self":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/comments/32881971"},"html":{"href":"https://github.com/payrollhero/dispatch-rider/pull/63#discussion_r32881971"},"pull_request":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63"}}},"pull_request":{"url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63","id":38162188,"html_url":"https://github.com/payrollhero/dispatch-rider/pull/63","diff_url":"https://github.com/payrollhero/dispatch-rider/pull/63.diff","patch_url":"https://github.com/payrollhero/dispatch-rider/pull/63.patch","issue_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/63","number":63,"state":"open","locked":false,"title":"Rspec upgrade","user":{"login":"piotrb","id":13251,"avatar_url":"https://avatars.githubusercontent.com/u/13251?v=3","gravatar_id":"","url":"https://api.github.com/users/piotrb","html_url":"https://github.com/piotrb","followers_url":"https://api.github.com/users/piotrb/followers","following_url":"https://api.github.com/users/piotrb/following{/other_user}","gists_url":"https://api.github.com/users/piotrb/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrb/subscriptions","organizations_url":"https://api.github.com/users/piotrb/orgs","repos_url":"https://api.github.com/users/piotrb/repos","events_url":"https://api.github.com/users/piotrb/events{/privacy}","received_events_url":"https://api.github.com/users/piotrb/received_events","type":"User","site_admin":false},"body":"**Feature:**\r\nSaw some deprecations and upgraded the syntax using the transpec gem. Nothing really changing here.\r\n\r\n**Ticket:**\r\n-\r\n\r\n**Submitter Checklist:**\r\n- [ ] CI Passing\r\n- [ ] PR Linked to Asana Ticket\r\n- [ ] Hound Appeased Acceptably\r\n- [ ] No Code Climate Issues\r\n- [ ] Class, Module, and public method comments up to spec\r\n\r\n**Reviewer Checklist:**\r\n- [ ] New Code Tested Effectively\r\n- [ ] Code organization meets SOP standards\r\n- [ ] Does this code fullfill the ticket?\r\n\r\n**Only Then:**\r\n- [ ] Move ticket in Asana","created_at":"2015-06-20T03:52:53Z","updated_at":"2015-06-20T04:14:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f4133a847dfec17942516a4d54a82aefa1f3ea8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63/commits","review_comments_url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63/comments","review_comment_url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/comments{/number}","comments_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/63/comments","statuses_url":"https://api.github.com/repos/payrollhero/dispatch-rider/statuses/66b33362e6ffcafc9e790bb6c7c823d46b53bc52","head":{"label":"payrollhero:rspec-upgrade","ref":"rspec-upgrade","sha":"66b33362e6ffcafc9e790bb6c7c823d46b53bc52","user":{"login":"payrollhero","id":1617662,"avatar_url":"https://avatars.githubusercontent.com/u/1617662?v=3","gravatar_id":"","url":"https://api.github.com/users/payrollhero","html_url":"https://github.com/payrollhero","followers_url":"https://api.github.com/users/payrollhero/followers","following_url":"https://api.github.com/users/payrollhero/following{/other_user}","gists_url":"https://api.github.com/users/payrollhero/gists{/gist_id}","starred_url":"https://api.github.com/users/payrollhero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payrollhero/subscriptions","organizations_url":"https://api.github.com/users/payrollhero/orgs","repos_url":"https://api.github.com/users/payrollhero/repos","events_url":"https://api.github.com/users/payrollhero/events{/privacy}","received_events_url":"https://api.github.com/users/payrollhero/received_events","type":"Organization","site_admin":false},"repo":{"id":8812568,"name":"dispatch-rider","full_name":"payrollhero/dispatch-rider","owner":{"login":"payrollhero","id":1617662,"avatar_url":"https://avatars.githubusercontent.com/u/1617662?v=3","gravatar_id":"","url":"https://api.github.com/users/payrollhero","html_url":"https://github.com/payrollhero","followers_url":"https://api.github.com/users/payrollhero/followers","following_url":"https://api.github.com/users/payrollhero/following{/other_user}","gists_url":"https://api.github.com/users/payrollhero/gists{/gist_id}","starred_url":"https://api.github.com/users/payrollhero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payrollhero/subscriptions","organizations_url":"https://api.github.com/users/payrollhero/orgs","repos_url":"https://api.github.com/users/payrollhero/repos","events_url":"https://api.github.com/users/payrollhero/events{/privacy}","received_events_url":"https://api.github.com/users/payrollhero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/payrollhero/dispatch-rider","description":"A messaging system (pub/sub).","fork":false,"url":"https://api.github.com/repos/payrollhero/dispatch-rider","forks_url":"https://api.github.com/repos/payrollhero/dispatch-rider/forks","keys_url":"https://api.github.com/repos/payrollhero/dispatch-rider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payrollhero/dispatch-rider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payrollhero/dispatch-rider/teams","hooks_url":"https://api.github.com/repos/payrollhero/dispatch-rider/hooks","issue_events_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/events{/number}","events_url":"https://api.github.com/repos/payrollhero/dispatch-rider/events","assignees_url":"https://api.github.com/repos/payrollhero/dispatch-rider/assignees{/user}","branches_url":"https://api.github.com/repos/payrollhero/dispatch-rider/branches{/branch}","tags_url":"https://api.github.com/repos/payrollhero/dispatch-rider/tags","blobs_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/refs{/sha}","trees_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payrollhero/dispatch-rider/statuses/{sha}","languages_url":"https://api.github.com/repos/payrollhero/dispatch-rider/languages","stargazers_url":"https://api.github.com/repos/payrollhero/dispatch-rider/stargazers","contributors_url":"https://api.github.com/repos/payrollhero/dispatch-rider/contributors","subscribers_url":"https://api.github.com/repos/payrollhero/dispatch-rider/subscribers","subscription_url":"https://api.github.com/repos/payrollhero/dispatch-rider/subscription","commits_url":"https://api.github.com/repos/payrollhero/dispatch-rider/commits{/sha}","git_commits_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/commits{/sha}","comments_url":"https://api.github.com/repos/payrollhero/dispatch-rider/comments{/number}","issue_comment_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/comments{/number}","contents_url":"https://api.github.com/repos/payrollhero/dispatch-rider/contents/{+path}","compare_url":"https://api.github.com/repos/payrollhero/dispatch-rider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payrollhero/dispatch-rider/merges","archive_url":"https://api.github.com/repos/payrollhero/dispatch-rider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payrollhero/dispatch-rider/downloads","issues_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues{/number}","pulls_url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls{/number}","milestones_url":"https://api.github.com/repos/payrollhero/dispatch-rider/milestones{/number}","notifications_url":"https://api.github.com/repos/payrollhero/dispatch-rider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payrollhero/dispatch-rider/labels{/name}","releases_url":"https://api.github.com/repos/payrollhero/dispatch-rider/releases{/id}","created_at":"2013-03-16T01:47:40Z","updated_at":"2015-04-15T00:39:45Z","pushed_at":"2015-06-20T04:14:43Z","git_url":"git://github.com/payrollhero/dispatch-rider.git","ssh_url":"git@github.com:payrollhero/dispatch-rider.git","clone_url":"https://github.com/payrollhero/dispatch-rider.git","svn_url":"https://github.com/payrollhero/dispatch-rider","homepage":"","size":1623,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"master"}},"base":{"label":"payrollhero:master","ref":"master","sha":"a6929e430f5cbd1b0d959777a04999e094119ee7","user":{"login":"payrollhero","id":1617662,"avatar_url":"https://avatars.githubusercontent.com/u/1617662?v=3","gravatar_id":"","url":"https://api.github.com/users/payrollhero","html_url":"https://github.com/payrollhero","followers_url":"https://api.github.com/users/payrollhero/followers","following_url":"https://api.github.com/users/payrollhero/following{/other_user}","gists_url":"https://api.github.com/users/payrollhero/gists{/gist_id}","starred_url":"https://api.github.com/users/payrollhero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payrollhero/subscriptions","organizations_url":"https://api.github.com/users/payrollhero/orgs","repos_url":"https://api.github.com/users/payrollhero/repos","events_url":"https://api.github.com/users/payrollhero/events{/privacy}","received_events_url":"https://api.github.com/users/payrollhero/received_events","type":"Organization","site_admin":false},"repo":{"id":8812568,"name":"dispatch-rider","full_name":"payrollhero/dispatch-rider","owner":{"login":"payrollhero","id":1617662,"avatar_url":"https://avatars.githubusercontent.com/u/1617662?v=3","gravatar_id":"","url":"https://api.github.com/users/payrollhero","html_url":"https://github.com/payrollhero","followers_url":"https://api.github.com/users/payrollhero/followers","following_url":"https://api.github.com/users/payrollhero/following{/other_user}","gists_url":"https://api.github.com/users/payrollhero/gists{/gist_id}","starred_url":"https://api.github.com/users/payrollhero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/payrollhero/subscriptions","organizations_url":"https://api.github.com/users/payrollhero/orgs","repos_url":"https://api.github.com/users/payrollhero/repos","events_url":"https://api.github.com/users/payrollhero/events{/privacy}","received_events_url":"https://api.github.com/users/payrollhero/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/payrollhero/dispatch-rider","description":"A messaging system (pub/sub).","fork":false,"url":"https://api.github.com/repos/payrollhero/dispatch-rider","forks_url":"https://api.github.com/repos/payrollhero/dispatch-rider/forks","keys_url":"https://api.github.com/repos/payrollhero/dispatch-rider/keys{/key_id}","collaborators_url":"https://api.github.com/repos/payrollhero/dispatch-rider/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/payrollhero/dispatch-rider/teams","hooks_url":"https://api.github.com/repos/payrollhero/dispatch-rider/hooks","issue_events_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/events{/number}","events_url":"https://api.github.com/repos/payrollhero/dispatch-rider/events","assignees_url":"https://api.github.com/repos/payrollhero/dispatch-rider/assignees{/user}","branches_url":"https://api.github.com/repos/payrollhero/dispatch-rider/branches{/branch}","tags_url":"https://api.github.com/repos/payrollhero/dispatch-rider/tags","blobs_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/refs{/sha}","trees_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/trees{/sha}","statuses_url":"https://api.github.com/repos/payrollhero/dispatch-rider/statuses/{sha}","languages_url":"https://api.github.com/repos/payrollhero/dispatch-rider/languages","stargazers_url":"https://api.github.com/repos/payrollhero/dispatch-rider/stargazers","contributors_url":"https://api.github.com/repos/payrollhero/dispatch-rider/contributors","subscribers_url":"https://api.github.com/repos/payrollhero/dispatch-rider/subscribers","subscription_url":"https://api.github.com/repos/payrollhero/dispatch-rider/subscription","commits_url":"https://api.github.com/repos/payrollhero/dispatch-rider/commits{/sha}","git_commits_url":"https://api.github.com/repos/payrollhero/dispatch-rider/git/commits{/sha}","comments_url":"https://api.github.com/repos/payrollhero/dispatch-rider/comments{/number}","issue_comment_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/comments{/number}","contents_url":"https://api.github.com/repos/payrollhero/dispatch-rider/contents/{+path}","compare_url":"https://api.github.com/repos/payrollhero/dispatch-rider/compare/{base}...{head}","merges_url":"https://api.github.com/repos/payrollhero/dispatch-rider/merges","archive_url":"https://api.github.com/repos/payrollhero/dispatch-rider/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/payrollhero/dispatch-rider/downloads","issues_url":"https://api.github.com/repos/payrollhero/dispatch-rider/issues{/number}","pulls_url":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls{/number}","milestones_url":"https://api.github.com/repos/payrollhero/dispatch-rider/milestones{/number}","notifications_url":"https://api.github.com/repos/payrollhero/dispatch-rider/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/payrollhero/dispatch-rider/labels{/name}","releases_url":"https://api.github.com/repos/payrollhero/dispatch-rider/releases{/id}","created_at":"2013-03-16T01:47:40Z","updated_at":"2015-04-15T00:39:45Z","pushed_at":"2015-06-20T04:14:43Z","git_url":"git://github.com/payrollhero/dispatch-rider.git","ssh_url":"git@github.com:payrollhero/dispatch-rider.git","clone_url":"https://github.com/payrollhero/dispatch-rider.git","svn_url":"https://github.com/payrollhero/dispatch-rider","homepage":"","size":1623,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":5,"forks":4,"open_issues":5,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63"},"html":{"href":"https://github.com/payrollhero/dispatch-rider/pull/63"},"issue":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/63"},"comments":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/payrollhero/dispatch-rider/statuses/66b33362e6ffcafc9e790bb6c7c823d46b53bc52"}}}}