{"action":"created","issue":{"url":"https://api.github.com/repos/aheckmann/node-ses/issues/15","labels_url":"https://api.github.com/repos/aheckmann/node-ses/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/aheckmann/node-ses/issues/15/comments","events_url":"https://api.github.com/repos/aheckmann/node-ses/issues/15/events","html_url":"https://github.com/aheckmann/node-ses/pull/15","id":67205336,"number":15,"title":"Removing xml2json dependency for xml2js for smaller dependency footprint...","user":{"login":"cromestant","id":56137,"avatar_url":"https://avatars.githubusercontent.com/u/56137?v=3","gravatar_id":"","url":"https://api.github.com/users/cromestant","html_url":"https://github.com/cromestant","followers_url":"https://api.github.com/users/cromestant/followers","following_url":"https://api.github.com/users/cromestant/following{/other_user}","gists_url":"https://api.github.com/users/cromestant/gists{/gist_id}","starred_url":"https://api.github.com/users/cromestant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cromestant/subscriptions","organizations_url":"https://api.github.com/users/cromestant/orgs","repos_url":"https://api.github.com/users/cromestant/repos","events_url":"https://api.github.com/users/cromestant/events{/privacy}","received_events_url":"https://api.github.com/users/cromestant/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-04-08T19:50:28Z","updated_at":"2015-04-15T13:40:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/aheckmann/node-ses/pulls/15","html_url":"https://github.com/aheckmann/node-ses/pull/15","diff_url":"https://github.com/aheckmann/node-ses/pull/15.diff","patch_url":"https://github.com/aheckmann/node-ses/pull/15.patch"},"body":"xml2json module builds lots of dependencie sand is huge.\r\nUnless I missed something ( tests pass) it is not required and can do with this smaller footprint xml2js module."},"comment":{"url":"https://api.github.com/repos/aheckmann/node-ses/issues/comments/93405098","html_url":"https://github.com/aheckmann/node-ses/pull/15#issuecomment-93405098","issue_url":"https://api.github.com/repos/aheckmann/node-ses/issues/15","id":93405098,"user":{"login":"markstos","id":25829,"avatar_url":"https://avatars.githubusercontent.com/u/25829?v=3","gravatar_id":"","url":"https://api.github.com/users/markstos","html_url":"https://github.com/markstos","followers_url":"https://api.github.com/users/markstos/followers","following_url":"https://api.github.com/users/markstos/following{/other_user}","gists_url":"https://api.github.com/users/markstos/gists{/gist_id}","starred_url":"https://api.github.com/users/markstos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markstos/subscriptions","organizations_url":"https://api.github.com/users/markstos/orgs","repos_url":"https://api.github.com/users/markstos/repos","events_url":"https://api.github.com/users/markstos/events{/privacy}","received_events_url":"https://api.github.com/users/markstos/received_events","type":"User","site_admin":false},"created_at":"2015-04-15T13:40:44Z","updated_at":"2015-04-15T13:40:44Z","body":"I found the patch had a bug in it. It lacked some `return` calls, so that when the XML error parsing was invoked, the callback would be called twice, once as an \"error\" and then a second time as \"success\". \r\n\r\nI added new test coverage to check for this and also fixed the issue. \r\n\r\nI squashed the various commits and merged them into master:\r\n\r\nhttps://github.com/aheckmann/node-ses/commit/600e9013d630f04fa08ea83b09017be7322298c3\r\n\r\nUnless @aheckmann or @robludwig object in the next day or so, I'll publish the new version which replaces the xml2json dependency with xml2js.\r\n\r\nThe new version I prepared also bumps our other dependencies as long as we are doing some maintenance. "}}