{"action":"created","comment":{"url":"https://api.github.com/repos/phstc/shoryuken/pulls/comments/22430807","id":22430807,"diff_hunk":"@@ -173,11 +173,10 @@ def next_queue\n       # get/remove the first queue in the list\n       queue = @queues.shift\n \n-\n-      unless Shoryuken.workers.include? queue\n+      unless defined?(::ActiveJob) || Shoryuken.workers.include?(queue)","path":"lib/shoryuken/manager.rb","position":6,"original_position":6,"commit_id":"548c94ccbc8347303e9fcf4e6e793785c3aad68d","original_commit_id":"548c94ccbc8347303e9fcf4e6e793785c3aad68d","user":{"login":"elsurudo","id":50223,"avatar_url":"https://avatars.githubusercontent.com/u/50223?v=3","gravatar_id":"","url":"https://api.github.com/users/elsurudo","html_url":"https://github.com/elsurudo","followers_url":"https://api.github.com/users/elsurudo/followers","following_url":"https://api.github.com/users/elsurudo/following{/other_user}","gists_url":"https://api.github.com/users/elsurudo/gists{/gist_id}","starred_url":"https://api.github.com/users/elsurudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsurudo/subscriptions","organizations_url":"https://api.github.com/users/elsurudo/orgs","repos_url":"https://api.github.com/users/elsurudo/repos","events_url":"https://api.github.com/users/elsurudo/events{/privacy}","received_events_url":"https://api.github.com/users/elsurudo/received_events","type":"User","site_admin":false},"body":"I had this in there originally because I found that only jobs on the default queue were being processed. However, I just tried getting rid of this now and all queues are processing, so it must have been unrelated.\r\n\r\nGood catch! Will update.","created_at":"2015-01-03T10:19:11Z","updated_at":"2015-01-03T10:19:11Z","html_url":"https://github.com/phstc/shoryuken/pull/28#discussion_r22430807","pull_request_url":"https://api.github.com/repos/phstc/shoryuken/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/comments/22430807"},"html":{"href":"https://github.com/phstc/shoryuken/pull/28#discussion_r22430807"},"pull_request":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/phstc/shoryuken/pulls/28","id":26757827,"html_url":"https://github.com/phstc/shoryuken/pull/28","diff_url":"https://github.com/phstc/shoryuken/pull/28.diff","patch_url":"https://github.com/phstc/shoryuken/pull/28.patch","issue_url":"https://api.github.com/repos/phstc/shoryuken/issues/28","number":28,"state":"open","locked":false,"title":"ActiveJob support","user":{"login":"elsurudo","id":50223,"avatar_url":"https://avatars.githubusercontent.com/u/50223?v=3","gravatar_id":"","url":"https://api.github.com/users/elsurudo","html_url":"https://github.com/elsurudo","followers_url":"https://api.github.com/users/elsurudo/followers","following_url":"https://api.github.com/users/elsurudo/following{/other_user}","gists_url":"https://api.github.com/users/elsurudo/gists{/gist_id}","starred_url":"https://api.github.com/users/elsurudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsurudo/subscriptions","organizations_url":"https://api.github.com/users/elsurudo/orgs","repos_url":"https://api.github.com/users/elsurudo/repos","events_url":"https://api.github.com/users/elsurudo/events{/privacy}","received_events_url":"https://api.github.com/users/elsurudo/received_events","type":"User","site_admin":false},"body":"This is working for me in development currently. This is similar to the code @phstc posted here: https://github.com/phstc/shoryuken/issues/4#issuecomment-62056681, with a few fixes and improvements.\r\n\r\nNotes:\r\n- Queue pausing/sleeping is disabled when ActiveJob is present. This is needed because the workers are dynamically-defined, so the queues would be paused indefinitely and jobs wouldn't be processed.\r\n- Logging middleware altered to use the ActiveJob subclass name (instead of wrapper class name) for better logging.\r\n- It would be good to add tests, but I'm not sure where to start with this yet. All current tests pass.\r\n- Altered Celluloid dependency to track the minor version, in case of breaking changes.","created_at":"2015-01-02T13:59:38Z","updated_at":"2015-01-03T10:19:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f440a13add881301a51f8b265faf024e5bfbfa11","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/phstc/shoryuken/pulls/28/commits","review_comments_url":"https://api.github.com/repos/phstc/shoryuken/pulls/28/comments","review_comment_url":"https://api.github.com/repos/phstc/shoryuken/pulls/comments/{number}","comments_url":"https://api.github.com/repos/phstc/shoryuken/issues/28/comments","statuses_url":"https://api.github.com/repos/phstc/shoryuken/statuses/548c94ccbc8347303e9fcf4e6e793785c3aad68d","head":{"label":"elsurudo:active-job","ref":"active-job","sha":"548c94ccbc8347303e9fcf4e6e793785c3aad68d","user":{"login":"elsurudo","id":50223,"avatar_url":"https://avatars.githubusercontent.com/u/50223?v=3","gravatar_id":"","url":"https://api.github.com/users/elsurudo","html_url":"https://github.com/elsurudo","followers_url":"https://api.github.com/users/elsurudo/followers","following_url":"https://api.github.com/users/elsurudo/following{/other_user}","gists_url":"https://api.github.com/users/elsurudo/gists{/gist_id}","starred_url":"https://api.github.com/users/elsurudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsurudo/subscriptions","organizations_url":"https://api.github.com/users/elsurudo/orgs","repos_url":"https://api.github.com/users/elsurudo/repos","events_url":"https://api.github.com/users/elsurudo/events{/privacy}","received_events_url":"https://api.github.com/users/elsurudo/received_events","type":"User","site_admin":false},"repo":{"id":26116851,"name":"shoryuken","full_name":"elsurudo/shoryuken","owner":{"login":"elsurudo","id":50223,"avatar_url":"https://avatars.githubusercontent.com/u/50223?v=3","gravatar_id":"","url":"https://api.github.com/users/elsurudo","html_url":"https://github.com/elsurudo","followers_url":"https://api.github.com/users/elsurudo/followers","following_url":"https://api.github.com/users/elsurudo/following{/other_user}","gists_url":"https://api.github.com/users/elsurudo/gists{/gist_id}","starred_url":"https://api.github.com/users/elsurudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elsurudo/subscriptions","organizations_url":"https://api.github.com/users/elsurudo/orgs","repos_url":"https://api.github.com/users/elsurudo/repos","events_url":"https://api.github.com/users/elsurudo/events{/privacy}","received_events_url":"https://api.github.com/users/elsurudo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elsurudo/shoryuken","description":"A super efficient AWS SQS thread based message processor for Ruby","fork":true,"url":"https://api.github.com/repos/elsurudo/shoryuken","forks_url":"https://api.github.com/repos/elsurudo/shoryuken/forks","keys_url":"https://api.github.com/repos/elsurudo/shoryuken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elsurudo/shoryuken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elsurudo/shoryuken/teams","hooks_url":"https://api.github.com/repos/elsurudo/shoryuken/hooks","issue_events_url":"https://api.github.com/repos/elsurudo/shoryuken/issues/events{/number}","events_url":"https://api.github.com/repos/elsurudo/shoryuken/events","assignees_url":"https://api.github.com/repos/elsurudo/shoryuken/assignees{/user}","branches_url":"https://api.github.com/repos/elsurudo/shoryuken/branches{/branch}","tags_url":"https://api.github.com/repos/elsurudo/shoryuken/tags","blobs_url":"https://api.github.com/repos/elsurudo/shoryuken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elsurudo/shoryuken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elsurudo/shoryuken/git/refs{/sha}","trees_url":"https://api.github.com/repos/elsurudo/shoryuken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elsurudo/shoryuken/statuses/{sha}","languages_url":"https://api.github.com/repos/elsurudo/shoryuken/languages","stargazers_url":"https://api.github.com/repos/elsurudo/shoryuken/stargazers","contributors_url":"https://api.github.com/repos/elsurudo/shoryuken/contributors","subscribers_url":"https://api.github.com/repos/elsurudo/shoryuken/subscribers","subscription_url":"https://api.github.com/repos/elsurudo/shoryuken/subscription","commits_url":"https://api.github.com/repos/elsurudo/shoryuken/commits{/sha}","git_commits_url":"https://api.github.com/repos/elsurudo/shoryuken/git/commits{/sha}","comments_url":"https://api.github.com/repos/elsurudo/shoryuken/comments{/number}","issue_comment_url":"https://api.github.com/repos/elsurudo/shoryuken/issues/comments/{number}","contents_url":"https://api.github.com/repos/elsurudo/shoryuken/contents/{+path}","compare_url":"https://api.github.com/repos/elsurudo/shoryuken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elsurudo/shoryuken/merges","archive_url":"https://api.github.com/repos/elsurudo/shoryuken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elsurudo/shoryuken/downloads","issues_url":"https://api.github.com/repos/elsurudo/shoryuken/issues{/number}","pulls_url":"https://api.github.com/repos/elsurudo/shoryuken/pulls{/number}","milestones_url":"https://api.github.com/repos/elsurudo/shoryuken/milestones{/number}","notifications_url":"https://api.github.com/repos/elsurudo/shoryuken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elsurudo/shoryuken/labels{/name}","releases_url":"https://api.github.com/repos/elsurudo/shoryuken/releases{/id}","created_at":"2014-11-03T12:07:24Z","updated_at":"2014-12-11T21:22:04Z","pushed_at":"2015-01-02T13:49:19Z","git_url":"git://github.com/elsurudo/shoryuken.git","ssh_url":"git@github.com:elsurudo/shoryuken.git","clone_url":"https://github.com/elsurudo/shoryuken.git","svn_url":"https://github.com/elsurudo/shoryuken","homepage":"https://github.com/phstc/shoryuken","size":356,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"phstc:master","ref":"master","sha":"315d89a6d766d513a296c269a171467950070df4","user":{"login":"phstc","id":105652,"avatar_url":"https://avatars.githubusercontent.com/u/105652?v=3","gravatar_id":"","url":"https://api.github.com/users/phstc","html_url":"https://github.com/phstc","followers_url":"https://api.github.com/users/phstc/followers","following_url":"https://api.github.com/users/phstc/following{/other_user}","gists_url":"https://api.github.com/users/phstc/gists{/gist_id}","starred_url":"https://api.github.com/users/phstc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phstc/subscriptions","organizations_url":"https://api.github.com/users/phstc/orgs","repos_url":"https://api.github.com/users/phstc/repos","events_url":"https://api.github.com/users/phstc/events{/privacy}","received_events_url":"https://api.github.com/users/phstc/received_events","type":"User","site_admin":false},"repo":{"id":23578850,"name":"shoryuken","full_name":"phstc/shoryuken","owner":{"login":"phstc","id":105652,"avatar_url":"https://avatars.githubusercontent.com/u/105652?v=3","gravatar_id":"","url":"https://api.github.com/users/phstc","html_url":"https://github.com/phstc","followers_url":"https://api.github.com/users/phstc/followers","following_url":"https://api.github.com/users/phstc/following{/other_user}","gists_url":"https://api.github.com/users/phstc/gists{/gist_id}","starred_url":"https://api.github.com/users/phstc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phstc/subscriptions","organizations_url":"https://api.github.com/users/phstc/orgs","repos_url":"https://api.github.com/users/phstc/repos","events_url":"https://api.github.com/users/phstc/events{/privacy}","received_events_url":"https://api.github.com/users/phstc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phstc/shoryuken","description":"A super efficient AWS SQS thread based message processor for Ruby","fork":false,"url":"https://api.github.com/repos/phstc/shoryuken","forks_url":"https://api.github.com/repos/phstc/shoryuken/forks","keys_url":"https://api.github.com/repos/phstc/shoryuken/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phstc/shoryuken/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phstc/shoryuken/teams","hooks_url":"https://api.github.com/repos/phstc/shoryuken/hooks","issue_events_url":"https://api.github.com/repos/phstc/shoryuken/issues/events{/number}","events_url":"https://api.github.com/repos/phstc/shoryuken/events","assignees_url":"https://api.github.com/repos/phstc/shoryuken/assignees{/user}","branches_url":"https://api.github.com/repos/phstc/shoryuken/branches{/branch}","tags_url":"https://api.github.com/repos/phstc/shoryuken/tags","blobs_url":"https://api.github.com/repos/phstc/shoryuken/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phstc/shoryuken/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phstc/shoryuken/git/refs{/sha}","trees_url":"https://api.github.com/repos/phstc/shoryuken/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phstc/shoryuken/statuses/{sha}","languages_url":"https://api.github.com/repos/phstc/shoryuken/languages","stargazers_url":"https://api.github.com/repos/phstc/shoryuken/stargazers","contributors_url":"https://api.github.com/repos/phstc/shoryuken/contributors","subscribers_url":"https://api.github.com/repos/phstc/shoryuken/subscribers","subscription_url":"https://api.github.com/repos/phstc/shoryuken/subscription","commits_url":"https://api.github.com/repos/phstc/shoryuken/commits{/sha}","git_commits_url":"https://api.github.com/repos/phstc/shoryuken/git/commits{/sha}","comments_url":"https://api.github.com/repos/phstc/shoryuken/comments{/number}","issue_comment_url":"https://api.github.com/repos/phstc/shoryuken/issues/comments/{number}","contents_url":"https://api.github.com/repos/phstc/shoryuken/contents/{+path}","compare_url":"https://api.github.com/repos/phstc/shoryuken/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phstc/shoryuken/merges","archive_url":"https://api.github.com/repos/phstc/shoryuken/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phstc/shoryuken/downloads","issues_url":"https://api.github.com/repos/phstc/shoryuken/issues{/number}","pulls_url":"https://api.github.com/repos/phstc/shoryuken/pulls{/number}","milestones_url":"https://api.github.com/repos/phstc/shoryuken/milestones{/number}","notifications_url":"https://api.github.com/repos/phstc/shoryuken/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phstc/shoryuken/labels{/name}","releases_url":"https://api.github.com/repos/phstc/shoryuken/releases{/id}","created_at":"2014-09-02T13:04:10Z","updated_at":"2014-12-31T14:07:41Z","pushed_at":"2014-12-31T14:07:41Z","git_url":"git://github.com/phstc/shoryuken.git","ssh_url":"git@github.com:phstc/shoryuken.git","clone_url":"https://github.com/phstc/shoryuken.git","svn_url":"https://github.com/phstc/shoryuken","homepage":"https://github.com/phstc/shoryuken","size":1185,"stargazers_count":199,"watchers_count":199,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":5,"forks":7,"open_issues":5,"watchers":199,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/28"},"html":{"href":"https://github.com/phstc/shoryuken/pull/28"},"issue":{"href":"https://api.github.com/repos/phstc/shoryuken/issues/28"},"comments":{"href":"https://api.github.com/repos/phstc/shoryuken/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/phstc/shoryuken/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/phstc/shoryuken/statuses/548c94ccbc8347303e9fcf4e6e793785c3aad68d"}}}}