{"action":"created","comment":{"url":"https://api.github.com/repos/videojs/video.js/pulls/comments/38601193","id":38601193,"diff_hunk":"@@ -69,6 +70,15 @@ class Flash extends Tech {\n   createEl() {\n     let options = this.options_;\n \n+    // If video.js is hosted locally you should also set the location\n+    // for the hosted swf, which should be relative to the page (not video.js)\n+    // Otherwise this adds a CDN url.\n+    // The CDN also auto-adds a swf URL for that specific version.\n+    if (!options.swf) {\n+      let protocol = ('https:' === window.location.protocol ? 'https://' : 'http://');\n+      options.swf = protocol+'vjs.zencdn.net/swf/'+pkg.dependencies['videojs-swf']+'/video-js.swf';","path":"src/js/tech/flash.js","position":18,"original_position":18,"commit_id":"0db28220669611403cbd41eedf71ab50a009b79e","original_commit_id":"0db28220669611403cbd41eedf71ab50a009b79e","user":{"login":"gkatsev","id":535884,"avatar_url":"https://avatars.githubusercontent.com/u/535884?v=3","gravatar_id":"","url":"https://api.github.com/users/gkatsev","html_url":"https://github.com/gkatsev","followers_url":"https://api.github.com/users/gkatsev/followers","following_url":"https://api.github.com/users/gkatsev/following{/other_user}","gists_url":"https://api.github.com/users/gkatsev/gists{/gist_id}","starred_url":"https://api.github.com/users/gkatsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkatsev/subscriptions","organizations_url":"https://api.github.com/users/gkatsev/orgs","repos_url":"https://api.github.com/users/gkatsev/repos","events_url":"https://api.github.com/users/gkatsev/events{/privacy}","received_events_url":"https://api.github.com/users/gkatsev/received_events","type":"User","site_admin":false},"body":"will the version string of the swf always be just the version? Could we at some point switch to using `^` or anything that could cause this to break?","created_at":"2015-09-03T00:10:21Z","updated_at":"2015-09-03T00:10:21Z","html_url":"https://github.com/videojs/video.js/pull/2533#discussion_r38601193","pull_request_url":"https://api.github.com/repos/videojs/video.js/pulls/2533","_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments/38601193"},"html":{"href":"https://github.com/videojs/video.js/pull/2533#discussion_r38601193"},"pull_request":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2533"}}},"pull_request":{"url":"https://api.github.com/repos/videojs/video.js/pulls/2533","id":43827943,"html_url":"https://github.com/videojs/video.js/pull/2533","diff_url":"https://github.com/videojs/video.js/pull/2533.diff","patch_url":"https://github.com/videojs/video.js/pull/2533.patch","issue_url":"https://api.github.com/repos/videojs/video.js/issues/2533","number":2533,"state":"open","locked":false,"title":"Added a default swf url","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"body":"fixes #2488 \r\n\r\n> The swf URL needs to be relative to the page (not video.js)\r\nso this probably won't work for most, but it's the best we can do.\r\nThe CDN auto-adds a better swf URL for that specific version.\r\nOtherwise you just need to set your swf location","created_at":"2015-09-01T01:11:56Z","updated_at":"2015-09-03T00:10:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3701d420783b758d13a04fbbab76279c52bb5e95","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/videojs/video.js/pulls/2533/commits","review_comments_url":"https://api.github.com/repos/videojs/video.js/pulls/2533/comments","review_comment_url":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videojs/video.js/issues/2533/comments","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/0db28220669611403cbd41eedf71ab50a009b79e","head":{"label":"heff:fix-default-swf","ref":"fix-default-swf","sha":"0db28220669611403cbd41eedf71ab50a009b79e","user":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"repo":{"id":5362506,"name":"video.js","full_name":"heff/video.js","owner":{"login":"heff","id":166,"avatar_url":"https://avatars.githubusercontent.com/u/166?v=3","gravatar_id":"","url":"https://api.github.com/users/heff","html_url":"https://github.com/heff","followers_url":"https://api.github.com/users/heff/followers","following_url":"https://api.github.com/users/heff/following{/other_user}","gists_url":"https://api.github.com/users/heff/gists{/gist_id}","starred_url":"https://api.github.com/users/heff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heff/subscriptions","organizations_url":"https://api.github.com/users/heff/orgs","repos_url":"https://api.github.com/users/heff/repos","events_url":"https://api.github.com/users/heff/events{/privacy}","received_events_url":"https://api.github.com/users/heff/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heff/video.js","description":"Universal video embed.","fork":true,"url":"https://api.github.com/repos/heff/video.js","forks_url":"https://api.github.com/repos/heff/video.js/forks","keys_url":"https://api.github.com/repos/heff/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heff/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heff/video.js/teams","hooks_url":"https://api.github.com/repos/heff/video.js/hooks","issue_events_url":"https://api.github.com/repos/heff/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/heff/video.js/events","assignees_url":"https://api.github.com/repos/heff/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/heff/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/heff/video.js/tags","blobs_url":"https://api.github.com/repos/heff/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heff/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heff/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/heff/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heff/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/heff/video.js/languages","stargazers_url":"https://api.github.com/repos/heff/video.js/stargazers","contributors_url":"https://api.github.com/repos/heff/video.js/contributors","subscribers_url":"https://api.github.com/repos/heff/video.js/subscribers","subscription_url":"https://api.github.com/repos/heff/video.js/subscription","commits_url":"https://api.github.com/repos/heff/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/heff/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/heff/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/heff/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/heff/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/heff/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heff/video.js/merges","archive_url":"https://api.github.com/repos/heff/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heff/video.js/downloads","issues_url":"https://api.github.com/repos/heff/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/heff/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/heff/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/heff/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heff/video.js/labels{/name}","releases_url":"https://api.github.com/repos/heff/video.js/releases{/id}","created_at":"2012-08-09T23:12:27Z","updated_at":"2015-07-07T03:16:43Z","pushed_at":"2015-09-03T00:04:20Z","git_url":"git://github.com/heff/video.js.git","ssh_url":"git@github.com:heff/video.js.git","clone_url":"https://github.com/heff/video.js.git","svn_url":"https://github.com/heff/video.js","homepage":"videojs.com","size":16723,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":0,"forks":4,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"videojs:master","ref":"master","sha":"f151c3b67edf2c90ff1dec7a0c40f47be9d45e58","user":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"repo":{"id":667006,"name":"video.js","full_name":"videojs/video.js","owner":{"login":"videojs","id":3287189,"avatar_url":"https://avatars.githubusercontent.com/u/3287189?v=3","gravatar_id":"","url":"https://api.github.com/users/videojs","html_url":"https://github.com/videojs","followers_url":"https://api.github.com/users/videojs/followers","following_url":"https://api.github.com/users/videojs/following{/other_user}","gists_url":"https://api.github.com/users/videojs/gists{/gist_id}","starred_url":"https://api.github.com/users/videojs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videojs/subscriptions","organizations_url":"https://api.github.com/users/videojs/orgs","repos_url":"https://api.github.com/users/videojs/repos","events_url":"https://api.github.com/users/videojs/events{/privacy}","received_events_url":"https://api.github.com/users/videojs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videojs/video.js","description":"Video.js - open source HTML5 & Flash video player","fork":false,"url":"https://api.github.com/repos/videojs/video.js","forks_url":"https://api.github.com/repos/videojs/video.js/forks","keys_url":"https://api.github.com/repos/videojs/video.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videojs/video.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videojs/video.js/teams","hooks_url":"https://api.github.com/repos/videojs/video.js/hooks","issue_events_url":"https://api.github.com/repos/videojs/video.js/issues/events{/number}","events_url":"https://api.github.com/repos/videojs/video.js/events","assignees_url":"https://api.github.com/repos/videojs/video.js/assignees{/user}","branches_url":"https://api.github.com/repos/videojs/video.js/branches{/branch}","tags_url":"https://api.github.com/repos/videojs/video.js/tags","blobs_url":"https://api.github.com/repos/videojs/video.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videojs/video.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videojs/video.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/videojs/video.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videojs/video.js/statuses/{sha}","languages_url":"https://api.github.com/repos/videojs/video.js/languages","stargazers_url":"https://api.github.com/repos/videojs/video.js/stargazers","contributors_url":"https://api.github.com/repos/videojs/video.js/contributors","subscribers_url":"https://api.github.com/repos/videojs/video.js/subscribers","subscription_url":"https://api.github.com/repos/videojs/video.js/subscription","commits_url":"https://api.github.com/repos/videojs/video.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/videojs/video.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/videojs/video.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/videojs/video.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/videojs/video.js/contents/{+path}","compare_url":"https://api.github.com/repos/videojs/video.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videojs/video.js/merges","archive_url":"https://api.github.com/repos/videojs/video.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videojs/video.js/downloads","issues_url":"https://api.github.com/repos/videojs/video.js/issues{/number}","pulls_url":"https://api.github.com/repos/videojs/video.js/pulls{/number}","milestones_url":"https://api.github.com/repos/videojs/video.js/milestones{/number}","notifications_url":"https://api.github.com/repos/videojs/video.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videojs/video.js/labels{/name}","releases_url":"https://api.github.com/repos/videojs/video.js/releases{/id}","created_at":"2010-05-14T18:45:10Z","updated_at":"2015-09-02T19:25:12Z","pushed_at":"2015-09-03T00:04:22Z","git_url":"git://github.com/videojs/video.js.git","ssh_url":"git@github.com:videojs/video.js.git","clone_url":"https://github.com/videojs/video.js.git","svn_url":"https://github.com/videojs/video.js","homepage":"www.videojs.com","size":69417,"stargazers_count":10013,"watchers_count":10013,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":2878,"mirror_url":null,"open_issues_count":194,"forks":2878,"open_issues":194,"watchers":10013,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2533"},"html":{"href":"https://github.com/videojs/video.js/pull/2533"},"issue":{"href":"https://api.github.com/repos/videojs/video.js/issues/2533"},"comments":{"href":"https://api.github.com/repos/videojs/video.js/issues/2533/comments"},"review_comments":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2533/comments"},"review_comment":{"href":"https://api.github.com/repos/videojs/video.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videojs/video.js/pulls/2533/commits"},"statuses":{"href":"https://api.github.com/repos/videojs/video.js/statuses/0db28220669611403cbd41eedf71ab50a009b79e"}}}}