{"action":"created","comment":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/26738447","id":26738447,"diff_hunk":"@@ -1,9 +1,14 @@\n+\n <!--\n+Disabled by https-everywhere-checker because:\n+Fetch error: http://accesd.desjardins.com/ => https://accesd.desjardins.com/: (28, 'Connection timed out after 10001 milliseconds')\n+Fetch error: http://accesd.affaires.desjardins.com/ => https://accesd.affaires.desjardins.com/: (28, 'Connection timed out after 10000 milliseconds')\n+","path":"src/chrome/content/rules/Desjardins.xml","position":6,"original_position":6,"commit_id":"38388af7a29987bd97a9cc5e8e5dc88a5f90a8d6","original_commit_id":"d6a1ff8a818d5c3287c96e8f65e651a9aecaa93e","user":{"login":"2d1","id":1521326,"avatar_url":"https://avatars.githubusercontent.com/u/1521326?v=3","gravatar_id":"","url":"https://api.github.com/users/2d1","html_url":"https://github.com/2d1","followers_url":"https://api.github.com/users/2d1/followers","following_url":"https://api.github.com/users/2d1/following{/other_user}","gists_url":"https://api.github.com/users/2d1/gists{/gist_id}","starred_url":"https://api.github.com/users/2d1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2d1/subscriptions","organizations_url":"https://api.github.com/users/2d1/orgs","repos_url":"https://api.github.com/users/2d1/repos","events_url":"https://api.github.com/users/2d1/events{/privacy}","received_events_url":"https://api.github.com/users/2d1/received_events","type":"User","site_admin":false},"body":"> I think this is correct to disable because there is no HTTP version.\r\n\r\nWould it be correct to infer from this that https-everywhere's threat model only includes passive observers? I had assumed up until now that the threat model included a mitm that could change traffic in transit, rather than a simple passive dragnet.\r\n\r\nI'm guessing that torbrowser does include an active adversary (@ioerror would this guess be correct?), so perhaps there ought to be a platform=\"tor\" for coverage beneficial to only an active mitm scenario.\r\n\r\nFurther, perhaps the current threat model assumes that our users are as clued up as we are, in that you and I realize plaintext content is to be considered as rendering bug fodder (and never to be trusted). However, as Ian Goldberg illustrated in last year's shmoocon keynote, average users really aren't that clued up. Presented with a plaintext copy and a padlock favicon, hilarity will ensue.\r\n\r\nClued up users would suffer more distinguishable behavior in their traffic, but I think that's a small cost in comparison.\r\n\r\nI really think you should consider adding an adversary that can copy and inject web pages into the https-everywhere threat model.","created_at":"2015-03-19T09:19:51Z","updated_at":"2015-03-19T09:19:51Z","html_url":"https://github.com/EFForg/https-everywhere/pull/1201#discussion_r26738447","pull_request_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201","_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments/26738447"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/1201#discussion_r26738447"},"pull_request":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201"}}},"pull_request":{"url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201","id":31303572,"html_url":"https://github.com/EFForg/https-everywhere/pull/1201","diff_url":"https://github.com/EFForg/https-everywhere/pull/1201.diff","patch_url":"https://github.com/EFForg/https-everywhere/pull/1201.patch","issue_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/1201","number":1201,"state":"open","locked":false,"title":"Disable rules since Feb 12 that fail fetch test.","user":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"body":"cc @2d1 @cooperq for review.","created_at":"2015-03-17T02:56:04Z","updated_at":"2015-03-19T09:19:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"73cf3a5dcbbc69bcb199c68e2e27e632bde6b304","assignee":{"login":"2d1","id":1521326,"avatar_url":"https://avatars.githubusercontent.com/u/1521326?v=3","gravatar_id":"","url":"https://api.github.com/users/2d1","html_url":"https://github.com/2d1","followers_url":"https://api.github.com/users/2d1/followers","following_url":"https://api.github.com/users/2d1/following{/other_user}","gists_url":"https://api.github.com/users/2d1/gists{/gist_id}","starred_url":"https://api.github.com/users/2d1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2d1/subscriptions","organizations_url":"https://api.github.com/users/2d1/orgs","repos_url":"https://api.github.com/users/2d1/repos","events_url":"https://api.github.com/users/2d1/events{/privacy}","received_events_url":"https://api.github.com/users/2d1/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201/commits","review_comments_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201/comments","review_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/1201/comments","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/38388af7a29987bd97a9cc5e8e5dc88a5f90a8d6","head":{"label":"jsha:disable-new-rulesets","ref":"disable-new-rulesets","sha":"38388af7a29987bd97a9cc5e8e5dc88a5f90a8d6","user":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"repo":{"id":15194001,"name":"https-everywhere","full_name":"jsha/https-everywhere","owner":{"login":"jsha","id":220205,"avatar_url":"https://avatars.githubusercontent.com/u/220205?v=3","gravatar_id":"","url":"https://api.github.com/users/jsha","html_url":"https://github.com/jsha","followers_url":"https://api.github.com/users/jsha/followers","following_url":"https://api.github.com/users/jsha/following{/other_user}","gists_url":"https://api.github.com/users/jsha/gists{/gist_id}","starred_url":"https://api.github.com/users/jsha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsha/subscriptions","organizations_url":"https://api.github.com/users/jsha/orgs","repos_url":"https://api.github.com/users/jsha/repos","events_url":"https://api.github.com/users/jsha/events{/privacy}","received_events_url":"https://api.github.com/users/jsha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jsha/https-everywhere","description":"Fork","fork":true,"url":"https://api.github.com/repos/jsha/https-everywhere","forks_url":"https://api.github.com/repos/jsha/https-everywhere/forks","keys_url":"https://api.github.com/repos/jsha/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsha/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsha/https-everywhere/teams","hooks_url":"https://api.github.com/repos/jsha/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/jsha/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/jsha/https-everywhere/events","assignees_url":"https://api.github.com/repos/jsha/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/jsha/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/jsha/https-everywhere/tags","blobs_url":"https://api.github.com/repos/jsha/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsha/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsha/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsha/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsha/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/jsha/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/jsha/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/jsha/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/jsha/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/jsha/https-everywhere/subscription","commits_url":"https://api.github.com/repos/jsha/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsha/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsha/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsha/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsha/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/jsha/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsha/https-everywhere/merges","archive_url":"https://api.github.com/repos/jsha/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsha/https-everywhere/downloads","issues_url":"https://api.github.com/repos/jsha/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/jsha/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/jsha/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/jsha/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsha/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/jsha/https-everywhere/releases{/id}","created_at":"2013-12-14T22:29:11Z","updated_at":"2015-03-10T01:30:11Z","pushed_at":"2015-03-19T01:25:13Z","git_url":"git://github.com/jsha/https-everywhere.git","ssh_url":"git@github.com:jsha/https-everywhere.git","clone_url":"https://github.com/jsha/https-everywhere.git","svn_url":"https://github.com/jsha/https-everywhere","homepage":"https://eff.org/https-everywhere","size":60556,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"EFForg:master","ref":"master","sha":"c1d9349e968eaaeb44774d1c6ec6ff7b8b8dc490","user":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"repo":{"id":14939303,"name":"https-everywhere","full_name":"EFForg/https-everywhere","owner":{"login":"EFForg","id":2120271,"avatar_url":"https://avatars.githubusercontent.com/u/2120271?v=3","gravatar_id":"","url":"https://api.github.com/users/EFForg","html_url":"https://github.com/EFForg","followers_url":"https://api.github.com/users/EFForg/followers","following_url":"https://api.github.com/users/EFForg/following{/other_user}","gists_url":"https://api.github.com/users/EFForg/gists{/gist_id}","starred_url":"https://api.github.com/users/EFForg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EFForg/subscriptions","organizations_url":"https://api.github.com/users/EFForg/orgs","repos_url":"https://api.github.com/users/EFForg/repos","events_url":"https://api.github.com/users/EFForg/events{/privacy}","received_events_url":"https://api.github.com/users/EFForg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/EFForg/https-everywhere","description":"The official Github mirror of the HTTPS Everywhere repository at https://gitweb.torproject.org/https-everywhere.git. You can send pull requests here.","fork":false,"url":"https://api.github.com/repos/EFForg/https-everywhere","forks_url":"https://api.github.com/repos/EFForg/https-everywhere/forks","keys_url":"https://api.github.com/repos/EFForg/https-everywhere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EFForg/https-everywhere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EFForg/https-everywhere/teams","hooks_url":"https://api.github.com/repos/EFForg/https-everywhere/hooks","issue_events_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/events{/number}","events_url":"https://api.github.com/repos/EFForg/https-everywhere/events","assignees_url":"https://api.github.com/repos/EFForg/https-everywhere/assignees{/user}","branches_url":"https://api.github.com/repos/EFForg/https-everywhere/branches{/branch}","tags_url":"https://api.github.com/repos/EFForg/https-everywhere/tags","blobs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EFForg/https-everywhere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EFForg/https-everywhere/git/refs{/sha}","trees_url":"https://api.github.com/repos/EFForg/https-everywhere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EFForg/https-everywhere/statuses/{sha}","languages_url":"https://api.github.com/repos/EFForg/https-everywhere/languages","stargazers_url":"https://api.github.com/repos/EFForg/https-everywhere/stargazers","contributors_url":"https://api.github.com/repos/EFForg/https-everywhere/contributors","subscribers_url":"https://api.github.com/repos/EFForg/https-everywhere/subscribers","subscription_url":"https://api.github.com/repos/EFForg/https-everywhere/subscription","commits_url":"https://api.github.com/repos/EFForg/https-everywhere/commits{/sha}","git_commits_url":"https://api.github.com/repos/EFForg/https-everywhere/git/commits{/sha}","comments_url":"https://api.github.com/repos/EFForg/https-everywhere/comments{/number}","issue_comment_url":"https://api.github.com/repos/EFForg/https-everywhere/issues/comments{/number}","contents_url":"https://api.github.com/repos/EFForg/https-everywhere/contents/{+path}","compare_url":"https://api.github.com/repos/EFForg/https-everywhere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EFForg/https-everywhere/merges","archive_url":"https://api.github.com/repos/EFForg/https-everywhere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EFForg/https-everywhere/downloads","issues_url":"https://api.github.com/repos/EFForg/https-everywhere/issues{/number}","pulls_url":"https://api.github.com/repos/EFForg/https-everywhere/pulls{/number}","milestones_url":"https://api.github.com/repos/EFForg/https-everywhere/milestones{/number}","notifications_url":"https://api.github.com/repos/EFForg/https-everywhere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EFForg/https-everywhere/labels{/name}","releases_url":"https://api.github.com/repos/EFForg/https-everywhere/releases{/id}","created_at":"2013-12-04T23:53:07Z","updated_at":"2015-03-19T08:17:23Z","pushed_at":"2015-03-19T08:17:23Z","git_url":"git://github.com/EFForg/https-everywhere.git","ssh_url":"git@github.com:EFForg/https-everywhere.git","clone_url":"https://github.com/EFForg/https-everywhere.git","svn_url":"https://github.com/EFForg/https-everywhere","homepage":"https://eff.org/https-everywhere","size":123151,"stargazers_count":504,"watchers_count":504,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":234,"mirror_url":null,"open_issues_count":171,"forks":234,"open_issues":171,"watchers":504,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201"},"html":{"href":"https://github.com/EFForg/https-everywhere/pull/1201"},"issue":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/1201"},"comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/issues/1201/comments"},"review_comments":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201/comments"},"review_comment":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EFForg/https-everywhere/pulls/1201/commits"},"statuses":{"href":"https://api.github.com/repos/EFForg/https-everywhere/statuses/38388af7a29987bd97a9cc5e8e5dc88a5f90a8d6"}}}}