{"action":"created","issue":{"url":"https://api.github.com/repos/juju/juju/issues/2306","labels_url":"https://api.github.com/repos/juju/juju/issues/2306/labels{/name}","comments_url":"https://api.github.com/repos/juju/juju/issues/2306/comments","events_url":"https://api.github.com/repos/juju/juju/issues/2306/events","html_url":"https://github.com/juju/juju/pull/2306","id":75834730,"number":2306,"title":"Fix lp:1454043 - instance poller comparing wrong addresses","user":{"login":"howbazaar","id":1744247,"avatar_url":"https://avatars.githubusercontent.com/u/1744247?v=3","gravatar_id":"","url":"https://api.github.com/users/howbazaar","html_url":"https://github.com/howbazaar","followers_url":"https://api.github.com/users/howbazaar/followers","following_url":"https://api.github.com/users/howbazaar/following{/other_user}","gists_url":"https://api.github.com/users/howbazaar/gists{/gist_id}","starred_url":"https://api.github.com/users/howbazaar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/howbazaar/subscriptions","organizations_url":"https://api.github.com/users/howbazaar/orgs","repos_url":"https://api.github.com/users/howbazaar/repos","events_url":"https://api.github.com/users/howbazaar/events{/privacy}","received_events_url":"https://api.github.com/users/howbazaar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-13T03:54:55Z","updated_at":"2015-05-13T04:52:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/2306","html_url":"https://github.com/juju/juju/pull/2306","diff_url":"https://github.com/juju/juju/pull/2306.diff","patch_url":"https://github.com/juju/juju/pull/2306.patch"},"body":"The instancepoller updater code was comparing the provider addresses for the instance with the combined list of addresses of the provider and the machine. If they were different, it would then set the addresses for the provider.\r\n\r\nThis confusion came about, I think, primarily due to the method names. The machine Addresses method returned a combined list of addresses, but SetAddresses only set the provider addresses.\r\n\r\nThere was already SetMachineAddresses and MachineAddresses.\r\n\r\nI renamed SetAddresses to be SetProviderAddresses, and added a method that just returned the ProviderAddresses.  The instance poller is updated to only ask for the ProviderAddresses.\r\n\r\nSince the instance poller is a state worker, not of these changes impact the api layer at all.\n\n(Review request: http://reviews.vapour.ws/r/1669/)"},"comment":{"url":"https://api.github.com/repos/juju/juju/issues/comments/101512592","html_url":"https://github.com/juju/juju/pull/2306#issuecomment-101512592","issue_url":"https://api.github.com/repos/juju/juju/issues/2306","id":101512592,"user":{"login":"jujubot","id":7779494,"avatar_url":"https://avatars.githubusercontent.com/u/7779494?v=3","gravatar_id":"","url":"https://api.github.com/users/jujubot","html_url":"https://github.com/jujubot","followers_url":"https://api.github.com/users/jujubot/followers","following_url":"https://api.github.com/users/jujubot/following{/other_user}","gists_url":"https://api.github.com/users/jujubot/gists{/gist_id}","starred_url":"https://api.github.com/users/jujubot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jujubot/subscriptions","organizations_url":"https://api.github.com/users/jujubot/orgs","repos_url":"https://api.github.com/users/jujubot/repos","events_url":"https://api.github.com/users/jujubot/events{/privacy}","received_events_url":"https://api.github.com/users/jujubot/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T04:52:37Z","updated_at":"2015-05-13T04:52:37Z","body":"Build failed: Tests failed\n        build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/3223\n"}}