{"action":"created","issue":{"url":"https://api.github.com/repos/codice/ddf/issues/210","labels_url":"https://api.github.com/repos/codice/ddf/issues/210/labels{/name}","comments_url":"https://api.github.com/repos/codice/ddf/issues/210/comments","events_url":"https://api.github.com/repos/codice/ddf/issues/210/events","html_url":"https://github.com/codice/ddf/pull/210","id":108954088,"number":210,"title":"DDF-1512 Updates conversions to cause minimal loss of precision, fixes up / down arrows","user":{"login":"andrewkfiedler","id":11984853,"avatar_url":"https://avatars.githubusercontent.com/u/11984853?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-09-29T20:32:58Z","updated_at":"2015-09-29T20:52:03Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/210","html_url":"https://github.com/codice/ddf/pull/210","diff_url":"https://github.com/codice/ddf/pull/210.diff","patch_url":"https://github.com/codice/ddf/pull/210.patch"},"body":" - Previously we were using the Math.ceil function during certain conversions.  This caused a significant loss of precision in both directions (view to model, and model to view).\r\n - For the most part, this fixed the issue with the up / down arrows seen in https://codice.atlassian.net/browse/DDF-1513.  I went ahead and refactored the radiusConverter function to fix a seperate issue that cropped up, which was also related to precision.  Instead of always updating the view based on the model, the view is now only updated when the difference between view and model is greater than a certain threshold.  I couldn't track down an example value (I searched cesium and ddf for thresholds, but couldn't find any references).  I tested the value in the code with the greatest zoom and the largest unit (mile) and it seemed to perform as expected.  Without this threshold for change, when using the up and down arrows (on a unit other than meters) you will see the value sometimes increases or decreases by a number close to 1 instead of 1. (ex: 54 to 54.99999999999 instead of 55)\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/codice/ddf/210)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/codice/ddf/issues/comments/144188019","html_url":"https://github.com/codice/ddf/pull/210#issuecomment-144188019","issue_url":"https://api.github.com/repos/codice/ddf/issues/210","id":144188019,"user":{"login":"andrewkfiedler","id":11984853,"avatar_url":"https://avatars.githubusercontent.com/u/11984853?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T20:52:03Z","updated_at":"2015-09-29T20:52:03Z","body":"@stustison "}}