{"action":"created","issue":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/458","labels_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/458/comments","events_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/458/events","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/458","id":57808511,"number":458,"title":"Add BlockHarvestEvent, changes how silk touch enchant works","user":{"login":"simon816","id":1497508,"avatar_url":"https://avatars.githubusercontent.com/u/1497508?v=3","gravatar_id":"","url":"https://api.github.com/users/simon816","html_url":"https://github.com/simon816","followers_url":"https://api.github.com/users/simon816/followers","following_url":"https://api.github.com/users/simon816/following{/other_user}","gists_url":"https://api.github.com/users/simon816/gists{/gist_id}","starred_url":"https://api.github.com/users/simon816/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon816/subscriptions","organizations_url":"https://api.github.com/users/simon816/orgs","repos_url":"https://api.github.com/users/simon816/repos","events_url":"https://api.github.com/users/simon816/events{/privacy}","received_events_url":"https://api.github.com/users/simon816/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-02-16T14:11:56Z","updated_at":"2015-02-17T00:33:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/pulls/458","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/458","diff_url":"https://github.com/SpongePowered/SpongeAPI/pull/458.diff","patch_url":"https://github.com/SpongePowered/SpongeAPI/pull/458.patch"},"body":"I have created a new event, `BlockHarvestEvent` see the javadoc. \r\nThis is the result from a previous PR, #422"},"comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/comments/74596657","html_url":"https://github.com/SpongePowered/SpongeAPI/pull/458#issuecomment-74596657","issue_url":"https://api.github.com/repos/SpongePowered/SpongeAPI/issues/458","id":74596657,"user":{"login":"Deamon5550","id":1249030,"avatar_url":"https://avatars.githubusercontent.com/u/1249030?v=3","gravatar_id":"","url":"https://api.github.com/users/Deamon5550","html_url":"https://github.com/Deamon5550","followers_url":"https://api.github.com/users/Deamon5550/followers","following_url":"https://api.github.com/users/Deamon5550/following{/other_user}","gists_url":"https://api.github.com/users/Deamon5550/gists{/gist_id}","starred_url":"https://api.github.com/users/Deamon5550/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deamon5550/subscriptions","organizations_url":"https://api.github.com/users/Deamon5550/orgs","repos_url":"https://api.github.com/users/Deamon5550/repos","events_url":"https://api.github.com/users/Deamon5550/events{/privacy}","received_events_url":"https://api.github.com/users/Deamon5550/received_events","type":"User","site_admin":false},"created_at":"2015-02-17T00:33:18Z","updated_at":"2015-02-17T00:33:18Z","body":"@me4502 At the time of the BlockBreakEvent the dropped items aren't technically known, since that is the point of the BlockHarvestEvent (to determine what blocks should drop).\r\n\r\nI wonder though if the BlockHarvestEvent should perhaps not be explicitly cancellable, since (unless I am misunderstanding the point of the harvest event) at that point the BlockBreakEvent has already been thrown and returned uncancelled so at this point it doesn't make much sense to cancel the harvest event (if you wanted no items to drop you could just clear the dropped items). Ehhh on second though perhaps it is less destructive to have it cancellable rather than forcing plugins to just clear the dropped items, makes it easier for another plugin to later uncancel it. Thoughts?"}}