{"action":"created","issue":{"url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/93","labels_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/93/labels{/name}","comments_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/93/comments","events_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/93/events","html_url":"https://github.com/tidepool-org/chrome-uploader/pull/93","id":63863872,"number":93,"title":"fudge a millisecond only on spring forward overlap datapoints that would have been dropped before","user":{"login":"jebeck","id":1588547,"avatar_url":"https://avatars.githubusercontent.com/u/1588547?v=3","gravatar_id":"","url":"https://api.github.com/users/jebeck","html_url":"https://github.com/jebeck","followers_url":"https://api.github.com/users/jebeck/followers","following_url":"https://api.github.com/users/jebeck/following{/other_user}","gists_url":"https://api.github.com/users/jebeck/gists{/gist_id}","starred_url":"https://api.github.com/users/jebeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jebeck/subscriptions","organizations_url":"https://api.github.com/users/jebeck/orgs","repos_url":"https://api.github.com/users/jebeck/repos","events_url":"https://api.github.com/users/jebeck/events{/privacy}","received_events_url":"https://api.github.com/users/jebeck/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-24T00:20:48Z","updated_at":"2015-03-25T01:05:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tidepool-org/chrome-uploader/pulls/93","html_url":"https://github.com/tidepool-org/chrome-uploader/pull/93","diff_url":"https://github.com/tidepool-org/chrome-uploader/pull/93.diff","patch_url":"https://github.com/tidepool-org/chrome-uploader/pull/93.patch"},"body":"So I think this actually accomplishes the original goal of completely fixing the data. I really need to test on B's receiver again to be sure, but I think I'm now always only fudging a millisecond on the datapoint that was considered a duplicate before (and thus not stored). (I think I can guarantee this because I found the code where @kentquirk was logging duplicates, and I'm leveraging the order the \"pairs\" come in, which is deterministic across multiple uploads from the same receiver, but *not* deterministic in terms of which of the pair comes \"first.\")"},"comment":{"url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/comments/85768437","html_url":"https://github.com/tidepool-org/chrome-uploader/pull/93#issuecomment-85768437","issue_url":"https://api.github.com/repos/tidepool-org/chrome-uploader/issues/93","id":85768437,"user":{"login":"jh-bate","id":5168993,"avatar_url":"https://avatars.githubusercontent.com/u/5168993?v=3","gravatar_id":"","url":"https://api.github.com/users/jh-bate","html_url":"https://github.com/jh-bate","followers_url":"https://api.github.com/users/jh-bate/followers","following_url":"https://api.github.com/users/jh-bate/following{/other_user}","gists_url":"https://api.github.com/users/jh-bate/gists{/gist_id}","starred_url":"https://api.github.com/users/jh-bate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jh-bate/subscriptions","organizations_url":"https://api.github.com/users/jh-bate/orgs","repos_url":"https://api.github.com/users/jh-bate/repos","events_url":"https://api.github.com/users/jh-bate/events{/privacy}","received_events_url":"https://api.github.com/users/jh-bate/received_events","type":"User","site_admin":false},"created_at":"2015-03-25T01:05:47Z","updated_at":"2015-03-25T01:05:47Z","body":"I was going to say are there corresponding tests but there is no test suite for the dexcomDriver. If you could just clarify my questions above other than that code wise LGTM  "}}