{"action":"created","comment":{"url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments/25339946","id":25339946,"diff_hunk":"@@ -994,47 +1009,50 @@ an accepted root certificate.\n           GET https://&lt;log server&gt;/ct/v2/get-proof-by-hash\n         </t>\n         <t>\n-          Inputs:\n-\n-          <list>\n-\t    <t><list style=\"hanging\">\n-\t      <t hangText=\"hash:\">\n-\t\tA base64-encoded v1 leaf hash.\n-\t      </t>\n-\t      <t hangText=\"tree_size:\">\n-\t\tThe tree_size of the tree on which to base the proof, in decimal.\n-\t      </t>\n-            </list></t>\n-\t  </list>\n-\t</t>\n-\t<t>\n-          The <spanx style=\"verb\">hash</spanx> must be calculated as defined in <xref target=\"tree\"/>. The <spanx style=\"verb\">tree_size</spanx> must designate an existing v1 STH. Because of skew, the front-end may not know the requested STH. In that case, it will return the latest STH it knows, along with an inclusion proof to that STH. If the front-end knows the requested STH then only <spanx style=\"verb\">leaf_index</spanx> and <spanx style=\"verb\">audit_path</spanx> are returned.\n-        </t>\n-\n-        <t>\n-          Outputs:\n-\n-          <list>\n-\t    <t><list style=\"hanging\">\n-\t      <t hangText=\"leaf_index:\">\n-\t\tThe 0-based index of the entry corresponding to the <spanx style=\"verb\">hash</spanx> parameter.\n-\t      </t>\n-\t      <t hangText=\"audit_path:\">\n-\t\tAn array of base64-encoded Merkle Tree nodes proving the inclusion of the chosen certificate.\n-\t      </t>\n-\t      <t hangText=\"tree_size:\">\n-\t\tThe size of the tree, in entries, in decimal.\n-\t      </t>\n-\t      <t hangText=\"timestamp:\">\n-\t\tThe timestamp, in decimal.\n-\t      </t>\n-\t      <t hangText=\"sha256_root_hash:\">\n-\t\tThe Merkle Tree Hash of the tree, in base64.\n-\t      </t>\n-\t      <t hangText=\"tree_head_signature:\">\n-\t\tA TreeHeadSignature for the above data.\n-\t      </t>\n-            </list></t>\n+\t  <list style=\"hanging\">\n+            <t hangText=\"Inputs:\">\n+\t      <list style=\"hanging\">\n+\t\t<t hangText=\"hash:\">\n+\t\t  A base64-encoded v1 leaf hash.\n+\t\t</t>\n+\t\t<t hangText=\"tree_size:\">\n+\t\t  The tree_size of the tree on which to base the proof, in decimal.\n+\t\t</t>\n+              </list>\n+              The <spanx style=\"verb\">hash</spanx> must be calculated as defined in <xref target=\"tree\"/>. The <spanx style=\"verb\">tree_size</spanx> must designate an existing v1 STH. Because of skew, the front-end may not know the requested STH. In that case, it will return the latest STH it knows, along with an inclusion proof to that STH. If the front-end knows the requested STH then only <spanx style=\"verb\">leaf_index</spanx> and <spanx style=\"verb\">audit_path</spanx> are returned.\n+            </t>\n+\t    <t hangText=\"Outputs:\">\n+\t      <list style=\"hanging\">\n+\t\t<t hangText=\"leaf_index:\">\n+\t\t  The 0-based index of the entry corresponding to the <spanx style=\"verb\">hash</spanx> parameter.\n+\t\t</t>\n+\t\t<t hangText=\"audit_path:\">\n+\t\t  An array of base64-encoded Merkle Tree nodes proving the inclusion of the chosen certificate.\n+\t\t</t>\n+\t\t<t hangText=\"tree_size:\">\n+\t\t  The size of the tree, in entries, in decimal.\n+\t\t</t>\n+\t\t<t hangText=\"timestamp:\">\n+\t\t  The timestamp, in decimal.\n+\t\t</t>\n+\t\t<t hangText=\"sha256_root_hash:\">\n+\t\t  The Merkle Tree Hash of the tree, in base64.\n+\t\t</t>\n+\t\t<t hangText=\"tree_head_signature:\">\n+\t\t  A TreeHeadSignature for the above data.\n+\t\t</t>\n+              </list>\n+\t    </t>\n+\t    <t hangText=\"Errors:\">\n+\t      <list style=\"hanging\">\n+\t\t<t hangText=\"hash unknown\">\n+\t\t  <spanx style=\"verb\">hash</spanx> is not the hash of a known leaf (may be caused by skew).\n+\t\t</t>\n+\t\t<t hangText=\"tree_size unknown\">\n+\t\t  <spanx style=\"verb\">hash</spanx> is before the latest known STH but is not from an existing STH.","path":"rfc6962-bis.xml","position":305,"original_position":305,"commit_id":"4ce08181fd00d0ae7fc5256d2800c473cfaf29ee","original_commit_id":"4ce08181fd00d0ae7fc5256d2800c473cfaf29ee","user":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"body":"There is no error - this is a normal condition and a non-error return is defined.","created_at":"2015-02-25T13:43:59Z","updated_at":"2015-02-25T13:43:59Z","html_url":"https://github.com/google/certificate-transparency-rfcs/pull/28#discussion_r25339946","pull_request_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments/25339946"},"html":{"href":"https://github.com/google/certificate-transparency-rfcs/pull/28#discussion_r25339946"},"pull_request":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28","id":29710760,"html_url":"https://github.com/google/certificate-transparency-rfcs/pull/28","diff_url":"https://github.com/google/certificate-transparency-rfcs/pull/28.diff","patch_url":"https://github.com/google/certificate-transparency-rfcs/pull/28.patch","issue_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/28","number":28,"state":"open","locked":false,"title":"Add errors for machine processing.","user":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"body":"@eranmes.\r\n\r\nBTW, I intend to submit a later CL that brings the list layout into line for other sections.\r\n","created_at":"2015-02-20T16:45:46Z","updated_at":"2015-02-25T13:43:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"758b56dc1f1fb16aa32d18d4c6c3f32668151258","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28/commits","review_comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28/comments","review_comment_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/28/comments","statuses_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/4ce08181fd00d0ae7fc5256d2800c473cfaf29ee","head":{"label":"benlaurie:fix-36","ref":"fix-36","sha":"4ce08181fd00d0ae7fc5256d2800c473cfaf29ee","user":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"repo":{"id":21500420,"name":"certificate-transparency-rfcs","full_name":"benlaurie/certificate-transparency-rfcs","owner":{"login":"benlaurie","id":40044,"avatar_url":"https://avatars.githubusercontent.com/u/40044?v=3","gravatar_id":"","url":"https://api.github.com/users/benlaurie","html_url":"https://github.com/benlaurie","followers_url":"https://api.github.com/users/benlaurie/followers","following_url":"https://api.github.com/users/benlaurie/following{/other_user}","gists_url":"https://api.github.com/users/benlaurie/gists{/gist_id}","starred_url":"https://api.github.com/users/benlaurie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benlaurie/subscriptions","organizations_url":"https://api.github.com/users/benlaurie/orgs","repos_url":"https://api.github.com/users/benlaurie/repos","events_url":"https://api.github.com/users/benlaurie/events{/privacy}","received_events_url":"https://api.github.com/users/benlaurie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benlaurie/certificate-transparency-rfcs","description":"Certificate Transparency RFC","fork":true,"url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs","forks_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/forks","keys_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/teams","hooks_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/hooks","issue_events_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/events","assignees_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/tags","blobs_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/languages","stargazers_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/stargazers","contributors_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/contributors","subscribers_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/subscribers","subscription_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/subscription","commits_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/merges","archive_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/downloads","issues_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/benlaurie/certificate-transparency-rfcs/releases{/id}","created_at":"2014-07-04T14:51:27Z","updated_at":"2015-02-20T15:43:53Z","pushed_at":"2015-02-20T16:41:50Z","git_url":"git://github.com/benlaurie/certificate-transparency-rfcs.git","ssh_url":"git@github.com:benlaurie/certificate-transparency-rfcs.git","clone_url":"https://github.com/benlaurie/certificate-transparency-rfcs.git","svn_url":"https://github.com/benlaurie/certificate-transparency-rfcs","homepage":"http://www.certificate-transparency.org/","size":1332,"stargazers_count":0,"watchers_count":0,"language":"XML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"0dcf92d3ce067fa2dd4d96efd00c7a27085c5983","user":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":20069953,"name":"certificate-transparency-rfcs","full_name":"google/certificate-transparency-rfcs","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/certificate-transparency-rfcs","description":"Certificate Transparency RFC","fork":false,"url":"https://api.github.com/repos/google/certificate-transparency-rfcs","forks_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/forks","keys_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/teams","hooks_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/hooks","issue_events_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/events","assignees_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/tags","blobs_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/languages","stargazers_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/stargazers","contributors_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/contributors","subscribers_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/subscribers","subscription_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/subscription","commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/merges","archive_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/downloads","issues_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/labels{/name}","releases_url":"https://api.github.com/repos/google/certificate-transparency-rfcs/releases{/id}","created_at":"2014-05-22T17:15:59Z","updated_at":"2015-02-20T13:50:11Z","pushed_at":"2015-02-20T13:50:11Z","git_url":"git://github.com/google/certificate-transparency-rfcs.git","ssh_url":"git@github.com:google/certificate-transparency-rfcs.git","clone_url":"https://github.com/google/certificate-transparency-rfcs.git","svn_url":"https://github.com/google/certificate-transparency-rfcs","homepage":"http://www.certificate-transparency.org/","size":1586,"stargazers_count":14,"watchers_count":14,"language":"XML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":1,"forks":6,"open_issues":1,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28"},"html":{"href":"https://github.com/google/certificate-transparency-rfcs/pull/28"},"issue":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/28"},"comments":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/google/certificate-transparency-rfcs/statuses/4ce08181fd00d0ae7fc5256d2800c473cfaf29ee"}}}}