{"action":"created","comment":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/47049696","id":47049696,"diff_hunk":"@@ -232,41 +252,138 @@ JitsiConference.prototype.selectParticipant = function(participantId) {\n     if (this.rtc) {\n         this.rtc.selectedEndpoint(participantId);\n     }\n-}\n+};\n \n /**\n  *\n  * @param id the identifier of the participant\n  */\n JitsiConference.prototype.pinParticipant = function(participantId) {\n-    if(this.rtc)\n+    if (this.rtc) {\n         this.rtc.pinEndpoint(participantId);\n-}\n+    }\n+};\n \n /**\n  * Returns the list of participants for this conference.\n- * @return Object a list of participant identifiers containing all conference participants.\n+ * @return Array<JitsiParticipant> a list of participant identifiers containing all conference participants.\n  */\n JitsiConference.prototype.getParticipants = function() {\n-    return this.participants;\n-}\n+    return Object.keys(this.participants).map(function (key) {\n+        return this.participants[key];\n+    }, this);\n+};\n \n /**\n  * @returns {JitsiParticipant} the participant in this conference with the specified id (or\n- * null if there isn't one).\n+ * undefined if there isn't one).\n  * @param id the id of the participant.\n  */\n JitsiConference.prototype.getParticipantById = function(id) {\n-    if(this.participants)\n-        return this.participants[id];\n-    return null;\n-}\n+    return this.participants[id];\n+};\n \n JitsiConference.prototype.onMemberJoined = function (jid, email, nick) {\n-    if(this.eventEmitter)\n-        this.eventEmitter.emit(JitsiConferenceEvents.USER_JOINED, Strophe.getResourceFromJid(jid));\n-//    this.participants[jid] = new JitsiParticipant();\n-}\n+    var id = Strophe.getResourceFromJid(jid);\n+    var participant = new JitsiParticipant(id, this, nick);\n+    this.eventEmitter.emit(JitsiConferenceEvents.USER_JOINED, id);\n+    this.participants[id] = participant;\n+    this.connection.xmpp.connection.disco.info(\n+        jid, \"\" /* node */, function(iq) {","path":"JitsiConference.js","position":263,"original_position":263,"commit_id":"6de7caa9ce6547af0873d1c383da74a864016c46","original_commit_id":"6de7caa9ce6547af0873d1c383da74a864016c46","user":{"login":"hristoterezov","id":1729265,"avatar_url":"https://avatars.githubusercontent.com/u/1729265?v=3","gravatar_id":"","url":"https://api.github.com/users/hristoterezov","html_url":"https://github.com/hristoterezov","followers_url":"https://api.github.com/users/hristoterezov/followers","following_url":"https://api.github.com/users/hristoterezov/following{/other_user}","gists_url":"https://api.github.com/users/hristoterezov/gists{/gist_id}","starred_url":"https://api.github.com/users/hristoterezov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hristoterezov/subscriptions","organizations_url":"https://api.github.com/users/hristoterezov/orgs","repos_url":"https://api.github.com/users/hristoterezov/repos","events_url":"https://api.github.com/users/hristoterezov/events{/privacy}","received_events_url":"https://api.github.com/users/hristoterezov/received_events","type":"User","site_admin":false},"body":"I received some JS error which was fixed when I tried with \"node\" parameter. I uncommented it temporary in the library.","created_at":"2015-12-09T04:14:27Z","updated_at":"2015-12-09T04:14:27Z","html_url":"https://github.com/jitsi/jitsi-meet/pull/426#discussion_r47049696","pull_request_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426","_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments/47049696"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/426#discussion_r47049696"},"pull_request":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426"}}},"pull_request":{"url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426","id":52665804,"html_url":"https://github.com/jitsi/jitsi-meet/pull/426","diff_url":"https://github.com/jitsi/jitsi-meet/pull/426.diff","patch_url":"https://github.com/jitsi/jitsi-meet/pull/426.patch","issue_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/426","number":426,"state":"closed","locked":false,"title":"Add DTMF support to JS API","user":{"login":"isymchych","id":15652019,"avatar_url":"https://avatars.githubusercontent.com/u/15652019?v=3","gravatar_id":"","url":"https://api.github.com/users/isymchych","html_url":"https://github.com/isymchych","followers_url":"https://api.github.com/users/isymchych/followers","following_url":"https://api.github.com/users/isymchych/following{/other_user}","gists_url":"https://api.github.com/users/isymchych/gists{/gist_id}","starred_url":"https://api.github.com/users/isymchych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isymchych/subscriptions","organizations_url":"https://api.github.com/users/isymchych/orgs","repos_url":"https://api.github.com/users/isymchych/repos","events_url":"https://api.github.com/users/isymchych/events{/privacy}","received_events_url":"https://api.github.com/users/isymchych/received_events","type":"User","site_admin":false},"body":"* add DTMF support to JitsiConference\r\n* add DTMF support detection from members module\r\n* implemented few methods for JitsiParticipant\r\n* provide methods/events to get user role\r\n* fix few critical issues in RTCUtils","created_at":"2015-12-04T12:54:23Z","updated_at":"2015-12-09T04:14:27Z","closed_at":"2015-12-09T02:59:18Z","merged_at":"2015-12-09T02:59:18Z","merge_commit_sha":"5b8494f39475a28d51ca321e87514069aa05a49e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426/commits","review_comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426/comments","review_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/426/comments","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/6de7caa9ce6547af0873d1c383da74a864016c46","head":{"label":"isymchych:move-dtmf","ref":"move-dtmf","sha":"6de7caa9ce6547af0873d1c383da74a864016c46","user":{"login":"isymchych","id":15652019,"avatar_url":"https://avatars.githubusercontent.com/u/15652019?v=3","gravatar_id":"","url":"https://api.github.com/users/isymchych","html_url":"https://github.com/isymchych","followers_url":"https://api.github.com/users/isymchych/followers","following_url":"https://api.github.com/users/isymchych/following{/other_user}","gists_url":"https://api.github.com/users/isymchych/gists{/gist_id}","starred_url":"https://api.github.com/users/isymchych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isymchych/subscriptions","organizations_url":"https://api.github.com/users/isymchych/orgs","repos_url":"https://api.github.com/users/isymchych/repos","events_url":"https://api.github.com/users/isymchych/events{/privacy}","received_events_url":"https://api.github.com/users/isymchych/received_events","type":"User","site_admin":false},"repo":{"id":45540870,"name":"jitsi-meet","full_name":"isymchych/jitsi-meet","owner":{"login":"isymchych","id":15652019,"avatar_url":"https://avatars.githubusercontent.com/u/15652019?v=3","gravatar_id":"","url":"https://api.github.com/users/isymchych","html_url":"https://github.com/isymchych","followers_url":"https://api.github.com/users/isymchych/followers","following_url":"https://api.github.com/users/isymchych/following{/other_user}","gists_url":"https://api.github.com/users/isymchych/gists{/gist_id}","starred_url":"https://api.github.com/users/isymchych/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isymchych/subscriptions","organizations_url":"https://api.github.com/users/isymchych/orgs","repos_url":"https://api.github.com/users/isymchych/repos","events_url":"https://api.github.com/users/isymchych/events{/privacy}","received_events_url":"https://api.github.com/users/isymchych/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isymchych/jitsi-meet","description":"Jitsi Videobridge meets WebRTC","fork":true,"url":"https://api.github.com/repos/isymchych/jitsi-meet","forks_url":"https://api.github.com/repos/isymchych/jitsi-meet/forks","keys_url":"https://api.github.com/repos/isymchych/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isymchych/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isymchych/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/isymchych/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/isymchych/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/isymchych/jitsi-meet/events","assignees_url":"https://api.github.com/repos/isymchych/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/isymchych/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/isymchych/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/isymchych/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isymchych/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isymchych/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/isymchych/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isymchych/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/isymchych/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/isymchych/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/isymchych/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/isymchych/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/isymchych/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/isymchych/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/isymchych/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/isymchych/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/isymchych/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/isymchych/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/isymchych/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isymchych/jitsi-meet/merges","archive_url":"https://api.github.com/repos/isymchych/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isymchych/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/isymchych/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/isymchych/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/isymchych/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/isymchych/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isymchych/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/isymchych/jitsi-meet/releases{/id}","created_at":"2015-11-04T13:32:24Z","updated_at":"2015-11-04T13:32:28Z","pushed_at":"2015-12-08T14:32:29Z","git_url":"git://github.com/isymchych/jitsi-meet.git","ssh_url":"git@github.com:isymchych/jitsi-meet.git","clone_url":"https://github.com/isymchych/jitsi-meet.git","svn_url":"https://github.com/isymchych/jitsi-meet","homepage":"https://jitsi.org/Projects/JitsiMeet","size":17227,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jitsi:lib-jitsi-meet","ref":"lib-jitsi-meet","sha":"df4ec063a58ee84dbfcfcd6328794cd8b38cecdc","user":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"repo":{"id":15225670,"name":"jitsi-meet","full_name":"jitsi/jitsi-meet","owner":{"login":"jitsi","id":3671647,"avatar_url":"https://avatars.githubusercontent.com/u/3671647?v=3","gravatar_id":"","url":"https://api.github.com/users/jitsi","html_url":"https://github.com/jitsi","followers_url":"https://api.github.com/users/jitsi/followers","following_url":"https://api.github.com/users/jitsi/following{/other_user}","gists_url":"https://api.github.com/users/jitsi/gists{/gist_id}","starred_url":"https://api.github.com/users/jitsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jitsi/subscriptions","organizations_url":"https://api.github.com/users/jitsi/orgs","repos_url":"https://api.github.com/users/jitsi/repos","events_url":"https://api.github.com/users/jitsi/events{/privacy}","received_events_url":"https://api.github.com/users/jitsi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jitsi/jitsi-meet","description":"Jitsi Videobridge meets WebRTC","fork":true,"url":"https://api.github.com/repos/jitsi/jitsi-meet","forks_url":"https://api.github.com/repos/jitsi/jitsi-meet/forks","keys_url":"https://api.github.com/repos/jitsi/jitsi-meet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jitsi/jitsi-meet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jitsi/jitsi-meet/teams","hooks_url":"https://api.github.com/repos/jitsi/jitsi-meet/hooks","issue_events_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/events{/number}","events_url":"https://api.github.com/repos/jitsi/jitsi-meet/events","assignees_url":"https://api.github.com/repos/jitsi/jitsi-meet/assignees{/user}","branches_url":"https://api.github.com/repos/jitsi/jitsi-meet/branches{/branch}","tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/tags","blobs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/refs{/sha}","trees_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/{sha}","languages_url":"https://api.github.com/repos/jitsi/jitsi-meet/languages","stargazers_url":"https://api.github.com/repos/jitsi/jitsi-meet/stargazers","contributors_url":"https://api.github.com/repos/jitsi/jitsi-meet/contributors","subscribers_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscribers","subscription_url":"https://api.github.com/repos/jitsi/jitsi-meet/subscription","commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/commits{/sha}","git_commits_url":"https://api.github.com/repos/jitsi/jitsi-meet/git/commits{/sha}","comments_url":"https://api.github.com/repos/jitsi/jitsi-meet/comments{/number}","issue_comment_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues/comments{/number}","contents_url":"https://api.github.com/repos/jitsi/jitsi-meet/contents/{+path}","compare_url":"https://api.github.com/repos/jitsi/jitsi-meet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jitsi/jitsi-meet/merges","archive_url":"https://api.github.com/repos/jitsi/jitsi-meet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jitsi/jitsi-meet/downloads","issues_url":"https://api.github.com/repos/jitsi/jitsi-meet/issues{/number}","pulls_url":"https://api.github.com/repos/jitsi/jitsi-meet/pulls{/number}","milestones_url":"https://api.github.com/repos/jitsi/jitsi-meet/milestones{/number}","notifications_url":"https://api.github.com/repos/jitsi/jitsi-meet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jitsi/jitsi-meet/labels{/name}","releases_url":"https://api.github.com/repos/jitsi/jitsi-meet/releases{/id}","created_at":"2013-12-16T12:51:09Z","updated_at":"2015-12-09T03:28:29Z","pushed_at":"2015-12-09T03:57:43Z","git_url":"git://github.com/jitsi/jitsi-meet.git","ssh_url":"git@github.com:jitsi/jitsi-meet.git","clone_url":"https://github.com/jitsi/jitsi-meet.git","svn_url":"https://github.com/jitsi/jitsi-meet","homepage":"https://jitsi.org/Projects/JitsiMeet","size":17709,"stargazers_count":434,"watchers_count":434,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":189,"mirror_url":null,"open_issues_count":117,"forks":189,"open_issues":117,"watchers":434,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426"},"html":{"href":"https://github.com/jitsi/jitsi-meet/pull/426"},"issue":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/426"},"comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/issues/426/comments"},"review_comments":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426/comments"},"review_comment":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/pulls/426/commits"},"statuses":{"href":"https://api.github.com/repos/jitsi/jitsi-meet/statuses/6de7caa9ce6547af0873d1c383da74a864016c46"}}}}