{"action":"opened","number":123,"pull_request":{"url":"https://api.github.com/repos/Blosc/c-blosc/pulls/123","id":35083495,"html_url":"https://github.com/Blosc/c-blosc/pull/123","diff_url":"https://github.com/Blosc/c-blosc/pull/123.diff","patch_url":"https://github.com/Blosc/c-blosc/pull/123.patch","issue_url":"https://api.github.com/repos/Blosc/c-blosc/issues/123","number":123,"state":"open","locked":false,"title":"Hidden symbols fix","user":{"login":"jack-pappas","id":477287,"avatar_url":"https://avatars.githubusercontent.com/u/477287?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-pappas","html_url":"https://github.com/jack-pappas","followers_url":"https://api.github.com/users/jack-pappas/followers","following_url":"https://api.github.com/users/jack-pappas/following{/other_user}","gists_url":"https://api.github.com/users/jack-pappas/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-pappas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-pappas/subscriptions","organizations_url":"https://api.github.com/users/jack-pappas/orgs","repos_url":"https://api.github.com/users/jack-pappas/repos","events_url":"https://api.github.com/users/jack-pappas/events{/privacy}","received_events_url":"https://api.github.com/users/jack-pappas/received_events","type":"User","site_admin":false},"body":"This PR modifies the symbol hiding introduced in #112 and should allow #114 to be re-submitted without breaking the build.\r\n\r\nWhen ``BUILD_TESTS`` is enabled in the CMake configuration, we now build a second, special version of ``libblosc``/``blosc.dll`` that exposes the normally-hidden symbols like ``shuffle_sse2`` to allow the tests to call them directly without going through the CPU feature-detection code. This extra library is called ``libblosc_testing``/``blosc_testing.dll`` and is *not* installed like the other libraries -- it is only used by and for the tests.\r\n\r\nOne thing that should be checked before accepting this PR -- the CMake config script now sets the symbol visibility to hidden by default (e.g., it will pass ``-fvisibility=hidden`` to GCC and Clang), so this might end up hiding some additional symbols that were visible by default before. If that's the case *and* they still need to be exported (for backwards compatibility), please let me know so I can make the necessary adjustments to preserve their visibility.","created_at":"2015-05-10T14:39:22Z","updated_at":"2015-05-10T14:39:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Blosc/c-blosc/pulls/123/commits","review_comments_url":"https://api.github.com/repos/Blosc/c-blosc/pulls/123/comments","review_comment_url":"https://api.github.com/repos/Blosc/c-blosc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Blosc/c-blosc/issues/123/comments","statuses_url":"https://api.github.com/repos/Blosc/c-blosc/statuses/b1b043d909ebcf57ed67dcb784e8feafd605c917","head":{"label":"jack-pappas:hidden-symbols-fix","ref":"hidden-symbols-fix","sha":"b1b043d909ebcf57ed67dcb784e8feafd605c917","user":{"login":"jack-pappas","id":477287,"avatar_url":"https://avatars.githubusercontent.com/u/477287?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-pappas","html_url":"https://github.com/jack-pappas","followers_url":"https://api.github.com/users/jack-pappas/followers","following_url":"https://api.github.com/users/jack-pappas/following{/other_user}","gists_url":"https://api.github.com/users/jack-pappas/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-pappas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-pappas/subscriptions","organizations_url":"https://api.github.com/users/jack-pappas/orgs","repos_url":"https://api.github.com/users/jack-pappas/repos","events_url":"https://api.github.com/users/jack-pappas/events{/privacy}","received_events_url":"https://api.github.com/users/jack-pappas/received_events","type":"User","site_admin":false},"repo":{"id":28775627,"name":"c-blosc","full_name":"jack-pappas/c-blosc","owner":{"login":"jack-pappas","id":477287,"avatar_url":"https://avatars.githubusercontent.com/u/477287?v=3","gravatar_id":"","url":"https://api.github.com/users/jack-pappas","html_url":"https://github.com/jack-pappas","followers_url":"https://api.github.com/users/jack-pappas/followers","following_url":"https://api.github.com/users/jack-pappas/following{/other_user}","gists_url":"https://api.github.com/users/jack-pappas/gists{/gist_id}","starred_url":"https://api.github.com/users/jack-pappas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jack-pappas/subscriptions","organizations_url":"https://api.github.com/users/jack-pappas/orgs","repos_url":"https://api.github.com/users/jack-pappas/repos","events_url":"https://api.github.com/users/jack-pappas/events{/privacy}","received_events_url":"https://api.github.com/users/jack-pappas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jack-pappas/c-blosc","description":"A blocking, shuffling and loss-less compression library that can be faster than `memcpy()`.","fork":true,"url":"https://api.github.com/repos/jack-pappas/c-blosc","forks_url":"https://api.github.com/repos/jack-pappas/c-blosc/forks","keys_url":"https://api.github.com/repos/jack-pappas/c-blosc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jack-pappas/c-blosc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jack-pappas/c-blosc/teams","hooks_url":"https://api.github.com/repos/jack-pappas/c-blosc/hooks","issue_events_url":"https://api.github.com/repos/jack-pappas/c-blosc/issues/events{/number}","events_url":"https://api.github.com/repos/jack-pappas/c-blosc/events","assignees_url":"https://api.github.com/repos/jack-pappas/c-blosc/assignees{/user}","branches_url":"https://api.github.com/repos/jack-pappas/c-blosc/branches{/branch}","tags_url":"https://api.github.com/repos/jack-pappas/c-blosc/tags","blobs_url":"https://api.github.com/repos/jack-pappas/c-blosc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jack-pappas/c-blosc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jack-pappas/c-blosc/git/refs{/sha}","trees_url":"https://api.github.com/repos/jack-pappas/c-blosc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jack-pappas/c-blosc/statuses/{sha}","languages_url":"https://api.github.com/repos/jack-pappas/c-blosc/languages","stargazers_url":"https://api.github.com/repos/jack-pappas/c-blosc/stargazers","contributors_url":"https://api.github.com/repos/jack-pappas/c-blosc/contributors","subscribers_url":"https://api.github.com/repos/jack-pappas/c-blosc/subscribers","subscription_url":"https://api.github.com/repos/jack-pappas/c-blosc/subscription","commits_url":"https://api.github.com/repos/jack-pappas/c-blosc/commits{/sha}","git_commits_url":"https://api.github.com/repos/jack-pappas/c-blosc/git/commits{/sha}","comments_url":"https://api.github.com/repos/jack-pappas/c-blosc/comments{/number}","issue_comment_url":"https://api.github.com/repos/jack-pappas/c-blosc/issues/comments{/number}","contents_url":"https://api.github.com/repos/jack-pappas/c-blosc/contents/{+path}","compare_url":"https://api.github.com/repos/jack-pappas/c-blosc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jack-pappas/c-blosc/merges","archive_url":"https://api.github.com/repos/jack-pappas/c-blosc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jack-pappas/c-blosc/downloads","issues_url":"https://api.github.com/repos/jack-pappas/c-blosc/issues{/number}","pulls_url":"https://api.github.com/repos/jack-pappas/c-blosc/pulls{/number}","milestones_url":"https://api.github.com/repos/jack-pappas/c-blosc/milestones{/number}","notifications_url":"https://api.github.com/repos/jack-pappas/c-blosc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jack-pappas/c-blosc/labels{/name}","releases_url":"https://api.github.com/repos/jack-pappas/c-blosc/releases{/id}","created_at":"2015-01-04T13:58:24Z","updated_at":"2015-04-26T16:46:23Z","pushed_at":"2015-05-09T21:09:35Z","git_url":"git://github.com/jack-pappas/c-blosc.git","ssh_url":"git@github.com:jack-pappas/c-blosc.git","clone_url":"https://github.com/jack-pappas/c-blosc.git","svn_url":"https://github.com/jack-pappas/c-blosc","homepage":"http://blosc.org","size":1844,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"Blosc:master","ref":"master","sha":"9706b36501fd1d78e34e79c0627ff5b1c619da3a","user":{"login":"Blosc","id":6469856,"avatar_url":"https://avatars.githubusercontent.com/u/6469856?v=3","gravatar_id":"","url":"https://api.github.com/users/Blosc","html_url":"https://github.com/Blosc","followers_url":"https://api.github.com/users/Blosc/followers","following_url":"https://api.github.com/users/Blosc/following{/other_user}","gists_url":"https://api.github.com/users/Blosc/gists{/gist_id}","starred_url":"https://api.github.com/users/Blosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blosc/subscriptions","organizations_url":"https://api.github.com/users/Blosc/orgs","repos_url":"https://api.github.com/users/Blosc/repos","events_url":"https://api.github.com/users/Blosc/events{/privacy}","received_events_url":"https://api.github.com/users/Blosc/received_events","type":"Organization","site_admin":false},"repo":{"id":1990838,"name":"c-blosc","full_name":"Blosc/c-blosc","owner":{"login":"Blosc","id":6469856,"avatar_url":"https://avatars.githubusercontent.com/u/6469856?v=3","gravatar_id":"","url":"https://api.github.com/users/Blosc","html_url":"https://github.com/Blosc","followers_url":"https://api.github.com/users/Blosc/followers","following_url":"https://api.github.com/users/Blosc/following{/other_user}","gists_url":"https://api.github.com/users/Blosc/gists{/gist_id}","starred_url":"https://api.github.com/users/Blosc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blosc/subscriptions","organizations_url":"https://api.github.com/users/Blosc/orgs","repos_url":"https://api.github.com/users/Blosc/repos","events_url":"https://api.github.com/users/Blosc/events{/privacy}","received_events_url":"https://api.github.com/users/Blosc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Blosc/c-blosc","description":"A blocking, shuffling and loss-less compression library that can be faster than `memcpy()`.","fork":false,"url":"https://api.github.com/repos/Blosc/c-blosc","forks_url":"https://api.github.com/repos/Blosc/c-blosc/forks","keys_url":"https://api.github.com/repos/Blosc/c-blosc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Blosc/c-blosc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Blosc/c-blosc/teams","hooks_url":"https://api.github.com/repos/Blosc/c-blosc/hooks","issue_events_url":"https://api.github.com/repos/Blosc/c-blosc/issues/events{/number}","events_url":"https://api.github.com/repos/Blosc/c-blosc/events","assignees_url":"https://api.github.com/repos/Blosc/c-blosc/assignees{/user}","branches_url":"https://api.github.com/repos/Blosc/c-blosc/branches{/branch}","tags_url":"https://api.github.com/repos/Blosc/c-blosc/tags","blobs_url":"https://api.github.com/repos/Blosc/c-blosc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Blosc/c-blosc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Blosc/c-blosc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Blosc/c-blosc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Blosc/c-blosc/statuses/{sha}","languages_url":"https://api.github.com/repos/Blosc/c-blosc/languages","stargazers_url":"https://api.github.com/repos/Blosc/c-blosc/stargazers","contributors_url":"https://api.github.com/repos/Blosc/c-blosc/contributors","subscribers_url":"https://api.github.com/repos/Blosc/c-blosc/subscribers","subscription_url":"https://api.github.com/repos/Blosc/c-blosc/subscription","commits_url":"https://api.github.com/repos/Blosc/c-blosc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Blosc/c-blosc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Blosc/c-blosc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Blosc/c-blosc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Blosc/c-blosc/contents/{+path}","compare_url":"https://api.github.com/repos/Blosc/c-blosc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Blosc/c-blosc/merges","archive_url":"https://api.github.com/repos/Blosc/c-blosc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Blosc/c-blosc/downloads","issues_url":"https://api.github.com/repos/Blosc/c-blosc/issues{/number}","pulls_url":"https://api.github.com/repos/Blosc/c-blosc/pulls{/number}","milestones_url":"https://api.github.com/repos/Blosc/c-blosc/milestones{/number}","notifications_url":"https://api.github.com/repos/Blosc/c-blosc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Blosc/c-blosc/labels{/name}","releases_url":"https://api.github.com/repos/Blosc/c-blosc/releases{/id}","created_at":"2011-07-03T11:38:39Z","updated_at":"2015-05-07T18:30:49Z","pushed_at":"2015-05-10T14:24:42Z","git_url":"git://github.com/Blosc/c-blosc.git","ssh_url":"git@github.com:Blosc/c-blosc.git","clone_url":"https://github.com/Blosc/c-blosc.git","svn_url":"https://github.com/Blosc/c-blosc","homepage":"http://blosc.org","size":3456,"stargazers_count":231,"watchers_count":231,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":18,"forks":39,"open_issues":18,"watchers":231,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Blosc/c-blosc/pulls/123"},"html":{"href":"https://github.com/Blosc/c-blosc/pull/123"},"issue":{"href":"https://api.github.com/repos/Blosc/c-blosc/issues/123"},"comments":{"href":"https://api.github.com/repos/Blosc/c-blosc/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/Blosc/c-blosc/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/Blosc/c-blosc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Blosc/c-blosc/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/Blosc/c-blosc/statuses/b1b043d909ebcf57ed67dcb784e8feafd605c917"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":2,"additions":119,"deletions":59,"changed_files":9}}