{"action":"created","comment":{"url":"https://api.github.com/repos/dojo/core/pulls/comments/32732514","id":32732514,"diff_hunk":"@@ -160,6 +132,8 @@ export function getPropertyNames(object: {}): string[] {\n \treturn names;\n }\n \n+// TODO ObjectObserver has a similar method that goes a step further by providing a default descriptor.\n+// Should this implementation be replaced with that one, as this one is not used anymore?","path":"src/lang.ts","position":201,"original_position":201,"commit_id":"cb3b39f2c4e9915cb8ab490998b949883749f3c5","original_commit_id":"cb3b39f2c4e9915cb8ab490998b949883749f3c5","user":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars.githubusercontent.com/u/398379?v=3","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"body":"#40 discusses moving the observe stuff to its own file anyway, so does this become entirely removable then?  If so, I'd vote to remove.","created_at":"2015-06-18T14:03:10Z","updated_at":"2015-06-18T14:03:10Z","html_url":"https://github.com/dojo/core/pull/31#discussion_r32732514","pull_request_url":"https://api.github.com/repos/dojo/core/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/dojo/core/pulls/comments/32732514"},"html":{"href":"https://github.com/dojo/core/pull/31#discussion_r32732514"},"pull_request":{"href":"https://api.github.com/repos/dojo/core/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/dojo/core/pulls/31","id":37290126,"html_url":"https://github.com/dojo/core/pull/31","diff_url":"https://github.com/dojo/core/pull/31.diff","patch_url":"https://github.com/dojo/core/pull/31.patch","issue_url":"https://api.github.com/repos/dojo/core/issues/31","number":31,"state":"open","locked":false,"title":"Simplify lang's object copying (addresses issue #26: https://github.com/dojo/core/issues/26)","user":{"login":"mwistrand","id":3423657,"avatar_url":"https://avatars.githubusercontent.com/u/3423657?v=3","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"body":"* Remove inheritance checking from lang.copy.\r\n* Break lang.copy into lang.assign, lang.assignDeep, lang.copy, and lang.copyDeep.","created_at":"2015-06-09T19:31:01Z","updated_at":"2015-06-18T14:03:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1f19b22dbc9cd2228b7b8b7822eeb987ab9f554","assignee":{"login":"kfranqueiro","id":398379,"avatar_url":"https://avatars.githubusercontent.com/u/398379?v=3","gravatar_id":"","url":"https://api.github.com/users/kfranqueiro","html_url":"https://github.com/kfranqueiro","followers_url":"https://api.github.com/users/kfranqueiro/followers","following_url":"https://api.github.com/users/kfranqueiro/following{/other_user}","gists_url":"https://api.github.com/users/kfranqueiro/gists{/gist_id}","starred_url":"https://api.github.com/users/kfranqueiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfranqueiro/subscriptions","organizations_url":"https://api.github.com/users/kfranqueiro/orgs","repos_url":"https://api.github.com/users/kfranqueiro/repos","events_url":"https://api.github.com/users/kfranqueiro/events{/privacy}","received_events_url":"https://api.github.com/users/kfranqueiro/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dojo/core/pulls/31/commits","review_comments_url":"https://api.github.com/repos/dojo/core/pulls/31/comments","review_comment_url":"https://api.github.com/repos/dojo/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dojo/core/issues/31/comments","statuses_url":"https://api.github.com/repos/dojo/core/statuses/cb3b39f2c4e9915cb8ab490998b949883749f3c5","head":{"label":"mwistrand:issue-26","ref":"issue-26","sha":"cb3b39f2c4e9915cb8ab490998b949883749f3c5","user":{"login":"mwistrand","id":3423657,"avatar_url":"https://avatars.githubusercontent.com/u/3423657?v=3","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"repo":{"id":35291640,"name":"core","full_name":"mwistrand/core","owner":{"login":"mwistrand","id":3423657,"avatar_url":"https://avatars.githubusercontent.com/u/3423657?v=3","gravatar_id":"","url":"https://api.github.com/users/mwistrand","html_url":"https://github.com/mwistrand","followers_url":"https://api.github.com/users/mwistrand/followers","following_url":"https://api.github.com/users/mwistrand/following{/other_user}","gists_url":"https://api.github.com/users/mwistrand/gists{/gist_id}","starred_url":"https://api.github.com/users/mwistrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwistrand/subscriptions","organizations_url":"https://api.github.com/users/mwistrand/orgs","repos_url":"https://api.github.com/users/mwistrand/repos","events_url":"https://api.github.com/users/mwistrand/events{/privacy}","received_events_url":"https://api.github.com/users/mwistrand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwistrand/core","description":"TypeScript and JavaScript core library utilities","fork":true,"url":"https://api.github.com/repos/mwistrand/core","forks_url":"https://api.github.com/repos/mwistrand/core/forks","keys_url":"https://api.github.com/repos/mwistrand/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwistrand/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwistrand/core/teams","hooks_url":"https://api.github.com/repos/mwistrand/core/hooks","issue_events_url":"https://api.github.com/repos/mwistrand/core/issues/events{/number}","events_url":"https://api.github.com/repos/mwistrand/core/events","assignees_url":"https://api.github.com/repos/mwistrand/core/assignees{/user}","branches_url":"https://api.github.com/repos/mwistrand/core/branches{/branch}","tags_url":"https://api.github.com/repos/mwistrand/core/tags","blobs_url":"https://api.github.com/repos/mwistrand/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwistrand/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwistrand/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwistrand/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwistrand/core/statuses/{sha}","languages_url":"https://api.github.com/repos/mwistrand/core/languages","stargazers_url":"https://api.github.com/repos/mwistrand/core/stargazers","contributors_url":"https://api.github.com/repos/mwistrand/core/contributors","subscribers_url":"https://api.github.com/repos/mwistrand/core/subscribers","subscription_url":"https://api.github.com/repos/mwistrand/core/subscription","commits_url":"https://api.github.com/repos/mwistrand/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwistrand/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwistrand/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwistrand/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwistrand/core/contents/{+path}","compare_url":"https://api.github.com/repos/mwistrand/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwistrand/core/merges","archive_url":"https://api.github.com/repos/mwistrand/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwistrand/core/downloads","issues_url":"https://api.github.com/repos/mwistrand/core/issues{/number}","pulls_url":"https://api.github.com/repos/mwistrand/core/pulls{/number}","milestones_url":"https://api.github.com/repos/mwistrand/core/milestones{/number}","notifications_url":"https://api.github.com/repos/mwistrand/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwistrand/core/labels{/name}","releases_url":"https://api.github.com/repos/mwistrand/core/releases{/id}","created_at":"2015-05-08T17:08:11Z","updated_at":"2015-05-08T17:08:12Z","pushed_at":"2015-06-15T20:43:01Z","git_url":"git://github.com/mwistrand/core.git","ssh_url":"git@github.com:mwistrand/core.git","clone_url":"https://github.com/mwistrand/core.git","svn_url":"https://github.com/mwistrand/core","homepage":null,"size":702,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dojo:master","ref":"master","sha":"50571111a88e3e2634753b34a7a2575e4a295780","user":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"repo":{"id":31790386,"name":"core","full_name":"dojo/core","owner":{"login":"dojo","id":86896,"avatar_url":"https://avatars.githubusercontent.com/u/86896?v=3","gravatar_id":"","url":"https://api.github.com/users/dojo","html_url":"https://github.com/dojo","followers_url":"https://api.github.com/users/dojo/followers","following_url":"https://api.github.com/users/dojo/following{/other_user}","gists_url":"https://api.github.com/users/dojo/gists{/gist_id}","starred_url":"https://api.github.com/users/dojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dojo/subscriptions","organizations_url":"https://api.github.com/users/dojo/orgs","repos_url":"https://api.github.com/users/dojo/repos","events_url":"https://api.github.com/users/dojo/events{/privacy}","received_events_url":"https://api.github.com/users/dojo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dojo/core","description":"Dojo 2 package containing TypeScript and JavaScript core utilities","fork":false,"url":"https://api.github.com/repos/dojo/core","forks_url":"https://api.github.com/repos/dojo/core/forks","keys_url":"https://api.github.com/repos/dojo/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dojo/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dojo/core/teams","hooks_url":"https://api.github.com/repos/dojo/core/hooks","issue_events_url":"https://api.github.com/repos/dojo/core/issues/events{/number}","events_url":"https://api.github.com/repos/dojo/core/events","assignees_url":"https://api.github.com/repos/dojo/core/assignees{/user}","branches_url":"https://api.github.com/repos/dojo/core/branches{/branch}","tags_url":"https://api.github.com/repos/dojo/core/tags","blobs_url":"https://api.github.com/repos/dojo/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dojo/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dojo/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/dojo/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dojo/core/statuses/{sha}","languages_url":"https://api.github.com/repos/dojo/core/languages","stargazers_url":"https://api.github.com/repos/dojo/core/stargazers","contributors_url":"https://api.github.com/repos/dojo/core/contributors","subscribers_url":"https://api.github.com/repos/dojo/core/subscribers","subscription_url":"https://api.github.com/repos/dojo/core/subscription","commits_url":"https://api.github.com/repos/dojo/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/dojo/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/dojo/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/dojo/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/dojo/core/contents/{+path}","compare_url":"https://api.github.com/repos/dojo/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dojo/core/merges","archive_url":"https://api.github.com/repos/dojo/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dojo/core/downloads","issues_url":"https://api.github.com/repos/dojo/core/issues{/number}","pulls_url":"https://api.github.com/repos/dojo/core/pulls{/number}","milestones_url":"https://api.github.com/repos/dojo/core/milestones{/number}","notifications_url":"https://api.github.com/repos/dojo/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dojo/core/labels{/name}","releases_url":"https://api.github.com/repos/dojo/core/releases{/id}","created_at":"2015-03-06T21:44:31Z","updated_at":"2015-06-04T07:20:05Z","pushed_at":"2015-06-17T20:21:12Z","git_url":"git://github.com/dojo/core.git","ssh_url":"git@github.com:dojo/core.git","clone_url":"https://github.com/dojo/core.git","svn_url":"https://github.com/dojo/core","homepage":"","size":1846,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":17,"forks":14,"open_issues":17,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dojo/core/pulls/31"},"html":{"href":"https://github.com/dojo/core/pull/31"},"issue":{"href":"https://api.github.com/repos/dojo/core/issues/31"},"comments":{"href":"https://api.github.com/repos/dojo/core/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/dojo/core/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/dojo/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dojo/core/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/dojo/core/statuses/cb3b39f2c4e9915cb8ab490998b949883749f3c5"}}}}