{"action":"created","issue":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/83","labels_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/83/comments","events_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/83/events","html_url":"https://github.com/ros2/rmw_opensplice/pull/83","id":107830618,"number":83,"title":"Bypass OpenSplice query encoding","user":{"login":"esteve","id":33620,"avatar_url":"https://avatars.githubusercontent.com/u/33620?v=3","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ros2/rmw_opensplice/labels/in%20review","name":"in review","color":"c7def8"}],"state":"open","locked":false,"assignee":{"login":"esteve","id":33620,"avatar_url":"https://avatars.githubusercontent.com/u/33620?v=3","gravatar_id":"","url":"https://api.github.com/users/esteve","html_url":"https://github.com/esteve","followers_url":"https://api.github.com/users/esteve/followers","following_url":"https://api.github.com/users/esteve/following{/other_user}","gists_url":"https://api.github.com/users/esteve/gists{/gist_id}","starred_url":"https://api.github.com/users/esteve/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esteve/subscriptions","organizations_url":"https://api.github.com/users/esteve/orgs","repos_url":"https://api.github.com/users/esteve/repos","events_url":"https://api.github.com/users/esteve/events{/privacy}","received_events_url":"https://api.github.com/users/esteve/received_events","type":"User","site_admin":false},"milestone":null,"comments":18,"created_at":"2015-09-23T00:35:59Z","updated_at":"2015-10-09T17:46:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/pulls/83","html_url":"https://github.com/ros2/rmw_opensplice/pull/83","diff_url":"https://github.com/ros2/rmw_opensplice/pull/83.diff","patch_url":"https://github.com/ros2/rmw_opensplice/pull/83.patch"},"body":"This uses standard C++ string concatenation instead of leaving it up to OpenSplice to encode the query. We have seen processes crashing on Windows, but it may not be platform specific and instead a consequence of memory corruption on our code."},"comment":{"url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/comments/146944723","html_url":"https://github.com/ros2/rmw_opensplice/pull/83#issuecomment-146944723","issue_url":"https://api.github.com/repos/ros2/rmw_opensplice/issues/83","id":146944723,"user":{"login":"dirk-thomas","id":1335366,"avatar_url":"https://avatars.githubusercontent.com/u/1335366?v=3","gravatar_id":"","url":"https://api.github.com/users/dirk-thomas","html_url":"https://github.com/dirk-thomas","followers_url":"https://api.github.com/users/dirk-thomas/followers","following_url":"https://api.github.com/users/dirk-thomas/following{/other_user}","gists_url":"https://api.github.com/users/dirk-thomas/gists{/gist_id}","starred_url":"https://api.github.com/users/dirk-thomas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirk-thomas/subscriptions","organizations_url":"https://api.github.com/users/dirk-thomas/orgs","repos_url":"https://api.github.com/users/dirk-thomas/repos","events_url":"https://api.github.com/users/dirk-thomas/events{/privacy}","received_events_url":"https://api.github.com/users/dirk-thomas/received_events","type":"User","site_admin":false},"created_at":"2015-10-09T17:46:45Z","updated_at":"2015-10-09T17:46:45Z","body":"+/-0 from me since I still don't think this is the way to fix the problem. Having a minimal example demonstrating the bug using the OpenSplice API directly (without any ROS 2 stuff) would be something that convinces me.\r\n\r\nWe currently also lack the necessary \"infrastructure\" to run these tests efficiently. If we rely on random numbers to be in a certain range we need to run the tests numerous times to get a reasonable confidence that a certain change improves things."}}