{"push_id":568956195,"size":1,"distinct_size":1,"ref":"refs/heads/branch-1.3","head":"f2aa7b7572735019c56091e770c14ccba3d95833","before":"5782ee29eb273b1f87a07fd624bbf228d2597b98","commits":[{"sha":"f2aa7b7572735019c56091e770c14ccba3d95833","author":{"email":"fbfd45890515f7eeeeabf87d7a80d3449c3bce83@gmail.com","name":"Nicholas Chammas"},"message":"[SPARK-5473] [EC2] Expose SSH failures after status checks pass\n\nIf there is some fatal problem with launching a cluster, `spark-ec2` just hangs without giving the user useful feedback on what the problem is.\n\nThis PR exposes the output of the SSH calls to the user if the SSH test fails during cluster launch for any reason but the instance status checks are all green. It also removes the growing trail of dots while waiting in favor of a fixed 3 dots.\n\nFor example:\n\n```\n$ ./ec2/spark-ec2 -k key -i /incorrect/path/identity.pem --instance-type m3.medium --slaves 1 --zone us-east-1c launch \"spark-test\"\nSetting up security groups...\nSearching for existing cluster spark-test...\nSpark AMI: ami-35b1885c\nLaunching instances...\nLaunched 1 slaves in us-east-1c, regid = r-7dadd096\nLaunched master in us-east-1c, regid = r-fcadd017\nWaiting for cluster to enter 'ssh-ready' state...\nWarning: SSH connection error. (This could be temporary.)\nHost: 127.0.0.1\nSSH return code: 255\nSSH output: Warning: Identity file /incorrect/path/identity.pem not accessible: No such file or directory.\nWarning: Permanently added '127.0.0.1' (RSA) to the list of known hosts.\nPermission denied (publickey).\n```\n\nThis should give users enough information when some unrecoverable error occurs during launch so they can know to abort the launch. This will help avoid situations like the ones reported [here on Stack Overflow](http://stackoverflow.com/q/28002443/) and [here on the user list](http://mail-archives.apache.org/mod_mbox/spark-user/201501.mbox/%3C1422323829398-21381.postn3.nabble.com%3E), where the users couldn't tell what the problem was because it was being hidden by `spark-ec2`.\n\nThis is a usability improvement that should be backported to 1.2.\n\nResolves [SPARK-5473](https://issues.apache.org/jira/browse/SPARK-5473).\n\nAuthor: Nicholas Chammas <nicholas.chammas@gmail.com>\n\nCloses #4262 from nchammas/expose-ssh-failure and squashes the following commits:\n\n8bda6ed [Nicholas Chammas] default to print SSH output\n2b92534 [Nicholas Chammas] show SSH output after status check pass\n\n(cherry picked from commit 4dfe180fc893bee1146161f8b2a6efd4d6d2bb8c)\nSigned-off-by: Sean Owen <sowen@cloudera.com>","distinct":true,"url":"https://api.github.com/repos/apache/spark/commits/f2aa7b7572735019c56091e770c14ccba3d95833"}]}