{"action":"created","comment":{"url":"https://api.github.com/repos/wunderlist/render/pulls/comments/36511203","id":36511203,"diff_hunk":"@@ -175,54 +177,37 @@ func buildExecutable(platform string, app string, rev string) {\n \tif err != nil {\n \t\tfmt.Println(err)\n \t}\n-\tif platform == \"golang\" {\n-\t\tfor _, p := range strings.Split(os.Getenv(\"PROJECT_PATH\"), \":\") {\n-\t\t\tproject := fmt.Sprintf(\"%s/%s\", p, app)\n-\t\t\tf, err := os.Open(project)\n-\t\t\tif err == nil {\n-\t\t\t\tif i, _ := f.Stat(); i.IsDir() {\n \n-\t\t\t\t\tcurr, err := os.Getwd()\n-\t\t\t\t\tif err != nil {\n-\t\t\t\t\t\tfmt.Println(err)\n-\t\t\t\t\t\treturn\n-\t\t\t\t\t}\n-\t\t\t\t\terr = os.Chdir(project)\n-\t\t\t\t\tif err != nil {\n-\t\t\t\t\t\tfmt.Println(err)\n-\t\t\t\t\t\treturn\n-\t\t\t\t\t}\n-\t\t\t\t\tcmd := exec.Command(\"git\", \"checkout\", rev)\n-\t\t\t\t\t_, err = cmd.Output()\n-\t\t\t\t\tif err != nil {\n-\t\t\t\t\t\tif debug {\n-\t\t\t\t\t\t\tfmt.Fprintf(os.Stderr, \"  Cannot checkout %s: %s\\n\", rev, err)\n-\t\t\t\t\t\t}\n-\t\t\t\t\t\tos.Exit(1)\n-\t\t\t\t\t}\n-\t\t\t\t\ttarget := fmt.Sprintf(\"%s/tmp/bin/%s\", curr, app)\n-\t\t\t\t\tcmd = exec.Command(\"go\", \"build\", \"-o\", target)\n-\t\t\t\t\tcmd.Env = append(os.Environ(), \"GOOS=linux\")\n-\t\t\t\t\tcmd.Env = append(cmd.Env, \"GOARCH=amd64\")\n-\t\t\t\t\tcmd.Env = append(cmd.Env, \"CGO_ENABLED=0\")\n-\t\t\t\t\t_, err = cmd.Output()\n-\t\t\t\t\tif err != nil {\n-\t\t\t\t\t\tfmt.Fprintf(os.Stderr, \"  Cannot build %s: %s\\n\", app, err)\n-\t\t\t\t\t\treturn\n-\t\t\t\t\t}\n-\t\t\t\t\tcmd = exec.Command(\"git\", \"checkout\", \"-\")\n-\t\t\t\t\t_, err = cmd.Output()\n-\t\t\t\t\tif err != nil {\n-\t\t\t\t\t\tfmt.Fprintf(os.Stderr, \"  Cannot checkout %s: %s\\n\", rev, err)\n-\t\t\t\t\t\treturn\n-\t\t\t\t\t}\n-\t\t\t\t\terr = os.Chdir(curr)\n-\t\t\t\t\tif err != nil {\n-\t\t\t\t\t\tfmt.Println(err)\n-\t\t\t\t\t\treturn\n-\t\t\t\t\t}\n-\t\t\t\t}\n+\n+\tproject := fmt.Sprintf(\"%s/%s\", projectPath, app)\n+\tf, err := os.Open(project)\n+\tif err == nil {\n+\t\tif i, _ := f.Stat(); i.IsDir() {\n+\t\t\tcurr, err := os.Getwd()\n+\t\t\tif err != nil {\n+\t\t\t\tfmt.Println(err)\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\terr = os.Chdir(project)\n+\t\t\tif err != nil {\n+\t\t\t\tfmt.Println(err)\n+\t\t\t\treturn\n+\t\t\t}\n+\n+\t\t\ttarget := fmt.Sprintf(\"%s/tmp/bin/\", curr)\n+\t\t\tcmd := exec.Command(m.BuildCommand, rev, target)\n+\t\t\t_, err = cmd.Output()\n+\t\t\tif err != nil {\n+\t\t\t\tfmt.Fprintf(os.Stderr, \"  Cannot build %s: %s\\n\", app, err)\n+\t\t\t\treturn\n+\t\t\t}\n+\t\t\terr = os.Chdir(curr)\n+\t\t\tif err != nil {\n+\t\t\t\tfmt.Println(err)\n+\t\t\t\treturn\n \t\t\t}\n+","path":"main.go","position":90,"original_position":90,"commit_id":"d4f447736fd727fff5f02202b68f4145b35822f0","original_commit_id":"d4f447736fd727fff5f02202b68f4145b35822f0","user":{"login":"rylev","id":1327285,"avatar_url":"https://avatars.githubusercontent.com/u/1327285?v=3","gravatar_id":"","url":"https://api.github.com/users/rylev","html_url":"https://github.com/rylev","followers_url":"https://api.github.com/users/rylev/followers","following_url":"https://api.github.com/users/rylev/following{/other_user}","gists_url":"https://api.github.com/users/rylev/gists{/gist_id}","starred_url":"https://api.github.com/users/rylev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rylev/subscriptions","organizations_url":"https://api.github.com/users/rylev/orgs","repos_url":"https://api.github.com/users/rylev/repos","events_url":"https://api.github.com/users/rylev/events{/privacy}","received_events_url":"https://api.github.com/users/rylev/received_events","type":"User","site_admin":false},"body":"Do we ever want to delete the tmp folder?","created_at":"2015-08-07T11:47:23Z","updated_at":"2015-08-07T11:47:23Z","html_url":"https://github.com/wunderlist/render/pull/1#discussion_r36511203","pull_request_url":"https://api.github.com/repos/wunderlist/render/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/wunderlist/render/pulls/comments/36511203"},"html":{"href":"https://github.com/wunderlist/render/pull/1#discussion_r36511203"},"pull_request":{"href":"https://api.github.com/repos/wunderlist/render/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/wunderlist/render/pulls/1","id":41880228,"html_url":"https://github.com/wunderlist/render/pull/1","diff_url":"https://github.com/wunderlist/render/pull/1.diff","patch_url":"https://github.com/wunderlist/render/pull/1.patch","issue_url":"https://api.github.com/repos/wunderlist/render/issues/1","number":1,"state":"open","locked":false,"title":"Store the build command in the manifest.json","user":{"login":"nathan-ms","id":13001334,"avatar_url":"https://avatars.githubusercontent.com/u/13001334?v=3","gravatar_id":"","url":"https://api.github.com/users/nathan-ms","html_url":"https://github.com/nathan-ms","followers_url":"https://api.github.com/users/nathan-ms/followers","following_url":"https://api.github.com/users/nathan-ms/following{/other_user}","gists_url":"https://api.github.com/users/nathan-ms/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-ms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-ms/subscriptions","organizations_url":"https://api.github.com/users/nathan-ms/orgs","repos_url":"https://api.github.com/users/nathan-ms/repos","events_url":"https://api.github.com/users/nathan-ms/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-ms/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-07T10:50:43Z","updated_at":"2015-08-07T11:47:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2dabcd9cf0d28d3dbdcc55a63a9b27ab10f34b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wunderlist/render/pulls/1/commits","review_comments_url":"https://api.github.com/repos/wunderlist/render/pulls/1/comments","review_comment_url":"https://api.github.com/repos/wunderlist/render/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wunderlist/render/issues/1/comments","statuses_url":"https://api.github.com/repos/wunderlist/render/statuses/d4f447736fd727fff5f02202b68f4145b35822f0","head":{"label":"wunderlist:build-from-manifest","ref":"build-from-manifest","sha":"d4f447736fd727fff5f02202b68f4145b35822f0","user":{"login":"wunderlist","id":5122306,"avatar_url":"https://avatars.githubusercontent.com/u/5122306?v=3","gravatar_id":"","url":"https://api.github.com/users/wunderlist","html_url":"https://github.com/wunderlist","followers_url":"https://api.github.com/users/wunderlist/followers","following_url":"https://api.github.com/users/wunderlist/following{/other_user}","gists_url":"https://api.github.com/users/wunderlist/gists{/gist_id}","starred_url":"https://api.github.com/users/wunderlist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wunderlist/subscriptions","organizations_url":"https://api.github.com/users/wunderlist/orgs","repos_url":"https://api.github.com/users/wunderlist/repos","events_url":"https://api.github.com/users/wunderlist/events{/privacy}","received_events_url":"https://api.github.com/users/wunderlist/received_events","type":"Organization","site_admin":false},"repo":{"id":40252684,"name":"render","full_name":"wunderlist/render","owner":{"login":"wunderlist","id":5122306,"avatar_url":"https://avatars.githubusercontent.com/u/5122306?v=3","gravatar_id":"","url":"https://api.github.com/users/wunderlist","html_url":"https://github.com/wunderlist","followers_url":"https://api.github.com/users/wunderlist/followers","following_url":"https://api.github.com/users/wunderlist/following{/other_user}","gists_url":"https://api.github.com/users/wunderlist/gists{/gist_id}","starred_url":"https://api.github.com/users/wunderlist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wunderlist/subscriptions","organizations_url":"https://api.github.com/users/wunderlist/orgs","repos_url":"https://api.github.com/users/wunderlist/repos","events_url":"https://api.github.com/users/wunderlist/events{/privacy}","received_events_url":"https://api.github.com/users/wunderlist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wunderlist/render","description":null,"fork":false,"url":"https://api.github.com/repos/wunderlist/render","forks_url":"https://api.github.com/repos/wunderlist/render/forks","keys_url":"https://api.github.com/repos/wunderlist/render/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wunderlist/render/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wunderlist/render/teams","hooks_url":"https://api.github.com/repos/wunderlist/render/hooks","issue_events_url":"https://api.github.com/repos/wunderlist/render/issues/events{/number}","events_url":"https://api.github.com/repos/wunderlist/render/events","assignees_url":"https://api.github.com/repos/wunderlist/render/assignees{/user}","branches_url":"https://api.github.com/repos/wunderlist/render/branches{/branch}","tags_url":"https://api.github.com/repos/wunderlist/render/tags","blobs_url":"https://api.github.com/repos/wunderlist/render/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wunderlist/render/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wunderlist/render/git/refs{/sha}","trees_url":"https://api.github.com/repos/wunderlist/render/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wunderlist/render/statuses/{sha}","languages_url":"https://api.github.com/repos/wunderlist/render/languages","stargazers_url":"https://api.github.com/repos/wunderlist/render/stargazers","contributors_url":"https://api.github.com/repos/wunderlist/render/contributors","subscribers_url":"https://api.github.com/repos/wunderlist/render/subscribers","subscription_url":"https://api.github.com/repos/wunderlist/render/subscription","commits_url":"https://api.github.com/repos/wunderlist/render/commits{/sha}","git_commits_url":"https://api.github.com/repos/wunderlist/render/git/commits{/sha}","comments_url":"https://api.github.com/repos/wunderlist/render/comments{/number}","issue_comment_url":"https://api.github.com/repos/wunderlist/render/issues/comments{/number}","contents_url":"https://api.github.com/repos/wunderlist/render/contents/{+path}","compare_url":"https://api.github.com/repos/wunderlist/render/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wunderlist/render/merges","archive_url":"https://api.github.com/repos/wunderlist/render/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wunderlist/render/downloads","issues_url":"https://api.github.com/repos/wunderlist/render/issues{/number}","pulls_url":"https://api.github.com/repos/wunderlist/render/pulls{/number}","milestones_url":"https://api.github.com/repos/wunderlist/render/milestones{/number}","notifications_url":"https://api.github.com/repos/wunderlist/render/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wunderlist/render/labels{/name}","releases_url":"https://api.github.com/repos/wunderlist/render/releases{/id}","created_at":"2015-08-05T15:16:39Z","updated_at":"2015-08-05T15:16:48Z","pushed_at":"2015-08-07T10:50:44Z","git_url":"git://github.com/wunderlist/render.git","ssh_url":"git@github.com:wunderlist/render.git","clone_url":"https://github.com/wunderlist/render.git","svn_url":"https://github.com/wunderlist/render","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"wunderlist:master","ref":"master","sha":"5370f2788fe92f38fa8d1bae0cb534c522a75756","user":{"login":"wunderlist","id":5122306,"avatar_url":"https://avatars.githubusercontent.com/u/5122306?v=3","gravatar_id":"","url":"https://api.github.com/users/wunderlist","html_url":"https://github.com/wunderlist","followers_url":"https://api.github.com/users/wunderlist/followers","following_url":"https://api.github.com/users/wunderlist/following{/other_user}","gists_url":"https://api.github.com/users/wunderlist/gists{/gist_id}","starred_url":"https://api.github.com/users/wunderlist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wunderlist/subscriptions","organizations_url":"https://api.github.com/users/wunderlist/orgs","repos_url":"https://api.github.com/users/wunderlist/repos","events_url":"https://api.github.com/users/wunderlist/events{/privacy}","received_events_url":"https://api.github.com/users/wunderlist/received_events","type":"Organization","site_admin":false},"repo":{"id":40252684,"name":"render","full_name":"wunderlist/render","owner":{"login":"wunderlist","id":5122306,"avatar_url":"https://avatars.githubusercontent.com/u/5122306?v=3","gravatar_id":"","url":"https://api.github.com/users/wunderlist","html_url":"https://github.com/wunderlist","followers_url":"https://api.github.com/users/wunderlist/followers","following_url":"https://api.github.com/users/wunderlist/following{/other_user}","gists_url":"https://api.github.com/users/wunderlist/gists{/gist_id}","starred_url":"https://api.github.com/users/wunderlist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wunderlist/subscriptions","organizations_url":"https://api.github.com/users/wunderlist/orgs","repos_url":"https://api.github.com/users/wunderlist/repos","events_url":"https://api.github.com/users/wunderlist/events{/privacy}","received_events_url":"https://api.github.com/users/wunderlist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wunderlist/render","description":null,"fork":false,"url":"https://api.github.com/repos/wunderlist/render","forks_url":"https://api.github.com/repos/wunderlist/render/forks","keys_url":"https://api.github.com/repos/wunderlist/render/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wunderlist/render/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wunderlist/render/teams","hooks_url":"https://api.github.com/repos/wunderlist/render/hooks","issue_events_url":"https://api.github.com/repos/wunderlist/render/issues/events{/number}","events_url":"https://api.github.com/repos/wunderlist/render/events","assignees_url":"https://api.github.com/repos/wunderlist/render/assignees{/user}","branches_url":"https://api.github.com/repos/wunderlist/render/branches{/branch}","tags_url":"https://api.github.com/repos/wunderlist/render/tags","blobs_url":"https://api.github.com/repos/wunderlist/render/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wunderlist/render/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wunderlist/render/git/refs{/sha}","trees_url":"https://api.github.com/repos/wunderlist/render/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wunderlist/render/statuses/{sha}","languages_url":"https://api.github.com/repos/wunderlist/render/languages","stargazers_url":"https://api.github.com/repos/wunderlist/render/stargazers","contributors_url":"https://api.github.com/repos/wunderlist/render/contributors","subscribers_url":"https://api.github.com/repos/wunderlist/render/subscribers","subscription_url":"https://api.github.com/repos/wunderlist/render/subscription","commits_url":"https://api.github.com/repos/wunderlist/render/commits{/sha}","git_commits_url":"https://api.github.com/repos/wunderlist/render/git/commits{/sha}","comments_url":"https://api.github.com/repos/wunderlist/render/comments{/number}","issue_comment_url":"https://api.github.com/repos/wunderlist/render/issues/comments{/number}","contents_url":"https://api.github.com/repos/wunderlist/render/contents/{+path}","compare_url":"https://api.github.com/repos/wunderlist/render/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wunderlist/render/merges","archive_url":"https://api.github.com/repos/wunderlist/render/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wunderlist/render/downloads","issues_url":"https://api.github.com/repos/wunderlist/render/issues{/number}","pulls_url":"https://api.github.com/repos/wunderlist/render/pulls{/number}","milestones_url":"https://api.github.com/repos/wunderlist/render/milestones{/number}","notifications_url":"https://api.github.com/repos/wunderlist/render/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wunderlist/render/labels{/name}","releases_url":"https://api.github.com/repos/wunderlist/render/releases{/id}","created_at":"2015-08-05T15:16:39Z","updated_at":"2015-08-05T15:16:48Z","pushed_at":"2015-08-07T10:50:44Z","git_url":"git://github.com/wunderlist/render.git","ssh_url":"git@github.com:wunderlist/render.git","clone_url":"https://github.com/wunderlist/render.git","svn_url":"https://github.com/wunderlist/render","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wunderlist/render/pulls/1"},"html":{"href":"https://github.com/wunderlist/render/pull/1"},"issue":{"href":"https://api.github.com/repos/wunderlist/render/issues/1"},"comments":{"href":"https://api.github.com/repos/wunderlist/render/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/wunderlist/render/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/wunderlist/render/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wunderlist/render/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/wunderlist/render/statuses/d4f447736fd727fff5f02202b68f4145b35822f0"}}}}