{"action":"closed","number":1366,"pull_request":{"url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/1366","id":16211302,"html_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/1366","diff_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/1366.diff","patch_url":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/1366.patch","issue_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/1366","number":1366,"state":"closed","locked":false,"title":"WPSC_Purchase_Log->is_transaction_completed() should check against array of filtered completed order statuses","user":{"login":"benhuson","id":765285,"avatar_url":"https://avatars.githubusercontent.com/u/765285?v=3","gravatar_id":"","url":"https://api.github.com/users/benhuson","html_url":"https://github.com/benhuson","followers_url":"https://api.github.com/users/benhuson/followers","following_url":"https://api.github.com/users/benhuson/following{/other_user}","gists_url":"https://api.github.com/users/benhuson/gists{/gist_id}","starred_url":"https://api.github.com/users/benhuson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhuson/subscriptions","organizations_url":"https://api.github.com/users/benhuson/orgs","repos_url":"https://api.github.com/users/benhuson/repos","events_url":"https://api.github.com/users/benhuson/events{/privacy}","received_events_url":"https://api.github.com/users/benhuson/received_events","type":"User","site_admin":false},"body":"Fix for #1360\r\n\r\nNot sure if this is the best approach.\r\n\r\nBoth methods seem to do a similar job, but one is static and once is not.\r\n\r\nEither way, if one method is deprecated the other will need to alias the remaining method.\r\n\r\nI have taken a punt that the more recent method is the one which should be used to check order status - the naming of the method is more descriptive anyway.\r\n\r\nI guess is_transaction_completed() could stay as there may be checks in future that require testing if the order status is complete and another condition.\r\n\r\nBen","created_at":"2014-05-22T10:20:07Z","updated_at":"2015-06-06T20:35:07Z","closed_at":"2015-06-06T20:35:07Z","merged_at":"2015-06-06T20:35:07Z","merge_commit_sha":"da9059533485d97be9fb9980c7a0ebb03f2ef55f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/1366/commits","review_comments_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/1366/comments","review_comment_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/1366/comments","statuses_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/statuses/26475fa9e5241de1cd10ff2f854293228583f433","head":{"label":"benhuson:is_transaction_completed_filter","ref":"is_transaction_completed_filter","sha":"26475fa9e5241de1cd10ff2f854293228583f433","user":{"login":"benhuson","id":765285,"avatar_url":"https://avatars.githubusercontent.com/u/765285?v=3","gravatar_id":"","url":"https://api.github.com/users/benhuson","html_url":"https://github.com/benhuson","followers_url":"https://api.github.com/users/benhuson/followers","following_url":"https://api.github.com/users/benhuson/following{/other_user}","gists_url":"https://api.github.com/users/benhuson/gists{/gist_id}","starred_url":"https://api.github.com/users/benhuson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhuson/subscriptions","organizations_url":"https://api.github.com/users/benhuson/orgs","repos_url":"https://api.github.com/users/benhuson/repos","events_url":"https://api.github.com/users/benhuson/events{/privacy}","received_events_url":"https://api.github.com/users/benhuson/received_events","type":"User","site_admin":false},"repo":{"id":7271654,"name":"WP-e-Commerce","full_name":"benhuson/WP-e-Commerce","owner":{"login":"benhuson","id":765285,"avatar_url":"https://avatars.githubusercontent.com/u/765285?v=3","gravatar_id":"","url":"https://api.github.com/users/benhuson","html_url":"https://github.com/benhuson","followers_url":"https://api.github.com/users/benhuson/followers","following_url":"https://api.github.com/users/benhuson/following{/other_user}","gists_url":"https://api.github.com/users/benhuson/gists{/gist_id}","starred_url":"https://api.github.com/users/benhuson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benhuson/subscriptions","organizations_url":"https://api.github.com/users/benhuson/orgs","repos_url":"https://api.github.com/users/benhuson/repos","events_url":"https://api.github.com/users/benhuson/events{/privacy}","received_events_url":"https://api.github.com/users/benhuson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benhuson/WP-e-Commerce","description":"WP e-Commerce plugin - The most popular e-Commerce solution for WordPress sites.","fork":true,"url":"https://api.github.com/repos/benhuson/WP-e-Commerce","forks_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/forks","keys_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/teams","hooks_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/hooks","issue_events_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/issues/events{/number}","events_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/events","assignees_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/assignees{/user}","branches_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/branches{/branch}","tags_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/tags","blobs_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/statuses/{sha}","languages_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/languages","stargazers_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/stargazers","contributors_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/contributors","subscribers_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/subscribers","subscription_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/subscription","commits_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/contents/{+path}","compare_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/merges","archive_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/downloads","issues_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/issues{/number}","pulls_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/pulls{/number}","milestones_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/milestones{/number}","notifications_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/labels{/name}","releases_url":"https://api.github.com/repos/benhuson/WP-e-Commerce/releases{/id}","created_at":"2012-12-21T09:52:21Z","updated_at":"2015-01-27T11:07:09Z","pushed_at":"2015-06-05T19:42:44Z","git_url":"git://github.com/benhuson/WP-e-Commerce.git","ssh_url":"git@github.com:benhuson/WP-e-Commerce.git","clone_url":"https://github.com/benhuson/WP-e-Commerce.git","svn_url":"https://github.com/benhuson/WP-e-Commerce","homepage":"http://getshopped.org","size":16189,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wp-e-commerce:master","ref":"master","sha":"99fc601ddda1afb0a3a26a71166a13dd735d74f4","user":{"login":"wp-e-commerce","id":2290601,"avatar_url":"https://avatars.githubusercontent.com/u/2290601?v=3","gravatar_id":"","url":"https://api.github.com/users/wp-e-commerce","html_url":"https://github.com/wp-e-commerce","followers_url":"https://api.github.com/users/wp-e-commerce/followers","following_url":"https://api.github.com/users/wp-e-commerce/following{/other_user}","gists_url":"https://api.github.com/users/wp-e-commerce/gists{/gist_id}","starred_url":"https://api.github.com/users/wp-e-commerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wp-e-commerce/subscriptions","organizations_url":"https://api.github.com/users/wp-e-commerce/orgs","repos_url":"https://api.github.com/users/wp-e-commerce/repos","events_url":"https://api.github.com/users/wp-e-commerce/events{/privacy}","received_events_url":"https://api.github.com/users/wp-e-commerce/received_events","type":"Organization","site_admin":false},"repo":{"id":2052629,"name":"WP-e-Commerce","full_name":"wp-e-commerce/WP-e-Commerce","owner":{"login":"wp-e-commerce","id":2290601,"avatar_url":"https://avatars.githubusercontent.com/u/2290601?v=3","gravatar_id":"","url":"https://api.github.com/users/wp-e-commerce","html_url":"https://github.com/wp-e-commerce","followers_url":"https://api.github.com/users/wp-e-commerce/followers","following_url":"https://api.github.com/users/wp-e-commerce/following{/other_user}","gists_url":"https://api.github.com/users/wp-e-commerce/gists{/gist_id}","starred_url":"https://api.github.com/users/wp-e-commerce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wp-e-commerce/subscriptions","organizations_url":"https://api.github.com/users/wp-e-commerce/orgs","repos_url":"https://api.github.com/users/wp-e-commerce/repos","events_url":"https://api.github.com/users/wp-e-commerce/events{/privacy}","received_events_url":"https://api.github.com/users/wp-e-commerce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wp-e-commerce/WP-e-Commerce","description":"WP eCommerce - The most popular independent eCommerce platform for WordPress","fork":false,"url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce","forks_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/forks","keys_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/teams","hooks_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/hooks","issue_events_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/events{/number}","events_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/events","assignees_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/assignees{/user}","branches_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/branches{/branch}","tags_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/tags","blobs_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/refs{/sha}","trees_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/statuses/{sha}","languages_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/languages","stargazers_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/stargazers","contributors_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/contributors","subscribers_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/subscribers","subscription_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/subscription","commits_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/commits{/sha}","git_commits_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/git/commits{/sha}","comments_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/comments{/number}","issue_comment_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/comments{/number}","contents_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/contents/{+path}","compare_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/merges","archive_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/downloads","issues_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues{/number}","pulls_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls{/number}","milestones_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/milestones{/number}","notifications_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/labels{/name}","releases_url":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/releases{/id}","created_at":"2011-07-15T10:54:16Z","updated_at":"2015-06-05T06:21:00Z","pushed_at":"2015-06-06T20:35:07Z","git_url":"git://github.com/wp-e-commerce/WP-e-Commerce.git","ssh_url":"git@github.com:wp-e-commerce/WP-e-Commerce.git","clone_url":"https://github.com/wp-e-commerce/WP-e-Commerce.git","svn_url":"https://github.com/wp-e-commerce/WP-e-Commerce","homepage":"https://wpecommerce.org","size":28835,"stargazers_count":162,"watchers_count":162,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":177,"mirror_url":null,"open_issues_count":394,"forks":177,"open_issues":394,"watchers":162,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/1366"},"html":{"href":"https://github.com/wp-e-commerce/WP-e-Commerce/pull/1366"},"issue":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/1366"},"comments":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/issues/1366/comments"},"review_comments":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/1366/comments"},"review_comment":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/pulls/1366/commits"},"statuses":{"href":"https://api.github.com/repos/wp-e-commerce/WP-e-Commerce/statuses/26475fa9e5241de1cd10ff2f854293228583f433"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"JustinSainton","id":1168754,"avatar_url":"https://avatars.githubusercontent.com/u/1168754?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinSainton","html_url":"https://github.com/JustinSainton","followers_url":"https://api.github.com/users/JustinSainton/followers","following_url":"https://api.github.com/users/JustinSainton/following{/other_user}","gists_url":"https://api.github.com/users/JustinSainton/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinSainton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinSainton/subscriptions","organizations_url":"https://api.github.com/users/JustinSainton/orgs","repos_url":"https://api.github.com/users/JustinSainton/repos","events_url":"https://api.github.com/users/JustinSainton/events{/privacy}","received_events_url":"https://api.github.com/users/JustinSainton/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}