{"action":"created","comment":{"url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/comments/42966504","id":42966504,"diff_hunk":"@@ -33,7 +33,7 @@\n \t</modules>\r\n \t\r\n \t<properties>\r\n-\t\t<openMRSVersion>1.12.0-SNAPSHOT</openMRSVersion>\r\n+\t\t<openMRSVersion>1.11.3</openMRSVersion>\r","path":"pom.xml","position":5,"original_position":5,"commit_id":"b62d59ecc8001a357a1df5105b7351af4b9063b6","original_commit_id":"b62d59ecc8001a357a1df5105b7351af4b9063b6","user":{"login":"rcrichton","id":266576,"avatar_url":"https://avatars.githubusercontent.com/u/266576?v=3","gravatar_id":"","url":"https://api.github.com/users/rcrichton","html_url":"https://github.com/rcrichton","followers_url":"https://api.github.com/users/rcrichton/followers","following_url":"https://api.github.com/users/rcrichton/following{/other_user}","gists_url":"https://api.github.com/users/rcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/rcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcrichton/subscriptions","organizations_url":"https://api.github.com/users/rcrichton/orgs","repos_url":"https://api.github.com/users/rcrichton/repos","events_url":"https://api.github.com/users/rcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/rcrichton/received_events","type":"User","site_admin":false},"body":"I think that we need to keep the 1.12 snapshot as some of the optimisations are only in those version of OpenMRS.","created_at":"2015-10-26T08:01:28Z","updated_at":"2015-10-26T08:01:28Z","html_url":"https://github.com/jembi/openmrs-module-shr-contenthandler/pull/23#discussion_r42966504","pull_request_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/comments/42966504"},"html":{"href":"https://github.com/jembi/openmrs-module-shr-contenthandler/pull/23#discussion_r42966504"},"pull_request":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23","id":48107194,"html_url":"https://github.com/jembi/openmrs-module-shr-contenthandler/pull/23","diff_url":"https://github.com/jembi/openmrs-module-shr-contenthandler/pull/23.diff","patch_url":"https://github.com/jembi/openmrs-module-shr-contenthandler/pull/23.patch","issue_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/23","number":23,"state":"open","locked":false,"title":"Obs are stored as char array however the read method checks for String.","user":{"login":"justin-fyfe","id":8038439,"avatar_url":"https://avatars.githubusercontent.com/u/8038439?v=3","gravatar_id":"","url":"https://api.github.com/users/justin-fyfe","html_url":"https://github.com/justin-fyfe","followers_url":"https://api.github.com/users/justin-fyfe/followers","following_url":"https://api.github.com/users/justin-fyfe/following{/other_user}","gists_url":"https://api.github.com/users/justin-fyfe/gists{/gist_id}","starred_url":"https://api.github.com/users/justin-fyfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justin-fyfe/subscriptions","organizations_url":"https://api.github.com/users/justin-fyfe/orgs","repos_url":"https://api.github.com/users/justin-fyfe/repos","events_url":"https://api.github.com/users/justin-fyfe/events{/privacy}","received_events_url":"https://api.github.com/users/justin-fyfe/received_events","type":"User","site_admin":false},"body":"I've updated the read method to use char array as the saveObs method uses char array..","created_at":"2015-10-19T18:22:41Z","updated_at":"2015-10-26T08:01:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6c5c8efd943a22f495cbca92d6b1d666d75ed6a6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23/commits","review_comments_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23/comments","review_comment_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/23/comments","statuses_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/statuses/b62d59ecc8001a357a1df5105b7351af4b9063b6","head":{"label":"jembi:bug/obshandler_wrong_type","ref":"bug/obshandler_wrong_type","sha":"b62d59ecc8001a357a1df5105b7351af4b9063b6","user":{"login":"jembi","id":1931511,"avatar_url":"https://avatars.githubusercontent.com/u/1931511?v=3","gravatar_id":"","url":"https://api.github.com/users/jembi","html_url":"https://github.com/jembi","followers_url":"https://api.github.com/users/jembi/followers","following_url":"https://api.github.com/users/jembi/following{/other_user}","gists_url":"https://api.github.com/users/jembi/gists{/gist_id}","starred_url":"https://api.github.com/users/jembi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jembi/subscriptions","organizations_url":"https://api.github.com/users/jembi/orgs","repos_url":"https://api.github.com/users/jembi/repos","events_url":"https://api.github.com/users/jembi/events{/privacy}","received_events_url":"https://api.github.com/users/jembi/received_events","type":"Organization","site_admin":false},"repo":{"id":13648347,"name":"openmrs-module-shr-contenthandler","full_name":"jembi/openmrs-module-shr-contenthandler","owner":{"login":"jembi","id":1931511,"avatar_url":"https://avatars.githubusercontent.com/u/1931511?v=3","gravatar_id":"","url":"https://api.github.com/users/jembi","html_url":"https://github.com/jembi","followers_url":"https://api.github.com/users/jembi/followers","following_url":"https://api.github.com/users/jembi/following{/other_user}","gists_url":"https://api.github.com/users/jembi/gists{/gist_id}","starred_url":"https://api.github.com/users/jembi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jembi/subscriptions","organizations_url":"https://api.github.com/users/jembi/orgs","repos_url":"https://api.github.com/users/jembi/repos","events_url":"https://api.github.com/users/jembi/events{/privacy}","received_events_url":"https://api.github.com/users/jembi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jembi/openmrs-module-shr-contenthandler","description":"Provides interfaces and services for dynamically linking content processors with particular content types","fork":false,"url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler","forks_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/forks","keys_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/teams","hooks_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/hooks","issue_events_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/events{/number}","events_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/events","assignees_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/assignees{/user}","branches_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/branches{/branch}","tags_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/tags","blobs_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/refs{/sha}","trees_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/statuses/{sha}","languages_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/languages","stargazers_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/stargazers","contributors_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/contributors","subscribers_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/subscribers","subscription_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/subscription","commits_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/commits{/sha}","git_commits_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/commits{/sha}","comments_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/comments{/number}","issue_comment_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/comments{/number}","contents_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/contents/{+path}","compare_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/merges","archive_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/downloads","issues_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues{/number}","pulls_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls{/number}","milestones_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/milestones{/number}","notifications_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/labels{/name}","releases_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/releases{/id}","created_at":"2013-10-17T12:31:08Z","updated_at":"2015-03-05T09:44:26Z","pushed_at":"2015-10-19T18:22:42Z","git_url":"git://github.com/jembi/openmrs-module-shr-contenthandler.git","ssh_url":"git@github.com:jembi/openmrs-module-shr-contenthandler.git","clone_url":"https://github.com/jembi/openmrs-module-shr-contenthandler.git","svn_url":"https://github.com/jembi/openmrs-module-shr-contenthandler","homepage":"","size":508,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"jembi:master","ref":"master","sha":"672c3645799cc9e3876298d624e2aa3b7f67d5ef","user":{"login":"jembi","id":1931511,"avatar_url":"https://avatars.githubusercontent.com/u/1931511?v=3","gravatar_id":"","url":"https://api.github.com/users/jembi","html_url":"https://github.com/jembi","followers_url":"https://api.github.com/users/jembi/followers","following_url":"https://api.github.com/users/jembi/following{/other_user}","gists_url":"https://api.github.com/users/jembi/gists{/gist_id}","starred_url":"https://api.github.com/users/jembi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jembi/subscriptions","organizations_url":"https://api.github.com/users/jembi/orgs","repos_url":"https://api.github.com/users/jembi/repos","events_url":"https://api.github.com/users/jembi/events{/privacy}","received_events_url":"https://api.github.com/users/jembi/received_events","type":"Organization","site_admin":false},"repo":{"id":13648347,"name":"openmrs-module-shr-contenthandler","full_name":"jembi/openmrs-module-shr-contenthandler","owner":{"login":"jembi","id":1931511,"avatar_url":"https://avatars.githubusercontent.com/u/1931511?v=3","gravatar_id":"","url":"https://api.github.com/users/jembi","html_url":"https://github.com/jembi","followers_url":"https://api.github.com/users/jembi/followers","following_url":"https://api.github.com/users/jembi/following{/other_user}","gists_url":"https://api.github.com/users/jembi/gists{/gist_id}","starred_url":"https://api.github.com/users/jembi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jembi/subscriptions","organizations_url":"https://api.github.com/users/jembi/orgs","repos_url":"https://api.github.com/users/jembi/repos","events_url":"https://api.github.com/users/jembi/events{/privacy}","received_events_url":"https://api.github.com/users/jembi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jembi/openmrs-module-shr-contenthandler","description":"Provides interfaces and services for dynamically linking content processors with particular content types","fork":false,"url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler","forks_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/forks","keys_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/teams","hooks_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/hooks","issue_events_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/events{/number}","events_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/events","assignees_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/assignees{/user}","branches_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/branches{/branch}","tags_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/tags","blobs_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/refs{/sha}","trees_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/statuses/{sha}","languages_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/languages","stargazers_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/stargazers","contributors_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/contributors","subscribers_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/subscribers","subscription_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/subscription","commits_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/commits{/sha}","git_commits_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/git/commits{/sha}","comments_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/comments{/number}","issue_comment_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/comments{/number}","contents_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/contents/{+path}","compare_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/merges","archive_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/downloads","issues_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues{/number}","pulls_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls{/number}","milestones_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/milestones{/number}","notifications_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/labels{/name}","releases_url":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/releases{/id}","created_at":"2013-10-17T12:31:08Z","updated_at":"2015-03-05T09:44:26Z","pushed_at":"2015-10-19T18:22:42Z","git_url":"git://github.com/jembi/openmrs-module-shr-contenthandler.git","ssh_url":"git@github.com:jembi/openmrs-module-shr-contenthandler.git","clone_url":"https://github.com/jembi/openmrs-module-shr-contenthandler.git","svn_url":"https://github.com/jembi/openmrs-module-shr-contenthandler","homepage":"","size":508,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":4,"forks":0,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23"},"html":{"href":"https://github.com/jembi/openmrs-module-shr-contenthandler/pull/23"},"issue":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/23"},"comments":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/jembi/openmrs-module-shr-contenthandler/statuses/b62d59ecc8001a357a1df5105b7351af4b9063b6"}}}}