{"action":"closed","number":973,"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform/pulls/973","id":29291094,"html_url":"https://github.com/hashicorp/terraform/pull/973","diff_url":"https://github.com/hashicorp/terraform/pull/973.diff","patch_url":"https://github.com/hashicorp/terraform/pull/973.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform/issues/973","number":973,"state":"closed","locked":false,"title":"Make Google Instance disk attribute all ForceNew. Fix #608.","user":{"login":"sparkprime","id":168158,"avatar_url":"https://avatars.githubusercontent.com/u/168158?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkprime","html_url":"https://github.com/sparkprime","followers_url":"https://api.github.com/users/sparkprime/followers","following_url":"https://api.github.com/users/sparkprime/following{/other_user}","gists_url":"https://api.github.com/users/sparkprime/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkprime/subscriptions","organizations_url":"https://api.github.com/users/sparkprime/orgs","repos_url":"https://api.github.com/users/sparkprime/repos","events_url":"https://api.github.com/users/sparkprime/events{/privacy}","received_events_url":"https://api.github.com/users/sparkprime/received_events","type":"User","site_admin":false},"body":"There is no code in Update to handle these cases.  It's nontrivial to implement updating disks because of limitations of Terraform's model (first element of the list is special).  We need to discuss the best way to move forward but in the short term marking them all as ForceNew seems reasonable.","created_at":"2015-02-13T19:21:01Z","updated_at":"2015-02-13T19:32:38Z","closed_at":"2015-02-13T19:32:38Z","merged_at":"2015-02-13T19:32:38Z","merge_commit_sha":"625c3ad12dabc053cd15b28ee343bb75a6efae51","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform/pulls/973/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform/pulls/973/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hashicorp/terraform/issues/973/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/b7f5f491e242c2e625c402c833ed867e070bd7ee","head":{"label":"sparkprime:forcenew_disk","ref":"forcenew_disk","sha":"b7f5f491e242c2e625c402c833ed867e070bd7ee","user":{"login":"sparkprime","id":168158,"avatar_url":"https://avatars.githubusercontent.com/u/168158?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkprime","html_url":"https://github.com/sparkprime","followers_url":"https://api.github.com/users/sparkprime/followers","following_url":"https://api.github.com/users/sparkprime/following{/other_user}","gists_url":"https://api.github.com/users/sparkprime/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkprime/subscriptions","organizations_url":"https://api.github.com/users/sparkprime/orgs","repos_url":"https://api.github.com/users/sparkprime/repos","events_url":"https://api.github.com/users/sparkprime/events{/privacy}","received_events_url":"https://api.github.com/users/sparkprime/received_events","type":"User","site_admin":false},"repo":{"id":26650581,"name":"terraform","full_name":"sparkprime/terraform","owner":{"login":"sparkprime","id":168158,"avatar_url":"https://avatars.githubusercontent.com/u/168158?v=3","gravatar_id":"","url":"https://api.github.com/users/sparkprime","html_url":"https://github.com/sparkprime","followers_url":"https://api.github.com/users/sparkprime/followers","following_url":"https://api.github.com/users/sparkprime/following{/other_user}","gists_url":"https://api.github.com/users/sparkprime/gists{/gist_id}","starred_url":"https://api.github.com/users/sparkprime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sparkprime/subscriptions","organizations_url":"https://api.github.com/users/sparkprime/orgs","repos_url":"https://api.github.com/users/sparkprime/repos","events_url":"https://api.github.com/users/sparkprime/events{/privacy}","received_events_url":"https://api.github.com/users/sparkprime/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sparkprime/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":true,"url":"https://api.github.com/repos/sparkprime/terraform","forks_url":"https://api.github.com/repos/sparkprime/terraform/forks","keys_url":"https://api.github.com/repos/sparkprime/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sparkprime/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sparkprime/terraform/teams","hooks_url":"https://api.github.com/repos/sparkprime/terraform/hooks","issue_events_url":"https://api.github.com/repos/sparkprime/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/sparkprime/terraform/events","assignees_url":"https://api.github.com/repos/sparkprime/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/sparkprime/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/sparkprime/terraform/tags","blobs_url":"https://api.github.com/repos/sparkprime/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sparkprime/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sparkprime/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/sparkprime/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sparkprime/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/sparkprime/terraform/languages","stargazers_url":"https://api.github.com/repos/sparkprime/terraform/stargazers","contributors_url":"https://api.github.com/repos/sparkprime/terraform/contributors","subscribers_url":"https://api.github.com/repos/sparkprime/terraform/subscribers","subscription_url":"https://api.github.com/repos/sparkprime/terraform/subscription","commits_url":"https://api.github.com/repos/sparkprime/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/sparkprime/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/sparkprime/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/sparkprime/terraform/issues/comments/{number}","contents_url":"https://api.github.com/repos/sparkprime/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/sparkprime/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sparkprime/terraform/merges","archive_url":"https://api.github.com/repos/sparkprime/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sparkprime/terraform/downloads","issues_url":"https://api.github.com/repos/sparkprime/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/sparkprime/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/sparkprime/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/sparkprime/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sparkprime/terraform/labels{/name}","releases_url":"https://api.github.com/repos/sparkprime/terraform/releases{/id}","created_at":"2014-11-14T17:54:55Z","updated_at":"2015-02-11T05:36:56Z","pushed_at":"2015-02-13T19:23:58Z","git_url":"git://github.com/sparkprime/terraform.git","ssh_url":"git@github.com:sparkprime/terraform.git","clone_url":"https://github.com/sparkprime/terraform.git","svn_url":"https://github.com/sparkprime/terraform","homepage":"http://www.terraform.io","size":19005,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"c0819181708840e96cabe0d0fff2f3fac4f18449","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":17728164,"name":"terraform","full_name":"hashicorp/terraform","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars.githubusercontent.com/u/761456?v=3","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform","description":"Terraform is a tool for building, changing, and combining infrastructure safely and efficiently.","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform","forks_url":"https://api.github.com/repos/hashicorp/terraform/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform/issues/comments/{number}","contents_url":"https://api.github.com/repos/hashicorp/terraform/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform/releases{/id}","created_at":"2014-03-13T22:25:48Z","updated_at":"2015-02-13T19:08:35Z","pushed_at":"2015-02-13T19:32:38Z","git_url":"git://github.com/hashicorp/terraform.git","ssh_url":"git@github.com:hashicorp/terraform.git","clone_url":"https://github.com/hashicorp/terraform.git","svn_url":"https://github.com/hashicorp/terraform","homepage":"http://www.terraform.io","size":30037,"stargazers_count":1976,"watchers_count":1976,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":268,"mirror_url":null,"open_issues_count":228,"forks":268,"open_issues":228,"watchers":1976,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/973"},"html":{"href":"https://github.com/hashicorp/terraform/pull/973"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/973"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform/issues/973/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/973/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform/pulls/973/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform/statuses/b7f5f491e242c2e625c402c833ed867e070bd7ee"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"phinze","id":37534,"avatar_url":"https://avatars.githubusercontent.com/u/37534?v=3","gravatar_id":"","url":"https://api.github.com/users/phinze","html_url":"https://github.com/phinze","followers_url":"https://api.github.com/users/phinze/followers","following_url":"https://api.github.com/users/phinze/following{/other_user}","gists_url":"https://api.github.com/users/phinze/gists{/gist_id}","starred_url":"https://api.github.com/users/phinze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phinze/subscriptions","organizations_url":"https://api.github.com/users/phinze/orgs","repos_url":"https://api.github.com/users/phinze/repos","events_url":"https://api.github.com/users/phinze/events{/privacy}","received_events_url":"https://api.github.com/users/phinze/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":0,"changed_files":1}}