{"action":"created","issue":{"url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1715","labels_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1715/labels{/name}","comments_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1715/comments","events_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1715/events","html_url":"https://github.com/learning-unlimited/ESP-Website/pull/1715","id":90444330,"number":1715,"title":"Remove catalog sort by _num_students for performance reasons","user":{"login":"mgersh","id":2846855,"avatar_url":"https://avatars.githubusercontent.com/u/2846855?v=3","gravatar_id":"","url":"https://api.github.com/users/mgersh","html_url":"https://github.com/mgersh","followers_url":"https://api.github.com/users/mgersh/followers","following_url":"https://api.github.com/users/mgersh/following{/other_user}","gists_url":"https://api.github.com/users/mgersh/gists{/gist_id}","starred_url":"https://api.github.com/users/mgersh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgersh/subscriptions","organizations_url":"https://api.github.com/users/mgersh/orgs","repos_url":"https://api.github.com/users/mgersh/repos","events_url":"https://api.github.com/users/mgersh/events{/privacy}","received_events_url":"https://api.github.com/users/mgersh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-23T17:29:05Z","updated_at":"2015-06-23T20:12:33Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/learning-unlimited/ESP-Website/pulls/1715","html_url":"https://github.com/learning-unlimited/ESP-Website/pull/1715","diff_url":"https://github.com/learning-unlimited/ESP-Website/pull/1715.diff","patch_url":"https://github.com/learning-unlimited/ESP-Website/pull/1715.patch"},"body":"This is removing a feature that's still in use, but I think it's a good tradeoff. The catalog query is an abomination, it gets run all the time during FCFS student reg, and removing _num_students from it helps a lot: down from 2000-3300ms to 1100-1300ms on a really big program on my dev server. Having this sorting seems relatively unimportant compared to having FCFS be less slow. If we do remove it, we'd have to edit the tags on the bc and chicago sites (which appear to just be copies of what the default sort order was before #1576 was fixed).\r\n\r\nThoughts?"},"comment":{"url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/comments/114628236","html_url":"https://github.com/learning-unlimited/ESP-Website/pull/1715#issuecomment-114628236","issue_url":"https://api.github.com/repos/learning-unlimited/ESP-Website/issues/1715","id":114628236,"user":{"login":"benjaminjkraft","id":111238,"avatar_url":"https://avatars.githubusercontent.com/u/111238?v=3","gravatar_id":"","url":"https://api.github.com/users/benjaminjkraft","html_url":"https://github.com/benjaminjkraft","followers_url":"https://api.github.com/users/benjaminjkraft/followers","following_url":"https://api.github.com/users/benjaminjkraft/following{/other_user}","gists_url":"https://api.github.com/users/benjaminjkraft/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminjkraft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminjkraft/subscriptions","organizations_url":"https://api.github.com/users/benjaminjkraft/orgs","repos_url":"https://api.github.com/users/benjaminjkraft/repos","events_url":"https://api.github.com/users/benjaminjkraft/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminjkraft/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T20:12:33Z","updated_at":"2015-06-23T20:12:33Z","body":"Yeah, probably if we wanted to do that the sort would end up subtracting from total capacity or something.  But in any case, the way it is now is not that useful, so any alternate functionality can be a separate thing."}}