{"action":"created","issue":{"url":"https://api.github.com/repos/edx/edx-platform/issues/7595","labels_url":"https://api.github.com/repos/edx/edx-platform/issues/7595/labels{/name}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/7595/comments","events_url":"https://api.github.com/repos/edx/edx-platform/issues/7595/events","html_url":"https://github.com/edx/edx-platform/pull/7595","id":66268584,"number":7595,"title":"Complete Printing Cleanup","user":{"login":"jolyonb","id":6232546,"avatar_url":"https://avatars.githubusercontent.com/u/6232546?v=3","gravatar_id":"","url":"https://api.github.com/users/jolyonb","html_url":"https://github.com/jolyonb","followers_url":"https://api.github.com/users/jolyonb/followers","following_url":"https://api.github.com/users/jolyonb/following{/other_user}","gists_url":"https://api.github.com/users/jolyonb/gists{/gist_id}","starred_url":"https://api.github.com/users/jolyonb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jolyonb/subscriptions","organizations_url":"https://api.github.com/users/jolyonb/orgs","repos_url":"https://api.github.com/users/jolyonb/repos","events_url":"https://api.github.com/users/jolyonb/events{/privacy}","received_events_url":"https://api.github.com/users/jolyonb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/edx/edx-platform/labels/engineering%20review","name":"engineering review","color":"c7def8"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-04-04T03:20:54Z","updated_at":"2015-05-13T14:01:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/7595","html_url":"https://github.com/edx/edx-platform/pull/7595","diff_url":"https://github.com/edx/edx-platform/pull/7595.diff","patch_url":"https://github.com/edx/edx-platform/pull/7595.patch"},"body":"This PR applies a number of changes to the print media CSS.\r\n\r\nBeing able to print nicely from edX is important for a number of reasons, including making PDFs for students to view offline, and for a variety of accessibility issues. Currently, printing in the edX platform is unusable. For example, here is a print to pdf of a page from MITx: http://web.mit.edu/jolyon/Public/printing_present.pdf\r\n\r\nThis pull request modifies a number of things in the print media CSS to make this beautiful. I'll jump straight to the punchline. Here is what that same page looks like with this pull request in place: http://web.mit.edu/jolyon/Public/printing_with_changes.pdf\r\n\r\n(Two other pull requests are also in place for this second pdf; https://github.com/edx/edx-platform/pull/7592 and https://github.com/edx/edx-platform/pull/7591)\r\n\r\nAll of the changes included in this PR modify print media CSS *only*. I'll go through and annotate each change individually, so that you can see what it is doing. Most of the changes are hiding things; a few of them are changing borders and whitespace."},"comment":{"url":"https://api.github.com/repos/edx/edx-platform/issues/comments/101672929","html_url":"https://github.com/edx/edx-platform/pull/7595#issuecomment-101672929","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/7595","id":101672929,"user":{"login":"marcotuts","id":2023680,"avatar_url":"https://avatars.githubusercontent.com/u/2023680?v=3","gravatar_id":"","url":"https://api.github.com/users/marcotuts","html_url":"https://github.com/marcotuts","followers_url":"https://api.github.com/users/marcotuts/followers","following_url":"https://api.github.com/users/marcotuts/following{/other_user}","gists_url":"https://api.github.com/users/marcotuts/gists{/gist_id}","starred_url":"https://api.github.com/users/marcotuts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcotuts/subscriptions","organizations_url":"https://api.github.com/users/marcotuts/orgs","repos_url":"https://api.github.com/users/marcotuts/repos","events_url":"https://api.github.com/users/marcotuts/events{/privacy}","received_events_url":"https://api.github.com/users/marcotuts/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T14:01:21Z","updated_at":"2015-05-13T14:01:21Z","body":"@jolyonb - I'll try and rebuild the sandbox using this new rebased PR. I ran into issues trying to provision a sandbox earlier this morning on the PR before it was rebased. I am still seeing 2 failing tests (down from 50!) so I'll try and kick off tests again to see if it is a flaky test. (It seems to be a Youtube test, so it isn't related to this PR as far as I can tell.) \r\n\r\nThanks for flagging that other PR, but as Sarina noted, this will go through the standard OSPR process. I may not wind up being the reviewer at that point, it depends. \r\n\r\ntest this please"}}