{"action":"created","issue":{"url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4","labels_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4/comments","events_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4/events","html_url":"https://github.com/ssj71/OSC2MIDI/pull/4","id":86719713,"number":4,"title":"OSX fixes","user":{"login":"agraef","id":2853977,"avatar_url":"https://avatars.githubusercontent.com/u/2853977?v=3","gravatar_id":"","url":"https://api.github.com/users/agraef","html_url":"https://github.com/agraef","followers_url":"https://api.github.com/users/agraef/followers","following_url":"https://api.github.com/users/agraef/following{/other_user}","gists_url":"https://api.github.com/users/agraef/gists{/gist_id}","starred_url":"https://api.github.com/users/agraef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraef/subscriptions","organizations_url":"https://api.github.com/users/agraef/orgs","repos_url":"https://api.github.com/users/agraef/repos","events_url":"https://api.github.com/users/agraef/events{/privacy}","received_events_url":"https://api.github.com/users/agraef/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-06-09T20:09:42Z","updated_at":"2015-06-12T14:25:11Z","closed_at":"2015-06-10T23:12:49Z","pull_request":{"url":"https://api.github.com/repos/ssj71/OSC2MIDI/pulls/4","html_url":"https://github.com/ssj71/OSC2MIDI/pull/4","diff_url":"https://github.com/ssj71/OSC2MIDI/pull/4.diff","patch_url":"https://github.com/ssj71/OSC2MIDI/pull/4.patch"},"body":"This fixes padding with extra null bytes in osc2midi's MIDI output, which JackOSX/CoreMidi doesn't like. Output MIDI messages are now trimmed to the proper byte count, and invalid MIDI data is ignored.\r\n\r\nFor some reason, the extra bytes don't cause issues on Linux -- maybe the ALSA layer eliminates them when hooking up osc2midi to ALSA MIDI applications via a2jmidid? But on OSX this fix is definitely needed, otherwise MIDI applications may misbehave, or at least spit out warnings about invalid MIDI data. And of course the fix works on Linux, too."},"comment":{"url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/comments/111512029","html_url":"https://github.com/ssj71/OSC2MIDI/pull/4#issuecomment-111512029","issue_url":"https://api.github.com/repos/ssj71/OSC2MIDI/issues/4","id":111512029,"user":{"login":"agraef","id":2853977,"avatar_url":"https://avatars.githubusercontent.com/u/2853977?v=3","gravatar_id":"","url":"https://api.github.com/users/agraef","html_url":"https://github.com/agraef","followers_url":"https://api.github.com/users/agraef/followers","following_url":"https://api.github.com/users/agraef/following{/other_user}","gists_url":"https://api.github.com/users/agraef/gists{/gist_id}","starred_url":"https://api.github.com/users/agraef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agraef/subscriptions","organizations_url":"https://api.github.com/users/agraef/orgs","repos_url":"https://api.github.com/users/agraef/repos","events_url":"https://api.github.com/users/agraef/events{/privacy}","received_events_url":"https://api.github.com/users/agraef/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T14:25:11Z","updated_at":"2015-06-12T14:25:11Z","body":"Criticizing the code of others is what makes github and friends so effective and so much fun. ;-) So don't worry about that.\r\n\r\nI've been doing some more work on the syntax checking, so expect another pull request soon."}}