{"action":"created","issue":{"url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/issues/19","labels_url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/issues/19/comments","events_url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/issues/19/events","html_url":"https://github.com/bueltge/wordpress-multisite-enhancements/pull/19","id":101947591,"number":19,"title":"Added support for wp_site_icon (since WP 4.3)","user":{"login":"JoryHogeveen","id":826148,"avatar_url":"https://avatars.githubusercontent.com/u/826148?v=3","gravatar_id":"","url":"https://api.github.com/users/JoryHogeveen","html_url":"https://github.com/JoryHogeveen","followers_url":"https://api.github.com/users/JoryHogeveen/followers","following_url":"https://api.github.com/users/JoryHogeveen/following{/other_user}","gists_url":"https://api.github.com/users/JoryHogeveen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoryHogeveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoryHogeveen/subscriptions","organizations_url":"https://api.github.com/users/JoryHogeveen/orgs","repos_url":"https://api.github.com/users/JoryHogeveen/repos","events_url":"https://api.github.com/users/JoryHogeveen/events{/privacy}","received_events_url":"https://api.github.com/users/JoryHogeveen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-08-19T17:06:05Z","updated_at":"2015-08-19T18:16:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/pulls/19","html_url":"https://github.com/bueltge/wordpress-multisite-enhancements/pull/19","diff_url":"https://github.com/bueltge/wordpress-multisite-enhancements/pull/19.diff","patch_url":"https://github.com/bueltge/wordpress-multisite-enhancements/pull/19.patch"},"body":"Added support for the new WP Site Icon (added since WP 4.3) in the favicon selections.\r\n\r\nWhen a user has added a custom site icon this icon will override the stylesheet icons and the hook in get_favicon_path.\r\n\r\nWhy also the hook? My thought was that since user actually used this it's safe to say he/she want's to use this icon instead of the theme icon. Feedback welcome!"},"comment":{"url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/issues/comments/132729410","html_url":"https://github.com/bueltge/wordpress-multisite-enhancements/pull/19#issuecomment-132729410","issue_url":"https://api.github.com/repos/bueltge/wordpress-multisite-enhancements/issues/19","id":132729410,"user":{"login":"JoryHogeveen","id":826148,"avatar_url":"https://avatars.githubusercontent.com/u/826148?v=3","gravatar_id":"","url":"https://api.github.com/users/JoryHogeveen","html_url":"https://github.com/JoryHogeveen","followers_url":"https://api.github.com/users/JoryHogeveen/followers","following_url":"https://api.github.com/users/JoryHogeveen/following{/other_user}","gists_url":"https://api.github.com/users/JoryHogeveen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoryHogeveen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoryHogeveen/subscriptions","organizations_url":"https://api.github.com/users/JoryHogeveen/orgs","repos_url":"https://api.github.com/users/JoryHogeveen/repos","events_url":"https://api.github.com/users/JoryHogeveen/events{/privacy}","received_events_url":"https://api.github.com/users/JoryHogeveen/received_events","type":"User","site_admin":false},"created_at":"2015-08-19T18:16:23Z","updated_at":"2015-08-19T18:16:23Z","body":"Hi Frank,\r\n\r\nI think i merge the wrong way. What is do is create a pull request for myself to get your current master branch. Is that correct?\r\n\r\nAlso on your not of the custom hooks. When a user had added a favicon with the new WP functionality this will override alle theme and hook icons.\r\nMy thought on the was since the favicon is manually uploaded this way a user would likely want to see this icon instead of any other, agree?\r\n\r\nThe hook is mostly used for custom themes that add favicon a different way, so that won't be needed anymore when using the WP way since 4.3.\r\nAn option would be to add a \"mandatory\" boolean that will override the WP default icon.\r\n\r\nLet me know!"}}