{"action":"closed","number":486,"pull_request":{"url":"https://api.github.com/repos/mrclay/minify/pulls/486","id":51076354,"html_url":"https://github.com/mrclay/minify/pull/486","diff_url":"https://github.com/mrclay/minify/pull/486.diff","patch_url":"https://github.com/mrclay/minify/pull/486.patch","issue_url":"https://api.github.com/repos/mrclay/minify/issues/486","number":486,"state":"closed","locked":false,"title":"port tests to phpunit","user":{"login":"glensc","id":199095,"avatar_url":"https://avatars.githubusercontent.com/u/199095?v=3","gravatar_id":"","url":"https://api.github.com/users/glensc","html_url":"https://github.com/glensc","followers_url":"https://api.github.com/users/glensc/followers","following_url":"https://api.github.com/users/glensc/following{/other_user}","gists_url":"https://api.github.com/users/glensc/gists{/gist_id}","starred_url":"https://api.github.com/users/glensc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glensc/subscriptions","organizations_url":"https://api.github.com/users/glensc/orgs","repos_url":"https://api.github.com/users/glensc/repos","events_url":"https://api.github.com/users/glensc/events{/privacy}","received_events_url":"https://api.github.com/users/glensc/received_events","type":"User","site_admin":false},"body":"#265: i've ported to phpunit instead of simpletest ,as i'm more familiar with it\r\nhttps://github.com/mrclay/minify/issues/265#issuecomment-157686554\r\n\r\nlet me know what you think, and i continue at least porting tests that don't need browser (probably should list them)\r\n\r\nalso travis integration with running those tests is good idea","created_at":"2015-11-18T12:10:11Z","updated_at":"2015-11-22T19:54:24Z","closed_at":"2015-11-22T19:54:24Z","merged_at":null,"merge_commit_sha":"90b4b2dfbb3f53fbadcbbcdeddde910610573ca1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mrclay/minify/pulls/486/commits","review_comments_url":"https://api.github.com/repos/mrclay/minify/pulls/486/comments","review_comment_url":"https://api.github.com/repos/mrclay/minify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrclay/minify/issues/486/comments","statuses_url":"https://api.github.com/repos/mrclay/minify/statuses/cba869f80f50b48f57d3552cee4c0349b1f02005","head":{"label":"glensc:phpunit-tests","ref":"phpunit-tests","sha":"cba869f80f50b48f57d3552cee4c0349b1f02005","user":{"login":"glensc","id":199095,"avatar_url":"https://avatars.githubusercontent.com/u/199095?v=3","gravatar_id":"","url":"https://api.github.com/users/glensc","html_url":"https://github.com/glensc","followers_url":"https://api.github.com/users/glensc/followers","following_url":"https://api.github.com/users/glensc/following{/other_user}","gists_url":"https://api.github.com/users/glensc/gists{/gist_id}","starred_url":"https://api.github.com/users/glensc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glensc/subscriptions","organizations_url":"https://api.github.com/users/glensc/orgs","repos_url":"https://api.github.com/users/glensc/repos","events_url":"https://api.github.com/users/glensc/events{/privacy}","received_events_url":"https://api.github.com/users/glensc/received_events","type":"User","site_admin":false},"repo":{"id":3868542,"name":"minify","full_name":"glensc/minify","owner":{"login":"glensc","id":199095,"avatar_url":"https://avatars.githubusercontent.com/u/199095?v=3","gravatar_id":"","url":"https://api.github.com/users/glensc","html_url":"https://github.com/glensc","followers_url":"https://api.github.com/users/glensc/followers","following_url":"https://api.github.com/users/glensc/following{/other_user}","gists_url":"https://api.github.com/users/glensc/gists{/gist_id}","starred_url":"https://api.github.com/users/glensc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glensc/subscriptions","organizations_url":"https://api.github.com/users/glensc/orgs","repos_url":"https://api.github.com/users/glensc/repos","events_url":"https://api.github.com/users/glensc/events{/privacy}","received_events_url":"https://api.github.com/users/glensc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/glensc/minify","description":"Minify is a PHP5 app that helps you follow several rules for client-side performance. It combines multiple CSS or Javascript files, removes unnecessary whitespace and comments, and serves them with gzip encoding and optimal client-side cache headers.","fork":true,"url":"https://api.github.com/repos/glensc/minify","forks_url":"https://api.github.com/repos/glensc/minify/forks","keys_url":"https://api.github.com/repos/glensc/minify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/glensc/minify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/glensc/minify/teams","hooks_url":"https://api.github.com/repos/glensc/minify/hooks","issue_events_url":"https://api.github.com/repos/glensc/minify/issues/events{/number}","events_url":"https://api.github.com/repos/glensc/minify/events","assignees_url":"https://api.github.com/repos/glensc/minify/assignees{/user}","branches_url":"https://api.github.com/repos/glensc/minify/branches{/branch}","tags_url":"https://api.github.com/repos/glensc/minify/tags","blobs_url":"https://api.github.com/repos/glensc/minify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/glensc/minify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/glensc/minify/git/refs{/sha}","trees_url":"https://api.github.com/repos/glensc/minify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/glensc/minify/statuses/{sha}","languages_url":"https://api.github.com/repos/glensc/minify/languages","stargazers_url":"https://api.github.com/repos/glensc/minify/stargazers","contributors_url":"https://api.github.com/repos/glensc/minify/contributors","subscribers_url":"https://api.github.com/repos/glensc/minify/subscribers","subscription_url":"https://api.github.com/repos/glensc/minify/subscription","commits_url":"https://api.github.com/repos/glensc/minify/commits{/sha}","git_commits_url":"https://api.github.com/repos/glensc/minify/git/commits{/sha}","comments_url":"https://api.github.com/repos/glensc/minify/comments{/number}","issue_comment_url":"https://api.github.com/repos/glensc/minify/issues/comments{/number}","contents_url":"https://api.github.com/repos/glensc/minify/contents/{+path}","compare_url":"https://api.github.com/repos/glensc/minify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/glensc/minify/merges","archive_url":"https://api.github.com/repos/glensc/minify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/glensc/minify/downloads","issues_url":"https://api.github.com/repos/glensc/minify/issues{/number}","pulls_url":"https://api.github.com/repos/glensc/minify/pulls{/number}","milestones_url":"https://api.github.com/repos/glensc/minify/milestones{/number}","notifications_url":"https://api.github.com/repos/glensc/minify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/glensc/minify/labels{/name}","releases_url":"https://api.github.com/repos/glensc/minify/releases{/id}","created_at":"2012-03-29T17:32:56Z","updated_at":"2014-09-26T15:52:25Z","pushed_at":"2015-11-22T19:46:38Z","git_url":"git://github.com/glensc/minify.git","ssh_url":"git@github.com:glensc/minify.git","clone_url":"https://github.com/glensc/minify.git","svn_url":"https://github.com/glensc/minify","homepage":"http://code.google.com/p/minify/","size":1826,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"dev"}},"base":{"label":"mrclay:master","ref":"master","sha":"e271c370a99b872ae8a59e98b8907806d8b0db6e","user":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"repo":{"id":1951136,"name":"minify","full_name":"mrclay/minify","owner":{"login":"mrclay","id":170687,"avatar_url":"https://avatars.githubusercontent.com/u/170687?v=3","gravatar_id":"","url":"https://api.github.com/users/mrclay","html_url":"https://github.com/mrclay","followers_url":"https://api.github.com/users/mrclay/followers","following_url":"https://api.github.com/users/mrclay/following{/other_user}","gists_url":"https://api.github.com/users/mrclay/gists{/gist_id}","starred_url":"https://api.github.com/users/mrclay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrclay/subscriptions","organizations_url":"https://api.github.com/users/mrclay/orgs","repos_url":"https://api.github.com/users/mrclay/repos","events_url":"https://api.github.com/users/mrclay/events{/privacy}","received_events_url":"https://api.github.com/users/mrclay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrclay/minify","description":"Combines. minifies, and serves CSS or Javascript files","fork":false,"url":"https://api.github.com/repos/mrclay/minify","forks_url":"https://api.github.com/repos/mrclay/minify/forks","keys_url":"https://api.github.com/repos/mrclay/minify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrclay/minify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrclay/minify/teams","hooks_url":"https://api.github.com/repos/mrclay/minify/hooks","issue_events_url":"https://api.github.com/repos/mrclay/minify/issues/events{/number}","events_url":"https://api.github.com/repos/mrclay/minify/events","assignees_url":"https://api.github.com/repos/mrclay/minify/assignees{/user}","branches_url":"https://api.github.com/repos/mrclay/minify/branches{/branch}","tags_url":"https://api.github.com/repos/mrclay/minify/tags","blobs_url":"https://api.github.com/repos/mrclay/minify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrclay/minify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrclay/minify/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrclay/minify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrclay/minify/statuses/{sha}","languages_url":"https://api.github.com/repos/mrclay/minify/languages","stargazers_url":"https://api.github.com/repos/mrclay/minify/stargazers","contributors_url":"https://api.github.com/repos/mrclay/minify/contributors","subscribers_url":"https://api.github.com/repos/mrclay/minify/subscribers","subscription_url":"https://api.github.com/repos/mrclay/minify/subscription","commits_url":"https://api.github.com/repos/mrclay/minify/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrclay/minify/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrclay/minify/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrclay/minify/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrclay/minify/contents/{+path}","compare_url":"https://api.github.com/repos/mrclay/minify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrclay/minify/merges","archive_url":"https://api.github.com/repos/mrclay/minify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrclay/minify/downloads","issues_url":"https://api.github.com/repos/mrclay/minify/issues{/number}","pulls_url":"https://api.github.com/repos/mrclay/minify/pulls{/number}","milestones_url":"https://api.github.com/repos/mrclay/minify/milestones{/number}","notifications_url":"https://api.github.com/repos/mrclay/minify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrclay/minify/labels{/name}","releases_url":"https://api.github.com/repos/mrclay/minify/releases{/id}","created_at":"2011-06-25T05:52:15Z","updated_at":"2015-11-22T14:56:00Z","pushed_at":"2015-11-22T19:45:46Z","git_url":"git://github.com/mrclay/minify.git","ssh_url":"git@github.com:mrclay/minify.git","clone_url":"https://github.com/mrclay/minify.git","svn_url":"https://github.com/mrclay/minify","homepage":"","size":2373,"stargazers_count":1667,"watchers_count":1667,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":257,"mirror_url":null,"open_issues_count":32,"forks":257,"open_issues":32,"watchers":1667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrclay/minify/pulls/486"},"html":{"href":"https://github.com/mrclay/minify/pull/486"},"issue":{"href":"https://api.github.com/repos/mrclay/minify/issues/486"},"comments":{"href":"https://api.github.com/repos/mrclay/minify/issues/486/comments"},"review_comments":{"href":"https://api.github.com/repos/mrclay/minify/pulls/486/comments"},"review_comment":{"href":"https://api.github.com/repos/mrclay/minify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrclay/minify/pulls/486/commits"},"statuses":{"href":"https://api.github.com/repos/mrclay/minify/statuses/cba869f80f50b48f57d3552cee4c0349b1f02005"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":10,"review_comments":6,"commits":29,"additions":1131,"deletions":1168,"changed_files":38}}