{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29261735","id":29261735,"diff_hunk":"@@ -58,16 +60,17 @@ function create-kubeconfig() {\n     )\n   fi\n   local user_args=()\n-  if [[ -z \"${KUBE_USER:-}\" || -z \"${KUBE_PASSWORD:-}\" ]]; then\n-    user_args+=(\n-     \"--token=${KUBE_BEARER_TOKEN}\"\n-    )\n-  else\n+  if [[ ! -z \"${KUBE_USER:-}\" && ! -z \"${KUBE_PASSWORD:-}\" ]]; then","path":"cluster/common.sh","position":28,"original_position":28,"commit_id":"3c7cfc371e9e9cf1e3d40c1ede35f5a37500b923","original_commit_id":"3c7cfc371e9e9cf1e3d40c1ede35f5a37500b923","user":{"login":"jlowdermilk","id":2101035,"avatar_url":"https://avatars.githubusercontent.com/u/2101035?v=3","gravatar_id":"","url":"https://api.github.com/users/jlowdermilk","html_url":"https://github.com/jlowdermilk","followers_url":"https://api.github.com/users/jlowdermilk/followers","following_url":"https://api.github.com/users/jlowdermilk/following{/other_user}","gists_url":"https://api.github.com/users/jlowdermilk/gists{/gist_id}","starred_url":"https://api.github.com/users/jlowdermilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlowdermilk/subscriptions","organizations_url":"https://api.github.com/users/jlowdermilk/orgs","repos_url":"https://api.github.com/users/jlowdermilk/repos","events_url":"https://api.github.com/users/jlowdermilk/events{/privacy}","received_events_url":"https://api.github.com/users/jlowdermilk/received_events","type":"User","site_admin":false},"body":"[Yes](https://github.com/GoogleCloudPlatform/kubernetes/blob/master/pkg/kubectl/cmd/config/create_authinfo.go#L207). You can only set username/password or token, and doing so will clear the other if it is present.","created_at":"2015-04-28T16:39:04Z","updated_at":"2015-04-28T16:39:04Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7426#discussion_r29261735","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/29261735"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7426#discussion_r29261735"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426","id":34235276,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7426","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7426.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7426.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7426","number":7426,"state":"open","locked":false,"title":"WIP - configure basic auth for GCE.","user":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"body":"This doesn't quite work yet -- kube-up succeeds but the script exits abruptly before cluster validation. I'm waiting for #7383 and #7425 to be merged so I can rebase this on top of them and figure out where in the shell needs to be tweaked. \r\n\r\n/cc @brendandburns ","created_at":"2015-04-28T05:42:00Z","updated_at":"2015-04-28T16:39:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"28cd8dd8c29621735ced986fc2356d117c705b3d","assignee":{"login":"zmerlynn","id":4942464,"avatar_url":"https://avatars.githubusercontent.com/u/4942464?v=3","gravatar_id":"","url":"https://api.github.com/users/zmerlynn","html_url":"https://github.com/zmerlynn","followers_url":"https://api.github.com/users/zmerlynn/followers","following_url":"https://api.github.com/users/zmerlynn/following{/other_user}","gists_url":"https://api.github.com/users/zmerlynn/gists{/gist_id}","starred_url":"https://api.github.com/users/zmerlynn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zmerlynn/subscriptions","organizations_url":"https://api.github.com/users/zmerlynn/orgs","repos_url":"https://api.github.com/users/zmerlynn/repos","events_url":"https://api.github.com/users/zmerlynn/events{/privacy}","received_events_url":"https://api.github.com/users/zmerlynn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7426/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/3c7cfc371e9e9cf1e3d40c1ede35f5a37500b923","head":{"label":"roberthbailey:basic-auth-salt","ref":"basic-auth-salt","sha":"3c7cfc371e9e9cf1e3d40c1ede35f5a37500b923","user":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"repo":{"id":21398175,"name":"kubernetes","full_name":"roberthbailey/kubernetes","owner":{"login":"roberthbailey","id":7751204,"avatar_url":"https://avatars.githubusercontent.com/u/7751204?v=3","gravatar_id":"","url":"https://api.github.com/users/roberthbailey","html_url":"https://github.com/roberthbailey","followers_url":"https://api.github.com/users/roberthbailey/followers","following_url":"https://api.github.com/users/roberthbailey/following{/other_user}","gists_url":"https://api.github.com/users/roberthbailey/gists{/gist_id}","starred_url":"https://api.github.com/users/roberthbailey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roberthbailey/subscriptions","organizations_url":"https://api.github.com/users/roberthbailey/orgs","repos_url":"https://api.github.com/users/roberthbailey/repos","events_url":"https://api.github.com/users/roberthbailey/events{/privacy}","received_events_url":"https://api.github.com/users/roberthbailey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/roberthbailey/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/roberthbailey/kubernetes","forks_url":"https://api.github.com/repos/roberthbailey/kubernetes/forks","keys_url":"https://api.github.com/repos/roberthbailey/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/roberthbailey/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/roberthbailey/kubernetes/teams","hooks_url":"https://api.github.com/repos/roberthbailey/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/roberthbailey/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/roberthbailey/kubernetes/events","assignees_url":"https://api.github.com/repos/roberthbailey/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/roberthbailey/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/roberthbailey/kubernetes/tags","blobs_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/roberthbailey/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/roberthbailey/kubernetes/languages","stargazers_url":"https://api.github.com/repos/roberthbailey/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/roberthbailey/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/roberthbailey/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/roberthbailey/kubernetes/subscription","commits_url":"https://api.github.com/repos/roberthbailey/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/roberthbailey/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/roberthbailey/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/roberthbailey/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/roberthbailey/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/roberthbailey/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/roberthbailey/kubernetes/merges","archive_url":"https://api.github.com/repos/roberthbailey/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/roberthbailey/kubernetes/downloads","issues_url":"https://api.github.com/repos/roberthbailey/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/roberthbailey/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/roberthbailey/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/roberthbailey/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/roberthbailey/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/roberthbailey/kubernetes/releases{/id}","created_at":"2014-07-01T18:28:50Z","updated_at":"2015-04-25T05:18:23Z","pushed_at":"2015-04-28T05:40:06Z","git_url":"git://github.com/roberthbailey/kubernetes.git","ssh_url":"git@github.com:roberthbailey/kubernetes.git","clone_url":"https://github.com/roberthbailey/kubernetes.git","svn_url":"https://github.com/roberthbailey/kubernetes","homepage":null,"size":47776,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"99fc906f78cd2bcb08536c262867fa6803f816d5","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-04-28T16:31:29Z","pushed_at":"2015-04-28T16:33:51Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":209033,"stargazers_count":7387,"watchers_count":7387,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1481,"mirror_url":null,"open_issues_count":961,"forks":1481,"open_issues":961,"watchers":7387,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/7426"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7426"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/7426/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/7426/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/3c7cfc371e9e9cf1e3d40c1ede35f5a37500b923"}}}}