{"action":"closed","number":633,"pull_request":{"url":"https://api.github.com/repos/docker/libcontainer/pulls/633","id":37726629,"html_url":"https://github.com/docker/libcontainer/pull/633","diff_url":"https://github.com/docker/libcontainer/pull/633.diff","patch_url":"https://github.com/docker/libcontainer/pull/633.patch","issue_url":"https://api.github.com/repos/docker/libcontainer/issues/633","number":633,"state":"closed","locked":false,"title":"Move Seccomp support to use Libseccomp as backend","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"body":"In a brief summary of prior events: there were two competing Seccomp integrations, a native Golang implementation (PR #613) and one based on the libseccomp library (PR #384). The libseccomp PR had licensing issues preventing its merging, so the native Golang implementation was merged.\r\n\r\nI believe that the licensing issues present in the old Libseccomp based implementation have been resolved, and that the library-based solution is a decidedly superior implementation to the current Golang version. Libseccomp is well-tested, well-supported, and high-performance, and removes the burden of supporting this code from Docker.\r\n\r\nThis PR removes the existing Seccomp implementation and replaces it with a Libseccomp based one. The API from the original Libseccomp PR has been substituted for the existing API, but the two are mostly compatible, and it should be possible to convert this to use the existing API if that is desired.","created_at":"2015-06-15T19:31:31Z","updated_at":"2015-07-14T01:36:06Z","closed_at":"2015-07-14T01:36:06Z","merged_at":null,"merge_commit_sha":"b227e5856f892f86a31c0c025c664aced98f7aa8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libcontainer/pulls/633/commits","review_comments_url":"https://api.github.com/repos/docker/libcontainer/pulls/633/comments","review_comment_url":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libcontainer/issues/633/comments","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/42d21e2d4d43441a93acf91fcbd6c273359b0269","head":{"label":"mheon:seccomp_redone","ref":"seccomp_redone","sha":"42d21e2d4d43441a93acf91fcbd6c273359b0269","user":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"repo":{"id":23075865,"name":"libcontainer","full_name":"mheon/libcontainer","owner":{"login":"mheon","id":7735048,"avatar_url":"https://avatars.githubusercontent.com/u/7735048?v=3","gravatar_id":"","url":"https://api.github.com/users/mheon","html_url":"https://github.com/mheon","followers_url":"https://api.github.com/users/mheon/followers","following_url":"https://api.github.com/users/mheon/following{/other_user}","gists_url":"https://api.github.com/users/mheon/gists{/gist_id}","starred_url":"https://api.github.com/users/mheon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mheon/subscriptions","organizations_url":"https://api.github.com/users/mheon/orgs","repos_url":"https://api.github.com/users/mheon/repos","events_url":"https://api.github.com/users/mheon/events{/privacy}","received_events_url":"https://api.github.com/users/mheon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mheon/libcontainer","description":"Linux Containers","fork":true,"url":"https://api.github.com/repos/mheon/libcontainer","forks_url":"https://api.github.com/repos/mheon/libcontainer/forks","keys_url":"https://api.github.com/repos/mheon/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mheon/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mheon/libcontainer/teams","hooks_url":"https://api.github.com/repos/mheon/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/mheon/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/mheon/libcontainer/events","assignees_url":"https://api.github.com/repos/mheon/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/mheon/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/mheon/libcontainer/tags","blobs_url":"https://api.github.com/repos/mheon/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mheon/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mheon/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/mheon/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mheon/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/mheon/libcontainer/languages","stargazers_url":"https://api.github.com/repos/mheon/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/mheon/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/mheon/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/mheon/libcontainer/subscription","commits_url":"https://api.github.com/repos/mheon/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/mheon/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/mheon/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/mheon/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/mheon/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/mheon/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mheon/libcontainer/merges","archive_url":"https://api.github.com/repos/mheon/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mheon/libcontainer/downloads","issues_url":"https://api.github.com/repos/mheon/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/mheon/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/mheon/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/mheon/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mheon/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/mheon/libcontainer/releases{/id}","created_at":"2014-08-18T15:13:48Z","updated_at":"2015-03-19T13:18:19Z","pushed_at":"2015-06-26T15:49:19Z","git_url":"git://github.com/mheon/libcontainer.git","ssh_url":"git@github.com:mheon/libcontainer.git","clone_url":"https://github.com/mheon/libcontainer.git","svn_url":"https://github.com/mheon/libcontainer","homepage":"http://www.docker.com/","size":2514,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"6dd3154348876e59831cc1ca7b582fa053119edf","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":15693680,"name":"libcontainer","full_name":"docker/libcontainer","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcontainer","description":"PROJECT MOVED TO RUNC","fork":false,"url":"https://api.github.com/repos/docker/libcontainer","forks_url":"https://api.github.com/repos/docker/libcontainer/forks","keys_url":"https://api.github.com/repos/docker/libcontainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcontainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcontainer/teams","hooks_url":"https://api.github.com/repos/docker/libcontainer/hooks","issue_events_url":"https://api.github.com/repos/docker/libcontainer/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcontainer/events","assignees_url":"https://api.github.com/repos/docker/libcontainer/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcontainer/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcontainer/tags","blobs_url":"https://api.github.com/repos/docker/libcontainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcontainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcontainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcontainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcontainer/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcontainer/languages","stargazers_url":"https://api.github.com/repos/docker/libcontainer/stargazers","contributors_url":"https://api.github.com/repos/docker/libcontainer/contributors","subscribers_url":"https://api.github.com/repos/docker/libcontainer/subscribers","subscription_url":"https://api.github.com/repos/docker/libcontainer/subscription","commits_url":"https://api.github.com/repos/docker/libcontainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcontainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcontainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcontainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libcontainer/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcontainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcontainer/merges","archive_url":"https://api.github.com/repos/docker/libcontainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcontainer/downloads","issues_url":"https://api.github.com/repos/docker/libcontainer/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcontainer/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcontainer/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcontainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcontainer/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcontainer/releases{/id}","created_at":"2014-01-07T03:05:05Z","updated_at":"2015-07-13T08:30:34Z","pushed_at":"2015-07-09T11:39:09Z","git_url":"git://github.com/docker/libcontainer.git","ssh_url":"git@github.com:docker/libcontainer.git","clone_url":"https://github.com/docker/libcontainer.git","svn_url":"https://github.com/docker/libcontainer","homepage":"https://github.com/opencontainers/runc","size":8274,"stargazers_count":837,"watchers_count":837,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":259,"mirror_url":null,"open_issues_count":32,"forks":259,"open_issues":32,"watchers":837,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/633"},"html":{"href":"https://github.com/docker/libcontainer/pull/633"},"issue":{"href":"https://api.github.com/repos/docker/libcontainer/issues/633"},"comments":{"href":"https://api.github.com/repos/docker/libcontainer/issues/633/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/633/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libcontainer/pulls/633/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcontainer/statuses/42d21e2d4d43441a93acf91fcbd6c273359b0269"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":16,"review_comments":0,"commits":4,"additions":2430,"deletions":704,"changed_files":24}}