{"action":"created","comment":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/47693914","id":47693914,"diff_hunk":"@@ -7,18 +7,19 @@ namespace NServiceBus.AcceptanceTests.Config\n     using NServiceBus.AcceptanceTests.FakeTransport;\n     using NServiceBus.Config;\n     using NUnit.Framework;\n+    using ScenarioDescriptors;\n \n     public class When_limiting_concurrency_via_both_api_and_config : NServiceBusAcceptanceTest\n     {\n         [Test]\n         public async Task Should_throw()\n         {\n-            var context = await Scenario.Define<Context>()\n+            await Scenario.Define<Context>()\n                 .WithEndpoint<ThrottledEndpoint>(b => b.CustomConfig(c => c.LimitMessageProcessingConcurrencyTo(10)))\n                 .Done(c => c.EndpointsStarted)\n+                .Repeat(r => r.For(Transports.AllAvailable.SingleOrDefault(t => t.Key == \"FakeTransport\")))","path":"src/NServiceBus.AcceptanceTests/Performance/ProcessingOptimizations/When_limiting_concurrency_via_both_api_and_config.cs","position":15,"original_position":15,"commit_id":"93e709f6828ec11107978f5dafc82df804aaebf3","original_commit_id":"93e709f6828ec11107978f5dafc82df804aaebf3","user":{"login":"danielmarbach","id":174258,"avatar_url":"https://avatars.githubusercontent.com/u/174258?v=3","gravatar_id":"","url":"https://api.github.com/users/danielmarbach","html_url":"https://github.com/danielmarbach","followers_url":"https://api.github.com/users/danielmarbach/followers","following_url":"https://api.github.com/users/danielmarbach/following{/other_user}","gists_url":"https://api.github.com/users/danielmarbach/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmarbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmarbach/subscriptions","organizations_url":"https://api.github.com/users/danielmarbach/orgs","repos_url":"https://api.github.com/users/danielmarbach/repos","events_url":"https://api.github.com/users/danielmarbach/events{/privacy}","received_events_url":"https://api.github.com/users/danielmarbach/received_events","type":"User","site_admin":false},"body":"Shouldn't we then find the root cause why UseTransport get's ignored?\n\nOn Tuesday, December 15, 2015, Sean Feldman <notifications@github.com>\nwrote:\n\n> In\n> src/NServiceBus.AcceptanceTests/Performance/ProcessingOptimizations/When_limiting_concurrency_via_both_api_and_config.cs\n> <https://github.com/Particular/NServiceBus/pull/3235#discussion_r47686115>\n> :\n>\n> >                  .WithEndpoint<ThrottledEndpoint>(b => b.CustomConfig(c => c.LimitMessageProcessingConcurrencyTo(10)))\n> >                  .Done(c => c.EndpointsStarted)\n> > +                .Repeat(r => r.For(Transports.AllAvailable.SingleOrDefault(t => t.Key == \"FakeTransport\")))\n>\n> Because .UseTransport() seems to be ignored and we get\n>\n>  ----> System.InvalidCastException : Unable to cast object of type 'NServiceBus.AcceptanceTests.FakeTransport.FakeTransport'\n> to type 'NServiceBus.AzureServiceBusTransport'```\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/Particular/NServiceBus/pull/3235/files#r47686115>.\n>\n\n\n-- \n*#NSBcon 2015 • The \"All About NServiceBus\" conference is back *\n*• Learn more <http://go.particular.net/l/27442/2015-08-21/5d4wzp> →*\n","created_at":"2015-12-15T20:31:02Z","updated_at":"2015-12-15T20:31:02Z","html_url":"https://github.com/Particular/NServiceBus/pull/3235#discussion_r47693914","pull_request_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235","_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments/47693914"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/3235#discussion_r47693914"},"pull_request":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235"}}},"pull_request":{"url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235","id":53729443,"html_url":"https://github.com/Particular/NServiceBus/pull/3235","diff_url":"https://github.com/Particular/NServiceBus/pull/3235.diff","patch_url":"https://github.com/Particular/NServiceBus/pull/3235.patch","issue_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3235","number":3235,"state":"open","locked":false,"title":"Fix flaky test & tests that rely on FakeTransport","user":{"login":"yvesgoeleven","id":471354,"avatar_url":"https://avatars.githubusercontent.com/u/471354?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesgoeleven","html_url":"https://github.com/yvesgoeleven","followers_url":"https://api.github.com/users/yvesgoeleven/followers","following_url":"https://api.github.com/users/yvesgoeleven/following{/other_user}","gists_url":"https://api.github.com/users/yvesgoeleven/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesgoeleven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesgoeleven/subscriptions","organizations_url":"https://api.github.com/users/yvesgoeleven/orgs","repos_url":"https://api.github.com/users/yvesgoeleven/repos","events_url":"https://api.github.com/users/yvesgoeleven/events{/privacy}","received_events_url":"https://api.github.com/users/yvesgoeleven/received_events","type":"User","site_admin":false},"body":"Fixes a flaky test that assumed message order would be consistent","created_at":"2015-12-15T16:46:53Z","updated_at":"2015-12-15T20:31:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3703eeace36fd6ea3a9cd8b608fb60c6b48ddae2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235/commits","review_comments_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235/comments","review_comment_url":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/issues/3235/comments","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/93e709f6828ec11107978f5dafc82df804aaebf3","head":{"label":"Particular:fix-flaky-test","ref":"fix-flaky-test","sha":"93e709f6828ec11107978f5dafc82df804aaebf3","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","created_at":"2010-11-06T12:54:52Z","updated_at":"2015-12-15T16:12:51Z","pushed_at":"2015-12-15T16:51:17Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":158261,"stargazers_count":842,"watchers_count":842,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":456,"mirror_url":null,"open_issues_count":210,"forks":456,"open_issues":210,"watchers":842,"default_branch":"develop"}},"base":{"label":"Particular:develop","ref":"develop","sha":"551f1c1d14e2d84241b499eadfe3b6ef73f896ae","user":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"repo":{"id":1056713,"name":"NServiceBus","full_name":"Particular/NServiceBus","owner":{"login":"Particular","id":5038441,"avatar_url":"https://avatars.githubusercontent.com/u/5038441?v=3","gravatar_id":"","url":"https://api.github.com/users/Particular","html_url":"https://github.com/Particular","followers_url":"https://api.github.com/users/Particular/followers","following_url":"https://api.github.com/users/Particular/following{/other_user}","gists_url":"https://api.github.com/users/Particular/gists{/gist_id}","starred_url":"https://api.github.com/users/Particular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Particular/subscriptions","organizations_url":"https://api.github.com/users/Particular/orgs","repos_url":"https://api.github.com/users/Particular/repos","events_url":"https://api.github.com/users/Particular/events{/privacy}","received_events_url":"https://api.github.com/users/Particular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Particular/NServiceBus","description":"The most popular service bus for .NET","fork":false,"url":"https://api.github.com/repos/Particular/NServiceBus","forks_url":"https://api.github.com/repos/Particular/NServiceBus/forks","keys_url":"https://api.github.com/repos/Particular/NServiceBus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Particular/NServiceBus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Particular/NServiceBus/teams","hooks_url":"https://api.github.com/repos/Particular/NServiceBus/hooks","issue_events_url":"https://api.github.com/repos/Particular/NServiceBus/issues/events{/number}","events_url":"https://api.github.com/repos/Particular/NServiceBus/events","assignees_url":"https://api.github.com/repos/Particular/NServiceBus/assignees{/user}","branches_url":"https://api.github.com/repos/Particular/NServiceBus/branches{/branch}","tags_url":"https://api.github.com/repos/Particular/NServiceBus/tags","blobs_url":"https://api.github.com/repos/Particular/NServiceBus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Particular/NServiceBus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Particular/NServiceBus/git/refs{/sha}","trees_url":"https://api.github.com/repos/Particular/NServiceBus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Particular/NServiceBus/statuses/{sha}","languages_url":"https://api.github.com/repos/Particular/NServiceBus/languages","stargazers_url":"https://api.github.com/repos/Particular/NServiceBus/stargazers","contributors_url":"https://api.github.com/repos/Particular/NServiceBus/contributors","subscribers_url":"https://api.github.com/repos/Particular/NServiceBus/subscribers","subscription_url":"https://api.github.com/repos/Particular/NServiceBus/subscription","commits_url":"https://api.github.com/repos/Particular/NServiceBus/commits{/sha}","git_commits_url":"https://api.github.com/repos/Particular/NServiceBus/git/commits{/sha}","comments_url":"https://api.github.com/repos/Particular/NServiceBus/comments{/number}","issue_comment_url":"https://api.github.com/repos/Particular/NServiceBus/issues/comments{/number}","contents_url":"https://api.github.com/repos/Particular/NServiceBus/contents/{+path}","compare_url":"https://api.github.com/repos/Particular/NServiceBus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Particular/NServiceBus/merges","archive_url":"https://api.github.com/repos/Particular/NServiceBus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Particular/NServiceBus/downloads","issues_url":"https://api.github.com/repos/Particular/NServiceBus/issues{/number}","pulls_url":"https://api.github.com/repos/Particular/NServiceBus/pulls{/number}","milestones_url":"https://api.github.com/repos/Particular/NServiceBus/milestones{/number}","notifications_url":"https://api.github.com/repos/Particular/NServiceBus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Particular/NServiceBus/labels{/name}","releases_url":"https://api.github.com/repos/Particular/NServiceBus/releases{/id}","created_at":"2010-11-06T12:54:52Z","updated_at":"2015-12-15T16:12:51Z","pushed_at":"2015-12-15T16:51:17Z","git_url":"git://github.com/Particular/NServiceBus.git","ssh_url":"git@github.com:Particular/NServiceBus.git","clone_url":"https://github.com/Particular/NServiceBus.git","svn_url":"https://github.com/Particular/NServiceBus","homepage":"http://particular.net/nservicebus","size":158261,"stargazers_count":842,"watchers_count":842,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":456,"mirror_url":null,"open_issues_count":210,"forks":456,"open_issues":210,"watchers":842,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235"},"html":{"href":"https://github.com/Particular/NServiceBus/pull/3235"},"issue":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/3235"},"comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/issues/3235/comments"},"review_comments":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235/comments"},"review_comment":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Particular/NServiceBus/pulls/3235/commits"},"statuses":{"href":"https://api.github.com/repos/Particular/NServiceBus/statuses/93e709f6828ec11107978f5dafc82df804aaebf3"}}}}