{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/EECOLOR/scala/pulls/3","id":28670269,"html_url":"https://github.com/EECOLOR/scala/pull/3","diff_url":"https://github.com/EECOLOR/scala/pull/3.diff","patch_url":"https://github.com/EECOLOR/scala/pull/3.patch","issue_url":"https://api.github.com/repos/EECOLOR/scala/issues/3","number":3,"state":"open","locked":false,"title":"Refactoring typechecker","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars.githubusercontent.com/u/1486362?v=3","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"body":"Types of refactoring:\r\n\r\n- *Optimizing dependency graph* - Moves members to more appropriate places to prevent unnecessary coupling. In a lot of cases this is done to follow the [Single Responsibility Principle](http://en.wikipedia.org/wiki/Single_responsibility_principle).\r\n- *Minimize public API* - Keep the public API as small as possible. This helps with refactoring as you can more easily determine which methods you can safely change / rename. In a lot of cases this is done to follow the [Interface Segregation Principle]. As a bonus this improves incremental compilation speed.\r\n\r\n**TODO**: Group commits by type (or squash completely)","created_at":"2015-02-04T20:04:28Z","updated_at":"2015-02-04T20:04:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/EECOLOR/scala/pulls/3/commits","review_comments_url":"https://api.github.com/repos/EECOLOR/scala/pulls/3/comments","review_comment_url":"https://api.github.com/repos/EECOLOR/scala/pulls/comments/{number}","comments_url":"https://api.github.com/repos/EECOLOR/scala/issues/3/comments","statuses_url":"https://api.github.com/repos/EECOLOR/scala/statuses/e8d69f45db5f84d3ece222145cabd39101cc8aba","head":{"label":"EECOLOR:refactoring_typechecker","ref":"refactoring_typechecker","sha":"e8d69f45db5f84d3ece222145cabd39101cc8aba","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars.githubusercontent.com/u/1486362?v=3","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"repo":{"id":29316354,"name":"scala","full_name":"EECOLOR/scala","owner":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars.githubusercontent.com/u/1486362?v=3","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EECOLOR/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/EECOLOR/scala","forks_url":"https://api.github.com/repos/EECOLOR/scala/forks","keys_url":"https://api.github.com/repos/EECOLOR/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EECOLOR/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EECOLOR/scala/teams","hooks_url":"https://api.github.com/repos/EECOLOR/scala/hooks","issue_events_url":"https://api.github.com/repos/EECOLOR/scala/issues/events{/number}","events_url":"https://api.github.com/repos/EECOLOR/scala/events","assignees_url":"https://api.github.com/repos/EECOLOR/scala/assignees{/user}","branches_url":"https://api.github.com/repos/EECOLOR/scala/branches{/branch}","tags_url":"https://api.github.com/repos/EECOLOR/scala/tags","blobs_url":"https://api.github.com/repos/EECOLOR/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EECOLOR/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EECOLOR/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/EECOLOR/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EECOLOR/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/EECOLOR/scala/languages","stargazers_url":"https://api.github.com/repos/EECOLOR/scala/stargazers","contributors_url":"https://api.github.com/repos/EECOLOR/scala/contributors","subscribers_url":"https://api.github.com/repos/EECOLOR/scala/subscribers","subscription_url":"https://api.github.com/repos/EECOLOR/scala/subscription","commits_url":"https://api.github.com/repos/EECOLOR/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/EECOLOR/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/EECOLOR/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/EECOLOR/scala/issues/comments/{number}","contents_url":"https://api.github.com/repos/EECOLOR/scala/contents/{+path}","compare_url":"https://api.github.com/repos/EECOLOR/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EECOLOR/scala/merges","archive_url":"https://api.github.com/repos/EECOLOR/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EECOLOR/scala/downloads","issues_url":"https://api.github.com/repos/EECOLOR/scala/issues{/number}","pulls_url":"https://api.github.com/repos/EECOLOR/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/EECOLOR/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/EECOLOR/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EECOLOR/scala/labels{/name}","releases_url":"https://api.github.com/repos/EECOLOR/scala/releases{/id}","created_at":"2015-01-15T20:19:49Z","updated_at":"2015-02-04T19:44:41Z","pushed_at":"2015-02-04T20:02:33Z","git_url":"git://github.com/EECOLOR/scala.git","ssh_url":"git@github.com:EECOLOR/scala.git","clone_url":"https://github.com/EECOLOR/scala.git","svn_url":"https://github.com/EECOLOR/scala","homepage":"http://www.scala-lang.org/","size":84797,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"EECOLOR:2.11.x","ref":"2.11.x","sha":"745ed5c8f6431400cb432cfec751351b3bbd88f0","user":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars.githubusercontent.com/u/1486362?v=3","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"repo":{"id":29316354,"name":"scala","full_name":"EECOLOR/scala","owner":{"login":"EECOLOR","id":1486362,"avatar_url":"https://avatars.githubusercontent.com/u/1486362?v=3","gravatar_id":"","url":"https://api.github.com/users/EECOLOR","html_url":"https://github.com/EECOLOR","followers_url":"https://api.github.com/users/EECOLOR/followers","following_url":"https://api.github.com/users/EECOLOR/following{/other_user}","gists_url":"https://api.github.com/users/EECOLOR/gists{/gist_id}","starred_url":"https://api.github.com/users/EECOLOR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EECOLOR/subscriptions","organizations_url":"https://api.github.com/users/EECOLOR/orgs","repos_url":"https://api.github.com/users/EECOLOR/repos","events_url":"https://api.github.com/users/EECOLOR/events{/privacy}","received_events_url":"https://api.github.com/users/EECOLOR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EECOLOR/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/EECOLOR/scala","forks_url":"https://api.github.com/repos/EECOLOR/scala/forks","keys_url":"https://api.github.com/repos/EECOLOR/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EECOLOR/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EECOLOR/scala/teams","hooks_url":"https://api.github.com/repos/EECOLOR/scala/hooks","issue_events_url":"https://api.github.com/repos/EECOLOR/scala/issues/events{/number}","events_url":"https://api.github.com/repos/EECOLOR/scala/events","assignees_url":"https://api.github.com/repos/EECOLOR/scala/assignees{/user}","branches_url":"https://api.github.com/repos/EECOLOR/scala/branches{/branch}","tags_url":"https://api.github.com/repos/EECOLOR/scala/tags","blobs_url":"https://api.github.com/repos/EECOLOR/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EECOLOR/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EECOLOR/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/EECOLOR/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EECOLOR/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/EECOLOR/scala/languages","stargazers_url":"https://api.github.com/repos/EECOLOR/scala/stargazers","contributors_url":"https://api.github.com/repos/EECOLOR/scala/contributors","subscribers_url":"https://api.github.com/repos/EECOLOR/scala/subscribers","subscription_url":"https://api.github.com/repos/EECOLOR/scala/subscription","commits_url":"https://api.github.com/repos/EECOLOR/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/EECOLOR/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/EECOLOR/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/EECOLOR/scala/issues/comments/{number}","contents_url":"https://api.github.com/repos/EECOLOR/scala/contents/{+path}","compare_url":"https://api.github.com/repos/EECOLOR/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EECOLOR/scala/merges","archive_url":"https://api.github.com/repos/EECOLOR/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EECOLOR/scala/downloads","issues_url":"https://api.github.com/repos/EECOLOR/scala/issues{/number}","pulls_url":"https://api.github.com/repos/EECOLOR/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/EECOLOR/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/EECOLOR/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EECOLOR/scala/labels{/name}","releases_url":"https://api.github.com/repos/EECOLOR/scala/releases{/id}","created_at":"2015-01-15T20:19:49Z","updated_at":"2015-02-04T19:44:41Z","pushed_at":"2015-02-04T20:02:33Z","git_url":"git://github.com/EECOLOR/scala.git","ssh_url":"git@github.com:EECOLOR/scala.git","clone_url":"https://github.com/EECOLOR/scala.git","svn_url":"https://github.com/EECOLOR/scala","homepage":"http://www.scala-lang.org/","size":84797,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/EECOLOR/scala/pulls/3"},"html":{"href":"https://github.com/EECOLOR/scala/pull/3"},"issue":{"href":"https://api.github.com/repos/EECOLOR/scala/issues/3"},"comments":{"href":"https://api.github.com/repos/EECOLOR/scala/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/EECOLOR/scala/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/EECOLOR/scala/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/EECOLOR/scala/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/EECOLOR/scala/statuses/e8d69f45db5f84d3ece222145cabd39101cc8aba"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":11,"additions":2011,"deletions":711,"changed_files":62}}