{"action":"created","comment":{"url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/comments/24072913","id":24072913,"diff_hunk":"@@ -180,6 +180,9 @@ public function onBuildKernel( PreBuildKernelEvent $event )\n         // Multisite settings (PathPrefix and co)\n         $settings += $this->getMultiSiteSettings();\n \n+        // SiteAccess settings\n+        $settings += $this->getSiteSettings();","path":"bundle/LegacyMapper/Configuration.php","position":5,"original_position":5,"commit_id":"2eb9d952ccf66c11fe529b28e81f25b66b8ab4f8","original_commit_id":"2eb9d952ccf66c11fe529b28e81f25b66b8ab4f8","user":{"login":"andrerom","id":289757,"avatar_url":"https://avatars.githubusercontent.com/u/289757?v=3","gravatar_id":"","url":"https://api.github.com/users/andrerom","html_url":"https://github.com/andrerom","followers_url":"https://api.github.com/users/andrerom/followers","following_url":"https://api.github.com/users/andrerom/following{/other_user}","gists_url":"https://api.github.com/users/andrerom/gists{/gist_id}","starred_url":"https://api.github.com/users/andrerom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrerom/subscriptions","organizations_url":"https://api.github.com/users/andrerom/orgs","repos_url":"https://api.github.com/users/andrerom/repos","events_url":"https://api.github.com/users/andrerom/events{/privacy}","received_events_url":"https://api.github.com/users/andrerom/received_events","type":"User","site_admin":false},"body":"My point is, it is to complex, it is hard to read.\r\n\r\nmaybe *remove* `getSiteSettings`, and move the logic into the `if ( $rootLocationId === null )` block, with inline doc saying we return plan site settings if rootLocationId is not used.","created_at":"2015-02-04T10:01:49Z","updated_at":"2015-02-04T10:01:49Z","html_url":"https://github.com/ezsystems/LegacyBridge/pull/5#discussion_r24072913","pull_request_url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/comments/24072913"},"html":{"href":"https://github.com/ezsystems/LegacyBridge/pull/5#discussion_r24072913"},"pull_request":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5","id":28570258,"html_url":"https://github.com/ezsystems/LegacyBridge/pull/5","diff_url":"https://github.com/ezsystems/LegacyBridge/pull/5.diff","patch_url":"https://github.com/ezsystems/LegacyBridge/pull/5.patch","issue_url":"https://api.github.com/repos/ezsystems/LegacyBridge/issues/5","number":5,"state":"open","locked":false,"title":"Fix EZP-23978: Inject index_page and default_page settings","user":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"body":"JIRA: https://jira.ez.no/browse/EZP-23978\r\n\r\nInject `IndexPage` and `DefaultPage` if set, regardless of using multisite settings (content.tree_root.location_id) or not.","created_at":"2015-02-03T17:12:30Z","updated_at":"2015-02-04T10:01:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cd7d2622526b1fba131e20fde5e329d25cd60c9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5/commits","review_comments_url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5/comments","review_comment_url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/comments/{number}","comments_url":"https://api.github.com/repos/ezsystems/LegacyBridge/issues/5/comments","statuses_url":"https://api.github.com/repos/ezsystems/LegacyBridge/statuses/2eb9d952ccf66c11fe529b28e81f25b66b8ab4f8","head":{"label":"joaoinacio:EZP-23978_legacy_indexpage","ref":"EZP-23978_legacy_indexpage","sha":"2eb9d952ccf66c11fe529b28e81f25b66b8ab4f8","user":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"repo":{"id":30248682,"name":"LegacyBridge","full_name":"joaoinacio/LegacyBridge","owner":{"login":"joaoinacio","id":1168342,"avatar_url":"https://avatars.githubusercontent.com/u/1168342?v=3","gravatar_id":"","url":"https://api.github.com/users/joaoinacio","html_url":"https://github.com/joaoinacio","followers_url":"https://api.github.com/users/joaoinacio/followers","following_url":"https://api.github.com/users/joaoinacio/following{/other_user}","gists_url":"https://api.github.com/users/joaoinacio/gists{/gist_id}","starred_url":"https://api.github.com/users/joaoinacio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaoinacio/subscriptions","organizations_url":"https://api.github.com/users/joaoinacio/orgs","repos_url":"https://api.github.com/users/joaoinacio/repos","events_url":"https://api.github.com/users/joaoinacio/events{/privacy}","received_events_url":"https://api.github.com/users/joaoinacio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/joaoinacio/LegacyBridge","description":"eZ Platform bridge to eZ Publish Legacy","fork":true,"url":"https://api.github.com/repos/joaoinacio/LegacyBridge","forks_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/forks","keys_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/teams","hooks_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/hooks","issue_events_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/issues/events{/number}","events_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/events","assignees_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/assignees{/user}","branches_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/branches{/branch}","tags_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/tags","blobs_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/statuses/{sha}","languages_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/languages","stargazers_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/stargazers","contributors_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/contributors","subscribers_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/subscribers","subscription_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/subscription","commits_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/issues/comments/{number}","contents_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/contents/{+path}","compare_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/merges","archive_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/downloads","issues_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/issues{/number}","pulls_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/pulls{/number}","milestones_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/milestones{/number}","notifications_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/labels{/name}","releases_url":"https://api.github.com/repos/joaoinacio/LegacyBridge/releases{/id}","created_at":"2015-02-03T15:11:35Z","updated_at":"2015-02-03T15:11:36Z","pushed_at":"2015-02-03T17:05:59Z","git_url":"git://github.com/joaoinacio/LegacyBridge.git","ssh_url":"git@github.com:joaoinacio/LegacyBridge.git","clone_url":"https://github.com/joaoinacio/LegacyBridge.git","svn_url":"https://github.com/joaoinacio/LegacyBridge","homepage":null,"size":1136,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ezsystems:master","ref":"master","sha":"c45436211a75198a76895efcf5c54f46033c408e","user":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"repo":{"id":29585452,"name":"LegacyBridge","full_name":"ezsystems/LegacyBridge","owner":{"login":"ezsystems","id":295311,"avatar_url":"https://avatars.githubusercontent.com/u/295311?v=3","gravatar_id":"","url":"https://api.github.com/users/ezsystems","html_url":"https://github.com/ezsystems","followers_url":"https://api.github.com/users/ezsystems/followers","following_url":"https://api.github.com/users/ezsystems/following{/other_user}","gists_url":"https://api.github.com/users/ezsystems/gists{/gist_id}","starred_url":"https://api.github.com/users/ezsystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ezsystems/subscriptions","organizations_url":"https://api.github.com/users/ezsystems/orgs","repos_url":"https://api.github.com/users/ezsystems/repos","events_url":"https://api.github.com/users/ezsystems/events{/privacy}","received_events_url":"https://api.github.com/users/ezsystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ezsystems/LegacyBridge","description":"eZ Platform bridge to eZ Publish Legacy","fork":false,"url":"https://api.github.com/repos/ezsystems/LegacyBridge","forks_url":"https://api.github.com/repos/ezsystems/LegacyBridge/forks","keys_url":"https://api.github.com/repos/ezsystems/LegacyBridge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ezsystems/LegacyBridge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ezsystems/LegacyBridge/teams","hooks_url":"https://api.github.com/repos/ezsystems/LegacyBridge/hooks","issue_events_url":"https://api.github.com/repos/ezsystems/LegacyBridge/issues/events{/number}","events_url":"https://api.github.com/repos/ezsystems/LegacyBridge/events","assignees_url":"https://api.github.com/repos/ezsystems/LegacyBridge/assignees{/user}","branches_url":"https://api.github.com/repos/ezsystems/LegacyBridge/branches{/branch}","tags_url":"https://api.github.com/repos/ezsystems/LegacyBridge/tags","blobs_url":"https://api.github.com/repos/ezsystems/LegacyBridge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ezsystems/LegacyBridge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ezsystems/LegacyBridge/git/refs{/sha}","trees_url":"https://api.github.com/repos/ezsystems/LegacyBridge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ezsystems/LegacyBridge/statuses/{sha}","languages_url":"https://api.github.com/repos/ezsystems/LegacyBridge/languages","stargazers_url":"https://api.github.com/repos/ezsystems/LegacyBridge/stargazers","contributors_url":"https://api.github.com/repos/ezsystems/LegacyBridge/contributors","subscribers_url":"https://api.github.com/repos/ezsystems/LegacyBridge/subscribers","subscription_url":"https://api.github.com/repos/ezsystems/LegacyBridge/subscription","commits_url":"https://api.github.com/repos/ezsystems/LegacyBridge/commits{/sha}","git_commits_url":"https://api.github.com/repos/ezsystems/LegacyBridge/git/commits{/sha}","comments_url":"https://api.github.com/repos/ezsystems/LegacyBridge/comments{/number}","issue_comment_url":"https://api.github.com/repos/ezsystems/LegacyBridge/issues/comments/{number}","contents_url":"https://api.github.com/repos/ezsystems/LegacyBridge/contents/{+path}","compare_url":"https://api.github.com/repos/ezsystems/LegacyBridge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ezsystems/LegacyBridge/merges","archive_url":"https://api.github.com/repos/ezsystems/LegacyBridge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ezsystems/LegacyBridge/downloads","issues_url":"https://api.github.com/repos/ezsystems/LegacyBridge/issues{/number}","pulls_url":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls{/number}","milestones_url":"https://api.github.com/repos/ezsystems/LegacyBridge/milestones{/number}","notifications_url":"https://api.github.com/repos/ezsystems/LegacyBridge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ezsystems/LegacyBridge/labels{/name}","releases_url":"https://api.github.com/repos/ezsystems/LegacyBridge/releases{/id}","created_at":"2015-01-21T10:54:07Z","updated_at":"2015-01-31T09:57:00Z","pushed_at":"2015-02-03T14:21:46Z","git_url":"git://github.com/ezsystems/LegacyBridge.git","ssh_url":"git@github.com:ezsystems/LegacyBridge.git","clone_url":"https://github.com/ezsystems/LegacyBridge.git","svn_url":"https://github.com/ezsystems/LegacyBridge","homepage":null,"size":1136,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5"},"html":{"href":"https://github.com/ezsystems/LegacyBridge/pull/5"},"issue":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/issues/5"},"comments":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/ezsystems/LegacyBridge/statuses/2eb9d952ccf66c11fe529b28e81f25b66b8ab4f8"}}}}