{"action":"created","issue":{"url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/230","labels_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/230/labels{/name}","comments_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/230/comments","events_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/230/events","html_url":"https://github.com/armenzg/mozilla_ci_tools/issues/230","id":82511089,"number":230,"title":"Do not allow to trigger abitrary job for a downstream type of job *without* test files (aka test jobs)","user":{"login":"armenzg","id":44410,"avatar_url":"https://avatars.githubusercontent.com/u/44410?v=3","gravatar_id":"","url":"https://api.github.com/users/armenzg","html_url":"https://github.com/armenzg","followers_url":"https://api.github.com/users/armenzg/followers","following_url":"https://api.github.com/users/armenzg/following{/other_user}","gists_url":"https://api.github.com/users/armenzg/gists{/gist_id}","starred_url":"https://api.github.com/users/armenzg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armenzg/subscriptions","organizations_url":"https://api.github.com/users/armenzg/orgs","repos_url":"https://api.github.com/users/armenzg/repos","events_url":"https://api.github.com/users/armenzg/events{/privacy}","received_events_url":"https://api.github.com/users/armenzg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-29T17:20:21Z","updated_at":"2015-08-12T18:03:14Z","closed_at":null,"body":"Ryan showed me this:\r\nhttps://treeherder.mozilla.org/logviewer.html#?job_id=10271595&repo=mozilla-inbound\r\n\r\nThe question to answer, how did we schedule a job without specifying the files?\r\nWe should prevent mozci from ever doing that for downstream jobs (files can currently be [] for build builders):\r\nhttps://github.com/armenzg/mozilla_ci_tools/blob/master/mozci/sources/buildapi.py#L42\r\n\r\nSomehow he triggered once a job without files [1]:\r\n{'files': [], 'priority': 0, 'builder_name': 'Windows XP 32-bit mozilla-inbound debug test crashtest', 'branch': 'mozilla-inbound-selfserve', 'properties': {}, 'revision': '197a7c20143d'}\r\nBODY:\r\n{'body': {'msg': 'Ok', 'errors': False}, 'request_id': 1341351}\r\n\r\nAfter that he triggered it with files:\r\n{'files': ['http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1432908942/firefox-41.0a1.en-US.win32.zip', 'http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1432908942/firefox-41.0a1.en-US.win32.tests.zip', 'http://ftp.mozilla.org/pub/mozilla.org/firefox/tinderbox-builds/mozilla-inbound-win32-debug/1432908942/firefox-41.0a1.en-US.win32.crashreporter-symbols.zip'], 'priority': 0, 'builder_name': 'Windows XP 32-bit mozilla-inbound debug test crashtest', 'branch': 'mozilla-inbound-selfserve', 'properties': {}, 'revision': '197a7c20143d'}\r\nBODY:\r\n{'body': {'msg': 'Ok', 'errors': False}, 'request_id': 1341357}\r\n\r\nHowever mozci, re-triggered the job **without** files.\r\n\r\n[1] https://secure.pub.build.mozilla.org/buildapi/self-serve/jobs"},"comment":{"url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/comments/130394251","html_url":"https://github.com/armenzg/mozilla_ci_tools/issues/230#issuecomment-130394251","issue_url":"https://api.github.com/repos/armenzg/mozilla_ci_tools/issues/230","id":130394251,"user":{"login":"vaibhavmagarwal","id":2410741,"avatar_url":"https://avatars.githubusercontent.com/u/2410741?v=3","gravatar_id":"","url":"https://api.github.com/users/vaibhavmagarwal","html_url":"https://github.com/vaibhavmagarwal","followers_url":"https://api.github.com/users/vaibhavmagarwal/followers","following_url":"https://api.github.com/users/vaibhavmagarwal/following{/other_user}","gists_url":"https://api.github.com/users/vaibhavmagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/vaibhavmagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaibhavmagarwal/subscriptions","organizations_url":"https://api.github.com/users/vaibhavmagarwal/orgs","repos_url":"https://api.github.com/users/vaibhavmagarwal/repos","events_url":"https://api.github.com/users/vaibhavmagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/vaibhavmagarwal/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T18:03:14Z","updated_at":"2015-08-12T18:03:14Z","body":"Comparing the files when this issue was filed: https://github.com/armenzg/mozilla_ci_tools/blob/2d822a38a292de7b423da40e9d15be8cc08a7852/mozci/mozci.py#L205 vs now:\r\nhttps://github.com/armenzg/mozilla_ci_tools/blob/master/mozci/mozci.py#L238\r\nWe now also check for \"testPackagesUrl\", so this issue should not occur. @armenzg thoughts?"}}