{"action":"created","issue":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/2296","labels_url":"https://api.github.com/repos/musescore/MuseScore/issues/2296/labels{/name}","comments_url":"https://api.github.com/repos/musescore/MuseScore/issues/2296/comments","events_url":"https://api.github.com/repos/musescore/MuseScore/issues/2296/events","html_url":"https://github.com/musescore/MuseScore/pull/2296","id":118206289,"number":2296,"title":"fix gui scaling regressions for high DPI displays","user":{"login":"MarcSabatella","id":1799936,"avatar_url":"https://avatars.githubusercontent.com/u/1799936?v=3","gravatar_id":"","url":"https://api.github.com/users/MarcSabatella","html_url":"https://github.com/MarcSabatella","followers_url":"https://api.github.com/users/MarcSabatella/followers","following_url":"https://api.github.com/users/MarcSabatella/following{/other_user}","gists_url":"https://api.github.com/users/MarcSabatella/gists{/gist_id}","starred_url":"https://api.github.com/users/MarcSabatella/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarcSabatella/subscriptions","organizations_url":"https://api.github.com/users/MarcSabatella/orgs","repos_url":"https://api.github.com/users/MarcSabatella/repos","events_url":"https://api.github.com/users/MarcSabatella/events{/privacy}","received_events_url":"https://api.github.com/users/MarcSabatella/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-11-21T16:17:18Z","updated_at":"2015-11-24T12:21:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/musescore/MuseScore/pulls/2296","html_url":"https://github.com/musescore/MuseScore/pull/2296","diff_url":"https://github.com/musescore/MuseScore/pull/2296.diff","patch_url":"https://github.com/musescore/MuseScore/pull/2296.patch"},"body":"See discussion in https://musescore.org/en/node/87861, specifically my comments at https://musescore.org/en/node/87861#comment-388486 and below.\r\n\r\nNow that scores are being scaled to physical screen resolution, we don't need the \"-x\" option to perform that function, so I have removed guiScaling from the calculation of physicalDotsPerInch.  And now that we have a good value for physicalDotsPerInch, I have also added code to set a reasonable default value of guiScaling (still needed for icons, palette elements, and window sizes, since they continue to be recorded in physical pixel dimensions).\r\n\r\nThe bottom line is that things now scale correctly for me on my high DPI display on Ubuntu, and I believe my changes should be safe for standard resolution displays.  However, I am not sure what effect my changes will have on Macs with \"retina\" displays, since that OS apparently does some scaling magic that allows the hard coded pixel dimensions to work correctly in most places.  If someone with a retina Mac can test my changes I would greatly appreciate it.  If the result is that icons, palette elements, and example views are now too large, we can ifdef the code in musescore.cpp that sets the default value for guiScaling, so it is always set to 1.0 for Mac rather than being scaled to physicalDotsPerInch.  Or maybe there is a different value thaty is more appropriate to use for Mac, like maybe screen->logicalDotsPerInch().\r\n\r\nOne other thing my code does not get right: while the *scaling* of example views is correct - so the note groups in Time Signature Properties are sized properly - the initial size of the widget is not.  The changes I made to ExampleView::sizeHint() seem like they should be correct, but it seems sizeHint() is being ignored here unelss I change the size policy.  Not sure what changed exactly here, since I think this was working earlier.  But in any case, it seems we should look at this in conjunction with #2288.  My changes here should be good in any case."},"comment":{"url":"https://api.github.com/repos/musescore/MuseScore/issues/comments/159251255","html_url":"https://github.com/musescore/MuseScore/pull/2296#issuecomment-159251255","issue_url":"https://api.github.com/repos/musescore/MuseScore/issues/2296","id":159251255,"user":{"login":"lasconic","id":234271,"avatar_url":"https://avatars.githubusercontent.com/u/234271?v=3","gravatar_id":"","url":"https://api.github.com/users/lasconic","html_url":"https://github.com/lasconic","followers_url":"https://api.github.com/users/lasconic/followers","following_url":"https://api.github.com/users/lasconic/following{/other_user}","gists_url":"https://api.github.com/users/lasconic/gists{/gist_id}","starred_url":"https://api.github.com/users/lasconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lasconic/subscriptions","organizations_url":"https://api.github.com/users/lasconic/orgs","repos_url":"https://api.github.com/users/lasconic/repos","events_url":"https://api.github.com/users/lasconic/events{/privacy}","received_events_url":"https://api.github.com/users/lasconic/received_events","type":"User","site_admin":false},"created_at":"2015-11-24T12:21:44Z","updated_at":"2015-11-24T12:21:44Z","body":"On Mac retina, the palette looks better but the example view is still less good than in 2.0.2 (right).\r\n\r\n<img width=\"1188\" alt=\"capture d ecran 2015-11-24 16 19 02\" src=\"https://cloud.githubusercontent.com/assets/234271/11366536/55581060-92c7-11e5-9edb-96d3384fc1dd.png\">\r\n"}}