{"action":"created","issue":{"url":"https://api.github.com/repos/infinispan/infinispan/issues/3773","labels_url":"https://api.github.com/repos/infinispan/infinispan/issues/3773/labels{/name}","comments_url":"https://api.github.com/repos/infinispan/infinispan/issues/3773/comments","events_url":"https://api.github.com/repos/infinispan/infinispan/issues/3773/events","html_url":"https://github.com/infinispan/infinispan/pull/3773","id":112756258,"number":3773,"title":"ISPN-5803 Cache loaders/stores key/value params are unwrapped","user":{"login":"galderz","id":50187,"avatar_url":"https://avatars.githubusercontent.com/u/50187?v=3","gravatar_id":"","url":"https://api.github.com/users/galderz","html_url":"https://github.com/galderz","followers_url":"https://api.github.com/users/galderz/followers","following_url":"https://api.github.com/users/galderz/following{/other_user}","gists_url":"https://api.github.com/users/galderz/gists{/gist_id}","starred_url":"https://api.github.com/users/galderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galderz/subscriptions","organizations_url":"https://api.github.com/users/galderz/orgs","repos_url":"https://api.github.com/users/galderz/repos","events_url":"https://api.github.com/users/galderz/events{/privacy}","received_events_url":"https://api.github.com/users/galderz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/infinispan/infinispan/labels/Ready%20for%20Review","name":"Ready for Review","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-22T08:38:01Z","updated_at":"2015-10-22T08:38:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/infinispan/infinispan/pulls/3773","html_url":"https://github.com/infinispan/infinispan/pull/3773","diff_url":"https://github.com/infinispan/infinispan/pull/3773.diff","patch_url":"https://github.com/infinispan/infinispan/pull/3773.patch"},"body":"https://issues.jboss.org/browse/ISPN-5803\r\n\r\n* Instead of having the JCache loader/writer adapters deal with\r\n  MarshalledValue handling, make the persistence manager and\r\n  MarshalledEntryImpl deal with the complexity of providing cache store\r\n  implementations with the expected key/value types.\r\n* Key instances passed directly to cache stores are now user types as\r\n  opposed to: user types or marshalled values.\r\n* MarshalledEntryImpl now unwraps key/value instances from\r\n  MarshalledValue if callin getKey()/getValue() but such operations\r\n  should normally not be called by cache stores since they normally\r\n  should deal with byte array format, which is accessible via\r\n  getKeyBytes()/getValueBytes and those do no\r\n  unwrapping.\r\n* DummyCacheStore has been fixed to avoid unnecessary\r\n  serialization/deserialization by calling getValueBytes() in\r\n  MarshalledEntry instead of getValue()."},"comment":{"url":"https://api.github.com/repos/infinispan/infinispan/issues/comments/150148634","html_url":"https://github.com/infinispan/infinispan/pull/3773#issuecomment-150148634","issue_url":"https://api.github.com/repos/infinispan/infinispan/issues/3773","id":150148634,"user":{"login":"galderz","id":50187,"avatar_url":"https://avatars.githubusercontent.com/u/50187?v=3","gravatar_id":"","url":"https://api.github.com/users/galderz","html_url":"https://github.com/galderz","followers_url":"https://api.github.com/users/galderz/followers","following_url":"https://api.github.com/users/galderz/following{/other_user}","gists_url":"https://api.github.com/users/galderz/gists{/gist_id}","starred_url":"https://api.github.com/users/galderz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galderz/subscriptions","organizations_url":"https://api.github.com/users/galderz/orgs","repos_url":"https://api.github.com/users/galderz/repos","events_url":"https://api.github.com/users/galderz/events{/privacy}","received_events_url":"https://api.github.com/users/galderz/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T08:38:23Z","updated_at":"2015-10-22T08:38:23Z","body":"@danberindei @wburns FYI, a reimplementation"}}