{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/37936717","id":37936717,"diff_hunk":"@@ -593,3 +593,46 @@ void JitArm64::fctiwzx(UGeckoInstruction inst)\n \t}\n \tfpr.Unlock(V0);\n }\n+\n+void JitArm64::fdivx(UGeckoInstruction inst)\n+{\n+\tINSTRUCTION_START\n+\tJITDISABLE(bJITFloatingPointOff);\n+\tFALLBACK_IF(inst.Rc);\n+\n+\tu32 a = inst.FA, b = inst.FB, d = inst.FD;\n+\tfpr.BindToRegister(d, true);","path":"Source/Core/Core/PowerPC/JitArm64/JitArm64_FloatingPoint.cpp","position":12,"original_position":12,"commit_id":"0666c0750bf4a35deeeea128ff2671180cce61b3","original_commit_id":"0666c0750bf4a35deeeea128ff2671180cce61b3","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=3","gravatar_id":"","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"body":"That's a good question, why am I just using true?\r\nThis seems like a copy and paste issue that hits every one of the floating point instructions.","created_at":"2015-08-26T00:42:58Z","updated_at":"2015-08-26T00:42:58Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/2904#discussion_r37936717","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/37936717"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2904#discussion_r37936717"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904","id":43217696,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2904","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2904.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2904.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2904","number":2904,"state":"open","locked":false,"title":"[AArch64] Implement fdivx/fdivsx/mfcr/mtcrf.","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=3","gravatar_id":"","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"body":"Gets the povray bench to better times than the Wii.","created_at":"2015-08-24T20:27:57Z","updated_at":"2015-08-26T00:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53514b330cdca4ffc1a569b0fc61ef44c2ebdba0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2904/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/0666c0750bf4a35deeeea128ff2671180cce61b3","head":{"label":"Sonicadvance1:aarch64_more_inst","ref":"aarch64_more_inst","sha":"0666c0750bf4a35deeeea128ff2671180cce61b3","user":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=3","gravatar_id":"","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"repo":{"id":16360220,"name":"dolphin","full_name":"Sonicadvance1/dolphin","owner":{"login":"Sonicadvance1","id":1018829,"avatar_url":"https://avatars.githubusercontent.com/u/1018829?v=3","gravatar_id":"","url":"https://api.github.com/users/Sonicadvance1","html_url":"https://github.com/Sonicadvance1","followers_url":"https://api.github.com/users/Sonicadvance1/followers","following_url":"https://api.github.com/users/Sonicadvance1/following{/other_user}","gists_url":"https://api.github.com/users/Sonicadvance1/gists{/gist_id}","starred_url":"https://api.github.com/users/Sonicadvance1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sonicadvance1/subscriptions","organizations_url":"https://api.github.com/users/Sonicadvance1/orgs","repos_url":"https://api.github.com/users/Sonicadvance1/repos","events_url":"https://api.github.com/users/Sonicadvance1/events{/privacy}","received_events_url":"https://api.github.com/users/Sonicadvance1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Sonicadvance1/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Sonicadvance1/dolphin","forks_url":"https://api.github.com/repos/Sonicadvance1/dolphin/forks","keys_url":"https://api.github.com/repos/Sonicadvance1/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sonicadvance1/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sonicadvance1/dolphin/teams","hooks_url":"https://api.github.com/repos/Sonicadvance1/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Sonicadvance1/dolphin/events","assignees_url":"https://api.github.com/repos/Sonicadvance1/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Sonicadvance1/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Sonicadvance1/dolphin/tags","blobs_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sonicadvance1/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Sonicadvance1/dolphin/languages","stargazers_url":"https://api.github.com/repos/Sonicadvance1/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Sonicadvance1/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Sonicadvance1/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Sonicadvance1/dolphin/subscription","commits_url":"https://api.github.com/repos/Sonicadvance1/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sonicadvance1/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sonicadvance1/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sonicadvance1/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Sonicadvance1/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sonicadvance1/dolphin/merges","archive_url":"https://api.github.com/repos/Sonicadvance1/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sonicadvance1/dolphin/downloads","issues_url":"https://api.github.com/repos/Sonicadvance1/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Sonicadvance1/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Sonicadvance1/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Sonicadvance1/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sonicadvance1/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Sonicadvance1/dolphin/releases{/id}","created_at":"2014-01-29T21:48:46Z","updated_at":"2015-04-16T04:30:55Z","pushed_at":"2015-08-25T21:30:36Z","git_url":"git://github.com/Sonicadvance1/dolphin.git","ssh_url":"git@github.com:Sonicadvance1/dolphin.git","clone_url":"https://github.com/Sonicadvance1/dolphin.git","svn_url":"https://github.com/Sonicadvance1/dolphin","homepage":null,"size":226934,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"d96be9250c8c0d76fba7ec46177cd3739317d493","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-08-25T14:57:04Z","pushed_at":"2015-08-25T22:28:35Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":306019,"stargazers_count":1602,"watchers_count":1602,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":501,"mirror_url":null,"open_issues_count":76,"forks":501,"open_issues":76,"watchers":1602,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2904"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2904"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2904/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2904/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/0666c0750bf4a35deeeea128ff2671180cce61b3"}}}}