{"action":"created","comment":{"url":"https://api.github.com/repos/esl/escalus/pulls/comments/24321753","id":24321753,"diff_hunk":"@@ -121,9 +121,9 @@ session(Conn, Props) ->\n     Props.\n \n use_ssl(Props, Features) ->\n-    UserNeedSSL = proplists:get_value(ssl, Props, false),\n-    StreamAllowSSL = proplists:get_value(starttls, Features),\n-    case {UserNeedSSL, StreamAllowSSL} of\n+    UserNeedsSSL = proplists:get_value(starttls, Props, false),","path":"src/escalus_session.erl","position":7,"original_position":7,"commit_id":"c638f87a154abf732c34477299cfabfdfa92377e","original_commit_id":"c638f87a154abf732c34477299cfabfdfa92377e","user":{"login":"lavrin","id":112145,"avatar_url":"https://avatars.githubusercontent.com/u/112145?v=3","gravatar_id":"","url":"https://api.github.com/users/lavrin","html_url":"https://github.com/lavrin","followers_url":"https://api.github.com/users/lavrin/followers","following_url":"https://api.github.com/users/lavrin/following{/other_user}","gists_url":"https://api.github.com/users/lavrin/gists{/gist_id}","starred_url":"https://api.github.com/users/lavrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavrin/subscriptions","organizations_url":"https://api.github.com/users/lavrin/orgs","repos_url":"https://api.github.com/users/lavrin/repos","events_url":"https://api.github.com/users/lavrin/events{/privacy}","received_events_url":"https://api.github.com/users/lavrin/received_events","type":"User","site_admin":false},"body":"This changes public interface (the configuration file) of the library in a backwards incompatible way (by adding `starttls` and redefining `ssl`). I would have loved it to be reflected in `priv/escalus.config` before bisecting the history in search of this tiny little bit ;)","created_at":"2015-02-09T11:20:56Z","updated_at":"2015-02-09T11:20:56Z","html_url":"https://github.com/esl/escalus/pull/52#discussion_r24321753","pull_request_url":"https://api.github.com/repos/esl/escalus/pulls/52","_links":{"self":{"href":"https://api.github.com/repos/esl/escalus/pulls/comments/24321753"},"html":{"href":"https://github.com/esl/escalus/pull/52#discussion_r24321753"},"pull_request":{"href":"https://api.github.com/repos/esl/escalus/pulls/52"}}},"pull_request":{"url":"https://api.github.com/repos/esl/escalus/pulls/52","id":26228198,"html_url":"https://github.com/esl/escalus/pull/52","diff_url":"https://github.com/esl/escalus/pull/52.diff","patch_url":"https://github.com/esl/escalus/pull/52.patch","issue_url":"https://api.github.com/repos/esl/escalus/issues/52","number":52,"state":"closed","locked":false,"title":"allow legacy ssl connection","user":{"login":"michalwski","id":705828,"avatar_url":"https://avatars.githubusercontent.com/u/705828?v=3","gravatar_id":"","url":"https://api.github.com/users/michalwski","html_url":"https://github.com/michalwski","followers_url":"https://api.github.com/users/michalwski/followers","following_url":"https://api.github.com/users/michalwski/following{/other_user}","gists_url":"https://api.github.com/users/michalwski/gists{/gist_id}","starred_url":"https://api.github.com/users/michalwski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalwski/subscriptions","organizations_url":"https://api.github.com/users/michalwski/orgs","repos_url":"https://api.github.com/users/michalwski/repos","events_url":"https://api.github.com/users/michalwski/events{/privacy}","received_events_url":"https://api.github.com/users/michalwski/received_events","type":"User","site_admin":false},"body":"","created_at":"2014-12-17T14:39:46Z","updated_at":"2015-02-09T11:20:56Z","closed_at":"2014-12-18T14:36:33Z","merged_at":"2014-12-18T14:36:33Z","merge_commit_sha":"cb0603df8cf909192ea27df911680fadc97e68da","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/esl/escalus/pulls/52/commits","review_comments_url":"https://api.github.com/repos/esl/escalus/pulls/52/comments","review_comment_url":"https://api.github.com/repos/esl/escalus/pulls/comments/{number}","comments_url":"https://api.github.com/repos/esl/escalus/issues/52/comments","statuses_url":"https://api.github.com/repos/esl/escalus/statuses/c638f87a154abf732c34477299cfabfdfa92377e","head":{"label":"esl:ssl-connection","ref":"ssl-connection","sha":"c638f87a154abf732c34477299cfabfdfa92377e","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":1934832,"name":"escalus","full_name":"esl/escalus","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/escalus","description":"Erlang library for convenient testing of XMPP servers","fork":false,"url":"https://api.github.com/repos/esl/escalus","forks_url":"https://api.github.com/repos/esl/escalus/forks","keys_url":"https://api.github.com/repos/esl/escalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/escalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/escalus/teams","hooks_url":"https://api.github.com/repos/esl/escalus/hooks","issue_events_url":"https://api.github.com/repos/esl/escalus/issues/events{/number}","events_url":"https://api.github.com/repos/esl/escalus/events","assignees_url":"https://api.github.com/repos/esl/escalus/assignees{/user}","branches_url":"https://api.github.com/repos/esl/escalus/branches{/branch}","tags_url":"https://api.github.com/repos/esl/escalus/tags","blobs_url":"https://api.github.com/repos/esl/escalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/escalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/escalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/escalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/escalus/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/escalus/languages","stargazers_url":"https://api.github.com/repos/esl/escalus/stargazers","contributors_url":"https://api.github.com/repos/esl/escalus/contributors","subscribers_url":"https://api.github.com/repos/esl/escalus/subscribers","subscription_url":"https://api.github.com/repos/esl/escalus/subscription","commits_url":"https://api.github.com/repos/esl/escalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/escalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/escalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/escalus/issues/comments/{number}","contents_url":"https://api.github.com/repos/esl/escalus/contents/{+path}","compare_url":"https://api.github.com/repos/esl/escalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/escalus/merges","archive_url":"https://api.github.com/repos/esl/escalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/escalus/downloads","issues_url":"https://api.github.com/repos/esl/escalus/issues{/number}","pulls_url":"https://api.github.com/repos/esl/escalus/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/escalus/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/escalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/escalus/labels{/name}","releases_url":"https://api.github.com/repos/esl/escalus/releases{/id}","created_at":"2011-06-22T13:03:44Z","updated_at":"2015-02-06T14:30:39Z","pushed_at":"2015-02-06T14:30:43Z","git_url":"git://github.com/esl/escalus.git","ssh_url":"git@github.com:esl/escalus.git","clone_url":"https://github.com/esl/escalus.git","svn_url":"https://github.com/esl/escalus","homepage":"","size":3548,"stargazers_count":37,"watchers_count":37,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":37,"default_branch":"master"}},"base":{"label":"esl:master","ref":"master","sha":"4e28e4426f8e5c7956ba25e0728840eb13aaee7f","user":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"repo":{"id":1934832,"name":"escalus","full_name":"esl/escalus","owner":{"login":"esl","id":283412,"avatar_url":"https://avatars.githubusercontent.com/u/283412?v=3","gravatar_id":"","url":"https://api.github.com/users/esl","html_url":"https://github.com/esl","followers_url":"https://api.github.com/users/esl/followers","following_url":"https://api.github.com/users/esl/following{/other_user}","gists_url":"https://api.github.com/users/esl/gists{/gist_id}","starred_url":"https://api.github.com/users/esl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esl/subscriptions","organizations_url":"https://api.github.com/users/esl/orgs","repos_url":"https://api.github.com/users/esl/repos","events_url":"https://api.github.com/users/esl/events{/privacy}","received_events_url":"https://api.github.com/users/esl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/esl/escalus","description":"Erlang library for convenient testing of XMPP servers","fork":false,"url":"https://api.github.com/repos/esl/escalus","forks_url":"https://api.github.com/repos/esl/escalus/forks","keys_url":"https://api.github.com/repos/esl/escalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esl/escalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esl/escalus/teams","hooks_url":"https://api.github.com/repos/esl/escalus/hooks","issue_events_url":"https://api.github.com/repos/esl/escalus/issues/events{/number}","events_url":"https://api.github.com/repos/esl/escalus/events","assignees_url":"https://api.github.com/repos/esl/escalus/assignees{/user}","branches_url":"https://api.github.com/repos/esl/escalus/branches{/branch}","tags_url":"https://api.github.com/repos/esl/escalus/tags","blobs_url":"https://api.github.com/repos/esl/escalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esl/escalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esl/escalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/esl/escalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esl/escalus/statuses/{sha}","languages_url":"https://api.github.com/repos/esl/escalus/languages","stargazers_url":"https://api.github.com/repos/esl/escalus/stargazers","contributors_url":"https://api.github.com/repos/esl/escalus/contributors","subscribers_url":"https://api.github.com/repos/esl/escalus/subscribers","subscription_url":"https://api.github.com/repos/esl/escalus/subscription","commits_url":"https://api.github.com/repos/esl/escalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/esl/escalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/esl/escalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/esl/escalus/issues/comments/{number}","contents_url":"https://api.github.com/repos/esl/escalus/contents/{+path}","compare_url":"https://api.github.com/repos/esl/escalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esl/escalus/merges","archive_url":"https://api.github.com/repos/esl/escalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esl/escalus/downloads","issues_url":"https://api.github.com/repos/esl/escalus/issues{/number}","pulls_url":"https://api.github.com/repos/esl/escalus/pulls{/number}","milestones_url":"https://api.github.com/repos/esl/escalus/milestones{/number}","notifications_url":"https://api.github.com/repos/esl/escalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esl/escalus/labels{/name}","releases_url":"https://api.github.com/repos/esl/escalus/releases{/id}","created_at":"2011-06-22T13:03:44Z","updated_at":"2015-02-06T14:30:39Z","pushed_at":"2015-02-06T14:30:43Z","git_url":"git://github.com/esl/escalus.git","ssh_url":"git@github.com:esl/escalus.git","clone_url":"https://github.com/esl/escalus.git","svn_url":"https://github.com/esl/escalus","homepage":"","size":3548,"stargazers_count":37,"watchers_count":37,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":7,"forks":24,"open_issues":7,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esl/escalus/pulls/52"},"html":{"href":"https://github.com/esl/escalus/pull/52"},"issue":{"href":"https://api.github.com/repos/esl/escalus/issues/52"},"comments":{"href":"https://api.github.com/repos/esl/escalus/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/esl/escalus/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/esl/escalus/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/esl/escalus/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/esl/escalus/statuses/c638f87a154abf732c34477299cfabfdfa92377e"}}}}