{"action":"created","issue":{"url":"https://api.github.com/repos/npauzenga/address-bloc/issues/1","labels_url":"https://api.github.com/repos/npauzenga/address-bloc/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/npauzenga/address-bloc/issues/1/comments","events_url":"https://api.github.com/repos/npauzenga/address-bloc/issues/1/events","html_url":"https://github.com/npauzenga/address-bloc/pull/1","id":107413643,"number":1,"title":"Assignment 21 completed","user":{"login":"npauzenga","id":5838826,"avatar_url":"https://avatars.githubusercontent.com/u/5838826?v=3","gravatar_id":"","url":"https://api.github.com/users/npauzenga","html_url":"https://github.com/npauzenga","followers_url":"https://api.github.com/users/npauzenga/followers","following_url":"https://api.github.com/users/npauzenga/following{/other_user}","gists_url":"https://api.github.com/users/npauzenga/gists{/gist_id}","starred_url":"https://api.github.com/users/npauzenga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/npauzenga/subscriptions","organizations_url":"https://api.github.com/users/npauzenga/orgs","repos_url":"https://api.github.com/users/npauzenga/repos","events_url":"https://api.github.com/users/npauzenga/events{/privacy}","received_events_url":"https://api.github.com/users/npauzenga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-20T19:50:41Z","updated_at":"2015-09-23T12:57:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/npauzenga/address-bloc/pulls/1","html_url":"https://github.com/npauzenga/address-bloc/pull/1","diff_url":"https://github.com/npauzenga/address-bloc/pull/1.diff","patch_url":"https://github.com/npauzenga/address-bloc/pull/1.patch"},"body":"So I watched the tutorial video and subsequently made some changes. If you check out _spec/address_book_spec.rb_, you'll see lines 43 - 46 commented out. 44 - 46 represent my initial attempt at the test. I was thinking that I could rely on the previous test in the `AddressBook#add_entry` context to add an entry, which I could then remove in the `AddressBook#remove_entry` test. \r\n\r\nIn hindsight this was not a great idea. Not only would it make one test depend on another, it actually doesn't work. The test passed because I was checking to see that the size was == 0 (thinking it was because an entry was removed). Turns out, because I created a new instance of AddressBook in this test there was no previous entry and the size started out at 0. Line 43 is me figuring this out :-)\r\n\r\nAlso, in the actual `AddressBook#remove_entry` method, you'll see I used an index like `add_entry`. Using the `delete_entry` variable might be a little cleaner."},"comment":{"url":"https://api.github.com/repos/npauzenga/address-bloc/issues/comments/142590802","html_url":"https://github.com/npauzenga/address-bloc/pull/1#issuecomment-142590802","issue_url":"https://api.github.com/repos/npauzenga/address-bloc/issues/1","id":142590802,"user":{"login":"Enriikke","id":1388106,"avatar_url":"https://avatars.githubusercontent.com/u/1388106?v=3","gravatar_id":"","url":"https://api.github.com/users/Enriikke","html_url":"https://github.com/Enriikke","followers_url":"https://api.github.com/users/Enriikke/followers","following_url":"https://api.github.com/users/Enriikke/following{/other_user}","gists_url":"https://api.github.com/users/Enriikke/gists{/gist_id}","starred_url":"https://api.github.com/users/Enriikke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enriikke/subscriptions","organizations_url":"https://api.github.com/users/Enriikke/orgs","repos_url":"https://api.github.com/users/Enriikke/repos","events_url":"https://api.github.com/users/Enriikke/events{/privacy}","received_events_url":"https://api.github.com/users/Enriikke/received_events","type":"User","site_admin":false},"created_at":"2015-09-23T12:57:20Z","updated_at":"2015-09-23T12:57:20Z","body":"The changes look great @npauzenga! You can :shipit: now but it looks like you have some merge conflicts :scream:. You will need to get those fixed before you are able to merge. \r\n\r\nSee if you can fix the conflicts and get the PR merged. We can talk more about fixing these type of issues or even go through a simple example on our next session :smile:."}}