{"action":"closed","number":83,"pull_request":{"url":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/83","id":46125177,"html_url":"https://github.com/scragg0x/realms-wiki/pull/83","diff_url":"https://github.com/scragg0x/realms-wiki/pull/83.diff","patch_url":"https://github.com/scragg0x/realms-wiki/pull/83.patch","issue_url":"https://api.github.com/repos/scragg0x/realms-wiki/issues/83","number":83,"state":"closed","locked":false,"title":"Implement delete page","user":{"login":"alvinchow86","id":5131063,"avatar_url":"https://avatars.githubusercontent.com/u/5131063?v=3","gravatar_id":"","url":"https://api.github.com/users/alvinchow86","html_url":"https://github.com/alvinchow86","followers_url":"https://api.github.com/users/alvinchow86/followers","following_url":"https://api.github.com/users/alvinchow86/following{/other_user}","gists_url":"https://api.github.com/users/alvinchow86/gists{/gist_id}","starred_url":"https://api.github.com/users/alvinchow86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alvinchow86/subscriptions","organizations_url":"https://api.github.com/users/alvinchow86/orgs","repos_url":"https://api.github.com/users/alvinchow86/repos","events_url":"https://api.github.com/users/alvinchow86/events{/privacy}","received_events_url":"https://api.github.com/users/alvinchow86/received_events","type":"User","site_admin":false},"body":"Hook up the \"Delete Page\" button and get it working.\r\n\r\nThis is rebased off of https://github.com/scragg0x/realms-wiki/pull/81 because I need some changes from there, to get the actual difference see https://github.com/doordash/realms-wiki/compare/rename-page-fix...doordash:delete-page?expand=1\r\n\r\n- `gittle.rm()` only touches the index, seems like we actually have to remove the file ourselves..\r\n- added some simple JS that prompts the user, and adds a confirmation after successful delete\r\n- apparently `gittle.rm()` (or rather `dulinger`) doesn't take unicode input, had to make sure its UTF8\r\n- fixed the `test_delete_page` test, it wasn't actually really testing anything because no page was created. (before my fix it fails, but passes after)\r\n- upgraded gittle to 0.5.0, why not\r\n\r\n![image](https://cloud.githubusercontent.com/assets/5131063/10129418/69377e5e-6572-11e5-9a5e-4d1e037d8f0a.png)\r\n![image](https://cloud.githubusercontent.com/assets/5131063/10129525/e7476b5a-6573-11e5-8b83-5e8e0abac537.png)\r\n\r\n\r\nMore than happy to make any tweaks or style fixes if needed","created_at":"2015-09-28T06:57:21Z","updated_at":"2015-09-30T19:27:28Z","closed_at":"2015-09-30T19:27:28Z","merged_at":"2015-09-30T19:27:28Z","merge_commit_sha":"c16167904fa574f2af3d13e50cf3187cb34b1c84","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/83/commits","review_comments_url":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/83/comments","review_comment_url":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scragg0x/realms-wiki/issues/83/comments","statuses_url":"https://api.github.com/repos/scragg0x/realms-wiki/statuses/4e4cdf6348749e14983834e966cc76c5050cf3e0","head":{"label":"doordash:delete-page","ref":"delete-page","sha":"4e4cdf6348749e14983834e966cc76c5050cf3e0","user":{"login":"doordash","id":7462138,"avatar_url":"https://avatars.githubusercontent.com/u/7462138?v=3","gravatar_id":"","url":"https://api.github.com/users/doordash","html_url":"https://github.com/doordash","followers_url":"https://api.github.com/users/doordash/followers","following_url":"https://api.github.com/users/doordash/following{/other_user}","gists_url":"https://api.github.com/users/doordash/gists{/gist_id}","starred_url":"https://api.github.com/users/doordash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doordash/subscriptions","organizations_url":"https://api.github.com/users/doordash/orgs","repos_url":"https://api.github.com/users/doordash/repos","events_url":"https://api.github.com/users/doordash/events{/privacy}","received_events_url":"https://api.github.com/users/doordash/received_events","type":"Organization","site_admin":false},"repo":{"id":43101074,"name":"realms-wiki","full_name":"doordash/realms-wiki","owner":{"login":"doordash","id":7462138,"avatar_url":"https://avatars.githubusercontent.com/u/7462138?v=3","gravatar_id":"","url":"https://api.github.com/users/doordash","html_url":"https://github.com/doordash","followers_url":"https://api.github.com/users/doordash/followers","following_url":"https://api.github.com/users/doordash/following{/other_user}","gists_url":"https://api.github.com/users/doordash/gists{/gist_id}","starred_url":"https://api.github.com/users/doordash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doordash/subscriptions","organizations_url":"https://api.github.com/users/doordash/orgs","repos_url":"https://api.github.com/users/doordash/repos","events_url":"https://api.github.com/users/doordash/events{/privacy}","received_events_url":"https://api.github.com/users/doordash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doordash/realms-wiki","description":"Git based wiki inspired by Gollum","fork":true,"url":"https://api.github.com/repos/doordash/realms-wiki","forks_url":"https://api.github.com/repos/doordash/realms-wiki/forks","keys_url":"https://api.github.com/repos/doordash/realms-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doordash/realms-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doordash/realms-wiki/teams","hooks_url":"https://api.github.com/repos/doordash/realms-wiki/hooks","issue_events_url":"https://api.github.com/repos/doordash/realms-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/doordash/realms-wiki/events","assignees_url":"https://api.github.com/repos/doordash/realms-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/doordash/realms-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/doordash/realms-wiki/tags","blobs_url":"https://api.github.com/repos/doordash/realms-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doordash/realms-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doordash/realms-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/doordash/realms-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doordash/realms-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/doordash/realms-wiki/languages","stargazers_url":"https://api.github.com/repos/doordash/realms-wiki/stargazers","contributors_url":"https://api.github.com/repos/doordash/realms-wiki/contributors","subscribers_url":"https://api.github.com/repos/doordash/realms-wiki/subscribers","subscription_url":"https://api.github.com/repos/doordash/realms-wiki/subscription","commits_url":"https://api.github.com/repos/doordash/realms-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/doordash/realms-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/doordash/realms-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/doordash/realms-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/doordash/realms-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/doordash/realms-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doordash/realms-wiki/merges","archive_url":"https://api.github.com/repos/doordash/realms-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doordash/realms-wiki/downloads","issues_url":"https://api.github.com/repos/doordash/realms-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/doordash/realms-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/doordash/realms-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/doordash/realms-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doordash/realms-wiki/labels{/name}","releases_url":"https://api.github.com/repos/doordash/realms-wiki/releases{/id}","created_at":"2015-09-25T00:50:29Z","updated_at":"2015-09-25T00:50:30Z","pushed_at":"2015-09-30T00:14:07Z","git_url":"git://github.com/doordash/realms-wiki.git","ssh_url":"git@github.com:doordash/realms-wiki.git","clone_url":"https://github.com/doordash/realms-wiki.git","svn_url":"https://github.com/doordash/realms-wiki","homepage":"http://realms.io","size":2327,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scragg0x:master","ref":"master","sha":"459a9c2c597ee0a7faa24962bb2a4c0d1f362f78","user":{"login":"scragg0x","id":222611,"avatar_url":"https://avatars.githubusercontent.com/u/222611?v=3","gravatar_id":"","url":"https://api.github.com/users/scragg0x","html_url":"https://github.com/scragg0x","followers_url":"https://api.github.com/users/scragg0x/followers","following_url":"https://api.github.com/users/scragg0x/following{/other_user}","gists_url":"https://api.github.com/users/scragg0x/gists{/gist_id}","starred_url":"https://api.github.com/users/scragg0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scragg0x/subscriptions","organizations_url":"https://api.github.com/users/scragg0x/orgs","repos_url":"https://api.github.com/users/scragg0x/repos","events_url":"https://api.github.com/users/scragg0x/events{/privacy}","received_events_url":"https://api.github.com/users/scragg0x/received_events","type":"User","site_admin":false},"repo":{"id":23153684,"name":"realms-wiki","full_name":"scragg0x/realms-wiki","owner":{"login":"scragg0x","id":222611,"avatar_url":"https://avatars.githubusercontent.com/u/222611?v=3","gravatar_id":"","url":"https://api.github.com/users/scragg0x","html_url":"https://github.com/scragg0x","followers_url":"https://api.github.com/users/scragg0x/followers","following_url":"https://api.github.com/users/scragg0x/following{/other_user}","gists_url":"https://api.github.com/users/scragg0x/gists{/gist_id}","starred_url":"https://api.github.com/users/scragg0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scragg0x/subscriptions","organizations_url":"https://api.github.com/users/scragg0x/orgs","repos_url":"https://api.github.com/users/scragg0x/repos","events_url":"https://api.github.com/users/scragg0x/events{/privacy}","received_events_url":"https://api.github.com/users/scragg0x/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/scragg0x/realms-wiki","description":"Git based wiki inspired by Gollum","fork":false,"url":"https://api.github.com/repos/scragg0x/realms-wiki","forks_url":"https://api.github.com/repos/scragg0x/realms-wiki/forks","keys_url":"https://api.github.com/repos/scragg0x/realms-wiki/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scragg0x/realms-wiki/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scragg0x/realms-wiki/teams","hooks_url":"https://api.github.com/repos/scragg0x/realms-wiki/hooks","issue_events_url":"https://api.github.com/repos/scragg0x/realms-wiki/issues/events{/number}","events_url":"https://api.github.com/repos/scragg0x/realms-wiki/events","assignees_url":"https://api.github.com/repos/scragg0x/realms-wiki/assignees{/user}","branches_url":"https://api.github.com/repos/scragg0x/realms-wiki/branches{/branch}","tags_url":"https://api.github.com/repos/scragg0x/realms-wiki/tags","blobs_url":"https://api.github.com/repos/scragg0x/realms-wiki/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scragg0x/realms-wiki/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scragg0x/realms-wiki/git/refs{/sha}","trees_url":"https://api.github.com/repos/scragg0x/realms-wiki/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scragg0x/realms-wiki/statuses/{sha}","languages_url":"https://api.github.com/repos/scragg0x/realms-wiki/languages","stargazers_url":"https://api.github.com/repos/scragg0x/realms-wiki/stargazers","contributors_url":"https://api.github.com/repos/scragg0x/realms-wiki/contributors","subscribers_url":"https://api.github.com/repos/scragg0x/realms-wiki/subscribers","subscription_url":"https://api.github.com/repos/scragg0x/realms-wiki/subscription","commits_url":"https://api.github.com/repos/scragg0x/realms-wiki/commits{/sha}","git_commits_url":"https://api.github.com/repos/scragg0x/realms-wiki/git/commits{/sha}","comments_url":"https://api.github.com/repos/scragg0x/realms-wiki/comments{/number}","issue_comment_url":"https://api.github.com/repos/scragg0x/realms-wiki/issues/comments{/number}","contents_url":"https://api.github.com/repos/scragg0x/realms-wiki/contents/{+path}","compare_url":"https://api.github.com/repos/scragg0x/realms-wiki/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scragg0x/realms-wiki/merges","archive_url":"https://api.github.com/repos/scragg0x/realms-wiki/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scragg0x/realms-wiki/downloads","issues_url":"https://api.github.com/repos/scragg0x/realms-wiki/issues{/number}","pulls_url":"https://api.github.com/repos/scragg0x/realms-wiki/pulls{/number}","milestones_url":"https://api.github.com/repos/scragg0x/realms-wiki/milestones{/number}","notifications_url":"https://api.github.com/repos/scragg0x/realms-wiki/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scragg0x/realms-wiki/labels{/name}","releases_url":"https://api.github.com/repos/scragg0x/realms-wiki/releases{/id}","created_at":"2014-08-20T15:26:57Z","updated_at":"2015-09-29T11:44:30Z","pushed_at":"2015-09-30T19:27:28Z","git_url":"git://github.com/scragg0x/realms-wiki.git","ssh_url":"git@github.com:scragg0x/realms-wiki.git","clone_url":"https://github.com/scragg0x/realms-wiki.git","svn_url":"https://github.com/scragg0x/realms-wiki","homepage":"http://realms.io","size":2949,"stargazers_count":403,"watchers_count":403,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"open_issues_count":31,"forks":52,"open_issues":31,"watchers":403,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/83"},"html":{"href":"https://github.com/scragg0x/realms-wiki/pull/83"},"issue":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/issues/83"},"comments":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/scragg0x/realms-wiki/statuses/4e4cdf6348749e14983834e966cc76c5050cf3e0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"scragg0x","id":222611,"avatar_url":"https://avatars.githubusercontent.com/u/222611?v=3","gravatar_id":"","url":"https://api.github.com/users/scragg0x","html_url":"https://github.com/scragg0x","followers_url":"https://api.github.com/users/scragg0x/followers","following_url":"https://api.github.com/users/scragg0x/following{/other_user}","gists_url":"https://api.github.com/users/scragg0x/gists{/gist_id}","starred_url":"https://api.github.com/users/scragg0x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scragg0x/subscriptions","organizations_url":"https://api.github.com/users/scragg0x/orgs","repos_url":"https://api.github.com/users/scragg0x/repos","events_url":"https://api.github.com/users/scragg0x/events{/privacy}","received_events_url":"https://api.github.com/users/scragg0x/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":3,"additions":74,"deletions":11,"changed_files":8}}