{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/30215136","id":30215136,"diff_hunk":"@@ -1288,7 +1288,11 @@ Namespace Microsoft.CodeAnalysis.VisualBasic.Extensions\n                     End If\n \n                     Dim aliasInfo = semanticModel.GetAliasInfo(name, cancellationToken)\n-                    If nameHasNoAlias AndAlso aliasInfo Is Nothing Then\n+\n+                    ' Don't simplify to predefined type if name is part of a QualifiedName.\n+                    ' QualifiedNames can't contain PredefinedTypeNames (although MemberAccessExpressions can).\n+                    ' In other words, the left side of a QualifiedName can't be a PredefinedTypeName.\n+                    If nameHasNoAlias AndAlso aliasInfo Is Nothing AndAlso Not name.Parent.IsKind(SyntaxKind.QualifiedName) Then","path":"src/Workspaces/VisualBasic/Portable/Extensions/ExpressionSyntaxExtensions.vb","position":9,"original_position":9,"commit_id":"490d62c1e5723662ff6809cf1fae6f57def2d7bb","original_commit_id":"490d62c1e5723662ff6809cf1fae6f57def2d7bb","user":{"login":"heejaechang","id":1333179,"avatar_url":"https://avatars.githubusercontent.com/u/1333179?v=3","gravatar_id":"","url":"https://api.github.com/users/heejaechang","html_url":"https://github.com/heejaechang","followers_url":"https://api.github.com/users/heejaechang/followers","following_url":"https://api.github.com/users/heejaechang/following{/other_user}","gists_url":"https://api.github.com/users/heejaechang/gists{/gist_id}","starred_url":"https://api.github.com/users/heejaechang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heejaechang/subscriptions","organizations_url":"https://api.github.com/users/heejaechang/orgs","repos_url":"https://api.github.com/users/heejaechang/repos","events_url":"https://api.github.com/users/heejaechang/events{/privacy}","received_events_url":"https://api.github.com/users/heejaechang/received_events","type":"User","site_admin":false},"body":"can we reduce number of \"If\", it has like 4 if and not sure what if affects what.","created_at":"2015-05-13T09:28:59Z","updated_at":"2015-05-13T09:28:59Z","html_url":"https://github.com/dotnet/roslyn/pull/2704#discussion_r30215136","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2704","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/30215136"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2704#discussion_r30215136"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2704"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/2704","id":35290457,"html_url":"https://github.com/dotnet/roslyn/pull/2704","diff_url":"https://github.com/dotnet/roslyn/pull/2704.diff","patch_url":"https://github.com/dotnet/roslyn/pull/2704.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/2704","number":2704,"state":"open","locked":false,"title":"Fix an InvalidCastException in simplifier.","user":{"login":"shyamnamboodiripad","id":10579684,"avatar_url":"https://avatars.githubusercontent.com/u/10579684?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamnamboodiripad","html_url":"https://github.com/shyamnamboodiripad","followers_url":"https://api.github.com/users/shyamnamboodiripad/followers","following_url":"https://api.github.com/users/shyamnamboodiripad/following{/other_user}","gists_url":"https://api.github.com/users/shyamnamboodiripad/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamnamboodiripad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamnamboodiripad/subscriptions","organizations_url":"https://api.github.com/users/shyamnamboodiripad/orgs","repos_url":"https://api.github.com/users/shyamnamboodiripad/repos","events_url":"https://api.github.com/users/shyamnamboodiripad/events{/privacy}","received_events_url":"https://api.github.com/users/shyamnamboodiripad/received_events","type":"User","site_admin":false},"body":"Fixes #2232\r\n\r\nPrevent crash by avoiding QualifiedName->PredefinedTypeName simplification inside QualifiedNames.","created_at":"2015-05-13T02:59:47Z","updated_at":"2015-05-13T09:28:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41276b83b317a2f2760d688908fdf71461a72cc9","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2704/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/2704/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/2704/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/490d62c1e5723662ff6809cf1fae6f57def2d7bb","head":{"label":"shyamnamboodiripad:FixInvalidCastInSimplifier","ref":"FixInvalidCastInSimplifier","sha":"490d62c1e5723662ff6809cf1fae6f57def2d7bb","user":{"login":"shyamnamboodiripad","id":10579684,"avatar_url":"https://avatars.githubusercontent.com/u/10579684?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamnamboodiripad","html_url":"https://github.com/shyamnamboodiripad","followers_url":"https://api.github.com/users/shyamnamboodiripad/followers","following_url":"https://api.github.com/users/shyamnamboodiripad/following{/other_user}","gists_url":"https://api.github.com/users/shyamnamboodiripad/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamnamboodiripad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamnamboodiripad/subscriptions","organizations_url":"https://api.github.com/users/shyamnamboodiripad/orgs","repos_url":"https://api.github.com/users/shyamnamboodiripad/repos","events_url":"https://api.github.com/users/shyamnamboodiripad/events{/privacy}","received_events_url":"https://api.github.com/users/shyamnamboodiripad/received_events","type":"User","site_admin":false},"repo":{"id":30558724,"name":"roslyn","full_name":"shyamnamboodiripad/roslyn","owner":{"login":"shyamnamboodiripad","id":10579684,"avatar_url":"https://avatars.githubusercontent.com/u/10579684?v=3","gravatar_id":"","url":"https://api.github.com/users/shyamnamboodiripad","html_url":"https://github.com/shyamnamboodiripad","followers_url":"https://api.github.com/users/shyamnamboodiripad/followers","following_url":"https://api.github.com/users/shyamnamboodiripad/following{/other_user}","gists_url":"https://api.github.com/users/shyamnamboodiripad/gists{/gist_id}","starred_url":"https://api.github.com/users/shyamnamboodiripad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shyamnamboodiripad/subscriptions","organizations_url":"https://api.github.com/users/shyamnamboodiripad/orgs","repos_url":"https://api.github.com/users/shyamnamboodiripad/repos","events_url":"https://api.github.com/users/shyamnamboodiripad/events{/privacy}","received_events_url":"https://api.github.com/users/shyamnamboodiripad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shyamnamboodiripad/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/shyamnamboodiripad/roslyn","forks_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/forks","keys_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/teams","hooks_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/hooks","issue_events_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/events","assignees_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/tags","blobs_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/languages","stargazers_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/stargazers","contributors_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/contributors","subscribers_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/subscribers","subscription_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/subscription","commits_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/merges","archive_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/downloads","issues_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/shyamnamboodiripad/roslyn/releases{/id}","created_at":"2015-02-09T21:12:20Z","updated_at":"2015-04-27T21:51:00Z","pushed_at":"2015-05-13T02:59:26Z","git_url":"git://github.com/shyamnamboodiripad/roslyn.git","ssh_url":"git@github.com:shyamnamboodiripad/roslyn.git","clone_url":"https://github.com/shyamnamboodiripad/roslyn.git","svn_url":"https://github.com/shyamnamboodiripad/roslyn","homepage":"","size":73352,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1cc2fcc5ee009e353f501eb501a15f79c7993db6","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","created_at":"2015-01-11T02:39:03Z","updated_at":"2015-05-13T08:54:05Z","pushed_at":"2015-05-13T05:13:23Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":129681,"stargazers_count":2278,"watchers_count":2278,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":483,"mirror_url":null,"open_issues_count":817,"forks":483,"open_issues":817,"watchers":2278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2704"},"html":{"href":"https://github.com/dotnet/roslyn/pull/2704"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2704"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/2704/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2704/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/2704/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/490d62c1e5723662ff6809cf1fae6f57def2d7bb"}}}}