{"action":"created","comment":{"url":"https://api.github.com/repos/numpy/numpy/pulls/comments/27092916","id":27092916,"diff_hunk":"@@ -317,12 +317,14 @@ def _write_array_header(fp, d, version=None):\n     if len(header) >= (256*256) and version == (1, 0):\n         raise ValueError(\"header does not fit inside %s bytes required by the\"\n                          \" 1.0 format\" % (256*256))\n-    if len(header) < (256*256):\n+    elif len(header) < (256*256):\n+        if version is None:\n+            version = (1, 0)\n         header_len_str = struct.pack('<H', len(header))\n-        version = (1, 0)","path":"numpy/lib/format.py","position":9,"original_position":9,"commit_id":"632f9c2439b356ce312bfa4ed3b2645353773de7","original_commit_id":"632f9c2439b356ce312bfa4ed3b2645353773de7","user":{"login":"charris","id":77272,"avatar_url":"https://avatars.githubusercontent.com/u/77272?v=3","gravatar_id":"","url":"https://api.github.com/users/charris","html_url":"https://github.com/charris","followers_url":"https://api.github.com/users/charris/followers","following_url":"https://api.github.com/users/charris/following{/other_user}","gists_url":"https://api.github.com/users/charris/gists{/gist_id}","starred_url":"https://api.github.com/users/charris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charris/subscriptions","organizations_url":"https://api.github.com/users/charris/orgs","repos_url":"https://api.github.com/users/charris/repos","events_url":"https://api.github.com/users/charris/events{/privacy}","received_events_url":"https://api.github.com/users/charris/received_events","type":"User","site_admin":false},"body":"Changing behavior here. I think the point was to only use (2, 0) for big files.","created_at":"2015-03-25T03:31:42Z","updated_at":"2015-03-25T03:31:42Z","html_url":"https://github.com/numpy/numpy/pull/5713#discussion_r27092916","pull_request_url":"https://api.github.com/repos/numpy/numpy/pulls/5713","_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments/27092916"},"html":{"href":"https://github.com/numpy/numpy/pull/5713#discussion_r27092916"},"pull_request":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5713"}}},"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/5713","id":31797709,"html_url":"https://github.com/numpy/numpy/pull/5713","diff_url":"https://github.com/numpy/numpy/pull/5713.diff","patch_url":"https://github.com/numpy/numpy/pull/5713.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/5713","number":5713,"state":"open","locked":false,"title":"Fix read_array_header_*","user":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?v=3","gravatar_id":"","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"body":"This fixes #5712 ","created_at":"2015-03-24T05:07:56Z","updated_at":"2015-03-25T03:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7707c7c8d26109473a30da53544d2b7d9c4fdc07","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/5713/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/5713/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/5713/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/632f9c2439b356ce312bfa4ed3b2645353773de7","head":{"label":"cowlicks:bug-5712","ref":"bug-5712","sha":"632f9c2439b356ce312bfa4ed3b2645353773de7","user":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?v=3","gravatar_id":"","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"repo":{"id":9528335,"name":"numpy","full_name":"cowlicks/numpy","owner":{"login":"cowlicks","id":598099,"avatar_url":"https://avatars.githubusercontent.com/u/598099?v=3","gravatar_id":"","url":"https://api.github.com/users/cowlicks","html_url":"https://github.com/cowlicks","followers_url":"https://api.github.com/users/cowlicks/followers","following_url":"https://api.github.com/users/cowlicks/following{/other_user}","gists_url":"https://api.github.com/users/cowlicks/gists{/gist_id}","starred_url":"https://api.github.com/users/cowlicks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cowlicks/subscriptions","organizations_url":"https://api.github.com/users/cowlicks/orgs","repos_url":"https://api.github.com/users/cowlicks/repos","events_url":"https://api.github.com/users/cowlicks/events{/privacy}","received_events_url":"https://api.github.com/users/cowlicks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cowlicks/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/cowlicks/numpy","forks_url":"https://api.github.com/repos/cowlicks/numpy/forks","keys_url":"https://api.github.com/repos/cowlicks/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cowlicks/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cowlicks/numpy/teams","hooks_url":"https://api.github.com/repos/cowlicks/numpy/hooks","issue_events_url":"https://api.github.com/repos/cowlicks/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/cowlicks/numpy/events","assignees_url":"https://api.github.com/repos/cowlicks/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/cowlicks/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/cowlicks/numpy/tags","blobs_url":"https://api.github.com/repos/cowlicks/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cowlicks/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cowlicks/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/cowlicks/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cowlicks/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/cowlicks/numpy/languages","stargazers_url":"https://api.github.com/repos/cowlicks/numpy/stargazers","contributors_url":"https://api.github.com/repos/cowlicks/numpy/contributors","subscribers_url":"https://api.github.com/repos/cowlicks/numpy/subscribers","subscription_url":"https://api.github.com/repos/cowlicks/numpy/subscription","commits_url":"https://api.github.com/repos/cowlicks/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/cowlicks/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/cowlicks/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/cowlicks/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/cowlicks/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/cowlicks/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cowlicks/numpy/merges","archive_url":"https://api.github.com/repos/cowlicks/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cowlicks/numpy/downloads","issues_url":"https://api.github.com/repos/cowlicks/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/cowlicks/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/cowlicks/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/cowlicks/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cowlicks/numpy/labels{/name}","releases_url":"https://api.github.com/repos/cowlicks/numpy/releases{/id}","created_at":"2013-04-18T18:07:44Z","updated_at":"2015-03-24T04:56:44Z","pushed_at":"2015-03-25T02:51:18Z","git_url":"git://github.com/cowlicks/numpy.git","ssh_url":"git@github.com:cowlicks/numpy.git","clone_url":"https://github.com/cowlicks/numpy.git","svn_url":"https://github.com/cowlicks/numpy","homepage":"http://www.numpy.org/","size":38560,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"e3101647ef7c262fa6b4ddc8fdf79453f8a1e05c","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars.githubusercontent.com/u/288276?v=3","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","created_at":"2010-09-13T23:02:39Z","updated_at":"2015-03-25T02:50:02Z","pushed_at":"2015-03-25T02:51:20Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":62893,"stargazers_count":1839,"watchers_count":1839,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":920,"mirror_url":null,"open_issues_count":827,"forks":920,"open_issues":827,"watchers":1839,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5713"},"html":{"href":"https://github.com/numpy/numpy/pull/5713"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/5713"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/5713/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5713/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/5713/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/632f9c2439b356ce312bfa4ed3b2645353773de7"}}}}