{"action":"created","issue":{"url":"https://api.github.com/repos/libigl/libigl/issues/118","labels_url":"https://api.github.com/repos/libigl/libigl/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/libigl/libigl/issues/118/comments","events_url":"https://api.github.com/repos/libigl/libigl/issues/118/events","html_url":"https://github.com/libigl/libigl/pull/118","id":106797822,"number":118,"title":"Moved GTest submodule to external.","user":{"login":"qnzhou","id":3606672,"avatar_url":"https://avatars.githubusercontent.com/u/3606672?v=3","gravatar_id":"","url":"https://api.github.com/users/qnzhou","html_url":"https://github.com/qnzhou","followers_url":"https://api.github.com/users/qnzhou/followers","following_url":"https://api.github.com/users/qnzhou/following{/other_user}","gists_url":"https://api.github.com/users/qnzhou/gists{/gist_id}","starred_url":"https://api.github.com/users/qnzhou/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qnzhou/subscriptions","organizations_url":"https://api.github.com/users/qnzhou/orgs","repos_url":"https://api.github.com/users/qnzhou/repos","events_url":"https://api.github.com/users/qnzhou/events{/privacy}","received_events_url":"https://api.github.com/users/qnzhou/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-16T15:27:37Z","updated_at":"2015-09-17T12:19:46Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/libigl/libigl/pulls/118","html_url":"https://github.com/libigl/libigl/pull/118","diff_url":"https://github.com/libigl/libigl/pull/118.diff","patch_url":"https://github.com/libigl/libigl/pull/118.patch"},"body":"As discussed in pull request #116 , google unit test submodule is moved to the external folder."},"comment":{"url":"https://api.github.com/repos/libigl/libigl/issues/comments/141061794","html_url":"https://github.com/libigl/libigl/pull/118#issuecomment-141061794","issue_url":"https://api.github.com/repos/libigl/libigl/issues/118","id":141061794,"user":{"login":"alecjacobson","id":2241689,"avatar_url":"https://avatars.githubusercontent.com/u/2241689?v=3","gravatar_id":"","url":"https://api.github.com/users/alecjacobson","html_url":"https://github.com/alecjacobson","followers_url":"https://api.github.com/users/alecjacobson/followers","following_url":"https://api.github.com/users/alecjacobson/following{/other_user}","gists_url":"https://api.github.com/users/alecjacobson/gists{/gist_id}","starred_url":"https://api.github.com/users/alecjacobson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alecjacobson/subscriptions","organizations_url":"https://api.github.com/users/alecjacobson/orgs","repos_url":"https://api.github.com/users/alecjacobson/repos","events_url":"https://api.github.com/users/alecjacobson/events{/privacy}","received_events_url":"https://api.github.com/users/alecjacobson/received_events","type":"User","site_admin":false},"created_at":"2015-09-17T12:19:46Z","updated_at":"2015-09-17T12:19:46Z","body":"eek. Is this a new problem? Is it related to GTest? If it's unrelated, then\nplease post a github issue with the errors, perhaps Daniele will have some\nideas.\n\nOn Wed, Sep 16, 2015 at 11:15 PM, Qingnan Zhou <notifications@github.com>\nwrote:\n\n> I have verified that the old google test directory is deleted, but I am\n> having a lot of trouble getting embree (required by the tutorial) to\n> compile properly using the script. I got errors about invalid gcc-4.9.3\n> compiler option ``-stdlib=libc++``. When I switch to clang-3.6.0, the\n> compilation failed because undefined symbol ``xgetbv`` not defined.\n>\n> On Wed, Sep 16, 2015 at 12:04 PM, Alec Jacobson <notifications@github.com>\n> wrote:\n>\n> > Could you make sure that the old ay module folder is deleted and verify\n> > that the scripts/clone_and_build.sh executes correctly? The last pull\n> > request broke the submodules...\n> >\n> > On Wednesday, September 16, 2015, Qingnan Zhou <notifications@github.com\n> >\n> > wrote:\n> >\n> > > As discussed in pull request #116\n> > > <https://github.com/libigl/libigl/pull/116> , google unit test\n> submodule\n> > > is moved to the external folder.\n> > > ------------------------------\n> > > You can view, comment on, or merge this pull request online at:\n> > >\n> > > https://github.com/libigl/libigl/pull/118\n> > > Commit Summary\n> > >\n> > > - Moved GTest submodule to external.\n> > >\n> > > File Changes\n> > >\n> > > - *M* .gitmodules\n> > > <https://github.com/libigl/libigl/pull/118/files#diff-0> (4)\n> > > - *R* external/googletest\n> > > <https://github.com/libigl/libigl/pull/118/files#diff-1> (0)\n> > > - *M* tests/Settings.cmake\n> > > <https://github.com/libigl/libigl/pull/118/files#diff-2> (3)\n> > >\n> > > Patch Links:\n> > >\n> > > - https://github.com/libigl/libigl/pull/118.patch\n> > > - https://github.com/libigl/libigl/pull/118.diff\n> > >\n> > > —\n> > > Reply to this email directly or view it on GitHub\n> > > <https://github.com/libigl/libigl/pull/118>.\n> > >\n> >\n> > —\n> > Reply to this email directly or view it on GitHub\n> > <https://github.com/libigl/libigl/pull/118#issuecomment-140788886>.\n>\n> >\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/libigl/libigl/pull/118#issuecomment-140956995>.\n>\n"}}