{"action":"created","comment":{"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/24203776","id":24203776,"diff_hunk":"@@ -440,7 +441,7 @@ public CacheHeader(String key, Entry entry) {\n          * @param is The InputStream to read from.\n          * @throws IOException\n          */\n-        public static CacheHeader readHeader(InputStream is) throws IOException {\n+        public static CacheHeader readHeader(InputStream is, boolean readFull) throws IOException {","path":"src/com/android/volley/toolbox/DiskBasedCache.java","position":34,"original_position":34,"commit_id":"388d83c5e4ffb42e3cef06a334c9860f91786d80","original_commit_id":"388d83c5e4ffb42e3cef06a334c9860f91786d80","user":{"login":"elihart","id":2739242,"avatar_url":"https://avatars.githubusercontent.com/u/2739242?v=3","gravatar_id":"","url":"https://api.github.com/users/elihart","html_url":"https://github.com/elihart","followers_url":"https://api.github.com/users/elihart/followers","following_url":"https://api.github.com/users/elihart/following{/other_user}","gists_url":"https://api.github.com/users/elihart/gists{/gist_id}","starred_url":"https://api.github.com/users/elihart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elihart/subscriptions","organizations_url":"https://api.github.com/users/elihart/orgs","repos_url":"https://api.github.com/users/elihart/repos","events_url":"https://api.github.com/users/elihart/events{/privacy}","received_events_url":"https://api.github.com/users/elihart/received_events","type":"User","site_admin":false},"body":"Could rename `readFull` to be more descriptive like `readHeaders`, `includeHeaders', `saveHeaders` etc","created_at":"2015-02-05T21:58:52Z","updated_at":"2015-02-05T21:58:52Z","html_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/71#discussion_r24203776","pull_request_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71","_links":{"self":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/24203776"},"html":{"href":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/71#discussion_r24203776"},"pull_request":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71"}}},"pull_request":{"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71","id":28530390,"html_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/71","diff_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/71.diff","patch_url":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/71.patch","issue_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/71","number":71,"state":"open","locked":false,"title":"save memory with cache headers","user":{"login":"nwadams","id":879170,"avatar_url":"https://avatars.githubusercontent.com/u/879170?v=3","gravatar_id":"","url":"https://api.github.com/users/nwadams","html_url":"https://github.com/nwadams","followers_url":"https://api.github.com/users/nwadams/followers","following_url":"https://api.github.com/users/nwadams/following{/other_user}","gists_url":"https://api.github.com/users/nwadams/gists{/gist_id}","starred_url":"https://api.github.com/users/nwadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwadams/subscriptions","organizations_url":"https://api.github.com/users/nwadams/orgs","repos_url":"https://api.github.com/users/nwadams/repos","events_url":"https://api.github.com/users/nwadams/events{/privacy}","received_events_url":"https://api.github.com/users/nwadams/received_events","type":"User","site_admin":false},"body":"save a bunch of memory by not parsing all the cache headers up front\r\n@lxdvs ","created_at":"2015-02-03T06:46:40Z","updated_at":"2015-02-05T21:58:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85ec5db5b22d82e50db5ef49953e0b0a9c5b8344","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71/commits","review_comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71/comments","review_comment_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/71/comments","statuses_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/388d83c5e4ffb42e3cef06a334c9860f91786d80","head":{"label":"lxdvs:nick/cache_headers","ref":"nick/cache_headers","sha":"388d83c5e4ffb42e3cef06a334c9860f91786d80","user":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"repo":{"id":10260163,"name":"Volley-OkHttp-Android","full_name":"lxdvs/Volley-OkHttp-Android","owner":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lxdvs/Volley-OkHttp-Android","description":"This is a clone of Volley, with the relevant changes made to make it work with Square's OkHttp library. It also has Jackson integrated to provide a convenient object model.","fork":false,"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android","forks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/forks","keys_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/teams","hooks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/hooks","issue_events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/events{/number}","events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/events","assignees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/assignees{/user}","branches_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/branches{/branch}","tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/tags","blobs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/languages","stargazers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/stargazers","contributors_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contributors","subscribers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscribers","subscription_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscription","commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contents/{+path}","compare_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/merges","archive_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/downloads","issues_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues{/number}","pulls_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/labels{/name}","releases_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/releases{/id}","created_at":"2013-05-24T05:53:31Z","updated_at":"2015-02-05T08:25:48Z","pushed_at":"2015-02-03T22:30:15Z","git_url":"git://github.com/lxdvs/Volley-OkHttp-Android.git","ssh_url":"git@github.com:lxdvs/Volley-OkHttp-Android.git","clone_url":"https://github.com/lxdvs/Volley-OkHttp-Android.git","svn_url":"https://github.com/lxdvs/Volley-OkHttp-Android","homepage":"","size":7487,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":5,"forks":27,"open_issues":5,"watchers":77,"default_branch":"master"}},"base":{"label":"lxdvs:bnb","ref":"bnb","sha":"55794d5206d2331606a8f96e3068f2b98717610a","user":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"repo":{"id":10260163,"name":"Volley-OkHttp-Android","full_name":"lxdvs/Volley-OkHttp-Android","owner":{"login":"lxdvs","id":368697,"avatar_url":"https://avatars.githubusercontent.com/u/368697?v=3","gravatar_id":"","url":"https://api.github.com/users/lxdvs","html_url":"https://github.com/lxdvs","followers_url":"https://api.github.com/users/lxdvs/followers","following_url":"https://api.github.com/users/lxdvs/following{/other_user}","gists_url":"https://api.github.com/users/lxdvs/gists{/gist_id}","starred_url":"https://api.github.com/users/lxdvs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxdvs/subscriptions","organizations_url":"https://api.github.com/users/lxdvs/orgs","repos_url":"https://api.github.com/users/lxdvs/repos","events_url":"https://api.github.com/users/lxdvs/events{/privacy}","received_events_url":"https://api.github.com/users/lxdvs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lxdvs/Volley-OkHttp-Android","description":"This is a clone of Volley, with the relevant changes made to make it work with Square's OkHttp library. It also has Jackson integrated to provide a convenient object model.","fork":false,"url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android","forks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/forks","keys_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/teams","hooks_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/hooks","issue_events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/events{/number}","events_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/events","assignees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/assignees{/user}","branches_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/branches{/branch}","tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/tags","blobs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/{sha}","languages_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/languages","stargazers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/stargazers","contributors_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contributors","subscribers_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscribers","subscription_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/subscription","commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/comments/{number}","contents_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/contents/{+path}","compare_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/merges","archive_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/downloads","issues_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues{/number}","pulls_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls{/number}","milestones_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/milestones{/number}","notifications_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/labels{/name}","releases_url":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/releases{/id}","created_at":"2013-05-24T05:53:31Z","updated_at":"2015-02-05T08:25:48Z","pushed_at":"2015-02-03T22:30:15Z","git_url":"git://github.com/lxdvs/Volley-OkHttp-Android.git","ssh_url":"git@github.com:lxdvs/Volley-OkHttp-Android.git","clone_url":"https://github.com/lxdvs/Volley-OkHttp-Android.git","svn_url":"https://github.com/lxdvs/Volley-OkHttp-Android","homepage":"","size":7487,"stargazers_count":77,"watchers_count":77,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":27,"mirror_url":null,"open_issues_count":5,"forks":27,"open_issues":5,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71"},"html":{"href":"https://github.com/lxdvs/Volley-OkHttp-Android/pull/71"},"issue":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/71"},"comments":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/lxdvs/Volley-OkHttp-Android/statuses/388d83c5e4ffb42e3cef06a334c9860f91786d80"}}}}