{"action":"created","issue":{"url":"https://api.github.com/repos/mhenrixon/sidekiq-unique-jobs/issues/84","labels_url":"https://api.github.com/repos/mhenrixon/sidekiq-unique-jobs/issues/84/labels{/name}","comments_url":"https://api.github.com/repos/mhenrixon/sidekiq-unique-jobs/issues/84/comments","events_url":"https://api.github.com/repos/mhenrixon/sidekiq-unique-jobs/issues/84/events","html_url":"https://github.com/mhenrixon/sidekiq-unique-jobs/issues/84","id":81150973,"number":84,"title":"Test suite unclear on what happens when duplicate job is attempted","user":{"login":"fj","id":57813,"avatar_url":"https://avatars.githubusercontent.com/u/57813?v=3","gravatar_id":"","url":"https://api.github.com/users/fj","html_url":"https://github.com/fj","followers_url":"https://api.github.com/users/fj/followers","following_url":"https://api.github.com/users/fj/following{/other_user}","gists_url":"https://api.github.com/users/fj/gists{/gist_id}","starred_url":"https://api.github.com/users/fj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fj/subscriptions","organizations_url":"https://api.github.com/users/fj/orgs","repos_url":"https://api.github.com/users/fj/repos","events_url":"https://api.github.com/users/fj/events{/privacy}","received_events_url":"https://api.github.com/users/fj/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-26T21:47:37Z","updated_at":"2015-07-31T14:48:40Z","closed_at":"2015-07-31T14:48:40Z","body":"The test suite says that a duplicate job is not added, which is the desired behavior.\r\n\r\nBut what else happens? Is an error raised? Is `false` returned? How does one know if success occurred or not? The nearest I can tell is that `perform` just won't return a job_id:\r\n\r\n```ruby\r\nTestJob.perform_async :arg => 1\r\n# => \"1234...\"\r\n\r\nTestJob.perform_async :arg => 1    # a duplicate!\r\n# => nil\r\n```\r\n\r\nThe test suite doesn't make it clear how to check this, since it works by looking at the queue size, which definitely isn't the correct strategy for production, since jobs are being added and removed all the time."},"comment":{"url":"https://api.github.com/repos/mhenrixon/sidekiq-unique-jobs/issues/comments/126713517","html_url":"https://github.com/mhenrixon/sidekiq-unique-jobs/issues/84#issuecomment-126713517","issue_url":"https://api.github.com/repos/mhenrixon/sidekiq-unique-jobs/issues/84","id":126713517,"user":{"login":"mhenrixon","id":106795,"avatar_url":"https://avatars.githubusercontent.com/u/106795?v=3","gravatar_id":"","url":"https://api.github.com/users/mhenrixon","html_url":"https://github.com/mhenrixon","followers_url":"https://api.github.com/users/mhenrixon/followers","following_url":"https://api.github.com/users/mhenrixon/following{/other_user}","gists_url":"https://api.github.com/users/mhenrixon/gists{/gist_id}","starred_url":"https://api.github.com/users/mhenrixon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhenrixon/subscriptions","organizations_url":"https://api.github.com/users/mhenrixon/orgs","repos_url":"https://api.github.com/users/mhenrixon/repos","events_url":"https://api.github.com/users/mhenrixon/events{/privacy}","received_events_url":"https://api.github.com/users/mhenrixon/received_events","type":"User","site_admin":false},"created_at":"2015-07-31T14:48:39Z","updated_at":"2015-07-31T14:48:39Z","body":"Check the readme https://github.com/mhenrixon/sidekiq-unique-jobs#logging"}}