{"action":"created","comment":{"url":"https://api.github.com/repos/chocolatey/choco/pulls/comments/24774545","id":24774545,"diff_hunk":"@@ -0,0 +1,65 @@\n+<StyleCopSettings Version=\"105\">\n+  <GlobalSettings>\n+    <CollectionProperty Name=\"RecognizedWords\">\n+      <Value>Chocolatey</Value>\n+      <Value>em</Value>\n+      <Value>Friedl's</Value>\n+      <Value>hr</Value>\n+      <Value>li</Value>\n+      <Value>ol</Value>\n+      <Value>runspace</Value>\n+      <Value>sehe</Value>\n+      <Value>stackoverflow</Value>\n+      <Value>tunnelling</Value>\n+      <Value>ul</Value>\n+      <Value>xaml</Value>\n+    </CollectionProperty>\n+  </GlobalSettings>\n+  <Analyzers>\n+    <Analyzer AnalyzerId=\"StyleCop.CSharp.DocumentationRules\">\n+      <Rules>\n+        <Rule Name=\"ElementsMustBeDocumented\">\n+          <RuleSettings>\n+            <BooleanProperty Name=\"Enabled\">False</BooleanProperty>\n+          </RuleSettings>\n+        </Rule>\n+        <Rule Name=\"EnumerationItemsMustBeDocumented\">\n+          <RuleSettings>\n+            <BooleanProperty Name=\"Enabled\">False</BooleanProperty>\n+          </RuleSettings>\n+        </Rule>\n+      </Rules>\n+      <AnalyzerSettings>\n+        <StringProperty Name=\"CompanyName\">Chocolatey</StringProperty>\n+        <StringProperty Name=\"Copyright\">Copyright 2014 - Present Rob Reynolds, the maintainers of Chocolatey, and RealDimensions Software, LLC</StringProperty>","path":"src/Settings.StyleCop","position":34,"original_position":34,"commit_id":"664608b1b6245931ec1ac41e9f2d4e715ebcd4c0","original_commit_id":"664608b1b6245931ec1ac41e9f2d4e715ebcd4c0","user":{"login":"gep13","id":1271146,"avatar_url":"https://avatars.githubusercontent.com/u/1271146?v=3","gravatar_id":"","url":"https://api.github.com/users/gep13","html_url":"https://github.com/gep13","followers_url":"https://api.github.com/users/gep13/followers","following_url":"https://api.github.com/users/gep13/following{/other_user}","gists_url":"https://api.github.com/users/gep13/gists{/gist_id}","starred_url":"https://api.github.com/users/gep13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gep13/subscriptions","organizations_url":"https://api.github.com/users/gep13/orgs","repos_url":"https://api.github.com/users/gep13/repos","events_url":"https://api.github.com/users/gep13/events{/privacy}","received_events_url":"https://api.github.com/users/gep13/received_events","type":"User","site_admin":false},"body":"Understood, I saw that this had been updated in the codebase, I need to update ChocolateyGUI to match, so that everything is consistent.","created_at":"2015-02-16T20:40:58Z","updated_at":"2015-02-16T20:40:58Z","html_url":"https://github.com/chocolatey/choco/pull/104#discussion_r24774545","pull_request_url":"https://api.github.com/repos/chocolatey/choco/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/comments/24774545"},"html":{"href":"https://github.com/chocolatey/choco/pull/104#discussion_r24774545"},"pull_request":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/chocolatey/choco/pulls/104","id":29398933,"html_url":"https://github.com/chocolatey/choco/pull/104","diff_url":"https://github.com/chocolatey/choco/pull/104.diff","patch_url":"https://github.com/chocolatey/choco/pull/104.patch","issue_url":"https://api.github.com/repos/chocolatey/choco/issues/104","number":104,"state":"open","locked":false,"title":"[WIP - DO NOT MERGE] Adding StyleCop and FxCop","user":{"login":"gep13","id":1271146,"avatar_url":"https://avatars.githubusercontent.com/u/1271146?v=3","gravatar_id":"","url":"https://api.github.com/users/gep13","html_url":"https://github.com/gep13","followers_url":"https://api.github.com/users/gep13/followers","following_url":"https://api.github.com/users/gep13/following{/other_user}","gists_url":"https://api.github.com/users/gep13/gists{/gist_id}","starred_url":"https://api.github.com/users/gep13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gep13/subscriptions","organizations_url":"https://api.github.com/users/gep13/orgs","repos_url":"https://api.github.com/users/gep13/repos","events_url":"https://api.github.com/users/gep13/events{/privacy}","received_events_url":"https://api.github.com/users/gep13/received_events","type":"User","site_admin":false},"body":"As discussed, here is my first attempt at getting FxCop and StyleCop added into the build process...\r\n\r\n**NOTES:**\r\n* As I mentioned, although there is a StyleCopCmd that can be used to run StyleCop from the command line (and you can find it [here](http://sourceforge.net/projects/stylecopcmd/)) it is very much out of date.  It is just as simple to run msbuild against a pre-prepared *.proj file, and this is what I have done in this Pull Request.  All you need to do is `msbuild .\\StyleCopCheck.proj` and StyleCop run's the analysis and spits out the output file to the build_artifacts folder:\r\n![image](https://cloud.githubusercontent.com/assets/1271146/6218825/699e0b04-b61a-11e4-8206-e376ff55c455.png)\r\n\r\n* I had to modify the default.build.settings to change all 10.0 references to 11.0 to get FxCop to run on my machine.  Is it just a case of adding this potential locations of FxCopCmd.exe to the settings file, rather than changing them?\r\n* The StyleCop.settings file that I have added here is just the one that I have borrowed from ChocolateyGUI, so it will need some tinkering.\r\n\r\nAssuming you are happy with the above, these things needs to be done:\r\n\r\n- [ ] Add StyleCop MsBuild task to UppercuT execution\r\n- [ ] Run XSL file on FxCop Result File to generate HTML\r\n- [ ] Run XSL file on StyleCop Result File to generate HTML\r\n- [ ] Go through all Code Analysis Rules and decide which ones we are following and generate a chocolatey.ruleset file\r\n- [ ] Go through all StyleCop Rules and decide which ones we are following and modify StyleCop.settings file\r\n- [ ] Make any violations in StyleCop and FxCop rules fail the build\r\n\r\nIf you could provide some guidance on how to do the first three of the above, I can continue with the others.","created_at":"2015-02-16T20:31:28Z","updated_at":"2015-02-16T20:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5b69b1cb19a445a3c9bd21f3f10efabaf98091c6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chocolatey/choco/pulls/104/commits","review_comments_url":"https://api.github.com/repos/chocolatey/choco/pulls/104/comments","review_comment_url":"https://api.github.com/repos/chocolatey/choco/pulls/comments/{number}","comments_url":"https://api.github.com/repos/chocolatey/choco/issues/104/comments","statuses_url":"https://api.github.com/repos/chocolatey/choco/statuses/664608b1b6245931ec1ac41e9f2d4e715ebcd4c0","head":{"label":"gep13:Issue-13","ref":"Issue-13","sha":"664608b1b6245931ec1ac41e9f2d4e715ebcd4c0","user":{"login":"gep13","id":1271146,"avatar_url":"https://avatars.githubusercontent.com/u/1271146?v=3","gravatar_id":"","url":"https://api.github.com/users/gep13","html_url":"https://github.com/gep13","followers_url":"https://api.github.com/users/gep13/followers","following_url":"https://api.github.com/users/gep13/following{/other_user}","gists_url":"https://api.github.com/users/gep13/gists{/gist_id}","starred_url":"https://api.github.com/users/gep13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gep13/subscriptions","organizations_url":"https://api.github.com/users/gep13/orgs","repos_url":"https://api.github.com/users/gep13/repos","events_url":"https://api.github.com/users/gep13/events{/privacy}","received_events_url":"https://api.github.com/users/gep13/received_events","type":"User","site_admin":false},"repo":{"id":29422671,"name":"choco","full_name":"gep13/choco","owner":{"login":"gep13","id":1271146,"avatar_url":"https://avatars.githubusercontent.com/u/1271146?v=3","gravatar_id":"","url":"https://api.github.com/users/gep13","html_url":"https://github.com/gep13","followers_url":"https://api.github.com/users/gep13/followers","following_url":"https://api.github.com/users/gep13/following{/other_user}","gists_url":"https://api.github.com/users/gep13/gists{/gist_id}","starred_url":"https://api.github.com/users/gep13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gep13/subscriptions","organizations_url":"https://api.github.com/users/gep13/orgs","repos_url":"https://api.github.com/users/gep13/repos","events_url":"https://api.github.com/users/gep13/events{/privacy}","received_events_url":"https://api.github.com/users/gep13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gep13/choco","description":"The New Chocolatey","fork":true,"url":"https://api.github.com/repos/gep13/choco","forks_url":"https://api.github.com/repos/gep13/choco/forks","keys_url":"https://api.github.com/repos/gep13/choco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gep13/choco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gep13/choco/teams","hooks_url":"https://api.github.com/repos/gep13/choco/hooks","issue_events_url":"https://api.github.com/repos/gep13/choco/issues/events{/number}","events_url":"https://api.github.com/repos/gep13/choco/events","assignees_url":"https://api.github.com/repos/gep13/choco/assignees{/user}","branches_url":"https://api.github.com/repos/gep13/choco/branches{/branch}","tags_url":"https://api.github.com/repos/gep13/choco/tags","blobs_url":"https://api.github.com/repos/gep13/choco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gep13/choco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gep13/choco/git/refs{/sha}","trees_url":"https://api.github.com/repos/gep13/choco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gep13/choco/statuses/{sha}","languages_url":"https://api.github.com/repos/gep13/choco/languages","stargazers_url":"https://api.github.com/repos/gep13/choco/stargazers","contributors_url":"https://api.github.com/repos/gep13/choco/contributors","subscribers_url":"https://api.github.com/repos/gep13/choco/subscribers","subscription_url":"https://api.github.com/repos/gep13/choco/subscription","commits_url":"https://api.github.com/repos/gep13/choco/commits{/sha}","git_commits_url":"https://api.github.com/repos/gep13/choco/git/commits{/sha}","comments_url":"https://api.github.com/repos/gep13/choco/comments{/number}","issue_comment_url":"https://api.github.com/repos/gep13/choco/issues/comments/{number}","contents_url":"https://api.github.com/repos/gep13/choco/contents/{+path}","compare_url":"https://api.github.com/repos/gep13/choco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gep13/choco/merges","archive_url":"https://api.github.com/repos/gep13/choco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gep13/choco/downloads","issues_url":"https://api.github.com/repos/gep13/choco/issues{/number}","pulls_url":"https://api.github.com/repos/gep13/choco/pulls{/number}","milestones_url":"https://api.github.com/repos/gep13/choco/milestones{/number}","notifications_url":"https://api.github.com/repos/gep13/choco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gep13/choco/labels{/name}","releases_url":"https://api.github.com/repos/gep13/choco/releases{/id}","created_at":"2015-01-18T10:41:01Z","updated_at":"2015-02-07T20:57:54Z","pushed_at":"2015-02-16T20:20:22Z","git_url":"git://github.com/gep13/choco.git","ssh_url":"git@github.com:gep13/choco.git","clone_url":"https://github.com/gep13/choco.git","svn_url":"https://github.com/gep13/choco","homepage":null,"size":7334,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chocolatey:master","ref":"master","sha":"0bc7303affc85f4220bc91a80a79d78dc59bdc46","user":{"login":"chocolatey","id":811025,"avatar_url":"https://avatars.githubusercontent.com/u/811025?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"repo":{"id":28647218,"name":"choco","full_name":"chocolatey/choco","owner":{"login":"chocolatey","id":811025,"avatar_url":"https://avatars.githubusercontent.com/u/811025?v=3","gravatar_id":"","url":"https://api.github.com/users/chocolatey","html_url":"https://github.com/chocolatey","followers_url":"https://api.github.com/users/chocolatey/followers","following_url":"https://api.github.com/users/chocolatey/following{/other_user}","gists_url":"https://api.github.com/users/chocolatey/gists{/gist_id}","starred_url":"https://api.github.com/users/chocolatey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chocolatey/subscriptions","organizations_url":"https://api.github.com/users/chocolatey/orgs","repos_url":"https://api.github.com/users/chocolatey/repos","events_url":"https://api.github.com/users/chocolatey/events{/privacy}","received_events_url":"https://api.github.com/users/chocolatey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chocolatey/choco","description":"The New Chocolatey","fork":false,"url":"https://api.github.com/repos/chocolatey/choco","forks_url":"https://api.github.com/repos/chocolatey/choco/forks","keys_url":"https://api.github.com/repos/chocolatey/choco/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chocolatey/choco/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chocolatey/choco/teams","hooks_url":"https://api.github.com/repos/chocolatey/choco/hooks","issue_events_url":"https://api.github.com/repos/chocolatey/choco/issues/events{/number}","events_url":"https://api.github.com/repos/chocolatey/choco/events","assignees_url":"https://api.github.com/repos/chocolatey/choco/assignees{/user}","branches_url":"https://api.github.com/repos/chocolatey/choco/branches{/branch}","tags_url":"https://api.github.com/repos/chocolatey/choco/tags","blobs_url":"https://api.github.com/repos/chocolatey/choco/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chocolatey/choco/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chocolatey/choco/git/refs{/sha}","trees_url":"https://api.github.com/repos/chocolatey/choco/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chocolatey/choco/statuses/{sha}","languages_url":"https://api.github.com/repos/chocolatey/choco/languages","stargazers_url":"https://api.github.com/repos/chocolatey/choco/stargazers","contributors_url":"https://api.github.com/repos/chocolatey/choco/contributors","subscribers_url":"https://api.github.com/repos/chocolatey/choco/subscribers","subscription_url":"https://api.github.com/repos/chocolatey/choco/subscription","commits_url":"https://api.github.com/repos/chocolatey/choco/commits{/sha}","git_commits_url":"https://api.github.com/repos/chocolatey/choco/git/commits{/sha}","comments_url":"https://api.github.com/repos/chocolatey/choco/comments{/number}","issue_comment_url":"https://api.github.com/repos/chocolatey/choco/issues/comments/{number}","contents_url":"https://api.github.com/repos/chocolatey/choco/contents/{+path}","compare_url":"https://api.github.com/repos/chocolatey/choco/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chocolatey/choco/merges","archive_url":"https://api.github.com/repos/chocolatey/choco/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chocolatey/choco/downloads","issues_url":"https://api.github.com/repos/chocolatey/choco/issues{/number}","pulls_url":"https://api.github.com/repos/chocolatey/choco/pulls{/number}","milestones_url":"https://api.github.com/repos/chocolatey/choco/milestones{/number}","notifications_url":"https://api.github.com/repos/chocolatey/choco/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chocolatey/choco/labels{/name}","releases_url":"https://api.github.com/repos/chocolatey/choco/releases{/id}","created_at":"2014-12-30T22:12:11Z","updated_at":"2015-02-16T19:46:44Z","pushed_at":"2015-02-16T19:16:41Z","git_url":"git://github.com/chocolatey/choco.git","ssh_url":"git@github.com:chocolatey/choco.git","clone_url":"https://github.com/chocolatey/choco.git","svn_url":"https://github.com/chocolatey/choco","homepage":null,"size":10110,"stargazers_count":82,"watchers_count":82,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":41,"forks":9,"open_issues":41,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/104"},"html":{"href":"https://github.com/chocolatey/choco/pull/104"},"issue":{"href":"https://api.github.com/repos/chocolatey/choco/issues/104"},"comments":{"href":"https://api.github.com/repos/chocolatey/choco/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/chocolatey/choco/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/chocolatey/choco/statuses/664608b1b6245931ec1ac41e9f2d4e715ebcd4c0"}}}}