{"action":"created","comment":{"url":"https://api.github.com/repos/sass/libsass/pulls/comments/30111616","id":30111616,"diff_hunk":"@@ -1073,8 +1073,15 @@ namespace Sass {\n       (*map) << make_pair(key, value);\n     }\n \n-    if (map->has_duplicate_key())\n-    { error(\"Duplicate key \\\"\" + map->get_duplicate_key()->perform(&to_string) + \"\\\" in map \" + map->perform(&to_string) + \".\", pstate); }\n+    // Check was moved to eval step\n+    // if (map->has_duplicate_key()) {\n+    //   To_String to_string(&ctx);\n+    //   error(\"Duplicate key \\\"\" + map->get_duplicate_key()->perform(&to_string) + \"\\\" in map \" + map->perform(&to_string) + \".\", pstate);\n+    // }\n+\n+    ParserState ps = map->pstate();\n+    ps.offset = pstate - ps + pstate.offset;\n+    map->pstate(ps);","path":"parser.cpp","position":32,"original_position":32,"commit_id":"8b556bc69ed960b50d66e8d12fa5313e2c37a41f","original_commit_id":"8b556bc69ed960b50d66e8d12fa5313e2c37a41f","user":{"login":"xzyfer","id":579928,"avatar_url":"https://avatars.githubusercontent.com/u/579928?v=3","gravatar_id":"","url":"https://api.github.com/users/xzyfer","html_url":"https://github.com/xzyfer","followers_url":"https://api.github.com/users/xzyfer/followers","following_url":"https://api.github.com/users/xzyfer/following{/other_user}","gists_url":"https://api.github.com/users/xzyfer/gists{/gist_id}","starred_url":"https://api.github.com/users/xzyfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xzyfer/subscriptions","organizations_url":"https://api.github.com/users/xzyfer/orgs","repos_url":"https://api.github.com/users/xzyfer/repos","events_url":"https://api.github.com/users/xzyfer/events{/privacy}","received_events_url":"https://api.github.com/users/xzyfer/received_events","type":"User","site_admin":false},"body":"Can you quickly explain this change?","created_at":"2015-05-12T07:54:45Z","updated_at":"2015-05-12T07:54:45Z","html_url":"https://github.com/sass/libsass/pull/1195#discussion_r30111616","pull_request_url":"https://api.github.com/repos/sass/libsass/pulls/1195","_links":{"self":{"href":"https://api.github.com/repos/sass/libsass/pulls/comments/30111616"},"html":{"href":"https://github.com/sass/libsass/pull/1195#discussion_r30111616"},"pull_request":{"href":"https://api.github.com/repos/sass/libsass/pulls/1195"}}},"pull_request":{"url":"https://api.github.com/repos/sass/libsass/pulls/1195","id":35084938,"html_url":"https://github.com/sass/libsass/pull/1195","diff_url":"https://github.com/sass/libsass/pull/1195.diff","patch_url":"https://github.com/sass/libsass/pull/1195.patch","issue_url":"https://api.github.com/repos/sass/libsass/issues/1195","number":1195,"state":"open","locked":false,"title":"Fix duplicate key handling for maps","user":{"login":"mgreter","id":282293,"avatar_url":"https://avatars.githubusercontent.com/u/282293?v=3","gravatar_id":"","url":"https://api.github.com/users/mgreter","html_url":"https://github.com/mgreter","followers_url":"https://api.github.com/users/mgreter/followers","following_url":"https://api.github.com/users/mgreter/following{/other_user}","gists_url":"https://api.github.com/users/mgreter/gists{/gist_id}","starred_url":"https://api.github.com/users/mgreter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgreter/subscriptions","organizations_url":"https://api.github.com/users/mgreter/orgs","repos_url":"https://api.github.com/users/mgreter/repos","events_url":"https://api.github.com/users/mgreter/events{/privacy}","received_events_url":"https://api.github.com/users/mgreter/received_events","type":"User","site_admin":false},"body":"Deferred check from parser to evaluation\r\nFixes https://github.com/sass/libsass/issues/1187","created_at":"2015-05-10T16:28:54Z","updated_at":"2015-05-12T07:54:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6ceed6ac6776ca3dfec858212c6e1132f954ed0e","assignee":{"login":"mgreter","id":282293,"avatar_url":"https://avatars.githubusercontent.com/u/282293?v=3","gravatar_id":"","url":"https://api.github.com/users/mgreter","html_url":"https://github.com/mgreter","followers_url":"https://api.github.com/users/mgreter/followers","following_url":"https://api.github.com/users/mgreter/following{/other_user}","gists_url":"https://api.github.com/users/mgreter/gists{/gist_id}","starred_url":"https://api.github.com/users/mgreter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgreter/subscriptions","organizations_url":"https://api.github.com/users/mgreter/orgs","repos_url":"https://api.github.com/users/mgreter/repos","events_url":"https://api.github.com/users/mgreter/events{/privacy}","received_events_url":"https://api.github.com/users/mgreter/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/sass/libsass/milestones/9","html_url":"https://github.com/sass/libsass/milestones/3.2.4","labels_url":"https://api.github.com/repos/sass/libsass/milestones/9/labels","id":1103433,"number":9,"title":"3.2.4","description":"Next Bugfix Release","creator":{"login":"xzyfer","id":579928,"avatar_url":"https://avatars.githubusercontent.com/u/579928?v=3","gravatar_id":"","url":"https://api.github.com/users/xzyfer","html_url":"https://github.com/xzyfer","followers_url":"https://api.github.com/users/xzyfer/followers","following_url":"https://api.github.com/users/xzyfer/following{/other_user}","gists_url":"https://api.github.com/users/xzyfer/gists{/gist_id}","starred_url":"https://api.github.com/users/xzyfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xzyfer/subscriptions","organizations_url":"https://api.github.com/users/xzyfer/orgs","repos_url":"https://api.github.com/users/xzyfer/repos","events_url":"https://api.github.com/users/xzyfer/events{/privacy}","received_events_url":"https://api.github.com/users/xzyfer/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":6,"state":"open","created_at":"2015-05-10T04:01:14Z","updated_at":"2015-05-12T01:20:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sass/libsass/pulls/1195/commits","review_comments_url":"https://api.github.com/repos/sass/libsass/pulls/1195/comments","review_comment_url":"https://api.github.com/repos/sass/libsass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sass/libsass/issues/1195/comments","statuses_url":"https://api.github.com/repos/sass/libsass/statuses/8b556bc69ed960b50d66e8d12fa5313e2c37a41f","head":{"label":"mgreter:bugfix/issue_1187","ref":"bugfix/issue_1187","sha":"8b556bc69ed960b50d66e8d12fa5313e2c37a41f","user":{"login":"mgreter","id":282293,"avatar_url":"https://avatars.githubusercontent.com/u/282293?v=3","gravatar_id":"","url":"https://api.github.com/users/mgreter","html_url":"https://github.com/mgreter","followers_url":"https://api.github.com/users/mgreter/followers","following_url":"https://api.github.com/users/mgreter/following{/other_user}","gists_url":"https://api.github.com/users/mgreter/gists{/gist_id}","starred_url":"https://api.github.com/users/mgreter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgreter/subscriptions","organizations_url":"https://api.github.com/users/mgreter/orgs","repos_url":"https://api.github.com/users/mgreter/repos","events_url":"https://api.github.com/users/mgreter/events{/privacy}","received_events_url":"https://api.github.com/users/mgreter/received_events","type":"User","site_admin":false},"repo":{"id":13783687,"name":"libsass","full_name":"mgreter/libsass","owner":{"login":"mgreter","id":282293,"avatar_url":"https://avatars.githubusercontent.com/u/282293?v=3","gravatar_id":"","url":"https://api.github.com/users/mgreter","html_url":"https://github.com/mgreter","followers_url":"https://api.github.com/users/mgreter/followers","following_url":"https://api.github.com/users/mgreter/following{/other_user}","gists_url":"https://api.github.com/users/mgreter/gists{/gist_id}","starred_url":"https://api.github.com/users/mgreter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgreter/subscriptions","organizations_url":"https://api.github.com/users/mgreter/orgs","repos_url":"https://api.github.com/users/mgreter/repos","events_url":"https://api.github.com/users/mgreter/events{/privacy}","received_events_url":"https://api.github.com/users/mgreter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mgreter/libsass","description":"A C implementation of a Sass compiler","fork":true,"url":"https://api.github.com/repos/mgreter/libsass","forks_url":"https://api.github.com/repos/mgreter/libsass/forks","keys_url":"https://api.github.com/repos/mgreter/libsass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mgreter/libsass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mgreter/libsass/teams","hooks_url":"https://api.github.com/repos/mgreter/libsass/hooks","issue_events_url":"https://api.github.com/repos/mgreter/libsass/issues/events{/number}","events_url":"https://api.github.com/repos/mgreter/libsass/events","assignees_url":"https://api.github.com/repos/mgreter/libsass/assignees{/user}","branches_url":"https://api.github.com/repos/mgreter/libsass/branches{/branch}","tags_url":"https://api.github.com/repos/mgreter/libsass/tags","blobs_url":"https://api.github.com/repos/mgreter/libsass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mgreter/libsass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mgreter/libsass/git/refs{/sha}","trees_url":"https://api.github.com/repos/mgreter/libsass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mgreter/libsass/statuses/{sha}","languages_url":"https://api.github.com/repos/mgreter/libsass/languages","stargazers_url":"https://api.github.com/repos/mgreter/libsass/stargazers","contributors_url":"https://api.github.com/repos/mgreter/libsass/contributors","subscribers_url":"https://api.github.com/repos/mgreter/libsass/subscribers","subscription_url":"https://api.github.com/repos/mgreter/libsass/subscription","commits_url":"https://api.github.com/repos/mgreter/libsass/commits{/sha}","git_commits_url":"https://api.github.com/repos/mgreter/libsass/git/commits{/sha}","comments_url":"https://api.github.com/repos/mgreter/libsass/comments{/number}","issue_comment_url":"https://api.github.com/repos/mgreter/libsass/issues/comments{/number}","contents_url":"https://api.github.com/repos/mgreter/libsass/contents/{+path}","compare_url":"https://api.github.com/repos/mgreter/libsass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mgreter/libsass/merges","archive_url":"https://api.github.com/repos/mgreter/libsass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mgreter/libsass/downloads","issues_url":"https://api.github.com/repos/mgreter/libsass/issues{/number}","pulls_url":"https://api.github.com/repos/mgreter/libsass/pulls{/number}","milestones_url":"https://api.github.com/repos/mgreter/libsass/milestones{/number}","notifications_url":"https://api.github.com/repos/mgreter/libsass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mgreter/libsass/labels{/name}","releases_url":"https://api.github.com/repos/mgreter/libsass/releases{/id}","created_at":"2013-10-22T19:33:21Z","updated_at":"2015-04-06T17:27:23Z","pushed_at":"2015-05-11T20:37:28Z","git_url":"git://github.com/mgreter/libsass.git","ssh_url":"git@github.com:mgreter/libsass.git","clone_url":"https://github.com/mgreter/libsass.git","svn_url":"https://github.com/mgreter/libsass","homepage":"","size":11068,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"sass:master","ref":"master","sha":"fb82f0bb604a457670ecaf87e10435d2a23af7e2","user":{"login":"sass","id":317889,"avatar_url":"https://avatars.githubusercontent.com/u/317889?v=3","gravatar_id":"","url":"https://api.github.com/users/sass","html_url":"https://github.com/sass","followers_url":"https://api.github.com/users/sass/followers","following_url":"https://api.github.com/users/sass/following{/other_user}","gists_url":"https://api.github.com/users/sass/gists{/gist_id}","starred_url":"https://api.github.com/users/sass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sass/subscriptions","organizations_url":"https://api.github.com/users/sass/orgs","repos_url":"https://api.github.com/users/sass/repos","events_url":"https://api.github.com/users/sass/events{/privacy}","received_events_url":"https://api.github.com/users/sass/received_events","type":"Organization","site_admin":false},"repo":{"id":3319769,"name":"libsass","full_name":"sass/libsass","owner":{"login":"sass","id":317889,"avatar_url":"https://avatars.githubusercontent.com/u/317889?v=3","gravatar_id":"","url":"https://api.github.com/users/sass","html_url":"https://github.com/sass","followers_url":"https://api.github.com/users/sass/followers","following_url":"https://api.github.com/users/sass/following{/other_user}","gists_url":"https://api.github.com/users/sass/gists{/gist_id}","starred_url":"https://api.github.com/users/sass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sass/subscriptions","organizations_url":"https://api.github.com/users/sass/orgs","repos_url":"https://api.github.com/users/sass/repos","events_url":"https://api.github.com/users/sass/events{/privacy}","received_events_url":"https://api.github.com/users/sass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sass/libsass","description":"A C/C++ implementation of a Sass compiler","fork":false,"url":"https://api.github.com/repos/sass/libsass","forks_url":"https://api.github.com/repos/sass/libsass/forks","keys_url":"https://api.github.com/repos/sass/libsass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sass/libsass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sass/libsass/teams","hooks_url":"https://api.github.com/repos/sass/libsass/hooks","issue_events_url":"https://api.github.com/repos/sass/libsass/issues/events{/number}","events_url":"https://api.github.com/repos/sass/libsass/events","assignees_url":"https://api.github.com/repos/sass/libsass/assignees{/user}","branches_url":"https://api.github.com/repos/sass/libsass/branches{/branch}","tags_url":"https://api.github.com/repos/sass/libsass/tags","blobs_url":"https://api.github.com/repos/sass/libsass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sass/libsass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sass/libsass/git/refs{/sha}","trees_url":"https://api.github.com/repos/sass/libsass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sass/libsass/statuses/{sha}","languages_url":"https://api.github.com/repos/sass/libsass/languages","stargazers_url":"https://api.github.com/repos/sass/libsass/stargazers","contributors_url":"https://api.github.com/repos/sass/libsass/contributors","subscribers_url":"https://api.github.com/repos/sass/libsass/subscribers","subscription_url":"https://api.github.com/repos/sass/libsass/subscription","commits_url":"https://api.github.com/repos/sass/libsass/commits{/sha}","git_commits_url":"https://api.github.com/repos/sass/libsass/git/commits{/sha}","comments_url":"https://api.github.com/repos/sass/libsass/comments{/number}","issue_comment_url":"https://api.github.com/repos/sass/libsass/issues/comments{/number}","contents_url":"https://api.github.com/repos/sass/libsass/contents/{+path}","compare_url":"https://api.github.com/repos/sass/libsass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sass/libsass/merges","archive_url":"https://api.github.com/repos/sass/libsass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sass/libsass/downloads","issues_url":"https://api.github.com/repos/sass/libsass/issues{/number}","pulls_url":"https://api.github.com/repos/sass/libsass/pulls{/number}","milestones_url":"https://api.github.com/repos/sass/libsass/milestones{/number}","notifications_url":"https://api.github.com/repos/sass/libsass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sass/libsass/labels{/name}","releases_url":"https://api.github.com/repos/sass/libsass/releases{/id}","created_at":"2012-01-31T22:59:07Z","updated_at":"2015-05-12T01:41:27Z","pushed_at":"2015-05-12T01:20:53Z","git_url":"git://github.com/sass/libsass.git","ssh_url":"git@github.com:sass/libsass.git","clone_url":"https://github.com/sass/libsass.git","svn_url":"https://github.com/sass/libsass","homepage":"http://libsass.org","size":19737,"stargazers_count":2376,"watchers_count":2376,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":256,"mirror_url":null,"open_issues_count":56,"forks":256,"open_issues":56,"watchers":2376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sass/libsass/pulls/1195"},"html":{"href":"https://github.com/sass/libsass/pull/1195"},"issue":{"href":"https://api.github.com/repos/sass/libsass/issues/1195"},"comments":{"href":"https://api.github.com/repos/sass/libsass/issues/1195/comments"},"review_comments":{"href":"https://api.github.com/repos/sass/libsass/pulls/1195/comments"},"review_comment":{"href":"https://api.github.com/repos/sass/libsass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sass/libsass/pulls/1195/commits"},"statuses":{"href":"https://api.github.com/repos/sass/libsass/statuses/8b556bc69ed960b50d66e8d12fa5313e2c37a41f"}}}}