{"action":"created","issue":{"url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/5","labels_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/5/comments","events_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/5/events","html_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/5","id":109931817,"number":5,"title":"Video stats overhaul","user":{"login":"EhsanKia","id":1619970,"avatar_url":"https://avatars.githubusercontent.com/u/1619970?v=3","gravatar_id":"","url":"https://api.github.com/users/EhsanKia","html_url":"https://github.com/EhsanKia","followers_url":"https://api.github.com/users/EhsanKia/followers","following_url":"https://api.github.com/users/EhsanKia/following{/other_user}","gists_url":"https://api.github.com/users/EhsanKia/gists{/gist_id}","starred_url":"https://api.github.com/users/EhsanKia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EhsanKia/subscriptions","organizations_url":"https://api.github.com/users/EhsanKia/orgs","repos_url":"https://api.github.com/users/EhsanKia/repos","events_url":"https://api.github.com/users/EhsanKia/events{/privacy}","received_events_url":"https://api.github.com/users/EhsanKia/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-10-06T04:03:37Z","updated_at":"2015-10-06T05:01:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/pulls/5","html_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/5","diff_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/5.diff","patch_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/5.patch"},"body":"1. Moved the stats button from the inside menu to the main bar, with some SVG icon.\r\nNot quite sold on the icon yet, just took one from here: https://icomoon.io/app/#/select\r\nI'd be open to suggestions for a different icon.\r\n\r\n2. Made it so latency to broadcaster is always showing in the top right corner under live.\r\nThis is a bit of a subjective change, and down the live I'd be open to adding options to\r\ntoggling some of this optimizations off. Also, to achieve this, I open and hide the stats\r\nmenu, which starts pulling stats every second. I'm not sure what sort of performance\r\nimpact this can have, having stats being pulled all the time in the background.\r\n\r\nLastly, these changes are also made in VODs. Seems to work fine, but we may want\r\nto split the behaviors/tweaks depending on which mode we are in down the road.\r\n\r\nAny extra thoughts before we merge this? Can you guys test it a bit?"},"comment":{"url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/comments/145742539","html_url":"https://github.com/EhsanKia/TwitchPlayerPlus/pull/5#issuecomment-145742539","issue_url":"https://api.github.com/repos/EhsanKia/TwitchPlayerPlus/issues/5","id":145742539,"user":{"login":"tduva","id":5621113,"avatar_url":"https://avatars.githubusercontent.com/u/5621113?v=3","gravatar_id":"","url":"https://api.github.com/users/tduva","html_url":"https://github.com/tduva","followers_url":"https://api.github.com/users/tduva/followers","following_url":"https://api.github.com/users/tduva/following{/other_user}","gists_url":"https://api.github.com/users/tduva/gists{/gist_id}","starred_url":"https://api.github.com/users/tduva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tduva/subscriptions","organizations_url":"https://api.github.com/users/tduva/orgs","repos_url":"https://api.github.com/users/tduva/repos","events_url":"https://api.github.com/users/tduva/events{/privacy}","received_events_url":"https://api.github.com/users/tduva/received_events","type":"User","site_admin":false},"created_at":"2015-10-06T05:01:23Z","updated_at":"2015-10-06T05:01:23Z","body":"Seems to work fine in Firefox for me sow far. I don't get the latency on a VOD, probably because the live icon is hidden, so that's the only change that wouldn't make sense, the stats button can still be useful on VODs.\r\n\r\nWhat options are there to save potential settings between page reloads?"}}