{"action":"created","issue":{"url":"https://api.github.com/repos/Jasig/java-cas-client/issues/102","labels_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/102/labels{/name}","comments_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/102/comments","events_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/102/events","html_url":"https://github.com/Jasig/java-cas-client/pull/102","id":75146085,"number":102,"title":"Introduced common method in order to retrieve Assertion object","user":{"login":"manamana88","id":8737056,"avatar_url":"https://avatars.githubusercontent.com/u/8737056?v=3","gravatar_id":"","url":"https://api.github.com/users/manamana88","html_url":"https://github.com/manamana88","followers_url":"https://api.github.com/users/manamana88/followers","following_url":"https://api.github.com/users/manamana88/following{/other_user}","gists_url":"https://api.github.com/users/manamana88/gists{/gist_id}","starred_url":"https://api.github.com/users/manamana88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manamana88/subscriptions","organizations_url":"https://api.github.com/users/manamana88/orgs","repos_url":"https://api.github.com/users/manamana88/repos","events_url":"https://api.github.com/users/manamana88/events{/privacy}","received_events_url":"https://api.github.com/users/manamana88/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-05-11T09:07:21Z","updated_at":"2015-06-04T08:42:52Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Jasig/java-cas-client/pulls/102","html_url":"https://github.com/Jasig/java-cas-client/pull/102","diff_url":"https://github.com/Jasig/java-cas-client/pull/102.diff","patch_url":"https://github.com/Jasig/java-cas-client/pull/102.patch"},"body":"1. Introduced the new method retrieveAssertionFromRequestOrSession in CommonUtils\r\n2. Changed AssertionThreadLocalFilter, AuthenticationFilter and HttpServletRequestWrapperFilter in order to use the new method"},"comment":{"url":"https://api.github.com/repos/Jasig/java-cas-client/issues/comments/108789241","html_url":"https://github.com/Jasig/java-cas-client/pull/102#issuecomment-108789241","issue_url":"https://api.github.com/repos/Jasig/java-cas-client/issues/102","id":108789241,"user":{"login":"manamana88","id":8737056,"avatar_url":"https://avatars.githubusercontent.com/u/8737056?v=3","gravatar_id":"","url":"https://api.github.com/users/manamana88","html_url":"https://github.com/manamana88","followers_url":"https://api.github.com/users/manamana88/followers","following_url":"https://api.github.com/users/manamana88/following{/other_user}","gists_url":"https://api.github.com/users/manamana88/gists{/gist_id}","starred_url":"https://api.github.com/users/manamana88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manamana88/subscriptions","organizations_url":"https://api.github.com/users/manamana88/orgs","repos_url":"https://api.github.com/users/manamana88/repos","events_url":"https://api.github.com/users/manamana88/events{/privacy}","received_events_url":"https://api.github.com/users/manamana88/received_events","type":"User","site_admin":false},"created_at":"2015-06-04T08:42:52Z","updated_at":"2015-06-04T08:42:52Z","body":"I think that ideologically the best filter where to place this method is the AbstractCasFilter because we use the CONST_CAS_ASSERTION which is defined there. Anyway leaving out these philosophical matters, I agree with you that it's better to avoid public utility methods but following this guideline in this case would be a little bit forced, i.e. the AssertionThreadLocalFilter does not extend any filter"}}