{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/22519002","id":22519002,"diff_hunk":"@@ -45,7 +45,7 @@ You have a simple ``User`` entity mapped to the database::\n         /**\n          * @ORM\\Column(type=\"string\", length=255)\n          * @Assert\\NotBlank()\n-         * @Assert\\Length(max = 4096)\n+         * @Assert\\Length(max=4096)","path":"cookbook/doctrine/registration_form.rst","position":23,"original_position":23,"commit_id":"1ac87108c8de1dff7186c34ebce38f1f746606ee","original_commit_id":"1ac87108c8de1dff7186c34ebce38f1f746606ee","user":{"login":"xelaris","id":2466932,"avatar_url":"https://avatars.githubusercontent.com/u/2466932?v=3","gravatar_id":"","url":"https://api.github.com/users/xelaris","html_url":"https://github.com/xelaris","followers_url":"https://api.github.com/users/xelaris/followers","following_url":"https://api.github.com/users/xelaris/following{/other_user}","gists_url":"https://api.github.com/users/xelaris/gists{/gist_id}","starred_url":"https://api.github.com/users/xelaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelaris/subscriptions","organizations_url":"https://api.github.com/users/xelaris/orgs","repos_url":"https://api.github.com/users/xelaris/repos","events_url":"https://api.github.com/users/xelaris/events{/privacy}","received_events_url":"https://api.github.com/users/xelaris/received_events","type":"User","site_admin":false},"body":"I re-read the preamble of this entry. Thereby I become unsure about what the actual topic of this entry is. On the one hand it resides in the doctrine category and is about \"extra fields whose values don't need to be stored in the database\", on the other hand it's about a registration form and thus related to security. \r\nThe more I think about it... maybe this entry should be splitted into two entries. One to fulfill the preamble of the current entry and one to implement a comprehensive registration form like the headline promises. Therefore it requires another example/usecase for the doctrine/form related entry. The new entry about a registration form wouldn't need the embedded form, because the \"terms accepted\" can be ignored there. Assuming that the registration from would operate with the security system (e.g. an entity that implements the UserInterface of the Security component and using the recommended bcrypt encoder via security.yml) it would not be as \"simple\" as the current registration form. I think it would be nice to complement http://symfony.com/doc/current/cookbook/security/form_login_setup.html and http://symfony.com/doc/current/cookbook/security/entity_provider.html with the new entry about a registration from since the latter one already describes the required `User` implementing the UserInterface and the `security.yml`.\r\nWhat are your opinions?","created_at":"2015-01-06T11:25:33Z","updated_at":"2015-01-06T11:25:33Z","html_url":"https://github.com/symfony/symfony-docs/pull/4773#discussion_r22519002","pull_request_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/22519002"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4773#discussion_r22519002"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773","id":26804887,"html_url":"https://github.com/symfony/symfony-docs/pull/4773","diff_url":"https://github.com/symfony/symfony-docs/pull/4773.diff","patch_url":"https://github.com/symfony/symfony-docs/pull/4773.patch","issue_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4773","number":4773,"state":"open","locked":false,"title":"[Cookbook] Make registration_form follow best practices","user":{"login":"xelaris","id":2466932,"avatar_url":"https://avatars.githubusercontent.com/u/2466932?v=3","gravatar_id":"","url":"https://api.github.com/users/xelaris","html_url":"https://github.com/xelaris","followers_url":"https://api.github.com/users/xelaris/followers","following_url":"https://api.github.com/users/xelaris/following{/other_user}","gists_url":"https://api.github.com/users/xelaris/gists{/gist_id}","starred_url":"https://api.github.com/users/xelaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelaris/subscriptions","organizations_url":"https://api.github.com/users/xelaris/orgs","repos_url":"https://api.github.com/users/xelaris/repos","events_url":"https://api.github.com/users/xelaris/events{/privacy}","received_events_url":"https://api.github.com/users/xelaris/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Doc fix?      | yes\r\n| New docs?     | no\r\n| Applies to    | 2.3+\r\n| Fixed tickets |","created_at":"2015-01-05T03:30:46Z","updated_at":"2015-01-06T11:25:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8cd42fc1bc8f066e0d1c1c9395aed740ad29895","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/issues/4773/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/1ac87108c8de1dff7186c34ebce38f1f746606ee","head":{"label":"xelaris:reg-form","ref":"reg-form","sha":"1ac87108c8de1dff7186c34ebce38f1f746606ee","user":{"login":"xelaris","id":2466932,"avatar_url":"https://avatars.githubusercontent.com/u/2466932?v=3","gravatar_id":"","url":"https://api.github.com/users/xelaris","html_url":"https://github.com/xelaris","followers_url":"https://api.github.com/users/xelaris/followers","following_url":"https://api.github.com/users/xelaris/following{/other_user}","gists_url":"https://api.github.com/users/xelaris/gists{/gist_id}","starred_url":"https://api.github.com/users/xelaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelaris/subscriptions","organizations_url":"https://api.github.com/users/xelaris/orgs","repos_url":"https://api.github.com/users/xelaris/repos","events_url":"https://api.github.com/users/xelaris/events{/privacy}","received_events_url":"https://api.github.com/users/xelaris/received_events","type":"User","site_admin":false},"repo":{"id":27297816,"name":"symfony-docs","full_name":"xelaris/symfony-docs","owner":{"login":"xelaris","id":2466932,"avatar_url":"https://avatars.githubusercontent.com/u/2466932?v=3","gravatar_id":"","url":"https://api.github.com/users/xelaris","html_url":"https://github.com/xelaris","followers_url":"https://api.github.com/users/xelaris/followers","following_url":"https://api.github.com/users/xelaris/following{/other_user}","gists_url":"https://api.github.com/users/xelaris/gists{/gist_id}","starred_url":"https://api.github.com/users/xelaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelaris/subscriptions","organizations_url":"https://api.github.com/users/xelaris/orgs","repos_url":"https://api.github.com/users/xelaris/repos","events_url":"https://api.github.com/users/xelaris/events{/privacy}","received_events_url":"https://api.github.com/users/xelaris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xelaris/symfony-docs","description":"The Symfony2 documentation","fork":true,"url":"https://api.github.com/repos/xelaris/symfony-docs","forks_url":"https://api.github.com/repos/xelaris/symfony-docs/forks","keys_url":"https://api.github.com/repos/xelaris/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xelaris/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xelaris/symfony-docs/teams","hooks_url":"https://api.github.com/repos/xelaris/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/xelaris/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/xelaris/symfony-docs/events","assignees_url":"https://api.github.com/repos/xelaris/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/xelaris/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/xelaris/symfony-docs/tags","blobs_url":"https://api.github.com/repos/xelaris/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xelaris/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xelaris/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/xelaris/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xelaris/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/xelaris/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/xelaris/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/xelaris/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/xelaris/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/xelaris/symfony-docs/subscription","commits_url":"https://api.github.com/repos/xelaris/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/xelaris/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/xelaris/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/xelaris/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/xelaris/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/xelaris/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xelaris/symfony-docs/merges","archive_url":"https://api.github.com/repos/xelaris/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xelaris/symfony-docs/downloads","issues_url":"https://api.github.com/repos/xelaris/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/xelaris/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/xelaris/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/xelaris/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xelaris/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/xelaris/symfony-docs/releases{/id}","created_at":"2014-11-29T09:47:02Z","updated_at":"2014-11-29T09:47:07Z","pushed_at":"2015-01-05T03:27:00Z","git_url":"git://github.com/xelaris/symfony-docs.git","ssh_url":"git@github.com:xelaris/symfony-docs.git","clone_url":"https://github.com/xelaris/symfony-docs.git","svn_url":"https://github.com/xelaris/symfony-docs","homepage":"http://symfony.com/doc/current/","size":24694,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.3","ref":"2.3","sha":"99aca4532681c1fbc5d85b2935145b3d4fe9934c","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":521583,"name":"symfony-docs","full_name":"symfony/symfony-docs","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-docs","description":"The Symfony2 documentation","fork":false,"url":"https://api.github.com/repos/symfony/symfony-docs","forks_url":"https://api.github.com/repos/symfony/symfony-docs/forks","keys_url":"https://api.github.com/repos/symfony/symfony-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-docs/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-docs/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-docs/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-docs/events","assignees_url":"https://api.github.com/repos/symfony/symfony-docs/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-docs/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-docs/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-docs/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-docs/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-docs/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-docs/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-docs/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-docs/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony-docs/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-docs/merges","archive_url":"https://api.github.com/repos/symfony/symfony-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-docs/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-docs/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-docs/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-docs/releases{/id}","created_at":"2010-02-17T08:43:51Z","updated_at":"2015-01-04T23:00:58Z","pushed_at":"2015-01-05T17:53:00Z","git_url":"git://github.com/symfony/symfony-docs.git","ssh_url":"git@github.com:symfony/symfony-docs.git","clone_url":"https://github.com/symfony/symfony-docs.git","svn_url":"https://github.com/symfony/symfony-docs","homepage":"http://symfony.com/doc/current/","size":52059,"stargazers_count":944,"watchers_count":944,"language":"Python","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1629,"mirror_url":null,"open_issues_count":256,"forks":1629,"open_issues":256,"watchers":944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773"},"html":{"href":"https://github.com/symfony/symfony-docs/pull/4773"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4773"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/issues/4773/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-docs/pulls/4773/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-docs/statuses/1ac87108c8de1dff7186c34ebce38f1f746606ee"}}}}