{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/15157","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15157/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15157/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15157/events","html_url":"https://github.com/elastic/elasticsearch/pull/15157","id":119766308,"number":15157,"title":" Add fromXContent method to HighlightBuilder","user":{"login":"cbuescher","id":10398885,"avatar_url":"https://avatars.githubusercontent.com/u/10398885?v=3","gravatar_id":"","url":"https://api.github.com/users/cbuescher","html_url":"https://github.com/cbuescher","followers_url":"https://api.github.com/users/cbuescher/followers","following_url":"https://api.github.com/users/cbuescher/following{/other_user}","gists_url":"https://api.github.com/users/cbuescher/gists{/gist_id}","starred_url":"https://api.github.com/users/cbuescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbuescher/subscriptions","organizations_url":"https://api.github.com/users/cbuescher/orgs","repos_url":"https://api.github.com/users/cbuescher/repos","events_url":"https://api.github.com/users/cbuescher/events{/privacy}","received_events_url":"https://api.github.com/users/cbuescher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Highlighting","name":":Highlighting","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search%20Refactoring","name":":Search Refactoring","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/enhancement","name":"enhancement","color":"4a4ea8"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/v3.0.0","name":"v3.0.0","color":"dddddd"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-12-01T17:22:06Z","updated_at":"2015-12-07T11:14:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15157","html_url":"https://github.com/elastic/elasticsearch/pull/15157","diff_url":"https://github.com/elastic/elasticsearch/pull/15157.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/15157.patch"},"body":"For the search refactoring the HighlightBuilder needs a way to create new instances by parsing xContent. For bwc this PR start by moving over and slightly modifying the parsing from HighlighterParseElement and keeps parsing for top level highlighter and field options separate. Also adding tests for roundtrip of random builder (rendering it to xContent and parsing it and making sure the original builder properties are preserved)."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/162487889","html_url":"https://github.com/elastic/elasticsearch/pull/15157#issuecomment-162487889","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15157","id":162487889,"user":{"login":"colings86","id":236731,"avatar_url":"https://avatars.githubusercontent.com/u/236731?v=3","gravatar_id":"","url":"https://api.github.com/users/colings86","html_url":"https://github.com/colings86","followers_url":"https://api.github.com/users/colings86/followers","following_url":"https://api.github.com/users/colings86/following{/other_user}","gists_url":"https://api.github.com/users/colings86/gists{/gist_id}","starred_url":"https://api.github.com/users/colings86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colings86/subscriptions","organizations_url":"https://api.github.com/users/colings86/orgs","repos_url":"https://api.github.com/users/colings86/repos","events_url":"https://api.github.com/users/colings86/events{/privacy}","received_events_url":"https://api.github.com/users/colings86/received_events","type":"User","site_admin":false},"created_at":"2015-12-07T11:14:27Z","updated_at":"2015-12-07T11:14:27Z","body":"@cbuescher This is looking good so far, I left a few comments"}}