{"action":"created","issue":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/609","labels_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/609/labels{/name}","comments_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/609/comments","events_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/609/events","html_url":"https://github.com/chocolate-doom/chocolate-doom/issues/609","id":105773065,"number":609,"title":"possible to crash in MAP06","user":{"login":"fabiangreffrath","id":6449237,"avatar_url":"https://avatars.githubusercontent.com/u/6449237?v=3","gravatar_id":"","url":"https://api.github.com/users/fabiangreffrath","html_url":"https://github.com/fabiangreffrath","followers_url":"https://api.github.com/users/fabiangreffrath/followers","following_url":"https://api.github.com/users/fabiangreffrath/following{/other_user}","gists_url":"https://api.github.com/users/fabiangreffrath/gists{/gist_id}","starred_url":"https://api.github.com/users/fabiangreffrath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabiangreffrath/subscriptions","organizations_url":"https://api.github.com/users/fabiangreffrath/orgs","repos_url":"https://api.github.com/users/fabiangreffrath/repos","events_url":"https://api.github.com/users/fabiangreffrath/events{/privacy}","received_events_url":"https://api.github.com/users/fabiangreffrath/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-09-10T09:51:05Z","updated_at":"2015-09-12T08:11:26Z","closed_at":null,"body":"Hi all,\r\n\r\nin map06 of DOOM2.wad there are two lines of type 117 (DR Open Door /fast) that will immediately crash Chocolate Doom upon activation. The reason is that they are missing a tag and are 1-sided, i.e. they have no sector on their backside. These lines are linedef #24 and #25, inside the red door.\r\n\r\nThis happens in `EV_VerticalDoor()` in `src/doom/p_doors.c`:\r\n```\r\nsec = sides[ line->sidenum[side^1]] .sector;\r\n```\r\nNow imagine what happens if `line->sidenum[1] == -1`...\r\n\r\nDOOM.EXE also does strange things as reported by dosbox, but it does not crash. Boom already has a check for this in EV_VerticalDoor() and does thus not crash either. So, how should we Chocolate Doom behave, then?\r\n"},"comment":{"url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/comments/139739649","html_url":"https://github.com/chocolate-doom/chocolate-doom/issues/609#issuecomment-139739649","issue_url":"https://api.github.com/repos/chocolate-doom/chocolate-doom/issues/609","id":139739649,"user":{"login":"jmtd","id":63694,"avatar_url":"https://avatars.githubusercontent.com/u/63694?v=3","gravatar_id":"","url":"https://api.github.com/users/jmtd","html_url":"https://github.com/jmtd","followers_url":"https://api.github.com/users/jmtd/followers","following_url":"https://api.github.com/users/jmtd/following{/other_user}","gists_url":"https://api.github.com/users/jmtd/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtd/subscriptions","organizations_url":"https://api.github.com/users/jmtd/orgs","repos_url":"https://api.github.com/users/jmtd/repos","events_url":"https://api.github.com/users/jmtd/events{/privacy}","received_events_url":"https://api.github.com/users/jmtd/received_events","type":"User","site_admin":false},"created_at":"2015-09-12T08:11:25Z","updated_at":"2015-09-12T08:11:25Z","body":"Venetian blind crashes trigger a segfault in DOSBox for me on OS X.\r\n\r\nI agree with @linguica; it's appropriate for c-d to exit when the error occurs, as exiting is vanilla behaviour; it's in-line with project philosophy to give a clear message to the user as to what happened; but it should be a 'clean', captured exit, not a sigbus, segfault or whatever."}}