{"action":"created","issue":{"url":"https://api.github.com/repos/tux3/qTox/issues/2509","labels_url":"https://api.github.com/repos/tux3/qTox/issues/2509/labels{/name}","comments_url":"https://api.github.com/repos/tux3/qTox/issues/2509/comments","events_url":"https://api.github.com/repos/tux3/qTox/issues/2509/events","html_url":"https://github.com/tux3/qTox/pull/2509","id":115539674,"number":2509,"title":"some cleanup for audio based on \"newav_final_for_realsies\"","user":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"tux3","id":5155966,"avatar_url":"https://avatars.githubusercontent.com/u/5155966?v=3","gravatar_id":"","url":"https://api.github.com/users/tux3","html_url":"https://github.com/tux3","followers_url":"https://api.github.com/users/tux3/followers","following_url":"https://api.github.com/users/tux3/following{/other_user}","gists_url":"https://api.github.com/users/tux3/gists{/gist_id}","starred_url":"https://api.github.com/users/tux3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tux3/subscriptions","organizations_url":"https://api.github.com/users/tux3/orgs","repos_url":"https://api.github.com/users/tux3/repos","events_url":"https://api.github.com/users/tux3/events{/privacy}","received_events_url":"https://api.github.com/users/tux3/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-11-06T16:29:59Z","updated_at":"2015-11-08T05:20:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/tux3/qTox/pulls/2509","html_url":"https://github.com/tux3/qTox/pull/2509","diff_url":"https://github.com/tux3/qTox/pull/2509.diff","patch_url":"https://github.com/tux3/qTox/pull/2509.patch"},"body":"Revival of #2463\r\n\r\n- [x] Open audio input & output device only, if not already open, when subscribing to input.\r\n    * It is questionable, that the output device should be opened at all in `subscribeInput`\r\n- [x] use internal methods to cleanup & close audio devices"},"comment":{"url":"https://api.github.com/repos/tux3/qTox/issues/comments/154776476","html_url":"https://github.com/tux3/qTox/pull/2509#issuecomment-154776476","issue_url":"https://api.github.com/repos/tux3/qTox/issues/2509","id":154776476,"user":{"login":"antis81","id":440517,"avatar_url":"https://avatars.githubusercontent.com/u/440517?v=3","gravatar_id":"","url":"https://api.github.com/users/antis81","html_url":"https://github.com/antis81","followers_url":"https://api.github.com/users/antis81/followers","following_url":"https://api.github.com/users/antis81/following{/other_user}","gists_url":"https://api.github.com/users/antis81/gists{/gist_id}","starred_url":"https://api.github.com/users/antis81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antis81/subscriptions","organizations_url":"https://api.github.com/users/antis81/orgs","repos_url":"https://api.github.com/users/antis81/repos","events_url":"https://api.github.com/users/antis81/events{/privacy}","received_events_url":"https://api.github.com/users/antis81/received_events","type":"User","site_admin":false},"created_at":"2015-11-08T05:20:26Z","updated_at":"2015-11-08T05:20:26Z","body":"@tux3 It is not as buggy as one might think at first view - just required a slight modification… :smile: I finally managed to compile (will open new issue for that soon) and thus check it myself. Now listen to the sound… :smile:\r\n\r\nYou should notice, that there's no more nasty noises when re-calling a person. The only thing I'm not sure about is, if the open device is closed on hangup. I like to fix it in this PR, too.\r\n\r\n@agilob @zetok Tested with ALSA. Can you confirm, this improves qTox audio with PulseAudio, please?"}}