{"action":"created","issue":{"url":"https://api.github.com/repos/brooklyncentral/clocker/issues/118","labels_url":"https://api.github.com/repos/brooklyncentral/clocker/issues/118/labels{/name}","comments_url":"https://api.github.com/repos/brooklyncentral/clocker/issues/118/comments","events_url":"https://api.github.com/repos/brooklyncentral/clocker/issues/118/events","html_url":"https://github.com/brooklyncentral/clocker/pull/118","id":89348266,"number":118,"title":"Support docker exec (instead of SSH)","user":{"login":"csabapalfi","id":181959,"avatar_url":"https://avatars.githubusercontent.com/u/181959?v=3","gravatar_id":"","url":"https://api.github.com/users/csabapalfi","html_url":"https://github.com/csabapalfi","followers_url":"https://api.github.com/users/csabapalfi/followers","following_url":"https://api.github.com/users/csabapalfi/following{/other_user}","gists_url":"https://api.github.com/users/csabapalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/csabapalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabapalfi/subscriptions","organizations_url":"https://api.github.com/users/csabapalfi/orgs","repos_url":"https://api.github.com/users/csabapalfi/repos","events_url":"https://api.github.com/users/csabapalfi/events{/privacy}","received_events_url":"https://api.github.com/users/csabapalfi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-06-18T17:19:58Z","updated_at":"2015-06-23T08:00:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/brooklyncentral/clocker/pulls/118","html_url":"https://github.com/brooklyncentral/clocker/pull/118","diff_url":"https://github.com/brooklyncentral/clocker/pull/118.diff","patch_url":"https://github.com/brooklyncentral/clocker/pull/118.patch"},"body":"This is still work in progress. It's a naive implementation for using docker exec instead of SSHing in to container to execute commands.\r\n\r\n* need to rebase this on top of the latest master (with latest weave) then force push\r\n* env vars are not handled properly\r\n* there are a few places where DockerContainerLocation is still used as an SSH location as it implements that interface (e.g. MachineLifecycleEffectorTasks.resolveOnBoxDir)"},"comment":{"url":"https://api.github.com/repos/brooklyncentral/clocker/issues/comments/114396853","html_url":"https://github.com/brooklyncentral/clocker/pull/118#issuecomment-114396853","issue_url":"https://api.github.com/repos/brooklyncentral/clocker/issues/118","id":114396853,"user":{"login":"csabapalfi","id":181959,"avatar_url":"https://avatars.githubusercontent.com/u/181959?v=3","gravatar_id":"","url":"https://api.github.com/users/csabapalfi","html_url":"https://github.com/csabapalfi","followers_url":"https://api.github.com/users/csabapalfi/followers","following_url":"https://api.github.com/users/csabapalfi/following{/other_user}","gists_url":"https://api.github.com/users/csabapalfi/gists{/gist_id}","starred_url":"https://api.github.com/users/csabapalfi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/csabapalfi/subscriptions","organizations_url":"https://api.github.com/users/csabapalfi/orgs","repos_url":"https://api.github.com/users/csabapalfi/repos","events_url":"https://api.github.com/users/csabapalfi/events{/privacy}","received_events_url":"https://api.github.com/users/csabapalfi/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T08:00:31Z","updated_at":"2015-06-23T08:00:31Z","body":"Almost there, just need to make sure that we escape quotes correctly. \r\n\r\nAs we're running docker exec by SSHing into the docker host escaping gets a bit tricky."}}