{"push_id":867412528,"size":17,"distinct_size":17,"ref":"refs/heads/spike-fail-fast-on-missing-methods-in-state-object","head":"deda27a474eba1c3e5826734f81a7ad723d22571","before":"c617309d2c9f86782a706fba39047ddaa6da11b8","commits":[{"sha":"a81e60fd23dc84daa20b78563a7ea244cfcad9a7","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to additional-commodity-code\n\nCaught by the regression tests.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/a81e60fd23dc84daa20b78563a7ea244cfcad9a7"},{"sha":"759f8462906a0500e9e881f76b6a083754b269c8","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to calculate-agricultural-holiday-entitlement","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/759f8462906a0500e9e881f76b6a083754b269c8"},{"sha":"3abbf62deca9cacf707cf580ec6dc9da6d1fcbfb","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to calculate-married-couples-allowance","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/3abbf62deca9cacf707cf580ec6dc9da6d1fcbfb"},{"sha":"eb1d65d4e30eed438947cd77a7008f2a1b7a26eb","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to calculate-state-pension","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/eb1d65d4e30eed438947cd77a7008f2a1b7a26eb"},{"sha":"47a0763f65c15a9f7ebc4fb069f223d5313797b8","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to calculate-your-holiday-entitlement","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/47a0763f65c15a9f7ebc4fb069f223d5313797b8"},{"sha":"031065bb35d2a718dad7551afe33198a2a9f34cc","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to check-uk-visa","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/031065bb35d2a718dad7551afe33198a2a9f34cc"},{"sha":"ec08941ab829ea4a0f60bda68ef02f65519e90e4","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to childcare-costs-for-tax-credits","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/ec08941ab829ea4a0f60bda68ef02f65519e90e4"},{"sha":"1f1e8e64c5d15e5f633bc32fd1143edd7a417681","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to energy-grants-calculator","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/1f1e8e64c5d15e5f633bc32fd1143edd7a417681"},{"sha":"01711e9dfbc31c92d823f515abec3904a5b32c4d","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to marriage-abroad","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/01711e9dfbc31c92d823f515abec3904a5b32c4d"},{"sha":"038131c63c522fbf28a7f43084991d8c532a6e5e","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to maternity-paternity-calculator","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/038131c63c522fbf28a7f43084991d8c532a6e5e"},{"sha":"6c95f32ec0fbe0f62814dfb669aa17d9962660f1","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to minimum_wage shared logic","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/6c95f32ec0fbe0f62814dfb669aa17d9962660f1"},{"sha":"0466d0d40556b162dbc3240f4934c8456d976cf0","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to overseas-passports","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/0466d0d40556b162dbc3240f4934c8456d976cf0"},{"sha":"b6ab5ddc13e1d01c67487baf93fa013fe9015926","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add missing variables to simplified-expenses-checker","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/b6ab5ddc13e1d01c67487baf93fa013fe9015926"},{"sha":"7674e7addd0eab233b8ed49864c3e98cea51822d","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Update question_base_test.rb\n\nEnsure the color variable is set on the state before trying to call it.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/7674e7addd0eab233b8ed49864c3e98cea51822d"},{"sha":"1cab9841fa46d910cc3c73a379d750028a8ce20b","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Update am_i_getting_minimum_wage_flow_test.rb\n\nEnsure the accommodation_charge variable is set on the state before trying to\ncall it.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/1cab9841fa46d910cc3c73a379d750028a8ce20b"},{"sha":"3d775a8ccca975c7e33ab0f10c9b49075e3d169e","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Add State#error and State#response\n\nI'm planning to override `State#method_missing` so that it raises a\n`NoMethodError` if you attempt to read an attribute value without first setting\nit. We always want to be able to read `error` and `response` irrespective of\nwhether they've been set.\n\nI initially tried using `attr_reader` but that means that `error` and `state`\nare left out of the hash returned from `State#to_hash`. Setting them in this\ncall to `super` ensures that `#to_hash` works as expected.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/3d775a8ccca975c7e33ab0f10c9b49075e3d169e"},{"sha":"deda27a474eba1c3e5826734f81a7ad723d22571","author":{"email":"711c73f64afdce07b7e38039a96d2224209e9a6c@seagul.co.uk","name":"Chris Roos"},"message":"Implement State#method_missing\n\nSo that it raises a NoMethodError unless the method being called is a writer\n(i.e. ends in =).\n\nThis should help avoid errors in our code by failing fast if we try to access a\nmethod that's not previously been set on the `State`.","distinct":true,"url":"https://api.github.com/repos/alphagov/smart-answers/commits/deda27a474eba1c3e5826734f81a7ad723d22571"}]}