{"action":"created","issue":{"url":"https://api.github.com/repos/holidayextras/ui-toolkit/issues/7","labels_url":"https://api.github.com/repos/holidayextras/ui-toolkit/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/holidayextras/ui-toolkit/issues/7/comments","events_url":"https://api.github.com/repos/holidayextras/ui-toolkit/issues/7/events","html_url":"https://github.com/holidayextras/ui-toolkit/pull/7","id":70371984,"number":7,"title":"UXUI-222 - New Button styles","user":{"login":"jodiedoubleday","id":778942,"avatar_url":"https://avatars.githubusercontent.com/u/778942?v=3","gravatar_id":"","url":"https://api.github.com/users/jodiedoubleday","html_url":"https://github.com/jodiedoubleday","followers_url":"https://api.github.com/users/jodiedoubleday/followers","following_url":"https://api.github.com/users/jodiedoubleday/following{/other_user}","gists_url":"https://api.github.com/users/jodiedoubleday/gists{/gist_id}","starred_url":"https://api.github.com/users/jodiedoubleday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodiedoubleday/subscriptions","organizations_url":"https://api.github.com/users/jodiedoubleday/orgs","repos_url":"https://api.github.com/users/jodiedoubleday/repos","events_url":"https://api.github.com/users/jodiedoubleday/events{/privacy}","received_events_url":"https://api.github.com/users/jodiedoubleday/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-23T10:26:39Z","updated_at":"2015-04-23T10:26:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/holidayextras/ui-toolkit/pulls/7","html_url":"https://github.com/holidayextras/ui-toolkit/pull/7","diff_url":"https://github.com/holidayextras/ui-toolkit/pull/7.diff","patch_url":"https://github.com/holidayextras/ui-toolkit/pull/7.patch"},"body":"#### What does this PR do?\r\n- Adds styles for the ui-componenent-button\r\n- Default, Primary, Secondary, Success, Warning, Danger, Info buttons all added\r\n- Sizes - Small, Large and Extra-Large added (medium is default)\r\n- Updated docs to reflect changes and provided examples of each.\r\n\r\n#### What unit or integration tests does this PR have?\r\nN/A\r\n\r\n#### What selenium tests does this PR have?\r\nN/A\r\n\r\n#### How should a developer review this?\r\nCheck that the code seems sane and that the documentation describes sufficiently how to use it.\r\n`grunt docs` will build the docs for you to see the example etc.\r\n\r\n#### How should this be manually tested?\r\nRun `grunt docs` & check the example [http://localhost:4000](http://localhost:4000)\r\nHave a good look at the documentation, you should now see a full range of buttons.\r\nIf you click on the `code` tab on the documentation, you can live edit and play with the components.\r\n(N.B this functionality is sketchy, trying clicking on the end of words in the code section to edit)\r\n\r\n#### Any background context you want to provide?\r\nBootstrap buttons are a great base, but we require an extra button. We have used some of bootstraps code but removed elements we deem necessary and added in extra functionality.\r\n\r\n#### What are the relevant tickets?\r\nhttps://holidayextras.jira.com/browse/UXUI-222\r\n\r\n#### Screenshots (if appropriate)\r\n![screen shot 2015-04-23 at 11 23 29](https://cloud.githubusercontent.com/assets/778942/7295159/3638ac0a-e9ab-11e4-9827-e91e6629ef88.png)\r\n\r\n#### What gif best describes how you feel about this work?\r\n![button moon](http://blog.truffleshuffle.co.uk/wp-content/uploads/2015/02/Button-Moon-Gif.gif)\r\n\r\n---\r\n#### Quality checklist (for PR author to complete BEFORE code review):\r\n- [ ] I've checked there is appropriate unit test coverage.\r\n- [ ] I've checked there is appropriate selenium test coverage.\r\n- [ ] I've included regression tests for any bug fixes.\r\n- [ ] I've updated documentation with any changes to procedures.\r\n- [ ] I've tested this on mobile Android, Safari, Chrome for any visual changes.\r\n- [ ] I've tested this on desktop IE9/10/11, Firefox, Chrome for any visual changes.\r\n- [ ] I've checked any significant visual changes with a member of the UX/UI pod.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] I've added and updated translations for all supported languages\r\n- [ ] I've informed those who need to know of any unforeseen impact of this work (database migrations, deployment procedure changes).\r\n- [ ] I am ready for this to be code reviewed, merged and tested.\r\n- [ ] I've thought about writing a blog post about this\r\n\r\n#### IP or Developer Review:\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve run all the tests locally and they pass.\r\n- [ ] +1 from me!\r\n\r\n#### Software Engineer or Developer review:\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve run all the tests locally and they pass.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I've checked this work against the requirements of the Jira.\r\n- [ ] +1 from me!\r\n\r\n#### Software Engineer or project guru review:\r\n- [ ] I agree with the assumptions made in the quality checklist.\r\n- [ ] I’ve witnessed the work behaving as expected.\r\n- [ ] I’ve run all the tests locally and they pass.\r\n- [ ] I’ve checked for appropriate test coverage.\r\n- [ ] I’ve checked for coding anti-patterns.\r\n- [ ] I don’t believe this work introduces unnecessary technical debt.\r\n- [ ] +1 from me!"},"comment":{"url":"https://api.github.com/repos/holidayextras/ui-toolkit/issues/comments/95527094","html_url":"https://github.com/holidayextras/ui-toolkit/pull/7#issuecomment-95527094","issue_url":"https://api.github.com/repos/holidayextras/ui-toolkit/issues/7","id":95527094,"user":{"login":"jodiedoubleday","id":778942,"avatar_url":"https://avatars.githubusercontent.com/u/778942?v=3","gravatar_id":"","url":"https://api.github.com/users/jodiedoubleday","html_url":"https://github.com/jodiedoubleday","followers_url":"https://api.github.com/users/jodiedoubleday/followers","following_url":"https://api.github.com/users/jodiedoubleday/following{/other_user}","gists_url":"https://api.github.com/users/jodiedoubleday/gists{/gist_id}","starred_url":"https://api.github.com/users/jodiedoubleday/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jodiedoubleday/subscriptions","organizations_url":"https://api.github.com/users/jodiedoubleday/orgs","repos_url":"https://api.github.com/users/jodiedoubleday/repos","events_url":"https://api.github.com/users/jodiedoubleday/events{/privacy}","received_events_url":"https://api.github.com/users/jodiedoubleday/received_events","type":"User","site_admin":false},"created_at":"2015-04-23T10:26:54Z","updated_at":"2015-04-23T10:26:54Z","body":"@joestump "}}