{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/2514","labels_url":"https://api.github.com/repos/nodejs/node/issues/2514/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/2514/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/2514/events","html_url":"https://github.com/nodejs/node/issues/2514","id":102721085,"number":2514,"title":" [Converge] SSLv2/3 related commits","user":{"login":"rvagg","id":495647,"avatar_url":"https://avatars.githubusercontent.com/u/495647?v=3","gravatar_id":"","url":"https://api.github.com/users/rvagg","html_url":"https://github.com/rvagg","followers_url":"https://api.github.com/users/rvagg/followers","following_url":"https://api.github.com/users/rvagg/following{/other_user}","gists_url":"https://api.github.com/users/rvagg/gists{/gist_id}","starred_url":"https://api.github.com/users/rvagg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rvagg/subscriptions","organizations_url":"https://api.github.com/users/rvagg/orgs","repos_url":"https://api.github.com/users/rvagg/repos","events_url":"https://api.github.com/users/rvagg/events{/privacy}","received_events_url":"https://api.github.com/users/rvagg/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/node/labels/tls","name":"tls","color":"fad8c7"}],"state":"closed","locked":false,"assignee":{"login":"shigeki","id":782880,"avatar_url":"https://avatars.githubusercontent.com/u/782880?v=3","gravatar_id":"","url":"https://api.github.com/users/shigeki","html_url":"https://github.com/shigeki","followers_url":"https://api.github.com/users/shigeki/followers","following_url":"https://api.github.com/users/shigeki/following{/other_user}","gists_url":"https://api.github.com/users/shigeki/gists{/gist_id}","starred_url":"https://api.github.com/users/shigeki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shigeki/subscriptions","organizations_url":"https://api.github.com/users/shigeki/orgs","repos_url":"https://api.github.com/users/shigeki/repos","events_url":"https://api.github.com/users/shigeki/events{/privacy}","received_events_url":"https://api.github.com/users/shigeki/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nodejs/node/milestones/10","html_url":"https://github.com/nodejs/node/milestones/4.0.0","labels_url":"https://api.github.com/repos/nodejs/node/milestones/10/labels","id":1232256,"number":10,"title":"4.0.0","description":"","creator":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars.githubusercontent.com/u/1093990?v=3","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":5,"state":"open","created_at":"2015-07-29T19:30:25Z","updated_at":"2015-08-25T07:33:50Z","due_on":"2015-08-31T07:00:00Z","closed_at":null},"comments":5,"created_at":"2015-08-24T06:48:15Z","updated_at":"2015-08-25T07:33:50Z","closed_at":"2015-08-25T07:33:50Z","body":"Continuing from https://github.com/nodejs/node-convergence-archive/issues/20, marking against 4.0.0 milestone. Summary of that discussion is that **SSLv2 and SSLv3 will not be reintroduced to v4**, but there are some outstanding items raised by @misterdjules:\r\n\r\n> If I remember correctly, joyent/node@69080f5 is a bug fix that is independent of SSLv2/SSLv3 support, and I would think we'd want to keep it.\r\n>\r\n> joyent/node@8d045a3 (and subsequent changes to the tests that it adds) has proven to be very valuable to catch issues when upgrading OpenSSL. It's actually what helped us find out about the problen that joyent/node@69080f5 fixes, and others. So I would suggest to keep that too.\r\n>\r\n> joyent/node@d230fa9 fixes a minor but still real issue with documentation. I would also keep that.\r\n\r\n@jasnell can you look back through that thread to see if there are any other commits missing from this list that should be included?"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/134510787","html_url":"https://github.com/nodejs/node/issues/2514#issuecomment-134510787","issue_url":"https://api.github.com/repos/nodejs/node/issues/2514","id":134510787,"user":{"login":"shigeki","id":782880,"avatar_url":"https://avatars.githubusercontent.com/u/782880?v=3","gravatar_id":"","url":"https://api.github.com/users/shigeki","html_url":"https://github.com/shigeki","followers_url":"https://api.github.com/users/shigeki/followers","following_url":"https://api.github.com/users/shigeki/following{/other_user}","gists_url":"https://api.github.com/users/shigeki/gists{/gist_id}","starred_url":"https://api.github.com/users/shigeki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shigeki/subscriptions","organizations_url":"https://api.github.com/users/shigeki/orgs","repos_url":"https://api.github.com/users/shigeki/repos","events_url":"https://api.github.com/users/shigeki/events{/privacy}","received_events_url":"https://api.github.com/users/shigeki/received_events","type":"User","site_admin":false},"created_at":"2015-08-25T07:33:50Z","updated_at":"2015-08-25T07:33:50Z","body":"@rvagg Okay, no problem. \r\n\r\nChecking all test cases in joyent/node@8d045a3, I think this is not necessary to be merged into 4.0 because 4.0 has no `--enable-ssl2/ssl3` command line options and configurations of SSL options/methods for SSLv2/v3 are explicitly disabled so that the remaining test cases are only for TLSv1_methods. \r\n\r\nThe doc fix of joyent/node@d230fa9 is for the description that was introduced only in joyent/node as https://github.com/joyent/node/commit/1349b680badeb5d08ad82811af8350dc3e0f0397 to allow SSLv2/v3. This description is not included in 4.0 so it's no longer is needed neither.\r\n"}}