{"action":"created","comment":{"url":"https://api.github.com/repos/akka/akka/pulls/comments/28861739","id":28861739,"diff_hunk":"@@ -0,0 +1,121 @@\n+/**\n+ * Copyright (C) 2015 Typesafe Inc. <http://www.typesafe.com>\n+ */\n+package akka.stream.io.impl\n+\n+import java.io.InputStream\n+\n+import akka.actor.{ ActorLogging, DeadLetterSuppression, Props }\n+import akka.io.DirectByteBufferPool\n+import akka.stream.actor.ActorPublisherMessage\n+import akka.util.ByteString\n+import akka.util.ByteString.ByteString1C\n+\n+import scala.annotation.tailrec\n+import scala.concurrent.Promise\n+\n+/** INTERNAL API */\n+private[akka] object InputStreamPublisher {\n+\n+  def props(is: InputStream, completionPromise: Promise[Long], chunkSize: Int, initialBuffer: Int, maxBuffer: Int): Props = {\n+    require(chunkSize > 0, s\"chunkSize must be > 0 (was $chunkSize)\")\n+    require(initialBuffer > 0, s\"initialBuffer must be > 0 (was $initialBuffer)\")\n+    require(maxBuffer >= initialBuffer, s\"maxBuffer must be >= initialBuffer (was $maxBuffer)\")\n+\n+    Props(classOf[InputStreamPublisher], is, completionPromise, chunkSize, initialBuffer, maxBuffer)\n+  }\n+\n+  private final case object Continue extends DeadLetterSuppression\n+}\n+\n+/** INTERNAL API */\n+private[akka] class InputStreamPublisher(is: InputStream, bytesReadPromise: Promise[Long], chunkSize: Int, initialBuffer: Int, maxBuffer: Int)\n+  extends akka.stream.actor.ActorPublisher[ByteString]\n+  with ActorLogging {\n+\n+  // TODO possibly de-duplicate with SynchronousFilePublisher?\n+\n+  import InputStreamPublisher._\n+\n+  val buffs = new DirectByteBufferPool(chunkSize, maxBuffer)\n+  var eofReachedAtOffset = Long.MinValue\n+\n+  var readBytesTotal = 0L\n+  var availableChunks: Vector[ByteString] = Vector.empty\n+\n+  override def preStart() = {\n+    try {\n+      readAndSignal(initialBuffer)\n+    } catch {\n+      case ex: Exception ⇒\n+        onError(ex)\n+    }\n+\n+    super.preStart()\n+  }\n+\n+  def receive = {\n+    case ActorPublisherMessage.Request(elements) ⇒ readAndSignal(maxBuffer)\n+    case Continue                                ⇒ readAndSignal(maxBuffer)\n+    case ActorPublisherMessage.Cancel            ⇒ context.stop(self)\n+  }\n+\n+  def readAndSignal(readAhead: Int): Unit =\n+    if (isActive) {\n+      // signal from available buffer right away\n+      signalOnNexts()\n+\n+      // read chunks until readAhead is fulfilled\n+      while (availableChunks.length < readAhead && !eofEncountered && isActive)\n+        loadChunk()\n+\n+      if (totalDemand > 0) self ! Continue\n+      else if (availableChunks.isEmpty) signalOnNexts()\n+    }\n+\n+  @tailrec private def signalOnNexts(): Unit =\n+    if (availableChunks.nonEmpty) {\n+      if (totalDemand > 0) {\n+        val ready = availableChunks.head\n+        availableChunks = availableChunks.tail\n+\n+        onNext(ready)\n+\n+        if (totalDemand > 0) signalOnNexts()\n+      }\n+    } else if (eofEncountered) onComplete()\n+\n+  /** BLOCKING I/O READ */\n+  def loadChunk() = try {\n+    val arr = Array.ofDim[Byte](chunkSize)\n+\n+    // blocking read\n+    val readBytes = is.read(arr)\n+\n+    readBytes match {\n+      case -1 | 0 ⇒","path":"akka-stream/src/main/scala/akka/stream/io/impl/InputStreamPublisher.scala","position":96,"original_position":96,"commit_id":"2dd7c56b217928fe1b7f86353742eb5736ce56c7","original_commit_id":"2dd7c56b217928fe1b7f86353742eb5736ce56c7","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"Good catch, thanks guys","created_at":"2015-04-22T10:52:41Z","updated_at":"2015-04-22T10:52:41Z","html_url":"https://github.com/akka/akka/pull/17211#discussion_r28861739","pull_request_url":"https://api.github.com/repos/akka/akka/pulls/17211","_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/comments/28861739"},"html":{"href":"https://github.com/akka/akka/pull/17211#discussion_r28861739"},"pull_request":{"href":"https://api.github.com/repos/akka/akka/pulls/17211"}}},"pull_request":{"url":"https://api.github.com/repos/akka/akka/pulls/17211","id":33434397,"html_url":"https://github.com/akka/akka/pull/17211","diff_url":"https://github.com/akka/akka/pull/17211.diff","patch_url":"https://github.com/akka/akka/pull/17211.patch","issue_url":"https://api.github.com/repos/akka/akka/issues/17211","number":17211,"state":"open","locked":false,"title":"+str #15588 Java 6 Synchronous File Sink / Source","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"body":"Note for reviewers: Yes, these are blocking and pretty simple. Got asynchronous impls stashed and can dig them up, however we can't include them directly because they'd require JDK7.\r\n\r\nResolves https://github.com/akka/akka/issues/15588 ","created_at":"2015-04-16T09:48:48Z","updated_at":"2015-04-22T10:52:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b6d26989fc18f45fba1caba1a2d95cf0d041b254","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/akka/akka/pulls/17211/commits","review_comments_url":"https://api.github.com/repos/akka/akka/pulls/17211/comments","review_comment_url":"https://api.github.com/repos/akka/akka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akka/akka/issues/17211/comments","statuses_url":"https://api.github.com/repos/akka/akka/statuses/2dd7c56b217928fe1b7f86353742eb5736ce56c7","head":{"label":"ktoso:wip-filesource-java6-ktoso","ref":"wip-filesource-java6-ktoso","sha":"2dd7c56b217928fe1b7f86353742eb5736ce56c7","user":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"repo":{"id":4462204,"name":"akka","full_name":"ktoso/akka","owner":{"login":"ktoso","id":120979,"avatar_url":"https://avatars.githubusercontent.com/u/120979?v=3","gravatar_id":"","url":"https://api.github.com/users/ktoso","html_url":"https://github.com/ktoso","followers_url":"https://api.github.com/users/ktoso/followers","following_url":"https://api.github.com/users/ktoso/following{/other_user}","gists_url":"https://api.github.com/users/ktoso/gists{/gist_id}","starred_url":"https://api.github.com/users/ktoso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktoso/subscriptions","organizations_url":"https://api.github.com/users/ktoso/orgs","repos_url":"https://api.github.com/users/ktoso/repos","events_url":"https://api.github.com/users/ktoso/events{/privacy}","received_events_url":"https://api.github.com/users/ktoso/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ktoso/akka","description":"Akka Project","fork":true,"url":"https://api.github.com/repos/ktoso/akka","forks_url":"https://api.github.com/repos/ktoso/akka/forks","keys_url":"https://api.github.com/repos/ktoso/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktoso/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktoso/akka/teams","hooks_url":"https://api.github.com/repos/ktoso/akka/hooks","issue_events_url":"https://api.github.com/repos/ktoso/akka/issues/events{/number}","events_url":"https://api.github.com/repos/ktoso/akka/events","assignees_url":"https://api.github.com/repos/ktoso/akka/assignees{/user}","branches_url":"https://api.github.com/repos/ktoso/akka/branches{/branch}","tags_url":"https://api.github.com/repos/ktoso/akka/tags","blobs_url":"https://api.github.com/repos/ktoso/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktoso/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktoso/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktoso/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktoso/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/ktoso/akka/languages","stargazers_url":"https://api.github.com/repos/ktoso/akka/stargazers","contributors_url":"https://api.github.com/repos/ktoso/akka/contributors","subscribers_url":"https://api.github.com/repos/ktoso/akka/subscribers","subscription_url":"https://api.github.com/repos/ktoso/akka/subscription","commits_url":"https://api.github.com/repos/ktoso/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktoso/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktoso/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktoso/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktoso/akka/contents/{+path}","compare_url":"https://api.github.com/repos/ktoso/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktoso/akka/merges","archive_url":"https://api.github.com/repos/ktoso/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktoso/akka/downloads","issues_url":"https://api.github.com/repos/ktoso/akka/issues{/number}","pulls_url":"https://api.github.com/repos/ktoso/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/ktoso/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/ktoso/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktoso/akka/labels{/name}","releases_url":"https://api.github.com/repos/ktoso/akka/releases{/id}","created_at":"2012-05-27T14:05:17Z","updated_at":"2015-04-03T11:58:56Z","pushed_at":"2015-04-21T23:57:31Z","git_url":"git://github.com/ktoso/akka.git","ssh_url":"git@github.com:ktoso/akka.git","clone_url":"https://github.com/ktoso/akka.git","svn_url":"https://github.com/ktoso/akka","homepage":"http://akka.io","size":163633,"stargazers_count":1,"watchers_count":1,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"akka:release-2.3-dev","ref":"release-2.3-dev","sha":"ef7ae332611f97866ec8edd6baa5d0cdf95a9ed7","user":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"repo":{"id":130013,"name":"akka","full_name":"akka/akka","owner":{"login":"akka","id":1496237,"avatar_url":"https://avatars.githubusercontent.com/u/1496237?v=3","gravatar_id":"","url":"https://api.github.com/users/akka","html_url":"https://github.com/akka","followers_url":"https://api.github.com/users/akka/followers","following_url":"https://api.github.com/users/akka/following{/other_user}","gists_url":"https://api.github.com/users/akka/gists{/gist_id}","starred_url":"https://api.github.com/users/akka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akka/subscriptions","organizations_url":"https://api.github.com/users/akka/orgs","repos_url":"https://api.github.com/users/akka/repos","events_url":"https://api.github.com/users/akka/events{/privacy}","received_events_url":"https://api.github.com/users/akka/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akka/akka","description":"Akka Project","fork":false,"url":"https://api.github.com/repos/akka/akka","forks_url":"https://api.github.com/repos/akka/akka/forks","keys_url":"https://api.github.com/repos/akka/akka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akka/akka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akka/akka/teams","hooks_url":"https://api.github.com/repos/akka/akka/hooks","issue_events_url":"https://api.github.com/repos/akka/akka/issues/events{/number}","events_url":"https://api.github.com/repos/akka/akka/events","assignees_url":"https://api.github.com/repos/akka/akka/assignees{/user}","branches_url":"https://api.github.com/repos/akka/akka/branches{/branch}","tags_url":"https://api.github.com/repos/akka/akka/tags","blobs_url":"https://api.github.com/repos/akka/akka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akka/akka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akka/akka/git/refs{/sha}","trees_url":"https://api.github.com/repos/akka/akka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akka/akka/statuses/{sha}","languages_url":"https://api.github.com/repos/akka/akka/languages","stargazers_url":"https://api.github.com/repos/akka/akka/stargazers","contributors_url":"https://api.github.com/repos/akka/akka/contributors","subscribers_url":"https://api.github.com/repos/akka/akka/subscribers","subscription_url":"https://api.github.com/repos/akka/akka/subscription","commits_url":"https://api.github.com/repos/akka/akka/commits{/sha}","git_commits_url":"https://api.github.com/repos/akka/akka/git/commits{/sha}","comments_url":"https://api.github.com/repos/akka/akka/comments{/number}","issue_comment_url":"https://api.github.com/repos/akka/akka/issues/comments{/number}","contents_url":"https://api.github.com/repos/akka/akka/contents/{+path}","compare_url":"https://api.github.com/repos/akka/akka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akka/akka/merges","archive_url":"https://api.github.com/repos/akka/akka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akka/akka/downloads","issues_url":"https://api.github.com/repos/akka/akka/issues{/number}","pulls_url":"https://api.github.com/repos/akka/akka/pulls{/number}","milestones_url":"https://api.github.com/repos/akka/akka/milestones{/number}","notifications_url":"https://api.github.com/repos/akka/akka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akka/akka/labels{/name}","releases_url":"https://api.github.com/repos/akka/akka/releases{/id}","created_at":"2009-02-16T12:51:54Z","updated_at":"2015-04-22T09:05:40Z","pushed_at":"2015-04-22T10:52:31Z","git_url":"git://github.com/akka/akka.git","ssh_url":"git@github.com:akka/akka.git","clone_url":"https://github.com/akka/akka.git","svn_url":"https://github.com/akka/akka","homepage":"http://akka.io","size":247346,"stargazers_count":3841,"watchers_count":3841,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1099,"mirror_url":null,"open_issues_count":649,"forks":1099,"open_issues":649,"watchers":3841,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akka/akka/pulls/17211"},"html":{"href":"https://github.com/akka/akka/pull/17211"},"issue":{"href":"https://api.github.com/repos/akka/akka/issues/17211"},"comments":{"href":"https://api.github.com/repos/akka/akka/issues/17211/comments"},"review_comments":{"href":"https://api.github.com/repos/akka/akka/pulls/17211/comments"},"review_comment":{"href":"https://api.github.com/repos/akka/akka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akka/akka/pulls/17211/commits"},"statuses":{"href":"https://api.github.com/repos/akka/akka/statuses/2dd7c56b217928fe1b7f86353742eb5736ce56c7"}}}}