{"push_id":877395333,"size":21,"distinct_size":8,"ref":"refs/heads/lr/default-unmanaged-bgo746566","head":"635464d1fe103bfb327f13fd6624795349dcda5a","before":"6de138b92c2bea22ca2722a045e723e1356b1024","commits":[{"sha":"c09b12240eccd57bb1279e44a55cd76712aa8c0c","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"dhcp-manager: strip hostname sent by internal DHCP client\n\nThe dhclient DHCP backend strips the domain part from the hostname\noption sent to server; for consistency among different backends\nuniform the internal client to do the same.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c09b12240eccd57bb1279e44a55cd76712aa8c0c"},{"sha":"dbbb08eb01b750532f3dfabf1b397f0adf01f710","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"dhcp-manager: strip hostname sent by dhcpcd\n\nThe dhclient DHCP backend strips the domain part from the hostname\noption sent to server; for consistency among different backends\nuniform the dhcpcd client to do the same.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/dbbb08eb01b750532f3dfabf1b397f0adf01f710"},{"sha":"cb40194532208108c3fb5cbf3c5b12a749fb6ad8","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"libnm-core: add a 'dhcp-fqdn' property to NMSettingIP4Config\n\nThe property contains the fully qualified domain name to be sent to\nDHCP server using the FQDN option. The property is mutually exclusive\nwith 'dhcp-hostname'.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cb40194532208108c3fb5cbf3c5b12a749fb6ad8"},{"sha":"5002342d94a1b166a2c577055e4160c98e30be87","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"ifcfg-rh: support the DHCP_FQDN variable\n\nAdd support for the DHCP_FQDN ifcfg-rh variable which maps to the\nipv4.dhcp-fqdn property.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5002342d94a1b166a2c577055e4160c98e30be87"},{"sha":"cba0f4e3c4f70a291d212f30772758dcc114ef17","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"cli: add ipv4.dhcp-fqdn property","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/cba0f4e3c4f70a291d212f30772758dcc114ef17"},{"sha":"c3573ebf2bb4958ee2ebf08e7ebac351765b92ef","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"dhcp4: send FQDN option when ipv4.dhcp-fqdn is set\n\nModify the 3 DHCP client backends to support the new property.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c3573ebf2bb4958ee2ebf08e7ebac351765b92ef"},{"sha":"9b1d195600721bac1ce6df6e5b284847a11b071c","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"merge: branch 'bg/dhcp-send-fqdn-rh1255507'\n\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1255507","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/9b1d195600721bac1ce6df6e5b284847a11b071c"},{"sha":"5031fc3c7163b254697f2c0a74b8a750de5fe7a8","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"nmtst: initialize g_test_init() after parsing NMTST_DEBUG","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5031fc3c7163b254697f2c0a74b8a750de5fe7a8"},{"sha":"c8174f0f9f2a38f0022ef49fb905d3b891b97e85","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"nmtst: detect whether the test runs as tap test\n\nSame as gtestutils does, look for --tap command line argument.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/c8174f0f9f2a38f0022ef49fb905d3b891b97e85"},{"sha":"a6a2fd7eef5a1aefcc7ab6d35b84a8d4c0039cd1","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"nmtst: pass -m=quick when specifying quick test in $NMTST_DEBUG\n\nWhen the environment variable indicates that we want to run quick\ntests, pass \"-m=quick\" to g_test_init().","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a6a2fd7eef5a1aefcc7ab6d35b84a8d4c0039cd1"},{"sha":"73cb57910835ef46d43bb92309def186e38534cf","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"nmtst: support -p and -s arguments from gtestutils via $NMTST_DEBUG\n\nFor tests based on glib's test framework, you can select which tests to\nrun by passing -p/-s on the command line.\n\nUsually, we want to invoke our tests via `make check` which conveniently\ncalls valgrind (run-test-valgrind.sh) or spawns a private D-Bus server\n(libnm-test-launch.sh, libnm-glib-test-launch.sh). At that point, it is\nnot directly possible to specify command line arguments for the tests,\nwhich is why it is convenient to specify arguments via $NMTST_DEBUG\nenvironment variable.\n\nParse \"p\" and \"s\" arguments from $NMTST_DEBUG and pass them to g_test_init()\nto select which tests to run.\n\n  NMTST_DEBUG=p=/core/general/test_setting_ip4_changed_signal ./libnm-core/tests/test-general\n\nHowever, there is a problem here: in gtestutils, -p/-s conflicts with --tap,\nwhich is how our Makefile invokes the tests. Thus the new options explicitly\ndon't work when being called during `make check`. Which makes this much\nless useful. I only noticed that afterwards, so still keep the patch\nbecause it might still be convenient during developing tests to set the\nenvironment variable once, and then repeatedly spawn the tests, without\nspecifying -p/-s.","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/73cb57910835ef46d43bb92309def186e38534cf"},{"sha":"4dacf0b1ad716747310e56188a0d283ee47ebee0","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"nmtst/valgrind: allow calling 'run-test-valgrind.sh' script directly\n\nWhen you want to run valgrind for a test, you either had to\ninvoke valgrind manually, or doing it via `make check` (provided\nyou configured --with-valgrind).\n\nMake it more convenient to run valgrind by passing the test\nto run to the \"run-test-valgrind.sh\" wrapper.\n\nThis also allows to pass -p/-s to the test, which is not possible\nduring `make check` because selecting tests conflicts with \"--tap\".\nThe following invocations are largely equivalent and work as\nexpected:\n\n  $ ./tools/run-test-valgrind.sh ./src/platform/tests/test-link-linux -p /link/software/detect/vlan\n\n  $ NMTST_DEBUG=no-debug,p=/link/software/detect/vlan ./tools/run-test-valgrind.sh ./src/platform/tests/test-link-linux","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/4dacf0b1ad716747310e56188a0d283ee47ebee0"},{"sha":"5276f6896b595b6ebc1a3a9233bc9eaa721a9e4e","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"tests: merge branch 'th/test-run-valgrind'","distinct":false,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/5276f6896b595b6ebc1a3a9233bc9eaa721a9e4e"},{"sha":"8320e466a14a762be0b449a69e1033d762748e1a","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: reorder unmanaged-flags\n\nThe next commit will rename several flags. So reorder them now to\nmake the next diff smaller (and easier to understand).","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/8320e466a14a762be0b449a69e1033d762748e1a"},{"sha":"0b9bdebc68b637c41127fc3c132202a907471c2d","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"core/trivial: move code","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/0b9bdebc68b637c41127fc3c132202a907471c2d"},{"sha":"8149519e9f8793f3bb8c78a20c0251c7712bdbfc","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"core/trivial: rename functions","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/8149519e9f8793f3bb8c78a20c0251c7712bdbfc"},{"sha":"a760819842468311f7df3320cccfc8da92f30f7a","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: return the unmanaged flags from nm_device_get_unmanaged_flags()","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/a760819842468311f7df3320cccfc8da92f30f7a"},{"sha":"ffa8b5dd591a1a9c7de153d53b3ea4564b2aaf7d","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: expose nm_device_set_autoconnect() function","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/ffa8b5dd591a1a9c7de153d53b3ea4564b2aaf7d"},{"sha":"7704322b64545086a88a4ba93d7e79059c8e1d15","author":{"email":"16e26612e4159990a6b3691e92592e691ff74132@redhat.com","name":"Thomas Haller"},"message":"device: remove default-unmanaged and refactor unamanged flags\n\nGet rid of NM_UNMANAGED_DEFAULT and refine the interaction between\nunmanaged flags, device state and managed property.\n\nPreviously, the NM_UNMANAGED_DEFAULT was special in that a device was\nconsidered managed if it had solely the NM_UNMANAGED_DEFAULT flag set and\nits state was managed. Thus, whether the device was managed, depended\non the device state too -- which is strange, because the state should\ninstead depend on the managed flags.\n\nNow, a device is considered managed (or unmanaged) only based on the\nunmanaged flags alone. At the same time, the device state directly\ncorresponds to the managed property of the device. Of course, while\nchanging the unmanaged flags, that invariant is shortly violated until\nthe state transistion is complete.\n\nIntroduce more unmanaged flags whereas some of them are non-authorative.\nFor example, the EXTERNAL_DOWN flag has only effect as long as the user\ndidn't explicitly manage the device (NM_UNMANAGED_USER_EXPLICIT). In other\nwords, certain flags can render other flags ineffective. Whether the device\nis considered managed depends on the flags but also at the explicitly unset flags.\nIn a way, this is similar to previously where the NM_UNMANAGED_DEFAULT\nwas ignored (if no other flags were present).\n\nAlso, previously a device that was NM_UNMANAGED_DEFAULT and in disconnected\nstate would transition back to unmanaged.\nNo longer do that. Once a device is managed, it stays managed as long as the\nflags indicate it should be managed. However, the user can already affect the\nunmanaged flags for example via the D-Bus API.\n\nhttps://bugzilla.gnome.org/show_bug.cgi?id=746566\n\nBased-on-patch-by: Lubomir Rintel <lkundrak@v3.sk>","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/7704322b64545086a88a4ba93d7e79059c8e1d15"},{"sha":"104579db3b4d3dd9bcc87737854432991da66325","author":{"email":"76686399b73357bbab3cce10937c280c528b17ce@redhat.com","name":"Beniamino Galvani"},"message":"fixup! device: remove default-unmanaged and refactor unamanged flags","distinct":true,"url":"https://api.github.com/repos/NetworkManager/NetworkManager/commits/104579db3b4d3dd9bcc87737854432991da66325"}]}