{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26767560","id":26767560,"diff_hunk":"@@ -32,14 +32,17 @@ import (\n \n var zero time.Time\n \n-func newRealImageManager(t *testing.T, policy ImageGCPolicy) (*realImageManager, *dockertools.FakeDockerClient, *cadvisor.Mock) {\n+func newRealImageManager(policy ImageGCPolicy) (*realImageManager, *dockertools.FakeDockerClient, *cadvisor.Mock) {","path":"pkg/kubelet/image_manager_test.go","position":5,"original_position":5,"commit_id":"3a3b950009469cb665c8dd3fdcc4dc36a2a79df2","original_commit_id":"3a3b950009469cb665c8dd3fdcc4dc36a2a79df2","user":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars.githubusercontent.com/u/10524058?v=3","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"body":"You stole my line. I usually tell people I'm terrible at names... ;)","created_at":"2015-03-19T15:54:15Z","updated_at":"2015-03-19T15:54:15Z","html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5627#discussion_r26767560","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments/26767560"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5627#discussion_r26767560"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627","id":31484735,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5627","diff_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5627.diff","patch_url":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5627.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5627","number":5627,"state":"closed","locked":false,"title":"Fix data race in imageManager test.","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"body":"The background monitoring thread was using the DockerClient before we\r\nhad written our fake data. This commit stops the background thread from\r\nrunning during tests.\r\n\r\nFixes #5611.","created_at":"2015-03-19T00:03:46Z","updated_at":"2015-03-19T15:54:15Z","closed_at":"2015-03-19T01:24:18Z","merged_at":"2015-03-19T01:24:18Z","merge_commit_sha":"f498368814de9fb28c95981c1635a80edeb89603","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5627/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/3a3b950009469cb665c8dd3fdcc4dc36a2a79df2","head":{"label":"vmarmol:fix-test","ref":"fix-test","sha":"3a3b950009469cb665c8dd3fdcc4dc36a2a79df2","user":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"repo":{"id":21019364,"name":"kubernetes","full_name":"vmarmol/kubernetes","owner":{"login":"vmarmol","id":985208,"avatar_url":"https://avatars.githubusercontent.com/u/985208?v=3","gravatar_id":"","url":"https://api.github.com/users/vmarmol","html_url":"https://github.com/vmarmol","followers_url":"https://api.github.com/users/vmarmol/followers","following_url":"https://api.github.com/users/vmarmol/following{/other_user}","gists_url":"https://api.github.com/users/vmarmol/gists{/gist_id}","starred_url":"https://api.github.com/users/vmarmol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmarmol/subscriptions","organizations_url":"https://api.github.com/users/vmarmol/orgs","repos_url":"https://api.github.com/users/vmarmol/repos","events_url":"https://api.github.com/users/vmarmol/events{/privacy}","received_events_url":"https://api.github.com/users/vmarmol/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vmarmol/kubernetes","description":"Container Cluster Manager","fork":true,"url":"https://api.github.com/repos/vmarmol/kubernetes","forks_url":"https://api.github.com/repos/vmarmol/kubernetes/forks","keys_url":"https://api.github.com/repos/vmarmol/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vmarmol/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vmarmol/kubernetes/teams","hooks_url":"https://api.github.com/repos/vmarmol/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/vmarmol/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/vmarmol/kubernetes/events","assignees_url":"https://api.github.com/repos/vmarmol/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/vmarmol/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/vmarmol/kubernetes/tags","blobs_url":"https://api.github.com/repos/vmarmol/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vmarmol/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vmarmol/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/vmarmol/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vmarmol/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/vmarmol/kubernetes/languages","stargazers_url":"https://api.github.com/repos/vmarmol/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/vmarmol/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/vmarmol/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/vmarmol/kubernetes/subscription","commits_url":"https://api.github.com/repos/vmarmol/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/vmarmol/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/vmarmol/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/vmarmol/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/vmarmol/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/vmarmol/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vmarmol/kubernetes/merges","archive_url":"https://api.github.com/repos/vmarmol/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vmarmol/kubernetes/downloads","issues_url":"https://api.github.com/repos/vmarmol/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/vmarmol/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/vmarmol/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/vmarmol/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vmarmol/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/vmarmol/kubernetes/releases{/id}","created_at":"2014-06-19T23:47:05Z","updated_at":"2014-10-03T15:37:19Z","pushed_at":"2015-03-19T15:52:07Z","git_url":"git://github.com/vmarmol/kubernetes.git","ssh_url":"git@github.com:vmarmol/kubernetes.git","clone_url":"https://github.com/vmarmol/kubernetes.git","svn_url":"https://github.com/vmarmol/kubernetes","homepage":null,"size":36571,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"242dd9c92174e62ca68761013f727da4aeeca05d","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"GoogleCloudPlatform/kubernetes","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-03-19T15:43:31Z","pushed_at":"2015-03-19T15:43:30Z","git_url":"git://github.com/GoogleCloudPlatform/kubernetes.git","ssh_url":"git@github.com:GoogleCloudPlatform/kubernetes.git","clone_url":"https://github.com/GoogleCloudPlatform/kubernetes.git","svn_url":"https://github.com/GoogleCloudPlatform/kubernetes","homepage":"http://kubernetes.io","size":106848,"stargazers_count":6655,"watchers_count":6655,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1239,"mirror_url":null,"open_issues_count":771,"forks":1239,"open_issues":771,"watchers":6655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627"},"html":{"href":"https://github.com/GoogleCloudPlatform/kubernetes/pull/5627"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5627"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/issues/5627/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/pulls/5627/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/kubernetes/statuses/3a3b950009469cb665c8dd3fdcc4dc36a2a79df2"}}}}