{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-schema/pulls/comments/22575149","id":22575149,"diff_hunk":"@@ -26,16 +26,61 @@ Source0:        %{name}-%{version}.tar.bz2\n Group:\t        System/YaST\n License:        GPL-2.0+\n \n-# FIXME: drop yast2-all-packages some day\n-BuildRequires:\ttrang yast2-all-packages\n-\n-# not covered by yast2-all-packages\n-BuildRequires:\tyast2-online-update-configuration\n-\n-\n-# yast2-core omited from some reason in buildservice, adding explicitly\n-BuildRequires:  yast2-core\n-#!BuildIgnore: yast2-build-test yast2-online-update\n+Url:            https://github.com/yast/yast-schema\n+\n+# Dependencies needed to build the package\n+BuildRequires:\ttrang yast2-devtools yast2-testsuite\n+\n+# All packages providing RNG files for AutoYaST\n+# in /usr/share/YaST2/schema/autoyast/rng/*.rng\n+BuildRequires: autoyast2\n+BuildRequires: yast2\n+BuildRequires: yast2-add-on\n+BuildRequires: yast2-audit-laf\n+BuildRequires: yast2-auth-client\n+BuildRequires: yast2-auth-server\n+BuildRequires: yast2-bootloader\n+BuildRequires: yast2-ca-management\n+BuildRequires: yast2-country\n+BuildRequires: yast2-dhcp-server\n+BuildRequires: yast2-dns-server\n+BuildRequires: yast2-firewall\n+BuildRequires: yast2-firstboot\n+BuildRequires: yast2-ftp-server\n+BuildRequires: yast2-http-server\n+BuildRequires: yast2-inetd\n+BuildRequires: yast2-installation\n+BuildRequires: yast2-iscsi-client\n+BuildRequires: yast2-kdump\n+BuildRequires: yast2-mail\n+BuildRequires: yast2-network\n+BuildRequires: yast2-nfs-client\n+BuildRequires: yast2-nfs-server\n+BuildRequires: yast2-nis-client\n+BuildRequires: yast2-nis-server\n+BuildRequires: yast2-ntp-client\n+BuildRequires: yast2-online-update-configuration\n+BuildRequires: yast2-printer\n+BuildRequires: yast2-proxy\n+# Available on SLE (12) only, needs to be adjusted for next SLE\n+%if 0%{?suse_version} == 1315\n+BuildRequires: yast2-registration","path":"package/yast2-schema.spec","position":61,"original_position":61,"commit_id":"2447abca87416dde93b9128c894290c2d447e3c4","original_commit_id":"2447abca87416dde93b9128c894290c2d447e3c4","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?v=3","gravatar_id":"","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"body":"No, no testcase. I've added that to All Ideas on Yast Team Trello. I know this might be a problem in the future and I've seen some discussions on ML that `this is not a problem at all` TM. Plus the fact that my team don't care either... saying `I told you` is not enough :)\r\n\r\nOn the other hand, I regret more that we cannot check for `sle_version` or `is_this_sles?`","created_at":"2015-01-07T08:28:09Z","updated_at":"2015-01-07T08:28:09Z","html_url":"https://github.com/yast/yast-schema/pull/5#discussion_r22575149","pull_request_url":"https://api.github.com/repos/yast/yast-schema/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-schema/pulls/comments/22575149"},"html":{"href":"https://github.com/yast/yast-schema/pull/5#discussion_r22575149"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-schema/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-schema/pulls/5","id":26371798,"html_url":"https://github.com/yast/yast-schema/pull/5","diff_url":"https://github.com/yast/yast-schema/pull/5.diff","patch_url":"https://github.com/yast/yast-schema/pull/5.patch","issue_url":"https://api.github.com/repos/yast/yast-schema/issues/5","number":5,"state":"closed","locked":false,"title":"Replacing yast2-all-packages in BuildRequires with list of packages needed for build","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?v=3","gravatar_id":"","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"body":"- Package `yast2-all-packages` will be dropped\r\n- This PR replaces that with list of Yast packages that contain RNG files needed for AutoYaST\r\n- Some Build-Ignores have been left there - for further clarification\r\n- The new RPM still contains the very same list of files (except of S390)","created_at":"2014-12-19T13:39:45Z","updated_at":"2015-01-07T08:28:09Z","closed_at":"2014-12-19T15:02:17Z","merged_at":"2014-12-19T15:02:17Z","merge_commit_sha":"c95800997f0881ac8696605ddd90408ab5804422","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-schema/pulls/5/commits","review_comments_url":"https://api.github.com/repos/yast/yast-schema/pulls/5/comments","review_comment_url":"https://api.github.com/repos/yast/yast-schema/pulls/comments/{number}","comments_url":"https://api.github.com/repos/yast/yast-schema/issues/5/comments","statuses_url":"https://api.github.com/repos/yast/yast-schema/statuses/2447abca87416dde93b9128c894290c2d447e3c4","head":{"label":"kobliha:remove-yast2-all-packages","ref":"remove-yast2-all-packages","sha":"2447abca87416dde93b9128c894290c2d447e3c4","user":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?v=3","gravatar_id":"","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"repo":{"id":27819575,"name":"yast-schema","full_name":"kobliha/yast-schema","owner":{"login":"kobliha","id":463995,"avatar_url":"https://avatars.githubusercontent.com/u/463995?v=3","gravatar_id":"","url":"https://api.github.com/users/kobliha","html_url":"https://github.com/kobliha","followers_url":"https://api.github.com/users/kobliha/followers","following_url":"https://api.github.com/users/kobliha/following{/other_user}","gists_url":"https://api.github.com/users/kobliha/gists{/gist_id}","starred_url":"https://api.github.com/users/kobliha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kobliha/subscriptions","organizations_url":"https://api.github.com/users/kobliha/orgs","repos_url":"https://api.github.com/users/kobliha/repos","events_url":"https://api.github.com/users/kobliha/events{/privacy}","received_events_url":"https://api.github.com/users/kobliha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kobliha/yast-schema","description":"YaST module schema","fork":true,"url":"https://api.github.com/repos/kobliha/yast-schema","forks_url":"https://api.github.com/repos/kobliha/yast-schema/forks","keys_url":"https://api.github.com/repos/kobliha/yast-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kobliha/yast-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kobliha/yast-schema/teams","hooks_url":"https://api.github.com/repos/kobliha/yast-schema/hooks","issue_events_url":"https://api.github.com/repos/kobliha/yast-schema/issues/events{/number}","events_url":"https://api.github.com/repos/kobliha/yast-schema/events","assignees_url":"https://api.github.com/repos/kobliha/yast-schema/assignees{/user}","branches_url":"https://api.github.com/repos/kobliha/yast-schema/branches{/branch}","tags_url":"https://api.github.com/repos/kobliha/yast-schema/tags","blobs_url":"https://api.github.com/repos/kobliha/yast-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kobliha/yast-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kobliha/yast-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/kobliha/yast-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kobliha/yast-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/kobliha/yast-schema/languages","stargazers_url":"https://api.github.com/repos/kobliha/yast-schema/stargazers","contributors_url":"https://api.github.com/repos/kobliha/yast-schema/contributors","subscribers_url":"https://api.github.com/repos/kobliha/yast-schema/subscribers","subscription_url":"https://api.github.com/repos/kobliha/yast-schema/subscription","commits_url":"https://api.github.com/repos/kobliha/yast-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/kobliha/yast-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/kobliha/yast-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/kobliha/yast-schema/issues/comments/{number}","contents_url":"https://api.github.com/repos/kobliha/yast-schema/contents/{+path}","compare_url":"https://api.github.com/repos/kobliha/yast-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kobliha/yast-schema/merges","archive_url":"https://api.github.com/repos/kobliha/yast-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kobliha/yast-schema/downloads","issues_url":"https://api.github.com/repos/kobliha/yast-schema/issues{/number}","pulls_url":"https://api.github.com/repos/kobliha/yast-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/kobliha/yast-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/kobliha/yast-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kobliha/yast-schema/labels{/name}","releases_url":"https://api.github.com/repos/kobliha/yast-schema/releases{/id}","created_at":"2014-12-10T12:47:50Z","updated_at":"2014-12-18T15:05:25Z","pushed_at":"2014-12-19T15:02:18Z","git_url":"git://github.com/kobliha/yast-schema.git","ssh_url":"git@github.com:kobliha/yast-schema.git","clone_url":"https://github.com/kobliha/yast-schema.git","svn_url":"https://github.com/kobliha/yast-schema","homepage":"http://en.opensuse.org/Portal:YaST","size":209,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"32137b389273ee4bcceefde39988c242366dce8c","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368208,"name":"yast-schema","full_name":"yast/yast-schema","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-schema","description":"YaST module schema","fork":false,"url":"https://api.github.com/repos/yast/yast-schema","forks_url":"https://api.github.com/repos/yast/yast-schema/forks","keys_url":"https://api.github.com/repos/yast/yast-schema/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-schema/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-schema/teams","hooks_url":"https://api.github.com/repos/yast/yast-schema/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-schema/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-schema/events","assignees_url":"https://api.github.com/repos/yast/yast-schema/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-schema/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-schema/tags","blobs_url":"https://api.github.com/repos/yast/yast-schema/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-schema/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-schema/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-schema/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-schema/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-schema/languages","stargazers_url":"https://api.github.com/repos/yast/yast-schema/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-schema/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-schema/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-schema/subscription","commits_url":"https://api.github.com/repos/yast/yast-schema/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-schema/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-schema/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-schema/issues/comments/{number}","contents_url":"https://api.github.com/repos/yast/yast-schema/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-schema/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-schema/merges","archive_url":"https://api.github.com/repos/yast/yast-schema/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-schema/downloads","issues_url":"https://api.github.com/repos/yast/yast-schema/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-schema/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-schema/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-schema/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-schema/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-schema/releases{/id}","created_at":"2012-05-18T10:26:12Z","updated_at":"2014-12-19T15:02:18Z","pushed_at":"2014-12-19T15:02:18Z","git_url":"git://github.com/yast/yast-schema.git","ssh_url":"git@github.com:yast/yast-schema.git","clone_url":"https://github.com/yast/yast-schema.git","svn_url":"https://github.com/yast/yast-schema","homepage":"http://en.opensuse.org/Portal:YaST","size":400,"stargazers_count":2,"watchers_count":2,"language":"XSLT","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-schema/pulls/5"},"html":{"href":"https://github.com/yast/yast-schema/pull/5"},"issue":{"href":"https://api.github.com/repos/yast/yast-schema/issues/5"},"comments":{"href":"https://api.github.com/repos/yast/yast-schema/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-schema/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-schema/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-schema/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-schema/statuses/2447abca87416dde93b9128c894290c2d447e3c4"}}}}