{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/hpack/pulls/comments/43295606","id":43295606,"diff_hunk":"@@ -271,6 +287,7 @@ public void decode(InputStream in, HeaderListener headerListener) throws IOExcep\n         }\n \n         name = readStringLiteral(in, nameLength);\n+        nameString = new String(name, HpackUtil.ISO_8859_1);","path":"hpack/src/main/java/com/twitter/hpack/Decoder.java","position":67,"original_position":67,"commit_id":"3f8ff885ced0d132c162a420682e554af45a5e32","original_commit_id":"3f8ff885ced0d132c162a420682e554af45a5e32","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"body":"Seems reasonable. See note above about listener interface adjustment.  ","created_at":"2015-10-28T18:11:47Z","updated_at":"2015-10-28T18:11:47Z","html_url":"https://github.com/twitter/hpack/pull/28#discussion_r43295606","pull_request_url":"https://api.github.com/repos/twitter/hpack/pulls/28","_links":{"self":{"href":"https://api.github.com/repos/twitter/hpack/pulls/comments/43295606"},"html":{"href":"https://github.com/twitter/hpack/pull/28#discussion_r43295606"},"pull_request":{"href":"https://api.github.com/repos/twitter/hpack/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/hpack/pulls/28","id":48950100,"html_url":"https://github.com/twitter/hpack/pull/28","diff_url":"https://github.com/twitter/hpack/pull/28.diff","patch_url":"https://github.com/twitter/hpack/pull/28.patch","issue_url":"https://api.github.com/repos/twitter/hpack/issues/28","number":28,"state":"open","locked":false,"title":"Improve listener interface to reduce common parsing overheaders","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"body":"Proposed solution for https://github.com/twitter/hpack/issues/27\r\n\r\nStore header names and values as Strings to avoid listeners creating them every time\r\nAllow header entries to be annotated with parsed values to allow for higher-level optimizations\r\nBroaden header listener interface to accommodate above\r\nAdd benchmarks","created_at":"2015-10-28T00:11:59Z","updated_at":"2015-10-28T18:11:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"920461a1c5222076a072fa2a196074ae9ac30ae7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/twitter/hpack/pulls/28/commits","review_comments_url":"https://api.github.com/repos/twitter/hpack/pulls/28/comments","review_comment_url":"https://api.github.com/repos/twitter/hpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/hpack/issues/28/comments","statuses_url":"https://api.github.com/repos/twitter/hpack/statuses/3f8ff885ced0d132c162a420682e554af45a5e32","head":{"label":"louiscryan:AnnotatableListener","ref":"AnnotatableListener","sha":"3f8ff885ced0d132c162a420682e554af45a5e32","user":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"repo":{"id":43783926,"name":"hpack","full_name":"louiscryan/hpack","owner":{"login":"louiscryan","id":9046588,"avatar_url":"https://avatars.githubusercontent.com/u/9046588?v=3","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/louiscryan/hpack","description":"Header Compression for HTTP/2","fork":true,"url":"https://api.github.com/repos/louiscryan/hpack","forks_url":"https://api.github.com/repos/louiscryan/hpack/forks","keys_url":"https://api.github.com/repos/louiscryan/hpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/louiscryan/hpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/louiscryan/hpack/teams","hooks_url":"https://api.github.com/repos/louiscryan/hpack/hooks","issue_events_url":"https://api.github.com/repos/louiscryan/hpack/issues/events{/number}","events_url":"https://api.github.com/repos/louiscryan/hpack/events","assignees_url":"https://api.github.com/repos/louiscryan/hpack/assignees{/user}","branches_url":"https://api.github.com/repos/louiscryan/hpack/branches{/branch}","tags_url":"https://api.github.com/repos/louiscryan/hpack/tags","blobs_url":"https://api.github.com/repos/louiscryan/hpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/louiscryan/hpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/louiscryan/hpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/louiscryan/hpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/louiscryan/hpack/statuses/{sha}","languages_url":"https://api.github.com/repos/louiscryan/hpack/languages","stargazers_url":"https://api.github.com/repos/louiscryan/hpack/stargazers","contributors_url":"https://api.github.com/repos/louiscryan/hpack/contributors","subscribers_url":"https://api.github.com/repos/louiscryan/hpack/subscribers","subscription_url":"https://api.github.com/repos/louiscryan/hpack/subscription","commits_url":"https://api.github.com/repos/louiscryan/hpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/louiscryan/hpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/louiscryan/hpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/louiscryan/hpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/louiscryan/hpack/contents/{+path}","compare_url":"https://api.github.com/repos/louiscryan/hpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/louiscryan/hpack/merges","archive_url":"https://api.github.com/repos/louiscryan/hpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/louiscryan/hpack/downloads","issues_url":"https://api.github.com/repos/louiscryan/hpack/issues{/number}","pulls_url":"https://api.github.com/repos/louiscryan/hpack/pulls{/number}","milestones_url":"https://api.github.com/repos/louiscryan/hpack/milestones{/number}","notifications_url":"https://api.github.com/repos/louiscryan/hpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/louiscryan/hpack/labels{/name}","releases_url":"https://api.github.com/repos/louiscryan/hpack/releases{/id}","created_at":"2015-10-06T23:05:38Z","updated_at":"2015-10-06T23:05:39Z","pushed_at":"2015-10-28T00:00:20Z","git_url":"git://github.com/louiscryan/hpack.git","ssh_url":"git@github.com:louiscryan/hpack.git","clone_url":"https://github.com/louiscryan/hpack.git","svn_url":"https://github.com/louiscryan/hpack","homepage":"https://twitter.com/http_2","size":239,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"d71e550b4b933f1a1528102d83aef183fd819f9d","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":15347941,"name":"hpack","full_name":"twitter/hpack","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/hpack","description":"Header Compression for HTTP/2","fork":false,"url":"https://api.github.com/repos/twitter/hpack","forks_url":"https://api.github.com/repos/twitter/hpack/forks","keys_url":"https://api.github.com/repos/twitter/hpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/hpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/hpack/teams","hooks_url":"https://api.github.com/repos/twitter/hpack/hooks","issue_events_url":"https://api.github.com/repos/twitter/hpack/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/hpack/events","assignees_url":"https://api.github.com/repos/twitter/hpack/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/hpack/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/hpack/tags","blobs_url":"https://api.github.com/repos/twitter/hpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/hpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/hpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/hpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/hpack/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/hpack/languages","stargazers_url":"https://api.github.com/repos/twitter/hpack/stargazers","contributors_url":"https://api.github.com/repos/twitter/hpack/contributors","subscribers_url":"https://api.github.com/repos/twitter/hpack/subscribers","subscription_url":"https://api.github.com/repos/twitter/hpack/subscription","commits_url":"https://api.github.com/repos/twitter/hpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/hpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/hpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/hpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/hpack/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/hpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/hpack/merges","archive_url":"https://api.github.com/repos/twitter/hpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/hpack/downloads","issues_url":"https://api.github.com/repos/twitter/hpack/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/hpack/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/hpack/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/hpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/hpack/labels{/name}","releases_url":"https://api.github.com/repos/twitter/hpack/releases{/id}","created_at":"2013-12-20T20:52:48Z","updated_at":"2015-10-13T11:22:55Z","pushed_at":"2015-10-28T00:11:59Z","git_url":"git://github.com/twitter/hpack.git","ssh_url":"git@github.com:twitter/hpack.git","clone_url":"https://github.com/twitter/hpack.git","svn_url":"https://github.com/twitter/hpack","homepage":"https://twitter.com/http_2","size":900,"stargazers_count":105,"watchers_count":105,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":3,"forks":26,"open_issues":3,"watchers":105,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/hpack/pulls/28"},"html":{"href":"https://github.com/twitter/hpack/pull/28"},"issue":{"href":"https://api.github.com/repos/twitter/hpack/issues/28"},"comments":{"href":"https://api.github.com/repos/twitter/hpack/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/hpack/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/hpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/hpack/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/hpack/statuses/3f8ff885ced0d132c162a420682e554af45a5e32"}}}}