{"action":"created","issue":{"url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1515","labels_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1515/labels{/name}","comments_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1515/comments","events_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1515/events","html_url":"https://github.com/ImageEngine/gaffer/pull/1515","id":112749208,"number":1515,"title":"Image reader image cache size","user":{"login":"HughMacdonald","id":625512,"avatar_url":"https://avatars.githubusercontent.com/u/625512?v=3","gravatar_id":"","url":"https://api.github.com/users/HughMacdonald","html_url":"https://github.com/HughMacdonald","followers_url":"https://api.github.com/users/HughMacdonald/followers","following_url":"https://api.github.com/users/HughMacdonald/following{/other_user}","gists_url":"https://api.github.com/users/HughMacdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/HughMacdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HughMacdonald/subscriptions","organizations_url":"https://api.github.com/users/HughMacdonald/orgs","repos_url":"https://api.github.com/users/HughMacdonald/repos","events_url":"https://api.github.com/users/HughMacdonald/events{/privacy}","received_events_url":"https://api.github.com/users/HughMacdonald/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-10-22T07:53:50Z","updated_at":"2015-10-22T17:21:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ImageEngine/gaffer/pulls/1515","html_url":"https://github.com/ImageEngine/gaffer/pull/1515","diff_url":"https://github.com/ImageEngine/gaffer/pull/1515.diff","patch_url":"https://github.com/ImageEngine/gaffer/pull/1515.patch"},"body":"This PR adds control over the OIIO::ImageCache size, and defaults it to a larger initial size (500Mb)\r\n\r\nHaving this cache size left at its low default was causing a crash (shown by the new test in ImageWriterTest)\r\n\r\nLarry Gritz has made some changes to OIIO to avoid this crash, and will be adding new functionality to increase the cache size if a file is found that doesn't fit into the cache itself. As per this discussion: https://github.com/OpenImageIO/oiio/issues/1239\r\n\r\nI'm sure there'll be feedback on how I've implemented this, but I wanted to get something in there."},"comment":{"url":"https://api.github.com/repos/ImageEngine/gaffer/issues/comments/150295999","html_url":"https://github.com/ImageEngine/gaffer/pull/1515#issuecomment-150295999","issue_url":"https://api.github.com/repos/ImageEngine/gaffer/issues/1515","id":150295999,"user":{"login":"johnhaddon","id":1133871,"avatar_url":"https://avatars.githubusercontent.com/u/1133871?v=3","gravatar_id":"","url":"https://api.github.com/users/johnhaddon","html_url":"https://github.com/johnhaddon","followers_url":"https://api.github.com/users/johnhaddon/followers","following_url":"https://api.github.com/users/johnhaddon/following{/other_user}","gists_url":"https://api.github.com/users/johnhaddon/gists{/gist_id}","starred_url":"https://api.github.com/users/johnhaddon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnhaddon/subscriptions","organizations_url":"https://api.github.com/users/johnhaddon/orgs","repos_url":"https://api.github.com/users/johnhaddon/repos","events_url":"https://api.github.com/users/johnhaddon/events{/privacy}","received_events_url":"https://api.github.com/users/johnhaddon/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T17:21:05Z","updated_at":"2015-10-22T17:21:05Z","body":"I wouldn't say we're happy, just that since we're not there yet the pragmatic thing is to give ourselves a bit of control over the current situation.\r\n\r\nI don't think we should go down this percentage route though - if I know my image cache is thrashing I don't want to have to up the global limit and then adjust all the percentages to make sure the extra memory goes to just images. Bear in mind though that if you want to do it that way at IE, you have all the control you need to do that via the API - it's just a config file which actually presents the final user-visible view of the limits."}}