{"action":"created","comment":{"url":"https://api.github.com/repos/xerial/msgpack-java/pulls/comments/33643529","id":33643529,"diff_hunk":"@@ -118,12 +120,11 @@ public String toString()\n         return decodedStringCache;\n     }\n \n-    private StringBuilder toJson(StringBuilder sb)\n+    static void appendJsonString(StringBuilder sb, String string)","path":"msgpack-core/src/main/java/org/msgpack/value/impl/AbstractImmutableRawValue.java","position":16,"original_position":16,"commit_id":"31d2fe8f12f21cb53a07308164270c3f76eaa5a3","original_commit_id":"31d2fe8f12f21cb53a07308164270c3f76eaa5a3","user":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"body":"Good. This name is less confusing :)","created_at":"2015-07-01T02:21:26Z","updated_at":"2015-07-01T02:21:26Z","html_url":"https://github.com/xerial/msgpack-java/pull/2#discussion_r33643529","pull_request_url":"https://api.github.com/repos/xerial/msgpack-java/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/xerial/msgpack-java/pulls/comments/33643529"},"html":{"href":"https://github.com/xerial/msgpack-java/pull/2#discussion_r33643529"},"pull_request":{"href":"https://api.github.com/repos/xerial/msgpack-java/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/xerial/msgpack-java/pulls/2","id":38942143,"html_url":"https://github.com/xerial/msgpack-java/pull/2","diff_url":"https://github.com/xerial/msgpack-java/pull/2.diff","patch_url":"https://github.com/xerial/msgpack-java/pull/2.patch","issue_url":"https://api.github.com/repos/xerial/msgpack-java/issues/2","number":2,"state":"open","locked":false,"title":"Fix Value#toJson","user":{"login":"frsyuki","id":40720,"avatar_url":"https://avatars.githubusercontent.com/u/40720?v=3","gravatar_id":"","url":"https://api.github.com/users/frsyuki","html_url":"https://github.com/frsyuki","followers_url":"https://api.github.com/users/frsyuki/followers","following_url":"https://api.github.com/users/frsyuki/following{/other_user}","gists_url":"https://api.github.com/users/frsyuki/gists{/gist_id}","starred_url":"https://api.github.com/users/frsyuki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frsyuki/subscriptions","organizations_url":"https://api.github.com/users/frsyuki/orgs","repos_url":"https://api.github.com/users/frsyuki/repos","events_url":"https://api.github.com/users/frsyuki/events{/privacy}","received_events_url":"https://api.github.com/users/frsyuki/received_events","type":"User","site_admin":false},"body":"Value#toJson() is expected to return a valid json since its name. Some\r\nvalid MessagePack values are invalid in JSON such as ExtensionValue,\r\nnon-string keys in a MapValue, NaN or Infinite.","created_at":"2015-07-01T02:00:49Z","updated_at":"2015-07-01T02:21:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c93604fddbad44a9f04d278edebc1a6177c1ffd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xerial/msgpack-java/pulls/2/commits","review_comments_url":"https://api.github.com/repos/xerial/msgpack-java/pulls/2/comments","review_comment_url":"https://api.github.com/repos/xerial/msgpack-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xerial/msgpack-java/issues/2/comments","statuses_url":"https://api.github.com/repos/xerial/msgpack-java/statuses/31d2fe8f12f21cb53a07308164270c3f76eaa5a3","head":{"label":"msgpack:fix-to-json","ref":"fix-to-json","sha":"31d2fe8f12f21cb53a07308164270c3f76eaa5a3","user":{"login":"msgpack","id":198264,"avatar_url":"https://avatars.githubusercontent.com/u/198264?v=3","gravatar_id":"","url":"https://api.github.com/users/msgpack","html_url":"https://github.com/msgpack","followers_url":"https://api.github.com/users/msgpack/followers","following_url":"https://api.github.com/users/msgpack/following{/other_user}","gists_url":"https://api.github.com/users/msgpack/gists{/gist_id}","starred_url":"https://api.github.com/users/msgpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgpack/subscriptions","organizations_url":"https://api.github.com/users/msgpack/orgs","repos_url":"https://api.github.com/users/msgpack/repos","events_url":"https://api.github.com/users/msgpack/events{/privacy}","received_events_url":"https://api.github.com/users/msgpack/received_events","type":"Organization","site_admin":false},"repo":{"id":1971346,"name":"msgpack-java","full_name":"msgpack/msgpack-java","owner":{"login":"msgpack","id":198264,"avatar_url":"https://avatars.githubusercontent.com/u/198264?v=3","gravatar_id":"","url":"https://api.github.com/users/msgpack","html_url":"https://github.com/msgpack","followers_url":"https://api.github.com/users/msgpack/followers","following_url":"https://api.github.com/users/msgpack/following{/other_user}","gists_url":"https://api.github.com/users/msgpack/gists{/gist_id}","starred_url":"https://api.github.com/users/msgpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/msgpack/subscriptions","organizations_url":"https://api.github.com/users/msgpack/orgs","repos_url":"https://api.github.com/users/msgpack/repos","events_url":"https://api.github.com/users/msgpack/events{/privacy}","received_events_url":"https://api.github.com/users/msgpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/msgpack/msgpack-java","description":"MessagePack serializer implementation for Java / msgpack.org[Java]","fork":false,"url":"https://api.github.com/repos/msgpack/msgpack-java","forks_url":"https://api.github.com/repos/msgpack/msgpack-java/forks","keys_url":"https://api.github.com/repos/msgpack/msgpack-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/msgpack/msgpack-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/msgpack/msgpack-java/teams","hooks_url":"https://api.github.com/repos/msgpack/msgpack-java/hooks","issue_events_url":"https://api.github.com/repos/msgpack/msgpack-java/issues/events{/number}","events_url":"https://api.github.com/repos/msgpack/msgpack-java/events","assignees_url":"https://api.github.com/repos/msgpack/msgpack-java/assignees{/user}","branches_url":"https://api.github.com/repos/msgpack/msgpack-java/branches{/branch}","tags_url":"https://api.github.com/repos/msgpack/msgpack-java/tags","blobs_url":"https://api.github.com/repos/msgpack/msgpack-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/msgpack/msgpack-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/msgpack/msgpack-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/msgpack/msgpack-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/msgpack/msgpack-java/statuses/{sha}","languages_url":"https://api.github.com/repos/msgpack/msgpack-java/languages","stargazers_url":"https://api.github.com/repos/msgpack/msgpack-java/stargazers","contributors_url":"https://api.github.com/repos/msgpack/msgpack-java/contributors","subscribers_url":"https://api.github.com/repos/msgpack/msgpack-java/subscribers","subscription_url":"https://api.github.com/repos/msgpack/msgpack-java/subscription","commits_url":"https://api.github.com/repos/msgpack/msgpack-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/msgpack/msgpack-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/msgpack/msgpack-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/msgpack/msgpack-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/msgpack/msgpack-java/contents/{+path}","compare_url":"https://api.github.com/repos/msgpack/msgpack-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/msgpack/msgpack-java/merges","archive_url":"https://api.github.com/repos/msgpack/msgpack-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/msgpack/msgpack-java/downloads","issues_url":"https://api.github.com/repos/msgpack/msgpack-java/issues{/number}","pulls_url":"https://api.github.com/repos/msgpack/msgpack-java/pulls{/number}","milestones_url":"https://api.github.com/repos/msgpack/msgpack-java/milestones{/number}","notifications_url":"https://api.github.com/repos/msgpack/msgpack-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/msgpack/msgpack-java/labels{/name}","releases_url":"https://api.github.com/repos/msgpack/msgpack-java/releases{/id}","created_at":"2011-06-29T08:45:39Z","updated_at":"2015-06-30T11:00:38Z","pushed_at":"2015-07-01T01:59:00Z","git_url":"git://github.com/msgpack/msgpack-java.git","ssh_url":"git@github.com:msgpack/msgpack-java.git","clone_url":"https://github.com/msgpack/msgpack-java.git","svn_url":"https://github.com/msgpack/msgpack-java","homepage":"http://msgpack.org/","size":6281,"stargazers_count":448,"watchers_count":448,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":122,"mirror_url":null,"open_issues_count":23,"forks":122,"open_issues":23,"watchers":448,"default_branch":"v07-develop"}},"base":{"label":"xerial:rename-dataaccess","ref":"rename-dataaccess","sha":"b18aecfbe9d1eb206d259429f74862d408aecf59","user":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"repo":{"id":13735214,"name":"msgpack-java","full_name":"xerial/msgpack-java","owner":{"login":"xerial","id":57538,"avatar_url":"https://avatars.githubusercontent.com/u/57538?v=3","gravatar_id":"","url":"https://api.github.com/users/xerial","html_url":"https://github.com/xerial","followers_url":"https://api.github.com/users/xerial/followers","following_url":"https://api.github.com/users/xerial/following{/other_user}","gists_url":"https://api.github.com/users/xerial/gists{/gist_id}","starred_url":"https://api.github.com/users/xerial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xerial/subscriptions","organizations_url":"https://api.github.com/users/xerial/orgs","repos_url":"https://api.github.com/users/xerial/repos","events_url":"https://api.github.com/users/xerial/events{/privacy}","received_events_url":"https://api.github.com/users/xerial/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xerial/msgpack-java","description":"MessagePack serializer implementation for Java / msgpack.org[Java]","fork":true,"url":"https://api.github.com/repos/xerial/msgpack-java","forks_url":"https://api.github.com/repos/xerial/msgpack-java/forks","keys_url":"https://api.github.com/repos/xerial/msgpack-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xerial/msgpack-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xerial/msgpack-java/teams","hooks_url":"https://api.github.com/repos/xerial/msgpack-java/hooks","issue_events_url":"https://api.github.com/repos/xerial/msgpack-java/issues/events{/number}","events_url":"https://api.github.com/repos/xerial/msgpack-java/events","assignees_url":"https://api.github.com/repos/xerial/msgpack-java/assignees{/user}","branches_url":"https://api.github.com/repos/xerial/msgpack-java/branches{/branch}","tags_url":"https://api.github.com/repos/xerial/msgpack-java/tags","blobs_url":"https://api.github.com/repos/xerial/msgpack-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xerial/msgpack-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xerial/msgpack-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/xerial/msgpack-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xerial/msgpack-java/statuses/{sha}","languages_url":"https://api.github.com/repos/xerial/msgpack-java/languages","stargazers_url":"https://api.github.com/repos/xerial/msgpack-java/stargazers","contributors_url":"https://api.github.com/repos/xerial/msgpack-java/contributors","subscribers_url":"https://api.github.com/repos/xerial/msgpack-java/subscribers","subscription_url":"https://api.github.com/repos/xerial/msgpack-java/subscription","commits_url":"https://api.github.com/repos/xerial/msgpack-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/xerial/msgpack-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/xerial/msgpack-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/xerial/msgpack-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/xerial/msgpack-java/contents/{+path}","compare_url":"https://api.github.com/repos/xerial/msgpack-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xerial/msgpack-java/merges","archive_url":"https://api.github.com/repos/xerial/msgpack-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xerial/msgpack-java/downloads","issues_url":"https://api.github.com/repos/xerial/msgpack-java/issues{/number}","pulls_url":"https://api.github.com/repos/xerial/msgpack-java/pulls{/number}","milestones_url":"https://api.github.com/repos/xerial/msgpack-java/milestones{/number}","notifications_url":"https://api.github.com/repos/xerial/msgpack-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xerial/msgpack-java/labels{/name}","releases_url":"https://api.github.com/repos/xerial/msgpack-java/releases{/id}","created_at":"2013-10-21T07:07:25Z","updated_at":"2015-02-10T16:22:12Z","pushed_at":"2015-07-01T02:00:51Z","git_url":"git://github.com/xerial/msgpack-java.git","ssh_url":"git@github.com:xerial/msgpack-java.git","clone_url":"https://github.com/xerial/msgpack-java.git","svn_url":"https://github.com/xerial/msgpack-java","homepage":"http://msgpack.org/","size":4151,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"v07-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/xerial/msgpack-java/pulls/2"},"html":{"href":"https://github.com/xerial/msgpack-java/pull/2"},"issue":{"href":"https://api.github.com/repos/xerial/msgpack-java/issues/2"},"comments":{"href":"https://api.github.com/repos/xerial/msgpack-java/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/xerial/msgpack-java/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/xerial/msgpack-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xerial/msgpack-java/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/xerial/msgpack-java/statuses/31d2fe8f12f21cb53a07308164270c3f76eaa5a3"}}}}