{"action":"created","comment":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/comments/44601070","id":44601070,"diff_hunk":"@@ -255,3 +272,20 @@ def get_all_launch_server_data(\n         'lb_nodes': list(concat([clb, rcv3]))\n     })\n     return eff\n+\n+\n+def get_all_launch_stack_data(\n+        tenant_id,\n+        group_id,\n+        now,\n+        get_scaling_group_stacks=get_scaling_group_stacks):\n+    \"\"\"\n+    Gather all launch_stack data relevant for convergence w.r.t given time\n+\n+    Returns an Effect of ([HeatStack], None) to match\n+    get_all_launch_server_data.\n+    \"\"\"\n+    eff = (get_scaling_group_stacks(tenant_id, group_id, now)\n+           .on(map(HeatStack.from_stack_details_json)).on(list)\n+           .on(lambda stacks: {'stacks': stacks}))","path":"otter/convergence/gathering.py","position":58,"original_position":58,"commit_id":"9eacd16dba45913c0a3ff589af6f133a164d0365","original_commit_id":"9eacd16dba45913c0a3ff589af6f133a164d0365","user":{"login":"manishtomar","id":758529,"avatar_url":"https://avatars.githubusercontent.com/u/758529?v=3","gravatar_id":"","url":"https://api.github.com/users/manishtomar","html_url":"https://github.com/manishtomar","followers_url":"https://api.github.com/users/manishtomar/followers","following_url":"https://api.github.com/users/manishtomar/following{/other_user}","gists_url":"https://api.github.com/users/manishtomar/gists{/gist_id}","starred_url":"https://api.github.com/users/manishtomar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manishtomar/subscriptions","organizations_url":"https://api.github.com/users/manishtomar/orgs","repos_url":"https://api.github.com/users/manishtomar/repos","events_url":"https://api.github.com/users/manishtomar/events{/privacy}","received_events_url":"https://api.github.com/users/manishtomar/received_events","type":"User","site_admin":false},"body":"If this returning stacks in a structured way (`HeatStack` objects) then why make it a dict?","created_at":"2015-11-11T23:11:34Z","updated_at":"2015-11-11T23:11:34Z","html_url":"https://github.com/rackerlabs/otter/pull/1774#discussion_r44601070","pull_request_url":"https://api.github.com/repos/rackerlabs/otter/pulls/1774","_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/comments/44601070"},"html":{"href":"https://github.com/rackerlabs/otter/pull/1774#discussion_r44601070"},"pull_request":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1774"}}},"pull_request":{"url":"https://api.github.com/repos/rackerlabs/otter/pulls/1774","id":49778298,"html_url":"https://github.com/rackerlabs/otter/pull/1774","diff_url":"https://github.com/rackerlabs/otter/pull/1774.diff","patch_url":"https://github.com/rackerlabs/otter/pull/1774.patch","issue_url":"https://api.github.com/repos/rackerlabs/otter/issues/1774","number":1774,"state":"open","locked":false,"title":"Add launch_stack gathering methods","user":{"login":"dragorosson","id":2906354,"avatar_url":"https://avatars.githubusercontent.com/u/2906354?v=3","gravatar_id":"","url":"https://api.github.com/users/dragorosson","html_url":"https://github.com/dragorosson","followers_url":"https://api.github.com/users/dragorosson/followers","following_url":"https://api.github.com/users/dragorosson/following{/other_user}","gists_url":"https://api.github.com/users/dragorosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dragorosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragorosson/subscriptions","organizations_url":"https://api.github.com/users/dragorosson/orgs","repos_url":"https://api.github.com/users/dragorosson/repos","events_url":"https://api.github.com/users/dragorosson/events{/privacy}","received_events_url":"https://api.github.com/users/dragorosson/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-05T03:25:28Z","updated_at":"2015-11-11T23:11:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d741a867f0c07ed1c933027baa8900277871f6a3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rackerlabs/otter/pulls/1774/commits","review_comments_url":"https://api.github.com/repos/rackerlabs/otter/pulls/1774/comments","review_comment_url":"https://api.github.com/repos/rackerlabs/otter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rackerlabs/otter/issues/1774/comments","statuses_url":"https://api.github.com/repos/rackerlabs/otter/statuses/9eacd16dba45913c0a3ff589af6f133a164d0365","head":{"label":"dragorosson:gathering_stacks","ref":"gathering_stacks","sha":"9eacd16dba45913c0a3ff589af6f133a164d0365","user":{"login":"dragorosson","id":2906354,"avatar_url":"https://avatars.githubusercontent.com/u/2906354?v=3","gravatar_id":"","url":"https://api.github.com/users/dragorosson","html_url":"https://github.com/dragorosson","followers_url":"https://api.github.com/users/dragorosson/followers","following_url":"https://api.github.com/users/dragorosson/following{/other_user}","gists_url":"https://api.github.com/users/dragorosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dragorosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragorosson/subscriptions","organizations_url":"https://api.github.com/users/dragorosson/orgs","repos_url":"https://api.github.com/users/dragorosson/repos","events_url":"https://api.github.com/users/dragorosson/events{/privacy}","received_events_url":"https://api.github.com/users/dragorosson/received_events","type":"User","site_admin":false},"repo":{"id":43506383,"name":"otter","full_name":"dragorosson/otter","owner":{"login":"dragorosson","id":2906354,"avatar_url":"https://avatars.githubusercontent.com/u/2906354?v=3","gravatar_id":"","url":"https://api.github.com/users/dragorosson","html_url":"https://github.com/dragorosson","followers_url":"https://api.github.com/users/dragorosson/followers","following_url":"https://api.github.com/users/dragorosson/following{/other_user}","gists_url":"https://api.github.com/users/dragorosson/gists{/gist_id}","starred_url":"https://api.github.com/users/dragorosson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dragorosson/subscriptions","organizations_url":"https://api.github.com/users/dragorosson/orgs","repos_url":"https://api.github.com/users/dragorosson/repos","events_url":"https://api.github.com/users/dragorosson/events{/privacy}","received_events_url":"https://api.github.com/users/dragorosson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dragorosson/otter","description":"Rackspace Auto Scale","fork":true,"url":"https://api.github.com/repos/dragorosson/otter","forks_url":"https://api.github.com/repos/dragorosson/otter/forks","keys_url":"https://api.github.com/repos/dragorosson/otter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dragorosson/otter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dragorosson/otter/teams","hooks_url":"https://api.github.com/repos/dragorosson/otter/hooks","issue_events_url":"https://api.github.com/repos/dragorosson/otter/issues/events{/number}","events_url":"https://api.github.com/repos/dragorosson/otter/events","assignees_url":"https://api.github.com/repos/dragorosson/otter/assignees{/user}","branches_url":"https://api.github.com/repos/dragorosson/otter/branches{/branch}","tags_url":"https://api.github.com/repos/dragorosson/otter/tags","blobs_url":"https://api.github.com/repos/dragorosson/otter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dragorosson/otter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dragorosson/otter/git/refs{/sha}","trees_url":"https://api.github.com/repos/dragorosson/otter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dragorosson/otter/statuses/{sha}","languages_url":"https://api.github.com/repos/dragorosson/otter/languages","stargazers_url":"https://api.github.com/repos/dragorosson/otter/stargazers","contributors_url":"https://api.github.com/repos/dragorosson/otter/contributors","subscribers_url":"https://api.github.com/repos/dragorosson/otter/subscribers","subscription_url":"https://api.github.com/repos/dragorosson/otter/subscription","commits_url":"https://api.github.com/repos/dragorosson/otter/commits{/sha}","git_commits_url":"https://api.github.com/repos/dragorosson/otter/git/commits{/sha}","comments_url":"https://api.github.com/repos/dragorosson/otter/comments{/number}","issue_comment_url":"https://api.github.com/repos/dragorosson/otter/issues/comments{/number}","contents_url":"https://api.github.com/repos/dragorosson/otter/contents/{+path}","compare_url":"https://api.github.com/repos/dragorosson/otter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dragorosson/otter/merges","archive_url":"https://api.github.com/repos/dragorosson/otter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dragorosson/otter/downloads","issues_url":"https://api.github.com/repos/dragorosson/otter/issues{/number}","pulls_url":"https://api.github.com/repos/dragorosson/otter/pulls{/number}","milestones_url":"https://api.github.com/repos/dragorosson/otter/milestones{/number}","notifications_url":"https://api.github.com/repos/dragorosson/otter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dragorosson/otter/labels{/name}","releases_url":"https://api.github.com/repos/dragorosson/otter/releases{/id}","created_at":"2015-10-01T16:05:23Z","updated_at":"2015-10-01T16:05:28Z","pushed_at":"2015-11-11T21:10:11Z","git_url":"git://github.com/dragorosson/otter.git","ssh_url":"git@github.com:dragorosson/otter.git","clone_url":"https://github.com/dragorosson/otter.git","svn_url":"https://github.com/dragorosson/otter","homepage":"http://www.rackspace.com/cloud/auto-scale/","size":27340,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rackerlabs:master","ref":"master","sha":"4ab42820cc453b9947b08adaf78a2059aeb2480a","user":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":6097139,"name":"otter","full_name":"rackerlabs/otter","owner":{"login":"rackerlabs","id":84293,"avatar_url":"https://avatars.githubusercontent.com/u/84293?v=3","gravatar_id":"","url":"https://api.github.com/users/rackerlabs","html_url":"https://github.com/rackerlabs","followers_url":"https://api.github.com/users/rackerlabs/followers","following_url":"https://api.github.com/users/rackerlabs/following{/other_user}","gists_url":"https://api.github.com/users/rackerlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/rackerlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rackerlabs/subscriptions","organizations_url":"https://api.github.com/users/rackerlabs/orgs","repos_url":"https://api.github.com/users/rackerlabs/repos","events_url":"https://api.github.com/users/rackerlabs/events{/privacy}","received_events_url":"https://api.github.com/users/rackerlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rackerlabs/otter","description":"Rackspace Auto Scale","fork":false,"url":"https://api.github.com/repos/rackerlabs/otter","forks_url":"https://api.github.com/repos/rackerlabs/otter/forks","keys_url":"https://api.github.com/repos/rackerlabs/otter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rackerlabs/otter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rackerlabs/otter/teams","hooks_url":"https://api.github.com/repos/rackerlabs/otter/hooks","issue_events_url":"https://api.github.com/repos/rackerlabs/otter/issues/events{/number}","events_url":"https://api.github.com/repos/rackerlabs/otter/events","assignees_url":"https://api.github.com/repos/rackerlabs/otter/assignees{/user}","branches_url":"https://api.github.com/repos/rackerlabs/otter/branches{/branch}","tags_url":"https://api.github.com/repos/rackerlabs/otter/tags","blobs_url":"https://api.github.com/repos/rackerlabs/otter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rackerlabs/otter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rackerlabs/otter/git/refs{/sha}","trees_url":"https://api.github.com/repos/rackerlabs/otter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rackerlabs/otter/statuses/{sha}","languages_url":"https://api.github.com/repos/rackerlabs/otter/languages","stargazers_url":"https://api.github.com/repos/rackerlabs/otter/stargazers","contributors_url":"https://api.github.com/repos/rackerlabs/otter/contributors","subscribers_url":"https://api.github.com/repos/rackerlabs/otter/subscribers","subscription_url":"https://api.github.com/repos/rackerlabs/otter/subscription","commits_url":"https://api.github.com/repos/rackerlabs/otter/commits{/sha}","git_commits_url":"https://api.github.com/repos/rackerlabs/otter/git/commits{/sha}","comments_url":"https://api.github.com/repos/rackerlabs/otter/comments{/number}","issue_comment_url":"https://api.github.com/repos/rackerlabs/otter/issues/comments{/number}","contents_url":"https://api.github.com/repos/rackerlabs/otter/contents/{+path}","compare_url":"https://api.github.com/repos/rackerlabs/otter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rackerlabs/otter/merges","archive_url":"https://api.github.com/repos/rackerlabs/otter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rackerlabs/otter/downloads","issues_url":"https://api.github.com/repos/rackerlabs/otter/issues{/number}","pulls_url":"https://api.github.com/repos/rackerlabs/otter/pulls{/number}","milestones_url":"https://api.github.com/repos/rackerlabs/otter/milestones{/number}","notifications_url":"https://api.github.com/repos/rackerlabs/otter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rackerlabs/otter/labels{/name}","releases_url":"https://api.github.com/repos/rackerlabs/otter/releases{/id}","created_at":"2012-10-05T21:35:59Z","updated_at":"2015-09-28T09:25:57Z","pushed_at":"2015-11-11T21:10:11Z","git_url":"git://github.com/rackerlabs/otter.git","ssh_url":"git@github.com:rackerlabs/otter.git","clone_url":"https://github.com/rackerlabs/otter.git","svn_url":"https://github.com/rackerlabs/otter","homepage":"http://www.rackspace.com/cloud/auto-scale/","size":46737,"stargazers_count":45,"watchers_count":45,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":102,"forks":22,"open_issues":102,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1774"},"html":{"href":"https://github.com/rackerlabs/otter/pull/1774"},"issue":{"href":"https://api.github.com/repos/rackerlabs/otter/issues/1774"},"comments":{"href":"https://api.github.com/repos/rackerlabs/otter/issues/1774/comments"},"review_comments":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1774/comments"},"review_comment":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rackerlabs/otter/pulls/1774/commits"},"statuses":{"href":"https://api.github.com/repos/rackerlabs/otter/statuses/9eacd16dba45913c0a3ff589af6f133a164d0365"}}}}