{"action":"created","issue":{"url":"https://api.github.com/repos/FLIF-hub/FLIF/issues/185","labels_url":"https://api.github.com/repos/FLIF-hub/FLIF/issues/185/labels{/name}","comments_url":"https://api.github.com/repos/FLIF-hub/FLIF/issues/185/comments","events_url":"https://api.github.com/repos/FLIF-hub/FLIF/issues/185/events","html_url":"https://github.com/FLIF-hub/FLIF/pull/185","id":119170333,"number":185,"title":"make some functions static/const as suggested by cppcheck, rework makefile to work better with clang","user":{"login":"matthiaskrgr","id":476013,"avatar_url":"https://avatars.githubusercontent.com/u/476013?v=3","gravatar_id":"","url":"https://api.github.com/users/matthiaskrgr","html_url":"https://github.com/matthiaskrgr","followers_url":"https://api.github.com/users/matthiaskrgr/followers","following_url":"https://api.github.com/users/matthiaskrgr/following{/other_user}","gists_url":"https://api.github.com/users/matthiaskrgr/gists{/gist_id}","starred_url":"https://api.github.com/users/matthiaskrgr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthiaskrgr/subscriptions","organizations_url":"https://api.github.com/users/matthiaskrgr/orgs","repos_url":"https://api.github.com/users/matthiaskrgr/repos","events_url":"https://api.github.com/users/matthiaskrgr/events{/privacy}","received_events_url":"https://api.github.com/users/matthiaskrgr/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-27T10:16:29Z","updated_at":"2015-11-27T11:14:32Z","closed_at":"2015-11-27T11:13:00Z","pull_request":{"url":"https://api.github.com/repos/FLIF-hub/FLIF/pulls/185","html_url":"https://github.com/FLIF-hub/FLIF/pull/185","diff_url":"https://github.com/FLIF-hub/FLIF/pull/185.diff","patch_url":"https://github.com/FLIF-hub/FLIF/pull/185.patch"},"body":"Some functions can be made static/const according to cppcheck, I modified all functions that did not cause the build to break and ran 'make test', but I'd still like someone to read through it and see if everything is correct.\r\n\r\nAbout the makefile, a lot of distros (ubuntu/travis-ci as well) lack LTO support on clang, thus I disabled -flto if building via 'make CXX=clang++'2\r\n\r\nI also update the gitignore and \"make clean\" to know latest binary paths (binarys are dumped into ./src since a few days)."},"comment":{"url":"https://api.github.com/repos/FLIF-hub/FLIF/issues/comments/160117363","html_url":"https://github.com/FLIF-hub/FLIF/pull/185#issuecomment-160117363","issue_url":"https://api.github.com/repos/FLIF-hub/FLIF/issues/185","id":160117363,"user":{"login":"jonsneyers","id":15010068,"avatar_url":"https://avatars.githubusercontent.com/u/15010068?v=3","gravatar_id":"","url":"https://api.github.com/users/jonsneyers","html_url":"https://github.com/jonsneyers","followers_url":"https://api.github.com/users/jonsneyers/followers","following_url":"https://api.github.com/users/jonsneyers/following{/other_user}","gists_url":"https://api.github.com/users/jonsneyers/gists{/gist_id}","starred_url":"https://api.github.com/users/jonsneyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonsneyers/subscriptions","organizations_url":"https://api.github.com/users/jonsneyers/orgs","repos_url":"https://api.github.com/users/jonsneyers/repos","events_url":"https://api.github.com/users/jonsneyers/events{/privacy}","received_events_url":"https://api.github.com/users/jonsneyers/received_events","type":"User","site_admin":false},"created_at":"2015-11-27T11:14:32Z","updated_at":"2015-11-27T11:14:32Z","body":"Thanks! Can you also add your CLA? (cf #168)"}}