{"action":"created","issue":{"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/25","labels_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/25/comments","events_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/25/events","html_url":"https://github.com/saltstack-formulas/collectd-formula/pull/25","id":62110211,"number":25,"title":"Switch to standard formula style","user":{"login":"babilen","id":117961,"avatar_url":"https://avatars.githubusercontent.com/u/117961?v=3","gravatar_id":"","url":"https://api.github.com/users/babilen","html_url":"https://github.com/babilen","followers_url":"https://api.github.com/users/babilen/followers","following_url":"https://api.github.com/users/babilen/following{/other_user}","gists_url":"https://api.github.com/users/babilen/gists{/gist_id}","starred_url":"https://api.github.com/users/babilen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babilen/subscriptions","organizations_url":"https://api.github.com/users/babilen/orgs","repos_url":"https://api.github.com/users/babilen/repos","events_url":"https://api.github.com/users/babilen/events{/privacy}","received_events_url":"https://api.github.com/users/babilen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-03-16T15:10:25Z","updated_at":"2015-03-16T16:48:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/pulls/25","html_url":"https://github.com/saltstack-formulas/collectd-formula/pull/25","diff_url":"https://github.com/saltstack-formulas/collectd-formula/pull/25.diff","patch_url":"https://github.com/saltstack-formulas/collectd-formula/pull/25.patch"},"body":"    As recently discussed on salt-formulas it is preferred to keep settings (both\r\n    distribution specific ones and defaults for pillar data) in map.jinja and rely\r\n    on deep merging. This commit switches the formula to that style and thereby\r\n    provides a single way to access *all* settings via the collect_settings\r\n    dictionary.\r\n    \r\n    Pillar backwards compatibility was mostly kept, but it was necessary to adjust\r\n    both the mysql and postgresql pillars to contain lists of dictionaries, rather\r\n    than simply defining a single db over which the previous code then \"iterated\".\r\n    \r\n    Unfortunately it was also necessary to remove some symlink settings from the\r\n    java plugin that is both unnecessary on, at least, Debian family minions and\r\n    suffered from ill-defined defaults."},"comment":{"url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/comments/81794593","html_url":"https://github.com/saltstack-formulas/collectd-formula/pull/25#issuecomment-81794593","issue_url":"https://api.github.com/repos/saltstack-formulas/collectd-formula/issues/25","id":81794593,"user":{"login":"puneetk","id":528061,"avatar_url":"https://avatars.githubusercontent.com/u/528061?v=3","gravatar_id":"","url":"https://api.github.com/users/puneetk","html_url":"https://github.com/puneetk","followers_url":"https://api.github.com/users/puneetk/followers","following_url":"https://api.github.com/users/puneetk/following{/other_user}","gists_url":"https://api.github.com/users/puneetk/gists{/gist_id}","starred_url":"https://api.github.com/users/puneetk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneetk/subscriptions","organizations_url":"https://api.github.com/users/puneetk/orgs","repos_url":"https://api.github.com/users/puneetk/repos","events_url":"https://api.github.com/users/puneetk/events{/privacy}","received_events_url":"https://api.github.com/users/puneetk/received_events","type":"User","site_admin":false},"created_at":"2015-03-16T16:48:38Z","updated_at":"2015-03-16T16:48:38Z","body":"Is there a reason we are moving all the logic to templates ? The state files have the collectd_settings variable already setup it would be much cleaner to pass it down from there to the template file than to re import in the template. \r\n\r\n````saltstack\r\n+{%- from \"collectd/map.jinja\" import collectd_settings with context %}\r\n+{%- set java_settings = collectd_settings.plugins.java %}\r\n````\r\n"}}