{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/29786086","id":29786086,"diff_hunk":"@@ -239,15 +239,18 @@ public String getName() {\n     }\n \n     /**\n-     * Set the (optional) name of the object.\n+     * Set the (optional) name of the object. Scene object names are not needed:\n+     * they are only for the application's convenience.\n      * \n-     * Scene object names are not needed: they are only for the application's\n-     * convenience.\n-     * \n-     * @param name\n-     *            Name of the object.\n+     * @param name Name of the object.\n+     * @throws IllegalArgumentException if input parameter is null or empty.\n      */\n     public void setName(String name) {\n+        if (name == null || name.trim().isEmpty()) {","path":"GVRf/Framework/src/org/gearvrf/GVRSceneObject.java","position":17,"original_position":17,"commit_id":"490e219016728a7cfea5d3630e88d4d2661d0ff7","original_commit_id":"490e219016728a7cfea5d3630e88d4d2661d0ff7","user":{"login":"JonShemitz","id":11304782,"avatar_url":"https://avatars.githubusercontent.com/u/11304782?v=3","gravatar_id":"","url":"https://api.github.com/users/JonShemitz","html_url":"https://github.com/JonShemitz","followers_url":"https://api.github.com/users/JonShemitz/followers","following_url":"https://api.github.com/users/JonShemitz/following{/other_user}","gists_url":"https://api.github.com/users/JonShemitz/gists{/gist_id}","starred_url":"https://api.github.com/users/JonShemitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonShemitz/subscriptions","organizations_url":"https://api.github.com/users/JonShemitz/orgs","repos_url":"https://api.github.com/users/JonShemitz/repos","events_url":"https://api.github.com/users/JonShemitz/events{/privacy}","received_events_url":"https://api.github.com/users/JonShemitz/received_events","type":"User","site_admin":false},"body":"> Yes, we must check the given string for white spaces by suppressing them all, either leading or trailing. The trimmed string only can be used as a valid key in the map. Unfortunately, as I pointed out previously, Preconditions.checkStringNotNullOrEmpty() is not suitable for this case, as it just check null and strlen zero. Considering usage of this setName(), performance is not a problem.\r\n\r\nWhy are we even checking `GVRSceneObject.setName()` at all? We should check for `null` if (and _only_ if) the JNI crashes on `env->GetStringUTFChars(name, 0)` when name is `null` ... but we really shouldn't care if an app wants to name a scene object `\"\"` or `\" \"` or even `\" \\t \\n \\t \"`. The name is _not_ a key; the name is just stored.","created_at":"2015-05-06T18:17:21Z","updated_at":"2015-05-06T18:17:21Z","html_url":"https://github.com/Samsung/GearVRf/pull/31#discussion_r29786086","pull_request_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/31","_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments/29786086"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/31#discussion_r29786086"},"pull_request":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/Samsung/GearVRf/pulls/31","id":34093350,"html_url":"https://github.com/Samsung/GearVRf/pull/31","diff_url":"https://github.com/Samsung/GearVRf/pull/31.diff","patch_url":"https://github.com/Samsung/GearVRf/pull/31.patch","issue_url":"https://api.github.com/repos/Samsung/GearVRf/issues/31","number":31,"state":"open","locked":false,"title":"fix for some similar issues of,","user":{"login":"jason2kim","id":11304988,"avatar_url":"https://avatars.githubusercontent.com/u/11304988?v=3","gravatar_id":"","url":"https://api.github.com/users/jason2kim","html_url":"https://github.com/jason2kim","followers_url":"https://api.github.com/users/jason2kim/followers","following_url":"https://api.github.com/users/jason2kim/following{/other_user}","gists_url":"https://api.github.com/users/jason2kim/gists{/gist_id}","starred_url":"https://api.github.com/users/jason2kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason2kim/subscriptions","organizations_url":"https://api.github.com/users/jason2kim/orgs","repos_url":"https://api.github.com/users/jason2kim/repos","events_url":"https://api.github.com/users/jason2kim/events{/privacy}","received_events_url":"https://api.github.com/users/jason2kim/received_events","type":"User","site_admin":false},"body":"GVRSceneObject::setName(String) - native crash (#30)\r\nGVRMaterial::getVec2(String) - native crash (#29)\r\nGVRCameraRig::getFloat(String) - native crash (#28)\r\n\r\nGearVRf-DCO-1.0-Signed-off-by: Jason Kim\r\n\tjason2.kim@samsung.com","created_at":"2015-04-24T23:03:26Z","updated_at":"2015-05-06T18:17:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6c0b0941c1b0fdd0eb3781448ab795e5332ef50","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/31/commits","review_comments_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/31/comments","review_comment_url":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/issues/31/comments","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/490e219016728a7cfea5d3630e88d4d2661d0ff7","head":{"label":"jason2kim:master","ref":"master","sha":"490e219016728a7cfea5d3630e88d4d2661d0ff7","user":{"login":"jason2kim","id":11304988,"avatar_url":"https://avatars.githubusercontent.com/u/11304988?v=3","gravatar_id":"","url":"https://api.github.com/users/jason2kim","html_url":"https://github.com/jason2kim","followers_url":"https://api.github.com/users/jason2kim/followers","following_url":"https://api.github.com/users/jason2kim/following{/other_user}","gists_url":"https://api.github.com/users/jason2kim/gists{/gist_id}","starred_url":"https://api.github.com/users/jason2kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason2kim/subscriptions","organizations_url":"https://api.github.com/users/jason2kim/orgs","repos_url":"https://api.github.com/users/jason2kim/repos","events_url":"https://api.github.com/users/jason2kim/events{/privacy}","received_events_url":"https://api.github.com/users/jason2kim/received_events","type":"User","site_admin":false},"repo":{"id":33557790,"name":"GearVRf","full_name":"jason2kim/GearVRf","owner":{"login":"jason2kim","id":11304988,"avatar_url":"https://avatars.githubusercontent.com/u/11304988?v=3","gravatar_id":"","url":"https://api.github.com/users/jason2kim","html_url":"https://github.com/jason2kim","followers_url":"https://api.github.com/users/jason2kim/followers","following_url":"https://api.github.com/users/jason2kim/following{/other_user}","gists_url":"https://api.github.com/users/jason2kim/gists{/gist_id}","starred_url":"https://api.github.com/users/jason2kim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason2kim/subscriptions","organizations_url":"https://api.github.com/users/jason2kim/orgs","repos_url":"https://api.github.com/users/jason2kim/repos","events_url":"https://api.github.com/users/jason2kim/events{/privacy}","received_events_url":"https://api.github.com/users/jason2kim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jason2kim/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":true,"url":"https://api.github.com/repos/jason2kim/GearVRf","forks_url":"https://api.github.com/repos/jason2kim/GearVRf/forks","keys_url":"https://api.github.com/repos/jason2kim/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason2kim/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason2kim/GearVRf/teams","hooks_url":"https://api.github.com/repos/jason2kim/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/jason2kim/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/jason2kim/GearVRf/events","assignees_url":"https://api.github.com/repos/jason2kim/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/jason2kim/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/jason2kim/GearVRf/tags","blobs_url":"https://api.github.com/repos/jason2kim/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason2kim/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason2kim/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason2kim/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason2kim/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/jason2kim/GearVRf/languages","stargazers_url":"https://api.github.com/repos/jason2kim/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/jason2kim/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/jason2kim/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/jason2kim/GearVRf/subscription","commits_url":"https://api.github.com/repos/jason2kim/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason2kim/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason2kim/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason2kim/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason2kim/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/jason2kim/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason2kim/GearVRf/merges","archive_url":"https://api.github.com/repos/jason2kim/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason2kim/GearVRf/downloads","issues_url":"https://api.github.com/repos/jason2kim/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/jason2kim/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/jason2kim/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/jason2kim/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason2kim/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/jason2kim/GearVRf/releases{/id}","created_at":"2015-04-07T17:26:17Z","updated_at":"2015-05-04T18:12:11Z","pushed_at":"2015-05-04T18:12:11Z","git_url":"git://github.com/jason2kim/GearVRf.git","ssh_url":"git@github.com:jason2kim/GearVRf.git","clone_url":"https://github.com/jason2kim/GearVRf.git","svn_url":"https://github.com/jason2kim/GearVRf","homepage":"http://www.gearvrf.org","size":194776,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"615c23f7cbde75f6156a8437a1140324b1cc5df8","user":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":32836701,"name":"GearVRf","full_name":"Samsung/GearVRf","owner":{"login":"Samsung","id":6210390,"avatar_url":"https://avatars.githubusercontent.com/u/6210390?v=3","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Samsung/GearVRf","description":"The GearVR framework(GearVRf) is an Open Source VR rendering library for application development on VR-supported Android devices. ","fork":false,"url":"https://api.github.com/repos/Samsung/GearVRf","forks_url":"https://api.github.com/repos/Samsung/GearVRf/forks","keys_url":"https://api.github.com/repos/Samsung/GearVRf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/GearVRf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/GearVRf/teams","hooks_url":"https://api.github.com/repos/Samsung/GearVRf/hooks","issue_events_url":"https://api.github.com/repos/Samsung/GearVRf/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/GearVRf/events","assignees_url":"https://api.github.com/repos/Samsung/GearVRf/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/GearVRf/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/GearVRf/tags","blobs_url":"https://api.github.com/repos/Samsung/GearVRf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/GearVRf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/GearVRf/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/GearVRf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/GearVRf/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/GearVRf/languages","stargazers_url":"https://api.github.com/repos/Samsung/GearVRf/stargazers","contributors_url":"https://api.github.com/repos/Samsung/GearVRf/contributors","subscribers_url":"https://api.github.com/repos/Samsung/GearVRf/subscribers","subscription_url":"https://api.github.com/repos/Samsung/GearVRf/subscription","commits_url":"https://api.github.com/repos/Samsung/GearVRf/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/GearVRf/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/GearVRf/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/GearVRf/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/GearVRf/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/GearVRf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/GearVRf/merges","archive_url":"https://api.github.com/repos/Samsung/GearVRf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/GearVRf/downloads","issues_url":"https://api.github.com/repos/Samsung/GearVRf/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/GearVRf/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/GearVRf/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/GearVRf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/GearVRf/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/GearVRf/releases{/id}","created_at":"2015-03-25T02:02:18Z","updated_at":"2015-05-04T11:15:55Z","pushed_at":"2015-05-06T06:35:05Z","git_url":"git://github.com/Samsung/GearVRf.git","ssh_url":"git@github.com:Samsung/GearVRf.git","clone_url":"https://github.com/Samsung/GearVRf.git","svn_url":"https://github.com/Samsung/GearVRf","homepage":"http://www.gearvrf.org","size":198589,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":13,"forks":18,"open_issues":13,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/31"},"html":{"href":"https://github.com/Samsung/GearVRf/pull/31"},"issue":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/31"},"comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/GearVRf/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/GearVRf/statuses/490e219016728a7cfea5d3630e88d4d2661d0ff7"}}}}