{"action":"created","comment":{"url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/comments/37666287","id":37666287,"diff_hunk":"@@ -682,20 +807,22 @@ bool timing_driven_route_net(int inet, int itry, float pres_fac, float max_criti\n \t\t * point.                                                                   */\r\n \r\n \t\trr_node_route_inf[inode].target_flag--; /* Connected to this SINK. */\r\n-\t\tnew_route_start_tptr = update_traceback(cheapest, inet);\r\n+\t\tt_trace* new_route_start_tptr = update_traceback(cheapest, inet);\r\n \t\trt_node_of_sink[target_pin] = update_route_tree(cheapest);\r\n \t\tfree_heap_data(cheapest);\r\n \t\tpathfinder_update_one_cost(new_route_start_tptr, 1, pres_fac);\r\n-\r\n \t\tempty_heap();\r\n+\t\t// need to gurantee ALL nodes' path costs are HUGE_POSITIVE_FLOAT at the start of routing to a sink\r\n+\t\t// do this by resetting all the path_costs that have been touched while routing to the current sink\r\n \t\treset_path_costs();\r\n-\t}\r\n-#ifdef PROFILE\r\n-\t\tif (!time_to_build_heap.empty()) time_to_build_heap[num_sinks / fanout_per_bin] += build_heap_time;\r\n-#endif\r\n+\t} // finished all sinks\r\n+\r\n \t/* For later timing analysis. */\r\n \r\n-\tupdate_net_delays_from_route_tree(net_delay, rt_node_of_sink, inet);\r\n+\tupdate_remaining_net_delays_from_route_tree(net_delay, rt_node_of_sink, remaining_targets);\r\n+\r\n+\tINCREMENTAL_REROUTING_ASSERT(rr_node[rt_root->inode].get_occ() <= rr_node[rt_root->inode].get_capacity());\r","path":"vpr/SRC/route/route_timing.c","position":509,"original_position":509,"commit_id":"bca68eab4d6598535ecacc178462f2756ad44941","original_commit_id":"bca68eab4d6598535ecacc178462f2756ad44941","user":{"login":"kmurray","id":1386492,"avatar_url":"https://avatars.githubusercontent.com/u/1386492?v=3","gravatar_id":"","url":"https://api.github.com/users/kmurray","html_url":"https://github.com/kmurray","followers_url":"https://api.github.com/users/kmurray/followers","following_url":"https://api.github.com/users/kmurray/following{/other_user}","gists_url":"https://api.github.com/users/kmurray/gists{/gist_id}","starred_url":"https://api.github.com/users/kmurray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmurray/subscriptions","organizations_url":"https://api.github.com/users/kmurray/orgs","repos_url":"https://api.github.com/users/kmurray/repos","events_url":"https://api.github.com/users/kmurray/events{/privacy}","received_events_url":"https://api.github.com/users/kmurray/received_events","type":"User","site_admin":false},"body":"Again, this is a cheap check, so could be a standard assert?","created_at":"2015-08-21T18:55:24Z","updated_at":"2015-08-21T18:55:24Z","html_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/104#discussion_r37666287","pull_request_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104","_links":{"self":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/comments/37666287"},"html":{"href":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/104#discussion_r37666287"},"pull_request":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104"}}},"pull_request":{"url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104","id":43064667,"html_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/104","diff_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/104.diff","patch_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/104.patch","issue_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/104","number":104,"state":"open","locked":false,"title":"Connection based routing","user":{"login":"LemonPi","id":5508542,"avatar_url":"https://avatars.githubusercontent.com/u/5508542?v=3","gravatar_id":"","url":"https://api.github.com/users/LemonPi","html_url":"https://github.com/LemonPi","followers_url":"https://api.github.com/users/LemonPi/followers","following_url":"https://api.github.com/users/LemonPi/following{/other_user}","gists_url":"https://api.github.com/users/LemonPi/gists{/gist_id}","starred_url":"https://api.github.com/users/LemonPi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LemonPi/subscriptions","organizations_url":"https://api.github.com/users/LemonPi/orgs","repos_url":"https://api.github.com/users/LemonPi/repos","events_url":"https://api.github.com/users/LemonPi/events{/privacy}","received_events_url":"https://api.github.com/users/LemonPi/received_events","type":"User","site_admin":false},"body":"Please leave code review comments below (keep this open until all of the PROFILE items get eventually removed when the changes have been fully tested).","created_at":"2015-08-21T18:06:25Z","updated_at":"2015-08-21T18:55:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f65e99f7c17651b931c660c224deae4f20676745","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104/commits","review_comments_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104/comments","review_comment_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/104/comments","statuses_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/statuses/bca68eab4d6598535ecacc178462f2756ad44941","head":{"label":"verilog-to-routing:connection_based_routing","ref":"connection_based_routing","sha":"bca68eab4d6598535ecacc178462f2756ad44941","user":{"login":"verilog-to-routing","id":11666515,"avatar_url":"https://avatars.githubusercontent.com/u/11666515?v=3","gravatar_id":"","url":"https://api.github.com/users/verilog-to-routing","html_url":"https://github.com/verilog-to-routing","followers_url":"https://api.github.com/users/verilog-to-routing/followers","following_url":"https://api.github.com/users/verilog-to-routing/following{/other_user}","gists_url":"https://api.github.com/users/verilog-to-routing/gists{/gist_id}","starred_url":"https://api.github.com/users/verilog-to-routing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verilog-to-routing/subscriptions","organizations_url":"https://api.github.com/users/verilog-to-routing/orgs","repos_url":"https://api.github.com/users/verilog-to-routing/repos","events_url":"https://api.github.com/users/verilog-to-routing/events{/privacy}","received_events_url":"https://api.github.com/users/verilog-to-routing/received_events","type":"Organization","site_admin":false},"repo":{"id":38118370,"name":"vtr-verilog-to-routing","full_name":"verilog-to-routing/vtr-verilog-to-routing","owner":{"login":"verilog-to-routing","id":11666515,"avatar_url":"https://avatars.githubusercontent.com/u/11666515?v=3","gravatar_id":"","url":"https://api.github.com/users/verilog-to-routing","html_url":"https://github.com/verilog-to-routing","followers_url":"https://api.github.com/users/verilog-to-routing/followers","following_url":"https://api.github.com/users/verilog-to-routing/following{/other_user}","gists_url":"https://api.github.com/users/verilog-to-routing/gists{/gist_id}","starred_url":"https://api.github.com/users/verilog-to-routing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verilog-to-routing/subscriptions","organizations_url":"https://api.github.com/users/verilog-to-routing/orgs","repos_url":"https://api.github.com/users/verilog-to-routing/repos","events_url":"https://api.github.com/users/verilog-to-routing/events{/privacy}","received_events_url":"https://api.github.com/users/verilog-to-routing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing","description":"Verilog to Routing -- Open Source CAD Flow for FPGA Research","fork":false,"url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing","forks_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/forks","keys_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/teams","hooks_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/hooks","issue_events_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/events{/number}","events_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/events","assignees_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/assignees{/user}","branches_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/branches{/branch}","tags_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/tags","blobs_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/statuses/{sha}","languages_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/languages","stargazers_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/stargazers","contributors_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/contributors","subscribers_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/subscribers","subscription_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/subscription","commits_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/contents/{+path}","compare_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/merges","archive_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/downloads","issues_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues{/number}","pulls_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls{/number}","milestones_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/milestones{/number}","notifications_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/labels{/name}","releases_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/releases{/id}","created_at":"2015-06-26T15:24:42Z","updated_at":"2015-08-05T19:14:48Z","pushed_at":"2015-08-21T18:06:25Z","git_url":"git://github.com/verilog-to-routing/vtr-verilog-to-routing.git","ssh_url":"git@github.com:verilog-to-routing/vtr-verilog-to-routing.git","clone_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing.git","svn_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing","homepage":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/wiki","size":108990,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":50,"forks":3,"open_issues":50,"watchers":3,"default_branch":"master"}},"base":{"label":"verilog-to-routing:master","ref":"master","sha":"ee939b44571e13748b9cd9f45af95a7ff62d538d","user":{"login":"verilog-to-routing","id":11666515,"avatar_url":"https://avatars.githubusercontent.com/u/11666515?v=3","gravatar_id":"","url":"https://api.github.com/users/verilog-to-routing","html_url":"https://github.com/verilog-to-routing","followers_url":"https://api.github.com/users/verilog-to-routing/followers","following_url":"https://api.github.com/users/verilog-to-routing/following{/other_user}","gists_url":"https://api.github.com/users/verilog-to-routing/gists{/gist_id}","starred_url":"https://api.github.com/users/verilog-to-routing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verilog-to-routing/subscriptions","organizations_url":"https://api.github.com/users/verilog-to-routing/orgs","repos_url":"https://api.github.com/users/verilog-to-routing/repos","events_url":"https://api.github.com/users/verilog-to-routing/events{/privacy}","received_events_url":"https://api.github.com/users/verilog-to-routing/received_events","type":"Organization","site_admin":false},"repo":{"id":38118370,"name":"vtr-verilog-to-routing","full_name":"verilog-to-routing/vtr-verilog-to-routing","owner":{"login":"verilog-to-routing","id":11666515,"avatar_url":"https://avatars.githubusercontent.com/u/11666515?v=3","gravatar_id":"","url":"https://api.github.com/users/verilog-to-routing","html_url":"https://github.com/verilog-to-routing","followers_url":"https://api.github.com/users/verilog-to-routing/followers","following_url":"https://api.github.com/users/verilog-to-routing/following{/other_user}","gists_url":"https://api.github.com/users/verilog-to-routing/gists{/gist_id}","starred_url":"https://api.github.com/users/verilog-to-routing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verilog-to-routing/subscriptions","organizations_url":"https://api.github.com/users/verilog-to-routing/orgs","repos_url":"https://api.github.com/users/verilog-to-routing/repos","events_url":"https://api.github.com/users/verilog-to-routing/events{/privacy}","received_events_url":"https://api.github.com/users/verilog-to-routing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing","description":"Verilog to Routing -- Open Source CAD Flow for FPGA Research","fork":false,"url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing","forks_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/forks","keys_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/teams","hooks_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/hooks","issue_events_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/events{/number}","events_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/events","assignees_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/assignees{/user}","branches_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/branches{/branch}","tags_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/tags","blobs_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/statuses/{sha}","languages_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/languages","stargazers_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/stargazers","contributors_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/contributors","subscribers_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/subscribers","subscription_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/subscription","commits_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/contents/{+path}","compare_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/merges","archive_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/downloads","issues_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues{/number}","pulls_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls{/number}","milestones_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/milestones{/number}","notifications_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/labels{/name}","releases_url":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/releases{/id}","created_at":"2015-06-26T15:24:42Z","updated_at":"2015-08-05T19:14:48Z","pushed_at":"2015-08-21T18:06:25Z","git_url":"git://github.com/verilog-to-routing/vtr-verilog-to-routing.git","ssh_url":"git@github.com:verilog-to-routing/vtr-verilog-to-routing.git","clone_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing.git","svn_url":"https://github.com/verilog-to-routing/vtr-verilog-to-routing","homepage":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/wiki","size":108990,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":50,"forks":3,"open_issues":50,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104"},"html":{"href":"https://github.com/verilog-to-routing/vtr-verilog-to-routing/pull/104"},"issue":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/104"},"comments":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/verilog-to-routing/vtr-verilog-to-routing/statuses/bca68eab4d6598535ecacc178462f2756ad44941"}}}}