{"push_id":875399010,"size":5,"distinct_size":5,"ref":"refs/heads/Generic-ConfigLoad","head":"2afd99859b703c4a508a60f67cca3e05f9e62dd1","before":"2b39c9e6c73da6a318038ce6b213d1cf0bec0a93","commits":[{"sha":"114513b52c29b241d886f6bf8620993863d1df24","author":{"email":"7a0b01bb4d65c1ede01c4a440adc8264067b41d6@web.de","name":"willkuer"},"message":"gsdx: Generic SetConfig/GetConfig\n\nThe default value and return value will always be the same and\nautomatically detected. No need to cast or !! in the code anymore.\n\nSpecialized functions are provided for those types that are currently\nused: int, bool and strings (std::string). Additionally there is an overloaded method\nreading const char* and returning strings instead. All other used types need to be statically\ncastable (static_cast<>) to int. In this case this translates into number types. Otherwise a\nspecialization is needed.","distinct":true,"url":"https://api.github.com/repos/willkuer/pcsx2/commits/114513b52c29b241d886f6bf8620993863d1df24"},{"sha":"f9c44188ee047420926b9f312cb7794be590610f","author":{"email":"7a0b01bb4d65c1ede01c4a440adc8264067b41d6@web.de","name":"willkuer"},"message":"gsdx: Fix warnings introduced by generic Get/SetConfig\n\nDue to implicit conversion from int to bool and vice versa some warnings were introduced\nand solved by this commit.","distinct":true,"url":"https://api.github.com/repos/willkuer/pcsx2/commits/f9c44188ee047420926b9f312cb7794be590610f"},{"sha":"96067849e737c1585b109f7a87ca79e485bd395a","author":{"email":"7a0b01bb4d65c1ede01c4a440adc8264067b41d6@web.de","name":"willkuer"},"message":"gsdx: Facultative changes of code using Get/SetConfig\n\nAs Get/Setconfig is generic there is no need to cast types to int as it is done automatically.\nThis removes the usage of !! in front of bool-reads and of double static_cast usage in enum\nclass save/load scenarios (Currently only GSRendererType).","distinct":true,"url":"https://api.github.com/repos/willkuer/pcsx2/commits/96067849e737c1585b109f7a87ca79e485bd395a"},{"sha":"ae2ccc4d4e97b5202c258350b0f78d56056fa177","author":{"email":"7a0b01bb4d65c1ede01c4a440adc8264067b41d6@web.de","name":"willkuer"},"message":"gsdx: Generic GSSetting\n\n### Old Implementation\nThe old implementation saved the current value of a GSSetting as uint in\na field called 'id'. The implementation of GSSettings suggests that\nGSSettings could be saved in a database with id as primary key. This\nwould require a translation look up from id to value but would have all\nadvantages of a database. However the interface to GSSetting was never\nimplemented like that.\n\n### New implementation\nGSSetting has a 'value' field that stores an int representative value of\nthe desired state. Additionally the constructor is 'overloaded' as\ntemplate to reduce casting in the consumer code. However all consumer\nvalues need to be castable to int.\n\nAccordingly combobox initialization was adjusted.","distinct":true,"url":"https://api.github.com/repos/willkuer/pcsx2/commits/ae2ccc4d4e97b5202c258350b0f78d56056fa177"},{"sha":"2afd99859b703c4a508a60f67cca3e05f9e62dd1","author":{"email":"7a0b01bb4d65c1ede01c4a440adc8264067b41d6@web.de","name":"willkuer"},"message":"gsdx: Facultative changes due to generic GSSetting\n\nGSSetting casts in the constructor to the desired int value.","distinct":true,"url":"https://api.github.com/repos/willkuer/pcsx2/commits/2afd99859b703c4a508a60f67cca3e05f9e62dd1"}]}