{"action":"created","issue":{"url":"https://api.github.com/repos/realm/realm-cocoa/issues/1479","labels_url":"https://api.github.com/repos/realm/realm-cocoa/issues/1479/labels{/name}","comments_url":"https://api.github.com/repos/realm/realm-cocoa/issues/1479/comments","events_url":"https://api.github.com/repos/realm/realm-cocoa/issues/1479/events","html_url":"https://github.com/realm/realm-cocoa/pull/1479","id":57098037,"number":1479,"title":"Add OS X tests for doing things with multiple processes","user":{"login":"tgoyne","id":408944,"avatar_url":"https://avatars.githubusercontent.com/u/408944?v=3","gravatar_id":"","url":"https://api.github.com/users/tgoyne","html_url":"https://github.com/tgoyne","followers_url":"https://api.github.com/users/tgoyne/followers","following_url":"https://api.github.com/users/tgoyne/following{/other_user}","gists_url":"https://api.github.com/users/tgoyne/gists{/gist_id}","starred_url":"https://api.github.com/users/tgoyne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgoyne/subscriptions","organizations_url":"https://api.github.com/users/tgoyne/orgs","repos_url":"https://api.github.com/users/tgoyne/repos","events_url":"https://api.github.com/users/tgoyne/events{/privacy}","received_events_url":"https://api.github.com/users/tgoyne/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-09T22:12:03Z","updated_at":"2015-02-10T00:22:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/realm/realm-cocoa/pulls/1479","html_url":"https://github.com/realm/realm-cocoa/pull/1479","diff_url":"https://github.com/realm/realm-cocoa/pull/1479.diff","patch_url":"https://github.com/realm/realm-cocoa/pull/1479.patch"},"body":"Will fail on CI due to not using a core build with working wait_for_change().\r\n\r\nAny suggestions for other things to test? It covers everything we test for multiple threads along with a few other things that came to mind and an attempt at a brute-force test, but it seems like there must be more that's testable.\r\n\r\n@alazier "},"comment":{"url":"https://api.github.com/repos/realm/realm-cocoa/issues/comments/73620459","html_url":"https://github.com/realm/realm-cocoa/pull/1479#issuecomment-73620459","issue_url":"https://api.github.com/repos/realm/realm-cocoa/issues/1479","id":73620459,"user":{"login":"alazier","id":250144,"avatar_url":"https://avatars.githubusercontent.com/u/250144?v=3","gravatar_id":"","url":"https://api.github.com/users/alazier","html_url":"https://github.com/alazier","followers_url":"https://api.github.com/users/alazier/followers","following_url":"https://api.github.com/users/alazier/following{/other_user}","gists_url":"https://api.github.com/users/alazier/gists{/gist_id}","starred_url":"https://api.github.com/users/alazier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alazier/subscriptions","organizations_url":"https://api.github.com/users/alazier/orgs","repos_url":"https://api.github.com/users/alazier/repos","events_url":"https://api.github.com/users/alazier/events{/privacy}","received_events_url":"https://api.github.com/users/alazier/received_events","type":"User","site_admin":false},"created_at":"2015-02-10T00:22:55Z","updated_at":"2015-02-10T00:22:55Z","body":"Overall this looks really good. Some other things to consider testing:\r\n- Contesting write-locks - have parent blocked on child so that notification is fired at beginning of parent's write transaction\r\n- Crashing child - have child crash mid-write transaction and make sure parent can still write after and child has had no effect\r\n- Dueling migrations/schema initializations - ensure our logic is sound if parent and child both try to initialize schema simultaneously. I fear we may assume that there is another thread in the same process which successfully completes this operation?"}}