{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/23439418","id":23439418,"diff_hunk":"@@ -100,23 +100,41 @@ bool CGUIDialogPVRGuideInfo::ActionCancelTimer(CFileItemPtr timer)\n     return bReturn;\n   }\n \n-  // prompt user for confirmation of timer deletion\n-  CGUIDialogYesNo* pDialog = (CGUIDialogYesNo*)g_windowManager.GetWindow(WINDOW_DIALOG_YES_NO);\n-\n-  if (pDialog)\n+  if(!timer->GetPVRTimerInfoTag()->m_bIsRepeating)","path":"xbmc/pvr/dialogs/GUIDialogPVRGuideInfo.cpp","position":8,"original_position":8,"commit_id":"7445b6139baf2984e840518278b64905d18b18e4","original_commit_id":"7445b6139baf2984e840518278b64905d18b18e4","user":{"login":"Jalle19","id":1106133,"avatar_url":"https://avatars.githubusercontent.com/u/1106133?v=3","gravatar_id":"","url":"https://api.github.com/users/Jalle19","html_url":"https://github.com/Jalle19","followers_url":"https://api.github.com/users/Jalle19/followers","following_url":"https://api.github.com/users/Jalle19/following{/other_user}","gists_url":"https://api.github.com/users/Jalle19/gists{/gist_id}","starred_url":"https://api.github.com/users/Jalle19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jalle19/subscriptions","organizations_url":"https://api.github.com/users/Jalle19/orgs","repos_url":"https://api.github.com/users/Jalle19/repos","events_url":"https://api.github.com/users/Jalle19/events{/privacy}","received_events_url":"https://api.github.com/users/Jalle19/received_events","type":"User","site_admin":false},"body":"Missing space (yeah I know)","created_at":"2015-01-23T09:31:01Z","updated_at":"2015-01-23T09:31:01Z","html_url":"https://github.com/xbmc/xbmc/pull/5208#discussion_r23439418","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5208","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/23439418"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5208#discussion_r23439418"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5208"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/5208","id":19699562,"html_url":"https://github.com/xbmc/xbmc/pull/5208","diff_url":"https://github.com/xbmc/xbmc/pull/5208.diff","patch_url":"https://github.com/xbmc/xbmc/pull/5208.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/5208","number":5208,"state":"open","locked":false,"title":"[pvr] basic series recording support","user":{"login":"Glenn-1990","id":2036512,"avatar_url":"https://avatars.githubusercontent.com/u/2036512?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenn-1990","html_url":"https://github.com/Glenn-1990","followers_url":"https://api.github.com/users/Glenn-1990/followers","following_url":"https://api.github.com/users/Glenn-1990/following{/other_user}","gists_url":"https://api.github.com/users/Glenn-1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenn-1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenn-1990/subscriptions","organizations_url":"https://api.github.com/users/Glenn-1990/orgs","repos_url":"https://api.github.com/users/Glenn-1990/repos","events_url":"https://api.github.com/users/Glenn-1990/events{/privacy}","received_events_url":"https://api.github.com/users/Glenn-1990/received_events","type":"User","site_admin":false},"body":"@Jalle19, @xhaggi\r\nI've extended the pvr api for some basic serie recording support.\r\n\r\nThis is not very well tested as no pvr client supports this yet of cource :-)\r\n(Basic testing with faked timers and logging events sended to the pvr client)\r\n\r\nSo about the implementation:\r\n1) The most common serie types are supported and the pvr client can set them through a bitflag.\r\n\r\n2) No new dialog/window added, so every skin should stay working!\r\n\r\n3) Timersettings dialog is reworked so we can use that one now for creating serie recordings.\r\nIt's a lot more flexible now, only the appropriate settings are showed to the user and the others are hided.\r\n\r\n4) When an epg based serie timer is opened with the 'timersetting' dialog, a few settings will be greyed out (read only) These are: strart time, end time, title, day, channel, they are set by the epg tag so it's not smart to let the user edit them (I guess). If a unknown type of timer is opened, everything will be read only. \r\n\r\n5) It would be nice if this dialog gets auto sized depending on the amount of items, but I've no idea how.\r\n\r\n6) Adding a recording through the epg guide will still add a normal 'once' recording like it was before.\r\nPersonally I don't want to be asked for a serie recording every time :-)\r\n\r\n7) So, adding an serie recording has to be done through the contex menu from the 'tv guide' or 'timer search' window. The user will find an \"add advanced timer\" button for this.\r\n\r\n![schermafdruk van 2014-09-17 12 09 59](https://cloud.githubusercontent.com/assets/2036512/4301779/e5da3bd8-3e52-11e4-95dd-645f0597d8a6.png)\r\n\r\n","created_at":"2014-08-13T00:47:47Z","updated_at":"2015-01-23T09:31:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83d1872142a482fb5a152693cfdd68e371afe6ec","assignee":null,"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/26","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/26/labels","id":396004,"number":26,"title":"Pending for inclusion","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":1,"state":"open","created_at":"2013-08-06T19:03:23Z","updated_at":"2015-01-21T01:15:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5208/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/5208/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/5208/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/7445b6139baf2984e840518278b64905d18b18e4","head":{"label":"Glenn-1990:series_rec","ref":"series_rec","sha":"7445b6139baf2984e840518278b64905d18b18e4","user":{"login":"Glenn-1990","id":2036512,"avatar_url":"https://avatars.githubusercontent.com/u/2036512?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenn-1990","html_url":"https://github.com/Glenn-1990","followers_url":"https://api.github.com/users/Glenn-1990/followers","following_url":"https://api.github.com/users/Glenn-1990/following{/other_user}","gists_url":"https://api.github.com/users/Glenn-1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenn-1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenn-1990/subscriptions","organizations_url":"https://api.github.com/users/Glenn-1990/orgs","repos_url":"https://api.github.com/users/Glenn-1990/repos","events_url":"https://api.github.com/users/Glenn-1990/events{/privacy}","received_events_url":"https://api.github.com/users/Glenn-1990/received_events","type":"User","site_admin":false},"repo":{"id":5708097,"name":"xbmc","full_name":"Glenn-1990/xbmc","owner":{"login":"Glenn-1990","id":2036512,"avatar_url":"https://avatars.githubusercontent.com/u/2036512?v=3","gravatar_id":"","url":"https://api.github.com/users/Glenn-1990","html_url":"https://github.com/Glenn-1990","followers_url":"https://api.github.com/users/Glenn-1990/followers","following_url":"https://api.github.com/users/Glenn-1990/following{/other_user}","gists_url":"https://api.github.com/users/Glenn-1990/gists{/gist_id}","starred_url":"https://api.github.com/users/Glenn-1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Glenn-1990/subscriptions","organizations_url":"https://api.github.com/users/Glenn-1990/orgs","repos_url":"https://api.github.com/users/Glenn-1990/repos","events_url":"https://api.github.com/users/Glenn-1990/events{/privacy}","received_events_url":"https://api.github.com/users/Glenn-1990/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Glenn-1990/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/Glenn-1990/xbmc","forks_url":"https://api.github.com/repos/Glenn-1990/xbmc/forks","keys_url":"https://api.github.com/repos/Glenn-1990/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Glenn-1990/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Glenn-1990/xbmc/teams","hooks_url":"https://api.github.com/repos/Glenn-1990/xbmc/hooks","issue_events_url":"https://api.github.com/repos/Glenn-1990/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/Glenn-1990/xbmc/events","assignees_url":"https://api.github.com/repos/Glenn-1990/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/Glenn-1990/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/Glenn-1990/xbmc/tags","blobs_url":"https://api.github.com/repos/Glenn-1990/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Glenn-1990/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Glenn-1990/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Glenn-1990/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Glenn-1990/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/Glenn-1990/xbmc/languages","stargazers_url":"https://api.github.com/repos/Glenn-1990/xbmc/stargazers","contributors_url":"https://api.github.com/repos/Glenn-1990/xbmc/contributors","subscribers_url":"https://api.github.com/repos/Glenn-1990/xbmc/subscribers","subscription_url":"https://api.github.com/repos/Glenn-1990/xbmc/subscription","commits_url":"https://api.github.com/repos/Glenn-1990/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Glenn-1990/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Glenn-1990/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Glenn-1990/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/Glenn-1990/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/Glenn-1990/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Glenn-1990/xbmc/merges","archive_url":"https://api.github.com/repos/Glenn-1990/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Glenn-1990/xbmc/downloads","issues_url":"https://api.github.com/repos/Glenn-1990/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/Glenn-1990/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/Glenn-1990/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/Glenn-1990/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Glenn-1990/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/Glenn-1990/xbmc/releases{/id}","created_at":"2012-09-06T20:27:03Z","updated_at":"2014-08-05T08:56:25Z","pushed_at":"2015-01-21T23:33:55Z","git_url":"git://github.com/Glenn-1990/xbmc.git","ssh_url":"git@github.com:Glenn-1990/xbmc.git","clone_url":"https://github.com/Glenn-1990/xbmc.git","svn_url":"https://github.com/Glenn-1990/xbmc","homepage":"http://xbmc.org","size":485332,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"c7b076578268383e861c95fd10479ddd7ca7c94e","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-01-23T08:26:10Z","pushed_at":"2015-01-23T08:26:10Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1798655,"stargazers_count":3636,"watchers_count":3636,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2612,"mirror_url":null,"open_issues_count":253,"forks":2612,"open_issues":253,"watchers":3636,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5208"},"html":{"href":"https://github.com/xbmc/xbmc/pull/5208"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5208"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/5208/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5208/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/5208/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/7445b6139baf2984e840518278b64905d18b18e4"}}}}