{"action":"created","issue":{"url":"https://api.github.com/repos/wmde/FundraisingBanners/issues/78","labels_url":"https://api.github.com/repos/wmde/FundraisingBanners/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/wmde/FundraisingBanners/issues/78/comments","events_url":"https://api.github.com/repos/wmde/FundraisingBanners/issues/78/events","html_url":"https://github.com/wmde/FundraisingBanners/pull/78","id":117635820,"number":78,"title":"Hidebanner cookie","user":{"login":"KaiNissen","id":5435996,"avatar_url":"https://avatars.githubusercontent.com/u/5435996?v=3","gravatar_id":"","url":"https://api.github.com/users/KaiNissen","html_url":"https://github.com/KaiNissen","followers_url":"https://api.github.com/users/KaiNissen/followers","following_url":"https://api.github.com/users/KaiNissen/following{/other_user}","gists_url":"https://api.github.com/users/KaiNissen/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiNissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiNissen/subscriptions","organizations_url":"https://api.github.com/users/KaiNissen/orgs","repos_url":"https://api.github.com/users/KaiNissen/repos","events_url":"https://api.github.com/users/KaiNissen/events{/privacy}","received_events_url":"https://api.github.com/users/KaiNissen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-11-18T17:18:49Z","updated_at":"2015-11-19T14:09:09Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/wmde/FundraisingBanners/pulls/78","html_url":"https://github.com/wmde/FundraisingBanners/pull/78","diff_url":"https://github.com/wmde/FundraisingBanners/pull/78.diff","patch_url":"https://github.com/wmde/FundraisingBanners/pull/78.patch"},"body":"As requested in wmde/fundraising#837, this introduces a cookie that is set when users close a banner. The cookie will be valid until the campaign ends and prevents further banners from being displayed. Using `alterImpressionData` the banner loading will not count as an impression.\r\n\r\nTo force a banner to display the cookie value has to be ignored.\r\n\r\nNote, that this PR depends on #77."},"comment":{"url":"https://api.github.com/repos/wmde/FundraisingBanners/issues/comments/158066825","html_url":"https://github.com/wmde/FundraisingBanners/pull/78#issuecomment-158066825","issue_url":"https://api.github.com/repos/wmde/FundraisingBanners/issues/78","id":158066825,"user":{"login":"KaiNissen","id":5435996,"avatar_url":"https://avatars.githubusercontent.com/u/5435996?v=3","gravatar_id":"","url":"https://api.github.com/users/KaiNissen","html_url":"https://github.com/KaiNissen","followers_url":"https://api.github.com/users/KaiNissen/followers","following_url":"https://api.github.com/users/KaiNissen/following{/other_user}","gists_url":"https://api.github.com/users/KaiNissen/gists{/gist_id}","starred_url":"https://api.github.com/users/KaiNissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KaiNissen/subscriptions","organizations_url":"https://api.github.com/users/KaiNissen/orgs","repos_url":"https://api.github.com/users/KaiNissen/repos","events_url":"https://api.github.com/users/KaiNissen/events{/privacy}","received_events_url":"https://api.github.com/users/KaiNissen/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T14:09:09Z","updated_at":"2015-11-19T14:09:09Z","body":"If we use the jquery cookie plugin, it can be handled the same way it is handled on wp.org: Check that cookie and don't count an impression if it is set."}}