{"action":"created","issue":{"url":"https://api.github.com/repos/waterlock/waterlock-local-auth/issues/32","labels_url":"https://api.github.com/repos/waterlock/waterlock-local-auth/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/waterlock/waterlock-local-auth/issues/32/comments","events_url":"https://api.github.com/repos/waterlock/waterlock-local-auth/issues/32/events","html_url":"https://github.com/waterlock/waterlock-local-auth/pull/32","id":67695239,"number":32,"title":"change Bcrypt for bcryptjs","user":{"login":"mdepecker","id":6339985,"avatar_url":"https://avatars.githubusercontent.com/u/6339985?v=3","gravatar_id":"","url":"https://api.github.com/users/mdepecker","html_url":"https://github.com/mdepecker","followers_url":"https://api.github.com/users/mdepecker/followers","following_url":"https://api.github.com/users/mdepecker/following{/other_user}","gists_url":"https://api.github.com/users/mdepecker/gists{/gist_id}","starred_url":"https://api.github.com/users/mdepecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdepecker/subscriptions","organizations_url":"https://api.github.com/users/mdepecker/orgs","repos_url":"https://api.github.com/users/mdepecker/repos","events_url":"https://api.github.com/users/mdepecker/events{/privacy}","received_events_url":"https://api.github.com/users/mdepecker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-04-10T22:22:24Z","updated_at":"2015-10-04T20:59:51Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/waterlock/waterlock-local-auth/pulls/32","html_url":"https://github.com/waterlock/waterlock-local-auth/pull/32","diff_url":"https://github.com/waterlock/waterlock-local-auth/pull/32.diff","patch_url":"https://github.com/waterlock/waterlock-local-auth/pull/32.patch"},"body":"bcryptjs is API compatible to bcrypt but 100% pure JS, which avoids issues with the node-gyp compiling, for example having the wrong python version and similar issues.\r\n\r\nBasically, it is the same thing but just JS, so no issues caused by the native stuff, which makes for better forward and backwards compatibility and an easier time when deploying. Always bet on JS™ :)"},"comment":{"url":"https://api.github.com/repos/waterlock/waterlock-local-auth/issues/comments/145387379","html_url":"https://github.com/waterlock/waterlock-local-auth/pull/32#issuecomment-145387379","issue_url":"https://api.github.com/repos/waterlock/waterlock-local-auth/issues/32","id":145387379,"user":{"login":"s-devaney","id":4226191,"avatar_url":"https://avatars.githubusercontent.com/u/4226191?v=3","gravatar_id":"","url":"https://api.github.com/users/s-devaney","html_url":"https://github.com/s-devaney","followers_url":"https://api.github.com/users/s-devaney/followers","following_url":"https://api.github.com/users/s-devaney/following{/other_user}","gists_url":"https://api.github.com/users/s-devaney/gists{/gist_id}","starred_url":"https://api.github.com/users/s-devaney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-devaney/subscriptions","organizations_url":"https://api.github.com/users/s-devaney/orgs","repos_url":"https://api.github.com/users/s-devaney/repos","events_url":"https://api.github.com/users/s-devaney/events{/privacy}","received_events_url":"https://api.github.com/users/s-devaney/received_events","type":"User","site_admin":false},"created_at":"2015-10-04T20:59:51Z","updated_at":"2015-10-04T20:59:51Z","body":"Yes. In order to get waterlock-local-auth working on Windows with current native bcrypt implementation I had to install Python (~200mb?) and Windows Visual Studio (__~4GB__) which is just ridiculous.\r\n\r\nIf bcryptjs is a performance concern my recommendation would be to use [npm credential](https://www.npmjs.com/package/credential), but that is outside of the scope of this PR."}}