{"action":"created","comment":{"url":"https://api.github.com/repos/PencilCode/pencilcode/pulls/comments/35700951","id":35700951,"diff_hunk":"@@ -3172,6 +3380,147 @@ function setupHpanelBox(box) {\n   });\n }\n \n+function curvedVertical(x1, y1, x2, y2) {\n+  var radius = Math.abs(y1 - y2);\n+  var line = [];\n+\n+  return 'M'+ x1 + \",\" + y1 + \" \" + 'A'+ radius + \",\" + radius + \" 1 0,1 \" + x2 + \",\" + y2;\n+}\n+\n+//$(window).resize(..) event\n+\n+function arrow(pane, arrows, traceEventNum, show_fade){\n+  /* note: we expect arrow_lines to be an array of key value pairs where \n+  each key is a color for the arrow, and each value is a list of location pairs\n+  to draw an arrow on.   */\n+\n+  var arrow_data = arrows[traceEventNum]; ","path":"content/src/view.js","position":298,"original_position":298,"commit_id":"b7c5b6852812dd6feccf3b0ea98466f576c73e85","original_commit_id":"b7c5b6852812dd6feccf3b0ea98466f576c73e85","user":{"login":"davidbau","id":3458792,"avatar_url":"https://avatars.githubusercontent.com/u/3458792?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbau","html_url":"https://github.com/davidbau","followers_url":"https://api.github.com/users/davidbau/followers","following_url":"https://api.github.com/users/davidbau/following{/other_user}","gists_url":"https://api.github.com/users/davidbau/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbau/subscriptions","organizations_url":"https://api.github.com/users/davidbau/orgs","repos_url":"https://api.github.com/users/davidbau/repos","events_url":"https://api.github.com/users/davidbau/events{/privacy}","received_events_url":"https://api.github.com/users/davidbau/received_events","type":"User","site_admin":false},"body":"Very neat.  Can you do me a favor and add a big comment here illustrating the meaning of each of these variables?  For example, you could give example instance values for the whole set of variables, and  then illustrate with ASCII art what is going on (e.g., with x y coordinates) for that set of instance variables.","created_at":"2015-07-28T21:05:26Z","updated_at":"2015-07-28T21:05:26Z","html_url":"https://github.com/PencilCode/pencilcode/pull/170#discussion_r35700951","pull_request_url":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170","_links":{"self":{"href":"https://api.github.com/repos/PencilCode/pencilcode/pulls/comments/35700951"},"html":{"href":"https://github.com/PencilCode/pencilcode/pull/170#discussion_r35700951"},"pull_request":{"href":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170"}}},"pull_request":{"url":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170","id":40824043,"html_url":"https://github.com/PencilCode/pencilcode/pull/170","diff_url":"https://github.com/PencilCode/pencilcode/pull/170.diff","patch_url":"https://github.com/PencilCode/pencilcode/pull/170.patch","issue_url":"https://api.github.com/repos/PencilCode/pencilcode/issues/170","number":170,"state":"open","locked":false,"title":"Slider n arrows","user":{"login":"aboss1","id":10790729,"avatar_url":"https://avatars.githubusercontent.com/u/10790729?v=3","gravatar_id":"","url":"https://api.github.com/users/aboss1","html_url":"https://github.com/aboss1","followers_url":"https://api.github.com/users/aboss1/followers","following_url":"https://api.github.com/users/aboss1/following{/other_user}","gists_url":"https://api.github.com/users/aboss1/gists{/gist_id}","starred_url":"https://api.github.com/users/aboss1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aboss1/subscriptions","organizations_url":"https://api.github.com/users/aboss1/orgs","repos_url":"https://api.github.com/users/aboss1/repos","events_url":"https://api.github.com/users/aboss1/events{/privacy}","received_events_url":"https://api.github.com/users/aboss1/received_events","type":"User","site_admin":false},"body":"Hi David,\r\n\r\nThis isn't ready to be merged, but I included both my code and Cali's code in this pr so we don't leave everything to the last minute. It's going to fail the javascript code test, but we know why. I added a separate protractor.js file as a possible solution to having messy code because of circular dependencies. If you think I should use protractor.js in debug.js and view.js, let me know. Thanks! ","created_at":"2015-07-24T23:09:56Z","updated_at":"2015-07-28T21:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5b198a471505a20e453527d05790b110ed2be3e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170/commits","review_comments_url":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170/comments","review_comment_url":"https://api.github.com/repos/PencilCode/pencilcode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PencilCode/pencilcode/issues/170/comments","statuses_url":"https://api.github.com/repos/PencilCode/pencilcode/statuses/b7c5b6852812dd6feccf3b0ea98466f576c73e85","head":{"label":"davidbau:slider_n_arrows","ref":"slider_n_arrows","sha":"b7c5b6852812dd6feccf3b0ea98466f576c73e85","user":{"login":"davidbau","id":3458792,"avatar_url":"https://avatars.githubusercontent.com/u/3458792?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbau","html_url":"https://github.com/davidbau","followers_url":"https://api.github.com/users/davidbau/followers","following_url":"https://api.github.com/users/davidbau/following{/other_user}","gists_url":"https://api.github.com/users/davidbau/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbau/subscriptions","organizations_url":"https://api.github.com/users/davidbau/orgs","repos_url":"https://api.github.com/users/davidbau/repos","events_url":"https://api.github.com/users/davidbau/events{/privacy}","received_events_url":"https://api.github.com/users/davidbau/received_events","type":"User","site_admin":false},"repo":{"id":28933542,"name":"pencilcode","full_name":"davidbau/pencilcode","owner":{"login":"davidbau","id":3458792,"avatar_url":"https://avatars.githubusercontent.com/u/3458792?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbau","html_url":"https://github.com/davidbau","followers_url":"https://api.github.com/users/davidbau/followers","following_url":"https://api.github.com/users/davidbau/following{/other_user}","gists_url":"https://api.github.com/users/davidbau/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbau/subscriptions","organizations_url":"https://api.github.com/users/davidbau/orgs","repos_url":"https://api.github.com/users/davidbau/repos","events_url":"https://api.github.com/users/davidbau/events{/privacy}","received_events_url":"https://api.github.com/users/davidbau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidbau/pencilcode","description":"Experimental fork of pencilcode.net.","fork":true,"url":"https://api.github.com/repos/davidbau/pencilcode","forks_url":"https://api.github.com/repos/davidbau/pencilcode/forks","keys_url":"https://api.github.com/repos/davidbau/pencilcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidbau/pencilcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidbau/pencilcode/teams","hooks_url":"https://api.github.com/repos/davidbau/pencilcode/hooks","issue_events_url":"https://api.github.com/repos/davidbau/pencilcode/issues/events{/number}","events_url":"https://api.github.com/repos/davidbau/pencilcode/events","assignees_url":"https://api.github.com/repos/davidbau/pencilcode/assignees{/user}","branches_url":"https://api.github.com/repos/davidbau/pencilcode/branches{/branch}","tags_url":"https://api.github.com/repos/davidbau/pencilcode/tags","blobs_url":"https://api.github.com/repos/davidbau/pencilcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidbau/pencilcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidbau/pencilcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidbau/pencilcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidbau/pencilcode/statuses/{sha}","languages_url":"https://api.github.com/repos/davidbau/pencilcode/languages","stargazers_url":"https://api.github.com/repos/davidbau/pencilcode/stargazers","contributors_url":"https://api.github.com/repos/davidbau/pencilcode/contributors","subscribers_url":"https://api.github.com/repos/davidbau/pencilcode/subscribers","subscription_url":"https://api.github.com/repos/davidbau/pencilcode/subscription","commits_url":"https://api.github.com/repos/davidbau/pencilcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidbau/pencilcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidbau/pencilcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidbau/pencilcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidbau/pencilcode/contents/{+path}","compare_url":"https://api.github.com/repos/davidbau/pencilcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidbau/pencilcode/merges","archive_url":"https://api.github.com/repos/davidbau/pencilcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidbau/pencilcode/downloads","issues_url":"https://api.github.com/repos/davidbau/pencilcode/issues{/number}","pulls_url":"https://api.github.com/repos/davidbau/pencilcode/pulls{/number}","milestones_url":"https://api.github.com/repos/davidbau/pencilcode/milestones{/number}","notifications_url":"https://api.github.com/repos/davidbau/pencilcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidbau/pencilcode/labels{/name}","releases_url":"https://api.github.com/repos/davidbau/pencilcode/releases{/id}","created_at":"2015-01-07T20:51:46Z","updated_at":"2015-05-21T19:32:07Z","pushed_at":"2015-07-28T14:05:58Z","git_url":"git://github.com/davidbau/pencilcode.git","ssh_url":"git@github.com:davidbau/pencilcode.git","clone_url":"https://github.com/davidbau/pencilcode.git","svn_url":"https://github.com/davidbau/pencilcode","homepage":"","size":19929,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"debugger"}},"base":{"label":"PencilCode:master","ref":"master","sha":"ac30ac07c71bff6323dd41f5973c89ded95d6add","user":{"login":"PencilCode","id":6116232,"avatar_url":"https://avatars.githubusercontent.com/u/6116232?v=3","gravatar_id":"","url":"https://api.github.com/users/PencilCode","html_url":"https://github.com/PencilCode","followers_url":"https://api.github.com/users/PencilCode/followers","following_url":"https://api.github.com/users/PencilCode/following{/other_user}","gists_url":"https://api.github.com/users/PencilCode/gists{/gist_id}","starred_url":"https://api.github.com/users/PencilCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PencilCode/subscriptions","organizations_url":"https://api.github.com/users/PencilCode/orgs","repos_url":"https://api.github.com/users/PencilCode/repos","events_url":"https://api.github.com/users/PencilCode/events{/privacy}","received_events_url":"https://api.github.com/users/PencilCode/received_events","type":"Organization","site_admin":false},"repo":{"id":15417810,"name":"pencilcode","full_name":"PencilCode/pencilcode","owner":{"login":"PencilCode","id":6116232,"avatar_url":"https://avatars.githubusercontent.com/u/6116232?v=3","gravatar_id":"","url":"https://api.github.com/users/PencilCode","html_url":"https://github.com/PencilCode","followers_url":"https://api.github.com/users/PencilCode/followers","following_url":"https://api.github.com/users/PencilCode/following{/other_user}","gists_url":"https://api.github.com/users/PencilCode/gists{/gist_id}","starred_url":"https://api.github.com/users/PencilCode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PencilCode/subscriptions","organizations_url":"https://api.github.com/users/PencilCode/orgs","repos_url":"https://api.github.com/users/PencilCode/repos","events_url":"https://api.github.com/users/PencilCode/events{/privacy}","received_events_url":"https://api.github.com/users/PencilCode/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PencilCode/pencilcode","description":"An online IDE for kids: pencilcode.net.","fork":false,"url":"https://api.github.com/repos/PencilCode/pencilcode","forks_url":"https://api.github.com/repos/PencilCode/pencilcode/forks","keys_url":"https://api.github.com/repos/PencilCode/pencilcode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PencilCode/pencilcode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PencilCode/pencilcode/teams","hooks_url":"https://api.github.com/repos/PencilCode/pencilcode/hooks","issue_events_url":"https://api.github.com/repos/PencilCode/pencilcode/issues/events{/number}","events_url":"https://api.github.com/repos/PencilCode/pencilcode/events","assignees_url":"https://api.github.com/repos/PencilCode/pencilcode/assignees{/user}","branches_url":"https://api.github.com/repos/PencilCode/pencilcode/branches{/branch}","tags_url":"https://api.github.com/repos/PencilCode/pencilcode/tags","blobs_url":"https://api.github.com/repos/PencilCode/pencilcode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PencilCode/pencilcode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PencilCode/pencilcode/git/refs{/sha}","trees_url":"https://api.github.com/repos/PencilCode/pencilcode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PencilCode/pencilcode/statuses/{sha}","languages_url":"https://api.github.com/repos/PencilCode/pencilcode/languages","stargazers_url":"https://api.github.com/repos/PencilCode/pencilcode/stargazers","contributors_url":"https://api.github.com/repos/PencilCode/pencilcode/contributors","subscribers_url":"https://api.github.com/repos/PencilCode/pencilcode/subscribers","subscription_url":"https://api.github.com/repos/PencilCode/pencilcode/subscription","commits_url":"https://api.github.com/repos/PencilCode/pencilcode/commits{/sha}","git_commits_url":"https://api.github.com/repos/PencilCode/pencilcode/git/commits{/sha}","comments_url":"https://api.github.com/repos/PencilCode/pencilcode/comments{/number}","issue_comment_url":"https://api.github.com/repos/PencilCode/pencilcode/issues/comments{/number}","contents_url":"https://api.github.com/repos/PencilCode/pencilcode/contents/{+path}","compare_url":"https://api.github.com/repos/PencilCode/pencilcode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PencilCode/pencilcode/merges","archive_url":"https://api.github.com/repos/PencilCode/pencilcode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PencilCode/pencilcode/downloads","issues_url":"https://api.github.com/repos/PencilCode/pencilcode/issues{/number}","pulls_url":"https://api.github.com/repos/PencilCode/pencilcode/pulls{/number}","milestones_url":"https://api.github.com/repos/PencilCode/pencilcode/milestones{/number}","notifications_url":"https://api.github.com/repos/PencilCode/pencilcode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PencilCode/pencilcode/labels{/name}","releases_url":"https://api.github.com/repos/PencilCode/pencilcode/releases{/id}","created_at":"2013-12-24T12:08:52Z","updated_at":"2015-07-22T17:12:22Z","pushed_at":"2015-07-28T14:05:59Z","git_url":"git://github.com/PencilCode/pencilcode.git","ssh_url":"git@github.com:PencilCode/pencilcode.git","clone_url":"https://github.com/PencilCode/pencilcode.git","svn_url":"https://github.com/PencilCode/pencilcode","homepage":"http://dev.pencilcode.net/","size":25688,"stargazers_count":57,"watchers_count":57,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"open_issues_count":41,"forks":45,"open_issues":41,"watchers":57,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170"},"html":{"href":"https://github.com/PencilCode/pencilcode/pull/170"},"issue":{"href":"https://api.github.com/repos/PencilCode/pencilcode/issues/170"},"comments":{"href":"https://api.github.com/repos/PencilCode/pencilcode/issues/170/comments"},"review_comments":{"href":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170/comments"},"review_comment":{"href":"https://api.github.com/repos/PencilCode/pencilcode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PencilCode/pencilcode/pulls/170/commits"},"statuses":{"href":"https://api.github.com/repos/PencilCode/pencilcode/statuses/b7c5b6852812dd6feccf3b0ea98466f576c73e85"}}}}