{"action":"created","issue":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/1088","labels_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/1088/labels{/name}","comments_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/1088/comments","events_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/1088/events","html_url":"https://github.com/splitbrain/dokuwiki/pull/1088","id":64801892,"number":1088,"title":"Cleanup of the mail text signature.","user":{"login":"furun","id":6804905,"avatar_url":"https://avatars.githubusercontent.com/u/6804905?v=3","gravatar_id":"","url":"https://api.github.com/users/furun","html_url":"https://github.com/furun","followers_url":"https://api.github.com/users/furun/followers","following_url":"https://api.github.com/users/furun/following{/other_user}","gists_url":"https://api.github.com/users/furun/gists{/gist_id}","starred_url":"https://api.github.com/users/furun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furun/subscriptions","organizations_url":"https://api.github.com/users/furun/orgs","repos_url":"https://api.github.com/users/furun/repos","events_url":"https://api.github.com/users/furun/events{/privacy}","received_events_url":"https://api.github.com/users/furun/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-03-27T16:45:29Z","updated_at":"2015-03-31T23:08:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/pulls/1088","html_url":"https://github.com/splitbrain/dokuwiki/pull/1088","diff_url":"https://github.com/splitbrain/dokuwiki/pull/1088.diff","patch_url":"https://github.com/splitbrain/dokuwiki/pull/1088.patch"},"body":"Done:\r\nCleanup of the mail text signature.\r\nThe signature is deleted from the txt files and moved in to lang.php\r\nMailer.class.php updated to insert the signature\r\n\r\nFix:\r\n- Cleaner text\r\n- no more \"-- \"  \"--\" \"---\" \"----\" problems.\r\n- mailwrap.html is not needed anymore an can be deleted (?)\r\n\r\nChanged files in all languages:\r\nlang.php\r\nmailtext.txt\r\npassword.txt\r\nregistermail.txt\r\nsubscr_digest.txt\r\nsubscr_list.txt\r\nsubscr_single.txt\r\nuploadmail.txt\r\npwconfirm.txt\r\nshowrev.txt\r\n\r\n(delete?):\r\nmailwrap.html"},"comment":{"url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/comments/88279133","html_url":"https://github.com/splitbrain/dokuwiki/pull/1088#issuecomment-88279133","issue_url":"https://api.github.com/repos/splitbrain/dokuwiki/issues/1088","id":88279133,"user":{"login":"furun","id":6804905,"avatar_url":"https://avatars.githubusercontent.com/u/6804905?v=3","gravatar_id":"","url":"https://api.github.com/users/furun","html_url":"https://github.com/furun","followers_url":"https://api.github.com/users/furun/followers","following_url":"https://api.github.com/users/furun/following{/other_user}","gists_url":"https://api.github.com/users/furun/gists{/gist_id}","starred_url":"https://api.github.com/users/furun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/furun/subscriptions","organizations_url":"https://api.github.com/users/furun/orgs","repos_url":"https://api.github.com/users/furun/repos","events_url":"https://api.github.com/users/furun/events{/privacy}","received_events_url":"https://api.github.com/users/furun/received_events","type":"User","site_admin":false},"created_at":"2015-03-31T23:08:34Z","updated_at":"2015-03-31T23:08:34Z","body":"yes, @EMAILSIGNATURE@ i code is better. i seen that later too, and made it but have not published it yet.\r\n\r\n\r\ni tried to change the the tester only for my check, but this here is not fix it, because the placeholders are replaced already in the dump.\r\n$mail->setBody(\"A test mail in ASCII\\n@EMAILSIGNATURE@\");\r\nbut the person which is changing the code, should not change the tester, otherwise hi maybe take out the safeguard.\r\n\r\ni take your lint test for serious, and end up searching email format problems, and turn in circles.\r\n(this is basically me last patch and i am not up to date anymore, so i could easily miss something.)\r\n(and i get on local tests on xampp more tester errors from the unpatched code, which was additionally confusing at the beginning. working on it until 3 at the morning hast not help either ;)\r\n\r\nlet me guess, you but the tester text in a lint-checker, and this failed, because it not a accurate representation of a email end result but only a placeholder text.\r\n"}}