{"action":"created","comment":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/46120910","id":46120910,"diff_hunk":"@@ -26,395 +27,217 @@ Uniform.isUniform = function ( obj ) {\n \n /** @lends Uniform.prototype */\n Uniform.prototype = {\n+\n     getName: function () {\n-        return this.name;\n+        return this._name;\n+    },\n+\n+    dirty: function () {\n+        Notify.log( 'deprecated no need anymore' );\n     },\n+\n     getType: function () {\n-        return this.type;\n+        return this._type;\n     },\n \n-    get: function () { // call dirty if you update this array outside\n-        return this.data;\n+    get: function () {\n+        Notify.log( 'deprecated use getArray instead' );\n+        return this._data;\n     },\n+\n     set: function ( array ) {\n-        this.data = array;\n-        this.dirty();\n-    },\n-    dirty: function () {\n-        this._dirty = true;\n+        Notify.log( 'deprecated use setArray instead' );\n+        this._data = array;\n     },\n+\n     apply: function ( gl, location ) {\n-        if ( this._dirty ) {\n-            this.update.call( this.glData, this.data );\n-            this._dirty = false;\n-        }\n-        this.glCall( gl, location, this.glData );\n+        if ( this._isMatrix )\n+            gl[ this._glCall ]( location, this._transpose, this._data );\n+        else\n+            gl[ this._glCall ]( location, this._data );\n     },\n-    applyMatrix: function ( gl, location ) {\n-        if ( this._dirty ) {\n-            this.update.call( this.glData, this.data );\n-            this._dirty = false;\n-        }\n-        this.glCall( gl, location, this.transpose, this.glData );\n+\n+    setArray: function ( array ) {\n+        this._data = array;\n     },\n-    update: function ( array ) {\n-        for ( var i = 0, l = array.length; i < l; ++i ) { // FF not traced maybe short\n-            this[ i ] = array[ i ];\n-        }\n+\n+    getArray: function () {\n+        return this._data;\n     },\n \n-    _updateArray: function ( array ) {\n-        for ( var i = 0, l = array.length; i < l; ++i ) { // FF not traced maybe short\n-            this[ i ] = array[ i ];\n-        }\n+    setFloat1: function ( f ) {\n+        this._data[ 0 ] = f[ 0 ];\n     },\n \n-    _updateFloat1: function ( f ) {\n-        this[ 0 ] = f[ 0 ];\n+    setFloat: function ( f ) {\n+        this._data[ 0 ] = f;\n     },\n-    _updateFloat2: function ( f ) {\n-        this[ 0 ] = f[ 0 ];\n-        this[ 1 ] = f[ 1 ];\n+\n+    setFloat2: function ( f ) {\n+        this._data[ 0 ] = f[ 0 ];\n+        this._data[ 1 ] = f[ 1 ];\n     },\n-    _updateFloat3: function ( f ) {\n-        this[ 0 ] = f[ 0 ];\n-        this[ 1 ] = f[ 1 ];\n-        this[ 2 ] = f[ 2 ];\n+\n+    setFloat3: function ( f ) {\n+        this._data[ 0 ] = f[ 0 ];\n+        this._data[ 1 ] = f[ 1 ];\n+        this._data[ 2 ] = f[ 2 ];\n     },\n-    _updateFloat4: function ( f ) {\n-        this[ 0 ] = f[ 0 ];\n-        this[ 1 ] = f[ 1 ];\n-        this[ 2 ] = f[ 2 ];\n-        this[ 3 ] = f[ 3 ];\n+\n+    setFloat4: function ( f ) {\n+        this._data[ 0 ] = f[ 0 ];\n+        this._data[ 1 ] = f[ 1 ];\n+        this._data[ 2 ] = f[ 2 ];\n+        this._data[ 3 ] = f[ 3 ];\n     },\n-    _updateFloat9: function ( f ) {\n-        this[ 0 ] = f[ 0 ];\n-        this[ 1 ] = f[ 1 ];\n-        this[ 2 ] = f[ 2 ];\n-        this[ 3 ] = f[ 3 ];\n-        this[ 4 ] = f[ 4 ];\n-        this[ 5 ] = f[ 5 ];\n-        this[ 6 ] = f[ 6 ];\n-        this[ 7 ] = f[ 7 ];\n-        this[ 8 ] = f[ 8 ];\n+\n+    setFloat9: function ( f ) {\n+        this._data[ 0 ] = f[ 0 ];\n+        this._data[ 1 ] = f[ 1 ];\n+        this._data[ 2 ] = f[ 2 ];\n+        this._data[ 3 ] = f[ 3 ];\n+        this._data[ 4 ] = f[ 4 ];\n+        this._data[ 5 ] = f[ 5 ];\n+        this._data[ 6 ] = f[ 6 ];\n+        this._data[ 7 ] = f[ 7 ];\n+        this._data[ 8 ] = f[ 8 ];\n     },\n-    _updateFloat16: function ( f ) {\n-        this[ 0 ] = f[ 0 ];\n-        this[ 1 ] = f[ 1 ];\n-        this[ 2 ] = f[ 2 ];\n-        this[ 3 ] = f[ 3 ];\n-        this[ 4 ] = f[ 4 ];\n-        this[ 5 ] = f[ 5 ];\n-        this[ 6 ] = f[ 6 ];\n-        this[ 7 ] = f[ 7 ];\n-        this[ 8 ] = f[ 8 ];\n-        this[ 9 ] = f[ 9 ];\n-        this[ 10 ] = f[ 10 ];\n-        this[ 11 ] = f[ 11 ];\n-        this[ 12 ] = f[ 12 ];\n-        this[ 13 ] = f[ 13 ];\n-        this[ 14 ] = f[ 14 ];\n-        this[ 15 ] = f[ 15 ];\n+\n+    setFloat16: function ( f ) {\n+        this._data[ 0 ] = f[ 0 ];\n+        this._data[ 1 ] = f[ 1 ];\n+        this._data[ 2 ] = f[ 2 ];\n+        this._data[ 3 ] = f[ 3 ];\n+        this._data[ 4 ] = f[ 4 ];\n+        this._data[ 5 ] = f[ 5 ];\n+        this._data[ 6 ] = f[ 6 ];\n+        this._data[ 7 ] = f[ 7 ];\n+        this._data[ 8 ] = f[ 8 ];\n+        this._data[ 9 ] = f[ 9 ];\n+        this._data[ 10 ] = f[ 10 ];\n+        this._data[ 11 ] = f[ 11 ];\n+        this._data[ 12 ] = f[ 12 ];\n+        this._data[ 13 ] = f[ 13 ];\n+        this._data[ 14 ] = f[ 14 ];\n+        this._data[ 15 ] = f[ 15 ];\n     }\n };\n+Uniform.prototype.setVec2 = Uniform.prototype.setFloat2;\n+Uniform.prototype.setVec3 = Uniform.prototype.setFloat3;\n+Uniform.prototype.setVec4 = Uniform.prototype.setFloat4;\n+Uniform.prototype.setMatrix4 = Uniform.prototype.setFloat16;\n+Uniform.prototype.setMatrix3 = Uniform.prototype.setFloat9;\n \n-Uniform.createFloat1 = function ( data, uniformName ) {\n+\n+var createUniformX = function ( data, uniformName, defaultConstructor, glSignature, type, isMatrix ) {\n     var value = data;\n     var name = uniformName;\n     if ( name === undefined ) {\n         name = value;\n-        value = [ 0 ];\n+        value = defaultConstructor();\n     }\n-    var uniform = new Uniform();\n+    var uniform = new Uniform( name );\n \n-    // if we aleardy have an array because called from array version then dont generate\n-    // an array of array\n-    if ( !Array.isArray( value ) )\n+    // if argument is not an array or typed array, create one\n+    if ( !Array.isArray( value ) && value.byteLength === undefined )\n         value = [ value ];\n \n-    uniform.data = value;\n-    uniform.glCall = function ( gl, location, glData ) {\n-        gl.uniform1fv( location, glData );\n-    };\n-    uniform.glData = new MACROUTILS.Float32Array( uniform.data );\n-    uniform.update = Uniform.prototype._updateFloat1;\n-    uniform.set = function ( value ) {\n-        if ( value.length === undefined ) {\n-            this.data[ 0 ] = value;\n-        } else {\n-            this.data = value;\n-        }\n-        this.dirty();\n-    };\n-\n-    uniform.name = name;\n-    uniform.type = 'float';\n+    uniform.setArray( value );\n+    uniform._glCall = glSignature;","path":"sources/osg/Uniform.js","position":237,"original_position":237,"commit_id":"3f107ade0b9abfa780fb88855d31255478959c43","original_commit_id":"3f107ade0b9abfa780fb88855d31255478959c43","user":{"login":"Kuranes","id":128571,"avatar_url":"https://avatars.githubusercontent.com/u/128571?v=3","gravatar_id":"","url":"https://api.github.com/users/Kuranes","html_url":"https://github.com/Kuranes","followers_url":"https://api.github.com/users/Kuranes/followers","following_url":"https://api.github.com/users/Kuranes/following{/other_user}","gists_url":"https://api.github.com/users/Kuranes/gists{/gist_id}","starred_url":"https://api.github.com/users/Kuranes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kuranes/subscriptions","organizations_url":"https://api.github.com/users/Kuranes/orgs","repos_url":"https://api.github.com/users/Kuranes/repos","events_url":"https://api.github.com/users/Kuranes/events{/privacy}","received_events_url":"https://api.github.com/users/Kuranes/received_events","type":"User","site_admin":false},"body":"not sure but couldn't we store the function pointer instead ?\r\n```\r\nuniform._glCall = gl[glSignature].bind(gl);\r\n```\r\nSo that we do avoid a hash search each call of the gl.uniform\r\n(as said, not sure if any interest)","created_at":"2015-11-30T09:20:15Z","updated_at":"2015-11-30T09:20:15Z","html_url":"https://github.com/cedricpinson/osgjs/pull/498#discussion_r46120910","pull_request_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498","_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments/46120910"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/498#discussion_r46120910"},"pull_request":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498"}}},"pull_request":{"url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498","id":51073428,"html_url":"https://github.com/cedricpinson/osgjs/pull/498","diff_url":"https://github.com/cedricpinson/osgjs/pull/498.diff","patch_url":"https://github.com/cedricpinson/osgjs/pull/498.patch","issue_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/498","number":498,"state":"open","locked":false,"title":"Clean dirty usage","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-18T11:38:14Z","updated_at":"2015-11-30T09:20:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"50b4272f20904b4a4c0875114eaed2ebb116ff6e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498/commits","review_comments_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498/comments","review_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/498/comments","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/3f107ade0b9abfa780fb88855d31255478959c43","head":{"label":"cedricpinson:clean-dirty-usage","ref":"clean-dirty-usage","sha":"3f107ade0b9abfa780fb88855d31255478959c43","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2015-11-23T08:30:54Z","pushed_at":"2015-11-29T14:53:06Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":227573,"stargazers_count":257,"watchers_count":257,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":17,"forks":62,"open_issues":17,"watchers":257,"default_branch":"develop"}},"base":{"label":"cedricpinson:develop","ref":"develop","sha":"d129ddec86cfcf9a21cc077a4db444a7eb2d0856","user":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"repo":{"id":1675632,"name":"osgjs","full_name":"cedricpinson/osgjs","owner":{"login":"cedricpinson","id":351686,"avatar_url":"https://avatars.githubusercontent.com/u/351686?v=3","gravatar_id":"","url":"https://api.github.com/users/cedricpinson","html_url":"https://github.com/cedricpinson","followers_url":"https://api.github.com/users/cedricpinson/followers","following_url":"https://api.github.com/users/cedricpinson/following{/other_user}","gists_url":"https://api.github.com/users/cedricpinson/gists{/gist_id}","starred_url":"https://api.github.com/users/cedricpinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cedricpinson/subscriptions","organizations_url":"https://api.github.com/users/cedricpinson/orgs","repos_url":"https://api.github.com/users/cedricpinson/repos","events_url":"https://api.github.com/users/cedricpinson/events{/privacy}","received_events_url":"https://api.github.com/users/cedricpinson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cedricpinson/osgjs","description":"Javascript Implementation of OpenSceneGraph","fork":false,"url":"https://api.github.com/repos/cedricpinson/osgjs","forks_url":"https://api.github.com/repos/cedricpinson/osgjs/forks","keys_url":"https://api.github.com/repos/cedricpinson/osgjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cedricpinson/osgjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cedricpinson/osgjs/teams","hooks_url":"https://api.github.com/repos/cedricpinson/osgjs/hooks","issue_events_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/events{/number}","events_url":"https://api.github.com/repos/cedricpinson/osgjs/events","assignees_url":"https://api.github.com/repos/cedricpinson/osgjs/assignees{/user}","branches_url":"https://api.github.com/repos/cedricpinson/osgjs/branches{/branch}","tags_url":"https://api.github.com/repos/cedricpinson/osgjs/tags","blobs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cedricpinson/osgjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cedricpinson/osgjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cedricpinson/osgjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cedricpinson/osgjs/statuses/{sha}","languages_url":"https://api.github.com/repos/cedricpinson/osgjs/languages","stargazers_url":"https://api.github.com/repos/cedricpinson/osgjs/stargazers","contributors_url":"https://api.github.com/repos/cedricpinson/osgjs/contributors","subscribers_url":"https://api.github.com/repos/cedricpinson/osgjs/subscribers","subscription_url":"https://api.github.com/repos/cedricpinson/osgjs/subscription","commits_url":"https://api.github.com/repos/cedricpinson/osgjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cedricpinson/osgjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cedricpinson/osgjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cedricpinson/osgjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cedricpinson/osgjs/contents/{+path}","compare_url":"https://api.github.com/repos/cedricpinson/osgjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cedricpinson/osgjs/merges","archive_url":"https://api.github.com/repos/cedricpinson/osgjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cedricpinson/osgjs/downloads","issues_url":"https://api.github.com/repos/cedricpinson/osgjs/issues{/number}","pulls_url":"https://api.github.com/repos/cedricpinson/osgjs/pulls{/number}","milestones_url":"https://api.github.com/repos/cedricpinson/osgjs/milestones{/number}","notifications_url":"https://api.github.com/repos/cedricpinson/osgjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cedricpinson/osgjs/labels{/name}","releases_url":"https://api.github.com/repos/cedricpinson/osgjs/releases{/id}","created_at":"2011-04-28T12:36:33Z","updated_at":"2015-11-23T08:30:54Z","pushed_at":"2015-11-29T14:53:06Z","git_url":"git://github.com/cedricpinson/osgjs.git","ssh_url":"git@github.com:cedricpinson/osgjs.git","clone_url":"https://github.com/cedricpinson/osgjs.git","svn_url":"https://github.com/cedricpinson/osgjs","homepage":"http://osgjs.org","size":227573,"stargazers_count":257,"watchers_count":257,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":62,"mirror_url":null,"open_issues_count":17,"forks":62,"open_issues":17,"watchers":257,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498"},"html":{"href":"https://github.com/cedricpinson/osgjs/pull/498"},"issue":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/498"},"comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/issues/498/comments"},"review_comments":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498/comments"},"review_comment":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cedricpinson/osgjs/pulls/498/commits"},"statuses":{"href":"https://api.github.com/repos/cedricpinson/osgjs/statuses/3f107ade0b9abfa780fb88855d31255478959c43"}}}}