{"action":"created","issue":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4174","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4174/labels{/name}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4174/comments","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4174/events","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4174","id":103118476,"number":4174,"title":"[Feature Fix] Fix search bar occludes dropdown items","user":{"login":"haoyuchen1992","id":5420789,"avatar_url":"https://avatars.githubusercontent.com/u/5420789?v=3","gravatar_id":"","url":"https://api.github.com/users/haoyuchen1992","html_url":"https://github.com/haoyuchen1992","followers_url":"https://api.github.com/users/haoyuchen1992/followers","following_url":"https://api.github.com/users/haoyuchen1992/following{/other_user}","gists_url":"https://api.github.com/users/haoyuchen1992/gists{/gist_id}","starred_url":"https://api.github.com/users/haoyuchen1992/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haoyuchen1992/subscriptions","organizations_url":"https://api.github.com/users/haoyuchen1992/orgs","repos_url":"https://api.github.com/users/haoyuchen1992/repos","events_url":"https://api.github.com/users/haoyuchen1992/events{/privacy}","received_events_url":"https://api.github.com/users/haoyuchen1992/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lyndsysimon","id":131414,"avatar_url":"https://avatars.githubusercontent.com/u/131414?v=3","gravatar_id":"","url":"https://api.github.com/users/lyndsysimon","html_url":"https://github.com/lyndsysimon","followers_url":"https://api.github.com/users/lyndsysimon/followers","following_url":"https://api.github.com/users/lyndsysimon/following{/other_user}","gists_url":"https://api.github.com/users/lyndsysimon/gists{/gist_id}","starred_url":"https://api.github.com/users/lyndsysimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyndsysimon/subscriptions","organizations_url":"https://api.github.com/users/lyndsysimon/orgs","repos_url":"https://api.github.com/users/lyndsysimon/repos","events_url":"https://api.github.com/users/lyndsysimon/events{/privacy}","received_events_url":"https://api.github.com/users/lyndsysimon/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/46","html_url":"https://github.com/CenterForOpenScience/osf.io/milestones/0.47.0","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/milestones/46/labels","id":1259756,"number":46,"title":"0.47.0","description":"","creator":{"login":"sloria","id":2379650,"avatar_url":"https://avatars.githubusercontent.com/u/2379650?v=3","gravatar_id":"","url":"https://api.github.com/users/sloria","html_url":"https://github.com/sloria","followers_url":"https://api.github.com/users/sloria/followers","following_url":"https://api.github.com/users/sloria/following{/other_user}","gists_url":"https://api.github.com/users/sloria/gists{/gist_id}","starred_url":"https://api.github.com/users/sloria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloria/subscriptions","organizations_url":"https://api.github.com/users/sloria/orgs","repos_url":"https://api.github.com/users/sloria/repos","events_url":"https://api.github.com/users/sloria/events{/privacy}","received_events_url":"https://api.github.com/users/sloria/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":36,"state":"open","created_at":"2015-08-18T02:50:36Z","updated_at":"2015-08-26T15:36:43Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2015-08-25T21:10:56Z","updated_at":"2015-08-26T17:10:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4174","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4174","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/4174.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/4174.patch"},"body":"### Purpose\r\nThis PR will have the dropdown menu not hidden. The reason is because I changed z-index to solve the issue that search bar is hidden in small screen (Issue https://github.com/CenterForOpenScience/osf.io/issues/3881) . \r\n\r\n### Change\r\nBefore Change ---- Dropdown on search page -https://osf.io/search/\r\n![old-search](https://cloud.githubusercontent.com/assets/5420789/9479410/4bc3e18c-4b4b-11e5-962e-bf44e32e5ce0.gif)\r\n\r\nAfter Change  ---- Dropdown on search page\r\n![new-search-page](https://cloud.githubusercontent.com/assets/5420789/9479431/5f3fa39a-4b4b-11e5-874d-89deea6532f2.gif)\r\n\r\n\r\nBefore Change ---- Dropdown on other pages:\r\n![old-main](https://cloud.githubusercontent.com/assets/5420789/9479377/26f7e6aa-4b4b-11e5-967c-823876dafd0b.gif)\r\n\r\nAfter Change ---- Dropdown on other pages -- For example -- -https://osf.io\r\n![new-main](https://cloud.githubusercontent.com/assets/5420789/9479437/6ab1b736-4b4b-11e5-9861-e6aa607aa369.gif)\r\n\r\n### Side Effect\r\nGenerally, Putting `!important;` is not a good practice. I am not sure put the code below is the best practice.\r\n\r\n    $('.navbar .dropdown').on('show.bs.dropdown', function () {\r\n           self.showSearch(false);\r\n           self.searchCSS('');\r\n     });\r\n"},"comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments/135110661","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4174#issuecomment-135110661","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4174","id":135110661,"user":{"login":"lyndsysimon","id":131414,"avatar_url":"https://avatars.githubusercontent.com/u/131414?v=3","gravatar_id":"","url":"https://api.github.com/users/lyndsysimon","html_url":"https://github.com/lyndsysimon","followers_url":"https://api.github.com/users/lyndsysimon/followers","following_url":"https://api.github.com/users/lyndsysimon/following{/other_user}","gists_url":"https://api.github.com/users/lyndsysimon/gists{/gist_id}","starred_url":"https://api.github.com/users/lyndsysimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyndsysimon/subscriptions","organizations_url":"https://api.github.com/users/lyndsysimon/orgs","repos_url":"https://api.github.com/users/lyndsysimon/repos","events_url":"https://api.github.com/users/lyndsysimon/events{/privacy}","received_events_url":"https://api.github.com/users/lyndsysimon/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T17:10:07Z","updated_at":"2015-08-26T17:10:07Z","body":"With the CSS as it is now, what happens if you don't hide the search dropdown on non-search pages? Does the dropdown stay in front of it like it should?"}}