{"action":"closed","number":27390,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27390","id":41176856,"html_url":"https://github.com/rust-lang/rust/pull/27390","diff_url":"https://github.com/rust-lang/rust/pull/27390.diff","patch_url":"https://github.com/rust-lang/rust/pull/27390.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27390","number":27390,"state":"closed","locked":false,"title":"Add OsStr::from_platform_bytes()","user":{"login":"remram44","id":426784,"avatar_url":"https://avatars.githubusercontent.com/u/426784?v=3","gravatar_id":"","url":"https://api.github.com/users/remram44","html_url":"https://github.com/remram44","followers_url":"https://api.github.com/users/remram44/followers","following_url":"https://api.github.com/users/remram44/following{/other_user}","gists_url":"https://api.github.com/users/remram44/gists{/gist_id}","starred_url":"https://api.github.com/users/remram44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remram44/subscriptions","organizations_url":"https://api.github.com/users/remram44/orgs","repos_url":"https://api.github.com/users/remram44/repos","events_url":"https://api.github.com/users/remram44/events{/privacy}","received_events_url":"https://api.github.com/users/remram44/received_events","type":"User","site_admin":false},"body":"Rebased #26730\r\n\r\n`OsString::from_bytes()` turns `Vec<u8>` into `OsString`.\r\n\r\nThis adds the same thing, from `&[u8]` to `&OsStr`, and renames both of them to `from_platform_bytes()` to avoid conflict with `OsStrExt::from_bytes()` already available on UNIX.\r\n\r\nI don't know if the last commit is needed (should from_bytes() just be removed without deprecation? It was never stable), let me know.","created_at":"2015-07-29T21:54:19Z","updated_at":"2015-08-11T16:15:44Z","closed_at":"2015-08-11T16:15:44Z","merged_at":null,"merge_commit_sha":"fad302348f2af621915ca93efb36a616f726c7c4","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/27390/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/27390/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27390/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/3cd5b9c14aeb3212f8736f9dd02b2939d6d6b70a","head":{"label":"remram44:osstr-from-bytes","ref":"osstr-from-bytes","sha":"3cd5b9c14aeb3212f8736f9dd02b2939d6d6b70a","user":{"login":"remram44","id":426784,"avatar_url":"https://avatars.githubusercontent.com/u/426784?v=3","gravatar_id":"","url":"https://api.github.com/users/remram44","html_url":"https://github.com/remram44","followers_url":"https://api.github.com/users/remram44/followers","following_url":"https://api.github.com/users/remram44/following{/other_user}","gists_url":"https://api.github.com/users/remram44/gists{/gist_id}","starred_url":"https://api.github.com/users/remram44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remram44/subscriptions","organizations_url":"https://api.github.com/users/remram44/orgs","repos_url":"https://api.github.com/users/remram44/repos","events_url":"https://api.github.com/users/remram44/events{/privacy}","received_events_url":"https://api.github.com/users/remram44/received_events","type":"User","site_admin":false},"repo":{"id":33463166,"name":"rust","full_name":"remram44/rust","owner":{"login":"remram44","id":426784,"avatar_url":"https://avatars.githubusercontent.com/u/426784?v=3","gravatar_id":"","url":"https://api.github.com/users/remram44","html_url":"https://github.com/remram44","followers_url":"https://api.github.com/users/remram44/followers","following_url":"https://api.github.com/users/remram44/following{/other_user}","gists_url":"https://api.github.com/users/remram44/gists{/gist_id}","starred_url":"https://api.github.com/users/remram44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remram44/subscriptions","organizations_url":"https://api.github.com/users/remram44/orgs","repos_url":"https://api.github.com/users/remram44/repos","events_url":"https://api.github.com/users/remram44/events{/privacy}","received_events_url":"https://api.github.com/users/remram44/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/remram44/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/remram44/rust","forks_url":"https://api.github.com/repos/remram44/rust/forks","keys_url":"https://api.github.com/repos/remram44/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/remram44/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/remram44/rust/teams","hooks_url":"https://api.github.com/repos/remram44/rust/hooks","issue_events_url":"https://api.github.com/repos/remram44/rust/issues/events{/number}","events_url":"https://api.github.com/repos/remram44/rust/events","assignees_url":"https://api.github.com/repos/remram44/rust/assignees{/user}","branches_url":"https://api.github.com/repos/remram44/rust/branches{/branch}","tags_url":"https://api.github.com/repos/remram44/rust/tags","blobs_url":"https://api.github.com/repos/remram44/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/remram44/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/remram44/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/remram44/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/remram44/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/remram44/rust/languages","stargazers_url":"https://api.github.com/repos/remram44/rust/stargazers","contributors_url":"https://api.github.com/repos/remram44/rust/contributors","subscribers_url":"https://api.github.com/repos/remram44/rust/subscribers","subscription_url":"https://api.github.com/repos/remram44/rust/subscription","commits_url":"https://api.github.com/repos/remram44/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/remram44/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/remram44/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/remram44/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/remram44/rust/contents/{+path}","compare_url":"https://api.github.com/repos/remram44/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/remram44/rust/merges","archive_url":"https://api.github.com/repos/remram44/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/remram44/rust/downloads","issues_url":"https://api.github.com/repos/remram44/rust/issues{/number}","pulls_url":"https://api.github.com/repos/remram44/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/remram44/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/remram44/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/remram44/rust/labels{/name}","releases_url":"https://api.github.com/repos/remram44/rust/releases{/id}","created_at":"2015-04-06T02:27:38Z","updated_at":"2015-04-06T02:28:04Z","pushed_at":"2015-07-31T15:34:32Z","git_url":"git://github.com/remram44/rust.git","ssh_url":"git@github.com:remram44/rust.git","clone_url":"https://github.com/remram44/rust.git","svn_url":"https://github.com/remram44/rust","homepage":"http://www.rust-lang.org","size":307502,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"osstr-from-bytes"}},"base":{"label":"rust-lang:master","ref":"master","sha":"759726276733a6c63fcb9d5b0ca75128736f8539","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-08-11T14:53:37Z","pushed_at":"2015-08-11T15:42:10Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":657567,"stargazers_count":12939,"watchers_count":12939,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2508,"mirror_url":null,"open_issues_count":2163,"forks":2508,"open_issues":2163,"watchers":12939,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27390"},"html":{"href":"https://github.com/rust-lang/rust/pull/27390"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27390"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27390/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27390/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27390/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/3cd5b9c14aeb3212f8736f9dd02b2939d6d6b70a"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":36,"review_comments":1,"commits":5,"additions":83,"deletions":0,"changed_files":2}}