{"action":"created","comment":{"url":"https://api.github.com/repos/shoopio/shoop/pulls/comments/38616921","id":38616921,"diff_hunk":"@@ -0,0 +1,18 @@\n+# -*- coding: utf-8 -*-\n+from __future__ import unicode_literals\n+\n+from django.db import models, migrations\n+\n+\n+class Migration(migrations.Migration):\n+\n+    dependencies = [\n+        ('simple_pricing', '0001_initial'),","path":"shoop/simple_pricing/migrations/0002_remove_simpleproductprice_includes_tax.py","position":10,"original_position":10,"commit_id":"bf525e9f62ef6ea0f6efc1827864d530a500c3d5","original_commit_id":"6b3a73d037592a5de4815dd6f1555e1421cca47c","user":{"login":"suutari-ai","id":3531281,"avatar_url":"https://avatars.githubusercontent.com/u/3531281?v=3","gravatar_id":"","url":"https://api.github.com/users/suutari-ai","html_url":"https://github.com/suutari-ai","followers_url":"https://api.github.com/users/suutari-ai/followers","following_url":"https://api.github.com/users/suutari-ai/following{/other_user}","gists_url":"https://api.github.com/users/suutari-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/suutari-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/suutari-ai/subscriptions","organizations_url":"https://api.github.com/users/suutari-ai/orgs","repos_url":"https://api.github.com/users/suutari-ai/repos","events_url":"https://api.github.com/users/suutari-ai/events{/privacy}","received_events_url":"https://api.github.com/users/suutari-ai/received_events","type":"User","site_admin":false},"body":"Good idea, but if no such data migration is created, this does not matter. The SimpleProductPrice.includes_tax was not visible in the UI so I don't think many have set it manually. Therefore we could as well use the same default value for Shop.prices_include_tax and even if that turns out to be wrong for some case, it's usually not a big deal to manually fix couple booleans from the Admin (you're not having millions of Shops in a single Shoop instance -- hopefully).","created_at":"2015-09-03T06:41:32Z","updated_at":"2015-09-03T06:41:32Z","html_url":"https://github.com/shoopio/shoop/pull/75#discussion_r38616921","pull_request_url":"https://api.github.com/repos/shoopio/shoop/pulls/75","_links":{"self":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/comments/38616921"},"html":{"href":"https://github.com/shoopio/shoop/pull/75#discussion_r38616921"},"pull_request":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/shoopio/shoop/pulls/75","id":43141740,"html_url":"https://github.com/shoopio/shoop/pull/75","diff_url":"https://github.com/shoopio/shoop/pull/75.diff","patch_url":"https://github.com/shoopio/shoop/pull/75.patch","issue_url":"https://api.github.com/repos/shoopio/shoop/issues/75","number":75,"state":"open","locked":false,"title":"Rework `SimplePricing` and pricing in general","user":{"login":"Pikkupomo","id":2863405,"avatar_url":"https://avatars.githubusercontent.com/u/2863405?v=3","gravatar_id":"","url":"https://api.github.com/users/Pikkupomo","html_url":"https://github.com/Pikkupomo","followers_url":"https://api.github.com/users/Pikkupomo/followers","following_url":"https://api.github.com/users/Pikkupomo/following{/other_user}","gists_url":"https://api.github.com/users/Pikkupomo/gists{/gist_id}","starred_url":"https://api.github.com/users/Pikkupomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pikkupomo/subscriptions","organizations_url":"https://api.github.com/users/Pikkupomo/orgs","repos_url":"https://api.github.com/users/Pikkupomo/repos","events_url":"https://api.github.com/users/Pikkupomo/events{/privacy}","received_events_url":"https://api.github.com/users/Pikkupomo/received_events","type":"User","site_admin":false},"body":"Add `PriceInfo` to simplify price handling\r\nAdd `prices_include_tax` into `Shop`\r\n\r\nThe idea behind this change is that `ShopProduct` determines the default price\r\nof the product. Templates should only use `PriceInfo` the pricing module\r\noffers thru `Product`. `SimplePricing` adds Customer Group Specific pricing on\r\ntop of that.\r\n\r\n`SimplePricing` continues to return lowest possible price for `ShopProduct`\r\n\r\nNOTE: The changes in `Product.get_base_price` will cause backwards incompability.\r\n\r\nRefs SHOOP-514","created_at":"2015-08-24T05:46:10Z","updated_at":"2015-09-03T06:41:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"988a0a0aff03a709a4eb838545389ffa625e1621","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/shoopio/shoop/pulls/75/commits","review_comments_url":"https://api.github.com/repos/shoopio/shoop/pulls/75/comments","review_comment_url":"https://api.github.com/repos/shoopio/shoop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shoopio/shoop/issues/75/comments","statuses_url":"https://api.github.com/repos/shoopio/shoop/statuses/bf525e9f62ef6ea0f6efc1827864d530a500c3d5","head":{"label":"shoopio:pricing","ref":"pricing","sha":"bf525e9f62ef6ea0f6efc1827864d530a500c3d5","user":{"login":"shoopio","id":12714852,"avatar_url":"https://avatars.githubusercontent.com/u/12714852?v=3","gravatar_id":"","url":"https://api.github.com/users/shoopio","html_url":"https://github.com/shoopio","followers_url":"https://api.github.com/users/shoopio/followers","following_url":"https://api.github.com/users/shoopio/following{/other_user}","gists_url":"https://api.github.com/users/shoopio/gists{/gist_id}","starred_url":"https://api.github.com/users/shoopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoopio/subscriptions","organizations_url":"https://api.github.com/users/shoopio/orgs","repos_url":"https://api.github.com/users/shoopio/repos","events_url":"https://api.github.com/users/shoopio/events{/privacy}","received_events_url":"https://api.github.com/users/shoopio/received_events","type":"Organization","site_admin":false},"repo":{"id":36803364,"name":"shoop","full_name":"shoopio/shoop","owner":{"login":"shoopio","id":12714852,"avatar_url":"https://avatars.githubusercontent.com/u/12714852?v=3","gravatar_id":"","url":"https://api.github.com/users/shoopio","html_url":"https://github.com/shoopio","followers_url":"https://api.github.com/users/shoopio/followers","following_url":"https://api.github.com/users/shoopio/following{/other_user}","gists_url":"https://api.github.com/users/shoopio/gists{/gist_id}","starred_url":"https://api.github.com/users/shoopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoopio/subscriptions","organizations_url":"https://api.github.com/users/shoopio/orgs","repos_url":"https://api.github.com/users/shoopio/repos","events_url":"https://api.github.com/users/shoopio/events{/privacy}","received_events_url":"https://api.github.com/users/shoopio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shoopio/shoop","description":"E-Commerce Platform","fork":false,"url":"https://api.github.com/repos/shoopio/shoop","forks_url":"https://api.github.com/repos/shoopio/shoop/forks","keys_url":"https://api.github.com/repos/shoopio/shoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoopio/shoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoopio/shoop/teams","hooks_url":"https://api.github.com/repos/shoopio/shoop/hooks","issue_events_url":"https://api.github.com/repos/shoopio/shoop/issues/events{/number}","events_url":"https://api.github.com/repos/shoopio/shoop/events","assignees_url":"https://api.github.com/repos/shoopio/shoop/assignees{/user}","branches_url":"https://api.github.com/repos/shoopio/shoop/branches{/branch}","tags_url":"https://api.github.com/repos/shoopio/shoop/tags","blobs_url":"https://api.github.com/repos/shoopio/shoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoopio/shoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoopio/shoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoopio/shoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoopio/shoop/statuses/{sha}","languages_url":"https://api.github.com/repos/shoopio/shoop/languages","stargazers_url":"https://api.github.com/repos/shoopio/shoop/stargazers","contributors_url":"https://api.github.com/repos/shoopio/shoop/contributors","subscribers_url":"https://api.github.com/repos/shoopio/shoop/subscribers","subscription_url":"https://api.github.com/repos/shoopio/shoop/subscription","commits_url":"https://api.github.com/repos/shoopio/shoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoopio/shoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoopio/shoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoopio/shoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoopio/shoop/contents/{+path}","compare_url":"https://api.github.com/repos/shoopio/shoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoopio/shoop/merges","archive_url":"https://api.github.com/repos/shoopio/shoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoopio/shoop/downloads","issues_url":"https://api.github.com/repos/shoopio/shoop/issues{/number}","pulls_url":"https://api.github.com/repos/shoopio/shoop/pulls{/number}","milestones_url":"https://api.github.com/repos/shoopio/shoop/milestones{/number}","notifications_url":"https://api.github.com/repos/shoopio/shoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoopio/shoop/labels{/name}","releases_url":"https://api.github.com/repos/shoopio/shoop/releases{/id}","created_at":"2015-06-03T12:53:21Z","updated_at":"2015-09-02T23:06:29Z","pushed_at":"2015-09-02T11:44:39Z","git_url":"git://github.com/shoopio/shoop.git","ssh_url":"git@github.com:shoopio/shoop.git","clone_url":"https://github.com/shoopio/shoop.git","svn_url":"https://github.com/shoopio/shoop","homepage":"https://shoop.io","size":4091,"stargazers_count":144,"watchers_count":144,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":10,"forks":33,"open_issues":10,"watchers":144,"default_branch":"master"}},"base":{"label":"shoopio:master","ref":"master","sha":"2c56b7eee4eb02c1dd71f6ea18ceb82ab570e4ab","user":{"login":"shoopio","id":12714852,"avatar_url":"https://avatars.githubusercontent.com/u/12714852?v=3","gravatar_id":"","url":"https://api.github.com/users/shoopio","html_url":"https://github.com/shoopio","followers_url":"https://api.github.com/users/shoopio/followers","following_url":"https://api.github.com/users/shoopio/following{/other_user}","gists_url":"https://api.github.com/users/shoopio/gists{/gist_id}","starred_url":"https://api.github.com/users/shoopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoopio/subscriptions","organizations_url":"https://api.github.com/users/shoopio/orgs","repos_url":"https://api.github.com/users/shoopio/repos","events_url":"https://api.github.com/users/shoopio/events{/privacy}","received_events_url":"https://api.github.com/users/shoopio/received_events","type":"Organization","site_admin":false},"repo":{"id":36803364,"name":"shoop","full_name":"shoopio/shoop","owner":{"login":"shoopio","id":12714852,"avatar_url":"https://avatars.githubusercontent.com/u/12714852?v=3","gravatar_id":"","url":"https://api.github.com/users/shoopio","html_url":"https://github.com/shoopio","followers_url":"https://api.github.com/users/shoopio/followers","following_url":"https://api.github.com/users/shoopio/following{/other_user}","gists_url":"https://api.github.com/users/shoopio/gists{/gist_id}","starred_url":"https://api.github.com/users/shoopio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shoopio/subscriptions","organizations_url":"https://api.github.com/users/shoopio/orgs","repos_url":"https://api.github.com/users/shoopio/repos","events_url":"https://api.github.com/users/shoopio/events{/privacy}","received_events_url":"https://api.github.com/users/shoopio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shoopio/shoop","description":"E-Commerce Platform","fork":false,"url":"https://api.github.com/repos/shoopio/shoop","forks_url":"https://api.github.com/repos/shoopio/shoop/forks","keys_url":"https://api.github.com/repos/shoopio/shoop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shoopio/shoop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shoopio/shoop/teams","hooks_url":"https://api.github.com/repos/shoopio/shoop/hooks","issue_events_url":"https://api.github.com/repos/shoopio/shoop/issues/events{/number}","events_url":"https://api.github.com/repos/shoopio/shoop/events","assignees_url":"https://api.github.com/repos/shoopio/shoop/assignees{/user}","branches_url":"https://api.github.com/repos/shoopio/shoop/branches{/branch}","tags_url":"https://api.github.com/repos/shoopio/shoop/tags","blobs_url":"https://api.github.com/repos/shoopio/shoop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shoopio/shoop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shoopio/shoop/git/refs{/sha}","trees_url":"https://api.github.com/repos/shoopio/shoop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shoopio/shoop/statuses/{sha}","languages_url":"https://api.github.com/repos/shoopio/shoop/languages","stargazers_url":"https://api.github.com/repos/shoopio/shoop/stargazers","contributors_url":"https://api.github.com/repos/shoopio/shoop/contributors","subscribers_url":"https://api.github.com/repos/shoopio/shoop/subscribers","subscription_url":"https://api.github.com/repos/shoopio/shoop/subscription","commits_url":"https://api.github.com/repos/shoopio/shoop/commits{/sha}","git_commits_url":"https://api.github.com/repos/shoopio/shoop/git/commits{/sha}","comments_url":"https://api.github.com/repos/shoopio/shoop/comments{/number}","issue_comment_url":"https://api.github.com/repos/shoopio/shoop/issues/comments{/number}","contents_url":"https://api.github.com/repos/shoopio/shoop/contents/{+path}","compare_url":"https://api.github.com/repos/shoopio/shoop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shoopio/shoop/merges","archive_url":"https://api.github.com/repos/shoopio/shoop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shoopio/shoop/downloads","issues_url":"https://api.github.com/repos/shoopio/shoop/issues{/number}","pulls_url":"https://api.github.com/repos/shoopio/shoop/pulls{/number}","milestones_url":"https://api.github.com/repos/shoopio/shoop/milestones{/number}","notifications_url":"https://api.github.com/repos/shoopio/shoop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shoopio/shoop/labels{/name}","releases_url":"https://api.github.com/repos/shoopio/shoop/releases{/id}","created_at":"2015-06-03T12:53:21Z","updated_at":"2015-09-02T23:06:29Z","pushed_at":"2015-09-02T11:44:39Z","git_url":"git://github.com/shoopio/shoop.git","ssh_url":"git@github.com:shoopio/shoop.git","clone_url":"https://github.com/shoopio/shoop.git","svn_url":"https://github.com/shoopio/shoop","homepage":"https://shoop.io","size":4091,"stargazers_count":144,"watchers_count":144,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":10,"forks":33,"open_issues":10,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/75"},"html":{"href":"https://github.com/shoopio/shoop/pull/75"},"issue":{"href":"https://api.github.com/repos/shoopio/shoop/issues/75"},"comments":{"href":"https://api.github.com/repos/shoopio/shoop/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shoopio/shoop/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/shoopio/shoop/statuses/bf525e9f62ef6ea0f6efc1827864d530a500c3d5"}}}}