{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments/44919056","id":44919056,"diff_hunk":"@@ -504,6 +504,48 @@ describe('Validator.textOutput()', function() {\n \n describe('Validator.getAddonMetaData()', function() {\n \n+  it('should init with null metadata', () => {\n+    var addonValidator = new Validator({\n+      _: ['tests/fixtures/example.xpi'],\n+    });\n+\n+    addonValidator.print = sinon.stub();\n+\n+    assert.typeOf(addonValidator.addonMetaData, 'null');\n+\n+    return addonValidator.scan()\n+      .then(() => {\n+        return addonValidator.getAddonMetaData();\n+      })\n+      .then((metadata) => {\n+        assert.isAbove(Object.keys(metadata).length, 0);\n+      });\n+  });\n+\n+  it('should cache and return cached addonMetaData', () => {\n+    var addonValidator = new Validator({\n+      _: ['tests/fixtures/example.xpi'],\n+    });\n+\n+    addonValidator.print = sinon.stub();\n+\n+    // This should only be called once: when the addonMetaData isn't populated.\n+    var architectureCall = sinon.spy(addonValidator, '_getAddonArchitecture');\n+\n+    assert.isFalse(architectureCall.called);\n+\n+    // `scan()` calls `getAddonMetaData()`, so we consider it called here.\n+    return addonValidator.scan()\n+      .then(() => {\n+        assert.isTrue(architectureCall.calledOnce);\n+        assert.typeOf(addonValidator.addonMetaData, 'object');\n+        return addonValidator.getAddonMetaData();\n+      })\n+      .then(() => {\n+        assert.isTrue(architectureCall.calledOnce);","path":"tests/test.validator.js","position":42,"original_position":42,"commit_id":"8d45564618651097a35bd94987c66cdf14802126","original_commit_id":"8d45564618651097a35bd94987c66cdf14802126","user":{"login":"tofumatt","id":90871,"avatar_url":"https://avatars.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"Thanks :smile: ","created_at":"2015-11-16T12:47:09Z","updated_at":"2015-11-16T12:47:09Z","html_url":"https://github.com/mozilla/addons-validator/pull/269#discussion_r44919056","pull_request_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/269","_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments/44919056"},"html":{"href":"https://github.com/mozilla/addons-validator/pull/269#discussion_r44919056"},"pull_request":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/269"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/addons-validator/pulls/269","id":50733046,"html_url":"https://github.com/mozilla/addons-validator/pull/269","diff_url":"https://github.com/mozilla/addons-validator/pull/269.diff","patch_url":"https://github.com/mozilla/addons-validator/pull/269.patch","issue_url":"https://api.github.com/repos/mozilla/addons-validator/issues/269","number":269,"state":"open","locked":false,"title":"Initialise addonMetaData as null (close #257)","user":{"login":"tofumatt","id":90871,"avatar_url":"https://avatars.githubusercontent.com/u/90871?v=3","gravatar_id":"","url":"https://api.github.com/users/tofumatt","html_url":"https://github.com/tofumatt","followers_url":"https://api.github.com/users/tofumatt/followers","following_url":"https://api.github.com/users/tofumatt/following{/other_user}","gists_url":"https://api.github.com/users/tofumatt/gists{/gist_id}","starred_url":"https://api.github.com/users/tofumatt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tofumatt/subscriptions","organizations_url":"https://api.github.com/users/tofumatt/orgs","repos_url":"https://api.github.com/users/tofumatt/repos","events_url":"https://api.github.com/users/tofumatt/events{/privacy}","received_events_url":"https://api.github.com/users/tofumatt/received_events","type":"User","site_admin":false},"body":"Caches `addonMetaData` object once created and only assigns it in one place.","created_at":"2015-11-14T21:47:16Z","updated_at":"2015-11-16T12:47:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e959032c6703cb62b57148e9bd3c270795a46a75","assignee":{"login":"muffinresearch","id":1514,"avatar_url":"https://avatars.githubusercontent.com/u/1514?v=3","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/269/commits","review_comments_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/269/comments","review_comment_url":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/issues/269/comments","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/8d45564618651097a35bd94987c66cdf14802126","head":{"label":"mozilla:init-addonsmetadata-as-null-257","ref":"init-addonsmetadata-as-null-257","sha":"8d45564618651097a35bd94987c66cdf14802126","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":42436885,"name":"addons-validator","full_name":"mozilla/addons-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-validator","description":"The new Firefox Add-ons validator, written in ES6/JavaScript.","fork":false,"url":"https://api.github.com/repos/mozilla/addons-validator","forks_url":"https://api.github.com/repos/mozilla/addons-validator/forks","keys_url":"https://api.github.com/repos/mozilla/addons-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-validator/events","assignees_url":"https://api.github.com/repos/mozilla/addons-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-validator/merges","archive_url":"https://api.github.com/repos/mozilla/addons-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-validator/releases{/id}","created_at":"2015-09-14T08:34:44Z","updated_at":"2015-10-24T03:57:22Z","pushed_at":"2015-11-16T12:38:30Z","git_url":"git://github.com/mozilla/addons-validator.git","ssh_url":"git@github.com:mozilla/addons-validator.git","clone_url":"https://github.com/mozilla/addons-validator.git","svn_url":"https://github.com/mozilla/addons-validator","homepage":"","size":1607,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":50,"forks":4,"open_issues":50,"watchers":6,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"1e49f68ac9ea2f79f520e2317c93fd6190345a33","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":42436885,"name":"addons-validator","full_name":"mozilla/addons-validator","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/addons-validator","description":"The new Firefox Add-ons validator, written in ES6/JavaScript.","fork":false,"url":"https://api.github.com/repos/mozilla/addons-validator","forks_url":"https://api.github.com/repos/mozilla/addons-validator/forks","keys_url":"https://api.github.com/repos/mozilla/addons-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/addons-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/addons-validator/teams","hooks_url":"https://api.github.com/repos/mozilla/addons-validator/hooks","issue_events_url":"https://api.github.com/repos/mozilla/addons-validator/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/addons-validator/events","assignees_url":"https://api.github.com/repos/mozilla/addons-validator/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/addons-validator/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/addons-validator/tags","blobs_url":"https://api.github.com/repos/mozilla/addons-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/addons-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/addons-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/addons-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/addons-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/addons-validator/languages","stargazers_url":"https://api.github.com/repos/mozilla/addons-validator/stargazers","contributors_url":"https://api.github.com/repos/mozilla/addons-validator/contributors","subscribers_url":"https://api.github.com/repos/mozilla/addons-validator/subscribers","subscription_url":"https://api.github.com/repos/mozilla/addons-validator/subscription","commits_url":"https://api.github.com/repos/mozilla/addons-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/addons-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/addons-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/addons-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/addons-validator/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/addons-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/addons-validator/merges","archive_url":"https://api.github.com/repos/mozilla/addons-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/addons-validator/downloads","issues_url":"https://api.github.com/repos/mozilla/addons-validator/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/addons-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/addons-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/addons-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/addons-validator/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/addons-validator/releases{/id}","created_at":"2015-09-14T08:34:44Z","updated_at":"2015-10-24T03:57:22Z","pushed_at":"2015-11-16T12:38:30Z","git_url":"git://github.com/mozilla/addons-validator.git","ssh_url":"git@github.com:mozilla/addons-validator.git","clone_url":"https://github.com/mozilla/addons-validator.git","svn_url":"https://github.com/mozilla/addons-validator","homepage":"","size":1607,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"open_issues_count":50,"forks":4,"open_issues":50,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/269"},"html":{"href":"https://github.com/mozilla/addons-validator/pull/269"},"issue":{"href":"https://api.github.com/repos/mozilla/addons-validator/issues/269"},"comments":{"href":"https://api.github.com/repos/mozilla/addons-validator/issues/269/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/269/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/addons-validator/pulls/269/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/addons-validator/statuses/8d45564618651097a35bd94987c66cdf14802126"}}}}