{"action":"closed","number":1236,"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/1236","id":33126389,"html_url":"https://github.com/php/php-src/pull/1236","diff_url":"https://github.com/php/php-src/pull/1236.diff","patch_url":"https://github.com/php/php-src/pull/1236.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/1236","number":1236,"state":"closed","locked":false,"title":"Remove MSIE 5-specific Cache-Control fields.","user":{"login":"simi","id":193936,"avatar_url":"https://avatars.githubusercontent.com/u/193936?v=3","gravatar_id":"","url":"https://api.github.com/users/simi","html_url":"https://github.com/simi","followers_url":"https://api.github.com/users/simi/followers","following_url":"https://api.github.com/users/simi/following{/other_user}","gists_url":"https://api.github.com/users/simi/gists{/gist_id}","starred_url":"https://api.github.com/users/simi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simi/subscriptions","organizations_url":"https://api.github.com/users/simi/orgs","repos_url":"https://api.github.com/users/simi/repos","events_url":"https://api.github.com/users/simi/events{/privacy}","received_events_url":"https://api.github.com/users/simi/received_events","type":"User","site_admin":false},"body":"As it was mentioned in https://github.com/rails/rails/pull/19556#issuecomment-92073248 by @matthewd (based on great \"research\"), it is useless to support MSIE 5 specific `pre-check` and `post-check` Cache-Control fields now.\r\n\r\nThis patch was tested via built-in web server, cURL calls and following script:\r\n\r\n```php\r\n<?php\r\nsession_cache_limiter(\"nocache\"); // \"private_no_expire\" or \"private\"\r\nsession_start();\r\n?>\r\n```\r\n\r\nAnd it works as expected.\r\n\r\nThere are no tests for `session_cache_limiter` function.\r\n[Local `make test`](https://gist.github.com/simi/df19ae81a69a74c57f5b) is not passing, but I hope it is not related to this patch since it fails with same fails without this patch.\r\n\r\nThis is revert of 04daa55.","created_at":"2015-04-12T21:00:19Z","updated_at":"2015-05-12T07:56:38Z","closed_at":"2015-05-12T07:56:38Z","merged_at":null,"merge_commit_sha":"2d2d29ccb45ef4d39961f9e310e459ec23b63ffa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/1236/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/1236/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/1236/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/e8697b6ddea14a34ba0ded4bf5d105ce149e586c","head":{"label":"zizkovrb:drop-ie5-cookie-cache-support","ref":"drop-ie5-cookie-cache-support","sha":"e8697b6ddea14a34ba0ded4bf5d105ce149e586c","user":{"login":"zizkovrb","id":6131341,"avatar_url":"https://avatars.githubusercontent.com/u/6131341?v=3","gravatar_id":"","url":"https://api.github.com/users/zizkovrb","html_url":"https://github.com/zizkovrb","followers_url":"https://api.github.com/users/zizkovrb/followers","following_url":"https://api.github.com/users/zizkovrb/following{/other_user}","gists_url":"https://api.github.com/users/zizkovrb/gists{/gist_id}","starred_url":"https://api.github.com/users/zizkovrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizkovrb/subscriptions","organizations_url":"https://api.github.com/users/zizkovrb/orgs","repos_url":"https://api.github.com/users/zizkovrb/repos","events_url":"https://api.github.com/users/zizkovrb/events{/privacy}","received_events_url":"https://api.github.com/users/zizkovrb/received_events","type":"Organization","site_admin":false},"repo":{"id":33831558,"name":"php-src","full_name":"zizkovrb/php-src","owner":{"login":"zizkovrb","id":6131341,"avatar_url":"https://avatars.githubusercontent.com/u/6131341?v=3","gravatar_id":"","url":"https://api.github.com/users/zizkovrb","html_url":"https://github.com/zizkovrb","followers_url":"https://api.github.com/users/zizkovrb/followers","following_url":"https://api.github.com/users/zizkovrb/following{/other_user}","gists_url":"https://api.github.com/users/zizkovrb/gists{/gist_id}","starred_url":"https://api.github.com/users/zizkovrb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zizkovrb/subscriptions","organizations_url":"https://api.github.com/users/zizkovrb/orgs","repos_url":"https://api.github.com/users/zizkovrb/repos","events_url":"https://api.github.com/users/zizkovrb/events{/privacy}","received_events_url":"https://api.github.com/users/zizkovrb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zizkovrb/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/zizkovrb/php-src","forks_url":"https://api.github.com/repos/zizkovrb/php-src/forks","keys_url":"https://api.github.com/repos/zizkovrb/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zizkovrb/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zizkovrb/php-src/teams","hooks_url":"https://api.github.com/repos/zizkovrb/php-src/hooks","issue_events_url":"https://api.github.com/repos/zizkovrb/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/zizkovrb/php-src/events","assignees_url":"https://api.github.com/repos/zizkovrb/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/zizkovrb/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/zizkovrb/php-src/tags","blobs_url":"https://api.github.com/repos/zizkovrb/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zizkovrb/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zizkovrb/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/zizkovrb/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zizkovrb/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/zizkovrb/php-src/languages","stargazers_url":"https://api.github.com/repos/zizkovrb/php-src/stargazers","contributors_url":"https://api.github.com/repos/zizkovrb/php-src/contributors","subscribers_url":"https://api.github.com/repos/zizkovrb/php-src/subscribers","subscription_url":"https://api.github.com/repos/zizkovrb/php-src/subscription","commits_url":"https://api.github.com/repos/zizkovrb/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/zizkovrb/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/zizkovrb/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/zizkovrb/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/zizkovrb/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/zizkovrb/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zizkovrb/php-src/merges","archive_url":"https://api.github.com/repos/zizkovrb/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zizkovrb/php-src/downloads","issues_url":"https://api.github.com/repos/zizkovrb/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/zizkovrb/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/zizkovrb/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/zizkovrb/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zizkovrb/php-src/labels{/name}","releases_url":"https://api.github.com/repos/zizkovrb/php-src/releases{/id}","created_at":"2015-04-12T19:59:13Z","updated_at":"2015-04-12T19:59:55Z","pushed_at":"2015-04-12T21:03:36Z","git_url":"git://github.com/zizkovrb/php-src.git","ssh_url":"git@github.com:zizkovrb/php-src.git","clone_url":"https://github.com/zizkovrb/php-src.git","svn_url":"https://github.com/zizkovrb/php-src","homepage":"http://www.php.net","size":227425,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"0981345734f05d65dce3b52cefa3a393995ab0ce","user":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"name":"php-src","full_name":"php/php-src","owner":{"login":"php","id":25158,"avatar_url":"https://avatars.githubusercontent.com/u/25158?v=3","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","created_at":"2011-06-16T01:52:25Z","updated_at":"2015-05-11T19:40:14Z","pushed_at":"2015-05-12T07:56:21Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":1370963,"stargazers_count":5798,"watchers_count":5798,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2105,"mirror_url":null,"open_issues_count":194,"forks":2105,"open_issues":194,"watchers":5798,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/1236"},"html":{"href":"https://github.com/php/php-src/pull/1236"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/1236"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/1236/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/1236/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/1236/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/e8697b6ddea14a34ba0ded4bf5d105ce149e586c"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":2,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}