{"action":"created","comment":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/44350192","id":44350192,"diff_hunk":"@@ -397,18 +414,60 @@ private String toStringInternal() {\n     }\n \n     private final String name;\n-    private final byte[] asciiName;\n+\n+    private final String normalName;\n+    private final byte[] normalNameBytes;\n+\n+    private static BitSet generateValidTChars() {\n+      BitSet valid  = new BitSet(0x7f);\n+      valid.set('-');\n+      valid.set('_');\n+      for (char c = '0'; c <= '9'; c++) {\n+        valid.set(c);\n+      }\n+      // Only validates after normalization, so we exclude uppercase.\n+      for (char c = 'a'; c <= 'z'; c++) {\n+        valid.set(c);\n+      }\n+      return valid;\n+    }\n+\n+    private static String validateName(String n) {\n+      checkNotNull(n);\n+      checkArgument(n.length() != 0, \"token must have at least 1 tchar\");\n+      for (int i = 0; i < n.length(); i++) {\n+        char tChar = n.charAt(i);\n+        // TODO(notcarl): remove this hack once pseudo headers are properly handled\n+        if (tChar == ':' && i == 0) {\n+          continue;\n+        }\n+\n+        checkArgument(VALID_T_CHARS.get(tChar), \"Invalid character '%s' in key name\", tChar);\n+      }\n+      return n;\n+    }\n \n     private Key(String name) {\n-      this.name = Preconditions.checkNotNull(name, \"name\").toLowerCase(Locale.ROOT).intern();\n-      this.asciiName = this.name.getBytes(US_ASCII);\n+      this.name = checkNotNull(name);\n+      this.normalName = validateName(this.name.toLowerCase(Locale.ROOT));\n+      this.normalNameBytes = this.normalName.getBytes(US_ASCII);\n     }\n \n+    /**\n+     * @return The original name used to create this key.\n+     */\n     public String name() {\n       return name;\n     }\n \n     /**\n+     * @return The normalized name for this key.\n+     */\n+    public String normalName() {","path":"core/src/main/java/io/grpc/Metadata.java","position":190,"original_position":190,"commit_id":"51874b84659b38db6c4942cb5234130c1e9a94eb","original_commit_id":"51874b84659b38db6c4942cb5234130c1e9a94eb","user":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"body":"+1 ... why not just always normalize and not even store the other name?","created_at":"2015-11-09T23:35:34Z","updated_at":"2015-11-09T23:35:34Z","html_url":"https://github.com/grpc/grpc-java/pull/1011#discussion_r44350192","pull_request_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1011","_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments/44350192"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1011#discussion_r44350192"},"pull_request":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1011"}}},"pull_request":{"url":"https://api.github.com/repos/grpc/grpc-java/pulls/1011","id":44823615,"html_url":"https://github.com/grpc/grpc-java/pull/1011","diff_url":"https://github.com/grpc/grpc-java/pull/1011.diff","patch_url":"https://github.com/grpc/grpc-java/pull/1011.patch","issue_url":"https://api.github.com/repos/grpc/grpc-java/issues/1011","number":1011,"state":"open","locked":false,"title":"Add Header name character restrictions","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"body":"In regards to #725","created_at":"2015-09-11T20:08:38Z","updated_at":"2015-11-09T23:35:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"935e4f02dea2423cef305c1d695081890aa2c1e4","assignee":{"login":"nmittler","id":6493296,"avatar_url":"https://avatars.githubusercontent.com/u/6493296?v=3","gravatar_id":"","url":"https://api.github.com/users/nmittler","html_url":"https://github.com/nmittler","followers_url":"https://api.github.com/users/nmittler/followers","following_url":"https://api.github.com/users/nmittler/following{/other_user}","gists_url":"https://api.github.com/users/nmittler/gists{/gist_id}","starred_url":"https://api.github.com/users/nmittler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmittler/subscriptions","organizations_url":"https://api.github.com/users/nmittler/orgs","repos_url":"https://api.github.com/users/nmittler/repos","events_url":"https://api.github.com/users/nmittler/events{/privacy}","received_events_url":"https://api.github.com/users/nmittler/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1011/commits","review_comments_url":"https://api.github.com/repos/grpc/grpc-java/pulls/1011/comments","review_comment_url":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grpc/grpc-java/issues/1011/comments","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/51874b84659b38db6c4942cb5234130c1e9a94eb","head":{"label":"carl-mastrangelo:headername","ref":"headername","sha":"51874b84659b38db6c4942cb5234130c1e9a94eb","user":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"repo":{"id":38781678,"name":"grpc-java","full_name":"carl-mastrangelo/grpc-java","owner":{"login":"carl-mastrangelo","id":8943572,"avatar_url":"https://avatars.githubusercontent.com/u/8943572?v=3","gravatar_id":"","url":"https://api.github.com/users/carl-mastrangelo","html_url":"https://github.com/carl-mastrangelo","followers_url":"https://api.github.com/users/carl-mastrangelo/followers","following_url":"https://api.github.com/users/carl-mastrangelo/following{/other_user}","gists_url":"https://api.github.com/users/carl-mastrangelo/gists{/gist_id}","starred_url":"https://api.github.com/users/carl-mastrangelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carl-mastrangelo/subscriptions","organizations_url":"https://api.github.com/users/carl-mastrangelo/orgs","repos_url":"https://api.github.com/users/carl-mastrangelo/repos","events_url":"https://api.github.com/users/carl-mastrangelo/events{/privacy}","received_events_url":"https://api.github.com/users/carl-mastrangelo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carl-mastrangelo/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":true,"url":"https://api.github.com/repos/carl-mastrangelo/grpc-java","forks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/forks","keys_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/teams","hooks_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/events","assignees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/tags","blobs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/languages","stargazers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/subscription","commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/merges","archive_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/downloads","issues_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/carl-mastrangelo/grpc-java/releases{/id}","created_at":"2015-07-08T21:45:19Z","updated_at":"2015-07-08T21:45:20Z","pushed_at":"2015-11-09T23:10:54Z","git_url":"git://github.com/carl-mastrangelo/grpc-java.git","ssh_url":"git@github.com:carl-mastrangelo/grpc-java.git","clone_url":"https://github.com/carl-mastrangelo/grpc-java.git","svn_url":"https://github.com/carl-mastrangelo/grpc-java","homepage":"","size":4979,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grpc:master","ref":"master","sha":"49b513504c06652816aeebcb49f2f650337c1aa5","user":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"repo":{"id":27729926,"name":"grpc-java","full_name":"grpc/grpc-java","owner":{"login":"grpc","id":7802525,"avatar_url":"https://avatars.githubusercontent.com/u/7802525?v=3","gravatar_id":"","url":"https://api.github.com/users/grpc","html_url":"https://github.com/grpc","followers_url":"https://api.github.com/users/grpc/followers","following_url":"https://api.github.com/users/grpc/following{/other_user}","gists_url":"https://api.github.com/users/grpc/gists{/gist_id}","starred_url":"https://api.github.com/users/grpc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grpc/subscriptions","organizations_url":"https://api.github.com/users/grpc/orgs","repos_url":"https://api.github.com/users/grpc/repos","events_url":"https://api.github.com/users/grpc/events{/privacy}","received_events_url":"https://api.github.com/users/grpc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grpc/grpc-java","description":"The Java gRPC implementation. HTTP/2 based RPC","fork":false,"url":"https://api.github.com/repos/grpc/grpc-java","forks_url":"https://api.github.com/repos/grpc/grpc-java/forks","keys_url":"https://api.github.com/repos/grpc/grpc-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grpc/grpc-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grpc/grpc-java/teams","hooks_url":"https://api.github.com/repos/grpc/grpc-java/hooks","issue_events_url":"https://api.github.com/repos/grpc/grpc-java/issues/events{/number}","events_url":"https://api.github.com/repos/grpc/grpc-java/events","assignees_url":"https://api.github.com/repos/grpc/grpc-java/assignees{/user}","branches_url":"https://api.github.com/repos/grpc/grpc-java/branches{/branch}","tags_url":"https://api.github.com/repos/grpc/grpc-java/tags","blobs_url":"https://api.github.com/repos/grpc/grpc-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grpc/grpc-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grpc/grpc-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/grpc/grpc-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grpc/grpc-java/statuses/{sha}","languages_url":"https://api.github.com/repos/grpc/grpc-java/languages","stargazers_url":"https://api.github.com/repos/grpc/grpc-java/stargazers","contributors_url":"https://api.github.com/repos/grpc/grpc-java/contributors","subscribers_url":"https://api.github.com/repos/grpc/grpc-java/subscribers","subscription_url":"https://api.github.com/repos/grpc/grpc-java/subscription","commits_url":"https://api.github.com/repos/grpc/grpc-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/grpc/grpc-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/grpc/grpc-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/grpc/grpc-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/grpc/grpc-java/contents/{+path}","compare_url":"https://api.github.com/repos/grpc/grpc-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grpc/grpc-java/merges","archive_url":"https://api.github.com/repos/grpc/grpc-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grpc/grpc-java/downloads","issues_url":"https://api.github.com/repos/grpc/grpc-java/issues{/number}","pulls_url":"https://api.github.com/repos/grpc/grpc-java/pulls{/number}","milestones_url":"https://api.github.com/repos/grpc/grpc-java/milestones{/number}","notifications_url":"https://api.github.com/repos/grpc/grpc-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grpc/grpc-java/labels{/name}","releases_url":"https://api.github.com/repos/grpc/grpc-java/releases{/id}","created_at":"2014-12-08T19:00:00Z","updated_at":"2015-11-09T06:28:57Z","pushed_at":"2015-11-09T23:10:55Z","git_url":"git://github.com/grpc/grpc-java.git","ssh_url":"git@github.com:grpc/grpc-java.git","clone_url":"https://github.com/grpc/grpc-java.git","svn_url":"https://github.com/grpc/grpc-java","homepage":"","size":23904,"stargazers_count":964,"watchers_count":964,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":245,"mirror_url":null,"open_issues_count":118,"forks":245,"open_issues":118,"watchers":964,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1011"},"html":{"href":"https://github.com/grpc/grpc-java/pull/1011"},"issue":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1011"},"comments":{"href":"https://api.github.com/repos/grpc/grpc-java/issues/1011/comments"},"review_comments":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1011/comments"},"review_comment":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grpc/grpc-java/pulls/1011/commits"},"statuses":{"href":"https://api.github.com/repos/grpc/grpc-java/statuses/51874b84659b38db6c4942cb5234130c1e9a94eb"}}}}