{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2894","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2894/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2894/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2894/events","html_url":"https://github.com/cockroachdb/cockroach/pull/2894","id":112882849,"number":2894,"title":"Cluster stability fixes","user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-22T20:16:58Z","updated_at":"2015-10-22T21:04:31Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/2894","html_url":"https://github.com/cockroachdb/cockroach/pull/2894","diff_url":"https://github.com/cockroachdb/cockroach/pull/2894.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/2894.patch"},"body":"+ Fixes instances of #2881; in both cases, it is appropriate to return a\r\nRangeNotFoundError, rather than a non-descript util.Errorf(). This allows\r\nDistSenders to properly clear caches and retry the errors.\r\n+ Fixes an additional instance of #2535. Local intent resolution can apparently\r\nencounter RangeNotFoundError as a result of the above fixes."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/150355937","html_url":"https://github.com/cockroachdb/cockroach/pull/2894#issuecomment-150355937","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/2894","id":150355937,"user":{"login":"mrtracy","id":6969858,"avatar_url":"https://avatars.githubusercontent.com/u/6969858?v=3","gravatar_id":"","url":"https://api.github.com/users/mrtracy","html_url":"https://github.com/mrtracy","followers_url":"https://api.github.com/users/mrtracy/followers","following_url":"https://api.github.com/users/mrtracy/following{/other_user}","gists_url":"https://api.github.com/users/mrtracy/gists{/gist_id}","starred_url":"https://api.github.com/users/mrtracy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrtracy/subscriptions","organizations_url":"https://api.github.com/users/mrtracy/orgs","repos_url":"https://api.github.com/users/mrtracy/repos","events_url":"https://api.github.com/users/mrtracy/events{/privacy}","received_events_url":"https://api.github.com/users/mrtracy/received_events","type":"User","site_admin":false},"created_at":"2015-10-22T21:04:31Z","updated_at":"2015-10-22T21:04:31Z","body":"Well, you could write a test to verify that the replica returns that error type in that condition, which is of limited utility.  As for verifying the actual condition, I think it's less feasible to replicate these; they are quite racy with very specific conditions, and it would be difficult to set them up in a unit test.  While not impossible, I think it's a low return value versus improving our non-unit testing; we should be running long-term load tests, which readily root out this class of bugs, automatically and on a regular basis."}}