{"action":"opened","number":12785,"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785","id":38647288,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785","number":12785,"state":"open","locked":false,"title":"[CR] Monster upgrade fixes","user":{"login":"drbig","id":1252899,"avatar_url":"https://avatars.githubusercontent.com/u/1252899?v=3","gravatar_id":"","url":"https://api.github.com/users/drbig","html_url":"https://github.com/drbig","followers_url":"https://api.github.com/users/drbig/followers","following_url":"https://api.github.com/users/drbig/following{/other_user}","gists_url":"https://api.github.com/users/drbig/gists{/gist_id}","starred_url":"https://api.github.com/users/drbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbig/subscriptions","organizations_url":"https://api.github.com/users/drbig/orgs","repos_url":"https://api.github.com/users/drbig/repos","events_url":"https://api.github.com/users/drbig/events{/privacy}","received_events_url":"https://api.github.com/users/drbig/received_events","type":"User","site_admin":false},"body":"Relates to #12313.\r\n\r\nSo it was supposed to be simple... yeah. Commits are commented, so here's a TL;DR:\r\n\r\n - The first commit changes the description of the upgrade factor. IMO this should be in regardless of everything else\r\n - I've added both season length scaling and initial season offset\r\n - I recalculate the upgrade threshold once, directly on monster load\r\n - I've made `can_upgrade` an almost single-point of checking if upgrade is OK, this may turn off the upgrade special attack in some cases\r\n\r\nNote: with season length scaling the settings factor being 0.0 - 100.0 makes a bit more sense.","created_at":"2015-06-26T13:07:54Z","updated_at":"2015-06-26T13:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/2c423a421bd564386be4ee9437ee9cc5721c60a6","head":{"label":"drbig:monupdate-fix","ref":"monupdate-fix","sha":"2c423a421bd564386be4ee9437ee9cc5721c60a6","user":{"login":"drbig","id":1252899,"avatar_url":"https://avatars.githubusercontent.com/u/1252899?v=3","gravatar_id":"","url":"https://api.github.com/users/drbig","html_url":"https://github.com/drbig","followers_url":"https://api.github.com/users/drbig/followers","following_url":"https://api.github.com/users/drbig/following{/other_user}","gists_url":"https://api.github.com/users/drbig/gists{/gist_id}","starred_url":"https://api.github.com/users/drbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbig/subscriptions","organizations_url":"https://api.github.com/users/drbig/orgs","repos_url":"https://api.github.com/users/drbig/repos","events_url":"https://api.github.com/users/drbig/events{/privacy}","received_events_url":"https://api.github.com/users/drbig/received_events","type":"User","site_admin":false},"repo":{"id":24682768,"name":"Cataclysm-DDA","full_name":"drbig/Cataclysm-DDA","owner":{"login":"drbig","id":1252899,"avatar_url":"https://avatars.githubusercontent.com/u/1252899?v=3","gravatar_id":"","url":"https://api.github.com/users/drbig","html_url":"https://github.com/drbig","followers_url":"https://api.github.com/users/drbig/followers","following_url":"https://api.github.com/users/drbig/following{/other_user}","gists_url":"https://api.github.com/users/drbig/gists{/gist_id}","starred_url":"https://api.github.com/users/drbig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drbig/subscriptions","organizations_url":"https://api.github.com/users/drbig/orgs","repos_url":"https://api.github.com/users/drbig/repos","events_url":"https://api.github.com/users/drbig/events{/privacy}","received_events_url":"https://api.github.com/users/drbig/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drbig/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/drbig/Cataclysm-DDA","forks_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/drbig/Cataclysm-DDA/releases{/id}","created_at":"2014-10-01T15:01:33Z","updated_at":"2015-04-02T18:35:11Z","pushed_at":"2015-06-26T12:59:17Z","git_url":"git://github.com/drbig/Cataclysm-DDA.git","ssh_url":"git@github.com:drbig/Cataclysm-DDA.git","clone_url":"https://github.com/drbig/Cataclysm-DDA.git","svn_url":"https://github.com/drbig/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":470491,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"0c9399d8fb894c7ab09b6a1146cd8e96a72f2f4b","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-06-26T02:45:17Z","pushed_at":"2015-06-26T12:09:34Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":554370,"stargazers_count":687,"watchers_count":687,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":729,"mirror_url":null,"open_issues_count":991,"forks":729,"open_issues":991,"watchers":687,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/12785"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/12785/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/12785/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/2c423a421bd564386be4ee9437ee9cc5721c60a6"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":4,"additions":35,"deletions":31,"changed_files":3}}