{"action":"created","comment":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/24548205","id":24548205,"diff_hunk":"@@ -122,15 +124,14 @@ public Effect (GraphicsDevice graphicsDevice, byte[] effectCode)\n             Clone(cloneSource);\n         }\n \n-        private MGFXHeader ReadHeader(byte[] effectCode)\n+        private MGFXHeader ReadHeader(byte[] effectCode, int index = 0)","path":"MonoGame.Framework/Graphics/Effect/Effect.cs","position":36,"original_position":36,"commit_id":"25e93af22ab121e4f1d50efcc87cb698f4c731f3","original_commit_id":"25e93af22ab121e4f1d50efcc87cb698f4c731f3","user":{"login":"tomspilman","id":103522,"avatar_url":"https://avatars.githubusercontent.com/u/103522?v=3","gravatar_id":"","url":"https://api.github.com/users/tomspilman","html_url":"https://github.com/tomspilman","followers_url":"https://api.github.com/users/tomspilman/followers","following_url":"https://api.github.com/users/tomspilman/following{/other_user}","gists_url":"https://api.github.com/users/tomspilman/gists{/gist_id}","starred_url":"https://api.github.com/users/tomspilman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomspilman/subscriptions","organizations_url":"https://api.github.com/users/tomspilman/orgs","repos_url":"https://api.github.com/users/tomspilman/repos","events_url":"https://api.github.com/users/tomspilman/events{/privacy}","received_events_url":"https://api.github.com/users/tomspilman/received_events","type":"User","site_admin":false},"body":"This is an internal API...  I would remove the default parameter value and make everyone deal with the new argument.","created_at":"2015-02-12T00:23:33Z","updated_at":"2015-02-12T00:23:33Z","html_url":"https://github.com/mono/MonoGame/pull/3518#discussion_r24548205","pull_request_url":"https://api.github.com/repos/mono/MonoGame/pulls/3518","_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/24548205"},"html":{"href":"https://github.com/mono/MonoGame/pull/3518#discussion_r24548205"},"pull_request":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/3518"}}},"pull_request":{"url":"https://api.github.com/repos/mono/MonoGame/pulls/3518","id":29139058,"html_url":"https://github.com/mono/MonoGame/pull/3518","diff_url":"https://github.com/mono/MonoGame/pull/3518.diff","patch_url":"https://github.com/mono/MonoGame/pull/3518.patch","issue_url":"https://api.github.com/repos/mono/MonoGame/issues/3518","number":3518,"state":"open","locked":false,"title":"Content readers cache","user":{"login":"nkast","id":3018589,"avatar_url":"https://avatars.githubusercontent.com/u/3018589?v=3","gravatar_id":"","url":"https://api.github.com/users/nkast","html_url":"https://github.com/nkast","followers_url":"https://api.github.com/users/nkast/followers","following_url":"https://api.github.com/users/nkast/following{/other_user}","gists_url":"https://api.github.com/users/nkast/gists{/gist_id}","starred_url":"https://api.github.com/users/nkast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkast/subscriptions","organizations_url":"https://api.github.com/users/nkast/orgs","repos_url":"https://api.github.com/users/nkast/repos","events_url":"https://api.github.com/users/nkast/events{/privacy}","received_events_url":"https://api.github.com/users/nkast/received_events","type":"User","site_admin":false},"body":"Here is a memoryPool for byte[] objects used by ContentReaders. I found that this can reduce load/resume times down to 70%.\r\nHaven't tested it on other than DX platforms and probably needs some more work but this thread on community reminded me I need to submit this.\r\nhttp://community.monogame.net/t/loading-huge-content/1942\r\nFeel free to propose any changes to names, functionality, and of course feedback on other platforms, profile data, etc.\r\n\r\n![contentreadersbufferpool](https://cloud.githubusercontent.com/assets/3018589/6158649/3570e6c6-b255-11e4-8e74-420f2d31a1bf.png)\r\n","created_at":"2015-02-11T23:29:02Z","updated_at":"2015-02-12T00:23:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"036276b312345962522854b83d708a69dc40eaf0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mono/MonoGame/pulls/3518/commits","review_comments_url":"https://api.github.com/repos/mono/MonoGame/pulls/3518/comments","review_comment_url":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}","comments_url":"https://api.github.com/repos/mono/MonoGame/issues/3518/comments","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/25e93af22ab121e4f1d50efcc87cb698f4c731f3","head":{"label":"nkast:ContentReadersCache","ref":"ContentReadersCache","sha":"25e93af22ab121e4f1d50efcc87cb698f4c731f3","user":{"login":"nkast","id":3018589,"avatar_url":"https://avatars.githubusercontent.com/u/3018589?v=3","gravatar_id":"","url":"https://api.github.com/users/nkast","html_url":"https://github.com/nkast","followers_url":"https://api.github.com/users/nkast/followers","following_url":"https://api.github.com/users/nkast/following{/other_user}","gists_url":"https://api.github.com/users/nkast/gists{/gist_id}","starred_url":"https://api.github.com/users/nkast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkast/subscriptions","organizations_url":"https://api.github.com/users/nkast/orgs","repos_url":"https://api.github.com/users/nkast/repos","events_url":"https://api.github.com/users/nkast/events{/privacy}","received_events_url":"https://api.github.com/users/nkast/received_events","type":"User","site_admin":false},"repo":{"id":22667387,"name":"MonoGame","full_name":"nkast/MonoGame","owner":{"login":"nkast","id":3018589,"avatar_url":"https://avatars.githubusercontent.com/u/3018589?v=3","gravatar_id":"","url":"https://api.github.com/users/nkast","html_url":"https://github.com/nkast","followers_url":"https://api.github.com/users/nkast/followers","following_url":"https://api.github.com/users/nkast/following{/other_user}","gists_url":"https://api.github.com/users/nkast/gists{/gist_id}","starred_url":"https://api.github.com/users/nkast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkast/subscriptions","organizations_url":"https://api.github.com/users/nkast/orgs","repos_url":"https://api.github.com/users/nkast/repos","events_url":"https://api.github.com/users/nkast/events{/privacy}","received_events_url":"https://api.github.com/users/nkast/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nkast/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":true,"url":"https://api.github.com/repos/nkast/MonoGame","forks_url":"https://api.github.com/repos/nkast/MonoGame/forks","keys_url":"https://api.github.com/repos/nkast/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nkast/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nkast/MonoGame/teams","hooks_url":"https://api.github.com/repos/nkast/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/nkast/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/nkast/MonoGame/events","assignees_url":"https://api.github.com/repos/nkast/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/nkast/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/nkast/MonoGame/tags","blobs_url":"https://api.github.com/repos/nkast/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nkast/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nkast/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/nkast/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nkast/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/nkast/MonoGame/languages","stargazers_url":"https://api.github.com/repos/nkast/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/nkast/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/nkast/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/nkast/MonoGame/subscription","commits_url":"https://api.github.com/repos/nkast/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/nkast/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/nkast/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/nkast/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/nkast/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/nkast/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nkast/MonoGame/merges","archive_url":"https://api.github.com/repos/nkast/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nkast/MonoGame/downloads","issues_url":"https://api.github.com/repos/nkast/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/nkast/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/nkast/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/nkast/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nkast/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/nkast/MonoGame/releases{/id}","created_at":"2014-08-06T02:45:42Z","updated_at":"2015-02-04T02:45:51Z","pushed_at":"2015-02-07T06:39:31Z","git_url":"git://github.com/nkast/MonoGame.git","ssh_url":"git@github.com:nkast/MonoGame.git","clone_url":"https://github.com/nkast/MonoGame.git","svn_url":"https://github.com/nkast/MonoGame","homepage":"http://www.monogame.net","size":49235,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mono:develop","ref":"develop","sha":"3257d09b2ab0d06df738988dba376487188b3778","user":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"repo":{"id":1579990,"name":"MonoGame","full_name":"mono/MonoGame","owner":{"login":"mono","id":53395,"avatar_url":"https://avatars.githubusercontent.com/u/53395?v=3","gravatar_id":"","url":"https://api.github.com/users/mono","html_url":"https://github.com/mono","followers_url":"https://api.github.com/users/mono/followers","following_url":"https://api.github.com/users/mono/following{/other_user}","gists_url":"https://api.github.com/users/mono/gists{/gist_id}","starred_url":"https://api.github.com/users/mono/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mono/subscriptions","organizations_url":"https://api.github.com/users/mono/orgs","repos_url":"https://api.github.com/users/mono/repos","events_url":"https://api.github.com/users/mono/events{/privacy}","received_events_url":"https://api.github.com/users/mono/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mono/MonoGame","description":"One framework for creating powerful cross-platform games.","fork":false,"url":"https://api.github.com/repos/mono/MonoGame","forks_url":"https://api.github.com/repos/mono/MonoGame/forks","keys_url":"https://api.github.com/repos/mono/MonoGame/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mono/MonoGame/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mono/MonoGame/teams","hooks_url":"https://api.github.com/repos/mono/MonoGame/hooks","issue_events_url":"https://api.github.com/repos/mono/MonoGame/issues/events{/number}","events_url":"https://api.github.com/repos/mono/MonoGame/events","assignees_url":"https://api.github.com/repos/mono/MonoGame/assignees{/user}","branches_url":"https://api.github.com/repos/mono/MonoGame/branches{/branch}","tags_url":"https://api.github.com/repos/mono/MonoGame/tags","blobs_url":"https://api.github.com/repos/mono/MonoGame/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mono/MonoGame/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mono/MonoGame/git/refs{/sha}","trees_url":"https://api.github.com/repos/mono/MonoGame/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mono/MonoGame/statuses/{sha}","languages_url":"https://api.github.com/repos/mono/MonoGame/languages","stargazers_url":"https://api.github.com/repos/mono/MonoGame/stargazers","contributors_url":"https://api.github.com/repos/mono/MonoGame/contributors","subscribers_url":"https://api.github.com/repos/mono/MonoGame/subscribers","subscription_url":"https://api.github.com/repos/mono/MonoGame/subscription","commits_url":"https://api.github.com/repos/mono/MonoGame/commits{/sha}","git_commits_url":"https://api.github.com/repos/mono/MonoGame/git/commits{/sha}","comments_url":"https://api.github.com/repos/mono/MonoGame/comments{/number}","issue_comment_url":"https://api.github.com/repos/mono/MonoGame/issues/comments/{number}","contents_url":"https://api.github.com/repos/mono/MonoGame/contents/{+path}","compare_url":"https://api.github.com/repos/mono/MonoGame/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mono/MonoGame/merges","archive_url":"https://api.github.com/repos/mono/MonoGame/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mono/MonoGame/downloads","issues_url":"https://api.github.com/repos/mono/MonoGame/issues{/number}","pulls_url":"https://api.github.com/repos/mono/MonoGame/pulls{/number}","milestones_url":"https://api.github.com/repos/mono/MonoGame/milestones{/number}","notifications_url":"https://api.github.com/repos/mono/MonoGame/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mono/MonoGame/labels{/name}","releases_url":"https://api.github.com/repos/mono/MonoGame/releases{/id}","created_at":"2011-04-07T00:23:40Z","updated_at":"2015-02-11T20:19:45Z","pushed_at":"2015-02-10T23:44:56Z","git_url":"git://github.com/mono/MonoGame.git","ssh_url":"git@github.com:mono/MonoGame.git","clone_url":"https://github.com/mono/MonoGame.git","svn_url":"https://github.com/mono/MonoGame","homepage":"http://www.monogame.net","size":313017,"stargazers_count":2555,"watchers_count":2555,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1456,"mirror_url":null,"open_issues_count":573,"forks":1456,"open_issues":573,"watchers":2555,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/3518"},"html":{"href":"https://github.com/mono/MonoGame/pull/3518"},"issue":{"href":"https://api.github.com/repos/mono/MonoGame/issues/3518"},"comments":{"href":"https://api.github.com/repos/mono/MonoGame/issues/3518/comments"},"review_comments":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/3518/comments"},"review_comment":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/mono/MonoGame/pulls/3518/commits"},"statuses":{"href":"https://api.github.com/repos/mono/MonoGame/statuses/25e93af22ab121e4f1d50efcc87cb698f4c731f3"}}}}