{"action":"created","issue":{"url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1024","labels_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1024/labels{/name}","comments_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1024/comments","events_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1024/events","html_url":"https://github.com/quasar-analytics/quasar/pull/1024","id":121083363,"number":1024,"title":"[SD-1177] Port over addition of offset and limit to query API","user":{"login":"jedesah","id":1780116,"avatar_url":"https://avatars.githubusercontent.com/u/1780116?v=3","gravatar_id":"","url":"https://api.github.com/users/jedesah","html_url":"https://github.com/jedesah","followers_url":"https://api.github.com/users/jedesah/followers","following_url":"https://api.github.com/users/jedesah/following{/other_user}","gists_url":"https://api.github.com/users/jedesah/gists{/gist_id}","starred_url":"https://api.github.com/users/jedesah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedesah/subscriptions","organizations_url":"https://api.github.com/users/jedesah/orgs","repos_url":"https://api.github.com/users/jedesah/repos","events_url":"https://api.github.com/users/jedesah/events{/privacy}","received_events_url":"https://api.github.com/users/jedesah/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-12-08T19:43:11Z","updated_at":"2015-12-08T21:41:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/quasar-analytics/quasar/pulls/1024","html_url":"https://github.com/quasar-analytics/quasar/pull/1024","diff_url":"https://github.com/quasar-analytics/quasar/pull/1024.diff","patch_url":"https://github.com/quasar-analytics/quasar/pull/1024.patch"},"body":"- Add show for Positive\r\n- Implement response for SemanticError\r\n- Add new test in CompileAndQuerySpec and refactor a little to get it in there nicely\r\n- Add simple in-memory query evaluator"},"comment":{"url":"https://api.github.com/repos/quasar-analytics/quasar/issues/comments/163026262","html_url":"https://github.com/quasar-analytics/quasar/pull/1024#issuecomment-163026262","issue_url":"https://api.github.com/repos/quasar-analytics/quasar/issues/1024","id":163026262,"user":{"login":"mossprescott","id":6147371,"avatar_url":"https://avatars.githubusercontent.com/u/6147371?v=3","gravatar_id":"","url":"https://api.github.com/users/mossprescott","html_url":"https://github.com/mossprescott","followers_url":"https://api.github.com/users/mossprescott/followers","following_url":"https://api.github.com/users/mossprescott/following{/other_user}","gists_url":"https://api.github.com/users/mossprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/mossprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mossprescott/subscriptions","organizations_url":"https://api.github.com/users/mossprescott/orgs","repos_url":"https://api.github.com/users/mossprescott/repos","events_url":"https://api.github.com/users/mossprescott/events{/privacy}","received_events_url":"https://api.github.com/users/mossprescott/received_events","type":"User","site_admin":false},"created_at":"2015-12-08T21:41:07Z","updated_at":"2015-12-08T21:41:07Z","body":"On POST: what you want to test is always just that the right query was evaluated; in the old tests, I had to do all kinds of tricks to verify that by inspecting the response because I wanted to avoid state in the (stubbed) backend. In this case, you could inspect the log that comes back long with the output path.\r\n\r\nBut it might be easier now to just record the query when it's evaluated and inspect it directly, or at least that was my hope. :)\r\n"}}