{"action":"created","issue":{"url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/issues/128","labels_url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/issues/128/comments","events_url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/issues/128/events","html_url":"https://github.com/criticalmaps/criticalmaps-android/pull/128","id":116325973,"number":128,"title":"Use dagger 2.0","user":{"login":"ligi","id":111600,"avatar_url":"https://avatars.githubusercontent.com/u/111600?v=3","gravatar_id":"","url":"https://api.github.com/users/ligi","html_url":"https://github.com/ligi","followers_url":"https://api.github.com/users/ligi/followers","following_url":"https://api.github.com/users/ligi/following{/other_user}","gists_url":"https://api.github.com/users/ligi/gists{/gist_id}","starred_url":"https://api.github.com/users/ligi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ligi/subscriptions","organizations_url":"https://api.github.com/users/ligi/orgs","repos_url":"https://api.github.com/users/ligi/repos","events_url":"https://api.github.com/users/ligi/events{/privacy}","received_events_url":"https://api.github.com/users/ligi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-11T12:34:54Z","updated_at":"2015-11-11T13:51:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/pulls/128","html_url":"https://github.com/criticalmaps/criticalmaps-android/pull/128","diff_url":"https://github.com/criticalmaps/criticalmaps-android/pull/128.diff","patch_url":"https://github.com/criticalmaps/criticalmaps-android/pull/128.patch"},"body":"And move Constants to central place + cleanup"},"comment":{"url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/issues/comments/155789287","html_url":"https://github.com/criticalmaps/criticalmaps-android/pull/128#issuecomment-155789287","issue_url":"https://api.github.com/repos/criticalmaps/criticalmaps-android/issues/128","id":155789287,"user":{"login":"cbalster","id":9266843,"avatar_url":"https://avatars.githubusercontent.com/u/9266843?v=3","gravatar_id":"","url":"https://api.github.com/users/cbalster","html_url":"https://github.com/cbalster","followers_url":"https://api.github.com/users/cbalster/followers","following_url":"https://api.github.com/users/cbalster/following{/other_user}","gists_url":"https://api.github.com/users/cbalster/gists{/gist_id}","starred_url":"https://api.github.com/users/cbalster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbalster/subscriptions","organizations_url":"https://api.github.com/users/cbalster/orgs","repos_url":"https://api.github.com/users/cbalster/repos","events_url":"https://api.github.com/users/cbalster/events{/privacy}","received_events_url":"https://api.github.com/users/cbalster/received_events","type":"User","site_admin":false},"created_at":"2015-11-11T13:51:47Z","updated_at":"2015-11-11T13:51:47Z","body":"Not tested yet, but looks good so far. One thing though:\r\nI really, really dislike dumping all constants - without any logical connection - into a single class. There is absolutely no reason to do so as they all have a perfectly fine place to live in that corresponds to their use. For example the http timeout should just be moved to the component imho."}}