{"action":"created","comment":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/comments/31378604","id":31378604,"diff_hunk":"@@ -138,17 +139,20 @@ def update\n     return error!(401, 'Wrong user') unless current_user == user\n \n     # Finagling things into place\n-    changes[:cover_image] = changes[:cover_image_url] if changes[:cover_image_url] =~ /^data:/\n-    changes[:password] = changes[:new_password] if changes[:new_password].present?\n+    changes[:cover_image] =\n+      changes[:cover_image_url] if changes[:cover_image_url] =~ /^data:/\n+    changes[:password] =\n+      changes[:new_password] if changes[:new_password].present?\n     changes[:name] = changes[:new_username] if changes[:new_username].present?\n     changes[:star_rating] = (changes[:rating_type] == 'advanced')\n-    [:new_password, :new_username, :rating_type, :cover_image_url].each do |key|\n+    %i(new_password new_username rating_type cover_image_url).each do |key|\n       changes.delete(key)\n     end\n \n-    changes = changes.permit(:about, :location, :waifu, :website, :waifu_or_husbando,\n-                   :bio, :waifu_char_id, :email, :cover_image, :sfw_filter,\n-                   :title_language_preference, :password, :name, :star_rating)\n+    changes = changes.permit(:about, :location, :website, :name, :waifu_char_id,\n+                             :sfw_filter, :waifu, :bio, :email, :cover_image,\n+                             :waifu_or_husbando, :title_language_preference,\n+                             :password, :star_rating)","path":"app/controllers/users_controller.rb","position":126,"original_position":126,"commit_id":"f3a4a4d963fee5fb4ac953bb98287d8bb4a6ce8c","original_commit_id":"f3a4a4d963fee5fb4ac953bb98287d8bb4a6ce8c","user":{"login":"Eschon","id":11647830,"avatar_url":"https://avatars.githubusercontent.com/u/11647830?v=3","gravatar_id":"","url":"https://api.github.com/users/Eschon","html_url":"https://github.com/Eschon","followers_url":"https://api.github.com/users/Eschon/followers","following_url":"https://api.github.com/users/Eschon/following{/other_user}","gists_url":"https://api.github.com/users/Eschon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eschon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eschon/subscriptions","organizations_url":"https://api.github.com/users/Eschon/orgs","repos_url":"https://api.github.com/users/Eschon/repos","events_url":"https://api.github.com/users/Eschon/events{/privacy}","received_events_url":"https://api.github.com/users/Eschon/received_events","type":"User","site_admin":false},"body":"Looks much better to me now.\r\nWhat do you think?","created_at":"2015-05-30T07:13:19Z","updated_at":"2015-05-30T07:13:19Z","html_url":"https://github.com/hummingbird-me/hummingbird/pull/561#discussion_r31378604","pull_request_url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561","_links":{"self":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/comments/31378604"},"html":{"href":"https://github.com/hummingbird-me/hummingbird/pull/561#discussion_r31378604"},"pull_request":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561"}}},"pull_request":{"url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561","id":36137556,"html_url":"https://github.com/hummingbird-me/hummingbird/pull/561","diff_url":"https://github.com/hummingbird-me/hummingbird/pull/561.diff","patch_url":"https://github.com/hummingbird-me/hummingbird/pull/561.patch","issue_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/561","number":561,"state":"open","locked":false,"title":"resolve rubocop offenses for users_controller.rb","user":{"login":"Eschon","id":11647830,"avatar_url":"https://avatars.githubusercontent.com/u/11647830?v=3","gravatar_id":"","url":"https://api.github.com/users/Eschon","html_url":"https://github.com/Eschon","followers_url":"https://api.github.com/users/Eschon/followers","following_url":"https://api.github.com/users/Eschon/following{/other_user}","gists_url":"https://api.github.com/users/Eschon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eschon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eschon/subscriptions","organizations_url":"https://api.github.com/users/Eschon/orgs","repos_url":"https://api.github.com/users/Eschon/repos","events_url":"https://api.github.com/users/Eschon/events{/privacy}","received_events_url":"https://api.github.com/users/Eschon/received_events","type":"User","site_admin":false},"body":"I resolved a few rubocop offenses again. \r\nAgain there where a few that I didn't know how to fix:\r\n* Assignment Branch Condition size too high (for `def index`, `def follow` and `def update`)\r\n* Method has too many lines (for `def index`, `def follow` and `def update`)\r\n* Perceived complexity to high (for `def index`)","created_at":"2015-05-25T12:45:56Z","updated_at":"2015-05-30T07:13:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"46765b3a4d600c6a72e6b0b5698f7c56f1104f34","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561/commits","review_comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561/comments","review_comment_url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/561/comments","statuses_url":"https://api.github.com/repos/hummingbird-me/hummingbird/statuses/f3a4a4d963fee5fb4ac953bb98287d8bb4a6ce8c","head":{"label":"Eschon:rubocop","ref":"rubocop","sha":"f3a4a4d963fee5fb4ac953bb98287d8bb4a6ce8c","user":{"login":"Eschon","id":11647830,"avatar_url":"https://avatars.githubusercontent.com/u/11647830?v=3","gravatar_id":"","url":"https://api.github.com/users/Eschon","html_url":"https://github.com/Eschon","followers_url":"https://api.github.com/users/Eschon/followers","following_url":"https://api.github.com/users/Eschon/following{/other_user}","gists_url":"https://api.github.com/users/Eschon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eschon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eschon/subscriptions","organizations_url":"https://api.github.com/users/Eschon/orgs","repos_url":"https://api.github.com/users/Eschon/repos","events_url":"https://api.github.com/users/Eschon/events{/privacy}","received_events_url":"https://api.github.com/users/Eschon/received_events","type":"User","site_admin":false},"repo":{"id":35328845,"name":"hummingbird","full_name":"Eschon/hummingbird","owner":{"login":"Eschon","id":11647830,"avatar_url":"https://avatars.githubusercontent.com/u/11647830?v=3","gravatar_id":"","url":"https://api.github.com/users/Eschon","html_url":"https://github.com/Eschon","followers_url":"https://api.github.com/users/Eschon/followers","following_url":"https://api.github.com/users/Eschon/following{/other_user}","gists_url":"https://api.github.com/users/Eschon/gists{/gist_id}","starred_url":"https://api.github.com/users/Eschon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eschon/subscriptions","organizations_url":"https://api.github.com/users/Eschon/orgs","repos_url":"https://api.github.com/users/Eschon/repos","events_url":"https://api.github.com/users/Eschon/events{/privacy}","received_events_url":"https://api.github.com/users/Eschon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Eschon/hummingbird","description":"Probably the coolest anime discovery platform around.","fork":true,"url":"https://api.github.com/repos/Eschon/hummingbird","forks_url":"https://api.github.com/repos/Eschon/hummingbird/forks","keys_url":"https://api.github.com/repos/Eschon/hummingbird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Eschon/hummingbird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Eschon/hummingbird/teams","hooks_url":"https://api.github.com/repos/Eschon/hummingbird/hooks","issue_events_url":"https://api.github.com/repos/Eschon/hummingbird/issues/events{/number}","events_url":"https://api.github.com/repos/Eschon/hummingbird/events","assignees_url":"https://api.github.com/repos/Eschon/hummingbird/assignees{/user}","branches_url":"https://api.github.com/repos/Eschon/hummingbird/branches{/branch}","tags_url":"https://api.github.com/repos/Eschon/hummingbird/tags","blobs_url":"https://api.github.com/repos/Eschon/hummingbird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Eschon/hummingbird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Eschon/hummingbird/git/refs{/sha}","trees_url":"https://api.github.com/repos/Eschon/hummingbird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Eschon/hummingbird/statuses/{sha}","languages_url":"https://api.github.com/repos/Eschon/hummingbird/languages","stargazers_url":"https://api.github.com/repos/Eschon/hummingbird/stargazers","contributors_url":"https://api.github.com/repos/Eschon/hummingbird/contributors","subscribers_url":"https://api.github.com/repos/Eschon/hummingbird/subscribers","subscription_url":"https://api.github.com/repos/Eschon/hummingbird/subscription","commits_url":"https://api.github.com/repos/Eschon/hummingbird/commits{/sha}","git_commits_url":"https://api.github.com/repos/Eschon/hummingbird/git/commits{/sha}","comments_url":"https://api.github.com/repos/Eschon/hummingbird/comments{/number}","issue_comment_url":"https://api.github.com/repos/Eschon/hummingbird/issues/comments{/number}","contents_url":"https://api.github.com/repos/Eschon/hummingbird/contents/{+path}","compare_url":"https://api.github.com/repos/Eschon/hummingbird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Eschon/hummingbird/merges","archive_url":"https://api.github.com/repos/Eschon/hummingbird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Eschon/hummingbird/downloads","issues_url":"https://api.github.com/repos/Eschon/hummingbird/issues{/number}","pulls_url":"https://api.github.com/repos/Eschon/hummingbird/pulls{/number}","milestones_url":"https://api.github.com/repos/Eschon/hummingbird/milestones{/number}","notifications_url":"https://api.github.com/repos/Eschon/hummingbird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Eschon/hummingbird/labels{/name}","releases_url":"https://api.github.com/repos/Eschon/hummingbird/releases{/id}","created_at":"2015-05-09T13:05:12Z","updated_at":"2015-05-09T13:05:15Z","pushed_at":"2015-05-30T07:11:33Z","git_url":"git://github.com/Eschon/hummingbird.git","ssh_url":"git@github.com:Eschon/hummingbird.git","clone_url":"https://github.com/Eschon/hummingbird.git","svn_url":"https://github.com/Eschon/hummingbird","homepage":"http://hummingbird.me/","size":81003,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hummingbird-me:master","ref":"master","sha":"b07ab11971a0c87d43dd47d1b67dd647a9dec583","user":{"login":"hummingbird-me","id":7648832,"avatar_url":"https://avatars.githubusercontent.com/u/7648832?v=3","gravatar_id":"","url":"https://api.github.com/users/hummingbird-me","html_url":"https://github.com/hummingbird-me","followers_url":"https://api.github.com/users/hummingbird-me/followers","following_url":"https://api.github.com/users/hummingbird-me/following{/other_user}","gists_url":"https://api.github.com/users/hummingbird-me/gists{/gist_id}","starred_url":"https://api.github.com/users/hummingbird-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hummingbird-me/subscriptions","organizations_url":"https://api.github.com/users/hummingbird-me/orgs","repos_url":"https://api.github.com/users/hummingbird-me/repos","events_url":"https://api.github.com/users/hummingbird-me/events{/privacy}","received_events_url":"https://api.github.com/users/hummingbird-me/received_events","type":"Organization","site_admin":false},"repo":{"id":20206508,"name":"hummingbird","full_name":"hummingbird-me/hummingbird","owner":{"login":"hummingbird-me","id":7648832,"avatar_url":"https://avatars.githubusercontent.com/u/7648832?v=3","gravatar_id":"","url":"https://api.github.com/users/hummingbird-me","html_url":"https://github.com/hummingbird-me","followers_url":"https://api.github.com/users/hummingbird-me/followers","following_url":"https://api.github.com/users/hummingbird-me/following{/other_user}","gists_url":"https://api.github.com/users/hummingbird-me/gists{/gist_id}","starred_url":"https://api.github.com/users/hummingbird-me/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hummingbird-me/subscriptions","organizations_url":"https://api.github.com/users/hummingbird-me/orgs","repos_url":"https://api.github.com/users/hummingbird-me/repos","events_url":"https://api.github.com/users/hummingbird-me/events{/privacy}","received_events_url":"https://api.github.com/users/hummingbird-me/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hummingbird-me/hummingbird","description":"Probably the coolest anime discovery platform around.","fork":false,"url":"https://api.github.com/repos/hummingbird-me/hummingbird","forks_url":"https://api.github.com/repos/hummingbird-me/hummingbird/forks","keys_url":"https://api.github.com/repos/hummingbird-me/hummingbird/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hummingbird-me/hummingbird/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hummingbird-me/hummingbird/teams","hooks_url":"https://api.github.com/repos/hummingbird-me/hummingbird/hooks","issue_events_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/events{/number}","events_url":"https://api.github.com/repos/hummingbird-me/hummingbird/events","assignees_url":"https://api.github.com/repos/hummingbird-me/hummingbird/assignees{/user}","branches_url":"https://api.github.com/repos/hummingbird-me/hummingbird/branches{/branch}","tags_url":"https://api.github.com/repos/hummingbird-me/hummingbird/tags","blobs_url":"https://api.github.com/repos/hummingbird-me/hummingbird/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hummingbird-me/hummingbird/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hummingbird-me/hummingbird/git/refs{/sha}","trees_url":"https://api.github.com/repos/hummingbird-me/hummingbird/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hummingbird-me/hummingbird/statuses/{sha}","languages_url":"https://api.github.com/repos/hummingbird-me/hummingbird/languages","stargazers_url":"https://api.github.com/repos/hummingbird-me/hummingbird/stargazers","contributors_url":"https://api.github.com/repos/hummingbird-me/hummingbird/contributors","subscribers_url":"https://api.github.com/repos/hummingbird-me/hummingbird/subscribers","subscription_url":"https://api.github.com/repos/hummingbird-me/hummingbird/subscription","commits_url":"https://api.github.com/repos/hummingbird-me/hummingbird/commits{/sha}","git_commits_url":"https://api.github.com/repos/hummingbird-me/hummingbird/git/commits{/sha}","comments_url":"https://api.github.com/repos/hummingbird-me/hummingbird/comments{/number}","issue_comment_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/comments{/number}","contents_url":"https://api.github.com/repos/hummingbird-me/hummingbird/contents/{+path}","compare_url":"https://api.github.com/repos/hummingbird-me/hummingbird/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hummingbird-me/hummingbird/merges","archive_url":"https://api.github.com/repos/hummingbird-me/hummingbird/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hummingbird-me/hummingbird/downloads","issues_url":"https://api.github.com/repos/hummingbird-me/hummingbird/issues{/number}","pulls_url":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls{/number}","milestones_url":"https://api.github.com/repos/hummingbird-me/hummingbird/milestones{/number}","notifications_url":"https://api.github.com/repos/hummingbird-me/hummingbird/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hummingbird-me/hummingbird/labels{/name}","releases_url":"https://api.github.com/repos/hummingbird-me/hummingbird/releases{/id}","created_at":"2014-05-27T04:05:08Z","updated_at":"2015-05-27T17:39:02Z","pushed_at":"2015-05-30T07:11:33Z","git_url":"git://github.com/hummingbird-me/hummingbird.git","ssh_url":"git@github.com:hummingbird-me/hummingbird.git","clone_url":"https://github.com/hummingbird-me/hummingbird.git","svn_url":"https://github.com/hummingbird-me/hummingbird","homepage":"http://hummingbird.me/","size":106058,"stargazers_count":1350,"watchers_count":1350,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"open_issues_count":59,"forks":151,"open_issues":59,"watchers":1350,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561"},"html":{"href":"https://github.com/hummingbird-me/hummingbird/pull/561"},"issue":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/561"},"comments":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/issues/561/comments"},"review_comments":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561/comments"},"review_comment":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/pulls/561/commits"},"statuses":{"href":"https://api.github.com/repos/hummingbird-me/hummingbird/statuses/f3a4a4d963fee5fb4ac953bb98287d8bb4a6ce8c"}}}}