{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/36578414","id":36578414,"diff_hunk":"@@ -290,6 +292,75 @@ void Jit64::lXXx(UGeckoInstruction inst)\n \tgpr.UnlockAllX();\n }\n \n+void Jit64::dcbx(UGeckoInstruction inst)\n+{\n+\tINSTRUCTION_START\n+\tJITDISABLE(bJITLoadStoreOff);\n+\n+\tX64Reg addr = RSCRATCH;\n+\tX64Reg value = RSCRATCH2;\n+\tX64Reg tmp = gpr.GetFreeXReg();\n+\tgpr.FlushLockX(tmp);\n+\n+\tif (inst.RA && gpr.R(inst.RA).IsSimpleReg() && gpr.R(inst.RB).IsSimpleReg())\n+\t{\n+\t\tLEA(32, addr, MRegSum(gpr.RX(inst.RA), gpr.RX(inst.RB)));\n+\t}\n+\telse\n+\t{\n+\t\tMOV(32, R(addr), gpr.R(inst.RB));\n+\t\tif (inst.RA)\n+\t\t\tADD(32, R(addr), gpr.R(inst.RA));\n+\t}\n+\n+\tMOV(32, R(value), R(addr));\n+\tSHL(32, R(value), Imm8(3));\n+\tSHR(32, R(value), Imm8(13));\n+\tMOV(64, R(tmp), ImmPtr(jit->GetBlockCache()->GetBlockBitSet()));\n+\tMOV(32, R(value), MComplex(tmp, value, SCALE_4, 0));\n+\n+\tMOV(32, R(tmp), R(addr));\n+\tSHR(32, R(tmp), Imm8(5));\n+\tBT(32, R(value), R(tmp));\n+\n+\tFixupBranch c = J_CC(CC_C, true);\n+\tSwitchToFarCode();\n+\tSetJumpTarget(c);\n+\tBitSet32 registersInUse = CallerSavedRegistersInUse();\n+\tABI_PushRegistersAndAdjustStack(registersInUse, 0);\n+\tMOV(32, R(ABI_PARAM1), R(addr));","path":"Source/Core/Core/PowerPC/Jit64/Jit_LoadStore.cpp","position":49,"original_position":49,"commit_id":"7a111cbecf67e768e1a6f93e51358fab755e40b3","original_commit_id":"7a111cbecf67e768e1a6f93e51358fab755e40b3","user":{"login":"delroth","id":202798,"avatar_url":"https://avatars.githubusercontent.com/u/202798?v=3","gravatar_id":"","url":"https://api.github.com/users/delroth","html_url":"https://github.com/delroth","followers_url":"https://api.github.com/users/delroth/followers","following_url":"https://api.github.com/users/delroth/following{/other_user}","gists_url":"https://api.github.com/users/delroth/gists{/gist_id}","starred_url":"https://api.github.com/users/delroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delroth/subscriptions","organizations_url":"https://api.github.com/users/delroth/orgs","repos_url":"https://api.github.com/users/delroth/repos","events_url":"https://api.github.com/users/delroth/events{/privacy}","received_events_url":"https://api.github.com/users/delroth/received_events","type":"User","site_admin":false},"body":"Actually, relevant to the comment above re: temporary, I'm not sure if this is correct. this should really be addr & ~0x20 to realign the invalidation to one block.","created_at":"2015-08-08T13:52:17Z","updated_at":"2015-08-08T13:52:17Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/2663#discussion_r36578414","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/36578414"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2663#discussion_r36578414"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663","id":38641108,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2663","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2663.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2663.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2663","number":2663,"state":"open","locked":false,"title":"Jit64: dcbf + dcbi + icbi","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"Both dcbx instructions are called quite often and usually NOPs. So inline to first check within the JIT itself to skip over them much faster.","created_at":"2015-06-26T11:40:12Z","updated_at":"2015-08-08T13:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72654b4429a77e0e5502100a8a36d4720af99dd5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2663/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/7a111cbecf67e768e1a6f93e51358fab755e40b3","head":{"label":"degasus:dcbx","ref":"dcbx","sha":"7a111cbecf67e768e1a6f93e51358fab755e40b3","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"repo":{"id":16313731,"name":"dolphin","full_name":"degasus/dolphin","owner":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/degasus/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/degasus/dolphin","forks_url":"https://api.github.com/repos/degasus/dolphin/forks","keys_url":"https://api.github.com/repos/degasus/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/degasus/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/degasus/dolphin/teams","hooks_url":"https://api.github.com/repos/degasus/dolphin/hooks","issue_events_url":"https://api.github.com/repos/degasus/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/degasus/dolphin/events","assignees_url":"https://api.github.com/repos/degasus/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/degasus/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/degasus/dolphin/tags","blobs_url":"https://api.github.com/repos/degasus/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/degasus/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/degasus/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/degasus/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/degasus/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/degasus/dolphin/languages","stargazers_url":"https://api.github.com/repos/degasus/dolphin/stargazers","contributors_url":"https://api.github.com/repos/degasus/dolphin/contributors","subscribers_url":"https://api.github.com/repos/degasus/dolphin/subscribers","subscription_url":"https://api.github.com/repos/degasus/dolphin/subscription","commits_url":"https://api.github.com/repos/degasus/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/degasus/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/degasus/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/degasus/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/degasus/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/degasus/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/degasus/dolphin/merges","archive_url":"https://api.github.com/repos/degasus/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/degasus/dolphin/downloads","issues_url":"https://api.github.com/repos/degasus/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/degasus/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/degasus/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/degasus/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/degasus/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/degasus/dolphin/releases{/id}","created_at":"2014-01-28T14:18:33Z","updated_at":"2015-04-18T13:03:26Z","pushed_at":"2015-08-08T13:27:45Z","git_url":"git://github.com/degasus/dolphin.git","ssh_url":"git@github.com:degasus/dolphin.git","clone_url":"https://github.com/degasus/dolphin.git","svn_url":"https://github.com/degasus/dolphin","homepage":null,"size":220620,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"14a0b01854555d23a5990e04f99e79f9aa6a1e7e","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-08-07T15:09:30Z","pushed_at":"2015-08-08T13:27:47Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":304010,"stargazers_count":1557,"watchers_count":1557,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"open_issues_count":76,"forks":480,"open_issues":76,"watchers":1557,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2663"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2663"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2663/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2663/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/7a111cbecf67e768e1a6f93e51358fab755e40b3"}}}}