{"action":"opened","number":2219,"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/2219","id":53900298,"html_url":"https://github.com/rust-lang/cargo/pull/2219","diff_url":"https://github.com/rust-lang/cargo/pull/2219.diff","patch_url":"https://github.com/rust-lang/cargo/pull/2219.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/2219","number":2219,"state":"open","locked":false,"title":"refactor Target serialization","user":{"login":"matklad","id":1711539,"avatar_url":"https://avatars.githubusercontent.com/u/1711539?v=3","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false},"body":"@alexcrichton another preparation PR for #2196 \r\n\r\nI've removed obscure `metadata` field from `Target`. It is a breaking change (for read-manifest), but the field seemed cryptic, useless and untested :) \r\n\r\n`Target` has a bunch of boolean fields:\r\n\r\n```\r\n    tested: bool,\r\n    benched: bool,\r\n    doc: bool,\r\n    doctest: bool,\r\n    harness: bool, // whether to use the test harness (--test)\r\n    for_host: bool,\r\n```\r\n\r\nI guess they should not be included in serialized representation?\r\n\r\nI will push commits for other `Encodable`s here. ","created_at":"2015-12-16T21:22:51Z","updated_at":"2015-12-16T21:22:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2219/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/2219/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/2219/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/33976d56e6356688a788d7dedf824054a5622300","head":{"label":"matklad:encodable-audit","ref":"encodable-audit","sha":"33976d56e6356688a788d7dedf824054a5622300","user":{"login":"matklad","id":1711539,"avatar_url":"https://avatars.githubusercontent.com/u/1711539?v=3","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false},"repo":{"id":47427273,"name":"cargo","full_name":"matklad/cargo","owner":{"login":"matklad","id":1711539,"avatar_url":"https://avatars.githubusercontent.com/u/1711539?v=3","gravatar_id":"","url":"https://api.github.com/users/matklad","html_url":"https://github.com/matklad","followers_url":"https://api.github.com/users/matklad/followers","following_url":"https://api.github.com/users/matklad/following{/other_user}","gists_url":"https://api.github.com/users/matklad/gists{/gist_id}","starred_url":"https://api.github.com/users/matklad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matklad/subscriptions","organizations_url":"https://api.github.com/users/matklad/orgs","repos_url":"https://api.github.com/users/matklad/repos","events_url":"https://api.github.com/users/matklad/events{/privacy}","received_events_url":"https://api.github.com/users/matklad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matklad/cargo","description":"The Rust package manager","fork":true,"url":"https://api.github.com/repos/matklad/cargo","forks_url":"https://api.github.com/repos/matklad/cargo/forks","keys_url":"https://api.github.com/repos/matklad/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matklad/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matklad/cargo/teams","hooks_url":"https://api.github.com/repos/matklad/cargo/hooks","issue_events_url":"https://api.github.com/repos/matklad/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/matklad/cargo/events","assignees_url":"https://api.github.com/repos/matklad/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/matklad/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/matklad/cargo/tags","blobs_url":"https://api.github.com/repos/matklad/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matklad/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matklad/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/matklad/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matklad/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/matklad/cargo/languages","stargazers_url":"https://api.github.com/repos/matklad/cargo/stargazers","contributors_url":"https://api.github.com/repos/matklad/cargo/contributors","subscribers_url":"https://api.github.com/repos/matklad/cargo/subscribers","subscription_url":"https://api.github.com/repos/matklad/cargo/subscription","commits_url":"https://api.github.com/repos/matklad/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/matklad/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/matklad/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/matklad/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/matklad/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/matklad/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matklad/cargo/merges","archive_url":"https://api.github.com/repos/matklad/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matklad/cargo/downloads","issues_url":"https://api.github.com/repos/matklad/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/matklad/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/matklad/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/matklad/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matklad/cargo/labels{/name}","releases_url":"https://api.github.com/repos/matklad/cargo/releases{/id}","created_at":"2015-12-04T20:30:04Z","updated_at":"2015-12-04T20:30:06Z","pushed_at":"2015-12-16T21:14:04Z","git_url":"git://github.com/matklad/cargo.git","ssh_url":"git@github.com:matklad/cargo.git","clone_url":"https://github.com/matklad/cargo.git","svn_url":"https://github.com/matklad/cargo","homepage":"http://crates.io/","size":8955,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"978009329aa0c76fbcd8f0cd0d450d0f4175d836","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","created_at":"2014-03-04T23:20:42Z","updated_at":"2015-12-16T21:18:28Z","pushed_at":"2015-12-16T21:22:52Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"http://crates.io/","size":21620,"stargazers_count":1411,"watchers_count":1411,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":317,"mirror_url":null,"open_issues_count":199,"forks":317,"open_issues":199,"watchers":1411,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2219"},"html":{"href":"https://github.com/rust-lang/cargo/pull/2219"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2219"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/2219/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2219/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/2219/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/33976d56e6356688a788d7dedf824054a5622300"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":24,"deletions":23,"changed_files":2}}