{"action":"created","issue":{"url":"https://api.github.com/repos/netty/netty/issues/4532","labels_url":"https://api.github.com/repos/netty/netty/issues/4532/labels{/name}","comments_url":"https://api.github.com/repos/netty/netty/issues/4532/comments","events_url":"https://api.github.com/repos/netty/netty/issues/4532/events","html_url":"https://github.com/netty/netty/pull/4532","id":119991317,"number":4532,"title":"Remove final to allow overriding behavior in SimpleChannelPool","user":{"login":"PierreCoquentin","id":3818289,"avatar_url":"https://avatars.githubusercontent.com/u/3818289?v=3","gravatar_id":"","url":"https://api.github.com/users/PierreCoquentin","html_url":"https://github.com/PierreCoquentin","followers_url":"https://api.github.com/users/PierreCoquentin/followers","following_url":"https://api.github.com/users/PierreCoquentin/following{/other_user}","gists_url":"https://api.github.com/users/PierreCoquentin/gists{/gist_id}","starred_url":"https://api.github.com/users/PierreCoquentin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PierreCoquentin/subscriptions","organizations_url":"https://api.github.com/users/PierreCoquentin/orgs","repos_url":"https://api.github.com/users/PierreCoquentin/repos","events_url":"https://api.github.com/users/PierreCoquentin/events{/privacy}","received_events_url":"https://api.github.com/users/PierreCoquentin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-12-02T17:14:04Z","updated_at":"2015-12-04T21:53:06Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/4532","html_url":"https://github.com/netty/netty/pull/4532","diff_url":"https://github.com/netty/netty/pull/4532.diff","patch_url":"https://github.com/netty/netty/pull/4532.patch"},"body":"Netty version 4.0.33\r\nI don't know if there is a reason to put final the class whereas there is some interesting behavior to override in the class io.netty.channel.pool.SimpleChannelPool and still using nice features offered by FixedChannelPool"},"comment":{"url":"https://api.github.com/repos/netty/netty/issues/comments/162092283","html_url":"https://github.com/netty/netty/pull/4532#issuecomment-162092283","issue_url":"https://api.github.com/repos/netty/netty/issues/4532","id":162092283,"user":{"login":"Scottmitch","id":7562868,"avatar_url":"https://avatars.githubusercontent.com/u/7562868?v=3","gravatar_id":"","url":"https://api.github.com/users/Scottmitch","html_url":"https://github.com/Scottmitch","followers_url":"https://api.github.com/users/Scottmitch/followers","following_url":"https://api.github.com/users/Scottmitch/following{/other_user}","gists_url":"https://api.github.com/users/Scottmitch/gists{/gist_id}","starred_url":"https://api.github.com/users/Scottmitch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Scottmitch/subscriptions","organizations_url":"https://api.github.com/users/Scottmitch/orgs","repos_url":"https://api.github.com/users/Scottmitch/repos","events_url":"https://api.github.com/users/Scottmitch/events{/privacy}","received_events_url":"https://api.github.com/users/Scottmitch/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T21:53:06Z","updated_at":"2015-12-04T21:53:06Z","body":"@PierreCoquentin - In general we try to restrict API access to the lowest level that makes sense. There were no apparent use cases where it would necessary to extend this class, but that doesn't mean we couldn't make it non-final if it makes sense to do so.  However can you describe why `AbstractChannelPoolMap` is not sufficient for your current use case?"}}