{"action":"created","comment":{"url":"https://api.github.com/repos/rails/rails/pulls/comments/23065089","id":23065089,"diff_hunk":"@@ -94,7 +94,11 @@ def self.[](*args)\n     #\n     # This value can be later fetched using either +:key+ or +'key'+.\n     def []=(key, value)\n-      regular_writer(convert_key(key), convert_value(value, for: :assignment))\n+      if value.frozen?\n+        regular_writer(convert_key(key), convert_value(value))\n+      else\n+        regular_writer(convert_key(key), convert_value(value, for: :assignment))\n+      end","path":"activesupport/lib/active_support/hash_with_indifferent_access.rb","position":9,"original_position":9,"commit_id":"133ed0ee844e48b6f142db22c12b0c26d7b33778","original_commit_id":"133ed0ee844e48b6f142db22c12b0c26d7b33778","user":{"login":"aditya-kapoor","id":1955930,"avatar_url":"https://avatars.githubusercontent.com/u/1955930?v=3","gravatar_id":"","url":"https://api.github.com/users/aditya-kapoor","html_url":"https://github.com/aditya-kapoor","followers_url":"https://api.github.com/users/aditya-kapoor/followers","following_url":"https://api.github.com/users/aditya-kapoor/following{/other_user}","gists_url":"https://api.github.com/users/aditya-kapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya-kapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya-kapoor/subscriptions","organizations_url":"https://api.github.com/users/aditya-kapoor/orgs","repos_url":"https://api.github.com/users/aditya-kapoor/repos","events_url":"https://api.github.com/users/aditya-kapoor/events{/privacy}","received_events_url":"https://api.github.com/users/aditya-kapoor/received_events","type":"User","site_admin":false},"body":"I initially followed that approach but @senny fixed the same in https://github.com/rails/rails/pull/10784, that would have a 'side effect' as described in the PR.","created_at":"2015-01-16T06:25:53Z","updated_at":"2015-01-16T06:25:53Z","html_url":"https://github.com/rails/rails/pull/18551#discussion_r23065089","pull_request_url":"https://api.github.com/repos/rails/rails/pulls/18551","_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/23065089"},"html":{"href":"https://github.com/rails/rails/pull/18551#discussion_r23065089"},"pull_request":{"href":"https://api.github.com/repos/rails/rails/pulls/18551"}}},"pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/18551","id":27486241,"html_url":"https://github.com/rails/rails/pull/18551","diff_url":"https://github.com/rails/rails/pull/18551.diff","patch_url":"https://github.com/rails/rails/pull/18551.patch","issue_url":"https://api.github.com/repos/rails/rails/issues/18551","number":18551,"state":"open","locked":false,"title":"Fix assignment for frozen value in HWIA","user":{"login":"aditya-kapoor","id":1955930,"avatar_url":"https://avatars.githubusercontent.com/u/1955930?v=3","gravatar_id":"","url":"https://api.github.com/users/aditya-kapoor","html_url":"https://github.com/aditya-kapoor","followers_url":"https://api.github.com/users/aditya-kapoor/followers","following_url":"https://api.github.com/users/aditya-kapoor/following{/other_user}","gists_url":"https://api.github.com/users/aditya-kapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya-kapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya-kapoor/subscriptions","organizations_url":"https://api.github.com/users/aditya-kapoor/orgs","repos_url":"https://api.github.com/users/aditya-kapoor/repos","events_url":"https://api.github.com/users/aditya-kapoor/events{/privacy}","received_events_url":"https://api.github.com/users/aditya-kapoor/received_events","type":"User","site_admin":false},"body":"Fixes #18550 ","created_at":"2015-01-16T06:13:30Z","updated_at":"2015-01-16T06:25:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb49120d39b65cc6da5aac9e34ed5b87652aab8c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/rails/pulls/18551/commits","review_comments_url":"https://api.github.com/repos/rails/rails/pulls/18551/comments","review_comment_url":"https://api.github.com/repos/rails/rails/pulls/comments/{number}","comments_url":"https://api.github.com/repos/rails/rails/issues/18551/comments","statuses_url":"https://api.github.com/repos/rails/rails/statuses/133ed0ee844e48b6f142db22c12b0c26d7b33778","head":{"label":"aditya-kapoor:fix-frozen-hwia","ref":"fix-frozen-hwia","sha":"133ed0ee844e48b6f142db22c12b0c26d7b33778","user":{"login":"aditya-kapoor","id":1955930,"avatar_url":"https://avatars.githubusercontent.com/u/1955930?v=3","gravatar_id":"","url":"https://api.github.com/users/aditya-kapoor","html_url":"https://github.com/aditya-kapoor","followers_url":"https://api.github.com/users/aditya-kapoor/followers","following_url":"https://api.github.com/users/aditya-kapoor/following{/other_user}","gists_url":"https://api.github.com/users/aditya-kapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya-kapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya-kapoor/subscriptions","organizations_url":"https://api.github.com/users/aditya-kapoor/orgs","repos_url":"https://api.github.com/users/aditya-kapoor/repos","events_url":"https://api.github.com/users/aditya-kapoor/events{/privacy}","received_events_url":"https://api.github.com/users/aditya-kapoor/received_events","type":"User","site_admin":false},"repo":{"id":9595353,"name":"rails","full_name":"aditya-kapoor/rails","owner":{"login":"aditya-kapoor","id":1955930,"avatar_url":"https://avatars.githubusercontent.com/u/1955930?v=3","gravatar_id":"","url":"https://api.github.com/users/aditya-kapoor","html_url":"https://github.com/aditya-kapoor","followers_url":"https://api.github.com/users/aditya-kapoor/followers","following_url":"https://api.github.com/users/aditya-kapoor/following{/other_user}","gists_url":"https://api.github.com/users/aditya-kapoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aditya-kapoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aditya-kapoor/subscriptions","organizations_url":"https://api.github.com/users/aditya-kapoor/orgs","repos_url":"https://api.github.com/users/aditya-kapoor/repos","events_url":"https://api.github.com/users/aditya-kapoor/events{/privacy}","received_events_url":"https://api.github.com/users/aditya-kapoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aditya-kapoor/rails","description":"Ruby on Rails","fork":true,"url":"https://api.github.com/repos/aditya-kapoor/rails","forks_url":"https://api.github.com/repos/aditya-kapoor/rails/forks","keys_url":"https://api.github.com/repos/aditya-kapoor/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aditya-kapoor/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aditya-kapoor/rails/teams","hooks_url":"https://api.github.com/repos/aditya-kapoor/rails/hooks","issue_events_url":"https://api.github.com/repos/aditya-kapoor/rails/issues/events{/number}","events_url":"https://api.github.com/repos/aditya-kapoor/rails/events","assignees_url":"https://api.github.com/repos/aditya-kapoor/rails/assignees{/user}","branches_url":"https://api.github.com/repos/aditya-kapoor/rails/branches{/branch}","tags_url":"https://api.github.com/repos/aditya-kapoor/rails/tags","blobs_url":"https://api.github.com/repos/aditya-kapoor/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aditya-kapoor/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aditya-kapoor/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/aditya-kapoor/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aditya-kapoor/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/aditya-kapoor/rails/languages","stargazers_url":"https://api.github.com/repos/aditya-kapoor/rails/stargazers","contributors_url":"https://api.github.com/repos/aditya-kapoor/rails/contributors","subscribers_url":"https://api.github.com/repos/aditya-kapoor/rails/subscribers","subscription_url":"https://api.github.com/repos/aditya-kapoor/rails/subscription","commits_url":"https://api.github.com/repos/aditya-kapoor/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/aditya-kapoor/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/aditya-kapoor/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/aditya-kapoor/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/aditya-kapoor/rails/contents/{+path}","compare_url":"https://api.github.com/repos/aditya-kapoor/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aditya-kapoor/rails/merges","archive_url":"https://api.github.com/repos/aditya-kapoor/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aditya-kapoor/rails/downloads","issues_url":"https://api.github.com/repos/aditya-kapoor/rails/issues{/number}","pulls_url":"https://api.github.com/repos/aditya-kapoor/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/aditya-kapoor/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/aditya-kapoor/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aditya-kapoor/rails/labels{/name}","releases_url":"https://api.github.com/repos/aditya-kapoor/rails/releases{/id}","created_at":"2013-04-22T09:20:42Z","updated_at":"2015-01-16T05:45:48Z","pushed_at":"2015-01-16T06:12:54Z","git_url":"git://github.com/aditya-kapoor/rails.git","ssh_url":"git@github.com:aditya-kapoor/rails.git","clone_url":"https://github.com/aditya-kapoor/rails.git","svn_url":"https://github.com/aditya-kapoor/rails","homepage":"http://rubyonrails.org","size":119826,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"090c5211ced7b728df6176d5c9fc7437c107beaf","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":8514,"name":"rails","full_name":"rails/rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/rails","description":"Ruby on Rails","fork":false,"url":"https://api.github.com/repos/rails/rails","forks_url":"https://api.github.com/repos/rails/rails/forks","keys_url":"https://api.github.com/repos/rails/rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/rails/teams","hooks_url":"https://api.github.com/repos/rails/rails/hooks","issue_events_url":"https://api.github.com/repos/rails/rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/rails/events","assignees_url":"https://api.github.com/repos/rails/rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/rails/tags","blobs_url":"https://api.github.com/repos/rails/rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/rails/languages","stargazers_url":"https://api.github.com/repos/rails/rails/stargazers","contributors_url":"https://api.github.com/repos/rails/rails/contributors","subscribers_url":"https://api.github.com/repos/rails/rails/subscribers","subscription_url":"https://api.github.com/repos/rails/rails/subscription","commits_url":"https://api.github.com/repos/rails/rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/rails/issues/comments/{number}","contents_url":"https://api.github.com/repos/rails/rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/rails/merges","archive_url":"https://api.github.com/repos/rails/rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/rails/downloads","issues_url":"https://api.github.com/repos/rails/rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/rails/releases{/id}","created_at":"2008-04-11T02:19:47Z","updated_at":"2015-01-15T23:42:40Z","pushed_at":"2015-01-15T22:26:52Z","git_url":"git://github.com/rails/rails.git","ssh_url":"git@github.com:rails/rails.git","clone_url":"https://github.com/rails/rails.git","svn_url":"https://github.com/rails/rails","homepage":"http://rubyonrails.org","size":378065,"stargazers_count":24591,"watchers_count":24591,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9508,"mirror_url":null,"open_issues_count":756,"forks":9508,"open_issues":756,"watchers":24591,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/rails/pulls/18551"},"html":{"href":"https://github.com/rails/rails/pull/18551"},"issue":{"href":"https://api.github.com/repos/rails/rails/issues/18551"},"comments":{"href":"https://api.github.com/repos/rails/rails/issues/18551/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/rails/pulls/18551/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/rails/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/rails/rails/pulls/18551/commits"},"statuses":{"href":"https://api.github.com/repos/rails/rails/statuses/133ed0ee844e48b6f142db22c12b0c26d7b33778"}}}}