{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/comments/27035664","id":27035664,"diff_hunk":"@@ -72,12 +73,47 @@ var ColdLaunch = function(options) {\n util.inherits(ColdLaunch, Phase);\n \n /**\n+ * Verify a given <appPath> is valid; raise error if not.\n+ * @param appPath\n+ */\n+ColdLaunch.prototype.verifyApp = function(appPath) {\n+  var parts = appPath.split('/');\n+  this.manifestPath = parts[0];\n+  this.entryPoint = parts[1] || '';\n+  this.appIndex = null;","path":"lib/suite/cold-launch.js","position":19,"original_position":19,"commit_id":"75a96bf2e647e15de429dac32404638a6ca56aaa","original_commit_id":"75a96bf2e647e15de429dac32404638a6ca56aaa","user":{"login":"eliperelman","id":285899,"avatar_url":"https://avatars.githubusercontent.com/u/285899?v=3","gravatar_id":"","url":"https://api.github.com/users/eliperelman","html_url":"https://github.com/eliperelman","followers_url":"https://api.github.com/users/eliperelman/followers","following_url":"https://api.github.com/users/eliperelman/following{/other_user}","gists_url":"https://api.github.com/users/eliperelman/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperelman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperelman/subscriptions","organizations_url":"https://api.github.com/users/eliperelman/orgs","repos_url":"https://api.github.com/users/eliperelman/repos","events_url":"https://api.github.com/users/eliperelman/events{/privacy}","received_events_url":"https://api.github.com/users/eliperelman/received_events","type":"User","site_admin":false},"body":"Similar to the other comment, if we run this method after `.setManifestData` then we don't need to worry about setting `.manifestPath` or `.entryPoint`.","created_at":"2015-03-24T14:59:00Z","updated_at":"2015-03-24T14:59:00Z","html_url":"https://github.com/mozilla-b2g/raptor/pull/23#discussion_r27035664","pull_request_url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/comments/27035664"},"html":{"href":"https://github.com/mozilla-b2g/raptor/pull/23#discussion_r27035664"},"pull_request":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23","id":31833517,"html_url":"https://github.com/mozilla-b2g/raptor/pull/23","diff_url":"https://github.com/mozilla-b2g/raptor/pull/23.diff","patch_url":"https://github.com/mozilla-b2g/raptor/pull/23.patch","issue_url":"https://api.github.com/repos/mozilla-b2g/raptor/issues/23","number":23,"state":"open","locked":false,"title":"Bug 113919 - Fail with descriptive error if valid app name not provided","user":{"login":"rwood-moz","id":2198968,"avatar_url":"https://avatars.githubusercontent.com/u/2198968?v=3","gravatar_id":"","url":"https://api.github.com/users/rwood-moz","html_url":"https://github.com/rwood-moz","followers_url":"https://api.github.com/users/rwood-moz/followers","following_url":"https://api.github.com/users/rwood-moz/following{/other_user}","gists_url":"https://api.github.com/users/rwood-moz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwood-moz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwood-moz/subscriptions","organizations_url":"https://api.github.com/users/rwood-moz/orgs","repos_url":"https://api.github.com/users/rwood-moz/repos","events_url":"https://api.github.com/users/rwood-moz/events{/privacy}","received_events_url":"https://api.github.com/users/rwood-moz/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-24T14:52:11Z","updated_at":"2015-03-24T14:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"470c371392b6609076cd9e0267fcff1ae052f2cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23/commits","review_comments_url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23/comments","review_comment_url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla-b2g/raptor/issues/23/comments","statuses_url":"https://api.github.com/repos/mozilla-b2g/raptor/statuses/75a96bf2e647e15de429dac32404638a6ca56aaa","head":{"label":"rwood-moz:bug1139195","ref":"bug1139195","sha":"75a96bf2e647e15de429dac32404638a6ca56aaa","user":{"login":"rwood-moz","id":2198968,"avatar_url":"https://avatars.githubusercontent.com/u/2198968?v=3","gravatar_id":"","url":"https://api.github.com/users/rwood-moz","html_url":"https://github.com/rwood-moz","followers_url":"https://api.github.com/users/rwood-moz/followers","following_url":"https://api.github.com/users/rwood-moz/following{/other_user}","gists_url":"https://api.github.com/users/rwood-moz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwood-moz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwood-moz/subscriptions","organizations_url":"https://api.github.com/users/rwood-moz/orgs","repos_url":"https://api.github.com/users/rwood-moz/repos","events_url":"https://api.github.com/users/rwood-moz/events{/privacy}","received_events_url":"https://api.github.com/users/rwood-moz/received_events","type":"User","site_admin":false},"repo":{"id":28238599,"name":"raptor","full_name":"rwood-moz/raptor","owner":{"login":"rwood-moz","id":2198968,"avatar_url":"https://avatars.githubusercontent.com/u/2198968?v=3","gravatar_id":"","url":"https://api.github.com/users/rwood-moz","html_url":"https://github.com/rwood-moz","followers_url":"https://api.github.com/users/rwood-moz/followers","following_url":"https://api.github.com/users/rwood-moz/following{/other_user}","gists_url":"https://api.github.com/users/rwood-moz/gists{/gist_id}","starred_url":"https://api.github.com/users/rwood-moz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rwood-moz/subscriptions","organizations_url":"https://api.github.com/users/rwood-moz/orgs","repos_url":"https://api.github.com/users/rwood-moz/repos","events_url":"https://api.github.com/users/rwood-moz/events{/privacy}","received_events_url":"https://api.github.com/users/rwood-moz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rwood-moz/raptor","description":"","fork":true,"url":"https://api.github.com/repos/rwood-moz/raptor","forks_url":"https://api.github.com/repos/rwood-moz/raptor/forks","keys_url":"https://api.github.com/repos/rwood-moz/raptor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rwood-moz/raptor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rwood-moz/raptor/teams","hooks_url":"https://api.github.com/repos/rwood-moz/raptor/hooks","issue_events_url":"https://api.github.com/repos/rwood-moz/raptor/issues/events{/number}","events_url":"https://api.github.com/repos/rwood-moz/raptor/events","assignees_url":"https://api.github.com/repos/rwood-moz/raptor/assignees{/user}","branches_url":"https://api.github.com/repos/rwood-moz/raptor/branches{/branch}","tags_url":"https://api.github.com/repos/rwood-moz/raptor/tags","blobs_url":"https://api.github.com/repos/rwood-moz/raptor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rwood-moz/raptor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rwood-moz/raptor/git/refs{/sha}","trees_url":"https://api.github.com/repos/rwood-moz/raptor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rwood-moz/raptor/statuses/{sha}","languages_url":"https://api.github.com/repos/rwood-moz/raptor/languages","stargazers_url":"https://api.github.com/repos/rwood-moz/raptor/stargazers","contributors_url":"https://api.github.com/repos/rwood-moz/raptor/contributors","subscribers_url":"https://api.github.com/repos/rwood-moz/raptor/subscribers","subscription_url":"https://api.github.com/repos/rwood-moz/raptor/subscription","commits_url":"https://api.github.com/repos/rwood-moz/raptor/commits{/sha}","git_commits_url":"https://api.github.com/repos/rwood-moz/raptor/git/commits{/sha}","comments_url":"https://api.github.com/repos/rwood-moz/raptor/comments{/number}","issue_comment_url":"https://api.github.com/repos/rwood-moz/raptor/issues/comments{/number}","contents_url":"https://api.github.com/repos/rwood-moz/raptor/contents/{+path}","compare_url":"https://api.github.com/repos/rwood-moz/raptor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rwood-moz/raptor/merges","archive_url":"https://api.github.com/repos/rwood-moz/raptor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rwood-moz/raptor/downloads","issues_url":"https://api.github.com/repos/rwood-moz/raptor/issues{/number}","pulls_url":"https://api.github.com/repos/rwood-moz/raptor/pulls{/number}","milestones_url":"https://api.github.com/repos/rwood-moz/raptor/milestones{/number}","notifications_url":"https://api.github.com/repos/rwood-moz/raptor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rwood-moz/raptor/labels{/name}","releases_url":"https://api.github.com/repos/rwood-moz/raptor/releases{/id}","created_at":"2014-12-19T17:14:00Z","updated_at":"2015-03-23T13:33:56Z","pushed_at":"2015-03-24T14:51:35Z","git_url":"git://github.com/rwood-moz/raptor.git","ssh_url":"git@github.com:rwood-moz/raptor.git","clone_url":"https://github.com/rwood-moz/raptor.git","svn_url":"https://github.com/rwood-moz/raptor","homepage":null,"size":283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla-b2g:master","ref":"master","sha":"214b080efb193c7503556b54c6ff4b1e51108898","user":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"repo":{"id":25987479,"name":"raptor","full_name":"mozilla-b2g/raptor","owner":{"login":"mozilla-b2g","id":1261292,"avatar_url":"https://avatars.githubusercontent.com/u/1261292?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla-b2g","html_url":"https://github.com/mozilla-b2g","followers_url":"https://api.github.com/users/mozilla-b2g/followers","following_url":"https://api.github.com/users/mozilla-b2g/following{/other_user}","gists_url":"https://api.github.com/users/mozilla-b2g/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla-b2g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla-b2g/subscriptions","organizations_url":"https://api.github.com/users/mozilla-b2g/orgs","repos_url":"https://api.github.com/users/mozilla-b2g/repos","events_url":"https://api.github.com/users/mozilla-b2g/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla-b2g/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla-b2g/raptor","description":"","fork":false,"url":"https://api.github.com/repos/mozilla-b2g/raptor","forks_url":"https://api.github.com/repos/mozilla-b2g/raptor/forks","keys_url":"https://api.github.com/repos/mozilla-b2g/raptor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla-b2g/raptor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla-b2g/raptor/teams","hooks_url":"https://api.github.com/repos/mozilla-b2g/raptor/hooks","issue_events_url":"https://api.github.com/repos/mozilla-b2g/raptor/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla-b2g/raptor/events","assignees_url":"https://api.github.com/repos/mozilla-b2g/raptor/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla-b2g/raptor/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla-b2g/raptor/tags","blobs_url":"https://api.github.com/repos/mozilla-b2g/raptor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla-b2g/raptor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla-b2g/raptor/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla-b2g/raptor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla-b2g/raptor/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla-b2g/raptor/languages","stargazers_url":"https://api.github.com/repos/mozilla-b2g/raptor/stargazers","contributors_url":"https://api.github.com/repos/mozilla-b2g/raptor/contributors","subscribers_url":"https://api.github.com/repos/mozilla-b2g/raptor/subscribers","subscription_url":"https://api.github.com/repos/mozilla-b2g/raptor/subscription","commits_url":"https://api.github.com/repos/mozilla-b2g/raptor/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla-b2g/raptor/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla-b2g/raptor/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla-b2g/raptor/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla-b2g/raptor/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla-b2g/raptor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla-b2g/raptor/merges","archive_url":"https://api.github.com/repos/mozilla-b2g/raptor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla-b2g/raptor/downloads","issues_url":"https://api.github.com/repos/mozilla-b2g/raptor/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla-b2g/raptor/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla-b2g/raptor/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla-b2g/raptor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla-b2g/raptor/labels{/name}","releases_url":"https://api.github.com/repos/mozilla-b2g/raptor/releases{/id}","created_at":"2014-10-30T20:01:03Z","updated_at":"2015-03-20T15:22:54Z","pushed_at":"2015-03-24T14:52:11Z","git_url":"git://github.com/mozilla-b2g/raptor.git","ssh_url":"git@github.com:mozilla-b2g/raptor.git","clone_url":"https://github.com/mozilla-b2g/raptor.git","svn_url":"https://github.com/mozilla-b2g/raptor","homepage":null,"size":493,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23"},"html":{"href":"https://github.com/mozilla-b2g/raptor/pull/23"},"issue":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/issues/23"},"comments":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla-b2g/raptor/statuses/75a96bf2e647e15de429dac32404638a6ca56aaa"}}}}