{"action":"created","comment":{"url":"https://api.github.com/repos/square/p2/pulls/comments/35025929","id":35025929,"diff_hunk":"@@ -81,7 +81,7 @@ func main() {\n \t\t\t}\n \n \t\t\told := statusMap[podId][node]\n-\t\t\t_, old.Health = health.FindWorst(results)\n+\t\t\t_, old.Health = health.GetMultisourceResult(results)","path":"bin/p2-inspect/main.go","position":5,"original_position":5,"commit_id":"c6fb779d6cedd2c94eed9ad0a1b8eec98839bb19","original_commit_id":"c6fb779d6cedd2c94eed9ad0a1b8eec98839bb19","user":{"login":"anthonybishopric","id":540783,"avatar_url":"https://avatars.githubusercontent.com/u/540783?v=3","gravatar_id":"","url":"https://api.github.com/users/anthonybishopric","html_url":"https://github.com/anthonybishopric","followers_url":"https://api.github.com/users/anthonybishopric/followers","following_url":"https://api.github.com/users/anthonybishopric/following{/other_user}","gists_url":"https://api.github.com/users/anthonybishopric/gists{/gist_id}","starred_url":"https://api.github.com/users/anthonybishopric/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anthonybishopric/subscriptions","organizations_url":"https://api.github.com/users/anthonybishopric/orgs","repos_url":"https://api.github.com/users/anthonybishopric/repos","events_url":"https://api.github.com/users/anthonybishopric/events{/privacy}","received_events_url":"https://api.github.com/users/anthonybishopric/received_events","type":"User","site_admin":false},"body":"We should try to minimize public API changes if possible. The fact that health lives in two places isn't important to clients. `FindWorst` is an important aspect of `pkg/replication` since we always want to ensure we're working on hosts that are the \"least healthy\" at any given time.","created_at":"2015-07-20T18:19:00Z","updated_at":"2015-07-20T18:19:00Z","html_url":"https://github.com/square/p2/pull/198#discussion_r35025929","pull_request_url":"https://api.github.com/repos/square/p2/pulls/198","_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/comments/35025929"},"html":{"href":"https://github.com/square/p2/pull/198#discussion_r35025929"},"pull_request":{"href":"https://api.github.com/repos/square/p2/pulls/198"}}},"pull_request":{"url":"https://api.github.com/repos/square/p2/pulls/198","id":40380143,"html_url":"https://github.com/square/p2/pull/198","diff_url":"https://github.com/square/p2/pull/198.diff","patch_url":"https://github.com/square/p2/pull/198.patch","issue_url":"https://api.github.com/repos/square/p2/issues/198","number":198,"state":"open","locked":false,"title":"Abbott/healthcheck","user":{"login":"robertabbott","id":7033685,"avatar_url":"https://avatars.githubusercontent.com/u/7033685?v=3","gravatar_id":"","url":"https://api.github.com/users/robertabbott","html_url":"https://github.com/robertabbott","followers_url":"https://api.github.com/users/robertabbott/followers","following_url":"https://api.github.com/users/robertabbott/following{/other_user}","gists_url":"https://api.github.com/users/robertabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/robertabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertabbott/subscriptions","organizations_url":"https://api.github.com/users/robertabbott/orgs","repos_url":"https://api.github.com/users/robertabbott/repos","events_url":"https://api.github.com/users/robertabbott/events{/privacy}","received_events_url":"https://api.github.com/users/robertabbott/received_events","type":"User","site_admin":false},"body":"hopefully this isn't a bad way to check both the kv store and the health catalog","created_at":"2015-07-20T18:07:53Z","updated_at":"2015-07-20T18:19:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"673b74330c50b896d5ba513919ffcfe314839493","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/square/p2/pulls/198/commits","review_comments_url":"https://api.github.com/repos/square/p2/pulls/198/comments","review_comment_url":"https://api.github.com/repos/square/p2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/square/p2/issues/198/comments","statuses_url":"https://api.github.com/repos/square/p2/statuses/c6fb779d6cedd2c94eed9ad0a1b8eec98839bb19","head":{"label":"robertabbott:abbott/healthcheck","ref":"abbott/healthcheck","sha":"c6fb779d6cedd2c94eed9ad0a1b8eec98839bb19","user":{"login":"robertabbott","id":7033685,"avatar_url":"https://avatars.githubusercontent.com/u/7033685?v=3","gravatar_id":"","url":"https://api.github.com/users/robertabbott","html_url":"https://github.com/robertabbott","followers_url":"https://api.github.com/users/robertabbott/followers","following_url":"https://api.github.com/users/robertabbott/following{/other_user}","gists_url":"https://api.github.com/users/robertabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/robertabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertabbott/subscriptions","organizations_url":"https://api.github.com/users/robertabbott/orgs","repos_url":"https://api.github.com/users/robertabbott/repos","events_url":"https://api.github.com/users/robertabbott/events{/privacy}","received_events_url":"https://api.github.com/users/robertabbott/received_events","type":"User","site_admin":false},"repo":{"id":38002902,"name":"p2","full_name":"robertabbott/p2","owner":{"login":"robertabbott","id":7033685,"avatar_url":"https://avatars.githubusercontent.com/u/7033685?v=3","gravatar_id":"","url":"https://api.github.com/users/robertabbott","html_url":"https://github.com/robertabbott","followers_url":"https://api.github.com/users/robertabbott/followers","following_url":"https://api.github.com/users/robertabbott/following{/other_user}","gists_url":"https://api.github.com/users/robertabbott/gists{/gist_id}","starred_url":"https://api.github.com/users/robertabbott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robertabbott/subscriptions","organizations_url":"https://api.github.com/users/robertabbott/orgs","repos_url":"https://api.github.com/users/robertabbott/repos","events_url":"https://api.github.com/users/robertabbott/events{/privacy}","received_events_url":"https://api.github.com/users/robertabbott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robertabbott/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":true,"url":"https://api.github.com/repos/robertabbott/p2","forks_url":"https://api.github.com/repos/robertabbott/p2/forks","keys_url":"https://api.github.com/repos/robertabbott/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robertabbott/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robertabbott/p2/teams","hooks_url":"https://api.github.com/repos/robertabbott/p2/hooks","issue_events_url":"https://api.github.com/repos/robertabbott/p2/issues/events{/number}","events_url":"https://api.github.com/repos/robertabbott/p2/events","assignees_url":"https://api.github.com/repos/robertabbott/p2/assignees{/user}","branches_url":"https://api.github.com/repos/robertabbott/p2/branches{/branch}","tags_url":"https://api.github.com/repos/robertabbott/p2/tags","blobs_url":"https://api.github.com/repos/robertabbott/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robertabbott/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robertabbott/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/robertabbott/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robertabbott/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/robertabbott/p2/languages","stargazers_url":"https://api.github.com/repos/robertabbott/p2/stargazers","contributors_url":"https://api.github.com/repos/robertabbott/p2/contributors","subscribers_url":"https://api.github.com/repos/robertabbott/p2/subscribers","subscription_url":"https://api.github.com/repos/robertabbott/p2/subscription","commits_url":"https://api.github.com/repos/robertabbott/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/robertabbott/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/robertabbott/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/robertabbott/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/robertabbott/p2/contents/{+path}","compare_url":"https://api.github.com/repos/robertabbott/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robertabbott/p2/merges","archive_url":"https://api.github.com/repos/robertabbott/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robertabbott/p2/downloads","issues_url":"https://api.github.com/repos/robertabbott/p2/issues{/number}","pulls_url":"https://api.github.com/repos/robertabbott/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/robertabbott/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/robertabbott/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robertabbott/p2/labels{/name}","releases_url":"https://api.github.com/repos/robertabbott/p2/releases{/id}","created_at":"2015-06-24T18:21:15Z","updated_at":"2015-06-24T18:21:16Z","pushed_at":"2015-07-20T18:04:14Z","git_url":"git://github.com/robertabbott/p2.git","ssh_url":"git@github.com:robertabbott/p2.git","clone_url":"https://github.com/robertabbott/p2.git","svn_url":"https://github.com/robertabbott/p2","homepage":"","size":15729,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"square:master","ref":"master","sha":"3c687af603b9264b3989f239266a2e2656649d4b","user":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"repo":{"id":25320424,"name":"p2","full_name":"square/p2","owner":{"login":"square","id":82592,"avatar_url":"https://avatars.githubusercontent.com/u/82592?v=3","gravatar_id":"","url":"https://api.github.com/users/square","html_url":"https://github.com/square","followers_url":"https://api.github.com/users/square/followers","following_url":"https://api.github.com/users/square/following{/other_user}","gists_url":"https://api.github.com/users/square/gists{/gist_id}","starred_url":"https://api.github.com/users/square/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/square/subscriptions","organizations_url":"https://api.github.com/users/square/orgs","repos_url":"https://api.github.com/users/square/repos","events_url":"https://api.github.com/users/square/events{/privacy}","received_events_url":"https://api.github.com/users/square/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/square/p2","description":"Platypus Platform: Tools for Scalable Deployment","fork":false,"url":"https://api.github.com/repos/square/p2","forks_url":"https://api.github.com/repos/square/p2/forks","keys_url":"https://api.github.com/repos/square/p2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/square/p2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/square/p2/teams","hooks_url":"https://api.github.com/repos/square/p2/hooks","issue_events_url":"https://api.github.com/repos/square/p2/issues/events{/number}","events_url":"https://api.github.com/repos/square/p2/events","assignees_url":"https://api.github.com/repos/square/p2/assignees{/user}","branches_url":"https://api.github.com/repos/square/p2/branches{/branch}","tags_url":"https://api.github.com/repos/square/p2/tags","blobs_url":"https://api.github.com/repos/square/p2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/square/p2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/square/p2/git/refs{/sha}","trees_url":"https://api.github.com/repos/square/p2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/square/p2/statuses/{sha}","languages_url":"https://api.github.com/repos/square/p2/languages","stargazers_url":"https://api.github.com/repos/square/p2/stargazers","contributors_url":"https://api.github.com/repos/square/p2/contributors","subscribers_url":"https://api.github.com/repos/square/p2/subscribers","subscription_url":"https://api.github.com/repos/square/p2/subscription","commits_url":"https://api.github.com/repos/square/p2/commits{/sha}","git_commits_url":"https://api.github.com/repos/square/p2/git/commits{/sha}","comments_url":"https://api.github.com/repos/square/p2/comments{/number}","issue_comment_url":"https://api.github.com/repos/square/p2/issues/comments{/number}","contents_url":"https://api.github.com/repos/square/p2/contents/{+path}","compare_url":"https://api.github.com/repos/square/p2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/square/p2/merges","archive_url":"https://api.github.com/repos/square/p2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/square/p2/downloads","issues_url":"https://api.github.com/repos/square/p2/issues{/number}","pulls_url":"https://api.github.com/repos/square/p2/pulls{/number}","milestones_url":"https://api.github.com/repos/square/p2/milestones{/number}","notifications_url":"https://api.github.com/repos/square/p2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/square/p2/labels{/name}","releases_url":"https://api.github.com/repos/square/p2/releases{/id}","created_at":"2014-10-16T20:31:12Z","updated_at":"2015-07-14T03:21:00Z","pushed_at":"2015-07-20T18:07:53Z","git_url":"git://github.com/square/p2.git","ssh_url":"git@github.com:square/p2.git","clone_url":"https://github.com/square/p2.git","svn_url":"https://github.com/square/p2","homepage":"","size":17370,"stargazers_count":60,"watchers_count":60,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":2,"forks":12,"open_issues":2,"watchers":60,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/square/p2/pulls/198"},"html":{"href":"https://github.com/square/p2/pull/198"},"issue":{"href":"https://api.github.com/repos/square/p2/issues/198"},"comments":{"href":"https://api.github.com/repos/square/p2/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/square/p2/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/square/p2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/square/p2/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/square/p2/statuses/c6fb779d6cedd2c94eed9ad0a1b8eec98839bb19"}}}}