{"action":"created","comment":{"url":"https://api.github.com/repos/nasa/openmctweb/pulls/comments/42566964","id":42566964,"diff_hunk":"@@ -0,0 +1,34 @@\n+/*****************************************************************************\n+ * Open MCT Web, Copyright (c) 2014-2015, United States Government\n+ * as represented by the Administrator of the National Aeronautics and Space\n+ * Administration. All rights reserved.\n+ *\n+ * Open MCT Web is licensed under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License.\n+ * You may obtain a copy of the License at\n+ * http://www.apache.org/licenses/LICENSE-2.0.\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS, WITHOUT\n+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the\n+ * License for the specific language governing permissions and limitations\n+ * under the License.\n+ *\n+ * Open MCT Web includes source code licensed under additional open source\n+ * licenses. See the Open Source Licenses file (LICENSES.md) included with\n+ * this source code distribution or the Licensing information page available\n+ * at runtime from the About dialog for additional information.\n+ *****************************************************************************/\n+/*global define*/\n+\n+define(\n+    ['./MessageSeverity'],\n+    function (MessageSeverity) {\n+        \"use strict\";\n+\n+        function MessageController($scope) {","path":"platform/commonUI/notification/src/MessageController.js","position":29,"original_position":29,"commit_id":"f08725b6a27cacbe45f85d1282d16fbe0f0f4974","original_commit_id":"f08725b6a27cacbe45f85d1282d16fbe0f0f4974","user":{"login":"VWoeltjen","id":1685764,"avatar_url":"https://avatars.githubusercontent.com/u/1685764?v=3","gravatar_id":"","url":"https://api.github.com/users/VWoeltjen","html_url":"https://github.com/VWoeltjen","followers_url":"https://api.github.com/users/VWoeltjen/followers","following_url":"https://api.github.com/users/VWoeltjen/following{/other_user}","gists_url":"https://api.github.com/users/VWoeltjen/gists{/gist_id}","starred_url":"https://api.github.com/users/VWoeltjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VWoeltjen/subscriptions","organizations_url":"https://api.github.com/users/VWoeltjen/orgs","repos_url":"https://api.github.com/users/VWoeltjen/repos","events_url":"https://api.github.com/users/VWoeltjen/events{/privacy}","received_events_url":"https://api.github.com/users/VWoeltjen/received_events","type":"User","site_admin":false},"body":"Needs JSDoc","created_at":"2015-10-20T23:13:46Z","updated_at":"2015-10-20T23:13:46Z","html_url":"https://github.com/nasa/openmctweb/pull/186#discussion_r42566964","pull_request_url":"https://api.github.com/repos/nasa/openmctweb/pulls/186","_links":{"self":{"href":"https://api.github.com/repos/nasa/openmctweb/pulls/comments/42566964"},"html":{"href":"https://github.com/nasa/openmctweb/pull/186#discussion_r42566964"},"pull_request":{"href":"https://api.github.com/repos/nasa/openmctweb/pulls/186"}}},"pull_request":{"url":"https://api.github.com/repos/nasa/openmctweb/pulls/186","id":47720523,"html_url":"https://github.com/nasa/openmctweb/pull/186","diff_url":"https://github.com/nasa/openmctweb/pull/186.diff","patch_url":"https://github.com/nasa/openmctweb/pull/186.patch","issue_url":"https://api.github.com/repos/nasa/openmctweb/issues/186","number":186,"state":"open","locked":false,"title":"Open155","user":{"login":"akhenry","id":4215777,"avatar_url":"https://avatars.githubusercontent.com/u/4215777?v=3","gravatar_id":"","url":"https://api.github.com/users/akhenry","html_url":"https://github.com/akhenry","followers_url":"https://api.github.com/users/akhenry/followers","following_url":"https://api.github.com/users/akhenry/following{/other_user}","gists_url":"https://api.github.com/users/akhenry/gists{/gist_id}","starred_url":"https://api.github.com/users/akhenry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akhenry/subscriptions","organizations_url":"https://api.github.com/users/akhenry/orgs","repos_url":"https://api.github.com/users/akhenry/repos","events_url":"https://api.github.com/users/akhenry/events{/privacy}","received_events_url":"https://api.github.com/users/akhenry/received_events","type":"User","site_admin":false},"body":"I have pushed an initial testing version of the notifications and dialogs framework (see branch [open155](https://github.com/nasa/openmctweb/tree/open155) ). The push includes a 'testing' bundle that adds some indicators in the bottom of the application for launching dialogs and notifications of different types. This will of course be removed prior to merge.\r\n\r\nNo existing process have been modified to use the new notifications framework, or the new modal dialog type.\r\n\r\nBlocking dialogs are invoked by calling the showBlockingMessage function on DialogService. Banner notifications are invoked by using the notify function on the new NotificationService. Note that there is also a convenience function 'info' that calls notify with some defaults (such as auto-minimize) appropriate for purely informational messages.\r\n\r\nThere are a couple of outstanding issues that I haven't addressed yet, and might need some discussion -\r\n\r\n* Currently all messages are minimized to the notifications list instead of dismissed, including 'info' messages. It is probably desirable not to minimize 'info' level messages, but rather just dismiss them. This might require a little thought though, because you may want success type messages to be dismissible, but progress messages to be dismissible only once the underlying process has completed. You also probably don't want success messages cluttering up your notifications list. Or maybe you do, but you provide the ability to filter the displayed messages. Incidentally, 'progress' and 'severity' are considered separate properties, and you may have a progress message of any severity.\r\n* The framework does not yet support clicking text within messages. The simplest way of supporting this is to allow html to be included in message text. This potentially enables an exploit if the source of the message is not carefully considered by developers using it, so I'd like to leave it as an open issue for now until we can have some discussion about the best approach here.","created_at":"2015-10-14T21:58:26Z","updated_at":"2015-10-20T23:13:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"VWoeltjen","id":1685764,"avatar_url":"https://avatars.githubusercontent.com/u/1685764?v=3","gravatar_id":"","url":"https://api.github.com/users/VWoeltjen","html_url":"https://github.com/VWoeltjen","followers_url":"https://api.github.com/users/VWoeltjen/followers","following_url":"https://api.github.com/users/VWoeltjen/following{/other_user}","gists_url":"https://api.github.com/users/VWoeltjen/gists{/gist_id}","starred_url":"https://api.github.com/users/VWoeltjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VWoeltjen/subscriptions","organizations_url":"https://api.github.com/users/VWoeltjen/orgs","repos_url":"https://api.github.com/users/VWoeltjen/repos","events_url":"https://api.github.com/users/VWoeltjen/events{/privacy}","received_events_url":"https://api.github.com/users/VWoeltjen/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/nasa/openmctweb/milestones/3","html_url":"https://github.com/nasa/openmctweb/milestones/Ballard","labels_url":"https://api.github.com/repos/nasa/openmctweb/milestones/3/labels","id":1364443,"number":3,"title":"Ballard","description":"","creator":{"login":"VWoeltjen","id":1685764,"avatar_url":"https://avatars.githubusercontent.com/u/1685764?v=3","gravatar_id":"","url":"https://api.github.com/users/VWoeltjen","html_url":"https://github.com/VWoeltjen","followers_url":"https://api.github.com/users/VWoeltjen/followers","following_url":"https://api.github.com/users/VWoeltjen/following{/other_user}","gists_url":"https://api.github.com/users/VWoeltjen/gists{/gist_id}","starred_url":"https://api.github.com/users/VWoeltjen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VWoeltjen/subscriptions","organizations_url":"https://api.github.com/users/VWoeltjen/orgs","repos_url":"https://api.github.com/users/VWoeltjen/repos","events_url":"https://api.github.com/users/VWoeltjen/events{/privacy}","received_events_url":"https://api.github.com/users/VWoeltjen/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":1,"state":"open","created_at":"2015-10-19T17:19:20Z","updated_at":"2015-10-20T00:07:25Z","due_on":"2015-11-06T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/nasa/openmctweb/pulls/186/commits","review_comments_url":"https://api.github.com/repos/nasa/openmctweb/pulls/186/comments","review_comment_url":"https://api.github.com/repos/nasa/openmctweb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nasa/openmctweb/issues/186/comments","statuses_url":"https://api.github.com/repos/nasa/openmctweb/statuses/f08725b6a27cacbe45f85d1282d16fbe0f0f4974","head":{"label":"nasa:open155","ref":"open155","sha":"f08725b6a27cacbe45f85d1282d16fbe0f0f4974","user":{"login":"nasa","id":848102,"avatar_url":"https://avatars.githubusercontent.com/u/848102?v=3","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":36753839,"name":"openmctweb","full_name":"nasa/openmctweb","owner":{"login":"nasa","id":848102,"avatar_url":"https://avatars.githubusercontent.com/u/848102?v=3","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/openmctweb","description":"","fork":false,"url":"https://api.github.com/repos/nasa/openmctweb","forks_url":"https://api.github.com/repos/nasa/openmctweb/forks","keys_url":"https://api.github.com/repos/nasa/openmctweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/openmctweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/openmctweb/teams","hooks_url":"https://api.github.com/repos/nasa/openmctweb/hooks","issue_events_url":"https://api.github.com/repos/nasa/openmctweb/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/openmctweb/events","assignees_url":"https://api.github.com/repos/nasa/openmctweb/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/openmctweb/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/openmctweb/tags","blobs_url":"https://api.github.com/repos/nasa/openmctweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/openmctweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/openmctweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/openmctweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/openmctweb/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/openmctweb/languages","stargazers_url":"https://api.github.com/repos/nasa/openmctweb/stargazers","contributors_url":"https://api.github.com/repos/nasa/openmctweb/contributors","subscribers_url":"https://api.github.com/repos/nasa/openmctweb/subscribers","subscription_url":"https://api.github.com/repos/nasa/openmctweb/subscription","commits_url":"https://api.github.com/repos/nasa/openmctweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/openmctweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/openmctweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/openmctweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/openmctweb/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/openmctweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/openmctweb/merges","archive_url":"https://api.github.com/repos/nasa/openmctweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/openmctweb/downloads","issues_url":"https://api.github.com/repos/nasa/openmctweb/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/openmctweb/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/openmctweb/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/openmctweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/openmctweb/labels{/name}","releases_url":"https://api.github.com/repos/nasa/openmctweb/releases{/id}","created_at":"2015-06-02T18:40:28Z","updated_at":"2015-10-16T05:04:21Z","pushed_at":"2015-10-20T23:12:48Z","git_url":"git://github.com/nasa/openmctweb.git","ssh_url":"git@github.com:nasa/openmctweb.git","clone_url":"https://github.com/nasa/openmctweb.git","svn_url":"https://github.com/nasa/openmctweb","homepage":null,"size":10030,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":100,"forks":9,"open_issues":100,"watchers":24,"default_branch":"master"}},"base":{"label":"nasa:master","ref":"master","sha":"9cc0c0b06fcb8016ac9bbd6d21879af83df68361","user":{"login":"nasa","id":848102,"avatar_url":"https://avatars.githubusercontent.com/u/848102?v=3","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"repo":{"id":36753839,"name":"openmctweb","full_name":"nasa/openmctweb","owner":{"login":"nasa","id":848102,"avatar_url":"https://avatars.githubusercontent.com/u/848102?v=3","gravatar_id":"","url":"https://api.github.com/users/nasa","html_url":"https://github.com/nasa","followers_url":"https://api.github.com/users/nasa/followers","following_url":"https://api.github.com/users/nasa/following{/other_user}","gists_url":"https://api.github.com/users/nasa/gists{/gist_id}","starred_url":"https://api.github.com/users/nasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nasa/subscriptions","organizations_url":"https://api.github.com/users/nasa/orgs","repos_url":"https://api.github.com/users/nasa/repos","events_url":"https://api.github.com/users/nasa/events{/privacy}","received_events_url":"https://api.github.com/users/nasa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nasa/openmctweb","description":"","fork":false,"url":"https://api.github.com/repos/nasa/openmctweb","forks_url":"https://api.github.com/repos/nasa/openmctweb/forks","keys_url":"https://api.github.com/repos/nasa/openmctweb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nasa/openmctweb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nasa/openmctweb/teams","hooks_url":"https://api.github.com/repos/nasa/openmctweb/hooks","issue_events_url":"https://api.github.com/repos/nasa/openmctweb/issues/events{/number}","events_url":"https://api.github.com/repos/nasa/openmctweb/events","assignees_url":"https://api.github.com/repos/nasa/openmctweb/assignees{/user}","branches_url":"https://api.github.com/repos/nasa/openmctweb/branches{/branch}","tags_url":"https://api.github.com/repos/nasa/openmctweb/tags","blobs_url":"https://api.github.com/repos/nasa/openmctweb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nasa/openmctweb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nasa/openmctweb/git/refs{/sha}","trees_url":"https://api.github.com/repos/nasa/openmctweb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nasa/openmctweb/statuses/{sha}","languages_url":"https://api.github.com/repos/nasa/openmctweb/languages","stargazers_url":"https://api.github.com/repos/nasa/openmctweb/stargazers","contributors_url":"https://api.github.com/repos/nasa/openmctweb/contributors","subscribers_url":"https://api.github.com/repos/nasa/openmctweb/subscribers","subscription_url":"https://api.github.com/repos/nasa/openmctweb/subscription","commits_url":"https://api.github.com/repos/nasa/openmctweb/commits{/sha}","git_commits_url":"https://api.github.com/repos/nasa/openmctweb/git/commits{/sha}","comments_url":"https://api.github.com/repos/nasa/openmctweb/comments{/number}","issue_comment_url":"https://api.github.com/repos/nasa/openmctweb/issues/comments{/number}","contents_url":"https://api.github.com/repos/nasa/openmctweb/contents/{+path}","compare_url":"https://api.github.com/repos/nasa/openmctweb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nasa/openmctweb/merges","archive_url":"https://api.github.com/repos/nasa/openmctweb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nasa/openmctweb/downloads","issues_url":"https://api.github.com/repos/nasa/openmctweb/issues{/number}","pulls_url":"https://api.github.com/repos/nasa/openmctweb/pulls{/number}","milestones_url":"https://api.github.com/repos/nasa/openmctweb/milestones{/number}","notifications_url":"https://api.github.com/repos/nasa/openmctweb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nasa/openmctweb/labels{/name}","releases_url":"https://api.github.com/repos/nasa/openmctweb/releases{/id}","created_at":"2015-06-02T18:40:28Z","updated_at":"2015-10-16T05:04:21Z","pushed_at":"2015-10-20T23:12:48Z","git_url":"git://github.com/nasa/openmctweb.git","ssh_url":"git@github.com:nasa/openmctweb.git","clone_url":"https://github.com/nasa/openmctweb.git","svn_url":"https://github.com/nasa/openmctweb","homepage":null,"size":10030,"stargazers_count":24,"watchers_count":24,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":100,"forks":9,"open_issues":100,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nasa/openmctweb/pulls/186"},"html":{"href":"https://github.com/nasa/openmctweb/pull/186"},"issue":{"href":"https://api.github.com/repos/nasa/openmctweb/issues/186"},"comments":{"href":"https://api.github.com/repos/nasa/openmctweb/issues/186/comments"},"review_comments":{"href":"https://api.github.com/repos/nasa/openmctweb/pulls/186/comments"},"review_comment":{"href":"https://api.github.com/repos/nasa/openmctweb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nasa/openmctweb/pulls/186/commits"},"statuses":{"href":"https://api.github.com/repos/nasa/openmctweb/statuses/f08725b6a27cacbe45f85d1282d16fbe0f0f4974"}}}}