{"action":"created","comment":{"url":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments/29577207","id":29577207,"diff_hunk":"@@ -110,4 +110,15 @@ class RequiredTest < ActionView::TestCase\n     assert_no_select 'input[required]'\n     assert_select 'input.optional#validating_user_phone_number'\n   end\n+\n+  test 'builder input does not generate required html attribute when option is set to false when it is set to true in wrapper' do\n+    swap SimpleForm, browser_validations: true do\n+      swap_wrapper :default, self.custom_wrapper_with_required_input do\n+        with_concat_form_for(@user) do |f|\n+          concat f.input :name, required: false\n+        end\n+        assert_no_select 'input[type=text][required]'","path":"test/inputs/required_test.rb","position":11,"original_position":11,"commit_id":"5b92b4032f5a9291d8cfde65d2d01a0be8388f4e","original_commit_id":"5b92b4032f5a9291d8cfde65d2d01a0be8388f4e","user":{"login":"carlosantoniodasilva","id":26328,"avatar_url":"https://avatars.githubusercontent.com/u/26328?v=3","gravatar_id":"","url":"https://api.github.com/users/carlosantoniodasilva","html_url":"https://github.com/carlosantoniodasilva","followers_url":"https://api.github.com/users/carlosantoniodasilva/followers","following_url":"https://api.github.com/users/carlosantoniodasilva/following{/other_user}","gists_url":"https://api.github.com/users/carlosantoniodasilva/gists{/gist_id}","starred_url":"https://api.github.com/users/carlosantoniodasilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlosantoniodasilva/subscriptions","organizations_url":"https://api.github.com/users/carlosantoniodasilva/orgs","repos_url":"https://api.github.com/users/carlosantoniodasilva/repos","events_url":"https://api.github.com/users/carlosantoniodasilva/events{/privacy}","received_events_url":"https://api.github.com/users/carlosantoniodasilva/received_events","type":"User","site_admin":false},"body":"Should we check for `aria-required` as well?","created_at":"2015-05-04T10:53:59Z","updated_at":"2015-05-04T10:53:59Z","html_url":"https://github.com/plataformatec/simple_form/pull/1247#discussion_r29577207","pull_request_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247","_links":{"self":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments/29577207"},"html":{"href":"https://github.com/plataformatec/simple_form/pull/1247#discussion_r29577207"},"pull_request":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247"}}},"pull_request":{"url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247","id":34604123,"html_url":"https://github.com/plataformatec/simple_form/pull/1247","diff_url":"https://github.com/plataformatec/simple_form/pull/1247.diff","patch_url":"https://github.com/plataformatec/simple_form/pull/1247.patch","issue_url":"https://api.github.com/repos/plataformatec/simple_form/issues/1247","number":1247,"state":"open","locked":false,"title":"Make it possible to override required value that was set in the wrapper.","user":{"login":"nashby","id":200500,"avatar_url":"https://avatars.githubusercontent.com/u/200500?v=3","gravatar_id":"","url":"https://api.github.com/users/nashby","html_url":"https://github.com/nashby","followers_url":"https://api.github.com/users/nashby/followers","following_url":"https://api.github.com/users/nashby/following{/other_user}","gists_url":"https://api.github.com/users/nashby/gists{/gist_id}","starred_url":"https://api.github.com/users/nashby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashby/subscriptions","organizations_url":"https://api.github.com/users/nashby/orgs","repos_url":"https://api.github.com/users/nashby/repos","events_url":"https://api.github.com/users/nashby/events{/privacy}","received_events_url":"https://api.github.com/users/nashby/received_events","type":"User","site_admin":false},"body":"fixes #1178 \r\n\r\n@jedschneider hey, I fixed you test and added it to this pull request. ","created_at":"2015-05-03T17:05:38Z","updated_at":"2015-05-04T10:53:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30dddabb5a441b4ac0d3539d18be22c3db9d922c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247/commits","review_comments_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247/comments","review_comment_url":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments{/number}","comments_url":"https://api.github.com/repos/plataformatec/simple_form/issues/1247/comments","statuses_url":"https://api.github.com/repos/plataformatec/simple_form/statuses/5b92b4032f5a9291d8cfde65d2d01a0be8388f4e","head":{"label":"plataformatec:issue-1178","ref":"issue-1178","sha":"5b92b4032f5a9291d8cfde65d2d01a0be8388f4e","user":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars.githubusercontent.com/u/127679?v=3","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"repo":{"id":451035,"name":"simple_form","full_name":"plataformatec/simple_form","owner":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars.githubusercontent.com/u/127679?v=3","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plataformatec/simple_form","description":"Forms made easy for Rails! It's tied to a simple DSL, with no opinion on markup.","fork":false,"url":"https://api.github.com/repos/plataformatec/simple_form","forks_url":"https://api.github.com/repos/plataformatec/simple_form/forks","keys_url":"https://api.github.com/repos/plataformatec/simple_form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plataformatec/simple_form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plataformatec/simple_form/teams","hooks_url":"https://api.github.com/repos/plataformatec/simple_form/hooks","issue_events_url":"https://api.github.com/repos/plataformatec/simple_form/issues/events{/number}","events_url":"https://api.github.com/repos/plataformatec/simple_form/events","assignees_url":"https://api.github.com/repos/plataformatec/simple_form/assignees{/user}","branches_url":"https://api.github.com/repos/plataformatec/simple_form/branches{/branch}","tags_url":"https://api.github.com/repos/plataformatec/simple_form/tags","blobs_url":"https://api.github.com/repos/plataformatec/simple_form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plataformatec/simple_form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plataformatec/simple_form/git/refs{/sha}","trees_url":"https://api.github.com/repos/plataformatec/simple_form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plataformatec/simple_form/statuses/{sha}","languages_url":"https://api.github.com/repos/plataformatec/simple_form/languages","stargazers_url":"https://api.github.com/repos/plataformatec/simple_form/stargazers","contributors_url":"https://api.github.com/repos/plataformatec/simple_form/contributors","subscribers_url":"https://api.github.com/repos/plataformatec/simple_form/subscribers","subscription_url":"https://api.github.com/repos/plataformatec/simple_form/subscription","commits_url":"https://api.github.com/repos/plataformatec/simple_form/commits{/sha}","git_commits_url":"https://api.github.com/repos/plataformatec/simple_form/git/commits{/sha}","comments_url":"https://api.github.com/repos/plataformatec/simple_form/comments{/number}","issue_comment_url":"https://api.github.com/repos/plataformatec/simple_form/issues/comments{/number}","contents_url":"https://api.github.com/repos/plataformatec/simple_form/contents/{+path}","compare_url":"https://api.github.com/repos/plataformatec/simple_form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plataformatec/simple_form/merges","archive_url":"https://api.github.com/repos/plataformatec/simple_form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plataformatec/simple_form/downloads","issues_url":"https://api.github.com/repos/plataformatec/simple_form/issues{/number}","pulls_url":"https://api.github.com/repos/plataformatec/simple_form/pulls{/number}","milestones_url":"https://api.github.com/repos/plataformatec/simple_form/milestones{/number}","notifications_url":"https://api.github.com/repos/plataformatec/simple_form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plataformatec/simple_form/labels{/name}","releases_url":"https://api.github.com/repos/plataformatec/simple_form/releases{/id}","created_at":"2009-12-28T14:23:48Z","updated_at":"2015-05-04T06:03:26Z","pushed_at":"2015-05-03T17:05:38Z","git_url":"git://github.com/plataformatec/simple_form.git","ssh_url":"git@github.com:plataformatec/simple_form.git","clone_url":"https://github.com/plataformatec/simple_form.git","svn_url":"https://github.com/plataformatec/simple_form","homepage":"http://blog.plataformatec.com.br/tag/simple_form","size":6219,"stargazers_count":5218,"watchers_count":5218,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":835,"mirror_url":null,"open_issues_count":20,"forks":835,"open_issues":20,"watchers":5218,"default_branch":"master"}},"base":{"label":"plataformatec:master","ref":"master","sha":"b40777154864f6a5316b78be5c3209783681080b","user":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars.githubusercontent.com/u/127679?v=3","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"repo":{"id":451035,"name":"simple_form","full_name":"plataformatec/simple_form","owner":{"login":"plataformatec","id":127679,"avatar_url":"https://avatars.githubusercontent.com/u/127679?v=3","gravatar_id":"","url":"https://api.github.com/users/plataformatec","html_url":"https://github.com/plataformatec","followers_url":"https://api.github.com/users/plataformatec/followers","following_url":"https://api.github.com/users/plataformatec/following{/other_user}","gists_url":"https://api.github.com/users/plataformatec/gists{/gist_id}","starred_url":"https://api.github.com/users/plataformatec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plataformatec/subscriptions","organizations_url":"https://api.github.com/users/plataformatec/orgs","repos_url":"https://api.github.com/users/plataformatec/repos","events_url":"https://api.github.com/users/plataformatec/events{/privacy}","received_events_url":"https://api.github.com/users/plataformatec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/plataformatec/simple_form","description":"Forms made easy for Rails! It's tied to a simple DSL, with no opinion on markup.","fork":false,"url":"https://api.github.com/repos/plataformatec/simple_form","forks_url":"https://api.github.com/repos/plataformatec/simple_form/forks","keys_url":"https://api.github.com/repos/plataformatec/simple_form/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plataformatec/simple_form/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plataformatec/simple_form/teams","hooks_url":"https://api.github.com/repos/plataformatec/simple_form/hooks","issue_events_url":"https://api.github.com/repos/plataformatec/simple_form/issues/events{/number}","events_url":"https://api.github.com/repos/plataformatec/simple_form/events","assignees_url":"https://api.github.com/repos/plataformatec/simple_form/assignees{/user}","branches_url":"https://api.github.com/repos/plataformatec/simple_form/branches{/branch}","tags_url":"https://api.github.com/repos/plataformatec/simple_form/tags","blobs_url":"https://api.github.com/repos/plataformatec/simple_form/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plataformatec/simple_form/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plataformatec/simple_form/git/refs{/sha}","trees_url":"https://api.github.com/repos/plataformatec/simple_form/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plataformatec/simple_form/statuses/{sha}","languages_url":"https://api.github.com/repos/plataformatec/simple_form/languages","stargazers_url":"https://api.github.com/repos/plataformatec/simple_form/stargazers","contributors_url":"https://api.github.com/repos/plataformatec/simple_form/contributors","subscribers_url":"https://api.github.com/repos/plataformatec/simple_form/subscribers","subscription_url":"https://api.github.com/repos/plataformatec/simple_form/subscription","commits_url":"https://api.github.com/repos/plataformatec/simple_form/commits{/sha}","git_commits_url":"https://api.github.com/repos/plataformatec/simple_form/git/commits{/sha}","comments_url":"https://api.github.com/repos/plataformatec/simple_form/comments{/number}","issue_comment_url":"https://api.github.com/repos/plataformatec/simple_form/issues/comments{/number}","contents_url":"https://api.github.com/repos/plataformatec/simple_form/contents/{+path}","compare_url":"https://api.github.com/repos/plataformatec/simple_form/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plataformatec/simple_form/merges","archive_url":"https://api.github.com/repos/plataformatec/simple_form/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plataformatec/simple_form/downloads","issues_url":"https://api.github.com/repos/plataformatec/simple_form/issues{/number}","pulls_url":"https://api.github.com/repos/plataformatec/simple_form/pulls{/number}","milestones_url":"https://api.github.com/repos/plataformatec/simple_form/milestones{/number}","notifications_url":"https://api.github.com/repos/plataformatec/simple_form/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plataformatec/simple_form/labels{/name}","releases_url":"https://api.github.com/repos/plataformatec/simple_form/releases{/id}","created_at":"2009-12-28T14:23:48Z","updated_at":"2015-05-04T06:03:26Z","pushed_at":"2015-05-03T17:05:38Z","git_url":"git://github.com/plataformatec/simple_form.git","ssh_url":"git@github.com:plataformatec/simple_form.git","clone_url":"https://github.com/plataformatec/simple_form.git","svn_url":"https://github.com/plataformatec/simple_form","homepage":"http://blog.plataformatec.com.br/tag/simple_form","size":6219,"stargazers_count":5218,"watchers_count":5218,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":835,"mirror_url":null,"open_issues_count":20,"forks":835,"open_issues":20,"watchers":5218,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247"},"html":{"href":"https://github.com/plataformatec/simple_form/pull/1247"},"issue":{"href":"https://api.github.com/repos/plataformatec/simple_form/issues/1247"},"comments":{"href":"https://api.github.com/repos/plataformatec/simple_form/issues/1247/comments"},"review_comments":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247/comments"},"review_comment":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/plataformatec/simple_form/pulls/1247/commits"},"statuses":{"href":"https://api.github.com/repos/plataformatec/simple_form/statuses/5b92b4032f5a9291d8cfde65d2d01a0be8388f4e"}}}}