{"action":"created","issue":{"url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/issues/32","labels_url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/issues/32/comments","events_url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/issues/32/events","html_url":"https://github.com/Ericmas001/BluffinMuffin.Protocol/issues/32","id":106184938,"number":32,"title":"Possible bug with CheckCompatibilityCommand on v2.3.1","user":{"login":"mgermain","id":1077147,"avatar_url":"https://avatars.githubusercontent.com/u/1077147?v=3","gravatar_id":"","url":"https://api.github.com/users/mgermain","html_url":"https://github.com/mgermain","followers_url":"https://api.github.com/users/mgermain/followers","following_url":"https://api.github.com/users/mgermain/following{/other_user}","gists_url":"https://api.github.com/users/mgermain/gists{/gist_id}","starred_url":"https://api.github.com/users/mgermain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgermain/subscriptions","organizations_url":"https://api.github.com/users/mgermain/orgs","repos_url":"https://api.github.com/users/mgermain/repos","events_url":"https://api.github.com/users/mgermain/events{/privacy}","received_events_url":"https://api.github.com/users/mgermain/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/labels/invalid","name":"invalid","color":"e6e6e6"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-12T21:03:52Z","updated_at":"2015-09-13T13:58:26Z","closed_at":"2015-09-13T13:58:26Z","body":"In previous version using:`\r\n```\r\nproto.lobby.CheckCompatibilityCommand({\"ImplementedProtocolVersion\": proto.__version__}).encode()\r\n```\r\n\r\nWould output to following format:\r\n```\r\n'{\"CommandName\": \"CheckCompatibilityCommand\", \"ImplementedProtocolVersion\": \"2.2.0\"}'\r\n```\r\n\r\nBut now with 2.3.1 it outputs:\r\n```\r\n'{\"CommandName\": \"CheckCompatibilityCommand\", \"ImplementedProtocolVersion\": {\"ImplementedProtocolVersion\": \"2.3.1\"}}'\r\n```\r\n\r\nThe fact the the version is not a string anymore but a json render this command useless because it is now incompatible with olser version of the protocol.\r\n\r\nAlso it feels weird to repeat \"ImplementedProtocolVersion\" for no reason."},"comment":{"url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/issues/comments/139879058","html_url":"https://github.com/Ericmas001/BluffinMuffin.Protocol/issues/32#issuecomment-139879058","issue_url":"https://api.github.com/repos/Ericmas001/BluffinMuffin.Protocol/issues/32","id":139879058,"user":{"login":"Ericmas001","id":11448087,"avatar_url":"https://avatars.githubusercontent.com/u/11448087?v=3","gravatar_id":"","url":"https://api.github.com/users/Ericmas001","html_url":"https://github.com/Ericmas001","followers_url":"https://api.github.com/users/Ericmas001/followers","following_url":"https://api.github.com/users/Ericmas001/following{/other_user}","gists_url":"https://api.github.com/users/Ericmas001/gists{/gist_id}","starred_url":"https://api.github.com/users/Ericmas001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ericmas001/subscriptions","organizations_url":"https://api.github.com/users/Ericmas001/orgs","repos_url":"https://api.github.com/users/Ericmas001/repos","events_url":"https://api.github.com/users/Ericmas001/events{/privacy}","received_events_url":"https://api.github.com/users/Ericmas001/received_events","type":"User","site_admin":false},"created_at":"2015-09-13T13:58:26Z","updated_at":"2015-09-13T13:58:26Z","body":"since 2,3,1 in python using \r\n```\r\nproto.lobby.CheckCompatibilityCommand({\"ImplementedProtocolVersion\": proto.__version__}).encode()\r\n```\r\nis wrong. Constructor as changed.\r\n\r\nYou should simply use\r\n```\r\nproto.lobby.CheckCompatibilityCommand(proto.__version__).encode()\r\n```"}}