{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/47148955","id":47148955,"diff_hunk":"@@ -173,11 +173,23 @@ Client client = TransportClient.builder().settings(settings).build();\n \n Or using `elasticsearch.yml` file as shown in <<node-client>>\n \n-The client allows sniffing the rest of the cluster, which adds data nodes\n-into its list of machines to use. In this case, note that the IP addresses\n-used will be the ones that the other nodes were started with (the\n-\"publish\" address). In order to enable it, set the\n-`client.transport.sniff` to `true`:\n+The Transport client comes with a cluster sniffing feature which\n+allows it to dynamically add new hosts and remove old ones.\n+When sniffing is enabled the the transport client will connect to the nodes in its\n+internal node list, which is built via calls to addTransportAddres.","path":"docs/java-api/client.asciidoc","position":12,"original_position":12,"commit_id":"9e919658f4c1cba3cb0030a509742b8296659fc1","original_commit_id":"9e919658f4c1cba3cb0030a509742b8296659fc1","user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"body":"addTransportAdress","created_at":"2015-12-09T20:44:22Z","updated_at":"2015-12-09T20:44:22Z","html_url":"https://github.com/elastic/elasticsearch/pull/15204#discussion_r47148955","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/47148955"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/15204#discussion_r47148955"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204","id":52474238,"html_url":"https://github.com/elastic/elasticsearch/pull/15204","diff_url":"https://github.com/elastic/elasticsearch/pull/15204.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/15204.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15204","number":15204,"state":"open","locked":false,"title":"Improve / Fix Inaccurate Transport Sniffing Docs","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"body":"The current transport sniffing docs imply that sniffing only adds nodes to the current node list. After discussing this with @ywelsch and @polyfractal it appears that is incorrect, and that the node list is fully replaced with data nodes. This new documentation reflects that.\r\n\r\nI have yet to functionally verify that this works as described, but the [code](https://github.com/elastic/elasticsearch/blob/2.1/core/src/main/java/org/elasticsearch/client/transport/TransportClientNodesService.java#L483) @ywelsch linked me to seems to clearly replace the values.","created_at":"2015-12-03T00:09:24Z","updated_at":"2015-12-09T20:44:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fae3ceeb787a2e84bd40a7d0a07fbd99540a1936","assignee":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/15204/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/9e919658f4c1cba3cb0030a509742b8296659fc1","head":{"label":"andrewvc:fix-transport-sniffing-docs","ref":"fix-transport-sniffing-docs","sha":"9e919658f4c1cba3cb0030a509742b8296659fc1","user":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"repo":{"id":14243750,"name":"elasticsearch","full_name":"andrewvc/elasticsearch","owner":{"login":"andrewvc","id":131427,"avatar_url":"https://avatars.githubusercontent.com/u/131427?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewvc","html_url":"https://github.com/andrewvc","followers_url":"https://api.github.com/users/andrewvc/followers","following_url":"https://api.github.com/users/andrewvc/following{/other_user}","gists_url":"https://api.github.com/users/andrewvc/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewvc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewvc/subscriptions","organizations_url":"https://api.github.com/users/andrewvc/orgs","repos_url":"https://api.github.com/users/andrewvc/repos","events_url":"https://api.github.com/users/andrewvc/events{/privacy}","received_events_url":"https://api.github.com/users/andrewvc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andrewvc/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/andrewvc/elasticsearch","forks_url":"https://api.github.com/repos/andrewvc/elasticsearch/forks","keys_url":"https://api.github.com/repos/andrewvc/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andrewvc/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andrewvc/elasticsearch/teams","hooks_url":"https://api.github.com/repos/andrewvc/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/andrewvc/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/andrewvc/elasticsearch/events","assignees_url":"https://api.github.com/repos/andrewvc/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/andrewvc/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/andrewvc/elasticsearch/tags","blobs_url":"https://api.github.com/repos/andrewvc/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andrewvc/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andrewvc/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/andrewvc/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andrewvc/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/andrewvc/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/andrewvc/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/andrewvc/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/andrewvc/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/andrewvc/elasticsearch/subscription","commits_url":"https://api.github.com/repos/andrewvc/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/andrewvc/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/andrewvc/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/andrewvc/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/andrewvc/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/andrewvc/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andrewvc/elasticsearch/merges","archive_url":"https://api.github.com/repos/andrewvc/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andrewvc/elasticsearch/downloads","issues_url":"https://api.github.com/repos/andrewvc/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/andrewvc/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/andrewvc/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/andrewvc/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andrewvc/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/andrewvc/elasticsearch/releases{/id}","created_at":"2013-11-08T20:35:56Z","updated_at":"2015-01-29T05:38:24Z","pushed_at":"2015-12-03T22:59:17Z","git_url":"git://github.com/andrewvc/elasticsearch.git","ssh_url":"git@github.com:andrewvc/elasticsearch.git","clone_url":"https://github.com/andrewvc/elasticsearch.git","svn_url":"https://github.com/andrewvc/elasticsearch","homepage":"http://elasticsearch.org","size":151106,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"ab45d69b16561985152f60d601f44b3004b7ad66","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars.githubusercontent.com/u/6764390?v=3","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","created_at":"2010-02-08T13:20:56Z","updated_at":"2015-12-09T19:37:54Z","pushed_at":"2015-12-09T20:37:04Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":227404,"stargazers_count":13923,"watchers_count":13923,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4620,"mirror_url":null,"open_issues_count":1203,"forks":4620,"open_issues":1203,"watchers":13923,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/15204"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/15204"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/15204/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/15204/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/9e919658f4c1cba3cb0030a509742b8296659fc1"}}}}