{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/43415738","id":43415738,"diff_hunk":"@@ -107,7 +107,7 @@\n         dns_proposal.elements[\"dns-client\"] = [\"admin\"]\n         dns_proposal.elements[\"dns-server\"] = [\"admin\"]\n \n-        dns_service.stubs(:role_constraints).returns({ \"dns-client\" => { \"unique\" => true, \"admin\" => true } })\n+        allow(dns_service).to receive(:role_constraints).and_return({ \"dns-client\" => { \"unique\" => true, \"admin\" => true } })","path":"crowbar_framework/spec/models/service_object_spec.rb","position":41,"original_position":41,"commit_id":"56c5f2c47c6da3ec9db5a8e2aacb108b36a41d87","original_commit_id":"56c5f2c47c6da3ec9db5a8e2aacb108b36a41d87","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Metrics/LineLength: Line is too long. [126/100] (https://github.com/bbatsov/ruby-style-guide#80-character-limits)<br>Style/BracesAroundHashParameters: Redundant curly braces around a hash parameter.","created_at":"2015-10-29T17:18:37Z","updated_at":"2015-10-29T17:18:37Z","html_url":"https://github.com/crowbar/crowbar-core/pull/106#discussion_r43415738","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/43415738"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/106#discussion_r43415738"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106","id":49171386,"html_url":"https://github.com/crowbar/crowbar-core/pull/106","diff_url":"https://github.com/crowbar/crowbar-core/pull/106.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/106.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/106","number":106,"state":"open","locked":false,"title":"Replace mocha mocks with default rspec mocks","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"body":"Rspec has since version 3.0 a similar features and mocha isn't\r\nmaintained properly.","created_at":"2015-10-29T17:18:25Z","updated_at":"2015-10-29T17:18:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fa4d09438a4b21c73df6a2f326355c78c856e0a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/106/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/56c5f2c47c6da3ec9db5a8e2aacb108b36a41d87","head":{"label":"rsalevsky:mocha","ref":"mocha","sha":"56c5f2c47c6da3ec9db5a8e2aacb108b36a41d87","user":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"repo":{"id":40906953,"name":"crowbar-core","full_name":"rsalevsky/crowbar-core","owner":{"login":"rsalevsky","id":4128547,"avatar_url":"https://avatars.githubusercontent.com/u/4128547?v=3","gravatar_id":"","url":"https://api.github.com/users/rsalevsky","html_url":"https://github.com/rsalevsky","followers_url":"https://api.github.com/users/rsalevsky/followers","following_url":"https://api.github.com/users/rsalevsky/following{/other_user}","gists_url":"https://api.github.com/users/rsalevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/rsalevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsalevsky/subscriptions","organizations_url":"https://api.github.com/users/rsalevsky/orgs","repos_url":"https://api.github.com/users/rsalevsky/repos","events_url":"https://api.github.com/users/rsalevsky/events{/privacy}","received_events_url":"https://api.github.com/users/rsalevsky/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rsalevsky/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/rsalevsky/crowbar-core","forks_url":"https://api.github.com/repos/rsalevsky/crowbar-core/forks","keys_url":"https://api.github.com/repos/rsalevsky/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rsalevsky/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rsalevsky/crowbar-core/teams","hooks_url":"https://api.github.com/repos/rsalevsky/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/rsalevsky/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/rsalevsky/crowbar-core/events","assignees_url":"https://api.github.com/repos/rsalevsky/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/rsalevsky/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/rsalevsky/crowbar-core/tags","blobs_url":"https://api.github.com/repos/rsalevsky/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rsalevsky/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rsalevsky/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rsalevsky/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rsalevsky/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rsalevsky/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/rsalevsky/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/rsalevsky/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/rsalevsky/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/rsalevsky/crowbar-core/subscription","commits_url":"https://api.github.com/repos/rsalevsky/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rsalevsky/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rsalevsky/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rsalevsky/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rsalevsky/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/rsalevsky/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rsalevsky/crowbar-core/merges","archive_url":"https://api.github.com/repos/rsalevsky/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rsalevsky/crowbar-core/downloads","issues_url":"https://api.github.com/repos/rsalevsky/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/rsalevsky/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rsalevsky/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rsalevsky/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rsalevsky/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/rsalevsky/crowbar-core/releases{/id}","created_at":"2015-08-17T15:42:44Z","updated_at":"2015-08-17T15:42:46Z","pushed_at":"2015-10-29T17:17:35Z","git_url":"git://github.com/rsalevsky/crowbar-core.git","ssh_url":"git@github.com:rsalevsky/crowbar-core.git","clone_url":"https://github.com/rsalevsky/crowbar-core.git","svn_url":"https://github.com/rsalevsky/crowbar-core","homepage":null,"size":103696,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"4e23e3ea17a1f1d2e80aca656fb5af4d301f821f","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"name":"crowbar-core","full_name":"crowbar/crowbar-core","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","created_at":"2015-07-13T09:31:28Z","updated_at":"2015-10-25T22:11:24Z","pushed_at":"2015-10-29T17:18:26Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":119772,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":20,"forks":21,"open_issues":20,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/106"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/106"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/56c5f2c47c6da3ec9db5a8e2aacb108b36a41d87"}}}}