{"action":"created","comment":{"url":"https://api.github.com/repos/muyjohno/desperado/pulls/comments/39384591","id":39384591,"diff_hunk":"@@ -21,7 +19,15 @@ def row_for(player)\n     sorted_rows.each do |row|\n       return row if row.player == player\n     end\n-    nil\n+    Null::LeaderboardRow.new(player)\n+  end\n+\n+  def rows\n+    @rows ||= @rows_by_player.map do |_, row|\n+      row.tap do |row|","path":"app/models/leaderboard.rb","position":29,"original_position":29,"commit_id":"0b1b543a1c49e1326eae7b111dfcd0e7cd7f066a","original_commit_id":"0b1b543a1c49e1326eae7b111dfcd0e7cd7f066a","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Shadowing outer local variable - `row`.","created_at":"2015-09-14T11:45:05Z","updated_at":"2015-09-14T11:45:05Z","html_url":"https://github.com/muyjohno/desperado/pull/33#discussion_r39384591","pull_request_url":"https://api.github.com/repos/muyjohno/desperado/pulls/33","_links":{"self":{"href":"https://api.github.com/repos/muyjohno/desperado/pulls/comments/39384591"},"html":{"href":"https://github.com/muyjohno/desperado/pull/33#discussion_r39384591"},"pull_request":{"href":"https://api.github.com/repos/muyjohno/desperado/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/muyjohno/desperado/pulls/33","id":44920384,"html_url":"https://github.com/muyjohno/desperado/pull/33","diff_url":"https://github.com/muyjohno/desperado/pull/33.diff","patch_url":"https://github.com/muyjohno/desperado/pull/33.patch","issue_url":"https://api.github.com/repos/muyjohno/desperado/issues/33","number":33,"state":"open","locked":false,"title":"Add strength of schedule tiebreaker","user":{"login":"muyjohno","id":242952,"avatar_url":"https://avatars.githubusercontent.com/u/242952?v=3","gravatar_id":"","url":"https://api.github.com/users/muyjohno","html_url":"https://github.com/muyjohno","followers_url":"https://api.github.com/users/muyjohno/followers","following_url":"https://api.github.com/users/muyjohno/following{/other_user}","gists_url":"https://api.github.com/users/muyjohno/gists{/gist_id}","starred_url":"https://api.github.com/users/muyjohno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muyjohno/subscriptions","organizations_url":"https://api.github.com/users/muyjohno/orgs","repos_url":"https://api.github.com/users/muyjohno/repos","events_url":"https://api.github.com/users/muyjohno/events{/privacy}","received_events_url":"https://api.github.com/users/muyjohno/received_events","type":"User","site_admin":false},"body":"Includes major changes to tiebreaker to allow a ranker to gather their own metadata prior to comparisons.\r\n\r\nAlso added `Null::LeaderboardRow` and sample league data to be reused across many specs","created_at":"2015-09-14T11:44:57Z","updated_at":"2015-09-14T11:45:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fbf0d9067e3350181ab8b1c4824b289259cda2b0","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/muyjohno/desperado/pulls/33/commits","review_comments_url":"https://api.github.com/repos/muyjohno/desperado/pulls/33/comments","review_comment_url":"https://api.github.com/repos/muyjohno/desperado/pulls/comments{/number}","comments_url":"https://api.github.com/repos/muyjohno/desperado/issues/33/comments","statuses_url":"https://api.github.com/repos/muyjohno/desperado/statuses/0b1b543a1c49e1326eae7b111dfcd0e7cd7f066a","head":{"label":"muyjohno:strength_of_schedule","ref":"strength_of_schedule","sha":"0b1b543a1c49e1326eae7b111dfcd0e7cd7f066a","user":{"login":"muyjohno","id":242952,"avatar_url":"https://avatars.githubusercontent.com/u/242952?v=3","gravatar_id":"","url":"https://api.github.com/users/muyjohno","html_url":"https://github.com/muyjohno","followers_url":"https://api.github.com/users/muyjohno/followers","following_url":"https://api.github.com/users/muyjohno/following{/other_user}","gists_url":"https://api.github.com/users/muyjohno/gists{/gist_id}","starred_url":"https://api.github.com/users/muyjohno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muyjohno/subscriptions","organizations_url":"https://api.github.com/users/muyjohno/orgs","repos_url":"https://api.github.com/users/muyjohno/repos","events_url":"https://api.github.com/users/muyjohno/events{/privacy}","received_events_url":"https://api.github.com/users/muyjohno/received_events","type":"User","site_admin":false},"repo":{"id":37414533,"name":"desperado","full_name":"muyjohno/desperado","owner":{"login":"muyjohno","id":242952,"avatar_url":"https://avatars.githubusercontent.com/u/242952?v=3","gravatar_id":"","url":"https://api.github.com/users/muyjohno","html_url":"https://github.com/muyjohno","followers_url":"https://api.github.com/users/muyjohno/followers","following_url":"https://api.github.com/users/muyjohno/following{/other_user}","gists_url":"https://api.github.com/users/muyjohno/gists{/gist_id}","starred_url":"https://api.github.com/users/muyjohno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muyjohno/subscriptions","organizations_url":"https://api.github.com/users/muyjohno/orgs","repos_url":"https://api.github.com/users/muyjohno/repos","events_url":"https://api.github.com/users/muyjohno/events{/privacy}","received_events_url":"https://api.github.com/users/muyjohno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muyjohno/desperado","description":"A league framework for Android: Netrunner running in Ruby on Rails","fork":false,"url":"https://api.github.com/repos/muyjohno/desperado","forks_url":"https://api.github.com/repos/muyjohno/desperado/forks","keys_url":"https://api.github.com/repos/muyjohno/desperado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muyjohno/desperado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muyjohno/desperado/teams","hooks_url":"https://api.github.com/repos/muyjohno/desperado/hooks","issue_events_url":"https://api.github.com/repos/muyjohno/desperado/issues/events{/number}","events_url":"https://api.github.com/repos/muyjohno/desperado/events","assignees_url":"https://api.github.com/repos/muyjohno/desperado/assignees{/user}","branches_url":"https://api.github.com/repos/muyjohno/desperado/branches{/branch}","tags_url":"https://api.github.com/repos/muyjohno/desperado/tags","blobs_url":"https://api.github.com/repos/muyjohno/desperado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muyjohno/desperado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muyjohno/desperado/git/refs{/sha}","trees_url":"https://api.github.com/repos/muyjohno/desperado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muyjohno/desperado/statuses/{sha}","languages_url":"https://api.github.com/repos/muyjohno/desperado/languages","stargazers_url":"https://api.github.com/repos/muyjohno/desperado/stargazers","contributors_url":"https://api.github.com/repos/muyjohno/desperado/contributors","subscribers_url":"https://api.github.com/repos/muyjohno/desperado/subscribers","subscription_url":"https://api.github.com/repos/muyjohno/desperado/subscription","commits_url":"https://api.github.com/repos/muyjohno/desperado/commits{/sha}","git_commits_url":"https://api.github.com/repos/muyjohno/desperado/git/commits{/sha}","comments_url":"https://api.github.com/repos/muyjohno/desperado/comments{/number}","issue_comment_url":"https://api.github.com/repos/muyjohno/desperado/issues/comments{/number}","contents_url":"https://api.github.com/repos/muyjohno/desperado/contents/{+path}","compare_url":"https://api.github.com/repos/muyjohno/desperado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muyjohno/desperado/merges","archive_url":"https://api.github.com/repos/muyjohno/desperado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muyjohno/desperado/downloads","issues_url":"https://api.github.com/repos/muyjohno/desperado/issues{/number}","pulls_url":"https://api.github.com/repos/muyjohno/desperado/pulls{/number}","milestones_url":"https://api.github.com/repos/muyjohno/desperado/milestones{/number}","notifications_url":"https://api.github.com/repos/muyjohno/desperado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muyjohno/desperado/labels{/name}","releases_url":"https://api.github.com/repos/muyjohno/desperado/releases{/id}","created_at":"2015-06-14T14:04:59Z","updated_at":"2015-07-04T09:09:32Z","pushed_at":"2015-09-14T11:44:59Z","git_url":"git://github.com/muyjohno/desperado.git","ssh_url":"git@github.com:muyjohno/desperado.git","clone_url":"https://github.com/muyjohno/desperado.git","svn_url":"https://github.com/muyjohno/desperado","homepage":"","size":437,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"muyjohno:master","ref":"master","sha":"5c8b66dddb31da559b4785379a6a0e4b178d3c90","user":{"login":"muyjohno","id":242952,"avatar_url":"https://avatars.githubusercontent.com/u/242952?v=3","gravatar_id":"","url":"https://api.github.com/users/muyjohno","html_url":"https://github.com/muyjohno","followers_url":"https://api.github.com/users/muyjohno/followers","following_url":"https://api.github.com/users/muyjohno/following{/other_user}","gists_url":"https://api.github.com/users/muyjohno/gists{/gist_id}","starred_url":"https://api.github.com/users/muyjohno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muyjohno/subscriptions","organizations_url":"https://api.github.com/users/muyjohno/orgs","repos_url":"https://api.github.com/users/muyjohno/repos","events_url":"https://api.github.com/users/muyjohno/events{/privacy}","received_events_url":"https://api.github.com/users/muyjohno/received_events","type":"User","site_admin":false},"repo":{"id":37414533,"name":"desperado","full_name":"muyjohno/desperado","owner":{"login":"muyjohno","id":242952,"avatar_url":"https://avatars.githubusercontent.com/u/242952?v=3","gravatar_id":"","url":"https://api.github.com/users/muyjohno","html_url":"https://github.com/muyjohno","followers_url":"https://api.github.com/users/muyjohno/followers","following_url":"https://api.github.com/users/muyjohno/following{/other_user}","gists_url":"https://api.github.com/users/muyjohno/gists{/gist_id}","starred_url":"https://api.github.com/users/muyjohno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muyjohno/subscriptions","organizations_url":"https://api.github.com/users/muyjohno/orgs","repos_url":"https://api.github.com/users/muyjohno/repos","events_url":"https://api.github.com/users/muyjohno/events{/privacy}","received_events_url":"https://api.github.com/users/muyjohno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/muyjohno/desperado","description":"A league framework for Android: Netrunner running in Ruby on Rails","fork":false,"url":"https://api.github.com/repos/muyjohno/desperado","forks_url":"https://api.github.com/repos/muyjohno/desperado/forks","keys_url":"https://api.github.com/repos/muyjohno/desperado/keys{/key_id}","collaborators_url":"https://api.github.com/repos/muyjohno/desperado/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/muyjohno/desperado/teams","hooks_url":"https://api.github.com/repos/muyjohno/desperado/hooks","issue_events_url":"https://api.github.com/repos/muyjohno/desperado/issues/events{/number}","events_url":"https://api.github.com/repos/muyjohno/desperado/events","assignees_url":"https://api.github.com/repos/muyjohno/desperado/assignees{/user}","branches_url":"https://api.github.com/repos/muyjohno/desperado/branches{/branch}","tags_url":"https://api.github.com/repos/muyjohno/desperado/tags","blobs_url":"https://api.github.com/repos/muyjohno/desperado/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/muyjohno/desperado/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/muyjohno/desperado/git/refs{/sha}","trees_url":"https://api.github.com/repos/muyjohno/desperado/git/trees{/sha}","statuses_url":"https://api.github.com/repos/muyjohno/desperado/statuses/{sha}","languages_url":"https://api.github.com/repos/muyjohno/desperado/languages","stargazers_url":"https://api.github.com/repos/muyjohno/desperado/stargazers","contributors_url":"https://api.github.com/repos/muyjohno/desperado/contributors","subscribers_url":"https://api.github.com/repos/muyjohno/desperado/subscribers","subscription_url":"https://api.github.com/repos/muyjohno/desperado/subscription","commits_url":"https://api.github.com/repos/muyjohno/desperado/commits{/sha}","git_commits_url":"https://api.github.com/repos/muyjohno/desperado/git/commits{/sha}","comments_url":"https://api.github.com/repos/muyjohno/desperado/comments{/number}","issue_comment_url":"https://api.github.com/repos/muyjohno/desperado/issues/comments{/number}","contents_url":"https://api.github.com/repos/muyjohno/desperado/contents/{+path}","compare_url":"https://api.github.com/repos/muyjohno/desperado/compare/{base}...{head}","merges_url":"https://api.github.com/repos/muyjohno/desperado/merges","archive_url":"https://api.github.com/repos/muyjohno/desperado/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/muyjohno/desperado/downloads","issues_url":"https://api.github.com/repos/muyjohno/desperado/issues{/number}","pulls_url":"https://api.github.com/repos/muyjohno/desperado/pulls{/number}","milestones_url":"https://api.github.com/repos/muyjohno/desperado/milestones{/number}","notifications_url":"https://api.github.com/repos/muyjohno/desperado/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/muyjohno/desperado/labels{/name}","releases_url":"https://api.github.com/repos/muyjohno/desperado/releases{/id}","created_at":"2015-06-14T14:04:59Z","updated_at":"2015-07-04T09:09:32Z","pushed_at":"2015-09-14T11:44:59Z","git_url":"git://github.com/muyjohno/desperado.git","ssh_url":"git@github.com:muyjohno/desperado.git","clone_url":"https://github.com/muyjohno/desperado.git","svn_url":"https://github.com/muyjohno/desperado","homepage":"","size":437,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/muyjohno/desperado/pulls/33"},"html":{"href":"https://github.com/muyjohno/desperado/pull/33"},"issue":{"href":"https://api.github.com/repos/muyjohno/desperado/issues/33"},"comments":{"href":"https://api.github.com/repos/muyjohno/desperado/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/muyjohno/desperado/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/muyjohno/desperado/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/muyjohno/desperado/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/muyjohno/desperado/statuses/0b1b543a1c49e1326eae7b111dfcd0e7cd7f066a"}}}}