{"action":"created","issue":{"url":"https://api.github.com/repos/umd-mith/mith-research-explorer/issues/20","labels_url":"https://api.github.com/repos/umd-mith/mith-research-explorer/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/umd-mith/mith-research-explorer/issues/20/comments","events_url":"https://api.github.com/repos/umd-mith/mith-research-explorer/issues/20/events","html_url":"https://github.com/umd-mith/mith-research-explorer/issues/20","id":119744181,"number":20,"title":"Problem with underscore import","user":{"login":"trevormunoz","id":351120,"avatar_url":"https://avatars.githubusercontent.com/u/351120?v=3","gravatar_id":"","url":"https://api.github.com/users/trevormunoz","html_url":"https://github.com/trevormunoz","followers_url":"https://api.github.com/users/trevormunoz/followers","following_url":"https://api.github.com/users/trevormunoz/following{/other_user}","gists_url":"https://api.github.com/users/trevormunoz/gists{/gist_id}","starred_url":"https://api.github.com/users/trevormunoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevormunoz/subscriptions","organizations_url":"https://api.github.com/users/trevormunoz/orgs","repos_url":"https://api.github.com/users/trevormunoz/repos","events_url":"https://api.github.com/users/trevormunoz/events{/privacy}","received_events_url":"https://api.github.com/users/trevormunoz/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/umd-mith/mith-research-explorer/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":{"login":"raffazizzi","id":144770,"avatar_url":"https://avatars.githubusercontent.com/u/144770?v=3","gravatar_id":"","url":"https://api.github.com/users/raffazizzi","html_url":"https://github.com/raffazizzi","followers_url":"https://api.github.com/users/raffazizzi/followers","following_url":"https://api.github.com/users/raffazizzi/following{/other_user}","gists_url":"https://api.github.com/users/raffazizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/raffazizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffazizzi/subscriptions","organizations_url":"https://api.github.com/users/raffazizzi/orgs","repos_url":"https://api.github.com/users/raffazizzi/repos","events_url":"https://api.github.com/users/raffazizzi/events{/privacy}","received_events_url":"https://api.github.com/users/raffazizzi/received_events","type":"User","site_admin":false},"milestone":null,"comments":1,"created_at":"2015-12-01T15:45:32Z","updated_at":"2015-12-01T16:23:39Z","closed_at":null,"body":"1. Checked out the new branch `issues-round-1`\r\n2. Ran `npm install`\r\n3. Ran `gulp run`\r\n\r\nGot the following error:\r\n\r\n```\r\n3.4.3 in mith-research-explorer/ on issues-round-1\r\n› gulp run\r\n[10:36:49] Using gulpfile ~/Code/mith-research-explorer/gulpfile.js\r\n[10:36:49] Starting 'webserver'...\r\n[10:36:49] Finished 'webserver' after 11 ms\r\n[10:36:49] Starting 'build:es6'...\r\n[10:36:49] Starting 'watch'...\r\n[10:36:49] Finished 'watch' after 27 ms\r\n[10:36:49] Server started http://localhost:8888\r\n[10:36:49] LiveReload started on port 35729\r\n[10:36:51] Error : Cannot find module 'backbone/node_modules/underscore' from '/Users/umd-laptop/Code/mith-research-explorer/src/js/views'\r\n[10:36:51] Finished 'build:es6' after 1.59 s\r\n[10:36:51] Starting 'run'...\r\n[10:36:51] Finished 'run' after 4.16 μs\r\n```\r\n\r\nThe problem is that underscore import we talked about :)\r\n\r\nThe backbone directory installed by npm looks like:\r\n\r\n```\r\nnode_modules/backbone\r\n├── README.md\r\n├── backbone-min.js\r\n├── backbone-min.map\r\n├── backbone.js\r\n└── package.json\r\n\r\n0 directories, 5 files\r\n```\r\n\r\nObviously there is no set of node_modules dependencies there. But there is an underscore install:\r\n\r\n```\r\nnode_modules/underscore\r\n├── LICENSE\r\n├── README.md\r\n├── package.json\r\n├── underscore-min.js\r\n├── underscore-min.map\r\n└── underscore.js\r\n\r\n0 directories, 6 files\r\n```\r\n\r\nSo it seems like it might make the install more reliable to just declare the underscore dependency explicitly in package.json even though it also gets installed for backbone."},"comment":{"url":"https://api.github.com/repos/umd-mith/mith-research-explorer/issues/comments/161020721","html_url":"https://github.com/umd-mith/mith-research-explorer/issues/20#issuecomment-161020721","issue_url":"https://api.github.com/repos/umd-mith/mith-research-explorer/issues/20","id":161020721,"user":{"login":"raffazizzi","id":144770,"avatar_url":"https://avatars.githubusercontent.com/u/144770?v=3","gravatar_id":"","url":"https://api.github.com/users/raffazizzi","html_url":"https://github.com/raffazizzi","followers_url":"https://api.github.com/users/raffazizzi/followers","following_url":"https://api.github.com/users/raffazizzi/following{/other_user}","gists_url":"https://api.github.com/users/raffazizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/raffazizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffazizzi/subscriptions","organizations_url":"https://api.github.com/users/raffazizzi/orgs","repos_url":"https://api.github.com/users/raffazizzi/repos","events_url":"https://api.github.com/users/raffazizzi/events{/privacy}","received_events_url":"https://api.github.com/users/raffazizzi/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T16:23:39Z","updated_at":"2015-12-01T16:23:39Z","body":"*sigh*"}}