{"action":"created","comment":{"url":"https://api.github.com/repos/ellismg/coreclr/pulls/comments/38320731","id":38320731,"diff_hunk":"@@ -31,9 +47,259 @@ enum LocaleNumberData : int32_t\n \n /*\n Function:\n+NormalizePattern\n+\n+Returns a numeric string pattern in a format that we can match against the appropriate managed pattern.\n+*/\n+UnicodeString* NormalizePattern(const UnicodeString *srcPattern, UnicodeString *destPattern, bool isNegative)","path":"src/corefx/System.Globalization.Native/localeNumberData.cpp","position":36,"original_position":36,"commit_id":"2d20a9eacdb8dd76408e237ab52d39ecdb71333a","original_commit_id":"2d20a9eacdb8dd76408e237ab52d39ecdb71333a","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"No it's not required in this case. I followed the coding patterns present in ICU that takes a string by ref and then outputs that same string for callers that want to easily chain methods. (http://userguide.icu-project.org/strings - Maximizing Performance with the UnicodeString Storage Model)","created_at":"2015-08-31T15:04:19Z","updated_at":"2015-08-31T15:04:19Z","html_url":"https://github.com/ellismg/coreclr/pull/3#discussion_r38320731","pull_request_url":"https://api.github.com/repos/ellismg/coreclr/pulls/3","_links":{"self":{"href":"https://api.github.com/repos/ellismg/coreclr/pulls/comments/38320731"},"html":{"href":"https://github.com/ellismg/coreclr/pull/3#discussion_r38320731"},"pull_request":{"href":"https://api.github.com/repos/ellismg/coreclr/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/ellismg/coreclr/pulls/3","id":43551094,"html_url":"https://github.com/ellismg/coreclr/pull/3","diff_url":"https://github.com/ellismg/coreclr/pull/3.diff","patch_url":"https://github.com/ellismg/coreclr/pull/3.patch","issue_url":"https://api.github.com/repos/ellismg/coreclr/issues/3","number":3,"state":"open","locked":false,"title":"Add number formatting to CultureData","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-27T18:35:06Z","updated_at":"2015-08-31T15:04:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe00c27a43834521794dc5d28db7fb1a2824ada7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ellismg/coreclr/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ellismg/coreclr/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ellismg/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ellismg/coreclr/issues/3/comments","statuses_url":"https://api.github.com/repos/ellismg/coreclr/statuses/2d20a9eacdb8dd76408e237ab52d39ecdb71333a","head":{"label":"steveharter:cultureinfo2","ref":"cultureinfo2","sha":"2d20a9eacdb8dd76408e237ab52d39ecdb71333a","user":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"repo":{"id":39029163,"name":"dotnet_coreclr","full_name":"steveharter/dotnet_coreclr","owner":{"login":"steveharter","id":6986755,"avatar_url":"https://avatars.githubusercontent.com/u/6986755?v=3","gravatar_id":"","url":"https://api.github.com/users/steveharter","html_url":"https://github.com/steveharter","followers_url":"https://api.github.com/users/steveharter/followers","following_url":"https://api.github.com/users/steveharter/following{/other_user}","gists_url":"https://api.github.com/users/steveharter/gists{/gist_id}","starred_url":"https://api.github.com/users/steveharter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveharter/subscriptions","organizations_url":"https://api.github.com/users/steveharter/orgs","repos_url":"https://api.github.com/users/steveharter/repos","events_url":"https://api.github.com/users/steveharter/events{/privacy}","received_events_url":"https://api.github.com/users/steveharter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/steveharter/dotnet_coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/steveharter/dotnet_coreclr","forks_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/forks","keys_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/teams","hooks_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/hooks","issue_events_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/events","assignees_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/tags","blobs_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/languages","stargazers_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/stargazers","contributors_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/contributors","subscribers_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/subscribers","subscription_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/subscription","commits_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/merges","archive_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/downloads","issues_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/labels{/name}","releases_url":"https://api.github.com/repos/steveharter/dotnet_coreclr/releases{/id}","created_at":"2015-07-13T18:14:59Z","updated_at":"2015-07-22T16:28:37Z","pushed_at":"2015-08-27T18:32:56Z","git_url":"git://github.com/steveharter/dotnet_coreclr.git","ssh_url":"git@github.com:steveharter/dotnet_coreclr.git","clone_url":"https://github.com/steveharter/dotnet_coreclr.git","svn_url":"https://github.com/steveharter/dotnet_coreclr","homepage":"http://dotnet.github.io/core/","size":36394,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ellismg:icu-normalization-casing-idna","ref":"icu-normalization-casing-idna","sha":"4dfa3899f29504554ab63d160172a7b02f723161","user":{"login":"ellismg","id":9602953,"avatar_url":"https://avatars.githubusercontent.com/u/9602953?v=3","gravatar_id":"","url":"https://api.github.com/users/ellismg","html_url":"https://github.com/ellismg","followers_url":"https://api.github.com/users/ellismg/followers","following_url":"https://api.github.com/users/ellismg/following{/other_user}","gists_url":"https://api.github.com/users/ellismg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellismg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellismg/subscriptions","organizations_url":"https://api.github.com/users/ellismg/orgs","repos_url":"https://api.github.com/users/ellismg/repos","events_url":"https://api.github.com/users/ellismg/events{/privacy}","received_events_url":"https://api.github.com/users/ellismg/received_events","type":"User","site_admin":false},"repo":{"id":30256626,"name":"coreclr","full_name":"ellismg/coreclr","owner":{"login":"ellismg","id":9602953,"avatar_url":"https://avatars.githubusercontent.com/u/9602953?v=3","gravatar_id":"","url":"https://api.github.com/users/ellismg","html_url":"https://github.com/ellismg","followers_url":"https://api.github.com/users/ellismg/followers","following_url":"https://api.github.com/users/ellismg/following{/other_user}","gists_url":"https://api.github.com/users/ellismg/gists{/gist_id}","starred_url":"https://api.github.com/users/ellismg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellismg/subscriptions","organizations_url":"https://api.github.com/users/ellismg/orgs","repos_url":"https://api.github.com/users/ellismg/repos","events_url":"https://api.github.com/users/ellismg/events{/privacy}","received_events_url":"https://api.github.com/users/ellismg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ellismg/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR. It is an execution engine for .NET apps, performing functions such as IL byte code loading, compilation to machine code and garbage collection. The repo contains the complete up-to-date CoreCLR codebase.","fork":true,"url":"https://api.github.com/repos/ellismg/coreclr","forks_url":"https://api.github.com/repos/ellismg/coreclr/forks","keys_url":"https://api.github.com/repos/ellismg/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ellismg/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ellismg/coreclr/teams","hooks_url":"https://api.github.com/repos/ellismg/coreclr/hooks","issue_events_url":"https://api.github.com/repos/ellismg/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/ellismg/coreclr/events","assignees_url":"https://api.github.com/repos/ellismg/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/ellismg/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/ellismg/coreclr/tags","blobs_url":"https://api.github.com/repos/ellismg/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ellismg/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ellismg/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ellismg/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ellismg/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/ellismg/coreclr/languages","stargazers_url":"https://api.github.com/repos/ellismg/coreclr/stargazers","contributors_url":"https://api.github.com/repos/ellismg/coreclr/contributors","subscribers_url":"https://api.github.com/repos/ellismg/coreclr/subscribers","subscription_url":"https://api.github.com/repos/ellismg/coreclr/subscription","commits_url":"https://api.github.com/repos/ellismg/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ellismg/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ellismg/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ellismg/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ellismg/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/ellismg/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ellismg/coreclr/merges","archive_url":"https://api.github.com/repos/ellismg/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ellismg/coreclr/downloads","issues_url":"https://api.github.com/repos/ellismg/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/ellismg/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/ellismg/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/ellismg/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ellismg/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/ellismg/coreclr/releases{/id}","created_at":"2015-02-03T18:00:05Z","updated_at":"2015-06-17T05:45:44Z","pushed_at":"2015-08-28T21:25:18Z","git_url":"git://github.com/ellismg/coreclr.git","ssh_url":"git@github.com:ellismg/coreclr.git","clone_url":"https://github.com/ellismg/coreclr.git","svn_url":"https://github.com/ellismg/coreclr","homepage":"","size":36690,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ellismg/coreclr/pulls/3"},"html":{"href":"https://github.com/ellismg/coreclr/pull/3"},"issue":{"href":"https://api.github.com/repos/ellismg/coreclr/issues/3"},"comments":{"href":"https://api.github.com/repos/ellismg/coreclr/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ellismg/coreclr/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ellismg/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ellismg/coreclr/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ellismg/coreclr/statuses/2d20a9eacdb8dd76408e237ab52d39ecdb71333a"}}}}