{"action":"closed","number":38,"pull_request":{"url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/38","id":38508156,"html_url":"https://github.com/AutomatedTester/browsermob-proxy-py/pull/38","diff_url":"https://github.com/AutomatedTester/browsermob-proxy-py/pull/38.diff","patch_url":"https://github.com/AutomatedTester/browsermob-proxy-py/pull/38.patch","issue_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues/38","number":38,"state":"closed","locked":false,"title":"fix broken test (test_new_page_defaults)","user":{"login":"aerickson","id":47889,"avatar_url":"https://avatars.githubusercontent.com/u/47889?v=3","gravatar_id":"","url":"https://api.github.com/users/aerickson","html_url":"https://github.com/aerickson","followers_url":"https://api.github.com/users/aerickson/followers","following_url":"https://api.github.com/users/aerickson/following{/other_user}","gists_url":"https://api.github.com/users/aerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/aerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerickson/subscriptions","organizations_url":"https://api.github.com/users/aerickson/orgs","repos_url":"https://api.github.com/users/aerickson/repos","events_url":"https://api.github.com/users/aerickson/events{/privacy}","received_events_url":"https://api.github.com/users/aerickson/received_events","type":"User","site_admin":false},"body":"I'm not very familiar with the HAR stuff, but it seems like browsermob creates pages starting at 0 now (vs 1)?\r\n\r\n```\r\nEX10346:~/git/browsermob-proxy-py (add_test_directions) > py.test test/test_client.py --pdb\r\n====================================================================== test session starts =======================================================================\r\nplatform darwin -- Python 2.7.9 -- py-1.4.29 -- pytest-2.7.2\r\nrootdir: /Users/aje/code/browsermob-proxy-py, inifile: \r\ncollected 1 items \r\n\r\ntest/test_client.py F\r\n>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> traceback >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>\r\n\r\nself = <test_client.TestClient object at 0x10efd6cd0>\r\n\r\n    def test_new_page_defaults(self):\r\n        \"\"\"\r\n            /proxy/:port/pageRef\r\n            adds a new page of 'Page N' when no page name is given\r\n            \"\"\"\r\n        # import ipdb; ipdb.set_trace()\r\n        self.client.new_har()\r\n        self.client.new_page()\r\n        har = self.client.har\r\n        assert(len(har[\"log\"][\"pages\"]) == 2)\r\n>       assert(har[\"log\"][\"pages\"][1][\"id\"] == \"Page 2\")\r\nE       assert 'Page 1' == 'Page 2'\r\nE         - Page 1\r\nE         ?      ^\r\nE         + Page 2\r\nE         ?      ^\r\n\r\ntest/test_client.py:68: AssertionError\r\n>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>> entering PDB >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>\r\n> /Users/aje/code/browsermob-proxy-py/test/test_client.py(68)test_new_page_defaults()\r\n-> assert(har[\"log\"][\"pages\"][1][\"id\"] == \"Page 2\")\r\n(Pdb) har\r\n{u'log': {u'comment': u'', u'entries': [], u'version': u'1.2', u'pages': [{u'pageTimings': {u'comment': u''}, u'comment': u'', u'title': u'Page 0', u'id': u'Page 0', u'startedDateTime': u'2015-06-24T19:48:57.130-07:00'}, {u'pageTimings': {u'comment': u''}, u'comment': u'', u'title': u'Page 1', u'id': u'Page 1', u'startedDateTime': u'2015-06-24T19:48:57.132-07:00'}], u'creator': {u'comment': u'', u'version': u'2.1.0-beta-1-legacy', u'name': u'BrowserMob Proxy'}}}\r\n(Pdb) \r\n```","created_at":"2015-06-25T03:03:25Z","updated_at":"2015-06-25T16:13:02Z","closed_at":"2015-06-25T16:13:02Z","merged_at":null,"merge_commit_sha":"981fa711bec335b268389e05aabd02a1160123b6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/38/commits","review_comments_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/38/comments","review_comment_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues/38/comments","statuses_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/statuses/40487187a33cb8930fea4821de4a50bdb52bedec","head":{"label":"aerickson:fix_broken_test","ref":"fix_broken_test","sha":"40487187a33cb8930fea4821de4a50bdb52bedec","user":{"login":"aerickson","id":47889,"avatar_url":"https://avatars.githubusercontent.com/u/47889?v=3","gravatar_id":"","url":"https://api.github.com/users/aerickson","html_url":"https://github.com/aerickson","followers_url":"https://api.github.com/users/aerickson/followers","following_url":"https://api.github.com/users/aerickson/following{/other_user}","gists_url":"https://api.github.com/users/aerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/aerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerickson/subscriptions","organizations_url":"https://api.github.com/users/aerickson/orgs","repos_url":"https://api.github.com/users/aerickson/repos","events_url":"https://api.github.com/users/aerickson/events{/privacy}","received_events_url":"https://api.github.com/users/aerickson/received_events","type":"User","site_admin":false},"repo":{"id":38022959,"name":"browsermob-proxy-py","full_name":"aerickson/browsermob-proxy-py","owner":{"login":"aerickson","id":47889,"avatar_url":"https://avatars.githubusercontent.com/u/47889?v=3","gravatar_id":"","url":"https://api.github.com/users/aerickson","html_url":"https://github.com/aerickson","followers_url":"https://api.github.com/users/aerickson/followers","following_url":"https://api.github.com/users/aerickson/following{/other_user}","gists_url":"https://api.github.com/users/aerickson/gists{/gist_id}","starred_url":"https://api.github.com/users/aerickson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerickson/subscriptions","organizations_url":"https://api.github.com/users/aerickson/orgs","repos_url":"https://api.github.com/users/aerickson/repos","events_url":"https://api.github.com/users/aerickson/events{/privacy}","received_events_url":"https://api.github.com/users/aerickson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aerickson/browsermob-proxy-py","description":"A python wrapper for Browsermob Proxy","fork":true,"url":"https://api.github.com/repos/aerickson/browsermob-proxy-py","forks_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/forks","keys_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/teams","hooks_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/hooks","issue_events_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/issues/events{/number}","events_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/events","assignees_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/assignees{/user}","branches_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/branches{/branch}","tags_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/tags","blobs_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/statuses/{sha}","languages_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/languages","stargazers_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/stargazers","contributors_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/contributors","subscribers_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/subscribers","subscription_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/subscription","commits_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/contents/{+path}","compare_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/merges","archive_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/downloads","issues_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/issues{/number}","pulls_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/pulls{/number}","milestones_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/milestones{/number}","notifications_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/labels{/name}","releases_url":"https://api.github.com/repos/aerickson/browsermob-proxy-py/releases{/id}","created_at":"2015-06-25T02:22:19Z","updated_at":"2015-06-25T02:22:20Z","pushed_at":"2015-06-25T03:01:55Z","git_url":"git://github.com/aerickson/browsermob-proxy-py.git","ssh_url":"git@github.com:aerickson/browsermob-proxy-py.git","clone_url":"https://github.com/aerickson/browsermob-proxy-py.git","svn_url":"https://github.com/aerickson/browsermob-proxy-py","homepage":"http://oss.theautomatedtester.co.uk/browsermob-proxy-py","size":695,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AutomatedTester:master","ref":"master","sha":"e37fe53e548f36e510eaae3e1eeb300ee37e7374","user":{"login":"AutomatedTester","id":128518,"avatar_url":"https://avatars.githubusercontent.com/u/128518?v=3","gravatar_id":"","url":"https://api.github.com/users/AutomatedTester","html_url":"https://github.com/AutomatedTester","followers_url":"https://api.github.com/users/AutomatedTester/followers","following_url":"https://api.github.com/users/AutomatedTester/following{/other_user}","gists_url":"https://api.github.com/users/AutomatedTester/gists{/gist_id}","starred_url":"https://api.github.com/users/AutomatedTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutomatedTester/subscriptions","organizations_url":"https://api.github.com/users/AutomatedTester/orgs","repos_url":"https://api.github.com/users/AutomatedTester/repos","events_url":"https://api.github.com/users/AutomatedTester/events{/privacy}","received_events_url":"https://api.github.com/users/AutomatedTester/received_events","type":"User","site_admin":false},"repo":{"id":2562699,"name":"browsermob-proxy-py","full_name":"AutomatedTester/browsermob-proxy-py","owner":{"login":"AutomatedTester","id":128518,"avatar_url":"https://avatars.githubusercontent.com/u/128518?v=3","gravatar_id":"","url":"https://api.github.com/users/AutomatedTester","html_url":"https://github.com/AutomatedTester","followers_url":"https://api.github.com/users/AutomatedTester/followers","following_url":"https://api.github.com/users/AutomatedTester/following{/other_user}","gists_url":"https://api.github.com/users/AutomatedTester/gists{/gist_id}","starred_url":"https://api.github.com/users/AutomatedTester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AutomatedTester/subscriptions","organizations_url":"https://api.github.com/users/AutomatedTester/orgs","repos_url":"https://api.github.com/users/AutomatedTester/repos","events_url":"https://api.github.com/users/AutomatedTester/events{/privacy}","received_events_url":"https://api.github.com/users/AutomatedTester/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AutomatedTester/browsermob-proxy-py","description":"A python wrapper for Browsermob Proxy","fork":false,"url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py","forks_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/forks","keys_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/teams","hooks_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/hooks","issue_events_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues/events{/number}","events_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/events","assignees_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/assignees{/user}","branches_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/branches{/branch}","tags_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/tags","blobs_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/statuses/{sha}","languages_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/languages","stargazers_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/stargazers","contributors_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/contributors","subscribers_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/subscribers","subscription_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/subscription","commits_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/contents/{+path}","compare_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/merges","archive_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/downloads","issues_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues{/number}","pulls_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls{/number}","milestones_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/milestones{/number}","notifications_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/labels{/name}","releases_url":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/releases{/id}","created_at":"2011-10-12T14:01:01Z","updated_at":"2015-06-04T23:12:48Z","pushed_at":"2015-06-25T04:28:01Z","git_url":"git://github.com/AutomatedTester/browsermob-proxy-py.git","ssh_url":"git@github.com:AutomatedTester/browsermob-proxy-py.git","clone_url":"https://github.com/AutomatedTester/browsermob-proxy-py.git","svn_url":"https://github.com/AutomatedTester/browsermob-proxy-py","homepage":"http://oss.theautomatedtester.co.uk/browsermob-proxy-py","size":695,"stargazers_count":44,"watchers_count":44,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":26,"mirror_url":null,"open_issues_count":10,"forks":26,"open_issues":10,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/38"},"html":{"href":"https://github.com/AutomatedTester/browsermob-proxy-py/pull/38"},"issue":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues/38"},"comments":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/AutomatedTester/browsermob-proxy-py/statuses/40487187a33cb8930fea4821de4a50bdb52bedec"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}