{"action":"created","issue":{"url":"https://api.github.com/repos/GPII/gpii-handlebars/issues/3","labels_url":"https://api.github.com/repos/GPII/gpii-handlebars/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/GPII/gpii-handlebars/issues/3/comments","events_url":"https://api.github.com/repos/GPII/gpii-handlebars/issues/3/events","html_url":"https://github.com/GPII/gpii-handlebars/pull/3","id":67620834,"number":3,"title":"Added \"equals\" helper and greatly improved tests...","user":{"login":"the-t-in-rtf","id":5765222,"avatar_url":"https://avatars.githubusercontent.com/u/5765222?v=3","gravatar_id":"","url":"https://api.github.com/users/the-t-in-rtf","html_url":"https://github.com/the-t-in-rtf","followers_url":"https://api.github.com/users/the-t-in-rtf/followers","following_url":"https://api.github.com/users/the-t-in-rtf/following{/other_user}","gists_url":"https://api.github.com/users/the-t-in-rtf/gists{/gist_id}","starred_url":"https://api.github.com/users/the-t-in-rtf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-t-in-rtf/subscriptions","organizations_url":"https://api.github.com/users/the-t-in-rtf/orgs","repos_url":"https://api.github.com/users/the-t-in-rtf/repos","events_url":"https://api.github.com/users/the-t-in-rtf/events{/privacy}","received_events_url":"https://api.github.com/users/the-t-in-rtf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"amb26","id":561418,"avatar_url":"https://avatars.githubusercontent.com/u/561418?v=3","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-04-10T15:30:48Z","updated_at":"2015-05-18T15:47:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/GPII/gpii-handlebars/pulls/3","html_url":"https://github.com/GPII/gpii-handlebars/pull/3","diff_url":"https://github.com/GPII/gpii-handlebars/pull/3.diff","patch_url":"https://github.com/GPII/gpii-handlebars/pull/3.patch"},"body":"I needed a bit more conditional formatting than handlebars' {{#if}} blocks can reasonably support without having to pollute the data model with display variables (shouldDisplayThis, etc.).  To assist with this, I created an \"equals\" helper that tests the equality of two items (which can be either variables or literal strings).  You can see the feature request here:\r\n\r\nhttp://issues.gpii.net/browse/CTR-176\r\n\r\nAs part of doing this, I had to refactor the tests.  Previously, they ran client side and only reported that all had passed or failed.  I converted these to tests that run within node rather than within zombie, so that all failures are clear from the console, CI reports, etc.\r\n\r\nI also ended up fixing the server-side jsonify test, which had been disabled because it broke when we prettified the output of the jsonify helper."},"comment":{"url":"https://api.github.com/repos/GPII/gpii-handlebars/issues/comments/103109729","html_url":"https://github.com/GPII/gpii-handlebars/pull/3#issuecomment-103109729","issue_url":"https://api.github.com/repos/GPII/gpii-handlebars/issues/3","id":103109729,"user":{"login":"amb26","id":561418,"avatar_url":"https://avatars.githubusercontent.com/u/561418?v=3","gravatar_id":"","url":"https://api.github.com/users/amb26","html_url":"https://github.com/amb26","followers_url":"https://api.github.com/users/amb26/followers","following_url":"https://api.github.com/users/amb26/following{/other_user}","gists_url":"https://api.github.com/users/amb26/gists{/gist_id}","starred_url":"https://api.github.com/users/amb26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amb26/subscriptions","organizations_url":"https://api.github.com/users/amb26/orgs","repos_url":"https://api.github.com/users/amb26/repos","events_url":"https://api.github.com/users/amb26/events{/privacy}","received_events_url":"https://api.github.com/users/amb26/received_events","type":"User","site_admin":false},"created_at":"2015-05-18T15:47:29Z","updated_at":"2015-05-18T15:47:29Z","body":"Ok - the test failure cause is very simple - I had not run \"bower install\". In retrospect this should have been obvious from the failure from \"http://localhost:6994/bc/handlebars/handlebars.js\" which depends only on the static content being present."}}