{"action":"created","comment":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/29939522","id":29939522,"diff_hunk":"@@ -239,8 +239,8 @@ sub returnRadiusAccessAccept {\n     try {\n \n         $logger->debug(\"[$mac] network device (\".$self->{'_id'}.\") supports roles. Evaluating role to be returned\");\n-        my $roleResolver = pf::roles::custom->instance();\n-        my $role = $roleResolver->getRoleForNode($mac, $self);\n+        my $role = $self->getRoleByName($user_role);\n+\n \n         # Roles are configured and the user should have one\n         if (defined($role)) {","path":"lib/pf/Switch/AeroHIVE.pm","position":10,"original_position":10,"commit_id":"83d03651509c2df230c4ba5557d1fc15e32185d6","original_commit_id":"83d03651509c2df230c4ba5557d1fc15e32185d6","user":{"login":"fdurand","id":1553962,"avatar_url":"https://avatars.githubusercontent.com/u/1553962?v=3","gravatar_id":"","url":"https://api.github.com/users/fdurand","html_url":"https://github.com/fdurand","followers_url":"https://api.github.com/users/fdurand/followers","following_url":"https://api.github.com/users/fdurand/following{/other_user}","gists_url":"https://api.github.com/users/fdurand/gists{/gist_id}","starred_url":"https://api.github.com/users/fdurand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdurand/subscriptions","organizations_url":"https://api.github.com/users/fdurand/orgs","repos_url":"https://api.github.com/users/fdurand/repos","events_url":"https://api.github.com/users/fdurand/events{/privacy}","received_events_url":"https://api.github.com/users/fdurand/received_events","type":"User","site_admin":false},"body":"if (defined($role)  && isenabled($this->{_RoleMap})) {\r\n\r\n....\r\n\r\nif (isenabled($this->{_VlanMap})) {","created_at":"2015-05-08T13:34:40Z","updated_at":"2015-05-08T13:34:40Z","html_url":"https://github.com/inverse-inc/packetfence/pull/534#discussion_r29939522","pull_request_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534","_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments/29939522"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/534#discussion_r29939522"},"pull_request":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534"}}},"pull_request":{"url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534","id":35008494,"html_url":"https://github.com/inverse-inc/packetfence/pull/534","diff_url":"https://github.com/inverse-inc/packetfence/pull/534.diff","patch_url":"https://github.com/inverse-inc/packetfence/pull/534.patch","issue_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/534","number":534,"state":"open","locked":false,"title":"Corrected how a role is determined.","user":{"login":"erSitzt","id":1625376,"avatar_url":"https://avatars.githubusercontent.com/u/1625376?v=3","gravatar_id":"","url":"https://api.github.com/users/erSitzt","html_url":"https://github.com/erSitzt","followers_url":"https://api.github.com/users/erSitzt/followers","following_url":"https://api.github.com/users/erSitzt/following{/other_user}","gists_url":"https://api.github.com/users/erSitzt/gists{/gist_id}","starred_url":"https://api.github.com/users/erSitzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erSitzt/subscriptions","organizations_url":"https://api.github.com/users/erSitzt/orgs","repos_url":"https://api.github.com/users/erSitzt/repos","events_url":"https://api.github.com/users/erSitzt/events{/privacy}","received_events_url":"https://api.github.com/users/erSitzt/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-05-08T13:29:01Z","updated_at":"2015-05-08T13:34:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f401504558db21f47f80935323391e00513669f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534/commits","review_comments_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534/comments","review_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/534/comments","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/83d03651509c2df230c4ba5557d1fc15e32185d6","head":{"label":"erSitzt:devel","ref":"devel","sha":"83d03651509c2df230c4ba5557d1fc15e32185d6","user":{"login":"erSitzt","id":1625376,"avatar_url":"https://avatars.githubusercontent.com/u/1625376?v=3","gravatar_id":"","url":"https://api.github.com/users/erSitzt","html_url":"https://github.com/erSitzt","followers_url":"https://api.github.com/users/erSitzt/followers","following_url":"https://api.github.com/users/erSitzt/following{/other_user}","gists_url":"https://api.github.com/users/erSitzt/gists{/gist_id}","starred_url":"https://api.github.com/users/erSitzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erSitzt/subscriptions","organizations_url":"https://api.github.com/users/erSitzt/orgs","repos_url":"https://api.github.com/users/erSitzt/repos","events_url":"https://api.github.com/users/erSitzt/events{/privacy}","received_events_url":"https://api.github.com/users/erSitzt/received_events","type":"User","site_admin":false},"repo":{"id":26499789,"name":"packetfence","full_name":"erSitzt/packetfence","owner":{"login":"erSitzt","id":1625376,"avatar_url":"https://avatars.githubusercontent.com/u/1625376?v=3","gravatar_id":"","url":"https://api.github.com/users/erSitzt","html_url":"https://github.com/erSitzt","followers_url":"https://api.github.com/users/erSitzt/followers","following_url":"https://api.github.com/users/erSitzt/following{/other_user}","gists_url":"https://api.github.com/users/erSitzt/gists{/gist_id}","starred_url":"https://api.github.com/users/erSitzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erSitzt/subscriptions","organizations_url":"https://api.github.com/users/erSitzt/orgs","repos_url":"https://api.github.com/users/erSitzt/repos","events_url":"https://api.github.com/users/erSitzt/events{/privacy}","received_events_url":"https://api.github.com/users/erSitzt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/erSitzt/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":true,"url":"https://api.github.com/repos/erSitzt/packetfence","forks_url":"https://api.github.com/repos/erSitzt/packetfence/forks","keys_url":"https://api.github.com/repos/erSitzt/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/erSitzt/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/erSitzt/packetfence/teams","hooks_url":"https://api.github.com/repos/erSitzt/packetfence/hooks","issue_events_url":"https://api.github.com/repos/erSitzt/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/erSitzt/packetfence/events","assignees_url":"https://api.github.com/repos/erSitzt/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/erSitzt/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/erSitzt/packetfence/tags","blobs_url":"https://api.github.com/repos/erSitzt/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/erSitzt/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/erSitzt/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/erSitzt/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/erSitzt/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/erSitzt/packetfence/languages","stargazers_url":"https://api.github.com/repos/erSitzt/packetfence/stargazers","contributors_url":"https://api.github.com/repos/erSitzt/packetfence/contributors","subscribers_url":"https://api.github.com/repos/erSitzt/packetfence/subscribers","subscription_url":"https://api.github.com/repos/erSitzt/packetfence/subscription","commits_url":"https://api.github.com/repos/erSitzt/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/erSitzt/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/erSitzt/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/erSitzt/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/erSitzt/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/erSitzt/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/erSitzt/packetfence/merges","archive_url":"https://api.github.com/repos/erSitzt/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/erSitzt/packetfence/downloads","issues_url":"https://api.github.com/repos/erSitzt/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/erSitzt/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/erSitzt/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/erSitzt/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/erSitzt/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/erSitzt/packetfence/releases{/id}","created_at":"2014-11-11T19:08:16Z","updated_at":"2015-02-02T13:43:11Z","pushed_at":"2015-05-08T13:27:38Z","git_url":"git://github.com/erSitzt/packetfence.git","ssh_url":"git@github.com:erSitzt/packetfence.git","clone_url":"https://github.com/erSitzt/packetfence.git","svn_url":"https://github.com/erSitzt/packetfence","homepage":"http://www.packetfence.org","size":85683,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"inverse-inc:devel","ref":"devel","sha":"c3251c571217ca9f4a35265b29393f72523bf951","user":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"repo":{"id":3595658,"name":"packetfence","full_name":"inverse-inc/packetfence","owner":{"login":"inverse-inc","id":1203154,"avatar_url":"https://avatars.githubusercontent.com/u/1203154?v=3","gravatar_id":"","url":"https://api.github.com/users/inverse-inc","html_url":"https://github.com/inverse-inc","followers_url":"https://api.github.com/users/inverse-inc/followers","following_url":"https://api.github.com/users/inverse-inc/following{/other_user}","gists_url":"https://api.github.com/users/inverse-inc/gists{/gist_id}","starred_url":"https://api.github.com/users/inverse-inc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inverse-inc/subscriptions","organizations_url":"https://api.github.com/users/inverse-inc/orgs","repos_url":"https://api.github.com/users/inverse-inc/repos","events_url":"https://api.github.com/users/inverse-inc/events{/privacy}","received_events_url":"https://api.github.com/users/inverse-inc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inverse-inc/packetfence","description":"PacketFence is a fully supported, trusted, Free and Open Source network access control (NAC) solution. Boasting an impressive feature set including a captive-portal for registration and remediation, centralized wired and wireless management, powerful guest management options, 802.1X support, layer-2 isolation of problematic devices; PacketFence can be used to effectively secure networks small to very large heterogeneous networks.","fork":false,"url":"https://api.github.com/repos/inverse-inc/packetfence","forks_url":"https://api.github.com/repos/inverse-inc/packetfence/forks","keys_url":"https://api.github.com/repos/inverse-inc/packetfence/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inverse-inc/packetfence/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inverse-inc/packetfence/teams","hooks_url":"https://api.github.com/repos/inverse-inc/packetfence/hooks","issue_events_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/events{/number}","events_url":"https://api.github.com/repos/inverse-inc/packetfence/events","assignees_url":"https://api.github.com/repos/inverse-inc/packetfence/assignees{/user}","branches_url":"https://api.github.com/repos/inverse-inc/packetfence/branches{/branch}","tags_url":"https://api.github.com/repos/inverse-inc/packetfence/tags","blobs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inverse-inc/packetfence/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inverse-inc/packetfence/git/refs{/sha}","trees_url":"https://api.github.com/repos/inverse-inc/packetfence/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inverse-inc/packetfence/statuses/{sha}","languages_url":"https://api.github.com/repos/inverse-inc/packetfence/languages","stargazers_url":"https://api.github.com/repos/inverse-inc/packetfence/stargazers","contributors_url":"https://api.github.com/repos/inverse-inc/packetfence/contributors","subscribers_url":"https://api.github.com/repos/inverse-inc/packetfence/subscribers","subscription_url":"https://api.github.com/repos/inverse-inc/packetfence/subscription","commits_url":"https://api.github.com/repos/inverse-inc/packetfence/commits{/sha}","git_commits_url":"https://api.github.com/repos/inverse-inc/packetfence/git/commits{/sha}","comments_url":"https://api.github.com/repos/inverse-inc/packetfence/comments{/number}","issue_comment_url":"https://api.github.com/repos/inverse-inc/packetfence/issues/comments{/number}","contents_url":"https://api.github.com/repos/inverse-inc/packetfence/contents/{+path}","compare_url":"https://api.github.com/repos/inverse-inc/packetfence/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inverse-inc/packetfence/merges","archive_url":"https://api.github.com/repos/inverse-inc/packetfence/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inverse-inc/packetfence/downloads","issues_url":"https://api.github.com/repos/inverse-inc/packetfence/issues{/number}","pulls_url":"https://api.github.com/repos/inverse-inc/packetfence/pulls{/number}","milestones_url":"https://api.github.com/repos/inverse-inc/packetfence/milestones{/number}","notifications_url":"https://api.github.com/repos/inverse-inc/packetfence/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inverse-inc/packetfence/labels{/name}","releases_url":"https://api.github.com/repos/inverse-inc/packetfence/releases{/id}","created_at":"2012-03-01T20:21:13Z","updated_at":"2015-05-08T13:05:09Z","pushed_at":"2015-05-08T13:29:01Z","git_url":"git://github.com/inverse-inc/packetfence.git","ssh_url":"git@github.com:inverse-inc/packetfence.git","clone_url":"https://github.com/inverse-inc/packetfence.git","svn_url":"https://github.com/inverse-inc/packetfence","homepage":"http://www.packetfence.org","size":139832,"stargazers_count":114,"watchers_count":114,"language":"Perl","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":65,"forks":60,"open_issues":65,"watchers":114,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534"},"html":{"href":"https://github.com/inverse-inc/packetfence/pull/534"},"issue":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/534"},"comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/issues/534/comments"},"review_comments":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534/comments"},"review_comment":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inverse-inc/packetfence/pulls/534/commits"},"statuses":{"href":"https://api.github.com/repos/inverse-inc/packetfence/statuses/83d03651509c2df230c4ba5557d1fc15e32185d6"}}}}