{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular.js/issues/12870","labels_url":"https://api.github.com/repos/angular/angular.js/issues/12870/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular.js/issues/12870/comments","events_url":"https://api.github.com/repos/angular/angular.js/issues/12870/events","html_url":"https://github.com/angular/angular.js/issues/12870","id":106839014,"number":12870,"title":"currency filter on negative value not in parentheses - AngularJS 1.3 to 1.4 regression","user":{"login":"wbeange","id":1535452,"avatar_url":"https://avatars.githubusercontent.com/u/1535452?v=3","gravatar_id":"","url":"https://api.github.com/users/wbeange","html_url":"https://github.com/wbeange","followers_url":"https://api.github.com/users/wbeange/followers","following_url":"https://api.github.com/users/wbeange/following{/other_user}","gists_url":"https://api.github.com/users/wbeange/gists{/gist_id}","starred_url":"https://api.github.com/users/wbeange/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbeange/subscriptions","organizations_url":"https://api.github.com/users/wbeange/orgs","repos_url":"https://api.github.com/users/wbeange/repos","events_url":"https://api.github.com/users/wbeange/events{/privacy}","received_events_url":"https://api.github.com/users/wbeange/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/angular/angular.js/labels/component:%20filters","name":"component: filters","color":"bfdadc"},{"url":"https://api.github.com/repos/angular/angular.js/labels/needs:%20investigation","name":"needs: investigation","color":"444444"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/angular/angular.js/milestones/35","html_url":"https://github.com/angular/angular.js/milestones/Purgatory","labels_url":"https://api.github.com/repos/angular/angular.js/milestones/35/labels","id":526241,"number":35,"title":"Purgatory","description":"This milestone is for issues and PRs that weren't accepted yet and we are waiting for more info from the submitter.\r\n\r\nFor issues this typically means that we weren't able to reproduce the issue or we haven't decided yet if a feature request is a good idea at all.\r\n\r\nFor PRs this means that the PR still needs a lot of work and we might not even be interested in merging it because it looks like a non-core feature. We are still waiting for more discussion within the team or more info from the contributor before making the final decision.","creator":{"login":"IgorMinar","id":216296,"avatar_url":"https://avatars.githubusercontent.com/u/216296?v=3","gravatar_id":"","url":"https://api.github.com/users/IgorMinar","html_url":"https://github.com/IgorMinar","followers_url":"https://api.github.com/users/IgorMinar/followers","following_url":"https://api.github.com/users/IgorMinar/following{/other_user}","gists_url":"https://api.github.com/users/IgorMinar/gists{/gist_id}","starred_url":"https://api.github.com/users/IgorMinar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IgorMinar/subscriptions","organizations_url":"https://api.github.com/users/IgorMinar/orgs","repos_url":"https://api.github.com/users/IgorMinar/repos","events_url":"https://api.github.com/users/IgorMinar/events{/privacy}","received_events_url":"https://api.github.com/users/IgorMinar/received_events","type":"User","site_admin":false},"open_issues":127,"closed_issues":471,"state":"open","created_at":"2014-01-04T01:20:50Z","updated_at":"2015-09-17T11:03:48Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2015-09-16T18:57:36Z","updated_at":"2015-09-18T12:28:01Z","closed_at":null,"body":"The currency filter now formats negative numbers with a negative sign, where it previously wrapped the negative number in brackets.\r\n\r\nAngularJS 1.3 currency filter:\r\n`$scope.filteredNumber = $filter('currency')(\"-4.962016\");` results in `($4.96)`\r\nhttp://plnkr.co/edit/iEkkjw?p=preview\r\n\r\nAngularJS 1.4 currency filter:\r\n`$scope.filteredNumber = $filter('currency')(\"-4.962016\");` results in `-$4.96`\r\nhttp://plnkr.co/edit/3dwKuIHTk9tzGOdZ7Xly?p=preview"},"comment":{"url":"https://api.github.com/repos/angular/angular.js/issues/comments/141438293","html_url":"https://github.com/angular/angular.js/issues/12870#issuecomment-141438293","issue_url":"https://api.github.com/repos/angular/angular.js/issues/12870","id":141438293,"user":{"login":"m-amr","id":6197215,"avatar_url":"https://avatars.githubusercontent.com/u/6197215?v=3","gravatar_id":"","url":"https://api.github.com/users/m-amr","html_url":"https://github.com/m-amr","followers_url":"https://api.github.com/users/m-amr/followers","following_url":"https://api.github.com/users/m-amr/following{/other_user}","gists_url":"https://api.github.com/users/m-amr/gists{/gist_id}","starred_url":"https://api.github.com/users/m-amr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-amr/subscriptions","organizations_url":"https://api.github.com/users/m-amr/orgs","repos_url":"https://api.github.com/users/m-amr/repos","events_url":"https://api.github.com/users/m-amr/events{/privacy}","received_events_url":"https://api.github.com/users/m-amr/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T12:28:01Z","updated_at":"2015-09-18T12:28:01Z","body":"@wbeange @Narretz \r\nI think adding a negative sign or a parentheses is related to the currency it self and the type of the user\r\ni think the best solution is make it optional\r\n so the developer can take this decision based on his web-application users typea\r\nbecause if you are not accountant parentheses will be negative for you\r\n\r\nIn Microsoft you can choose how to formate negative currencies\r\nhttps://support.office.com/en-us/article/Format-numbers-as-currency-0a03bb38-1a07-458d-9e30-2b54366bc7a4\r\n"}}