{"action":"created","comment":{"url":"https://api.github.com/repos/BonnierGaming/guides/pulls/comments/28725465","id":28725465,"diff_hunk":"@@ -0,0 +1,118 @@\n+# Merge requests\n+## Introduction\n+Since introducing GitLab to our workflow, we've been using it as our primary\n+tool for reviewing code.  \n+While issues still reside in Redmine and the actual merging/deploying is handled\n+outside of GitLab, commenting and discussing code is handled through GitLab.\n+\n+While there has been discussion about altering the workflow to utilize GitLab's\n+various features more extensively, for now you should only consider it being\n+something that rests on top of your everyday work in Redmine.\n+\n+## Prerequisite\n+The following instructions assume you have a working GitLab account. If you\n+don't yet have access to the web interface of GitLab, contact Operations.\n+\n+## Lifecycle of a merge request\n+### Creation procedure\n+Let's assume you've worked on an issue enough to set the status to \"Feedback\",\n+which would put it into the feedback queue.\n+\n+Before you set the status to \"Feedback\", make sure that there's a Merge Request\n+(henceforth referred to as \"MR\") available in GitLab.\n+\n+These are the steps necessary:\n+\n+1. Log into GitLab.\n+2. When logged in, you should arrive at the Dashboard (as written in the top\n+   left). Click \"Projects\" in the menu to the left.\n+3. Choose the project which you wish to submit a MR for. Most of the time, this\n+   will be \"sparkle\".\n+4. Click \"Merge Requests\" in the menu to the left.\n+5. Click the green \"New Merge Request\" button, located in the top right part of\n+   the page.\n+6. Here you'll need to provide the **source** branch and the **target** branch.\n+   The source branch should be the branch which you wish to have reviewed, while\n+   the target branch should be what you want to merge into.  \n+   Unless you've been asked to set it to something else, you'll want the target\n+   branch to be set to `master`.\n+7. Press the blue \"Compare branches\" button.\n+8. Enter title and description, following the guidelines written in the\n+   **Title and Description guidelines** section.  \n+   Set no label, this will be done by someone else.  \n+   Set no assignee, unless you've been asked to.\n+9. At this point you can review the MR one final time before pressing the\n+   \"Submit merge request\" button.\n+\n+This should take you to the page with the now created MR.  \n+All that is necessary from here is to post a link to the MR over in the\n+corresponding Redmine issue.\n+\n+#### Title and Description guidelines\n+The title should always look something like this:\n+\n+    #12345: Adjust constant in warpcore.yml to prevent overheating","path":"process/merge_requests/README.md","position":54,"original_position":54,"commit_id":"77b3b74145782fe7342c5bb831b9969f5f29120e","original_commit_id":"77b3b74145782fe7342c5bb831b9969f5f29120e","user":{"login":"jsageryd","id":48153,"avatar_url":"https://avatars.githubusercontent.com/u/48153?v=3","gravatar_id":"","url":"https://api.github.com/users/jsageryd","html_url":"https://github.com/jsageryd","followers_url":"https://api.github.com/users/jsageryd/followers","following_url":"https://api.github.com/users/jsageryd/following{/other_user}","gists_url":"https://api.github.com/users/jsageryd/gists{/gist_id}","starred_url":"https://api.github.com/users/jsageryd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsageryd/subscriptions","organizations_url":"https://api.github.com/users/jsageryd/orgs","repos_url":"https://api.github.com/users/jsageryd/repos","events_url":"https://api.github.com/users/jsageryd/events{/privacy}","received_events_url":"https://api.github.com/users/jsageryd/received_events","type":"User","site_admin":false},"body":"s/#12345:/#12345/ ? I commented on this earlier but I don't know what happened to my comment.","created_at":"2015-04-20T20:25:38Z","updated_at":"2015-04-20T20:25:38Z","html_url":"https://github.com/BonnierGaming/guides/pull/4#discussion_r28725465","pull_request_url":"https://api.github.com/repos/BonnierGaming/guides/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/BonnierGaming/guides/pulls/comments/28725465"},"html":{"href":"https://github.com/BonnierGaming/guides/pull/4#discussion_r28725465"},"pull_request":{"href":"https://api.github.com/repos/BonnierGaming/guides/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/BonnierGaming/guides/pulls/4","id":33352097,"html_url":"https://github.com/BonnierGaming/guides/pull/4","diff_url":"https://github.com/BonnierGaming/guides/pull/4.diff","patch_url":"https://github.com/BonnierGaming/guides/pull/4.patch","issue_url":"https://api.github.com/repos/BonnierGaming/guides/issues/4","number":4,"state":"open","locked":false,"title":"Add instructions for working with merge requests","user":{"login":"linduxed","id":222098,"avatar_url":"https://avatars.githubusercontent.com/u/222098?v=3","gravatar_id":"","url":"https://api.github.com/users/linduxed","html_url":"https://github.com/linduxed","followers_url":"https://api.github.com/users/linduxed/followers","following_url":"https://api.github.com/users/linduxed/following{/other_user}","gists_url":"https://api.github.com/users/linduxed/gists{/gist_id}","starred_url":"https://api.github.com/users/linduxed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linduxed/subscriptions","organizations_url":"https://api.github.com/users/linduxed/orgs","repos_url":"https://api.github.com/users/linduxed/repos","events_url":"https://api.github.com/users/linduxed/events{/privacy}","received_events_url":"https://api.github.com/users/linduxed/received_events","type":"User","site_admin":false},"body":"Covers creating, working in and closing merge requests in Gitlab.","created_at":"2015-04-15T13:04:29Z","updated_at":"2015-04-20T20:25:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b24580330970f9ad9caaa0b0a35932af11ec0eb3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/BonnierGaming/guides/pulls/4/commits","review_comments_url":"https://api.github.com/repos/BonnierGaming/guides/pulls/4/comments","review_comment_url":"https://api.github.com/repos/BonnierGaming/guides/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BonnierGaming/guides/issues/4/comments","statuses_url":"https://api.github.com/repos/BonnierGaming/guides/statuses/77b3b74145782fe7342c5bb831b9969f5f29120e","head":{"label":"BonnierGaming:merge-requests","ref":"merge-requests","sha":"77b3b74145782fe7342c5bb831b9969f5f29120e","user":{"login":"BonnierGaming","id":8100909,"avatar_url":"https://avatars.githubusercontent.com/u/8100909?v=3","gravatar_id":"","url":"https://api.github.com/users/BonnierGaming","html_url":"https://github.com/BonnierGaming","followers_url":"https://api.github.com/users/BonnierGaming/followers","following_url":"https://api.github.com/users/BonnierGaming/following{/other_user}","gists_url":"https://api.github.com/users/BonnierGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/BonnierGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BonnierGaming/subscriptions","organizations_url":"https://api.github.com/users/BonnierGaming/orgs","repos_url":"https://api.github.com/users/BonnierGaming/repos","events_url":"https://api.github.com/users/BonnierGaming/events{/privacy}","received_events_url":"https://api.github.com/users/BonnierGaming/received_events","type":"Organization","site_admin":false},"repo":{"id":28408856,"name":"guides","full_name":"BonnierGaming/guides","owner":{"login":"BonnierGaming","id":8100909,"avatar_url":"https://avatars.githubusercontent.com/u/8100909?v=3","gravatar_id":"","url":"https://api.github.com/users/BonnierGaming","html_url":"https://github.com/BonnierGaming","followers_url":"https://api.github.com/users/BonnierGaming/followers","following_url":"https://api.github.com/users/BonnierGaming/following{/other_user}","gists_url":"https://api.github.com/users/BonnierGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/BonnierGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BonnierGaming/subscriptions","organizations_url":"https://api.github.com/users/BonnierGaming/orgs","repos_url":"https://api.github.com/users/BonnierGaming/repos","events_url":"https://api.github.com/users/BonnierGaming/events{/privacy}","received_events_url":"https://api.github.com/users/BonnierGaming/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BonnierGaming/guides","description":"Guides for code style and processes","fork":false,"url":"https://api.github.com/repos/BonnierGaming/guides","forks_url":"https://api.github.com/repos/BonnierGaming/guides/forks","keys_url":"https://api.github.com/repos/BonnierGaming/guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BonnierGaming/guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BonnierGaming/guides/teams","hooks_url":"https://api.github.com/repos/BonnierGaming/guides/hooks","issue_events_url":"https://api.github.com/repos/BonnierGaming/guides/issues/events{/number}","events_url":"https://api.github.com/repos/BonnierGaming/guides/events","assignees_url":"https://api.github.com/repos/BonnierGaming/guides/assignees{/user}","branches_url":"https://api.github.com/repos/BonnierGaming/guides/branches{/branch}","tags_url":"https://api.github.com/repos/BonnierGaming/guides/tags","blobs_url":"https://api.github.com/repos/BonnierGaming/guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BonnierGaming/guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BonnierGaming/guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/BonnierGaming/guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BonnierGaming/guides/statuses/{sha}","languages_url":"https://api.github.com/repos/BonnierGaming/guides/languages","stargazers_url":"https://api.github.com/repos/BonnierGaming/guides/stargazers","contributors_url":"https://api.github.com/repos/BonnierGaming/guides/contributors","subscribers_url":"https://api.github.com/repos/BonnierGaming/guides/subscribers","subscription_url":"https://api.github.com/repos/BonnierGaming/guides/subscription","commits_url":"https://api.github.com/repos/BonnierGaming/guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/BonnierGaming/guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/BonnierGaming/guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/BonnierGaming/guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/BonnierGaming/guides/contents/{+path}","compare_url":"https://api.github.com/repos/BonnierGaming/guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BonnierGaming/guides/merges","archive_url":"https://api.github.com/repos/BonnierGaming/guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BonnierGaming/guides/downloads","issues_url":"https://api.github.com/repos/BonnierGaming/guides/issues{/number}","pulls_url":"https://api.github.com/repos/BonnierGaming/guides/pulls{/number}","milestones_url":"https://api.github.com/repos/BonnierGaming/guides/milestones{/number}","notifications_url":"https://api.github.com/repos/BonnierGaming/guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BonnierGaming/guides/labels{/name}","releases_url":"https://api.github.com/repos/BonnierGaming/guides/releases{/id}","created_at":"2014-12-23T16:49:00Z","updated_at":"2014-12-23T16:49:00Z","pushed_at":"2015-04-20T18:16:50Z","git_url":"git://github.com/BonnierGaming/guides.git","ssh_url":"git@github.com:BonnierGaming/guides.git","clone_url":"https://github.com/BonnierGaming/guides.git","svn_url":"https://github.com/BonnierGaming/guides","homepage":null,"size":440,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"BonnierGaming:master","ref":"master","sha":"1c3ff2e69fe63653b7173df2031bce1a43bc32a0","user":{"login":"BonnierGaming","id":8100909,"avatar_url":"https://avatars.githubusercontent.com/u/8100909?v=3","gravatar_id":"","url":"https://api.github.com/users/BonnierGaming","html_url":"https://github.com/BonnierGaming","followers_url":"https://api.github.com/users/BonnierGaming/followers","following_url":"https://api.github.com/users/BonnierGaming/following{/other_user}","gists_url":"https://api.github.com/users/BonnierGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/BonnierGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BonnierGaming/subscriptions","organizations_url":"https://api.github.com/users/BonnierGaming/orgs","repos_url":"https://api.github.com/users/BonnierGaming/repos","events_url":"https://api.github.com/users/BonnierGaming/events{/privacy}","received_events_url":"https://api.github.com/users/BonnierGaming/received_events","type":"Organization","site_admin":false},"repo":{"id":28408856,"name":"guides","full_name":"BonnierGaming/guides","owner":{"login":"BonnierGaming","id":8100909,"avatar_url":"https://avatars.githubusercontent.com/u/8100909?v=3","gravatar_id":"","url":"https://api.github.com/users/BonnierGaming","html_url":"https://github.com/BonnierGaming","followers_url":"https://api.github.com/users/BonnierGaming/followers","following_url":"https://api.github.com/users/BonnierGaming/following{/other_user}","gists_url":"https://api.github.com/users/BonnierGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/BonnierGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BonnierGaming/subscriptions","organizations_url":"https://api.github.com/users/BonnierGaming/orgs","repos_url":"https://api.github.com/users/BonnierGaming/repos","events_url":"https://api.github.com/users/BonnierGaming/events{/privacy}","received_events_url":"https://api.github.com/users/BonnierGaming/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BonnierGaming/guides","description":"Guides for code style and processes","fork":false,"url":"https://api.github.com/repos/BonnierGaming/guides","forks_url":"https://api.github.com/repos/BonnierGaming/guides/forks","keys_url":"https://api.github.com/repos/BonnierGaming/guides/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BonnierGaming/guides/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BonnierGaming/guides/teams","hooks_url":"https://api.github.com/repos/BonnierGaming/guides/hooks","issue_events_url":"https://api.github.com/repos/BonnierGaming/guides/issues/events{/number}","events_url":"https://api.github.com/repos/BonnierGaming/guides/events","assignees_url":"https://api.github.com/repos/BonnierGaming/guides/assignees{/user}","branches_url":"https://api.github.com/repos/BonnierGaming/guides/branches{/branch}","tags_url":"https://api.github.com/repos/BonnierGaming/guides/tags","blobs_url":"https://api.github.com/repos/BonnierGaming/guides/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BonnierGaming/guides/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BonnierGaming/guides/git/refs{/sha}","trees_url":"https://api.github.com/repos/BonnierGaming/guides/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BonnierGaming/guides/statuses/{sha}","languages_url":"https://api.github.com/repos/BonnierGaming/guides/languages","stargazers_url":"https://api.github.com/repos/BonnierGaming/guides/stargazers","contributors_url":"https://api.github.com/repos/BonnierGaming/guides/contributors","subscribers_url":"https://api.github.com/repos/BonnierGaming/guides/subscribers","subscription_url":"https://api.github.com/repos/BonnierGaming/guides/subscription","commits_url":"https://api.github.com/repos/BonnierGaming/guides/commits{/sha}","git_commits_url":"https://api.github.com/repos/BonnierGaming/guides/git/commits{/sha}","comments_url":"https://api.github.com/repos/BonnierGaming/guides/comments{/number}","issue_comment_url":"https://api.github.com/repos/BonnierGaming/guides/issues/comments{/number}","contents_url":"https://api.github.com/repos/BonnierGaming/guides/contents/{+path}","compare_url":"https://api.github.com/repos/BonnierGaming/guides/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BonnierGaming/guides/merges","archive_url":"https://api.github.com/repos/BonnierGaming/guides/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BonnierGaming/guides/downloads","issues_url":"https://api.github.com/repos/BonnierGaming/guides/issues{/number}","pulls_url":"https://api.github.com/repos/BonnierGaming/guides/pulls{/number}","milestones_url":"https://api.github.com/repos/BonnierGaming/guides/milestones{/number}","notifications_url":"https://api.github.com/repos/BonnierGaming/guides/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BonnierGaming/guides/labels{/name}","releases_url":"https://api.github.com/repos/BonnierGaming/guides/releases{/id}","created_at":"2014-12-23T16:49:00Z","updated_at":"2014-12-23T16:49:00Z","pushed_at":"2015-04-20T18:16:50Z","git_url":"git://github.com/BonnierGaming/guides.git","ssh_url":"git@github.com:BonnierGaming/guides.git","clone_url":"https://github.com/BonnierGaming/guides.git","svn_url":"https://github.com/BonnierGaming/guides","homepage":null,"size":440,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BonnierGaming/guides/pulls/4"},"html":{"href":"https://github.com/BonnierGaming/guides/pull/4"},"issue":{"href":"https://api.github.com/repos/BonnierGaming/guides/issues/4"},"comments":{"href":"https://api.github.com/repos/BonnierGaming/guides/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/BonnierGaming/guides/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/BonnierGaming/guides/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BonnierGaming/guides/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/BonnierGaming/guides/statuses/77b3b74145782fe7342c5bb831b9969f5f29120e"}}}}