{"action":"opened","issue":{"url":"https://api.github.com/repos/boto/boto/issues/2938","labels_url":"https://api.github.com/repos/boto/boto/issues/2938/labels{/name}","comments_url":"https://api.github.com/repos/boto/boto/issues/2938/comments","events_url":"https://api.github.com/repos/boto/boto/issues/2938/events","html_url":"https://github.com/boto/boto/issues/2938","id":56764575,"number":2938,"title":"Use uuid4 instead of uuid1 for SwfL1WorkflowExecutionTest.run_decider()","user":{"login":"micolous","id":246847,"avatar_url":"https://avatars.githubusercontent.com/u/246847?v=3","gravatar_id":"","url":"https://api.github.com/users/micolous","html_url":"https://github.com/micolous","followers_url":"https://api.github.com/users/micolous/followers","following_url":"https://api.github.com/users/micolous/following{/other_user}","gists_url":"https://api.github.com/users/micolous/gists{/gist_id}","starred_url":"https://api.github.com/users/micolous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/micolous/subscriptions","organizations_url":"https://api.github.com/users/micolous/orgs","repos_url":"https://api.github.com/users/micolous/repos","events_url":"https://api.github.com/users/micolous/events{/privacy}","received_events_url":"https://api.github.com/users/micolous/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-02-06T03:11:59Z","updated_at":"2015-02-06T03:11:59Z","closed_at":null,"body":"At present, in the following file:\r\n\r\nhttps://github.com/boto/boto/blob/5e5dc4c6b31de3331c6af918b2307869988e5a73/tests/integration/swf/test_layer1_workflow_execution.py#L56\r\n\r\n`SwfL1WorkflowExecutionTest.run_decider()` calls the method `uuid.uuid1()` to generate a UUID.\r\n\r\nIn Python, on platforms with `libuuid`, `uuid1` will call the method `uuid_generate_time`, which calls `get_clock`, which is not thread-safe, as it leaks file handles if `uuidd` is not present:\r\n\r\nhttp://comments.gmane.org/gmane.linux.utilities.util-linux-ng/4771\r\n\r\nInstead, `uuid.uuid4` should be used, as it does not suffer from this defect.\r\n\r\nMy reading of the function says that changing to `uuid.uuid4` shouldn't have a negative impact on the way this method behaves."}}