{"action":"closed","number":185,"pull_request":{"url":"https://api.github.com/repos/01org/parameter-framework/pulls/185","id":44334995,"html_url":"https://github.com/01org/parameter-framework/pull/185","diff_url":"https://github.com/01org/parameter-framework/pull/185.diff","patch_url":"https://github.com/01org/parameter-framework/pull/185.patch","issue_url":"https://api.github.com/repos/01org/parameter-framework/issues/185","number":185,"state":"closed","locked":false,"title":"Rework remote server","user":{"login":"cc6565","id":9692938,"avatar_url":"https://avatars.githubusercontent.com/u/9692938?v=3","gravatar_id":"","url":"https://api.github.com/users/cc6565","html_url":"https://github.com/cc6565","followers_url":"https://api.github.com/users/cc6565/followers","following_url":"https://api.github.com/users/cc6565/following{/other_user}","gists_url":"https://api.github.com/users/cc6565/gists{/gist_id}","starred_url":"https://api.github.com/users/cc6565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc6565/subscriptions","organizations_url":"https://api.github.com/users/cc6565/orgs","repos_url":"https://api.github.com/users/cc6565/repos","events_url":"https://api.github.com/users/cc6565/events{/privacy}","received_events_url":"https://api.github.com/users/cc6565/received_events","type":"User","site_admin":false},"body":"Split the RemoteProcessorServer into a server object (in charge of listening and processing messages from a pipe) and background server in charge of threading the server object.\r\nIt allows the test platform to bypass thread creation and avoid useless synchronization. \r\n\r\nIt also changes the way parameter library is linking with remote processor: this library is not opened through a dlopen any more but parameter links with dynamic remote processor library instead.\r\n\r\nCreating or not the remote processor server depends now only of the tuning allowed flag set within the configuration file of the Parameter Framework.\r\n\r\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/01org/parameter-framework/pull/185%23issuecomment-138493486%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/185%23issuecomment-138493861%22%2C%20%22https%3A//github.com/01org/parameter-framework/pull/185%23issuecomment-138494720%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/01org/parameter-framework/pull/185%23issuecomment-138493486%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%40cc6565%20Please%20fix%20all%20the%20commit%20messages.%22%2C%20%22created_at%22%3A%20%222015-09-08T09%3A23%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%2C%20%7B%22body%22%3A%20%22%40cc6565%20%40OznOg%20Please%20provide%20a%20more%20complete%20Pull%20Request%20message%20mentioning%20the%20new%20separation%20of%20responsibilities.%22%2C%20%22created_at%22%3A%20%222015-09-08T09%3A25%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%2C%20%7B%22body%22%3A%20%22Also%2C%20in%20most%20commit%20message%20headlines%2C%20it%20is%20impossible%20to%20tell%20which%20component%20is%20changed.%5Cr%5Cn%5Cr%5Cne.g.%5Cr%5Cn%5Cr%5Cn%20%20%20%20move%20commands%20into%20where%20it%20belongs%20%5Cr%5Cn%5Cr%5Cnbecomes%5Cr%5Cn%5Cr%5Cn%20%20%20%20test-platform%3A%20move%20command%20definitions%20to%20the%20thread%20function%22%2C%20%22created_at%22%3A%20%222015-09-08T09%3A28%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/6430928%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dawagner%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%7D%7D'></a>\r\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\r\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/01org/parameter-framework/pull/185#issuecomment-138493486'>General Comment</a></b>\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> @cc6565 Please fix all the commit messages.\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> @cc6565 @OznOg Please provide a more complete Pull Request message mentioning the new separation of responsibilities.\r\n- <a href='https://github.com/dawagner'><img border=0 src='https://avatars.githubusercontent.com/u/6430928?v=3' height=16 width=16'></a> Also, in most commit message headlines, it is impossible to tell which component is changed.\r\ne.g.\r\nmove commands into where it belongs\r\nbecomes\r\ntest-platform: move command definitions to the thread function\r\n\r\n\r\n<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/185?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/01org/parameter-framework/pull/185?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/01org/parameter-framework/pull/185'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\r\n<a href='#crh-end'></a>","created_at":"2015-09-07T09:15:33Z","updated_at":"2015-09-08T13:30:07Z","closed_at":"2015-09-08T13:30:06Z","merged_at":"2015-09-08T13:30:06Z","merge_commit_sha":"533c54b2cc05c58d2d7d4bad4614f4b4325de46b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/01org/parameter-framework/pulls/185/commits","review_comments_url":"https://api.github.com/repos/01org/parameter-framework/pulls/185/comments","review_comment_url":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/01org/parameter-framework/issues/185/comments","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/afa7fead2326559af6c26749ce1093eb3e119e0e","head":{"label":"cc6565:rework_seb_job","ref":"rework_seb_job","sha":"afa7fead2326559af6c26749ce1093eb3e119e0e","user":{"login":"cc6565","id":9692938,"avatar_url":"https://avatars.githubusercontent.com/u/9692938?v=3","gravatar_id":"","url":"https://api.github.com/users/cc6565","html_url":"https://github.com/cc6565","followers_url":"https://api.github.com/users/cc6565/followers","following_url":"https://api.github.com/users/cc6565/following{/other_user}","gists_url":"https://api.github.com/users/cc6565/gists{/gist_id}","starred_url":"https://api.github.com/users/cc6565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc6565/subscriptions","organizations_url":"https://api.github.com/users/cc6565/orgs","repos_url":"https://api.github.com/users/cc6565/repos","events_url":"https://api.github.com/users/cc6565/events{/privacy}","received_events_url":"https://api.github.com/users/cc6565/received_events","type":"User","site_admin":false},"repo":{"id":31022788,"name":"parameter-framework","full_name":"cc6565/parameter-framework","owner":{"login":"cc6565","id":9692938,"avatar_url":"https://avatars.githubusercontent.com/u/9692938?v=3","gravatar_id":"","url":"https://api.github.com/users/cc6565","html_url":"https://github.com/cc6565","followers_url":"https://api.github.com/users/cc6565/followers","following_url":"https://api.github.com/users/cc6565/following{/other_user}","gists_url":"https://api.github.com/users/cc6565/gists{/gist_id}","starred_url":"https://api.github.com/users/cc6565/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cc6565/subscriptions","organizations_url":"https://api.github.com/users/cc6565/orgs","repos_url":"https://api.github.com/users/cc6565/repos","events_url":"https://api.github.com/users/cc6565/events{/privacy}","received_events_url":"https://api.github.com/users/cc6565/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cc6565/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":true,"url":"https://api.github.com/repos/cc6565/parameter-framework","forks_url":"https://api.github.com/repos/cc6565/parameter-framework/forks","keys_url":"https://api.github.com/repos/cc6565/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cc6565/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cc6565/parameter-framework/teams","hooks_url":"https://api.github.com/repos/cc6565/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/cc6565/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/cc6565/parameter-framework/events","assignees_url":"https://api.github.com/repos/cc6565/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/cc6565/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/cc6565/parameter-framework/tags","blobs_url":"https://api.github.com/repos/cc6565/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cc6565/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cc6565/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/cc6565/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cc6565/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/cc6565/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/cc6565/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/cc6565/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/cc6565/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/cc6565/parameter-framework/subscription","commits_url":"https://api.github.com/repos/cc6565/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/cc6565/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/cc6565/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/cc6565/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/cc6565/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/cc6565/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cc6565/parameter-framework/merges","archive_url":"https://api.github.com/repos/cc6565/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cc6565/parameter-framework/downloads","issues_url":"https://api.github.com/repos/cc6565/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/cc6565/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/cc6565/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/cc6565/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cc6565/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/cc6565/parameter-framework/releases{/id}","created_at":"2015-02-19T15:53:39Z","updated_at":"2015-04-01T16:25:30Z","pushed_at":"2015-09-08T11:31:55Z","git_url":"git://github.com/cc6565/parameter-framework.git","ssh_url":"git@github.com:cc6565/parameter-framework.git","clone_url":"https://github.com/cc6565/parameter-framework.git","svn_url":"https://github.com/cc6565/parameter-framework","homepage":"","size":35923,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"01org:windows_port","ref":"windows_port","sha":"12353c658ed8b79688e207fc457b99c39e67175b","user":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"repo":{"id":16009363,"name":"parameter-framework","full_name":"01org/parameter-framework","owner":{"login":"01org","id":1635439,"avatar_url":"https://avatars.githubusercontent.com/u/1635439?v=3","gravatar_id":"","url":"https://api.github.com/users/01org","html_url":"https://github.com/01org","followers_url":"https://api.github.com/users/01org/followers","following_url":"https://api.github.com/users/01org/following{/other_user}","gists_url":"https://api.github.com/users/01org/gists{/gist_id}","starred_url":"https://api.github.com/users/01org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/01org/subscriptions","organizations_url":"https://api.github.com/users/01org/orgs","repos_url":"https://api.github.com/users/01org/repos","events_url":"https://api.github.com/users/01org/events{/privacy}","received_events_url":"https://api.github.com/users/01org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/01org/parameter-framework","description":"Plugin-based and rule-based framework for describing and controlling parameters","fork":false,"url":"https://api.github.com/repos/01org/parameter-framework","forks_url":"https://api.github.com/repos/01org/parameter-framework/forks","keys_url":"https://api.github.com/repos/01org/parameter-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/01org/parameter-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/01org/parameter-framework/teams","hooks_url":"https://api.github.com/repos/01org/parameter-framework/hooks","issue_events_url":"https://api.github.com/repos/01org/parameter-framework/issues/events{/number}","events_url":"https://api.github.com/repos/01org/parameter-framework/events","assignees_url":"https://api.github.com/repos/01org/parameter-framework/assignees{/user}","branches_url":"https://api.github.com/repos/01org/parameter-framework/branches{/branch}","tags_url":"https://api.github.com/repos/01org/parameter-framework/tags","blobs_url":"https://api.github.com/repos/01org/parameter-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/01org/parameter-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/01org/parameter-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/01org/parameter-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/01org/parameter-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/01org/parameter-framework/languages","stargazers_url":"https://api.github.com/repos/01org/parameter-framework/stargazers","contributors_url":"https://api.github.com/repos/01org/parameter-framework/contributors","subscribers_url":"https://api.github.com/repos/01org/parameter-framework/subscribers","subscription_url":"https://api.github.com/repos/01org/parameter-framework/subscription","commits_url":"https://api.github.com/repos/01org/parameter-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/01org/parameter-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/01org/parameter-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/01org/parameter-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/01org/parameter-framework/contents/{+path}","compare_url":"https://api.github.com/repos/01org/parameter-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/01org/parameter-framework/merges","archive_url":"https://api.github.com/repos/01org/parameter-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/01org/parameter-framework/downloads","issues_url":"https://api.github.com/repos/01org/parameter-framework/issues{/number}","pulls_url":"https://api.github.com/repos/01org/parameter-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/01org/parameter-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/01org/parameter-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/01org/parameter-framework/labels{/name}","releases_url":"https://api.github.com/repos/01org/parameter-framework/releases{/id}","created_at":"2014-01-17T19:24:01Z","updated_at":"2015-08-19T13:07:43Z","pushed_at":"2015-09-08T13:30:06Z","git_url":"git://github.com/01org/parameter-framework.git","ssh_url":"git@github.com:01org/parameter-framework.git","clone_url":"https://github.com/01org/parameter-framework.git","svn_url":"https://github.com/01org/parameter-framework","homepage":"","size":49505,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"open_issues_count":24,"forks":22,"open_issues":24,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/185"},"html":{"href":"https://github.com/01org/parameter-framework/pull/185"},"issue":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/185"},"comments":{"href":"https://api.github.com/repos/01org/parameter-framework/issues/185/comments"},"review_comments":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/185/comments"},"review_comment":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/01org/parameter-framework/pulls/185/commits"},"statuses":{"href":"https://api.github.com/repos/01org/parameter-framework/statuses/afa7fead2326559af6c26749ce1093eb3e119e0e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"krocard","id":6862950,"avatar_url":"https://avatars.githubusercontent.com/u/6862950?v=3","gravatar_id":"","url":"https://api.github.com/users/krocard","html_url":"https://github.com/krocard","followers_url":"https://api.github.com/users/krocard/followers","following_url":"https://api.github.com/users/krocard/following{/other_user}","gists_url":"https://api.github.com/users/krocard/gists{/gist_id}","starred_url":"https://api.github.com/users/krocard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krocard/subscriptions","organizations_url":"https://api.github.com/users/krocard/orgs","repos_url":"https://api.github.com/users/krocard/repos","events_url":"https://api.github.com/users/krocard/events{/privacy}","received_events_url":"https://api.github.com/users/krocard/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":7,"additions":138,"deletions":257,"changed_files":14}}