{"action":"created","comment":{"url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/comments/30775046","id":30775046,"diff_hunk":"@@ -1179,6 +1180,26 @@ namespace zmq {\n     NanReturnValue(NanNew<String>(version_info));\n   }\n \n+#if ZMQ_VERSION_MAJOR >= 4\n+   static NAN_METHOD(ZmqCurveKeypair) {\n+    NanScope();\n+\n+    char public_key [41];\n+    char secret_key [41];\n+\n+    int rc = zmq_curve_keypair( public_key, secret_key);\n+    if (rc < 0) {\n+      throw std::runtime_error(ErrorMessage());","path":"binding.cc","position":21,"original_position":21,"commit_id":"2fbd0de5ddf124ddd233a4396aff10bbcee59fbb","original_commit_id":"2fbd0de5ddf124ddd233a4396aff10bbcee59fbb","user":{"login":"szilardhuber","id":799824,"avatar_url":"https://avatars.githubusercontent.com/u/799824?v=3","gravatar_id":"","url":"https://api.github.com/users/szilardhuber","html_url":"https://github.com/szilardhuber","followers_url":"https://api.github.com/users/szilardhuber/followers","following_url":"https://api.github.com/users/szilardhuber/following{/other_user}","gists_url":"https://api.github.com/users/szilardhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/szilardhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szilardhuber/subscriptions","organizations_url":"https://api.github.com/users/szilardhuber/orgs","repos_url":"https://api.github.com/users/szilardhuber/repos","events_url":"https://api.github.com/users/szilardhuber/events{/privacy}","received_events_url":"https://api.github.com/users/szilardhuber/received_events","type":"User","site_admin":false},"body":"Actually I got this from other parts of the code. But looking at it again seems to me that ```        NanThrowError(ExceptionFromError());\r\n``` could be more appropriate. Would this be ok?","created_at":"2015-05-21T06:11:01Z","updated_at":"2015-05-21T06:11:01Z","html_url":"https://github.com/JustinTulloss/zeromq.node/pull/425#discussion_r30775046","pull_request_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425","_links":{"self":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/comments/30775046"},"html":{"href":"https://github.com/JustinTulloss/zeromq.node/pull/425#discussion_r30775046"},"pull_request":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425"}}},"pull_request":{"url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425","id":35710468,"html_url":"https://github.com/JustinTulloss/zeromq.node/pull/425","diff_url":"https://github.com/JustinTulloss/zeromq.node/pull/425.diff","patch_url":"https://github.com/JustinTulloss/zeromq.node/pull/425.patch","issue_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/425","number":425,"state":"open","locked":false,"title":"Adding zmq_curve_keypair to the interface.","user":{"login":"szilardhuber","id":799824,"avatar_url":"https://avatars.githubusercontent.com/u/799824?v=3","gravatar_id":"","url":"https://api.github.com/users/szilardhuber","html_url":"https://github.com/szilardhuber","followers_url":"https://api.github.com/users/szilardhuber/followers","following_url":"https://api.github.com/users/szilardhuber/following{/other_user}","gists_url":"https://api.github.com/users/szilardhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/szilardhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szilardhuber/subscriptions","organizations_url":"https://api.github.com/users/szilardhuber/orgs","repos_url":"https://api.github.com/users/szilardhuber/repos","events_url":"https://api.github.com/users/szilardhuber/events{/privacy}","received_events_url":"https://api.github.com/users/szilardhuber/received_events","type":"User","site_admin":false},"body":"This is my naive try to address #414. I have no previous experience neither with NaN nor with V8 so please point at my errors and I do my best to address them.\r\n\r\nThe motivation for the PR is described in the issue referred. I would like to generate the keys needed for Curve without using an external tool and as this method is part oz ZeroMQ since 4.0 I felt it appropriate to put it in to the node binding as well.\r\n\r\nI updated the headers in the include folder from [zeromq/zeromq4-x](https://github.com/zeromq/zeromq4-x). I haven't updated the dlls and libs as I couldn't figure out where to get them from.","created_at":"2015-05-19T09:22:03Z","updated_at":"2015-05-21T06:11:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f1693634570d8845600fc2dd7378551c73e7754","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425/commits","review_comments_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425/comments","review_comment_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/425/comments","statuses_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/statuses/2fbd0de5ddf124ddd233a4396aff10bbcee59fbb","head":{"label":"szilardhuber:master","ref":"master","sha":"2fbd0de5ddf124ddd233a4396aff10bbcee59fbb","user":{"login":"szilardhuber","id":799824,"avatar_url":"https://avatars.githubusercontent.com/u/799824?v=3","gravatar_id":"","url":"https://api.github.com/users/szilardhuber","html_url":"https://github.com/szilardhuber","followers_url":"https://api.github.com/users/szilardhuber/followers","following_url":"https://api.github.com/users/szilardhuber/following{/other_user}","gists_url":"https://api.github.com/users/szilardhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/szilardhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szilardhuber/subscriptions","organizations_url":"https://api.github.com/users/szilardhuber/orgs","repos_url":"https://api.github.com/users/szilardhuber/repos","events_url":"https://api.github.com/users/szilardhuber/events{/privacy}","received_events_url":"https://api.github.com/users/szilardhuber/received_events","type":"User","site_admin":false},"repo":{"id":35871121,"name":"zeromq.node","full_name":"szilardhuber/zeromq.node","owner":{"login":"szilardhuber","id":799824,"avatar_url":"https://avatars.githubusercontent.com/u/799824?v=3","gravatar_id":"","url":"https://api.github.com/users/szilardhuber","html_url":"https://github.com/szilardhuber","followers_url":"https://api.github.com/users/szilardhuber/followers","following_url":"https://api.github.com/users/szilardhuber/following{/other_user}","gists_url":"https://api.github.com/users/szilardhuber/gists{/gist_id}","starred_url":"https://api.github.com/users/szilardhuber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szilardhuber/subscriptions","organizations_url":"https://api.github.com/users/szilardhuber/orgs","repos_url":"https://api.github.com/users/szilardhuber/repos","events_url":"https://api.github.com/users/szilardhuber/events{/privacy}","received_events_url":"https://api.github.com/users/szilardhuber/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/szilardhuber/zeromq.node","description":"Node.js bindings to the zeromq library","fork":true,"url":"https://api.github.com/repos/szilardhuber/zeromq.node","forks_url":"https://api.github.com/repos/szilardhuber/zeromq.node/forks","keys_url":"https://api.github.com/repos/szilardhuber/zeromq.node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szilardhuber/zeromq.node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szilardhuber/zeromq.node/teams","hooks_url":"https://api.github.com/repos/szilardhuber/zeromq.node/hooks","issue_events_url":"https://api.github.com/repos/szilardhuber/zeromq.node/issues/events{/number}","events_url":"https://api.github.com/repos/szilardhuber/zeromq.node/events","assignees_url":"https://api.github.com/repos/szilardhuber/zeromq.node/assignees{/user}","branches_url":"https://api.github.com/repos/szilardhuber/zeromq.node/branches{/branch}","tags_url":"https://api.github.com/repos/szilardhuber/zeromq.node/tags","blobs_url":"https://api.github.com/repos/szilardhuber/zeromq.node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szilardhuber/zeromq.node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szilardhuber/zeromq.node/git/refs{/sha}","trees_url":"https://api.github.com/repos/szilardhuber/zeromq.node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szilardhuber/zeromq.node/statuses/{sha}","languages_url":"https://api.github.com/repos/szilardhuber/zeromq.node/languages","stargazers_url":"https://api.github.com/repos/szilardhuber/zeromq.node/stargazers","contributors_url":"https://api.github.com/repos/szilardhuber/zeromq.node/contributors","subscribers_url":"https://api.github.com/repos/szilardhuber/zeromq.node/subscribers","subscription_url":"https://api.github.com/repos/szilardhuber/zeromq.node/subscription","commits_url":"https://api.github.com/repos/szilardhuber/zeromq.node/commits{/sha}","git_commits_url":"https://api.github.com/repos/szilardhuber/zeromq.node/git/commits{/sha}","comments_url":"https://api.github.com/repos/szilardhuber/zeromq.node/comments{/number}","issue_comment_url":"https://api.github.com/repos/szilardhuber/zeromq.node/issues/comments{/number}","contents_url":"https://api.github.com/repos/szilardhuber/zeromq.node/contents/{+path}","compare_url":"https://api.github.com/repos/szilardhuber/zeromq.node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szilardhuber/zeromq.node/merges","archive_url":"https://api.github.com/repos/szilardhuber/zeromq.node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szilardhuber/zeromq.node/downloads","issues_url":"https://api.github.com/repos/szilardhuber/zeromq.node/issues{/number}","pulls_url":"https://api.github.com/repos/szilardhuber/zeromq.node/pulls{/number}","milestones_url":"https://api.github.com/repos/szilardhuber/zeromq.node/milestones{/number}","notifications_url":"https://api.github.com/repos/szilardhuber/zeromq.node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szilardhuber/zeromq.node/labels{/name}","releases_url":"https://api.github.com/repos/szilardhuber/zeromq.node/releases{/id}","created_at":"2015-05-19T09:01:51Z","updated_at":"2015-05-19T09:01:52Z","pushed_at":"2015-05-19T17:34:07Z","git_url":"git://github.com/szilardhuber/zeromq.node.git","ssh_url":"git@github.com:szilardhuber/zeromq.node.git","clone_url":"https://github.com/szilardhuber/zeromq.node.git","svn_url":"https://github.com/szilardhuber/zeromq.node","homepage":"","size":3147,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JustinTulloss:master","ref":"master","sha":"2b122a574df9b930388c62cd927661e4a324ce1d","user":{"login":"JustinTulloss","id":23734,"avatar_url":"https://avatars.githubusercontent.com/u/23734?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinTulloss","html_url":"https://github.com/JustinTulloss","followers_url":"https://api.github.com/users/JustinTulloss/followers","following_url":"https://api.github.com/users/JustinTulloss/following{/other_user}","gists_url":"https://api.github.com/users/JustinTulloss/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinTulloss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinTulloss/subscriptions","organizations_url":"https://api.github.com/users/JustinTulloss/orgs","repos_url":"https://api.github.com/users/JustinTulloss/repos","events_url":"https://api.github.com/users/JustinTulloss/events{/privacy}","received_events_url":"https://api.github.com/users/JustinTulloss/received_events","type":"User","site_admin":false},"repo":{"id":595090,"name":"zeromq.node","full_name":"JustinTulloss/zeromq.node","owner":{"login":"JustinTulloss","id":23734,"avatar_url":"https://avatars.githubusercontent.com/u/23734?v=3","gravatar_id":"","url":"https://api.github.com/users/JustinTulloss","html_url":"https://github.com/JustinTulloss","followers_url":"https://api.github.com/users/JustinTulloss/followers","following_url":"https://api.github.com/users/JustinTulloss/following{/other_user}","gists_url":"https://api.github.com/users/JustinTulloss/gists{/gist_id}","starred_url":"https://api.github.com/users/JustinTulloss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JustinTulloss/subscriptions","organizations_url":"https://api.github.com/users/JustinTulloss/orgs","repos_url":"https://api.github.com/users/JustinTulloss/repos","events_url":"https://api.github.com/users/JustinTulloss/events{/privacy}","received_events_url":"https://api.github.com/users/JustinTulloss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JustinTulloss/zeromq.node","description":"Node.js bindings to the zeromq library","fork":false,"url":"https://api.github.com/repos/JustinTulloss/zeromq.node","forks_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/forks","keys_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/teams","hooks_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/hooks","issue_events_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/events{/number}","events_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/events","assignees_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/assignees{/user}","branches_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/branches{/branch}","tags_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/tags","blobs_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/refs{/sha}","trees_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/statuses/{sha}","languages_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/languages","stargazers_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/stargazers","contributors_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/contributors","subscribers_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/subscribers","subscription_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/subscription","commits_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/commits{/sha}","git_commits_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/git/commits{/sha}","comments_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/comments{/number}","issue_comment_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/comments{/number}","contents_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/contents/{+path}","compare_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/merges","archive_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/downloads","issues_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues{/number}","pulls_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls{/number}","milestones_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/milestones{/number}","notifications_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/labels{/name}","releases_url":"https://api.github.com/repos/JustinTulloss/zeromq.node/releases{/id}","created_at":"2010-04-05T07:23:15Z","updated_at":"2015-05-20T09:02:24Z","pushed_at":"2015-05-21T03:43:57Z","git_url":"git://github.com/JustinTulloss/zeromq.node.git","ssh_url":"git@github.com:JustinTulloss/zeromq.node.git","clone_url":"https://github.com/JustinTulloss/zeromq.node.git","svn_url":"https://github.com/JustinTulloss/zeromq.node","homepage":"","size":3147,"stargazers_count":1111,"watchers_count":1111,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":215,"mirror_url":null,"open_issues_count":118,"forks":215,"open_issues":118,"watchers":1111,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425"},"html":{"href":"https://github.com/JustinTulloss/zeromq.node/pull/425"},"issue":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/425"},"comments":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/issues/425/comments"},"review_comments":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425/comments"},"review_comment":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/pulls/425/commits"},"statuses":{"href":"https://api.github.com/repos/JustinTulloss/zeromq.node/statuses/2fbd0de5ddf124ddd233a4396aff10bbcee59fbb"}}}}