{"action":"closed","number":428,"pull_request":{"url":"https://api.github.com/repos/flux-framework/flux-core/pulls/428","id":46340067,"html_url":"https://github.com/flux-framework/flux-core/pull/428","diff_url":"https://github.com/flux-framework/flux-core/pull/428.diff","patch_url":"https://github.com/flux-framework/flux-core/pull/428.patch","issue_url":"https://api.github.com/repos/flux-framework/flux-core/issues/428","number":428,"state":"closed","locked":false,"title":"bindings/lua: take reference counts on external handle and kvsdir objects","user":{"login":"grondo","id":741970,"avatar_url":"https://avatars.githubusercontent.com/u/741970?v=3","gravatar_id":"","url":"https://api.github.com/users/grondo","html_url":"https://github.com/grondo","followers_url":"https://api.github.com/users/grondo/followers","following_url":"https://api.github.com/users/grondo/following{/other_user}","gists_url":"https://api.github.com/users/grondo/gists{/gist_id}","starred_url":"https://api.github.com/users/grondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondo/subscriptions","organizations_url":"https://api.github.com/users/grondo/orgs","repos_url":"https://api.github.com/users/grondo/repos","events_url":"https://api.github.com/users/grondo/events{/privacy}","received_events_url":"https://api.github.com/users/grondo/received_events","type":"User","site_admin":false},"body":"This is a proposed fix for #426.\r\n\r\nLua doesn't own `flux_t` handles or `kvsdir_t` objects \"pushed\" into Lua state from C context, but the metatables for these objects still had a `__gc` field causing normal garbage collection to possibly trigger early destruction and assertion failures or other crashes.\r\n\r\nUse newly created `incref` primitives to increase reference count of these objects if they're passed in externally to Lua, thus avoiding premature destruction from Lua and/or C.\r\n\r\nFor a sanity check, I'd like to verify that `make check` passes for @garlick on toss desktop and @dongahn's sched tests pass before merging this one in.\r\nI've verified the reproducer I had is now fixed.","created_at":"2015-09-29T22:22:58Z","updated_at":"2015-09-30T21:57:36Z","closed_at":"2015-09-30T21:57:36Z","merged_at":"2015-09-30T21:57:36Z","merge_commit_sha":"3bccb704df3cf37b4b8d5fc896a42622a5f9b3d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flux-framework/flux-core/pulls/428/commits","review_comments_url":"https://api.github.com/repos/flux-framework/flux-core/pulls/428/comments","review_comment_url":"https://api.github.com/repos/flux-framework/flux-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flux-framework/flux-core/issues/428/comments","statuses_url":"https://api.github.com/repos/flux-framework/flux-core/statuses/26c542c6c985bd81bf267e983c3584532482daa0","head":{"label":"grondo:issue#426","ref":"issue#426","sha":"26c542c6c985bd81bf267e983c3584532482daa0","user":{"login":"grondo","id":741970,"avatar_url":"https://avatars.githubusercontent.com/u/741970?v=3","gravatar_id":"","url":"https://api.github.com/users/grondo","html_url":"https://github.com/grondo","followers_url":"https://api.github.com/users/grondo/followers","following_url":"https://api.github.com/users/grondo/following{/other_user}","gists_url":"https://api.github.com/users/grondo/gists{/gist_id}","starred_url":"https://api.github.com/users/grondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondo/subscriptions","organizations_url":"https://api.github.com/users/grondo/orgs","repos_url":"https://api.github.com/users/grondo/repos","events_url":"https://api.github.com/users/grondo/events{/privacy}","received_events_url":"https://api.github.com/users/grondo/received_events","type":"User","site_admin":false},"repo":{"id":24520566,"name":"flux-core","full_name":"grondo/flux-core","owner":{"login":"grondo","id":741970,"avatar_url":"https://avatars.githubusercontent.com/u/741970?v=3","gravatar_id":"","url":"https://api.github.com/users/grondo","html_url":"https://github.com/grondo","followers_url":"https://api.github.com/users/grondo/followers","following_url":"https://api.github.com/users/grondo/following{/other_user}","gists_url":"https://api.github.com/users/grondo/gists{/gist_id}","starred_url":"https://api.github.com/users/grondo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grondo/subscriptions","organizations_url":"https://api.github.com/users/grondo/orgs","repos_url":"https://api.github.com/users/grondo/repos","events_url":"https://api.github.com/users/grondo/events{/privacy}","received_events_url":"https://api.github.com/users/grondo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/grondo/flux-core","description":"core  services for the Flux resource management framework","fork":true,"url":"https://api.github.com/repos/grondo/flux-core","forks_url":"https://api.github.com/repos/grondo/flux-core/forks","keys_url":"https://api.github.com/repos/grondo/flux-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grondo/flux-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grondo/flux-core/teams","hooks_url":"https://api.github.com/repos/grondo/flux-core/hooks","issue_events_url":"https://api.github.com/repos/grondo/flux-core/issues/events{/number}","events_url":"https://api.github.com/repos/grondo/flux-core/events","assignees_url":"https://api.github.com/repos/grondo/flux-core/assignees{/user}","branches_url":"https://api.github.com/repos/grondo/flux-core/branches{/branch}","tags_url":"https://api.github.com/repos/grondo/flux-core/tags","blobs_url":"https://api.github.com/repos/grondo/flux-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grondo/flux-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grondo/flux-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/grondo/flux-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grondo/flux-core/statuses/{sha}","languages_url":"https://api.github.com/repos/grondo/flux-core/languages","stargazers_url":"https://api.github.com/repos/grondo/flux-core/stargazers","contributors_url":"https://api.github.com/repos/grondo/flux-core/contributors","subscribers_url":"https://api.github.com/repos/grondo/flux-core/subscribers","subscription_url":"https://api.github.com/repos/grondo/flux-core/subscription","commits_url":"https://api.github.com/repos/grondo/flux-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/grondo/flux-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/grondo/flux-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/grondo/flux-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/grondo/flux-core/contents/{+path}","compare_url":"https://api.github.com/repos/grondo/flux-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grondo/flux-core/merges","archive_url":"https://api.github.com/repos/grondo/flux-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grondo/flux-core/downloads","issues_url":"https://api.github.com/repos/grondo/flux-core/issues{/number}","pulls_url":"https://api.github.com/repos/grondo/flux-core/pulls{/number}","milestones_url":"https://api.github.com/repos/grondo/flux-core/milestones{/number}","notifications_url":"https://api.github.com/repos/grondo/flux-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grondo/flux-core/labels{/name}","releases_url":"https://api.github.com/repos/grondo/flux-core/releases{/id}","created_at":"2014-09-27T01:37:14Z","updated_at":"2014-10-10T22:50:00Z","pushed_at":"2015-09-30T21:47:42Z","git_url":"git://github.com/grondo/flux-core.git","ssh_url":"git@github.com:grondo/flux-core.git","clone_url":"https://github.com/grondo/flux-core.git","svn_url":"https://github.com/grondo/flux-core","homepage":"","size":22154,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flux-framework:master","ref":"master","sha":"4cb6c50437f9b2dda08b1aeb214beb9de56b806b","user":{"login":"flux-framework","id":7545483,"avatar_url":"https://avatars.githubusercontent.com/u/7545483?v=3","gravatar_id":"","url":"https://api.github.com/users/flux-framework","html_url":"https://github.com/flux-framework","followers_url":"https://api.github.com/users/flux-framework/followers","following_url":"https://api.github.com/users/flux-framework/following{/other_user}","gists_url":"https://api.github.com/users/flux-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/flux-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flux-framework/subscriptions","organizations_url":"https://api.github.com/users/flux-framework/orgs","repos_url":"https://api.github.com/users/flux-framework/repos","events_url":"https://api.github.com/users/flux-framework/events{/privacy}","received_events_url":"https://api.github.com/users/flux-framework/received_events","type":"Organization","site_admin":false},"repo":{"id":24517284,"name":"flux-core","full_name":"flux-framework/flux-core","owner":{"login":"flux-framework","id":7545483,"avatar_url":"https://avatars.githubusercontent.com/u/7545483?v=3","gravatar_id":"","url":"https://api.github.com/users/flux-framework","html_url":"https://github.com/flux-framework","followers_url":"https://api.github.com/users/flux-framework/followers","following_url":"https://api.github.com/users/flux-framework/following{/other_user}","gists_url":"https://api.github.com/users/flux-framework/gists{/gist_id}","starred_url":"https://api.github.com/users/flux-framework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flux-framework/subscriptions","organizations_url":"https://api.github.com/users/flux-framework/orgs","repos_url":"https://api.github.com/users/flux-framework/repos","events_url":"https://api.github.com/users/flux-framework/events{/privacy}","received_events_url":"https://api.github.com/users/flux-framework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flux-framework/flux-core","description":"core  services for the Flux resource management framework","fork":false,"url":"https://api.github.com/repos/flux-framework/flux-core","forks_url":"https://api.github.com/repos/flux-framework/flux-core/forks","keys_url":"https://api.github.com/repos/flux-framework/flux-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flux-framework/flux-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flux-framework/flux-core/teams","hooks_url":"https://api.github.com/repos/flux-framework/flux-core/hooks","issue_events_url":"https://api.github.com/repos/flux-framework/flux-core/issues/events{/number}","events_url":"https://api.github.com/repos/flux-framework/flux-core/events","assignees_url":"https://api.github.com/repos/flux-framework/flux-core/assignees{/user}","branches_url":"https://api.github.com/repos/flux-framework/flux-core/branches{/branch}","tags_url":"https://api.github.com/repos/flux-framework/flux-core/tags","blobs_url":"https://api.github.com/repos/flux-framework/flux-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flux-framework/flux-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flux-framework/flux-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/flux-framework/flux-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flux-framework/flux-core/statuses/{sha}","languages_url":"https://api.github.com/repos/flux-framework/flux-core/languages","stargazers_url":"https://api.github.com/repos/flux-framework/flux-core/stargazers","contributors_url":"https://api.github.com/repos/flux-framework/flux-core/contributors","subscribers_url":"https://api.github.com/repos/flux-framework/flux-core/subscribers","subscription_url":"https://api.github.com/repos/flux-framework/flux-core/subscription","commits_url":"https://api.github.com/repos/flux-framework/flux-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/flux-framework/flux-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/flux-framework/flux-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/flux-framework/flux-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/flux-framework/flux-core/contents/{+path}","compare_url":"https://api.github.com/repos/flux-framework/flux-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flux-framework/flux-core/merges","archive_url":"https://api.github.com/repos/flux-framework/flux-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flux-framework/flux-core/downloads","issues_url":"https://api.github.com/repos/flux-framework/flux-core/issues{/number}","pulls_url":"https://api.github.com/repos/flux-framework/flux-core/pulls{/number}","milestones_url":"https://api.github.com/repos/flux-framework/flux-core/milestones{/number}","notifications_url":"https://api.github.com/repos/flux-framework/flux-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flux-framework/flux-core/labels{/name}","releases_url":"https://api.github.com/repos/flux-framework/flux-core/releases{/id}","created_at":"2014-09-26T22:27:19Z","updated_at":"2015-09-25T09:16:55Z","pushed_at":"2015-09-30T21:57:36Z","git_url":"git://github.com/flux-framework/flux-core.git","ssh_url":"git@github.com:flux-framework/flux-core.git","clone_url":"https://github.com/flux-framework/flux-core.git","svn_url":"https://github.com/flux-framework/flux-core","homepage":"","size":23025,"stargazers_count":19,"watchers_count":19,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":93,"forks":8,"open_issues":93,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flux-framework/flux-core/pulls/428"},"html":{"href":"https://github.com/flux-framework/flux-core/pull/428"},"issue":{"href":"https://api.github.com/repos/flux-framework/flux-core/issues/428"},"comments":{"href":"https://api.github.com/repos/flux-framework/flux-core/issues/428/comments"},"review_comments":{"href":"https://api.github.com/repos/flux-framework/flux-core/pulls/428/comments"},"review_comment":{"href":"https://api.github.com/repos/flux-framework/flux-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flux-framework/flux-core/pulls/428/commits"},"statuses":{"href":"https://api.github.com/repos/flux-framework/flux-core/statuses/26c542c6c985bd81bf267e983c3584532482daa0"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"garlick","id":169947,"avatar_url":"https://avatars.githubusercontent.com/u/169947?v=3","gravatar_id":"","url":"https://api.github.com/users/garlick","html_url":"https://github.com/garlick","followers_url":"https://api.github.com/users/garlick/followers","following_url":"https://api.github.com/users/garlick/following{/other_user}","gists_url":"https://api.github.com/users/garlick/gists{/gist_id}","starred_url":"https://api.github.com/users/garlick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garlick/subscriptions","organizations_url":"https://api.github.com/users/garlick/orgs","repos_url":"https://api.github.com/users/garlick/repos","events_url":"https://api.github.com/users/garlick/events{/privacy}","received_events_url":"https://api.github.com/users/garlick/received_events","type":"User","site_admin":false},"comments":23,"review_comments":0,"commits":3,"additions":49,"deletions":10,"changed_files":5}}