{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/mantle/pulls/comments/48317153","id":48317153,"diff_hunk":"@@ -48,6 +48,8 @@ type Request struct {\n \n func NewRequest() *Request {\n \treturn &Request{\n+\t\t// silly hack, xml's Encoder doesn't want to set this.","path":"network/omaha/protocol.go","position":4,"original_position":4,"commit_id":"610c8f055ce69d5232e7a0ec9c74baeb9228a1ce","original_commit_id":"610c8f055ce69d5232e7a0ec9c74baeb9228a1ce","user":{"login":"marineam","id":153640,"avatar_url":"https://avatars.githubusercontent.com/u/153640?v=3","gravatar_id":"","url":"https://api.github.com/users/marineam","html_url":"https://github.com/marineam","followers_url":"https://api.github.com/users/marineam/followers","following_url":"https://api.github.com/users/marineam/following{/other_user}","gists_url":"https://api.github.com/users/marineam/gists{/gist_id}","starred_url":"https://api.github.com/users/marineam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marineam/subscriptions","organizations_url":"https://api.github.com/users/marineam/orgs","repos_url":"https://api.github.com/users/marineam/repos","events_url":"https://api.github.com/users/marineam/events{/privacy}","received_events_url":"https://api.github.com/users/marineam/received_events","type":"User","site_admin":false},"body":"Ah, ok. Well this has nothing to do with the encoder which obviously has no business modifying the structure given to it. So either update the comment to clarify that it is required to ensure consistency with the output of the decoder or add it to the test itself since a full struct comparison is the only place this would ever matter.","created_at":"2015-12-23T01:58:02Z","updated_at":"2015-12-23T01:58:02Z","html_url":"https://github.com/coreos/mantle/pull/217#discussion_r48317153","pull_request_url":"https://api.github.com/repos/coreos/mantle/pulls/217","_links":{"self":{"href":"https://api.github.com/repos/coreos/mantle/pulls/comments/48317153"},"html":{"href":"https://github.com/coreos/mantle/pull/217#discussion_r48317153"},"pull_request":{"href":"https://api.github.com/repos/coreos/mantle/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/mantle/pulls/217","id":54421646,"html_url":"https://github.com/coreos/mantle/pull/217","diff_url":"https://github.com/coreos/mantle/pull/217.diff","patch_url":"https://github.com/coreos/mantle/pull/217.patch","issue_url":"https://api.github.com/repos/coreos/mantle/issues/217","number":217,"state":"open","locked":false,"title":"network/omaha: add no-op server","user":{"login":"mischief","id":1487996,"avatar_url":"https://avatars.githubusercontent.com/u/1487996?v=3","gravatar_id":"","url":"https://api.github.com/users/mischief","html_url":"https://github.com/mischief","followers_url":"https://api.github.com/users/mischief/followers","following_url":"https://api.github.com/users/mischief/following{/other_user}","gists_url":"https://api.github.com/users/mischief/gists{/gist_id}","starred_url":"https://api.github.com/users/mischief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischief/subscriptions","organizations_url":"https://api.github.com/users/mischief/orgs","repos_url":"https://api.github.com/users/mischief/repos","events_url":"https://api.github.com/users/mischief/events{/privacy}","received_events_url":"https://api.github.com/users/mischief/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-22T22:19:43Z","updated_at":"2015-12-23T01:58:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6c40a09896a340732d0f133f257ba99afb1f9f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/mantle/pulls/217/commits","review_comments_url":"https://api.github.com/repos/coreos/mantle/pulls/217/comments","review_comment_url":"https://api.github.com/repos/coreos/mantle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/mantle/issues/217/comments","statuses_url":"https://api.github.com/repos/coreos/mantle/statuses/610c8f055ce69d5232e7a0ec9c74baeb9228a1ce","head":{"label":"mischief:omaha","ref":"omaha","sha":"610c8f055ce69d5232e7a0ec9c74baeb9228a1ce","user":{"login":"mischief","id":1487996,"avatar_url":"https://avatars.githubusercontent.com/u/1487996?v=3","gravatar_id":"","url":"https://api.github.com/users/mischief","html_url":"https://github.com/mischief","followers_url":"https://api.github.com/users/mischief/followers","following_url":"https://api.github.com/users/mischief/following{/other_user}","gists_url":"https://api.github.com/users/mischief/gists{/gist_id}","starred_url":"https://api.github.com/users/mischief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischief/subscriptions","organizations_url":"https://api.github.com/users/mischief/orgs","repos_url":"https://api.github.com/users/mischief/repos","events_url":"https://api.github.com/users/mischief/events{/privacy}","received_events_url":"https://api.github.com/users/mischief/received_events","type":"User","site_admin":false},"repo":{"id":32429070,"name":"mantle","full_name":"mischief/mantle","owner":{"login":"mischief","id":1487996,"avatar_url":"https://avatars.githubusercontent.com/u/1487996?v=3","gravatar_id":"","url":"https://api.github.com/users/mischief","html_url":"https://github.com/mischief","followers_url":"https://api.github.com/users/mischief/followers","following_url":"https://api.github.com/users/mischief/following{/other_user}","gists_url":"https://api.github.com/users/mischief/gists{/gist_id}","starred_url":"https://api.github.com/users/mischief/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mischief/subscriptions","organizations_url":"https://api.github.com/users/mischief/orgs","repos_url":"https://api.github.com/users/mischief/repos","events_url":"https://api.github.com/users/mischief/events{/privacy}","received_events_url":"https://api.github.com/users/mischief/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mischief/mantle","description":"Mantle: Gluing CoreOS together","fork":true,"url":"https://api.github.com/repos/mischief/mantle","forks_url":"https://api.github.com/repos/mischief/mantle/forks","keys_url":"https://api.github.com/repos/mischief/mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mischief/mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mischief/mantle/teams","hooks_url":"https://api.github.com/repos/mischief/mantle/hooks","issue_events_url":"https://api.github.com/repos/mischief/mantle/issues/events{/number}","events_url":"https://api.github.com/repos/mischief/mantle/events","assignees_url":"https://api.github.com/repos/mischief/mantle/assignees{/user}","branches_url":"https://api.github.com/repos/mischief/mantle/branches{/branch}","tags_url":"https://api.github.com/repos/mischief/mantle/tags","blobs_url":"https://api.github.com/repos/mischief/mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mischief/mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mischief/mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/mischief/mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mischief/mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/mischief/mantle/languages","stargazers_url":"https://api.github.com/repos/mischief/mantle/stargazers","contributors_url":"https://api.github.com/repos/mischief/mantle/contributors","subscribers_url":"https://api.github.com/repos/mischief/mantle/subscribers","subscription_url":"https://api.github.com/repos/mischief/mantle/subscription","commits_url":"https://api.github.com/repos/mischief/mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/mischief/mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/mischief/mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/mischief/mantle/issues/comments{/number}","contents_url":"https://api.github.com/repos/mischief/mantle/contents/{+path}","compare_url":"https://api.github.com/repos/mischief/mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mischief/mantle/merges","archive_url":"https://api.github.com/repos/mischief/mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mischief/mantle/downloads","issues_url":"https://api.github.com/repos/mischief/mantle/issues{/number}","pulls_url":"https://api.github.com/repos/mischief/mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/mischief/mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/mischief/mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mischief/mantle/labels{/name}","releases_url":"https://api.github.com/repos/mischief/mantle/releases{/id}","created_at":"2015-03-18T00:47:11Z","updated_at":"2015-03-18T00:47:12Z","pushed_at":"2015-12-22T22:38:26Z","git_url":"git://github.com/mischief/mantle.git","ssh_url":"git@github.com:mischief/mantle.git","clone_url":"https://github.com/mischief/mantle.git","svn_url":"https://github.com/mischief/mantle","homepage":"","size":13710,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"6293e66277db123e742ef3257e9633931cbe3785","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":27562362,"name":"mantle","full_name":"coreos/mantle","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/mantle","description":"Mantle: Gluing CoreOS together","fork":false,"url":"https://api.github.com/repos/coreos/mantle","forks_url":"https://api.github.com/repos/coreos/mantle/forks","keys_url":"https://api.github.com/repos/coreos/mantle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/mantle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/mantle/teams","hooks_url":"https://api.github.com/repos/coreos/mantle/hooks","issue_events_url":"https://api.github.com/repos/coreos/mantle/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/mantle/events","assignees_url":"https://api.github.com/repos/coreos/mantle/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/mantle/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/mantle/tags","blobs_url":"https://api.github.com/repos/coreos/mantle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/mantle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/mantle/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/mantle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/mantle/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/mantle/languages","stargazers_url":"https://api.github.com/repos/coreos/mantle/stargazers","contributors_url":"https://api.github.com/repos/coreos/mantle/contributors","subscribers_url":"https://api.github.com/repos/coreos/mantle/subscribers","subscription_url":"https://api.github.com/repos/coreos/mantle/subscription","commits_url":"https://api.github.com/repos/coreos/mantle/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/mantle/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/mantle/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/mantle/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/mantle/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/mantle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/mantle/merges","archive_url":"https://api.github.com/repos/coreos/mantle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/mantle/downloads","issues_url":"https://api.github.com/repos/coreos/mantle/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/mantle/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/mantle/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/mantle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/mantle/labels{/name}","releases_url":"https://api.github.com/repos/coreos/mantle/releases{/id}","created_at":"2014-12-04T22:09:02Z","updated_at":"2015-12-09T07:35:12Z","pushed_at":"2015-12-22T22:39:01Z","git_url":"git://github.com/coreos/mantle.git","ssh_url":"git@github.com:coreos/mantle.git","clone_url":"https://github.com/coreos/mantle.git","svn_url":"https://github.com/coreos/mantle","homepage":"","size":13748,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":23,"forks":11,"open_issues":23,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/mantle/pulls/217"},"html":{"href":"https://github.com/coreos/mantle/pull/217"},"issue":{"href":"https://api.github.com/repos/coreos/mantle/issues/217"},"comments":{"href":"https://api.github.com/repos/coreos/mantle/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/mantle/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/mantle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/mantle/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/mantle/statuses/610c8f055ce69d5232e7a0ec9c74baeb9228a1ce"}}}}