{"action":"created","issue":{"url":"https://api.github.com/repos/zeapo/Android-Password-Store/issues/148","labels_url":"https://api.github.com/repos/zeapo/Android-Password-Store/issues/148/labels{/name}","comments_url":"https://api.github.com/repos/zeapo/Android-Password-Store/issues/148/comments","events_url":"https://api.github.com/repos/zeapo/Android-Password-Store/issues/148/events","html_url":"https://github.com/zeapo/Android-Password-Store/issues/148","id":118174356,"number":148,"title":"Please do not use bare external directory as a place to store the database","user":{"login":"amtlib-dot-dll","id":8613971,"avatar_url":"https://avatars.githubusercontent.com/u/8613971?v=3","gravatar_id":"","url":"https://api.github.com/users/amtlib-dot-dll","html_url":"https://github.com/amtlib-dot-dll","followers_url":"https://api.github.com/users/amtlib-dot-dll/followers","following_url":"https://api.github.com/users/amtlib-dot-dll/following{/other_user}","gists_url":"https://api.github.com/users/amtlib-dot-dll/gists{/gist_id}","starred_url":"https://api.github.com/users/amtlib-dot-dll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amtlib-dot-dll/subscriptions","organizations_url":"https://api.github.com/users/amtlib-dot-dll/orgs","repos_url":"https://api.github.com/users/amtlib-dot-dll/repos","events_url":"https://api.github.com/users/amtlib-dot-dll/events{/privacy}","received_events_url":"https://api.github.com/users/amtlib-dot-dll/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-21T06:29:48Z","updated_at":"2015-11-21T09:38:31Z","closed_at":null,"body":"I just come to use this application. The default location for external database is `/sdcard`.\r\n\r\nAnd I want a fresh restart, so I pressed \"Delete Repository\", and all of my data was lost. The `/sdcard` directory is treated by the application as the database to purge.\r\n\r\nThere shall be many choices to circumvent this.\r\n\r\nFor me I should backup my photos and documents to the hard drive regularly, because cloud synchronization costs too much here.\r\n\r\nHOWEVER, FOR THE DEVELOPERS OF THIS APPLICATION, I SUGGEST THAT THE DATABASE SHOULD BE STORED IN A SPECIFIC PLACE, EITHER INSIDE `/data/data/com.zeapo.pwdstore` OR INSIDE `/sdcard/Android/data/com.zeapo.pwdstore`, AND THERE SHOULD BE A METHOD TO BARELY EXPORT THE DATABASE OUT BECAUSE SOME USERS, LIKE ME, HAVE NO GIT REPOSITORY TO SYNCHRONIZE. YOU MAY USE THE STORAGE ACCESS FRAMEWORK WHICH IS SUGGESTED BY GOOGLE. THANK YOU VERY MUCH.\r\n\r\nSorry for my bad temper, and if you feel hard to read the capitalized text you may use some tools to convert it. Thank you again and I won't use this application any more until any change.\r\n"},"comment":{"url":"https://api.github.com/repos/zeapo/Android-Password-Store/issues/comments/158617076","html_url":"https://github.com/zeapo/Android-Password-Store/issues/148#issuecomment-158617076","issue_url":"https://api.github.com/repos/zeapo/Android-Password-Store/issues/148","id":158617076,"user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars.githubusercontent.com/u/13111288?v=3","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"created_at":"2015-11-21T09:38:31Z","updated_at":"2015-11-21T09:38:31Z","body":"Sorry this happened to you. #129 experienced the same thing. I have made it so that by default the app will create and choose a new empty folder, and when it prompts you to delete the folder it will show you what folder it is trying to delete. \r\n\r\nThe app makes the dangerous/wrong assumption that the user will choose some empty folder, even though the default choice is certainly not empty. Choosing 'Internal' at setup will store the data in /data/data/com.zeapo.pwdstore, and the purpose of 'External' is to give users full control over where to store the data. Since the app assumes that the directory it is deleting contains only data that was put there by the app itself, it should accept nothing but an empty directory at setup...I will add this check soon."}}