{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/timmybird/Elvira/pulls/1","id":51572597,"html_url":"https://github.com/timmybird/Elvira/pull/1","diff_url":"https://github.com/timmybird/Elvira/pull/1.diff","patch_url":"https://github.com/timmybird/Elvira/pull/1.patch","issue_url":"https://api.github.com/repos/timmybird/Elvira/issues/1","number":1,"state":"open","locked":false,"title":"Nu fungerar counter för frisparkar. Variabeln confirm fungerade inte …","user":{"login":"timmybird","id":15797332,"avatar_url":"https://avatars.githubusercontent.com/u/15797332?v=3","gravatar_id":"","url":"https://api.github.com/users/timmybird","html_url":"https://github.com/timmybird","followers_url":"https://api.github.com/users/timmybird/followers","following_url":"https://api.github.com/users/timmybird/following{/other_user}","gists_url":"https://api.github.com/users/timmybird/gists{/gist_id}","starred_url":"https://api.github.com/users/timmybird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmybird/subscriptions","organizations_url":"https://api.github.com/users/timmybird/orgs","repos_url":"https://api.github.com/users/timmybird/repos","events_url":"https://api.github.com/users/timmybird/events{/privacy}","received_events_url":"https://api.github.com/users/timmybird/received_events","type":"User","site_admin":false},"body":"…att använda så som vi ville för att confirm eller cancel knappar lyssnar först efter så klassen körs innan användaren hinner svara vilket gör att confirm=true/false inte uppfattades förrän nästa gång användaren tryckte på knappen. Detta är nu åtgärdat med en if-sats i confrmknappen..\r\n\r\nJag har lagt till en custom dialog layout som öppnas med två tillhörande Spinners när användaren anger att ett mål har gjorts. Dn första innehåller tidsangivelse (kan göras snyggare men valde spinner för nu) och sen populeras Pick player Spinnern med spelarna i respektive lag som hämtas för objektet FutsalTeam.\r\n\r\nVar tyvärr tvungen att ändra i klaserna för Player och Team då de angav att ID och NUMBER skulle vara int. I XML parsern läses allt in som Strings så därför ändrades jag dem till Strings i klasserna. Det är inget problem om det sen behövs int till lagring eller exporterande av data. Det sista tror jag absolut inte är ett problem då nummer som lagrats i String enkelt kan, om det ens behövs, göras om till int.\r\n\r\nFinns en del nya metoder så som XML parsen och även en ny confirmdialog. Sen har det givetvis tillkommit en del nya Strings värden och grejer för enklare användning.\r\n\r\nHar även lagt till en layoutfil för spinners. Man kan inte ändra textSize i Spinner objektet så som <Spinner..... android:textSize=\"storlek\"/> utan man måste ändra i en layoutfil. Denna heter spinner_item.","created_at":"2015-11-23T20:03:19Z","updated_at":"2015-11-23T20:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/timmybird/Elvira/pulls/1/commits","review_comments_url":"https://api.github.com/repos/timmybird/Elvira/pulls/1/comments","review_comment_url":"https://api.github.com/repos/timmybird/Elvira/pulls/comments{/number}","comments_url":"https://api.github.com/repos/timmybird/Elvira/issues/1/comments","statuses_url":"https://api.github.com/repos/timmybird/Elvira/statuses/b39023aa1c511e847068b1ac78a598c2aa9a668d","head":{"label":"timmybird:Robins_tryouts","ref":"Robins_tryouts","sha":"b39023aa1c511e847068b1ac78a598c2aa9a668d","user":{"login":"timmybird","id":15797332,"avatar_url":"https://avatars.githubusercontent.com/u/15797332?v=3","gravatar_id":"","url":"https://api.github.com/users/timmybird","html_url":"https://github.com/timmybird","followers_url":"https://api.github.com/users/timmybird/followers","following_url":"https://api.github.com/users/timmybird/following{/other_user}","gists_url":"https://api.github.com/users/timmybird/gists{/gist_id}","starred_url":"https://api.github.com/users/timmybird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmybird/subscriptions","organizations_url":"https://api.github.com/users/timmybird/orgs","repos_url":"https://api.github.com/users/timmybird/repos","events_url":"https://api.github.com/users/timmybird/events{/privacy}","received_events_url":"https://api.github.com/users/timmybird/received_events","type":"User","site_admin":false},"repo":{"id":45970999,"name":"Elvira","full_name":"timmybird/Elvira","owner":{"login":"timmybird","id":15797332,"avatar_url":"https://avatars.githubusercontent.com/u/15797332?v=3","gravatar_id":"","url":"https://api.github.com/users/timmybird","html_url":"https://github.com/timmybird","followers_url":"https://api.github.com/users/timmybird/followers","following_url":"https://api.github.com/users/timmybird/following{/other_user}","gists_url":"https://api.github.com/users/timmybird/gists{/gist_id}","starred_url":"https://api.github.com/users/timmybird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmybird/subscriptions","organizations_url":"https://api.github.com/users/timmybird/orgs","repos_url":"https://api.github.com/users/timmybird/repos","events_url":"https://api.github.com/users/timmybird/events{/privacy}","received_events_url":"https://api.github.com/users/timmybird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timmybird/Elvira","description":"","fork":false,"url":"https://api.github.com/repos/timmybird/Elvira","forks_url":"https://api.github.com/repos/timmybird/Elvira/forks","keys_url":"https://api.github.com/repos/timmybird/Elvira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timmybird/Elvira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timmybird/Elvira/teams","hooks_url":"https://api.github.com/repos/timmybird/Elvira/hooks","issue_events_url":"https://api.github.com/repos/timmybird/Elvira/issues/events{/number}","events_url":"https://api.github.com/repos/timmybird/Elvira/events","assignees_url":"https://api.github.com/repos/timmybird/Elvira/assignees{/user}","branches_url":"https://api.github.com/repos/timmybird/Elvira/branches{/branch}","tags_url":"https://api.github.com/repos/timmybird/Elvira/tags","blobs_url":"https://api.github.com/repos/timmybird/Elvira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timmybird/Elvira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timmybird/Elvira/git/refs{/sha}","trees_url":"https://api.github.com/repos/timmybird/Elvira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timmybird/Elvira/statuses/{sha}","languages_url":"https://api.github.com/repos/timmybird/Elvira/languages","stargazers_url":"https://api.github.com/repos/timmybird/Elvira/stargazers","contributors_url":"https://api.github.com/repos/timmybird/Elvira/contributors","subscribers_url":"https://api.github.com/repos/timmybird/Elvira/subscribers","subscription_url":"https://api.github.com/repos/timmybird/Elvira/subscription","commits_url":"https://api.github.com/repos/timmybird/Elvira/commits{/sha}","git_commits_url":"https://api.github.com/repos/timmybird/Elvira/git/commits{/sha}","comments_url":"https://api.github.com/repos/timmybird/Elvira/comments{/number}","issue_comment_url":"https://api.github.com/repos/timmybird/Elvira/issues/comments{/number}","contents_url":"https://api.github.com/repos/timmybird/Elvira/contents/{+path}","compare_url":"https://api.github.com/repos/timmybird/Elvira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timmybird/Elvira/merges","archive_url":"https://api.github.com/repos/timmybird/Elvira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timmybird/Elvira/downloads","issues_url":"https://api.github.com/repos/timmybird/Elvira/issues{/number}","pulls_url":"https://api.github.com/repos/timmybird/Elvira/pulls{/number}","milestones_url":"https://api.github.com/repos/timmybird/Elvira/milestones{/number}","notifications_url":"https://api.github.com/repos/timmybird/Elvira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timmybird/Elvira/labels{/name}","releases_url":"https://api.github.com/repos/timmybird/Elvira/releases{/id}","created_at":"2015-11-11T09:05:03Z","updated_at":"2015-11-11T09:05:28Z","pushed_at":"2015-11-23T18:58:48Z","git_url":"git://github.com/timmybird/Elvira.git","ssh_url":"git@github.com:timmybird/Elvira.git","clone_url":"https://github.com/timmybird/Elvira.git","svn_url":"https://github.com/timmybird/Elvira","homepage":null,"size":124,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"timmybird:master","ref":"master","sha":"27698094828e6f9f88d5a1e2f633177c105229ab","user":{"login":"timmybird","id":15797332,"avatar_url":"https://avatars.githubusercontent.com/u/15797332?v=3","gravatar_id":"","url":"https://api.github.com/users/timmybird","html_url":"https://github.com/timmybird","followers_url":"https://api.github.com/users/timmybird/followers","following_url":"https://api.github.com/users/timmybird/following{/other_user}","gists_url":"https://api.github.com/users/timmybird/gists{/gist_id}","starred_url":"https://api.github.com/users/timmybird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmybird/subscriptions","organizations_url":"https://api.github.com/users/timmybird/orgs","repos_url":"https://api.github.com/users/timmybird/repos","events_url":"https://api.github.com/users/timmybird/events{/privacy}","received_events_url":"https://api.github.com/users/timmybird/received_events","type":"User","site_admin":false},"repo":{"id":45970999,"name":"Elvira","full_name":"timmybird/Elvira","owner":{"login":"timmybird","id":15797332,"avatar_url":"https://avatars.githubusercontent.com/u/15797332?v=3","gravatar_id":"","url":"https://api.github.com/users/timmybird","html_url":"https://github.com/timmybird","followers_url":"https://api.github.com/users/timmybird/followers","following_url":"https://api.github.com/users/timmybird/following{/other_user}","gists_url":"https://api.github.com/users/timmybird/gists{/gist_id}","starred_url":"https://api.github.com/users/timmybird/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timmybird/subscriptions","organizations_url":"https://api.github.com/users/timmybird/orgs","repos_url":"https://api.github.com/users/timmybird/repos","events_url":"https://api.github.com/users/timmybird/events{/privacy}","received_events_url":"https://api.github.com/users/timmybird/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/timmybird/Elvira","description":"","fork":false,"url":"https://api.github.com/repos/timmybird/Elvira","forks_url":"https://api.github.com/repos/timmybird/Elvira/forks","keys_url":"https://api.github.com/repos/timmybird/Elvira/keys{/key_id}","collaborators_url":"https://api.github.com/repos/timmybird/Elvira/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/timmybird/Elvira/teams","hooks_url":"https://api.github.com/repos/timmybird/Elvira/hooks","issue_events_url":"https://api.github.com/repos/timmybird/Elvira/issues/events{/number}","events_url":"https://api.github.com/repos/timmybird/Elvira/events","assignees_url":"https://api.github.com/repos/timmybird/Elvira/assignees{/user}","branches_url":"https://api.github.com/repos/timmybird/Elvira/branches{/branch}","tags_url":"https://api.github.com/repos/timmybird/Elvira/tags","blobs_url":"https://api.github.com/repos/timmybird/Elvira/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/timmybird/Elvira/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/timmybird/Elvira/git/refs{/sha}","trees_url":"https://api.github.com/repos/timmybird/Elvira/git/trees{/sha}","statuses_url":"https://api.github.com/repos/timmybird/Elvira/statuses/{sha}","languages_url":"https://api.github.com/repos/timmybird/Elvira/languages","stargazers_url":"https://api.github.com/repos/timmybird/Elvira/stargazers","contributors_url":"https://api.github.com/repos/timmybird/Elvira/contributors","subscribers_url":"https://api.github.com/repos/timmybird/Elvira/subscribers","subscription_url":"https://api.github.com/repos/timmybird/Elvira/subscription","commits_url":"https://api.github.com/repos/timmybird/Elvira/commits{/sha}","git_commits_url":"https://api.github.com/repos/timmybird/Elvira/git/commits{/sha}","comments_url":"https://api.github.com/repos/timmybird/Elvira/comments{/number}","issue_comment_url":"https://api.github.com/repos/timmybird/Elvira/issues/comments{/number}","contents_url":"https://api.github.com/repos/timmybird/Elvira/contents/{+path}","compare_url":"https://api.github.com/repos/timmybird/Elvira/compare/{base}...{head}","merges_url":"https://api.github.com/repos/timmybird/Elvira/merges","archive_url":"https://api.github.com/repos/timmybird/Elvira/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/timmybird/Elvira/downloads","issues_url":"https://api.github.com/repos/timmybird/Elvira/issues{/number}","pulls_url":"https://api.github.com/repos/timmybird/Elvira/pulls{/number}","milestones_url":"https://api.github.com/repos/timmybird/Elvira/milestones{/number}","notifications_url":"https://api.github.com/repos/timmybird/Elvira/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/timmybird/Elvira/labels{/name}","releases_url":"https://api.github.com/repos/timmybird/Elvira/releases{/id}","created_at":"2015-11-11T09:05:03Z","updated_at":"2015-11-11T09:05:28Z","pushed_at":"2015-11-23T18:58:48Z","git_url":"git://github.com/timmybird/Elvira.git","ssh_url":"git@github.com:timmybird/Elvira.git","clone_url":"https://github.com/timmybird/Elvira.git","svn_url":"https://github.com/timmybird/Elvira","homepage":null,"size":124,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/timmybird/Elvira/pulls/1"},"html":{"href":"https://github.com/timmybird/Elvira/pull/1"},"issue":{"href":"https://api.github.com/repos/timmybird/Elvira/issues/1"},"comments":{"href":"https://api.github.com/repos/timmybird/Elvira/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/timmybird/Elvira/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/timmybird/Elvira/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/timmybird/Elvira/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/timmybird/Elvira/statuses/b39023aa1c511e847068b1ac78a598c2aa9a668d"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":407,"deletions":56,"changed_files":18}}