{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/35051524","id":35051524,"diff_hunk":"@@ -405,7 +409,11 @@ pub fn in_memory_type_of<'a, 'tcx>(cx: &CrateContext<'a, 'tcx>, t: Ty<'tcx>) ->\n       }\n       ty::TyStruct(did, ref substs) => {\n           if t.is_simd(cx.tcx()) {\n-              let llet = in_memory_type_of(cx, t.simd_type(cx.tcx()));\n+              let elem_ty = match t.simd_machine_type(cx.tcx()) {\n+                  Some(e) => e,\n+                  None => cx.sess().fatal(\"monomorphising SIMD type to an incompatible element\")","path":"src/librustc_trans/trans/type_of.rs","position":20,"original_position":20,"commit_id":"68fb46744a1225a471e7f304dd3ec4dcd9880538","original_commit_id":"964d589e99040afa9f430f6c138c98da5931637f","user":{"login":"eefriedman","id":12769964,"avatar_url":"https://avatars.githubusercontent.com/u/12769964?v=3","gravatar_id":"","url":"https://api.github.com/users/eefriedman","html_url":"https://github.com/eefriedman","followers_url":"https://api.github.com/users/eefriedman/followers","following_url":"https://api.github.com/users/eefriedman/following{/other_user}","gists_url":"https://api.github.com/users/eefriedman/gists{/gist_id}","starred_url":"https://api.github.com/users/eefriedman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eefriedman/subscriptions","organizations_url":"https://api.github.com/users/eefriedman/orgs","repos_url":"https://api.github.com/users/eefriedman/repos","events_url":"https://api.github.com/users/eefriedman/events{/privacy}","received_events_url":"https://api.github.com/users/eefriedman/received_events","type":"User","site_admin":false},"body":"Still not sure this is a great... but okay, I'll move the discussion.","created_at":"2015-07-20T22:24:36Z","updated_at":"2015-07-20T22:24:36Z","html_url":"https://github.com/rust-lang/rust/pull/27169#discussion_r35051524","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/27169","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/35051524"},"html":{"href":"https://github.com/rust-lang/rust/pull/27169#discussion_r35051524"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27169"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/27169","id":40392599,"html_url":"https://github.com/rust-lang/rust/pull/27169","diff_url":"https://github.com/rust-lang/rust/pull/27169.diff","patch_url":"https://github.com/rust-lang/rust/pull/27169.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/27169","number":27169,"state":"open","locked":false,"title":"SIMD groundwork part 1","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"body":"This implements https://github.com/rust-lang/rfcs/pull/1199 (except for doing all the platform intrinsics).\r\n\r\nThings remaining for SIMD (not necessarily in this PR):\r\n\r\n- [x] I (@huonw) am signed up to ensure the compiler matches the RFC, when it lands\r\n- [ ] the platform specific intrinsics aren't properly type checked at the moment (LLVM will throw a \"random\" assertion)\r\n- [ ] there's a lot of useful intrinsics that are missing, including whole platforms (mips, powerpc)\r\n- [ ] the target-feature `cfg` detection/adding is not so great at the moment\r\n- [ ] I think the platform specific intrinsics should go in their own `extern` ABI (i.e. not `\"rust-intrinsic\"`)\r\n\r\n(I'm adjusting the RFC to reflect the latter.)\r\n\r\nI think it would be very nice for this to land without requiring the RFC to land first, because of the first point, and because this is the only way for any further work to happen/be experimented with, without requiring people to build/install/multirust a compiler from a custom branch.\r\n\r\nr? @alexcrichton ","created_at":"2015-07-20T20:20:12Z","updated_at":"2015-07-20T22:24:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"992565d0315899eb43cd09b4f61b4922ffe43d8c","assignee":{"login":"alexcrichton","id":64996,"avatar_url":"https://avatars.githubusercontent.com/u/64996?v=3","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/27169/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/27169/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/27169/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/68fb46744a1225a471e7f304dd3ec4dcd9880538","head":{"label":"huonw:simd","ref":"simd","sha":"68fb46744a1225a471e7f304dd3ec4dcd9880538","user":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"repo":{"id":7084229,"name":"rust","full_name":"huonw/rust","owner":{"login":"huonw","id":1203825,"avatar_url":"https://avatars.githubusercontent.com/u/1203825?v=3","gravatar_id":"","url":"https://api.github.com/users/huonw","html_url":"https://github.com/huonw","followers_url":"https://api.github.com/users/huonw/followers","following_url":"https://api.github.com/users/huonw/following{/other_user}","gists_url":"https://api.github.com/users/huonw/gists{/gist_id}","starred_url":"https://api.github.com/users/huonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huonw/subscriptions","organizations_url":"https://api.github.com/users/huonw/orgs","repos_url":"https://api.github.com/users/huonw/repos","events_url":"https://api.github.com/users/huonw/events{/privacy}","received_events_url":"https://api.github.com/users/huonw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huonw/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/huonw/rust","forks_url":"https://api.github.com/repos/huonw/rust/forks","keys_url":"https://api.github.com/repos/huonw/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huonw/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huonw/rust/teams","hooks_url":"https://api.github.com/repos/huonw/rust/hooks","issue_events_url":"https://api.github.com/repos/huonw/rust/issues/events{/number}","events_url":"https://api.github.com/repos/huonw/rust/events","assignees_url":"https://api.github.com/repos/huonw/rust/assignees{/user}","branches_url":"https://api.github.com/repos/huonw/rust/branches{/branch}","tags_url":"https://api.github.com/repos/huonw/rust/tags","blobs_url":"https://api.github.com/repos/huonw/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huonw/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huonw/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/huonw/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huonw/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/huonw/rust/languages","stargazers_url":"https://api.github.com/repos/huonw/rust/stargazers","contributors_url":"https://api.github.com/repos/huonw/rust/contributors","subscribers_url":"https://api.github.com/repos/huonw/rust/subscribers","subscription_url":"https://api.github.com/repos/huonw/rust/subscription","commits_url":"https://api.github.com/repos/huonw/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/huonw/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/huonw/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/huonw/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/huonw/rust/contents/{+path}","compare_url":"https://api.github.com/repos/huonw/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huonw/rust/merges","archive_url":"https://api.github.com/repos/huonw/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huonw/rust/downloads","issues_url":"https://api.github.com/repos/huonw/rust/issues{/number}","pulls_url":"https://api.github.com/repos/huonw/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/huonw/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/huonw/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huonw/rust/labels{/name}","releases_url":"https://api.github.com/repos/huonw/rust/releases{/id}","created_at":"2012-12-09T22:12:58Z","updated_at":"2014-06-27T06:46:37Z","pushed_at":"2015-07-20T22:11:40Z","git_url":"git://github.com/huonw/rust.git","ssh_url":"git@github.com:huonw/rust.git","clone_url":"https://github.com/huonw/rust.git","svn_url":"https://github.com/huonw/rust","homepage":"http://www.rust-lang.org","size":306967,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"2fe870a5a7449643f5cf79c0d14d47888472c6ca","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-07-20T21:58:41Z","pushed_at":"2015-07-20T22:11:44Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":647537,"stargazers_count":12676,"watchers_count":12676,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2439,"mirror_url":null,"open_issues_count":2158,"forks":2439,"open_issues":2158,"watchers":12676,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27169"},"html":{"href":"https://github.com/rust-lang/rust/pull/27169"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27169"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/27169/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27169/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/27169/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/68fb46744a1225a471e7f304dd3ec4dcd9880538"}}}}