{"action":"opened","number":2941,"pull_request":{"url":"https://api.github.com/repos/opf/openproject/pulls/2941","id":34450739,"html_url":"https://github.com/opf/openproject/pull/2941","diff_url":"https://github.com/opf/openproject/pull/2941.diff","patch_url":"https://github.com/opf/openproject/pull/2941.patch","issue_url":"https://api.github.com/repos/opf/openproject/issues/2941","number":2941,"state":"open","locked":false,"title":"Allow bypassing basic auth for repository access authorization","user":{"login":"oliverguenther","id":459462,"avatar_url":"https://avatars.githubusercontent.com/u/459462?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverguenther","html_url":"https://github.com/oliverguenther","followers_url":"https://api.github.com/users/oliverguenther/followers","following_url":"https://api.github.com/users/oliverguenther/following{/other_user}","gists_url":"https://api.github.com/users/oliverguenther/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverguenther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverguenther/subscriptions","organizations_url":"https://api.github.com/users/oliverguenther/orgs","repos_url":"https://api.github.com/users/oliverguenther/repos","events_url":"https://api.github.com/users/oliverguenther/events{/privacy}","received_events_url":"https://api.github.com/users/oliverguenther/received_events","type":"User","site_admin":false},"body":"This is a follow-up of https://github.com/opf/openproject/pull/2449, as GitHub decided to mark my (very much existing) fork as `unknown repository` which I can no longer push to. Oh well.\r\n\r\n----- \r\n\r\nIn our use-case, we use RADIUS to authorize users through Apache\r\nin combination with an OmniAuth strategy.\r\n\r\nThus, we do not have an active authentication source to\r\nperform basic auth against and cannot use the existing `OpenProjectAuthentication.pm` Apache wrapper.\r\n\r\nThis commit adds an optional setting to allow bypassing\r\nbasic auth in the SysController.\r\nThe setting is placed right beside the API key (cf. screenshot below).\r\n\r\n![op_bypass](https://cloud.githubusercontent.com/assets/459462/7410198/f1a1812a-ef2c-11e4-872f-18f61169ebe9.png)\r\n\r\nIf the checkbox is checked, the surrounding web server is responsible for authentication. The sys API endpoint will still initiate a Basic Auth, however any password input is disregarded.\r\n\r\nI agree that this workaround feels rather hacky. An alternative solution that we might discuss is to remove basic auth completely for the bypass, and instead use a GET parameter alongside repository and key to set the user for which access rights are determined.\r\n\r\nHowever, putting any more efforts regarding authentication wrappers are questionable with the ongoing discussion and dire need to refactor the entire repository handling in OpenProject.\r\n\r\n\r\n\r\nWhen authorizing the user directly in the web server,\r\npassing the logged in user to SysController is sufficient\r\nto retrieve the project permissions.\r\n\r\nI suggest this as a temporary solution until the general issue of repositories and external authentication is resolved, as its discussion is still heavily ongoing.\r\n\r\nThe relevant work package:\r\nhttps://community.openproject.org/work_packages/18356\r\n","created_at":"2015-04-30T11:27:36Z","updated_at":"2015-04-30T11:27:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9123ae74a972e74ebae1f44fde10fd023fa2eac1","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/opf/openproject/pulls/2941/commits","review_comments_url":"https://api.github.com/repos/opf/openproject/pulls/2941/comments","review_comment_url":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opf/openproject/issues/2941/comments","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/39693f568b3de11ffc42481a3e95bedf20a959f3","head":{"label":"oliverguenther:feature/repo_auth_bypass","ref":"feature/repo_auth_bypass","sha":"39693f568b3de11ffc42481a3e95bedf20a959f3","user":{"login":"oliverguenther","id":459462,"avatar_url":"https://avatars.githubusercontent.com/u/459462?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverguenther","html_url":"https://github.com/oliverguenther","followers_url":"https://api.github.com/users/oliverguenther/followers","following_url":"https://api.github.com/users/oliverguenther/following{/other_user}","gists_url":"https://api.github.com/users/oliverguenther/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverguenther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverguenther/subscriptions","organizations_url":"https://api.github.com/users/oliverguenther/orgs","repos_url":"https://api.github.com/users/oliverguenther/repos","events_url":"https://api.github.com/users/oliverguenther/events{/privacy}","received_events_url":"https://api.github.com/users/oliverguenther/received_events","type":"User","site_admin":false},"repo":{"id":33988921,"name":"openproject","full_name":"oliverguenther/openproject","owner":{"login":"oliverguenther","id":459462,"avatar_url":"https://avatars.githubusercontent.com/u/459462?v=3","gravatar_id":"","url":"https://api.github.com/users/oliverguenther","html_url":"https://github.com/oliverguenther","followers_url":"https://api.github.com/users/oliverguenther/followers","following_url":"https://api.github.com/users/oliverguenther/following{/other_user}","gists_url":"https://api.github.com/users/oliverguenther/gists{/gist_id}","starred_url":"https://api.github.com/users/oliverguenther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliverguenther/subscriptions","organizations_url":"https://api.github.com/users/oliverguenther/orgs","repos_url":"https://api.github.com/users/oliverguenther/repos","events_url":"https://api.github.com/users/oliverguenther/events{/privacy}","received_events_url":"https://api.github.com/users/oliverguenther/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oliverguenther/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":true,"url":"https://api.github.com/repos/oliverguenther/openproject","forks_url":"https://api.github.com/repos/oliverguenther/openproject/forks","keys_url":"https://api.github.com/repos/oliverguenther/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oliverguenther/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oliverguenther/openproject/teams","hooks_url":"https://api.github.com/repos/oliverguenther/openproject/hooks","issue_events_url":"https://api.github.com/repos/oliverguenther/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/oliverguenther/openproject/events","assignees_url":"https://api.github.com/repos/oliverguenther/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/oliverguenther/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/oliverguenther/openproject/tags","blobs_url":"https://api.github.com/repos/oliverguenther/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oliverguenther/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oliverguenther/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/oliverguenther/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oliverguenther/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/oliverguenther/openproject/languages","stargazers_url":"https://api.github.com/repos/oliverguenther/openproject/stargazers","contributors_url":"https://api.github.com/repos/oliverguenther/openproject/contributors","subscribers_url":"https://api.github.com/repos/oliverguenther/openproject/subscribers","subscription_url":"https://api.github.com/repos/oliverguenther/openproject/subscription","commits_url":"https://api.github.com/repos/oliverguenther/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/oliverguenther/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/oliverguenther/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/oliverguenther/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/oliverguenther/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/oliverguenther/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oliverguenther/openproject/merges","archive_url":"https://api.github.com/repos/oliverguenther/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oliverguenther/openproject/downloads","issues_url":"https://api.github.com/repos/oliverguenther/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/oliverguenther/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/oliverguenther/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/oliverguenther/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oliverguenther/openproject/labels{/name}","releases_url":"https://api.github.com/repos/oliverguenther/openproject/releases{/id}","created_at":"2015-04-15T11:02:49Z","updated_at":"2015-04-15T11:02:57Z","pushed_at":"2015-04-30T09:22:52Z","git_url":"git://github.com/oliverguenther/openproject.git","ssh_url":"git@github.com:oliverguenther/openproject.git","clone_url":"https://github.com/oliverguenther/openproject.git","svn_url":"https://github.com/oliverguenther/openproject","homepage":"https://www.openproject.org","size":62992,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"opf:dev","ref":"dev","sha":"6d128f54aac068b31690479d71581fdfadfd036c","user":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"repo":{"id":6899875,"name":"openproject","full_name":"opf/openproject","owner":{"login":"opf","id":1756674,"avatar_url":"https://avatars.githubusercontent.com/u/1756674?v=3","gravatar_id":"","url":"https://api.github.com/users/opf","html_url":"https://github.com/opf","followers_url":"https://api.github.com/users/opf/followers","following_url":"https://api.github.com/users/opf/following{/other_user}","gists_url":"https://api.github.com/users/opf/gists{/gist_id}","starred_url":"https://api.github.com/users/opf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opf/subscriptions","organizations_url":"https://api.github.com/users/opf/orgs","repos_url":"https://api.github.com/users/opf/repos","events_url":"https://api.github.com/users/opf/events{/privacy}","received_events_url":"https://api.github.com/users/opf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opf/openproject","description":"OpenProject is a web-based project management system built on Ruby on Rails","fork":false,"url":"https://api.github.com/repos/opf/openproject","forks_url":"https://api.github.com/repos/opf/openproject/forks","keys_url":"https://api.github.com/repos/opf/openproject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opf/openproject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opf/openproject/teams","hooks_url":"https://api.github.com/repos/opf/openproject/hooks","issue_events_url":"https://api.github.com/repos/opf/openproject/issues/events{/number}","events_url":"https://api.github.com/repos/opf/openproject/events","assignees_url":"https://api.github.com/repos/opf/openproject/assignees{/user}","branches_url":"https://api.github.com/repos/opf/openproject/branches{/branch}","tags_url":"https://api.github.com/repos/opf/openproject/tags","blobs_url":"https://api.github.com/repos/opf/openproject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opf/openproject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opf/openproject/git/refs{/sha}","trees_url":"https://api.github.com/repos/opf/openproject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opf/openproject/statuses/{sha}","languages_url":"https://api.github.com/repos/opf/openproject/languages","stargazers_url":"https://api.github.com/repos/opf/openproject/stargazers","contributors_url":"https://api.github.com/repos/opf/openproject/contributors","subscribers_url":"https://api.github.com/repos/opf/openproject/subscribers","subscription_url":"https://api.github.com/repos/opf/openproject/subscription","commits_url":"https://api.github.com/repos/opf/openproject/commits{/sha}","git_commits_url":"https://api.github.com/repos/opf/openproject/git/commits{/sha}","comments_url":"https://api.github.com/repos/opf/openproject/comments{/number}","issue_comment_url":"https://api.github.com/repos/opf/openproject/issues/comments{/number}","contents_url":"https://api.github.com/repos/opf/openproject/contents/{+path}","compare_url":"https://api.github.com/repos/opf/openproject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opf/openproject/merges","archive_url":"https://api.github.com/repos/opf/openproject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opf/openproject/downloads","issues_url":"https://api.github.com/repos/opf/openproject/issues{/number}","pulls_url":"https://api.github.com/repos/opf/openproject/pulls{/number}","milestones_url":"https://api.github.com/repos/opf/openproject/milestones{/number}","notifications_url":"https://api.github.com/repos/opf/openproject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opf/openproject/labels{/name}","releases_url":"https://api.github.com/repos/opf/openproject/releases{/id}","created_at":"2012-11-28T09:59:11Z","updated_at":"2015-04-29T17:59:05Z","pushed_at":"2015-04-30T11:27:37Z","git_url":"git://github.com/opf/openproject.git","ssh_url":"git@github.com:opf/openproject.git","clone_url":"https://github.com/opf/openproject.git","svn_url":"https://github.com/opf/openproject","homepage":"https://www.openproject.org","size":192662,"stargazers_count":596,"watchers_count":596,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":262,"mirror_url":null,"open_issues_count":56,"forks":262,"open_issues":56,"watchers":596,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/opf/openproject/pulls/2941"},"html":{"href":"https://github.com/opf/openproject/pull/2941"},"issue":{"href":"https://api.github.com/repos/opf/openproject/issues/2941"},"comments":{"href":"https://api.github.com/repos/opf/openproject/issues/2941/comments"},"review_comments":{"href":"https://api.github.com/repos/opf/openproject/pulls/2941/comments"},"review_comment":{"href":"https://api.github.com/repos/opf/openproject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opf/openproject/pulls/2941/commits"},"statuses":{"href":"https://api.github.com/repos/opf/openproject/statuses/39693f568b3de11ffc42481a3e95bedf20a959f3"}},"merged":false,"mergeable":true,"mergeable_state":"clean","merged_by":null,"comments":1,"review_comments":0,"commits":2,"additions":77,"deletions":4,"changed_files":5}}