{"action":"created","comment":{"url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/comments/37247595","id":37247595,"diff_hunk":"@@ -55,6 +51,14 @@ function plistPaths (sim, identifier) {\n   return paths;\n }\n \n+async function updateSettings (sim, plist, updates) {\n+  log.debug(`Updating settings for ${plist}`);\n+  let paths = plistPaths(sim, plist);\n+  for (let path of paths) {\n+    await update(path, updates);","path":"lib/settings.js","position":22,"original_position":22,"commit_id":"ea4627e114ce9096cd69e539417bc665ef1b31ad","original_commit_id":"ea4627e114ce9096cd69e539417bc665ef1b31ad","user":{"login":"jlipps","id":605053,"avatar_url":"https://avatars.githubusercontent.com/u/605053?v=3","gravatar_id":"","url":"https://api.github.com/users/jlipps","html_url":"https://github.com/jlipps","followers_url":"https://api.github.com/users/jlipps/followers","following_url":"https://api.github.com/users/jlipps/following{/other_user}","gists_url":"https://api.github.com/users/jlipps/gists{/gist_id}","starred_url":"https://api.github.com/users/jlipps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlipps/subscriptions","organizations_url":"https://api.github.com/users/jlipps/orgs","repos_url":"https://api.github.com/users/jlipps/repos","events_url":"https://api.github.com/users/jlipps/events{/privacy}","received_events_url":"https://api.github.com/users/jlipps/received_events","type":"User","site_admin":false},"body":"can these run in parallel? or is that too dangerous","created_at":"2015-08-17T23:04:07Z","updated_at":"2015-08-17T23:04:07Z","html_url":"https://github.com/appium/appium-ios-simulator/pull/5#discussion_r37247595","pull_request_url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5","_links":{"self":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/comments/37247595"},"html":{"href":"https://github.com/appium/appium-ios-simulator/pull/5#discussion_r37247595"},"pull_request":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5","id":42632437,"html_url":"https://github.com/appium/appium-ios-simulator/pull/5","diff_url":"https://github.com/appium/appium-ios-simulator/pull/5.diff","patch_url":"https://github.com/appium/appium-ios-simulator/pull/5.patch","issue_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues/5","number":5,"state":"open","locked":false,"title":"Add update methods for safari and general settings","user":{"login":"imurchie","id":2614354,"avatar_url":"https://avatars.githubusercontent.com/u/2614354?v=3","gravatar_id":"","url":"https://api.github.com/users/imurchie","html_url":"https://github.com/imurchie","followers_url":"https://api.github.com/users/imurchie/followers","following_url":"https://api.github.com/users/imurchie/following{/other_user}","gists_url":"https://api.github.com/users/imurchie/gists{/gist_id}","starred_url":"https://api.github.com/users/imurchie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/imurchie/subscriptions","organizations_url":"https://api.github.com/users/imurchie/orgs","repos_url":"https://api.github.com/users/imurchie/repos","events_url":"https://api.github.com/users/imurchie/events{/privacy}","received_events_url":"https://api.github.com/users/imurchie/received_events","type":"User","site_admin":false},"body":"Use `appium-support` plist methods, and add a way to update the settings in general, and the safari user settings in particular.","created_at":"2015-08-17T20:49:24Z","updated_at":"2015-08-17T23:04:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe826d79b2f1f82d74f3e181f7c3cb26ba00249","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5/commits","review_comments_url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5/comments","review_comment_url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues/5/comments","statuses_url":"https://api.github.com/repos/appium/appium-ios-simulator/statuses/ea4627e114ce9096cd69e539417bc665ef1b31ad","head":{"label":"appium:isaac-updateSettings","ref":"isaac-updateSettings","sha":"ea4627e114ce9096cd69e539417bc665ef1b31ad","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":37160772,"name":"appium-ios-simulator","full_name":"appium/appium-ios-simulator","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-ios-simulator","description":"Module for interacting with iOS simulators (mainly directory-specific manipulations)","fork":false,"url":"https://api.github.com/repos/appium/appium-ios-simulator","forks_url":"https://api.github.com/repos/appium/appium-ios-simulator/forks","keys_url":"https://api.github.com/repos/appium/appium-ios-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-ios-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-ios-simulator/teams","hooks_url":"https://api.github.com/repos/appium/appium-ios-simulator/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-ios-simulator/events","assignees_url":"https://api.github.com/repos/appium/appium-ios-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-ios-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-ios-simulator/tags","blobs_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-ios-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-ios-simulator/languages","stargazers_url":"https://api.github.com/repos/appium/appium-ios-simulator/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-ios-simulator/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-ios-simulator/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-ios-simulator/subscription","commits_url":"https://api.github.com/repos/appium/appium-ios-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-ios-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-ios-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-ios-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-ios-simulator/merges","archive_url":"https://api.github.com/repos/appium/appium-ios-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-ios-simulator/downloads","issues_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-ios-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-ios-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-ios-simulator/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-ios-simulator/releases{/id}","created_at":"2015-06-09T21:55:59Z","updated_at":"2015-06-09T21:56:25Z","pushed_at":"2015-08-17T21:33:50Z","git_url":"git://github.com/appium/appium-ios-simulator.git","ssh_url":"git@github.com:appium/appium-ios-simulator.git","clone_url":"https://github.com/appium/appium-ios-simulator.git","svn_url":"https://github.com/appium/appium-ios-simulator","homepage":null,"size":224,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"appium:master","ref":"master","sha":"172a52e6fd843412724ed0a42553ada7c9d57fda","user":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"repo":{"id":37160772,"name":"appium-ios-simulator","full_name":"appium/appium-ios-simulator","owner":{"login":"appium","id":3221291,"avatar_url":"https://avatars.githubusercontent.com/u/3221291?v=3","gravatar_id":"","url":"https://api.github.com/users/appium","html_url":"https://github.com/appium","followers_url":"https://api.github.com/users/appium/followers","following_url":"https://api.github.com/users/appium/following{/other_user}","gists_url":"https://api.github.com/users/appium/gists{/gist_id}","starred_url":"https://api.github.com/users/appium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appium/subscriptions","organizations_url":"https://api.github.com/users/appium/orgs","repos_url":"https://api.github.com/users/appium/repos","events_url":"https://api.github.com/users/appium/events{/privacy}","received_events_url":"https://api.github.com/users/appium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appium/appium-ios-simulator","description":"Module for interacting with iOS simulators (mainly directory-specific manipulations)","fork":false,"url":"https://api.github.com/repos/appium/appium-ios-simulator","forks_url":"https://api.github.com/repos/appium/appium-ios-simulator/forks","keys_url":"https://api.github.com/repos/appium/appium-ios-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appium/appium-ios-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appium/appium-ios-simulator/teams","hooks_url":"https://api.github.com/repos/appium/appium-ios-simulator/hooks","issue_events_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/appium/appium-ios-simulator/events","assignees_url":"https://api.github.com/repos/appium/appium-ios-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/appium/appium-ios-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/appium/appium-ios-simulator/tags","blobs_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appium/appium-ios-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/appium/appium-ios-simulator/languages","stargazers_url":"https://api.github.com/repos/appium/appium-ios-simulator/stargazers","contributors_url":"https://api.github.com/repos/appium/appium-ios-simulator/contributors","subscribers_url":"https://api.github.com/repos/appium/appium-ios-simulator/subscribers","subscription_url":"https://api.github.com/repos/appium/appium-ios-simulator/subscription","commits_url":"https://api.github.com/repos/appium/appium-ios-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/appium/appium-ios-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/appium/appium-ios-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/appium/appium-ios-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/appium/appium-ios-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appium/appium-ios-simulator/merges","archive_url":"https://api.github.com/repos/appium/appium-ios-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appium/appium-ios-simulator/downloads","issues_url":"https://api.github.com/repos/appium/appium-ios-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/appium/appium-ios-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/appium/appium-ios-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/appium/appium-ios-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appium/appium-ios-simulator/labels{/name}","releases_url":"https://api.github.com/repos/appium/appium-ios-simulator/releases{/id}","created_at":"2015-06-09T21:55:59Z","updated_at":"2015-06-09T21:56:25Z","pushed_at":"2015-08-17T21:33:50Z","git_url":"git://github.com/appium/appium-ios-simulator.git","ssh_url":"git@github.com:appium/appium-ios-simulator.git","clone_url":"https://github.com/appium/appium-ios-simulator.git","svn_url":"https://github.com/appium/appium-ios-simulator","homepage":null,"size":224,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5"},"html":{"href":"https://github.com/appium/appium-ios-simulator/pull/5"},"issue":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/issues/5"},"comments":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/appium/appium-ios-simulator/statuses/ea4627e114ce9096cd69e539417bc665ef1b31ad"}}}}