{"action":"created","comment":{"url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/comments/28946707","id":28946707,"diff_hunk":"@@ -0,0 +1,17 @@\n+\n+parameters:\n+    aerial_ship_saml_sp.state.store.sso.class: AerialShip\\SamlSPBundle\\Doctrine\\SSOStateStore\n+    aerial_ship_saml_sp.backend_type_mongodb: 1\n+\n+services:\n+    # factory will be set in bundle extension, listed here to be used as a reference in other services\n+    aerial_ship_saml_sp.document_manager:\n+        class: Doctrine\\ODM\\MongoDB\\DocumentManager\n+        arguments:\n+            - %aerial_ship_saml_sp.model_manager_name% # not realy used since factory is set in extension\n+        public: false\n+\n+    aerial_ship_saml_sp.state.store.sso:\n+        class: %aerial_ship_saml_sp.state.store.sso.class%","path":"src/AerialShip/SamlSPBundle/Resources/config/mongodb.yml","position":15,"original_position":15,"commit_id":"40fc230d7000fe6625819343c1e6b1a5c490843b","original_commit_id":"40fc230d7000fe6625819343c1e6b1a5c490843b","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"I suggest not using parameters for the service class. Symfony deprecated this practices (services added in Symfony 2.6+ don't use this pattern anymore, and Symfony 3.0 will change all existing services)","created_at":"2015-04-23T08:58:19Z","updated_at":"2015-04-23T08:58:19Z","html_url":"https://github.com/aerialship/SamlSPBundle/pull/83#discussion_r28946707","pull_request_url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83","_links":{"self":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/comments/28946707"},"html":{"href":"https://github.com/aerialship/SamlSPBundle/pull/83#discussion_r28946707"},"pull_request":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83","id":33918051,"html_url":"https://github.com/aerialship/SamlSPBundle/pull/83","diff_url":"https://github.com/aerialship/SamlSPBundle/pull/83.diff","patch_url":"https://github.com/aerialship/SamlSPBundle/pull/83.patch","issue_url":"https://api.github.com/repos/aerialship/SamlSPBundle/issues/83","number":83,"state":"open","locked":false,"title":"Add doctrine odm support to be able to use mongodb #70","user":{"login":"tmilos","id":1818373,"avatar_url":"https://avatars.githubusercontent.com/u/1818373?v=3","gravatar_id":"","url":"https://api.github.com/users/tmilos","html_url":"https://github.com/tmilos","followers_url":"https://api.github.com/users/tmilos/followers","following_url":"https://api.github.com/users/tmilos/following{/other_user}","gists_url":"https://api.github.com/users/tmilos/gists{/gist_id}","starred_url":"https://api.github.com/users/tmilos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmilos/subscriptions","organizations_url":"https://api.github.com/users/tmilos/orgs","repos_url":"https://api.github.com/users/tmilos/repos","events_url":"https://api.github.com/users/tmilos/events{/privacy}","received_events_url":"https://api.github.com/users/tmilos/received_events","type":"User","site_admin":false},"body":"PR for #70\r\nThink @stof in #71 and #81 meant about something like this.\r\ncc @BernardoSilva @fnash\r\nPlease review if this can replace replace PR #71 and and #58 \r\nNote that I have tested it only with orm since I don't have mongo enabled environment. \r\n","created_at":"2015-04-23T01:57:20Z","updated_at":"2015-04-23T08:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25cf656c57ec31c8ef5cf65083e49b9cd9caa0c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83/commits","review_comments_url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83/comments","review_comment_url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aerialship/SamlSPBundle/issues/83/comments","statuses_url":"https://api.github.com/repos/aerialship/SamlSPBundle/statuses/40fc230d7000fe6625819343c1e6b1a5c490843b","head":{"label":"tmilos:mongodb","ref":"mongodb","sha":"40fc230d7000fe6625819343c1e6b1a5c490843b","user":{"login":"tmilos","id":1818373,"avatar_url":"https://avatars.githubusercontent.com/u/1818373?v=3","gravatar_id":"","url":"https://api.github.com/users/tmilos","html_url":"https://github.com/tmilos","followers_url":"https://api.github.com/users/tmilos/followers","following_url":"https://api.github.com/users/tmilos/following{/other_user}","gists_url":"https://api.github.com/users/tmilos/gists{/gist_id}","starred_url":"https://api.github.com/users/tmilos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmilos/subscriptions","organizations_url":"https://api.github.com/users/tmilos/orgs","repos_url":"https://api.github.com/users/tmilos/repos","events_url":"https://api.github.com/users/tmilos/events{/privacy}","received_events_url":"https://api.github.com/users/tmilos/received_events","type":"User","site_admin":false},"repo":{"id":34416497,"name":"SamlSPBundle","full_name":"tmilos/SamlSPBundle","owner":{"login":"tmilos","id":1818373,"avatar_url":"https://avatars.githubusercontent.com/u/1818373?v=3","gravatar_id":"","url":"https://api.github.com/users/tmilos","html_url":"https://github.com/tmilos","followers_url":"https://api.github.com/users/tmilos/followers","following_url":"https://api.github.com/users/tmilos/following{/other_user}","gists_url":"https://api.github.com/users/tmilos/gists{/gist_id}","starred_url":"https://api.github.com/users/tmilos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmilos/subscriptions","organizations_url":"https://api.github.com/users/tmilos/orgs","repos_url":"https://api.github.com/users/tmilos/repos","events_url":"https://api.github.com/users/tmilos/events{/privacy}","received_events_url":"https://api.github.com/users/tmilos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmilos/SamlSPBundle","description":"","fork":true,"url":"https://api.github.com/repos/tmilos/SamlSPBundle","forks_url":"https://api.github.com/repos/tmilos/SamlSPBundle/forks","keys_url":"https://api.github.com/repos/tmilos/SamlSPBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmilos/SamlSPBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmilos/SamlSPBundle/teams","hooks_url":"https://api.github.com/repos/tmilos/SamlSPBundle/hooks","issue_events_url":"https://api.github.com/repos/tmilos/SamlSPBundle/issues/events{/number}","events_url":"https://api.github.com/repos/tmilos/SamlSPBundle/events","assignees_url":"https://api.github.com/repos/tmilos/SamlSPBundle/assignees{/user}","branches_url":"https://api.github.com/repos/tmilos/SamlSPBundle/branches{/branch}","tags_url":"https://api.github.com/repos/tmilos/SamlSPBundle/tags","blobs_url":"https://api.github.com/repos/tmilos/SamlSPBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmilos/SamlSPBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmilos/SamlSPBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmilos/SamlSPBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmilos/SamlSPBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/tmilos/SamlSPBundle/languages","stargazers_url":"https://api.github.com/repos/tmilos/SamlSPBundle/stargazers","contributors_url":"https://api.github.com/repos/tmilos/SamlSPBundle/contributors","subscribers_url":"https://api.github.com/repos/tmilos/SamlSPBundle/subscribers","subscription_url":"https://api.github.com/repos/tmilos/SamlSPBundle/subscription","commits_url":"https://api.github.com/repos/tmilos/SamlSPBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmilos/SamlSPBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmilos/SamlSPBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmilos/SamlSPBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmilos/SamlSPBundle/contents/{+path}","compare_url":"https://api.github.com/repos/tmilos/SamlSPBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmilos/SamlSPBundle/merges","archive_url":"https://api.github.com/repos/tmilos/SamlSPBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmilos/SamlSPBundle/downloads","issues_url":"https://api.github.com/repos/tmilos/SamlSPBundle/issues{/number}","pulls_url":"https://api.github.com/repos/tmilos/SamlSPBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/tmilos/SamlSPBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/tmilos/SamlSPBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmilos/SamlSPBundle/labels{/name}","releases_url":"https://api.github.com/repos/tmilos/SamlSPBundle/releases{/id}","created_at":"2015-04-22T21:18:51Z","updated_at":"2015-04-22T21:18:52Z","pushed_at":"2015-04-23T01:52:51Z","git_url":"git://github.com/tmilos/SamlSPBundle.git","ssh_url":"git@github.com:tmilos/SamlSPBundle.git","clone_url":"https://github.com/tmilos/SamlSPBundle.git","svn_url":"https://github.com/tmilos/SamlSPBundle","homepage":null,"size":958,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aerialship:master","ref":"master","sha":"158c87311e2d76a8dcaffa32bdd15dc3b6aa8024","user":{"login":"aerialship","id":5762640,"avatar_url":"https://avatars.githubusercontent.com/u/5762640?v=3","gravatar_id":"","url":"https://api.github.com/users/aerialship","html_url":"https://github.com/aerialship","followers_url":"https://api.github.com/users/aerialship/followers","following_url":"https://api.github.com/users/aerialship/following{/other_user}","gists_url":"https://api.github.com/users/aerialship/gists{/gist_id}","starred_url":"https://api.github.com/users/aerialship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerialship/subscriptions","organizations_url":"https://api.github.com/users/aerialship/orgs","repos_url":"https://api.github.com/users/aerialship/repos","events_url":"https://api.github.com/users/aerialship/events{/privacy}","received_events_url":"https://api.github.com/users/aerialship/received_events","type":"Organization","site_admin":false},"repo":{"id":14365634,"name":"SamlSPBundle","full_name":"aerialship/SamlSPBundle","owner":{"login":"aerialship","id":5762640,"avatar_url":"https://avatars.githubusercontent.com/u/5762640?v=3","gravatar_id":"","url":"https://api.github.com/users/aerialship","html_url":"https://github.com/aerialship","followers_url":"https://api.github.com/users/aerialship/followers","following_url":"https://api.github.com/users/aerialship/following{/other_user}","gists_url":"https://api.github.com/users/aerialship/gists{/gist_id}","starred_url":"https://api.github.com/users/aerialship/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerialship/subscriptions","organizations_url":"https://api.github.com/users/aerialship/orgs","repos_url":"https://api.github.com/users/aerialship/repos","events_url":"https://api.github.com/users/aerialship/events{/privacy}","received_events_url":"https://api.github.com/users/aerialship/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerialship/SamlSPBundle","description":"","fork":false,"url":"https://api.github.com/repos/aerialship/SamlSPBundle","forks_url":"https://api.github.com/repos/aerialship/SamlSPBundle/forks","keys_url":"https://api.github.com/repos/aerialship/SamlSPBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerialship/SamlSPBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerialship/SamlSPBundle/teams","hooks_url":"https://api.github.com/repos/aerialship/SamlSPBundle/hooks","issue_events_url":"https://api.github.com/repos/aerialship/SamlSPBundle/issues/events{/number}","events_url":"https://api.github.com/repos/aerialship/SamlSPBundle/events","assignees_url":"https://api.github.com/repos/aerialship/SamlSPBundle/assignees{/user}","branches_url":"https://api.github.com/repos/aerialship/SamlSPBundle/branches{/branch}","tags_url":"https://api.github.com/repos/aerialship/SamlSPBundle/tags","blobs_url":"https://api.github.com/repos/aerialship/SamlSPBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerialship/SamlSPBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerialship/SamlSPBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerialship/SamlSPBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerialship/SamlSPBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/aerialship/SamlSPBundle/languages","stargazers_url":"https://api.github.com/repos/aerialship/SamlSPBundle/stargazers","contributors_url":"https://api.github.com/repos/aerialship/SamlSPBundle/contributors","subscribers_url":"https://api.github.com/repos/aerialship/SamlSPBundle/subscribers","subscription_url":"https://api.github.com/repos/aerialship/SamlSPBundle/subscription","commits_url":"https://api.github.com/repos/aerialship/SamlSPBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerialship/SamlSPBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerialship/SamlSPBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerialship/SamlSPBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerialship/SamlSPBundle/contents/{+path}","compare_url":"https://api.github.com/repos/aerialship/SamlSPBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerialship/SamlSPBundle/merges","archive_url":"https://api.github.com/repos/aerialship/SamlSPBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerialship/SamlSPBundle/downloads","issues_url":"https://api.github.com/repos/aerialship/SamlSPBundle/issues{/number}","pulls_url":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/aerialship/SamlSPBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/aerialship/SamlSPBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerialship/SamlSPBundle/labels{/name}","releases_url":"https://api.github.com/repos/aerialship/SamlSPBundle/releases{/id}","created_at":"2013-11-13T14:06:07Z","updated_at":"2015-04-22T12:40:02Z","pushed_at":"2015-04-23T01:57:20Z","git_url":"git://github.com/aerialship/SamlSPBundle.git","ssh_url":"git@github.com:aerialship/SamlSPBundle.git","clone_url":"https://github.com/aerialship/SamlSPBundle.git","svn_url":"https://github.com/aerialship/SamlSPBundle","homepage":null,"size":958,"stargazers_count":37,"watchers_count":37,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":26,"forks":39,"open_issues":26,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83"},"html":{"href":"https://github.com/aerialship/SamlSPBundle/pull/83"},"issue":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/issues/83"},"comments":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/aerialship/SamlSPBundle/statuses/40fc230d7000fe6625819343c1e6b1a5c490843b"}}}}