{"action":"created","comment":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/24367622","id":24367622,"diff_hunk":"@@ -102,64 +137,69 @@ <h2 class=\"instructor-nav\">\n           %endif\n       %endif\n \n-      <table class=\"stat_table\" width=\"100%\">\n-        <thead>\n-          <tr>\n-            <th width=\"15%\">${_('Date')}</th>\n-            <th width=\"15%\">${_('Course ID')}</th>\n-            ## Translators: Git is a version-control system; see http://git-scm.com/about\n-            <th>${_('Git Action')}</th>\n-          </tr>\n-        </thead>\n-        <tbody>\n-          <%\n-          if course_id == None:\n-              logs = cilset[:10]\n-          else:\n-              logs = cilset[:5]\n-\n-          cil = None\n-          %>\n-          % for index, cil in enumerate(logs):\n-              <%\n-                  # Appropriate datetime string for current locale and timezone\n-                  date = get_time_display(cil.created.replace(tzinfo=UTC),\n-                                          DEFAULT_DATE_TIME_FORMAT, coerce_tz=settings.TIME_ZONE)\n-              %>\n+      %if len(logs):\n+          ${pagination()}\n+\n+          <table class=\"stat_table\" width=\"100%\">\n+            <thead>\n               <tr>\n-                <td>${date}</td>\n-                <td>\n-                  <a href=\"${reverse('gitlogs_detail', kwargs={'course_id': unicode(cil.course_id)})}\">\n-                    ${cil.course_id | h}\n-                  </a>\n-                </td>\n-                <td>\n-                  %if course_id is not None:\n-                      <a class=\"toggle-import-log\" data-import-log=\"${index}\" href=\"#\">[ + ]</a>\n-                  %endif\n-                  ${cil.git_log}\n-                </td>\n+                <th width=\"15%\">${_('Date')}</th>\n+                <th width=\"15%\">${_('Course ID')}</th>\n+                ## Translators: Git is a version-control system; see http://git-scm.com/about\n+                <th>${_('Git Action')}</th>\n               </tr>\n-\n-              ## Show the full log of the latest import if viewing logs for a specific course\n-              %if course_id is not None:\n-                  <tr class=\"import-log\" id=\"import-log-${index}\">\n-                    <td colspan=\"3\">\n-                      <pre>\n-                        ${cil.import_log | h}\n-                      </pre>\n+            </thead>\n+            <tbody>\n+              %for index, cil in enumerate(logs):\n+                  <%\n+                      # Appropriate datetime string for current locale and timezone\n+                      date = get_time_display(cil.created.replace(tzinfo=UTC),\n+                                              DEFAULT_DATE_TIME_FORMAT, coerce_tz=settings.TIME_ZONE)\n+                  %>\n+                  <tr>\n+                    <td>${date}</td>\n+                    <td>\n+                      <a href=\"${reverse('gitlogs_detail', kwargs={'course_id': unicode(cil.course_id)})}\">\n+                        ${cil.course_id | h}\n+                      </a>\n+                    </td>\n+                    <td>\n+                      %if course_id is not None:\n+                          <a class=\"toggle-import-log\" data-import-log=\"${index}\" href=\"#\">[ + ]</a>\n+                      %endif\n+                      ${cil.git_log}\n                     </td>\n                   </tr>\n-              %endif\n-          %endfor\n-        </tbody>\n-      </table>\n-\n-      ## If viewing a single course and there are no logs available, let the user know\n-      %if course_id is not None and cil is None:\n-        ## Translators: git is a version-control system; see http://git-scm.com/about\n-        ${_('No git import logs have been recorded for this course.')}\n+\n+                  ## Show the full log of the latest import if viewing logs for a specific course\n+                  %if course_id is not None:\n+                      <tr class=\"import-log\" id=\"import-log-${index}\">\n+                        <td colspan=\"3\">\n+                          <pre>\n+                            ${cil.import_log | h}\n+                          </pre>\n+                        </td>\n+                      </tr>\n+                  %endif\n+              %endfor\n+            </tbody>\n+          </table>\n+\n+          ${pagination()}\n+      %else:\n+          <div class=\"page-status\">\n+            %if not course_id:\n+                # If viewing all logs there are no logs available, let the user know\n+                ## Translators: git is a version-control system; see http://git-scm.com/about\n+                ${_('No Git import logs have been recorded.')}","path":"lms/templates/sysadmin_dashboard_gitlogs.html","position":160,"original_position":160,"commit_id":"b58015fd7f901a6d31b278b15ba333207fa36ac2","original_commit_id":"b58015fd7f901a6d31b278b15ba333207fa36ac2","user":{"login":"sarina","id":1985317,"avatar_url":"https://avatars.githubusercontent.com/u/1985317?v=3","gravatar_id":"","url":"https://api.github.com/users/sarina","html_url":"https://github.com/sarina","followers_url":"https://api.github.com/users/sarina/followers","following_url":"https://api.github.com/users/sarina/following{/other_user}","gists_url":"https://api.github.com/users/sarina/gists{/gist_id}","starred_url":"https://api.github.com/users/sarina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarina/subscriptions","organizations_url":"https://api.github.com/users/sarina/orgs","repos_url":"https://api.github.com/users/sarina/repos","events_url":"https://api.github.com/users/sarina/events{/privacy}","received_events_url":"https://api.github.com/users/sarina/received_events","type":"User","site_admin":false},"body":"Is it worthwhile to capitalize \"git\" here? This creates a new translation string and causes additional translation work, simply due to the change in capitalization (there is no notion of changed strings, only new strings). So if it's not critically necessary to change the string I would advise against it.","created_at":"2015-02-09T21:35:38Z","updated_at":"2015-02-09T21:35:38Z","html_url":"https://github.com/edx/edx-platform/pull/6938#discussion_r24367622","pull_request_url":"https://api.github.com/repos/edx/edx-platform/pulls/6938","_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/24367622"},"html":{"href":"https://github.com/edx/edx-platform/pull/6938#discussion_r24367622"},"pull_request":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6938"}}},"pull_request":{"url":"https://api.github.com/repos/edx/edx-platform/pulls/6938","id":28957821,"html_url":"https://github.com/edx/edx-platform/pull/6938","diff_url":"https://github.com/edx/edx-platform/pull/6938.diff","patch_url":"https://github.com/edx/edx-platform/pull/6938.patch","issue_url":"https://api.github.com/repos/edx/edx-platform/issues/6938","number":6938,"state":"open","locked":false,"title":"Add pagination to sysadmin dashboard Git import logs","user":{"login":"bdero","id":919017,"avatar_url":"https://avatars.githubusercontent.com/u/919017?v=3","gravatar_id":"","url":"https://api.github.com/users/bdero","html_url":"https://github.com/bdero","followers_url":"https://api.github.com/users/bdero/followers","following_url":"https://api.github.com/users/bdero/following{/other_user}","gists_url":"https://api.github.com/users/bdero/gists{/gist_id}","starred_url":"https://api.github.com/users/bdero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdero/subscriptions","organizations_url":"https://api.github.com/users/bdero/orgs","repos_url":"https://api.github.com/users/bdero/repos","events_url":"https://api.github.com/users/bdero/events{/privacy}","received_events_url":"https://api.github.com/users/bdero/received_events","type":"User","site_admin":false},"body":"Add pagination to the git import log view in the Sysadmin dashboard. @carsongee \r\n\r\nLog overview\r\n------------\r\n![Log overview screenshot](http://i.imgur.com/9z1nFoE.png)\r\n\r\nFocused (single course) logs\r\n----------------------------\r\n![Focused logs screenshot](http://i.imgur.com/XFQ0Z6F.png)\r\n","created_at":"2015-02-09T21:24:55Z","updated_at":"2015-02-09T21:35:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7f4aded4f45d1b3828042c7c5d90feab3d5a8de","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/edx/edx-platform/pulls/6938/commits","review_comments_url":"https://api.github.com/repos/edx/edx-platform/pulls/6938/comments","review_comment_url":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}","comments_url":"https://api.github.com/repos/edx/edx-platform/issues/6938/comments","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/b58015fd7f901a6d31b278b15ba333207fa36ac2","head":{"label":"mitocw:bdero/gitlog-pagination","ref":"bdero/gitlog-pagination","sha":"b58015fd7f901a6d31b278b15ba333207fa36ac2","user":{"login":"mitocw","id":3009146,"avatar_url":"https://avatars.githubusercontent.com/u/3009146?v=3","gravatar_id":"","url":"https://api.github.com/users/mitocw","html_url":"https://github.com/mitocw","followers_url":"https://api.github.com/users/mitocw/followers","following_url":"https://api.github.com/users/mitocw/following{/other_user}","gists_url":"https://api.github.com/users/mitocw/gists{/gist_id}","starred_url":"https://api.github.com/users/mitocw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitocw/subscriptions","organizations_url":"https://api.github.com/users/mitocw/orgs","repos_url":"https://api.github.com/users/mitocw/repos","events_url":"https://api.github.com/users/mitocw/events{/privacy}","received_events_url":"https://api.github.com/users/mitocw/received_events","type":"Organization","site_admin":false},"repo":{"id":17842334,"name":"edx-platform","full_name":"mitocw/edx-platform","owner":{"login":"mitocw","id":3009146,"avatar_url":"https://avatars.githubusercontent.com/u/3009146?v=3","gravatar_id":"","url":"https://api.github.com/users/mitocw","html_url":"https://github.com/mitocw","followers_url":"https://api.github.com/users/mitocw/followers","following_url":"https://api.github.com/users/mitocw/following{/other_user}","gists_url":"https://api.github.com/users/mitocw/gists{/gist_id}","starred_url":"https://api.github.com/users/mitocw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mitocw/subscriptions","organizations_url":"https://api.github.com/users/mitocw/orgs","repos_url":"https://api.github.com/users/mitocw/repos","events_url":"https://api.github.com/users/mitocw/events{/privacy}","received_events_url":"https://api.github.com/users/mitocw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mitocw/edx-platform","description":"the edX learning management system (LMS) and course authoring tool, Studio","fork":true,"url":"https://api.github.com/repos/mitocw/edx-platform","forks_url":"https://api.github.com/repos/mitocw/edx-platform/forks","keys_url":"https://api.github.com/repos/mitocw/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mitocw/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mitocw/edx-platform/teams","hooks_url":"https://api.github.com/repos/mitocw/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/mitocw/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/mitocw/edx-platform/events","assignees_url":"https://api.github.com/repos/mitocw/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/mitocw/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/mitocw/edx-platform/tags","blobs_url":"https://api.github.com/repos/mitocw/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mitocw/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mitocw/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/mitocw/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mitocw/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/mitocw/edx-platform/languages","stargazers_url":"https://api.github.com/repos/mitocw/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/mitocw/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/mitocw/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/mitocw/edx-platform/subscription","commits_url":"https://api.github.com/repos/mitocw/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/mitocw/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/mitocw/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/mitocw/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/mitocw/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/mitocw/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mitocw/edx-platform/merges","archive_url":"https://api.github.com/repos/mitocw/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mitocw/edx-platform/downloads","issues_url":"https://api.github.com/repos/mitocw/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/mitocw/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/mitocw/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/mitocw/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mitocw/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/mitocw/edx-platform/releases{/id}","created_at":"2014-03-17T20:32:05Z","updated_at":"2015-02-04T19:40:44Z","pushed_at":"2015-02-09T20:56:30Z","git_url":"git://github.com/mitocw/edx-platform.git","ssh_url":"git@github.com:mitocw/edx-platform.git","clone_url":"https://github.com/mitocw/edx-platform.git","svn_url":"https://github.com/mitocw/edx-platform","homepage":"http://code.edx.org/","size":412786,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"edx:master","ref":"master","sha":"2c60a1d5464d94a281e67ff0d9ffa0f695f5afd9","user":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"repo":{"id":10391073,"name":"edx-platform","full_name":"edx/edx-platform","owner":{"login":"edx","id":3179841,"avatar_url":"https://avatars.githubusercontent.com/u/3179841?v=3","gravatar_id":"","url":"https://api.github.com/users/edx","html_url":"https://github.com/edx","followers_url":"https://api.github.com/users/edx/followers","following_url":"https://api.github.com/users/edx/following{/other_user}","gists_url":"https://api.github.com/users/edx/gists{/gist_id}","starred_url":"https://api.github.com/users/edx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/edx/subscriptions","organizations_url":"https://api.github.com/users/edx/orgs","repos_url":"https://api.github.com/users/edx/repos","events_url":"https://api.github.com/users/edx/events{/privacy}","received_events_url":"https://api.github.com/users/edx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/edx/edx-platform","description":"Open edX, the edX platform that powers http://edx.org","fork":false,"url":"https://api.github.com/repos/edx/edx-platform","forks_url":"https://api.github.com/repos/edx/edx-platform/forks","keys_url":"https://api.github.com/repos/edx/edx-platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/edx/edx-platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/edx/edx-platform/teams","hooks_url":"https://api.github.com/repos/edx/edx-platform/hooks","issue_events_url":"https://api.github.com/repos/edx/edx-platform/issues/events{/number}","events_url":"https://api.github.com/repos/edx/edx-platform/events","assignees_url":"https://api.github.com/repos/edx/edx-platform/assignees{/user}","branches_url":"https://api.github.com/repos/edx/edx-platform/branches{/branch}","tags_url":"https://api.github.com/repos/edx/edx-platform/tags","blobs_url":"https://api.github.com/repos/edx/edx-platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/edx/edx-platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/edx/edx-platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/edx/edx-platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/edx/edx-platform/statuses/{sha}","languages_url":"https://api.github.com/repos/edx/edx-platform/languages","stargazers_url":"https://api.github.com/repos/edx/edx-platform/stargazers","contributors_url":"https://api.github.com/repos/edx/edx-platform/contributors","subscribers_url":"https://api.github.com/repos/edx/edx-platform/subscribers","subscription_url":"https://api.github.com/repos/edx/edx-platform/subscription","commits_url":"https://api.github.com/repos/edx/edx-platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/edx/edx-platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/edx/edx-platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/edx/edx-platform/issues/comments/{number}","contents_url":"https://api.github.com/repos/edx/edx-platform/contents/{+path}","compare_url":"https://api.github.com/repos/edx/edx-platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/edx/edx-platform/merges","archive_url":"https://api.github.com/repos/edx/edx-platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/edx/edx-platform/downloads","issues_url":"https://api.github.com/repos/edx/edx-platform/issues{/number}","pulls_url":"https://api.github.com/repos/edx/edx-platform/pulls{/number}","milestones_url":"https://api.github.com/repos/edx/edx-platform/milestones{/number}","notifications_url":"https://api.github.com/repos/edx/edx-platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/edx/edx-platform/labels{/name}","releases_url":"https://api.github.com/repos/edx/edx-platform/releases{/id}","created_at":"2013-05-30T20:20:38Z","updated_at":"2015-02-09T21:16:32Z","pushed_at":"2015-02-09T21:29:00Z","git_url":"git://github.com/edx/edx-platform.git","ssh_url":"git@github.com:edx/edx-platform.git","clone_url":"https://github.com/edx/edx-platform.git","svn_url":"https://github.com/edx/edx-platform","homepage":"http://openedx.org/","size":1582008,"stargazers_count":1735,"watchers_count":1735,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":985,"mirror_url":null,"open_issues_count":140,"forks":985,"open_issues":140,"watchers":1735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6938"},"html":{"href":"https://github.com/edx/edx-platform/pull/6938"},"issue":{"href":"https://api.github.com/repos/edx/edx-platform/issues/6938"},"comments":{"href":"https://api.github.com/repos/edx/edx-platform/issues/6938/comments"},"review_comments":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6938/comments"},"review_comment":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/edx/edx-platform/pulls/6938/commits"},"statuses":{"href":"https://api.github.com/repos/edx/edx-platform/statuses/b58015fd7f901a6d31b278b15ba333207fa36ac2"}}}}