{"action":"created","issue":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/1555","labels_url":"https://api.github.com/repos/buildbot/buildbot/issues/1555/labels{/name}","comments_url":"https://api.github.com/repos/buildbot/buildbot/issues/1555/comments","events_url":"https://api.github.com/repos/buildbot/buildbot/issues/1555/events","html_url":"https://github.com/buildbot/buildbot/pull/1555","id":58487129,"number":1555,"title":"[eight] ShellMixin: two minor logging fixes","user":{"login":"jaredgrubb","id":1256381,"avatar_url":"https://avatars.githubusercontent.com/u/1256381?v=3","gravatar_id":"","url":"https://api.github.com/users/jaredgrubb","html_url":"https://github.com/jaredgrubb","followers_url":"https://api.github.com/users/jaredgrubb/followers","following_url":"https://api.github.com/users/jaredgrubb/following{/other_user}","gists_url":"https://api.github.com/users/jaredgrubb/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredgrubb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredgrubb/subscriptions","organizations_url":"https://api.github.com/users/jaredgrubb/orgs","repos_url":"https://api.github.com/users/jaredgrubb/repos","events_url":"https://api.github.com/users/jaredgrubb/events{/privacy}","received_events_url":"https://api.github.com/users/jaredgrubb/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/buildbot/buildbot/labels/eight","name":"eight","color":"d4c5f9"},{"url":"https://api.github.com/repos/buildbot/buildbot/labels/needs%20more%20review","name":"needs more review","color":"bfe5bf"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-02-22T02:27:52Z","updated_at":"2015-02-22T21:46:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/buildbot/buildbot/pulls/1555","html_url":"https://github.com/buildbot/buildbot/pull/1555","diff_url":"https://github.com/buildbot/buildbot/pull/1555.diff","patch_url":"https://github.com/buildbot/buildbot/pull/1555.patch"},"body":"This has two fixes that I found useful:\r\n* collectStdout/collectStderr args are never used. I think this is an oversight.\r\n* passing in the same log name creates new logs each time (eg, a bunch of 'stdio' logs). I think it should reuse the same log if it already exists.\r\n\r\nI havent done any unit tests for these. I'm not really sure if those parts are tested?"},"comment":{"url":"https://api.github.com/repos/buildbot/buildbot/issues/comments/75463996","html_url":"https://github.com/buildbot/buildbot/pull/1555#issuecomment-75463996","issue_url":"https://api.github.com/repos/buildbot/buildbot/issues/1555","id":75463996,"user":{"login":"djmitche","id":28673,"avatar_url":"https://avatars.githubusercontent.com/u/28673?v=3","gravatar_id":"","url":"https://api.github.com/users/djmitche","html_url":"https://github.com/djmitche","followers_url":"https://api.github.com/users/djmitche/followers","following_url":"https://api.github.com/users/djmitche/following{/other_user}","gists_url":"https://api.github.com/users/djmitche/gists{/gist_id}","starred_url":"https://api.github.com/users/djmitche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djmitche/subscriptions","organizations_url":"https://api.github.com/users/djmitche/orgs","repos_url":"https://api.github.com/users/djmitche/repos","events_url":"https://api.github.com/users/djmitche/events{/privacy}","received_events_url":"https://api.github.com/users/djmitche/received_events","type":"User","site_admin":false},"created_at":"2015-02-22T21:46:23Z","updated_at":"2015-02-22T21:46:23Z","body":"Jared, you definitely have the right understanding, and re-using the existing logs is the intended behavior."}}