{"action":"created","comment":{"url":"https://api.github.com/repos/basho/riak_cs/pulls/comments/24797770","id":24797770,"diff_hunk":"@@ -43,13 +44,21 @@\n \n -spec identify(RD::term(), #context{}) ->\n                       {string() | undefined,\n-                       string() | {v4, v4_attrs()} | undefined}.\n+                       string() | {v4, v4_attrs()} | undefined} |\n+                      {failed, Reason::atom()}.\n identify(RD,_Ctx) ->\n     case wrq:get_req_header(\"authorization\", RD) of\n         undefined ->\n             identify_by_query_string(RD);\n         AuthHeader ->\n-            parse_auth_header(AuthHeader)\n+            %% Query string auth does not require date/x-amz-date header\n+            Date = riak_cs_wm_utils:extract_date(RD),\n+            case riak_cs_wm_utils:check_timeskew(Date) of","path":"src/riak_cs_s3_auth.erl","position":35,"original_position":35,"commit_id":"2dd0b31e6b0b214f5e2a4d3971693bb30c8f61f1","original_commit_id":"2dd0b31e6b0b214f5e2a4d3971693bb30c8f61f1","user":{"login":"shino","id":10225,"avatar_url":"https://avatars.githubusercontent.com/u/10225?v=3","gravatar_id":"","url":"https://api.github.com/users/shino","html_url":"https://github.com/shino","followers_url":"https://api.github.com/users/shino/followers","following_url":"https://api.github.com/users/shino/following{/other_user}","gists_url":"https://api.github.com/users/shino/gists{/gist_id}","starred_url":"https://api.github.com/users/shino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shino/subscriptions","organizations_url":"https://api.github.com/users/shino/orgs","repos_url":"https://api.github.com/users/shino/repos","events_url":"https://api.github.com/users/shino/events{/privacy}","received_events_url":"https://api.github.com/users/shino/received_events","type":"User","site_admin":false},"body":"Just a proposal: How about move this check logic from `identify` to `authenticate`?\r\nMain reason is skewed time errors should be counted for access stats.\r\nBut it will be minor parts, so feel free to reject this proposal if it complicate the source code.","created_at":"2015-02-17T07:39:54Z","updated_at":"2015-02-17T07:39:54Z","html_url":"https://github.com/basho/riak_cs/pull/1067#discussion_r24797770","pull_request_url":"https://api.github.com/repos/basho/riak_cs/pulls/1067","_links":{"self":{"href":"https://api.github.com/repos/basho/riak_cs/pulls/comments/24797770"},"html":{"href":"https://github.com/basho/riak_cs/pull/1067#discussion_r24797770"},"pull_request":{"href":"https://api.github.com/repos/basho/riak_cs/pulls/1067"}}},"pull_request":{"url":"https://api.github.com/repos/basho/riak_cs/pulls/1067","id":29013335,"html_url":"https://github.com/basho/riak_cs/pull/1067","diff_url":"https://github.com/basho/riak_cs/pull/1067.diff","patch_url":"https://github.com/basho/riak_cs/pull/1067.patch","issue_url":"https://api.github.com/repos/basho/riak_cs/issues/1067","number":1067,"state":"open","locked":false,"title":"Add date time skew check to both v2 and v4 authentication","user":{"login":"kuenishi","id":11440,"avatar_url":"https://avatars.githubusercontent.com/u/11440?v=3","gravatar_id":"","url":"https://api.github.com/users/kuenishi","html_url":"https://github.com/kuenishi","followers_url":"https://api.github.com/users/kuenishi/followers","following_url":"https://api.github.com/users/kuenishi/following{/other_user}","gists_url":"https://api.github.com/users/kuenishi/gists{/gist_id}","starred_url":"https://api.github.com/users/kuenishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuenishi/subscriptions","organizations_url":"https://api.github.com/users/kuenishi/orgs","repos_url":"https://api.github.com/users/kuenishi/repos","events_url":"https://api.github.com/users/kuenishi/events{/privacy}","received_events_url":"https://api.github.com/users/kuenishi/received_events","type":"User","site_admin":false},"body":"1/2 for RCS-118","created_at":"2015-02-10T14:59:39Z","updated_at":"2015-02-17T07:39:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32cf6768dbb1600266dddf666101a865837729f1","assignee":null,"milestone":{"url":"https://api.github.com/repos/basho/riak_cs/milestones/6","labels_url":"https://api.github.com/repos/basho/riak_cs/milestones/6/labels","id":401063,"number":6,"title":"2.0.0","description":"","creator":{"login":"kellymclaughlin","id":29337,"avatar_url":"https://avatars.githubusercontent.com/u/29337?v=3","gravatar_id":"","url":"https://api.github.com/users/kellymclaughlin","html_url":"https://github.com/kellymclaughlin","followers_url":"https://api.github.com/users/kellymclaughlin/followers","following_url":"https://api.github.com/users/kellymclaughlin/following{/other_user}","gists_url":"https://api.github.com/users/kellymclaughlin/gists{/gist_id}","starred_url":"https://api.github.com/users/kellymclaughlin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kellymclaughlin/subscriptions","organizations_url":"https://api.github.com/users/kellymclaughlin/orgs","repos_url":"https://api.github.com/users/kellymclaughlin/repos","events_url":"https://api.github.com/users/kellymclaughlin/events{/privacy}","received_events_url":"https://api.github.com/users/kellymclaughlin/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":17,"state":"open","created_at":"2013-08-13T16:18:28Z","updated_at":"2015-02-12T09:06:16Z","due_on":"2015-03-30T15:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/basho/riak_cs/pulls/1067/commits","review_comments_url":"https://api.github.com/repos/basho/riak_cs/pulls/1067/comments","review_comment_url":"https://api.github.com/repos/basho/riak_cs/pulls/comments/{number}","comments_url":"https://api.github.com/repos/basho/riak_cs/issues/1067/comments","statuses_url":"https://api.github.com/repos/basho/riak_cs/statuses/2dd0b31e6b0b214f5e2a4d3971693bb30c8f61f1","head":{"label":"basho:feature/check-signed-date","ref":"feature/check-signed-date","sha":"2dd0b31e6b0b214f5e2a4d3971693bb30c8f61f1","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":2513151,"name":"riak_cs","full_name":"basho/riak_cs","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_cs","description":"Riak CS is simple, available cloud storage built on Riak.","fork":false,"url":"https://api.github.com/repos/basho/riak_cs","forks_url":"https://api.github.com/repos/basho/riak_cs/forks","keys_url":"https://api.github.com/repos/basho/riak_cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_cs/teams","hooks_url":"https://api.github.com/repos/basho/riak_cs/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_cs/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_cs/events","assignees_url":"https://api.github.com/repos/basho/riak_cs/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_cs/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_cs/tags","blobs_url":"https://api.github.com/repos/basho/riak_cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_cs/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_cs/languages","stargazers_url":"https://api.github.com/repos/basho/riak_cs/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_cs/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_cs/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_cs/subscription","commits_url":"https://api.github.com/repos/basho/riak_cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_cs/issues/comments/{number}","contents_url":"https://api.github.com/repos/basho/riak_cs/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_cs/merges","archive_url":"https://api.github.com/repos/basho/riak_cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_cs/downloads","issues_url":"https://api.github.com/repos/basho/riak_cs/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_cs/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_cs/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_cs/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_cs/releases{/id}","created_at":"2011-10-04T16:16:25Z","updated_at":"2015-02-16T22:46:09Z","pushed_at":"2015-02-15T03:10:19Z","git_url":"git://github.com/basho/riak_cs.git","ssh_url":"git@github.com:basho/riak_cs.git","clone_url":"https://github.com/basho/riak_cs.git","svn_url":"https://github.com/basho/riak_cs","homepage":"http://docs.basho.com/riakcs/latest/","size":20652,"stargazers_count":359,"watchers_count":359,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":154,"forks":53,"open_issues":154,"watchers":359,"default_branch":"develop"}},"base":{"label":"basho:develop","ref":"develop","sha":"ec032d7efde10d0279e7b9b0b6d2d7e92fbbe943","user":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"repo":{"id":2513151,"name":"riak_cs","full_name":"basho/riak_cs","owner":{"login":"basho","id":176293,"avatar_url":"https://avatars.githubusercontent.com/u/176293?v=3","gravatar_id":"","url":"https://api.github.com/users/basho","html_url":"https://github.com/basho","followers_url":"https://api.github.com/users/basho/followers","following_url":"https://api.github.com/users/basho/following{/other_user}","gists_url":"https://api.github.com/users/basho/gists{/gist_id}","starred_url":"https://api.github.com/users/basho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basho/subscriptions","organizations_url":"https://api.github.com/users/basho/orgs","repos_url":"https://api.github.com/users/basho/repos","events_url":"https://api.github.com/users/basho/events{/privacy}","received_events_url":"https://api.github.com/users/basho/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/basho/riak_cs","description":"Riak CS is simple, available cloud storage built on Riak.","fork":false,"url":"https://api.github.com/repos/basho/riak_cs","forks_url":"https://api.github.com/repos/basho/riak_cs/forks","keys_url":"https://api.github.com/repos/basho/riak_cs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basho/riak_cs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basho/riak_cs/teams","hooks_url":"https://api.github.com/repos/basho/riak_cs/hooks","issue_events_url":"https://api.github.com/repos/basho/riak_cs/issues/events{/number}","events_url":"https://api.github.com/repos/basho/riak_cs/events","assignees_url":"https://api.github.com/repos/basho/riak_cs/assignees{/user}","branches_url":"https://api.github.com/repos/basho/riak_cs/branches{/branch}","tags_url":"https://api.github.com/repos/basho/riak_cs/tags","blobs_url":"https://api.github.com/repos/basho/riak_cs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basho/riak_cs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basho/riak_cs/git/refs{/sha}","trees_url":"https://api.github.com/repos/basho/riak_cs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basho/riak_cs/statuses/{sha}","languages_url":"https://api.github.com/repos/basho/riak_cs/languages","stargazers_url":"https://api.github.com/repos/basho/riak_cs/stargazers","contributors_url":"https://api.github.com/repos/basho/riak_cs/contributors","subscribers_url":"https://api.github.com/repos/basho/riak_cs/subscribers","subscription_url":"https://api.github.com/repos/basho/riak_cs/subscription","commits_url":"https://api.github.com/repos/basho/riak_cs/commits{/sha}","git_commits_url":"https://api.github.com/repos/basho/riak_cs/git/commits{/sha}","comments_url":"https://api.github.com/repos/basho/riak_cs/comments{/number}","issue_comment_url":"https://api.github.com/repos/basho/riak_cs/issues/comments/{number}","contents_url":"https://api.github.com/repos/basho/riak_cs/contents/{+path}","compare_url":"https://api.github.com/repos/basho/riak_cs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basho/riak_cs/merges","archive_url":"https://api.github.com/repos/basho/riak_cs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basho/riak_cs/downloads","issues_url":"https://api.github.com/repos/basho/riak_cs/issues{/number}","pulls_url":"https://api.github.com/repos/basho/riak_cs/pulls{/number}","milestones_url":"https://api.github.com/repos/basho/riak_cs/milestones{/number}","notifications_url":"https://api.github.com/repos/basho/riak_cs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basho/riak_cs/labels{/name}","releases_url":"https://api.github.com/repos/basho/riak_cs/releases{/id}","created_at":"2011-10-04T16:16:25Z","updated_at":"2015-02-16T22:46:09Z","pushed_at":"2015-02-15T03:10:19Z","git_url":"git://github.com/basho/riak_cs.git","ssh_url":"git@github.com:basho/riak_cs.git","clone_url":"https://github.com/basho/riak_cs.git","svn_url":"https://github.com/basho/riak_cs","homepage":"http://docs.basho.com/riakcs/latest/","size":20652,"stargazers_count":359,"watchers_count":359,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":154,"forks":53,"open_issues":154,"watchers":359,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/basho/riak_cs/pulls/1067"},"html":{"href":"https://github.com/basho/riak_cs/pull/1067"},"issue":{"href":"https://api.github.com/repos/basho/riak_cs/issues/1067"},"comments":{"href":"https://api.github.com/repos/basho/riak_cs/issues/1067/comments"},"review_comments":{"href":"https://api.github.com/repos/basho/riak_cs/pulls/1067/comments"},"review_comment":{"href":"https://api.github.com/repos/basho/riak_cs/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/basho/riak_cs/pulls/1067/commits"},"statuses":{"href":"https://api.github.com/repos/basho/riak_cs/statuses/2dd0b31e6b0b214f5e2a4d3971693bb30c8f61f1"}}}}