{"comment":{"url":"https://api.github.com/repos/rbrw/puppetdb/comments/14106967","html_url":"https://github.com/rbrw/puppetdb/commit/4cbde0760533f8a474d4f10fbce1548ce8b274bc#commitcomment-14106967","id":14106967,"user":{"login":"rbrw","id":10120698,"avatar_url":"https://avatars.githubusercontent.com/u/10120698?v=3","gravatar_id":"","url":"https://api.github.com/users/rbrw","html_url":"https://github.com/rbrw","followers_url":"https://api.github.com/users/rbrw/followers","following_url":"https://api.github.com/users/rbrw/following{/other_user}","gists_url":"https://api.github.com/users/rbrw/gists{/gist_id}","starred_url":"https://api.github.com/users/rbrw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbrw/subscriptions","organizations_url":"https://api.github.com/users/rbrw/orgs","repos_url":"https://api.github.com/users/rbrw/repos","events_url":"https://api.github.com/users/rbrw/events{/privacy}","received_events_url":"https://api.github.com/users/rbrw/received_events","type":"User","site_admin":false},"position":59,"line":55,"path":"test/puppetlabs/puppetdb/fixtures.clj","commit_id":"4cbde0760533f8a474d4f10fbce1548ce8b274bc","created_at":"2015-10-31T01:57:45Z","updated_at":"2015-10-31T01:57:45Z","body":"I suppose what I was really getting at here was why does the thing that sounds like it just needs metadata also need to create a database?  Seems like maybe either migrate-test should just use *with-test-db which already deals with db-metadata-fn, or call-with-test-db should be written in terms of with-db-metadata, if there are actually cases where we might want to deal with db-metadata-fn for the current db (without creating a new one).\r\n\r\nOtherwise, since after all the reworking, call-with-test-db and with-db-metadata are actually doing the same thing it could be that we just need to drop the latter."}}