{"action":"created","issue":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617","labels_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617/labels{/name}","comments_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617/comments","events_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617/events","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617","id":66354353,"number":617,"title":"Some more work on the material scripts","user":{"login":"akien-mga","id":4701338,"avatar_url":"https://avatars.githubusercontent.com/u/4701338?v=3","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-04-04T19:07:25Z","updated_at":"2015-04-04T21:37:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/pulls/617","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617","diff_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617.diff","patch_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617.patch"},"body":"As discussed in #612 and #615, I've tried to correct some mistakes introduced previously due to a wrong understanding of what the arguments mean for the ambient, diffuse, specular and emissive lighting parameters.\r\n\r\nI enforced the default values for those that were not already custom, and used a minimal shininess value of 2.0 for the specular parameter, since Ogre advises against uses values ranging from 0 to 1.\r\n\r\nSome values were also rounded to decimals with one (or two in some cases) significant number, and I tried to fix the indentation (with a \"tabulation\" of 4 spaces)."},"comment":{"url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/comments/89670230","html_url":"https://github.com/OpenDungeons/OpenDungeons/pull/617#issuecomment-89670230","issue_url":"https://api.github.com/repos/OpenDungeons/OpenDungeons/issues/617","id":89670230,"user":{"login":"Bertram25","id":765917,"avatar_url":"https://avatars.githubusercontent.com/u/765917?v=3","gravatar_id":"","url":"https://api.github.com/users/Bertram25","html_url":"https://github.com/Bertram25","followers_url":"https://api.github.com/users/Bertram25/followers","following_url":"https://api.github.com/users/Bertram25/following{/other_user}","gists_url":"https://api.github.com/users/Bertram25/gists{/gist_id}","starred_url":"https://api.github.com/users/Bertram25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Bertram25/subscriptions","organizations_url":"https://api.github.com/users/Bertram25/orgs","repos_url":"https://api.github.com/users/Bertram25/repos","events_url":"https://api.github.com/users/Bertram25/events{/privacy}","received_events_url":"https://api.github.com/users/Bertram25/received_events","type":"User","site_admin":false},"created_at":"2015-04-04T21:37:19Z","updated_at":"2015-04-04T21:37:19Z","body":"Looks fine after a full game played with several AI. IMHO good to merge if it's ok on Windows."}}