{"action":"created","issue":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4338","labels_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4338/labels{/name}","comments_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4338/comments","events_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4338/events","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4338","id":107922639,"number":4338,"title":"[feature] Merge prereg-prize-2 into prereg-prize branch","user":{"login":"HarryRybacki","id":2614670,"avatar_url":"https://avatars.githubusercontent.com/u/2614670?v=3","gravatar_id":"","url":"https://api.github.com/users/HarryRybacki","html_url":"https://github.com/HarryRybacki","followers_url":"https://api.github.com/users/HarryRybacki/followers","following_url":"https://api.github.com/users/HarryRybacki/following{/other_user}","gists_url":"https://api.github.com/users/HarryRybacki/gists{/gist_id}","starred_url":"https://api.github.com/users/HarryRybacki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HarryRybacki/subscriptions","organizations_url":"https://api.github.com/users/HarryRybacki/orgs","repos_url":"https://api.github.com/users/HarryRybacki/repos","events_url":"https://api.github.com/users/HarryRybacki/events{/privacy}","received_events_url":"https://api.github.com/users/HarryRybacki/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":16,"created_at":"2015-09-23T13:43:53Z","updated_at":"2015-09-24T22:12:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/pulls/4338","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4338","diff_url":"https://github.com/CenterForOpenScience/osf.io/pull/4338.diff","patch_url":"https://github.com/CenterForOpenScience/osf.io/pull/4338.patch"},"body":"Replaces [PR against @lyndsysimon's branch](https://github.com/lyndsysimon/osf.io/pull/8)\r\n## Purpose\r\nMerge `feature/prereg-prize-2` into `feature/prereg-prize`\r\nThis merge will bring in the actual prereg-prize specific features that have been developed by @samchrisinger and @barbour-em thus far.\r\n\r\n## Changes\r\n- **Activate** previously commented out code related to prereg-specific functionality\r\n- Adds `prereg-prize-test.json` schema to existing set of schemas\r\n- Expands `MetaSchema` to accommodate prereg-prize needs\r\n- Adds `DraftRegistrationApproval` class\r\n- Adds `draft approval` route\r\n- Adds numerous docstrings related to prereg and registration code\r\n\r\n## Notes:\r\nThis will require some thorough regression testing to make sure we don't re-work any existing functionality we don't have 'checked off' yet.\r\n\r\n1. There seems to be a PUT request for each character modified on field inputs. Is this excessive/necessary?\r\n  - This is causing console errors when attempting to reach `/api/v1/project/<pid>/draft/<draft_id>/ endpoints. Server logs show django related errors.\r\n\r\n## Prereg-prize draft registration overview:\r\n\r\n- Template\r\n![screen shot 2015-09-21 at 10 49 48 am](https://cloud.githubusercontent.com/assets/2614670/9995166/aceb6940-604e-11e5-9a28-229693a5daa6.png)\r\n  - **Fulfulls** section links to [https://cos.io/prereg](prereg-prize marketing page).   \r\n  - **TODO**: Fix html being escaped in the prereg-prize template\r\n\r\n- Tooltip regarding **Requires Approval** warning\r\n![screen shot 2015-09-21 at 10 50 02 am](https://cloud.githubusercontent.com/assets/2614670/9995196/d25ba280-604e-11e5-8524-3243e5d911ec.png)\r\n\r\n- In template examples\r\n![screen shot 2015-09-21 at 12 13 46 pm](https://cloud.githubusercontent.com/assets/2614670/9997467/4a4a5056-605a-11e5-9943-2be9397e0194.png)\r\n![screen shot 2015-09-21 at 12 13 53 pm](https://cloud.githubusercontent.com/assets/2614670/9997466/4a49aaf2-605a-11e5-8bb5-2e0798a188dd.png)\r\n\r\n- In template comments for each form field\r\n![screen shot 2015-09-21 at 12 14 41 pm](https://cloud.githubusercontent.com/assets/2614670/9997488/5c2bb10c-605a-11e5-9ef5-a8049743e726.png)\r\n\r\n- **Submit for review** button\r\n  - Overview\r\n![screen shot 2015-09-21 at 12 18 23 pm](https://cloud.githubusercontent.com/assets/2614670/9997584/f1cf9908-605a-11e5-8624-c99fdadf5bbe.png)\r\n  - Upon clicking **Submit for review**\r\n![screen shot 2015-09-21 at 12 26 01 pm](https://cloud.githubusercontent.com/assets/2614670/9997788/11b522a0-605c-11e5-80f6-a1c12f1aa8ff.png)\r\n  - After confirming submission\r\n![screen shot 2015-09-21 at 12 26 09 pm](https://cloud.githubusercontent.com/assets/2614670/9997792/168c8890-605c-11e5-9833-48cbca2c7dcd.png)\r\n\r\n- File uploads for specific form fields\r\n  - Not expanded\r\n![screen shot 2015-09-21 at 12 19 07 pm](https://cloud.githubusercontent.com/assets/2614670/9997593/03b0dcfe-605b-11e5-991b-c4500be48238.png)\r\n  - Expanded\r\n![screen shot 2015-09-21 at 12 21 32 pm](https://cloud.githubusercontent.com/assets/2614670/9997649/59e4a7cc-605b-11e5-83ad-61c1d84679c0.png)\r\n  - **NOTE:** files are attached via files that have been added to the parent project -- not something a user would upload from their computer.\r\n\r\n- **Certify** user input seems wonky.\r\n  - Do we want the user to 'sign' the text input? If so we should expand the placeholder to be more explicit.\r\n![screen shot 2015-09-21 at 12 23 38 pm](https://cloud.githubusercontent.com/assets/2614670/9997713/c1b21664-605b-11e5-886d-92e2a34a2a17.png)"},"comment":{"url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/comments/143063701","html_url":"https://github.com/CenterForOpenScience/osf.io/pull/4338#issuecomment-143063701","issue_url":"https://api.github.com/repos/CenterForOpenScience/osf.io/issues/4338","id":143063701,"user":{"login":"abought","id":2957073,"avatar_url":"https://avatars.githubusercontent.com/u/2957073?v=3","gravatar_id":"","url":"https://api.github.com/users/abought","html_url":"https://github.com/abought","followers_url":"https://api.github.com/users/abought/followers","following_url":"https://api.github.com/users/abought/following{/other_user}","gists_url":"https://api.github.com/users/abought/gists{/gist_id}","starred_url":"https://api.github.com/users/abought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abought/subscriptions","organizations_url":"https://api.github.com/users/abought/orgs","repos_url":"https://api.github.com/users/abought/repos","events_url":"https://api.github.com/users/abought/events{/privacy}","received_events_url":"https://api.github.com/users/abought/received_events","type":"User","site_admin":false},"created_at":"2015-09-24T22:12:14Z","updated_at":"2015-09-24T22:12:14Z","body":"The list of registrations refers to my prereg entry as \"pending approval\". As a user, it is unclear to me *whose* approval I'm waiting for (and no email text was dumped to console, celery, or mailserver console to give me insight in local testing).\r\n\r\nThere is also the same inexplicably disabled register button.\r\n\r\n"}}