{"action":"created","issue":{"url":"https://api.github.com/repos/nylas/sync-engine/issues/128","labels_url":"https://api.github.com/repos/nylas/sync-engine/issues/128/labels{/name}","comments_url":"https://api.github.com/repos/nylas/sync-engine/issues/128/comments","events_url":"https://api.github.com/repos/nylas/sync-engine/issues/128/events","html_url":"https://github.com/nylas/sync-engine/pull/128","id":60450828,"number":128,"title":"Add username and secure flag to SMTP/IMAP accounts","user":{"login":"thomasst","id":68381,"avatar_url":"https://avatars.githubusercontent.com/u/68381?v=3","gravatar_id":"","url":"https://api.github.com/users/thomasst","html_url":"https://github.com/thomasst","followers_url":"https://api.github.com/users/thomasst/followers","following_url":"https://api.github.com/users/thomasst/following{/other_user}","gists_url":"https://api.github.com/users/thomasst/gists{/gist_id}","starred_url":"https://api.github.com/users/thomasst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomasst/subscriptions","organizations_url":"https://api.github.com/users/thomasst/orgs","repos_url":"https://api.github.com/users/thomasst/repos","events_url":"https://api.github.com/users/thomasst/events{/privacy}","received_events_url":"https://api.github.com/users/thomasst/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-03-10T04:52:30Z","updated_at":"2015-04-07T22:57:41Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nylas/sync-engine/pulls/128","html_url":"https://github.com/nylas/sync-engine/pull/128","diff_url":"https://github.com/nylas/sync-engine/pull/128.diff","patch_url":"https://github.com/nylas/sync-engine/pull/128.patch"},"body":"This PR is based on the STARTTLS one (https://github.com/inboxapp/inbox/pull/125) and also fixes https://github.com/inboxapp/inbox/issues/110\r\n\r\n* Added `AuthHandler.connect_to_imap` which connects to the IMAP endpoint but doesn't authenticate to avoid repeating code.\r\n* Added support for non-SSL/TLS accounts using the `_imap_server_is_secure`/`_smtp_server_is_secure` flag. Endpoints are now a tuple of three items.\r\n* Added support for custom SMTP/IMAP login usernames using the `imap_username`/`smtp_username` fields."},"comment":{"url":"https://api.github.com/repos/nylas/sync-engine/issues/comments/90753413","html_url":"https://github.com/nylas/sync-engine/pull/128#issuecomment-90753413","issue_url":"https://api.github.com/repos/nylas/sync-engine/issues/128","id":90753413,"user":{"login":"spang","id":48515,"avatar_url":"https://avatars.githubusercontent.com/u/48515?v=3","gravatar_id":"","url":"https://api.github.com/users/spang","html_url":"https://github.com/spang","followers_url":"https://api.github.com/users/spang/followers","following_url":"https://api.github.com/users/spang/following{/other_user}","gists_url":"https://api.github.com/users/spang/gists{/gist_id}","starred_url":"https://api.github.com/users/spang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spang/subscriptions","organizations_url":"https://api.github.com/users/spang/orgs","repos_url":"https://api.github.com/users/spang/repos","events_url":"https://api.github.com/users/spang/events{/privacy}","received_events_url":"https://api.github.com/users/spang/received_events","type":"User","site_admin":false},"created_at":"2015-04-07T22:57:41Z","updated_at":"2015-04-07T22:57:41Z","body":"Yeah. We're aware, and are looking into that as well."}}