{"action":"created","comment":{"url":"https://api.github.com/repos/sulu-cmf/sulu/pulls/comments/23836992","id":23836992,"diff_hunk":"@@ -72,18 +72,22 @@ protected function renderStructure(\n \n             // if not preview enable cache handling\n             if (!$preview) {\n-                // mark the response as either public or private\n-                $response->setPublic();\n-\n-                // set the private and shared max age\n-                $response->setMaxAge(240);\n-                $response->setSharedMaxAge(960);\n-\n-                // set reverse-proxy TTL (Symfony HttpCache, Varnish, ...)\n-                $response->headers->set(\n-                    HttpCache::HEADER_REVERSE_PROXY_TTL,\n-                    $response->getAge() + intval($structure->getCacheLifeTime())\n-                );\n+                if (!$this->getRequest()->isMethod('GET')) {\n+                    $response->setPrivate();","path":"src/Sulu/Bundle/WebsiteBundle/Controller/WebsiteController.php","position":17,"original_position":17,"commit_id":"3468691c757ef21ac3d9a2d47bf57179f28658d6","original_commit_id":"3468691c757ef21ac3d9a2d47bf57179f28658d6","user":{"login":"danrot","id":405874,"avatar_url":"https://avatars.githubusercontent.com/u/405874?v=3","gravatar_id":"","url":"https://api.github.com/users/danrot","html_url":"https://github.com/danrot","followers_url":"https://api.github.com/users/danrot/followers","following_url":"https://api.github.com/users/danrot/following{/other_user}","gists_url":"https://api.github.com/users/danrot/gists{/gist_id}","starred_url":"https://api.github.com/users/danrot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danrot/subscriptions","organizations_url":"https://api.github.com/users/danrot/orgs","repos_url":"https://api.github.com/users/danrot/repos","events_url":"https://api.github.com/users/danrot/events{/privacy}","received_events_url":"https://api.github.com/users/danrot/received_events","type":"User","site_admin":false},"body":"Hopefully next week","created_at":"2015-01-30T11:33:17Z","updated_at":"2015-01-30T11:33:17Z","html_url":"https://github.com/sulu-cmf/sulu/pull/747#discussion_r23836992","pull_request_url":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747","_links":{"self":{"href":"https://api.github.com/repos/sulu-cmf/sulu/pulls/comments/23836992"},"html":{"href":"https://github.com/sulu-cmf/sulu/pull/747#discussion_r23836992"},"pull_request":{"href":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747"}}},"pull_request":{"url":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747","id":27910054,"html_url":"https://github.com/sulu-cmf/sulu/pull/747","diff_url":"https://github.com/sulu-cmf/sulu/pull/747.diff","patch_url":"https://github.com/sulu-cmf/sulu/pull/747.patch","issue_url":"https://api.github.com/repos/sulu-cmf/sulu/issues/747","number":747,"state":"closed","locked":false,"title":"set no caching headers for post request","user":{"login":"alexander-schranz","id":1698337,"avatar_url":"https://avatars.githubusercontent.com/u/1698337?v=3","gravatar_id":"","url":"https://api.github.com/users/alexander-schranz","html_url":"https://github.com/alexander-schranz","followers_url":"https://api.github.com/users/alexander-schranz/followers","following_url":"https://api.github.com/users/alexander-schranz/following{/other_user}","gists_url":"https://api.github.com/users/alexander-schranz/gists{/gist_id}","starred_url":"https://api.github.com/users/alexander-schranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexander-schranz/subscriptions","organizations_url":"https://api.github.com/users/alexander-schranz/orgs","repos_url":"https://api.github.com/users/alexander-schranz/repos","events_url":"https://api.github.com/users/alexander-schranz/events{/privacy}","received_events_url":"https://api.github.com/users/alexander-schranz/received_events","type":"User","site_admin":false},"body":"__Tasks:__\r\n\r\n- [ ] test coverage\r\n- [ ] gather feedback for my changes\r\n- [x] added changelog line\r\n\r\n\r\n__Informations:__\r\n\r\n| Q             | A\r\n| ------------- | ---\r\n| Tests pass?   | none\r\n| Fixed tickets | fixes #746 \r\n| BC Breaks     | no\r\n| Doc           | none","created_at":"2015-01-23T09:16:00Z","updated_at":"2015-01-30T11:33:17Z","closed_at":"2015-01-30T07:59:35Z","merged_at":null,"merge_commit_sha":"b695746f6467a52b4e3283bdda8f10ba4966a8f2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747/commits","review_comments_url":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747/comments","review_comment_url":"https://api.github.com/repos/sulu-cmf/sulu/pulls/comments/{number}","comments_url":"https://api.github.com/repos/sulu-cmf/sulu/issues/747/comments","statuses_url":"https://api.github.com/repos/sulu-cmf/sulu/statuses/3468691c757ef21ac3d9a2d47bf57179f28658d6","head":{"label":"sulu-cmf:bugfix/#746-cache-post","ref":"bugfix/#746-cache-post","sha":"3468691c757ef21ac3d9a2d47bf57179f28658d6","user":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu-cmf/sulu","owner":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu-cmf/sulu","description":"Sulu 2.0 core bundle & components","fork":false,"url":"https://api.github.com/repos/sulu-cmf/sulu","forks_url":"https://api.github.com/repos/sulu-cmf/sulu/forks","keys_url":"https://api.github.com/repos/sulu-cmf/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu-cmf/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu-cmf/sulu/teams","hooks_url":"https://api.github.com/repos/sulu-cmf/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu-cmf/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu-cmf/sulu/events","assignees_url":"https://api.github.com/repos/sulu-cmf/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu-cmf/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu-cmf/sulu/tags","blobs_url":"https://api.github.com/repos/sulu-cmf/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu-cmf/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu-cmf/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu-cmf/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu-cmf/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu-cmf/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu-cmf/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu-cmf/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu-cmf/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu-cmf/sulu/subscription","commits_url":"https://api.github.com/repos/sulu-cmf/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu-cmf/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu-cmf/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu-cmf/sulu/issues/comments/{number}","contents_url":"https://api.github.com/repos/sulu-cmf/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu-cmf/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu-cmf/sulu/merges","archive_url":"https://api.github.com/repos/sulu-cmf/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu-cmf/sulu/downloads","issues_url":"https://api.github.com/repos/sulu-cmf/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu-cmf/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu-cmf/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu-cmf/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu-cmf/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu-cmf/sulu/releases{/id}","created_at":"2013-10-18T12:57:02Z","updated_at":"2015-01-29T16:10:37Z","pushed_at":"2015-01-30T10:23:08Z","git_url":"git://github.com/sulu-cmf/sulu.git","ssh_url":"git@github.com:sulu-cmf/sulu.git","clone_url":"https://github.com/sulu-cmf/sulu.git","svn_url":"https://github.com/sulu-cmf/sulu","homepage":"www.sulu.io","size":35132,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":240,"forks":7,"open_issues":240,"watchers":19,"default_branch":"develop"}},"base":{"label":"sulu-cmf:develop","ref":"develop","sha":"b2c16c4e9a70d8dffb33ed92a65d4afc2d3ebc15","user":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"repo":{"id":13678015,"name":"sulu","full_name":"sulu-cmf/sulu","owner":{"login":"sulu-cmf","id":5717006,"avatar_url":"https://avatars.githubusercontent.com/u/5717006?v=3","gravatar_id":"","url":"https://api.github.com/users/sulu-cmf","html_url":"https://github.com/sulu-cmf","followers_url":"https://api.github.com/users/sulu-cmf/followers","following_url":"https://api.github.com/users/sulu-cmf/following{/other_user}","gists_url":"https://api.github.com/users/sulu-cmf/gists{/gist_id}","starred_url":"https://api.github.com/users/sulu-cmf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sulu-cmf/subscriptions","organizations_url":"https://api.github.com/users/sulu-cmf/orgs","repos_url":"https://api.github.com/users/sulu-cmf/repos","events_url":"https://api.github.com/users/sulu-cmf/events{/privacy}","received_events_url":"https://api.github.com/users/sulu-cmf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sulu-cmf/sulu","description":"Sulu 2.0 core bundle & components","fork":false,"url":"https://api.github.com/repos/sulu-cmf/sulu","forks_url":"https://api.github.com/repos/sulu-cmf/sulu/forks","keys_url":"https://api.github.com/repos/sulu-cmf/sulu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sulu-cmf/sulu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sulu-cmf/sulu/teams","hooks_url":"https://api.github.com/repos/sulu-cmf/sulu/hooks","issue_events_url":"https://api.github.com/repos/sulu-cmf/sulu/issues/events{/number}","events_url":"https://api.github.com/repos/sulu-cmf/sulu/events","assignees_url":"https://api.github.com/repos/sulu-cmf/sulu/assignees{/user}","branches_url":"https://api.github.com/repos/sulu-cmf/sulu/branches{/branch}","tags_url":"https://api.github.com/repos/sulu-cmf/sulu/tags","blobs_url":"https://api.github.com/repos/sulu-cmf/sulu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sulu-cmf/sulu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sulu-cmf/sulu/git/refs{/sha}","trees_url":"https://api.github.com/repos/sulu-cmf/sulu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sulu-cmf/sulu/statuses/{sha}","languages_url":"https://api.github.com/repos/sulu-cmf/sulu/languages","stargazers_url":"https://api.github.com/repos/sulu-cmf/sulu/stargazers","contributors_url":"https://api.github.com/repos/sulu-cmf/sulu/contributors","subscribers_url":"https://api.github.com/repos/sulu-cmf/sulu/subscribers","subscription_url":"https://api.github.com/repos/sulu-cmf/sulu/subscription","commits_url":"https://api.github.com/repos/sulu-cmf/sulu/commits{/sha}","git_commits_url":"https://api.github.com/repos/sulu-cmf/sulu/git/commits{/sha}","comments_url":"https://api.github.com/repos/sulu-cmf/sulu/comments{/number}","issue_comment_url":"https://api.github.com/repos/sulu-cmf/sulu/issues/comments/{number}","contents_url":"https://api.github.com/repos/sulu-cmf/sulu/contents/{+path}","compare_url":"https://api.github.com/repos/sulu-cmf/sulu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sulu-cmf/sulu/merges","archive_url":"https://api.github.com/repos/sulu-cmf/sulu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sulu-cmf/sulu/downloads","issues_url":"https://api.github.com/repos/sulu-cmf/sulu/issues{/number}","pulls_url":"https://api.github.com/repos/sulu-cmf/sulu/pulls{/number}","milestones_url":"https://api.github.com/repos/sulu-cmf/sulu/milestones{/number}","notifications_url":"https://api.github.com/repos/sulu-cmf/sulu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sulu-cmf/sulu/labels{/name}","releases_url":"https://api.github.com/repos/sulu-cmf/sulu/releases{/id}","created_at":"2013-10-18T12:57:02Z","updated_at":"2015-01-29T16:10:37Z","pushed_at":"2015-01-30T10:23:08Z","git_url":"git://github.com/sulu-cmf/sulu.git","ssh_url":"git@github.com:sulu-cmf/sulu.git","clone_url":"https://github.com/sulu-cmf/sulu.git","svn_url":"https://github.com/sulu-cmf/sulu","homepage":"www.sulu.io","size":35132,"stargazers_count":19,"watchers_count":19,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"open_issues_count":240,"forks":7,"open_issues":240,"watchers":19,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747"},"html":{"href":"https://github.com/sulu-cmf/sulu/pull/747"},"issue":{"href":"https://api.github.com/repos/sulu-cmf/sulu/issues/747"},"comments":{"href":"https://api.github.com/repos/sulu-cmf/sulu/issues/747/comments"},"review_comments":{"href":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747/comments"},"review_comment":{"href":"https://api.github.com/repos/sulu-cmf/sulu/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/sulu-cmf/sulu/pulls/747/commits"},"statuses":{"href":"https://api.github.com/repos/sulu-cmf/sulu/statuses/3468691c757ef21ac3d9a2d47bf57179f28658d6"}}}}