{"action":"created","issue":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1142","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1142/labels{/name}","comments_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1142/comments","events_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1142/events","html_url":"https://github.com/MarlinFirmware/Marlin/issues/1142","id":48524687,"number":1142,"title":"Ramps 1.4 Reprap Discount full graphic + reprapworld keypad","user":{"login":"vanhooren","id":9697619,"avatar_url":"https://avatars.githubusercontent.com/u/9697619?v=3","gravatar_id":"","url":"https://api.github.com/users/vanhooren","html_url":"https://github.com/vanhooren","followers_url":"https://api.github.com/users/vanhooren/followers","following_url":"https://api.github.com/users/vanhooren/following{/other_user}","gists_url":"https://api.github.com/users/vanhooren/gists{/gist_id}","starred_url":"https://api.github.com/users/vanhooren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanhooren/subscriptions","organizations_url":"https://api.github.com/users/vanhooren/orgs","repos_url":"https://api.github.com/users/vanhooren/repos","events_url":"https://api.github.com/users/vanhooren/events{/privacy}","received_events_url":"https://api.github.com/users/vanhooren/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/labels/Verified+bug","name":"Verified bug","color":"e11d21"}],"state":"open","locked":false,"assignee":{"login":"stv0g","id":285829,"avatar_url":"https://avatars.githubusercontent.com/u/285829?v=3","gravatar_id":"","url":"https://api.github.com/users/stv0g","html_url":"https://github.com/stv0g","followers_url":"https://api.github.com/users/stv0g/followers","following_url":"https://api.github.com/users/stv0g/following{/other_user}","gists_url":"https://api.github.com/users/stv0g/gists{/gist_id}","starred_url":"https://api.github.com/users/stv0g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stv0g/subscriptions","organizations_url":"https://api.github.com/users/stv0g/orgs","repos_url":"https://api.github.com/users/stv0g/repos","events_url":"https://api.github.com/users/stv0g/events{/privacy}","received_events_url":"https://api.github.com/users/stv0g/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones/2","labels_url":"https://api.github.com/repos/MarlinFirmware/Marlin/milestones/2/labels","id":924172,"number":2,"title":"Bug Fixing Round 2","description":"","creator":{"login":"boelle","id":3832239,"avatar_url":"https://avatars.githubusercontent.com/u/3832239?v=3","gravatar_id":"","url":"https://api.github.com/users/boelle","html_url":"https://github.com/boelle","followers_url":"https://api.github.com/users/boelle/followers","following_url":"https://api.github.com/users/boelle/following{/other_user}","gists_url":"https://api.github.com/users/boelle/gists{/gist_id}","starred_url":"https://api.github.com/users/boelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boelle/subscriptions","organizations_url":"https://api.github.com/users/boelle/orgs","repos_url":"https://api.github.com/users/boelle/repos","events_url":"https://api.github.com/users/boelle/events{/privacy}","received_events_url":"https://api.github.com/users/boelle/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":0,"state":"open","created_at":"2015-01-06T17:52:12Z","updated_at":"2015-01-15T14:34:01Z","due_on":"2015-03-07T23:00:00Z","closed_at":null},"comments":17,"created_at":"2014-11-12T15:44:07Z","updated_at":"2015-01-16T19:02:49Z","closed_at":null,"body":"I can't seem to get the marlin firmware to compile when the following is selected\r\nmotherboard 33 ''ramps\"\r\n```\r\n#define REPRAPWORLD_KEYPAD\r\n#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER\r\n```\r\n\r\nthe firmware will compile when\r\n  - I only select the discount controller\r\n  - I only select the keypad but only in the older marlin version I used not in the newest version.\r\n\r\nSelecting both these will not compile in any marlin version i tested.\r\nI understand that there is some overlap in functionality between the reprap discount rotary encoder and the keypad rotary encoder perhaps this is the problem? \r\nUnfortunately I am not a programmer and between learning 3d modeling and learning about printing in general i doubt i will have time to delve into it in the next couple of weeks.\r\nI will do my best to understand the issues further. \r\nI was planning on doing vb.net evening courses but that is still a couple of months away.\r\n\r\nWhen trying to compile with board set to 33 (ramps 1.4)\r\n```\r\n#define REPRAPWORLD_KEYPAD\r\n#define REPRAP_DISCOUNT_FULL_GRAPHIC_SMART_CONTROLLER uncommented\r\n```\r\n\r\nI get the following error log \r\n\r\n```\r\nultralcd.cpp: In function 'void lcd_init()':\r\nultralcd.cpp:1176: error: 'SHIFT_CLK' was not declared in this scope\r\nultralcd.cpp:1177: error: 'SHIFT_LD' was not declared in this scope\r\nultralcd.cpp:1178: error: 'SHIFT_OUT' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_RPORT' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_WPORT' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_PIN' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_WPORT' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_PIN' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_WPORT' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_PIN' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_WPORT' was not declared in this scope\r\nultralcd.cpp:1179: error: 'DIOSHIFT_OUT_PIN' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_RPORT' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1180: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp: In function 'void lcd_update()':\r\nultralcd.cpp:1249: error: 'BLEN_REPRAPWORLD_KEYPAD_F2' was not declared in this scope\r\nultralcd.cpp:1252: error: 'BLEN_REPRAPWORLD_KEYPAD_F3' was not declared in this scope\r\nultralcd.cpp:1255: error: 'BLEN_REPRAPWORLD_KEYPAD_LEFT' was not declared in this scope\r\nultralcd.cpp:1258: error: 'BLEN_REPRAPWORLD_KEYPAD_RIGHT' was not declared in this scope\r\nultralcd.cpp:1261: error: 'BLEN_REPRAPWORLD_KEYPAD_DOWN' was not declared in this scope\r\nultralcd.cpp:1264: error: 'BLEN_REPRAPWORLD_KEYPAD_UP' was not declared in this scope\r\nultralcd.cpp:1267: error: 'BLEN_REPRAPWORLD_KEYPAD_MIDDLE' was not declared in this scope\r\nultralcd.cpp: In function 'void lcd_buttons_update()':\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_RPORT' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1372: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_RPORT' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_WPORT' was not declared in this scope\r\nultralcd.cpp:1373: error: 'DIOSHIFT_LD_PIN' was not declared in this scope\r\nultralcd.cpp:1376: error: 'DIOSHIFT_OUT_RPORT' was not declared in this scope\r\nultralcd.cpp:1376: error: 'DIOSHIFT_OUT_PIN' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_RPORT' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1378: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_RPORT' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_WPORT' was not declared in this scope\r\nultralcd.cpp:1379: error: 'DIOSHIFT_CLK_PIN' was not declared in this scope\r\n```\r\n\r\nwhen compiling with only  the  `#define REPRAPWORLD_KEYPAD` uncommented \r\ni get the this error \r\n\r\n```\r\nIn file included from ultralcd.cpp:38:\r\nultralcd_implementation_hitachi_HD44780.h:12: error: conflicting declaration 'volatile uint16_t buttons'\r\nultralcd.h:30: error: 'buttons' has a previous declaration as 'volatile uint8_t buttons'\r\n```\r\ncompiling with only the full graphics controller has always worked fine \r\n\r\nIf i missed something bleedingly obvious i am sorry for wasting time \r\n\r\nI have found issues that debate a similar problem but found no solution that could be applied to my \r\nexact situation  \r\n"},"comment":{"url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/comments/70304144","html_url":"https://github.com/MarlinFirmware/Marlin/issues/1142#issuecomment-70304144","issue_url":"https://api.github.com/repos/MarlinFirmware/Marlin/issues/1142","id":70304144,"user":{"login":"lordofhyphens","id":31754,"avatar_url":"https://avatars.githubusercontent.com/u/31754?v=3","gravatar_id":"","url":"https://api.github.com/users/lordofhyphens","html_url":"https://github.com/lordofhyphens","followers_url":"https://api.github.com/users/lordofhyphens/followers","following_url":"https://api.github.com/users/lordofhyphens/following{/other_user}","gists_url":"https://api.github.com/users/lordofhyphens/gists{/gist_id}","starred_url":"https://api.github.com/users/lordofhyphens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lordofhyphens/subscriptions","organizations_url":"https://api.github.com/users/lordofhyphens/orgs","repos_url":"https://api.github.com/users/lordofhyphens/repos","events_url":"https://api.github.com/users/lordofhyphens/events{/privacy}","received_events_url":"https://api.github.com/users/lordofhyphens/received_events","type":"User","site_admin":false},"created_at":"2015-01-16T19:02:49Z","updated_at":"2015-01-16T19:02:49Z","body":"I was mostly thinking about refactoring that area so that there is an\r\nestablished way of handling 2 overlapping input devices. Right now anything\r\nthat has buttons creates the same structure and assumes that the\r\npreprocessor will sort everything out.\r\n\r\nAlso who did write the support for the keypad?\r\nOn Jan 16, 2015 12:55 PM, \"Erik van der Zalm\" <notifications@github.com>\r\nwrote:\r\n\r\n> The reprapworld keypad is something that we do not support.\r\n> reprapworld made the keypad and did not work on the firmware side. They\r\n> sell hardware and get a lot of money for it. They expect that others make\r\n> the firmware.\r\n> We do not make firmware for 1 specific type of hardware. reprapworld can\r\n> add support and send a pull request.\r\n> (That is how the other hardware developers do it)\r\n>\r\n> If you have a reprapworld keypad, Ask reprapworld for support.\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/MarlinFirmware/Marlin/issues/1142#issuecomment-70302894>\r\n> .\r\n>"}}