{"action":"created","comment":{"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments/40090811","id":40090811,"diff_hunk":"@@ -261,18 +261,25 @@ func (c *Client) doWithBody(req *http.Request, body io.ReadSeeker) (*http.Respon\n \tif err != nil {\n \t\treturn nil, errgo.Mask(err, errgo.Any)\n \t}\n+\tvar cookiePath string\n \tcookieURL := req.URL\n \tif path := resp.Info.MacaroonPath; path != \"\" {\n \t\trelURL, err := parseURLPath(path)\n \t\tif err != nil {\n \t\t\tlogger.Warningf(\"ignoring invalid path in discharge-required response: %v\", err)\n \t\t} else {\n-\t\t\tcookieURL = req.URL.ResolveReference(relURL)\n+\t\t\tcookieURL := req.URL.ResolveReference(relURL)\n+\t\t\tcookiePath = cookieURL.Path\n \t\t}\n \t}\n-\tif err := SetCookie(c.Jar, cookieURL, macaroons); err != nil {\n+\tif len(cookiePath) > 1 && strings.HasSuffix(cookiePath, \"/\") {\n+\t\tcookiePath = strings.TrimSuffix(cookiePath, \"/\")\n+\t}\n+\tlogger.Debugf(\"cookiePath: %q\", cookiePath)\n+\tif err := SetCookieWithPath(c.Jar, cookieURL, cookiePath, macaroons); err != nil {","path":"httpbakery/client.go","position":21,"original_position":21,"commit_id":"dc6ca0fcd56d286d2dd9913c7b1b6484bc8b064b","original_commit_id":"dc6ca0fcd56d286d2dd9913c7b1b6484bc8b064b","user":{"login":"rogpeppe","id":66491,"avatar_url":"https://avatars.githubusercontent.com/u/66491?v=3","gravatar_id":"","url":"https://api.github.com/users/rogpeppe","html_url":"https://github.com/rogpeppe","followers_url":"https://api.github.com/users/rogpeppe/followers","following_url":"https://api.github.com/users/rogpeppe/following{/other_user}","gists_url":"https://api.github.com/users/rogpeppe/gists{/gist_id}","starred_url":"https://api.github.com/users/rogpeppe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogpeppe/subscriptions","organizations_url":"https://api.github.com/users/rogpeppe/orgs","repos_url":"https://api.github.com/users/rogpeppe/repos","events_url":"https://api.github.com/users/rogpeppe/events{/privacy}","received_events_url":"https://api.github.com/users/rogpeppe/received_events","type":"User","site_admin":false},"body":"Given that you're setting the cookie path here, why not just use req.URL ?\r\n","created_at":"2015-09-22T14:14:58Z","updated_at":"2015-09-22T14:14:58Z","html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/64#discussion_r40090811","pull_request_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64","_links":{"self":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments/40090811"},"html":{"href":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/64#discussion_r40090811"},"pull_request":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64","id":45666000,"html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/64","diff_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/64.diff","patch_url":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/64.patch","issue_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/64","number":64,"state":"open","locked":false,"title":"use paths set in macaroon discharges without change","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"body":"If a discharge required error set a macaroon path then the cookie path used will match this path exactly.","created_at":"2015-09-22T13:55:30Z","updated_at":"2015-09-22T14:14:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cba9b4a7627e6b6bd09027044a38c1927d667384","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64/commits","review_comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64/comments","review_comment_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/64/comments","statuses_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/dc6ca0fcd56d286d2dd9913c7b1b6484bc8b064b","head":{"label":"mhilton:007-macaroon-path","ref":"007-macaroon-path","sha":"dc6ca0fcd56d286d2dd9913c7b1b6484bc8b064b","user":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"repo":{"id":29598274,"name":"macaroon-bakery","full_name":"mhilton/macaroon-bakery","owner":{"login":"mhilton","id":1136018,"avatar_url":"https://avatars.githubusercontent.com/u/1136018?v=3","gravatar_id":"","url":"https://api.github.com/users/mhilton","html_url":"https://github.com/mhilton","followers_url":"https://api.github.com/users/mhilton/followers","following_url":"https://api.github.com/users/mhilton/following{/other_user}","gists_url":"https://api.github.com/users/mhilton/gists{/gist_id}","starred_url":"https://api.github.com/users/mhilton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhilton/subscriptions","organizations_url":"https://api.github.com/users/mhilton/orgs","repos_url":"https://api.github.com/users/mhilton/repos","events_url":"https://api.github.com/users/mhilton/events{/privacy}","received_events_url":"https://api.github.com/users/mhilton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhilton/macaroon-bakery","description":"We bake 'em sweet, we bake 'em nice","fork":true,"url":"https://api.github.com/repos/mhilton/macaroon-bakery","forks_url":"https://api.github.com/repos/mhilton/macaroon-bakery/forks","keys_url":"https://api.github.com/repos/mhilton/macaroon-bakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhilton/macaroon-bakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhilton/macaroon-bakery/teams","hooks_url":"https://api.github.com/repos/mhilton/macaroon-bakery/hooks","issue_events_url":"https://api.github.com/repos/mhilton/macaroon-bakery/issues/events{/number}","events_url":"https://api.github.com/repos/mhilton/macaroon-bakery/events","assignees_url":"https://api.github.com/repos/mhilton/macaroon-bakery/assignees{/user}","branches_url":"https://api.github.com/repos/mhilton/macaroon-bakery/branches{/branch}","tags_url":"https://api.github.com/repos/mhilton/macaroon-bakery/tags","blobs_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhilton/macaroon-bakery/statuses/{sha}","languages_url":"https://api.github.com/repos/mhilton/macaroon-bakery/languages","stargazers_url":"https://api.github.com/repos/mhilton/macaroon-bakery/stargazers","contributors_url":"https://api.github.com/repos/mhilton/macaroon-bakery/contributors","subscribers_url":"https://api.github.com/repos/mhilton/macaroon-bakery/subscribers","subscription_url":"https://api.github.com/repos/mhilton/macaroon-bakery/subscription","commits_url":"https://api.github.com/repos/mhilton/macaroon-bakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhilton/macaroon-bakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhilton/macaroon-bakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhilton/macaroon-bakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhilton/macaroon-bakery/contents/{+path}","compare_url":"https://api.github.com/repos/mhilton/macaroon-bakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhilton/macaroon-bakery/merges","archive_url":"https://api.github.com/repos/mhilton/macaroon-bakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhilton/macaroon-bakery/downloads","issues_url":"https://api.github.com/repos/mhilton/macaroon-bakery/issues{/number}","pulls_url":"https://api.github.com/repos/mhilton/macaroon-bakery/pulls{/number}","milestones_url":"https://api.github.com/repos/mhilton/macaroon-bakery/milestones{/number}","notifications_url":"https://api.github.com/repos/mhilton/macaroon-bakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhilton/macaroon-bakery/labels{/name}","releases_url":"https://api.github.com/repos/mhilton/macaroon-bakery/releases{/id}","created_at":"2015-01-21T16:15:10Z","updated_at":"2015-01-21T16:15:11Z","pushed_at":"2015-09-22T13:53:55Z","git_url":"git://github.com/mhilton/macaroon-bakery.git","ssh_url":"git@github.com:mhilton/macaroon-bakery.git","clone_url":"https://github.com/mhilton/macaroon-bakery.git","svn_url":"https://github.com/mhilton/macaroon-bakery","homepage":null,"size":449,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v0"}},"base":{"label":"go-macaroon-bakery:v1","ref":"v1","sha":"bae62ed8328f00e1155e36bfb9f7a2bcd5392bde","user":{"login":"go-macaroon-bakery","id":9721471,"avatar_url":"https://avatars.githubusercontent.com/u/9721471?v=3","gravatar_id":"","url":"https://api.github.com/users/go-macaroon-bakery","html_url":"https://github.com/go-macaroon-bakery","followers_url":"https://api.github.com/users/go-macaroon-bakery/followers","following_url":"https://api.github.com/users/go-macaroon-bakery/following{/other_user}","gists_url":"https://api.github.com/users/go-macaroon-bakery/gists{/gist_id}","starred_url":"https://api.github.com/users/go-macaroon-bakery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-macaroon-bakery/subscriptions","organizations_url":"https://api.github.com/users/go-macaroon-bakery/orgs","repos_url":"https://api.github.com/users/go-macaroon-bakery/repos","events_url":"https://api.github.com/users/go-macaroon-bakery/events{/privacy}","received_events_url":"https://api.github.com/users/go-macaroon-bakery/received_events","type":"Organization","site_admin":false},"repo":{"id":26593206,"name":"macaroon-bakery","full_name":"go-macaroon-bakery/macaroon-bakery","owner":{"login":"go-macaroon-bakery","id":9721471,"avatar_url":"https://avatars.githubusercontent.com/u/9721471?v=3","gravatar_id":"","url":"https://api.github.com/users/go-macaroon-bakery","html_url":"https://github.com/go-macaroon-bakery","followers_url":"https://api.github.com/users/go-macaroon-bakery/followers","following_url":"https://api.github.com/users/go-macaroon-bakery/following{/other_user}","gists_url":"https://api.github.com/users/go-macaroon-bakery/gists{/gist_id}","starred_url":"https://api.github.com/users/go-macaroon-bakery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-macaroon-bakery/subscriptions","organizations_url":"https://api.github.com/users/go-macaroon-bakery/orgs","repos_url":"https://api.github.com/users/go-macaroon-bakery/repos","events_url":"https://api.github.com/users/go-macaroon-bakery/events{/privacy}","received_events_url":"https://api.github.com/users/go-macaroon-bakery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-macaroon-bakery/macaroon-bakery","description":"We bake 'em sweet, we bake 'em nice","fork":false,"url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery","forks_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/forks","keys_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/teams","hooks_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/hooks","issue_events_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/events{/number}","events_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/events","assignees_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/assignees{/user}","branches_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/branches{/branch}","tags_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/tags","blobs_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/{sha}","languages_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/languages","stargazers_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/stargazers","contributors_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/contributors","subscribers_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/subscribers","subscription_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/subscription","commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/contents/{+path}","compare_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/merges","archive_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/downloads","issues_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues{/number}","pulls_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls{/number}","milestones_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/milestones{/number}","notifications_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/labels{/name}","releases_url":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/releases{/id}","created_at":"2014-11-13T15:08:41Z","updated_at":"2015-06-04T11:37:00Z","pushed_at":"2015-09-22T13:55:30Z","git_url":"git://github.com/go-macaroon-bakery/macaroon-bakery.git","ssh_url":"git@github.com:go-macaroon-bakery/macaroon-bakery.git","clone_url":"https://github.com/go-macaroon-bakery/macaroon-bakery.git","svn_url":"https://github.com/go-macaroon-bakery/macaroon-bakery","homepage":null,"size":792,"stargazers_count":13,"watchers_count":13,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":2,"forks":8,"open_issues":2,"watchers":13,"default_branch":"v1"}},"_links":{"self":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64"},"html":{"href":"https://github.com/go-macaroon-bakery/macaroon-bakery/pull/64"},"issue":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/64"},"comments":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/go-macaroon-bakery/macaroon-bakery/statuses/dc6ca0fcd56d286d2dd9913c7b1b6484bc8b064b"}}}}