{"action":"created","comment":{"url":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments/35141724","id":35141724,"diff_hunk":"@@ -183,12 +183,22 @@ function dosomething_signup_sms_game_form($form, &$form_state, $node, $num_frien\n     ),\n   );\n   for ($i = 0; $i < $num_friends; $i++) {\n-    $form['group1']['beta_first_name_' .$i] = array(\n-      '#type' => 'hidden',\n-      '#title' => 'Your Friend\\'s Name',\n-    );\n+    // If this is a multiplayer game, add first name fields.\n+    if ($form['sms_game_type']['#default_value'] === 'multi_player') {\n+      $form['beta_first_name_' .$i] = array(\n+        '#type' => 'textfield',\n+        '#title' => 'Your Friend\\'s Name',\n+        '#required' => TRUE,\n+        '#attributes' => array(\n+          'data-validate' => 'friend_name',\n+          'data-validate-required' => '',\n+          'placeholder' => t('(555) 555-5555'),","path":"lib/modules/dosomething/dosomething_signup/dosomething_signup.forms.inc","position":null,"original_position":47,"commit_id":"9085ead177587037cfa483ee718d88cb8ca75255","original_commit_id":"46987396820e8eca9effdb0f04451a5e8c33b4d2","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"body":"Fixed!","created_at":"2015-07-21T19:11:16Z","updated_at":"2015-07-21T19:11:16Z","html_url":"https://github.com/DoSomething/dosomething/pull/4710#discussion_r35141724","pull_request_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710","_links":{"self":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments/35141724"},"html":{"href":"https://github.com/DoSomething/dosomething/pull/4710#discussion_r35141724"},"pull_request":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710"}}},"pull_request":{"url":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710","id":40486333,"html_url":"https://github.com/DoSomething/dosomething/pull/4710","diff_url":"https://github.com/DoSomething/dosomething/pull/4710.diff","patch_url":"https://github.com/DoSomething/dosomething/pull/4710.patch","issue_url":"https://api.github.com/repos/DoSomething/dosomething/issues/4710","number":4710,"state":"open","locked":false,"title":"Form updates for multiplayer SMS games","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"body":"# Step 1: Know It\r\n - This merges in the changes that were A/B tested in #4247. All multiplayer games will now have first name fields. Closes #4499.\r\n\r\nFor review: @angaither @aaronschachter @tongxiang \r\n\r\n# Step 4: Prove It\r\nFor single-player games (configured with `mobilecommons_opt_in_path` and `mobilecommons_friends_opt_in_path`):\r\n![screen shot 2015-07-21 at 3 10 12 pm](https://cloud.githubusercontent.com/assets/583202/8810096/a86a2be6-2fba-11e5-9611-5d89ece986b5.png)\r\n\r\nFor multiplayer games (configured with `ms_game_mp_story_id` and `sms_game_mp_story_type`):\r\n![screen shot 2015-07-21 at 3 10 22 pm](https://cloud.githubusercontent.com/assets/583202/8810099/ab40ad40-2fba-11e5-9c21-26e8fb639172.png)\r\n\r\n\r\n","created_at":"2015-07-21T18:02:42Z","updated_at":"2015-07-21T19:11:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e397571c342fef966a4d1c1d44dc6f473b05a276","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710/commits","review_comments_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710/comments","review_comment_url":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DoSomething/dosomething/issues/4710/comments","statuses_url":"https://api.github.com/repos/DoSomething/dosomething/statuses/9085ead177587037cfa483ee718d88cb8ca75255","head":{"label":"DFurnes:sms-form-stuffs","ref":"sms-form-stuffs","sha":"9085ead177587037cfa483ee718d88cb8ca75255","user":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"repo":{"id":23975099,"name":"dosomething","full_name":"DFurnes/dosomething","owner":{"login":"DFurnes","id":583202,"avatar_url":"https://avatars.githubusercontent.com/u/583202?v=3","gravatar_id":"","url":"https://api.github.com/users/DFurnes","html_url":"https://github.com/DFurnes","followers_url":"https://api.github.com/users/DFurnes/followers","following_url":"https://api.github.com/users/DFurnes/following{/other_user}","gists_url":"https://api.github.com/users/DFurnes/gists{/gist_id}","starred_url":"https://api.github.com/users/DFurnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DFurnes/subscriptions","organizations_url":"https://api.github.com/users/DFurnes/orgs","repos_url":"https://api.github.com/users/DFurnes/repos","events_url":"https://api.github.com/users/DFurnes/events{/privacy}","received_events_url":"https://api.github.com/users/DFurnes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DFurnes/dosomething","description":"A Drupal 7 distribution that powers the DoSomething.org web platform.","fork":true,"url":"https://api.github.com/repos/DFurnes/dosomething","forks_url":"https://api.github.com/repos/DFurnes/dosomething/forks","keys_url":"https://api.github.com/repos/DFurnes/dosomething/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DFurnes/dosomething/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DFurnes/dosomething/teams","hooks_url":"https://api.github.com/repos/DFurnes/dosomething/hooks","issue_events_url":"https://api.github.com/repos/DFurnes/dosomething/issues/events{/number}","events_url":"https://api.github.com/repos/DFurnes/dosomething/events","assignees_url":"https://api.github.com/repos/DFurnes/dosomething/assignees{/user}","branches_url":"https://api.github.com/repos/DFurnes/dosomething/branches{/branch}","tags_url":"https://api.github.com/repos/DFurnes/dosomething/tags","blobs_url":"https://api.github.com/repos/DFurnes/dosomething/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DFurnes/dosomething/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DFurnes/dosomething/git/refs{/sha}","trees_url":"https://api.github.com/repos/DFurnes/dosomething/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DFurnes/dosomething/statuses/{sha}","languages_url":"https://api.github.com/repos/DFurnes/dosomething/languages","stargazers_url":"https://api.github.com/repos/DFurnes/dosomething/stargazers","contributors_url":"https://api.github.com/repos/DFurnes/dosomething/contributors","subscribers_url":"https://api.github.com/repos/DFurnes/dosomething/subscribers","subscription_url":"https://api.github.com/repos/DFurnes/dosomething/subscription","commits_url":"https://api.github.com/repos/DFurnes/dosomething/commits{/sha}","git_commits_url":"https://api.github.com/repos/DFurnes/dosomething/git/commits{/sha}","comments_url":"https://api.github.com/repos/DFurnes/dosomething/comments{/number}","issue_comment_url":"https://api.github.com/repos/DFurnes/dosomething/issues/comments{/number}","contents_url":"https://api.github.com/repos/DFurnes/dosomething/contents/{+path}","compare_url":"https://api.github.com/repos/DFurnes/dosomething/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DFurnes/dosomething/merges","archive_url":"https://api.github.com/repos/DFurnes/dosomething/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DFurnes/dosomething/downloads","issues_url":"https://api.github.com/repos/DFurnes/dosomething/issues{/number}","pulls_url":"https://api.github.com/repos/DFurnes/dosomething/pulls{/number}","milestones_url":"https://api.github.com/repos/DFurnes/dosomething/milestones{/number}","notifications_url":"https://api.github.com/repos/DFurnes/dosomething/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DFurnes/dosomething/labels{/name}","releases_url":"https://api.github.com/repos/DFurnes/dosomething/releases{/id}","created_at":"2014-09-12T20:07:06Z","updated_at":"2015-05-07T18:01:50Z","pushed_at":"2015-07-21T19:09:52Z","git_url":"git://github.com/DFurnes/dosomething.git","ssh_url":"git@github.com:DFurnes/dosomething.git","clone_url":"https://github.com/DFurnes/dosomething.git","svn_url":"https://github.com/DFurnes/dosomething","homepage":"http://www.dosomething.org/","size":14570,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"DoSomething:dev","ref":"dev","sha":"13655f6f223705f4f99284f88e942ec30cc55926","user":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"repo":{"id":13592927,"name":"dosomething","full_name":"DoSomething/dosomething","owner":{"login":"DoSomething","id":731685,"avatar_url":"https://avatars.githubusercontent.com/u/731685?v=3","gravatar_id":"","url":"https://api.github.com/users/DoSomething","html_url":"https://github.com/DoSomething","followers_url":"https://api.github.com/users/DoSomething/followers","following_url":"https://api.github.com/users/DoSomething/following{/other_user}","gists_url":"https://api.github.com/users/DoSomething/gists{/gist_id}","starred_url":"https://api.github.com/users/DoSomething/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DoSomething/subscriptions","organizations_url":"https://api.github.com/users/DoSomething/orgs","repos_url":"https://api.github.com/users/DoSomething/repos","events_url":"https://api.github.com/users/DoSomething/events{/privacy}","received_events_url":"https://api.github.com/users/DoSomething/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DoSomething/dosomething","description":"A Drupal 7 distribution that powers the DoSomething.org web platform.","fork":false,"url":"https://api.github.com/repos/DoSomething/dosomething","forks_url":"https://api.github.com/repos/DoSomething/dosomething/forks","keys_url":"https://api.github.com/repos/DoSomething/dosomething/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DoSomething/dosomething/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DoSomething/dosomething/teams","hooks_url":"https://api.github.com/repos/DoSomething/dosomething/hooks","issue_events_url":"https://api.github.com/repos/DoSomething/dosomething/issues/events{/number}","events_url":"https://api.github.com/repos/DoSomething/dosomething/events","assignees_url":"https://api.github.com/repos/DoSomething/dosomething/assignees{/user}","branches_url":"https://api.github.com/repos/DoSomething/dosomething/branches{/branch}","tags_url":"https://api.github.com/repos/DoSomething/dosomething/tags","blobs_url":"https://api.github.com/repos/DoSomething/dosomething/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DoSomething/dosomething/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DoSomething/dosomething/git/refs{/sha}","trees_url":"https://api.github.com/repos/DoSomething/dosomething/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DoSomething/dosomething/statuses/{sha}","languages_url":"https://api.github.com/repos/DoSomething/dosomething/languages","stargazers_url":"https://api.github.com/repos/DoSomething/dosomething/stargazers","contributors_url":"https://api.github.com/repos/DoSomething/dosomething/contributors","subscribers_url":"https://api.github.com/repos/DoSomething/dosomething/subscribers","subscription_url":"https://api.github.com/repos/DoSomething/dosomething/subscription","commits_url":"https://api.github.com/repos/DoSomething/dosomething/commits{/sha}","git_commits_url":"https://api.github.com/repos/DoSomething/dosomething/git/commits{/sha}","comments_url":"https://api.github.com/repos/DoSomething/dosomething/comments{/number}","issue_comment_url":"https://api.github.com/repos/DoSomething/dosomething/issues/comments{/number}","contents_url":"https://api.github.com/repos/DoSomething/dosomething/contents/{+path}","compare_url":"https://api.github.com/repos/DoSomething/dosomething/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DoSomething/dosomething/merges","archive_url":"https://api.github.com/repos/DoSomething/dosomething/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DoSomething/dosomething/downloads","issues_url":"https://api.github.com/repos/DoSomething/dosomething/issues{/number}","pulls_url":"https://api.github.com/repos/DoSomething/dosomething/pulls{/number}","milestones_url":"https://api.github.com/repos/DoSomething/dosomething/milestones{/number}","notifications_url":"https://api.github.com/repos/DoSomething/dosomething/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DoSomething/dosomething/labels{/name}","releases_url":"https://api.github.com/repos/DoSomething/dosomething/releases{/id}","created_at":"2013-10-15T14:50:48Z","updated_at":"2015-06-15T04:21:42Z","pushed_at":"2015-07-21T19:09:53Z","git_url":"git://github.com/DoSomething/dosomething.git","ssh_url":"git@github.com:DoSomething/dosomething.git","clone_url":"https://github.com/DoSomething/dosomething.git","svn_url":"https://github.com/DoSomething/dosomething","homepage":"http://www.dosomething.org/","size":25262,"stargazers_count":25,"watchers_count":25,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":223,"forks":18,"open_issues":223,"watchers":25,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710"},"html":{"href":"https://github.com/DoSomething/dosomething/pull/4710"},"issue":{"href":"https://api.github.com/repos/DoSomething/dosomething/issues/4710"},"comments":{"href":"https://api.github.com/repos/DoSomething/dosomething/issues/4710/comments"},"review_comments":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710/comments"},"review_comment":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DoSomething/dosomething/pulls/4710/commits"},"statuses":{"href":"https://api.github.com/repos/DoSomething/dosomething/statuses/9085ead177587037cfa483ee718d88cb8ca75255"}}}}