{"action":"opened","number":8,"pull_request":{"url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/8","id":45235130,"html_url":"https://github.com/99designs/http-signatures-php/pull/8","diff_url":"https://github.com/99designs/http-signatures-php/pull/8.diff","patch_url":"https://github.com/99designs/http-signatures-php/pull/8.patch","issue_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/8","number":8,"state":"open","locked":false,"title":"FAILING TEST: SigningStringTest query string ordering.","user":{"login":"pda","id":15759,"avatar_url":"https://avatars.githubusercontent.com/u/15759?v=3","gravatar_id":"","url":"https://api.github.com/users/pda","html_url":"https://github.com/pda","followers_url":"https://api.github.com/users/pda/followers","following_url":"https://api.github.com/users/pda/following{/other_user}","gists_url":"https://api.github.com/users/pda/gists{/gist_id}","starred_url":"https://api.github.com/users/pda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pda/subscriptions","organizations_url":"https://api.github.com/users/pda/orgs","repos_url":"https://api.github.com/users/pda/repos","events_url":"https://api.github.com/users/pda/events{/privacy}","received_events_url":"https://api.github.com/users/pda/received_events","type":"User","site_admin":false},"body":"Turns out `Symfony\\Component\\HttpFoundation\\Request` `getQueryString()` isn't suitable for generating/verifying signing strings:\r\n\r\n> Generates the normalized query string for the Request.\r\n> It builds a normalized query string, where keys/value pairs are alphabetized and have consistent escaping.\r\n— http://api.symfony.com/2.0/Symfony/Component/HttpFoundation/Request.html#method_getQueryString\r\n\r\nI'm told by @dhotson that `$request->server->get('QUERY_STRING')` is probably what I want.\r\n\r\n- [x] Demonstrate bug with failing test.\r\n- [ ] Fix implementation.\r\n- [ ] Squash commits\r\n- [ ] :ship:","created_at":"2015-09-16T23:07:21Z","updated_at":"2015-09-16T23:07:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/8/commits","review_comments_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/8/comments","review_comment_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls/comments{/number}","comments_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/8/comments","statuses_url":"https://api.github.com/repos/99designs/http-signatures-php/statuses/a4c7eaaee76ad4d1aa88c331d2d3efbe4e9478e5","head":{"label":"99designs:query-string-ordering","ref":"query-string-ordering","sha":"a4c7eaaee76ad4d1aa88c331d2d3efbe4e9478e5","user":{"login":"99designs","id":17182,"avatar_url":"https://avatars.githubusercontent.com/u/17182?v=3","gravatar_id":"","url":"https://api.github.com/users/99designs","html_url":"https://github.com/99designs","followers_url":"https://api.github.com/users/99designs/followers","following_url":"https://api.github.com/users/99designs/following{/other_user}","gists_url":"https://api.github.com/users/99designs/gists{/gist_id}","starred_url":"https://api.github.com/users/99designs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/99designs/subscriptions","organizations_url":"https://api.github.com/users/99designs/orgs","repos_url":"https://api.github.com/users/99designs/repos","events_url":"https://api.github.com/users/99designs/events{/privacy}","received_events_url":"https://api.github.com/users/99designs/received_events","type":"Organization","site_admin":false},"repo":{"id":22449072,"name":"http-signatures-php","full_name":"99designs/http-signatures-php","owner":{"login":"99designs","id":17182,"avatar_url":"https://avatars.githubusercontent.com/u/17182?v=3","gravatar_id":"","url":"https://api.github.com/users/99designs","html_url":"https://github.com/99designs","followers_url":"https://api.github.com/users/99designs/followers","following_url":"https://api.github.com/users/99designs/following{/other_user}","gists_url":"https://api.github.com/users/99designs/gists{/gist_id}","starred_url":"https://api.github.com/users/99designs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/99designs/subscriptions","organizations_url":"https://api.github.com/users/99designs/orgs","repos_url":"https://api.github.com/users/99designs/repos","events_url":"https://api.github.com/users/99designs/events{/privacy}","received_events_url":"https://api.github.com/users/99designs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/99designs/http-signatures-php","description":"Sign and verify HTTP messages in PHP.","fork":false,"url":"https://api.github.com/repos/99designs/http-signatures-php","forks_url":"https://api.github.com/repos/99designs/http-signatures-php/forks","keys_url":"https://api.github.com/repos/99designs/http-signatures-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/99designs/http-signatures-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/99designs/http-signatures-php/teams","hooks_url":"https://api.github.com/repos/99designs/http-signatures-php/hooks","issue_events_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/events{/number}","events_url":"https://api.github.com/repos/99designs/http-signatures-php/events","assignees_url":"https://api.github.com/repos/99designs/http-signatures-php/assignees{/user}","branches_url":"https://api.github.com/repos/99designs/http-signatures-php/branches{/branch}","tags_url":"https://api.github.com/repos/99designs/http-signatures-php/tags","blobs_url":"https://api.github.com/repos/99designs/http-signatures-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/99designs/http-signatures-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/99designs/http-signatures-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/99designs/http-signatures-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/99designs/http-signatures-php/statuses/{sha}","languages_url":"https://api.github.com/repos/99designs/http-signatures-php/languages","stargazers_url":"https://api.github.com/repos/99designs/http-signatures-php/stargazers","contributors_url":"https://api.github.com/repos/99designs/http-signatures-php/contributors","subscribers_url":"https://api.github.com/repos/99designs/http-signatures-php/subscribers","subscription_url":"https://api.github.com/repos/99designs/http-signatures-php/subscription","commits_url":"https://api.github.com/repos/99designs/http-signatures-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/99designs/http-signatures-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/99designs/http-signatures-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/99designs/http-signatures-php/contents/{+path}","compare_url":"https://api.github.com/repos/99designs/http-signatures-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/99designs/http-signatures-php/merges","archive_url":"https://api.github.com/repos/99designs/http-signatures-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/99designs/http-signatures-php/downloads","issues_url":"https://api.github.com/repos/99designs/http-signatures-php/issues{/number}","pulls_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls{/number}","milestones_url":"https://api.github.com/repos/99designs/http-signatures-php/milestones{/number}","notifications_url":"https://api.github.com/repos/99designs/http-signatures-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/99designs/http-signatures-php/labels{/name}","releases_url":"https://api.github.com/repos/99designs/http-signatures-php/releases{/id}","created_at":"2014-07-30T23:44:34Z","updated_at":"2015-09-06T11:59:36Z","pushed_at":"2015-09-16T23:04:30Z","git_url":"git://github.com/99designs/http-signatures-php.git","ssh_url":"git@github.com:99designs/http-signatures-php.git","clone_url":"https://github.com/99designs/http-signatures-php.git","svn_url":"https://github.com/99designs/http-signatures-php","homepage":null,"size":244,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"99designs:master","ref":"master","sha":"a3a3ae83613f4fc06ab9d914058d107d272ba62a","user":{"login":"99designs","id":17182,"avatar_url":"https://avatars.githubusercontent.com/u/17182?v=3","gravatar_id":"","url":"https://api.github.com/users/99designs","html_url":"https://github.com/99designs","followers_url":"https://api.github.com/users/99designs/followers","following_url":"https://api.github.com/users/99designs/following{/other_user}","gists_url":"https://api.github.com/users/99designs/gists{/gist_id}","starred_url":"https://api.github.com/users/99designs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/99designs/subscriptions","organizations_url":"https://api.github.com/users/99designs/orgs","repos_url":"https://api.github.com/users/99designs/repos","events_url":"https://api.github.com/users/99designs/events{/privacy}","received_events_url":"https://api.github.com/users/99designs/received_events","type":"Organization","site_admin":false},"repo":{"id":22449072,"name":"http-signatures-php","full_name":"99designs/http-signatures-php","owner":{"login":"99designs","id":17182,"avatar_url":"https://avatars.githubusercontent.com/u/17182?v=3","gravatar_id":"","url":"https://api.github.com/users/99designs","html_url":"https://github.com/99designs","followers_url":"https://api.github.com/users/99designs/followers","following_url":"https://api.github.com/users/99designs/following{/other_user}","gists_url":"https://api.github.com/users/99designs/gists{/gist_id}","starred_url":"https://api.github.com/users/99designs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/99designs/subscriptions","organizations_url":"https://api.github.com/users/99designs/orgs","repos_url":"https://api.github.com/users/99designs/repos","events_url":"https://api.github.com/users/99designs/events{/privacy}","received_events_url":"https://api.github.com/users/99designs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/99designs/http-signatures-php","description":"Sign and verify HTTP messages in PHP.","fork":false,"url":"https://api.github.com/repos/99designs/http-signatures-php","forks_url":"https://api.github.com/repos/99designs/http-signatures-php/forks","keys_url":"https://api.github.com/repos/99designs/http-signatures-php/keys{/key_id}","collaborators_url":"https://api.github.com/repos/99designs/http-signatures-php/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/99designs/http-signatures-php/teams","hooks_url":"https://api.github.com/repos/99designs/http-signatures-php/hooks","issue_events_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/events{/number}","events_url":"https://api.github.com/repos/99designs/http-signatures-php/events","assignees_url":"https://api.github.com/repos/99designs/http-signatures-php/assignees{/user}","branches_url":"https://api.github.com/repos/99designs/http-signatures-php/branches{/branch}","tags_url":"https://api.github.com/repos/99designs/http-signatures-php/tags","blobs_url":"https://api.github.com/repos/99designs/http-signatures-php/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/99designs/http-signatures-php/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/99designs/http-signatures-php/git/refs{/sha}","trees_url":"https://api.github.com/repos/99designs/http-signatures-php/git/trees{/sha}","statuses_url":"https://api.github.com/repos/99designs/http-signatures-php/statuses/{sha}","languages_url":"https://api.github.com/repos/99designs/http-signatures-php/languages","stargazers_url":"https://api.github.com/repos/99designs/http-signatures-php/stargazers","contributors_url":"https://api.github.com/repos/99designs/http-signatures-php/contributors","subscribers_url":"https://api.github.com/repos/99designs/http-signatures-php/subscribers","subscription_url":"https://api.github.com/repos/99designs/http-signatures-php/subscription","commits_url":"https://api.github.com/repos/99designs/http-signatures-php/commits{/sha}","git_commits_url":"https://api.github.com/repos/99designs/http-signatures-php/git/commits{/sha}","comments_url":"https://api.github.com/repos/99designs/http-signatures-php/comments{/number}","issue_comment_url":"https://api.github.com/repos/99designs/http-signatures-php/issues/comments{/number}","contents_url":"https://api.github.com/repos/99designs/http-signatures-php/contents/{+path}","compare_url":"https://api.github.com/repos/99designs/http-signatures-php/compare/{base}...{head}","merges_url":"https://api.github.com/repos/99designs/http-signatures-php/merges","archive_url":"https://api.github.com/repos/99designs/http-signatures-php/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/99designs/http-signatures-php/downloads","issues_url":"https://api.github.com/repos/99designs/http-signatures-php/issues{/number}","pulls_url":"https://api.github.com/repos/99designs/http-signatures-php/pulls{/number}","milestones_url":"https://api.github.com/repos/99designs/http-signatures-php/milestones{/number}","notifications_url":"https://api.github.com/repos/99designs/http-signatures-php/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/99designs/http-signatures-php/labels{/name}","releases_url":"https://api.github.com/repos/99designs/http-signatures-php/releases{/id}","created_at":"2014-07-30T23:44:34Z","updated_at":"2015-09-06T11:59:36Z","pushed_at":"2015-09-16T23:04:30Z","git_url":"git://github.com/99designs/http-signatures-php.git","ssh_url":"git@github.com:99designs/http-signatures-php.git","clone_url":"https://github.com/99designs/http-signatures-php.git","svn_url":"https://github.com/99designs/http-signatures-php","homepage":null,"size":244,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":2,"forks":6,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/8"},"html":{"href":"https://github.com/99designs/http-signatures-php/pull/8"},"issue":{"href":"https://api.github.com/repos/99designs/http-signatures-php/issues/8"},"comments":{"href":"https://api.github.com/repos/99designs/http-signatures-php/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/99designs/http-signatures-php/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/99designs/http-signatures-php/statuses/a4c7eaaee76ad4d1aa88c331d2d3efbe4e9478e5"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":2,"changed_files":1}}