{"action":"closed","number":25301,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/25301","id":35116933,"html_url":"https://github.com/rust-lang/rust/pull/25301","diff_url":"https://github.com/rust-lang/rust/pull/25301.diff","patch_url":"https://github.com/rust-lang/rust/pull/25301.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/25301","number":25301,"state":"closed","locked":false,"title":"Minor optimization for `VecMap::split_off`","user":{"login":"jooert","id":1774713,"avatar_url":"https://avatars.githubusercontent.com/u/1774713?v=3","gravatar_id":"","url":"https://api.github.com/users/jooert","html_url":"https://github.com/jooert","followers_url":"https://api.github.com/users/jooert/followers","following_url":"https://api.github.com/users/jooert/following{/other_user}","gists_url":"https://api.github.com/users/jooert/gists{/gist_id}","starred_url":"https://api.github.com/users/jooert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooert/subscriptions","organizations_url":"https://api.github.com/users/jooert/orgs","repos_url":"https://api.github.com/users/jooert/repos","events_url":"https://api.github.com/users/jooert/events{/privacy}","received_events_url":"https://api.github.com/users/jooert/received_events","type":"User","site_admin":false},"body":"We don't need to copy any elements if `at` is behind the last element\r\nin the map. The last element is at index `self.v.len() - 1`, so we\r\nshould not copy if `at` is greater **or equals** `self.v.len()`.\r\n\r\nr? @Gankro","created_at":"2015-05-11T11:01:29Z","updated_at":"2015-05-11T18:13:17Z","closed_at":"2015-05-11T18:13:17Z","merged_at":"2015-05-11T18:13:17Z","merge_commit_sha":"f59a0f427aa207eb184e570a106a821168e53dcf","assignee":{"login":"Gankro","id":1136864,"avatar_url":"https://avatars.githubusercontent.com/u/1136864?v=3","gravatar_id":"","url":"https://api.github.com/users/Gankro","html_url":"https://github.com/Gankro","followers_url":"https://api.github.com/users/Gankro/followers","following_url":"https://api.github.com/users/Gankro/following{/other_user}","gists_url":"https://api.github.com/users/Gankro/gists{/gist_id}","starred_url":"https://api.github.com/users/Gankro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gankro/subscriptions","organizations_url":"https://api.github.com/users/Gankro/orgs","repos_url":"https://api.github.com/users/Gankro/repos","events_url":"https://api.github.com/users/Gankro/events{/privacy}","received_events_url":"https://api.github.com/users/Gankro/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/25301/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/25301/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/25301/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/5b0e19794efe6d2d7f225df57505205627103f32","head":{"label":"jooert:vec_map_fix_split_off","ref":"vec_map_fix_split_off","sha":"5b0e19794efe6d2d7f225df57505205627103f32","user":{"login":"jooert","id":1774713,"avatar_url":"https://avatars.githubusercontent.com/u/1774713?v=3","gravatar_id":"","url":"https://api.github.com/users/jooert","html_url":"https://github.com/jooert","followers_url":"https://api.github.com/users/jooert/followers","following_url":"https://api.github.com/users/jooert/following{/other_user}","gists_url":"https://api.github.com/users/jooert/gists{/gist_id}","starred_url":"https://api.github.com/users/jooert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooert/subscriptions","organizations_url":"https://api.github.com/users/jooert/orgs","repos_url":"https://api.github.com/users/jooert/repos","events_url":"https://api.github.com/users/jooert/events{/privacy}","received_events_url":"https://api.github.com/users/jooert/received_events","type":"User","site_admin":false},"repo":{"id":32516150,"name":"rust","full_name":"jooert/rust","owner":{"login":"jooert","id":1774713,"avatar_url":"https://avatars.githubusercontent.com/u/1774713?v=3","gravatar_id":"","url":"https://api.github.com/users/jooert","html_url":"https://github.com/jooert","followers_url":"https://api.github.com/users/jooert/followers","following_url":"https://api.github.com/users/jooert/following{/other_user}","gists_url":"https://api.github.com/users/jooert/gists{/gist_id}","starred_url":"https://api.github.com/users/jooert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jooert/subscriptions","organizations_url":"https://api.github.com/users/jooert/orgs","repos_url":"https://api.github.com/users/jooert/repos","events_url":"https://api.github.com/users/jooert/events{/privacy}","received_events_url":"https://api.github.com/users/jooert/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jooert/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/jooert/rust","forks_url":"https://api.github.com/repos/jooert/rust/forks","keys_url":"https://api.github.com/repos/jooert/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jooert/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jooert/rust/teams","hooks_url":"https://api.github.com/repos/jooert/rust/hooks","issue_events_url":"https://api.github.com/repos/jooert/rust/issues/events{/number}","events_url":"https://api.github.com/repos/jooert/rust/events","assignees_url":"https://api.github.com/repos/jooert/rust/assignees{/user}","branches_url":"https://api.github.com/repos/jooert/rust/branches{/branch}","tags_url":"https://api.github.com/repos/jooert/rust/tags","blobs_url":"https://api.github.com/repos/jooert/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jooert/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jooert/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/jooert/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jooert/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/jooert/rust/languages","stargazers_url":"https://api.github.com/repos/jooert/rust/stargazers","contributors_url":"https://api.github.com/repos/jooert/rust/contributors","subscribers_url":"https://api.github.com/repos/jooert/rust/subscribers","subscription_url":"https://api.github.com/repos/jooert/rust/subscription","commits_url":"https://api.github.com/repos/jooert/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/jooert/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/jooert/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/jooert/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/jooert/rust/contents/{+path}","compare_url":"https://api.github.com/repos/jooert/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jooert/rust/merges","archive_url":"https://api.github.com/repos/jooert/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jooert/rust/downloads","issues_url":"https://api.github.com/repos/jooert/rust/issues{/number}","pulls_url":"https://api.github.com/repos/jooert/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/jooert/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/jooert/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jooert/rust/labels{/name}","releases_url":"https://api.github.com/repos/jooert/rust/releases{/id}","created_at":"2015-03-19T10:55:04Z","updated_at":"2015-05-07T16:10:14Z","pushed_at":"2015-05-11T10:58:25Z","git_url":"git://github.com/jooert/rust.git","ssh_url":"git@github.com:jooert/rust.git","clone_url":"https://github.com/jooert/rust.git","svn_url":"https://github.com/jooert/rust","homepage":"http://www.rust-lang.org","size":286559,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"c44d84da981c14cdaa144aa7b0f1109578ed72c3","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"a safe, concurrent, practical language","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","created_at":"2010-06-16T20:39:03Z","updated_at":"2015-05-11T17:58:42Z","pushed_at":"2015-05-11T18:13:12Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"http://www.rust-lang.org","size":644231,"stargazers_count":10758,"watchers_count":10758,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2100,"mirror_url":null,"open_issues_count":2015,"forks":2100,"open_issues":2015,"watchers":10758,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/25301"},"html":{"href":"https://github.com/rust-lang/rust/pull/25301"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/25301"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/25301/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/25301/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/25301/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/5b0e19794efe6d2d7f225df57505205627103f32"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"avatar_url":"https://avatars.githubusercontent.com/u/3372342?v=3","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}