{"action":"created","comment":{"url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments/29945725","id":29945725,"diff_hunk":"@@ -62,7 +62,8 @@ exports.compile = compile = withPrettyErrors (code, options) ->\n   for fragment in fragments\n     # Update the sourcemap with data from each fragment\n     if options.sourceMap\n-      if fragment.locationData\n+      # Do not include empty, whitespace, or semicolon-only fragments.\n+      if fragment.locationData and not /^[;\\s]*$/.test fragment.code","path":"src/coffee-script.coffee","position":6,"original_position":6,"commit_id":"378a04e48c11aef2514b7b7f1d574e30c17db112","original_commit_id":"378a04e48c11aef2514b7b7f1d574e30c17db112","user":{"login":"michaelficarra","id":218840,"avatar_url":"https://avatars.githubusercontent.com/u/218840?v=3","gravatar_id":"","url":"https://api.github.com/users/michaelficarra","html_url":"https://github.com/michaelficarra","followers_url":"https://api.github.com/users/michaelficarra/followers","following_url":"https://api.github.com/users/michaelficarra/following{/other_user}","gists_url":"https://api.github.com/users/michaelficarra/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelficarra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelficarra/subscriptions","organizations_url":"https://api.github.com/users/michaelficarra/orgs","repos_url":"https://api.github.com/users/michaelficarra/repos","events_url":"https://api.github.com/users/michaelficarra/events{/privacy}","received_events_url":"https://api.github.com/users/michaelficarra/received_events","type":"User","site_admin":false},"body":"That's fine. I didn't know whether we were creating good mappings for any of them, so that's why I asked.","created_at":"2015-05-08T14:52:43Z","updated_at":"2015-05-08T14:52:43Z","html_url":"https://github.com/jashkenas/coffeescript/pull/3966#discussion_r29945725","pull_request_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966","_links":{"self":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments/29945725"},"html":{"href":"https://github.com/jashkenas/coffeescript/pull/3966#discussion_r29945725"},"pull_request":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966"}}},"pull_request":{"url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966","id":34502371,"html_url":"https://github.com/jashkenas/coffeescript/pull/3966","diff_url":"https://github.com/jashkenas/coffeescript/pull/3966.diff","patch_url":"https://github.com/jashkenas/coffeescript/pull/3966.patch","issue_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/3966","number":3966,"state":"open","locked":false,"title":"Fix #3965, sourcemaps for bare programs.","user":{"login":"davidbau","id":3458792,"avatar_url":"https://avatars.githubusercontent.com/u/3458792?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbau","html_url":"https://github.com/davidbau","followers_url":"https://api.github.com/users/davidbau/followers","following_url":"https://api.github.com/users/davidbau/following{/other_user}","gists_url":"https://api.github.com/users/davidbau/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbau/subscriptions","organizations_url":"https://api.github.com/users/davidbau/orgs","repos_url":"https://api.github.com/users/davidbau/repos","events_url":"https://api.github.com/users/davidbau/events{/privacy}","received_events_url":"https://api.github.com/users/davidbau/received_events","type":"User","site_admin":false},"body":"Instead of mapping all generated spaces and semicolons and newlines\r\nto the source position (0,0), we avoid generating sourcemap information\r\nfor generated space-or-semicolon-only fragments.\r\n\r\n(In addition to shortening sourcemaps, this fixes a correctness issue\r\nwhere an empty fragment at the beginning of each line maps from (0,0),\r\nbut in a bare program, that position at the begining of the line\r\nshould map from the actual source line.  When this conflict occurred,\r\n(0,0) would win, resulting in an incorrect sourcemap, where each\r\ntop-level function call mapped to (0,0).)","created_at":"2015-04-30T21:21:12Z","updated_at":"2015-05-08T14:52:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9d3e18eb2e3b08997e2d68c533e2d2ace37f3832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966/commits","review_comments_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966/comments","review_comment_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/3966/comments","statuses_url":"https://api.github.com/repos/jashkenas/coffeescript/statuses/378a04e48c11aef2514b7b7f1d574e30c17db112","head":{"label":"davidbau:simplesourcemaps","ref":"simplesourcemaps","sha":"378a04e48c11aef2514b7b7f1d574e30c17db112","user":{"login":"davidbau","id":3458792,"avatar_url":"https://avatars.githubusercontent.com/u/3458792?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbau","html_url":"https://github.com/davidbau","followers_url":"https://api.github.com/users/davidbau/followers","following_url":"https://api.github.com/users/davidbau/following{/other_user}","gists_url":"https://api.github.com/users/davidbau/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbau/subscriptions","organizations_url":"https://api.github.com/users/davidbau/orgs","repos_url":"https://api.github.com/users/davidbau/repos","events_url":"https://api.github.com/users/davidbau/events{/privacy}","received_events_url":"https://api.github.com/users/davidbau/received_events","type":"User","site_admin":false},"repo":{"id":29782462,"name":"coffee-script","full_name":"davidbau/coffee-script","owner":{"login":"davidbau","id":3458792,"avatar_url":"https://avatars.githubusercontent.com/u/3458792?v=3","gravatar_id":"","url":"https://api.github.com/users/davidbau","html_url":"https://github.com/davidbau","followers_url":"https://api.github.com/users/davidbau/followers","following_url":"https://api.github.com/users/davidbau/following{/other_user}","gists_url":"https://api.github.com/users/davidbau/gists{/gist_id}","starred_url":"https://api.github.com/users/davidbau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidbau/subscriptions","organizations_url":"https://api.github.com/users/davidbau/orgs","repos_url":"https://api.github.com/users/davidbau/repos","events_url":"https://api.github.com/users/davidbau/events{/privacy}","received_events_url":"https://api.github.com/users/davidbau/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidbau/coffee-script","description":"IcedCoffeeScript","fork":true,"url":"https://api.github.com/repos/davidbau/coffee-script","forks_url":"https://api.github.com/repos/davidbau/coffee-script/forks","keys_url":"https://api.github.com/repos/davidbau/coffee-script/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidbau/coffee-script/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidbau/coffee-script/teams","hooks_url":"https://api.github.com/repos/davidbau/coffee-script/hooks","issue_events_url":"https://api.github.com/repos/davidbau/coffee-script/issues/events{/number}","events_url":"https://api.github.com/repos/davidbau/coffee-script/events","assignees_url":"https://api.github.com/repos/davidbau/coffee-script/assignees{/user}","branches_url":"https://api.github.com/repos/davidbau/coffee-script/branches{/branch}","tags_url":"https://api.github.com/repos/davidbau/coffee-script/tags","blobs_url":"https://api.github.com/repos/davidbau/coffee-script/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidbau/coffee-script/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidbau/coffee-script/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidbau/coffee-script/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidbau/coffee-script/statuses/{sha}","languages_url":"https://api.github.com/repos/davidbau/coffee-script/languages","stargazers_url":"https://api.github.com/repos/davidbau/coffee-script/stargazers","contributors_url":"https://api.github.com/repos/davidbau/coffee-script/contributors","subscribers_url":"https://api.github.com/repos/davidbau/coffee-script/subscribers","subscription_url":"https://api.github.com/repos/davidbau/coffee-script/subscription","commits_url":"https://api.github.com/repos/davidbau/coffee-script/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidbau/coffee-script/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidbau/coffee-script/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidbau/coffee-script/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidbau/coffee-script/contents/{+path}","compare_url":"https://api.github.com/repos/davidbau/coffee-script/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidbau/coffee-script/merges","archive_url":"https://api.github.com/repos/davidbau/coffee-script/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidbau/coffee-script/downloads","issues_url":"https://api.github.com/repos/davidbau/coffee-script/issues{/number}","pulls_url":"https://api.github.com/repos/davidbau/coffee-script/pulls{/number}","milestones_url":"https://api.github.com/repos/davidbau/coffee-script/milestones{/number}","notifications_url":"https://api.github.com/repos/davidbau/coffee-script/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidbau/coffee-script/labels{/name}","releases_url":"https://api.github.com/repos/davidbau/coffee-script/releases{/id}","created_at":"2015-01-24T16:16:35Z","updated_at":"2015-04-06T21:45:47Z","pushed_at":"2015-05-08T12:43:56Z","git_url":"git://github.com/davidbau/coffee-script.git","ssh_url":"git@github.com:davidbau/coffee-script.git","clone_url":"https://github.com/davidbau/coffee-script.git","svn_url":"https://github.com/davidbau/coffee-script","homepage":"http://maxtaco.github.com/coffee-script","size":21211,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"asyncassign"}},"base":{"label":"jashkenas:master","ref":"master","sha":"1e62781759e8497853072d9c17c25a9d4a4c42da","user":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"repo":{"id":441269,"name":"coffeescript","full_name":"jashkenas/coffeescript","owner":{"login":"jashkenas","id":4732,"avatar_url":"https://avatars.githubusercontent.com/u/4732?v=3","gravatar_id":"","url":"https://api.github.com/users/jashkenas","html_url":"https://github.com/jashkenas","followers_url":"https://api.github.com/users/jashkenas/followers","following_url":"https://api.github.com/users/jashkenas/following{/other_user}","gists_url":"https://api.github.com/users/jashkenas/gists{/gist_id}","starred_url":"https://api.github.com/users/jashkenas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jashkenas/subscriptions","organizations_url":"https://api.github.com/users/jashkenas/orgs","repos_url":"https://api.github.com/users/jashkenas/repos","events_url":"https://api.github.com/users/jashkenas/events{/privacy}","received_events_url":"https://api.github.com/users/jashkenas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jashkenas/coffeescript","description":"Unfancy JavaScript","fork":false,"url":"https://api.github.com/repos/jashkenas/coffeescript","forks_url":"https://api.github.com/repos/jashkenas/coffeescript/forks","keys_url":"https://api.github.com/repos/jashkenas/coffeescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jashkenas/coffeescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jashkenas/coffeescript/teams","hooks_url":"https://api.github.com/repos/jashkenas/coffeescript/hooks","issue_events_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/events{/number}","events_url":"https://api.github.com/repos/jashkenas/coffeescript/events","assignees_url":"https://api.github.com/repos/jashkenas/coffeescript/assignees{/user}","branches_url":"https://api.github.com/repos/jashkenas/coffeescript/branches{/branch}","tags_url":"https://api.github.com/repos/jashkenas/coffeescript/tags","blobs_url":"https://api.github.com/repos/jashkenas/coffeescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jashkenas/coffeescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jashkenas/coffeescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/jashkenas/coffeescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jashkenas/coffeescript/statuses/{sha}","languages_url":"https://api.github.com/repos/jashkenas/coffeescript/languages","stargazers_url":"https://api.github.com/repos/jashkenas/coffeescript/stargazers","contributors_url":"https://api.github.com/repos/jashkenas/coffeescript/contributors","subscribers_url":"https://api.github.com/repos/jashkenas/coffeescript/subscribers","subscription_url":"https://api.github.com/repos/jashkenas/coffeescript/subscription","commits_url":"https://api.github.com/repos/jashkenas/coffeescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/jashkenas/coffeescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/jashkenas/coffeescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/jashkenas/coffeescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/jashkenas/coffeescript/contents/{+path}","compare_url":"https://api.github.com/repos/jashkenas/coffeescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jashkenas/coffeescript/merges","archive_url":"https://api.github.com/repos/jashkenas/coffeescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jashkenas/coffeescript/downloads","issues_url":"https://api.github.com/repos/jashkenas/coffeescript/issues{/number}","pulls_url":"https://api.github.com/repos/jashkenas/coffeescript/pulls{/number}","milestones_url":"https://api.github.com/repos/jashkenas/coffeescript/milestones{/number}","notifications_url":"https://api.github.com/repos/jashkenas/coffeescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jashkenas/coffeescript/labels{/name}","releases_url":"https://api.github.com/repos/jashkenas/coffeescript/releases{/id}","created_at":"2009-12-18T01:39:53Z","updated_at":"2015-05-08T13:40:42Z","pushed_at":"2015-05-02T16:06:51Z","git_url":"git://github.com/jashkenas/coffeescript.git","ssh_url":"git@github.com:jashkenas/coffeescript.git","clone_url":"https://github.com/jashkenas/coffeescript.git","svn_url":"https://github.com/jashkenas/coffeescript","homepage":"http://coffeescript.org/","size":24517,"stargazers_count":11196,"watchers_count":11196,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1510,"mirror_url":null,"open_issues_count":281,"forks":1510,"open_issues":281,"watchers":11196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966"},"html":{"href":"https://github.com/jashkenas/coffeescript/pull/3966"},"issue":{"href":"https://api.github.com/repos/jashkenas/coffeescript/issues/3966"},"comments":{"href":"https://api.github.com/repos/jashkenas/coffeescript/issues/3966/comments"},"review_comments":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966/comments"},"review_comment":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jashkenas/coffeescript/pulls/3966/commits"},"statuses":{"href":"https://api.github.com/repos/jashkenas/coffeescript/statuses/378a04e48c11aef2514b7b7f1d574e30c17db112"}}}}