{"action":"created","issue":{"url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1161","labels_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1161/labels{/name}","comments_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1161/comments","events_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1161/events","html_url":"https://github.com/matethurzo/liferay-portal/pull/1161","id":105326762,"number":1161,"title":"[TECHNICAL-SUPPORT] LPS-58450 Staging - Friendly URL translations are not deleted from Live","user":{"login":"moltam89","id":1397179,"avatar_url":"https://avatars.githubusercontent.com/u/1397179?v=3","gravatar_id":"","url":"https://api.github.com/users/moltam89","html_url":"https://github.com/moltam89","followers_url":"https://api.github.com/users/moltam89/followers","following_url":"https://api.github.com/users/moltam89/following{/other_user}","gists_url":"https://api.github.com/users/moltam89/gists{/gist_id}","starred_url":"https://api.github.com/users/moltam89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moltam89/subscriptions","organizations_url":"https://api.github.com/users/moltam89/orgs","repos_url":"https://api.github.com/users/moltam89/repos","events_url":"https://api.github.com/users/moltam89/events{/privacy}","received_events_url":"https://api.github.com/users/moltam89/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-08T08:24:09Z","updated_at":"2015-09-08T09:14:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/matethurzo/liferay-portal/pulls/1161","html_url":"https://github.com/matethurzo/liferay-portal/pull/1161","diff_url":"https://github.com/matethurzo/liferay-portal/pull/1161.diff","patch_url":"https://github.com/matethurzo/liferay-portal/pull/1161.patch"},"body":"Hi Máté,\r\n\r\nthis fix is about to delete those friendlyURLs which don't exist anymore on the source system.\r\n\r\nI took the idea from **LayoutImportController -> deleteMissingLayouts** method.\r\n\r\nHowever, I don't consider the UUIDs, as according to **LayoutFriendlyURLStagedModelDataHandler -> fetchExistingLayoutFriendlyURL** it's possible that the UUIDs don't match.\r\nFurthermore, I couldn't imagine a use case when the **getNewPrimaryKeysMap** doesn't contain the correct values.\r\n\r\nCould you please review my changes?\r\n\r\nThanks,\r\nTamás"},"comment":{"url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/comments/138491131","html_url":"https://github.com/matethurzo/liferay-portal/pull/1161#issuecomment-138491131","issue_url":"https://api.github.com/repos/matethurzo/liferay-portal/issues/1161","id":138491131,"user":{"login":"liferay-continuous-integration","id":4502793,"avatar_url":"https://avatars.githubusercontent.com/u/4502793?v=3","gravatar_id":"","url":"https://api.github.com/users/liferay-continuous-integration","html_url":"https://github.com/liferay-continuous-integration","followers_url":"https://api.github.com/users/liferay-continuous-integration/followers","following_url":"https://api.github.com/users/liferay-continuous-integration/following{/other_user}","gists_url":"https://api.github.com/users/liferay-continuous-integration/gists{/gist_id}","starred_url":"https://api.github.com/users/liferay-continuous-integration/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liferay-continuous-integration/subscriptions","organizations_url":"https://api.github.com/users/liferay-continuous-integration/orgs","repos_url":"https://api.github.com/users/liferay-continuous-integration/repos","events_url":"https://api.github.com/users/liferay-continuous-integration/events{/privacy}","received_events_url":"https://api.github.com/users/liferay-continuous-integration/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T09:14:38Z","updated_at":"2015-09-08T09:14:38Z","body":"<h1>All tests PASSED!</h1><p>Build Time: 49 minutes 51 seconds</p><h4>Job Results:</h4><p>18 Jobs Passed.<br />0 Jobs Failed.</p><h1>See the following links for more information.</h1><ul><li><h4><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest(master)/1260/\">test-portal-acceptance-pullrequest(master)</a></h4></li><li><h4><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8693/\">test-portal-acceptance-pullrequest-batch(master)/functional-tomcat-mysql/portal-smoke</a></h4></li><li><h4><a href=\"https://test-1-3.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8742/\">test-portal-acceptance-pullrequest-batch(master)/integration-db2</a></h4></li><li><h4><a href=\"https://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8616/\">test-portal-acceptance-pullrequest-batch(master)/integration-mysql</a></h4></li><li><h4><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8748/\">test-portal-acceptance-pullrequest-batch(master)/integration-oracle</a></h4></li><li><h4><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8665/\">test-portal-acceptance-pullrequest-batch(master)/integration-postgresql</a></h4></li><li><h4><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8662/\">test-portal-acceptance-pullrequest-batch(master)/integration-sybase</a></h4></li><li><h4><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8682/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-db2</a></h4></li><li><h4><a href=\"https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8752/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-mysql</a></h4></li><li><h4><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8694/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-oracle</a></h4></li><li><h4><a href=\"https://test-1-3.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8743/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-postgresql</a></h4></li><li><h4><a href=\"https://test-1-5.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8617/\">test-portal-acceptance-pullrequest-batch(master)/modules-integration-sybase</a></h4></li><li><h4><a href=\"https://test-1-7.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8749/\">test-portal-acceptance-pullrequest-batch(master)/modules-unit</a></h4></li><li><h4><a href=\"https://test-1-8.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8666/\">test-portal-acceptance-pullrequest-batch(master)/plugins</a></h4></li><li><h4><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8663/\">test-portal-acceptance-pullrequest-batch(master)/portal-web</a></h4></li><li><h4><a href=\"https://test-1-2.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8683/\">test-portal-acceptance-pullrequest-batch(master)/service-builder</a></h4></li><li><h4><a href=\"https://test-1-4.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8753/\">test-portal-acceptance-pullrequest-batch(master)/tck</a></h4></li><li><h4><a href=\"https://test-1-6.liferay.com/job/test-portal-acceptance-pullrequest-batch(master)/8695/\">test-portal-acceptance-pullrequest-batch(master)/unit</a></h4></li><li><h4><a href=\"https://test-1-1.liferay.com/job/test-portal-acceptance-pullrequest-source(master)/1275/\">test-portal-acceptance-pullrequest-source(master)</a></h4></li></ul>"}}