{"action":"closed","number":395,"pull_request":{"url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/395","id":53005425,"html_url":"https://github.com/LimeSurvey/LimeSurvey/pull/395","diff_url":"https://github.com/LimeSurvey/LimeSurvey/pull/395.diff","patch_url":"https://github.com/LimeSurvey/LimeSurvey/pull/395.patch","issue_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/395","number":395,"state":"closed","locked":false,"title":"[Fixed issue] reuse the master field map in case of activating a survey","user":{"login":"sieutruc","id":486471,"avatar_url":"https://avatars.githubusercontent.com/u/486471?v=3","gravatar_id":"","url":"https://api.github.com/users/sieutruc","html_url":"https://github.com/sieutruc","followers_url":"https://api.github.com/users/sieutruc/followers","following_url":"https://api.github.com/users/sieutruc/following{/other_user}","gists_url":"https://api.github.com/users/sieutruc/gists{/gist_id}","starred_url":"https://api.github.com/users/sieutruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sieutruc/subscriptions","organizations_url":"https://api.github.com/users/sieutruc/orgs","repos_url":"https://api.github.com/users/sieutruc/repos","events_url":"https://api.github.com/users/sieutruc/events{/privacy}","received_events_url":"https://api.github.com/users/sieutruc/received_events","type":"User","site_admin":false},"body":"BUG: \r\n - Create a new survey with the \"Save IP address\" value to \"No\", create 5 tokens, do one or two  survey.\r\n - Deactivate that survey and reactive it with the \"Save IP address\" value to \"Yes\", restore the initial token table, and do one survey from that table. \r\n-----> Error: surveydynamic.ipaddr does not exist.\r\nCheck the table of that survey in the database, \" describe lime_survey_[surveynumber]\", this table does not have the field  \"ipaddr\".\r\n\r\nReason: \r\n\r\n - Limesurvey reuses the master field map when activating the survey,  if master field map does not contain ipaddr , the created lime_survey_[surveynumber] table will not contain that field. \r\n\r\n- It is mentioned in the end of the function  createFieldMap of common_helper.php\r\n\r\n`// If the fieldmap was randomized, the master will contain the proper order.  Copy that fieldmap with the new language settings`\r\n           ` if (isset(Yii::app()->session['survey_'.$surveyid]['fieldmap-' . $surveyid . '-randMaster']))`\r\n\r\nPatch: \r\n\r\n * unset that session above everytime we activate a survey.\r\n\r\nI have also noticed that the argument \"$force_refresh\" seems not be used in that function ???\r\n\r\nMaybe you forget to use it to unset some session variable ? like the one that i did.\r\n\r\n\r\n","created_at":"2015-12-08T16:43:14Z","updated_at":"2015-12-17T13:24:54Z","closed_at":"2015-12-17T13:24:53Z","merged_at":"2015-12-17T13:24:53Z","merge_commit_sha":"73737d4da9918437050b5fccd0b0771d3f6f4d63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/395/commits","review_comments_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/395/comments","review_comment_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/395/comments","statuses_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/statuses/323bcba81f6bc7fcb663c996f4bad6528235417f","head":{"label":"sieutruc:wrongFieldMap","ref":"wrongFieldMap","sha":"323bcba81f6bc7fcb663c996f4bad6528235417f","user":{"login":"sieutruc","id":486471,"avatar_url":"https://avatars.githubusercontent.com/u/486471?v=3","gravatar_id":"","url":"https://api.github.com/users/sieutruc","html_url":"https://github.com/sieutruc","followers_url":"https://api.github.com/users/sieutruc/followers","following_url":"https://api.github.com/users/sieutruc/following{/other_user}","gists_url":"https://api.github.com/users/sieutruc/gists{/gist_id}","starred_url":"https://api.github.com/users/sieutruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sieutruc/subscriptions","organizations_url":"https://api.github.com/users/sieutruc/orgs","repos_url":"https://api.github.com/users/sieutruc/repos","events_url":"https://api.github.com/users/sieutruc/events{/privacy}","received_events_url":"https://api.github.com/users/sieutruc/received_events","type":"User","site_admin":false},"repo":{"id":34740803,"name":"LimeSurvey","full_name":"sieutruc/LimeSurvey","owner":{"login":"sieutruc","id":486471,"avatar_url":"https://avatars.githubusercontent.com/u/486471?v=3","gravatar_id":"","url":"https://api.github.com/users/sieutruc","html_url":"https://github.com/sieutruc","followers_url":"https://api.github.com/users/sieutruc/followers","following_url":"https://api.github.com/users/sieutruc/following{/other_user}","gists_url":"https://api.github.com/users/sieutruc/gists{/gist_id}","starred_url":"https://api.github.com/users/sieutruc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sieutruc/subscriptions","organizations_url":"https://api.github.com/users/sieutruc/orgs","repos_url":"https://api.github.com/users/sieutruc/repos","events_url":"https://api.github.com/users/sieutruc/events{/privacy}","received_events_url":"https://api.github.com/users/sieutruc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sieutruc/LimeSurvey","description":"The official LimeSurvey repository","fork":true,"url":"https://api.github.com/repos/sieutruc/LimeSurvey","forks_url":"https://api.github.com/repos/sieutruc/LimeSurvey/forks","keys_url":"https://api.github.com/repos/sieutruc/LimeSurvey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sieutruc/LimeSurvey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sieutruc/LimeSurvey/teams","hooks_url":"https://api.github.com/repos/sieutruc/LimeSurvey/hooks","issue_events_url":"https://api.github.com/repos/sieutruc/LimeSurvey/issues/events{/number}","events_url":"https://api.github.com/repos/sieutruc/LimeSurvey/events","assignees_url":"https://api.github.com/repos/sieutruc/LimeSurvey/assignees{/user}","branches_url":"https://api.github.com/repos/sieutruc/LimeSurvey/branches{/branch}","tags_url":"https://api.github.com/repos/sieutruc/LimeSurvey/tags","blobs_url":"https://api.github.com/repos/sieutruc/LimeSurvey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sieutruc/LimeSurvey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sieutruc/LimeSurvey/git/refs{/sha}","trees_url":"https://api.github.com/repos/sieutruc/LimeSurvey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sieutruc/LimeSurvey/statuses/{sha}","languages_url":"https://api.github.com/repos/sieutruc/LimeSurvey/languages","stargazers_url":"https://api.github.com/repos/sieutruc/LimeSurvey/stargazers","contributors_url":"https://api.github.com/repos/sieutruc/LimeSurvey/contributors","subscribers_url":"https://api.github.com/repos/sieutruc/LimeSurvey/subscribers","subscription_url":"https://api.github.com/repos/sieutruc/LimeSurvey/subscription","commits_url":"https://api.github.com/repos/sieutruc/LimeSurvey/commits{/sha}","git_commits_url":"https://api.github.com/repos/sieutruc/LimeSurvey/git/commits{/sha}","comments_url":"https://api.github.com/repos/sieutruc/LimeSurvey/comments{/number}","issue_comment_url":"https://api.github.com/repos/sieutruc/LimeSurvey/issues/comments{/number}","contents_url":"https://api.github.com/repos/sieutruc/LimeSurvey/contents/{+path}","compare_url":"https://api.github.com/repos/sieutruc/LimeSurvey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sieutruc/LimeSurvey/merges","archive_url":"https://api.github.com/repos/sieutruc/LimeSurvey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sieutruc/LimeSurvey/downloads","issues_url":"https://api.github.com/repos/sieutruc/LimeSurvey/issues{/number}","pulls_url":"https://api.github.com/repos/sieutruc/LimeSurvey/pulls{/number}","milestones_url":"https://api.github.com/repos/sieutruc/LimeSurvey/milestones{/number}","notifications_url":"https://api.github.com/repos/sieutruc/LimeSurvey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sieutruc/LimeSurvey/labels{/name}","releases_url":"https://api.github.com/repos/sieutruc/LimeSurvey/releases{/id}","created_at":"2015-04-28T16:01:41Z","updated_at":"2015-04-28T16:01:51Z","pushed_at":"2015-12-10T16:02:50Z","git_url":"git://github.com/sieutruc/LimeSurvey.git","ssh_url":"git@github.com:sieutruc/LimeSurvey.git","clone_url":"https://github.com/sieutruc/LimeSurvey.git","svn_url":"https://github.com/sieutruc/LimeSurvey","homepage":"http://www.limesurvey.org","size":371349,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LimeSurvey:master","ref":"master","sha":"1e6538287ea0ecc6fdf1d313167239ad32a256b0","user":{"login":"LimeSurvey","id":1364105,"avatar_url":"https://avatars.githubusercontent.com/u/1364105?v=3","gravatar_id":"","url":"https://api.github.com/users/LimeSurvey","html_url":"https://github.com/LimeSurvey","followers_url":"https://api.github.com/users/LimeSurvey/followers","following_url":"https://api.github.com/users/LimeSurvey/following{/other_user}","gists_url":"https://api.github.com/users/LimeSurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/LimeSurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LimeSurvey/subscriptions","organizations_url":"https://api.github.com/users/LimeSurvey/orgs","repos_url":"https://api.github.com/users/LimeSurvey/repos","events_url":"https://api.github.com/users/LimeSurvey/events{/privacy}","received_events_url":"https://api.github.com/users/LimeSurvey/received_events","type":"Organization","site_admin":false},"repo":{"id":3305384,"name":"LimeSurvey","full_name":"LimeSurvey/LimeSurvey","owner":{"login":"LimeSurvey","id":1364105,"avatar_url":"https://avatars.githubusercontent.com/u/1364105?v=3","gravatar_id":"","url":"https://api.github.com/users/LimeSurvey","html_url":"https://github.com/LimeSurvey","followers_url":"https://api.github.com/users/LimeSurvey/followers","following_url":"https://api.github.com/users/LimeSurvey/following{/other_user}","gists_url":"https://api.github.com/users/LimeSurvey/gists{/gist_id}","starred_url":"https://api.github.com/users/LimeSurvey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LimeSurvey/subscriptions","organizations_url":"https://api.github.com/users/LimeSurvey/orgs","repos_url":"https://api.github.com/users/LimeSurvey/repos","events_url":"https://api.github.com/users/LimeSurvey/events{/privacy}","received_events_url":"https://api.github.com/users/LimeSurvey/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LimeSurvey/LimeSurvey","description":"The most popular Free Open Source Software survey tool on the web.","fork":false,"url":"https://api.github.com/repos/LimeSurvey/LimeSurvey","forks_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/forks","keys_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/teams","hooks_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/hooks","issue_events_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/events{/number}","events_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/events","assignees_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/assignees{/user}","branches_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/branches{/branch}","tags_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/tags","blobs_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/git/refs{/sha}","trees_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/statuses/{sha}","languages_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/languages","stargazers_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/stargazers","contributors_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/contributors","subscribers_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/subscribers","subscription_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/subscription","commits_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/commits{/sha}","git_commits_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/git/commits{/sha}","comments_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/comments{/number}","issue_comment_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/comments{/number}","contents_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/contents/{+path}","compare_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/merges","archive_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/downloads","issues_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues{/number}","pulls_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls{/number}","milestones_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/milestones{/number}","notifications_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/labels{/name}","releases_url":"https://api.github.com/repos/LimeSurvey/LimeSurvey/releases{/id}","created_at":"2012-01-30T14:14:53Z","updated_at":"2015-12-17T02:53:34Z","pushed_at":"2015-12-17T13:24:54Z","git_url":"git://github.com/LimeSurvey/LimeSurvey.git","ssh_url":"git@github.com:LimeSurvey/LimeSurvey.git","clone_url":"https://github.com/LimeSurvey/LimeSurvey.git","svn_url":"https://github.com/LimeSurvey/LimeSurvey","homepage":"http://www.limesurvey.org","size":380925,"stargazers_count":321,"watchers_count":321,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":288,"mirror_url":null,"open_issues_count":24,"forks":288,"open_issues":24,"watchers":321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/395"},"html":{"href":"https://github.com/LimeSurvey/LimeSurvey/pull/395"},"issue":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/395"},"comments":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/issues/395/comments"},"review_comments":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/395/comments"},"review_comment":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/pulls/395/commits"},"statuses":{"href":"https://api.github.com/repos/LimeSurvey/LimeSurvey/statuses/323bcba81f6bc7fcb663c996f4bad6528235417f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Shnoulle","id":1439428,"avatar_url":"https://avatars.githubusercontent.com/u/1439428?v=3","gravatar_id":"","url":"https://api.github.com/users/Shnoulle","html_url":"https://github.com/Shnoulle","followers_url":"https://api.github.com/users/Shnoulle/followers","following_url":"https://api.github.com/users/Shnoulle/following{/other_user}","gists_url":"https://api.github.com/users/Shnoulle/gists{/gist_id}","starred_url":"https://api.github.com/users/Shnoulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shnoulle/subscriptions","organizations_url":"https://api.github.com/users/Shnoulle/orgs","repos_url":"https://api.github.com/users/Shnoulle/repos","events_url":"https://api.github.com/users/Shnoulle/events{/privacy}","received_events_url":"https://api.github.com/users/Shnoulle/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"commits":2,"additions":3,"deletions":0,"changed_files":1}}