{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/47427349","id":47427349,"diff_hunk":"@@ -0,0 +1,482 @@\n+// Copyright (c) Microsoft. All rights reserved.","path":"src/System.Data.SqlClient/src/Interop/LocaleMapperApiHelper.cs","position":1,"original_position":1,"commit_id":"94bb94627a623bf656c43edcd2e656c98460f182","original_commit_id":"94bb94627a623bf656c43edcd2e656c98460f182","user":{"login":"saurabh500","id":1623701,"avatar_url":"https://avatars.githubusercontent.com/u/1623701?v=3","gravatar_id":"","url":"https://api.github.com/users/saurabh500","html_url":"https://github.com/saurabh500","followers_url":"https://api.github.com/users/saurabh500/followers","following_url":"https://api.github.com/users/saurabh500/following{/other_user}","gists_url":"https://api.github.com/users/saurabh500/gists{/gist_id}","starred_url":"https://api.github.com/users/saurabh500/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saurabh500/subscriptions","organizations_url":"https://api.github.com/users/saurabh500/orgs","repos_url":"https://api.github.com/users/saurabh500/repos","events_url":"https://api.github.com/users/saurabh500/events{/privacy}","received_events_url":"https://api.github.com/users/saurabh500/received_events","type":"User","site_admin":false},"body":"Can we leave the LocaleInterop.cs as is and use a naming convention like the files at the link below for the new non-windows files you are adding? \r\nhttps://github.com/dotnet/corefx/tree/master/src/System.Runtime.InteropServices.RuntimeInformation/src\r\n","created_at":"2015-12-12T05:07:49Z","updated_at":"2015-12-12T05:07:49Z","html_url":"https://github.com/dotnet/corefx/pull/4958#discussion_r47427349","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/4958","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/47427349"},"html":{"href":"https://github.com/dotnet/corefx/pull/4958#discussion_r47427349"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4958"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/4958","id":53467807,"html_url":"https://github.com/dotnet/corefx/pull/4958","diff_url":"https://github.com/dotnet/corefx/pull/4958.diff","patch_url":"https://github.com/dotnet/corefx/pull/4958.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/4958","number":4958,"state":"open","locked":false,"title":"Replace windows API Locale to mapper for Non Windows build","user":{"login":"kkurni","id":698547,"avatar_url":"https://avatars.githubusercontent.com/u/698547?v=3","gravatar_id":"","url":"https://api.github.com/users/kkurni","html_url":"https://github.com/kkurni","followers_url":"https://api.github.com/users/kkurni/followers","following_url":"https://api.github.com/users/kkurni/following{/other_user}","gists_url":"https://api.github.com/users/kkurni/gists{/gist_id}","starred_url":"https://api.github.com/users/kkurni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkurni/subscriptions","organizations_url":"https://api.github.com/users/kkurni/orgs","repos_url":"https://api.github.com/users/kkurni/repos","events_url":"https://api.github.com/users/kkurni/events{/privacy}","received_events_url":"https://api.github.com/users/kkurni/received_events","type":"User","site_admin":false},"body":"Quick Mapper for Unix to mitigate \r\nhttps://github.com/dotnet/corefx/issues/4579.\r\n\r\nThis mapper will map from LCID to CodePage which served via Windows API.\r\n\r\nIt will be optimized as we go.\r\n","created_at":"2015-12-12T04:02:42Z","updated_at":"2015-12-12T05:07:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9bff15cf309bbf88ef6d385daca8c0487b3a9663","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/4958/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/4958/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/4958/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/94bb94627a623bf656c43edcd2e656c98460f182","head":{"label":"kkurni:unix-locale","ref":"unix-locale","sha":"94bb94627a623bf656c43edcd2e656c98460f182","user":{"login":"kkurni","id":698547,"avatar_url":"https://avatars.githubusercontent.com/u/698547?v=3","gravatar_id":"","url":"https://api.github.com/users/kkurni","html_url":"https://github.com/kkurni","followers_url":"https://api.github.com/users/kkurni/followers","following_url":"https://api.github.com/users/kkurni/following{/other_user}","gists_url":"https://api.github.com/users/kkurni/gists{/gist_id}","starred_url":"https://api.github.com/users/kkurni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkurni/subscriptions","organizations_url":"https://api.github.com/users/kkurni/orgs","repos_url":"https://api.github.com/users/kkurni/repos","events_url":"https://api.github.com/users/kkurni/events{/privacy}","received_events_url":"https://api.github.com/users/kkurni/received_events","type":"User","site_admin":false},"repo":{"id":45491501,"name":"corefx","full_name":"kkurni/corefx","owner":{"login":"kkurni","id":698547,"avatar_url":"https://avatars.githubusercontent.com/u/698547?v=3","gravatar_id":"","url":"https://api.github.com/users/kkurni","html_url":"https://github.com/kkurni","followers_url":"https://api.github.com/users/kkurni/followers","following_url":"https://api.github.com/users/kkurni/following{/other_user}","gists_url":"https://api.github.com/users/kkurni/gists{/gist_id}","starred_url":"https://api.github.com/users/kkurni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkurni/subscriptions","organizations_url":"https://api.github.com/users/kkurni/orgs","repos_url":"https://api.github.com/users/kkurni/repos","events_url":"https://api.github.com/users/kkurni/events{/privacy}","received_events_url":"https://api.github.com/users/kkurni/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kkurni/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/kkurni/corefx","forks_url":"https://api.github.com/repos/kkurni/corefx/forks","keys_url":"https://api.github.com/repos/kkurni/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kkurni/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kkurni/corefx/teams","hooks_url":"https://api.github.com/repos/kkurni/corefx/hooks","issue_events_url":"https://api.github.com/repos/kkurni/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/kkurni/corefx/events","assignees_url":"https://api.github.com/repos/kkurni/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/kkurni/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/kkurni/corefx/tags","blobs_url":"https://api.github.com/repos/kkurni/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kkurni/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kkurni/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kkurni/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kkurni/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/kkurni/corefx/languages","stargazers_url":"https://api.github.com/repos/kkurni/corefx/stargazers","contributors_url":"https://api.github.com/repos/kkurni/corefx/contributors","subscribers_url":"https://api.github.com/repos/kkurni/corefx/subscribers","subscription_url":"https://api.github.com/repos/kkurni/corefx/subscription","commits_url":"https://api.github.com/repos/kkurni/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kkurni/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kkurni/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kkurni/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kkurni/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/kkurni/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kkurni/corefx/merges","archive_url":"https://api.github.com/repos/kkurni/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kkurni/corefx/downloads","issues_url":"https://api.github.com/repos/kkurni/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/kkurni/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/kkurni/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/kkurni/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kkurni/corefx/labels{/name}","releases_url":"https://api.github.com/repos/kkurni/corefx/releases{/id}","created_at":"2015-11-03T19:49:13Z","updated_at":"2015-11-05T07:07:33Z","pushed_at":"2015-12-12T03:59:51Z","git_url":"git://github.com/kkurni/corefx.git","ssh_url":"git@github.com:kkurni/corefx.git","clone_url":"https://github.com/kkurni/corefx.git","svn_url":"https://github.com/kkurni/corefx","homepage":"http://dotnet.github.io/core/","size":41447,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"1395a9dd15416a03904c8bc9ca00ead28f60c84a","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","created_at":"2014-11-06T23:42:48Z","updated_at":"2015-12-12T00:32:41Z","pushed_at":"2015-12-12T04:30:36Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"http://dotnet.github.io/","size":52244,"stargazers_count":8762,"watchers_count":8762,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1983,"mirror_url":null,"open_issues_count":774,"forks":1983,"open_issues":774,"watchers":8762,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4958"},"html":{"href":"https://github.com/dotnet/corefx/pull/4958"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4958"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/4958/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4958/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/4958/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/94bb94627a623bf656c43edcd2e656c98460f182"}}}}