{"action":"created","comment":{"url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/comments/31326307","id":31326307,"diff_hunk":"@@ -28,12 +28,12 @@ INSTALL\n Copy the statsd library from the .m2 folder to cassandra/lib.\n Add the following to your cassandra startup script:\n \n-Copy the agent-1.1.jar to a new directory cassandra/plugins\n+Copy the agent-1.2.jar to a new directory cassandra/plugins\n \n Change cassandra startup to add this agent. This can be done in\n a stock install by adding the following to /etc/default/cassandra:","path":"README.md","position":17,"original_position":17,"commit_id":"da51a14772b2750a2196961c2d206aa9815598f1","original_commit_id":"da51a14772b2750a2196961c2d206aa9815598f1","user":{"login":"rkuris","id":3193068,"avatar_url":"https://avatars.githubusercontent.com/u/3193068?v=3","gravatar_id":"","url":"https://api.github.com/users/rkuris","html_url":"https://github.com/rkuris","followers_url":"https://api.github.com/users/rkuris/followers","following_url":"https://api.github.com/users/rkuris/following{/other_user}","gists_url":"https://api.github.com/users/rkuris/gists{/gist_id}","starred_url":"https://api.github.com/users/rkuris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkuris/subscriptions","organizations_url":"https://api.github.com/users/rkuris/orgs","repos_url":"https://api.github.com/users/rkuris/repos","events_url":"https://api.github.com/users/rkuris/events{/privacy}","received_events_url":"https://api.github.com/users/rkuris/received_events","type":"User","site_admin":false},"body":"Agreed. The reason for putting it somewhere else is that chef manages the cassandra-env.sh file. More specifically, it's the community cookbook that manages that file, so adding that line in there was much more challenging. JMX settings are all controlled by the community cookbook.\r\n\r\nAlso, I phrased the README to say that it \"can be done\" this way but doesn't mean there aren't other ways to do it :)","created_at":"2015-05-29T13:59:22Z","updated_at":"2015-05-29T13:59:22Z","html_url":"https://github.com/lookout/cassandra-statsd-agent/pull/4#discussion_r31326307","pull_request_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/comments/31326307"},"html":{"href":"https://github.com/lookout/cassandra-statsd-agent/pull/4#discussion_r31326307"},"pull_request":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4","id":36462787,"html_url":"https://github.com/lookout/cassandra-statsd-agent/pull/4","diff_url":"https://github.com/lookout/cassandra-statsd-agent/pull/4.diff","patch_url":"https://github.com/lookout/cassandra-statsd-agent/pull/4.patch","issue_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/4","number":4,"state":"open","locked":false,"title":"Fetch some jmx stats","user":{"login":"rkuris","id":3193068,"avatar_url":"https://avatars.githubusercontent.com/u/3193068?v=3","gravatar_id":"","url":"https://api.github.com/users/rkuris","html_url":"https://github.com/rkuris","followers_url":"https://api.github.com/users/rkuris/followers","following_url":"https://api.github.com/users/rkuris/following{/other_user}","gists_url":"https://api.github.com/users/rkuris/gists{/gist_id}","starred_url":"https://api.github.com/users/rkuris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rkuris/subscriptions","organizations_url":"https://api.github.com/users/rkuris/orgs","repos_url":"https://api.github.com/users/rkuris/repos","events_url":"https://api.github.com/users/rkuris/events{/privacy}","received_events_url":"https://api.github.com/users/rkuris/received_events","type":"User","site_admin":false},"body":"@maheshkelkar can you take a look at this before I merge it? In particular, take a look at CassandraJMXGenerator.","created_at":"2015-05-28T23:55:35Z","updated_at":"2015-05-29T13:59:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aa9120ae86e6df9d5a8efcb9e596242b36a4a09","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4/commits","review_comments_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4/comments","review_comment_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/4/comments","statuses_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/statuses/da51a14772b2750a2196961c2d206aa9815598f1","head":{"label":"lookout:fetch-some-jmx-stats","ref":"fetch-some-jmx-stats","sha":"da51a14772b2750a2196961c2d206aa9815598f1","user":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"repo":{"id":28209403,"name":"cassandra-statsd-agent","full_name":"lookout/cassandra-statsd-agent","owner":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lookout/cassandra-statsd-agent","description":"Java Agent for Cassandra integration with StatsD","fork":true,"url":"https://api.github.com/repos/lookout/cassandra-statsd-agent","forks_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/forks","keys_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/teams","hooks_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/hooks","issue_events_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/events","assignees_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/tags","blobs_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/languages","stargazers_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/stargazers","contributors_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/contributors","subscribers_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/subscribers","subscription_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/subscription","commits_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/merges","archive_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/downloads","issues_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/labels{/name}","releases_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/releases{/id}","created_at":"2014-12-19T01:38:08Z","updated_at":"2015-01-05T17:29:59Z","pushed_at":"2015-05-28T23:55:36Z","git_url":"git://github.com/lookout/cassandra-statsd-agent.git","ssh_url":"git@github.com:lookout/cassandra-statsd-agent.git","clone_url":"https://github.com/lookout/cassandra-statsd-agent.git","svn_url":"https://github.com/lookout/cassandra-statsd-agent","homepage":null,"size":207,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"lookout"}},"base":{"label":"lookout:master","ref":"master","sha":"b459a53d049961a2550665c17863b49d68197e45","user":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"repo":{"id":28209403,"name":"cassandra-statsd-agent","full_name":"lookout/cassandra-statsd-agent","owner":{"login":"lookout","id":47237,"avatar_url":"https://avatars.githubusercontent.com/u/47237?v=3","gravatar_id":"","url":"https://api.github.com/users/lookout","html_url":"https://github.com/lookout","followers_url":"https://api.github.com/users/lookout/followers","following_url":"https://api.github.com/users/lookout/following{/other_user}","gists_url":"https://api.github.com/users/lookout/gists{/gist_id}","starred_url":"https://api.github.com/users/lookout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lookout/subscriptions","organizations_url":"https://api.github.com/users/lookout/orgs","repos_url":"https://api.github.com/users/lookout/repos","events_url":"https://api.github.com/users/lookout/events{/privacy}","received_events_url":"https://api.github.com/users/lookout/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lookout/cassandra-statsd-agent","description":"Java Agent for Cassandra integration with StatsD","fork":true,"url":"https://api.github.com/repos/lookout/cassandra-statsd-agent","forks_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/forks","keys_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/teams","hooks_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/hooks","issue_events_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/events{/number}","events_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/events","assignees_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/assignees{/user}","branches_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/branches{/branch}","tags_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/tags","blobs_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/languages","stargazers_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/stargazers","contributors_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/contributors","subscribers_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/subscribers","subscription_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/subscription","commits_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/contents/{+path}","compare_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/merges","archive_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/downloads","issues_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues{/number}","pulls_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/labels{/name}","releases_url":"https://api.github.com/repos/lookout/cassandra-statsd-agent/releases{/id}","created_at":"2014-12-19T01:38:08Z","updated_at":"2015-01-05T17:29:59Z","pushed_at":"2015-05-28T23:55:36Z","git_url":"git://github.com/lookout/cassandra-statsd-agent.git","ssh_url":"git@github.com:lookout/cassandra-statsd-agent.git","clone_url":"https://github.com/lookout/cassandra-statsd-agent.git","svn_url":"https://github.com/lookout/cassandra-statsd-agent","homepage":null,"size":207,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":1,"default_branch":"lookout"}},"_links":{"self":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4"},"html":{"href":"https://github.com/lookout/cassandra-statsd-agent/pull/4"},"issue":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/4"},"comments":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/lookout/cassandra-statsd-agent/statuses/da51a14772b2750a2196961c2d206aa9815598f1"}}}}