{"action":"created","comment":{"url":"https://api.github.com/repos/uber/uncaught-exception/pulls/comments/27512627","id":27512627,"diff_hunk":"@@ -248,13 +329,13 @@ function stringifyError(error, uncaughtType) {\n     var d = new Date();\n \n     return jsonStringify({\n-        message: error.message,\n-        type: error.type,\n+        message: error && error.message,","path":"uncaught.js","position":289,"original_position":289,"commit_id":"3e48eab447fdd3279c3da2511ca499540b5f4022","original_commit_id":"3e48eab447fdd3279c3da2511ca499540b5f4022","user":{"login":"jwolski","id":16902,"avatar_url":"https://avatars.githubusercontent.com/u/16902?v=3","gravatar_id":"","url":"https://api.github.com/users/jwolski","html_url":"https://github.com/jwolski","followers_url":"https://api.github.com/users/jwolski/followers","following_url":"https://api.github.com/users/jwolski/following{/other_user}","gists_url":"https://api.github.com/users/jwolski/gists{/gist_id}","starred_url":"https://api.github.com/users/jwolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwolski/subscriptions","organizations_url":"https://api.github.com/users/jwolski/orgs","repos_url":"https://api.github.com/users/jwolski/repos","events_url":"https://api.github.com/users/jwolski/events{/privacy}","received_events_url":"https://api.github.com/users/jwolski/received_events","type":"User","site_admin":false},"body":"why were these safe guards necessary? it seems that you trust `error` is defined elsewhere in the code.","created_at":"2015-03-31T19:13:11Z","updated_at":"2015-03-31T19:13:11Z","html_url":"https://github.com/uber/uncaught-exception/pull/8#discussion_r27512627","pull_request_url":"https://api.github.com/repos/uber/uncaught-exception/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/uber/uncaught-exception/pulls/comments/27512627"},"html":{"href":"https://github.com/uber/uncaught-exception/pull/8#discussion_r27512627"},"pull_request":{"href":"https://api.github.com/repos/uber/uncaught-exception/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/uber/uncaught-exception/pulls/8","id":32286551,"html_url":"https://github.com/uber/uncaught-exception/pull/8","diff_url":"https://github.com/uber/uncaught-exception/pull/8.diff","patch_url":"https://github.com/uber/uncaught-exception/pull/8.patch","issue_url":"https://api.github.com/repos/uber/uncaught-exception/issues/8","number":8,"state":"open","locked":false,"title":"create a ton of data structures before going down","user":{"login":"Raynos","id":479538,"avatar_url":"https://avatars.githubusercontent.com/u/479538?v=3","gravatar_id":"","url":"https://api.github.com/users/Raynos","html_url":"https://github.com/Raynos","followers_url":"https://api.github.com/users/Raynos/followers","following_url":"https://api.github.com/users/Raynos/following{/other_user}","gists_url":"https://api.github.com/users/Raynos/gists{/gist_id}","starred_url":"https://api.github.com/users/Raynos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Raynos/subscriptions","organizations_url":"https://api.github.com/users/Raynos/orgs","repos_url":"https://api.github.com/users/Raynos/repos","events_url":"https://api.github.com/users/Raynos/events{/privacy}","received_events_url":"https://api.github.com/users/Raynos/received_events","type":"User","site_admin":false},"body":"This augments the `uncaught-exception` library with two powerful\nfeatures for post mortem debugging\n\n - 8 new unique prototypes to search for in a heap snapshot or core dump\n - A new stack frame called `internalTerminate()` which is going to be the\n    top of the stack right before `abort()`. This has a single argument\n    that is all of the state the `uncaught-exception` library is aware of.\n\nThese two features will make post-mortem debugging a lot easier. It means\nyou can scan the heap for data structures related to the uncaught exception.\n\nIt means you can look at the arguments for the first stack frame and see all\nof the data related to the uncaught exception and the processing of the uncaught\nexception.\n\nr: @Matt-Esch @wolski","created_at":"2015-03-31T02:39:34Z","updated_at":"2015-03-31T19:13:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1ba88c1c67bfc7ed836d39af4f3e9ef174cbcd2f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/uncaught-exception/pulls/8/commits","review_comments_url":"https://api.github.com/repos/uber/uncaught-exception/pulls/8/comments","review_comment_url":"https://api.github.com/repos/uber/uncaught-exception/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/uncaught-exception/issues/8/comments","statuses_url":"https://api.github.com/repos/uber/uncaught-exception/statuses/3e48eab447fdd3279c3da2511ca499540b5f4022","head":{"label":"uber:data-structures","ref":"data-structures","sha":"3e48eab447fdd3279c3da2511ca499540b5f4022","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":15322507,"name":"uncaught-exception","full_name":"uber/uncaught-exception","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/uncaught-exception","description":"Handle uncaught exceptions.","fork":false,"url":"https://api.github.com/repos/uber/uncaught-exception","forks_url":"https://api.github.com/repos/uber/uncaught-exception/forks","keys_url":"https://api.github.com/repos/uber/uncaught-exception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/uncaught-exception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/uncaught-exception/teams","hooks_url":"https://api.github.com/repos/uber/uncaught-exception/hooks","issue_events_url":"https://api.github.com/repos/uber/uncaught-exception/issues/events{/number}","events_url":"https://api.github.com/repos/uber/uncaught-exception/events","assignees_url":"https://api.github.com/repos/uber/uncaught-exception/assignees{/user}","branches_url":"https://api.github.com/repos/uber/uncaught-exception/branches{/branch}","tags_url":"https://api.github.com/repos/uber/uncaught-exception/tags","blobs_url":"https://api.github.com/repos/uber/uncaught-exception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/uncaught-exception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/uncaught-exception/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/uncaught-exception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/uncaught-exception/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/uncaught-exception/languages","stargazers_url":"https://api.github.com/repos/uber/uncaught-exception/stargazers","contributors_url":"https://api.github.com/repos/uber/uncaught-exception/contributors","subscribers_url":"https://api.github.com/repos/uber/uncaught-exception/subscribers","subscription_url":"https://api.github.com/repos/uber/uncaught-exception/subscription","commits_url":"https://api.github.com/repos/uber/uncaught-exception/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/uncaught-exception/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/uncaught-exception/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/uncaught-exception/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/uncaught-exception/contents/{+path}","compare_url":"https://api.github.com/repos/uber/uncaught-exception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/uncaught-exception/merges","archive_url":"https://api.github.com/repos/uber/uncaught-exception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/uncaught-exception/downloads","issues_url":"https://api.github.com/repos/uber/uncaught-exception/issues{/number}","pulls_url":"https://api.github.com/repos/uber/uncaught-exception/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/uncaught-exception/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/uncaught-exception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/uncaught-exception/labels{/name}","releases_url":"https://api.github.com/repos/uber/uncaught-exception/releases{/id}","created_at":"2013-12-19T20:53:16Z","updated_at":"2015-02-10T10:46:11Z","pushed_at":"2015-03-31T02:39:34Z","git_url":"git://github.com/uber/uncaught-exception.git","ssh_url":"git@github.com:uber/uncaught-exception.git","clone_url":"https://github.com/uber/uncaught-exception.git","svn_url":"https://github.com/uber/uncaught-exception","homepage":"","size":1503,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":14,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"aea2b66d91f4933db9d48b6728067f80a44a45dd","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":15322507,"name":"uncaught-exception","full_name":"uber/uncaught-exception","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/uncaught-exception","description":"Handle uncaught exceptions.","fork":false,"url":"https://api.github.com/repos/uber/uncaught-exception","forks_url":"https://api.github.com/repos/uber/uncaught-exception/forks","keys_url":"https://api.github.com/repos/uber/uncaught-exception/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/uncaught-exception/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/uncaught-exception/teams","hooks_url":"https://api.github.com/repos/uber/uncaught-exception/hooks","issue_events_url":"https://api.github.com/repos/uber/uncaught-exception/issues/events{/number}","events_url":"https://api.github.com/repos/uber/uncaught-exception/events","assignees_url":"https://api.github.com/repos/uber/uncaught-exception/assignees{/user}","branches_url":"https://api.github.com/repos/uber/uncaught-exception/branches{/branch}","tags_url":"https://api.github.com/repos/uber/uncaught-exception/tags","blobs_url":"https://api.github.com/repos/uber/uncaught-exception/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/uncaught-exception/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/uncaught-exception/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/uncaught-exception/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/uncaught-exception/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/uncaught-exception/languages","stargazers_url":"https://api.github.com/repos/uber/uncaught-exception/stargazers","contributors_url":"https://api.github.com/repos/uber/uncaught-exception/contributors","subscribers_url":"https://api.github.com/repos/uber/uncaught-exception/subscribers","subscription_url":"https://api.github.com/repos/uber/uncaught-exception/subscription","commits_url":"https://api.github.com/repos/uber/uncaught-exception/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/uncaught-exception/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/uncaught-exception/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/uncaught-exception/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/uncaught-exception/contents/{+path}","compare_url":"https://api.github.com/repos/uber/uncaught-exception/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/uncaught-exception/merges","archive_url":"https://api.github.com/repos/uber/uncaught-exception/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/uncaught-exception/downloads","issues_url":"https://api.github.com/repos/uber/uncaught-exception/issues{/number}","pulls_url":"https://api.github.com/repos/uber/uncaught-exception/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/uncaught-exception/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/uncaught-exception/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/uncaught-exception/labels{/name}","releases_url":"https://api.github.com/repos/uber/uncaught-exception/releases{/id}","created_at":"2013-12-19T20:53:16Z","updated_at":"2015-02-10T10:46:11Z","pushed_at":"2015-03-31T02:39:34Z","git_url":"git://github.com/uber/uncaught-exception.git","ssh_url":"git@github.com:uber/uncaught-exception.git","clone_url":"https://github.com/uber/uncaught-exception.git","svn_url":"https://github.com/uber/uncaught-exception","homepage":"","size":1503,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/uncaught-exception/pulls/8"},"html":{"href":"https://github.com/uber/uncaught-exception/pull/8"},"issue":{"href":"https://api.github.com/repos/uber/uncaught-exception/issues/8"},"comments":{"href":"https://api.github.com/repos/uber/uncaught-exception/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/uncaught-exception/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/uncaught-exception/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/uncaught-exception/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/uber/uncaught-exception/statuses/3e48eab447fdd3279c3da2511ca499540b5f4022"}}}}