{"action":"created","issue":{"url":"https://api.github.com/repos/uProxy/uproxy-lib/issues/284","labels_url":"https://api.github.com/repos/uProxy/uproxy-lib/issues/284/labels{/name}","comments_url":"https://api.github.com/repos/uProxy/uproxy-lib/issues/284/comments","events_url":"https://api.github.com/repos/uProxy/uproxy-lib/issues/284/events","html_url":"https://github.com/uProxy/uproxy-lib/pull/284","id":106056649,"number":284,"title":"Added Protean transformer","user":{"login":"blanu","id":35673,"avatar_url":"https://avatars.githubusercontent.com/u/35673?v=3","gravatar_id":"","url":"https://api.github.com/users/blanu","html_url":"https://github.com/blanu","followers_url":"https://api.github.com/users/blanu/followers","following_url":"https://api.github.com/users/blanu/following{/other_user}","gists_url":"https://api.github.com/users/blanu/gists{/gist_id}","starred_url":"https://api.github.com/users/blanu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blanu/subscriptions","organizations_url":"https://api.github.com/users/blanu/orgs","repos_url":"https://api.github.com/users/blanu/repos","events_url":"https://api.github.com/users/blanu/events{/privacy}","received_events_url":"https://api.github.com/users/blanu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-09-11T17:27:07Z","updated_at":"2015-09-11T21:50:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uProxy/uproxy-lib/pulls/284","html_url":"https://github.com/uProxy/uproxy-lib/pull/284","diff_url":"https://github.com/uProxy/uproxy-lib/pull/284.diff","patch_url":"https://github.com/uProxy/uproxy-lib/pull/284.patch"},"body":"This is a transformer that combines the other transformers.\r\nCurrently it just combines the AES encryption and the byte sequence injector.\r\nThis branch also contains a minor fix for ByteSequenceShaper and some formatting fixes.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/uproxy/uproxy-lib/284)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/uProxy/uproxy-lib/issues/comments/139669363","html_url":"https://github.com/uProxy/uproxy-lib/pull/284#issuecomment-139669363","issue_url":"https://api.github.com/repos/uProxy/uproxy-lib/issues/284","id":139669363,"user":{"login":"trevj","id":5142116,"avatar_url":"https://avatars.githubusercontent.com/u/5142116?v=3","gravatar_id":"","url":"https://api.github.com/users/trevj","html_url":"https://github.com/trevj","followers_url":"https://api.github.com/users/trevj/followers","following_url":"https://api.github.com/users/trevj/following{/other_user}","gists_url":"https://api.github.com/users/trevj/gists{/gist_id}","starred_url":"https://api.github.com/users/trevj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trevj/subscriptions","organizations_url":"https://api.github.com/users/trevj/orgs","repos_url":"https://api.github.com/users/trevj/repos","events_url":"https://api.github.com/users/trevj/events{/privacy}","received_events_url":"https://api.github.com/users/trevj/received_events","type":"User","site_admin":false},"created_at":"2015-09-11T21:50:34Z","updated_at":"2015-09-11T21:50:34Z","body":"I love how you've re-used code. Very nice!\n\n:+1:\n\n---\n\nReview status: all files reviewed at latest revision, 4 unresolved discussions, some commit checks failed.\n\n---\n\n<sup>**[src/churn/churn.ts, line 321 \\[r1\\]](https://reviewable.io:443/reviews/uproxy/uproxy-lib/284#-JyxxFiRNnZ71MVCQrgq)** ([raw file](https://github.com/uproxy/uproxy-lib/blob/d860802266526a811edffec74cf8951f0acb64fe/src/churn/churn.ts#L321)):</sup>\nApologies for the confusion! Seems like we're all agreed braces in this context should have their own line :-)\n\n---\n\n<sup>**[src/fancy-transformers/protean.ts, line 23 \\[r3\\]](https://reviewable.io:443/reviews/uproxy/uproxy-lib/284#-JyyNgT1NRfiPj0YGaW9)** ([raw file](https://github.com/uproxy/uproxy-lib/blob/b11d37dd8049cbd56aae5d4964f4557750b0c4ea/src/fancy-transformers/protean.ts#L23)):</sup>\nAnd packet injection!\n\n---\n\n<sup>**[src/fancy-transformers/protean.ts, line 23 \\[r3\\]](https://reviewable.io:443/reviews/uproxy/uproxy-lib/284#-JyyNhe4CMzsbGyX5zLY)** ([raw file](https://github.com/uproxy/uproxy-lib/blob/b11d37dd8049cbd56aae5d4964f4557750b0c4ea/src/fancy-transformers/protean.ts#L23)):</sup>\nDo you plan to add packet length stuff here, too?\n\n---\n\n\nComments from the [review on Reviewable.io](https://reviewable.io:443/reviews/uproxy/uproxy-lib/284)\n<!-- Sent from Reviewable.io -->\n"}}