{"action":"created","comment":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/40822673","id":40822673,"diff_hunk":"@@ -92,10 +93,9 @@ public void testFreeStyleShellOnSlave() throws Exception {\n \t}\n \n \tpublic void testFreeStyleAntOnSlave() throws Exception {\n-        if (jenkins.getDescriptorByType(Ant.DescriptorImpl.class).getInstallations().length == 0) {\n-            System.out.println(\"Cannot do testFreeStyleAntOnSlave without ANT_HOME\");\n-            return;\n-        }\n+\t    // Cannot do testFreeStyleAntOnSlave without ANT_HOME\n+\t    Assume.assumeTrue((jenkins.getDescriptorByType(Ant.DescriptorImpl.class).getInstallations().length > 0);","path":"test/src/test/java/hudson/tasks/EnvVarsInConfigTasksTest.java","position":17,"original_position":17,"commit_id":"977e47a6926142de6aaf724114b1bb182b276de3","original_commit_id":"977e47a6926142de6aaf724114b1bb182b276de3","user":{"login":"jtnord","id":494726,"avatar_url":"https://avatars.githubusercontent.com/u/494726?v=3","gravatar_id":"","url":"https://api.github.com/users/jtnord","html_url":"https://github.com/jtnord","followers_url":"https://api.github.com/users/jtnord/followers","following_url":"https://api.github.com/users/jtnord/following{/other_user}","gists_url":"https://api.github.com/users/jtnord/gists{/gist_id}","starred_url":"https://api.github.com/users/jtnord/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jtnord/subscriptions","organizations_url":"https://api.github.com/users/jtnord/orgs","repos_url":"https://api.github.com/users/jtnord/repos","events_url":"https://api.github.com/users/jtnord/events{/privacy}","received_events_url":"https://api.github.com/users/jtnord/received_events","type":"User","site_admin":false},"body":"`assumeThat(jenkins.getDescriptorByType(Ant.DescriptorImpl.class).getInstallations(), not(empty()))`","created_at":"2015-09-30T17:19:37Z","updated_at":"2015-09-30T17:19:37Z","html_url":"https://github.com/jenkinsci/jenkins/pull/1845#discussion_r40822673","pull_request_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845","_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments/40822673"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1845#discussion_r40822673"},"pull_request":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845"}}},"pull_request":{"url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845","id":46426522,"html_url":"https://github.com/jenkinsci/jenkins/pull/1845","diff_url":"https://github.com/jenkinsci/jenkins/pull/1845.diff","patch_url":"https://github.com/jenkinsci/jenkins/pull/1845.patch","issue_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1845","number":1845,"state":"open","locked":false,"title":"Do not skip tests silently","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"body":"Replace early returns in tests with assumptions.\r\n\r\nThere should be 15 new skipped tests after this refactorization.","created_at":"2015-09-30T16:43:30Z","updated_at":"2015-09-30T17:19:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3961c57a7012b3f3ee8f4e79834879dd22e8f901","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845/commits","review_comments_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845/comments","review_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/1845/comments","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/977e47a6926142de6aaf724114b1bb182b276de3","head":{"label":"olivergondza:assume","ref":"assume","sha":"977e47a6926142de6aaf724114b1bb182b276de3","user":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"repo":{"id":5356417,"name":"jenkins","full_name":"olivergondza/jenkins","owner":{"login":"olivergondza","id":206841,"avatar_url":"https://avatars.githubusercontent.com/u/206841?v=3","gravatar_id":"","url":"https://api.github.com/users/olivergondza","html_url":"https://github.com/olivergondza","followers_url":"https://api.github.com/users/olivergondza/followers","following_url":"https://api.github.com/users/olivergondza/following{/other_user}","gists_url":"https://api.github.com/users/olivergondza/gists{/gist_id}","starred_url":"https://api.github.com/users/olivergondza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olivergondza/subscriptions","organizations_url":"https://api.github.com/users/olivergondza/orgs","repos_url":"https://api.github.com/users/olivergondza/repos","events_url":"https://api.github.com/users/olivergondza/events{/privacy}","received_events_url":"https://api.github.com/users/olivergondza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olivergondza/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/olivergondza/jenkins","forks_url":"https://api.github.com/repos/olivergondza/jenkins/forks","keys_url":"https://api.github.com/repos/olivergondza/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olivergondza/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olivergondza/jenkins/teams","hooks_url":"https://api.github.com/repos/olivergondza/jenkins/hooks","issue_events_url":"https://api.github.com/repos/olivergondza/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/olivergondza/jenkins/events","assignees_url":"https://api.github.com/repos/olivergondza/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/olivergondza/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/olivergondza/jenkins/tags","blobs_url":"https://api.github.com/repos/olivergondza/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olivergondza/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olivergondza/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/olivergondza/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olivergondza/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/olivergondza/jenkins/languages","stargazers_url":"https://api.github.com/repos/olivergondza/jenkins/stargazers","contributors_url":"https://api.github.com/repos/olivergondza/jenkins/contributors","subscribers_url":"https://api.github.com/repos/olivergondza/jenkins/subscribers","subscription_url":"https://api.github.com/repos/olivergondza/jenkins/subscription","commits_url":"https://api.github.com/repos/olivergondza/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/olivergondza/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/olivergondza/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/olivergondza/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/olivergondza/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/olivergondza/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olivergondza/jenkins/merges","archive_url":"https://api.github.com/repos/olivergondza/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olivergondza/jenkins/downloads","issues_url":"https://api.github.com/repos/olivergondza/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/olivergondza/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/olivergondza/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/olivergondza/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olivergondza/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/olivergondza/jenkins/releases{/id}","created_at":"2012-08-09T14:14:09Z","updated_at":"2015-09-29T19:26:23Z","pushed_at":"2015-09-30T16:41:38Z","git_url":"git://github.com/olivergondza/jenkins.git","ssh_url":"git@github.com:olivergondza/jenkins.git","clone_url":"https://github.com/olivergondza/jenkins.git","svn_url":"https://github.com/olivergondza/jenkins","homepage":"http://jenkins-ci.org/","size":87231,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkinsci:master","ref":"master","sha":"7fb4696a6f8725211a4011f3a007f2facaf08947","user":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"repo":{"id":1103607,"name":"jenkins","full_name":"jenkinsci/jenkins","owner":{"login":"jenkinsci","id":107424,"avatar_url":"https://avatars.githubusercontent.com/u/107424?v=3","gravatar_id":"","url":"https://api.github.com/users/jenkinsci","html_url":"https://github.com/jenkinsci","followers_url":"https://api.github.com/users/jenkinsci/followers","following_url":"https://api.github.com/users/jenkinsci/following{/other_user}","gists_url":"https://api.github.com/users/jenkinsci/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkinsci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkinsci/subscriptions","organizations_url":"https://api.github.com/users/jenkinsci/orgs","repos_url":"https://api.github.com/users/jenkinsci/repos","events_url":"https://api.github.com/users/jenkinsci/events{/privacy}","received_events_url":"https://api.github.com/users/jenkinsci/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jenkinsci/jenkins","description":"Jenkins Continuous Integration Server","fork":true,"url":"https://api.github.com/repos/jenkinsci/jenkins","forks_url":"https://api.github.com/repos/jenkinsci/jenkins/forks","keys_url":"https://api.github.com/repos/jenkinsci/jenkins/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkinsci/jenkins/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkinsci/jenkins/teams","hooks_url":"https://api.github.com/repos/jenkinsci/jenkins/hooks","issue_events_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/events{/number}","events_url":"https://api.github.com/repos/jenkinsci/jenkins/events","assignees_url":"https://api.github.com/repos/jenkinsci/jenkins/assignees{/user}","branches_url":"https://api.github.com/repos/jenkinsci/jenkins/branches{/branch}","tags_url":"https://api.github.com/repos/jenkinsci/jenkins/tags","blobs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkinsci/jenkins/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkinsci/jenkins/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkinsci/jenkins/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkinsci/jenkins/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkinsci/jenkins/languages","stargazers_url":"https://api.github.com/repos/jenkinsci/jenkins/stargazers","contributors_url":"https://api.github.com/repos/jenkinsci/jenkins/contributors","subscribers_url":"https://api.github.com/repos/jenkinsci/jenkins/subscribers","subscription_url":"https://api.github.com/repos/jenkinsci/jenkins/subscription","commits_url":"https://api.github.com/repos/jenkinsci/jenkins/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkinsci/jenkins/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkinsci/jenkins/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkinsci/jenkins/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkinsci/jenkins/contents/{+path}","compare_url":"https://api.github.com/repos/jenkinsci/jenkins/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkinsci/jenkins/merges","archive_url":"https://api.github.com/repos/jenkinsci/jenkins/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkinsci/jenkins/downloads","issues_url":"https://api.github.com/repos/jenkinsci/jenkins/issues{/number}","pulls_url":"https://api.github.com/repos/jenkinsci/jenkins/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkinsci/jenkins/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkinsci/jenkins/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkinsci/jenkins/labels{/name}","releases_url":"https://api.github.com/repos/jenkinsci/jenkins/releases{/id}","created_at":"2010-11-22T21:21:23Z","updated_at":"2015-09-30T17:04:12Z","pushed_at":"2015-09-30T16:43:31Z","git_url":"git://github.com/jenkinsci/jenkins.git","ssh_url":"git@github.com:jenkinsci/jenkins.git","clone_url":"https://github.com/jenkinsci/jenkins.git","svn_url":"https://github.com/jenkinsci/jenkins","homepage":"http://jenkins-ci.org/","size":455678,"stargazers_count":4588,"watchers_count":4588,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2041,"mirror_url":null,"open_issues_count":126,"forks":2041,"open_issues":126,"watchers":4588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845"},"html":{"href":"https://github.com/jenkinsci/jenkins/pull/1845"},"issue":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1845"},"comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/issues/1845/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkinsci/jenkins/pulls/1845/commits"},"statuses":{"href":"https://api.github.com/repos/jenkinsci/jenkins/statuses/977e47a6926142de6aaf724114b1bb182b276de3"}}}}