{"action":"created","issue":{"url":"https://api.github.com/repos/rehan-0601/InstagramClient/issues/1","labels_url":"https://api.github.com/repos/rehan-0601/InstagramClient/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/rehan-0601/InstagramClient/issues/1/comments","events_url":"https://api.github.com/repos/rehan-0601/InstagramClient/issues/1/events","html_url":"https://github.com/rehan-0601/InstagramClient/issues/1","id":107407644,"number":1,"title":"[Android Bootcamp]:Project1-Instagram Client - ready for review","user":{"login":"rehan-0601","id":12778915,"avatar_url":"https://avatars.githubusercontent.com/u/12778915?v=3","gravatar_id":"","url":"https://api.github.com/users/rehan-0601","html_url":"https://github.com/rehan-0601","followers_url":"https://api.github.com/users/rehan-0601/followers","following_url":"https://api.github.com/users/rehan-0601/following{/other_user}","gists_url":"https://api.github.com/users/rehan-0601/gists{/gist_id}","starred_url":"https://api.github.com/users/rehan-0601/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rehan-0601/subscriptions","organizations_url":"https://api.github.com/users/rehan-0601/orgs","repos_url":"https://api.github.com/users/rehan-0601/repos","events_url":"https://api.github.com/users/rehan-0601/events{/privacy}","received_events_url":"https://api.github.com/users/rehan-0601/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-20T18:03:59Z","updated_at":"2015-09-21T06:49:29Z","closed_at":null,"body":"My app is complete, please review. /cc @codepathreview @codepath\r\n\r\nQuestions:\r\n1.I could'nt get my font color/sizes to look like instagram. How do you find out the fonts/styles they use and use the same typeface.(android gave me only 4 typefaces, how do you import more fonts)\r\n2.The REST end point for /media/popular seems to be returning a max of 8 comments.(Though the count is > 8). Im i messing up or is this expected behavior.\r\n3.For an imageView does it matter if i use padding or layout margin.(sorry if i do'nt have the box model right.)"},"comment":{"url":"https://api.github.com/repos/rehan-0601/InstagramClient/issues/comments/141892623","html_url":"https://github.com/rehan-0601/InstagramClient/issues/1#issuecomment-141892623","issue_url":"https://api.github.com/repos/rehan-0601/InstagramClient/issues/1","id":141892623,"user":{"login":"codepathreview","id":7917093,"avatar_url":"https://avatars.githubusercontent.com/u/7917093?v=3","gravatar_id":"","url":"https://api.github.com/users/codepathreview","html_url":"https://github.com/codepathreview","followers_url":"https://api.github.com/users/codepathreview/followers","following_url":"https://api.github.com/users/codepathreview/following{/other_user}","gists_url":"https://api.github.com/users/codepathreview/gists{/gist_id}","starred_url":"https://api.github.com/users/codepathreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codepathreview/subscriptions","organizations_url":"https://api.github.com/users/codepathreview/orgs","repos_url":"https://api.github.com/users/codepathreview/repos","events_url":"https://api.github.com/users/codepathreview/events{/privacy}","received_events_url":"https://api.github.com/users/codepathreview/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T06:49:29Z","updated_at":"2015-09-21T06:49:29Z","body":"Decent work, Rehan. \r\n\r\nRegarding your questions:\r\n\r\n1. You can use a chrome plugin called \"ColorPick Eyedropper\" for finding color values. Checkout http://stackoverflow.com/questions/3424165/can-i-embed-a-custom-font-in-an-android-application to understand how to import custom fonts.\r\n2. Checkout https://instagram.com/developer/endpoints/comments/ to understand how to get comments for a photo.\r\n3. Checkout http://stackoverflow.com/questions/4619899/difference-between-a-views-padding-and-margin to understand the difference between margin and padding.\r\n\r\n\r\nA few notes after checking out the code:\r\n\r\nGood layout, proper view naming, usage of sp/dp, margin and relative placement rules\r\nCorrect use of Styles, Colors and String resources\r\nNice to see you used the SwipeRefreshLayout for easy stream refreshes\r\nGood job using the ViewHolder pattern to improve performance of photos ListView.\r\nGood to see that you used a dialog instead of activity to show all comments.\r\nConsider polishing UI little more. \r\nConsider adding profile pic along with comments in \"all comments\" view\r\nConsider including a check to see if internet is available to detect any network failures. Show an appropriate message in case of failure.\r\nConsider overriding onFailure method in JsonHttpResponseHandler to handle error messages appropriately.\r\nOne of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to complete the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.\r\n\r\nWe have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.\r\n\r\nHopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.\r\n\r\nIf you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or or email us support@codepath.com.\r\n\r\nP.S. Good to see you properly added the readme with features and screenshots to your project as described in the submitting assignments guide!"}}