{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/29741566","id":29741566,"diff_hunk":"@@ -0,0 +1,175 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.ml.reduction\n+\n+\n+import scala.language.existentials\n+\n+import org.apache.spark.annotation.{AlphaComponent, DeveloperApi}\n+import org.apache.spark.ml.{Estimator, Model}\n+import org.apache.spark.ml.attribute.BinaryAttribute\n+import org.apache.spark.ml.classification.{ClassificationModel, Classifier, ClassifierParams}\n+import org.apache.spark.ml.param.Param\n+import org.apache.spark.ml.util.{MetadataUtils, SchemaUtils}\n+import org.apache.spark.mllib.linalg._\n+import org.apache.spark.rdd.RDD\n+import org.apache.spark.sql.{DataFrame, Row}\n+import org.apache.spark.sql.functions._\n+import org.apache.spark.sql.types._\n+import org.apache.spark.storage.StorageLevel\n+\n+/**\n+ * Params for [[OneVsRestClassifier]].\n+ */\n+private[ml] trait OneVsRestParams extends ClassifierParams {\n+\n+  type ClassifierType = Classifier[F, E, M] forSome {\n+    type F ;\n+    type M <: ClassificationModel[F,M];\n+    type E <:  Classifier[F, E,M]\n+  }\n+\n+  /**\n+   * param for the base classifier that we reduce multiclass classification into.\n+   * @group param\n+   */\n+  val baseClassifier: Param[ClassifierType]  =\n+    new Param(this, \"baseClassifier\", \"base binary classifier/regressor \")\n+\n+  /** @group getParam */\n+  def getBaseClassifier: ClassifierType = getOrDefault(baseClassifier)\n+\n+}\n+\n+/**\n+ *\n+ * @param parent\n+ * @param baseClassificationModels the binary classification models for reduction.\n+ */\n+@AlphaComponent\n+private[ml] class OneVsRestModel(\n+    override val parent: OneVsRestClassifier,\n+    val baseClassificationModels: Array[Model[_]])\n+  extends Model[OneVsRestModel] with OneVsRestParams {\n+\n+  /**\n+   * Transforms the dataset with provided parameter map as additional parameters.\n+   * @param dataset input dataset\n+   * @return transformed dataset\n+   */\n+  override def transform(dataset: DataFrame): DataFrame = {\n+    // Check schema\n+    val parentSchema = dataset.schema\n+    transformSchema(parentSchema, logging = true)\n+    val sqlCtx = dataset.sqlContext\n+\n+    // score each model on every data point and pick the model with highest score\n+    val predictions = baseClassificationModels.zipWithIndex.par.map { case (model, index) =>\n+      val output = model.transform(dataset)\n+      output.select($(rawPredictionCol)).map { case Row(p: Vector) => List((index, p(1))) }\n+    }.reduce[RDD[List[(Int, Double)]]] { case (x, y) =>\n+      x.zip(y).map { case ((a, b)) =>","path":"mllib/src/main/scala/org/apache/spark/ml/reduction/OneVsRestClassifier.scala","position":86,"original_position":86,"commit_id":"df188d84b89f8883304bba653839ab7e79e28e79","original_commit_id":"df188d84b89f8883304bba653839ab7e79e28e79","user":{"login":"mengxr","id":829644,"avatar_url":"https://avatars.githubusercontent.com/u/829644?v=3","gravatar_id":"","url":"https://api.github.com/users/mengxr","html_url":"https://github.com/mengxr","followers_url":"https://api.github.com/users/mengxr/followers","following_url":"https://api.github.com/users/mengxr/following{/other_user}","gists_url":"https://api.github.com/users/mengxr/gists{/gist_id}","starred_url":"https://api.github.com/users/mengxr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mengxr/subscriptions","organizations_url":"https://api.github.com/users/mengxr/orgs","repos_url":"https://api.github.com/users/mengxr/repos","events_url":"https://api.github.com/users/mengxr/events{/privacy}","received_events_url":"https://api.github.com/users/mengxr/received_events","type":"User","site_admin":false},"body":"We should leave a TODO here to tune performance. It would be nice if we can use DataFrame expressions in the future to leverage on SQL performance improvements.","created_at":"2015-05-06T08:25:48Z","updated_at":"2015-05-06T08:25:48Z","html_url":"https://github.com/apache/spark/pull/5830#discussion_r29741566","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/5830","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/29741566"},"html":{"href":"https://github.com/apache/spark/pull/5830#discussion_r29741566"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/5830"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/5830","id":34524294,"html_url":"https://github.com/apache/spark/pull/5830","diff_url":"https://github.com/apache/spark/pull/5830.diff","patch_url":"https://github.com/apache/spark/pull/5830.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/5830","number":5830,"state":"open","locked":false,"title":"[SPARK-7015][MLLib][WIP] Multiclass to Binary Reduction: One Against All","user":{"login":"harsha2010","id":271956,"avatar_url":"https://avatars.githubusercontent.com/u/271956?v=3","gravatar_id":"","url":"https://api.github.com/users/harsha2010","html_url":"https://github.com/harsha2010","followers_url":"https://api.github.com/users/harsha2010/followers","following_url":"https://api.github.com/users/harsha2010/following{/other_user}","gists_url":"https://api.github.com/users/harsha2010/gists{/gist_id}","starred_url":"https://api.github.com/users/harsha2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsha2010/subscriptions","organizations_url":"https://api.github.com/users/harsha2010/orgs","repos_url":"https://api.github.com/users/harsha2010/repos","events_url":"https://api.github.com/users/harsha2010/events{/privacy}","received_events_url":"https://api.github.com/users/harsha2010/received_events","type":"User","site_admin":false},"body":"initial cut of one against all. test code is a scaffolding , not fully implemented.\r\nThis WIP is to gather early feedback. ","created_at":"2015-05-01T06:50:52Z","updated_at":"2015-05-06T08:25:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79c8306ed0dce293dff6888305f582037af4e664","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/5830/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/5830/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/5830/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/df188d84b89f8883304bba653839ab7e79e28e79","head":{"label":"harsha2010:reduction","ref":"reduction","sha":"df188d84b89f8883304bba653839ab7e79e28e79","user":{"login":"harsha2010","id":271956,"avatar_url":"https://avatars.githubusercontent.com/u/271956?v=3","gravatar_id":"","url":"https://api.github.com/users/harsha2010","html_url":"https://github.com/harsha2010","followers_url":"https://api.github.com/users/harsha2010/followers","following_url":"https://api.github.com/users/harsha2010/following{/other_user}","gists_url":"https://api.github.com/users/harsha2010/gists{/gist_id}","starred_url":"https://api.github.com/users/harsha2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsha2010/subscriptions","organizations_url":"https://api.github.com/users/harsha2010/orgs","repos_url":"https://api.github.com/users/harsha2010/repos","events_url":"https://api.github.com/users/harsha2010/events{/privacy}","received_events_url":"https://api.github.com/users/harsha2010/received_events","type":"User","site_admin":false},"repo":{"id":34759855,"name":"spark","full_name":"harsha2010/spark","owner":{"login":"harsha2010","id":271956,"avatar_url":"https://avatars.githubusercontent.com/u/271956?v=3","gravatar_id":"","url":"https://api.github.com/users/harsha2010","html_url":"https://github.com/harsha2010","followers_url":"https://api.github.com/users/harsha2010/followers","following_url":"https://api.github.com/users/harsha2010/following{/other_user}","gists_url":"https://api.github.com/users/harsha2010/gists{/gist_id}","starred_url":"https://api.github.com/users/harsha2010/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsha2010/subscriptions","organizations_url":"https://api.github.com/users/harsha2010/orgs","repos_url":"https://api.github.com/users/harsha2010/repos","events_url":"https://api.github.com/users/harsha2010/events{/privacy}","received_events_url":"https://api.github.com/users/harsha2010/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/harsha2010/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/harsha2010/spark","forks_url":"https://api.github.com/repos/harsha2010/spark/forks","keys_url":"https://api.github.com/repos/harsha2010/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/harsha2010/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/harsha2010/spark/teams","hooks_url":"https://api.github.com/repos/harsha2010/spark/hooks","issue_events_url":"https://api.github.com/repos/harsha2010/spark/issues/events{/number}","events_url":"https://api.github.com/repos/harsha2010/spark/events","assignees_url":"https://api.github.com/repos/harsha2010/spark/assignees{/user}","branches_url":"https://api.github.com/repos/harsha2010/spark/branches{/branch}","tags_url":"https://api.github.com/repos/harsha2010/spark/tags","blobs_url":"https://api.github.com/repos/harsha2010/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/harsha2010/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/harsha2010/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/harsha2010/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/harsha2010/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/harsha2010/spark/languages","stargazers_url":"https://api.github.com/repos/harsha2010/spark/stargazers","contributors_url":"https://api.github.com/repos/harsha2010/spark/contributors","subscribers_url":"https://api.github.com/repos/harsha2010/spark/subscribers","subscription_url":"https://api.github.com/repos/harsha2010/spark/subscription","commits_url":"https://api.github.com/repos/harsha2010/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/harsha2010/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/harsha2010/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/harsha2010/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/harsha2010/spark/contents/{+path}","compare_url":"https://api.github.com/repos/harsha2010/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/harsha2010/spark/merges","archive_url":"https://api.github.com/repos/harsha2010/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/harsha2010/spark/downloads","issues_url":"https://api.github.com/repos/harsha2010/spark/issues{/number}","pulls_url":"https://api.github.com/repos/harsha2010/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/harsha2010/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/harsha2010/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/harsha2010/spark/labels{/name}","releases_url":"https://api.github.com/repos/harsha2010/spark/releases{/id}","created_at":"2015-04-28T22:43:49Z","updated_at":"2015-04-28T22:44:09Z","pushed_at":"2015-05-06T07:02:21Z","git_url":"git://github.com/harsha2010/spark.git","ssh_url":"git@github.com:harsha2010/spark.git","clone_url":"https://github.com/harsha2010/spark.git","svn_url":"https://github.com/harsha2010/spark","homepage":null,"size":104243,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a4669443999dc13a1bb34509c827d8b9096ea84f","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-05-06T07:20:08Z","pushed_at":"2015-05-06T07:57:57Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1618638,"stargazers_count":3869,"watchers_count":3869,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3373,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":305,"forks":3373,"open_issues":305,"watchers":3869,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/5830"},"html":{"href":"https://github.com/apache/spark/pull/5830"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/5830"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/5830/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/5830/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/5830/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/df188d84b89f8883304bba653839ab7e79e28e79"}}}}