{"action":"created","comment":{"url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/comments/39404365","id":39404365,"diff_hunk":"@@ -229,6 +229,22 @@ void main() {\n     expect(results[1]['tagName'], equals('DIV'));\n   });\n \n+  test('scryRenderedDomComponentsWithId', () {\n+    var idName = 'searchableId';\n+\n+    component = renderIntoDocument(div({}, [\n+      div({'id': idName}),\n+      div({'id': idName}),\n+      span({})\n+    ]));\n+\n+    var results = scryRenderedDOMComponentsWithId(component, idName);\n+\n+    expect(results.length, 2);\n+    expect(results[0]['props']['id'], equals(idName));\n+    expect(results[1]['props']['id'], equals(idName));\n+  });","path":"test/react_test_utils_test.dart","position":18,"original_position":18,"commit_id":"14afa2626e363fc15cabe41215f964d6f3b1c282","original_commit_id":"14afa2626e363fc15cabe41215f964d6f3b1c282","user":{"login":"tylersnavely-wf","id":1466382,"avatar_url":"https://avatars.githubusercontent.com/u/1466382?v=3","gravatar_id":"","url":"https://api.github.com/users/tylersnavely-wf","html_url":"https://github.com/tylersnavely-wf","followers_url":"https://api.github.com/users/tylersnavely-wf/followers","following_url":"https://api.github.com/users/tylersnavely-wf/following{/other_user}","gists_url":"https://api.github.com/users/tylersnavely-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersnavely-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersnavely-wf/subscriptions","organizations_url":"https://api.github.com/users/tylersnavely-wf/orgs","repos_url":"https://api.github.com/users/tylersnavely-wf/repos","events_url":"https://api.github.com/users/tylersnavely-wf/events{/privacy}","received_events_url":"https://api.github.com/users/tylersnavely-wf/received_events","type":"User","site_admin":false},"body":"It would also be a good idea to test the scenario where the query returns an empty list.","created_at":"2015-09-14T15:03:05Z","updated_at":"2015-09-14T15:03:05Z","html_url":"https://github.com/jayudey-wf/react-dart/pull/2#discussion_r39404365","pull_request_url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/comments/39404365"},"html":{"href":"https://github.com/jayudey-wf/react-dart/pull/2#discussion_r39404365"},"pull_request":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2","id":44794263,"html_url":"https://github.com/jayudey-wf/react-dart/pull/2","diff_url":"https://github.com/jayudey-wf/react-dart/pull/2.diff","patch_url":"https://github.com/jayudey-wf/react-dart/pull/2.patch","issue_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues/2","number":2,"state":"open","locked":false,"title":"Adding method to allow search for Id","user":{"login":"jayudey-wf","id":4429043,"avatar_url":"https://avatars.githubusercontent.com/u/4429043?v=3","gravatar_id":"","url":"https://api.github.com/users/jayudey-wf","html_url":"https://github.com/jayudey-wf","followers_url":"https://api.github.com/users/jayudey-wf/followers","following_url":"https://api.github.com/users/jayudey-wf/following{/other_user}","gists_url":"https://api.github.com/users/jayudey-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jayudey-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayudey-wf/subscriptions","organizations_url":"https://api.github.com/users/jayudey-wf/orgs","repos_url":"https://api.github.com/users/jayudey-wf/repos","events_url":"https://api.github.com/users/jayudey-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jayudey-wf/received_events","type":"User","site_admin":false},"body":"Internal Review\r\n\r\n## Issue\r\n- There is no way to search for elements by Id\r\n\r\n## Changes\r\n**Source:**\r\n- Added method to allow for this type of search\r\n\r\n**Tests:**\r\n- Added corresponding test\r\n\r\n## Areas of Regression\r\n- n/a\r\n\r\n## Testing\r\n- Ensure that tests pass\r\n\r\n## Code Review\r\n@greglittlefield-wf\r\n@tylersnavely-wf\r\n@jonasray-wf\r\n\r\n","created_at":"2015-09-11T15:17:18Z","updated_at":"2015-09-14T15:03:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a03a4e02cc8a732320b3cf53034f1878dc59c3c8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues/2/comments","statuses_url":"https://api.github.com/repos/jayudey-wf/react-dart/statuses/14afa2626e363fc15cabe41215f964d6f3b1c282","head":{"label":"jayudey-wf:adding_id_search","ref":"adding_id_search","sha":"14afa2626e363fc15cabe41215f964d6f3b1c282","user":{"login":"jayudey-wf","id":4429043,"avatar_url":"https://avatars.githubusercontent.com/u/4429043?v=3","gravatar_id":"","url":"https://api.github.com/users/jayudey-wf","html_url":"https://github.com/jayudey-wf","followers_url":"https://api.github.com/users/jayudey-wf/followers","following_url":"https://api.github.com/users/jayudey-wf/following{/other_user}","gists_url":"https://api.github.com/users/jayudey-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jayudey-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayudey-wf/subscriptions","organizations_url":"https://api.github.com/users/jayudey-wf/orgs","repos_url":"https://api.github.com/users/jayudey-wf/repos","events_url":"https://api.github.com/users/jayudey-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jayudey-wf/received_events","type":"User","site_admin":false},"repo":{"id":34685169,"name":"react-dart","full_name":"jayudey-wf/react-dart","owner":{"login":"jayudey-wf","id":4429043,"avatar_url":"https://avatars.githubusercontent.com/u/4429043?v=3","gravatar_id":"","url":"https://api.github.com/users/jayudey-wf","html_url":"https://github.com/jayudey-wf","followers_url":"https://api.github.com/users/jayudey-wf/followers","following_url":"https://api.github.com/users/jayudey-wf/following{/other_user}","gists_url":"https://api.github.com/users/jayudey-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jayudey-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayudey-wf/subscriptions","organizations_url":"https://api.github.com/users/jayudey-wf/orgs","repos_url":"https://api.github.com/users/jayudey-wf/repos","events_url":"https://api.github.com/users/jayudey-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jayudey-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayudey-wf/react-dart","description":"Bindings for React to Dart","fork":true,"url":"https://api.github.com/repos/jayudey-wf/react-dart","forks_url":"https://api.github.com/repos/jayudey-wf/react-dart/forks","keys_url":"https://api.github.com/repos/jayudey-wf/react-dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayudey-wf/react-dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayudey-wf/react-dart/teams","hooks_url":"https://api.github.com/repos/jayudey-wf/react-dart/hooks","issue_events_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues/events{/number}","events_url":"https://api.github.com/repos/jayudey-wf/react-dart/events","assignees_url":"https://api.github.com/repos/jayudey-wf/react-dart/assignees{/user}","branches_url":"https://api.github.com/repos/jayudey-wf/react-dart/branches{/branch}","tags_url":"https://api.github.com/repos/jayudey-wf/react-dart/tags","blobs_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayudey-wf/react-dart/statuses/{sha}","languages_url":"https://api.github.com/repos/jayudey-wf/react-dart/languages","stargazers_url":"https://api.github.com/repos/jayudey-wf/react-dart/stargazers","contributors_url":"https://api.github.com/repos/jayudey-wf/react-dart/contributors","subscribers_url":"https://api.github.com/repos/jayudey-wf/react-dart/subscribers","subscription_url":"https://api.github.com/repos/jayudey-wf/react-dart/subscription","commits_url":"https://api.github.com/repos/jayudey-wf/react-dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayudey-wf/react-dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayudey-wf/react-dart/contents/{+path}","compare_url":"https://api.github.com/repos/jayudey-wf/react-dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayudey-wf/react-dart/merges","archive_url":"https://api.github.com/repos/jayudey-wf/react-dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayudey-wf/react-dart/downloads","issues_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues{/number}","pulls_url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls{/number}","milestones_url":"https://api.github.com/repos/jayudey-wf/react-dart/milestones{/number}","notifications_url":"https://api.github.com/repos/jayudey-wf/react-dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayudey-wf/react-dart/labels{/name}","releases_url":"https://api.github.com/repos/jayudey-wf/react-dart/releases{/id}","created_at":"2015-04-27T18:57:06Z","updated_at":"2015-04-27T18:57:07Z","pushed_at":"2015-09-11T15:17:19Z","git_url":"git://github.com/jayudey-wf/react-dart.git","ssh_url":"git@github.com:jayudey-wf/react-dart.git","clone_url":"https://github.com/jayudey-wf/react-dart.git","svn_url":"https://github.com/jayudey-wf/react-dart","homepage":null,"size":690,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jayudey-wf:master","ref":"master","sha":"ca6ec7213e185735adc4c50ebeab3fe1a23c3de2","user":{"login":"jayudey-wf","id":4429043,"avatar_url":"https://avatars.githubusercontent.com/u/4429043?v=3","gravatar_id":"","url":"https://api.github.com/users/jayudey-wf","html_url":"https://github.com/jayudey-wf","followers_url":"https://api.github.com/users/jayudey-wf/followers","following_url":"https://api.github.com/users/jayudey-wf/following{/other_user}","gists_url":"https://api.github.com/users/jayudey-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jayudey-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayudey-wf/subscriptions","organizations_url":"https://api.github.com/users/jayudey-wf/orgs","repos_url":"https://api.github.com/users/jayudey-wf/repos","events_url":"https://api.github.com/users/jayudey-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jayudey-wf/received_events","type":"User","site_admin":false},"repo":{"id":34685169,"name":"react-dart","full_name":"jayudey-wf/react-dart","owner":{"login":"jayudey-wf","id":4429043,"avatar_url":"https://avatars.githubusercontent.com/u/4429043?v=3","gravatar_id":"","url":"https://api.github.com/users/jayudey-wf","html_url":"https://github.com/jayudey-wf","followers_url":"https://api.github.com/users/jayudey-wf/followers","following_url":"https://api.github.com/users/jayudey-wf/following{/other_user}","gists_url":"https://api.github.com/users/jayudey-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/jayudey-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayudey-wf/subscriptions","organizations_url":"https://api.github.com/users/jayudey-wf/orgs","repos_url":"https://api.github.com/users/jayudey-wf/repos","events_url":"https://api.github.com/users/jayudey-wf/events{/privacy}","received_events_url":"https://api.github.com/users/jayudey-wf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jayudey-wf/react-dart","description":"Bindings for React to Dart","fork":true,"url":"https://api.github.com/repos/jayudey-wf/react-dart","forks_url":"https://api.github.com/repos/jayudey-wf/react-dart/forks","keys_url":"https://api.github.com/repos/jayudey-wf/react-dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jayudey-wf/react-dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jayudey-wf/react-dart/teams","hooks_url":"https://api.github.com/repos/jayudey-wf/react-dart/hooks","issue_events_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues/events{/number}","events_url":"https://api.github.com/repos/jayudey-wf/react-dart/events","assignees_url":"https://api.github.com/repos/jayudey-wf/react-dart/assignees{/user}","branches_url":"https://api.github.com/repos/jayudey-wf/react-dart/branches{/branch}","tags_url":"https://api.github.com/repos/jayudey-wf/react-dart/tags","blobs_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jayudey-wf/react-dart/statuses/{sha}","languages_url":"https://api.github.com/repos/jayudey-wf/react-dart/languages","stargazers_url":"https://api.github.com/repos/jayudey-wf/react-dart/stargazers","contributors_url":"https://api.github.com/repos/jayudey-wf/react-dart/contributors","subscribers_url":"https://api.github.com/repos/jayudey-wf/react-dart/subscribers","subscription_url":"https://api.github.com/repos/jayudey-wf/react-dart/subscription","commits_url":"https://api.github.com/repos/jayudey-wf/react-dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/jayudey-wf/react-dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/jayudey-wf/react-dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/jayudey-wf/react-dart/contents/{+path}","compare_url":"https://api.github.com/repos/jayudey-wf/react-dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jayudey-wf/react-dart/merges","archive_url":"https://api.github.com/repos/jayudey-wf/react-dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jayudey-wf/react-dart/downloads","issues_url":"https://api.github.com/repos/jayudey-wf/react-dart/issues{/number}","pulls_url":"https://api.github.com/repos/jayudey-wf/react-dart/pulls{/number}","milestones_url":"https://api.github.com/repos/jayudey-wf/react-dart/milestones{/number}","notifications_url":"https://api.github.com/repos/jayudey-wf/react-dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jayudey-wf/react-dart/labels{/name}","releases_url":"https://api.github.com/repos/jayudey-wf/react-dart/releases{/id}","created_at":"2015-04-27T18:57:06Z","updated_at":"2015-04-27T18:57:07Z","pushed_at":"2015-09-11T15:17:19Z","git_url":"git://github.com/jayudey-wf/react-dart.git","ssh_url":"git@github.com:jayudey-wf/react-dart.git","clone_url":"https://github.com/jayudey-wf/react-dart.git","svn_url":"https://github.com/jayudey-wf/react-dart","homepage":null,"size":690,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2"},"html":{"href":"https://github.com/jayudey-wf/react-dart/pull/2"},"issue":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/issues/2"},"comments":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jayudey-wf/react-dart/statuses/14afa2626e363fc15cabe41215f964d6f3b1c282"}}}}