{"action":"created","comment":{"url":"https://api.github.com/repos/goatslacker/alt/pulls/comments/27504091","id":27504091,"diff_hunk":"@@ -364,22 +364,24 @@ class Alt {\n     let storeInstance\n     let key = iden || StoreModel.name || StoreModel.displayName || ''\n \n-    if (saveStore && (this.stores[key] || !key)) {\n-      /* istanbul ignore else */\n-      if (typeof console !== 'undefined') {\n-        if (this.stores[key]) {\n-          console.warn(new ReferenceError(\n-            `A store named ${key} already exists, double check your store ` +\n-            `names or pass in your own custom identifier for each store`\n-          ))\n-        } else {\n-          console.warn(new ReferenceError('Store name was not specified'))\n-        }\n+    /* istanbul ignore else */\n+    if (typeof console !== 'undefined') {\n+      if (saveStore && !key) {\n+        console.warn('Store name was not specified')\n       }\n \n-      key = uid(this.stores, key)\n+      if (saveStore && this.stores[key] && StoreModel !== this.stores[key].StoreModel) {\n+        console.warn(\n+          `A store named ${key} already exists, double check your store ` +\n+          `names or pass in your own custom identifier for each store`\n+        )\n+      }\n     }\n \n+    key = this.stores[key] && StoreModel === this.stores[key].StoreModel\n+      ? key\n+      : uid(this.stores, key)\n+","path":"src/alt.js","position":33,"original_position":33,"commit_id":"6e692a452f06346463fce911a75ad72cc5127480","original_commit_id":"6e692a452f06346463fce911a75ad72cc5127480","user":{"login":"jdlehman","id":3144695,"avatar_url":"https://avatars.githubusercontent.com/u/3144695?v=3","gravatar_id":"","url":"https://api.github.com/users/jdlehman","html_url":"https://github.com/jdlehman","followers_url":"https://api.github.com/users/jdlehman/followers","following_url":"https://api.github.com/users/jdlehman/following{/other_user}","gists_url":"https://api.github.com/users/jdlehman/gists{/gist_id}","starred_url":"https://api.github.com/users/jdlehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdlehman/subscriptions","organizations_url":"https://api.github.com/users/jdlehman/orgs","repos_url":"https://api.github.com/users/jdlehman/repos","events_url":"https://api.github.com/users/jdlehman/events{/privacy}","received_events_url":"https://api.github.com/users/jdlehman/received_events","type":"User","site_admin":false},"body":"nit. Once a ternary has to be on multiple lines, does it make more sense to use an if statement?","created_at":"2015-03-31T17:50:28Z","updated_at":"2015-03-31T17:50:28Z","html_url":"https://github.com/goatslacker/alt/pull/116#discussion_r27504091","pull_request_url":"https://api.github.com/repos/goatslacker/alt/pulls/116","_links":{"self":{"href":"https://api.github.com/repos/goatslacker/alt/pulls/comments/27504091"},"html":{"href":"https://github.com/goatslacker/alt/pull/116#discussion_r27504091"},"pull_request":{"href":"https://api.github.com/repos/goatslacker/alt/pulls/116"}}},"pull_request":{"url":"https://api.github.com/repos/goatslacker/alt/pulls/116","id":32291956,"html_url":"https://github.com/goatslacker/alt/pull/116","diff_url":"https://github.com/goatslacker/alt/pull/116.diff","patch_url":"https://github.com/goatslacker/alt/pull/116.patch","issue_url":"https://api.github.com/repos/goatslacker/alt/issues/116","number":116,"state":"open","locked":false,"title":"Fix react-hot-loader from reloading stores","user":{"login":"goatslacker","id":10632,"avatar_url":"https://avatars.githubusercontent.com/u/10632?v=3","gravatar_id":"","url":"https://api.github.com/users/goatslacker","html_url":"https://github.com/goatslacker","followers_url":"https://api.github.com/users/goatslacker/followers","following_url":"https://api.github.com/users/goatslacker/following{/other_user}","gists_url":"https://api.github.com/users/goatslacker/gists{/gist_id}","starred_url":"https://api.github.com/users/goatslacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatslacker/subscriptions","organizations_url":"https://api.github.com/users/goatslacker/orgs","repos_url":"https://api.github.com/users/goatslacker/repos","events_url":"https://api.github.com/users/goatslacker/events{/privacy}","received_events_url":"https://api.github.com/users/goatslacker/received_events","type":"User","site_admin":false},"body":"This fixes #85 ","created_at":"2015-03-31T05:21:21Z","updated_at":"2015-03-31T17:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a9183a943e50046ec83d354ac6c514647c66273","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/goatslacker/alt/pulls/116/commits","review_comments_url":"https://api.github.com/repos/goatslacker/alt/pulls/116/comments","review_comment_url":"https://api.github.com/repos/goatslacker/alt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/goatslacker/alt/issues/116/comments","statuses_url":"https://api.github.com/repos/goatslacker/alt/statuses/6e692a452f06346463fce911a75ad72cc5127480","head":{"label":"goatslacker:fix-react-hot-loader-store","ref":"fix-react-hot-loader-store","sha":"6e692a452f06346463fce911a75ad72cc5127480","user":{"login":"goatslacker","id":10632,"avatar_url":"https://avatars.githubusercontent.com/u/10632?v=3","gravatar_id":"","url":"https://api.github.com/users/goatslacker","html_url":"https://github.com/goatslacker","followers_url":"https://api.github.com/users/goatslacker/followers","following_url":"https://api.github.com/users/goatslacker/following{/other_user}","gists_url":"https://api.github.com/users/goatslacker/gists{/gist_id}","starred_url":"https://api.github.com/users/goatslacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatslacker/subscriptions","organizations_url":"https://api.github.com/users/goatslacker/orgs","repos_url":"https://api.github.com/users/goatslacker/repos","events_url":"https://api.github.com/users/goatslacker/events{/privacy}","received_events_url":"https://api.github.com/users/goatslacker/received_events","type":"User","site_admin":false},"repo":{"id":28223616,"name":"alt","full_name":"goatslacker/alt","owner":{"login":"goatslacker","id":10632,"avatar_url":"https://avatars.githubusercontent.com/u/10632?v=3","gravatar_id":"","url":"https://api.github.com/users/goatslacker","html_url":"https://github.com/goatslacker","followers_url":"https://api.github.com/users/goatslacker/followers","following_url":"https://api.github.com/users/goatslacker/following{/other_user}","gists_url":"https://api.github.com/users/goatslacker/gists{/gist_id}","starred_url":"https://api.github.com/users/goatslacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatslacker/subscriptions","organizations_url":"https://api.github.com/users/goatslacker/orgs","repos_url":"https://api.github.com/users/goatslacker/repos","events_url":"https://api.github.com/users/goatslacker/events{/privacy}","received_events_url":"https://api.github.com/users/goatslacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goatslacker/alt","description":"Isomorphic flux implementation","fork":false,"url":"https://api.github.com/repos/goatslacker/alt","forks_url":"https://api.github.com/repos/goatslacker/alt/forks","keys_url":"https://api.github.com/repos/goatslacker/alt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goatslacker/alt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goatslacker/alt/teams","hooks_url":"https://api.github.com/repos/goatslacker/alt/hooks","issue_events_url":"https://api.github.com/repos/goatslacker/alt/issues/events{/number}","events_url":"https://api.github.com/repos/goatslacker/alt/events","assignees_url":"https://api.github.com/repos/goatslacker/alt/assignees{/user}","branches_url":"https://api.github.com/repos/goatslacker/alt/branches{/branch}","tags_url":"https://api.github.com/repos/goatslacker/alt/tags","blobs_url":"https://api.github.com/repos/goatslacker/alt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goatslacker/alt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goatslacker/alt/git/refs{/sha}","trees_url":"https://api.github.com/repos/goatslacker/alt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goatslacker/alt/statuses/{sha}","languages_url":"https://api.github.com/repos/goatslacker/alt/languages","stargazers_url":"https://api.github.com/repos/goatslacker/alt/stargazers","contributors_url":"https://api.github.com/repos/goatslacker/alt/contributors","subscribers_url":"https://api.github.com/repos/goatslacker/alt/subscribers","subscription_url":"https://api.github.com/repos/goatslacker/alt/subscription","commits_url":"https://api.github.com/repos/goatslacker/alt/commits{/sha}","git_commits_url":"https://api.github.com/repos/goatslacker/alt/git/commits{/sha}","comments_url":"https://api.github.com/repos/goatslacker/alt/comments{/number}","issue_comment_url":"https://api.github.com/repos/goatslacker/alt/issues/comments{/number}","contents_url":"https://api.github.com/repos/goatslacker/alt/contents/{+path}","compare_url":"https://api.github.com/repos/goatslacker/alt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goatslacker/alt/merges","archive_url":"https://api.github.com/repos/goatslacker/alt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goatslacker/alt/downloads","issues_url":"https://api.github.com/repos/goatslacker/alt/issues{/number}","pulls_url":"https://api.github.com/repos/goatslacker/alt/pulls{/number}","milestones_url":"https://api.github.com/repos/goatslacker/alt/milestones{/number}","notifications_url":"https://api.github.com/repos/goatslacker/alt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goatslacker/alt/labels{/name}","releases_url":"https://api.github.com/repos/goatslacker/alt/releases{/id}","created_at":"2014-12-19T09:44:04Z","updated_at":"2015-03-31T17:35:44Z","pushed_at":"2015-03-31T13:44:47Z","git_url":"git://github.com/goatslacker/alt.git","ssh_url":"git@github.com:goatslacker/alt.git","clone_url":"https://github.com/goatslacker/alt.git","svn_url":"https://github.com/goatslacker/alt","homepage":"http://goatslacker.github.io/alt/","size":2759,"stargazers_count":575,"watchers_count":575,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":17,"forks":39,"open_issues":17,"watchers":575,"default_branch":"master"}},"base":{"label":"goatslacker:master","ref":"master","sha":"b5f5618351443cabd55eb30302bc1bcee86ad640","user":{"login":"goatslacker","id":10632,"avatar_url":"https://avatars.githubusercontent.com/u/10632?v=3","gravatar_id":"","url":"https://api.github.com/users/goatslacker","html_url":"https://github.com/goatslacker","followers_url":"https://api.github.com/users/goatslacker/followers","following_url":"https://api.github.com/users/goatslacker/following{/other_user}","gists_url":"https://api.github.com/users/goatslacker/gists{/gist_id}","starred_url":"https://api.github.com/users/goatslacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatslacker/subscriptions","organizations_url":"https://api.github.com/users/goatslacker/orgs","repos_url":"https://api.github.com/users/goatslacker/repos","events_url":"https://api.github.com/users/goatslacker/events{/privacy}","received_events_url":"https://api.github.com/users/goatslacker/received_events","type":"User","site_admin":false},"repo":{"id":28223616,"name":"alt","full_name":"goatslacker/alt","owner":{"login":"goatslacker","id":10632,"avatar_url":"https://avatars.githubusercontent.com/u/10632?v=3","gravatar_id":"","url":"https://api.github.com/users/goatslacker","html_url":"https://github.com/goatslacker","followers_url":"https://api.github.com/users/goatslacker/followers","following_url":"https://api.github.com/users/goatslacker/following{/other_user}","gists_url":"https://api.github.com/users/goatslacker/gists{/gist_id}","starred_url":"https://api.github.com/users/goatslacker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goatslacker/subscriptions","organizations_url":"https://api.github.com/users/goatslacker/orgs","repos_url":"https://api.github.com/users/goatslacker/repos","events_url":"https://api.github.com/users/goatslacker/events{/privacy}","received_events_url":"https://api.github.com/users/goatslacker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goatslacker/alt","description":"Isomorphic flux implementation","fork":false,"url":"https://api.github.com/repos/goatslacker/alt","forks_url":"https://api.github.com/repos/goatslacker/alt/forks","keys_url":"https://api.github.com/repos/goatslacker/alt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goatslacker/alt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goatslacker/alt/teams","hooks_url":"https://api.github.com/repos/goatslacker/alt/hooks","issue_events_url":"https://api.github.com/repos/goatslacker/alt/issues/events{/number}","events_url":"https://api.github.com/repos/goatslacker/alt/events","assignees_url":"https://api.github.com/repos/goatslacker/alt/assignees{/user}","branches_url":"https://api.github.com/repos/goatslacker/alt/branches{/branch}","tags_url":"https://api.github.com/repos/goatslacker/alt/tags","blobs_url":"https://api.github.com/repos/goatslacker/alt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goatslacker/alt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goatslacker/alt/git/refs{/sha}","trees_url":"https://api.github.com/repos/goatslacker/alt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goatslacker/alt/statuses/{sha}","languages_url":"https://api.github.com/repos/goatslacker/alt/languages","stargazers_url":"https://api.github.com/repos/goatslacker/alt/stargazers","contributors_url":"https://api.github.com/repos/goatslacker/alt/contributors","subscribers_url":"https://api.github.com/repos/goatslacker/alt/subscribers","subscription_url":"https://api.github.com/repos/goatslacker/alt/subscription","commits_url":"https://api.github.com/repos/goatslacker/alt/commits{/sha}","git_commits_url":"https://api.github.com/repos/goatslacker/alt/git/commits{/sha}","comments_url":"https://api.github.com/repos/goatslacker/alt/comments{/number}","issue_comment_url":"https://api.github.com/repos/goatslacker/alt/issues/comments{/number}","contents_url":"https://api.github.com/repos/goatslacker/alt/contents/{+path}","compare_url":"https://api.github.com/repos/goatslacker/alt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goatslacker/alt/merges","archive_url":"https://api.github.com/repos/goatslacker/alt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goatslacker/alt/downloads","issues_url":"https://api.github.com/repos/goatslacker/alt/issues{/number}","pulls_url":"https://api.github.com/repos/goatslacker/alt/pulls{/number}","milestones_url":"https://api.github.com/repos/goatslacker/alt/milestones{/number}","notifications_url":"https://api.github.com/repos/goatslacker/alt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goatslacker/alt/labels{/name}","releases_url":"https://api.github.com/repos/goatslacker/alt/releases{/id}","created_at":"2014-12-19T09:44:04Z","updated_at":"2015-03-31T17:35:44Z","pushed_at":"2015-03-31T13:44:47Z","git_url":"git://github.com/goatslacker/alt.git","ssh_url":"git@github.com:goatslacker/alt.git","clone_url":"https://github.com/goatslacker/alt.git","svn_url":"https://github.com/goatslacker/alt","homepage":"http://goatslacker.github.io/alt/","size":2759,"stargazers_count":575,"watchers_count":575,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":39,"mirror_url":null,"open_issues_count":17,"forks":39,"open_issues":17,"watchers":575,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/goatslacker/alt/pulls/116"},"html":{"href":"https://github.com/goatslacker/alt/pull/116"},"issue":{"href":"https://api.github.com/repos/goatslacker/alt/issues/116"},"comments":{"href":"https://api.github.com/repos/goatslacker/alt/issues/116/comments"},"review_comments":{"href":"https://api.github.com/repos/goatslacker/alt/pulls/116/comments"},"review_comment":{"href":"https://api.github.com/repos/goatslacker/alt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/goatslacker/alt/pulls/116/commits"},"statuses":{"href":"https://api.github.com/repos/goatslacker/alt/statuses/6e692a452f06346463fce911a75ad72cc5127480"}}}}