{"action":"created","issue":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859","labels_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859/labels{/name}","comments_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859/comments","events_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859/events","html_url":"https://github.com/cfpb/cfgov-refresh/pull/859","id":99664852,"number":859,"title":"DF-2320 - Sauce Labs for legacy browsers, updated test flow","user":{"login":"anselmbradford","id":704760,"avatar_url":"https://avatars.githubusercontent.com/u/704760?v=3","gravatar_id":"","url":"https://api.github.com/users/anselmbradford","html_url":"https://github.com/anselmbradford","followers_url":"https://api.github.com/users/anselmbradford/followers","following_url":"https://api.github.com/users/anselmbradford/following{/other_user}","gists_url":"https://api.github.com/users/anselmbradford/gists{/gist_id}","starred_url":"https://api.github.com/users/anselmbradford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anselmbradford/subscriptions","organizations_url":"https://api.github.com/users/anselmbradford/orgs","repos_url":"https://api.github.com/users/anselmbradford/repos","events_url":"https://api.github.com/users/anselmbradford/events{/privacy}","received_events_url":"https://api.github.com/users/anselmbradford/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-08-07T15:00:53Z","updated_at":"2015-08-12T17:21:45Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/pulls/859","html_url":"https://github.com/cfpb/cfgov-refresh/pull/859","diff_url":"https://github.com/cfpb/cfgov-refresh/pull/859.diff","patch_url":"https://github.com/cfpb/cfgov-refresh/pull/859.patch"},"body":"Creates browser test suites for essentials, legacy, and modern browsers and sets it up so only essentials runs locally and full suite runs on Sauce.\r\n\r\n## Additions\r\n\r\n- Added `gulp test:unit` and `gulp test:acceptance` tasks for test stages.\r\n\r\n## Changes\r\n\r\n- Added copying of `.env_SAMPLE` to `.env` part of `setup.sh`.\r\n- Moved console output messages to the end of the `setup.sh` `init` method.\r\n- Organized `.env_SAMPLE` and made `.env` executable on its own.\r\n- Added `HTTP_HOST`, `HTTP_PORT`, `SELENIUM_URL`, `SAUCE_USERNAME`,\r\n  `SAUCE_ACCESS_KEY`, `SAUCE_SELENIUM_URL`, `USE_SAUCE`, and `VIRTUAL_ENV`\r\n  constants to `.env_SAMPLE`.\r\n- Moved aggregate `gulp lint` task to bottom of file to avoid duplicate\r\n  lint task entries in `gulp --tasks`.\r\n- Renamed `gulp lint:src` to `gulp lint:js` to future-proof type of linting.\r\n- Renamed `gulp test:macro` to `gulp test:unit:macro`.\r\n- Renamed `gulp test:processor` to `gulp test:unit:processor`.\r\n- Renamed `gulp test:browser` to `gulp test:acceptance:browser`.\r\n- Edited `INSTALL.md` to accommodate changes in `.env_SAMPLE`.\r\n- Edited Protractor configuration to include browser groups,\r\n  which by default only run the essentials locally, but the full suite\r\n  (including legacy browsers) on Sauce Labs when Sauce credentials are present.\r\n- Updates test instructions to use the gulp test subtasks.\r\n- Updated Travis CI settings to use `setup.sh`.\r\n\r\n## Testing\r\n\r\n- Follow instructions in `TEST.md`.\r\n\r\n## Review\r\n\r\n- @KimberlyMunoz \r\n- @sebworks \r\n- @dpford \r\n\r\n## Screenshots\r\n\r\n![screen shot 2015-08-07 at 10 59 23 am](https://cloud.githubusercontent.com/assets/704760/9138701/67b56084-3cf3-11e5-844b-26a47bcbe878.png)\r\n\r\n\r\n## Todos\r\n\r\n- Pass-through Protractor command-line flags to `gulp test:acceptance:browser`, in particular the `specs=` flag.\r\n- Sauce Labs tests will sometimes time out. I've set the timeout to the max amount, so not sure what to do about that. But the tests can always be run locally. (EDIT: protractor timeout guidance https://angular.github.io/protractor/#/timeouts)"},"comment":{"url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/comments/130381330","html_url":"https://github.com/cfpb/cfgov-refresh/pull/859#issuecomment-130381330","issue_url":"https://api.github.com/repos/cfpb/cfgov-refresh/issues/859","id":130381330,"user":{"login":"KimberlyMunoz","id":1860176,"avatar_url":"https://avatars.githubusercontent.com/u/1860176?v=3","gravatar_id":"","url":"https://api.github.com/users/KimberlyMunoz","html_url":"https://github.com/KimberlyMunoz","followers_url":"https://api.github.com/users/KimberlyMunoz/followers","following_url":"https://api.github.com/users/KimberlyMunoz/following{/other_user}","gists_url":"https://api.github.com/users/KimberlyMunoz/gists{/gist_id}","starred_url":"https://api.github.com/users/KimberlyMunoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KimberlyMunoz/subscriptions","organizations_url":"https://api.github.com/users/KimberlyMunoz/orgs","repos_url":"https://api.github.com/users/KimberlyMunoz/repos","events_url":"https://api.github.com/users/KimberlyMunoz/events{/privacy}","received_events_url":"https://api.github.com/users/KimberlyMunoz/received_events","type":"User","site_admin":false},"created_at":"2015-08-12T17:21:45Z","updated_at":"2015-08-12T17:21:45Z","body":"These tests look so nice! I'm just getting a few linting errors, but other than that it looks amazing.\r\n\r\n![image](https://cloud.githubusercontent.com/assets/1860176/9231136/7ef508f8-40f4-11e5-81a7-324b1a91f315.png)\r\n\r\n![andy-confetti-gif](https://cloud.githubusercontent.com/assets/1860176/9231225/11702f0a-40f5-11e5-9d51-4f83044aa819.gif)\r\n\r\n"}}