{"action":"created","comment":{"url":"https://api.github.com/repos/docker/docker/pulls/comments/35286069","id":35286069,"diff_hunk":"@@ -58,14 +60,18 @@ type Root struct {\n \tvolumes map[string]*Volume\n }\n \n+// DataPath returns the constructed path of this volume.\n func (r *Root) DataPath(volumeName string) string {\n \treturn filepath.Join(r.path, volumeName, VolumeDataPathName)\n }\n \n+// Name returns name of this (driver?)","path":"volume/local/local.go","position":25,"original_position":25,"commit_id":"0585e766b42a545e96aa48cbd5499abfe8bee178","original_commit_id":"0585e766b42a545e96aa48cbd5499abfe8bee178","user":{"login":"cpuguy83","id":799078,"avatar_url":"https://avatars.githubusercontent.com/u/799078?v=3","gravatar_id":"","url":"https://api.github.com/users/cpuguy83","html_url":"https://github.com/cpuguy83","followers_url":"https://api.github.com/users/cpuguy83/followers","following_url":"https://api.github.com/users/cpuguy83/following{/other_user}","gists_url":"https://api.github.com/users/cpuguy83/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuguy83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuguy83/subscriptions","organizations_url":"https://api.github.com/users/cpuguy83/orgs","repos_url":"https://api.github.com/users/cpuguy83/repos","events_url":"https://api.github.com/users/cpuguy83/events{/privacy}","received_events_url":"https://api.github.com/users/cpuguy83/received_events","type":"User","site_admin":false},"body":"Name returns the name of Root, defined in the volume package in the `DefaultDriverName` constant.","created_at":"2015-07-23T02:44:31Z","updated_at":"2015-07-23T02:44:31Z","html_url":"https://github.com/docker/docker/pull/14818#discussion_r35286069","pull_request_url":"https://api.github.com/repos/docker/docker/pulls/14818","_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/comments/35286069"},"html":{"href":"https://github.com/docker/docker/pull/14818#discussion_r35286069"},"pull_request":{"href":"https://api.github.com/repos/docker/docker/pulls/14818"}}},"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/14818","id":40486032,"html_url":"https://github.com/docker/docker/pull/14818","diff_url":"https://github.com/docker/docker/pull/14818.diff","patch_url":"https://github.com/docker/docker/pull/14818.patch","issue_url":"https://api.github.com/repos/docker/docker/issues/14818","number":14818,"state":"open","locked":false,"title":"lint for volume/*","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"I am not familiar enough with volumes to understand totally what is going on in detail.\r\n\r\nI need more expert eyes to make sure these are factual sentences.\r\n\r\nfor #14756 ","created_at":"2015-07-21T18:00:06Z","updated_at":"2015-07-23T02:44:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"838bfc23a953a0a8603e0454354efbd0e5224765","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/docker/pulls/14818/commits","review_comments_url":"https://api.github.com/repos/docker/docker/pulls/14818/comments","review_comment_url":"https://api.github.com/repos/docker/docker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/docker/issues/14818/comments","statuses_url":"https://api.github.com/repos/docker/docker/statuses/0585e766b42a545e96aa48cbd5499abfe8bee178","head":{"label":"MHBauer:volume-lint","ref":"volume-lint","sha":"0585e766b42a545e96aa48cbd5499abfe8bee178","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"repo":{"id":39091680,"name":"docker","full_name":"MHBauer/docker","owner":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MHBauer/docker","description":"Docker - the open-source application container engine","fork":true,"url":"https://api.github.com/repos/MHBauer/docker","forks_url":"https://api.github.com/repos/MHBauer/docker/forks","keys_url":"https://api.github.com/repos/MHBauer/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MHBauer/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MHBauer/docker/teams","hooks_url":"https://api.github.com/repos/MHBauer/docker/hooks","issue_events_url":"https://api.github.com/repos/MHBauer/docker/issues/events{/number}","events_url":"https://api.github.com/repos/MHBauer/docker/events","assignees_url":"https://api.github.com/repos/MHBauer/docker/assignees{/user}","branches_url":"https://api.github.com/repos/MHBauer/docker/branches{/branch}","tags_url":"https://api.github.com/repos/MHBauer/docker/tags","blobs_url":"https://api.github.com/repos/MHBauer/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MHBauer/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MHBauer/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/MHBauer/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MHBauer/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/MHBauer/docker/languages","stargazers_url":"https://api.github.com/repos/MHBauer/docker/stargazers","contributors_url":"https://api.github.com/repos/MHBauer/docker/contributors","subscribers_url":"https://api.github.com/repos/MHBauer/docker/subscribers","subscription_url":"https://api.github.com/repos/MHBauer/docker/subscription","commits_url":"https://api.github.com/repos/MHBauer/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/MHBauer/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/MHBauer/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/MHBauer/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/MHBauer/docker/contents/{+path}","compare_url":"https://api.github.com/repos/MHBauer/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MHBauer/docker/merges","archive_url":"https://api.github.com/repos/MHBauer/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MHBauer/docker/downloads","issues_url":"https://api.github.com/repos/MHBauer/docker/issues{/number}","pulls_url":"https://api.github.com/repos/MHBauer/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/MHBauer/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/MHBauer/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MHBauer/docker/labels{/name}","releases_url":"https://api.github.com/repos/MHBauer/docker/releases{/id}","created_at":"2015-07-14T18:02:26Z","updated_at":"2015-07-14T18:02:34Z","pushed_at":"2015-07-22T17:27:39Z","git_url":"git://github.com/MHBauer/docker.git","ssh_url":"git@github.com:MHBauer/docker.git","clone_url":"https://github.com/MHBauer/docker.git","svn_url":"https://github.com/MHBauer/docker","homepage":"http://www.docker.com","size":62251,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"ff011ededba4b51c047a9f8d27c7c5c327494c0d","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":7691631,"name":"docker","full_name":"docker/docker","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/docker","description":"Docker - the open-source application container engine","fork":false,"url":"https://api.github.com/repos/docker/docker","forks_url":"https://api.github.com/repos/docker/docker/forks","keys_url":"https://api.github.com/repos/docker/docker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/docker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/docker/teams","hooks_url":"https://api.github.com/repos/docker/docker/hooks","issue_events_url":"https://api.github.com/repos/docker/docker/issues/events{/number}","events_url":"https://api.github.com/repos/docker/docker/events","assignees_url":"https://api.github.com/repos/docker/docker/assignees{/user}","branches_url":"https://api.github.com/repos/docker/docker/branches{/branch}","tags_url":"https://api.github.com/repos/docker/docker/tags","blobs_url":"https://api.github.com/repos/docker/docker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/docker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/docker/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/docker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/docker/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/docker/languages","stargazers_url":"https://api.github.com/repos/docker/docker/stargazers","contributors_url":"https://api.github.com/repos/docker/docker/contributors","subscribers_url":"https://api.github.com/repos/docker/docker/subscribers","subscription_url":"https://api.github.com/repos/docker/docker/subscription","commits_url":"https://api.github.com/repos/docker/docker/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/docker/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/docker/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/docker/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/docker/contents/{+path}","compare_url":"https://api.github.com/repos/docker/docker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/docker/merges","archive_url":"https://api.github.com/repos/docker/docker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/docker/downloads","issues_url":"https://api.github.com/repos/docker/docker/issues{/number}","pulls_url":"https://api.github.com/repos/docker/docker/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/docker/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/docker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/docker/labels{/name}","releases_url":"https://api.github.com/repos/docker/docker/releases{/id}","created_at":"2013-01-18T18:10:57Z","updated_at":"2015-07-23T02:43:09Z","pushed_at":"2015-07-23T02:31:59Z","git_url":"git://github.com/docker/docker.git","ssh_url":"git@github.com:docker/docker.git","clone_url":"https://github.com/docker/docker.git","svn_url":"https://github.com/docker/docker","homepage":"http://www.docker.com","size":230214,"stargazers_count":23473,"watchers_count":23473,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5855,"mirror_url":null,"open_issues_count":1039,"forks":5855,"open_issues":1039,"watchers":23473,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/docker/pulls/14818"},"html":{"href":"https://github.com/docker/docker/pull/14818"},"issue":{"href":"https://api.github.com/repos/docker/docker/issues/14818"},"comments":{"href":"https://api.github.com/repos/docker/docker/issues/14818/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/docker/pulls/14818/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/docker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/docker/pulls/14818/commits"},"statuses":{"href":"https://api.github.com/repos/docker/docker/statuses/0585e766b42a545e96aa48cbd5499abfe8bee178"}}}}