{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/23052343","id":23052343,"diff_hunk":"@@ -24,57 +24,64 @@ internal TagHelperOutput(string tagName)\n             Attributes = new Dictionary<string, string>(StringComparer.OrdinalIgnoreCase);\n         }\n \n-        // Internal for testing\n-        internal TagHelperOutput(string tagName, [NotNull] IDictionary<string, string> attributes)\n-            : this(tagName, attributes, string.Empty)\n-        {\n-        }\n-\n         /// <summary>\n         /// Instantiates a new instance of <see cref=\"TagHelperOutput\"/>.\n         /// </summary>\n         /// <param name=\"tagName\">The HTML element's tag name.</param>\n         /// <param name=\"attributes\">The HTML attributes.</param>\n-        /// <param name=\"content\">The HTML element's content.</param>\n-        public TagHelperOutput(string tagName,\n-                               [NotNull] IDictionary<string, string> attributes,\n-                               string content)\n+        public TagHelperOutput(string tagName, [NotNull] IDictionary<string, string> attributes)\n         {\n             TagName = tagName;\n-            Content = content;\n             Attributes = new Dictionary<string, string>(attributes, StringComparer.OrdinalIgnoreCase);\n+            PreContent = string.Empty;\n+            _content = string.Empty;\n+            PostContent = string.Empty;\n         }\n \n         /// <summary>\n         /// The HTML element's tag name.\n         /// </summary>\n         /// <remarks>\n-        /// A whitespace value results in no start or end tag being rendered.\n+        /// A whitespace or <c>null</c> value results in no start or end tag being rendered.\n         /// </remarks>\n-        public string TagName\n+        public string TagName { get; set; }\n+\n+        /// <summary>\n+        /// The HTML element's pre content.\n+        /// </summary>\n+        /// <remarks>Value is prepended to the <see cref=\"ITagHelper\"/>'s final output.</remarks>\n+        public string PreContent { get; set; }\n+\n+        /// <summary>\n+        /// The HTML element's content.\n+        /// </summary>\n+        public string Content\n         {\n             get\n             {\n-                return _tagName;\n+                return _content;\n             }\n             set\n             {\n-                _tagName = value ?? string.Empty;\n+                _contentSet = true;\n+                _content = value;\n             }\n         }\n \n         /// <summary>\n-        /// The HTML element's content.\n+        /// The HTML element's post content.\n         /// </summary>\n-        public string Content\n+        /// <remarks>Value is prepended to the <see cref=\"ITagHelper\"/>'s final output.</remarks>","path":"src/Microsoft.AspNet.Razor.Runtime/TagHelpers/TagHelperOutput.cs","position":77,"original_position":77,"commit_id":"ecb33db14580cbf9155e1988e7e6849c34085cd2","original_commit_id":"ecb33db14580cbf9155e1988e7e6849c34085cd2","user":{"login":"dougbu","id":6431421,"avatar_url":"https://avatars.githubusercontent.com/u/6431421?v=3","gravatar_id":"","url":"https://api.github.com/users/dougbu","html_url":"https://github.com/dougbu","followers_url":"https://api.github.com/users/dougbu/followers","following_url":"https://api.github.com/users/dougbu/following{/other_user}","gists_url":"https://api.github.com/users/dougbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dougbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dougbu/subscriptions","organizations_url":"https://api.github.com/users/dougbu/orgs","repos_url":"https://api.github.com/users/dougbu/repos","events_url":"https://api.github.com/users/dougbu/events{/privacy}","received_events_url":"https://api.github.com/users/dougbu/received_events","type":"User","site_admin":false},"body":"prepended -> appended","created_at":"2015-01-15T23:15:09Z","updated_at":"2015-01-15T23:15:09Z","html_url":"https://github.com/aspnet/Razor/pull/261#discussion_r23052343","pull_request_url":"https://api.github.com/repos/aspnet/Razor/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/23052343"},"html":{"href":"https://github.com/aspnet/Razor/pull/261#discussion_r23052343"},"pull_request":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/Razor/pulls/261","id":26486114,"html_url":"https://github.com/aspnet/Razor/pull/261","diff_url":"https://github.com/aspnet/Razor/pull/261.diff","patch_url":"https://github.com/aspnet/Razor/pull/261.patch","issue_url":"https://api.github.com/repos/aspnet/Razor/issues/261","number":261,"state":"open","locked":false,"title":"Redesign TagHelper content modes.","user":{"login":"NTaylorMullen","id":2008729,"avatar_url":"https://avatars.githubusercontent.com/u/2008729?v=3","gravatar_id":"","url":"https://api.github.com/users/NTaylorMullen","html_url":"https://github.com/NTaylorMullen","followers_url":"https://api.github.com/users/NTaylorMullen/followers","following_url":"https://api.github.com/users/NTaylorMullen/following{/other_user}","gists_url":"https://api.github.com/users/NTaylorMullen/gists{/gist_id}","starred_url":"https://api.github.com/users/NTaylorMullen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NTaylorMullen/subscriptions","organizations_url":"https://api.github.com/users/NTaylorMullen/orgs","repos_url":"https://api.github.com/users/NTaylorMullen/repos","events_url":"https://api.github.com/users/NTaylorMullen/events{/privacy}","received_events_url":"https://api.github.com/users/NTaylorMullen/received_events","type":"User","site_admin":false},"body":"**Removed ContentBehavior**\r\n- Removed all tests and instances of ContentBehavior in preparation for moving to a non-ContentBehavior based design.\r\n- Removed ContentBehavior specific CodeGeneration.\r\n\r\n**Re-design TagHelperOutput and runtime dependencies to allow all content modes.**\r\n- Added PreContent, PostContent and ContentSet properties to TagHelperOutput.\r\n- Added GeneratePreContent, GeneratePostContent and SupressOutput methods to TagHelperOutput.\r\n- Added multile ExecuteChildContentAsync and GetChildContentAsync to the rendering phase, ultimately only exposing GetChildContentAsync to a TagHelper author.\r\n- Added more knowledge of StartWritingScope and EndWritingScope to the TagHelper runtime components. This is to enable the runtime components to utilize the RazorPage's infrastructure to render a delegate to a writer and retrieve its value to ultimately expose it to the user.\r\n\r\n**Modify tests to allow new content mode design for runtime components.**\r\n- Added a new internal ctor for TagHelperExecutionContext since it's used in multiple tests to allow for less friction testing.\r\n\r\n**Added CodeGen for TagHelper content mode redesign.**\r\n- Modified the CSharpTagHelperCodeRenderer to understand a single line of TagHelper rendering (instead of doing different things based on ContentBehavior).\r\n- Modified existing CodeGen output to reflect new content changes.\r\n\r\n#221\r\n\r\n/cc @dougbu @pranavkm ","created_at":"2014-12-22T22:50:53Z","updated_at":"2015-01-15T23:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c660eba73a110ec64c4a65426d17841778e8303a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/Razor/pulls/261/commits","review_comments_url":"https://api.github.com/repos/aspnet/Razor/pulls/261/comments","review_comment_url":"https://api.github.com/repos/aspnet/Razor/pulls/comments/{number}","comments_url":"https://api.github.com/repos/aspnet/Razor/issues/261/comments","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/ecb33db14580cbf9155e1988e7e6849c34085cd2","head":{"label":"aspnet:thcontentmode.221","ref":"thcontentmode.221","sha":"ecb33db14580cbf9155e1988e7e6849c34085cd2","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-01-15T16:19:31Z","pushed_at":"2015-01-15T18:55:30Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":5699,"stargazers_count":261,"watchers_count":261,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":71,"forks":56,"open_issues":71,"watchers":261,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"8c47f6a67ecd3da91635c251770a6b872ee33f0b","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":15835991,"name":"Razor","full_name":"aspnet/Razor","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars.githubusercontent.com/u/6476660?v=3","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/Razor","description":"Parser and code generator for CSHTML files used in view pages for MVC web apps.","fork":false,"url":"https://api.github.com/repos/aspnet/Razor","forks_url":"https://api.github.com/repos/aspnet/Razor/forks","keys_url":"https://api.github.com/repos/aspnet/Razor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/Razor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/Razor/teams","hooks_url":"https://api.github.com/repos/aspnet/Razor/hooks","issue_events_url":"https://api.github.com/repos/aspnet/Razor/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/Razor/events","assignees_url":"https://api.github.com/repos/aspnet/Razor/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/Razor/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/Razor/tags","blobs_url":"https://api.github.com/repos/aspnet/Razor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/Razor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/Razor/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/Razor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/Razor/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/Razor/languages","stargazers_url":"https://api.github.com/repos/aspnet/Razor/stargazers","contributors_url":"https://api.github.com/repos/aspnet/Razor/contributors","subscribers_url":"https://api.github.com/repos/aspnet/Razor/subscribers","subscription_url":"https://api.github.com/repos/aspnet/Razor/subscription","commits_url":"https://api.github.com/repos/aspnet/Razor/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/Razor/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/Razor/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/Razor/issues/comments/{number}","contents_url":"https://api.github.com/repos/aspnet/Razor/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/Razor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/Razor/merges","archive_url":"https://api.github.com/repos/aspnet/Razor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/Razor/downloads","issues_url":"https://api.github.com/repos/aspnet/Razor/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/Razor/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/Razor/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/Razor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/Razor/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/Razor/releases{/id}","created_at":"2014-01-12T03:52:46Z","updated_at":"2015-01-15T16:19:31Z","pushed_at":"2015-01-15T18:55:30Z","git_url":"git://github.com/aspnet/Razor.git","ssh_url":"git@github.com:aspnet/Razor.git","clone_url":"https://github.com/aspnet/Razor.git","svn_url":"https://github.com/aspnet/Razor","homepage":"","size":5699,"stargazers_count":261,"watchers_count":261,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"open_issues_count":71,"forks":56,"open_issues":71,"watchers":261,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/261"},"html":{"href":"https://github.com/aspnet/Razor/pull/261"},"issue":{"href":"https://api.github.com/repos/aspnet/Razor/issues/261"},"comments":{"href":"https://api.github.com/repos/aspnet/Razor/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/aspnet/Razor/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/Razor/statuses/ecb33db14580cbf9155e1988e7e6849c34085cd2"}}}}