{"action":"created","issue":{"url":"https://api.github.com/repos/sensu/sensu-puppet/issues/336","labels_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/336/labels{/name}","comments_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/336/comments","events_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/336/events","html_url":"https://github.com/sensu/sensu-puppet/issues/336","id":64309324,"number":336,"title":"sensu::client::config keepalives 'change' every run","user":{"login":"poolski","id":1942093,"avatar_url":"https://avatars.githubusercontent.com/u/1942093?v=3","gravatar_id":"","url":"https://api.github.com/users/poolski","html_url":"https://github.com/poolski","followers_url":"https://api.github.com/users/poolski/followers","following_url":"https://api.github.com/users/poolski/following{/other_user}","gists_url":"https://api.github.com/users/poolski/gists{/gist_id}","starred_url":"https://api.github.com/users/poolski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poolski/subscriptions","organizations_url":"https://api.github.com/users/poolski/orgs","repos_url":"https://api.github.com/users/poolski/repos","events_url":"https://api.github.com/users/poolski/events{/privacy}","received_events_url":"https://api.github.com/users/poolski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":31,"created_at":"2015-03-25T16:12:48Z","updated_at":"2015-06-12T07:50:48Z","closed_at":null,"body":"Every single time I run puppet, the module seems to change my thresholds for keepalive, flapping detection etc as follows. It's not a big deal but it does add time to puppet runs and it's a bit misleading, given no change takes place\r\n\r\n```\r\nNotice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[hostname.example.com]/custom: custom changed 'handlers => [\"default\"]' to 'handlers => [\"default\"], keepalive => {\"high_flap_threshold\"=>20, \"low_flap_threshold\"=>5, \"refresh\"=>14400, \"thresholds\"=>{\"critical\"=>120, \"warning\"=>90}}'\r\nNotice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[hostname.example.com]/keepalive: keepalive changed 'high_flap_threshold => 20, low_flap_threshold => 5, refresh => 14400, thresholds => {\"critical\"=>120, \"warning\"=>90}' to ''\r\n```"},"comment":{"url":"https://api.github.com/repos/sensu/sensu-puppet/issues/comments/111397489","html_url":"https://github.com/sensu/sensu-puppet/issues/336#issuecomment-111397489","issue_url":"https://api.github.com/repos/sensu/sensu-puppet/issues/336","id":111397489,"user":{"login":"jcustenborder","id":209792,"avatar_url":"https://avatars.githubusercontent.com/u/209792?v=3","gravatar_id":"","url":"https://api.github.com/users/jcustenborder","html_url":"https://github.com/jcustenborder","followers_url":"https://api.github.com/users/jcustenborder/followers","following_url":"https://api.github.com/users/jcustenborder/following{/other_user}","gists_url":"https://api.github.com/users/jcustenborder/gists{/gist_id}","starred_url":"https://api.github.com/users/jcustenborder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcustenborder/subscriptions","organizations_url":"https://api.github.com/users/jcustenborder/orgs","repos_url":"https://api.github.com/users/jcustenborder/repos","events_url":"https://api.github.com/users/jcustenborder/events{/privacy}","received_events_url":"https://api.github.com/users/jcustenborder/received_events","type":"User","site_admin":false},"created_at":"2015-06-12T07:50:48Z","updated_at":"2015-06-12T07:50:48Z","body":"I'm seeing similar behavior with 3.7.5. \r\n\r\n```\r\ncat client.json \r\n{\r\n  \"client\": {\r\n    \"address\": \"10.10.0.222\",\r\n    \"name\": \"sensu-server.elysium.home\",\r\n    \"subscriptions\": [\r\n\r\n    ],\r\n    \"bind\": \"127.0.0.1\",\r\n    \"safe_mode\": false,\r\n    \"keepalive\": {\r\n    }\r\n  }\r\n}\r\n```\r\n\r\n```\r\npuppet agent --test\r\n...\r\nNotice: /Stage[main]/Sensu::Redis::Config/Sensu_redis_config[sensu-server.elysium.home]/reconnect_on_error: reconnect_on_error changed 'true' to 'false'\r\nInfo: Class[Sensu::Redis::Config]: Scheduling refresh of Service[sensu-api]\r\nInfo: Class[Sensu::Redis::Config]: Scheduling refresh of Service[sensu-server]\r\nNotice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[sensu-server.elysium.home]/port: port changed '' to '3030'\r\nInfo: Class[Sensu::Client::Config]: Scheduling refresh of Service[sensu-client]\r\nNotice: /Stage[main]/Sensu::Client::Service/Service[sensu-client]: Triggered 'refresh' from 1 events\r\nNotice: /Stage[main]/Sensu::Api::Service/Service[sensu-api]: Triggered 'refresh' from 1 events\r\nNotice: /Stage[main]/Sensu::Server::Service/Service[sensu-server]: Triggered 'refresh' from 1 events\r\n```\r\n\r\n```\r\n{\r\n  \"client\": {\r\n    \"name\": \"sensu-server.elysium.home\",\r\n    \"safe_mode\": false,\r\n    \"address\": \"10.10.0.222\",\r\n    \"port\": \"3030\",\r\n    \"subscriptions\": [\r\n\r\n    ],\r\n    \"bind\": \"127.0.0.1\",\r\n    \"keepalive\": {\r\n    }\r\n  }\r\n}\r\n```\r\n\r\n```\r\npuppet agent --test\r\n...\r\nNotice: /Stage[main]/Sensu::Redis::Config/Sensu_redis_config[sensu-server.elysium.home]/reconnect_on_error: reconnect_on_error changed 'true' to 'false'\r\nInfo: Class[Sensu::Redis::Config]: Scheduling refresh of Service[sensu-server]\r\nInfo: Class[Sensu::Redis::Config]: Scheduling refresh of Service[sensu-api]\r\nNotice: /Stage[main]/Sensu::Client::Config/Sensu_client_config[sensu-server.elysium.home]/custom: custom changed 'port => 3030' to ''\r\nInfo: Class[Sensu::Client::Config]: Scheduling refresh of Service[sensu-client]\r\nNotice: /Stage[main]/Sensu::Client::Service/Service[sensu-client]: Triggered 'refresh' from 1 events\r\nNotice: /Stage[main]/Sensu::Api::Service/Service[sensu-api]: Triggered 'refresh' from 1 events\r\nNotice: /Stage[main]/Sensu::Server::Service/Service[sensu-server]: Triggered 'refresh' from 1 events\r\n```\r\n\r\n```\r\ncat client.json \r\n{\r\n  \"client\": {\r\n    \"subscriptions\": [\r\n\r\n    ],\r\n    \"keepalive\": {\r\n    },\r\n    \"bind\": \"127.0.0.1\",\r\n    \"address\": \"10.10.0.222\",\r\n    \"safe_mode\": false,\r\n    \"name\": \"sensu-server.elysium.home\"\r\n  }\r\n}\r\n```\r\n\r\nIt's dropping some of the properties between each run. Notice the missing port between runs. All runs were with the same version."}}