{"action":"created","issue":{"url":"https://api.github.com/repos/lmtri1991/MovieApp/issues/1","labels_url":"https://api.github.com/repos/lmtri1991/MovieApp/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/lmtri1991/MovieApp/issues/1/comments","events_url":"https://api.github.com/repos/lmtri1991/MovieApp/issues/1/events","html_url":"https://github.com/lmtri1991/MovieApp/issues/1","id":117046640,"number":1,"title":"Submission","user":{"login":"chug2k","id":44512,"avatar_url":"https://avatars.githubusercontent.com/u/44512?v=3","gravatar_id":"","url":"https://api.github.com/users/chug2k","html_url":"https://github.com/chug2k","followers_url":"https://api.github.com/users/chug2k/followers","following_url":"https://api.github.com/users/chug2k/following{/other_user}","gists_url":"https://api.github.com/users/chug2k/gists{/gist_id}","starred_url":"https://api.github.com/users/chug2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chug2k/subscriptions","organizations_url":"https://api.github.com/users/chug2k/orgs","repos_url":"https://api.github.com/users/chug2k/repos","events_url":"https://api.github.com/users/chug2k/events{/privacy}","received_events_url":"https://api.github.com/users/chug2k/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-16T03:49:25Z","updated_at":"2015-11-19T04:03:39Z","closed_at":null,"body":"/cc @coderschoolreview"},"comment":{"url":"https://api.github.com/repos/lmtri1991/MovieApp/issues/comments/157944800","html_url":"https://github.com/lmtri1991/MovieApp/issues/1#issuecomment-157944800","issue_url":"https://api.github.com/repos/lmtri1991/MovieApp/issues/1","id":157944800,"user":{"login":"coderschoolreview","id":15702670,"avatar_url":"https://avatars.githubusercontent.com/u/15702670?v=3","gravatar_id":"","url":"https://api.github.com/users/coderschoolreview","html_url":"https://github.com/coderschoolreview","followers_url":"https://api.github.com/users/coderschoolreview/followers","following_url":"https://api.github.com/users/coderschoolreview/following{/other_user}","gists_url":"https://api.github.com/users/coderschoolreview/gists{/gist_id}","starred_url":"https://api.github.com/users/coderschoolreview/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coderschoolreview/subscriptions","organizations_url":"https://api.github.com/users/coderschoolreview/orgs","repos_url":"https://api.github.com/users/coderschoolreview/repos","events_url":"https://api.github.com/users/coderschoolreview/events{/privacy}","received_events_url":"https://api.github.com/users/coderschoolreview/received_events","type":"User","site_admin":false},"created_at":"2015-11-19T04:03:39Z","updated_at":"2015-11-19T04:03:39Z","body":":+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. You learned about UITableViews, custom UITableViewCells, navigation from a UITableView, and basic networking.\r\n\r\n## Grading Summary:\r\n* **Functionality**: Needs Improvement\r\n* **Code Style**: Needs Improvement\r\n* **Visual Design**: Average\r\n* **Usability**: Good\r\n\r\n* **Overall**: Needs Improvement\r\n\r\nYou and @konnguyen have very similar code, so my comments will be very similar.. Both of you definitely copied and pasted the Reachability code.\r\n\r\nYou did not correctly fulfill the homework requirements. From the homework:\r\n> User sees error message when there's a networking error. You may not use UIAlertView or a 3rd party library to display the error. \r\n\r\nImportant: You used UIAlertView. **Please revise to not use UIAlertView.** \r\n\r\n* Be sure to follow the Swift code styling conventions for the homework. . Please read this style guide for more detail. Style is important! ` func getData(){` should be `func getData() {`, and please fix compiler warnings about `!`.\r\n   - [Ray Wenderlich Swift Style Guide](https://github.com/raywenderlich/swift-style-guide)\r\n* Your custom Movie cell should have a property called `movie`. In the custom setter of `movie`, you should configure the various labels and images. This decouples your custom cells from the table view controllers.\r\n* Nice work loading the images asynchronously. However, you should load the \"detailed\" poster in the MoveDetailsViewController, not the thumbnail.\r\n* Nice work setting up the proper modes for the images so that they are not stretched.\r\n* Nice job keeping things nice and aligned on a grid. That helps the application look cleaner and make it easier for the user to find the correct information. For a lot more information, you can read [Design tips for iOS9](https://designcode.io/iosdesign-guidelines). \r\n\r\n  > To use alignment properly, imagine there are evenly-spaced vertical lines running through the entire length of the design. Both the left and right edges of every single item should fall along these lines, which designers call a grid.\r\n\r\n  > You want to align as many items as possible along the same grid lines. Instead of looking at layout like the game Tetris, where the goal is to fill every available space, try to arrange elements in neat columns.\r\n\r\n![alignment](http://i.imgur.com/Nv3QunL.png)\r\n\r\nHomework is the core part of this class. Through the homework assignments you'll create real apps that you should be proud to show anybody. The more time you spend, the better your portfolio will be and the more you will learn. Try to spend a little more time next week! "}}