{"action":"opened","number":3556,"pull_request":{"url":"https://api.github.com/repos/netty/netty/pulls/3556","id":32262372,"html_url":"https://github.com/netty/netty/pull/3556","diff_url":"https://github.com/netty/netty/pull/3556.diff","patch_url":"https://github.com/netty/netty/pull/3556.patch","issue_url":"https://api.github.com/repos/netty/netty/issues/3556","number":3556,"state":"open","locked":false,"title":"Always fire interestChanged from IO thread","user":{"login":"huguesb","id":7319881,"avatar_url":"https://avatars.githubusercontent.com/u/7319881?v=3","gravatar_id":"","url":"https://api.github.com/users/huguesb","html_url":"https://github.com/huguesb","followers_url":"https://api.github.com/users/huguesb/followers","following_url":"https://api.github.com/users/huguesb/following{/other_user}","gists_url":"https://api.github.com/users/huguesb/gists{/gist_id}","starred_url":"https://api.github.com/users/huguesb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huguesb/subscriptions","organizations_url":"https://api.github.com/users/huguesb/orgs","repos_url":"https://api.github.com/users/huguesb/repos","events_url":"https://api.github.com/users/huguesb/events{/privacy}","received_events_url":"https://api.github.com/users/huguesb/received_events","type":"User","site_admin":false},"body":"Motivation:\r\n\r\nThe documented thread model stipulates that all\r\nupstream events should be fired from the IO thread,\r\nwhich is crucial to avoid race conditions.\r\n\r\nSee #3546\r\n\r\nModifications:\r\n\r\nChange AbstractNioChannel.WriteQueue to check if\r\nthe current thread is the IO thread of the worker\r\nand call fireInterestChangedLater accordingly.\r\n\r\nResult:\r\n\r\ninterestChanged event is always fired from IO\r\nthread of channel thus honoring the documented\r\nthread model and fixing race conditions.","created_at":"2015-03-30T20:10:48Z","updated_at":"2015-03-30T20:10:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/netty/netty/pulls/3556/commits","review_comments_url":"https://api.github.com/repos/netty/netty/pulls/3556/comments","review_comment_url":"https://api.github.com/repos/netty/netty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netty/netty/issues/3556/comments","statuses_url":"https://api.github.com/repos/netty/netty/statuses/f3aa4a78353cbb372deafd644d8879bff9afef79","head":{"label":"aerofs:fix-interest-ops-thread-model","ref":"fix-interest-ops-thread-model","sha":"f3aa4a78353cbb372deafd644d8879bff9afef79","user":{"login":"aerofs","id":1200824,"avatar_url":"https://avatars.githubusercontent.com/u/1200824?v=3","gravatar_id":"","url":"https://api.github.com/users/aerofs","html_url":"https://github.com/aerofs","followers_url":"https://api.github.com/users/aerofs/followers","following_url":"https://api.github.com/users/aerofs/following{/other_user}","gists_url":"https://api.github.com/users/aerofs/gists{/gist_id}","starred_url":"https://api.github.com/users/aerofs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerofs/subscriptions","organizations_url":"https://api.github.com/users/aerofs/orgs","repos_url":"https://api.github.com/users/aerofs/repos","events_url":"https://api.github.com/users/aerofs/events{/privacy}","received_events_url":"https://api.github.com/users/aerofs/received_events","type":"Organization","site_admin":false},"repo":{"id":33016859,"name":"netty","full_name":"aerofs/netty","owner":{"login":"aerofs","id":1200824,"avatar_url":"https://avatars.githubusercontent.com/u/1200824?v=3","gravatar_id":"","url":"https://api.github.com/users/aerofs","html_url":"https://github.com/aerofs","followers_url":"https://api.github.com/users/aerofs/followers","following_url":"https://api.github.com/users/aerofs/following{/other_user}","gists_url":"https://api.github.com/users/aerofs/gists{/gist_id}","starred_url":"https://api.github.com/users/aerofs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerofs/subscriptions","organizations_url":"https://api.github.com/users/aerofs/orgs","repos_url":"https://api.github.com/users/aerofs/repos","events_url":"https://api.github.com/users/aerofs/events{/privacy}","received_events_url":"https://api.github.com/users/aerofs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerofs/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":true,"url":"https://api.github.com/repos/aerofs/netty","forks_url":"https://api.github.com/repos/aerofs/netty/forks","keys_url":"https://api.github.com/repos/aerofs/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerofs/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerofs/netty/teams","hooks_url":"https://api.github.com/repos/aerofs/netty/hooks","issue_events_url":"https://api.github.com/repos/aerofs/netty/issues/events{/number}","events_url":"https://api.github.com/repos/aerofs/netty/events","assignees_url":"https://api.github.com/repos/aerofs/netty/assignees{/user}","branches_url":"https://api.github.com/repos/aerofs/netty/branches{/branch}","tags_url":"https://api.github.com/repos/aerofs/netty/tags","blobs_url":"https://api.github.com/repos/aerofs/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerofs/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerofs/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerofs/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerofs/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/aerofs/netty/languages","stargazers_url":"https://api.github.com/repos/aerofs/netty/stargazers","contributors_url":"https://api.github.com/repos/aerofs/netty/contributors","subscribers_url":"https://api.github.com/repos/aerofs/netty/subscribers","subscription_url":"https://api.github.com/repos/aerofs/netty/subscription","commits_url":"https://api.github.com/repos/aerofs/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerofs/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerofs/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerofs/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerofs/netty/contents/{+path}","compare_url":"https://api.github.com/repos/aerofs/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerofs/netty/merges","archive_url":"https://api.github.com/repos/aerofs/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerofs/netty/downloads","issues_url":"https://api.github.com/repos/aerofs/netty/issues{/number}","pulls_url":"https://api.github.com/repos/aerofs/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/aerofs/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/aerofs/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerofs/netty/labels{/name}","releases_url":"https://api.github.com/repos/aerofs/netty/releases{/id}","created_at":"2015-03-28T01:25:59Z","updated_at":"2015-03-28T01:26:09Z","pushed_at":"2015-03-30T20:07:25Z","git_url":"git://github.com/aerofs/netty.git","ssh_url":"git@github.com:aerofs/netty.git","clone_url":"https://github.com/aerofs/netty.git","svn_url":"https://github.com/aerofs/netty","homepage":"http://netty.io/","size":40240,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"netty:3.10","ref":"3.10","sha":"2f4693d18801368e76f2d4ca3a407be1bb938618","user":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"repo":{"id":1064563,"name":"netty","full_name":"netty/netty","owner":{"login":"netty","id":473791,"avatar_url":"https://avatars.githubusercontent.com/u/473791?v=3","gravatar_id":"","url":"https://api.github.com/users/netty","html_url":"https://github.com/netty","followers_url":"https://api.github.com/users/netty/followers","following_url":"https://api.github.com/users/netty/following{/other_user}","gists_url":"https://api.github.com/users/netty/gists{/gist_id}","starred_url":"https://api.github.com/users/netty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netty/subscriptions","organizations_url":"https://api.github.com/users/netty/orgs","repos_url":"https://api.github.com/users/netty/repos","events_url":"https://api.github.com/users/netty/events{/privacy}","received_events_url":"https://api.github.com/users/netty/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netty/netty","description":"Netty project - an event-driven asynchronous network application framework","fork":false,"url":"https://api.github.com/repos/netty/netty","forks_url":"https://api.github.com/repos/netty/netty/forks","keys_url":"https://api.github.com/repos/netty/netty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netty/netty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netty/netty/teams","hooks_url":"https://api.github.com/repos/netty/netty/hooks","issue_events_url":"https://api.github.com/repos/netty/netty/issues/events{/number}","events_url":"https://api.github.com/repos/netty/netty/events","assignees_url":"https://api.github.com/repos/netty/netty/assignees{/user}","branches_url":"https://api.github.com/repos/netty/netty/branches{/branch}","tags_url":"https://api.github.com/repos/netty/netty/tags","blobs_url":"https://api.github.com/repos/netty/netty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netty/netty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netty/netty/git/refs{/sha}","trees_url":"https://api.github.com/repos/netty/netty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netty/netty/statuses/{sha}","languages_url":"https://api.github.com/repos/netty/netty/languages","stargazers_url":"https://api.github.com/repos/netty/netty/stargazers","contributors_url":"https://api.github.com/repos/netty/netty/contributors","subscribers_url":"https://api.github.com/repos/netty/netty/subscribers","subscription_url":"https://api.github.com/repos/netty/netty/subscription","commits_url":"https://api.github.com/repos/netty/netty/commits{/sha}","git_commits_url":"https://api.github.com/repos/netty/netty/git/commits{/sha}","comments_url":"https://api.github.com/repos/netty/netty/comments{/number}","issue_comment_url":"https://api.github.com/repos/netty/netty/issues/comments{/number}","contents_url":"https://api.github.com/repos/netty/netty/contents/{+path}","compare_url":"https://api.github.com/repos/netty/netty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netty/netty/merges","archive_url":"https://api.github.com/repos/netty/netty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netty/netty/downloads","issues_url":"https://api.github.com/repos/netty/netty/issues{/number}","pulls_url":"https://api.github.com/repos/netty/netty/pulls{/number}","milestones_url":"https://api.github.com/repos/netty/netty/milestones{/number}","notifications_url":"https://api.github.com/repos/netty/netty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netty/netty/labels{/name}","releases_url":"https://api.github.com/repos/netty/netty/releases{/id}","created_at":"2010-11-09T09:22:21Z","updated_at":"2015-03-30T18:22:50Z","pushed_at":"2015-03-30T20:07:28Z","git_url":"git://github.com/netty/netty.git","ssh_url":"git@github.com:netty/netty.git","clone_url":"https://github.com/netty/netty.git","svn_url":"https://github.com/netty/netty","homepage":"http://netty.io/","size":113223,"stargazers_count":4343,"watchers_count":4343,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2135,"mirror_url":null,"open_issues_count":254,"forks":2135,"open_issues":254,"watchers":4343,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netty/netty/pulls/3556"},"html":{"href":"https://github.com/netty/netty/pull/3556"},"issue":{"href":"https://api.github.com/repos/netty/netty/issues/3556"},"comments":{"href":"https://api.github.com/repos/netty/netty/issues/3556/comments"},"review_comments":{"href":"https://api.github.com/repos/netty/netty/pulls/3556/comments"},"review_comment":{"href":"https://api.github.com/repos/netty/netty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netty/netty/pulls/3556/commits"},"statuses":{"href":"https://api.github.com/repos/netty/netty/statuses/f3aa4a78353cbb372deafd644d8879bff9afef79"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":79,"deletions":33,"changed_files":2}}