{"action":"created","comment":{"url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/comments/43584417","id":43584417,"diff_hunk":"@@ -492,21 +602,23 @@ func generateASTFunction(f *Function) string {\n \t\t\t\t\taddDefer(doCall(p.Name, \"Dispose\"))\n \t\t\t\t}\n \n-\t\t\t\t// Add the return argument to the return statement\n-\t\t\t\tif p.Type.IsPrimitive {\n-\t\t\t\t\taddReturnItem(doCast(\n-\t\t\t\t\t\tp.Type.GoName,\n-\t\t\t\t\t\t&ast.Ident{\n-\t\t\t\t\t\t\tName: p.Name,\n-\t\t\t\t\t\t},\n-\t\t\t\t\t))\n-\t\t\t\t} else {\n-\t\t\t\t\tif p.Type.GoName == \"cxstring\" {\n-\t\t\t\t\t\taddReturnItem(doCall(p.Name, \"String\"))\n+\t\t\t\tif p.Type.LengthOfSlice == \"\" {","path":"cmd/go-clang-generate/function.go","position":202,"original_position":202,"commit_id":"cc153d9e796d9152cf290418c134f4fdc716a2dd","original_commit_id":"cc153d9e796d9152cf290418c134f4fdc716a2dd","user":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"body":"Must be an slice<->length pair so we can figure out how to iterate over the slice.","created_at":"2015-11-01T16:37:49Z","updated_at":"2015-11-01T16:37:49Z","html_url":"https://github.com/zimmski/go-clang-phoenix/pull/39#discussion_r43584417","pull_request_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39","_links":{"self":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/comments/43584417"},"html":{"href":"https://github.com/zimmski/go-clang-phoenix/pull/39#discussion_r43584417"},"pull_request":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39"}}},"pull_request":{"url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39","id":49371723,"html_url":"https://github.com/zimmski/go-clang-phoenix/pull/39","diff_url":"https://github.com/zimmski/go-clang-phoenix/pull/39.diff","patch_url":"https://github.com/zimmski/go-clang-phoenix/pull/39.patch","issue_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/39","number":39,"state":"open","locked":false,"title":"Mark small things as done, TODO or just implement them","user":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-11-01T13:16:51Z","updated_at":"2015-11-01T16:37:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e3d7137342cbfcc26c9e41a97b870647a9d3afe","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39/commits","review_comments_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39/comments","review_comment_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/39/comments","statuses_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/statuses/cc153d9e796d9152cf290418c134f4fdc716a2dd","head":{"label":"zimmski:do-the-done-train","ref":"do-the-done-train","sha":"cc153d9e796d9152cf290418c134f4fdc716a2dd","user":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"repo":{"id":44170554,"name":"go-clang-phoenix","full_name":"zimmski/go-clang-phoenix","owner":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zimmski/go-clang-phoenix","description":"This is a temporary repository to redo go-clang","fork":false,"url":"https://api.github.com/repos/zimmski/go-clang-phoenix","forks_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/forks","keys_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/teams","hooks_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/hooks","issue_events_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/events","assignees_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/tags","blobs_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/languages","stargazers_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/stargazers","contributors_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/contributors","subscribers_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/subscribers","subscription_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/subscription","commits_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/merges","archive_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/downloads","issues_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/labels{/name}","releases_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/releases{/id}","created_at":"2015-10-13T11:05:45Z","updated_at":"2015-10-30T10:34:02Z","pushed_at":"2015-11-01T15:10:53Z","git_url":"git://github.com/zimmski/go-clang-phoenix.git","ssh_url":"git@github.com:zimmski/go-clang-phoenix.git","clone_url":"https://github.com/zimmski/go-clang-phoenix.git","svn_url":"https://github.com/zimmski/go-clang-phoenix","homepage":null,"size":832,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":2,"default_branch":"master"}},"base":{"label":"zimmski:master","ref":"master","sha":"3cd18ea6dcda41bc7a817344ace44c12604aef0a","user":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"repo":{"id":44170554,"name":"go-clang-phoenix","full_name":"zimmski/go-clang-phoenix","owner":{"login":"zimmski","id":1847950,"avatar_url":"https://avatars.githubusercontent.com/u/1847950?v=3","gravatar_id":"","url":"https://api.github.com/users/zimmski","html_url":"https://github.com/zimmski","followers_url":"https://api.github.com/users/zimmski/followers","following_url":"https://api.github.com/users/zimmski/following{/other_user}","gists_url":"https://api.github.com/users/zimmski/gists{/gist_id}","starred_url":"https://api.github.com/users/zimmski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimmski/subscriptions","organizations_url":"https://api.github.com/users/zimmski/orgs","repos_url":"https://api.github.com/users/zimmski/repos","events_url":"https://api.github.com/users/zimmski/events{/privacy}","received_events_url":"https://api.github.com/users/zimmski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zimmski/go-clang-phoenix","description":"This is a temporary repository to redo go-clang","fork":false,"url":"https://api.github.com/repos/zimmski/go-clang-phoenix","forks_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/forks","keys_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/teams","hooks_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/hooks","issue_events_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/events{/number}","events_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/events","assignees_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/assignees{/user}","branches_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/branches{/branch}","tags_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/tags","blobs_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/statuses/{sha}","languages_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/languages","stargazers_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/stargazers","contributors_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/contributors","subscribers_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/subscribers","subscription_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/subscription","commits_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/contents/{+path}","compare_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/merges","archive_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/downloads","issues_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues{/number}","pulls_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls{/number}","milestones_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/milestones{/number}","notifications_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/labels{/name}","releases_url":"https://api.github.com/repos/zimmski/go-clang-phoenix/releases{/id}","created_at":"2015-10-13T11:05:45Z","updated_at":"2015-10-30T10:34:02Z","pushed_at":"2015-11-01T15:10:53Z","git_url":"git://github.com/zimmski/go-clang-phoenix.git","ssh_url":"git@github.com:zimmski/go-clang-phoenix.git","clone_url":"https://github.com/zimmski/go-clang-phoenix.git","svn_url":"https://github.com/zimmski/go-clang-phoenix","homepage":null,"size":832,"stargazers_count":2,"watchers_count":2,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":19,"forks":0,"open_issues":19,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39"},"html":{"href":"https://github.com/zimmski/go-clang-phoenix/pull/39"},"issue":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/39"},"comments":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/zimmski/go-clang-phoenix/statuses/cc153d9e796d9152cf290418c134f4fdc716a2dd"}}}}