{"action":"created","issue":{"url":"https://api.github.com/repos/BOINC/boinc/issues/802","labels_url":"https://api.github.com/repos/BOINC/boinc/issues/802/labels{/name}","comments_url":"https://api.github.com/repos/BOINC/boinc/issues/802/comments","events_url":"https://api.github.com/repos/BOINC/boinc/issues/802/events","html_url":"https://github.com/BOINC/boinc/issues/802","id":56198192,"number":802,"title":"php errors in show_log.php","user":{"login":"romw","id":985772,"avatar_url":"https://avatars.githubusercontent.com/u/985772?v=3","gravatar_id":"","url":"https://api.github.com/users/romw","html_url":"https://github.com/romw","followers_url":"https://api.github.com/users/romw/followers","following_url":"https://api.github.com/users/romw/following{/other_user}","gists_url":"https://api.github.com/users/romw/gists{/gist_id}","starred_url":"https://api.github.com/users/romw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romw/subscriptions","organizations_url":"https://api.github.com/users/romw/orgs","repos_url":"https://api.github.com/users/romw/repos","events_url":"https://api.github.com/users/romw/events{/privacy}","received_events_url":"https://api.github.com/users/romw/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"romw","id":985772,"avatar_url":"https://avatars.githubusercontent.com/u/985772?v=3","gravatar_id":"","url":"https://api.github.com/users/romw","html_url":"https://github.com/romw","followers_url":"https://api.github.com/users/romw/followers","following_url":"https://api.github.com/users/romw/following{/other_user}","gists_url":"https://api.github.com/users/romw/gists{/gist_id}","starred_url":"https://api.github.com/users/romw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romw/subscriptions","organizations_url":"https://api.github.com/users/romw/orgs","repos_url":"https://api.github.com/users/romw/repos","events_url":"https://api.github.com/users/romw/events{/privacy}","received_events_url":"https://api.github.com/users/romw/received_events","type":"User","site_admin":false},"milestone":null,"comments":5,"created_at":"2015-02-02T05:38:55Z","updated_at":"2015-02-02T19:22:03Z","closed_at":"2015-02-02T05:39:06Z","body":"**Reported by mweltin on 30 Mar 37722117 15:06 UTC**\nSome php.ini files will cause the following errors to appear when viewing logs from in $PROJECT/html/ops/show_log.php\r\n\r\n```\r\nNotice: Undefined index: f in /home/mweltin/projects/tsp/html/ops/show_log.php on line 11\r\nNotice: Undefined index: s in /home/mweltin/projects/tsp/html/ops/show_log.php on line 12\r\nNotice: Undefined index: l in /home/mweltin/projects/tsp/html/ops/show_log.php on line 13\r\nNotice: Undefined variable: lines in /home/mweltin/projects/tsp/html/ops/show_log.php on line 38\r\n```\r\nBy first testing for the variable with php's isset function the errors on lines 11-13 can be avoided.\r\nE.g.\r\n\r\n```\r\nif( isset($_GET![){\r\n  $f = $_GET![\"f\"](\"f\"]));\r\n} else {\r\n  $f = \"\";\r\n}\r\nif( isset($_GET![){\r\n  $s = $_GET![\"s\"](\"s\"]));\r\n} else {\r\n  $s = \"\";\r\n}\r\nif( isset($_GET![){\r\n  $l = (int)$_GET![\"l\"](\"l\"]));\r\n} else {\r\n  $l = 0;\r\n}\r\n```\r\nAdding that code pushes the error from line 38 to 54, but I'm not sure what $lines is needed for.  My perl is not so good, and I was not sure what the grep_logs script would use that parameter for. \r\n\r\n-Markus "},"comment":{"url":"https://api.github.com/repos/BOINC/boinc/issues/comments/72519475","html_url":"https://github.com/BOINC/boinc/issues/802#issuecomment-72519475","issue_url":"https://api.github.com/repos/BOINC/boinc/issues/802","id":72519475,"user":{"login":"romw","id":985772,"avatar_url":"https://avatars.githubusercontent.com/u/985772?v=3","gravatar_id":"","url":"https://api.github.com/users/romw","html_url":"https://github.com/romw","followers_url":"https://api.github.com/users/romw/followers","following_url":"https://api.github.com/users/romw/following{/other_user}","gists_url":"https://api.github.com/users/romw/gists{/gist_id}","starred_url":"https://api.github.com/users/romw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romw/subscriptions","organizations_url":"https://api.github.com/users/romw/orgs","repos_url":"https://api.github.com/users/romw/repos","events_url":"https://api.github.com/users/romw/events{/privacy}","received_events_url":"https://api.github.com/users/romw/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T19:22:03Z","updated_at":"2015-02-02T19:22:03Z","body":"**Commented by ChristianB on 10 Mar 37978828 07:33 UTC**\nThe fix introduces some bugs. I attached a patch to get it working again."}}