{"comment":{"url":"https://api.github.com/repos/sipwise/rtpengine/comments/12773405","html_url":"https://github.com/sipwise/rtpengine/commit/08cb513e66623b7095211ec6f3a02ae3342d437c#commitcomment-12773405","id":12773405,"user":{"login":"paulandrewhughes","id":3446283,"avatar_url":"https://avatars.githubusercontent.com/u/3446283?v=3","gravatar_id":"","url":"https://api.github.com/users/paulandrewhughes","html_url":"https://github.com/paulandrewhughes","followers_url":"https://api.github.com/users/paulandrewhughes/followers","following_url":"https://api.github.com/users/paulandrewhughes/following{/other_user}","gists_url":"https://api.github.com/users/paulandrewhughes/gists{/gist_id}","starred_url":"https://api.github.com/users/paulandrewhughes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulandrewhughes/subscriptions","organizations_url":"https://api.github.com/users/paulandrewhughes/orgs","repos_url":"https://api.github.com/users/paulandrewhughes/repos","events_url":"https://api.github.com/users/paulandrewhughes/events{/privacy}","received_events_url":"https://api.github.com/users/paulandrewhughes/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"08cb513e66623b7095211ec6f3a02ae3342d437c","created_at":"2015-08-18T23:51:03Z","updated_at":"2015-08-18T23:51:03Z","body":"Do you need to initialize the stream->endpoint too? There would be 2 bytes uninitialized here too?\r\ni.e at label update_addr:\r\n\tstream->endpoint.ip46 = fsin->sin6_addr;\r\n\tstream->endpoint.port = ntohs(fsin->sin6_port);\r\n\r\nMaybe it would be more efficient to compare the members of struct rather that doing memset?\r\n```\r\nint tmp = memcmp(&endpoint.ip46, &stream->endpoint.ip46, sizeof(endpoint.ip46));\r\nif(!tmp) tmp=endpoint.ip46.port-stream->endpoint.port;\r\n```\r\n\r\n\r\n\r\n"}}