{"action":"created","issue":{"url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261","labels_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261/comments","events_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261/events","html_url":"https://github.com/music-encoding/music-encoding/pull/261","id":108570897,"number":261,"title":"Fixed: Allow @visible on <accid>","user":{"login":"ahankinson","id":163183,"avatar_url":"https://avatars.githubusercontent.com/u/163183?v=3","gravatar_id":"","url":"https://api.github.com/users/ahankinson","html_url":"https://github.com/ahankinson","followers_url":"https://api.github.com/users/ahankinson/followers","following_url":"https://api.github.com/users/ahankinson/following{/other_user}","gists_url":"https://api.github.com/users/ahankinson/gists{/gist_id}","starred_url":"https://api.github.com/users/ahankinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahankinson/subscriptions","organizations_url":"https://api.github.com/users/ahankinson/orgs","repos_url":"https://api.github.com/users/ahankinson/repos","events_url":"https://api.github.com/users/ahankinson/events{/privacy}","received_events_url":"https://api.github.com/users/ahankinson/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Component:%20Core%20Schema","name":"Component: Core Schema","color":"c7def8"},{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Priority:%20Medium","name":"Priority: Medium","color":"fbca04"},{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Status:%20Needs%20Discussion","name":"Status: Needs Discussion","color":"fad8c7"},{"url":"https://api.github.com/repos/music-encoding/music-encoding/labels/Type:%20Enhancement","name":"Type: Enhancement","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":31,"created_at":"2015-09-28T00:43:39Z","updated_at":"2015-09-29T15:39:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/music-encoding/music-encoding/pulls/261","html_url":"https://github.com/music-encoding/music-encoding/pull/261","diff_url":"https://github.com/music-encoding/music-encoding/pull/261.diff","patch_url":"https://github.com/music-encoding/music-encoding/pull/261.patch"},"body":"This commit adds the @visible parameter to `<accid>`, providing a way to record an accidental that is present, but hidden. Note that this is not to be confused with the function of cautionary accidentals (i.e., accidentals that would normally be shown but for the convention that they were already shown in the bar.\r\n\r\nAlso included in this commit is a test case to check that `<accid>` takes @visible.\r\n\r\nNote that this pull request is based on the latest from the `develop-perry` branch and, if accepted, should be merged into this branch before being merged into `develop.`"},"comment":{"url":"https://api.github.com/repos/music-encoding/music-encoding/issues/comments/144097270","html_url":"https://github.com/music-encoding/music-encoding/pull/261#issuecomment-144097270","issue_url":"https://api.github.com/repos/music-encoding/music-encoding/issues/261","id":144097270,"user":{"login":"raffazizzi","id":144770,"avatar_url":"https://avatars.githubusercontent.com/u/144770?v=3","gravatar_id":"","url":"https://api.github.com/users/raffazizzi","html_url":"https://github.com/raffazizzi","followers_url":"https://api.github.com/users/raffazizzi/followers","following_url":"https://api.github.com/users/raffazizzi/following{/other_user}","gists_url":"https://api.github.com/users/raffazizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/raffazizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raffazizzi/subscriptions","organizations_url":"https://api.github.com/users/raffazizzi/orgs","repos_url":"https://api.github.com/users/raffazizzi/repos","events_url":"https://api.github.com/users/raffazizzi/events{/privacy}","received_events_url":"https://api.github.com/users/raffazizzi/received_events","type":"User","site_admin":false},"created_at":"2015-09-29T15:39:04Z","updated_at":"2015-09-29T15:39:04Z","body":"Shouldn't we be encoding *the reason* why an accidental is visible or not, rather whether it is visible? `@accid.ges` is used to encode performed accidental (I don't have an issue with it confirming or contradicting `@accid` because they're on two different domains) and that may sometimes correspond to presence/absence of the accidental on the page. So @ahankinson's example is better encoded with `@accid.ges` than `@visibility` because one is clearer about the reason for the encoding. And @lpugin's example needs it too, as he showed.\r\n\r\nSo yes, we need `@accid.ges` on `<accid>`.\r\n\r\nAre there other cases where we'd need to be explicit about visibility? If yes, let's find the reason and encoded that, not the visibility."}}