{"action":"created","comment":{"url":"https://api.github.com/repos/ms705/firmament/pulls/comments/31382328","id":31382328,"diff_hunk":"@@ -6,6 +6,8 @@\n ","path":"src/scheduling/dimacs_change.h","position":1,"original_position":1,"commit_id":"5f20b0853d96507feb3efc224e37bb425f873a92","original_commit_id":"83b765d4216539f1ec844fc76e73095f3aaecbcd","user":{"login":"ms705","id":192315,"avatar_url":"https://avatars.githubusercontent.com/u/192315?v=3","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"body":"It's the superclass for the concrete types of change, though, so I think this is okay?","created_at":"2015-05-30T16:45:29Z","updated_at":"2015-05-30T16:45:29Z","html_url":"https://github.com/ms705/firmament/pull/17#discussion_r31382328","pull_request_url":"https://api.github.com/repos/ms705/firmament/pulls/17","_links":{"self":{"href":"https://api.github.com/repos/ms705/firmament/pulls/comments/31382328"},"html":{"href":"https://github.com/ms705/firmament/pull/17#discussion_r31382328"},"pull_request":{"href":"https://api.github.com/repos/ms705/firmament/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/ms705/firmament/pulls/17","id":35842626,"html_url":"https://github.com/ms705/firmament/pull/17","diff_url":"https://github.com/ms705/firmament/pull/17.diff","patch_url":"https://github.com/ms705/firmament/pull/17.patch","issue_url":"https://api.github.com/repos/ms705/firmament/issues/17","number":17,"state":"open","locked":false,"title":"Integrate Adam's changes (inc. simulator and simulated Quincy cost model)","user":{"login":"ms705","id":192315,"avatar_url":"https://avatars.githubusercontent.com/u/192315?v=3","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"body":"This pull request contains the changes from @AdamGleave's Hapi project for review. We should aim to upstream these changes in a reasonably timely manner in order not to uphold some of the upcoming changes to code structure.\r\n\r\nApart from a bunch of fixes and improvements, this pull request contains three major components:\r\n 1. A simulated Quincy cost model that allows us to simulate locality in a distributed file system with the Google trace simulator.\r\n 2. Changes to support the Hapi min-cost flow solvers in Firmament (adding approximate and incremental scheduling support).\r\n 3. Changes to the Google trace simulator to run experiments and measure a variety of metrics when running approximate and incremental flow solvers.\r\n\r\nI will aim to go through the commits and tick them off individually, adding comments and deltas as required; I don't think there's an easy way to make this into multiple pull requests, unfortunately.\r\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948050%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948056%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948061%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948069%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948075%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948145%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948268%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948343%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948603%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948639%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948817%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948822%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948880%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948909%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948941%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948945%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948950%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948951%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948954%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948960%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948961%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948969%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948975%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948981%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948989%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949000%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949011%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949053%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949062%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949099%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949111%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949113%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949122%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949124%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949125%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949127%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949129%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949184%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949790%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949801%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949816%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949832%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949836%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949846%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949891%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949895%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949956%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949964%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950027%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950031%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950036%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950052%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31002701%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003040%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003041%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003043%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003045%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003047%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003048%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003052%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003053%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003054%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003055%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003093%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003094%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003098%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003100%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003102%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003104%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003105%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003107%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003109%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003112%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003167%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003174%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003189%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003194%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003199%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003212%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003214%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003217%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003222%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003229%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003242%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003245%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003249%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003257%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003258%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003282%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003291%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003307%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003312%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003317%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003318%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003342%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003343%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003344%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003381%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003383%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003384%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003391%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003394%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003395%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003398%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003400%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003407%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003414%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003417%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003424%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003426%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003432%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003433%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003434%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003435%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003436%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003437%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003439%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003440%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003441%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003443%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003445%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003447%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003448%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003449%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003450%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003451%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003452%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003454%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003457%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003459%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003460%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003463%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003465%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003466%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003467%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003468%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003469%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003470%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31004062%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31004063%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31004067%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31004071%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31004074%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31004146%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31122636%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31123975%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31123977%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31123978%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31124133%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31128057%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31128060%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31128063%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31128497%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31128604%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31128865%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31288497%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31288862%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31289093%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31289233%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31289537%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31290928%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31290929%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31290930%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31290936%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31312920%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31315505%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31315506%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31315507%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31315508%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31315511%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31381239%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31381412%22%2C%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31381421%22%5D%2C%20%22comments%22%3A%20%7B%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.h%2022%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003040%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A52%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A55%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A58%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.h%3AL1-23%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_new_arc.cc%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949127%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Ditto.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A47%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_new_arc.cc%3AL9-16%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/utils.cc%2045%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948961%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%27m%20a%20little%20confused%3A%20why%20do%20we%20do%20this%3F%20There%20shouldn%27t%20usually%20be%20any%20others%20open%2C%20but%20there%20could%20be%20%28e.g.%20if%20a%20perf%20file%20is%20written%20or%20logging%20is%20done%20concurrently%29.%20Is%20this%20in%20order%20to%20get%20rid%20of%20stale%20open%20FDs%3F%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A11%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/utils.cc%3AL291-314%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/cost_models.h%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948969%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22In%20an%20ideal%20implementation%2C%20the%20simulated%20Quincy%20model%20would%20be%20a%20wrapper%20around%20the%20real%20Quincy%20model%20that%20feeds%20it%20with%20simulated%20data%20locality%20information.%20We%20should%20think%20about%20re-engineering%20it%20that%20way.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A13%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/cost_models.h%3AL16-22%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/quincy_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003384%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/quincy_cost_model.h%3AL61-68%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%20152%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949011%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Hmm..I%20think%20from%20this%20method%20we%20should%20just%20return%20the%20equiv_classes%20to%20which%20the%20resource%20node%20is%20going%20to%20be%20connected.%20Similarly%2C%20from%20the%20GetOutgoingEquivClassPrefArcs%20we%20should%20return%20the%20ResIDs%20to%20which%20the%20equiv_class%20will%20be%20connected%20%28i.e.%2C%20just%20the%20forward%20going%20arcs%29.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A20%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_change_stats.h%202%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949125%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Remove%20SRC_.%20I%27ll%20stop%20commenting%20about%20these.%20We%27ll%20just%20have%20to%20do%20a%20pass%20over%20all%20the%20files.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A46%3A53Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A30%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_change_stats.h%3AL1-23%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/flow_graph_test.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003432%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A53Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/flow_graph_test.cc%3AL120-131%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_change.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949099%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20file%20has%20a%20misleading%20name.%20It%20only%20prints%20a%20comment.%20It%20doesn%27t%20generate%20a%20change.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A41%3A48Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_change.h%3AL6-14%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_dfs.cc%2047%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948603%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20wonder%20if%20we%20should%20use%20an%20unordered_map%20here.%22%2C%20%22created_at%22%3A%20%222015-05-23T22%3A11%3A59Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22What%20would%20the%20map%20be%20keyed%20by%3F%20The%20machine%20ID%20or%20the%20resource%20ID%3F%20If%20we%20use%20the%20machine%2C%20there%20is%20no%20benefit%20over%20using%20a%20vector%2C%20since%20the%20vector%20can%20be%20subscripted%20into%20at%20O%281%29%20cost.%20If%20we%20use%20the%20resource%20ID%2C%20the%20placement%20code%20in%20GetMachines%28%29%20will%20become%20more%20complex.%5Cr%5Cn%5Cr%5CnI%20think%20I%20agree%20that%20we%20should%20change%20it%2C%20but%20let%27s%20quickly%20discuss%20the%20design%20here.%22%2C%20%22created_at%22%3A%20%222015-05-27T12%3A39%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_dfs.cc%3AL1-104%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20816%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950027%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22We%20probably%20want%20to%20move%20this%20into%20a%20separate%20method.%20The%20current%20method%20is%20already%20rather%20long.%20%22%2C%20%22created_at%22%3A%20%222015-05-24T04%3A16%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20made%20a%20more%20general%20pass%20over%20%60ReplayTrace%60%20and%20refactored%20it%20into%20smaller%20methods.%20It%27s%20now%20%7E130%20lines%20itself.%22%2C%20%22created_at%22%3A%20%222015-05-30T15%3A04%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL1132-1284%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.cc%2049%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003041%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A52%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A55%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A58%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.cc%3AL1-50%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/octopus_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003394%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A17Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/octopus_cost_model.h%3AL46-53%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_runtime_distribution.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948145%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20wonder%20if%20we%20should%20move%20these%20distribution%20files%20to%20the%20simulator%20directory.%22%2C%20%22created_at%22%3A%20%222015-05-23T20%3A50%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22Agree%2C%20we%20should%20%28though%20that%20might%20complicate%20linkage%20a%20bit%29.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A14%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-27T12%3A33%3A21Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_runtime_distribution.cc%3AL1-41%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/octopus_cost_model.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003395%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/octopus_cost_model.cc%3AL115-124%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.h%2027%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948880%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Aren%27t%20we%20defining%20it%20is%20some%20other%20place%20already%3F%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A00%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22We%20currently%20define%20this%20in%20every%20cost%20model%2C%20but%20this%20is%20clearly%20silly.%20I%20will%20move%20it%20into%20a%20common%20header.%22%2C%20%22created_at%22%3A%20%222015-05-28T23%3A41%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T00%3A31%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.h%3AL1-117%22%7D%2C%20%22Pull%202cff3c590900e863a9eb6d4b7217b9ba90571f5e%20src/scheduling/dimacs_exporter.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003436%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_exporter.cc%3AL112-120%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/base/types.h%2015%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948050%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Only%20used%20in%20one%20place%20%28simulated_quincy_cost_model%29.%20I%20would%20not%20define%20it%20in%20types%20if%20it%27s%20only%20used%20in%20one%20place.%22%2C%20%22created_at%22%3A%20%222015-05-23T20%3A35%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-05-27T11%3A08%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/base/types.h%3AL113-133%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/base/types.h%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948945%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Likewise%2C%20I%20think%20these%20should%20be%20in%20a%20cost-model%20header%2C%20rather%20than%20in%20the%20global%20types%20header.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A08%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22It%20turns%20out%20that%20the%20simulated%20DFS%20class%20also%20uses%20this%20type.%20For%20now%2C%20we%20have%20two%20typedefs%20in%20different%20places%20for%20this%2C%20but%20that%27s%20clearly%20not%20ideal.%20We%27ll%20need%20to%20think%20about%20a%20shared%20header%20in%20the%20future.%20However%20the%20places%20that%20use%20this%20are%20in%20different%20modules%20%28%5C%22sim%5C%22%20and%20%5C%22cost_models%5C%22%29%2C%20so%20there%20is%20no%20trivial%20solution.%22%2C%20%22created_at%22%3A%20%222015-05-28T23%3A57%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T00%3A31%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/base/types.h%3AL113-133%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_dfs.h%2034%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948639%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22A%20comment%20would%20help%20here.%20I%27m%20not%20sure%20what%20the%20method%20is%20trying%20to%20do.%22%2C%20%22created_at%22%3A%20%222015-05-23T22%3A17%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%20%2Athink%2A%20it%20randomly%20picks%20input%20files%20covers%20num_blocks%20DFS%20blocks%20for%20a%20job.%20%40AdamGleave%20should%20be%20able%20to%20confirm.%22%2C%20%22created_at%22%3A%20%222015-05-27T12%3A40%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_dfs.h%3AL1-59%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/wharemap_cost_model.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003440%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A57Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/wharemap_cost_model.cc%3AL306-315%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%20140%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948989%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20are%20tasks%20modelled%20as%20equiv%20classes%3F%20I%20don%27t%20any%20limitation%20in%20modelling%20them%20as%20task%20nodes.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A16%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/coco_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003398%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A25Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/coco_cost_model.h%3AL78-85%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/Makefile%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003400%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/Makefile%3AL8-15%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_change_stats.cc%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949122%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Another%20way%20to%20do%20this%20is%20to%20have%20the%20fields%20%28e.g.%20new_node%2C%20new_arc..%29%20in%20the%20dimacs_change.cc.%20Then%20we%20can%20increment%20them%20from%20any%20subclass.%20Moreover%2C%20we%20won%27t%20have%20to%20do%20any%20instanceOf%20checks.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A46%3A13Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_change_stats.cc%3AL1-43%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/wharemap_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003441%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/wharemap_cost_model.h%3AL56-63%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/flow_scheduling_cost_model_interface.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003433%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/flow_scheduling_cost_model_interface.h%3AL31-38%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20207%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949816%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22MAX_VALUE%20is%20uint32_t.%20Shouldn%27t%20the%20hash%20be%20uint64_t%3F%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A21%3A22Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL260-292%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20449%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949891%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Add%20comment.%20%28e.g.%20Only%20considering%20machines%20that%20have%20a%20hash%20%3C%20proportion%29.%20Maybe%20proportion%20should%20be%20called%20max_hash.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A40%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T11%3A03%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL633-657%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/flow_scheduling_cost_model_interface.h%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003043%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A52%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A57%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/flow_scheduling_cost_model_interface.h%3AL31-38%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/void_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003447%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/void_cost_model.h%3AL48-55%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/sjf_cost_model.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003448%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/sjf_cost_model.cc%3AL167-176%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003045%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A57%3A18Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.h%3AL1-23%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_task_processor.cc%20165%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950052%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Fix.%22%2C%20%22created_at%22%3A%20%222015-05-24T04%3A21%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A33%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_task_processor.cc%3AL900-943%22%7D%2C%20%22Pull%207e5942a04e1b561c46840c4a2478b52501e1005c%20src/scheduling/cost_models/simulated_dfs.cc%209%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31124133%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20is%20a%20little%20suboptimal%2C%20as%20the%20ext%20directory%20isn%27t%20part%20of%20our%20standard%20include%20path%20%28and%20not%20in%20the%20source%20tree%20either%29.%20Should%20we%20just%20add%20it%20to%20the%20include%20path%20in%20Makefile.config%3F%22%2C%20%22created_at%22%3A%20%222015-05-27T11%3A34%3A45Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_dfs.cc%3AL1-106%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_task_processor.cc%2015%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950036%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Fix%20indentation.%22%2C%20%22created_at%22%3A%20%222015-05-24T04%3A17%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-05-27T12%3A44%3A23Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_task_processor.cc%3AL44-60%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/void_cost_model.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003443%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/void_cost_model.cc%3AL107-116%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/octopus_cost_model.cc%2018%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948981%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Do%20you%20know%20what%20flag%20controls%20logging%20here%3F%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A15%3A00Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/octopus_cost_model.cc%3AL184-194%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/knowledge_base.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003450%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/knowledge_base.h%3AL35-42%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20621%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949956%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Rename%20%2B%20plus%20comment.%20From%20what%20I%20understand%20the%20method%20is%20used%20to%20lookup%20machine%20binary%20from%20relative%20path%20and%20not%20cwd.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A57%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22Moved%20to%20%60misc/utils.cc%60%2C%20since%20this%20is%20more%20general%20functionality%20that%20will%20be%20useful%20outside%20the%20simulator.%22%2C%20%22created_at%22%3A%20%222015-05-30T14%3A47%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%22%2C%20%22created_at%22%3A%20%222015-05-30T15%3A05%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL1022-1064%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20121%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949790%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20think%20all%20these%20settings%20should%20be%20in%20a%20quincy%20specific%20file.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A11%3A19Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL55-164%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20124%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949801%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Why%20is%20this%20a%20constant%3F%20Should%20we%20just%20maintain%20it%20and%20update%20it%20as%20we%20add/remove%20machines%3F%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A15%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL55-164%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20909%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30950031%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20think%20we%20should%20not%20remove%20a%20task%20from%20the%20knowledge%20base.%20We%20want%20to%20keep%20the%20information.%22%2C%20%22created_at%22%3A%20%222015-05-24T04%3A17%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL1300-1308%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/utils.cc%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948075%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Reorder.%22%2C%20%22created_at%22%3A%20%222015-05-23T20%3A38%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-27T12%3A33%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/utils.cc%3AL7-15%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/dimacs_add_node.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003452%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_add_node.cc%3AL7-39%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_remove_node.cc%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949129%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Ditto.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A47%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_remove_node.cc%3AL7-14%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%20200%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949053%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20wonder%20if%20we%20should%20randomize%20this%20by%20adding%20the%20machine%20to%20a%20random%20rack%20that%20has%20ports%20for%20another%20machine.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A31%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22Won%27t%20fix%20for%20this%20PR.%20Have%20added%20a%20comment%20explaining%20what%27s%20going%20on%20here%20and%20pointing%20out%20that%20we%20should%20change%20it.%22%2C%20%22created_at%22%3A%20%222015-05-29T00%3A03%3A16Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T00%3A31%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20703%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949964%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Ditto.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A58%3A33Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T11%3A03%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL1114-1130%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%2097%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948941%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20covers%20the%20sw%20rack%20to%20machine%20case%20as%20well.%20Shouldn%27t%20the%20method%20return%20a%20non-zero%20value%3F%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A08%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20257%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949832%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20guess%20we%20have%20to%20make%20sure%20we%20use%20the%20same%20way%20of%20writing%20to%20files.%20One%20uses%20ofstream%20and%20another%20one%20uses%20fopen.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A25%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL311-357%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/utils.cc%2017%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948951%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22We%20should%20add%20a%20comment%20here%20to%20point%20out%20why%20this%20is%20necessary%2C%20and%20where%20it%27s%20used.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A09%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%2B1%20on%20this%20one.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A11%3A48Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/utils.cc%3AL20-36%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20381%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949846%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22A%20comment%20would%20help%20here.%20I%20assume%20that%20all%20the%20tasks%20are%20sharing%20the%20same%20equivalence%20class.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A29%3A11Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22I%27ve%20added%20a%20comment%2C%20but%20it%27s%20not%20as%20you%20assume%3A%20by%20contrast%2C%20each%20task%20has%20its%20own%2C%20single-entity%20equivalence%20class.%20I%20think%20Adam%20did%20this%20as%20a%20short-cut%20hack%20in%20order%20to%20have%20information%20in%20the%20KB%20even%20though%20the%20SimulatedQuincyCostModel%20does%20not%20actually%20have%20a%20proper%20notion%20of%20TECs%20%28it%20would%20record%20the%20stats%20on%20a%20per-rack%20basis%21%29.%20%5Cr%5Cn%5Cr%5CnWe%20almost%20certainly%20need%20to%20do%20some%20work%20here%20to%20improve%20statistics%20collection.%20Okay%20to%20merge%20anyway%20with%20my%20changes%3F%22%2C%20%22created_at%22%3A%20%222015-05-29T10%3A12%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T11%3A03%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL443-511%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%2062%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948822%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%27m%20not%20sure%20what%20elt%20stands%20for.%22%2C%20%22created_at%22%3A%20%222015-05-23T22%3A53%3A53Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%5C%22element%5C%22%2C%20at%20a%20guess.%20But%20I%27ve%20replaced%20it%20with%20%5C%22mapping%5C%22%20everywhere%2C%20which%20is%20clearer.%22%2C%20%22created_at%22%3A%20%222015-05-28T23%3A50%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T00%3A31%3A27Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%20348%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948909%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20am%20a%20bit%20surprised%20that%20these%20methods%20are%20not%20implemented.%20I%20think%20we%20should%20use%20them%20in%20order%20to%20adjust%20the%20costs%20of%20the%20preference%20arcs.%20We%20should%20gather%20the%20number%20of%20tasks%20that%20are%20running%20on%20a%20machine.%20We%20don%27t%20want%20to%20place%20N%20tasks%20on%20the%20same%20machine%20if%20they%20are%20all%20hitting%20hard%20the%20disk.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A04%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/google_runtime_distribution.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003383%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A03Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_runtime_distribution.h%3AL1-23%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20Makefile%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003435%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A54Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20Makefile%3AL21-28%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20503%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949895%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Ditto.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A41%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T11%3A03%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL764-785%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20include/pkglist.Ubuntu-12.04%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003437%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A55Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20include/pkglist.Ubuntu-12.04%3AL6-13%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/Makefile%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003439%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A57Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/Makefile%3AL10-18%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/dimacs_exporter.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31002701%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Done.%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A33%3A45Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A57%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_exporter.cc%3AL110-119%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/Makefile%206%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003048%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A04Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A57%3A41Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A26Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/Makefile%3AL10-19%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/cost_models.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003217%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/cost_models.h%3AL13-23%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/random_cost_model.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003417%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/random_cost_model.cc%3AL134-143%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.cc%2010%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003052%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A06Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A28Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.cc%3AL1-50%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/flow_scheduling_cost_model_interface.h%2012%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003047%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A02Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A56%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A57%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A59%3A24Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A01%3A47Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A18Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/flow_scheduling_cost_model_interface.h%3AL68-75%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.cc%2014%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003053%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.cc%3AL1-50%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/trivial_cost_model.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003463%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A34Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/trivial_cost_model.cc%3AL125-134%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_dfs.cc%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948343%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Similarly%2C%20I%20would%20move%20this%20file%20to%20the%20simulator%20directory.%22%2C%20%22created_at%22%3A%20%222015-05-23T21%3A24%3A49Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-27T12%3A33%3A20Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_dfs.cc%3AL1-104%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/SpookyV2.cc%20351%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948061%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20ext.%22%2C%20%22created_at%22%3A%20%222015-05-23T20%3A37%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-27T11%3A32%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/SpookyV2.cc%3AL1-352%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_dfs.cc%20103%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948268%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Fix%20indentation.%22%2C%20%22created_at%22%3A%20%222015-05-23T21%3A10%3A52Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A30%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_dfs.cc%3AL1-104%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%20231%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949062%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22This%20should%20definitely%20be%20a%20TODO.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A32%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_change_arc.cc%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949111%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22We%20should%20definitely%20be%20able%20to%20de-activate%20these%20comments.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A43%3A46Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_change_arc.cc%3AL9-16%22%7D%2C%20%22Pull%200ae12bf98ff57e9db9b24f92c5acf83f9bcda401%20src/scheduling/cost_models/random_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003465%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/random_cost_model.h%3AL50-57%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_dfs.cc%2063%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949000%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Hang%20on%2C%20is%20this%20computing%20the%20replication%20factor%20as%20an%20element%20of%20%280%2C%20num_machines%20-%201%29%3F%20That%20would%20be%20very%20different%20to%20how%20HDFS%20works%2C%20for%20example.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A17%3A50Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_dfs.cc%3AL1-104%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/google_trace_simulator.cc%20278%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949836%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%27d%20rather%20have%20this%20as%20a%20method.%22%2C%20%22created_at%22%3A%20%222015-05-24T03%3A26%3A32Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-29T11%3A03%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/google_trace_simulator.cc%3AL311-357%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/sim/trace-extract/event_desc.proto%205%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949184%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Shouldn%27t%20have%20pinning%20in%20the%20name%3F%22%2C%20%22created_at%22%3A%20%222015-05-24T00%3A02%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/sim/trace-extract/event_desc.proto%3AL11-19%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/trivial_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003466%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A38Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/trivial_cost_model.h%3AL53-60%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%2032%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948817%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Maybe%20we%20should%20create%20a%20class%20that%20stores%20all%20these%20options.%20Otherwise%2C%20we%20end%20up%20having%20this%20monstrous%20constructor.%22%2C%20%22created_at%22%3A%20%222015-05-23T22%3A52%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/utils.cc%2034%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948954%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22One%20declaration%20per%20line.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A09%3A51Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A30%3A36Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/utils.cc%3AL291-314%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.h%2016%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003054%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A14Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A09Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A40Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.h%3AL1-23%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/SpookyV2.h%20299%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948069%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Move%20to%20ext%20or%20figure%20out%20a%20better%20way%20of%20including%20a%20decent%20hash%20function.%22%2C%20%22created_at%22%3A%20%222015-05-23T20%3A37%3A37Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-27T11%3A32%3A08Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/SpookyV2.h%3AL1-300%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/dimacs_add_node.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003468%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A42Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_add_node.h%3AL10-17%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%20118%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948950%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Hmm..this%20indicates%20that%20the%20code%20models%20racks%20as%20task%20equivalence%20aggregators.%20Maybe%20the%20new%20version%20of%20the%20code%20is%20doing%20this%2C%20but%20previously%20it%20was%20treating%20racks%20as%20resources.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A09%3A31Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22We%20discussed%20the%20reasoning%20behind%20this%20%28a%20quick%20hack%20to%20allow%20direct%20mapping%20of%20tasks%20to%20racks%2C%20rather%20than%20via%20TECs%29.%20I%27m%20not%20sure%20if%20we%20arrived%20at%20a%20conclusion%20what%20a%20better%20way%20of%20doing%20this%20would%20be%3F%20Needs%20more%20discussion%22%2C%20%22created_at%22%3A%20%222015-05-28T23%3A55%3A10Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/simulated_quincy_cost_model.cc%3AL1-359%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_change_stats.cc%2042%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949113%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Fix%20indentation.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A44%3A05Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A30%3A39Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_change_stats.cc%3AL1-43%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/misc/Makefile%206%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30948056%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Spooky%20should%20probably%20go%20in%20externals.%22%2C%20%22created_at%22%3A%20%222015-05-23T20%3A36%3A58Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-27T11%3A32%3A07Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/192315%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ms705%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/misc/Makefile%3AL6-14%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/dimacs_change_stats.h%2014%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r30949124%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Only%20one%20variable%20per%20line.%22%2C%20%22created_at%22%3A%20%222015-05-23T23%3A46%3A29Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A30%3A43Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/dimacs_change_stats.h%3AL1-23%22%7D%2C%20%22Pull%2083b765d4216539f1ec844fc76e73095f3aaecbcd%20src/scheduling/cost_models/google_block_distribution.cc%2037%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003055%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A51%3A15Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T03%3A53%3A12Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%2C%20%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-none%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/google_block_distribution.cc%3AL1-50%22%7D%2C%20%22Pull%20b8affa5c0bc5168a552370dfad9c95eaee706a5e%20src/scheduling/cost_models/sjf_cost_model.h%201%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/ms705/firmament/pull/17%23discussion_r31003470%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22%3A%2B1%3A%3Ca%20href%3D%27%23crh-update-complete%27%3E%3C/a%3E%22%2C%20%22created_at%22%3A%20%222015-05-26T04%3A02%3A44Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/433340%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/ICGog%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20src/scheduling/cost_models/sjf_cost_model.h%3AL54-61%22%7D%7D%7D'></a>\r\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_dfs.cc 47'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948603'>File: src/scheduling/cost_models/simulated_dfs.cc:L1-104</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I wonder if we should use an unordered_map here.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> What would the map be keyed by? The machine ID or the resource ID? If we use the machine, there is no benefit over using a vector, since the vector can be subscripted into at O(1) cost. If we use the resource ID, the placement code in GetMachines() will become more complex.\r\nI think I agree that we should change it, but let's quickly discuss the design here.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_dfs.h 34'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948639'>File: src/scheduling/cost_models/simulated_dfs.h:L1-59</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> A comment would help here. I'm not sure what the method is trying to do.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> I *think* it randomly picks input files covers num_blocks DFS blocks for a job. @AdamGleave should be able to confirm.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 32'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948817'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Maybe we should create a class that stores all these options. Otherwise, we end up having this monstrous constructor.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 348'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948909'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I am a bit surprised that these methods are not implemented. I think we should use them in order to adjust the costs of the preference arcs. We should gather the number of tasks that are running on a machine. We don't want to place N tasks on the same machine if they are all hitting hard the disk.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 97'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948941'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> This covers the sw rack to machine case as well. Shouldn't the method return a non-zero value?\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 118'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948950'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Hmm..this indicates that the code models racks as task equivalence aggregators. Maybe the new version of the code is doing this, but previously it was treating racks as resources.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> We discussed the reasoning behind this (a quick hack to allow direct mapping of tasks to racks, rather than via TECs). I'm not sure if we arrived at a conclusion what a better way of doing this would be? Needs more discussion\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/utils.cc 17'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948951'>File: src/misc/utils.cc:L20-36</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> We should add a comment here to point out why this is necessary, and where it's used.\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> +1 on this one.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/utils.cc 45'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948961'>File: src/misc/utils.cc:L291-314</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> I'm a little confused: why do we do this? There shouldn't usually be any others open, but there could be (e.g. if a perf file is written or logging is done concurrently). Is this in order to get rid of stale open FDs?\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/cost_models.h 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948969'>File: src/scheduling/cost_models/cost_models.h:L16-22</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> In an ideal implementation, the simulated Quincy model would be a wrapper around the real Quincy model that feeds it with simulated data locality information. We should think about re-engineering it that way.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/octopus_cost_model.cc 18'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948981'>File: src/scheduling/cost_models/octopus_cost_model.cc:L184-194</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> Do you know what flag controls logging here?\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 140'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948989'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Why are tasks modelled as equiv classes? I don't any limitation in modelling them as task nodes.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_dfs.cc 63'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949000'>File: src/scheduling/cost_models/simulated_dfs.cc:L1-104</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> Hang on, is this computing the replication factor as an element of (0, num_machines - 1)? That would be very different to how HDFS works, for example.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 152'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949011'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Hmm..I think from this method we should just return the equiv_classes to which the resource node is going to be connected. Similarly, from the GetOutgoingEquivClassPrefArcs we should return the ResIDs to which the equiv_class will be connected (i.e., just the forward going arcs).\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 231'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949062'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> This should definitely be a TODO.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_change.h 1'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949099'>File: src/scheduling/dimacs_change.h:L6-14</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> This file has a misleading name. It only prints a comment. It doesn't generate a change.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_change_arc.cc 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949111'>File: src/scheduling/dimacs_change_arc.cc:L9-16</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> We should definitely be able to de-activate these comments.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_change_stats.cc 17'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949122'>File: src/scheduling/dimacs_change_stats.cc:L1-43</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Another way to do this is to have the fields (e.g. new_node, new_arc..) in the dimacs_change.cc. Then we can increment them from any subclass. Moreover, we won't have to do any instanceOf checks.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_new_arc.cc 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949127'>File: src/scheduling/dimacs_new_arc.cc:L9-16</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Ditto.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_remove_node.cc 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949129'>File: src/scheduling/dimacs_remove_node.cc:L7-14</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Ditto.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/event_desc.proto 5'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949184'>File: src/sim/trace-extract/event_desc.proto:L11-19</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Shouldn't have pinning in the name?\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 121'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949790'>File: src/sim/trace-extract/google_trace_simulator.cc:L55-164</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I think all these settings should be in a quincy specific file.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 124'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949801'>File: src/sim/trace-extract/google_trace_simulator.cc:L55-164</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Why is this a constant? Should we just maintain it and update it as we add/remove machines?\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 207'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949816'>File: src/sim/trace-extract/google_trace_simulator.cc:L260-292</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> MAX_VALUE is uint32_t. Shouldn't the hash be uint64_t?\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 257'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949832'>File: src/sim/trace-extract/google_trace_simulator.cc:L311-357</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I guess we have to make sure we use the same way of writing to files. One uses ofstream and another one uses fopen.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 816'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30950027'>File: src/sim/trace-extract/google_trace_simulator.cc:L1132-1284</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> We probably want to move this into a separate method. The current method is already rather long.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> I made a more general pass over `ReplayTrace` and refactored it into smaller methods. It's now ~130 lines itself.\r\n- [ ] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 909'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30950031'>File: src/sim/trace-extract/google_trace_simulator.cc:L1300-1308</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I think we should not remove a task from the knowledge base. We want to keep the information.\r\n- [ ] <a href='#crh-comment-Pull 7e5942a04e1b561c46840c4a2478b52501e1005c src/scheduling/cost_models/simulated_dfs.cc 9'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r31124133'>File: src/scheduling/cost_models/simulated_dfs.cc:L1-106</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> This is a little suboptimal, as the ext directory isn't part of our standard include path (and not in the source tree either). Should we just add it to the include path in Makefile.config?\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/base/types.h 15'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948050'>File: src/base/types.h:L113-133</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Only used in one place (simulated_quincy_cost_model). I would not define it in types if it's only used in one place.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/Makefile 6'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948056'>File: src/misc/Makefile:L6-14</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Spooky should probably go in externals.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/SpookyV2.cc 351'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948061'>File: src/misc/SpookyV2.cc:L1-352</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Move to ext.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/SpookyV2.h 299'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948069'>File: src/misc/SpookyV2.h:L1-300</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Move to ext or figure out a better way of including a decent hash function.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/utils.cc 4'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948075'>File: src/misc/utils.cc:L7-15</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Reorder.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/google_runtime_distribution.cc 1'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948145'>File: src/scheduling/cost_models/google_runtime_distribution.cc:L1-41</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I wonder if we should move these distribution files to the simulator directory.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> Agree, we should (though that might complicate linkage a bit).\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_dfs.cc 103'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948268'>File: src/scheduling/cost_models/simulated_dfs.cc:L1-104</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Fix indentation.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_dfs.cc 1'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948343'>File: src/scheduling/cost_models/simulated_dfs.cc:L1-104</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Similarly, I would move this file to the simulator directory.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 62'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948822'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I'm not sure what elt stands for.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> \"element\", at a guess. But I've replaced it with \"mapping\" everywhere, which is clearer.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.h 27'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948880'>File: src/scheduling/cost_models/simulated_quincy_cost_model.h:L1-117</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Aren't we defining it is some other place already?\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> We currently define this in every cost model, but this is clearly silly. I will move it into a common header.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/base/types.h 17'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948945'>File: src/base/types.h:L113-133</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> Likewise, I think these should be in a cost-model header, rather than in the global types header.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> It turns out that the simulated DFS class also uses this type. For now, we have two typedefs in different places for this, but that's clearly not ideal. We'll need to think about a shared header in the future. However the places that use this are in different modules (\"sim\" and \"cost_models\"), so there is no trivial solution.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/misc/utils.cc 34'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30948954'>File: src/misc/utils.cc:L291-314</a></b>\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> One declaration per line.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/cost_models/simulated_quincy_cost_model.cc 200'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949053'>File: src/scheduling/cost_models/simulated_quincy_cost_model.cc:L1-359</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I wonder if we should randomize this by adding the machine to a random rack that has ports for another machine.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> Won't fix for this PR. Have added a comment explaining what's going on here and pointing out that we should change it.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_change_stats.cc 42'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949113'>File: src/scheduling/dimacs_change_stats.cc:L1-43</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Fix indentation.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_change_stats.h 14'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949124'>File: src/scheduling/dimacs_change_stats.h:L1-23</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Only one variable per line.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/scheduling/dimacs_change_stats.h 2'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949125'>File: src/scheduling/dimacs_change_stats.h:L1-23</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Remove SRC_. I'll stop commenting about these. We'll just have to do a pass over all the files.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 278'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949836'>File: src/sim/trace-extract/google_trace_simulator.cc:L311-357</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> I'd rather have this as a method.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 381'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949846'>File: src/sim/trace-extract/google_trace_simulator.cc:L443-511</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> A comment would help here. I assume that all the tasks are sharing the same equivalence class.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> I've added a comment, but it's not as you assume: by contrast, each task has its own, single-entity equivalence class. I think Adam did this as a short-cut hack in order to have information in the KB even though the SimulatedQuincyCostModel does not actually have a proper notion of TECs (it would record the stats on a per-rack basis!).\r\nWe almost certainly need to do some work here to improve statistics collection. Okay to merge anyway with my changes?\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 449'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949891'>File: src/sim/trace-extract/google_trace_simulator.cc:L633-657</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Add comment. (e.g. Only considering machines that have a hash < proportion). Maybe proportion should be called max_hash.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 503'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949895'>File: src/sim/trace-extract/google_trace_simulator.cc:L764-785</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Ditto.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 621'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949956'>File: src/sim/trace-extract/google_trace_simulator.cc:L1022-1064</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Rename + plus comment. From what I understand the method is used to lookup machine binary from relative path and not cwd.\r\n- <a href='https://github.com/ms705'><img border=0 src='https://avatars.githubusercontent.com/u/192315?v=3' height=16 width=16'></a> Moved to `misc/utils.cc`, since this is more general functionality that will be useful outside the simulator.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_simulator.cc 703'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30949964'>File: src/sim/trace-extract/google_trace_simulator.cc:L1114-1130</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Ditto.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_task_processor.cc 15'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30950036'>File: src/sim/trace-extract/google_trace_task_processor.cc:L44-60</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Fix indentation.\r\n- [x] <a href='#crh-comment-Pull 83b765d4216539f1ec844fc76e73095f3aaecbcd src/sim/trace-extract/google_trace_task_processor.cc 165'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r30950052'>File: src/sim/trace-extract/google_trace_task_processor.cc:L900-943</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Fix.\r\n- [x] <a href='#crh-comment-Pull b8affa5c0bc5168a552370dfad9c95eaee706a5e src/scheduling/dimacs_exporter.cc 1'></a> <img src='http://www.codereviewhub.com/site/github-completed.png' height=16 width=60>&nbsp;<b><a href='https://github.com/ms705/firmament/pull/17#discussion_r31002701'>File: src/scheduling/dimacs_exporter.cc:L110-119</a></b>\r\n- <a href='https://github.com/ICGog'><img border=0 src='https://avatars.githubusercontent.com/u/433340?v=3' height=16 width=16'></a> Done.\r\n\r\n\r\n<a href='https://www.codereviewhub.com/ms705/firmament/pull/17?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/ms705/firmament/pull/17?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/ms705/firmament/pull/17'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\r\n<a href='#crh-end'></a>","created_at":"2015-05-20T15:15:38Z","updated_at":"2015-05-30T16:45:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc7f201b8e5976dedf1ca5661b2a4a01ded2e1cd","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ms705/firmament/pulls/17/commits","review_comments_url":"https://api.github.com/repos/ms705/firmament/pulls/17/comments","review_comment_url":"https://api.github.com/repos/ms705/firmament/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ms705/firmament/issues/17/comments","statuses_url":"https://api.github.com/repos/ms705/firmament/statuses/5f20b0853d96507feb3efc224e37bb425f873a92","head":{"label":"ms705:trace_simulator","ref":"trace_simulator","sha":"5f20b0853d96507feb3efc224e37bb425f873a92","user":{"login":"ms705","id":192315,"avatar_url":"https://avatars.githubusercontent.com/u/192315?v=3","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"repo":{"id":2183323,"name":"firmament","full_name":"ms705/firmament","owner":{"login":"ms705","id":192315,"avatar_url":"https://avatars.githubusercontent.com/u/192315?v=3","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ms705/firmament","description":"The Firmament cluster scheduling framework","fork":false,"url":"https://api.github.com/repos/ms705/firmament","forks_url":"https://api.github.com/repos/ms705/firmament/forks","keys_url":"https://api.github.com/repos/ms705/firmament/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ms705/firmament/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ms705/firmament/teams","hooks_url":"https://api.github.com/repos/ms705/firmament/hooks","issue_events_url":"https://api.github.com/repos/ms705/firmament/issues/events{/number}","events_url":"https://api.github.com/repos/ms705/firmament/events","assignees_url":"https://api.github.com/repos/ms705/firmament/assignees{/user}","branches_url":"https://api.github.com/repos/ms705/firmament/branches{/branch}","tags_url":"https://api.github.com/repos/ms705/firmament/tags","blobs_url":"https://api.github.com/repos/ms705/firmament/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ms705/firmament/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ms705/firmament/git/refs{/sha}","trees_url":"https://api.github.com/repos/ms705/firmament/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ms705/firmament/statuses/{sha}","languages_url":"https://api.github.com/repos/ms705/firmament/languages","stargazers_url":"https://api.github.com/repos/ms705/firmament/stargazers","contributors_url":"https://api.github.com/repos/ms705/firmament/contributors","subscribers_url":"https://api.github.com/repos/ms705/firmament/subscribers","subscription_url":"https://api.github.com/repos/ms705/firmament/subscription","commits_url":"https://api.github.com/repos/ms705/firmament/commits{/sha}","git_commits_url":"https://api.github.com/repos/ms705/firmament/git/commits{/sha}","comments_url":"https://api.github.com/repos/ms705/firmament/comments{/number}","issue_comment_url":"https://api.github.com/repos/ms705/firmament/issues/comments{/number}","contents_url":"https://api.github.com/repos/ms705/firmament/contents/{+path}","compare_url":"https://api.github.com/repos/ms705/firmament/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ms705/firmament/merges","archive_url":"https://api.github.com/repos/ms705/firmament/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ms705/firmament/downloads","issues_url":"https://api.github.com/repos/ms705/firmament/issues{/number}","pulls_url":"https://api.github.com/repos/ms705/firmament/pulls{/number}","milestones_url":"https://api.github.com/repos/ms705/firmament/milestones{/number}","notifications_url":"https://api.github.com/repos/ms705/firmament/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ms705/firmament/labels{/name}","releases_url":"https://api.github.com/repos/ms705/firmament/releases{/id}","created_at":"2011-08-10T04:34:31Z","updated_at":"2015-05-10T05:42:16Z","pushed_at":"2015-05-30T16:43:39Z","git_url":"git://github.com/ms705/firmament.git","ssh_url":"git@github.com:ms705/firmament.git","clone_url":"https://github.com/ms705/firmament.git","svn_url":"https://github.com/ms705/firmament","homepage":"http://www.cl.cam.ac.uk/netos/camsas/firmament","size":4673,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":18,"default_branch":"master"}},"base":{"label":"ms705:master","ref":"master","sha":"76bb0ca3adba4037282ec2dc9d47b50366659f5f","user":{"login":"ms705","id":192315,"avatar_url":"https://avatars.githubusercontent.com/u/192315?v=3","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"repo":{"id":2183323,"name":"firmament","full_name":"ms705/firmament","owner":{"login":"ms705","id":192315,"avatar_url":"https://avatars.githubusercontent.com/u/192315?v=3","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ms705/firmament","description":"The Firmament cluster scheduling framework","fork":false,"url":"https://api.github.com/repos/ms705/firmament","forks_url":"https://api.github.com/repos/ms705/firmament/forks","keys_url":"https://api.github.com/repos/ms705/firmament/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ms705/firmament/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ms705/firmament/teams","hooks_url":"https://api.github.com/repos/ms705/firmament/hooks","issue_events_url":"https://api.github.com/repos/ms705/firmament/issues/events{/number}","events_url":"https://api.github.com/repos/ms705/firmament/events","assignees_url":"https://api.github.com/repos/ms705/firmament/assignees{/user}","branches_url":"https://api.github.com/repos/ms705/firmament/branches{/branch}","tags_url":"https://api.github.com/repos/ms705/firmament/tags","blobs_url":"https://api.github.com/repos/ms705/firmament/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ms705/firmament/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ms705/firmament/git/refs{/sha}","trees_url":"https://api.github.com/repos/ms705/firmament/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ms705/firmament/statuses/{sha}","languages_url":"https://api.github.com/repos/ms705/firmament/languages","stargazers_url":"https://api.github.com/repos/ms705/firmament/stargazers","contributors_url":"https://api.github.com/repos/ms705/firmament/contributors","subscribers_url":"https://api.github.com/repos/ms705/firmament/subscribers","subscription_url":"https://api.github.com/repos/ms705/firmament/subscription","commits_url":"https://api.github.com/repos/ms705/firmament/commits{/sha}","git_commits_url":"https://api.github.com/repos/ms705/firmament/git/commits{/sha}","comments_url":"https://api.github.com/repos/ms705/firmament/comments{/number}","issue_comment_url":"https://api.github.com/repos/ms705/firmament/issues/comments{/number}","contents_url":"https://api.github.com/repos/ms705/firmament/contents/{+path}","compare_url":"https://api.github.com/repos/ms705/firmament/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ms705/firmament/merges","archive_url":"https://api.github.com/repos/ms705/firmament/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ms705/firmament/downloads","issues_url":"https://api.github.com/repos/ms705/firmament/issues{/number}","pulls_url":"https://api.github.com/repos/ms705/firmament/pulls{/number}","milestones_url":"https://api.github.com/repos/ms705/firmament/milestones{/number}","notifications_url":"https://api.github.com/repos/ms705/firmament/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ms705/firmament/labels{/name}","releases_url":"https://api.github.com/repos/ms705/firmament/releases{/id}","created_at":"2011-08-10T04:34:31Z","updated_at":"2015-05-10T05:42:16Z","pushed_at":"2015-05-30T16:43:39Z","git_url":"git://github.com/ms705/firmament.git","ssh_url":"git@github.com:ms705/firmament.git","clone_url":"https://github.com/ms705/firmament.git","svn_url":"https://github.com/ms705/firmament","homepage":"http://www.cl.cam.ac.uk/netos/camsas/firmament","size":4673,"stargazers_count":18,"watchers_count":18,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":5,"forks":6,"open_issues":5,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ms705/firmament/pulls/17"},"html":{"href":"https://github.com/ms705/firmament/pull/17"},"issue":{"href":"https://api.github.com/repos/ms705/firmament/issues/17"},"comments":{"href":"https://api.github.com/repos/ms705/firmament/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/ms705/firmament/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/ms705/firmament/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ms705/firmament/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/ms705/firmament/statuses/5f20b0853d96507feb3efc224e37bb425f873a92"}}}}