{"action":"created","comment":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/39935137","id":39935137,"diff_hunk":"@@ -46,6 +46,7 @@ SPIRAL_3                        0           0           0       0       0\n SPIRAL_4                        0           0           0       0       0       0       0               0\n CLUSTER                         0           0           0       0       0       0       0               0\n ELLIPTICAL                      0           0           0       0       0       0       0               0\n+DISC                            0           0           0       0       0       0       0               0","path":"default/universe_tables.txt","position":4,"original_position":4,"commit_id":"fbd09637695c683c52d5a6ed0f6b8b0929277d1d","original_commit_id":"fbd09637695c683c52d5a6ed0f6b8b0929277d1d","user":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars.githubusercontent.com/u/10279417?v=3","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"body":"Thanks a lot. I knew it had to be something simple and obvious. Facepalm moment of the day... :wink:","created_at":"2015-09-20T21:43:32Z","updated_at":"2015-09-20T21:43:32Z","html_url":"https://github.com/freeorion/freeorion/pull/352#discussion_r39935137","pull_request_url":"https://api.github.com/repos/freeorion/freeorion/pulls/352","_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments/39935137"},"html":{"href":"https://github.com/freeorion/freeorion/pull/352#discussion_r39935137"},"pull_request":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/freeorion/freeorion/pulls/352","id":45503738,"html_url":"https://github.com/freeorion/freeorion/pull/352","diff_url":"https://github.com/freeorion/freeorion/pull/352.diff","patch_url":"https://github.com/freeorion/freeorion/pull/352.patch","issue_url":"https://api.github.com/repos/freeorion/freeorion/issues/352","number":352,"state":"open","locked":false,"title":"Added new galaxy shape \"Disc\"","user":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars.githubusercontent.com/u/10279417?v=3","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"body":"Should work in theory, but causes apparently random segfaults during universe generation.\r\n\r\nWhen I replace one of the existing galaxy shapes (e.g. \"Box\") with my new one, everything works just perfectly fine. But if I *add* the new shape, and extend the `Shape` enum in `Enums.h` instead of just renaming one of its entries, all weirdness breaks loose.\r\n\r\nI can only guess that somewhere in the codebase the capacity of a list or something like that needs to be adjusted accordingly, but I'm completely stumped. Anyone any idea what I'm missing here? :confused: ","created_at":"2015-09-20T20:45:32Z","updated_at":"2015-09-20T21:43:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80b9d30eea363c10a8b10dd3e7e2ef498190a853","assignee":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars.githubusercontent.com/u/10279417?v=3","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/freeorion/freeorion/milestones/15","html_url":"https://github.com/freeorion/freeorion/milestones/Next%20release","labels_url":"https://api.github.com/repos/freeorion/freeorion/milestones/15/labels","id":1226316,"number":15,"title":"Next release","description":"Bugs, features and pull requests that should be fixed until next release.","creator":{"login":"adrianbroher","id":84891,"avatar_url":"https://avatars.githubusercontent.com/u/84891?v=3","gravatar_id":"","url":"https://api.github.com/users/adrianbroher","html_url":"https://github.com/adrianbroher","followers_url":"https://api.github.com/users/adrianbroher/followers","following_url":"https://api.github.com/users/adrianbroher/following{/other_user}","gists_url":"https://api.github.com/users/adrianbroher/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianbroher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianbroher/subscriptions","organizations_url":"https://api.github.com/users/adrianbroher/orgs","repos_url":"https://api.github.com/users/adrianbroher/repos","events_url":"https://api.github.com/users/adrianbroher/events{/privacy}","received_events_url":"https://api.github.com/users/adrianbroher/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":41,"state":"open","created_at":"2015-07-26T16:21:09Z","updated_at":"2015-09-20T20:45:32Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/freeorion/freeorion/pulls/352/commits","review_comments_url":"https://api.github.com/repos/freeorion/freeorion/pulls/352/comments","review_comment_url":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freeorion/freeorion/issues/352/comments","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/fbd09637695c683c52d5a6ed0f6b8b0929277d1d","head":{"label":"Vezzra:galaxy_shapes","ref":"galaxy_shapes","sha":"fbd09637695c683c52d5a6ed0f6b8b0929277d1d","user":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars.githubusercontent.com/u/10279417?v=3","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"repo":{"id":33499994,"name":"freeorion","full_name":"Vezzra/freeorion","owner":{"login":"Vezzra","id":10279417,"avatar_url":"https://avatars.githubusercontent.com/u/10279417?v=3","gravatar_id":"","url":"https://api.github.com/users/Vezzra","html_url":"https://github.com/Vezzra","followers_url":"https://api.github.com/users/Vezzra/followers","following_url":"https://api.github.com/users/Vezzra/following{/other_user}","gists_url":"https://api.github.com/users/Vezzra/gists{/gist_id}","starred_url":"https://api.github.com/users/Vezzra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vezzra/subscriptions","organizations_url":"https://api.github.com/users/Vezzra/orgs","repos_url":"https://api.github.com/users/Vezzra/repos","events_url":"https://api.github.com/users/Vezzra/events{/privacy}","received_events_url":"https://api.github.com/users/Vezzra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vezzra/freeorion","description":"Source code repository of the FreeOrion project.","fork":true,"url":"https://api.github.com/repos/Vezzra/freeorion","forks_url":"https://api.github.com/repos/Vezzra/freeorion/forks","keys_url":"https://api.github.com/repos/Vezzra/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vezzra/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vezzra/freeorion/teams","hooks_url":"https://api.github.com/repos/Vezzra/freeorion/hooks","issue_events_url":"https://api.github.com/repos/Vezzra/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/Vezzra/freeorion/events","assignees_url":"https://api.github.com/repos/Vezzra/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/Vezzra/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/Vezzra/freeorion/tags","blobs_url":"https://api.github.com/repos/Vezzra/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vezzra/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vezzra/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vezzra/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vezzra/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/Vezzra/freeorion/languages","stargazers_url":"https://api.github.com/repos/Vezzra/freeorion/stargazers","contributors_url":"https://api.github.com/repos/Vezzra/freeorion/contributors","subscribers_url":"https://api.github.com/repos/Vezzra/freeorion/subscribers","subscription_url":"https://api.github.com/repos/Vezzra/freeorion/subscription","commits_url":"https://api.github.com/repos/Vezzra/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vezzra/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vezzra/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vezzra/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vezzra/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/Vezzra/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vezzra/freeorion/merges","archive_url":"https://api.github.com/repos/Vezzra/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vezzra/freeorion/downloads","issues_url":"https://api.github.com/repos/Vezzra/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/Vezzra/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/Vezzra/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/Vezzra/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vezzra/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/Vezzra/freeorion/releases{/id}","created_at":"2015-04-06T19:07:48Z","updated_at":"2015-05-08T09:53:21Z","pushed_at":"2015-09-20T20:37:17Z","git_url":"git://github.com/Vezzra/freeorion.git","ssh_url":"git@github.com:Vezzra/freeorion.git","clone_url":"https://github.com/Vezzra/freeorion.git","svn_url":"https://github.com/Vezzra/freeorion","homepage":"http://www.freeorion.org/","size":491803,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freeorion:master","ref":"master","sha":"a1b897376cfc03b5f34b9d1032299e1a0d85b0a1","user":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"repo":{"id":33066062,"name":"freeorion","full_name":"freeorion/freeorion","owner":{"login":"freeorion","id":1025550,"avatar_url":"https://avatars.githubusercontent.com/u/1025550?v=3","gravatar_id":"","url":"https://api.github.com/users/freeorion","html_url":"https://github.com/freeorion","followers_url":"https://api.github.com/users/freeorion/followers","following_url":"https://api.github.com/users/freeorion/following{/other_user}","gists_url":"https://api.github.com/users/freeorion/gists{/gist_id}","starred_url":"https://api.github.com/users/freeorion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freeorion/subscriptions","organizations_url":"https://api.github.com/users/freeorion/orgs","repos_url":"https://api.github.com/users/freeorion/repos","events_url":"https://api.github.com/users/freeorion/events{/privacy}","received_events_url":"https://api.github.com/users/freeorion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freeorion/freeorion","description":"Source code repository of the FreeOrion project.","fork":false,"url":"https://api.github.com/repos/freeorion/freeorion","forks_url":"https://api.github.com/repos/freeorion/freeorion/forks","keys_url":"https://api.github.com/repos/freeorion/freeorion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freeorion/freeorion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freeorion/freeorion/teams","hooks_url":"https://api.github.com/repos/freeorion/freeorion/hooks","issue_events_url":"https://api.github.com/repos/freeorion/freeorion/issues/events{/number}","events_url":"https://api.github.com/repos/freeorion/freeorion/events","assignees_url":"https://api.github.com/repos/freeorion/freeorion/assignees{/user}","branches_url":"https://api.github.com/repos/freeorion/freeorion/branches{/branch}","tags_url":"https://api.github.com/repos/freeorion/freeorion/tags","blobs_url":"https://api.github.com/repos/freeorion/freeorion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freeorion/freeorion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freeorion/freeorion/git/refs{/sha}","trees_url":"https://api.github.com/repos/freeorion/freeorion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freeorion/freeorion/statuses/{sha}","languages_url":"https://api.github.com/repos/freeorion/freeorion/languages","stargazers_url":"https://api.github.com/repos/freeorion/freeorion/stargazers","contributors_url":"https://api.github.com/repos/freeorion/freeorion/contributors","subscribers_url":"https://api.github.com/repos/freeorion/freeorion/subscribers","subscription_url":"https://api.github.com/repos/freeorion/freeorion/subscription","commits_url":"https://api.github.com/repos/freeorion/freeorion/commits{/sha}","git_commits_url":"https://api.github.com/repos/freeorion/freeorion/git/commits{/sha}","comments_url":"https://api.github.com/repos/freeorion/freeorion/comments{/number}","issue_comment_url":"https://api.github.com/repos/freeorion/freeorion/issues/comments{/number}","contents_url":"https://api.github.com/repos/freeorion/freeorion/contents/{+path}","compare_url":"https://api.github.com/repos/freeorion/freeorion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freeorion/freeorion/merges","archive_url":"https://api.github.com/repos/freeorion/freeorion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freeorion/freeorion/downloads","issues_url":"https://api.github.com/repos/freeorion/freeorion/issues{/number}","pulls_url":"https://api.github.com/repos/freeorion/freeorion/pulls{/number}","milestones_url":"https://api.github.com/repos/freeorion/freeorion/milestones{/number}","notifications_url":"https://api.github.com/repos/freeorion/freeorion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freeorion/freeorion/labels{/name}","releases_url":"https://api.github.com/repos/freeorion/freeorion/releases{/id}","created_at":"2015-03-29T08:22:20Z","updated_at":"2015-09-16T12:41:58Z","pushed_at":"2015-09-20T20:45:33Z","git_url":"git://github.com/freeorion/freeorion.git","ssh_url":"git@github.com:freeorion/freeorion.git","clone_url":"https://github.com/freeorion/freeorion.git","svn_url":"https://github.com/freeorion/freeorion","homepage":"http://www.freeorion.org/","size":506364,"stargazers_count":84,"watchers_count":84,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":15,"forks":38,"open_issues":15,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/352"},"html":{"href":"https://github.com/freeorion/freeorion/pull/352"},"issue":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/352"},"comments":{"href":"https://api.github.com/repos/freeorion/freeorion/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freeorion/freeorion/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/freeorion/freeorion/statuses/fbd09637695c683c52d5a6ed0f6b8b0929277d1d"}}}}