{"action":"created","comment":{"url":"https://api.github.com/repos/laravel/framework/pulls/comments/31710693","id":31710693,"diff_hunk":"@@ -169,6 +169,20 @@ class Builder\n     protected $backups = [];\n \n     /**\n+     * These are the fields that we backup when doing counts\n+     *\n+     * @var string\n+     */\n+    protected $backupFields = ['orders', 'limit', 'offset', 'columns'];\n+\n+    /**\n+     * These are additional fields we backup when doing counts with groups","path":"src/Illuminate/Database/Query/Builder.php","position":11,"original_position":11,"commit_id":"14a95862313e0bc6f5bb76757149feda7a264b90","original_commit_id":"14a95862313e0bc6f5bb76757149feda7a264b90","user":{"login":"GrahamCampbell","id":2829600,"avatar_url":"https://avatars.githubusercontent.com/u/2829600?v=3","gravatar_id":"","url":"https://api.github.com/users/GrahamCampbell","html_url":"https://github.com/GrahamCampbell","followers_url":"https://api.github.com/users/GrahamCampbell/followers","following_url":"https://api.github.com/users/GrahamCampbell/following{/other_user}","gists_url":"https://api.github.com/users/GrahamCampbell/gists{/gist_id}","starred_url":"https://api.github.com/users/GrahamCampbell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrahamCampbell/subscriptions","organizations_url":"https://api.github.com/users/GrahamCampbell/orgs","repos_url":"https://api.github.com/users/GrahamCampbell/repos","events_url":"https://api.github.com/users/GrahamCampbell/events{/privacy}","received_events_url":"https://api.github.com/users/GrahamCampbell/received_events","type":"User","site_admin":false},"body":"Please end the description in a fullstop.","created_at":"2015-06-04T11:00:07Z","updated_at":"2015-06-04T11:00:07Z","html_url":"https://github.com/laravel/framework/pull/9055#discussion_r31710693","pull_request_url":"https://api.github.com/repos/laravel/framework/pulls/9055","_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments/31710693"},"html":{"href":"https://github.com/laravel/framework/pull/9055#discussion_r31710693"},"pull_request":{"href":"https://api.github.com/repos/laravel/framework/pulls/9055"}}},"pull_request":{"url":"https://api.github.com/repos/laravel/framework/pulls/9055","id":36921770,"html_url":"https://github.com/laravel/framework/pull/9055","diff_url":"https://github.com/laravel/framework/pull/9055.diff","patch_url":"https://github.com/laravel/framework/pull/9055.patch","issue_url":"https://api.github.com/repos/laravel/framework/issues/9055","number":9055,"state":"open","locked":false,"title":"Fix for the Pagination Query that selected all rows from a table and would fail on large datasets","user":{"login":"mxaddict","id":1060905,"avatar_url":"https://avatars.githubusercontent.com/u/1060905?v=3","gravatar_id":"","url":"https://api.github.com/users/mxaddict","html_url":"https://github.com/mxaddict","followers_url":"https://api.github.com/users/mxaddict/followers","following_url":"https://api.github.com/users/mxaddict/following{/other_user}","gists_url":"https://api.github.com/users/mxaddict/gists{/gist_id}","starred_url":"https://api.github.com/users/mxaddict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxaddict/subscriptions","organizations_url":"https://api.github.com/users/mxaddict/orgs","repos_url":"https://api.github.com/users/mxaddict/repos","events_url":"https://api.github.com/users/mxaddict/events{/privacy}","received_events_url":"https://api.github.com/users/mxaddict/received_events","type":"User","site_admin":false},"body":"Implemented my 4.2.x Fix for the pagination count query into 5.1.x\r\n\r\nFix for the Pagination Query that selected all rows from a table and would fail on large datasets","created_at":"2015-06-04T10:35:21Z","updated_at":"2015-06-04T11:00:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0dc2b7e1e9bfa0631ef1b107663bc3c0d342736","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/laravel/framework/pulls/9055/commits","review_comments_url":"https://api.github.com/repos/laravel/framework/pulls/9055/comments","review_comment_url":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/framework/issues/9055/comments","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/14a95862313e0bc6f5bb76757149feda7a264b90","head":{"label":"mxaddict:5.1","ref":"5.1","sha":"14a95862313e0bc6f5bb76757149feda7a264b90","user":{"login":"mxaddict","id":1060905,"avatar_url":"https://avatars.githubusercontent.com/u/1060905?v=3","gravatar_id":"","url":"https://api.github.com/users/mxaddict","html_url":"https://github.com/mxaddict","followers_url":"https://api.github.com/users/mxaddict/followers","following_url":"https://api.github.com/users/mxaddict/following{/other_user}","gists_url":"https://api.github.com/users/mxaddict/gists{/gist_id}","starred_url":"https://api.github.com/users/mxaddict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxaddict/subscriptions","organizations_url":"https://api.github.com/users/mxaddict/orgs","repos_url":"https://api.github.com/users/mxaddict/repos","events_url":"https://api.github.com/users/mxaddict/events{/privacy}","received_events_url":"https://api.github.com/users/mxaddict/received_events","type":"User","site_admin":false},"repo":{"id":36835191,"name":"framework","full_name":"mxaddict/framework","owner":{"login":"mxaddict","id":1060905,"avatar_url":"https://avatars.githubusercontent.com/u/1060905?v=3","gravatar_id":"","url":"https://api.github.com/users/mxaddict","html_url":"https://github.com/mxaddict","followers_url":"https://api.github.com/users/mxaddict/followers","following_url":"https://api.github.com/users/mxaddict/following{/other_user}","gists_url":"https://api.github.com/users/mxaddict/gists{/gist_id}","starred_url":"https://api.github.com/users/mxaddict/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mxaddict/subscriptions","organizations_url":"https://api.github.com/users/mxaddict/orgs","repos_url":"https://api.github.com/users/mxaddict/repos","events_url":"https://api.github.com/users/mxaddict/events{/privacy}","received_events_url":"https://api.github.com/users/mxaddict/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mxaddict/framework","description":"","fork":true,"url":"https://api.github.com/repos/mxaddict/framework","forks_url":"https://api.github.com/repos/mxaddict/framework/forks","keys_url":"https://api.github.com/repos/mxaddict/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mxaddict/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mxaddict/framework/teams","hooks_url":"https://api.github.com/repos/mxaddict/framework/hooks","issue_events_url":"https://api.github.com/repos/mxaddict/framework/issues/events{/number}","events_url":"https://api.github.com/repos/mxaddict/framework/events","assignees_url":"https://api.github.com/repos/mxaddict/framework/assignees{/user}","branches_url":"https://api.github.com/repos/mxaddict/framework/branches{/branch}","tags_url":"https://api.github.com/repos/mxaddict/framework/tags","blobs_url":"https://api.github.com/repos/mxaddict/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mxaddict/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mxaddict/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/mxaddict/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mxaddict/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/mxaddict/framework/languages","stargazers_url":"https://api.github.com/repos/mxaddict/framework/stargazers","contributors_url":"https://api.github.com/repos/mxaddict/framework/contributors","subscribers_url":"https://api.github.com/repos/mxaddict/framework/subscribers","subscription_url":"https://api.github.com/repos/mxaddict/framework/subscription","commits_url":"https://api.github.com/repos/mxaddict/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/mxaddict/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/mxaddict/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/mxaddict/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/mxaddict/framework/contents/{+path}","compare_url":"https://api.github.com/repos/mxaddict/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mxaddict/framework/merges","archive_url":"https://api.github.com/repos/mxaddict/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mxaddict/framework/downloads","issues_url":"https://api.github.com/repos/mxaddict/framework/issues{/number}","pulls_url":"https://api.github.com/repos/mxaddict/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/mxaddict/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/mxaddict/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mxaddict/framework/labels{/name}","releases_url":"https://api.github.com/repos/mxaddict/framework/releases{/id}","created_at":"2015-06-03T22:56:06Z","updated_at":"2015-06-03T22:56:09Z","pushed_at":"2015-06-04T10:33:20Z","git_url":"git://github.com/mxaddict/framework.git","ssh_url":"git@github.com:mxaddict/framework.git","clone_url":"https://github.com/mxaddict/framework.git","svn_url":"https://github.com/mxaddict/framework","homepage":"http://laravel.com","size":70113,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"5.0"}},"base":{"label":"laravel:5.1","ref":"5.1","sha":"73ad2636ced1219d6170d4352e091a51a885feb7","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":7548986,"name":"framework","full_name":"laravel/framework","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars.githubusercontent.com/u/958072?v=3","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/framework","description":"","fork":false,"url":"https://api.github.com/repos/laravel/framework","forks_url":"https://api.github.com/repos/laravel/framework/forks","keys_url":"https://api.github.com/repos/laravel/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/framework/teams","hooks_url":"https://api.github.com/repos/laravel/framework/hooks","issue_events_url":"https://api.github.com/repos/laravel/framework/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/framework/events","assignees_url":"https://api.github.com/repos/laravel/framework/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/framework/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/framework/tags","blobs_url":"https://api.github.com/repos/laravel/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/framework/languages","stargazers_url":"https://api.github.com/repos/laravel/framework/stargazers","contributors_url":"https://api.github.com/repos/laravel/framework/contributors","subscribers_url":"https://api.github.com/repos/laravel/framework/subscribers","subscription_url":"https://api.github.com/repos/laravel/framework/subscription","commits_url":"https://api.github.com/repos/laravel/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/framework/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/framework/merges","archive_url":"https://api.github.com/repos/laravel/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/framework/downloads","issues_url":"https://api.github.com/repos/laravel/framework/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/framework/labels{/name}","releases_url":"https://api.github.com/repos/laravel/framework/releases{/id}","created_at":"2013-01-10T21:27:28Z","updated_at":"2015-06-03T18:47:08Z","pushed_at":"2015-06-04T10:35:22Z","git_url":"git://github.com/laravel/framework.git","ssh_url":"git@github.com:laravel/framework.git","clone_url":"https://github.com/laravel/framework.git","svn_url":"https://github.com/laravel/framework","homepage":"http://laravel.com","size":70113,"stargazers_count":3666,"watchers_count":3666,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2025,"mirror_url":null,"open_issues_count":70,"forks":2025,"open_issues":70,"watchers":3666,"default_branch":"5.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/framework/pulls/9055"},"html":{"href":"https://github.com/laravel/framework/pull/9055"},"issue":{"href":"https://api.github.com/repos/laravel/framework/issues/9055"},"comments":{"href":"https://api.github.com/repos/laravel/framework/issues/9055/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/framework/pulls/9055/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/framework/pulls/9055/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/framework/statuses/14a95862313e0bc6f5bb76757149feda7a264b90"}}}}