{"push_id":716034998,"size":4,"distinct_size":4,"ref":"refs/heads/2.3","head":"8a8a929d5c9046fe599623beba91cd9d17ef9e5a","before":"7c36f0b9a05e04baec83d81074fe25c67f31d7be","commits":[{"sha":"5f4015c3cded4f20f6333c60bd52156bc70b0086","author":{"email":"8d3fadd4fad95f65a95a07af54a8b1c515d4d5e3@gmail.com","name":"Nicolas Grekas"},"message":"Enhance hhvm test skip message","distinct":true,"url":"https://api.github.com/repos/keradus/symfony/commits/5f4015c3cded4f20f6333c60bd52156bc70b0086"},{"sha":"9fcad381be6a29aa47f9fca212e46f4bd66828c7","author":{"email":"d4f8dcd89cfe40276c0fbf336903f4a05ab082c9@gmail.com","name":"Fabien Potencier"},"message":"minor #15187 Enhance hhvm test skip message (nicolas-grekas)\n\nThis PR was merged into the 2.3 branch.\n\nDiscussion\n----------\n\nEnhance hhvm test skip message\n\n| Q             | A\n| ------------- | ---\n| Bug fix?      | no\n| New feature?  | no\n| BC breaks?    | no\n| Deprecations? | no\n| Tests pass?   | yes\n| Fixed tickets | -\n| License       | MIT\n| Doc PR        | -\n\nReading our blog about hhvm (http://symfony.com/blog/symfony-2-3-achieves-100-hhvm-compatibility)\nI'd like to improve the only single test skip in our code base that exists for hhvm.\n\nHHVM does not trigger strict notices. This is a missing feature of the HHVM parser (https://github.com/facebook/hhvm/issues/5583). But this does not affect in any way the behavior of any PHP app. Strict notices are only for the dev stage.\n\nThere is some FUD-friendliness in the article and in the comments (no offence @javiereguiluz ☮):\n100% hhvm compat is 100% honest. We did not skip any single tests because of errors, issues nor bugs. And the single missing \"feature\" of hhvm is this one: strict notices. Kudos to hhvm for what they did: parity is close enough so that the delta can be handled in exactly the same way as we handle deltas between PHP versions.\n\nCommits\n-------\n\n5f4015c Enhance hhvm test skip message","distinct":true,"url":"https://api.github.com/repos/keradus/symfony/commits/9fcad381be6a29aa47f9fca212e46f4bd66828c7"},{"sha":"da5218f2ae7fb3724c08dbe047e196766374ac49","author":{"email":"bfcdf3e6ca6cef45543bfbb57509c92aec9a39fb@wearebase.com","name":"Dave Hulbert"},"message":"Remove var not used due to returning early (introduced in 8982c32)","distinct":true,"url":"https://api.github.com/repos/keradus/symfony/commits/da5218f2ae7fb3724c08dbe047e196766374ac49"},{"sha":"8a8a929d5c9046fe599623beba91cd9d17ef9e5a","author":{"email":"50f3f01caa053693ce619d596e14b0ff3901ab49@tubo-world.de","name":"Tobias Schultze"},"message":"minor #15198 [HttpFoundation] Remove unused var (Dave Hulbert)\n\nThis PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #15198).\n\nDiscussion\n----------\n\n[HttpFoundation] Remove unused var\n\nMinor. Looks like the var `$content` got introduced in aa5e6165, then in 8982c324 the early return meant it wasn't needed.\n\n| Q             | A\n| ------------- | ---\n| Fixed tickets | N/A\n| License       | MIT\n\nCommits\n-------\n\nda5218f Remove var not used due to returning early (introduced in 8982c32)","distinct":true,"url":"https://api.github.com/repos/keradus/symfony/commits/8a8a929d5c9046fe599623beba91cd9d17ef9e5a"}]}