{"action":"created","comment":{"url":"https://api.github.com/repos/samclarke/SCEditor/pulls/comments/30509726","id":30509726,"diff_hunk":"@@ -69,8 +69,8 @@ define(function (require) {\n \n \t\toptions = options || {};\n \n-\t\tif (!options.runWithoutWysiwygSupport && !browser.isWysiwygSupported) {\n-\t\t\treturn;\n+\t\tif (options.runWithoutWysiwygSupport || !browser.isWysiwygSupported) {\n+\t\t\tSCEditor.isWysiwygSupported = false;","path":"src/jquery.sceditor.js","position":7,"original_position":7,"commit_id":"3a217a37b67d6219a35bb78862eca88f023dc050","original_commit_id":"3a217a37b67d6219a35bb78862eca88f023dc050","user":{"login":"samclarke","id":490870,"avatar_url":"https://avatars.githubusercontent.com/u/490870?v=3","gravatar_id":"","url":"https://api.github.com/users/samclarke","html_url":"https://github.com/samclarke","followers_url":"https://api.github.com/users/samclarke/followers","following_url":"https://api.github.com/users/samclarke/following{/other_user}","gists_url":"https://api.github.com/users/samclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/samclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samclarke/subscriptions","organizations_url":"https://api.github.com/users/samclarke/orgs","repos_url":"https://api.github.com/users/samclarke/repos","events_url":"https://api.github.com/users/samclarke/events{/privacy}","received_events_url":"https://api.github.com/users/samclarke/received_events","type":"User","site_admin":false},"body":"Oh, do you mean force source mode only regardless of WYSIWYG support?\r\n\r\nThe `runWithoutWysiwygSupport` option is to make the editor run when there is no browser WYSIWYG support. This is what it should do:\r\n\r\n| WYSIWYG supported | Run without WYSIWYG |       Mode       |\r\n|:-----------------:|:-------------------:|:----------------:|\r\n|        Yes        |         Yes         |        Any       |\r\n|        Yes        |          No         |        Any       |\r\n|         No        |         Yes         | Source mode only |\r\n|         No        |          No         |     Disabled     |\r\n\r\nForcing the editor to only run in source mode, regardless of if the browser supports WYSIWYG, isn't what `runWithoutWysiwygSupport` option is for. `runWithoutWysiwygSupport` is for what to do if there's no browser WYSIWYG support.","created_at":"2015-05-18T14:05:06Z","updated_at":"2015-05-18T14:05:06Z","html_url":"https://github.com/samclarke/SCEditor/pull/445#discussion_r30509726","pull_request_url":"https://api.github.com/repos/samclarke/SCEditor/pulls/445","_links":{"self":{"href":"https://api.github.com/repos/samclarke/SCEditor/pulls/comments/30509726"},"html":{"href":"https://github.com/samclarke/SCEditor/pull/445#discussion_r30509726"},"pull_request":{"href":"https://api.github.com/repos/samclarke/SCEditor/pulls/445"}}},"pull_request":{"url":"https://api.github.com/repos/samclarke/SCEditor/pulls/445","id":35629318,"html_url":"https://github.com/samclarke/SCEditor/pull/445","diff_url":"https://github.com/samclarke/SCEditor/pull/445.diff","patch_url":"https://github.com/samclarke/SCEditor/pull/445.patch","issue_url":"https://api.github.com/repos/samclarke/SCEditor/issues/445","number":445,"state":"open","locked":false,"title":"Fixes #444. Running in source mode only was not checking properly","user":{"login":"brunoais","id":639467,"avatar_url":"https://avatars.githubusercontent.com/u/639467?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoais","html_url":"https://github.com/brunoais","followers_url":"https://api.github.com/users/brunoais/followers","following_url":"https://api.github.com/users/brunoais/following{/other_user}","gists_url":"https://api.github.com/users/brunoais/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoais/subscriptions","organizations_url":"https://api.github.com/users/brunoais/orgs","repos_url":"https://api.github.com/users/brunoais/repos","events_url":"https://api.github.com/users/brunoais/events{/privacy}","received_events_url":"https://api.github.com/users/brunoais/received_events","type":"User","site_admin":false},"body":"@samclarke Please check on this.","created_at":"2015-05-18T12:41:24Z","updated_at":"2015-05-18T14:05:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"183f07953b5e0593c13c4853579622847545a24a","assignee":{"login":"brunoais","id":639467,"avatar_url":"https://avatars.githubusercontent.com/u/639467?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoais","html_url":"https://github.com/brunoais","followers_url":"https://api.github.com/users/brunoais/followers","following_url":"https://api.github.com/users/brunoais/following{/other_user}","gists_url":"https://api.github.com/users/brunoais/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoais/subscriptions","organizations_url":"https://api.github.com/users/brunoais/orgs","repos_url":"https://api.github.com/users/brunoais/repos","events_url":"https://api.github.com/users/brunoais/events{/privacy}","received_events_url":"https://api.github.com/users/brunoais/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/samclarke/SCEditor/milestones/7","html_url":"https://github.com/samclarke/SCEditor/milestones/v1.5.0","labels_url":"https://api.github.com/repos/samclarke/SCEditor/milestones/7/labels","id":752583,"number":7,"title":"v1.5.0","description":"","creator":{"login":"samclarke","id":490870,"avatar_url":"https://avatars.githubusercontent.com/u/490870?v=3","gravatar_id":"","url":"https://api.github.com/users/samclarke","html_url":"https://github.com/samclarke","followers_url":"https://api.github.com/users/samclarke/followers","following_url":"https://api.github.com/users/samclarke/following{/other_user}","gists_url":"https://api.github.com/users/samclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/samclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samclarke/subscriptions","organizations_url":"https://api.github.com/users/samclarke/orgs","repos_url":"https://api.github.com/users/samclarke/repos","events_url":"https://api.github.com/users/samclarke/events{/privacy}","received_events_url":"https://api.github.com/users/samclarke/received_events","type":"User","site_admin":false},"open_issues":22,"closed_issues":11,"state":"open","created_at":"2014-08-13T18:10:34Z","updated_at":"2015-05-18T12:55:14Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/samclarke/SCEditor/pulls/445/commits","review_comments_url":"https://api.github.com/repos/samclarke/SCEditor/pulls/445/comments","review_comment_url":"https://api.github.com/repos/samclarke/SCEditor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/samclarke/SCEditor/issues/445/comments","statuses_url":"https://api.github.com/repos/samclarke/SCEditor/statuses/3a217a37b67d6219a35bb78862eca88f023dc050","head":{"label":"brunoais:fix/444","ref":"fix/444","sha":"3a217a37b67d6219a35bb78862eca88f023dc050","user":{"login":"brunoais","id":639467,"avatar_url":"https://avatars.githubusercontent.com/u/639467?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoais","html_url":"https://github.com/brunoais","followers_url":"https://api.github.com/users/brunoais/followers","following_url":"https://api.github.com/users/brunoais/following{/other_user}","gists_url":"https://api.github.com/users/brunoais/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoais/subscriptions","organizations_url":"https://api.github.com/users/brunoais/orgs","repos_url":"https://api.github.com/users/brunoais/repos","events_url":"https://api.github.com/users/brunoais/events{/privacy}","received_events_url":"https://api.github.com/users/brunoais/received_events","type":"User","site_admin":false},"repo":{"id":6545972,"name":"SCEditor","full_name":"brunoais/SCEditor","owner":{"login":"brunoais","id":639467,"avatar_url":"https://avatars.githubusercontent.com/u/639467?v=3","gravatar_id":"","url":"https://api.github.com/users/brunoais","html_url":"https://github.com/brunoais","followers_url":"https://api.github.com/users/brunoais/followers","following_url":"https://api.github.com/users/brunoais/following{/other_user}","gists_url":"https://api.github.com/users/brunoais/gists{/gist_id}","starred_url":"https://api.github.com/users/brunoais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brunoais/subscriptions","organizations_url":"https://api.github.com/users/brunoais/orgs","repos_url":"https://api.github.com/users/brunoais/repos","events_url":"https://api.github.com/users/brunoais/events{/privacy}","received_events_url":"https://api.github.com/users/brunoais/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brunoais/SCEditor","description":"A lightweight HTML and BBCode WYSIWYG editor","fork":true,"url":"https://api.github.com/repos/brunoais/SCEditor","forks_url":"https://api.github.com/repos/brunoais/SCEditor/forks","keys_url":"https://api.github.com/repos/brunoais/SCEditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brunoais/SCEditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brunoais/SCEditor/teams","hooks_url":"https://api.github.com/repos/brunoais/SCEditor/hooks","issue_events_url":"https://api.github.com/repos/brunoais/SCEditor/issues/events{/number}","events_url":"https://api.github.com/repos/brunoais/SCEditor/events","assignees_url":"https://api.github.com/repos/brunoais/SCEditor/assignees{/user}","branches_url":"https://api.github.com/repos/brunoais/SCEditor/branches{/branch}","tags_url":"https://api.github.com/repos/brunoais/SCEditor/tags","blobs_url":"https://api.github.com/repos/brunoais/SCEditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brunoais/SCEditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brunoais/SCEditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/brunoais/SCEditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brunoais/SCEditor/statuses/{sha}","languages_url":"https://api.github.com/repos/brunoais/SCEditor/languages","stargazers_url":"https://api.github.com/repos/brunoais/SCEditor/stargazers","contributors_url":"https://api.github.com/repos/brunoais/SCEditor/contributors","subscribers_url":"https://api.github.com/repos/brunoais/SCEditor/subscribers","subscription_url":"https://api.github.com/repos/brunoais/SCEditor/subscription","commits_url":"https://api.github.com/repos/brunoais/SCEditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/brunoais/SCEditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/brunoais/SCEditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/brunoais/SCEditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/brunoais/SCEditor/contents/{+path}","compare_url":"https://api.github.com/repos/brunoais/SCEditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brunoais/SCEditor/merges","archive_url":"https://api.github.com/repos/brunoais/SCEditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brunoais/SCEditor/downloads","issues_url":"https://api.github.com/repos/brunoais/SCEditor/issues{/number}","pulls_url":"https://api.github.com/repos/brunoais/SCEditor/pulls{/number}","milestones_url":"https://api.github.com/repos/brunoais/SCEditor/milestones{/number}","notifications_url":"https://api.github.com/repos/brunoais/SCEditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brunoais/SCEditor/labels{/name}","releases_url":"https://api.github.com/repos/brunoais/SCEditor/releases{/id}","created_at":"2012-11-05T14:51:02Z","updated_at":"2015-05-06T08:35:01Z","pushed_at":"2015-05-18T13:00:40Z","git_url":"git://github.com/brunoais/SCEditor.git","ssh_url":"git@github.com:brunoais/SCEditor.git","clone_url":"https://github.com/brunoais/SCEditor.git","svn_url":"https://github.com/brunoais/SCEditor","homepage":"http://www.sceditor.com/","size":6702,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"samclarke:master","ref":"master","sha":"50d1d3aab2ec88db7016021cbfbd51f940c3501c","user":{"login":"samclarke","id":490870,"avatar_url":"https://avatars.githubusercontent.com/u/490870?v=3","gravatar_id":"","url":"https://api.github.com/users/samclarke","html_url":"https://github.com/samclarke","followers_url":"https://api.github.com/users/samclarke/followers","following_url":"https://api.github.com/users/samclarke/following{/other_user}","gists_url":"https://api.github.com/users/samclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/samclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samclarke/subscriptions","organizations_url":"https://api.github.com/users/samclarke/orgs","repos_url":"https://api.github.com/users/samclarke/repos","events_url":"https://api.github.com/users/samclarke/events{/privacy}","received_events_url":"https://api.github.com/users/samclarke/received_events","type":"User","site_admin":false},"repo":{"id":2067414,"name":"SCEditor","full_name":"samclarke/SCEditor","owner":{"login":"samclarke","id":490870,"avatar_url":"https://avatars.githubusercontent.com/u/490870?v=3","gravatar_id":"","url":"https://api.github.com/users/samclarke","html_url":"https://github.com/samclarke","followers_url":"https://api.github.com/users/samclarke/followers","following_url":"https://api.github.com/users/samclarke/following{/other_user}","gists_url":"https://api.github.com/users/samclarke/gists{/gist_id}","starred_url":"https://api.github.com/users/samclarke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samclarke/subscriptions","organizations_url":"https://api.github.com/users/samclarke/orgs","repos_url":"https://api.github.com/users/samclarke/repos","events_url":"https://api.github.com/users/samclarke/events{/privacy}","received_events_url":"https://api.github.com/users/samclarke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samclarke/SCEditor","description":"A lightweight HTML and BBCode WYSIWYG editor","fork":false,"url":"https://api.github.com/repos/samclarke/SCEditor","forks_url":"https://api.github.com/repos/samclarke/SCEditor/forks","keys_url":"https://api.github.com/repos/samclarke/SCEditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samclarke/SCEditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samclarke/SCEditor/teams","hooks_url":"https://api.github.com/repos/samclarke/SCEditor/hooks","issue_events_url":"https://api.github.com/repos/samclarke/SCEditor/issues/events{/number}","events_url":"https://api.github.com/repos/samclarke/SCEditor/events","assignees_url":"https://api.github.com/repos/samclarke/SCEditor/assignees{/user}","branches_url":"https://api.github.com/repos/samclarke/SCEditor/branches{/branch}","tags_url":"https://api.github.com/repos/samclarke/SCEditor/tags","blobs_url":"https://api.github.com/repos/samclarke/SCEditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samclarke/SCEditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samclarke/SCEditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/samclarke/SCEditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samclarke/SCEditor/statuses/{sha}","languages_url":"https://api.github.com/repos/samclarke/SCEditor/languages","stargazers_url":"https://api.github.com/repos/samclarke/SCEditor/stargazers","contributors_url":"https://api.github.com/repos/samclarke/SCEditor/contributors","subscribers_url":"https://api.github.com/repos/samclarke/SCEditor/subscribers","subscription_url":"https://api.github.com/repos/samclarke/SCEditor/subscription","commits_url":"https://api.github.com/repos/samclarke/SCEditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/samclarke/SCEditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/samclarke/SCEditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/samclarke/SCEditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/samclarke/SCEditor/contents/{+path}","compare_url":"https://api.github.com/repos/samclarke/SCEditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samclarke/SCEditor/merges","archive_url":"https://api.github.com/repos/samclarke/SCEditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samclarke/SCEditor/downloads","issues_url":"https://api.github.com/repos/samclarke/SCEditor/issues{/number}","pulls_url":"https://api.github.com/repos/samclarke/SCEditor/pulls{/number}","milestones_url":"https://api.github.com/repos/samclarke/SCEditor/milestones{/number}","notifications_url":"https://api.github.com/repos/samclarke/SCEditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samclarke/SCEditor/labels{/name}","releases_url":"https://api.github.com/repos/samclarke/SCEditor/releases{/id}","created_at":"2011-07-18T16:46:44Z","updated_at":"2015-05-16T12:36:37Z","pushed_at":"2015-05-18T13:00:41Z","git_url":"git://github.com/samclarke/SCEditor.git","ssh_url":"git@github.com:samclarke/SCEditor.git","clone_url":"https://github.com/samclarke/SCEditor.git","svn_url":"https://github.com/samclarke/SCEditor","homepage":"http://www.sceditor.com/","size":8168,"stargazers_count":229,"watchers_count":229,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"open_issues_count":101,"forks":103,"open_issues":101,"watchers":229,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/samclarke/SCEditor/pulls/445"},"html":{"href":"https://github.com/samclarke/SCEditor/pull/445"},"issue":{"href":"https://api.github.com/repos/samclarke/SCEditor/issues/445"},"comments":{"href":"https://api.github.com/repos/samclarke/SCEditor/issues/445/comments"},"review_comments":{"href":"https://api.github.com/repos/samclarke/SCEditor/pulls/445/comments"},"review_comment":{"href":"https://api.github.com/repos/samclarke/SCEditor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/samclarke/SCEditor/pulls/445/commits"},"statuses":{"href":"https://api.github.com/repos/samclarke/SCEditor/statuses/3a217a37b67d6219a35bb78862eca88f023dc050"}}}}