{"action":"created","comment":{"url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments/28255095","id":28255095,"diff_hunk":"@@ -412,31 +362,23 @@ public static String getNamespaceUri(XmlNamespace xmlNamespace) {\n    * @return the namespace from uri\n    */\n   public static XmlNamespace getNamespaceFromUri(String namespaceUri) {\n-    if (namespaceUri.equals(EwsErrorsNamespace)) {\n+    if (EwsErrorsNamespace.equals(namespaceUri)) {\n       return XmlNamespace.Errors;\n-    }\n-    if (namespaceUri.equals(EwsTypesNamespace)) {\n+    } else if (EwsTypesNamespace.equals(namespaceUri)) {","path":"src/main/java/microsoft/exchange/webservices/data/core/EwsUtilities.java","position":183,"original_position":183,"commit_id":"703f1b1f827b2d420b3e9865ebe5581b4fde9f4f","original_commit_id":"703f1b1f827b2d420b3e9865ebe5581b4fde9f4f","user":{"login":"vboctor","id":6446,"avatar_url":"https://avatars.githubusercontent.com/u/6446?v=3","gravatar_id":"","url":"https://api.github.com/users/vboctor","html_url":"https://github.com/vboctor","followers_url":"https://api.github.com/users/vboctor/followers","following_url":"https://api.github.com/users/vboctor/following{/other_user}","gists_url":"https://api.github.com/users/vboctor/gists{/gist_id}","starred_url":"https://api.github.com/users/vboctor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vboctor/subscriptions","organizations_url":"https://api.github.com/users/vboctor/orgs","repos_url":"https://api.github.com/users/vboctor/repos","events_url":"https://api.github.com/users/vboctor/events{/privacy}","received_events_url":"https://api.github.com/users/vboctor/received_events","type":"User","site_admin":false},"body":"Why the else if, given that the blocks from previous if returns?","created_at":"2015-04-13T16:43:58Z","updated_at":"2015-04-13T16:43:58Z","html_url":"https://github.com/OfficeDev/ews-java-api/pull/290#discussion_r28255095","pull_request_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290","_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments/28255095"},"html":{"href":"https://github.com/OfficeDev/ews-java-api/pull/290#discussion_r28255095"},"pull_request":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290"}}},"pull_request":{"url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290","id":33124975,"html_url":"https://github.com/OfficeDev/ews-java-api/pull/290","diff_url":"https://github.com/OfficeDev/ews-java-api/pull/290.diff","patch_url":"https://github.com/OfficeDev/ews-java-api/pull/290.patch","issue_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/290","number":290,"state":"open","locked":false,"title":"Optimize EwsUtilities","user":{"login":"vbauer","id":578021,"avatar_url":"https://avatars.githubusercontent.com/u/578021?v=3","gravatar_id":"","url":"https://api.github.com/users/vbauer","html_url":"https://github.com/vbauer","followers_url":"https://api.github.com/users/vbauer/followers","following_url":"https://api.github.com/users/vbauer/following{/other_user}","gists_url":"https://api.github.com/users/vbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/vbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbauer/subscriptions","organizations_url":"https://api.github.com/users/vbauer/orgs","repos_url":"https://api.github.com/users/vbauer/repos","events_url":"https://api.github.com/users/vbauer/events{/privacy}","received_events_url":"https://api.github.com/users/vbauer/received_events","type":"User","site_admin":false},"body":"Class `EwsUtilities` is used in many places. This PR suggests to optimize some moments in this class.","created_at":"2015-04-12T19:29:20Z","updated_at":"2015-04-13T16:43:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57c4b49e0fb3a6ecfb10fd1ccb69dc0a82532c59","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290/commits","review_comments_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290/comments","review_comment_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/290/comments","statuses_url":"https://api.github.com/repos/OfficeDev/ews-java-api/statuses/703f1b1f827b2d420b3e9865ebe5581b4fde9f4f","head":{"label":"vbauer:optimize-ews-utils","ref":"optimize-ews-utils","sha":"703f1b1f827b2d420b3e9865ebe5581b4fde9f4f","user":{"login":"vbauer","id":578021,"avatar_url":"https://avatars.githubusercontent.com/u/578021?v=3","gravatar_id":"","url":"https://api.github.com/users/vbauer","html_url":"https://github.com/vbauer","followers_url":"https://api.github.com/users/vbauer/followers","following_url":"https://api.github.com/users/vbauer/following{/other_user}","gists_url":"https://api.github.com/users/vbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/vbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbauer/subscriptions","organizations_url":"https://api.github.com/users/vbauer/orgs","repos_url":"https://api.github.com/users/vbauer/repos","events_url":"https://api.github.com/users/vbauer/events{/privacy}","received_events_url":"https://api.github.com/users/vbauer/received_events","type":"User","site_admin":false},"repo":{"id":31546893,"name":"ews-java-api","full_name":"vbauer/ews-java-api","owner":{"login":"vbauer","id":578021,"avatar_url":"https://avatars.githubusercontent.com/u/578021?v=3","gravatar_id":"","url":"https://api.github.com/users/vbauer","html_url":"https://github.com/vbauer","followers_url":"https://api.github.com/users/vbauer/followers","following_url":"https://api.github.com/users/vbauer/following{/other_user}","gists_url":"https://api.github.com/users/vbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/vbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vbauer/subscriptions","organizations_url":"https://api.github.com/users/vbauer/orgs","repos_url":"https://api.github.com/users/vbauer/repos","events_url":"https://api.github.com/users/vbauer/events{/privacy}","received_events_url":"https://api.github.com/users/vbauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vbauer/ews-java-api","description":"A java client library to access Exchange web services.  The API works against Office 365 Exchange Online as well as on premises Exchange.","fork":true,"url":"https://api.github.com/repos/vbauer/ews-java-api","forks_url":"https://api.github.com/repos/vbauer/ews-java-api/forks","keys_url":"https://api.github.com/repos/vbauer/ews-java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vbauer/ews-java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vbauer/ews-java-api/teams","hooks_url":"https://api.github.com/repos/vbauer/ews-java-api/hooks","issue_events_url":"https://api.github.com/repos/vbauer/ews-java-api/issues/events{/number}","events_url":"https://api.github.com/repos/vbauer/ews-java-api/events","assignees_url":"https://api.github.com/repos/vbauer/ews-java-api/assignees{/user}","branches_url":"https://api.github.com/repos/vbauer/ews-java-api/branches{/branch}","tags_url":"https://api.github.com/repos/vbauer/ews-java-api/tags","blobs_url":"https://api.github.com/repos/vbauer/ews-java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vbauer/ews-java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vbauer/ews-java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/vbauer/ews-java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vbauer/ews-java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/vbauer/ews-java-api/languages","stargazers_url":"https://api.github.com/repos/vbauer/ews-java-api/stargazers","contributors_url":"https://api.github.com/repos/vbauer/ews-java-api/contributors","subscribers_url":"https://api.github.com/repos/vbauer/ews-java-api/subscribers","subscription_url":"https://api.github.com/repos/vbauer/ews-java-api/subscription","commits_url":"https://api.github.com/repos/vbauer/ews-java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/vbauer/ews-java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/vbauer/ews-java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/vbauer/ews-java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/vbauer/ews-java-api/contents/{+path}","compare_url":"https://api.github.com/repos/vbauer/ews-java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vbauer/ews-java-api/merges","archive_url":"https://api.github.com/repos/vbauer/ews-java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vbauer/ews-java-api/downloads","issues_url":"https://api.github.com/repos/vbauer/ews-java-api/issues{/number}","pulls_url":"https://api.github.com/repos/vbauer/ews-java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/vbauer/ews-java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/vbauer/ews-java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vbauer/ews-java-api/labels{/name}","releases_url":"https://api.github.com/repos/vbauer/ews-java-api/releases{/id}","created_at":"2015-03-02T15:27:26Z","updated_at":"2015-04-12T14:30:28Z","pushed_at":"2015-04-12T22:57:08Z","git_url":"git://github.com/vbauer/ews-java-api.git","ssh_url":"git@github.com:vbauer/ews-java-api.git","clone_url":"https://github.com/vbauer/ews-java-api.git","svn_url":"https://github.com/vbauer/ews-java-api","homepage":"","size":5765,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"OfficeDev:master","ref":"master","sha":"ab6646875ae298d938465b0683a49c28c25f0996","user":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"repo":{"id":23322482,"name":"ews-java-api","full_name":"OfficeDev/ews-java-api","owner":{"login":"OfficeDev","id":6789362,"avatar_url":"https://avatars.githubusercontent.com/u/6789362?v=3","gravatar_id":"","url":"https://api.github.com/users/OfficeDev","html_url":"https://github.com/OfficeDev","followers_url":"https://api.github.com/users/OfficeDev/followers","following_url":"https://api.github.com/users/OfficeDev/following{/other_user}","gists_url":"https://api.github.com/users/OfficeDev/gists{/gist_id}","starred_url":"https://api.github.com/users/OfficeDev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OfficeDev/subscriptions","organizations_url":"https://api.github.com/users/OfficeDev/orgs","repos_url":"https://api.github.com/users/OfficeDev/repos","events_url":"https://api.github.com/users/OfficeDev/events{/privacy}","received_events_url":"https://api.github.com/users/OfficeDev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OfficeDev/ews-java-api","description":"A java client library to access Exchange web services.  The API works against Office 365 Exchange Online as well as on premises Exchange.","fork":false,"url":"https://api.github.com/repos/OfficeDev/ews-java-api","forks_url":"https://api.github.com/repos/OfficeDev/ews-java-api/forks","keys_url":"https://api.github.com/repos/OfficeDev/ews-java-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OfficeDev/ews-java-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OfficeDev/ews-java-api/teams","hooks_url":"https://api.github.com/repos/OfficeDev/ews-java-api/hooks","issue_events_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/events{/number}","events_url":"https://api.github.com/repos/OfficeDev/ews-java-api/events","assignees_url":"https://api.github.com/repos/OfficeDev/ews-java-api/assignees{/user}","branches_url":"https://api.github.com/repos/OfficeDev/ews-java-api/branches{/branch}","tags_url":"https://api.github.com/repos/OfficeDev/ews-java-api/tags","blobs_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OfficeDev/ews-java-api/statuses/{sha}","languages_url":"https://api.github.com/repos/OfficeDev/ews-java-api/languages","stargazers_url":"https://api.github.com/repos/OfficeDev/ews-java-api/stargazers","contributors_url":"https://api.github.com/repos/OfficeDev/ews-java-api/contributors","subscribers_url":"https://api.github.com/repos/OfficeDev/ews-java-api/subscribers","subscription_url":"https://api.github.com/repos/OfficeDev/ews-java-api/subscription","commits_url":"https://api.github.com/repos/OfficeDev/ews-java-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/OfficeDev/ews-java-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/OfficeDev/ews-java-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/OfficeDev/ews-java-api/contents/{+path}","compare_url":"https://api.github.com/repos/OfficeDev/ews-java-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OfficeDev/ews-java-api/merges","archive_url":"https://api.github.com/repos/OfficeDev/ews-java-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OfficeDev/ews-java-api/downloads","issues_url":"https://api.github.com/repos/OfficeDev/ews-java-api/issues{/number}","pulls_url":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls{/number}","milestones_url":"https://api.github.com/repos/OfficeDev/ews-java-api/milestones{/number}","notifications_url":"https://api.github.com/repos/OfficeDev/ews-java-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OfficeDev/ews-java-api/labels{/name}","releases_url":"https://api.github.com/repos/OfficeDev/ews-java-api/releases{/id}","created_at":"2014-08-25T17:33:09Z","updated_at":"2015-04-12T12:44:55Z","pushed_at":"2015-04-12T23:02:38Z","git_url":"git://github.com/OfficeDev/ews-java-api.git","ssh_url":"git@github.com:OfficeDev/ews-java-api.git","clone_url":"https://github.com/OfficeDev/ews-java-api.git","svn_url":"https://github.com/OfficeDev/ews-java-api","homepage":"","size":9884,"stargazers_count":142,"watchers_count":142,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":75,"forks":106,"open_issues":75,"watchers":142,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290"},"html":{"href":"https://github.com/OfficeDev/ews-java-api/pull/290"},"issue":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/290"},"comments":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/OfficeDev/ews-java-api/statuses/703f1b1f827b2d420b3e9865ebe5581b4fde9f4f"}}}}