{"action":"created","comment":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments/48100132","id":48100132,"diff_hunk":"@@ -90,6 +90,16 @@ def add_parser_arguments(cls, add):\n \n         \"\"\"\n \n+    @property","path":"letsencrypt/plugins/common.py","position":4,"original_position":4,"commit_id":"41df3c1486d18b27a8213cc6ff02da9c2604fd9c","original_commit_id":"41df3c1486d18b27a8213cc6ff02da9c2604fd9c","user":{"login":"kuba","id":106176,"avatar_url":"https://avatars.githubusercontent.com/u/106176?v=3","gravatar_id":"","url":"https://api.github.com/users/kuba","html_url":"https://github.com/kuba","followers_url":"https://api.github.com/users/kuba/followers","following_url":"https://api.github.com/users/kuba/following{/other_user}","gists_url":"https://api.github.com/users/kuba/gists{/gist_id}","starred_url":"https://api.github.com/users/kuba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kuba/subscriptions","organizations_url":"https://api.github.com/users/kuba/orgs","repos_url":"https://api.github.com/users/kuba/repos","events_url":"https://api.github.com/users/kuba/events{/privacy}","received_events_url":"https://api.github.com/users/kuba/received_events","type":"User","site_admin":false},"body":"Why make a property of such uncomplicated thing? Just say `is_root_required = True`","created_at":"2015-12-20T06:03:19Z","updated_at":"2015-12-20T06:03:19Z","html_url":"https://github.com/letsencrypt/letsencrypt/pull/1938#discussion_r48100132","pull_request_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938","_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments/48100132"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/1938#discussion_r48100132"},"pull_request":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938"}}},"pull_request":{"url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938","id":54024462,"html_url":"https://github.com/letsencrypt/letsencrypt/pull/1938","diff_url":"https://github.com/letsencrypt/letsencrypt/pull/1938.diff","patch_url":"https://github.com/letsencrypt/letsencrypt/pull/1938.patch","issue_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1938","number":1938,"state":"open","locked":false,"title":"Ability to suppress warning \"Root (sudo) is required\" in plugins","user":{"login":"xgin","id":5378093,"avatar_url":"https://avatars.githubusercontent.com/u/5378093?v=3","gravatar_id":"","url":"https://api.github.com/users/xgin","html_url":"https://github.com/xgin","followers_url":"https://api.github.com/users/xgin/followers","following_url":"https://api.github.com/users/xgin/following{/other_user}","gists_url":"https://api.github.com/users/xgin/gists{/gist_id}","starred_url":"https://api.github.com/users/xgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgin/subscriptions","organizations_url":"https://api.github.com/users/xgin/orgs","repos_url":"https://api.github.com/users/xgin/repos","events_url":"https://api.github.com/users/xgin/events{/privacy}","received_events_url":"https://api.github.com/users/xgin/received_events","type":"User","site_admin":false},"body":"Some plugins do not require root privileges.\r\nThe warning is misleading, e.g. https://github.com/plesk/letsencrypt-plesk/issues/35\r\nProposed solution is to expose is_root_required property in order to check root privileges on demand.","created_at":"2015-12-17T20:03:23Z","updated_at":"2015-12-20T06:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"34e6e22ac0083ab69c9160ff01619f03b3035512","assignee":{"login":"pde","id":479213,"avatar_url":"https://avatars.githubusercontent.com/u/479213?v=3","gravatar_id":"","url":"https://api.github.com/users/pde","html_url":"https://github.com/pde","followers_url":"https://api.github.com/users/pde/followers","following_url":"https://api.github.com/users/pde/following{/other_user}","gists_url":"https://api.github.com/users/pde/gists{/gist_id}","starred_url":"https://api.github.com/users/pde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pde/subscriptions","organizations_url":"https://api.github.com/users/pde/orgs","repos_url":"https://api.github.com/users/pde/repos","events_url":"https://api.github.com/users/pde/events{/privacy}","received_events_url":"https://api.github.com/users/pde/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938/commits","review_comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938/comments","review_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1938/comments","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/41df3c1486d18b27a8213cc6ff02da9c2604fd9c","head":{"label":"xgin:non-root-warning","ref":"non-root-warning","sha":"41df3c1486d18b27a8213cc6ff02da9c2604fd9c","user":{"login":"xgin","id":5378093,"avatar_url":"https://avatars.githubusercontent.com/u/5378093?v=3","gravatar_id":"","url":"https://api.github.com/users/xgin","html_url":"https://github.com/xgin","followers_url":"https://api.github.com/users/xgin/followers","following_url":"https://api.github.com/users/xgin/following{/other_user}","gists_url":"https://api.github.com/users/xgin/gists{/gist_id}","starred_url":"https://api.github.com/users/xgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgin/subscriptions","organizations_url":"https://api.github.com/users/xgin/orgs","repos_url":"https://api.github.com/users/xgin/repos","events_url":"https://api.github.com/users/xgin/events{/privacy}","received_events_url":"https://api.github.com/users/xgin/received_events","type":"User","site_admin":false},"repo":{"id":41913757,"name":"letsencrypt","full_name":"xgin/letsencrypt","owner":{"login":"xgin","id":5378093,"avatar_url":"https://avatars.githubusercontent.com/u/5378093?v=3","gravatar_id":"","url":"https://api.github.com/users/xgin","html_url":"https://github.com/xgin","followers_url":"https://api.github.com/users/xgin/followers","following_url":"https://api.github.com/users/xgin/following{/other_user}","gists_url":"https://api.github.com/users/xgin/gists{/gist_id}","starred_url":"https://api.github.com/users/xgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xgin/subscriptions","organizations_url":"https://api.github.com/users/xgin/orgs","repos_url":"https://api.github.com/users/xgin/repos","events_url":"https://api.github.com/users/xgin/events{/privacy}","received_events_url":"https://api.github.com/users/xgin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xgin/letsencrypt","description":"An ACME client that can update Apache/Nginx configurations","fork":true,"url":"https://api.github.com/repos/xgin/letsencrypt","forks_url":"https://api.github.com/repos/xgin/letsencrypt/forks","keys_url":"https://api.github.com/repos/xgin/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xgin/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xgin/letsencrypt/teams","hooks_url":"https://api.github.com/repos/xgin/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/xgin/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/xgin/letsencrypt/events","assignees_url":"https://api.github.com/repos/xgin/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/xgin/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/xgin/letsencrypt/tags","blobs_url":"https://api.github.com/repos/xgin/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xgin/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xgin/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/xgin/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xgin/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/xgin/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/xgin/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/xgin/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/xgin/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/xgin/letsencrypt/subscription","commits_url":"https://api.github.com/repos/xgin/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/xgin/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/xgin/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/xgin/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/xgin/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/xgin/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xgin/letsencrypt/merges","archive_url":"https://api.github.com/repos/xgin/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xgin/letsencrypt/downloads","issues_url":"https://api.github.com/repos/xgin/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/xgin/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/xgin/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/xgin/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xgin/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/xgin/letsencrypt/releases{/id}","created_at":"2015-09-04T12:09:16Z","updated_at":"2015-09-04T12:09:17Z","pushed_at":"2015-12-20T02:17:39Z","git_url":"git://github.com/xgin/letsencrypt.git","ssh_url":"git@github.com:xgin/letsencrypt.git","clone_url":"https://github.com/xgin/letsencrypt.git","svn_url":"https://github.com/xgin/letsencrypt","homepage":"","size":6944,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"letsencrypt:master","ref":"master","sha":"ebfcd90d729c39b004b1ac851a6e1a37a4c092fe","user":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"repo":{"id":26516210,"name":"letsencrypt","full_name":"letsencrypt/letsencrypt","owner":{"login":"letsencrypt","id":9289019,"avatar_url":"https://avatars.githubusercontent.com/u/9289019?v=3","gravatar_id":"","url":"https://api.github.com/users/letsencrypt","html_url":"https://github.com/letsencrypt","followers_url":"https://api.github.com/users/letsencrypt/followers","following_url":"https://api.github.com/users/letsencrypt/following{/other_user}","gists_url":"https://api.github.com/users/letsencrypt/gists{/gist_id}","starred_url":"https://api.github.com/users/letsencrypt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/letsencrypt/subscriptions","organizations_url":"https://api.github.com/users/letsencrypt/orgs","repos_url":"https://api.github.com/users/letsencrypt/repos","events_url":"https://api.github.com/users/letsencrypt/events{/privacy}","received_events_url":"https://api.github.com/users/letsencrypt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/letsencrypt/letsencrypt","description":"This Let's Encrypt repo is an ACME client that can obtain certs and extensibly update server configurations (currently supports Apache on .deb based systems, nginx support coming soon)","fork":false,"url":"https://api.github.com/repos/letsencrypt/letsencrypt","forks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/forks","keys_url":"https://api.github.com/repos/letsencrypt/letsencrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/letsencrypt/letsencrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/letsencrypt/letsencrypt/teams","hooks_url":"https://api.github.com/repos/letsencrypt/letsencrypt/hooks","issue_events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/events{/number}","events_url":"https://api.github.com/repos/letsencrypt/letsencrypt/events","assignees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/assignees{/user}","branches_url":"https://api.github.com/repos/letsencrypt/letsencrypt/branches{/branch}","tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/tags","blobs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/letsencrypt/letsencrypt/languages","stargazers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/stargazers","contributors_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contributors","subscribers_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscribers","subscription_url":"https://api.github.com/repos/letsencrypt/letsencrypt/subscription","commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/letsencrypt/letsencrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/letsencrypt/letsencrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/letsencrypt/letsencrypt/contents/{+path}","compare_url":"https://api.github.com/repos/letsencrypt/letsencrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/letsencrypt/letsencrypt/merges","archive_url":"https://api.github.com/repos/letsencrypt/letsencrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/letsencrypt/letsencrypt/downloads","issues_url":"https://api.github.com/repos/letsencrypt/letsencrypt/issues{/number}","pulls_url":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/letsencrypt/letsencrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/letsencrypt/letsencrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/letsencrypt/letsencrypt/labels{/name}","releases_url":"https://api.github.com/repos/letsencrypt/letsencrypt/releases{/id}","created_at":"2014-11-12T02:52:20Z","updated_at":"2015-12-20T05:11:57Z","pushed_at":"2015-12-20T02:17:40Z","git_url":"git://github.com/letsencrypt/letsencrypt.git","ssh_url":"git@github.com:letsencrypt/letsencrypt.git","clone_url":"https://github.com/letsencrypt/letsencrypt.git","svn_url":"https://github.com/letsencrypt/letsencrypt","homepage":"","size":12525,"stargazers_count":9942,"watchers_count":9942,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":721,"mirror_url":null,"open_issues_count":442,"forks":721,"open_issues":442,"watchers":9942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938"},"html":{"href":"https://github.com/letsencrypt/letsencrypt/pull/1938"},"issue":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1938"},"comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/issues/1938/comments"},"review_comments":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938/comments"},"review_comment":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/pulls/1938/commits"},"statuses":{"href":"https://api.github.com/repos/letsencrypt/letsencrypt/statuses/41df3c1486d18b27a8213cc6ff02da9c2604fd9c"}}}}