{"action":"created","issue":{"url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39","labels_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39/labels{/name}","comments_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39/comments","events_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39/events","html_url":"https://github.com/thlorenz/proxyquireify/pull/39","id":95983438,"number":39,"title":"Do not execute required mock","user":{"login":"royriojas","id":131290,"avatar_url":"https://avatars.githubusercontent.com/u/131290?v=3","gravatar_id":"","url":"https://api.github.com/users/royriojas","html_url":"https://github.com/royriojas","followers_url":"https://api.github.com/users/royriojas/followers","following_url":"https://api.github.com/users/royriojas/following{/other_user}","gists_url":"https://api.github.com/users/royriojas/gists{/gist_id}","starred_url":"https://api.github.com/users/royriojas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/royriojas/subscriptions","organizations_url":"https://api.github.com/users/royriojas/orgs","repos_url":"https://api.github.com/users/royriojas/repos","events_url":"https://api.github.com/users/royriojas/events{/privacy}","received_events_url":"https://api.github.com/users/royriojas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":22,"created_at":"2015-07-20T04:21:22Z","updated_at":"2015-07-21T05:41:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/thlorenz/proxyquireify/pulls/39","html_url":"https://github.com/thlorenz/proxyquireify/pull/39","diff_url":"https://github.com/thlorenz/proxyquireify/pull/39.diff","patch_url":"https://github.com/thlorenz/proxyquireify/pull/39.patch"},"body":"Hi guys this is the improvement proposed as part of https://github.com/thlorenz/proxyquireify/issues/38\r\n\r\nCouple of notes.\r\n\r\n- the magic just wraps the call to require with an anonymous function. Since it is not executed it prevents double calls to require that were happening before.\r\n- the tests were consistently failing, some sort of race condition maybe. I just solved it splitting the problematic test into its own module and launching it after the other tests. Would be really nice to figure it out what went wrong, but at least this helps pass the tests for now "},"comment":{"url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/comments/123168699","html_url":"https://github.com/thlorenz/proxyquireify/pull/39#issuecomment-123168699","issue_url":"https://api.github.com/repos/thlorenz/proxyquireify/issues/39","id":123168699,"user":{"login":"bendrucker","id":808808,"avatar_url":"https://avatars.githubusercontent.com/u/808808?v=3","gravatar_id":"","url":"https://api.github.com/users/bendrucker","html_url":"https://github.com/bendrucker","followers_url":"https://api.github.com/users/bendrucker/followers","following_url":"https://api.github.com/users/bendrucker/following{/other_user}","gists_url":"https://api.github.com/users/bendrucker/gists{/gist_id}","starred_url":"https://api.github.com/users/bendrucker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bendrucker/subscriptions","organizations_url":"https://api.github.com/users/bendrucker/orgs","repos_url":"https://api.github.com/users/bendrucker/repos","events_url":"https://api.github.com/users/bendrucker/events{/privacy}","received_events_url":"https://api.github.com/users/bendrucker/received_events","type":"User","site_admin":false},"created_at":"2015-07-21T05:41:32Z","updated_at":"2015-07-21T05:41:32Z","body":"Looks okay to me, pending a squash"}}