{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/10454","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10454/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10454/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10454/events","html_url":"https://github.com/elastic/elasticsearch/pull/10454","id":66850855,"number":10454,"title":"Refactor MatchAllQueryBuilder, TermQueryBuilder, IdsQueryBuilder","user":{"login":"cbuescher","id":10398885,"avatar_url":"https://avatars.githubusercontent.com/u/10398885?v=3","gravatar_id":"","url":"https://api.github.com/users/cbuescher","html_url":"https://github.com/cbuescher","followers_url":"https://api.github.com/users/cbuescher/followers","following_url":"https://api.github.com/users/cbuescher/following{/other_user}","gists_url":"https://api.github.com/users/cbuescher/gists{/gist_id}","starred_url":"https://api.github.com/users/cbuescher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbuescher/subscriptions","organizations_url":"https://api.github.com/users/cbuescher/orgs","repos_url":"https://api.github.com/users/cbuescher/repos","events_url":"https://api.github.com/users/cbuescher/events{/privacy}","received_events_url":"https://api.github.com/users/cbuescher/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Query%20Refactoring","name":":Query Refactoring","color":"009800"},{"url":"https://api.github.com/repos/elastic/elasticsearch/labels/review","name":"review","color":"0052cc"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-07T10:39:21Z","updated_at":"2015-04-10T14:33:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/10454","html_url":"https://github.com/elastic/elasticsearch/pull/10454","diff_url":"https://github.com/elastic/elasticsearch/pull/10454.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/10454.patch"},"body":"MatchAllQueryBuilder, TermQueryBuilder, IdsQueryBuilder now include the fromXContent, doXContent and toQuery methods suggested in #9901. Also implementing the Streamable interface and adding unit tests for the serialization and parsing.\r\n\r\nNOTE: this PR is against the feature/query-parse-refactoring branch."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/91576380","html_url":"https://github.com/elastic/elasticsearch/pull/10454#issuecomment-91576380","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/10454","id":91576380,"user":{"login":"javanna","id":832460,"avatar_url":"https://avatars.githubusercontent.com/u/832460?v=3","gravatar_id":"","url":"https://api.github.com/users/javanna","html_url":"https://github.com/javanna","followers_url":"https://api.github.com/users/javanna/followers","following_url":"https://api.github.com/users/javanna/following{/other_user}","gists_url":"https://api.github.com/users/javanna/gists{/gist_id}","starred_url":"https://api.github.com/users/javanna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javanna/subscriptions","organizations_url":"https://api.github.com/users/javanna/orgs","repos_url":"https://api.github.com/users/javanna/repos","events_url":"https://api.github.com/users/javanna/events{/privacy}","received_events_url":"https://api.github.com/users/javanna/received_events","type":"User","site_admin":false},"created_at":"2015-04-10T14:33:43Z","updated_at":"2015-04-10T14:33:43Z","body":"I left a bunch of comments. I am pretty positive that we can trim down the code needed for testing, by just having a base test class with a few abstract methods that provide the query to test etc. we'll see how far we can take this. I am happy that we are going with unit testing rather than requiring to fire up a node.\r\n\r\nMy personal preference, I think a single PR per query would be easier to review, also then you don't have to adapt all of the other queries to the same comments :) but I see how this time it was better to touch a few of them rather than just one."}}