{"action":"opened","number":607,"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/607","id":37740182,"html_url":"https://github.com/mozilla/firefox-ios/pull/607","diff_url":"https://github.com/mozilla/firefox-ios/pull/607.diff","patch_url":"https://github.com/mozilla/firefox-ios/pull/607.patch","issue_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/607","number":607,"state":"open","locked":false,"title":"Bug 1170672 - Tests for search suggestions prompt","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"body":"Attaches an accessibility hint to search suggestion buttons to allow KIF to find them (which we should have anyway for accessibility reasons), using a custom `tryFindingViewWithAccessibilityHint` implementation since KIF doesn't have this built in. With that, we can simply test for the presence of these buttons to determine whether suggestions are enabled. This doesn't test the suggestions themselves; we already have that covered in `SearchTests.swift` in `ClientTests`.\r\n\r\nI really dislike having to add a `SuggestionsPromptReset` notification observer just to handle resetting the prompt, but there's no way that I know of for UI tests to access the actual `Profile` or `SearchEngines` instances. Happy to hear other ideas.","created_at":"2015-06-15T21:58:44Z","updated_at":"2015-06-15T21:58:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/607/commits","review_comments_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/607/comments","review_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/607/comments","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/739e5dfc4a87a8b759a04c6c89f2d647d03f8590","head":{"label":"thebnich:search-tests","ref":"search-tests","sha":"739e5dfc4a87a8b759a04c6c89f2d647d03f8590","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"repo":{"id":27744299,"name":"firefox-ios","full_name":"thebnich/firefox-ios","owner":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thebnich/firefox-ios","description":"Firefox for iOS","fork":true,"url":"https://api.github.com/repos/thebnich/firefox-ios","forks_url":"https://api.github.com/repos/thebnich/firefox-ios/forks","keys_url":"https://api.github.com/repos/thebnich/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thebnich/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thebnich/firefox-ios/teams","hooks_url":"https://api.github.com/repos/thebnich/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/thebnich/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/thebnich/firefox-ios/events","assignees_url":"https://api.github.com/repos/thebnich/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/thebnich/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/thebnich/firefox-ios/tags","blobs_url":"https://api.github.com/repos/thebnich/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thebnich/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thebnich/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/thebnich/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thebnich/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/thebnich/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/thebnich/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/thebnich/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/thebnich/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/thebnich/firefox-ios/subscription","commits_url":"https://api.github.com/repos/thebnich/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/thebnich/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/thebnich/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/thebnich/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/thebnich/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/thebnich/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thebnich/firefox-ios/merges","archive_url":"https://api.github.com/repos/thebnich/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thebnich/firefox-ios/downloads","issues_url":"https://api.github.com/repos/thebnich/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/thebnich/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/thebnich/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/thebnich/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thebnich/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/thebnich/firefox-ios/releases{/id}","created_at":"2014-12-09T01:43:28Z","updated_at":"2015-02-20T01:57:25Z","pushed_at":"2015-06-15T21:51:25Z","git_url":"git://github.com/thebnich/firefox-ios.git","ssh_url":"git@github.com:thebnich/firefox-ios.git","clone_url":"https://github.com/thebnich/firefox-ios.git","svn_url":"https://github.com/thebnich/firefox-ios","homepage":"","size":19200,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"710f7ec09e0114c8eed0ff54b439126310280952","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla/firefox-ios","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ios","forks_url":"https://api.github.com/repos/mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ios/releases{/id}","created_at":"2014-11-03T19:07:02Z","updated_at":"2015-06-15T16:00:55Z","pushed_at":"2015-06-15T20:39:56Z","git_url":"git://github.com/mozilla/firefox-ios.git","ssh_url":"git@github.com:mozilla/firefox-ios.git","clone_url":"https://github.com/mozilla/firefox-ios.git","svn_url":"https://github.com/mozilla/firefox-ios","homepage":"","size":125403,"stargazers_count":3294,"watchers_count":3294,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":544,"mirror_url":null,"open_issues_count":34,"forks":544,"open_issues":34,"watchers":3294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/607"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/607"},"issue":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/607"},"comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/607/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/607/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/607/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/firefox-ios/statuses/739e5dfc4a87a8b759a04c6c89f2d647d03f8590"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":82,"deletions":16,"changed_files":6}}