{"push_id":876973051,"size":2,"distinct_size":2,"ref":"refs/heads/master","head":"2cd95ccb95d7b7658cb6c896c8c5fd1e85a61109","before":"cc80ecf5f0902e724a6e398d152323120e4e3b82","commits":[{"sha":"bdc3dfdb27cc0a682494fb4ab50e0e5d00b0cc77","author":{"email":"154c89f342e79b0ddb664ee118ab7b586cf9a56a@apple.com","name":"bburg@apple.com"},"message":"Web Inspector: RemoteInspector should track targets and connections for remote automation\nhttps://bugs.webkit.org/show_bug.cgi?id=151042\n\nReviewed by Joseph Pecoraro.\n\nSource/JavaScriptCore:\n\nRefactor RemoteInspector so it can be used to send listings of different target types.\nFirst, rename Debuggable to RemoteInspectionTarget, and pull things not specific to\nremote inspection into the base class RemoteControllableTarget and its Connection class.\n\nAdd a new RemoteControllableTarget called RemoteAutomationTarget, used by UIProcess\nto support remote UI automation via webinspectord. On the protocol side, this target\nuses a new WIRTypeKey called WIRTypeAutomation to distiguish the listing from\nWeb and JavaScript listings and avoid inventing a new listing mechanism.\n\n* API/JSContextRef.cpp:\n(JSGlobalContextGetDebuggerRunLoop):\n(JSGlobalContextSetDebuggerRunLoop):\n* JavaScriptCore.xcodeproj/project.pbxproj:\n* inspector/InspectorFrontendChannel.h:\n* inspector/remote/RemoteAutomationTarget.cpp: Added.\n(Inspector::RemoteAutomationTarget::setAutomationAllowed): Added.\n* inspector/remote/RemoteAutomationTarget.h: Added.\n* inspector/remote/RemoteConnectionToTarget.h: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.h.\n(Inspector::RemoteTargetBlock::RemoteTargetBlock):\n(Inspector::RemoteTargetBlock::~RemoteTargetBlock):\n(Inspector::RemoteTargetBlock::operator=):\n(Inspector::RemoteTargetBlock::operator()):\n* inspector/remote/RemoteConnectionToTarget.mm: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggableConnection.mm.\n(Inspector::RemoteTargetHandleRunSourceGlobal):\n(Inspector::RemoteTargetQueueTaskOnGlobalQueue):\n(Inspector::RemoteTargetInitializeGlobalQueue):\n(Inspector::RemoteTargetHandleRunSourceWithInfo):\n(Inspector::RemoteConnectionToTarget::RemoteConnectionToTarget):\n(Inspector::RemoteConnectionToTarget::~RemoteConnectionToTarget):\n(Inspector::RemoteConnectionToTarget::destination):\n(Inspector::RemoteConnectionToTarget::connectionIdentifier):\n(Inspector::RemoteConnectionToTarget::dispatchAsyncOnTarget):\n(Inspector::RemoteConnectionToTarget::setup):\n(Inspector::RemoteConnectionToTarget::targetClosed):\n(Inspector::RemoteConnectionToTarget::close):\n(Inspector::RemoteConnectionToTarget::sendMessageToTarget):\n(Inspector::RemoteConnectionToTarget::sendMessageToFrontend):\n(Inspector::RemoteConnectionToTarget::setupRunLoop):\n(Inspector::RemoteConnectionToTarget::teardownRunLoop):\n(Inspector::RemoteConnectionToTarget::queueTaskOnPrivateRunLoop):\n* inspector/remote/RemoteControllableTarget.cpp: Added.\n(Inspector::RemoteControllableTarget::~RemoteControllableTarget):\n(Inspector::RemoteControllableTarget::init):\n(Inspector::RemoteControllableTarget::update):\n* inspector/remote/RemoteControllableTarget.h: Added.\n* inspector/remote/RemoteInspectionTarget.cpp: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.cpp.\n(Inspector::RemoteInspectionTarget::remoteControlAllowed):\n(Inspector::RemoteInspectionTarget::setRemoteDebuggingAllowed):\n(Inspector::RemoteInspectionTarget::pauseWaitingForAutomaticInspection):\n(Inspector::RemoteInspectionTarget::unpauseForInitializedInspector):\n* inspector/remote/RemoteInspectionTarget.h: Renamed from Source/JavaScriptCore/inspector/remote/RemoteInspectorDebuggable.h.\n(isType):\n* inspector/remote/RemoteInspector.h:\n\n    Code to manage Debuggables now works with RemoteControllableTargets and doesn't\n    care whether the target is for Inspection or Automation. Listing data with target-\n    and type-specific information are captured when clients call into RemoteInspector\n    since that's the easiest time to gather this information on the right thread.\n    Use the is<> / downcast<> machinery when we need a concrete Target type.\n\n* inspector/remote/RemoteInspector.mm:\n(Inspector::RemoteInspector::nextAvailableIdentifier):\n(Inspector::RemoteInspector::registerTarget): renamed from registerDebuggable.\n(Inspector::RemoteInspector::unregisterTarget): renamed from unregisterDebuggable.\n(Inspector::RemoteInspector::updateTarget): renamed from updateDebuggable.\n(Inspector::RemoteInspector::updateAutomaticInspectionCandidate):\n(Inspector::RemoteInspector::sendMessageToRemote):\n(Inspector::RemoteInspector::setupFailed):\n(Inspector::RemoteInspector::stopInternal):\n(Inspector::RemoteInspector::setupXPCConnectionIfNeeded):\n(Inspector::RemoteInspector::xpcConnectionFailed):\n(Inspector::RemoteInspector::listingForTarget):\n(Inspector::RemoteInspector::listingForInspectionTarget):\n(Inspector::RemoteInspector::listingForAutomationTarget):\n(Inspector::RemoteInspector::pushListingsNow):\n(Inspector::RemoteInspector::pushListingsSoon):\n(Inspector::RemoteInspector::receivedSetupMessage):\n(Inspector::RemoteInspector::receivedDataMessage):\n(Inspector::RemoteInspector::receivedDidCloseMessage):\n(Inspector::RemoteInspector::receivedGetListingMessage):\n(Inspector::RemoteInspector::receivedIndicateMessage):\n(Inspector::RemoteInspector::receivedConnectionDiedMessage):\n(Inspector::RemoteInspector::RemoteInspector): Deleted.\n(Inspector::RemoteInspector::registerDebuggable): Deleted.\n(Inspector::RemoteInspector::unregisterDebuggable): Deleted.\n(Inspector::RemoteInspector::updateDebuggable): Deleted.\n(Inspector::RemoteInspector::updateDebuggableAutomaticInspectCandidate): Deleted.\n(Inspector::RemoteInspector::sendMessageToRemoteFrontend): Deleted.\n(Inspector::RemoteInspector::listingForDebuggable): Deleted.\n(Inspector::RemoteInspector::pushListingNow): Deleted.\n(Inspector::RemoteInspector::pushListingSoon): Deleted.\n* inspector/remote/RemoteInspectorConstants.h:\n* runtime/JSGlobalObjectDebuggable.cpp:\n(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemote):\n(JSC::JSGlobalObjectDebuggable::pauseWaitingForAutomaticInspection):\n(JSC::JSGlobalObjectDebuggable::dispatchMessageFromRemoteFrontend): Deleted.\n* runtime/JSGlobalObjectDebuggable.h:\n\nSource/WebCore:\n\nUse the new RemoteControllableTarget API method names.\n\nNo new tests, no behavior change.\n\n* page/PageDebuggable.cpp:\n(WebCore::PageDebuggable::connect):\n(WebCore::PageDebuggable::dispatchMessageFromRemote):\n(WebCore::PageDebuggable::dispatchMessageFromRemoteFrontend): Deleted.\n* page/PageDebuggable.h:\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@192753 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/bdc3dfdb27cc0a682494fb4ab50e0e5d00b0cc77"},{"sha":"2cd95ccb95d7b7658cb6c896c8c5fd1e85a61109","author":{"email":"02f199576e3fa8dd317089ce53371c928ff2f6f2@webkit.org","name":"gyuyoung.kim@webkit.org"},"message":"REGRESSION(r188206): [EFL] Missing to adjust scrollbar size to ewk_view_contents_size_get API test\nhttps://bugs.webkit.org/show_bug.cgi?id=148735\n\nReviewed by Csaba Osztrogonác.\n\nr189256 missed to adjust scrollbar size to other tests in ewk_view_contents_size_get() API test.\nIn this case we need to apply scrollbar size to both width and height unlike previous fix. Because\nhorizontal scrollbar is also shown since device pixel ratio(= 2.0) is adjusted.\n\n* UIProcess/API/efl/tests/test_ewk2_view.cpp:\n(TEST_F):\n\n\ngit-svn-id: http://svn.webkit.org/repository/webkit/trunk@192754 268f45cc-cd09-0410-ab3c-d52691b4dbfc","distinct":true,"url":"https://api.github.com/repos/paul99/webkit-mips/commits/2cd95ccb95d7b7658cb6c896c8c5fd1e85a61109"}]}