{"action":"created","issue":{"url":"https://api.github.com/repos/digint/btrbk/issues/30","labels_url":"https://api.github.com/repos/digint/btrbk/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/digint/btrbk/issues/30/comments","events_url":"https://api.github.com/repos/digint/btrbk/issues/30/events","html_url":"https://github.com/digint/btrbk/pull/30","id":93783017,"number":30,"title":"ENH: script (ssh_filter_btrbk.sh) should fail if any command fails, or var is undefined","user":{"login":"yarikoptic","id":39889,"avatar_url":"https://avatars.githubusercontent.com/u/39889?v=3","gravatar_id":"","url":"https://api.github.com/users/yarikoptic","html_url":"https://github.com/yarikoptic","followers_url":"https://api.github.com/users/yarikoptic/followers","following_url":"https://api.github.com/users/yarikoptic/following{/other_user}","gists_url":"https://api.github.com/users/yarikoptic/gists{/gist_id}","starred_url":"https://api.github.com/users/yarikoptic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarikoptic/subscriptions","organizations_url":"https://api.github.com/users/yarikoptic/orgs","repos_url":"https://api.github.com/users/yarikoptic/repos","events_url":"https://api.github.com/users/yarikoptic/events{/privacy}","received_events_url":"https://api.github.com/users/yarikoptic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-07-08T12:56:16Z","updated_at":"2015-07-08T13:47:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/digint/btrbk/pulls/30","html_url":"https://github.com/digint/btrbk/pull/30","diff_url":"https://github.com/digint/btrbk/pull/30.diff","patch_url":"https://github.com/digint/btrbk/pull/30.patch"},"body":"although haven't tested yet i proper \"ssh\" deployment"},"comment":{"url":"https://api.github.com/repos/digint/btrbk/issues/comments/119584215","html_url":"https://github.com/digint/btrbk/pull/30#issuecomment-119584215","issue_url":"https://api.github.com/repos/digint/btrbk/issues/30","id":119584215,"user":{"login":"digint","id":7590973,"avatar_url":"https://avatars.githubusercontent.com/u/7590973?v=3","gravatar_id":"","url":"https://api.github.com/users/digint","html_url":"https://github.com/digint","followers_url":"https://api.github.com/users/digint/followers","following_url":"https://api.github.com/users/digint/following{/other_user}","gists_url":"https://api.github.com/users/digint/gists{/gist_id}","starred_url":"https://api.github.com/users/digint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/digint/subscriptions","organizations_url":"https://api.github.com/users/digint/orgs","repos_url":"https://api.github.com/users/digint/repos","events_url":"https://api.github.com/users/digint/events{/privacy}","received_events_url":"https://api.github.com/users/digint/received_events","type":"User","site_admin":false},"created_at":"2015-07-08T13:47:27Z","updated_at":"2015-07-08T13:47:27Z","body":"Thanks for your contribution!\r\n\r\nI agree that `set -u` and `set -e` generally enhance security.\r\n\r\nProblem with `set -u` is that if the script fails to expand either `$LOGNAME`, `$SSH_CLIENT` and `$SSH_ORIGINAL_COMMAND`, it will fail without logging anything. I think this is not acceptable.\r\n\r\nProblem with `set -e` is that if `/usr/bin/logger` fails for some reason, the `$SSH_ORIGINAL_COMMAND` will not be executed (in `run_cmd()`). I think this is acceptable.\r\n\r\nWhat do you think?"}}