{"action":"created","issue":{"url":"https://api.github.com/repos/emberjs/data/issues/3635","labels_url":"https://api.github.com/repos/emberjs/data/issues/3635/labels{/name}","comments_url":"https://api.github.com/repos/emberjs/data/issues/3635/comments","events_url":"https://api.github.com/repos/emberjs/data/issues/3635/events","html_url":"https://github.com/emberjs/data/issues/3635","id":100081967,"number":3635,"title":"Ember data 1.13.8 should have removed _registerHelper deprecations warnings but didn't","user":{"login":"adam-knights","id":12710362,"avatar_url":"https://avatars.githubusercontent.com/u/12710362?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-knights","html_url":"https://github.com/adam-knights","followers_url":"https://api.github.com/users/adam-knights/followers","following_url":"https://api.github.com/users/adam-knights/following{/other_user}","gists_url":"https://api.github.com/users/adam-knights/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-knights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-knights/subscriptions","organizations_url":"https://api.github.com/users/adam-knights/orgs","repos_url":"https://api.github.com/users/adam-knights/repos","events_url":"https://api.github.com/users/adam-knights/events{/privacy}","received_events_url":"https://api.github.com/users/adam-knights/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-08-10T14:34:33Z","updated_at":"2015-08-10T14:38:22Z","closed_at":null,"body":"This is continueing on the onversation in this issue https://github.com/stefanpenner/ember-inflector/issues/75.\r\n\r\n@jcope2013 was of the opinion that something has gone wrong with the build of 1.13.8 on bower.\r\n\r\nSo summarise - if you compare http://builds.emberjs.com/tags/v1.13.8/ember-data.js which doesnot doe give deprecation warnings and https://cdnjs.cloudflare.com/ajax/libs/ember-data.js/1.13.8/ember-data.js which does cause deprecation warnings then theres a large difference in the diff in that the cdnjs file has this section while the other does not:\r\n\r\n    var ember$inflector$lib$lib$utils$register$helper$$default = ember$inflector$lib$lib$utils$register$helper$$registerHelper;\r\n\r\n    function ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration1(name, helperFunction) {\r\n      //earlier versions of ember with htmlbars used this\r\n      ember$lib$main$$default.HTMLBars.helpers[name] = helperFunction;\r\n    }\r\n\r\n    function ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration2(name, helperFunction) {\r\n      //registerHelper has been made private as _registerHelper\r\n      //this is kept here if anyone is using it\r\n      ember$lib$main$$default.HTMLBars.registerHelper(name, helperFunction);\r\n    }\r\n\r\n    function ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration3(name, helperFunction) {\r\n      //latest versin of ember uses this\r\n      ember$lib$main$$default.HTMLBars._registerHelper(name, helperFunction);\r\n    }\r\n    function ember$inflector$lib$lib$utils$register$helper$$registerHelper(name, helperFunction) {\r\n      if (ember$lib$main$$default.HTMLBars) {\r\n        var fn = ember$lib$main$$default.HTMLBars.makeBoundHelper(helperFunction);\r\n\r\n        if (ember$lib$main$$default.HTMLBars._registerHelper) {\r\n          if (ember$lib$main$$default.HTMLBars.helpers) {\r\n            ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration1(name, fn);\r\n          } else {\r\n            ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration3(name, fn);\r\n          }\r\n        } else if (ember$lib$main$$default.HTMLBars.registerHelper) {\r\n          ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration2(name, fn);\r\n        }\r\n      } else if (ember$lib$main$$default.Handlebars) {\r\n        ember$lib$main$$default.Handlebars.helper(name, helperFunction);\r\n      }\r\n    }\r\n\r\n    /**\r\n     *\r\n     * If you have Ember Inflector (such as if Ember Data is present),\r\n     * singularize a word. For example, turn \"oxen\" into \"ox\".\r\n     *\r\n     * Example:\r\n     *\r\n     * {{singularize myProperty}}\r\n     * {{singularize \"oxen\"}}\r\n     *\r\n     * @for Ember.HTMLBars.helpers\r\n     * @method singularize\r\n     * @param {String|Property} word word to singularize\r\n    */\r\n    ember$inflector$lib$lib$utils$register$helper$$default('singularize', function (params) {\r\n      return ember$inflector$lib$lib$system$string$$singularize(params[0]);\r\n    });\r\n\r\n    /**\r\n     *\r\n     * If you have Ember Inflector (such as if Ember Data is present),\r\n     * pluralize a word. For example, turn \"ox\" into \"oxen\".\r\n     *\r\n     * Example:\r\n     *\r\n     * {{pluralize count myProperty}}\r\n     * {{pluralize 1 \"oxen\"}}\r\n     * {{pluralize myProperty}}\r\n     * {{pluralize \"ox\"}}\r\n     *\r\n     * @for Ember.HTMLBars.helpers\r\n     * @method pluralize\r\n     * @param {Number|Property} [count] count of objects\r\n     * @param {String|Property} word word to pluralize\r\n    */\r\n    ember$inflector$lib$lib$utils$register$helper$$default('pluralize', function (params) {\r\n      var count, word;\r\n\r\n      if (params.length === 1) {\r\n        word = params[0];\r\n        return ember$inflector$lib$lib$system$string$$pluralize(word);\r\n      } else {\r\n        count = params[0];\r\n        word = params[1];\r\n\r\n        if (count !== 1) {\r\n          word = ember$inflector$lib$lib$system$string$$pluralize(word);\r\n        }\r\n        return count + ' ' + word;\r\n      }\r\n    });\r\n\r\nThe cdnjs file matches exactly what I get from bower, and so in ember data 1.13.8 I still get deprecation warnings on _registerHelper and makeBoundHelper\r\n\r\nA quick way to repo the issue is to go to http://ember-twiddle.com/, open console and switch twiddle.json on the left between the above two 1.13.8 urls."},"comment":{"url":"https://api.github.com/repos/emberjs/data/issues/comments/129477049","html_url":"https://github.com/emberjs/data/issues/3635#issuecomment-129477049","issue_url":"https://api.github.com/repos/emberjs/data/issues/3635","id":129477049,"user":{"login":"adam-knights","id":12710362,"avatar_url":"https://avatars.githubusercontent.com/u/12710362?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-knights","html_url":"https://github.com/adam-knights","followers_url":"https://api.github.com/users/adam-knights/followers","following_url":"https://api.github.com/users/adam-knights/following{/other_user}","gists_url":"https://api.github.com/users/adam-knights/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-knights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-knights/subscriptions","organizations_url":"https://api.github.com/users/adam-knights/orgs","repos_url":"https://api.github.com/users/adam-knights/repos","events_url":"https://api.github.com/users/adam-knights/events{/privacy}","received_events_url":"https://api.github.com/users/adam-knights/received_events","type":"User","site_admin":false},"created_at":"2015-08-10T14:38:21Z","updated_at":"2015-08-10T14:38:21Z","body":"The exact deprecation warnings are:\r\n\r\n    DEPRECATION: Using `Ember.HTMLBars.makeBoundHelper` is deprecated. Please refactor to using `Ember.Helper` or `Ember.Helper.helper`. [deprecation id: ember-htmlbars.make-bound-helper]\r\n\r\nand\r\n\r\n    DEPRECATION: Using Ember.HTMLBars._registerHelper is deprecated. Helpers (even dashless ones) are automatically resolved. [deprecation id: ember-htmlbars.register-helper]\r\n\r\n-----\r\n    DEBUG: Ember                       : 1.13.6\r\n    DEBUG: Ember Data                  : 1.13.8\r\n\r\nand Ember CLI 1.13.7\r\n----\r\nDEPRECATION: Using `Ember.HTMLBars.makeBoundHelper` is deprecated. Please refactor to using `Ember.Helper` or `Ember.Helper.helper`. [deprecation id: ember-htmlbars.make-bound-helper]\r\n        at Object.makeBoundHelper (http://localhost:4200/assets/vendor.js:21270:32)\r\n        at ember$inflector$lib$lib$utils$register$helper$$registerHelper (http://localhost:4200/assets/vendor.js:75716:51)\r\n        at http://localhost:4200/assets/vendor.js:75746:5\r\n        at http://localhost:4200/assets/vendor.js:90277:4\r\n\r\nDEPRECATION: Using Ember.HTMLBars._registerHelper is deprecated. Helpers (even dashless ones) are automatically resolved. [deprecation id: ember-htmlbars.register-helper]\r\n        at Object._ret.v [as _registerHelper] (http://localhost:4200/assets/vendor.js:16049:40)\r\n        at ember$inflector$lib$lib$utils$register$helper$$registerHelperIteration3 (http://localhost:4200/assets/vendor.js:75712:40)\r\n        at ember$inflector$lib$lib$utils$register$helper$$registerHelper (http://localhost:4200/assets/vendor.js:75722:13)\r\n        at http://localhost:4200/assets/vendor.js:75746:5\r\n        at http://localhost:4200/assets/vendor.js:90277:4"}}