{"action":"created","comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments/33800679","id":33800679,"diff_hunk":"@@ -19,6 +19,25 @@ function mixin(WindowsBuilder) {\n }\r\n \r\n /**\r\n+ * Escapes a value in a relative distinguished name. Used to generate the distinguished name for the windows cert string from tiapp publisher value.\r\n+ **/\r\n+function escapeRDN(value) {\r\n+\tvar escapeChar = \"\\\\\",\r\n+\t\tchars = [\"/\", \",\", \"#\", \"+\", \"<\", \">\", \";\", '\"', \"=\"],\r\n+\t\t// cheat and just trim leading and trailing whitespace, rather than escaping\r\n+\t\tescaped = value.trim().replace(escapeChar, escapeChar + escapeChar);\r","path":"cli/commands/_build/validate.js","position":10,"original_position":10,"commit_id":"9c17c4c24973367fda9c1f0df0b6f74bf08d6491","original_commit_id":"9c17c4c24973367fda9c1f0df0b6f74bf08d6491","user":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"body":"I was going to use regexp but got lazy. This is much better. Thanks! New commit coming soon...","created_at":"2015-07-02T17:18:09Z","updated_at":"2015-07-02T17:18:09Z","html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/348#discussion_r33800679","pull_request_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348","_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments/33800679"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/348#discussion_r33800679"},"pull_request":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348"}}},"pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348","id":39033795,"html_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/348","diff_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/348.diff","patch_url":"https://github.com/appcelerator/titanium_mobile_windows/pull/348.patch","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/348","number":348,"state":"open","locked":false,"title":"TIMOB-19104 Windows: If generating ti.windows.publishername from tiapp publisher value, escape invalid characters","user":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"body":"https://jira.appcelerator.org/browse/TIMOB-19104\r\n\r\nA good example is to set your tiapp publisher value to \"Appcelerator, Inc.\" (like some of our samples do) and make sure the build doesn't break.","created_at":"2015-07-01T22:58:52Z","updated_at":"2015-07-02T17:18:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a174800d446d0139442356a959e0dd01178618d2","assignee":{"login":"dawsontoth","id":472869,"avatar_url":"https://avatars.githubusercontent.com/u/472869?v=3","gravatar_id":"","url":"https://api.github.com/users/dawsontoth","html_url":"https://github.com/dawsontoth","followers_url":"https://api.github.com/users/dawsontoth/followers","following_url":"https://api.github.com/users/dawsontoth/following{/other_user}","gists_url":"https://api.github.com/users/dawsontoth/gists{/gist_id}","starred_url":"https://api.github.com/users/dawsontoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dawsontoth/subscriptions","organizations_url":"https://api.github.com/users/dawsontoth/orgs","repos_url":"https://api.github.com/users/dawsontoth/repos","events_url":"https://api.github.com/users/dawsontoth/events{/privacy}","received_events_url":"https://api.github.com/users/dawsontoth/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348/commits","review_comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348/comments","review_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/348/comments","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/9c17c4c24973367fda9c1f0df0b6f74bf08d6491","head":{"label":"sgtcoolguy:TIMOB-19104","ref":"TIMOB-19104","sha":"9c17c4c24973367fda9c1f0df0b6f74bf08d6491","user":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"repo":{"id":33495035,"name":"titanium_mobile_windows","full_name":"sgtcoolguy/titanium_mobile_windows","owner":{"login":"sgtcoolguy","id":3252,"avatar_url":"https://avatars.githubusercontent.com/u/3252?v=3","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgtcoolguy/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":true,"url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows","forks_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/sgtcoolguy/titanium_mobile_windows/releases{/id}","created_at":"2015-04-06T17:29:12Z","updated_at":"2015-05-08T17:29:39Z","pushed_at":"2015-07-02T17:14:53Z","git_url":"git://github.com/sgtcoolguy/titanium_mobile_windows.git","ssh_url":"git@github.com:sgtcoolguy/titanium_mobile_windows.git","clone_url":"https://github.com/sgtcoolguy/titanium_mobile_windows.git","svn_url":"https://github.com/sgtcoolguy/titanium_mobile_windows","homepage":null,"size":38062,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"appcelerator:master","ref":"master","sha":"8458f05387508ff4f38e9a9fd9164b4d8d3f2207","user":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"repo":{"id":27684398,"name":"titanium_mobile_windows","full_name":"appcelerator/titanium_mobile_windows","owner":{"login":"appcelerator","id":82188,"avatar_url":"https://avatars.githubusercontent.com/u/82188?v=3","gravatar_id":"","url":"https://api.github.com/users/appcelerator","html_url":"https://github.com/appcelerator","followers_url":"https://api.github.com/users/appcelerator/followers","following_url":"https://api.github.com/users/appcelerator/following{/other_user}","gists_url":"https://api.github.com/users/appcelerator/gists{/gist_id}","starred_url":"https://api.github.com/users/appcelerator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/appcelerator/subscriptions","organizations_url":"https://api.github.com/users/appcelerator/orgs","repos_url":"https://api.github.com/users/appcelerator/repos","events_url":"https://api.github.com/users/appcelerator/events{/privacy}","received_events_url":"https://api.github.com/users/appcelerator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/appcelerator/titanium_mobile_windows","description":"Windows platform for Titanium Mobile","fork":false,"url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows","forks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/forks","keys_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/keys{/key_id}","collaborators_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/teams","hooks_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/hooks","issue_events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/events{/number}","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/events","assignees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/assignees{/user}","branches_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/branches{/branch}","tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/tags","blobs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/refs{/sha}","trees_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/trees{/sha}","statuses_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/{sha}","languages_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/languages","stargazers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/stargazers","contributors_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contributors","subscribers_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscribers","subscription_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/subscription","commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/commits{/sha}","git_commits_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/git/commits{/sha}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/comments{/number}","issue_comment_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/comments{/number}","contents_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/contents/{+path}","compare_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/compare/{base}...{head}","merges_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/merges","archive_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/downloads","issues_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues{/number}","pulls_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls{/number}","milestones_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/milestones{/number}","notifications_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/labels{/name}","releases_url":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/releases{/id}","created_at":"2014-12-07T20:55:18Z","updated_at":"2015-05-15T17:37:30Z","pushed_at":"2015-07-02T17:14:53Z","git_url":"git://github.com/appcelerator/titanium_mobile_windows.git","ssh_url":"git@github.com:appcelerator/titanium_mobile_windows.git","clone_url":"https://github.com/appcelerator/titanium_mobile_windows.git","svn_url":"https://github.com/appcelerator/titanium_mobile_windows","homepage":null,"size":41079,"stargazers_count":7,"watchers_count":7,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348"},"html":{"href":"https://github.com/appcelerator/titanium_mobile_windows/pull/348"},"issue":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/348"},"comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/appcelerator/titanium_mobile_windows/statuses/9c17c4c24973367fda9c1f0df0b6f74bf08d6491"}}}}