{"action":"closed","issue":{"url":"https://api.github.com/repos/Parsely/pykafka/issues/394","labels_url":"https://api.github.com/repos/Parsely/pykafka/issues/394/labels{/name}","comments_url":"https://api.github.com/repos/Parsely/pykafka/issues/394/comments","events_url":"https://api.github.com/repos/Parsely/pykafka/issues/394/events","html_url":"https://github.com/Parsely/pykafka/issues/394","id":122350548,"number":394,"title":"Put Changes.rst updates in tag","user":{"login":"ottomata","id":1626054,"avatar_url":"https://avatars.githubusercontent.com/u/1626054?v=3","gravatar_id":"","url":"https://api.github.com/users/ottomata","html_url":"https://github.com/ottomata","followers_url":"https://api.github.com/users/ottomata/followers","following_url":"https://api.github.com/users/ottomata/following{/other_user}","gists_url":"https://api.github.com/users/ottomata/gists{/gist_id}","starred_url":"https://api.github.com/users/ottomata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ottomata/subscriptions","organizations_url":"https://api.github.com/users/ottomata/orgs","repos_url":"https://api.github.com/users/ottomata/repos","events_url":"https://api.github.com/users/ottomata/events{/privacy}","received_events_url":"https://api.github.com/users/ottomata/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-15T19:43:43Z","updated_at":"2015-12-18T18:17:19Z","closed_at":"2015-12-18T18:17:19Z","body":"Hiya!  This is just a pedantic request!  I've noticed that in the last two tags, the update to the CHANGES.rst for the changes in the tag arrived in a commit to master after the tag was made.  This confused me for 2.1.0, as I was only looking at the CHANGES.rst file for that tag, and wasn't sure what had made it in.\r\n\r\nIn the future, could you modify the CHANGES.rst file before that tag is made?  In my own projects, I've done this by updating the changelog in the commit that actually made a change.  E.g., you could maintain a 2.1.1 (SNAPSHOT) (or (ALPHA) or (WHATEVER)) tag at the top of CHANGES.rst, and then change it so it says the date of the tag when you make the tag.\r\n\r\nOr do whatever you want! :)  Thank you!\r\n\r\n"}}