{"action":"closed","number":3842,"pull_request":{"url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3842","id":35593576,"html_url":"https://github.com/openframeworks/openFrameworks/pull/3842","diff_url":"https://github.com/openframeworks/openFrameworks/pull/3842.diff","patch_url":"https://github.com/openframeworks/openFrameworks/pull/3842.patch","issue_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3842","number":3842,"state":"closed","locked":false,"title":"change denominator of ofRandomuf from float to double.","user":{"login":"2bbb","id":200899,"avatar_url":"https://avatars.githubusercontent.com/u/200899?v=3","gravatar_id":"","url":"https://api.github.com/users/2bbb","html_url":"https://github.com/2bbb","followers_url":"https://api.github.com/users/2bbb/followers","following_url":"https://api.github.com/users/2bbb/following{/other_user}","gists_url":"https://api.github.com/users/2bbb/gists{/gist_id}","starred_url":"https://api.github.com/users/2bbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2bbb/subscriptions","organizations_url":"https://api.github.com/users/2bbb/orgs","repos_url":"https://api.github.com/users/2bbb/repos","events_url":"https://api.github.com/users/2bbb/events{/privacy}","received_events_url":"https://api.github.com/users/2bbb/received_events","type":"User","site_admin":false},"body":"change from `(RAND_MAX + 1.0f)` to `(static_cast<double>(RAND_MAX) + 1.0)`.\r\n\r\nBecause, if RAND_MAX is sufficiently large as larger than float precision, then `RAND_MAX + 1.0f == RAND_MAX`.\r\nIn other words, often `rand() / (RAND_MAX + 1.0f)` returns `1.0f`\r\n\r\nAnd, added `static_cast<double>` to clarify the meaning.\r\n\r\nAt the same time, replace same codes like `rand() / (RAND_MAX + 1.0f)` to `ofRandomuf()`.\r\nMaybe this tiny code will be inline expanded automatically when compiling.\r\n\r\nmore discussion about this: please see #3762\r\n","created_at":"2015-05-17T21:21:19Z","updated_at":"2015-06-03T04:03:47Z","closed_at":"2015-06-03T04:03:47Z","merged_at":"2015-06-03T04:03:47Z","merge_commit_sha":"bfe5cbf3af9ca6b79e1723fff0c7a90b89eda826","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3842/commits","review_comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3842/comments","review_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3842/comments","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/0eae57d8b5ebf925d9a5e1fc0e692b045ec07ea6","head":{"label":"2bbb:fix_ofRandom_returns_just_maximum_value","ref":"fix_ofRandom_returns_just_maximum_value","sha":"0eae57d8b5ebf925d9a5e1fc0e692b045ec07ea6","user":{"login":"2bbb","id":200899,"avatar_url":"https://avatars.githubusercontent.com/u/200899?v=3","gravatar_id":"","url":"https://api.github.com/users/2bbb","html_url":"https://github.com/2bbb","followers_url":"https://api.github.com/users/2bbb/followers","following_url":"https://api.github.com/users/2bbb/following{/other_user}","gists_url":"https://api.github.com/users/2bbb/gists{/gist_id}","starred_url":"https://api.github.com/users/2bbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2bbb/subscriptions","organizations_url":"https://api.github.com/users/2bbb/orgs","repos_url":"https://api.github.com/users/2bbb/repos","events_url":"https://api.github.com/users/2bbb/events{/privacy}","received_events_url":"https://api.github.com/users/2bbb/received_events","type":"User","site_admin":false},"repo":{"id":35782321,"name":"openFrameworks","full_name":"2bbb/openFrameworks","owner":{"login":"2bbb","id":200899,"avatar_url":"https://avatars.githubusercontent.com/u/200899?v=3","gravatar_id":"","url":"https://api.github.com/users/2bbb","html_url":"https://github.com/2bbb","followers_url":"https://api.github.com/users/2bbb/followers","following_url":"https://api.github.com/users/2bbb/following{/other_user}","gists_url":"https://api.github.com/users/2bbb/gists{/gist_id}","starred_url":"https://api.github.com/users/2bbb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2bbb/subscriptions","organizations_url":"https://api.github.com/users/2bbb/orgs","repos_url":"https://api.github.com/users/2bbb/repos","events_url":"https://api.github.com/users/2bbb/events{/privacy}","received_events_url":"https://api.github.com/users/2bbb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2bbb/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":true,"url":"https://api.github.com/repos/2bbb/openFrameworks","forks_url":"https://api.github.com/repos/2bbb/openFrameworks/forks","keys_url":"https://api.github.com/repos/2bbb/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2bbb/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2bbb/openFrameworks/teams","hooks_url":"https://api.github.com/repos/2bbb/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/2bbb/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/2bbb/openFrameworks/events","assignees_url":"https://api.github.com/repos/2bbb/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/2bbb/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/2bbb/openFrameworks/tags","blobs_url":"https://api.github.com/repos/2bbb/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2bbb/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2bbb/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/2bbb/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2bbb/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/2bbb/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/2bbb/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/2bbb/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/2bbb/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/2bbb/openFrameworks/subscription","commits_url":"https://api.github.com/repos/2bbb/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/2bbb/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/2bbb/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/2bbb/openFrameworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/2bbb/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/2bbb/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2bbb/openFrameworks/merges","archive_url":"https://api.github.com/repos/2bbb/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2bbb/openFrameworks/downloads","issues_url":"https://api.github.com/repos/2bbb/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/2bbb/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/2bbb/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/2bbb/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2bbb/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/2bbb/openFrameworks/releases{/id}","created_at":"2015-05-17T20:46:11Z","updated_at":"2015-05-17T20:46:41Z","pushed_at":"2015-06-03T02:24:23Z","git_url":"git://github.com/2bbb/openFrameworks.git","ssh_url":"git@github.com:2bbb/openFrameworks.git","clone_url":"https://github.com/2bbb/openFrameworks.git","svn_url":"https://github.com/2bbb/openFrameworks","homepage":"http://openframeworks.cc","size":1134866,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openframeworks:master","ref":"master","sha":"b2f2cb81a57e2713ef6140f92f1d6885179a866f","user":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments{/number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2015-06-02T22:29:26Z","pushed_at":"2015-06-03T04:03:47Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1504818,"stargazers_count":3552,"watchers_count":3552,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1303,"mirror_url":null,"open_issues_count":572,"forks":1303,"open_issues":572,"watchers":3552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3842"},"html":{"href":"https://github.com/openframeworks/openFrameworks/pull/3842"},"issue":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3842"},"comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3842/comments"},"review_comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3842/comments"},"review_comment":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3842/commits"},"statuses":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/0eae57d8b5ebf925d9a5e1fc0e692b045ec07ea6"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"kylemcdonald","id":157106,"avatar_url":"https://avatars.githubusercontent.com/u/157106?v=3","gravatar_id":"","url":"https://api.github.com/users/kylemcdonald","html_url":"https://github.com/kylemcdonald","followers_url":"https://api.github.com/users/kylemcdonald/followers","following_url":"https://api.github.com/users/kylemcdonald/following{/other_user}","gists_url":"https://api.github.com/users/kylemcdonald/gists{/gist_id}","starred_url":"https://api.github.com/users/kylemcdonald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kylemcdonald/subscriptions","organizations_url":"https://api.github.com/users/kylemcdonald/orgs","repos_url":"https://api.github.com/users/kylemcdonald/repos","events_url":"https://api.github.com/users/kylemcdonald/events{/privacy}","received_events_url":"https://api.github.com/users/kylemcdonald/received_events","type":"User","site_admin":false},"comments":57,"review_comments":0,"commits":6,"additions":6,"deletions":8,"changed_files":1}}