{"action":"created","comment":{"url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/comments/43936305","id":43936305,"diff_hunk":"@@ -212,10 +212,11 @@ function islandora_paged_content_create_pdf_paged_content_batch_operation($paged\n  *   The batch definition.\n  */\n function islandora_paged_content_create_ocr_batch(AbstractObject $paged_content, array $pages, array $options) {\n-  return array(\n+  $return = array(\n     'operations' => array(\n       array('islandora_paged_content_create_ocr_batch_operation', array(\n-          $pages, $options)),\n+        $pages, $options)),\n+      array('islandora_paged_content_create_ocr_paged_content_batch_operation', array($paged_content->id)),","path":"includes/batch.inc","position":10,"original_position":10,"commit_id":"a7eac1427ab1d0ab821ade5276a525e7876ec725","original_commit_id":"a7eac1427ab1d0ab821ade5276a525e7876ec725","user":{"login":"adam-vessey","id":607975,"avatar_url":"https://avatars.githubusercontent.com/u/607975?v=3","gravatar_id":"","url":"https://api.github.com/users/adam-vessey","html_url":"https://github.com/adam-vessey","followers_url":"https://api.github.com/users/adam-vessey/followers","following_url":"https://api.github.com/users/adam-vessey/following{/other_user}","gists_url":"https://api.github.com/users/adam-vessey/gists{/gist_id}","starred_url":"https://api.github.com/users/adam-vessey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adam-vessey/subscriptions","organizations_url":"https://api.github.com/users/adam-vessey/orgs","repos_url":"https://api.github.com/users/adam-vessey/repos","events_url":"https://api.github.com/users/adam-vessey/events{/privacy}","received_events_url":"https://api.github.com/users/adam-vessey/received_events","type":"User","site_admin":false},"body":"Should this be here? Seems to be accounted for in the `$options` check below... While this would _always_ add it...","created_at":"2015-11-04T20:40:58Z","updated_at":"2015-11-04T20:40:58Z","html_url":"https://github.com/Islandora/islandora_paged_content/pull/108#discussion_r43936305","pull_request_url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108","_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/comments/43936305"},"html":{"href":"https://github.com/Islandora/islandora_paged_content/pull/108#discussion_r43936305"},"pull_request":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108"}}},"pull_request":{"url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108","id":49720496,"html_url":"https://github.com/Islandora/islandora_paged_content/pull/108","diff_url":"https://github.com/Islandora/islandora_paged_content/pull/108.diff","patch_url":"https://github.com/Islandora/islandora_paged_content/pull/108.patch","issue_url":"https://api.github.com/repos/Islandora/islandora_paged_content/issues/108","number":108,"state":"open","locked":false,"title":"7.x islandora 1533","user":{"login":"qadan","id":3406327,"avatar_url":"https://avatars.githubusercontent.com/u/3406327?v=3","gravatar_id":"","url":"https://api.github.com/users/qadan","html_url":"https://github.com/qadan","followers_url":"https://api.github.com/users/qadan/followers","following_url":"https://api.github.com/users/qadan/following{/other_user}","gists_url":"https://api.github.com/users/qadan/gists{/gist_id}","starred_url":"https://api.github.com/users/qadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qadan/subscriptions","organizations_url":"https://api.github.com/users/qadan/orgs","repos_url":"https://api.github.com/users/qadan/repos","events_url":"https://api.github.com/users/qadan/events{/privacy}","received_events_url":"https://api.github.com/users/qadan/received_events","type":"User","site_admin":false},"body":"**Jira:** https://jira.duraspace.org/browse/ISLANDORA-1533\r\n\r\n# What does this Pull Request do?\r\nAdds functionality to optionally consolidate OCR from pages to their parent paged content objects during batch ingests, as well as to update paged content objects without consolidated OCR via Drush.\r\n\r\n# How should this be tested?\r\n- The Drush command 'paged-content-consolidate-missing-ocr' should be tested to make sure that it consolidates OCR datastreams to paged content objects accurately, and that it doesn't overwrite existing OCR datastreams.\r\n- The 'islandora/object/PID/manage/book' and 'islandora/object/PID/manage/issue' management pages should be looked at; an 'Aggregate OCR to the parent?' checkbox has been added to the 'Perform OCR' section.\r\n- Solr results altering options have been added to 'admin/islandora/solution_pack_config/paged_content'; these should be confirmed working.\r\n- In all cases, it should be confirmed that these new features do not hijack settings on existing installs.\r\n\r\n# Background context:\r\nThe purpose of ISLANDORA-1533 is to allow OCR datastreams to be aggregated and stored with the parent paged object so they can be indexed into Solr, and so that pages can be hidden from search results.\r\n\r\n# Screenshots\r\n## Paged Content Configuration (before)\r\n![config before](https://cloud.githubusercontent.com/assets/3406327/10946386/65d72176-82f8-11e5-8a57-127c3b486f62.png)\r\n## Paged Content Configuration (after)\r\n![config after](https://cloud.githubusercontent.com/assets/3406327/10946384/65d33606-82f8-11e5-842e-93f33937a7a8.png)\r\n## OCR Regeneration (before)\r\n![ocr before](https://cloud.githubusercontent.com/assets/3406327/10946387/65d74c46-82f8-11e5-960c-35e36364e25f.png)\r\n## OCR Regeneration (after)\r\n![ocr after](https://cloud.githubusercontent.com/assets/3406327/10946385/65d6c424-82f8-11e5-8707-485859d70eb9.png)\r\n\r\n# Additional Notes: \r\n* **Does this change require documentation to be updated?** Possibly; most of the functionality will be described in the UI, but documentation may be necessary to inform of the overarching option here.\r\n* **Does this change require any other modifications to be made to the repository (i.e., Regeneration activity, etc.)?** If the feature wants to be used, yes, the Drush script to consolidate OCR should be run.\r\n* **Could this change impact execution of existing code?** There is a risk that in some cases we could be creating extra, unnecessary OCR datastreams; this should be confirmed not to be the case.\r\n\r\nThis change depends on https://github.com/Islandora/islandora_ocr/pull/59\r\n\r\n**Tagging:** @Islandora/7-x-1-x-committers @whikloj as component manager here.\r\n\r\n----\r\nQA Dan\r\n_Developer_\r\n**[discoverygarden inc.](http://www.discoverygarden.ca) | Managing Digital Content**","created_at":"2015-11-04T17:39:40Z","updated_at":"2015-11-04T20:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e20e3cd56ed753059fbc62d8749759eefc810372","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108/commits","review_comments_url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108/comments","review_comment_url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Islandora/islandora_paged_content/issues/108/comments","statuses_url":"https://api.github.com/repos/Islandora/islandora_paged_content/statuses/a7eac1427ab1d0ab821ade5276a525e7876ec725","head":{"label":"qadan:7.x-ISLANDORA-1533","ref":"7.x-ISLANDORA-1533","sha":"a7eac1427ab1d0ab821ade5276a525e7876ec725","user":{"login":"qadan","id":3406327,"avatar_url":"https://avatars.githubusercontent.com/u/3406327?v=3","gravatar_id":"","url":"https://api.github.com/users/qadan","html_url":"https://github.com/qadan","followers_url":"https://api.github.com/users/qadan/followers","following_url":"https://api.github.com/users/qadan/following{/other_user}","gists_url":"https://api.github.com/users/qadan/gists{/gist_id}","starred_url":"https://api.github.com/users/qadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qadan/subscriptions","organizations_url":"https://api.github.com/users/qadan/orgs","repos_url":"https://api.github.com/users/qadan/repos","events_url":"https://api.github.com/users/qadan/events{/privacy}","received_events_url":"https://api.github.com/users/qadan/received_events","type":"User","site_admin":false},"repo":{"id":45203121,"name":"islandora_paged_content","full_name":"qadan/islandora_paged_content","owner":{"login":"qadan","id":3406327,"avatar_url":"https://avatars.githubusercontent.com/u/3406327?v=3","gravatar_id":"","url":"https://api.github.com/users/qadan","html_url":"https://github.com/qadan","followers_url":"https://api.github.com/users/qadan/followers","following_url":"https://api.github.com/users/qadan/following{/other_user}","gists_url":"https://api.github.com/users/qadan/gists{/gist_id}","starred_url":"https://api.github.com/users/qadan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qadan/subscriptions","organizations_url":"https://api.github.com/users/qadan/orgs","repos_url":"https://api.github.com/users/qadan/repos","events_url":"https://api.github.com/users/qadan/events{/privacy}","received_events_url":"https://api.github.com/users/qadan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/qadan/islandora_paged_content","description":"Libraries for paged content in Islandora.","fork":true,"url":"https://api.github.com/repos/qadan/islandora_paged_content","forks_url":"https://api.github.com/repos/qadan/islandora_paged_content/forks","keys_url":"https://api.github.com/repos/qadan/islandora_paged_content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qadan/islandora_paged_content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qadan/islandora_paged_content/teams","hooks_url":"https://api.github.com/repos/qadan/islandora_paged_content/hooks","issue_events_url":"https://api.github.com/repos/qadan/islandora_paged_content/issues/events{/number}","events_url":"https://api.github.com/repos/qadan/islandora_paged_content/events","assignees_url":"https://api.github.com/repos/qadan/islandora_paged_content/assignees{/user}","branches_url":"https://api.github.com/repos/qadan/islandora_paged_content/branches{/branch}","tags_url":"https://api.github.com/repos/qadan/islandora_paged_content/tags","blobs_url":"https://api.github.com/repos/qadan/islandora_paged_content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qadan/islandora_paged_content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qadan/islandora_paged_content/git/refs{/sha}","trees_url":"https://api.github.com/repos/qadan/islandora_paged_content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qadan/islandora_paged_content/statuses/{sha}","languages_url":"https://api.github.com/repos/qadan/islandora_paged_content/languages","stargazers_url":"https://api.github.com/repos/qadan/islandora_paged_content/stargazers","contributors_url":"https://api.github.com/repos/qadan/islandora_paged_content/contributors","subscribers_url":"https://api.github.com/repos/qadan/islandora_paged_content/subscribers","subscription_url":"https://api.github.com/repos/qadan/islandora_paged_content/subscription","commits_url":"https://api.github.com/repos/qadan/islandora_paged_content/commits{/sha}","git_commits_url":"https://api.github.com/repos/qadan/islandora_paged_content/git/commits{/sha}","comments_url":"https://api.github.com/repos/qadan/islandora_paged_content/comments{/number}","issue_comment_url":"https://api.github.com/repos/qadan/islandora_paged_content/issues/comments{/number}","contents_url":"https://api.github.com/repos/qadan/islandora_paged_content/contents/{+path}","compare_url":"https://api.github.com/repos/qadan/islandora_paged_content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qadan/islandora_paged_content/merges","archive_url":"https://api.github.com/repos/qadan/islandora_paged_content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qadan/islandora_paged_content/downloads","issues_url":"https://api.github.com/repos/qadan/islandora_paged_content/issues{/number}","pulls_url":"https://api.github.com/repos/qadan/islandora_paged_content/pulls{/number}","milestones_url":"https://api.github.com/repos/qadan/islandora_paged_content/milestones{/number}","notifications_url":"https://api.github.com/repos/qadan/islandora_paged_content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qadan/islandora_paged_content/labels{/name}","releases_url":"https://api.github.com/repos/qadan/islandora_paged_content/releases{/id}","created_at":"2015-10-29T18:37:32Z","updated_at":"2015-10-29T18:37:33Z","pushed_at":"2015-11-04T18:01:19Z","git_url":"git://github.com/qadan/islandora_paged_content.git","ssh_url":"git@github.com:qadan/islandora_paged_content.git","clone_url":"https://github.com/qadan/islandora_paged_content.git","svn_url":"https://github.com/qadan/islandora_paged_content","homepage":null,"size":2697,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"7.x"}},"base":{"label":"Islandora:7.x","ref":"7.x","sha":"3468257cb5feccf6585e2220a8350410452b0a72","user":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"repo":{"id":7777364,"name":"islandora_paged_content","full_name":"Islandora/islandora_paged_content","owner":{"login":"Islandora","id":494054,"avatar_url":"https://avatars.githubusercontent.com/u/494054?v=3","gravatar_id":"","url":"https://api.github.com/users/Islandora","html_url":"https://github.com/Islandora","followers_url":"https://api.github.com/users/Islandora/followers","following_url":"https://api.github.com/users/Islandora/following{/other_user}","gists_url":"https://api.github.com/users/Islandora/gists{/gist_id}","starred_url":"https://api.github.com/users/Islandora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Islandora/subscriptions","organizations_url":"https://api.github.com/users/Islandora/orgs","repos_url":"https://api.github.com/users/Islandora/repos","events_url":"https://api.github.com/users/Islandora/events{/privacy}","received_events_url":"https://api.github.com/users/Islandora/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Islandora/islandora_paged_content","description":"Libraries for paged content in Islandora.","fork":false,"url":"https://api.github.com/repos/Islandora/islandora_paged_content","forks_url":"https://api.github.com/repos/Islandora/islandora_paged_content/forks","keys_url":"https://api.github.com/repos/Islandora/islandora_paged_content/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Islandora/islandora_paged_content/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Islandora/islandora_paged_content/teams","hooks_url":"https://api.github.com/repos/Islandora/islandora_paged_content/hooks","issue_events_url":"https://api.github.com/repos/Islandora/islandora_paged_content/issues/events{/number}","events_url":"https://api.github.com/repos/Islandora/islandora_paged_content/events","assignees_url":"https://api.github.com/repos/Islandora/islandora_paged_content/assignees{/user}","branches_url":"https://api.github.com/repos/Islandora/islandora_paged_content/branches{/branch}","tags_url":"https://api.github.com/repos/Islandora/islandora_paged_content/tags","blobs_url":"https://api.github.com/repos/Islandora/islandora_paged_content/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Islandora/islandora_paged_content/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Islandora/islandora_paged_content/git/refs{/sha}","trees_url":"https://api.github.com/repos/Islandora/islandora_paged_content/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Islandora/islandora_paged_content/statuses/{sha}","languages_url":"https://api.github.com/repos/Islandora/islandora_paged_content/languages","stargazers_url":"https://api.github.com/repos/Islandora/islandora_paged_content/stargazers","contributors_url":"https://api.github.com/repos/Islandora/islandora_paged_content/contributors","subscribers_url":"https://api.github.com/repos/Islandora/islandora_paged_content/subscribers","subscription_url":"https://api.github.com/repos/Islandora/islandora_paged_content/subscription","commits_url":"https://api.github.com/repos/Islandora/islandora_paged_content/commits{/sha}","git_commits_url":"https://api.github.com/repos/Islandora/islandora_paged_content/git/commits{/sha}","comments_url":"https://api.github.com/repos/Islandora/islandora_paged_content/comments{/number}","issue_comment_url":"https://api.github.com/repos/Islandora/islandora_paged_content/issues/comments{/number}","contents_url":"https://api.github.com/repos/Islandora/islandora_paged_content/contents/{+path}","compare_url":"https://api.github.com/repos/Islandora/islandora_paged_content/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Islandora/islandora_paged_content/merges","archive_url":"https://api.github.com/repos/Islandora/islandora_paged_content/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Islandora/islandora_paged_content/downloads","issues_url":"https://api.github.com/repos/Islandora/islandora_paged_content/issues{/number}","pulls_url":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls{/number}","milestones_url":"https://api.github.com/repos/Islandora/islandora_paged_content/milestones{/number}","notifications_url":"https://api.github.com/repos/Islandora/islandora_paged_content/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Islandora/islandora_paged_content/labels{/name}","releases_url":"https://api.github.com/repos/Islandora/islandora_paged_content/releases{/id}","created_at":"2013-01-23T15:28:32Z","updated_at":"2015-08-13T13:42:08Z","pushed_at":"2015-11-04T19:24:29Z","git_url":"git://github.com/Islandora/islandora_paged_content.git","ssh_url":"git@github.com:Islandora/islandora_paged_content.git","clone_url":"https://github.com/Islandora/islandora_paged_content.git","svn_url":"https://github.com/Islandora/islandora_paged_content","homepage":null,"size":2697,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":2,"forks":26,"open_issues":2,"watchers":0,"default_branch":"7.x"}},"_links":{"self":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108"},"html":{"href":"https://github.com/Islandora/islandora_paged_content/pull/108"},"issue":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/issues/108"},"comments":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/issues/108/comments"},"review_comments":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108/comments"},"review_comment":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/pulls/108/commits"},"statuses":{"href":"https://api.github.com/repos/Islandora/islandora_paged_content/statuses/a7eac1427ab1d0ab821ade5276a525e7876ec725"}}}}