{"action":"closed","number":3592,"pull_request":{"url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3592","id":39862036,"html_url":"https://github.com/zfsonlinux/zfs/pull/3592","diff_url":"https://github.com/zfsonlinux/zfs/pull/3592.diff","patch_url":"https://github.com/zfsonlinux/zfs/pull/3592.patch","issue_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3592","number":3592,"state":"closed","locked":false,"title":"Add logic to try and recover an inode with an invalid mode","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"body":"When an inode is detected with invalid mode bits the safe thing to\r\ndo is panic the system.  This indicates a problem with the contents\r\nof a dnode and it should never be possible.  This is the default\r\nbehavior.\r\n\r\nUnfortunately, due to flaws in the system attribution implementation\r\nit was possible that old versions of ZFS could create such dnodes.\r\nThis was a very rare issue because it depended on hitting a specific\r\nrace and having the xattr=sa property set.  Nevertheless a small number\r\nof damaged pools do exist.  As of the 0.6.4 tag the root cause of this\r\nissue has been fixed.\r\n\r\nFor pools which are exhibiting this damage the 'zfs_recover=1' module\r\nmay be set.  This will cause ZFS to interpret dnode with invalid mode\r\nbits to be treated as files.  This may allows the files to be accessed\r\nfor recovery purposes.\r\n\r\nSigned-off-by: Brian Behlendorf <behlendorf1@llnl.gov>","created_at":"2015-07-13T22:06:04Z","updated_at":"2015-07-17T22:39:26Z","closed_at":"2015-07-17T22:39:26Z","merged_at":null,"merge_commit_sha":"23a9b69f3acf258a935b7da1905d1fff4619aa9e","assignee":null,"milestone":{"url":"https://api.github.com/repos/zfsonlinux/zfs/milestones/25","html_url":"https://github.com/zfsonlinux/zfs/milestones/0.6.5","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones/25/labels","id":175736,"number":25,"title":"0.6.5","description":"ZFS on Linux v0.6.5 - Functionality / Integration","creator":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":61,"state":"open","created_at":"2012-09-16T18:38:32Z","updated_at":"2015-07-17T22:39:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3592/commits","review_comments_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3592/comments","review_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/3592/comments","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/6034bcdd34bdb7cbcde797e5c9f0138f489d6ef2","head":{"label":"behlendorf:issue-3548","ref":"issue-3548","sha":"6034bcdd34bdb7cbcde797e5c9f0138f489d6ef2","user":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"repo":{"id":2003466,"name":"zfs","full_name":"behlendorf/zfs","owner":{"login":"behlendorf","id":148917,"avatar_url":"https://avatars.githubusercontent.com/u/148917?v=3","gravatar_id":"","url":"https://api.github.com/users/behlendorf","html_url":"https://github.com/behlendorf","followers_url":"https://api.github.com/users/behlendorf/followers","following_url":"https://api.github.com/users/behlendorf/following{/other_user}","gists_url":"https://api.github.com/users/behlendorf/gists{/gist_id}","starred_url":"https://api.github.com/users/behlendorf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/behlendorf/subscriptions","organizations_url":"https://api.github.com/users/behlendorf/orgs","repos_url":"https://api.github.com/users/behlendorf/repos","events_url":"https://api.github.com/users/behlendorf/events{/privacy}","received_events_url":"https://api.github.com/users/behlendorf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/behlendorf/zfs","description":"Native ZFS for Linux","fork":true,"url":"https://api.github.com/repos/behlendorf/zfs","forks_url":"https://api.github.com/repos/behlendorf/zfs/forks","keys_url":"https://api.github.com/repos/behlendorf/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/behlendorf/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/behlendorf/zfs/teams","hooks_url":"https://api.github.com/repos/behlendorf/zfs/hooks","issue_events_url":"https://api.github.com/repos/behlendorf/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/behlendorf/zfs/events","assignees_url":"https://api.github.com/repos/behlendorf/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/behlendorf/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/behlendorf/zfs/tags","blobs_url":"https://api.github.com/repos/behlendorf/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/behlendorf/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/behlendorf/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/behlendorf/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/behlendorf/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/behlendorf/zfs/languages","stargazers_url":"https://api.github.com/repos/behlendorf/zfs/stargazers","contributors_url":"https://api.github.com/repos/behlendorf/zfs/contributors","subscribers_url":"https://api.github.com/repos/behlendorf/zfs/subscribers","subscription_url":"https://api.github.com/repos/behlendorf/zfs/subscription","commits_url":"https://api.github.com/repos/behlendorf/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/behlendorf/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/behlendorf/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/behlendorf/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/behlendorf/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/behlendorf/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/behlendorf/zfs/merges","archive_url":"https://api.github.com/repos/behlendorf/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/behlendorf/zfs/downloads","issues_url":"https://api.github.com/repos/behlendorf/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/behlendorf/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/behlendorf/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/behlendorf/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/behlendorf/zfs/labels{/name}","releases_url":"https://api.github.com/repos/behlendorf/zfs/releases{/id}","created_at":"2011-07-05T22:51:43Z","updated_at":"2015-05-06T21:13:58Z","pushed_at":"2015-07-17T22:39:09Z","git_url":"git://github.com/behlendorf/zfs.git","ssh_url":"git@github.com:behlendorf/zfs.git","clone_url":"https://github.com/behlendorf/zfs.git","svn_url":"https://github.com/behlendorf/zfs","homepage":"http://zfsonlinux.org/","size":30485,"stargazers_count":35,"watchers_count":35,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":35,"default_branch":"master"}},"base":{"label":"zfsonlinux:master","ref":"master","sha":"b39c22b73c0e8016381057c2240570f7af992def","user":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":437011,"name":"zfs","full_name":"zfsonlinux/zfs","owner":{"login":"zfsonlinux","id":575083,"avatar_url":"https://avatars.githubusercontent.com/u/575083?v=3","gravatar_id":"","url":"https://api.github.com/users/zfsonlinux","html_url":"https://github.com/zfsonlinux","followers_url":"https://api.github.com/users/zfsonlinux/followers","following_url":"https://api.github.com/users/zfsonlinux/following{/other_user}","gists_url":"https://api.github.com/users/zfsonlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/zfsonlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zfsonlinux/subscriptions","organizations_url":"https://api.github.com/users/zfsonlinux/orgs","repos_url":"https://api.github.com/users/zfsonlinux/repos","events_url":"https://api.github.com/users/zfsonlinux/events{/privacy}","received_events_url":"https://api.github.com/users/zfsonlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zfsonlinux/zfs","description":"Native ZFS for Linux","fork":false,"url":"https://api.github.com/repos/zfsonlinux/zfs","forks_url":"https://api.github.com/repos/zfsonlinux/zfs/forks","keys_url":"https://api.github.com/repos/zfsonlinux/zfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zfsonlinux/zfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zfsonlinux/zfs/teams","hooks_url":"https://api.github.com/repos/zfsonlinux/zfs/hooks","issue_events_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/events{/number}","events_url":"https://api.github.com/repos/zfsonlinux/zfs/events","assignees_url":"https://api.github.com/repos/zfsonlinux/zfs/assignees{/user}","branches_url":"https://api.github.com/repos/zfsonlinux/zfs/branches{/branch}","tags_url":"https://api.github.com/repos/zfsonlinux/zfs/tags","blobs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zfsonlinux/zfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zfsonlinux/zfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/zfsonlinux/zfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zfsonlinux/zfs/statuses/{sha}","languages_url":"https://api.github.com/repos/zfsonlinux/zfs/languages","stargazers_url":"https://api.github.com/repos/zfsonlinux/zfs/stargazers","contributors_url":"https://api.github.com/repos/zfsonlinux/zfs/contributors","subscribers_url":"https://api.github.com/repos/zfsonlinux/zfs/subscribers","subscription_url":"https://api.github.com/repos/zfsonlinux/zfs/subscription","commits_url":"https://api.github.com/repos/zfsonlinux/zfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/zfsonlinux/zfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/zfsonlinux/zfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/zfsonlinux/zfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/zfsonlinux/zfs/contents/{+path}","compare_url":"https://api.github.com/repos/zfsonlinux/zfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zfsonlinux/zfs/merges","archive_url":"https://api.github.com/repos/zfsonlinux/zfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zfsonlinux/zfs/downloads","issues_url":"https://api.github.com/repos/zfsonlinux/zfs/issues{/number}","pulls_url":"https://api.github.com/repos/zfsonlinux/zfs/pulls{/number}","milestones_url":"https://api.github.com/repos/zfsonlinux/zfs/milestones{/number}","notifications_url":"https://api.github.com/repos/zfsonlinux/zfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zfsonlinux/zfs/labels{/name}","releases_url":"https://api.github.com/repos/zfsonlinux/zfs/releases{/id}","created_at":"2009-12-14T20:20:34Z","updated_at":"2015-07-17T22:26:36Z","pushed_at":"2015-07-17T22:39:04Z","git_url":"git://github.com/zfsonlinux/zfs.git","ssh_url":"git@github.com:zfsonlinux/zfs.git","clone_url":"https://github.com/zfsonlinux/zfs.git","svn_url":"https://github.com/zfsonlinux/zfs","homepage":"http://zfsonlinux.org/","size":56244,"stargazers_count":1444,"watchers_count":1444,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":365,"mirror_url":null,"open_issues_count":776,"forks":365,"open_issues":776,"watchers":1444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3592"},"html":{"href":"https://github.com/zfsonlinux/zfs/pull/3592"},"issue":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3592"},"comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/issues/3592/comments"},"review_comments":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3592/comments"},"review_comment":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zfsonlinux/zfs/pulls/3592/commits"},"statuses":{"href":"https://api.github.com/repos/zfsonlinux/zfs/statuses/6034bcdd34bdb7cbcde797e5c9f0138f489d6ef2"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":4,"review_comments":0,"commits":1,"additions":9,"deletions":2,"changed_files":1}}