{"action":"created","issue":{"url":"https://api.github.com/repos/Katello/katello/issues/5663","labels_url":"https://api.github.com/repos/Katello/katello/issues/5663/labels{/name}","comments_url":"https://api.github.com/repos/Katello/katello/issues/5663/comments","events_url":"https://api.github.com/repos/Katello/katello/issues/5663/events","html_url":"https://github.com/Katello/katello/pull/5663","id":121526059,"number":5663,"title":"Fixes #10970 - Rails4 merge into master","user":{"login":"johnpmitsch","id":5964462,"avatar_url":"https://avatars.githubusercontent.com/u/5964462?v=3","gravatar_id":"","url":"https://api.github.com/users/johnpmitsch","html_url":"https://github.com/johnpmitsch","followers_url":"https://api.github.com/users/johnpmitsch/followers","following_url":"https://api.github.com/users/johnpmitsch/following{/other_user}","gists_url":"https://api.github.com/users/johnpmitsch/gists{/gist_id}","starred_url":"https://api.github.com/users/johnpmitsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnpmitsch/subscriptions","organizations_url":"https://api.github.com/users/johnpmitsch/orgs","repos_url":"https://api.github.com/users/johnpmitsch/repos","events_url":"https://api.github.com/users/johnpmitsch/events{/privacy}","received_events_url":"https://api.github.com/users/johnpmitsch/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/Katello/katello/labels/Needs%20re-review","name":"Needs re-review","color":"0052cc"},{"url":"https://api.github.com/repos/Katello/katello/labels/Needs%20testing","name":"Needs testing","color":"fbca04"},{"url":"https://api.github.com/repos/Katello/katello/labels/Rails4","name":"Rails4","color":"006b75"},{"url":"https://api.github.com/repos/Katello/katello/labels/Waiting%20on%20contributor","name":"Waiting on contributor","color":"eb6420"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":10,"created_at":"2015-12-10T16:32:29Z","updated_at":"2015-12-14T18:51:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Katello/katello/pulls/5663","html_url":"https://github.com/Katello/katello/pull/5663","diff_url":"https://github.com/Katello/katello/pull/5663.diff","patch_url":"https://github.com/Katello/katello/pull/5663.patch"},"body":"These commits upgrade us to Rails 4.1.5. :tada:\r\n\r\nChanges include:\r\n\r\n * Updating necessary gems to rails 4 compatible versions\r\n * assert_include becomes assert_includes.\r\n * ```find_by_foo(\"bar\")``` becomes ```find_by(:foo => \"bar\")```\r\n * We will continue to use strong parameters, but have removed protected attributes and all instances of attr_accessible in our models. However, Foreman is using protected attributes currently in order to transition to strong parameters, so any extended foreman models should use  attr_accessible to whitelist attributes.\r\n * ```.scoped``` becomes ```.where(nil)```\r\n * ```:dependent => restrict``` becomes ```:dependent => :restrict_with_error``` \r\n * ```find_or_create_by_foo(\"bar\")``` becomes ```where(:foo => \"bar\").first_or_create```\r\n * Remove conditions, order, limit from has_many relations\r\n * Scope no longer uses ```:conditions =>```\r\n\r\nFeel free to comment if I left anything out."},"comment":{"url":"https://api.github.com/repos/Katello/katello/issues/comments/164524050","html_url":"https://github.com/Katello/katello/pull/5663#issuecomment-164524050","issue_url":"https://api.github.com/repos/Katello/katello/issues/5663","id":164524050,"user":{"login":"theforeman-bot","id":3763234,"avatar_url":"https://avatars.githubusercontent.com/u/3763234?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman-bot","html_url":"https://github.com/theforeman-bot","followers_url":"https://api.github.com/users/theforeman-bot/followers","following_url":"https://api.github.com/users/theforeman-bot/following{/other_user}","gists_url":"https://api.github.com/users/theforeman-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman-bot/subscriptions","organizations_url":"https://api.github.com/users/theforeman-bot/orgs","repos_url":"https://api.github.com/users/theforeman-bot/repos","events_url":"https://api.github.com/users/theforeman-bot/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman-bot/received_events","type":"User","site_admin":false},"created_at":"2015-12-14T18:51:07Z","updated_at":"2015-12-14T18:51:07Z","body":"There were the following issues with the commit message:\n  * 03fb8be44e5e825510739cbb130df9f7c2622977 must be in the format ```fixes #redmine_number - brief description```.\n  * 09d23c6e3aba410c0d02f7e01a1d54df7e5be33c must be in the format ```fixes #redmine_number - brief description```.\n  * f40dfaeef85f1d8101b86ea201980d342723494a must be in the format ```fixes #redmine_number - brief description```.\n  * 90504ad405ecd18b551dd91bc6ffc9642d3041ee must be in the format ```fixes #redmine_number - brief description```.\n  * 5ad496c2334cff48b32d6ff9eb9a5128d262590a must be in the format ```fixes #redmine_number - brief description```.\n  * 2e0790904b2394e8b596b17a86e1c00e663f3db5 must be in the format ```fixes #redmine_number - brief description```.\n  * 49bb741ec6ba6e759e96f074c385f567a3b33c65 must be in the format ```fixes #redmine_number - brief description```.\n  * 90ac28e3a47d9ede87a866d3ca47b8d2f33e81ca must be in the format ```fixes #redmine_number - brief description```.\n  * 0003933f69143636e85f004806d31345c6164248 must be in the format ```fixes #redmine_number - brief description```.\n  * f169a280a251444a6e9d987904a25f200f2f9353 must be in the format ```fixes #redmine_number - brief description```.\n  * 0cd423d4c2e381a220b25428d0ac0829ea8775e6 must be in the format ```fixes #redmine_number - brief description```.\n  * 232e5ad48827b95199da8fc5b0127d3373f8fb7f must be in the format ```fixes #redmine_number - brief description```.\n  * 72352008b1bd1ca3d4bdaee77b56650ec3bbe940 must be in the format ```fixes #redmine_number - brief description```.\n  * 25d94a6854975739c696d230d7b1faf55e7db14f must be in the format ```fixes #redmine_number - brief description```.\n  * 1ada23086636a32de9217c06c1385d7deab5ffd1 must be in the format ```fixes #redmine_number - brief description```.\n  * 332e380ca15dc901c72978da83494c3258249dfa must be in the format ```fixes #redmine_number - brief description```.\n  * accf2e86b56f42c9dacf6311072b36c485462330 must be in the format ```fixes #redmine_number - brief description```.\n  * 6e277fccc27e0dc1b605955aa58933af5def771f must be in the format ```fixes #redmine_number - brief description```.\n  * 74023438c37571bbc020dd2b6dc3a9c706fba8ed must be in the format ```fixes #redmine_number - brief description```.\n  * 31c5ffe631732e854f55650af1603462d14010ad must be in the format ```fixes #redmine_number - brief description```.\n  * 858c60f71b1c060f1ad28014218e3c0cf3e08948 must be in the format ```fixes #redmine_number - brief description```.\n  * 7b03b439e79e05b0bcabf1fe5f7bcef6dfcd564b must be in the format ```fixes #redmine_number - brief description```.\n\n\nIf you don't have a ticket number, please [create an issue in Redmine](http://projects.theforeman.org/projects/foreman/issues/new), selecting the appropriate project.\n\nMore guidelines are available on [the Foreman wiki](http://projects.theforeman.org/projects/foreman/wiki/Reviewing_patches-commit_message_format).\n\n---------------------------------------\nThis message was auto-generated by Foreman's [prprocessor](http://projects.theforeman.org/projects/foreman/wiki/PrProcessor)\n"}}