{"action":"created","comment":{"url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/comments/27909642","id":27909642,"diff_hunk":"@@ -0,0 +1,3 @@\n+[submodule \"plate-tectonics\"]\n+\tpath = plate-tectonics\n+\turl = https://github.com/Mindwerks/plate-tectonics.git","path":".gitmodules","position":3,"original_position":3,"commit_id":"7b83fdcc1a5d308e1284488d8b7765501252d83d","original_commit_id":"7b83fdcc1a5d308e1284488d8b7765501252d83d","user":{"login":"ftomassetti","id":439078,"avatar_url":"https://avatars.githubusercontent.com/u/439078?v=3","gravatar_id":"","url":"https://api.github.com/users/ftomassetti","html_url":"https://github.com/ftomassetti","followers_url":"https://api.github.com/users/ftomassetti/followers","following_url":"https://api.github.com/users/ftomassetti/following{/other_user}","gists_url":"https://api.github.com/users/ftomassetti/gists{/gist_id}","starred_url":"https://api.github.com/users/ftomassetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftomassetti/subscriptions","organizations_url":"https://api.github.com/users/ftomassetti/orgs","repos_url":"https://api.github.com/users/ftomassetti/repos","events_url":"https://api.github.com/users/ftomassetti/events{/privacy}","received_events_url":"https://api.github.com/users/ftomassetti/received_events","type":"User","site_admin":false},"body":"I have not experience with submodules. The problem is that it makes sense to have plate-tectonics has a C library, independent by any python code. We want then to wrap it in a python module but to do that we need its code. Can we do in another way?","created_at":"2015-04-07T19:06:53Z","updated_at":"2015-04-07T19:06:53Z","html_url":"https://github.com/Mindwerks/pyplatec/pull/10#discussion_r27909642","pull_request_url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/comments/27909642"},"html":{"href":"https://github.com/Mindwerks/pyplatec/pull/10#discussion_r27909642"},"pull_request":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10","id":32065620,"html_url":"https://github.com/Mindwerks/pyplatec/pull/10","diff_url":"https://github.com/Mindwerks/pyplatec/pull/10.diff","patch_url":"https://github.com/Mindwerks/pyplatec/pull/10.patch","issue_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues/10","number":10,"state":"open","locked":false,"title":"Make tests and make them pass on Travis and AppVeyor","user":{"login":"ftomassetti","id":439078,"avatar_url":"https://avatars.githubusercontent.com/u/439078?v=3","gravatar_id":"","url":"https://api.github.com/users/ftomassetti","html_url":"https://github.com/ftomassetti","followers_url":"https://api.github.com/users/ftomassetti/followers","following_url":"https://api.github.com/users/ftomassetti/following{/other_user}","gists_url":"https://api.github.com/users/ftomassetti/gists{/gist_id}","starred_url":"https://api.github.com/users/ftomassetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ftomassetti/subscriptions","organizations_url":"https://api.github.com/users/ftomassetti/orgs","repos_url":"https://api.github.com/users/ftomassetti/repos","events_url":"https://api.github.com/users/ftomassetti/events{/privacy}","received_events_url":"https://api.github.com/users/ftomassetti/received_events","type":"User","site_admin":false},"body":"This is a big, disorganized patch.\r\nAs first thing we removed a bunch of files and imported plate-tectonics as a module.\r\nThen we wrote super basic tests just for sanity check.\r\nWe configured AppVeyor and Travis and we have those tests passing.\r\n\r\nThis should be the basis for starting having a decent process from now on :)","created_at":"2015-03-26T21:59:14Z","updated_at":"2015-04-07T19:06:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c4997da7e9c92f18f12a0c94b5c16c1caec64f6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues/10/comments","statuses_url":"https://api.github.com/repos/Mindwerks/pyplatec/statuses/7b83fdcc1a5d308e1284488d8b7765501252d83d","head":{"label":"Mindwerks:tests","ref":"tests","sha":"7b83fdcc1a5d308e1284488d8b7765501252d83d","user":{"login":"Mindwerks","id":6725881,"avatar_url":"https://avatars.githubusercontent.com/u/6725881?v=3","gravatar_id":"","url":"https://api.github.com/users/Mindwerks","html_url":"https://github.com/Mindwerks","followers_url":"https://api.github.com/users/Mindwerks/followers","following_url":"https://api.github.com/users/Mindwerks/following{/other_user}","gists_url":"https://api.github.com/users/Mindwerks/gists{/gist_id}","starred_url":"https://api.github.com/users/Mindwerks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mindwerks/subscriptions","organizations_url":"https://api.github.com/users/Mindwerks/orgs","repos_url":"https://api.github.com/users/Mindwerks/repos","events_url":"https://api.github.com/users/Mindwerks/events{/privacy}","received_events_url":"https://api.github.com/users/Mindwerks/received_events","type":"Organization","site_admin":false},"repo":{"id":15476277,"name":"pyplatec","full_name":"Mindwerks/pyplatec","owner":{"login":"Mindwerks","id":6725881,"avatar_url":"https://avatars.githubusercontent.com/u/6725881?v=3","gravatar_id":"","url":"https://api.github.com/users/Mindwerks","html_url":"https://github.com/Mindwerks","followers_url":"https://api.github.com/users/Mindwerks/followers","following_url":"https://api.github.com/users/Mindwerks/following{/other_user}","gists_url":"https://api.github.com/users/Mindwerks/gists{/gist_id}","starred_url":"https://api.github.com/users/Mindwerks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mindwerks/subscriptions","organizations_url":"https://api.github.com/users/Mindwerks/orgs","repos_url":"https://api.github.com/users/Mindwerks/repos","events_url":"https://api.github.com/users/Mindwerks/events{/privacy}","received_events_url":"https://api.github.com/users/Mindwerks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mindwerks/pyplatec","description":"Plate simulation for python (wrapper of an existing C library)","fork":false,"url":"https://api.github.com/repos/Mindwerks/pyplatec","forks_url":"https://api.github.com/repos/Mindwerks/pyplatec/forks","keys_url":"https://api.github.com/repos/Mindwerks/pyplatec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mindwerks/pyplatec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mindwerks/pyplatec/teams","hooks_url":"https://api.github.com/repos/Mindwerks/pyplatec/hooks","issue_events_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues/events{/number}","events_url":"https://api.github.com/repos/Mindwerks/pyplatec/events","assignees_url":"https://api.github.com/repos/Mindwerks/pyplatec/assignees{/user}","branches_url":"https://api.github.com/repos/Mindwerks/pyplatec/branches{/branch}","tags_url":"https://api.github.com/repos/Mindwerks/pyplatec/tags","blobs_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mindwerks/pyplatec/statuses/{sha}","languages_url":"https://api.github.com/repos/Mindwerks/pyplatec/languages","stargazers_url":"https://api.github.com/repos/Mindwerks/pyplatec/stargazers","contributors_url":"https://api.github.com/repos/Mindwerks/pyplatec/contributors","subscribers_url":"https://api.github.com/repos/Mindwerks/pyplatec/subscribers","subscription_url":"https://api.github.com/repos/Mindwerks/pyplatec/subscription","commits_url":"https://api.github.com/repos/Mindwerks/pyplatec/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mindwerks/pyplatec/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mindwerks/pyplatec/contents/{+path}","compare_url":"https://api.github.com/repos/Mindwerks/pyplatec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mindwerks/pyplatec/merges","archive_url":"https://api.github.com/repos/Mindwerks/pyplatec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mindwerks/pyplatec/downloads","issues_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues{/number}","pulls_url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls{/number}","milestones_url":"https://api.github.com/repos/Mindwerks/pyplatec/milestones{/number}","notifications_url":"https://api.github.com/repos/Mindwerks/pyplatec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mindwerks/pyplatec/labels{/name}","releases_url":"https://api.github.com/repos/Mindwerks/pyplatec/releases{/id}","created_at":"2013-12-27T15:22:42Z","updated_at":"2015-02-20T14:27:01Z","pushed_at":"2015-03-26T21:59:14Z","git_url":"git://github.com/Mindwerks/pyplatec.git","ssh_url":"git@github.com:Mindwerks/pyplatec.git","clone_url":"https://github.com/Mindwerks/pyplatec.git","svn_url":"https://github.com/Mindwerks/pyplatec","homepage":null,"size":649,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"Mindwerks:master","ref":"master","sha":"b7ee468d28af873c40acb393a1676bbd4112aeeb","user":{"login":"Mindwerks","id":6725881,"avatar_url":"https://avatars.githubusercontent.com/u/6725881?v=3","gravatar_id":"","url":"https://api.github.com/users/Mindwerks","html_url":"https://github.com/Mindwerks","followers_url":"https://api.github.com/users/Mindwerks/followers","following_url":"https://api.github.com/users/Mindwerks/following{/other_user}","gists_url":"https://api.github.com/users/Mindwerks/gists{/gist_id}","starred_url":"https://api.github.com/users/Mindwerks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mindwerks/subscriptions","organizations_url":"https://api.github.com/users/Mindwerks/orgs","repos_url":"https://api.github.com/users/Mindwerks/repos","events_url":"https://api.github.com/users/Mindwerks/events{/privacy}","received_events_url":"https://api.github.com/users/Mindwerks/received_events","type":"Organization","site_admin":false},"repo":{"id":15476277,"name":"pyplatec","full_name":"Mindwerks/pyplatec","owner":{"login":"Mindwerks","id":6725881,"avatar_url":"https://avatars.githubusercontent.com/u/6725881?v=3","gravatar_id":"","url":"https://api.github.com/users/Mindwerks","html_url":"https://github.com/Mindwerks","followers_url":"https://api.github.com/users/Mindwerks/followers","following_url":"https://api.github.com/users/Mindwerks/following{/other_user}","gists_url":"https://api.github.com/users/Mindwerks/gists{/gist_id}","starred_url":"https://api.github.com/users/Mindwerks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mindwerks/subscriptions","organizations_url":"https://api.github.com/users/Mindwerks/orgs","repos_url":"https://api.github.com/users/Mindwerks/repos","events_url":"https://api.github.com/users/Mindwerks/events{/privacy}","received_events_url":"https://api.github.com/users/Mindwerks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Mindwerks/pyplatec","description":"Plate simulation for python (wrapper of an existing C library)","fork":false,"url":"https://api.github.com/repos/Mindwerks/pyplatec","forks_url":"https://api.github.com/repos/Mindwerks/pyplatec/forks","keys_url":"https://api.github.com/repos/Mindwerks/pyplatec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mindwerks/pyplatec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mindwerks/pyplatec/teams","hooks_url":"https://api.github.com/repos/Mindwerks/pyplatec/hooks","issue_events_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues/events{/number}","events_url":"https://api.github.com/repos/Mindwerks/pyplatec/events","assignees_url":"https://api.github.com/repos/Mindwerks/pyplatec/assignees{/user}","branches_url":"https://api.github.com/repos/Mindwerks/pyplatec/branches{/branch}","tags_url":"https://api.github.com/repos/Mindwerks/pyplatec/tags","blobs_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mindwerks/pyplatec/statuses/{sha}","languages_url":"https://api.github.com/repos/Mindwerks/pyplatec/languages","stargazers_url":"https://api.github.com/repos/Mindwerks/pyplatec/stargazers","contributors_url":"https://api.github.com/repos/Mindwerks/pyplatec/contributors","subscribers_url":"https://api.github.com/repos/Mindwerks/pyplatec/subscribers","subscription_url":"https://api.github.com/repos/Mindwerks/pyplatec/subscription","commits_url":"https://api.github.com/repos/Mindwerks/pyplatec/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mindwerks/pyplatec/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mindwerks/pyplatec/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mindwerks/pyplatec/contents/{+path}","compare_url":"https://api.github.com/repos/Mindwerks/pyplatec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mindwerks/pyplatec/merges","archive_url":"https://api.github.com/repos/Mindwerks/pyplatec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mindwerks/pyplatec/downloads","issues_url":"https://api.github.com/repos/Mindwerks/pyplatec/issues{/number}","pulls_url":"https://api.github.com/repos/Mindwerks/pyplatec/pulls{/number}","milestones_url":"https://api.github.com/repos/Mindwerks/pyplatec/milestones{/number}","notifications_url":"https://api.github.com/repos/Mindwerks/pyplatec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mindwerks/pyplatec/labels{/name}","releases_url":"https://api.github.com/repos/Mindwerks/pyplatec/releases{/id}","created_at":"2013-12-27T15:22:42Z","updated_at":"2015-02-20T14:27:01Z","pushed_at":"2015-03-26T21:59:14Z","git_url":"git://github.com/Mindwerks/pyplatec.git","ssh_url":"git@github.com:Mindwerks/pyplatec.git","clone_url":"https://github.com/Mindwerks/pyplatec.git","svn_url":"https://github.com/Mindwerks/pyplatec","homepage":null,"size":649,"stargazers_count":3,"watchers_count":3,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":5,"forks":2,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10"},"html":{"href":"https://github.com/Mindwerks/pyplatec/pull/10"},"issue":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/issues/10"},"comments":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Mindwerks/pyplatec/statuses/7b83fdcc1a5d308e1284488d8b7765501252d83d"}}}}