{"action":"created","comment":{"url":"https://api.github.com/repos/campagnola/vispy/pulls/comments/33573680","id":33573680,"diff_hunk":"@@ -215,4 +208,4 @@ def draw(self, transforms):\n             self._update_color_lev = False\n \n         LineVisual.set_data(self, pos=self._v, connect=self._c, color=self._cl)","path":"vispy/visuals/isoline.py","position":19,"original_position":19,"commit_id":"9f5ff428d506794e9a1264f20e685eb1dc9a5ef2","original_commit_id":"9f5ff428d506794e9a1264f20e685eb1dc9a5ef2","user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"body":"This looks expensive--ideally, `set_data` is only called if something has changed. I'd be happy to merge your changes as they are (especially since this was the state of the code before you got to it), but if you happen to have time to take care of this line, that'd be awesome.","created_at":"2015-06-30T13:46:45Z","updated_at":"2015-06-30T13:46:45Z","html_url":"https://github.com/campagnola/vispy/pull/9#discussion_r33573680","pull_request_url":"https://api.github.com/repos/campagnola/vispy/pulls/9","_links":{"self":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/comments/33573680"},"html":{"href":"https://github.com/campagnola/vispy/pull/9#discussion_r33573680"},"pull_request":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/campagnola/vispy/pulls/9","id":38653923,"html_url":"https://github.com/campagnola/vispy/pull/9","diff_url":"https://github.com/campagnola/vispy/pull/9.diff","patch_url":"https://github.com/campagnola/vispy/pull/9.patch","issue_url":"https://api.github.com/repos/campagnola/vispy/issues/9","number":9,"state":"open","locked":false,"title":"IsocurveVisual, IsolineVisual","user":{"login":"kmuehlbauer","id":5821660,"avatar_url":"https://avatars.githubusercontent.com/u/5821660?v=3","gravatar_id":"","url":"https://api.github.com/users/kmuehlbauer","html_url":"https://github.com/kmuehlbauer","followers_url":"https://api.github.com/users/kmuehlbauer/followers","following_url":"https://api.github.com/users/kmuehlbauer/following{/other_user}","gists_url":"https://api.github.com/users/kmuehlbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/kmuehlbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmuehlbauer/subscriptions","organizations_url":"https://api.github.com/users/kmuehlbauer/orgs","repos_url":"https://api.github.com/users/kmuehlbauer/repos","events_url":"https://api.github.com/users/kmuehlbauer/events{/privacy}","received_events_url":"https://api.github.com/users/kmuehlbauer/received_events","type":"User","site_admin":false},"body":"While adding multi-level support to IsocurveVisual, I tried to port IsolineVisual to new system (for testing). Worked so far. @campagnola please have a look, if you find the time.\r\n\r\nIn IsocurveVisual I added the fast matplotlib implementation of the isoline algorithm. Multilevel support is analogue to IsolineVisual done via `levels`. Seems to me that the _HAS_MPL checking could be made much better, also testing for x,y-meshgrid may be improved. (see also #989)\r\n\r\nI did not change the examples yet...","created_at":"2015-06-26T14:22:28Z","updated_at":"2015-06-30T13:46:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3171bb4e43353a3f9f3ad2c3b330bfc7f0c28df","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/campagnola/vispy/pulls/9/commits","review_comments_url":"https://api.github.com/repos/campagnola/vispy/pulls/9/comments","review_comment_url":"https://api.github.com/repos/campagnola/vispy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/campagnola/vispy/issues/9/comments","statuses_url":"https://api.github.com/repos/campagnola/vispy/statuses/9f5ff428d506794e9a1264f20e685eb1dc9a5ef2","head":{"label":"kmuehlbauer:scenegraph-update-isocurves","ref":"scenegraph-update-isocurves","sha":"9f5ff428d506794e9a1264f20e685eb1dc9a5ef2","user":{"login":"kmuehlbauer","id":5821660,"avatar_url":"https://avatars.githubusercontent.com/u/5821660?v=3","gravatar_id":"","url":"https://api.github.com/users/kmuehlbauer","html_url":"https://github.com/kmuehlbauer","followers_url":"https://api.github.com/users/kmuehlbauer/followers","following_url":"https://api.github.com/users/kmuehlbauer/following{/other_user}","gists_url":"https://api.github.com/users/kmuehlbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/kmuehlbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmuehlbauer/subscriptions","organizations_url":"https://api.github.com/users/kmuehlbauer/orgs","repos_url":"https://api.github.com/users/kmuehlbauer/repos","events_url":"https://api.github.com/users/kmuehlbauer/events{/privacy}","received_events_url":"https://api.github.com/users/kmuehlbauer/received_events","type":"User","site_admin":false},"repo":{"id":38092979,"name":"vispy","full_name":"kmuehlbauer/vispy","owner":{"login":"kmuehlbauer","id":5821660,"avatar_url":"https://avatars.githubusercontent.com/u/5821660?v=3","gravatar_id":"","url":"https://api.github.com/users/kmuehlbauer","html_url":"https://github.com/kmuehlbauer","followers_url":"https://api.github.com/users/kmuehlbauer/followers","following_url":"https://api.github.com/users/kmuehlbauer/following{/other_user}","gists_url":"https://api.github.com/users/kmuehlbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/kmuehlbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmuehlbauer/subscriptions","organizations_url":"https://api.github.com/users/kmuehlbauer/orgs","repos_url":"https://api.github.com/users/kmuehlbauer/repos","events_url":"https://api.github.com/users/kmuehlbauer/events{/privacy}","received_events_url":"https://api.github.com/users/kmuehlbauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kmuehlbauer/vispy","description":"Kai's vispy fork","fork":true,"url":"https://api.github.com/repos/kmuehlbauer/vispy","forks_url":"https://api.github.com/repos/kmuehlbauer/vispy/forks","keys_url":"https://api.github.com/repos/kmuehlbauer/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kmuehlbauer/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kmuehlbauer/vispy/teams","hooks_url":"https://api.github.com/repos/kmuehlbauer/vispy/hooks","issue_events_url":"https://api.github.com/repos/kmuehlbauer/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/kmuehlbauer/vispy/events","assignees_url":"https://api.github.com/repos/kmuehlbauer/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/kmuehlbauer/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/kmuehlbauer/vispy/tags","blobs_url":"https://api.github.com/repos/kmuehlbauer/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kmuehlbauer/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kmuehlbauer/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/kmuehlbauer/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kmuehlbauer/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/kmuehlbauer/vispy/languages","stargazers_url":"https://api.github.com/repos/kmuehlbauer/vispy/stargazers","contributors_url":"https://api.github.com/repos/kmuehlbauer/vispy/contributors","subscribers_url":"https://api.github.com/repos/kmuehlbauer/vispy/subscribers","subscription_url":"https://api.github.com/repos/kmuehlbauer/vispy/subscription","commits_url":"https://api.github.com/repos/kmuehlbauer/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/kmuehlbauer/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/kmuehlbauer/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/kmuehlbauer/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/kmuehlbauer/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/kmuehlbauer/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kmuehlbauer/vispy/merges","archive_url":"https://api.github.com/repos/kmuehlbauer/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kmuehlbauer/vispy/downloads","issues_url":"https://api.github.com/repos/kmuehlbauer/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/kmuehlbauer/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/kmuehlbauer/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/kmuehlbauer/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kmuehlbauer/vispy/labels{/name}","releases_url":"https://api.github.com/repos/kmuehlbauer/vispy/releases{/id}","created_at":"2015-06-26T05:42:01Z","updated_at":"2015-06-28T19:06:01Z","pushed_at":"2015-06-30T05:40:39Z","git_url":"git://github.com/kmuehlbauer/vispy.git","ssh_url":"git@github.com:kmuehlbauer/vispy.git","clone_url":"https://github.com/kmuehlbauer/vispy.git","svn_url":"https://github.com/kmuehlbauer/vispy","homepage":"http://vispy.org","size":9058,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"campagnola:scenegraph-update","ref":"scenegraph-update","sha":"981ab49be71be9b09cee6b4f4b9f55659c912cbe","user":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"repo":{"id":16300808,"name":"vispy","full_name":"campagnola/vispy","owner":{"login":"campagnola","id":940580,"avatar_url":"https://avatars.githubusercontent.com/u/940580?v=3","gravatar_id":"","url":"https://api.github.com/users/campagnola","html_url":"https://github.com/campagnola","followers_url":"https://api.github.com/users/campagnola/followers","following_url":"https://api.github.com/users/campagnola/following{/other_user}","gists_url":"https://api.github.com/users/campagnola/gists{/gist_id}","starred_url":"https://api.github.com/users/campagnola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campagnola/subscriptions","organizations_url":"https://api.github.com/users/campagnola/orgs","repos_url":"https://api.github.com/users/campagnola/repos","events_url":"https://api.github.com/users/campagnola/events{/privacy}","received_events_url":"https://api.github.com/users/campagnola/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/campagnola/vispy","description":"Luke's vispy fork","fork":true,"url":"https://api.github.com/repos/campagnola/vispy","forks_url":"https://api.github.com/repos/campagnola/vispy/forks","keys_url":"https://api.github.com/repos/campagnola/vispy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campagnola/vispy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campagnola/vispy/teams","hooks_url":"https://api.github.com/repos/campagnola/vispy/hooks","issue_events_url":"https://api.github.com/repos/campagnola/vispy/issues/events{/number}","events_url":"https://api.github.com/repos/campagnola/vispy/events","assignees_url":"https://api.github.com/repos/campagnola/vispy/assignees{/user}","branches_url":"https://api.github.com/repos/campagnola/vispy/branches{/branch}","tags_url":"https://api.github.com/repos/campagnola/vispy/tags","blobs_url":"https://api.github.com/repos/campagnola/vispy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campagnola/vispy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campagnola/vispy/git/refs{/sha}","trees_url":"https://api.github.com/repos/campagnola/vispy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campagnola/vispy/statuses/{sha}","languages_url":"https://api.github.com/repos/campagnola/vispy/languages","stargazers_url":"https://api.github.com/repos/campagnola/vispy/stargazers","contributors_url":"https://api.github.com/repos/campagnola/vispy/contributors","subscribers_url":"https://api.github.com/repos/campagnola/vispy/subscribers","subscription_url":"https://api.github.com/repos/campagnola/vispy/subscription","commits_url":"https://api.github.com/repos/campagnola/vispy/commits{/sha}","git_commits_url":"https://api.github.com/repos/campagnola/vispy/git/commits{/sha}","comments_url":"https://api.github.com/repos/campagnola/vispy/comments{/number}","issue_comment_url":"https://api.github.com/repos/campagnola/vispy/issues/comments{/number}","contents_url":"https://api.github.com/repos/campagnola/vispy/contents/{+path}","compare_url":"https://api.github.com/repos/campagnola/vispy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campagnola/vispy/merges","archive_url":"https://api.github.com/repos/campagnola/vispy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campagnola/vispy/downloads","issues_url":"https://api.github.com/repos/campagnola/vispy/issues{/number}","pulls_url":"https://api.github.com/repos/campagnola/vispy/pulls{/number}","milestones_url":"https://api.github.com/repos/campagnola/vispy/milestones{/number}","notifications_url":"https://api.github.com/repos/campagnola/vispy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campagnola/vispy/labels{/name}","releases_url":"https://api.github.com/repos/campagnola/vispy/releases{/id}","created_at":"2014-01-28T03:13:59Z","updated_at":"2015-03-26T00:43:14Z","pushed_at":"2015-06-30T05:40:39Z","git_url":"git://github.com/campagnola/vispy.git","ssh_url":"git@github.com:campagnola/vispy.git","clone_url":"https://github.com/campagnola/vispy.git","svn_url":"https://github.com/campagnola/vispy","homepage":"","size":10436,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/9"},"html":{"href":"https://github.com/campagnola/vispy/pull/9"},"issue":{"href":"https://api.github.com/repos/campagnola/vispy/issues/9"},"comments":{"href":"https://api.github.com/repos/campagnola/vispy/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/campagnola/vispy/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/campagnola/vispy/statuses/9f5ff428d506794e9a1264f20e685eb1dc9a5ef2"}}}}