{"action":"closed","number":4864,"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4864","id":41609940,"html_url":"https://github.com/matplotlib/matplotlib/pull/4864","diff_url":"https://github.com/matplotlib/matplotlib/pull/4864.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/4864.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/4864","number":4864,"state":"closed","locked":false,"title":"Add documentation for mpl_toolkits.axes_grid1.inset_locator","user":{"login":"sargas","id":33512,"avatar_url":"https://avatars.githubusercontent.com/u/33512?v=3","gravatar_id":"","url":"https://api.github.com/users/sargas","html_url":"https://github.com/sargas","followers_url":"https://api.github.com/users/sargas/followers","following_url":"https://api.github.com/users/sargas/following{/other_user}","gists_url":"https://api.github.com/users/sargas/gists{/gist_id}","starred_url":"https://api.github.com/users/sargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargas/subscriptions","organizations_url":"https://api.github.com/users/sargas/orgs","repos_url":"https://api.github.com/users/sargas/repos","events_url":"https://api.github.com/users/sargas/events{/privacy}","received_events_url":"https://api.github.com/users/sargas/received_events","type":"User","site_admin":false},"body":"This module has some nice, undocumented (except in narrative form) helpers that has been interesting to figure out.\n\nI made some formatting changes, and some slight API differences:\n\n1. `AnchoredSizeLocator` and `AnchoredZoomLocator` both overrode `__call__` merely to save the axes (which is unused in `AnchoredSizeLocator` anyways). I moved the saving of this value to the `__call__` of their superclass. No other file in matplotlib uses these classes, and the superclass doesn't look used for anything else online.\n2. `inset_axes` and `zoomed_inset_axes` take a `**kwarg`, but the only keyworded argument that would not result in an error is `borderpad`. I changed the functions to make that clear.\n\nI still have `AnchoredLocatorBase` (and its subclasses) to document, but I don't understand the code as is - for instance, a required parameter `offsetbox` is always unused, and I don't understand why a locator object (something used with `Axes.set_axes_locator`) would ever have any method except those used by `__call__` (making the capabilities inherited from `AnchoredOffsetBox` useless).","created_at":"2015-08-04T19:51:53Z","updated_at":"2015-12-16T16:17:48Z","closed_at":"2015-12-16T16:17:48Z","merged_at":"2015-12-16T16:17:48Z","merge_commit_sha":"421df38d4600d3b54c48369e74602adffa5bf1be","assignee":null,"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12","html_url":"https://github.com/matplotlib/matplotlib/milestones/proposed%20next%20point%20release%20(2.1)","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/12/labels","id":534144,"number":12,"title":"proposed next point release (2.1)","description":"Next feature release.\r\n\r\nBig ticket items:\r\n\r\n - MEP 22/27\r\n - traitlets","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":433,"closed_issues":260,"state":"open","created_at":"2014-01-13T03:21:09Z","updated_at":"2015-12-16T16:17:48Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4864/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4864/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/4864/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/e6181ded90fefc3f01d723df4bfdb64eb1cdfbd8","head":{"label":"sargas:document_inset_locator","ref":"document_inset_locator","sha":"e6181ded90fefc3f01d723df4bfdb64eb1cdfbd8","user":{"login":"sargas","id":33512,"avatar_url":"https://avatars.githubusercontent.com/u/33512?v=3","gravatar_id":"","url":"https://api.github.com/users/sargas","html_url":"https://github.com/sargas","followers_url":"https://api.github.com/users/sargas/followers","following_url":"https://api.github.com/users/sargas/following{/other_user}","gists_url":"https://api.github.com/users/sargas/gists{/gist_id}","starred_url":"https://api.github.com/users/sargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargas/subscriptions","organizations_url":"https://api.github.com/users/sargas/orgs","repos_url":"https://api.github.com/users/sargas/repos","events_url":"https://api.github.com/users/sargas/events{/privacy}","received_events_url":"https://api.github.com/users/sargas/received_events","type":"User","site_admin":false},"repo":{"id":39956867,"name":"matplotlib","full_name":"sargas/matplotlib","owner":{"login":"sargas","id":33512,"avatar_url":"https://avatars.githubusercontent.com/u/33512?v=3","gravatar_id":"","url":"https://api.github.com/users/sargas","html_url":"https://github.com/sargas","followers_url":"https://api.github.com/users/sargas/followers","following_url":"https://api.github.com/users/sargas/following{/other_user}","gists_url":"https://api.github.com/users/sargas/gists{/gist_id}","starred_url":"https://api.github.com/users/sargas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sargas/subscriptions","organizations_url":"https://api.github.com/users/sargas/orgs","repos_url":"https://api.github.com/users/sargas/repos","events_url":"https://api.github.com/users/sargas/events{/privacy}","received_events_url":"https://api.github.com/users/sargas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sargas/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/sargas/matplotlib","forks_url":"https://api.github.com/repos/sargas/matplotlib/forks","keys_url":"https://api.github.com/repos/sargas/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sargas/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sargas/matplotlib/teams","hooks_url":"https://api.github.com/repos/sargas/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/sargas/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/sargas/matplotlib/events","assignees_url":"https://api.github.com/repos/sargas/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/sargas/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/sargas/matplotlib/tags","blobs_url":"https://api.github.com/repos/sargas/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sargas/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sargas/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/sargas/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sargas/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/sargas/matplotlib/languages","stargazers_url":"https://api.github.com/repos/sargas/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/sargas/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/sargas/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/sargas/matplotlib/subscription","commits_url":"https://api.github.com/repos/sargas/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/sargas/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/sargas/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/sargas/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/sargas/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/sargas/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sargas/matplotlib/merges","archive_url":"https://api.github.com/repos/sargas/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sargas/matplotlib/downloads","issues_url":"https://api.github.com/repos/sargas/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/sargas/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/sargas/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/sargas/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sargas/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/sargas/matplotlib/releases{/id}","created_at":"2015-07-30T15:10:21Z","updated_at":"2015-07-30T15:10:29Z","pushed_at":"2015-11-18T20:02:15Z","git_url":"git://github.com/sargas/matplotlib.git","ssh_url":"git@github.com:sargas/matplotlib.git","clone_url":"https://github.com/sargas/matplotlib.git","svn_url":"https://github.com/sargas/matplotlib","homepage":"http://matplotlib.org/","size":225866,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"91ca2a3724ae91d28d979d942f82e125f42c76b2","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars.githubusercontent.com/u/215947?v=3","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","created_at":"2011-02-19T03:17:12Z","updated_at":"2015-12-16T15:59:00Z","pushed_at":"2015-12-16T16:17:48Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":293686,"stargazers_count":3108,"watchers_count":3108,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1568,"mirror_url":null,"open_issues_count":784,"forks":1568,"open_issues":784,"watchers":3108,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4864"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/4864"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/4864"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/4864/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4864/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/4864/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/e6181ded90fefc3f01d723df4bfdb64eb1cdfbd8"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars.githubusercontent.com/u/199813?v=3","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"comments":12,"review_comments":7,"commits":13,"additions":357,"deletions":70,"changed_files":3}}