{"action":"created","comment":{"url":"https://api.github.com/repos/interagent/pliny/pulls/comments/27527337","id":27527337,"diff_hunk":"@@ -0,0 +1,3 @@\n+if Config.timeout > 0","path":"lib/template/config/initializers/timeout.rb","position":1,"original_position":1,"commit_id":"fb615b6cad29a9fce55f3a1640bd6a7f406de84e","original_commit_id":"fb615b6cad29a9fce55f3a1640bd6a7f406de84e","user":{"login":"brandur","id":96890,"avatar_url":"https://avatars.githubusercontent.com/u/96890?v=3","gravatar_id":"","url":"https://api.github.com/users/brandur","html_url":"https://github.com/brandur","followers_url":"https://api.github.com/users/brandur/followers","following_url":"https://api.github.com/users/brandur/following{/other_user}","gists_url":"https://api.github.com/users/brandur/gists{/gist_id}","starred_url":"https://api.github.com/users/brandur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandur/subscriptions","organizations_url":"https://api.github.com/users/brandur/orgs","repos_url":"https://api.github.com/users/brandur/repos","events_url":"https://api.github.com/users/brandur/events{/privacy}","received_events_url":"https://api.github.com/users/brandur/received_events","type":"User","site_admin":false},"body":"Should we call this file `rack_timeout.rb` maybe? We recently introduced database timeouts as well, so it might help disambiguate.","created_at":"2015-03-31T21:56:05Z","updated_at":"2015-03-31T21:56:05Z","html_url":"https://github.com/interagent/pliny/pull/142#discussion_r27527337","pull_request_url":"https://api.github.com/repos/interagent/pliny/pulls/142","_links":{"self":{"href":"https://api.github.com/repos/interagent/pliny/pulls/comments/27527337"},"html":{"href":"https://github.com/interagent/pliny/pull/142#discussion_r27527337"},"pull_request":{"href":"https://api.github.com/repos/interagent/pliny/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/interagent/pliny/pulls/142","id":32280120,"html_url":"https://github.com/interagent/pliny/pull/142","diff_url":"https://github.com/interagent/pliny/pull/142.diff","patch_url":"https://github.com/interagent/pliny/pull/142.patch","issue_url":"https://api.github.com/repos/interagent/pliny/issues/142","number":142,"state":"open","locked":false,"title":"use Rack::Timeout","user":{"login":"pedro","id":2248,"avatar_url":"https://avatars.githubusercontent.com/u/2248?v=3","gravatar_id":"","url":"https://api.github.com/users/pedro","html_url":"https://github.com/pedro","followers_url":"https://api.github.com/users/pedro/followers","following_url":"https://api.github.com/users/pedro/following{/other_user}","gists_url":"https://api.github.com/users/pedro/gists{/gist_id}","starred_url":"https://api.github.com/users/pedro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedro/subscriptions","organizations_url":"https://api.github.com/users/pedro/orgs","repos_url":"https://api.github.com/users/pedro/repos","events_url":"https://api.github.com/users/pedro/events{/privacy}","received_events_url":"https://api.github.com/users/pedro/received_events","type":"User","site_admin":false},"body":"Fix #141.\r\n\r\nCurrent behavior on timeout is to log the corresponding Rack::Timeout::Error exception to Rollbar and render a 500. I think this is a sensible default, and certainly better than the current state where there's apparently no visibility into timeouts. Thoughts?","created_at":"2015-03-31T00:10:17Z","updated_at":"2015-03-31T21:56:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec518caaa22804ecd653e98ab63f3bf1b0f34b15","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/interagent/pliny/pulls/142/commits","review_comments_url":"https://api.github.com/repos/interagent/pliny/pulls/142/comments","review_comment_url":"https://api.github.com/repos/interagent/pliny/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interagent/pliny/issues/142/comments","statuses_url":"https://api.github.com/repos/interagent/pliny/statuses/fb615b6cad29a9fce55f3a1640bd6a7f406de84e","head":{"label":"interagent:pedro-rack-timeout","ref":"pedro-rack-timeout","sha":"fb615b6cad29a9fce55f3a1640bd6a7f406de84e","user":{"login":"interagent","id":7388387,"avatar_url":"https://avatars.githubusercontent.com/u/7388387?v=3","gravatar_id":"","url":"https://api.github.com/users/interagent","html_url":"https://github.com/interagent","followers_url":"https://api.github.com/users/interagent/followers","following_url":"https://api.github.com/users/interagent/following{/other_user}","gists_url":"https://api.github.com/users/interagent/gists{/gist_id}","starred_url":"https://api.github.com/users/interagent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interagent/subscriptions","organizations_url":"https://api.github.com/users/interagent/orgs","repos_url":"https://api.github.com/users/interagent/repos","events_url":"https://api.github.com/users/interagent/events{/privacy}","received_events_url":"https://api.github.com/users/interagent/received_events","type":"Organization","site_admin":false},"repo":{"id":19099484,"name":"pliny","full_name":"interagent/pliny","owner":{"login":"interagent","id":7388387,"avatar_url":"https://avatars.githubusercontent.com/u/7388387?v=3","gravatar_id":"","url":"https://api.github.com/users/interagent","html_url":"https://github.com/interagent","followers_url":"https://api.github.com/users/interagent/followers","following_url":"https://api.github.com/users/interagent/following{/other_user}","gists_url":"https://api.github.com/users/interagent/gists{/gist_id}","starred_url":"https://api.github.com/users/interagent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interagent/subscriptions","organizations_url":"https://api.github.com/users/interagent/orgs","repos_url":"https://api.github.com/users/interagent/repos","events_url":"https://api.github.com/users/interagent/events{/privacy}","received_events_url":"https://api.github.com/users/interagent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interagent/pliny","description":"Write excellent APIs in Ruby","fork":false,"url":"https://api.github.com/repos/interagent/pliny","forks_url":"https://api.github.com/repos/interagent/pliny/forks","keys_url":"https://api.github.com/repos/interagent/pliny/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interagent/pliny/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interagent/pliny/teams","hooks_url":"https://api.github.com/repos/interagent/pliny/hooks","issue_events_url":"https://api.github.com/repos/interagent/pliny/issues/events{/number}","events_url":"https://api.github.com/repos/interagent/pliny/events","assignees_url":"https://api.github.com/repos/interagent/pliny/assignees{/user}","branches_url":"https://api.github.com/repos/interagent/pliny/branches{/branch}","tags_url":"https://api.github.com/repos/interagent/pliny/tags","blobs_url":"https://api.github.com/repos/interagent/pliny/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interagent/pliny/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interagent/pliny/git/refs{/sha}","trees_url":"https://api.github.com/repos/interagent/pliny/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interagent/pliny/statuses/{sha}","languages_url":"https://api.github.com/repos/interagent/pliny/languages","stargazers_url":"https://api.github.com/repos/interagent/pliny/stargazers","contributors_url":"https://api.github.com/repos/interagent/pliny/contributors","subscribers_url":"https://api.github.com/repos/interagent/pliny/subscribers","subscription_url":"https://api.github.com/repos/interagent/pliny/subscription","commits_url":"https://api.github.com/repos/interagent/pliny/commits{/sha}","git_commits_url":"https://api.github.com/repos/interagent/pliny/git/commits{/sha}","comments_url":"https://api.github.com/repos/interagent/pliny/comments{/number}","issue_comment_url":"https://api.github.com/repos/interagent/pliny/issues/comments{/number}","contents_url":"https://api.github.com/repos/interagent/pliny/contents/{+path}","compare_url":"https://api.github.com/repos/interagent/pliny/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interagent/pliny/merges","archive_url":"https://api.github.com/repos/interagent/pliny/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interagent/pliny/downloads","issues_url":"https://api.github.com/repos/interagent/pliny/issues{/number}","pulls_url":"https://api.github.com/repos/interagent/pliny/pulls{/number}","milestones_url":"https://api.github.com/repos/interagent/pliny/milestones{/number}","notifications_url":"https://api.github.com/repos/interagent/pliny/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interagent/pliny/labels{/name}","releases_url":"https://api.github.com/repos/interagent/pliny/releases{/id}","created_at":"2014-04-24T07:22:09Z","updated_at":"2015-03-31T20:58:59Z","pushed_at":"2015-03-31T00:11:36Z","git_url":"git://github.com/interagent/pliny.git","ssh_url":"git@github.com:interagent/pliny.git","clone_url":"https://github.com/interagent/pliny.git","svn_url":"https://github.com/interagent/pliny","homepage":"","size":1936,"stargazers_count":336,"watchers_count":336,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":14,"forks":28,"open_issues":14,"watchers":336,"default_branch":"master"}},"base":{"label":"interagent:master","ref":"master","sha":"b2022afc7beca0f7065c1347232e1c25ea725453","user":{"login":"interagent","id":7388387,"avatar_url":"https://avatars.githubusercontent.com/u/7388387?v=3","gravatar_id":"","url":"https://api.github.com/users/interagent","html_url":"https://github.com/interagent","followers_url":"https://api.github.com/users/interagent/followers","following_url":"https://api.github.com/users/interagent/following{/other_user}","gists_url":"https://api.github.com/users/interagent/gists{/gist_id}","starred_url":"https://api.github.com/users/interagent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interagent/subscriptions","organizations_url":"https://api.github.com/users/interagent/orgs","repos_url":"https://api.github.com/users/interagent/repos","events_url":"https://api.github.com/users/interagent/events{/privacy}","received_events_url":"https://api.github.com/users/interagent/received_events","type":"Organization","site_admin":false},"repo":{"id":19099484,"name":"pliny","full_name":"interagent/pliny","owner":{"login":"interagent","id":7388387,"avatar_url":"https://avatars.githubusercontent.com/u/7388387?v=3","gravatar_id":"","url":"https://api.github.com/users/interagent","html_url":"https://github.com/interagent","followers_url":"https://api.github.com/users/interagent/followers","following_url":"https://api.github.com/users/interagent/following{/other_user}","gists_url":"https://api.github.com/users/interagent/gists{/gist_id}","starred_url":"https://api.github.com/users/interagent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interagent/subscriptions","organizations_url":"https://api.github.com/users/interagent/orgs","repos_url":"https://api.github.com/users/interagent/repos","events_url":"https://api.github.com/users/interagent/events{/privacy}","received_events_url":"https://api.github.com/users/interagent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interagent/pliny","description":"Write excellent APIs in Ruby","fork":false,"url":"https://api.github.com/repos/interagent/pliny","forks_url":"https://api.github.com/repos/interagent/pliny/forks","keys_url":"https://api.github.com/repos/interagent/pliny/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interagent/pliny/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interagent/pliny/teams","hooks_url":"https://api.github.com/repos/interagent/pliny/hooks","issue_events_url":"https://api.github.com/repos/interagent/pliny/issues/events{/number}","events_url":"https://api.github.com/repos/interagent/pliny/events","assignees_url":"https://api.github.com/repos/interagent/pliny/assignees{/user}","branches_url":"https://api.github.com/repos/interagent/pliny/branches{/branch}","tags_url":"https://api.github.com/repos/interagent/pliny/tags","blobs_url":"https://api.github.com/repos/interagent/pliny/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interagent/pliny/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interagent/pliny/git/refs{/sha}","trees_url":"https://api.github.com/repos/interagent/pliny/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interagent/pliny/statuses/{sha}","languages_url":"https://api.github.com/repos/interagent/pliny/languages","stargazers_url":"https://api.github.com/repos/interagent/pliny/stargazers","contributors_url":"https://api.github.com/repos/interagent/pliny/contributors","subscribers_url":"https://api.github.com/repos/interagent/pliny/subscribers","subscription_url":"https://api.github.com/repos/interagent/pliny/subscription","commits_url":"https://api.github.com/repos/interagent/pliny/commits{/sha}","git_commits_url":"https://api.github.com/repos/interagent/pliny/git/commits{/sha}","comments_url":"https://api.github.com/repos/interagent/pliny/comments{/number}","issue_comment_url":"https://api.github.com/repos/interagent/pliny/issues/comments{/number}","contents_url":"https://api.github.com/repos/interagent/pliny/contents/{+path}","compare_url":"https://api.github.com/repos/interagent/pliny/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interagent/pliny/merges","archive_url":"https://api.github.com/repos/interagent/pliny/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interagent/pliny/downloads","issues_url":"https://api.github.com/repos/interagent/pliny/issues{/number}","pulls_url":"https://api.github.com/repos/interagent/pliny/pulls{/number}","milestones_url":"https://api.github.com/repos/interagent/pliny/milestones{/number}","notifications_url":"https://api.github.com/repos/interagent/pliny/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interagent/pliny/labels{/name}","releases_url":"https://api.github.com/repos/interagent/pliny/releases{/id}","created_at":"2014-04-24T07:22:09Z","updated_at":"2015-03-31T20:58:59Z","pushed_at":"2015-03-31T00:11:36Z","git_url":"git://github.com/interagent/pliny.git","ssh_url":"git@github.com:interagent/pliny.git","clone_url":"https://github.com/interagent/pliny.git","svn_url":"https://github.com/interagent/pliny","homepage":"","size":1936,"stargazers_count":336,"watchers_count":336,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"open_issues_count":14,"forks":28,"open_issues":14,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interagent/pliny/pulls/142"},"html":{"href":"https://github.com/interagent/pliny/pull/142"},"issue":{"href":"https://api.github.com/repos/interagent/pliny/issues/142"},"comments":{"href":"https://api.github.com/repos/interagent/pliny/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/interagent/pliny/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/interagent/pliny/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interagent/pliny/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/interagent/pliny/statuses/fb615b6cad29a9fce55f3a1640bd6a7f406de84e"}}}}