{"comment":{"url":"https://api.github.com/repos/snoyberg/http-client/comments/10718689","html_url":"https://github.com/snoyberg/http-client/commit/b86b1cdd91e56ee33150433dedb32954d2082621#commitcomment-10718689","id":10718689,"user":{"login":"feuerbach","id":24844,"avatar_url":"https://avatars.githubusercontent.com/u/24844?v=3","gravatar_id":"","url":"https://api.github.com/users/feuerbach","html_url":"https://github.com/feuerbach","followers_url":"https://api.github.com/users/feuerbach/followers","following_url":"https://api.github.com/users/feuerbach/following{/other_user}","gists_url":"https://api.github.com/users/feuerbach/gists{/gist_id}","starred_url":"https://api.github.com/users/feuerbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feuerbach/subscriptions","organizations_url":"https://api.github.com/users/feuerbach/orgs","repos_url":"https://api.github.com/users/feuerbach/repos","events_url":"https://api.github.com/users/feuerbach/events{/privacy}","received_events_url":"https://api.github.com/users/feuerbach/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":"","commit_id":"b86b1cdd91e56ee33150433dedb32954d2082621","created_at":"2015-04-14T16:57:34Z","updated_at":"2015-04-14T16:57:34Z","body":"Here's the issue with this patch.\r\n\r\nSomeone may be catching `FailedConnectionException` in order to reconnect upon reaching the timeout. In fact, that was what I considered to do.\r\n\r\nThis patch would break this code silently, in a way that even tests are unlikely to catch.\r\n\r\nSo I would prefer (in this order of preference):\r\n\r\n1. Documenting what `FailedConnectionException` means and changing its show instance. This has the benefit of not breaking any code and having most of the benefits.\r\n2. Actually renaming the `FailedConnectionException` constructor. This way any code which attempts to catch it will break, which may be annoying, but will explicitly tell the users that they should fix it."}}