{"action":"created","comment":{"url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/comments/31666663","id":31666663,"diff_hunk":"@@ -276,6 +276,7 @@ public void checkIn(ServiceHandle<S> handle) throws Exception {\n             _serviceCounter.dec();\n         }\n \n+        context.stop();","path":"core/src/main/java/com/bazaarvoice/ostrich/pool/MultiThreadedClientServiceCache.java","position":23,"original_position":20,"commit_id":"7883487959a9030bf7b5ea1eebb412b7c7853d0f","original_commit_id":"fd91ec51b20b89a1d37bedf112d1fc0bcd068ede","user":{"login":"dump247","id":448969,"avatar_url":"https://avatars.githubusercontent.com/u/448969?v=3","gravatar_id":"","url":"https://api.github.com/users/dump247","html_url":"https://github.com/dump247","followers_url":"https://api.github.com/users/dump247/followers","following_url":"https://api.github.com/users/dump247/following{/other_user}","gists_url":"https://api.github.com/users/dump247/gists{/gist_id}","starred_url":"https://api.github.com/users/dump247/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dump247/subscriptions","organizations_url":"https://api.github.com/users/dump247/orgs","repos_url":"https://api.github.com/users/dump247/repos","events_url":"https://api.github.com/users/dump247/events{/privacy}","received_events_url":"https://api.github.com/users/dump247/received_events","type":"User","site_admin":false},"body":"My apologies. Yes, there is currently no try/catch in doRegister. However, you are moving the timer context from `register`, which was doing the `context.stop()` in a finally block. I was wondering if not putting it in a finally block was a decision or if it was just an oversight.","created_at":"2015-06-03T20:33:10Z","updated_at":"2015-06-03T20:33:10Z","html_url":"https://github.com/bazaarvoice/ostrich/pull/175#discussion_r31666663","pull_request_url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175","_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/comments/31666663"},"html":{"href":"https://github.com/bazaarvoice/ostrich/pull/175#discussion_r31666663"},"pull_request":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175"}}},"pull_request":{"url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175","id":36860808,"html_url":"https://github.com/bazaarvoice/ostrich/pull/175","diff_url":"https://github.com/bazaarvoice/ostrich/pull/175.diff","patch_url":"https://github.com/bazaarvoice/ostrich/pull/175.patch","issue_url":"https://api.github.com/repos/bazaarvoice/ostrich/issues/175","number":175,"state":"open","locked":false,"title":"fixed cache register metrix reporting","user":{"login":"bivasdas","id":5587198,"avatar_url":"https://avatars.githubusercontent.com/u/5587198?v=3","gravatar_id":"","url":"https://api.github.com/users/bivasdas","html_url":"https://github.com/bivasdas","followers_url":"https://api.github.com/users/bivasdas/followers","following_url":"https://api.github.com/users/bivasdas/following{/other_user}","gists_url":"https://api.github.com/users/bivasdas/gists{/gist_id}","starred_url":"https://api.github.com/users/bivasdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bivasdas/subscriptions","organizations_url":"https://api.github.com/users/bivasdas/orgs","repos_url":"https://api.github.com/users/bivasdas/repos","events_url":"https://api.github.com/users/bivasdas/events{/privacy}","received_events_url":"https://api.github.com/users/bivasdas/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-03T18:09:56Z","updated_at":"2015-06-03T20:33:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27222fd15ab587784503851f2c35c954477134ab","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175/commits","review_comments_url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175/comments","review_comment_url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bazaarvoice/ostrich/issues/175/comments","statuses_url":"https://api.github.com/repos/bazaarvoice/ostrich/statuses/7883487959a9030bf7b5ea1eebb412b7c7853d0f","head":{"label":"bivasdas:1.7.x-fix","ref":"1.7.x-fix","sha":"7883487959a9030bf7b5ea1eebb412b7c7853d0f","user":{"login":"bivasdas","id":5587198,"avatar_url":"https://avatars.githubusercontent.com/u/5587198?v=3","gravatar_id":"","url":"https://api.github.com/users/bivasdas","html_url":"https://github.com/bivasdas","followers_url":"https://api.github.com/users/bivasdas/followers","following_url":"https://api.github.com/users/bivasdas/following{/other_user}","gists_url":"https://api.github.com/users/bivasdas/gists{/gist_id}","starred_url":"https://api.github.com/users/bivasdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bivasdas/subscriptions","organizations_url":"https://api.github.com/users/bivasdas/orgs","repos_url":"https://api.github.com/users/bivasdas/repos","events_url":"https://api.github.com/users/bivasdas/events{/privacy}","received_events_url":"https://api.github.com/users/bivasdas/received_events","type":"User","site_admin":false},"repo":{"id":25937888,"name":"ostrich","full_name":"bivasdas/ostrich","owner":{"login":"bivasdas","id":5587198,"avatar_url":"https://avatars.githubusercontent.com/u/5587198?v=3","gravatar_id":"","url":"https://api.github.com/users/bivasdas","html_url":"https://github.com/bivasdas","followers_url":"https://api.github.com/users/bivasdas/followers","following_url":"https://api.github.com/users/bivasdas/following{/other_user}","gists_url":"https://api.github.com/users/bivasdas/gists{/gist_id}","starred_url":"https://api.github.com/users/bivasdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bivasdas/subscriptions","organizations_url":"https://api.github.com/users/bivasdas/orgs","repos_url":"https://api.github.com/users/bivasdas/repos","events_url":"https://api.github.com/users/bivasdas/events{/privacy}","received_events_url":"https://api.github.com/users/bivasdas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bivasdas/ostrich","description":"SOA Library","fork":true,"url":"https://api.github.com/repos/bivasdas/ostrich","forks_url":"https://api.github.com/repos/bivasdas/ostrich/forks","keys_url":"https://api.github.com/repos/bivasdas/ostrich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bivasdas/ostrich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bivasdas/ostrich/teams","hooks_url":"https://api.github.com/repos/bivasdas/ostrich/hooks","issue_events_url":"https://api.github.com/repos/bivasdas/ostrich/issues/events{/number}","events_url":"https://api.github.com/repos/bivasdas/ostrich/events","assignees_url":"https://api.github.com/repos/bivasdas/ostrich/assignees{/user}","branches_url":"https://api.github.com/repos/bivasdas/ostrich/branches{/branch}","tags_url":"https://api.github.com/repos/bivasdas/ostrich/tags","blobs_url":"https://api.github.com/repos/bivasdas/ostrich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bivasdas/ostrich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bivasdas/ostrich/git/refs{/sha}","trees_url":"https://api.github.com/repos/bivasdas/ostrich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bivasdas/ostrich/statuses/{sha}","languages_url":"https://api.github.com/repos/bivasdas/ostrich/languages","stargazers_url":"https://api.github.com/repos/bivasdas/ostrich/stargazers","contributors_url":"https://api.github.com/repos/bivasdas/ostrich/contributors","subscribers_url":"https://api.github.com/repos/bivasdas/ostrich/subscribers","subscription_url":"https://api.github.com/repos/bivasdas/ostrich/subscription","commits_url":"https://api.github.com/repos/bivasdas/ostrich/commits{/sha}","git_commits_url":"https://api.github.com/repos/bivasdas/ostrich/git/commits{/sha}","comments_url":"https://api.github.com/repos/bivasdas/ostrich/comments{/number}","issue_comment_url":"https://api.github.com/repos/bivasdas/ostrich/issues/comments{/number}","contents_url":"https://api.github.com/repos/bivasdas/ostrich/contents/{+path}","compare_url":"https://api.github.com/repos/bivasdas/ostrich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bivasdas/ostrich/merges","archive_url":"https://api.github.com/repos/bivasdas/ostrich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bivasdas/ostrich/downloads","issues_url":"https://api.github.com/repos/bivasdas/ostrich/issues{/number}","pulls_url":"https://api.github.com/repos/bivasdas/ostrich/pulls{/number}","milestones_url":"https://api.github.com/repos/bivasdas/ostrich/milestones{/number}","notifications_url":"https://api.github.com/repos/bivasdas/ostrich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bivasdas/ostrich/labels{/name}","releases_url":"https://api.github.com/repos/bivasdas/ostrich/releases{/id}","created_at":"2014-10-29T19:35:15Z","updated_at":"2015-04-01T16:09:50Z","pushed_at":"2015-06-03T20:28:47Z","git_url":"git://github.com/bivasdas/ostrich.git","ssh_url":"git@github.com:bivasdas/ostrich.git","clone_url":"https://github.com/bivasdas/ostrich.git","svn_url":"https://github.com/bivasdas/ostrich","homepage":"","size":1937,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bazaarvoice:1.7.x","ref":"1.7.x","sha":"91c02a15e6d22914dc51211266c50fcf48de5175","user":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"repo":{"id":4341250,"name":"ostrich","full_name":"bazaarvoice/ostrich","owner":{"login":"bazaarvoice","id":152469,"avatar_url":"https://avatars.githubusercontent.com/u/152469?v=3","gravatar_id":"","url":"https://api.github.com/users/bazaarvoice","html_url":"https://github.com/bazaarvoice","followers_url":"https://api.github.com/users/bazaarvoice/followers","following_url":"https://api.github.com/users/bazaarvoice/following{/other_user}","gists_url":"https://api.github.com/users/bazaarvoice/gists{/gist_id}","starred_url":"https://api.github.com/users/bazaarvoice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bazaarvoice/subscriptions","organizations_url":"https://api.github.com/users/bazaarvoice/orgs","repos_url":"https://api.github.com/users/bazaarvoice/repos","events_url":"https://api.github.com/users/bazaarvoice/events{/privacy}","received_events_url":"https://api.github.com/users/bazaarvoice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bazaarvoice/ostrich","description":"SOA Library","fork":false,"url":"https://api.github.com/repos/bazaarvoice/ostrich","forks_url":"https://api.github.com/repos/bazaarvoice/ostrich/forks","keys_url":"https://api.github.com/repos/bazaarvoice/ostrich/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bazaarvoice/ostrich/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bazaarvoice/ostrich/teams","hooks_url":"https://api.github.com/repos/bazaarvoice/ostrich/hooks","issue_events_url":"https://api.github.com/repos/bazaarvoice/ostrich/issues/events{/number}","events_url":"https://api.github.com/repos/bazaarvoice/ostrich/events","assignees_url":"https://api.github.com/repos/bazaarvoice/ostrich/assignees{/user}","branches_url":"https://api.github.com/repos/bazaarvoice/ostrich/branches{/branch}","tags_url":"https://api.github.com/repos/bazaarvoice/ostrich/tags","blobs_url":"https://api.github.com/repos/bazaarvoice/ostrich/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bazaarvoice/ostrich/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bazaarvoice/ostrich/git/refs{/sha}","trees_url":"https://api.github.com/repos/bazaarvoice/ostrich/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bazaarvoice/ostrich/statuses/{sha}","languages_url":"https://api.github.com/repos/bazaarvoice/ostrich/languages","stargazers_url":"https://api.github.com/repos/bazaarvoice/ostrich/stargazers","contributors_url":"https://api.github.com/repos/bazaarvoice/ostrich/contributors","subscribers_url":"https://api.github.com/repos/bazaarvoice/ostrich/subscribers","subscription_url":"https://api.github.com/repos/bazaarvoice/ostrich/subscription","commits_url":"https://api.github.com/repos/bazaarvoice/ostrich/commits{/sha}","git_commits_url":"https://api.github.com/repos/bazaarvoice/ostrich/git/commits{/sha}","comments_url":"https://api.github.com/repos/bazaarvoice/ostrich/comments{/number}","issue_comment_url":"https://api.github.com/repos/bazaarvoice/ostrich/issues/comments{/number}","contents_url":"https://api.github.com/repos/bazaarvoice/ostrich/contents/{+path}","compare_url":"https://api.github.com/repos/bazaarvoice/ostrich/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bazaarvoice/ostrich/merges","archive_url":"https://api.github.com/repos/bazaarvoice/ostrich/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bazaarvoice/ostrich/downloads","issues_url":"https://api.github.com/repos/bazaarvoice/ostrich/issues{/number}","pulls_url":"https://api.github.com/repos/bazaarvoice/ostrich/pulls{/number}","milestones_url":"https://api.github.com/repos/bazaarvoice/ostrich/milestones{/number}","notifications_url":"https://api.github.com/repos/bazaarvoice/ostrich/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bazaarvoice/ostrich/labels{/name}","releases_url":"https://api.github.com/repos/bazaarvoice/ostrich/releases{/id}","created_at":"2012-05-15T22:13:54Z","updated_at":"2015-05-18T22:09:15Z","pushed_at":"2015-06-03T20:28:47Z","git_url":"git://github.com/bazaarvoice/ostrich.git","ssh_url":"git@github.com:bazaarvoice/ostrich.git","clone_url":"https://github.com/bazaarvoice/ostrich.git","svn_url":"https://github.com/bazaarvoice/ostrich","homepage":"","size":2484,"stargazers_count":23,"watchers_count":23,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":12,"forks":19,"open_issues":12,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175"},"html":{"href":"https://github.com/bazaarvoice/ostrich/pull/175"},"issue":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/issues/175"},"comments":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/issues/175/comments"},"review_comments":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175/comments"},"review_comment":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/pulls/175/commits"},"statuses":{"href":"https://api.github.com/repos/bazaarvoice/ostrich/statuses/7883487959a9030bf7b5ea1eebb412b7c7853d0f"}}}}