{"action":"created","comment":{"url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/comments/24550774","id":24550774,"diff_hunk":"@@ -91,23 +92,30 @@ public static void setup() {\n         Cluck.publish(\"Elevator Lowering\", lowering);\n \n         FloatInputPoll main = Mixing.quadSelect(raising, lowering, FloatMixing.always(0.0f), FloatMixing.negate(winchSpeed), winchSpeed, FloatMixing.always(0.0f));\n-        FloatInputPoll override = new FloatInputPoll() {\n-            @Override\n-            public float get() {\n-                float f = overrideValue.get();\n-                if (atTop.get()) {\n-                    f = Math.min(0, f);\n-                }\n-\n-                if (atBottom.get()) {\n-                    f = Math.max(0, f);\n-                }\n-\n-                return f;\n+        FloatInputPoll override = () -> {\n+            float f = overrideValue.get();\n+            if (atTop.get()) {\n+                f = Math.min(0, f);\n             }\n+\n+            if (atBottom.get()) {\n+                f = Math.max(0, f);\n+            }\n+\n+            return f;\n         };\n+        \n         FloatMixing.pumpWhen(QuasarHelios.constantControl, Mixing.select((BooleanInputPoll) overrideEnabled, main, override), winch);\n \n+        FloatInput elevatorTimeout = ControlInterface.mainTuning.getFloat(\"elevator-timeout\", 1.0f);\n+\n+        ExpirationTimer timer = new ExpirationTimer();\n+\n+        timer.schedule(elevatorTimeout, BooleanMixing.getSetEvent(BooleanMixing.combine(raising, lowering), false));\n+        \n+        raising.send(timer.getRunningControl());\n+        lowering.send(timer.getRunningControl());","path":"QuasarHelios2015/src/org/team1540/quasarhelios/Elevator.java","position":78,"original_position":78,"commit_id":"797aef041c094f4f7ab76f316af4ad7ff03e3132","original_commit_id":"797aef041c094f4f7ab76f316af4ad7ff03e3132","user":{"login":"col6y","id":5056099,"avatar_url":"https://avatars.githubusercontent.com/u/5056099?v=3","gravatar_id":"","url":"https://api.github.com/users/col6y","html_url":"https://github.com/col6y","followers_url":"https://api.github.com/users/col6y/followers","following_url":"https://api.github.com/users/col6y/following{/other_user}","gists_url":"https://api.github.com/users/col6y/gists{/gist_id}","starred_url":"https://api.github.com/users/col6y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/col6y/subscriptions","organizations_url":"https://api.github.com/users/col6y/orgs","repos_url":"https://api.github.com/users/col6y/repos","events_url":"https://api.github.com/users/col6y/events{/privacy}","received_events_url":"https://api.github.com/users/col6y/received_events","type":"User","site_admin":false},"body":"As usual, you probably don't want two separate sources going to any output at the same time. Consider using something like `BooleanMixing.orBooleans`.","created_at":"2015-02-12T01:11:49Z","updated_at":"2015-02-12T01:11:49Z","html_url":"https://github.com/flamingchickens1540/quasar-helios-2015/pull/55#discussion_r24550774","pull_request_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55","_links":{"self":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/comments/24550774"},"html":{"href":"https://github.com/flamingchickens1540/quasar-helios-2015/pull/55#discussion_r24550774"},"pull_request":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55"}}},"pull_request":{"url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55","id":29141467,"html_url":"https://github.com/flamingchickens1540/quasar-helios-2015/pull/55","diff_url":"https://github.com/flamingchickens1540/quasar-helios-2015/pull/55.diff","patch_url":"https://github.com/flamingchickens1540/quasar-helios-2015/pull/55.patch","issue_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/55","number":55,"state":"open","locked":false,"title":"Robustify","user":{"login":"vincent-miller","id":10442769,"avatar_url":"https://avatars.githubusercontent.com/u/10442769?v=3","gravatar_id":"","url":"https://api.github.com/users/vincent-miller","html_url":"https://github.com/vincent-miller","followers_url":"https://api.github.com/users/vincent-miller/followers","following_url":"https://api.github.com/users/vincent-miller/following{/other_user}","gists_url":"https://api.github.com/users/vincent-miller/gists{/gist_id}","starred_url":"https://api.github.com/users/vincent-miller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincent-miller/subscriptions","organizations_url":"https://api.github.com/users/vincent-miller/orgs","repos_url":"https://api.github.com/users/vincent-miller/repos","events_url":"https://api.github.com/users/vincent-miller/events{/privacy}","received_events_url":"https://api.github.com/users/vincent-miller/received_events","type":"User","site_admin":false},"body":"Made elevator stop automatically after an adjustable period of time, and added another control mode to Clamp where the stick bypasses PID and controls the speed of the motor directly.","created_at":"2015-02-12T00:09:28Z","updated_at":"2015-02-12T01:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b021e02a9d184b6e47b5b6beeeceeca4ae28b3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55/commits","review_comments_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55/comments","review_comment_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/comments/{number}","comments_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/55/comments","statuses_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/statuses/797aef041c094f4f7ab76f316af4ad7ff03e3132","head":{"label":"flamingchickens1540:robustify","ref":"robustify","sha":"797aef041c094f4f7ab76f316af4ad7ff03e3132","user":{"login":"flamingchickens1540","id":5280254,"avatar_url":"https://avatars.githubusercontent.com/u/5280254?v=3","gravatar_id":"","url":"https://api.github.com/users/flamingchickens1540","html_url":"https://github.com/flamingchickens1540","followers_url":"https://api.github.com/users/flamingchickens1540/followers","following_url":"https://api.github.com/users/flamingchickens1540/following{/other_user}","gists_url":"https://api.github.com/users/flamingchickens1540/gists{/gist_id}","starred_url":"https://api.github.com/users/flamingchickens1540/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamingchickens1540/subscriptions","organizations_url":"https://api.github.com/users/flamingchickens1540/orgs","repos_url":"https://api.github.com/users/flamingchickens1540/repos","events_url":"https://api.github.com/users/flamingchickens1540/events{/privacy}","received_events_url":"https://api.github.com/users/flamingchickens1540/received_events","type":"Organization","site_admin":false},"repo":{"id":28941570,"name":"quasar-helios-2015","full_name":"flamingchickens1540/quasar-helios-2015","owner":{"login":"flamingchickens1540","id":5280254,"avatar_url":"https://avatars.githubusercontent.com/u/5280254?v=3","gravatar_id":"","url":"https://api.github.com/users/flamingchickens1540","html_url":"https://github.com/flamingchickens1540","followers_url":"https://api.github.com/users/flamingchickens1540/followers","following_url":"https://api.github.com/users/flamingchickens1540/following{/other_user}","gists_url":"https://api.github.com/users/flamingchickens1540/gists{/gist_id}","starred_url":"https://api.github.com/users/flamingchickens1540/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamingchickens1540/subscriptions","organizations_url":"https://api.github.com/users/flamingchickens1540/orgs","repos_url":"https://api.github.com/users/flamingchickens1540/repos","events_url":"https://api.github.com/users/flamingchickens1540/events{/privacy}","received_events_url":"https://api.github.com/users/flamingchickens1540/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flamingchickens1540/quasar-helios-2015","description":"Quasar and Helios code for Team 1540's 2015 season code","fork":false,"url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015","forks_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/forks","keys_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/teams","hooks_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/hooks","issue_events_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/events{/number}","events_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/events","assignees_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/assignees{/user}","branches_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/branches{/branch}","tags_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/tags","blobs_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/refs{/sha}","trees_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/statuses/{sha}","languages_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/languages","stargazers_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/stargazers","contributors_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/contributors","subscribers_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/subscribers","subscription_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/subscription","commits_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/commits{/sha}","git_commits_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/commits{/sha}","comments_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/comments{/number}","issue_comment_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/comments/{number}","contents_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/contents/{+path}","compare_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/merges","archive_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/downloads","issues_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues{/number}","pulls_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls{/number}","milestones_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/milestones{/number}","notifications_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/labels{/name}","releases_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/releases{/id}","created_at":"2015-01-08T00:50:37Z","updated_at":"2015-02-12T00:41:00Z","pushed_at":"2015-02-12T00:47:55Z","git_url":"git://github.com/flamingchickens1540/quasar-helios-2015.git","ssh_url":"git@github.com:flamingchickens1540/quasar-helios-2015.git","clone_url":"https://github.com/flamingchickens1540/quasar-helios-2015.git","svn_url":"https://github.com/flamingchickens1540/quasar-helios-2015","homepage":null,"size":4684,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"flamingchickens1540:master","ref":"master","sha":"a2d00b4c0d08191f3ffe43bffaa18111c067acc7","user":{"login":"flamingchickens1540","id":5280254,"avatar_url":"https://avatars.githubusercontent.com/u/5280254?v=3","gravatar_id":"","url":"https://api.github.com/users/flamingchickens1540","html_url":"https://github.com/flamingchickens1540","followers_url":"https://api.github.com/users/flamingchickens1540/followers","following_url":"https://api.github.com/users/flamingchickens1540/following{/other_user}","gists_url":"https://api.github.com/users/flamingchickens1540/gists{/gist_id}","starred_url":"https://api.github.com/users/flamingchickens1540/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamingchickens1540/subscriptions","organizations_url":"https://api.github.com/users/flamingchickens1540/orgs","repos_url":"https://api.github.com/users/flamingchickens1540/repos","events_url":"https://api.github.com/users/flamingchickens1540/events{/privacy}","received_events_url":"https://api.github.com/users/flamingchickens1540/received_events","type":"Organization","site_admin":false},"repo":{"id":28941570,"name":"quasar-helios-2015","full_name":"flamingchickens1540/quasar-helios-2015","owner":{"login":"flamingchickens1540","id":5280254,"avatar_url":"https://avatars.githubusercontent.com/u/5280254?v=3","gravatar_id":"","url":"https://api.github.com/users/flamingchickens1540","html_url":"https://github.com/flamingchickens1540","followers_url":"https://api.github.com/users/flamingchickens1540/followers","following_url":"https://api.github.com/users/flamingchickens1540/following{/other_user}","gists_url":"https://api.github.com/users/flamingchickens1540/gists{/gist_id}","starred_url":"https://api.github.com/users/flamingchickens1540/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flamingchickens1540/subscriptions","organizations_url":"https://api.github.com/users/flamingchickens1540/orgs","repos_url":"https://api.github.com/users/flamingchickens1540/repos","events_url":"https://api.github.com/users/flamingchickens1540/events{/privacy}","received_events_url":"https://api.github.com/users/flamingchickens1540/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flamingchickens1540/quasar-helios-2015","description":"Quasar and Helios code for Team 1540's 2015 season code","fork":false,"url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015","forks_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/forks","keys_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/teams","hooks_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/hooks","issue_events_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/events{/number}","events_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/events","assignees_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/assignees{/user}","branches_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/branches{/branch}","tags_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/tags","blobs_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/refs{/sha}","trees_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/statuses/{sha}","languages_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/languages","stargazers_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/stargazers","contributors_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/contributors","subscribers_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/subscribers","subscription_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/subscription","commits_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/commits{/sha}","git_commits_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/git/commits{/sha}","comments_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/comments{/number}","issue_comment_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/comments/{number}","contents_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/contents/{+path}","compare_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/merges","archive_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/downloads","issues_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues{/number}","pulls_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls{/number}","milestones_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/milestones{/number}","notifications_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/labels{/name}","releases_url":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/releases{/id}","created_at":"2015-01-08T00:50:37Z","updated_at":"2015-02-12T00:41:00Z","pushed_at":"2015-02-12T00:47:55Z","git_url":"git://github.com/flamingchickens1540/quasar-helios-2015.git","ssh_url":"git@github.com:flamingchickens1540/quasar-helios-2015.git","clone_url":"https://github.com/flamingchickens1540/quasar-helios-2015.git","svn_url":"https://github.com/flamingchickens1540/quasar-helios-2015","homepage":null,"size":4684,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55"},"html":{"href":"https://github.com/flamingchickens1540/quasar-helios-2015/pull/55"},"issue":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/55"},"comments":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/issues/55/comments"},"review_comments":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55/comments"},"review_comment":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/pulls/55/commits"},"statuses":{"href":"https://api.github.com/repos/flamingchickens1540/quasar-helios-2015/statuses/797aef041c094f4f7ab76f316af4ad7ff03e3132"}}}}