{"action":"created","issue":{"url":"https://api.github.com/repos/voipmonitor/sniffer/issues/12","labels_url":"https://api.github.com/repos/voipmonitor/sniffer/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/voipmonitor/sniffer/issues/12/comments","events_url":"https://api.github.com/repos/voipmonitor/sniffer/issues/12/events","html_url":"https://github.com/voipmonitor/sniffer/pull/12","id":56236388,"number":12,"title":"Adapt autotools for FreeBSD","user":{"login":"ClausAndersen","id":9268344,"avatar_url":"https://avatars.githubusercontent.com/u/9268344?v=3","gravatar_id":"","url":"https://api.github.com/users/ClausAndersen","html_url":"https://github.com/ClausAndersen","followers_url":"https://api.github.com/users/ClausAndersen/followers","following_url":"https://api.github.com/users/ClausAndersen/following{/other_user}","gists_url":"https://api.github.com/users/ClausAndersen/gists{/gist_id}","starred_url":"https://api.github.com/users/ClausAndersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ClausAndersen/subscriptions","organizations_url":"https://api.github.com/users/ClausAndersen/orgs","repos_url":"https://api.github.com/users/ClausAndersen/repos","events_url":"https://api.github.com/users/ClausAndersen/events{/privacy}","received_events_url":"https://api.github.com/users/ClausAndersen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-02-02T13:27:19Z","updated_at":"2015-02-02T16:27:20Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/voipmonitor/sniffer/pulls/12","html_url":"https://github.com/voipmonitor/sniffer/pull/12","diff_url":"https://github.com/voipmonitor/sniffer/pull/12.diff","patch_url":"https://github.com/voipmonitor/sniffer/pull/12.patch"},"body":"Hi,\r\n\r\n- Added FreeBSD specific paths in LDFLAGS for mysql.\r\n- Added detection for json/json-c\r\n- Added detection of LIBDL (Linuxism)\r\n- Change used of LDFALGS rather than CXXFLAGS when liniking\r\n\r\nWith these changes you get a clean compile on FreeBSD with clan using the following procedure:\r\n\r\n    pkg install -y libexecinfo libpcap unixodbc mysql56-client libvorbis libogg vorbis-tools gmake git autotools snappy libssh rrdtool pkgconf snappy json-c\r\n    cd /usr/src\r\n    git clone https://github.com/voipmonitor/sniffer.git\r\n    autoconf\r\n    ./configure\r\n    setenv CXX '/usr/bin/c++'\r\n    setenv CC '/usr/bin/cc'\r\n    gmake\r\n\r\nIf these patches are accepted I will improve detection of mysql libraries. Right now it depends on the path rather than proper detection. I am not to happy with allow multiple definitions as well - but that seems to originate from Asterisk - will investigate if this can be improved. But this is a start.\r\n\r\nKind Regards,\r\nClaus"},"comment":{"url":"https://api.github.com/repos/voipmonitor/sniffer/issues/comments/72486766","html_url":"https://github.com/voipmonitor/sniffer/pull/12#issuecomment-72486766","issue_url":"https://api.github.com/repos/voipmonitor/sniffer/issues/12","id":72486766,"user":{"login":"voipmonitor","id":7045031,"avatar_url":"https://avatars.githubusercontent.com/u/7045031?v=3","gravatar_id":"","url":"https://api.github.com/users/voipmonitor","html_url":"https://github.com/voipmonitor","followers_url":"https://api.github.com/users/voipmonitor/followers","following_url":"https://api.github.com/users/voipmonitor/following{/other_user}","gists_url":"https://api.github.com/users/voipmonitor/gists{/gist_id}","starred_url":"https://api.github.com/users/voipmonitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voipmonitor/subscriptions","organizations_url":"https://api.github.com/users/voipmonitor/orgs","repos_url":"https://api.github.com/users/voipmonitor/repos","events_url":"https://api.github.com/users/voipmonitor/events{/privacy}","received_events_url":"https://api.github.com/users/voipmonitor/received_events","type":"User","site_admin":false},"created_at":"2015-02-02T16:27:20Z","updated_at":"2015-02-02T16:27:20Z","body":"Hi,\r\n\r\nthank you I have applied the patch with slight change in error text when\r\njson not found - there is no need to print error now only if non of the\r\nlibrary has been found. Improving mysql libraries would be nice.\r\n\r\n2015-02-02 14:27 GMT+01:00 Claus Andersen <notifications@github.com>:\r\n\r\n> Hi,\r\n>\r\n>    - Added FreeBSD specific paths in LDFLAGS for mysql.\r\n>    - Added detection for json/json-c\r\n>    - Added detection of LIBDL (Linuxism)\r\n>    - Change used of LDFALGS rather than CXXFLAGS when liniking\r\n>\r\n> With these changes you get a clean compile on FreeBSD with clan using the\r\n> following procedure:\r\n>\r\n> pkg install -y libexecinfo libpcap unixodbc mysql56-client libvorbis libogg vorbis-tools gmake git autotools snappy libssh rrdtool pkgconf snappy json-c\r\n> cd /usr/src\r\n> git clone https://github.com/voipmonitor/sniffer.git\r\n> autoconf\r\n> ./configure\r\n> setenv CXX '/usr/bin/c++'\r\n> setenv CC '/usr/bin/cc'\r\n> gmake\r\n>\r\n> If these patches are accepted I will improve detection of mysql libraries.\r\n> Right now it depends on the path rather than proper detection. I am not to\r\n> happy with allow multiple definitions as well - but that seems to originate\r\n> from Asterisk - will investigate if this can be improved. But this is a\r\n> start.\r\n>\r\n> Kind Regards,\r\n> Claus\r\n> ------------------------------\r\n> You can view, comment on, or merge this pull request online at:\r\n>\r\n>   https://github.com/voipmonitor/sniffer/pull/12\r\n> Commit Summary\r\n>\r\n>    - Adapt autotools for FreeBSD\r\n>\r\n> File Changes\r\n>\r\n>    - *M* Makefile.in\r\n>    <https://github.com/voipmonitor/sniffer/pull/12/files#diff-0> (16)\r\n>    - *M* configure.in\r\n>    <https://github.com/voipmonitor/sniffer/pull/12/files#diff-1> (14)\r\n>\r\n> Patch Links:\r\n>\r\n>    - https://github.com/voipmonitor/sniffer/pull/12.patch\r\n>    - https://github.com/voipmonitor/sniffer/pull/12.diff\r\n>\r\n> —\r\n> Reply to this email directly or view it on GitHub\r\n> <https://github.com/voipmonitor/sniffer/pull/12>.\r\n>\r\n\r\n\r\n\r\n-- \r\nBest regards\r\nMartin Vit"}}