{"action":"created","issue":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2381","labels_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2381/labels{/name}","comments_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2381/comments","events_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2381/events","html_url":"https://github.com/concrete5/concrete5-5.7.0/issues/2381","id":73459656,"number":2381,"title":"concrete5 bricked in php 7 due to LSP issues","user":{"login":"KorvinSzanto","id":1007419,"avatar_url":"https://avatars.githubusercontent.com/u/1007419?v=3","gravatar_id":"","url":"https://api.github.com/users/KorvinSzanto","html_url":"https://github.com/KorvinSzanto","followers_url":"https://api.github.com/users/KorvinSzanto/followers","following_url":"https://api.github.com/users/KorvinSzanto/following{/other_user}","gists_url":"https://api.github.com/users/KorvinSzanto/gists{/gist_id}","starred_url":"https://api.github.com/users/KorvinSzanto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KorvinSzanto/subscriptions","organizations_url":"https://api.github.com/users/KorvinSzanto/orgs","repos_url":"https://api.github.com/users/KorvinSzanto/repos","events_url":"https://api.github.com/users/KorvinSzanto/events{/privacy}","received_events_url":"https://api.github.com/users/KorvinSzanto/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-05T23:18:32Z","updated_at":"2015-05-06T00:12:36Z","closed_at":null,"body":"in PHP 7, [LSP is elevated from an `E_STRICT` to an `E_WARNING`](http://3v4l.org/WaXZk), this means that any class loaded at compile time or in runtime before we disable the `E_WARNING` output will be bricked. I contend that instead of hiding these errors we should fix them before PHP 7 drops. Some can be fixed simply by [adding a default value to added parameters](http://3v4l.org/UdepA) but others are more complicated and require more work.\r\n\r\nThere are quite a few examples of these:\r\n\r\n* [Concrete\\Core\\Workflow\\Progress\\PageProgress::add](https://github.com/concrete5/concrete5-5.7.0/blob/ba0195fe5a060158a50b65d267e640ca681c885d/web/concrete/src/Workflow/Progress/PageProgress.php#L12-12)\r\n* [Concrete\\Core\\Permission\\Access\\EditPagePropertiesPageAccess::save](https://github.com/concrete5/concrete5-5.7.0/blob/d1f9bbbde50770392be1b81fe067cda3668840d5/web/concrete/src/Permission/Access/EditPagePropertiesPageAccess.php#L31-31) \r\n* [Concrete\\Core\\Attribute\\Key\\CollectionKey::add](https://github.com/concrete5/concrete5-5.7.0/blob/d1f9bbbde50770392be1b81fe067cda3668840d5/web/concrete/src/Attribute/Key/CollectionKey.php#L115-115)\r\n\r\nThe list goes on."},"comment":{"url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/comments/99267734","html_url":"https://github.com/concrete5/concrete5-5.7.0/issues/2381#issuecomment-99267734","issue_url":"https://api.github.com/repos/concrete5/concrete5-5.7.0/issues/2381","id":99267734,"user":{"login":"MeyerJL","id":1292766,"avatar_url":"https://avatars.githubusercontent.com/u/1292766?v=3","gravatar_id":"","url":"https://api.github.com/users/MeyerJL","html_url":"https://github.com/MeyerJL","followers_url":"https://api.github.com/users/MeyerJL/followers","following_url":"https://api.github.com/users/MeyerJL/following{/other_user}","gists_url":"https://api.github.com/users/MeyerJL/gists{/gist_id}","starred_url":"https://api.github.com/users/MeyerJL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MeyerJL/subscriptions","organizations_url":"https://api.github.com/users/MeyerJL/orgs","repos_url":"https://api.github.com/users/MeyerJL/repos","events_url":"https://api.github.com/users/MeyerJL/events{/privacy}","received_events_url":"https://api.github.com/users/MeyerJL/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T00:12:36Z","updated_at":"2015-05-06T00:12:36Z","body":"It really is unfortunate that it's going to likely be another \"breaking change\" but at the same time it needs to be fixed. \r\n\r\nI really believe that  continuing to have the framework suppress E_WARNING / E_NOTICE does a disservice to developers of the framework as they develop their own code since they're not getting notified of any of these either as they develop."}}