{"action":"created","issue":{"url":"https://api.github.com/repos/ga4gh/schemas/issues/269","labels_url":"https://api.github.com/repos/ga4gh/schemas/issues/269/labels{/name}","comments_url":"https://api.github.com/repos/ga4gh/schemas/issues/269/comments","events_url":"https://api.github.com/repos/ga4gh/schemas/issues/269/events","html_url":"https://github.com/ga4gh/schemas/pull/269","id":65276030,"number":269,"title":"Updating methods to work with side graphs.","user":{"login":"adamnovak","id":5062495,"avatar_url":"https://avatars.githubusercontent.com/u/5062495?v=3","gravatar_id":"","url":"https://api.github.com/users/adamnovak","html_url":"https://github.com/adamnovak","followers_url":"https://api.github.com/users/adamnovak/followers","following_url":"https://api.github.com/users/adamnovak/following{/other_user}","gists_url":"https://api.github.com/users/adamnovak/gists{/gist_id}","starred_url":"https://api.github.com/users/adamnovak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamnovak/subscriptions","organizations_url":"https://api.github.com/users/adamnovak/orgs","repos_url":"https://api.github.com/users/adamnovak/repos","events_url":"https://api.github.com/users/adamnovak/events{/privacy}","received_events_url":"https://api.github.com/users/adamnovak/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ga4gh/schemas/labels/RefVariationTaskTeam","name":"RefVariationTaskTeam","color":"5319e7"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":11,"created_at":"2015-03-30T18:47:06Z","updated_at":"2015-04-08T16:05:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ga4gh/schemas/pulls/269","html_url":"https://github.com/ga4gh/schemas/pull/269","diff_url":"https://github.com/ga4gh/schemas/pull/269.diff","patch_url":"https://github.com/ga4gh/schemas/pull/269.patch"},"body":"Since #250 went in, the methods have been out of sync with the graph representation. This is my suggestion for how to change the methods around to match the new side graph model.\r\n\r\nBasically, I'm adding the necessary search methods for `Sequence`s and `Join`s, and getting rid of the special methods used to get novel sequences from a `VariantSet` (in favor of a `variantSetId` field when searching for `Sequence`s and `Join`s).\r\n\r\nAlso fixing a comment typo in common.avdl."},"comment":{"url":"https://api.github.com/repos/ga4gh/schemas/issues/comments/90960828","html_url":"https://github.com/ga4gh/schemas/pull/269#issuecomment-90960828","issue_url":"https://api.github.com/repos/ga4gh/schemas/issues/269","id":90960828,"user":{"login":"adamnovak","id":5062495,"avatar_url":"https://avatars.githubusercontent.com/u/5062495?v=3","gravatar_id":"","url":"https://api.github.com/users/adamnovak","html_url":"https://github.com/adamnovak","followers_url":"https://api.github.com/users/adamnovak/followers","following_url":"https://api.github.com/users/adamnovak/following{/other_user}","gists_url":"https://api.github.com/users/adamnovak/gists{/gist_id}","starred_url":"https://api.github.com/users/adamnovak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamnovak/subscriptions","organizations_url":"https://api.github.com/users/adamnovak/orgs","repos_url":"https://api.github.com/users/adamnovak/repos","events_url":"https://api.github.com/users/adamnovak/events{/privacy}","received_events_url":"https://api.github.com/users/adamnovak/received_events","type":"User","site_admin":false},"created_at":"2015-04-08T16:05:32Z","updated_at":"2015-04-08T16:05:32Z","body":"I'm not convinced that it really is important to specify how the arrays will be filled in. The server can do whatever it wants, as long as when the client downloads and unions all the pages it gets the full result set. If we want to, we could add the constraint that neither array may be empty until all the results of that type have been returned.\r\n\r\nSplitting it up into two methods might solve two problems at once: we wouldn't have to worry about the two-array paging semantics, and the two separate methods are much more like searches than this one is.\r\n\r\nI don't really want to pull this method out, because I already pulled out the methods into this PR. I suppose I will if we can't get a consensus soon.\r\n\r\nDoes anyone not like the two-method solution?"}}