{"action":"created","issue":{"url":"https://api.github.com/repos/docker/libnetwork/issues/590","labels_url":"https://api.github.com/repos/docker/libnetwork/issues/590/labels{/name}","comments_url":"https://api.github.com/repos/docker/libnetwork/issues/590/comments","events_url":"https://api.github.com/repos/docker/libnetwork/issues/590/events","html_url":"https://github.com/docker/libnetwork/pull/590","id":109720879,"number":590,"title":"Allowing drivers to set mac & ip if the value is the same","user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":3,"created_at":"2015-10-05T02:24:08Z","updated_at":"2015-10-05T04:06:15Z","closed_at":"2015-10-05T04:06:15Z","pull_request":{"url":"https://api.github.com/repos/docker/libnetwork/pulls/590","html_url":"https://github.com/docker/libnetwork/pull/590","diff_url":"https://github.com/docker/libnetwork/pull/590.diff","patch_url":"https://github.com/docker/libnetwork/pull/590.patch"},"body":"With the change from EndpointInfo to InterfaceInfo and granular\r\nassignment of mac and ip, we should allow the drivers to set the same\r\nvalue back. Without that there is a lot of unneccessary special casing\r\nin the drivers.\r\n\r\nSigned-off-by: Madhu Venugopal <madhu@docker.com>"},"comment":{"url":"https://api.github.com/repos/docker/libnetwork/issues/comments/145425235","html_url":"https://github.com/docker/libnetwork/pull/590#issuecomment-145425235","issue_url":"https://api.github.com/repos/docker/libnetwork/issues/590","id":145425235,"user":{"login":"mavenugo","id":5056191,"avatar_url":"https://avatars.githubusercontent.com/u/5056191?v=3","gravatar_id":"","url":"https://api.github.com/users/mavenugo","html_url":"https://github.com/mavenugo","followers_url":"https://api.github.com/users/mavenugo/followers","following_url":"https://api.github.com/users/mavenugo/following{/other_user}","gists_url":"https://api.github.com/users/mavenugo/gists{/gist_id}","starred_url":"https://api.github.com/users/mavenugo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mavenugo/subscriptions","organizations_url":"https://api.github.com/users/mavenugo/orgs","repos_url":"https://api.github.com/users/mavenugo/repos","events_url":"https://api.github.com/users/mavenugo/events{/privacy}","received_events_url":"https://api.github.com/users/mavenugo/received_events","type":"User","site_admin":false},"created_at":"2015-10-05T04:06:15Z","updated_at":"2015-10-05T04:06:15Z","body":"@mrjana  @aboch this is not to special case bridge driver at all. It is actually quite simple to check and not call the SetMacAddres, SetAddress, etc....\r\n\r\nBut, the reason I suggested this change because it does add unnecessary burden on the drivers to check and decide on to call the SetXXX or not. But if we allow the SetXXX and handle the Forbidden error based on changing value, then it makes the code simpler for sure.\r\n\r\nBut, looks like you both dont prefer that. i will close this PR.\r\n"}}