{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments/37403903","id":37403903,"diff_hunk":"@@ -25,11 +25,13 @@\n #![deny(deprecated, drop_with_repr_extern, improper_ctypes, missing_docs,\n         non_shorthand_field_patterns, overflowing_literals, plugin_as_library,\n         private_no_mangle_fns, private_no_mangle_statics, raw_pointer_derive, stable_features,\n-        unconditional_recursion, unknown_lints, unsafe_code, unused, unused_allocation,\n+        unconditional_recursion, unknown_lints, unsafe_code, unused_allocation,","path":"src/main.rs","position":5,"original_position":5,"commit_id":"8cdddeec7528c5412833b6e105162a127724597e","original_commit_id":"af26dd7b56262e7024595a7763082d72d0de3215","user":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"body":"I've already reverted this locally and have the code compiling again (albeit with quite a few `#[allow(dead_code)]` instances).\r\n\r\nI think modifying the project lint settings should be last resort, then slightly less worse are file-level overrides, then least worst are function/variable-level overrides.","created_at":"2015-08-19T11:22:55Z","updated_at":"2015-08-19T11:22:55Z","html_url":"https://github.com/maidsafe/safe_vault/pull/193#discussion_r37403903","pull_request_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments/37403903"},"html":{"href":"https://github.com/maidsafe/safe_vault/pull/193#discussion_r37403903"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193","id":42791729,"html_url":"https://github.com/maidsafe/safe_vault/pull/193","diff_url":"https://github.com/maidsafe/safe_vault/pull/193.diff","patch_url":"https://github.com/maidsafe/safe_vault/pull/193.patch","issue_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/193","number":193,"state":"closed","locked":false,"title":"New routing event","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-19T09:06:40Z","updated_at":"2015-08-19T11:22:55Z","closed_at":"2015-08-19T10:32:09Z","merged_at":"2015-08-19T10:32:09Z","merge_commit_sha":"137d890be68c1467bc96afe0c0c2558e2cdc96f1","assignee":{"login":"Fraser999","id":190532,"avatar_url":"https://avatars.githubusercontent.com/u/190532?v=3","gravatar_id":"","url":"https://api.github.com/users/Fraser999","html_url":"https://github.com/Fraser999","followers_url":"https://api.github.com/users/Fraser999/followers","following_url":"https://api.github.com/users/Fraser999/following{/other_user}","gists_url":"https://api.github.com/users/Fraser999/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraser999/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraser999/subscriptions","organizations_url":"https://api.github.com/users/Fraser999/orgs","repos_url":"https://api.github.com/users/Fraser999/repos","events_url":"https://api.github.com/users/Fraser999/events{/privacy}","received_events_url":"https://api.github.com/users/Fraser999/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193/commits","review_comments_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193/comments","review_comment_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/193/comments","statuses_url":"https://api.github.com/repos/maidsafe/safe_vault/statuses/8cdddeec7528c5412833b6e105162a127724597e","head":{"label":"maqi:new_routing_event","ref":"new_routing_event","sha":"8cdddeec7528c5412833b6e105162a127724597e","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"repo":{"id":32813562,"name":"maidsafe_vault","full_name":"maqi/maidsafe_vault","owner":{"login":"maqi","id":568777,"avatar_url":"https://avatars.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maqi/maidsafe_vault","description":"The Ants are coming!!","fork":true,"url":"https://api.github.com/repos/maqi/maidsafe_vault","forks_url":"https://api.github.com/repos/maqi/maidsafe_vault/forks","keys_url":"https://api.github.com/repos/maqi/maidsafe_vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maqi/maidsafe_vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maqi/maidsafe_vault/teams","hooks_url":"https://api.github.com/repos/maqi/maidsafe_vault/hooks","issue_events_url":"https://api.github.com/repos/maqi/maidsafe_vault/issues/events{/number}","events_url":"https://api.github.com/repos/maqi/maidsafe_vault/events","assignees_url":"https://api.github.com/repos/maqi/maidsafe_vault/assignees{/user}","branches_url":"https://api.github.com/repos/maqi/maidsafe_vault/branches{/branch}","tags_url":"https://api.github.com/repos/maqi/maidsafe_vault/tags","blobs_url":"https://api.github.com/repos/maqi/maidsafe_vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maqi/maidsafe_vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maqi/maidsafe_vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/maqi/maidsafe_vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maqi/maidsafe_vault/statuses/{sha}","languages_url":"https://api.github.com/repos/maqi/maidsafe_vault/languages","stargazers_url":"https://api.github.com/repos/maqi/maidsafe_vault/stargazers","contributors_url":"https://api.github.com/repos/maqi/maidsafe_vault/contributors","subscribers_url":"https://api.github.com/repos/maqi/maidsafe_vault/subscribers","subscription_url":"https://api.github.com/repos/maqi/maidsafe_vault/subscription","commits_url":"https://api.github.com/repos/maqi/maidsafe_vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/maqi/maidsafe_vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/maqi/maidsafe_vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/maqi/maidsafe_vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/maqi/maidsafe_vault/contents/{+path}","compare_url":"https://api.github.com/repos/maqi/maidsafe_vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maqi/maidsafe_vault/merges","archive_url":"https://api.github.com/repos/maqi/maidsafe_vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maqi/maidsafe_vault/downloads","issues_url":"https://api.github.com/repos/maqi/maidsafe_vault/issues{/number}","pulls_url":"https://api.github.com/repos/maqi/maidsafe_vault/pulls{/number}","milestones_url":"https://api.github.com/repos/maqi/maidsafe_vault/milestones{/number}","notifications_url":"https://api.github.com/repos/maqi/maidsafe_vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maqi/maidsafe_vault/labels{/name}","releases_url":"https://api.github.com/repos/maqi/maidsafe_vault/releases{/id}","created_at":"2015-03-24T17:21:01Z","updated_at":"2015-03-24T17:21:01Z","pushed_at":"2015-08-19T10:14:02Z","git_url":"git://github.com/maqi/maidsafe_vault.git","ssh_url":"git@github.com:maqi/maidsafe_vault.git","clone_url":"https://github.com/maqi/maidsafe_vault.git","svn_url":"https://github.com/maqi/maidsafe_vault","homepage":null,"size":1881,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"maidsafe:master","ref":"master","sha":"83a9c28b0f3ceba3ceaa064553e3eb5b12761c38","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":32022044,"name":"safe_vault","full_name":"maidsafe/safe_vault","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/safe_vault","description":"The Ants are coming!!","fork":false,"url":"https://api.github.com/repos/maidsafe/safe_vault","forks_url":"https://api.github.com/repos/maidsafe/safe_vault/forks","keys_url":"https://api.github.com/repos/maidsafe/safe_vault/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/safe_vault/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/safe_vault/teams","hooks_url":"https://api.github.com/repos/maidsafe/safe_vault/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/safe_vault/events","assignees_url":"https://api.github.com/repos/maidsafe/safe_vault/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/safe_vault/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/safe_vault/tags","blobs_url":"https://api.github.com/repos/maidsafe/safe_vault/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/safe_vault/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/safe_vault/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/safe_vault/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/safe_vault/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/safe_vault/languages","stargazers_url":"https://api.github.com/repos/maidsafe/safe_vault/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/safe_vault/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/safe_vault/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/safe_vault/subscription","commits_url":"https://api.github.com/repos/maidsafe/safe_vault/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/safe_vault/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/safe_vault/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/safe_vault/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/safe_vault/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/safe_vault/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/safe_vault/merges","archive_url":"https://api.github.com/repos/maidsafe/safe_vault/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/safe_vault/downloads","issues_url":"https://api.github.com/repos/maidsafe/safe_vault/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/safe_vault/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/safe_vault/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/safe_vault/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/safe_vault/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/safe_vault/releases{/id}","created_at":"2015-03-11T14:27:31Z","updated_at":"2015-08-16T23:18:36Z","pushed_at":"2015-08-19T10:38:02Z","git_url":"git://github.com/maidsafe/safe_vault.git","ssh_url":"git@github.com:maidsafe/safe_vault.git","clone_url":"https://github.com/maidsafe/safe_vault.git","svn_url":"https://github.com/maidsafe/safe_vault","homepage":null,"size":7416,"stargazers_count":16,"watchers_count":16,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":21,"mirror_url":null,"open_issues_count":5,"forks":21,"open_issues":5,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193"},"html":{"href":"https://github.com/maidsafe/safe_vault/pull/193"},"issue":{"href":"https://api.github.com/repos/maidsafe/safe_vault/issues/193"},"comments":{"href":"https://api.github.com/repos/maidsafe/safe_vault/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/safe_vault/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/safe_vault/statuses/8cdddeec7528c5412833b6e105162a127724597e"}}}}