{"action":"closed","number":18,"pull_request":{"url":"https://api.github.com/repos/uber/tchannel-python/pulls/18","id":39861330,"html_url":"https://github.com/uber/tchannel-python/pull/18","diff_url":"https://github.com/uber/tchannel-python/pull/18.diff","patch_url":"https://github.com/uber/tchannel-python/pull/18.patch","issue_url":"https://api.github.com/repos/uber/tchannel-python/issues/18","number":18,"state":"closed","locked":false,"title":"make advertise to retry on all exceptions for now. Keep it alive.","user":{"login":"junchaowu","id":3731781,"avatar_url":"https://avatars.githubusercontent.com/u/3731781?v=3","gravatar_id":"","url":"https://api.github.com/users/junchaowu","html_url":"https://github.com/junchaowu","followers_url":"https://api.github.com/users/junchaowu/followers","following_url":"https://api.github.com/users/junchaowu/following{/other_user}","gists_url":"https://api.github.com/users/junchaowu/gists{/gist_id}","starred_url":"https://api.github.com/users/junchaowu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junchaowu/subscriptions","organizations_url":"https://api.github.com/users/junchaowu/orgs","repos_url":"https://api.github.com/users/junchaowu/repos","events_url":"https://api.github.com/users/junchaowu/events{/privacy}","received_events_url":"https://api.github.com/users/junchaowu/received_events","type":"User","site_admin":false},"body":"@blampe @breerly @abhinav \r\n\r\nCurrently advertise only retry for timeout error and protocol error. But when autobahn restarts, tchannel will stop advertising.  Create a large range of exception for retry for now to keep tchannel app alive. This can avoid keep updating current on-boarding service.\r\n\r\nThat's also what Node does.","created_at":"2015-07-13T21:57:58Z","updated_at":"2015-07-13T22:12:20Z","closed_at":"2015-07-13T22:12:20Z","merged_at":"2015-07-13T22:12:20Z","merge_commit_sha":"d4917fe512e5db381e3b472fe58dc5015a04bbc3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/uber/tchannel-python/pulls/18/commits","review_comments_url":"https://api.github.com/repos/uber/tchannel-python/pulls/18/comments","review_comment_url":"https://api.github.com/repos/uber/tchannel-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/tchannel-python/issues/18/comments","statuses_url":"https://api.github.com/repos/uber/tchannel-python/statuses/10aa6c247b5cbec67fec4556abadb51c75da3995","head":{"label":"uber:ad","ref":"ad","sha":"10aa6c247b5cbec67fec4556abadb51c75da3995","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":38906603,"name":"tchannel-python","full_name":"uber/tchannel-python","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-python","description":"Python implementation of the TChannel protocol.","fork":false,"url":"https://api.github.com/repos/uber/tchannel-python","forks_url":"https://api.github.com/repos/uber/tchannel-python/forks","keys_url":"https://api.github.com/repos/uber/tchannel-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-python/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-python/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-python/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-python/events","assignees_url":"https://api.github.com/repos/uber/tchannel-python/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-python/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-python/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-python/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-python/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-python/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-python/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-python/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-python/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-python/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-python/merges","archive_url":"https://api.github.com/repos/uber/tchannel-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-python/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-python/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-python/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-python/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-python/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-python/releases{/id}","created_at":"2015-07-10T23:35:17Z","updated_at":"2015-07-12T11:54:19Z","pushed_at":"2015-07-13T22:12:20Z","git_url":"git://github.com/uber/tchannel-python.git","ssh_url":"git@github.com:uber/tchannel-python.git","clone_url":"https://github.com/uber/tchannel-python.git","svn_url":"https://github.com/uber/tchannel-python","homepage":null,"size":6224,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"eaa67066bb081077a5b96bc4db68eb08f3e60d67","user":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":38906603,"name":"tchannel-python","full_name":"uber/tchannel-python","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars.githubusercontent.com/u/538264?v=3","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/tchannel-python","description":"Python implementation of the TChannel protocol.","fork":false,"url":"https://api.github.com/repos/uber/tchannel-python","forks_url":"https://api.github.com/repos/uber/tchannel-python/forks","keys_url":"https://api.github.com/repos/uber/tchannel-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/tchannel-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/tchannel-python/teams","hooks_url":"https://api.github.com/repos/uber/tchannel-python/hooks","issue_events_url":"https://api.github.com/repos/uber/tchannel-python/issues/events{/number}","events_url":"https://api.github.com/repos/uber/tchannel-python/events","assignees_url":"https://api.github.com/repos/uber/tchannel-python/assignees{/user}","branches_url":"https://api.github.com/repos/uber/tchannel-python/branches{/branch}","tags_url":"https://api.github.com/repos/uber/tchannel-python/tags","blobs_url":"https://api.github.com/repos/uber/tchannel-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/tchannel-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/tchannel-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/tchannel-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/tchannel-python/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/tchannel-python/languages","stargazers_url":"https://api.github.com/repos/uber/tchannel-python/stargazers","contributors_url":"https://api.github.com/repos/uber/tchannel-python/contributors","subscribers_url":"https://api.github.com/repos/uber/tchannel-python/subscribers","subscription_url":"https://api.github.com/repos/uber/tchannel-python/subscription","commits_url":"https://api.github.com/repos/uber/tchannel-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/tchannel-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/tchannel-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/tchannel-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/tchannel-python/contents/{+path}","compare_url":"https://api.github.com/repos/uber/tchannel-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/tchannel-python/merges","archive_url":"https://api.github.com/repos/uber/tchannel-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/tchannel-python/downloads","issues_url":"https://api.github.com/repos/uber/tchannel-python/issues{/number}","pulls_url":"https://api.github.com/repos/uber/tchannel-python/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/tchannel-python/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/tchannel-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/tchannel-python/labels{/name}","releases_url":"https://api.github.com/repos/uber/tchannel-python/releases{/id}","created_at":"2015-07-10T23:35:17Z","updated_at":"2015-07-12T11:54:19Z","pushed_at":"2015-07-13T22:12:20Z","git_url":"git://github.com/uber/tchannel-python.git","ssh_url":"git@github.com:uber/tchannel-python.git","clone_url":"https://github.com/uber/tchannel-python.git","svn_url":"https://github.com/uber/tchannel-python","homepage":null,"size":6224,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":11,"forks":0,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/tchannel-python/pulls/18"},"html":{"href":"https://github.com/uber/tchannel-python/pull/18"},"issue":{"href":"https://api.github.com/repos/uber/tchannel-python/issues/18"},"comments":{"href":"https://api.github.com/repos/uber/tchannel-python/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/tchannel-python/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/tchannel-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/tchannel-python/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/uber/tchannel-python/statuses/10aa6c247b5cbec67fec4556abadb51c75da3995"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"junchaowu","id":3731781,"avatar_url":"https://avatars.githubusercontent.com/u/3731781?v=3","gravatar_id":"","url":"https://api.github.com/users/junchaowu","html_url":"https://github.com/junchaowu","followers_url":"https://api.github.com/users/junchaowu/followers","following_url":"https://api.github.com/users/junchaowu/following{/other_user}","gists_url":"https://api.github.com/users/junchaowu/gists{/gist_id}","starred_url":"https://api.github.com/users/junchaowu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/junchaowu/subscriptions","organizations_url":"https://api.github.com/users/junchaowu/orgs","repos_url":"https://api.github.com/users/junchaowu/repos","events_url":"https://api.github.com/users/junchaowu/events{/privacy}","received_events_url":"https://api.github.com/users/junchaowu/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":2,"deletions":4,"changed_files":2}}