{"action":"opened","number":109,"pull_request":{"url":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/109","id":54426719,"html_url":"https://github.com/Thomvis/BrightFutures/pull/109","diff_url":"https://github.com/Thomvis/BrightFutures/pull/109.diff","patch_url":"https://github.com/Thomvis/BrightFutures/pull/109.patch","issue_url":"https://api.github.com/repos/Thomvis/BrightFutures/issues/109","number":109,"state":"open","locked":false,"title":"Allow consumers to set DefaultThreadingModel to a synchronous one","user":{"login":"matthew-healy","id":13350302,"avatar_url":"https://avatars.githubusercontent.com/u/13350302?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-healy","html_url":"https://github.com/matthew-healy","followers_url":"https://api.github.com/users/matthew-healy/followers","following_url":"https://api.github.com/users/matthew-healy/following{/other_user}","gists_url":"https://api.github.com/users/matthew-healy/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-healy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-healy/subscriptions","organizations_url":"https://api.github.com/users/matthew-healy/orgs","repos_url":"https://api.github.com/users/matthew-healy/repos","events_url":"https://api.github.com/users/matthew-healy/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-healy/received_events","type":"User","site_admin":false},"body":"… for easy testing.\r\n\r\nThis change implements my idea from #91. \r\n\r\nI didn't go so far as to convert the (currently asynchronous) tests in the `BrightFututesTests.swift` file as part of this commit. I did, however, confirm before opening this pull request that those tests can be made synchronous where appropriate. This should remove a number of unnecessary `waitForExpectation` calls, and therefore speed up the tests.\r\n\r\nIf you do decide to merge this in then I'll get to work converting the tests asap. :smile: ","created_at":"2015-12-22T23:25:00Z","updated_at":"2015-12-22T23:25:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/109/commits","review_comments_url":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/109/comments","review_comment_url":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Thomvis/BrightFutures/issues/109/comments","statuses_url":"https://api.github.com/repos/Thomvis/BrightFutures/statuses/89f104691d82e9f3b7ed587ad4e1201289b0a5c9","head":{"label":"matthew-healy:master","ref":"master","sha":"89f104691d82e9f3b7ed587ad4e1201289b0a5c9","user":{"login":"matthew-healy","id":13350302,"avatar_url":"https://avatars.githubusercontent.com/u/13350302?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-healy","html_url":"https://github.com/matthew-healy","followers_url":"https://api.github.com/users/matthew-healy/followers","following_url":"https://api.github.com/users/matthew-healy/following{/other_user}","gists_url":"https://api.github.com/users/matthew-healy/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-healy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-healy/subscriptions","organizations_url":"https://api.github.com/users/matthew-healy/orgs","repos_url":"https://api.github.com/users/matthew-healy/repos","events_url":"https://api.github.com/users/matthew-healy/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-healy/received_events","type":"User","site_admin":false},"repo":{"id":48458573,"name":"BrightFutures","full_name":"matthew-healy/BrightFutures","owner":{"login":"matthew-healy","id":13350302,"avatar_url":"https://avatars.githubusercontent.com/u/13350302?v=3","gravatar_id":"","url":"https://api.github.com/users/matthew-healy","html_url":"https://github.com/matthew-healy","followers_url":"https://api.github.com/users/matthew-healy/followers","following_url":"https://api.github.com/users/matthew-healy/following{/other_user}","gists_url":"https://api.github.com/users/matthew-healy/gists{/gist_id}","starred_url":"https://api.github.com/users/matthew-healy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthew-healy/subscriptions","organizations_url":"https://api.github.com/users/matthew-healy/orgs","repos_url":"https://api.github.com/users/matthew-healy/repos","events_url":"https://api.github.com/users/matthew-healy/events{/privacy}","received_events_url":"https://api.github.com/users/matthew-healy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/matthew-healy/BrightFutures","description":"Write great asynchronous code in Swift using futures and promises","fork":true,"url":"https://api.github.com/repos/matthew-healy/BrightFutures","forks_url":"https://api.github.com/repos/matthew-healy/BrightFutures/forks","keys_url":"https://api.github.com/repos/matthew-healy/BrightFutures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthew-healy/BrightFutures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthew-healy/BrightFutures/teams","hooks_url":"https://api.github.com/repos/matthew-healy/BrightFutures/hooks","issue_events_url":"https://api.github.com/repos/matthew-healy/BrightFutures/issues/events{/number}","events_url":"https://api.github.com/repos/matthew-healy/BrightFutures/events","assignees_url":"https://api.github.com/repos/matthew-healy/BrightFutures/assignees{/user}","branches_url":"https://api.github.com/repos/matthew-healy/BrightFutures/branches{/branch}","tags_url":"https://api.github.com/repos/matthew-healy/BrightFutures/tags","blobs_url":"https://api.github.com/repos/matthew-healy/BrightFutures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthew-healy/BrightFutures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthew-healy/BrightFutures/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthew-healy/BrightFutures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthew-healy/BrightFutures/statuses/{sha}","languages_url":"https://api.github.com/repos/matthew-healy/BrightFutures/languages","stargazers_url":"https://api.github.com/repos/matthew-healy/BrightFutures/stargazers","contributors_url":"https://api.github.com/repos/matthew-healy/BrightFutures/contributors","subscribers_url":"https://api.github.com/repos/matthew-healy/BrightFutures/subscribers","subscription_url":"https://api.github.com/repos/matthew-healy/BrightFutures/subscription","commits_url":"https://api.github.com/repos/matthew-healy/BrightFutures/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthew-healy/BrightFutures/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthew-healy/BrightFutures/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthew-healy/BrightFutures/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthew-healy/BrightFutures/contents/{+path}","compare_url":"https://api.github.com/repos/matthew-healy/BrightFutures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthew-healy/BrightFutures/merges","archive_url":"https://api.github.com/repos/matthew-healy/BrightFutures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthew-healy/BrightFutures/downloads","issues_url":"https://api.github.com/repos/matthew-healy/BrightFutures/issues{/number}","pulls_url":"https://api.github.com/repos/matthew-healy/BrightFutures/pulls{/number}","milestones_url":"https://api.github.com/repos/matthew-healy/BrightFutures/milestones{/number}","notifications_url":"https://api.github.com/repos/matthew-healy/BrightFutures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthew-healy/BrightFutures/labels{/name}","releases_url":"https://api.github.com/repos/matthew-healy/BrightFutures/releases{/id}","created_at":"2015-12-22T23:18:02Z","updated_at":"2015-12-22T23:18:03Z","pushed_at":"2015-12-22T23:20:53Z","git_url":"git://github.com/matthew-healy/BrightFutures.git","ssh_url":"git@github.com:matthew-healy/BrightFutures.git","clone_url":"https://github.com/matthew-healy/BrightFutures.git","svn_url":"https://github.com/matthew-healy/BrightFutures","homepage":"","size":638,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Thomvis:master","ref":"master","sha":"f59949c43dfd068dbe1b03e2d8bc6f1e9411a288","user":{"login":"Thomvis","id":134170,"avatar_url":"https://avatars.githubusercontent.com/u/134170?v=3","gravatar_id":"","url":"https://api.github.com/users/Thomvis","html_url":"https://github.com/Thomvis","followers_url":"https://api.github.com/users/Thomvis/followers","following_url":"https://api.github.com/users/Thomvis/following{/other_user}","gists_url":"https://api.github.com/users/Thomvis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomvis/subscriptions","organizations_url":"https://api.github.com/users/Thomvis/orgs","repos_url":"https://api.github.com/users/Thomvis/repos","events_url":"https://api.github.com/users/Thomvis/events{/privacy}","received_events_url":"https://api.github.com/users/Thomvis/received_events","type":"User","site_admin":false},"repo":{"id":20614919,"name":"BrightFutures","full_name":"Thomvis/BrightFutures","owner":{"login":"Thomvis","id":134170,"avatar_url":"https://avatars.githubusercontent.com/u/134170?v=3","gravatar_id":"","url":"https://api.github.com/users/Thomvis","html_url":"https://github.com/Thomvis","followers_url":"https://api.github.com/users/Thomvis/followers","following_url":"https://api.github.com/users/Thomvis/following{/other_user}","gists_url":"https://api.github.com/users/Thomvis/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomvis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomvis/subscriptions","organizations_url":"https://api.github.com/users/Thomvis/orgs","repos_url":"https://api.github.com/users/Thomvis/repos","events_url":"https://api.github.com/users/Thomvis/events{/privacy}","received_events_url":"https://api.github.com/users/Thomvis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thomvis/BrightFutures","description":"Write great asynchronous code in Swift using futures and promises","fork":false,"url":"https://api.github.com/repos/Thomvis/BrightFutures","forks_url":"https://api.github.com/repos/Thomvis/BrightFutures/forks","keys_url":"https://api.github.com/repos/Thomvis/BrightFutures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thomvis/BrightFutures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thomvis/BrightFutures/teams","hooks_url":"https://api.github.com/repos/Thomvis/BrightFutures/hooks","issue_events_url":"https://api.github.com/repos/Thomvis/BrightFutures/issues/events{/number}","events_url":"https://api.github.com/repos/Thomvis/BrightFutures/events","assignees_url":"https://api.github.com/repos/Thomvis/BrightFutures/assignees{/user}","branches_url":"https://api.github.com/repos/Thomvis/BrightFutures/branches{/branch}","tags_url":"https://api.github.com/repos/Thomvis/BrightFutures/tags","blobs_url":"https://api.github.com/repos/Thomvis/BrightFutures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thomvis/BrightFutures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thomvis/BrightFutures/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thomvis/BrightFutures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thomvis/BrightFutures/statuses/{sha}","languages_url":"https://api.github.com/repos/Thomvis/BrightFutures/languages","stargazers_url":"https://api.github.com/repos/Thomvis/BrightFutures/stargazers","contributors_url":"https://api.github.com/repos/Thomvis/BrightFutures/contributors","subscribers_url":"https://api.github.com/repos/Thomvis/BrightFutures/subscribers","subscription_url":"https://api.github.com/repos/Thomvis/BrightFutures/subscription","commits_url":"https://api.github.com/repos/Thomvis/BrightFutures/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thomvis/BrightFutures/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thomvis/BrightFutures/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thomvis/BrightFutures/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thomvis/BrightFutures/contents/{+path}","compare_url":"https://api.github.com/repos/Thomvis/BrightFutures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thomvis/BrightFutures/merges","archive_url":"https://api.github.com/repos/Thomvis/BrightFutures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thomvis/BrightFutures/downloads","issues_url":"https://api.github.com/repos/Thomvis/BrightFutures/issues{/number}","pulls_url":"https://api.github.com/repos/Thomvis/BrightFutures/pulls{/number}","milestones_url":"https://api.github.com/repos/Thomvis/BrightFutures/milestones{/number}","notifications_url":"https://api.github.com/repos/Thomvis/BrightFutures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thomvis/BrightFutures/labels{/name}","releases_url":"https://api.github.com/repos/Thomvis/BrightFutures/releases{/id}","created_at":"2014-06-08T10:57:27Z","updated_at":"2015-12-21T22:29:17Z","pushed_at":"2015-12-22T20:11:36Z","git_url":"git://github.com/Thomvis/BrightFutures.git","ssh_url":"git@github.com:Thomvis/BrightFutures.git","clone_url":"https://github.com/Thomvis/BrightFutures.git","svn_url":"https://github.com/Thomvis/BrightFutures","homepage":"","size":730,"stargazers_count":846,"watchers_count":846,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":66,"mirror_url":null,"open_issues_count":10,"forks":66,"open_issues":10,"watchers":846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/109"},"html":{"href":"https://github.com/Thomvis/BrightFutures/pull/109"},"issue":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/issues/109"},"comments":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/issues/109/comments"},"review_comments":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/109/comments"},"review_comment":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/pulls/109/commits"},"statuses":{"href":"https://api.github.com/repos/Thomvis/BrightFutures/statuses/89f104691d82e9f3b7ed587ad4e1201289b0a5c9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":98,"deletions":16,"changed_files":7}}