{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/9867","labels_url":"https://api.github.com/repos/apache/spark/issues/9867/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/9867/comments","events_url":"https://api.github.com/repos/apache/spark/issues/9867/events","html_url":"https://github.com/apache/spark/pull/9867","id":118114713,"number":9867,"title":"[SPARK-6990] [Build] Add Java linting script; fix minor warnings","user":{"login":"dskrvk","id":2267624,"avatar_url":"https://avatars.githubusercontent.com/u/2267624?v=3","gravatar_id":"","url":"https://api.github.com/users/dskrvk","html_url":"https://github.com/dskrvk","followers_url":"https://api.github.com/users/dskrvk/followers","following_url":"https://api.github.com/users/dskrvk/following{/other_user}","gists_url":"https://api.github.com/users/dskrvk/gists{/gist_id}","starred_url":"https://api.github.com/users/dskrvk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dskrvk/subscriptions","organizations_url":"https://api.github.com/users/dskrvk/orgs","repos_url":"https://api.github.com/users/dskrvk/repos","events_url":"https://api.github.com/users/dskrvk/events{/privacy}","received_events_url":"https://api.github.com/users/dskrvk/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":19,"created_at":"2015-11-20T19:56:05Z","updated_at":"2015-12-04T20:06:03Z","closed_at":"2015-12-04T20:05:31Z","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/9867","html_url":"https://github.com/apache/spark/pull/9867","diff_url":"https://github.com/apache/spark/pull/9867.diff","patch_url":"https://github.com/apache/spark/pull/9867.patch"},"body":"This replaces https://github.com/apache/spark/pull/9696\r\n\r\nInvoke Checkstyle and print any errors to the console, failing the step.\r\nUse Google's style rules modified according to\r\nhttps://cwiki.apache.org/confluence/display/SPARK/Spark+Code+Style+Guide\r\nSome important checks are disabled (see TODOs in `checkstyle.xml`) due to\r\nmultiple violations being present in the codebase.\r\n\r\nSuggest fixing those TODOs in a separate PR(s).\r\n\r\nMore on Checkstyle can be found on the [official website](http://checkstyle.sourceforge.net/).\r\n\r\nSample output (from [build 46345](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/46345/consoleFull)) (duplicated because I run the build twice with different profiles):\r\n\r\n> Checkstyle checks failed at following occurrences:\r\n[ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without \"default\" clause.\r\n> [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions.\r\n> [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/UnsafeRowParquetRecordReader.java:[217,7] (coding) MissingSwitchDefault: switch without \"default\" clause.\r\n> [ERROR] src/main/java/org/apache/spark/sql/execution/datasources/parquet/SpecificParquetRecordReaderBase.java:[198,10] (modifier) ModifierOrder: 'protected' modifier out of order with the JLS suggestions.\r\n> [error] running /home/jenkins/workspace/SparkPullRequestBuilder@2/dev/lint-java ; received return code 1\r\n\r\nAlso fix some of the minor violations that didn't require sweeping changes.\r\n\r\nApologies for the previous botched PRs - I finally figured out the issue.\r\n\r\ncr: @JoshRosen, @pwendell \r\n\r\n> I state that the contribution is my original work, and I license the work to the project under the project's open source license."},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/162068764","html_url":"https://github.com/apache/spark/pull/9867#issuecomment-162068764","issue_url":"https://api.github.com/repos/apache/spark/issues/9867","id":162068764,"user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T20:06:03Z","updated_at":"2015-12-04T20:06:03Z","body":"Hey @dskrvk, what's your Apache JIRA username? I need it in order to assign the JIRA to you so that you are properly credit by our release-notes generation script."}}