{"action":"created","comment":{"url":"https://api.github.com/repos/minetest/minetest/pulls/comments/36035619","id":36035619,"diff_hunk":"@@ -1826,21 +1826,23 @@ void ServerEnvironment::deactivateFarObjects(bool force_delete)\n \n \t\t\t\tMapBlock *block = m_map->emergeBlock(obj->m_static_block, false);\n \n-\t\t\t\tstd::map<u16, StaticObject>::iterator n =\n+\t\t\t\tif (block) {\n+\t\t\t\t\tstd::map<u16, StaticObject>::iterator n =\n \t\t\t\t\t\tblock->m_static_objects.m_active.find(id);\n-\t\t\t\tif(n != block->m_static_objects.m_active.end()){\n-\t\t\t\t\tStaticObject static_old = n->second;\n+\t\t\t\t\tif(n != block->m_static_objects.m_active.end()){\n+\t\t\t\t\t\tStaticObject static_old = n->second;\n \n-\t\t\t\t\tfloat save_movem = obj->getMinimumSavedMovement();\n+\t\t\t\t\t\tfloat save_movem = obj->getMinimumSavedMovement();\n \n-\t\t\t\t\tif(static_old.data == staticdata_new &&\n-\t\t\t\t\t\t\t(static_old.pos - objectpos).getLength() < save_movem)\n-\t\t\t\t\t\tdata_changed = false;\n-\t\t\t\t} else {\n-\t\t\t\t\terrorstream<<\"ServerEnvironment::deactivateFarObjects(): \"\n+\t\t\t\t\t\tif(static_old.data == staticdata_new &&","path":"src/environment.cpp","position":21,"original_position":21,"commit_id":"ab184d9199ccc67bb4668fb17a68a8a9e975f32d","original_commit_id":"ab184d9199ccc67bb4668fb17a68a8a9e975f32d","user":{"login":"est31","id":8872119,"avatar_url":"https://avatars.githubusercontent.com/u/8872119?v=3","gravatar_id":"","url":"https://api.github.com/users/est31","html_url":"https://github.com/est31","followers_url":"https://api.github.com/users/est31/followers","following_url":"https://api.github.com/users/est31/following{/other_user}","gists_url":"https://api.github.com/users/est31/gists{/gist_id}","starred_url":"https://api.github.com/users/est31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/est31/subscriptions","organizations_url":"https://api.github.com/users/est31/orgs","repos_url":"https://api.github.com/users/est31/repos","events_url":"https://api.github.com/users/est31/events{/privacy}","received_events_url":"https://api.github.com/users/est31/received_events","type":"User","site_admin":false},"body":"space","created_at":"2015-08-01T17:59:30Z","updated_at":"2015-08-01T17:59:30Z","html_url":"https://github.com/minetest/minetest/pull/2980#discussion_r36035619","pull_request_url":"https://api.github.com/repos/minetest/minetest/pulls/2980","_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments/36035619"},"html":{"href":"https://github.com/minetest/minetest/pull/2980#discussion_r36035619"},"pull_request":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2980"}}},"pull_request":{"url":"https://api.github.com/repos/minetest/minetest/pulls/2980","id":41401255,"html_url":"https://github.com/minetest/minetest/pull/2980","diff_url":"https://github.com/minetest/minetest/pull/2980.diff","patch_url":"https://github.com/minetest/minetest/pull/2980.patch","issue_url":"https://api.github.com/repos/minetest/minetest/issues/2980","number":2980,"state":"open","locked":false,"title":"Fix a race condition and a nullptr dereference","user":{"login":"t0suj4","id":1174502,"avatar_url":"https://avatars.githubusercontent.com/u/1174502?v=3","gravatar_id":"","url":"https://api.github.com/users/t0suj4","html_url":"https://github.com/t0suj4","followers_url":"https://api.github.com/users/t0suj4/followers","following_url":"https://api.github.com/users/t0suj4/following{/other_user}","gists_url":"https://api.github.com/users/t0suj4/gists{/gist_id}","starred_url":"https://api.github.com/users/t0suj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t0suj4/subscriptions","organizations_url":"https://api.github.com/users/t0suj4/orgs","repos_url":"https://api.github.com/users/t0suj4/repos","events_url":"https://api.github.com/users/t0suj4/events{/privacy}","received_events_url":"https://api.github.com/users/t0suj4/received_events","type":"User","site_admin":false},"body":"Related to two bugs of #2913 ","created_at":"2015-08-01T12:38:38Z","updated_at":"2015-08-01T17:59:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b704e10f881f5235df1544c80ca60d4b304ac0ba","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/minetest/minetest/pulls/2980/commits","review_comments_url":"https://api.github.com/repos/minetest/minetest/pulls/2980/comments","review_comment_url":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minetest/minetest/issues/2980/comments","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/ab184d9199ccc67bb4668fb17a68a8a9e975f32d","head":{"label":"t0suj4:master","ref":"master","sha":"ab184d9199ccc67bb4668fb17a68a8a9e975f32d","user":{"login":"t0suj4","id":1174502,"avatar_url":"https://avatars.githubusercontent.com/u/1174502?v=3","gravatar_id":"","url":"https://api.github.com/users/t0suj4","html_url":"https://github.com/t0suj4","followers_url":"https://api.github.com/users/t0suj4/followers","following_url":"https://api.github.com/users/t0suj4/following{/other_user}","gists_url":"https://api.github.com/users/t0suj4/gists{/gist_id}","starred_url":"https://api.github.com/users/t0suj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t0suj4/subscriptions","organizations_url":"https://api.github.com/users/t0suj4/orgs","repos_url":"https://api.github.com/users/t0suj4/repos","events_url":"https://api.github.com/users/t0suj4/events{/privacy}","received_events_url":"https://api.github.com/users/t0suj4/received_events","type":"User","site_admin":false},"repo":{"id":24194430,"name":"minetest","full_name":"t0suj4/minetest","owner":{"login":"t0suj4","id":1174502,"avatar_url":"https://avatars.githubusercontent.com/u/1174502?v=3","gravatar_id":"","url":"https://api.github.com/users/t0suj4","html_url":"https://github.com/t0suj4","followers_url":"https://api.github.com/users/t0suj4/followers","following_url":"https://api.github.com/users/t0suj4/following{/other_user}","gists_url":"https://api.github.com/users/t0suj4/gists{/gist_id}","starred_url":"https://api.github.com/users/t0suj4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t0suj4/subscriptions","organizations_url":"https://api.github.com/users/t0suj4/orgs","repos_url":"https://api.github.com/users/t0suj4/repos","events_url":"https://api.github.com/users/t0suj4/events{/privacy}","received_events_url":"https://api.github.com/users/t0suj4/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t0suj4/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":true,"url":"https://api.github.com/repos/t0suj4/minetest","forks_url":"https://api.github.com/repos/t0suj4/minetest/forks","keys_url":"https://api.github.com/repos/t0suj4/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t0suj4/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t0suj4/minetest/teams","hooks_url":"https://api.github.com/repos/t0suj4/minetest/hooks","issue_events_url":"https://api.github.com/repos/t0suj4/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/t0suj4/minetest/events","assignees_url":"https://api.github.com/repos/t0suj4/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/t0suj4/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/t0suj4/minetest/tags","blobs_url":"https://api.github.com/repos/t0suj4/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t0suj4/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t0suj4/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/t0suj4/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t0suj4/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/t0suj4/minetest/languages","stargazers_url":"https://api.github.com/repos/t0suj4/minetest/stargazers","contributors_url":"https://api.github.com/repos/t0suj4/minetest/contributors","subscribers_url":"https://api.github.com/repos/t0suj4/minetest/subscribers","subscription_url":"https://api.github.com/repos/t0suj4/minetest/subscription","commits_url":"https://api.github.com/repos/t0suj4/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/t0suj4/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/t0suj4/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/t0suj4/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/t0suj4/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/t0suj4/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t0suj4/minetest/merges","archive_url":"https://api.github.com/repos/t0suj4/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t0suj4/minetest/downloads","issues_url":"https://api.github.com/repos/t0suj4/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/t0suj4/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/t0suj4/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/t0suj4/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t0suj4/minetest/labels{/name}","releases_url":"https://api.github.com/repos/t0suj4/minetest/releases{/id}","created_at":"2014-09-18T15:48:25Z","updated_at":"2015-07-21T22:57:34Z","pushed_at":"2015-08-01T12:14:50Z","git_url":"git://github.com/t0suj4/minetest.git","ssh_url":"git@github.com:t0suj4/minetest.git","clone_url":"https://github.com/t0suj4/minetest.git","svn_url":"https://github.com/t0suj4/minetest","homepage":"http://minetest.net/","size":35578,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minetest:master","ref":"master","sha":"7919318be715e3bf60f01b7c63816a3e5802176d","user":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"repo":{"id":2168780,"name":"minetest","full_name":"minetest/minetest","owner":{"login":"minetest","id":2624745,"avatar_url":"https://avatars.githubusercontent.com/u/2624745?v=3","gravatar_id":"","url":"https://api.github.com/users/minetest","html_url":"https://github.com/minetest","followers_url":"https://api.github.com/users/minetest/followers","following_url":"https://api.github.com/users/minetest/following{/other_user}","gists_url":"https://api.github.com/users/minetest/gists{/gist_id}","starred_url":"https://api.github.com/users/minetest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minetest/subscriptions","organizations_url":"https://api.github.com/users/minetest/orgs","repos_url":"https://api.github.com/users/minetest/repos","events_url":"https://api.github.com/users/minetest/events{/privacy}","received_events_url":"https://api.github.com/users/minetest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minetest/minetest","description":"Minetest, an open source infinite-world block sandbox game with survival and crafting. [also https://github.com/minetest/minetest_game]","fork":false,"url":"https://api.github.com/repos/minetest/minetest","forks_url":"https://api.github.com/repos/minetest/minetest/forks","keys_url":"https://api.github.com/repos/minetest/minetest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minetest/minetest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minetest/minetest/teams","hooks_url":"https://api.github.com/repos/minetest/minetest/hooks","issue_events_url":"https://api.github.com/repos/minetest/minetest/issues/events{/number}","events_url":"https://api.github.com/repos/minetest/minetest/events","assignees_url":"https://api.github.com/repos/minetest/minetest/assignees{/user}","branches_url":"https://api.github.com/repos/minetest/minetest/branches{/branch}","tags_url":"https://api.github.com/repos/minetest/minetest/tags","blobs_url":"https://api.github.com/repos/minetest/minetest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minetest/minetest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minetest/minetest/git/refs{/sha}","trees_url":"https://api.github.com/repos/minetest/minetest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minetest/minetest/statuses/{sha}","languages_url":"https://api.github.com/repos/minetest/minetest/languages","stargazers_url":"https://api.github.com/repos/minetest/minetest/stargazers","contributors_url":"https://api.github.com/repos/minetest/minetest/contributors","subscribers_url":"https://api.github.com/repos/minetest/minetest/subscribers","subscription_url":"https://api.github.com/repos/minetest/minetest/subscription","commits_url":"https://api.github.com/repos/minetest/minetest/commits{/sha}","git_commits_url":"https://api.github.com/repos/minetest/minetest/git/commits{/sha}","comments_url":"https://api.github.com/repos/minetest/minetest/comments{/number}","issue_comment_url":"https://api.github.com/repos/minetest/minetest/issues/comments{/number}","contents_url":"https://api.github.com/repos/minetest/minetest/contents/{+path}","compare_url":"https://api.github.com/repos/minetest/minetest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minetest/minetest/merges","archive_url":"https://api.github.com/repos/minetest/minetest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minetest/minetest/downloads","issues_url":"https://api.github.com/repos/minetest/minetest/issues{/number}","pulls_url":"https://api.github.com/repos/minetest/minetest/pulls{/number}","milestones_url":"https://api.github.com/repos/minetest/minetest/milestones{/number}","notifications_url":"https://api.github.com/repos/minetest/minetest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minetest/minetest/labels{/name}","releases_url":"https://api.github.com/repos/minetest/minetest/releases{/id}","created_at":"2011-08-07T13:48:36Z","updated_at":"2015-08-01T14:43:42Z","pushed_at":"2015-08-01T12:38:38Z","git_url":"git://github.com/minetest/minetest.git","ssh_url":"git@github.com:minetest/minetest.git","clone_url":"https://github.com/minetest/minetest.git","svn_url":"https://github.com/minetest/minetest","homepage":"http://minetest.net/","size":100776,"stargazers_count":1568,"watchers_count":1568,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":518,"mirror_url":null,"open_issues_count":570,"forks":518,"open_issues":570,"watchers":1568,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2980"},"html":{"href":"https://github.com/minetest/minetest/pull/2980"},"issue":{"href":"https://api.github.com/repos/minetest/minetest/issues/2980"},"comments":{"href":"https://api.github.com/repos/minetest/minetest/issues/2980/comments"},"review_comments":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2980/comments"},"review_comment":{"href":"https://api.github.com/repos/minetest/minetest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minetest/minetest/pulls/2980/commits"},"statuses":{"href":"https://api.github.com/repos/minetest/minetest/statuses/ab184d9199ccc67bb4668fb17a68a8a9e975f32d"}}}}