{"action":"created","comment":{"url":"https://api.github.com/repos/aiorazabala/qmethod/pulls/comments/38820427","id":38820427,"diff_hunk":"@@ -1,12 +1,22 @@\n q.fnames <- function(results, fnames) {\n-  # Error checks \n-  if (class(results) != \"QmethodRes\") stop(\"The object provided is not of class 'QmethodRes'\")\n+  # Error checks\n+  if (class(results) != \"QmethodRes\") stop(\"The object provided is not of class 'QmethodRes'.\")\n   comb <- array(sapply(fnames, function(x) substring(x,1,1)))\n   nos <- 0:9\n+  if (!is.vector(fnames)) {  # correct type?\n+    stop(\n+      \"The factor names specified are not a vector.\"\n+    )\n+  }\n   if(sum(comb %in% nos) > 0) stop(\"The names should not begin with a number\")\n-  if (length(fnames) != results$brief$nfactors) stop(paste0(\"The names provided (\", length(names), \") does not match the number of factors in the results (\", results$brief$nfactors, \")\"))\n+  if (length(fnames) != results$brief$nfactors) stop(paste0(\"The names provided (\", length(fnames), \") does not match the number of factors in the results (\", results$brief$nfactors, \")\"))\n   if (max(nchar(fnames)) > 50) stop(\"The names provided are longer than 50 characters.\")\n-  \n+\n+  # are any factors named yet? see #https://github.com/aiorazabala/qmethod/issues/241\n+  if (any(colnames(results$loa) == c(\"f1\", \"f2\", \"f3\"))) {\n+    warning(\"At least some of the factors in results were already named. Old names have been overwritten.\")\n+  }","path":"R/q.fnames.R","position":22,"original_position":22,"commit_id":"0d1161e2b23434275bf91d5efe40b765445ac4f9","original_commit_id":"0d1161e2b23434275bf91d5efe40b765445ac4f9","user":{"login":"aiorazabala","id":9744924,"avatar_url":"https://avatars.githubusercontent.com/u/9744924?v=3","gravatar_id":"","url":"https://api.github.com/users/aiorazabala","html_url":"https://github.com/aiorazabala","followers_url":"https://api.github.com/users/aiorazabala/followers","following_url":"https://api.github.com/users/aiorazabala/following{/other_user}","gists_url":"https://api.github.com/users/aiorazabala/gists{/gist_id}","starred_url":"https://api.github.com/users/aiorazabala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiorazabala/subscriptions","organizations_url":"https://api.github.com/users/aiorazabala/orgs","repos_url":"https://api.github.com/users/aiorazabala/repos","events_url":"https://api.github.com/users/aiorazabala/events{/privacy}","received_events_url":"https://api.github.com/users/aiorazabala/received_events","type":"User","site_admin":false},"body":"What does this warning mean? please clarify the message","created_at":"2015-09-06T11:37:12Z","updated_at":"2015-09-06T11:37:12Z","html_url":"https://github.com/aiorazabala/qmethod/pull/97#discussion_r38820427","pull_request_url":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/aiorazabala/qmethod/pulls/comments/38820427"},"html":{"href":"https://github.com/aiorazabala/qmethod/pull/97#discussion_r38820427"},"pull_request":{"href":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97","id":30564463,"html_url":"https://github.com/aiorazabala/qmethod/pull/97","diff_url":"https://github.com/aiorazabala/qmethod/pull/97.diff","patch_url":"https://github.com/aiorazabala/qmethod/pull/97.patch","issue_url":"https://api.github.com/repos/aiorazabala/qmethod/issues/97","number":97,"state":"open","locked":false,"title":"Visualizations, Manual Rotation and Much More","user":{"login":"maxheld83","id":5372770,"avatar_url":"https://avatars.githubusercontent.com/u/5372770?v=3","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"body":"**NOT READY TO BE MERGED YET** (hence `[WIP]`)\r\n\r\n(This is the same as #75, but now vis-a-vis `master` as discussed in #79.)\r\n\r\nThis PR will feature a bunch of visualizations and necessary groundwork for them.\r\n\r\n- [x] Q array visualization (the ideal sorts) #14 \r\n  - [x] separate function to calculate item standard deviation #66 \r\n  - [x] spin out weighting procedure from `qzscores()` into seperate `qfwe()` function #129 \r\n  - [x] pop.sd helper function #126 \r\n- [x] correlation matrix plot #92 \r\n- [x] Various nfactor criteria and plots\r\n  - [x] #148 communalities plot\r\n  - [x] #149 bartlett's test and residual correlation matrix plot\r\n  - [x] #150 scree plot!\r\n  - [x] #151 Brown#s magic number 7\r\n  - [x] #152 Watts Stenner criterion\r\n  - [x] #153 Kaiser-Guttman\r\n- [x] factor space plots #94 (**2d**)\r\n- [x] factor composition plot #98 \r\n","created_at":"2015-03-05T15:12:47Z","updated_at":"2015-09-06T11:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eda5be6f38ba2026e6a53750c1881db9754f75d8","assignee":{"login":"maxheld83","id":5372770,"avatar_url":"https://avatars.githubusercontent.com/u/5372770?v=3","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/aiorazabala/qmethod/milestones/5","html_url":"https://github.com/aiorazabala/qmethod/milestones/1.4.0%20(Visualizations%20+%20Manual%20Rotation)","labels_url":"https://api.github.com/repos/aiorazabala/qmethod/milestones/5/labels","id":997073,"number":5,"title":"1.4.0 (Visualizations + Manual Rotation)","description":"","creator":{"login":"maxheld83","id":5372770,"avatar_url":"https://avatars.githubusercontent.com/u/5372770?v=3","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":92,"state":"open","created_at":"2015-02-26T14:46:15Z","updated_at":"2015-09-05T16:21:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97/commits","review_comments_url":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97/comments","review_comment_url":"https://api.github.com/repos/aiorazabala/qmethod/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aiorazabala/qmethod/issues/97/comments","statuses_url":"https://api.github.com/repos/aiorazabala/qmethod/statuses/0d1161e2b23434275bf91d5efe40b765445ac4f9","head":{"label":"maxheld83:array-viz","ref":"array-viz","sha":"0d1161e2b23434275bf91d5efe40b765445ac4f9","user":{"login":"maxheld83","id":5372770,"avatar_url":"https://avatars.githubusercontent.com/u/5372770?v=3","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"repo":{"id":26678532,"name":"qmethod","full_name":"maxheld83/qmethod","owner":{"login":"maxheld83","id":5372770,"avatar_url":"https://avatars.githubusercontent.com/u/5372770?v=3","gravatar_id":"","url":"https://api.github.com/users/maxheld83","html_url":"https://github.com/maxheld83","followers_url":"https://api.github.com/users/maxheld83/followers","following_url":"https://api.github.com/users/maxheld83/following{/other_user}","gists_url":"https://api.github.com/users/maxheld83/gists{/gist_id}","starred_url":"https://api.github.com/users/maxheld83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxheld83/subscriptions","organizations_url":"https://api.github.com/users/maxheld83/orgs","repos_url":"https://api.github.com/users/maxheld83/repos","events_url":"https://api.github.com/users/maxheld83/events{/privacy}","received_events_url":"https://api.github.com/users/maxheld83/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxheld83/qmethod","description":"R package to analyse Q methodology data","fork":true,"url":"https://api.github.com/repos/maxheld83/qmethod","forks_url":"https://api.github.com/repos/maxheld83/qmethod/forks","keys_url":"https://api.github.com/repos/maxheld83/qmethod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxheld83/qmethod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxheld83/qmethod/teams","hooks_url":"https://api.github.com/repos/maxheld83/qmethod/hooks","issue_events_url":"https://api.github.com/repos/maxheld83/qmethod/issues/events{/number}","events_url":"https://api.github.com/repos/maxheld83/qmethod/events","assignees_url":"https://api.github.com/repos/maxheld83/qmethod/assignees{/user}","branches_url":"https://api.github.com/repos/maxheld83/qmethod/branches{/branch}","tags_url":"https://api.github.com/repos/maxheld83/qmethod/tags","blobs_url":"https://api.github.com/repos/maxheld83/qmethod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxheld83/qmethod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxheld83/qmethod/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxheld83/qmethod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxheld83/qmethod/statuses/{sha}","languages_url":"https://api.github.com/repos/maxheld83/qmethod/languages","stargazers_url":"https://api.github.com/repos/maxheld83/qmethod/stargazers","contributors_url":"https://api.github.com/repos/maxheld83/qmethod/contributors","subscribers_url":"https://api.github.com/repos/maxheld83/qmethod/subscribers","subscription_url":"https://api.github.com/repos/maxheld83/qmethod/subscription","commits_url":"https://api.github.com/repos/maxheld83/qmethod/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxheld83/qmethod/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxheld83/qmethod/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxheld83/qmethod/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxheld83/qmethod/contents/{+path}","compare_url":"https://api.github.com/repos/maxheld83/qmethod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxheld83/qmethod/merges","archive_url":"https://api.github.com/repos/maxheld83/qmethod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxheld83/qmethod/downloads","issues_url":"https://api.github.com/repos/maxheld83/qmethod/issues{/number}","pulls_url":"https://api.github.com/repos/maxheld83/qmethod/pulls{/number}","milestones_url":"https://api.github.com/repos/maxheld83/qmethod/milestones{/number}","notifications_url":"https://api.github.com/repos/maxheld83/qmethod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxheld83/qmethod/labels{/name}","releases_url":"https://api.github.com/repos/maxheld83/qmethod/releases{/id}","created_at":"2014-11-15T11:56:29Z","updated_at":"2015-03-19T22:19:34Z","pushed_at":"2015-09-05T20:21:01Z","git_url":"git://github.com/maxheld83/qmethod.git","ssh_url":"git@github.com:maxheld83/qmethod.git","clone_url":"https://github.com/maxheld83/qmethod.git","svn_url":"https://github.com/maxheld83/qmethod","homepage":null,"size":980,"stargazers_count":0,"watchers_count":0,"language":"R","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aiorazabala:master","ref":"master","sha":"426680efee46d413f69a25d6285e86ed134eeaa7","user":{"login":"aiorazabala","id":9744924,"avatar_url":"https://avatars.githubusercontent.com/u/9744924?v=3","gravatar_id":"","url":"https://api.github.com/users/aiorazabala","html_url":"https://github.com/aiorazabala","followers_url":"https://api.github.com/users/aiorazabala/followers","following_url":"https://api.github.com/users/aiorazabala/following{/other_user}","gists_url":"https://api.github.com/users/aiorazabala/gists{/gist_id}","starred_url":"https://api.github.com/users/aiorazabala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiorazabala/subscriptions","organizations_url":"https://api.github.com/users/aiorazabala/orgs","repos_url":"https://api.github.com/users/aiorazabala/repos","events_url":"https://api.github.com/users/aiorazabala/events{/privacy}","received_events_url":"https://api.github.com/users/aiorazabala/received_events","type":"User","site_admin":false},"repo":{"id":26639809,"name":"qmethod","full_name":"aiorazabala/qmethod","owner":{"login":"aiorazabala","id":9744924,"avatar_url":"https://avatars.githubusercontent.com/u/9744924?v=3","gravatar_id":"","url":"https://api.github.com/users/aiorazabala","html_url":"https://github.com/aiorazabala","followers_url":"https://api.github.com/users/aiorazabala/followers","following_url":"https://api.github.com/users/aiorazabala/following{/other_user}","gists_url":"https://api.github.com/users/aiorazabala/gists{/gist_id}","starred_url":"https://api.github.com/users/aiorazabala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aiorazabala/subscriptions","organizations_url":"https://api.github.com/users/aiorazabala/orgs","repos_url":"https://api.github.com/users/aiorazabala/repos","events_url":"https://api.github.com/users/aiorazabala/events{/privacy}","received_events_url":"https://api.github.com/users/aiorazabala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aiorazabala/qmethod","description":"R package to analyse Q methodology data","fork":false,"url":"https://api.github.com/repos/aiorazabala/qmethod","forks_url":"https://api.github.com/repos/aiorazabala/qmethod/forks","keys_url":"https://api.github.com/repos/aiorazabala/qmethod/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aiorazabala/qmethod/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aiorazabala/qmethod/teams","hooks_url":"https://api.github.com/repos/aiorazabala/qmethod/hooks","issue_events_url":"https://api.github.com/repos/aiorazabala/qmethod/issues/events{/number}","events_url":"https://api.github.com/repos/aiorazabala/qmethod/events","assignees_url":"https://api.github.com/repos/aiorazabala/qmethod/assignees{/user}","branches_url":"https://api.github.com/repos/aiorazabala/qmethod/branches{/branch}","tags_url":"https://api.github.com/repos/aiorazabala/qmethod/tags","blobs_url":"https://api.github.com/repos/aiorazabala/qmethod/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aiorazabala/qmethod/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aiorazabala/qmethod/git/refs{/sha}","trees_url":"https://api.github.com/repos/aiorazabala/qmethod/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aiorazabala/qmethod/statuses/{sha}","languages_url":"https://api.github.com/repos/aiorazabala/qmethod/languages","stargazers_url":"https://api.github.com/repos/aiorazabala/qmethod/stargazers","contributors_url":"https://api.github.com/repos/aiorazabala/qmethod/contributors","subscribers_url":"https://api.github.com/repos/aiorazabala/qmethod/subscribers","subscription_url":"https://api.github.com/repos/aiorazabala/qmethod/subscription","commits_url":"https://api.github.com/repos/aiorazabala/qmethod/commits{/sha}","git_commits_url":"https://api.github.com/repos/aiorazabala/qmethod/git/commits{/sha}","comments_url":"https://api.github.com/repos/aiorazabala/qmethod/comments{/number}","issue_comment_url":"https://api.github.com/repos/aiorazabala/qmethod/issues/comments{/number}","contents_url":"https://api.github.com/repos/aiorazabala/qmethod/contents/{+path}","compare_url":"https://api.github.com/repos/aiorazabala/qmethod/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aiorazabala/qmethod/merges","archive_url":"https://api.github.com/repos/aiorazabala/qmethod/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aiorazabala/qmethod/downloads","issues_url":"https://api.github.com/repos/aiorazabala/qmethod/issues{/number}","pulls_url":"https://api.github.com/repos/aiorazabala/qmethod/pulls{/number}","milestones_url":"https://api.github.com/repos/aiorazabala/qmethod/milestones{/number}","notifications_url":"https://api.github.com/repos/aiorazabala/qmethod/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aiorazabala/qmethod/labels{/name}","releases_url":"https://api.github.com/repos/aiorazabala/qmethod/releases{/id}","created_at":"2014-11-14T13:30:50Z","updated_at":"2015-05-04T11:23:18Z","pushed_at":"2015-09-05T20:21:01Z","git_url":"git://github.com/aiorazabala/qmethod.git","ssh_url":"git@github.com:aiorazabala/qmethod.git","clone_url":"https://github.com/aiorazabala/qmethod.git","svn_url":"https://github.com/aiorazabala/qmethod","homepage":null,"size":1501,"stargazers_count":5,"watchers_count":5,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":95,"forks":4,"open_issues":95,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97"},"html":{"href":"https://github.com/aiorazabala/qmethod/pull/97"},"issue":{"href":"https://api.github.com/repos/aiorazabala/qmethod/issues/97"},"comments":{"href":"https://api.github.com/repos/aiorazabala/qmethod/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/aiorazabala/qmethod/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aiorazabala/qmethod/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/aiorazabala/qmethod/statuses/0d1161e2b23434275bf91d5efe40b765445ac4f9"}}}}