{"action":"opened","number":4650,"pull_request":{"url":"https://api.github.com/repos/scala/scala/pulls/4650","id":40364060,"html_url":"https://github.com/scala/scala/pull/4650","diff_url":"https://github.com/scala/scala/pull/4650.diff","patch_url":"https://github.com/scala/scala/pull/4650.patch","issue_url":"https://api.github.com/repos/scala/scala/issues/4650","number":4650,"state":"open","locked":false,"title":"SI-8502 create PackageClass instead of Class symbol stubs for pkgs","user":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"body":"https://github.com/scala/scala/pull/4111 creates a stub type symbol\r\nfor missing packages, deferring (or avoiding) a crash if a package\r\nis missing.\r\n\r\nThe symbol created was a ClassSymbol, which could lead to an assertion\r\nfailure in flattten:\r\n\r\n    case TypeRef(pre, sym, args) if isFlattenablePrefix(pre) =>\r\n      assert(args.isEmpty && sym.enclosingTopLevelClass != NoSymbol, sym.ownerChain)\r\n\r\n`pre` is the stub ClassSymbol, so `isFlattenablePrefix` is true (but\r\nit should be false). The assertion then fails because the enclosing\r\nclass of a top-level class defined in a missing package is NoSymbol.\r\n\r\nThis failed only with GenBCode, which traverses more of the symbol\r\ngraph while building ClassBTypes: it looks collects the nested classes\r\nof `Outer` into a `NestedInfo`.","created_at":"2015-07-20T15:26:51Z","updated_at":"2015-07-20T15:26:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/scala/scala/pulls/4650/commits","review_comments_url":"https://api.github.com/repos/scala/scala/pulls/4650/comments","review_comment_url":"https://api.github.com/repos/scala/scala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scala/scala/issues/4650/comments","statuses_url":"https://api.github.com/repos/scala/scala/statuses/3be56dd4a55d62f7da28bcb34ce3fd86bfa336fd","head":{"label":"lrytz:t8502-package","ref":"t8502-package","sha":"3be56dd4a55d62f7da28bcb34ce3fd86bfa336fd","user":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"repo":{"id":2891199,"name":"scala","full_name":"lrytz/scala","owner":{"login":"lrytz","id":119636,"avatar_url":"https://avatars.githubusercontent.com/u/119636?v=3","gravatar_id":"","url":"https://api.github.com/users/lrytz","html_url":"https://github.com/lrytz","followers_url":"https://api.github.com/users/lrytz/followers","following_url":"https://api.github.com/users/lrytz/following{/other_user}","gists_url":"https://api.github.com/users/lrytz/gists{/gist_id}","starred_url":"https://api.github.com/users/lrytz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrytz/subscriptions","organizations_url":"https://api.github.com/users/lrytz/orgs","repos_url":"https://api.github.com/users/lrytz/repos","events_url":"https://api.github.com/users/lrytz/events{/privacy}","received_events_url":"https://api.github.com/users/lrytz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lrytz/scala","description":"The Scala programming language","fork":true,"url":"https://api.github.com/repos/lrytz/scala","forks_url":"https://api.github.com/repos/lrytz/scala/forks","keys_url":"https://api.github.com/repos/lrytz/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lrytz/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lrytz/scala/teams","hooks_url":"https://api.github.com/repos/lrytz/scala/hooks","issue_events_url":"https://api.github.com/repos/lrytz/scala/issues/events{/number}","events_url":"https://api.github.com/repos/lrytz/scala/events","assignees_url":"https://api.github.com/repos/lrytz/scala/assignees{/user}","branches_url":"https://api.github.com/repos/lrytz/scala/branches{/branch}","tags_url":"https://api.github.com/repos/lrytz/scala/tags","blobs_url":"https://api.github.com/repos/lrytz/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lrytz/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lrytz/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/lrytz/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lrytz/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/lrytz/scala/languages","stargazers_url":"https://api.github.com/repos/lrytz/scala/stargazers","contributors_url":"https://api.github.com/repos/lrytz/scala/contributors","subscribers_url":"https://api.github.com/repos/lrytz/scala/subscribers","subscription_url":"https://api.github.com/repos/lrytz/scala/subscription","commits_url":"https://api.github.com/repos/lrytz/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/lrytz/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/lrytz/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/lrytz/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/lrytz/scala/contents/{+path}","compare_url":"https://api.github.com/repos/lrytz/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lrytz/scala/merges","archive_url":"https://api.github.com/repos/lrytz/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lrytz/scala/downloads","issues_url":"https://api.github.com/repos/lrytz/scala/issues{/number}","pulls_url":"https://api.github.com/repos/lrytz/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/lrytz/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/lrytz/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lrytz/scala/labels{/name}","releases_url":"https://api.github.com/repos/lrytz/scala/releases{/id}","created_at":"2011-12-01T13:16:01Z","updated_at":"2015-05-07T07:51:48Z","pushed_at":"2015-07-20T15:26:30Z","git_url":"git://github.com/lrytz/scala.git","ssh_url":"git@github.com:lrytz/scala.git","clone_url":"https://github.com/lrytz/scala.git","svn_url":"https://github.com/lrytz/scala","homepage":"http://www.scala-lang.org/","size":89166,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.11.x"}},"base":{"label":"scala:2.11.x","ref":"2.11.x","sha":"e84e06ca22c1fb77d3d4df82f322a8c6ee6c9569","user":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"repo":{"id":2888818,"name":"scala","full_name":"scala/scala","owner":{"login":"scala","id":57059,"avatar_url":"https://avatars.githubusercontent.com/u/57059?v=3","gravatar_id":"","url":"https://api.github.com/users/scala","html_url":"https://github.com/scala","followers_url":"https://api.github.com/users/scala/followers","following_url":"https://api.github.com/users/scala/following{/other_user}","gists_url":"https://api.github.com/users/scala/gists{/gist_id}","starred_url":"https://api.github.com/users/scala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scala/subscriptions","organizations_url":"https://api.github.com/users/scala/orgs","repos_url":"https://api.github.com/users/scala/repos","events_url":"https://api.github.com/users/scala/events{/privacy}","received_events_url":"https://api.github.com/users/scala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scala/scala","description":"The Scala programming language","fork":false,"url":"https://api.github.com/repos/scala/scala","forks_url":"https://api.github.com/repos/scala/scala/forks","keys_url":"https://api.github.com/repos/scala/scala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scala/scala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scala/scala/teams","hooks_url":"https://api.github.com/repos/scala/scala/hooks","issue_events_url":"https://api.github.com/repos/scala/scala/issues/events{/number}","events_url":"https://api.github.com/repos/scala/scala/events","assignees_url":"https://api.github.com/repos/scala/scala/assignees{/user}","branches_url":"https://api.github.com/repos/scala/scala/branches{/branch}","tags_url":"https://api.github.com/repos/scala/scala/tags","blobs_url":"https://api.github.com/repos/scala/scala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scala/scala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scala/scala/git/refs{/sha}","trees_url":"https://api.github.com/repos/scala/scala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scala/scala/statuses/{sha}","languages_url":"https://api.github.com/repos/scala/scala/languages","stargazers_url":"https://api.github.com/repos/scala/scala/stargazers","contributors_url":"https://api.github.com/repos/scala/scala/contributors","subscribers_url":"https://api.github.com/repos/scala/scala/subscribers","subscription_url":"https://api.github.com/repos/scala/scala/subscription","commits_url":"https://api.github.com/repos/scala/scala/commits{/sha}","git_commits_url":"https://api.github.com/repos/scala/scala/git/commits{/sha}","comments_url":"https://api.github.com/repos/scala/scala/comments{/number}","issue_comment_url":"https://api.github.com/repos/scala/scala/issues/comments{/number}","contents_url":"https://api.github.com/repos/scala/scala/contents/{+path}","compare_url":"https://api.github.com/repos/scala/scala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scala/scala/merges","archive_url":"https://api.github.com/repos/scala/scala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scala/scala/downloads","issues_url":"https://api.github.com/repos/scala/scala/issues{/number}","pulls_url":"https://api.github.com/repos/scala/scala/pulls{/number}","milestones_url":"https://api.github.com/repos/scala/scala/milestones{/number}","notifications_url":"https://api.github.com/repos/scala/scala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scala/scala/labels{/name}","releases_url":"https://api.github.com/repos/scala/scala/releases{/id}","created_at":"2011-12-01T05:02:34Z","updated_at":"2015-07-20T02:28:48Z","pushed_at":"2015-07-20T14:57:53Z","git_url":"git://github.com/scala/scala.git","ssh_url":"git@github.com:scala/scala.git","clone_url":"https://github.com/scala/scala.git","svn_url":"https://github.com/scala/scala","homepage":"http://www.scala-lang.org/","size":194211,"stargazers_count":4496,"watchers_count":4496,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1160,"mirror_url":null,"open_issues_count":27,"forks":1160,"open_issues":27,"watchers":4496,"default_branch":"2.11.x"}},"_links":{"self":{"href":"https://api.github.com/repos/scala/scala/pulls/4650"},"html":{"href":"https://github.com/scala/scala/pull/4650"},"issue":{"href":"https://api.github.com/repos/scala/scala/issues/4650"},"comments":{"href":"https://api.github.com/repos/scala/scala/issues/4650/comments"},"review_comments":{"href":"https://api.github.com/repos/scala/scala/pulls/4650/comments"},"review_comment":{"href":"https://api.github.com/repos/scala/scala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scala/scala/pulls/4650/commits"},"statuses":{"href":"https://api.github.com/repos/scala/scala/statuses/3be56dd4a55d62f7da28bcb34ce3fd86bfa336fd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":50,"deletions":3,"changed_files":3}}