{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/jupyter_core/pulls/comments/31076982","id":31076982,"diff_hunk":"@@ -216,14 +234,22 @@ def start(self):\n         \"\"\"Start the whole thing\"\"\"\n         if self.subcommand:\n             os.execv(self.subcommand, [self.subcommand] + self.argv[1:])\n-            return\n+            raise NoStart()","path":"jupyter_core/application.py","position":68,"original_position":68,"commit_id":"87f28f41645c03dac206743bb36bea845b6566d8","original_commit_id":"87f28f41645c03dac206743bb36bea845b6566d8","user":{"login":"takluyver","id":327925,"avatar_url":"https://avatars.githubusercontent.com/u/327925?v=3","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"body":"I think anything after execv is unreachable; if it succeeds, this code will no longer be executing, and if it fails, it will raise an error anyway.","created_at":"2015-05-26T20:36:59Z","updated_at":"2015-05-26T20:36:59Z","html_url":"https://github.com/jupyter/jupyter_core/pull/13#discussion_r31076982","pull_request_url":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_core/pulls/comments/31076982"},"html":{"href":"https://github.com/jupyter/jupyter_core/pull/13#discussion_r31076982"},"pull_request":{"href":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13","id":36241875,"html_url":"https://github.com/jupyter/jupyter_core/pull/13","diff_url":"https://github.com/jupyter/jupyter_core/pull/13.diff","patch_url":"https://github.com/jupyter/jupyter_core/pull/13.patch","issue_url":"https://api.github.com/repos/jupyter/jupyter_core/issues/13","number":13,"state":"open","locked":false,"title":"enable generating config files","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"body":"with `jupyter [app] --generate-config`\n\nBy raising `NoStart` in JupyterApp.start when start shouldn't proceed, subclasses can use `super` without having to duplicate checks for whether `start` should really do anything.","created_at":"2015-05-26T20:25:56Z","updated_at":"2015-05-26T20:36:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13/commits","review_comments_url":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13/comments","review_comment_url":"https://api.github.com/repos/jupyter/jupyter_core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/jupyter_core/issues/13/comments","statuses_url":"https://api.github.com/repos/jupyter/jupyter_core/statuses/87f28f41645c03dac206743bb36bea845b6566d8","head":{"label":"minrk:nostart","ref":"nostart","sha":"87f28f41645c03dac206743bb36bea845b6566d8","user":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"repo":{"id":33657505,"name":"jupyter_core","full_name":"minrk/jupyter_core","owner":{"login":"minrk","id":151929,"avatar_url":"https://avatars.githubusercontent.com/u/151929?v=3","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/minrk/jupyter_core","description":"Core Jupyter functionality","fork":true,"url":"https://api.github.com/repos/minrk/jupyter_core","forks_url":"https://api.github.com/repos/minrk/jupyter_core/forks","keys_url":"https://api.github.com/repos/minrk/jupyter_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minrk/jupyter_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minrk/jupyter_core/teams","hooks_url":"https://api.github.com/repos/minrk/jupyter_core/hooks","issue_events_url":"https://api.github.com/repos/minrk/jupyter_core/issues/events{/number}","events_url":"https://api.github.com/repos/minrk/jupyter_core/events","assignees_url":"https://api.github.com/repos/minrk/jupyter_core/assignees{/user}","branches_url":"https://api.github.com/repos/minrk/jupyter_core/branches{/branch}","tags_url":"https://api.github.com/repos/minrk/jupyter_core/tags","blobs_url":"https://api.github.com/repos/minrk/jupyter_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minrk/jupyter_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minrk/jupyter_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/minrk/jupyter_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minrk/jupyter_core/statuses/{sha}","languages_url":"https://api.github.com/repos/minrk/jupyter_core/languages","stargazers_url":"https://api.github.com/repos/minrk/jupyter_core/stargazers","contributors_url":"https://api.github.com/repos/minrk/jupyter_core/contributors","subscribers_url":"https://api.github.com/repos/minrk/jupyter_core/subscribers","subscription_url":"https://api.github.com/repos/minrk/jupyter_core/subscription","commits_url":"https://api.github.com/repos/minrk/jupyter_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/minrk/jupyter_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/minrk/jupyter_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/minrk/jupyter_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/minrk/jupyter_core/contents/{+path}","compare_url":"https://api.github.com/repos/minrk/jupyter_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minrk/jupyter_core/merges","archive_url":"https://api.github.com/repos/minrk/jupyter_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minrk/jupyter_core/downloads","issues_url":"https://api.github.com/repos/minrk/jupyter_core/issues{/number}","pulls_url":"https://api.github.com/repos/minrk/jupyter_core/pulls{/number}","milestones_url":"https://api.github.com/repos/minrk/jupyter_core/milestones{/number}","notifications_url":"https://api.github.com/repos/minrk/jupyter_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minrk/jupyter_core/labels{/name}","releases_url":"https://api.github.com/repos/minrk/jupyter_core/releases{/id}","created_at":"2015-04-09T08:27:52Z","updated_at":"2015-04-09T08:27:56Z","pushed_at":"2015-05-26T20:24:40Z","git_url":"git://github.com/minrk/jupyter_core.git","ssh_url":"git@github.com:minrk/jupyter_core.git","clone_url":"https://github.com/minrk/jupyter_core.git","svn_url":"https://github.com/minrk/jupyter_core","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"cb725125a9de49351f013dd43a36838f5395d519","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":32897150,"name":"jupyter_core","full_name":"jupyter/jupyter_core","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars.githubusercontent.com/u/7388996?v=3","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/jupyter_core","description":"Core Jupyter functionality","fork":false,"url":"https://api.github.com/repos/jupyter/jupyter_core","forks_url":"https://api.github.com/repos/jupyter/jupyter_core/forks","keys_url":"https://api.github.com/repos/jupyter/jupyter_core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/jupyter_core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/jupyter_core/teams","hooks_url":"https://api.github.com/repos/jupyter/jupyter_core/hooks","issue_events_url":"https://api.github.com/repos/jupyter/jupyter_core/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/jupyter_core/events","assignees_url":"https://api.github.com/repos/jupyter/jupyter_core/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/jupyter_core/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/jupyter_core/tags","blobs_url":"https://api.github.com/repos/jupyter/jupyter_core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/jupyter_core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/jupyter_core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/jupyter_core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/jupyter_core/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/jupyter_core/languages","stargazers_url":"https://api.github.com/repos/jupyter/jupyter_core/stargazers","contributors_url":"https://api.github.com/repos/jupyter/jupyter_core/contributors","subscribers_url":"https://api.github.com/repos/jupyter/jupyter_core/subscribers","subscription_url":"https://api.github.com/repos/jupyter/jupyter_core/subscription","commits_url":"https://api.github.com/repos/jupyter/jupyter_core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/jupyter_core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/jupyter_core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/jupyter_core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/jupyter_core/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/jupyter_core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/jupyter_core/merges","archive_url":"https://api.github.com/repos/jupyter/jupyter_core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/jupyter_core/downloads","issues_url":"https://api.github.com/repos/jupyter/jupyter_core/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/jupyter_core/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/jupyter_core/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/jupyter_core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/jupyter_core/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/jupyter_core/releases{/id}","created_at":"2015-03-25T23:35:43Z","updated_at":"2015-05-08T06:13:05Z","pushed_at":"2015-05-26T20:25:57Z","git_url":"git://github.com/jupyter/jupyter_core.git","ssh_url":"git@github.com:jupyter/jupyter_core.git","clone_url":"https://github.com/jupyter/jupyter_core.git","svn_url":"https://github.com/jupyter/jupyter_core","homepage":null,"size":435,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":5,"forks":11,"open_issues":5,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13"},"html":{"href":"https://github.com/jupyter/jupyter_core/pull/13"},"issue":{"href":"https://api.github.com/repos/jupyter/jupyter_core/issues/13"},"comments":{"href":"https://api.github.com/repos/jupyter/jupyter_core/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/jupyter_core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/jupyter_core/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/jupyter_core/statuses/87f28f41645c03dac206743bb36bea845b6566d8"}}}}