{"action":"created","comment":{"url":"https://api.github.com/repos/Horusiath/akka.net/pulls/comments/30628824","id":30628824,"diff_hunk":"@@ -12,129 +12,135 @@ open Microsoft.FSharp.Quotations\n open Microsoft.FSharp.Linq.QuotationEvaluation\n \n [<RequireQualifiedAccess>]\n-module Configuration = \n+module Configuration =\n     /// Parses provided HOCON string into a valid Akka configuration object.\n     let parse = Akka.Configuration.ConfigurationFactory.ParseString\n-    \n+\n     /// Returns default Akka configuration.\n     let defaultConfig = Akka.Configuration.ConfigurationFactory.Default\n-    \n+\n     /// Loads Akka configuration from the project's .config file.\n     let load = Akka.Configuration.ConfigurationFactory.Load\n \n-module System = \n+module System =\n     /// Creates an actor system with remote deployment serialization enabled.\n-    let create (name : string) (config : Akka.Configuration.Config) : ActorSystem = \n+    let create (name : string) (config : Akka.Configuration.Config) : ActorSystem =\n         let system = ActorSystem.Create(name, config)\n         Serialization.exprSerializationSupport system\n         system\n \n [<AutoOpen>]\n-module Spawn = \n-    type SpawnOption = \n+module Spawn =\n+    type SpawnOption =\n         | Deploy of Deploy\n         | Router of Akka.Routing.RouterConfig\n         | SupervisorStrategy of SupervisorStrategy\n         | Dispatcher of string\n         | Mailbox of string\n-    \n-    let rec applySpawnOptions (props : Props) (opt : SpawnOption list) : Props = \n+\n+    let rec applySpawnOptions opt (props : Props) =","path":"src/core/Akka.FSharp/Spawning.fs","position":39,"original_position":39,"commit_id":"12fe40ae06800a9643a3e1a797b37a748c3bb073","original_commit_id":"12fe40ae06800a9643a3e1a797b37a748c3bb073","user":{"login":"Horusiath","id":679705,"avatar_url":"https://avatars.githubusercontent.com/u/679705?v=3","gravatar_id":"","url":"https://api.github.com/users/Horusiath","html_url":"https://github.com/Horusiath","followers_url":"https://api.github.com/users/Horusiath/followers","following_url":"https://api.github.com/users/Horusiath/following{/other_user}","gists_url":"https://api.github.com/users/Horusiath/gists{/gist_id}","starred_url":"https://api.github.com/users/Horusiath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Horusiath/subscriptions","organizations_url":"https://api.github.com/users/Horusiath/orgs","repos_url":"https://api.github.com/users/Horusiath/repos","events_url":"https://api.github.com/users/Horusiath/events{/privacy}","received_events_url":"https://api.github.com/users/Horusiath/received_events","type":"User","site_admin":false},"body":"While this is not a big thing, it's still breaking the existing API.","created_at":"2015-05-19T18:12:54Z","updated_at":"2015-05-19T18:12:54Z","html_url":"https://github.com/Horusiath/akka.net/pull/1#discussion_r30628824","pull_request_url":"https://api.github.com/repos/Horusiath/akka.net/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/Horusiath/akka.net/pulls/comments/30628824"},"html":{"href":"https://github.com/Horusiath/akka.net/pull/1#discussion_r30628824"},"pull_request":{"href":"https://api.github.com/repos/Horusiath/akka.net/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/Horusiath/akka.net/pulls/1","id":35730646,"html_url":"https://github.com/Horusiath/akka.net/pull/1","diff_url":"https://github.com/Horusiath/akka.net/pull/1.diff","patch_url":"https://github.com/Horusiath/akka.net/pull/1.patch","issue_url":"https://api.github.com/repos/Horusiath/akka.net/issues/1","number":1,"state":"open","locked":false,"title":"Miscellaneous minor refactorings on the FSharp API","user":{"login":"neoeinstein","id":18165,"avatar_url":"https://avatars.githubusercontent.com/u/18165?v=3","gravatar_id":"","url":"https://api.github.com/users/neoeinstein","html_url":"https://github.com/neoeinstein","followers_url":"https://api.github.com/users/neoeinstein/followers","following_url":"https://api.github.com/users/neoeinstein/following{/other_user}","gists_url":"https://api.github.com/users/neoeinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/neoeinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoeinstein/subscriptions","organizations_url":"https://api.github.com/users/neoeinstein/orgs","repos_url":"https://api.github.com/users/neoeinstein/repos","events_url":"https://api.github.com/users/neoeinstein/events{/privacy}","received_events_url":"https://api.github.com/users/neoeinstein/received_events","type":"User","site_admin":false},"body":"I figure a directed pull request to you would be better since I don't expect this to actually be merged as is. It does have some of my thoughts on rewriting some of the API internals and reordering things to take advantage of the functional composition. Let me know what you think, what you do/don't like, and I can fix this up a bit.\r\n\r\nAlso, I was wondering a bit why akka.net uses such heavy type annotations in the definitions. As part of the clean up, I think that we could benefit from removing those that the F# compiler is able to easily imply.","created_at":"2015-05-19T13:36:44Z","updated_at":"2015-05-19T18:12:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dde871a311bc3f4aebe35d450a6e090948a233c","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Horusiath/akka.net/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Horusiath/akka.net/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Horusiath/akka.net/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Horusiath/akka.net/issues/1/comments","statuses_url":"https://api.github.com/repos/Horusiath/akka.net/statuses/12fe40ae06800a9643a3e1a797b37a748c3bb073","head":{"label":"neoeinstein:fsapi-spawn-refactor","ref":"fsapi-spawn-refactor","sha":"12fe40ae06800a9643a3e1a797b37a748c3bb073","user":{"login":"neoeinstein","id":18165,"avatar_url":"https://avatars.githubusercontent.com/u/18165?v=3","gravatar_id":"","url":"https://api.github.com/users/neoeinstein","html_url":"https://github.com/neoeinstein","followers_url":"https://api.github.com/users/neoeinstein/followers","following_url":"https://api.github.com/users/neoeinstein/following{/other_user}","gists_url":"https://api.github.com/users/neoeinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/neoeinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoeinstein/subscriptions","organizations_url":"https://api.github.com/users/neoeinstein/orgs","repos_url":"https://api.github.com/users/neoeinstein/repos","events_url":"https://api.github.com/users/neoeinstein/events{/privacy}","received_events_url":"https://api.github.com/users/neoeinstein/received_events","type":"User","site_admin":false},"repo":{"id":35747521,"name":"akka.net","full_name":"neoeinstein/akka.net","owner":{"login":"neoeinstein","id":18165,"avatar_url":"https://avatars.githubusercontent.com/u/18165?v=3","gravatar_id":"","url":"https://api.github.com/users/neoeinstein","html_url":"https://github.com/neoeinstein","followers_url":"https://api.github.com/users/neoeinstein/followers","following_url":"https://api.github.com/users/neoeinstein/following{/other_user}","gists_url":"https://api.github.com/users/neoeinstein/gists{/gist_id}","starred_url":"https://api.github.com/users/neoeinstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neoeinstein/subscriptions","organizations_url":"https://api.github.com/users/neoeinstein/orgs","repos_url":"https://api.github.com/users/neoeinstein/repos","events_url":"https://api.github.com/users/neoeinstein/events{/privacy}","received_events_url":"https://api.github.com/users/neoeinstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neoeinstein/akka.net","description":"Port of Akka actors for .NET","fork":true,"url":"https://api.github.com/repos/neoeinstein/akka.net","forks_url":"https://api.github.com/repos/neoeinstein/akka.net/forks","keys_url":"https://api.github.com/repos/neoeinstein/akka.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neoeinstein/akka.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neoeinstein/akka.net/teams","hooks_url":"https://api.github.com/repos/neoeinstein/akka.net/hooks","issue_events_url":"https://api.github.com/repos/neoeinstein/akka.net/issues/events{/number}","events_url":"https://api.github.com/repos/neoeinstein/akka.net/events","assignees_url":"https://api.github.com/repos/neoeinstein/akka.net/assignees{/user}","branches_url":"https://api.github.com/repos/neoeinstein/akka.net/branches{/branch}","tags_url":"https://api.github.com/repos/neoeinstein/akka.net/tags","blobs_url":"https://api.github.com/repos/neoeinstein/akka.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neoeinstein/akka.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neoeinstein/akka.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/neoeinstein/akka.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neoeinstein/akka.net/statuses/{sha}","languages_url":"https://api.github.com/repos/neoeinstein/akka.net/languages","stargazers_url":"https://api.github.com/repos/neoeinstein/akka.net/stargazers","contributors_url":"https://api.github.com/repos/neoeinstein/akka.net/contributors","subscribers_url":"https://api.github.com/repos/neoeinstein/akka.net/subscribers","subscription_url":"https://api.github.com/repos/neoeinstein/akka.net/subscription","commits_url":"https://api.github.com/repos/neoeinstein/akka.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/neoeinstein/akka.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/neoeinstein/akka.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/neoeinstein/akka.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/neoeinstein/akka.net/contents/{+path}","compare_url":"https://api.github.com/repos/neoeinstein/akka.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neoeinstein/akka.net/merges","archive_url":"https://api.github.com/repos/neoeinstein/akka.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neoeinstein/akka.net/downloads","issues_url":"https://api.github.com/repos/neoeinstein/akka.net/issues{/number}","pulls_url":"https://api.github.com/repos/neoeinstein/akka.net/pulls{/number}","milestones_url":"https://api.github.com/repos/neoeinstein/akka.net/milestones{/number}","notifications_url":"https://api.github.com/repos/neoeinstein/akka.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neoeinstein/akka.net/labels{/name}","releases_url":"https://api.github.com/repos/neoeinstein/akka.net/releases{/id}","created_at":"2015-05-17T01:44:12Z","updated_at":"2015-05-17T01:44:16Z","pushed_at":"2015-05-19T01:26:21Z","git_url":"git://github.com/neoeinstein/akka.net.git","ssh_url":"git@github.com:neoeinstein/akka.net.git","clone_url":"https://github.com/neoeinstein/akka.net.git","svn_url":"https://github.com/neoeinstein/akka.net","homepage":"http://getakka.net","size":43899,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Horusiath:fsapi-typed-ref","ref":"fsapi-typed-ref","sha":"d48ae084a71004153fc76eb9b1d709c3b64f9f1a","user":{"login":"Horusiath","id":679705,"avatar_url":"https://avatars.githubusercontent.com/u/679705?v=3","gravatar_id":"","url":"https://api.github.com/users/Horusiath","html_url":"https://github.com/Horusiath","followers_url":"https://api.github.com/users/Horusiath/followers","following_url":"https://api.github.com/users/Horusiath/following{/other_user}","gists_url":"https://api.github.com/users/Horusiath/gists{/gist_id}","starred_url":"https://api.github.com/users/Horusiath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Horusiath/subscriptions","organizations_url":"https://api.github.com/users/Horusiath/orgs","repos_url":"https://api.github.com/users/Horusiath/repos","events_url":"https://api.github.com/users/Horusiath/events{/privacy}","received_events_url":"https://api.github.com/users/Horusiath/received_events","type":"User","site_admin":false},"repo":{"id":21521073,"name":"akka.net","full_name":"Horusiath/akka.net","owner":{"login":"Horusiath","id":679705,"avatar_url":"https://avatars.githubusercontent.com/u/679705?v=3","gravatar_id":"","url":"https://api.github.com/users/Horusiath","html_url":"https://github.com/Horusiath","followers_url":"https://api.github.com/users/Horusiath/followers","following_url":"https://api.github.com/users/Horusiath/following{/other_user}","gists_url":"https://api.github.com/users/Horusiath/gists{/gist_id}","starred_url":"https://api.github.com/users/Horusiath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Horusiath/subscriptions","organizations_url":"https://api.github.com/users/Horusiath/orgs","repos_url":"https://api.github.com/users/Horusiath/repos","events_url":"https://api.github.com/users/Horusiath/events{/privacy}","received_events_url":"https://api.github.com/users/Horusiath/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Horusiath/akka.net","description":"Port of Akka actors for .NET","fork":true,"url":"https://api.github.com/repos/Horusiath/akka.net","forks_url":"https://api.github.com/repos/Horusiath/akka.net/forks","keys_url":"https://api.github.com/repos/Horusiath/akka.net/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Horusiath/akka.net/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Horusiath/akka.net/teams","hooks_url":"https://api.github.com/repos/Horusiath/akka.net/hooks","issue_events_url":"https://api.github.com/repos/Horusiath/akka.net/issues/events{/number}","events_url":"https://api.github.com/repos/Horusiath/akka.net/events","assignees_url":"https://api.github.com/repos/Horusiath/akka.net/assignees{/user}","branches_url":"https://api.github.com/repos/Horusiath/akka.net/branches{/branch}","tags_url":"https://api.github.com/repos/Horusiath/akka.net/tags","blobs_url":"https://api.github.com/repos/Horusiath/akka.net/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Horusiath/akka.net/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Horusiath/akka.net/git/refs{/sha}","trees_url":"https://api.github.com/repos/Horusiath/akka.net/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Horusiath/akka.net/statuses/{sha}","languages_url":"https://api.github.com/repos/Horusiath/akka.net/languages","stargazers_url":"https://api.github.com/repos/Horusiath/akka.net/stargazers","contributors_url":"https://api.github.com/repos/Horusiath/akka.net/contributors","subscribers_url":"https://api.github.com/repos/Horusiath/akka.net/subscribers","subscription_url":"https://api.github.com/repos/Horusiath/akka.net/subscription","commits_url":"https://api.github.com/repos/Horusiath/akka.net/commits{/sha}","git_commits_url":"https://api.github.com/repos/Horusiath/akka.net/git/commits{/sha}","comments_url":"https://api.github.com/repos/Horusiath/akka.net/comments{/number}","issue_comment_url":"https://api.github.com/repos/Horusiath/akka.net/issues/comments{/number}","contents_url":"https://api.github.com/repos/Horusiath/akka.net/contents/{+path}","compare_url":"https://api.github.com/repos/Horusiath/akka.net/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Horusiath/akka.net/merges","archive_url":"https://api.github.com/repos/Horusiath/akka.net/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Horusiath/akka.net/downloads","issues_url":"https://api.github.com/repos/Horusiath/akka.net/issues{/number}","pulls_url":"https://api.github.com/repos/Horusiath/akka.net/pulls{/number}","milestones_url":"https://api.github.com/repos/Horusiath/akka.net/milestones{/number}","notifications_url":"https://api.github.com/repos/Horusiath/akka.net/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Horusiath/akka.net/labels{/name}","releases_url":"https://api.github.com/repos/Horusiath/akka.net/releases{/id}","created_at":"2014-07-05T13:59:08Z","updated_at":"2015-03-10T21:39:36Z","pushed_at":"2015-05-19T13:36:44Z","git_url":"git://github.com/Horusiath/akka.net.git","ssh_url":"git@github.com:Horusiath/akka.net.git","clone_url":"https://github.com/Horusiath/akka.net.git","svn_url":"https://github.com/Horusiath/akka.net","homepage":"","size":44551,"stargazers_count":2,"watchers_count":2,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Horusiath/akka.net/pulls/1"},"html":{"href":"https://github.com/Horusiath/akka.net/pull/1"},"issue":{"href":"https://api.github.com/repos/Horusiath/akka.net/issues/1"},"comments":{"href":"https://api.github.com/repos/Horusiath/akka.net/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Horusiath/akka.net/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Horusiath/akka.net/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Horusiath/akka.net/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Horusiath/akka.net/statuses/12fe40ae06800a9643a3e1a797b37a748c3bb073"}}}}