{"action":"created","comment":{"url":"https://api.github.com/repos/tfausak/strive/pulls/comments/28960126","id":28960126,"diff_hunk":"@@ -26,13 +27,12 @@ instance Default BuildAuthorizeUrlOptions where\n     }\n \n instance QueryLike BuildAuthorizeUrlOptions where\n-  toQuery options = toQuery\n+  toQuery options = toQuery $\n     [ (\"approval_prompt\", unpack (toStrict (encode (buildAuthorizeUrlOptions_approvalPrompt options))))\n-    , (\"scope\", scopes)\n     , (\"state\", buildAuthorizeUrlOptions_state options)\n-    ]\n+    ] ++\n+    [ (\"scope\", intercalate \",\" scopes) | not (null scopes) ]","path":"library/Strive/Options/Authentication.hs","position":19,"original_position":19,"commit_id":"84387f1fdfba41ca7a47c2e68ba32b6e2d340fa6","original_commit_id":"84387f1fdfba41ca7a47c2e68ba32b6e2d340fa6","user":{"login":"liskin","id":300342,"avatar_url":"https://avatars.githubusercontent.com/u/300342?v=3","gravatar_id":"","url":"https://api.github.com/users/liskin","html_url":"https://github.com/liskin","followers_url":"https://api.github.com/users/liskin/followers","following_url":"https://api.github.com/users/liskin/following{/other_user}","gists_url":"https://api.github.com/users/liskin/gists{/gist_id}","starred_url":"https://api.github.com/users/liskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liskin/subscriptions","organizations_url":"https://api.github.com/users/liskin/orgs","repos_url":"https://api.github.com/users/liskin/repos","events_url":"https://api.github.com/users/liskin/events{/privacy}","received_events_url":"https://api.github.com/users/liskin/received_events","type":"User","site_admin":false},"body":"It's not ok, I tried. :-) \nDne 23. 4. 2015 14:53 napsal uživatel Taylor Fausak <notifications@github.com>:In library/Strive/Options/Authentication.hs:\r\n>      , (\"state\", buildAuthorizeUrlOptions_state options)\r\n> -    ]\r\n> +    ] ++\r\n> +    [ (\"scope\", intercalate \",\" scopes) | not (null scopes) ]\r\n\r\nI think it is fine to always include the \"scope\" parameter, even when it is empty. Does the Strava API treat an empty string different than null? The documentation only says: \"leave blank for read-only permissions\". \r\n\r\n—Reply to this email directly or view it on GitHub.","created_at":"2015-04-23T13:09:33Z","updated_at":"2015-04-23T13:09:33Z","html_url":"https://github.com/tfausak/strive/pull/97#discussion_r28960126","pull_request_url":"https://api.github.com/repos/tfausak/strive/pulls/97","_links":{"self":{"href":"https://api.github.com/repos/tfausak/strive/pulls/comments/28960126"},"html":{"href":"https://github.com/tfausak/strive/pull/97#discussion_r28960126"},"pull_request":{"href":"https://api.github.com/repos/tfausak/strive/pulls/97"}}},"pull_request":{"url":"https://api.github.com/repos/tfausak/strive/pulls/97","id":33934935,"html_url":"https://github.com/tfausak/strive/pull/97","diff_url":"https://github.com/tfausak/strive/pull/97.diff","patch_url":"https://github.com/tfausak/strive/pull/97.patch","issue_url":"https://api.github.com/repos/tfausak/strive/issues/97","number":97,"state":"open","locked":false,"title":"Fix OAuth scope","user":{"login":"liskin","id":300342,"avatar_url":"https://avatars.githubusercontent.com/u/300342?v=3","gravatar_id":"","url":"https://api.github.com/users/liskin","html_url":"https://github.com/liskin","followers_url":"https://api.github.com/users/liskin/followers","following_url":"https://api.github.com/users/liskin/following{/other_user}","gists_url":"https://api.github.com/users/liskin/gists{/gist_id}","starred_url":"https://api.github.com/users/liskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liskin/subscriptions","organizations_url":"https://api.github.com/users/liskin/orgs","repos_url":"https://api.github.com/users/liskin/repos","events_url":"https://api.github.com/users/liskin/events{/privacy}","received_events_url":"https://api.github.com/users/liskin/received_events","type":"User","site_admin":false},"body":null,"created_at":"2015-04-23T08:46:51Z","updated_at":"2015-04-23T13:09:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c9c1c3830fdb78b6e568568b3e27b974592069f","assignee":{"login":"tfausak","id":408753,"avatar_url":"https://avatars.githubusercontent.com/u/408753?v=3","gravatar_id":"","url":"https://api.github.com/users/tfausak","html_url":"https://github.com/tfausak","followers_url":"https://api.github.com/users/tfausak/followers","following_url":"https://api.github.com/users/tfausak/following{/other_user}","gists_url":"https://api.github.com/users/tfausak/gists{/gist_id}","starred_url":"https://api.github.com/users/tfausak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfausak/subscriptions","organizations_url":"https://api.github.com/users/tfausak/orgs","repos_url":"https://api.github.com/users/tfausak/repos","events_url":"https://api.github.com/users/tfausak/events{/privacy}","received_events_url":"https://api.github.com/users/tfausak/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/tfausak/strive/pulls/97/commits","review_comments_url":"https://api.github.com/repos/tfausak/strive/pulls/97/comments","review_comment_url":"https://api.github.com/repos/tfausak/strive/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tfausak/strive/issues/97/comments","statuses_url":"https://api.github.com/repos/tfausak/strive/statuses/84387f1fdfba41ca7a47c2e68ba32b6e2d340fa6","head":{"label":"liskin:master","ref":"master","sha":"84387f1fdfba41ca7a47c2e68ba32b6e2d340fa6","user":{"login":"liskin","id":300342,"avatar_url":"https://avatars.githubusercontent.com/u/300342?v=3","gravatar_id":"","url":"https://api.github.com/users/liskin","html_url":"https://github.com/liskin","followers_url":"https://api.github.com/users/liskin/followers","following_url":"https://api.github.com/users/liskin/following{/other_user}","gists_url":"https://api.github.com/users/liskin/gists{/gist_id}","starred_url":"https://api.github.com/users/liskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liskin/subscriptions","organizations_url":"https://api.github.com/users/liskin/orgs","repos_url":"https://api.github.com/users/liskin/repos","events_url":"https://api.github.com/users/liskin/events{/privacy}","received_events_url":"https://api.github.com/users/liskin/received_events","type":"User","site_admin":false},"repo":{"id":31506692,"name":"strive","full_name":"liskin/strive","owner":{"login":"liskin","id":300342,"avatar_url":"https://avatars.githubusercontent.com/u/300342?v=3","gravatar_id":"","url":"https://api.github.com/users/liskin","html_url":"https://github.com/liskin","followers_url":"https://api.github.com/users/liskin/followers","following_url":"https://api.github.com/users/liskin/following{/other_user}","gists_url":"https://api.github.com/users/liskin/gists{/gist_id}","starred_url":"https://api.github.com/users/liskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liskin/subscriptions","organizations_url":"https://api.github.com/users/liskin/orgs","repos_url":"https://api.github.com/users/liskin/repos","events_url":"https://api.github.com/users/liskin/events{/privacy}","received_events_url":"https://api.github.com/users/liskin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/liskin/strive","description":"A Haskell client for the Strava V3 API.","fork":true,"url":"https://api.github.com/repos/liskin/strive","forks_url":"https://api.github.com/repos/liskin/strive/forks","keys_url":"https://api.github.com/repos/liskin/strive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liskin/strive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liskin/strive/teams","hooks_url":"https://api.github.com/repos/liskin/strive/hooks","issue_events_url":"https://api.github.com/repos/liskin/strive/issues/events{/number}","events_url":"https://api.github.com/repos/liskin/strive/events","assignees_url":"https://api.github.com/repos/liskin/strive/assignees{/user}","branches_url":"https://api.github.com/repos/liskin/strive/branches{/branch}","tags_url":"https://api.github.com/repos/liskin/strive/tags","blobs_url":"https://api.github.com/repos/liskin/strive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liskin/strive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liskin/strive/git/refs{/sha}","trees_url":"https://api.github.com/repos/liskin/strive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liskin/strive/statuses/{sha}","languages_url":"https://api.github.com/repos/liskin/strive/languages","stargazers_url":"https://api.github.com/repos/liskin/strive/stargazers","contributors_url":"https://api.github.com/repos/liskin/strive/contributors","subscribers_url":"https://api.github.com/repos/liskin/strive/subscribers","subscription_url":"https://api.github.com/repos/liskin/strive/subscription","commits_url":"https://api.github.com/repos/liskin/strive/commits{/sha}","git_commits_url":"https://api.github.com/repos/liskin/strive/git/commits{/sha}","comments_url":"https://api.github.com/repos/liskin/strive/comments{/number}","issue_comment_url":"https://api.github.com/repos/liskin/strive/issues/comments{/number}","contents_url":"https://api.github.com/repos/liskin/strive/contents/{+path}","compare_url":"https://api.github.com/repos/liskin/strive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liskin/strive/merges","archive_url":"https://api.github.com/repos/liskin/strive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liskin/strive/downloads","issues_url":"https://api.github.com/repos/liskin/strive/issues{/number}","pulls_url":"https://api.github.com/repos/liskin/strive/pulls{/number}","milestones_url":"https://api.github.com/repos/liskin/strive/milestones{/number}","notifications_url":"https://api.github.com/repos/liskin/strive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liskin/strive/labels{/name}","releases_url":"https://api.github.com/repos/liskin/strive/releases{/id}","created_at":"2015-03-01T18:52:05Z","updated_at":"2015-04-23T08:46:02Z","pushed_at":"2015-04-23T08:46:01Z","git_url":"git://github.com/liskin/strive.git","ssh_url":"git@github.com:liskin/strive.git","clone_url":"https://github.com/liskin/strive.git","svn_url":"https://github.com/liskin/strive","homepage":"http://taylor.fausak.me/strive/","size":1068,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tfausak:master","ref":"master","sha":"b7547f7a97d02a7f949b814a50883550264cdaf2","user":{"login":"tfausak","id":408753,"avatar_url":"https://avatars.githubusercontent.com/u/408753?v=3","gravatar_id":"","url":"https://api.github.com/users/tfausak","html_url":"https://github.com/tfausak","followers_url":"https://api.github.com/users/tfausak/followers","following_url":"https://api.github.com/users/tfausak/following{/other_user}","gists_url":"https://api.github.com/users/tfausak/gists{/gist_id}","starred_url":"https://api.github.com/users/tfausak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfausak/subscriptions","organizations_url":"https://api.github.com/users/tfausak/orgs","repos_url":"https://api.github.com/users/tfausak/repos","events_url":"https://api.github.com/users/tfausak/events{/privacy}","received_events_url":"https://api.github.com/users/tfausak/received_events","type":"User","site_admin":false},"repo":{"id":21144719,"name":"strive","full_name":"tfausak/strive","owner":{"login":"tfausak","id":408753,"avatar_url":"https://avatars.githubusercontent.com/u/408753?v=3","gravatar_id":"","url":"https://api.github.com/users/tfausak","html_url":"https://github.com/tfausak","followers_url":"https://api.github.com/users/tfausak/followers","following_url":"https://api.github.com/users/tfausak/following{/other_user}","gists_url":"https://api.github.com/users/tfausak/gists{/gist_id}","starred_url":"https://api.github.com/users/tfausak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfausak/subscriptions","organizations_url":"https://api.github.com/users/tfausak/orgs","repos_url":"https://api.github.com/users/tfausak/repos","events_url":"https://api.github.com/users/tfausak/events{/privacy}","received_events_url":"https://api.github.com/users/tfausak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tfausak/strive","description":"A Haskell client for the Strava V3 API.","fork":false,"url":"https://api.github.com/repos/tfausak/strive","forks_url":"https://api.github.com/repos/tfausak/strive/forks","keys_url":"https://api.github.com/repos/tfausak/strive/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tfausak/strive/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tfausak/strive/teams","hooks_url":"https://api.github.com/repos/tfausak/strive/hooks","issue_events_url":"https://api.github.com/repos/tfausak/strive/issues/events{/number}","events_url":"https://api.github.com/repos/tfausak/strive/events","assignees_url":"https://api.github.com/repos/tfausak/strive/assignees{/user}","branches_url":"https://api.github.com/repos/tfausak/strive/branches{/branch}","tags_url":"https://api.github.com/repos/tfausak/strive/tags","blobs_url":"https://api.github.com/repos/tfausak/strive/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tfausak/strive/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tfausak/strive/git/refs{/sha}","trees_url":"https://api.github.com/repos/tfausak/strive/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tfausak/strive/statuses/{sha}","languages_url":"https://api.github.com/repos/tfausak/strive/languages","stargazers_url":"https://api.github.com/repos/tfausak/strive/stargazers","contributors_url":"https://api.github.com/repos/tfausak/strive/contributors","subscribers_url":"https://api.github.com/repos/tfausak/strive/subscribers","subscription_url":"https://api.github.com/repos/tfausak/strive/subscription","commits_url":"https://api.github.com/repos/tfausak/strive/commits{/sha}","git_commits_url":"https://api.github.com/repos/tfausak/strive/git/commits{/sha}","comments_url":"https://api.github.com/repos/tfausak/strive/comments{/number}","issue_comment_url":"https://api.github.com/repos/tfausak/strive/issues/comments{/number}","contents_url":"https://api.github.com/repos/tfausak/strive/contents/{+path}","compare_url":"https://api.github.com/repos/tfausak/strive/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tfausak/strive/merges","archive_url":"https://api.github.com/repos/tfausak/strive/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tfausak/strive/downloads","issues_url":"https://api.github.com/repos/tfausak/strive/issues{/number}","pulls_url":"https://api.github.com/repos/tfausak/strive/pulls{/number}","milestones_url":"https://api.github.com/repos/tfausak/strive/milestones{/number}","notifications_url":"https://api.github.com/repos/tfausak/strive/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tfausak/strive/labels{/name}","releases_url":"https://api.github.com/repos/tfausak/strive/releases{/id}","created_at":"2014-06-23T22:39:13Z","updated_at":"2015-04-06T01:10:20Z","pushed_at":"2015-04-23T08:46:51Z","git_url":"git://github.com/tfausak/strive.git","ssh_url":"git@github.com:tfausak/strive.git","clone_url":"https://github.com/tfausak/strive.git","svn_url":"https://github.com/tfausak/strive","homepage":"http://taylor.fausak.me/strive/","size":1841,"stargazers_count":12,"watchers_count":12,"language":"Haskell","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tfausak/strive/pulls/97"},"html":{"href":"https://github.com/tfausak/strive/pull/97"},"issue":{"href":"https://api.github.com/repos/tfausak/strive/issues/97"},"comments":{"href":"https://api.github.com/repos/tfausak/strive/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/tfausak/strive/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/tfausak/strive/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tfausak/strive/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/tfausak/strive/statuses/84387f1fdfba41ca7a47c2e68ba32b6e2d340fa6"}}}}