{"action":"created","issue":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2331","labels_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2331/labels{/name}","comments_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2331/comments","events_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2331/events","html_url":"https://github.com/WhisperSystems/TextSecure/pull/2331","id":54119288,"number":2331,"title":"End the reign of RoutingActivity","user":{"login":"mcginty","id":373823,"avatar_url":"https://avatars.githubusercontent.com/u/373823?v=3","gravatar_id":"","url":"https://api.github.com/users/mcginty","html_url":"https://github.com/mcginty","followers_url":"https://api.github.com/users/mcginty/followers","following_url":"https://api.github.com/users/mcginty/following{/other_user}","gists_url":"https://api.github.com/users/mcginty/gists{/gist_id}","starred_url":"https://api.github.com/users/mcginty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcginty/subscriptions","organizations_url":"https://api.github.com/users/mcginty/orgs","repos_url":"https://api.github.com/users/mcginty/repos","events_url":"https://api.github.com/users/mcginty/events{/privacy}","received_events_url":"https://api.github.com/users/mcginty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"moxie0","id":512439,"avatar_url":"https://avatars.githubusercontent.com/u/512439?v=3","gravatar_id":"","url":"https://api.github.com/users/moxie0","html_url":"https://github.com/moxie0","followers_url":"https://api.github.com/users/moxie0/followers","following_url":"https://api.github.com/users/moxie0/following{/other_user}","gists_url":"https://api.github.com/users/moxie0/gists{/gist_id}","starred_url":"https://api.github.com/users/moxie0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/moxie0/subscriptions","organizations_url":"https://api.github.com/users/moxie0/orgs","repos_url":"https://api.github.com/users/moxie0/repos","events_url":"https://api.github.com/users/moxie0/events{/privacy}","received_events_url":"https://api.github.com/users/moxie0/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/milestones/8","html_url":"https://github.com/WhisperSystems/TextSecure/milestones/2.9.0","labels_url":"https://api.github.com/repos/WhisperSystems/TextSecure/milestones/8/labels","id":1029978,"number":8,"title":"2.9.0","description":"","creator":{"login":"mcginty","id":373823,"avatar_url":"https://avatars.githubusercontent.com/u/373823?v=3","gravatar_id":"","url":"https://api.github.com/users/mcginty","html_url":"https://github.com/mcginty","followers_url":"https://api.github.com/users/mcginty/followers","following_url":"https://api.github.com/users/mcginty/following{/other_user}","gists_url":"https://api.github.com/users/mcginty/gists{/gist_id}","starred_url":"https://api.github.com/users/mcginty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcginty/subscriptions","organizations_url":"https://api.github.com/users/mcginty/orgs","repos_url":"https://api.github.com/users/mcginty/repos","events_url":"https://api.github.com/users/mcginty/events{/privacy}","received_events_url":"https://api.github.com/users/mcginty/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2015-03-19T20:35:02Z","updated_at":"2015-03-24T00:54:17Z","due_on":null,"closed_at":null},"comments":7,"created_at":"2015-01-12T22:53:58Z","updated_at":"2015-03-24T18:56:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/pulls/2331","html_url":"https://github.com/WhisperSystems/TextSecure/pull/2331","diff_url":"https://github.com/WhisperSystems/TextSecure/pull/2331.diff","patch_url":"https://github.com/WhisperSystems/TextSecure/pull/2331.patch"},"body":"### `Intent` logic\r\n* Move routing logic to `PassphraseRequiredActionBarActivity` which routes based on application state just as `RoutingActivity` once did in days of olde.\r\n* Children activities now implement `onCreate(Bundle bundle, MasterSecret masterSecret)`, which is only called if we don't have to route elsewhere.\r\n* ShareActivity now handles `SEND` intents\r\n* ConversationListActivity is now the launcher entry-point\r\n* ConversationActivity handles SMS `SENDTO` intents\r\n\r\n### `MasterSecret`\r\n* `MasterSecret`s are initialized in `PassphraseRequiredActionBarActivity`, and accessed via protected getter instead of being passed inter-Activity via parceled secrets. This means one MasterSecret object per activity that is cleared `onDestroy()`, so less chance of leak since fewer copies are made.\r\n* `MemoryCleaner`'s code was commented out, so just removed for now.\r\n\r\nCan't reproduce #2239 on this.\r\n\r\n389-line net :small_red_triangle_down:!"},"comment":{"url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/comments/85642182","html_url":"https://github.com/WhisperSystems/TextSecure/pull/2331#issuecomment-85642182","issue_url":"https://api.github.com/repos/WhisperSystems/TextSecure/issues/2331","id":85642182,"user":{"login":"mcginty","id":373823,"avatar_url":"https://avatars.githubusercontent.com/u/373823?v=3","gravatar_id":"","url":"https://api.github.com/users/mcginty","html_url":"https://github.com/mcginty","followers_url":"https://api.github.com/users/mcginty/followers","following_url":"https://api.github.com/users/mcginty/following{/other_user}","gists_url":"https://api.github.com/users/mcginty/gists{/gist_id}","starred_url":"https://api.github.com/users/mcginty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcginty/subscriptions","organizations_url":"https://api.github.com/users/mcginty/orgs","repos_url":"https://api.github.com/users/mcginty/repos","events_url":"https://api.github.com/users/mcginty/events{/privacy}","received_events_url":"https://api.github.com/users/mcginty/received_events","type":"User","site_admin":false},"created_at":"2015-03-24T18:56:05Z","updated_at":"2015-03-24T18:56:05Z","body":"@McLoo i know, I'm still making changes. Accidentally pushed WIP (will just revert for now so as not to mislead)."}}