{"action":"closed","number":1318,"pull_request":{"url":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/1318","id":34904312,"html_url":"https://github.com/cocos2d/cocos2d-objc/pull/1318","diff_url":"https://github.com/cocos2d/cocos2d-objc/pull/1318.diff","patch_url":"https://github.com/cocos2d/cocos2d-objc/pull/1318.patch","issue_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues/1318","number":1318,"state":"closed","locked":false,"title":"Fixing the color space lookup for initWithUIColor","user":{"login":"richardgroves","id":715058,"avatar_url":"https://avatars.githubusercontent.com/u/715058?v=3","gravatar_id":"","url":"https://api.github.com/users/richardgroves","html_url":"https://github.com/richardgroves","followers_url":"https://api.github.com/users/richardgroves/followers","following_url":"https://api.github.com/users/richardgroves/following{/other_user}","gists_url":"https://api.github.com/users/richardgroves/gists{/gist_id}","starred_url":"https://api.github.com/users/richardgroves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardgroves/subscriptions","organizations_url":"https://api.github.com/users/richardgroves/orgs","repos_url":"https://api.github.com/users/richardgroves/repos","events_url":"https://api.github.com/users/richardgroves/events{/privacy}","received_events_url":"https://api.github.com/users/richardgroves/received_events","type":"User","site_admin":false},"body":"CCColor initWithUIColor was using self.GCColor to work out the color space to use rather than the passed in color. Self at this point is un-initialised so wouldn't be giving good information and since change addb32507676c47cfc1624d66ec44893c9d16cbd it breaks the further use of CGColor on the object as that will have been lazy allocated, probably to pure transparent black - 0/0/0/0.\r\n\r\nPrevious to that commit this method would have caused a leak of a CGColor object.","created_at":"2015-05-07T11:00:46Z","updated_at":"2015-05-07T11:07:10Z","closed_at":"2015-05-07T11:07:10Z","merged_at":"2015-05-07T11:07:10Z","merge_commit_sha":"c40a0e4e1ad1c66fbd528e3751c8e2c3c0f0a420","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/1318/commits","review_comments_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/1318/comments","review_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues/1318/comments","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/statuses/067bb4df3e759c1b097a1d58f49019a6dc379a24","head":{"label":"richardgroves:patch-1","ref":"patch-1","sha":"067bb4df3e759c1b097a1d58f49019a6dc379a24","user":{"login":"richardgroves","id":715058,"avatar_url":"https://avatars.githubusercontent.com/u/715058?v=3","gravatar_id":"","url":"https://api.github.com/users/richardgroves","html_url":"https://github.com/richardgroves","followers_url":"https://api.github.com/users/richardgroves/followers","following_url":"https://api.github.com/users/richardgroves/following{/other_user}","gists_url":"https://api.github.com/users/richardgroves/gists{/gist_id}","starred_url":"https://api.github.com/users/richardgroves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardgroves/subscriptions","organizations_url":"https://api.github.com/users/richardgroves/orgs","repos_url":"https://api.github.com/users/richardgroves/repos","events_url":"https://api.github.com/users/richardgroves/events{/privacy}","received_events_url":"https://api.github.com/users/richardgroves/received_events","type":"User","site_admin":false},"repo":{"id":22837786,"name":"cocos2d-iphone","full_name":"richardgroves/cocos2d-iphone","owner":{"login":"richardgroves","id":715058,"avatar_url":"https://avatars.githubusercontent.com/u/715058?v=3","gravatar_id":"","url":"https://api.github.com/users/richardgroves","html_url":"https://github.com/richardgroves","followers_url":"https://api.github.com/users/richardgroves/followers","following_url":"https://api.github.com/users/richardgroves/following{/other_user}","gists_url":"https://api.github.com/users/richardgroves/gists{/gist_id}","starred_url":"https://api.github.com/users/richardgroves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardgroves/subscriptions","organizations_url":"https://api.github.com/users/richardgroves/orgs","repos_url":"https://api.github.com/users/richardgroves/repos","events_url":"https://api.github.com/users/richardgroves/events{/privacy}","received_events_url":"https://api.github.com/users/richardgroves/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/richardgroves/cocos2d-iphone","description":"cocos2d for iOS and OS X, built using Objective-C","fork":true,"url":"https://api.github.com/repos/richardgroves/cocos2d-iphone","forks_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/forks","keys_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/teams","hooks_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/hooks","issue_events_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/issues/events{/number}","events_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/events","assignees_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/assignees{/user}","branches_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/branches{/branch}","tags_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/tags","blobs_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/statuses/{sha}","languages_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/languages","stargazers_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/stargazers","contributors_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/contributors","subscribers_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/subscribers","subscription_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/subscription","commits_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/contents/{+path}","compare_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/merges","archive_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/downloads","issues_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/issues{/number}","pulls_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/pulls{/number}","milestones_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/milestones{/number}","notifications_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/labels{/name}","releases_url":"https://api.github.com/repos/richardgroves/cocos2d-iphone/releases{/id}","created_at":"2014-08-11T12:11:45Z","updated_at":"2015-01-23T04:14:09Z","pushed_at":"2015-05-07T11:00:40Z","git_url":"git://github.com/richardgroves/cocos2d-iphone.git","ssh_url":"git@github.com:richardgroves/cocos2d-iphone.git","clone_url":"https://github.com/richardgroves/cocos2d-iphone.git","svn_url":"https://github.com/richardgroves/cocos2d-iphone","homepage":"http://www.cocos2d-iphone.org","size":39581,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v3.1"}},"base":{"label":"cocos2d:v3.4","ref":"v3.4","sha":"5697e5648d7bbff5390ac4379f90de418cea0b70","user":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"repo":{"id":588871,"name":"cocos2d-objc","full_name":"cocos2d/cocos2d-objc","owner":{"login":"cocos2d","id":234324,"avatar_url":"https://avatars.githubusercontent.com/u/234324?v=3","gravatar_id":"","url":"https://api.github.com/users/cocos2d","html_url":"https://github.com/cocos2d","followers_url":"https://api.github.com/users/cocos2d/followers","following_url":"https://api.github.com/users/cocos2d/following{/other_user}","gists_url":"https://api.github.com/users/cocos2d/gists{/gist_id}","starred_url":"https://api.github.com/users/cocos2d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cocos2d/subscriptions","organizations_url":"https://api.github.com/users/cocos2d/orgs","repos_url":"https://api.github.com/users/cocos2d/repos","events_url":"https://api.github.com/users/cocos2d/events{/privacy}","received_events_url":"https://api.github.com/users/cocos2d/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cocos2d/cocos2d-objc","description":"Cocos2d for iOS and OS X, built using Objective-C","fork":false,"url":"https://api.github.com/repos/cocos2d/cocos2d-objc","forks_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/forks","keys_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/teams","hooks_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/hooks","issue_events_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues/events{/number}","events_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/events","assignees_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/assignees{/user}","branches_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/branches{/branch}","tags_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/tags","blobs_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/statuses/{sha}","languages_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/languages","stargazers_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/stargazers","contributors_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/contributors","subscribers_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/subscribers","subscription_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/subscription","commits_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/contents/{+path}","compare_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/merges","archive_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/downloads","issues_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues{/number}","pulls_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls{/number}","milestones_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/milestones{/number}","notifications_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/labels{/name}","releases_url":"https://api.github.com/repos/cocos2d/cocos2d-objc/releases{/id}","created_at":"2010-03-31T19:07:59Z","updated_at":"2015-05-07T11:06:07Z","pushed_at":"2015-05-07T11:07:10Z","git_url":"git://github.com/cocos2d/cocos2d-objc.git","ssh_url":"git@github.com:cocos2d/cocos2d-objc.git","clone_url":"https://github.com/cocos2d/cocos2d-objc.git","svn_url":"https://github.com/cocos2d/cocos2d-objc","homepage":"http://www.cocos2d-objc.org","size":507461,"stargazers_count":3703,"watchers_count":3703,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1165,"mirror_url":null,"open_issues_count":225,"forks":1165,"open_issues":225,"watchers":3703,"default_branch":"v3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/1318"},"html":{"href":"https://github.com/cocos2d/cocos2d-objc/pull/1318"},"issue":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues/1318"},"comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/issues/1318/comments"},"review_comments":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/1318/comments"},"review_comment":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/pulls/1318/commits"},"statuses":{"href":"https://api.github.com/repos/cocos2d/cocos2d-objc/statuses/067bb4df3e759c1b097a1d58f49019a6dc379a24"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"Birkemose","id":844912,"avatar_url":"https://avatars.githubusercontent.com/u/844912?v=3","gravatar_id":"","url":"https://api.github.com/users/Birkemose","html_url":"https://github.com/Birkemose","followers_url":"https://api.github.com/users/Birkemose/followers","following_url":"https://api.github.com/users/Birkemose/following{/other_user}","gists_url":"https://api.github.com/users/Birkemose/gists{/gist_id}","starred_url":"https://api.github.com/users/Birkemose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Birkemose/subscriptions","organizations_url":"https://api.github.com/users/Birkemose/orgs","repos_url":"https://api.github.com/users/Birkemose/repos","events_url":"https://api.github.com/users/Birkemose/events{/privacy}","received_events_url":"https://api.github.com/users/Birkemose/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":1}}