{"action":"created","issue":{"url":"https://api.github.com/repos/pgte/nock/issues/408","labels_url":"https://api.github.com/repos/pgte/nock/issues/408/labels{/name}","comments_url":"https://api.github.com/repos/pgte/nock/issues/408/comments","events_url":"https://api.github.com/repos/pgte/nock/issues/408/events","html_url":"https://github.com/pgte/nock/issues/408","id":117438982,"number":408,"title":"Socket Hang Up Errors","user":{"login":"garrypolley","id":992175,"avatar_url":"https://avatars.githubusercontent.com/u/992175?v=3","gravatar_id":"","url":"https://api.github.com/users/garrypolley","html_url":"https://github.com/garrypolley","followers_url":"https://api.github.com/users/garrypolley/followers","following_url":"https://api.github.com/users/garrypolley/following{/other_user}","gists_url":"https://api.github.com/users/garrypolley/gists{/gist_id}","starred_url":"https://api.github.com/users/garrypolley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrypolley/subscriptions","organizations_url":"https://api.github.com/users/garrypolley/orgs","repos_url":"https://api.github.com/users/garrypolley/repos","events_url":"https://api.github.com/users/garrypolley/events{/privacy}","received_events_url":"https://api.github.com/users/garrypolley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/pgte/nock/labels/pending%20investigation","name":"pending investigation","color":"02d7e1"}],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-11-17T20:08:21Z","updated_at":"2015-11-25T09:09:29Z","closed_at":"2015-11-25T09:09:29Z","body":"I'm not sure exactly what is causing the error but I believe it is due to this commit: \r\n\r\nhttps://github.com/pgte/nock/commit/f9063fc593138204c6ba01e336095ba18c7b7458\r\n\r\nWith version `2.17.0` we have no issues with version `2.18.0` our HTTP requests are getting a `socket hang up` error. \r\n\r\nI think it's related to the conditional checking on the `http.ClientRequest` that was added to support borwserify. \r\n\r\nOur current solution is to lock to version `2.17.0`. The places where we are getting the socket hang up error do not use nock directly, but seem to be impacted by another set of tests that pull in the nock library. "},"comment":{"url":"https://api.github.com/repos/pgte/nock/issues/comments/159543048","html_url":"https://github.com/pgte/nock/issues/408#issuecomment-159543048","issue_url":"https://api.github.com/repos/pgte/nock/issues/408","id":159543048,"user":{"login":"pgte","id":47910,"avatar_url":"https://avatars.githubusercontent.com/u/47910?v=3","gravatar_id":"","url":"https://api.github.com/users/pgte","html_url":"https://github.com/pgte","followers_url":"https://api.github.com/users/pgte/followers","following_url":"https://api.github.com/users/pgte/following{/other_user}","gists_url":"https://api.github.com/users/pgte/gists{/gist_id}","starred_url":"https://api.github.com/users/pgte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgte/subscriptions","organizations_url":"https://api.github.com/users/pgte/orgs","repos_url":"https://api.github.com/users/pgte/repos","events_url":"https://api.github.com/users/pgte/events{/privacy}","received_events_url":"https://api.github.com/users/pgte/received_events","type":"User","site_admin":false},"created_at":"2015-11-25T09:09:29Z","updated_at":"2015-11-25T09:09:29Z","body":"@garrypolley Closing for now. Please reopen if you find the bug still occurring."}}