{"action":"created","comment":{"url":"https://api.github.com/repos/ros/geometry_experimental/pulls/comments/47990284","id":47990284,"diff_hunk":"@@ -1,54 +1,53 @@\n cmake_minimum_required(VERSION 2.8.3)\n project(tf2)\n \n-find_package(console_bridge REQUIRED)\n-find_package(catkin REQUIRED COMPONENTS geometry_msgs rostime tf2_msgs)\n-find_package(Boost REQUIRED COMPONENTS signals system thread)\n+if(NOT WIN32)\n+  add_definitions(-std=c++11)\n+endif()\n \n-catkin_package(\n-   INCLUDE_DIRS include\n-   LIBRARIES tf2 \n-   DEPENDS console_bridge\n-   CATKIN_DEPENDS geometry_msgs tf2_msgs rostime)\n+find_package(ament_cmake)\n+find_package(console_bridge REQUIRED)\n+find_package(geometry_msgs REQUIRED)\n \n-include_directories(include ${catkin_INCLUDE_DIRS} ${console_bridge_INCLUDE_DIRS})\n-include_directories (src/bt) \n+include_directories(include src/bt ${geometry_msgs_INCLUDE_DIRS} ${console_bridge_INCLUDE_DIRS})\n \n # export user definitions\n \n #CPP Libraries\n add_library(tf2 src/cache.cpp src/buffer_core.cpp src/static_cache.cpp)\n-target_link_libraries(tf2 ${Boost_LIBRARIES} ${catkin_LIBRARIES} ${console_bridge_LIBRARIES})\n-add_dependencies(tf2 tf2_msgs_gencpp)\n+target_link_libraries(tf2 ${geometry_msgs_LIBRARIES} ${console_bridge_LIBRARIES})\n \n install(TARGETS tf2\n-  ARCHIVE DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}\n-  LIBRARY DESTINATION ${CATKIN_PACKAGE_LIB_DESTINATION}\n-  RUNTIME DESTINATION ${CATKIN_PACKAGE_BIN_DESTINATION}\n+  ARCHIVE DESTINATION lib\n+  LIBRARY DESTINATION lib\n+  RUNTIME DESTINATION lib/${PROJECT_NAME}","path":"tf2/CMakeLists.txt","position":38,"original_position":38,"commit_id":"591eb428364296fad71391bc6f117cdfc116e2bf","original_commit_id":"591eb428364296fad71391bc6f117cdfc116e2bf","user":{"login":"tfoote","id":447804,"avatar_url":"https://avatars.githubusercontent.com/u/447804?v=3","gravatar_id":"","url":"https://api.github.com/users/tfoote","html_url":"https://github.com/tfoote","followers_url":"https://api.github.com/users/tfoote/followers","following_url":"https://api.github.com/users/tfoote/following{/other_user}","gists_url":"https://api.github.com/users/tfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoote/subscriptions","organizations_url":"https://api.github.com/users/tfoote/orgs","repos_url":"https://api.github.com/users/tfoote/repos","events_url":"https://api.github.com/users/tfoote/events{/privacy}","received_events_url":"https://api.github.com/users/tfoote/received_events","type":"User","site_admin":false},"body":"I've updated it in both packages and added it to my update of the migration guide. ","created_at":"2015-12-18T03:06:30Z","updated_at":"2015-12-18T03:06:30Z","html_url":"https://github.com/ros/geometry_experimental/pull/135#discussion_r47990284","pull_request_url":"https://api.github.com/repos/ros/geometry_experimental/pulls/135","_links":{"self":{"href":"https://api.github.com/repos/ros/geometry_experimental/pulls/comments/47990284"},"html":{"href":"https://github.com/ros/geometry_experimental/pull/135#discussion_r47990284"},"pull_request":{"href":"https://api.github.com/repos/ros/geometry_experimental/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/ros/geometry_experimental/pulls/135","id":53890234,"html_url":"https://github.com/ros/geometry_experimental/pull/135","diff_url":"https://github.com/ros/geometry_experimental/pull/135.diff","patch_url":"https://github.com/ros/geometry_experimental/pull/135.patch","issue_url":"https://api.github.com/repos/ros/geometry_experimental/issues/135","number":135,"state":"open","locked":false,"title":"Create a version of tf2 for ros2.","user":{"login":"tfoote","id":447804,"avatar_url":"https://avatars.githubusercontent.com/u/447804?v=3","gravatar_id":"","url":"https://api.github.com/users/tfoote","html_url":"https://github.com/tfoote","followers_url":"https://api.github.com/users/tfoote/followers","following_url":"https://api.github.com/users/tfoote/following{/other_user}","gists_url":"https://api.github.com/users/tfoote/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoote/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoote/subscriptions","organizations_url":"https://api.github.com/users/tfoote/orgs","repos_url":"https://api.github.com/users/tfoote/repos","events_url":"https://api.github.com/users/tfoote/events{/privacy}","received_events_url":"https://api.github.com/users/tfoote/received_events","type":"User","site_admin":false},"body":"It is tested up to static_transform_publisher and tf2_echo and tf2_monitor are working.","created_at":"2015-12-16T19:58:30Z","updated_at":"2015-12-18T03:06:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7dd3fd99637f7cd512e6b88a99eeb587b2ff5775","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ros/geometry_experimental/pulls/135/commits","review_comments_url":"https://api.github.com/repos/ros/geometry_experimental/pulls/135/comments","review_comment_url":"https://api.github.com/repos/ros/geometry_experimental/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/geometry_experimental/issues/135/comments","statuses_url":"https://api.github.com/repos/ros/geometry_experimental/statuses/591eb428364296fad71391bc6f117cdfc116e2bf","head":{"label":"ros:tf2_ament","ref":"tf2_ament","sha":"591eb428364296fad71391bc6f117cdfc116e2bf","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7449056,"name":"geometry_experimental","full_name":"ros/geometry_experimental","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/geometry_experimental","description":"Catkinized version of geometry-experimental","fork":false,"url":"https://api.github.com/repos/ros/geometry_experimental","forks_url":"https://api.github.com/repos/ros/geometry_experimental/forks","keys_url":"https://api.github.com/repos/ros/geometry_experimental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/geometry_experimental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/geometry_experimental/teams","hooks_url":"https://api.github.com/repos/ros/geometry_experimental/hooks","issue_events_url":"https://api.github.com/repos/ros/geometry_experimental/issues/events{/number}","events_url":"https://api.github.com/repos/ros/geometry_experimental/events","assignees_url":"https://api.github.com/repos/ros/geometry_experimental/assignees{/user}","branches_url":"https://api.github.com/repos/ros/geometry_experimental/branches{/branch}","tags_url":"https://api.github.com/repos/ros/geometry_experimental/tags","blobs_url":"https://api.github.com/repos/ros/geometry_experimental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/geometry_experimental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/geometry_experimental/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/geometry_experimental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/geometry_experimental/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/geometry_experimental/languages","stargazers_url":"https://api.github.com/repos/ros/geometry_experimental/stargazers","contributors_url":"https://api.github.com/repos/ros/geometry_experimental/contributors","subscribers_url":"https://api.github.com/repos/ros/geometry_experimental/subscribers","subscription_url":"https://api.github.com/repos/ros/geometry_experimental/subscription","commits_url":"https://api.github.com/repos/ros/geometry_experimental/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/geometry_experimental/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/geometry_experimental/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/geometry_experimental/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/geometry_experimental/contents/{+path}","compare_url":"https://api.github.com/repos/ros/geometry_experimental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/geometry_experimental/merges","archive_url":"https://api.github.com/repos/ros/geometry_experimental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/geometry_experimental/downloads","issues_url":"https://api.github.com/repos/ros/geometry_experimental/issues{/number}","pulls_url":"https://api.github.com/repos/ros/geometry_experimental/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/geometry_experimental/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/geometry_experimental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/geometry_experimental/labels{/name}","releases_url":"https://api.github.com/repos/ros/geometry_experimental/releases{/id}","created_at":"2013-01-04T23:33:06Z","updated_at":"2015-10-06T15:00:34Z","pushed_at":"2015-12-16T19:58:31Z","git_url":"git://github.com/ros/geometry_experimental.git","ssh_url":"git@github.com:ros/geometry_experimental.git","clone_url":"https://github.com/ros/geometry_experimental.git","svn_url":"https://github.com/ros/geometry_experimental","homepage":null,"size":3148,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":19,"forks":41,"open_issues":19,"watchers":8,"default_branch":"indigo-devel"}},"base":{"label":"ros:ros2_alpha","ref":"ros2_alpha","sha":"860b8667a9a880b8831e42cb260029a384c99a9a","user":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7449056,"name":"geometry_experimental","full_name":"ros/geometry_experimental","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars.githubusercontent.com/u/547448?v=3","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/geometry_experimental","description":"Catkinized version of geometry-experimental","fork":false,"url":"https://api.github.com/repos/ros/geometry_experimental","forks_url":"https://api.github.com/repos/ros/geometry_experimental/forks","keys_url":"https://api.github.com/repos/ros/geometry_experimental/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/geometry_experimental/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/geometry_experimental/teams","hooks_url":"https://api.github.com/repos/ros/geometry_experimental/hooks","issue_events_url":"https://api.github.com/repos/ros/geometry_experimental/issues/events{/number}","events_url":"https://api.github.com/repos/ros/geometry_experimental/events","assignees_url":"https://api.github.com/repos/ros/geometry_experimental/assignees{/user}","branches_url":"https://api.github.com/repos/ros/geometry_experimental/branches{/branch}","tags_url":"https://api.github.com/repos/ros/geometry_experimental/tags","blobs_url":"https://api.github.com/repos/ros/geometry_experimental/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/geometry_experimental/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/geometry_experimental/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/geometry_experimental/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/geometry_experimental/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/geometry_experimental/languages","stargazers_url":"https://api.github.com/repos/ros/geometry_experimental/stargazers","contributors_url":"https://api.github.com/repos/ros/geometry_experimental/contributors","subscribers_url":"https://api.github.com/repos/ros/geometry_experimental/subscribers","subscription_url":"https://api.github.com/repos/ros/geometry_experimental/subscription","commits_url":"https://api.github.com/repos/ros/geometry_experimental/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/geometry_experimental/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/geometry_experimental/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/geometry_experimental/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/geometry_experimental/contents/{+path}","compare_url":"https://api.github.com/repos/ros/geometry_experimental/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/geometry_experimental/merges","archive_url":"https://api.github.com/repos/ros/geometry_experimental/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/geometry_experimental/downloads","issues_url":"https://api.github.com/repos/ros/geometry_experimental/issues{/number}","pulls_url":"https://api.github.com/repos/ros/geometry_experimental/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/geometry_experimental/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/geometry_experimental/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/geometry_experimental/labels{/name}","releases_url":"https://api.github.com/repos/ros/geometry_experimental/releases{/id}","created_at":"2013-01-04T23:33:06Z","updated_at":"2015-10-06T15:00:34Z","pushed_at":"2015-12-16T19:58:31Z","git_url":"git://github.com/ros/geometry_experimental.git","ssh_url":"git@github.com:ros/geometry_experimental.git","clone_url":"https://github.com/ros/geometry_experimental.git","svn_url":"https://github.com/ros/geometry_experimental","homepage":null,"size":3148,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":19,"forks":41,"open_issues":19,"watchers":8,"default_branch":"indigo-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/geometry_experimental/pulls/135"},"html":{"href":"https://github.com/ros/geometry_experimental/pull/135"},"issue":{"href":"https://api.github.com/repos/ros/geometry_experimental/issues/135"},"comments":{"href":"https://api.github.com/repos/ros/geometry_experimental/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/geometry_experimental/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/geometry_experimental/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/geometry_experimental/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/ros/geometry_experimental/statuses/591eb428364296fad71391bc6f117cdfc116e2bf"}}}}