{"action":"created","issue":{"url":"https://api.github.com/repos/jacobdufault/fullserializer/issues/42","labels_url":"https://api.github.com/repos/jacobdufault/fullserializer/issues/42/labels{/name}","comments_url":"https://api.github.com/repos/jacobdufault/fullserializer/issues/42/comments","events_url":"https://api.github.com/repos/jacobdufault/fullserializer/issues/42/events","html_url":"https://github.com/jacobdufault/fullserializer/issues/42","id":73465468,"number":42,"title":"fsObjectProcessor - OnBeforeDeserialize and \"$type\"","user":{"login":"nuverian","id":11355439,"avatar_url":"https://avatars.githubusercontent.com/u/11355439?v=3","gravatar_id":"","url":"https://api.github.com/users/nuverian","html_url":"https://github.com/nuverian","followers_url":"https://api.github.com/users/nuverian/followers","following_url":"https://api.github.com/users/nuverian/following{/other_user}","gists_url":"https://api.github.com/users/nuverian/gists{/gist_id}","starred_url":"https://api.github.com/users/nuverian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nuverian/subscriptions","organizations_url":"https://api.github.com/users/nuverian/orgs","repos_url":"https://api.github.com/users/nuverian/repos","events_url":"https://api.github.com/users/nuverian/events{/privacy}","received_events_url":"https://api.github.com/users/nuverian/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-05-05T23:48:24Z","updated_at":"2015-05-13T04:44:07Z","closed_at":"2015-05-13T04:44:07Z","body":"Hello Jacob,\r\n\r\nAfter updating to the latest FS, I am encountering an issue with OnBeforeDeserialize of the fsObjectProcessor and a trick I used that modifies the \"$type\" json entry of the object proccessed.\r\nAs it seems the json deserialized is not being modified at all now. This used to work great a couble of versions back (about 3 weeks ago).\r\nHere is the critical part of the processor code:\r\n\r\n\r\n\t\tpublic override void OnBeforeDeserialize(Type storageType, ref fsData data){\r\n\r\n\t\t\tif (data.IsNull)\r\n\t\t\t\treturn;\r\n\r\n\t\t\tvar json = data.AsDictionary;\r\n\r\n\t\t\tif (json.ContainsKey(\"$type\")){\r\n\r\n\t\t\t\tvar serializedType = ReflectionTools.GetType( json[\"$type\"].AsString );\r\n\t\t\t\tif (serializedType == null){\r\n\t\t\t\t\tjson[\"$type\"] = new fsData( typeof(MissingNode).FullName );\r\n\t\t\t\t}\r\n\t\t\t}\r\n\t\t}\r\n\r\n\r\nThanks a lot!\r\nGavalakis Vaggelis\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/jacobdufault/fullserializer/issues/comments/101511970","html_url":"https://github.com/jacobdufault/fullserializer/issues/42#issuecomment-101511970","issue_url":"https://api.github.com/repos/jacobdufault/fullserializer/issues/42","id":101511970,"user":{"login":"jacobdufault","id":356714,"avatar_url":"https://avatars.githubusercontent.com/u/356714?v=3","gravatar_id":"","url":"https://api.github.com/users/jacobdufault","html_url":"https://github.com/jacobdufault","followers_url":"https://api.github.com/users/jacobdufault/followers","following_url":"https://api.github.com/users/jacobdufault/following{/other_user}","gists_url":"https://api.github.com/users/jacobdufault/gists{/gist_id}","starred_url":"https://api.github.com/users/jacobdufault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacobdufault/subscriptions","organizations_url":"https://api.github.com/users/jacobdufault/orgs","repos_url":"https://api.github.com/users/jacobdufault/repos","events_url":"https://api.github.com/users/jacobdufault/events{/privacy}","received_events_url":"https://api.github.com/users/jacobdufault/received_events","type":"User","site_admin":false},"created_at":"2015-05-13T04:44:07Z","updated_at":"2015-05-13T04:44:07Z","body":"I believe the given commit should fix the issue. Let me know."}}