{"action":"closed","number":6,"pull_request":{"url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/6","id":41796785,"html_url":"https://github.com/zendesk/active_record_inherit_assoc/pull/6","diff_url":"https://github.com/zendesk/active_record_inherit_assoc/pull/6.diff","patch_url":"https://github.com/zendesk/active_record_inherit_assoc/pull/6.patch","issue_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/6","number":6,"state":"closed","locked":false,"title":"Compatibility with Rails 4.2","user":{"login":"pschambacher","id":547203,"avatar_url":"https://avatars.githubusercontent.com/u/547203?v=3","gravatar_id":"","url":"https://api.github.com/users/pschambacher","html_url":"https://github.com/pschambacher","followers_url":"https://api.github.com/users/pschambacher/followers","following_url":"https://api.github.com/users/pschambacher/following{/other_user}","gists_url":"https://api.github.com/users/pschambacher/gists{/gist_id}","starred_url":"https://api.github.com/users/pschambacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschambacher/subscriptions","organizations_url":"https://api.github.com/users/pschambacher/orgs","repos_url":"https://api.github.com/users/pschambacher/repos","events_url":"https://api.github.com/users/pschambacher/events{/privacy}","received_events_url":"https://api.github.com/users/pschambacher/received_events","type":"User","site_admin":false},"body":"/cc @zendesk/zendesk-rails-upgraders @osheroff \r\n\r\nBased on [this comment](https://github.com/rails/rails/blob/4-2-stable/activerecord/lib/active_record/associations/association.rb#L121-L125) it seems that ```target_scope``` is a better candidate for this patch than ```association_scope``` which doesn't work at all with Rails 4.2\r\n\r\n### Risks\r\n - Low: gem could be completely broken... but tests seem to indicate the opposite!","created_at":"2015-08-06T14:54:18Z","updated_at":"2015-08-07T07:54:54Z","closed_at":"2015-08-07T07:54:54Z","merged_at":"2015-08-07T07:54:54Z","merge_commit_sha":"ba9f6d50f5449a45f9a519313d828c98490b736b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/6/commits","review_comments_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/6/comments","review_comment_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/6/comments","statuses_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/statuses/49bfd2da3f27f7d75558077af437c8560477bdf2","head":{"label":"zendesk:pschambacher/rails4.2","ref":"pschambacher/rails4.2","sha":"49bfd2da3f27f7d75558077af437c8560477bdf2","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":2270679,"name":"active_record_inherit_assoc","full_name":"zendesk/active_record_inherit_assoc","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/active_record_inherit_assoc","description":"Attribute inheritance for AR associations","fork":false,"url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc","forks_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/forks","keys_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/teams","hooks_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/hooks","issue_events_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/events","assignees_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/tags","blobs_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/languages","stargazers_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/stargazers","contributors_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/contributors","subscribers_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/subscribers","subscription_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/subscription","commits_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/merges","archive_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/downloads","issues_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/releases{/id}","created_at":"2011-08-25T21:19:30Z","updated_at":"2015-02-26T17:50:12Z","pushed_at":"2015-08-07T07:54:55Z","git_url":"git://github.com/zendesk/active_record_inherit_assoc.git","ssh_url":"git@github.com:zendesk/active_record_inherit_assoc.git","clone_url":"https://github.com/zendesk/active_record_inherit_assoc.git","svn_url":"https://github.com/zendesk/active_record_inherit_assoc","homepage":"","size":352,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"zendesk:master","ref":"master","sha":"0696bf3ea2f45df98a586904587b65a7110f08c3","user":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"repo":{"id":2270679,"name":"active_record_inherit_assoc","full_name":"zendesk/active_record_inherit_assoc","owner":{"login":"zendesk","id":11525,"avatar_url":"https://avatars.githubusercontent.com/u/11525?v=3","gravatar_id":"","url":"https://api.github.com/users/zendesk","html_url":"https://github.com/zendesk","followers_url":"https://api.github.com/users/zendesk/followers","following_url":"https://api.github.com/users/zendesk/following{/other_user}","gists_url":"https://api.github.com/users/zendesk/gists{/gist_id}","starred_url":"https://api.github.com/users/zendesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendesk/subscriptions","organizations_url":"https://api.github.com/users/zendesk/orgs","repos_url":"https://api.github.com/users/zendesk/repos","events_url":"https://api.github.com/users/zendesk/events{/privacy}","received_events_url":"https://api.github.com/users/zendesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendesk/active_record_inherit_assoc","description":"Attribute inheritance for AR associations","fork":false,"url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc","forks_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/forks","keys_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/teams","hooks_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/hooks","issue_events_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/events{/number}","events_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/events","assignees_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/assignees{/user}","branches_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/branches{/branch}","tags_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/tags","blobs_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/statuses/{sha}","languages_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/languages","stargazers_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/stargazers","contributors_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/contributors","subscribers_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/subscribers","subscription_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/subscription","commits_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/contents/{+path}","compare_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/merges","archive_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/downloads","issues_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues{/number}","pulls_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls{/number}","milestones_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/milestones{/number}","notifications_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/labels{/name}","releases_url":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/releases{/id}","created_at":"2011-08-25T21:19:30Z","updated_at":"2015-02-26T17:50:12Z","pushed_at":"2015-08-07T07:54:55Z","git_url":"git://github.com/zendesk/active_record_inherit_assoc.git","ssh_url":"git@github.com:zendesk/active_record_inherit_assoc.git","clone_url":"https://github.com/zendesk/active_record_inherit_assoc.git","svn_url":"https://github.com/zendesk/active_record_inherit_assoc","homepage":"","size":352,"stargazers_count":3,"watchers_count":3,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/6"},"html":{"href":"https://github.com/zendesk/active_record_inherit_assoc/pull/6"},"issue":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/6"},"comments":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/zendesk/active_record_inherit_assoc/statuses/49bfd2da3f27f7d75558077af437c8560477bdf2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"pschambacher","id":547203,"avatar_url":"https://avatars.githubusercontent.com/u/547203?v=3","gravatar_id":"","url":"https://api.github.com/users/pschambacher","html_url":"https://github.com/pschambacher","followers_url":"https://api.github.com/users/pschambacher/followers","following_url":"https://api.github.com/users/pschambacher/following{/other_user}","gists_url":"https://api.github.com/users/pschambacher/gists{/gist_id}","starred_url":"https://api.github.com/users/pschambacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pschambacher/subscriptions","organizations_url":"https://api.github.com/users/pschambacher/orgs","repos_url":"https://api.github.com/users/pschambacher/repos","events_url":"https://api.github.com/users/pschambacher/events{/privacy}","received_events_url":"https://api.github.com/users/pschambacher/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":33,"deletions":327,"changed_files":12}}