{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/bradfitz/http2/pulls/25","id":26405246,"html_url":"https://github.com/bradfitz/http2/pull/25","diff_url":"https://github.com/bradfitz/http2/pull/25.diff","patch_url":"https://github.com/bradfitz/http2/pull/25.patch","issue_url":"https://api.github.com/repos/bradfitz/http2/issues/25","number":25,"state":"closed","locked":false,"title":"Fix several issues found by 'go vet'","user":{"login":"mdlayher","id":1926905,"avatar_url":"https://avatars.githubusercontent.com/u/1926905?v=3","gravatar_id":"","url":"https://api.github.com/users/mdlayher","html_url":"https://github.com/mdlayher","followers_url":"https://api.github.com/users/mdlayher/followers","following_url":"https://api.github.com/users/mdlayher/following{/other_user}","gists_url":"https://api.github.com/users/mdlayher/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlayher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlayher/subscriptions","organizations_url":"https://api.github.com/users/mdlayher/orgs","repos_url":"https://api.github.com/users/mdlayher/repos","events_url":"https://api.github.com/users/mdlayher/events{/privacy}","received_events_url":"https://api.github.com/users/mdlayher/received_events","type":"User","site_admin":false},"body":"I ran `go vet ./...` and have fixed all of the following issues:\r\n\r\n```\r\n[zsh|matt@nerr-2]:~/git/go/src/github.com/bradfitz/http2 0 (master) ± go vet ./...\r\nerrors_test.go:24: unrecognized printf verb 'i'\r\nframe_test.go:72: arg df.Data for printf verb %q of wrong type: func() []byte\r\nframe_test.go:347: missing argument for Errorf(\"%v\"): format reads arg 4, have only 3 args\r\nserver_test.go:508: missing argument for Errorf(\"%2f\"): format reads arg 2, have only 1 args\r\nserver_test.go:1899: missing argument for Errorf(\"%d\"): format reads arg 1, have only 0 args\r\nexit status 1\r\nhpack/encode_test.go:84: possible formatting directive in Error call\r\nhpack/hpack_test.go:130: arg got for printf verb %q of wrong type: hpack.HeaderField\r\nhpack/hpack_test.go:135: arg got for printf verb %q of wrong type: hpack.HeaderField\r\nhpack/hpack_test.go:138: arg got for printf verb %q of wrong type: hpack.HeaderField\r\nhpack/hpack_test.go:141: arg got for printf verb %q of wrong type: hpack.HeaderField\r\nhpack/hpack_test.go:199: arg got for printf verb %q of wrong type: hpack.HeaderField\r\nexit status 1\r\n```\r\n\r\nIn addition, I have already signed the Google Individual CLA under the same email address: mdlayher@gmail.com.  Thanks again for your time!\r\n","created_at":"2014-12-19T23:05:09Z","updated_at":"2015-01-12T21:04:43Z","closed_at":"2015-01-12T21:04:43Z","merged_at":"2015-01-12T21:04:43Z","merge_commit_sha":"5f247e921c5fe4330310b5bca272cb886426a092","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/bradfitz/http2/pulls/25/commits","review_comments_url":"https://api.github.com/repos/bradfitz/http2/pulls/25/comments","review_comment_url":"https://api.github.com/repos/bradfitz/http2/pulls/comments/{number}","comments_url":"https://api.github.com/repos/bradfitz/http2/issues/25/comments","statuses_url":"https://api.github.com/repos/bradfitz/http2/statuses/07d158ae7668bc32cc5077669d6bca8e40b5f544","head":{"label":"mdlayher:go_vet","ref":"go_vet","sha":"07d158ae7668bc32cc5077669d6bca8e40b5f544","user":{"login":"mdlayher","id":1926905,"avatar_url":"https://avatars.githubusercontent.com/u/1926905?v=3","gravatar_id":"","url":"https://api.github.com/users/mdlayher","html_url":"https://github.com/mdlayher","followers_url":"https://api.github.com/users/mdlayher/followers","following_url":"https://api.github.com/users/mdlayher/following{/other_user}","gists_url":"https://api.github.com/users/mdlayher/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlayher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlayher/subscriptions","organizations_url":"https://api.github.com/users/mdlayher/orgs","repos_url":"https://api.github.com/users/mdlayher/repos","events_url":"https://api.github.com/users/mdlayher/events{/privacy}","received_events_url":"https://api.github.com/users/mdlayher/received_events","type":"User","site_admin":false},"repo":{"id":28249585,"name":"http2","full_name":"mdlayher/http2","owner":{"login":"mdlayher","id":1926905,"avatar_url":"https://avatars.githubusercontent.com/u/1926905?v=3","gravatar_id":"","url":"https://api.github.com/users/mdlayher","html_url":"https://github.com/mdlayher","followers_url":"https://api.github.com/users/mdlayher/followers","following_url":"https://api.github.com/users/mdlayher/following{/other_user}","gists_url":"https://api.github.com/users/mdlayher/gists{/gist_id}","starred_url":"https://api.github.com/users/mdlayher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdlayher/subscriptions","organizations_url":"https://api.github.com/users/mdlayher/orgs","repos_url":"https://api.github.com/users/mdlayher/repos","events_url":"https://api.github.com/users/mdlayher/events{/privacy}","received_events_url":"https://api.github.com/users/mdlayher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mdlayher/http2","description":"HTTP/2 support for Go (in active development)","fork":true,"url":"https://api.github.com/repos/mdlayher/http2","forks_url":"https://api.github.com/repos/mdlayher/http2/forks","keys_url":"https://api.github.com/repos/mdlayher/http2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mdlayher/http2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mdlayher/http2/teams","hooks_url":"https://api.github.com/repos/mdlayher/http2/hooks","issue_events_url":"https://api.github.com/repos/mdlayher/http2/issues/events{/number}","events_url":"https://api.github.com/repos/mdlayher/http2/events","assignees_url":"https://api.github.com/repos/mdlayher/http2/assignees{/user}","branches_url":"https://api.github.com/repos/mdlayher/http2/branches{/branch}","tags_url":"https://api.github.com/repos/mdlayher/http2/tags","blobs_url":"https://api.github.com/repos/mdlayher/http2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mdlayher/http2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mdlayher/http2/git/refs{/sha}","trees_url":"https://api.github.com/repos/mdlayher/http2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mdlayher/http2/statuses/{sha}","languages_url":"https://api.github.com/repos/mdlayher/http2/languages","stargazers_url":"https://api.github.com/repos/mdlayher/http2/stargazers","contributors_url":"https://api.github.com/repos/mdlayher/http2/contributors","subscribers_url":"https://api.github.com/repos/mdlayher/http2/subscribers","subscription_url":"https://api.github.com/repos/mdlayher/http2/subscription","commits_url":"https://api.github.com/repos/mdlayher/http2/commits{/sha}","git_commits_url":"https://api.github.com/repos/mdlayher/http2/git/commits{/sha}","comments_url":"https://api.github.com/repos/mdlayher/http2/comments{/number}","issue_comment_url":"https://api.github.com/repos/mdlayher/http2/issues/comments/{number}","contents_url":"https://api.github.com/repos/mdlayher/http2/contents/{+path}","compare_url":"https://api.github.com/repos/mdlayher/http2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mdlayher/http2/merges","archive_url":"https://api.github.com/repos/mdlayher/http2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mdlayher/http2/downloads","issues_url":"https://api.github.com/repos/mdlayher/http2/issues{/number}","pulls_url":"https://api.github.com/repos/mdlayher/http2/pulls{/number}","milestones_url":"https://api.github.com/repos/mdlayher/http2/milestones{/number}","notifications_url":"https://api.github.com/repos/mdlayher/http2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mdlayher/http2/labels{/name}","releases_url":"https://api.github.com/repos/mdlayher/http2/releases{/id}","created_at":"2014-12-19T22:56:24Z","updated_at":"2014-12-19T22:56:24Z","pushed_at":"2014-12-19T23:01:57Z","git_url":"git://github.com/mdlayher/http2.git","ssh_url":"git@github.com:mdlayher/http2.git","clone_url":"https://github.com/mdlayher/http2.git","svn_url":"https://github.com/mdlayher/http2","homepage":"","size":514,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bradfitz:master","ref":"master","sha":"2fcb356ed44f5f4dd6bbd77c32ff323e3fd2cd7e","user":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars.githubusercontent.com/u/2621?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"repo":{"id":21876647,"name":"http2","full_name":"bradfitz/http2","owner":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars.githubusercontent.com/u/2621?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bradfitz/http2","description":"HTTP/2 support for Go (in active development)","fork":false,"url":"https://api.github.com/repos/bradfitz/http2","forks_url":"https://api.github.com/repos/bradfitz/http2/forks","keys_url":"https://api.github.com/repos/bradfitz/http2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradfitz/http2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradfitz/http2/teams","hooks_url":"https://api.github.com/repos/bradfitz/http2/hooks","issue_events_url":"https://api.github.com/repos/bradfitz/http2/issues/events{/number}","events_url":"https://api.github.com/repos/bradfitz/http2/events","assignees_url":"https://api.github.com/repos/bradfitz/http2/assignees{/user}","branches_url":"https://api.github.com/repos/bradfitz/http2/branches{/branch}","tags_url":"https://api.github.com/repos/bradfitz/http2/tags","blobs_url":"https://api.github.com/repos/bradfitz/http2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradfitz/http2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradfitz/http2/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradfitz/http2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradfitz/http2/statuses/{sha}","languages_url":"https://api.github.com/repos/bradfitz/http2/languages","stargazers_url":"https://api.github.com/repos/bradfitz/http2/stargazers","contributors_url":"https://api.github.com/repos/bradfitz/http2/contributors","subscribers_url":"https://api.github.com/repos/bradfitz/http2/subscribers","subscription_url":"https://api.github.com/repos/bradfitz/http2/subscription","commits_url":"https://api.github.com/repos/bradfitz/http2/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradfitz/http2/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradfitz/http2/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradfitz/http2/issues/comments/{number}","contents_url":"https://api.github.com/repos/bradfitz/http2/contents/{+path}","compare_url":"https://api.github.com/repos/bradfitz/http2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradfitz/http2/merges","archive_url":"https://api.github.com/repos/bradfitz/http2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradfitz/http2/downloads","issues_url":"https://api.github.com/repos/bradfitz/http2/issues{/number}","pulls_url":"https://api.github.com/repos/bradfitz/http2/pulls{/number}","milestones_url":"https://api.github.com/repos/bradfitz/http2/milestones{/number}","notifications_url":"https://api.github.com/repos/bradfitz/http2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradfitz/http2/labels{/name}","releases_url":"https://api.github.com/repos/bradfitz/http2/releases{/id}","created_at":"2014-07-15T21:31:33Z","updated_at":"2015-01-12T09:41:24Z","pushed_at":"2015-01-12T21:04:43Z","git_url":"git://github.com/bradfitz/http2.git","ssh_url":"git@github.com:bradfitz/http2.git","clone_url":"https://github.com/bradfitz/http2.git","svn_url":"https://github.com/bradfitz/http2","homepage":"","size":1253,"stargazers_count":489,"watchers_count":489,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":2,"forks":21,"open_issues":2,"watchers":489,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bradfitz/http2/pulls/25"},"html":{"href":"https://github.com/bradfitz/http2/pull/25"},"issue":{"href":"https://api.github.com/repos/bradfitz/http2/issues/25"},"comments":{"href":"https://api.github.com/repos/bradfitz/http2/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/bradfitz/http2/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/bradfitz/http2/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/bradfitz/http2/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/bradfitz/http2/statuses/07d158ae7668bc32cc5077669d6bca8e40b5f544"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"bradfitz","id":2621,"avatar_url":"https://avatars.githubusercontent.com/u/2621?v=3","gravatar_id":"","url":"https://api.github.com/users/bradfitz","html_url":"https://github.com/bradfitz","followers_url":"https://api.github.com/users/bradfitz/followers","following_url":"https://api.github.com/users/bradfitz/following{/other_user}","gists_url":"https://api.github.com/users/bradfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/bradfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradfitz/subscriptions","organizations_url":"https://api.github.com/users/bradfitz/orgs","repos_url":"https://api.github.com/users/bradfitz/repos","events_url":"https://api.github.com/users/bradfitz/events{/privacy}","received_events_url":"https://api.github.com/users/bradfitz/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":2,"additions":14,"deletions":13,"changed_files":7}}