{"action":"created","comment":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/comments/47435979","id":47435979,"diff_hunk":"@@ -4315,8 +4329,11 @@ default `:verify' function of command checkers.\"\n         (parser (or (plist-get properties :error-parser)\n                     #'flycheck-parse-with-patterns))\n         (predicate (plist-get properties :predicate))\n-        (standard-input (plist-get properties :standard-input)))\n-\n+        (standard-input (plist-get properties :standard-input))\n+        (cwd       (plist-get properties :cwd)))\n+    ;; FIXME add more to the cwd checker\n+    ;; (unless (stringp (car cwd))\n+    ;;   (error \"Current working directory must be a string\"))","path":"flycheck.el","position":40,"original_position":40,"commit_id":"9be11cc17c53d457b31c23669ac712468dab7cf6","original_commit_id":"9be11cc17c53d457b31c23669ac712468dab7cf6","user":{"login":"s3bs","id":16008197,"avatar_url":"https://avatars.githubusercontent.com/u/16008197?v=3","gravatar_id":"","url":"https://api.github.com/users/s3bs","html_url":"https://github.com/s3bs","followers_url":"https://api.github.com/users/s3bs/followers","following_url":"https://api.github.com/users/s3bs/following{/other_user}","gists_url":"https://api.github.com/users/s3bs/gists{/gist_id}","starred_url":"https://api.github.com/users/s3bs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s3bs/subscriptions","organizations_url":"https://api.github.com/users/s3bs/orgs","repos_url":"https://api.github.com/users/s3bs/repos","events_url":"https://api.github.com/users/s3bs/events{/privacy}","received_events_url":"https://api.github.com/users/s3bs/received_events","type":"User","site_admin":false},"body":"ups. I need to still update this to check if the property is either a string (fixed path) or a function. ","created_at":"2015-12-12T20:03:11Z","updated_at":"2015-12-12T20:03:11Z","html_url":"https://github.com/flycheck/flycheck/pull/813#discussion_r47435979","pull_request_url":"https://api.github.com/repos/flycheck/flycheck/pulls/813","_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/comments/47435979"},"html":{"href":"https://github.com/flycheck/flycheck/pull/813#discussion_r47435979"},"pull_request":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/flycheck/flycheck/pulls/813","id":52086698,"html_url":"https://github.com/flycheck/flycheck/pull/813","diff_url":"https://github.com/flycheck/flycheck/pull/813.diff","patch_url":"https://github.com/flycheck/flycheck/pull/813.patch","issue_url":"https://api.github.com/repos/flycheck/flycheck/issues/813","number":813,"state":"open","locked":false,"title":"Add current working directory [:cwd] property ","user":{"login":"s3bs","id":16008197,"avatar_url":"https://avatars.githubusercontent.com/u/16008197?v=3","gravatar_id":"","url":"https://api.github.com/users/s3bs","html_url":"https://github.com/s3bs","followers_url":"https://api.github.com/users/s3bs/followers","following_url":"https://api.github.com/users/s3bs/following{/other_user}","gists_url":"https://api.github.com/users/s3bs/gists{/gist_id}","starred_url":"https://api.github.com/users/s3bs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s3bs/subscriptions","organizations_url":"https://api.github.com/users/s3bs/orgs","repos_url":"https://api.github.com/users/s3bs/repos","events_url":"https://api.github.com/users/s3bs/events{/privacy}","received_events_url":"https://api.github.com/users/s3bs/received_events","type":"User","site_admin":false},"body":"This is a first iteration of trying to implement #312. It give the possibility to add :cwd to the flycheck-define-checker. :cwd can be a fixed path or a function that returns a absolute path. The function is called just before the checker. The default-directory is only changed in the lexical environment of the checker execution. \r\nIn addition there is a :environment property, where one can define additional environment variables. \r\nie (\"var1=value1\" \"var2=value2\")\r\n\r\nEdit: Connects to #312 ","created_at":"2015-11-30T05:29:18Z","updated_at":"2015-12-12T20:03:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ddabe736ea1b17fea5f33fbb0f43de53f1fc6b5","assignee":{"login":"lunaryorn","id":224922,"avatar_url":"https://avatars.githubusercontent.com/u/224922?v=3","gravatar_id":"","url":"https://api.github.com/users/lunaryorn","html_url":"https://github.com/lunaryorn","followers_url":"https://api.github.com/users/lunaryorn/followers","following_url":"https://api.github.com/users/lunaryorn/following{/other_user}","gists_url":"https://api.github.com/users/lunaryorn/gists{/gist_id}","starred_url":"https://api.github.com/users/lunaryorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lunaryorn/subscriptions","organizations_url":"https://api.github.com/users/lunaryorn/orgs","repos_url":"https://api.github.com/users/lunaryorn/repos","events_url":"https://api.github.com/users/lunaryorn/events{/privacy}","received_events_url":"https://api.github.com/users/lunaryorn/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/flycheck/flycheck/pulls/813/commits","review_comments_url":"https://api.github.com/repos/flycheck/flycheck/pulls/813/comments","review_comment_url":"https://api.github.com/repos/flycheck/flycheck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flycheck/flycheck/issues/813/comments","statuses_url":"https://api.github.com/repos/flycheck/flycheck/statuses/9be11cc17c53d457b31c23669ac712468dab7cf6","head":{"label":"s3bs:cwd","ref":"cwd","sha":"9be11cc17c53d457b31c23669ac712468dab7cf6","user":{"login":"s3bs","id":16008197,"avatar_url":"https://avatars.githubusercontent.com/u/16008197?v=3","gravatar_id":"","url":"https://api.github.com/users/s3bs","html_url":"https://github.com/s3bs","followers_url":"https://api.github.com/users/s3bs/followers","following_url":"https://api.github.com/users/s3bs/following{/other_user}","gists_url":"https://api.github.com/users/s3bs/gists{/gist_id}","starred_url":"https://api.github.com/users/s3bs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s3bs/subscriptions","organizations_url":"https://api.github.com/users/s3bs/orgs","repos_url":"https://api.github.com/users/s3bs/repos","events_url":"https://api.github.com/users/s3bs/events{/privacy}","received_events_url":"https://api.github.com/users/s3bs/received_events","type":"User","site_admin":false},"repo":{"id":46828028,"name":"flycheck","full_name":"s3bs/flycheck","owner":{"login":"s3bs","id":16008197,"avatar_url":"https://avatars.githubusercontent.com/u/16008197?v=3","gravatar_id":"","url":"https://api.github.com/users/s3bs","html_url":"https://github.com/s3bs","followers_url":"https://api.github.com/users/s3bs/followers","following_url":"https://api.github.com/users/s3bs/following{/other_user}","gists_url":"https://api.github.com/users/s3bs/gists{/gist_id}","starred_url":"https://api.github.com/users/s3bs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s3bs/subscriptions","organizations_url":"https://api.github.com/users/s3bs/orgs","repos_url":"https://api.github.com/users/s3bs/repos","events_url":"https://api.github.com/users/s3bs/events{/privacy}","received_events_url":"https://api.github.com/users/s3bs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/s3bs/flycheck","description":"Modern on the fly syntax checking for GNU Emacs","fork":true,"url":"https://api.github.com/repos/s3bs/flycheck","forks_url":"https://api.github.com/repos/s3bs/flycheck/forks","keys_url":"https://api.github.com/repos/s3bs/flycheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/s3bs/flycheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/s3bs/flycheck/teams","hooks_url":"https://api.github.com/repos/s3bs/flycheck/hooks","issue_events_url":"https://api.github.com/repos/s3bs/flycheck/issues/events{/number}","events_url":"https://api.github.com/repos/s3bs/flycheck/events","assignees_url":"https://api.github.com/repos/s3bs/flycheck/assignees{/user}","branches_url":"https://api.github.com/repos/s3bs/flycheck/branches{/branch}","tags_url":"https://api.github.com/repos/s3bs/flycheck/tags","blobs_url":"https://api.github.com/repos/s3bs/flycheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/s3bs/flycheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/s3bs/flycheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/s3bs/flycheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/s3bs/flycheck/statuses/{sha}","languages_url":"https://api.github.com/repos/s3bs/flycheck/languages","stargazers_url":"https://api.github.com/repos/s3bs/flycheck/stargazers","contributors_url":"https://api.github.com/repos/s3bs/flycheck/contributors","subscribers_url":"https://api.github.com/repos/s3bs/flycheck/subscribers","subscription_url":"https://api.github.com/repos/s3bs/flycheck/subscription","commits_url":"https://api.github.com/repos/s3bs/flycheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/s3bs/flycheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/s3bs/flycheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/s3bs/flycheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/s3bs/flycheck/contents/{+path}","compare_url":"https://api.github.com/repos/s3bs/flycheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/s3bs/flycheck/merges","archive_url":"https://api.github.com/repos/s3bs/flycheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/s3bs/flycheck/downloads","issues_url":"https://api.github.com/repos/s3bs/flycheck/issues{/number}","pulls_url":"https://api.github.com/repos/s3bs/flycheck/pulls{/number}","milestones_url":"https://api.github.com/repos/s3bs/flycheck/milestones{/number}","notifications_url":"https://api.github.com/repos/s3bs/flycheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/s3bs/flycheck/labels{/name}","releases_url":"https://api.github.com/repos/s3bs/flycheck/releases{/id}","created_at":"2015-11-25T00:50:30Z","updated_at":"2015-11-25T00:50:33Z","pushed_at":"2015-12-09T23:09:32Z","git_url":"git://github.com/s3bs/flycheck.git","ssh_url":"git@github.com:s3bs/flycheck.git","clone_url":"https://github.com/s3bs/flycheck.git","svn_url":"https://github.com/s3bs/flycheck","homepage":"http://www.flycheck.org","size":12468,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flycheck:master","ref":"master","sha":"1d31ed92dace97efe26f5fb38af323a848a4d795","user":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"repo":{"id":6158882,"name":"flycheck","full_name":"flycheck/flycheck","owner":{"login":"flycheck","id":5254142,"avatar_url":"https://avatars.githubusercontent.com/u/5254142?v=3","gravatar_id":"","url":"https://api.github.com/users/flycheck","html_url":"https://github.com/flycheck","followers_url":"https://api.github.com/users/flycheck/followers","following_url":"https://api.github.com/users/flycheck/following{/other_user}","gists_url":"https://api.github.com/users/flycheck/gists{/gist_id}","starred_url":"https://api.github.com/users/flycheck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flycheck/subscriptions","organizations_url":"https://api.github.com/users/flycheck/orgs","repos_url":"https://api.github.com/users/flycheck/repos","events_url":"https://api.github.com/users/flycheck/events{/privacy}","received_events_url":"https://api.github.com/users/flycheck/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flycheck/flycheck","description":"Modern on the fly syntax checking for GNU Emacs","fork":false,"url":"https://api.github.com/repos/flycheck/flycheck","forks_url":"https://api.github.com/repos/flycheck/flycheck/forks","keys_url":"https://api.github.com/repos/flycheck/flycheck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flycheck/flycheck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flycheck/flycheck/teams","hooks_url":"https://api.github.com/repos/flycheck/flycheck/hooks","issue_events_url":"https://api.github.com/repos/flycheck/flycheck/issues/events{/number}","events_url":"https://api.github.com/repos/flycheck/flycheck/events","assignees_url":"https://api.github.com/repos/flycheck/flycheck/assignees{/user}","branches_url":"https://api.github.com/repos/flycheck/flycheck/branches{/branch}","tags_url":"https://api.github.com/repos/flycheck/flycheck/tags","blobs_url":"https://api.github.com/repos/flycheck/flycheck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flycheck/flycheck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flycheck/flycheck/git/refs{/sha}","trees_url":"https://api.github.com/repos/flycheck/flycheck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flycheck/flycheck/statuses/{sha}","languages_url":"https://api.github.com/repos/flycheck/flycheck/languages","stargazers_url":"https://api.github.com/repos/flycheck/flycheck/stargazers","contributors_url":"https://api.github.com/repos/flycheck/flycheck/contributors","subscribers_url":"https://api.github.com/repos/flycheck/flycheck/subscribers","subscription_url":"https://api.github.com/repos/flycheck/flycheck/subscription","commits_url":"https://api.github.com/repos/flycheck/flycheck/commits{/sha}","git_commits_url":"https://api.github.com/repos/flycheck/flycheck/git/commits{/sha}","comments_url":"https://api.github.com/repos/flycheck/flycheck/comments{/number}","issue_comment_url":"https://api.github.com/repos/flycheck/flycheck/issues/comments{/number}","contents_url":"https://api.github.com/repos/flycheck/flycheck/contents/{+path}","compare_url":"https://api.github.com/repos/flycheck/flycheck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flycheck/flycheck/merges","archive_url":"https://api.github.com/repos/flycheck/flycheck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flycheck/flycheck/downloads","issues_url":"https://api.github.com/repos/flycheck/flycheck/issues{/number}","pulls_url":"https://api.github.com/repos/flycheck/flycheck/pulls{/number}","milestones_url":"https://api.github.com/repos/flycheck/flycheck/milestones{/number}","notifications_url":"https://api.github.com/repos/flycheck/flycheck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flycheck/flycheck/labels{/name}","releases_url":"https://api.github.com/repos/flycheck/flycheck/releases{/id}","created_at":"2012-10-10T14:45:13Z","updated_at":"2015-12-12T14:32:28Z","pushed_at":"2015-12-12T12:13:36Z","git_url":"git://github.com/flycheck/flycheck.git","ssh_url":"git@github.com:flycheck/flycheck.git","clone_url":"https://github.com/flycheck/flycheck.git","svn_url":"https://github.com/flycheck/flycheck","homepage":"http://www.flycheck.org","size":15075,"stargazers_count":866,"watchers_count":866,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":162,"mirror_url":null,"open_issues_count":24,"forks":162,"open_issues":24,"watchers":866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/813"},"html":{"href":"https://github.com/flycheck/flycheck/pull/813"},"issue":{"href":"https://api.github.com/repos/flycheck/flycheck/issues/813"},"comments":{"href":"https://api.github.com/repos/flycheck/flycheck/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flycheck/flycheck/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/flycheck/flycheck/statuses/9be11cc17c53d457b31c23669ac712468dab7cf6"}}}}