{"action":"created","comment":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/23727197","id":23727197,"diff_hunk":"@@ -82,8 +84,23 @@ namespace PVR\n     std::string   m_strFanartPath;    /*!< fanart path */\n     unsigned      m_iRecordingId;     /*!< id that won't change while xbmc is running */\n \n+  private:","path":"xbmc/pvr/recordings/PVRRecording.h","position":13,"original_position":13,"commit_id":"f7f406ff638b4e3c2db9fd0d596d3ea374f295d8","original_commit_id":"f7f406ff638b4e3c2db9fd0d596d3ea374f295d8","user":{"login":"opdenkamp","id":441806,"avatar_url":"https://avatars.githubusercontent.com/u/441806?v=3","gravatar_id":"","url":"https://api.github.com/users/opdenkamp","html_url":"https://github.com/opdenkamp","followers_url":"https://api.github.com/users/opdenkamp/followers","following_url":"https://api.github.com/users/opdenkamp/following{/other_user}","gists_url":"https://api.github.com/users/opdenkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/opdenkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opdenkamp/subscriptions","organizations_url":"https://api.github.com/users/opdenkamp/orgs","repos_url":"https://api.github.com/users/opdenkamp/repos","events_url":"https://api.github.com/users/opdenkamp/events{/privacy}","received_events_url":"https://api.github.com/users/opdenkamp/received_events","type":"User","site_admin":false},"body":"Okay, I thought you meant that it would be more efficient.\r\nYou cannot create copies if the copy ctor and operator= are private and have a default implementation, like we do throughout the code, so I'm not sure what you're on about here. Just make the ctor public again so you don't need the friend class statement.","created_at":"2015-01-28T21:53:40Z","updated_at":"2015-01-28T21:53:40Z","html_url":"https://github.com/xbmc/xbmc/pull/6207#discussion_r23727197","pull_request_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6207","_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/23727197"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6207#discussion_r23727197"},"pull_request":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6207"}}},"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/6207","id":27384359,"html_url":"https://github.com/xbmc/xbmc/pull/6207","diff_url":"https://github.com/xbmc/xbmc/pull/6207.diff","patch_url":"https://github.com/xbmc/xbmc/pull/6207.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/6207","number":6207,"state":"open","locked":false,"title":"Optimize CPVRRecording. No more copies, just shared pointers.","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"body":"Followup to #5763. Same implementation approach...\r\n\r\nCiting myself from #5763: \"Next after this PR got merged will be optimization of CPVRRecording, which will by the way fix the issues with watched/unwatched state in recording window. @Jalle19 recently introduced a hack (#5613) that fixes immediate display of watched/unwatched in the recording window after changing the state via the respective context menu entries but that does not fix immediate display of watched state after a recording has been watched completely. The state will be set correctly, but it gets not displayed in the recording window, because the state is set at the wrong CPVRRecording instance. Eleminating all CPVRRecording copies will make Sam's hack obsolete (Recently introduced CPVRRecording::GetByFileItem which obtains the original PVRRecording belonging to a copy no longer needed than).\"","created_at":"2015-01-14T21:20:09Z","updated_at":"2015-01-28T21:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"22e78f8af7fca735e42df1de1f9d29ae8f83e24b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6207/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/6207/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/6207/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/f7f406ff638b4e3c2db9fd0d596d3ea374f295d8","head":{"label":"ksooo:pvrrecording-optimizations","ref":"pvrrecording-optimizations","sha":"f7f406ff638b4e3c2db9fd0d596d3ea374f295d8","user":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"repo":{"id":17368872,"name":"xbmc","full_name":"ksooo/xbmc","owner":{"login":"ksooo","id":3226626,"avatar_url":"https://avatars.githubusercontent.com/u/3226626?v=3","gravatar_id":"","url":"https://api.github.com/users/ksooo","html_url":"https://github.com/ksooo","followers_url":"https://api.github.com/users/ksooo/followers","following_url":"https://api.github.com/users/ksooo/following{/other_user}","gists_url":"https://api.github.com/users/ksooo/gists{/gist_id}","starred_url":"https://api.github.com/users/ksooo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ksooo/subscriptions","organizations_url":"https://api.github.com/users/ksooo/orgs","repos_url":"https://api.github.com/users/ksooo/repos","events_url":"https://api.github.com/users/ksooo/events{/privacy}","received_events_url":"https://api.github.com/users/ksooo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ksooo/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/ksooo/xbmc","forks_url":"https://api.github.com/repos/ksooo/xbmc/forks","keys_url":"https://api.github.com/repos/ksooo/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ksooo/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ksooo/xbmc/teams","hooks_url":"https://api.github.com/repos/ksooo/xbmc/hooks","issue_events_url":"https://api.github.com/repos/ksooo/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/ksooo/xbmc/events","assignees_url":"https://api.github.com/repos/ksooo/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/ksooo/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/ksooo/xbmc/tags","blobs_url":"https://api.github.com/repos/ksooo/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ksooo/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ksooo/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ksooo/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ksooo/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/ksooo/xbmc/languages","stargazers_url":"https://api.github.com/repos/ksooo/xbmc/stargazers","contributors_url":"https://api.github.com/repos/ksooo/xbmc/contributors","subscribers_url":"https://api.github.com/repos/ksooo/xbmc/subscribers","subscription_url":"https://api.github.com/repos/ksooo/xbmc/subscription","commits_url":"https://api.github.com/repos/ksooo/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ksooo/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ksooo/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ksooo/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/ksooo/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/ksooo/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ksooo/xbmc/merges","archive_url":"https://api.github.com/repos/ksooo/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ksooo/xbmc/downloads","issues_url":"https://api.github.com/repos/ksooo/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/ksooo/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/ksooo/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/ksooo/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ksooo/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/ksooo/xbmc/releases{/id}","created_at":"2014-03-03T14:45:39Z","updated_at":"2015-01-27T08:07:17Z","pushed_at":"2015-01-28T10:59:39Z","git_url":"git://github.com/ksooo/xbmc.git","ssh_url":"git@github.com:ksooo/xbmc.git","clone_url":"https://github.com/ksooo/xbmc.git","svn_url":"https://github.com/ksooo/xbmc","homepage":"http://xbmc.org","size":491128,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"679a7869901ba0a5c2c2fe088a394b03aef177b3","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/{number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","created_at":"2011-01-03T21:18:51Z","updated_at":"2015-01-28T21:23:41Z","pushed_at":"2015-01-28T21:23:41Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1800944,"stargazers_count":3652,"watchers_count":3652,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2627,"mirror_url":null,"open_issues_count":243,"forks":2627,"open_issues":243,"watchers":3652,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6207"},"html":{"href":"https://github.com/xbmc/xbmc/pull/6207"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6207"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/6207/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6207/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/6207/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/f7f406ff638b4e3c2db9fd0d596d3ea374f295d8"}}}}