{"action":"created","comment":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/comments/33840324","id":33840324,"diff_hunk":"@@ -0,0 +1,54 @@\n+/*\n+ * Licensed to the University of California, Berkeley under one or more contributor license\n+ * agreements. See the NOTICE file distributed with this work for additional information regarding\n+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance with the License. You may obtain a\n+ * copy of the License at\n+ *\n+ * http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software distributed under the License\n+ * is distributed on an \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express\n+ * or implied. See the License for the specific language governing permissions and limitations under\n+ * the License.\n+ */\n+\n+package tachyon.security;\n+\n+import java.security.Principal;\n+\n+public class User implements Principal {\n+  private String mName;\n+\n+  // TODO: add more attributes and methods for supporting Kerberos\n+\n+  public User(String mName) {\n+    this.mName = mName;","path":"common/src/main/java/tachyon/security/User.java","position":26,"original_position":26,"commit_id":"9a2568c7b9aaa4ada2b60b833b685e9819657477","original_commit_id":"9a2568c7b9aaa4ada2b60b833b685e9819657477","user":{"login":"calvinjia","id":2223813,"avatar_url":"https://avatars.githubusercontent.com/u/2223813?v=3","gravatar_id":"","url":"https://api.github.com/users/calvinjia","html_url":"https://github.com/calvinjia","followers_url":"https://api.github.com/users/calvinjia/followers","following_url":"https://api.github.com/users/calvinjia/following{/other_user}","gists_url":"https://api.github.com/users/calvinjia/gists{/gist_id}","starred_url":"https://api.github.com/users/calvinjia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calvinjia/subscriptions","organizations_url":"https://api.github.com/users/calvinjia/orgs","repos_url":"https://api.github.com/users/calvinjia/repos","events_url":"https://api.github.com/users/calvinjia/events{/privacy}","received_events_url":"https://api.github.com/users/calvinjia/received_events","type":"User","site_admin":false},"body":"For Tachyon's code style, we avoid using `this`. Could you change the argument to something like `name`?","created_at":"2015-07-03T04:44:36Z","updated_at":"2015-07-03T04:44:36Z","html_url":"https://github.com/amplab/tachyon/pull/1031#discussion_r33840324","pull_request_url":"https://api.github.com/repos/amplab/tachyon/pulls/1031","_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments/33840324"},"html":{"href":"https://github.com/amplab/tachyon/pull/1031#discussion_r33840324"},"pull_request":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1031"}}},"pull_request":{"url":"https://api.github.com/repos/amplab/tachyon/pulls/1031","id":39143018,"html_url":"https://github.com/amplab/tachyon/pull/1031","diff_url":"https://github.com/amplab/tachyon/pull/1031.diff","patch_url":"https://github.com/amplab/tachyon/pull/1031.patch","issue_url":"https://api.github.com/repos/amplab/tachyon/issues/1031","number":1031,"state":"open","locked":false,"title":"TACHYON-600: Add user model","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"body":"JIRA link: https://tachyon.atlassian.net/browse/TACHYON-600\r\nThis is a sub-task of TACHYON-593: Simple Authentication.\r\n\r\nAdd a User class for representing a user in Tachyon. It implements Principal interface in the context of Java security frameworks. Then it can be used in JAAS framework.","created_at":"2015-07-03T03:11:21Z","updated_at":"2015-07-03T04:44:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"04a6efcdae263a634cc0cc5fa95b144962b69698","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/amplab/tachyon/pulls/1031/commits","review_comments_url":"https://api.github.com/repos/amplab/tachyon/pulls/1031/comments","review_comment_url":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/amplab/tachyon/issues/1031/comments","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/9a2568c7b9aaa4ada2b60b833b685e9819657477","head":{"label":"dongche:security","ref":"security","sha":"9a2568c7b9aaa4ada2b60b833b685e9819657477","user":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"repo":{"id":38419009,"name":"tachyon","full_name":"dongche/tachyon","owner":{"login":"dongche","id":8003874,"avatar_url":"https://avatars.githubusercontent.com/u/8003874?v=3","gravatar_id":"","url":"https://api.github.com/users/dongche","html_url":"https://github.com/dongche","followers_url":"https://api.github.com/users/dongche/followers","following_url":"https://api.github.com/users/dongche/following{/other_user}","gists_url":"https://api.github.com/users/dongche/gists{/gist_id}","starred_url":"https://api.github.com/users/dongche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dongche/subscriptions","organizations_url":"https://api.github.com/users/dongche/orgs","repos_url":"https://api.github.com/users/dongche/repos","events_url":"https://api.github.com/users/dongche/events{/privacy}","received_events_url":"https://api.github.com/users/dongche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dongche/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":true,"url":"https://api.github.com/repos/dongche/tachyon","forks_url":"https://api.github.com/repos/dongche/tachyon/forks","keys_url":"https://api.github.com/repos/dongche/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dongche/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dongche/tachyon/teams","hooks_url":"https://api.github.com/repos/dongche/tachyon/hooks","issue_events_url":"https://api.github.com/repos/dongche/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/dongche/tachyon/events","assignees_url":"https://api.github.com/repos/dongche/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/dongche/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/dongche/tachyon/tags","blobs_url":"https://api.github.com/repos/dongche/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dongche/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dongche/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/dongche/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dongche/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/dongche/tachyon/languages","stargazers_url":"https://api.github.com/repos/dongche/tachyon/stargazers","contributors_url":"https://api.github.com/repos/dongche/tachyon/contributors","subscribers_url":"https://api.github.com/repos/dongche/tachyon/subscribers","subscription_url":"https://api.github.com/repos/dongche/tachyon/subscription","commits_url":"https://api.github.com/repos/dongche/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/dongche/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/dongche/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/dongche/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/dongche/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/dongche/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dongche/tachyon/merges","archive_url":"https://api.github.com/repos/dongche/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dongche/tachyon/downloads","issues_url":"https://api.github.com/repos/dongche/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/dongche/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/dongche/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/dongche/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dongche/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/dongche/tachyon/releases{/id}","created_at":"2015-07-02T07:53:56Z","updated_at":"2015-07-02T07:53:58Z","pushed_at":"2015-07-03T03:06:37Z","git_url":"git://github.com/dongche/tachyon.git","ssh_url":"git@github.com:dongche/tachyon.git","clone_url":"https://github.com/dongche/tachyon.git","svn_url":"https://github.com/dongche/tachyon","homepage":"http://tachyon-project.org","size":14862,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"amplab:security","ref":"security","sha":"53d83971d2a460dd335933ff8b088594a44fb13a","user":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"repo":{"id":7276954,"name":"tachyon","full_name":"amplab/tachyon","owner":{"login":"amplab","id":1438454,"avatar_url":"https://avatars.githubusercontent.com/u/1438454?v=3","gravatar_id":"","url":"https://api.github.com/users/amplab","html_url":"https://github.com/amplab","followers_url":"https://api.github.com/users/amplab/followers","following_url":"https://api.github.com/users/amplab/following{/other_user}","gists_url":"https://api.github.com/users/amplab/gists{/gist_id}","starred_url":"https://api.github.com/users/amplab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amplab/subscriptions","organizations_url":"https://api.github.com/users/amplab/orgs","repos_url":"https://api.github.com/users/amplab/repos","events_url":"https://api.github.com/users/amplab/events{/privacy}","received_events_url":"https://api.github.com/users/amplab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/amplab/tachyon","description":" A Reliable Memory Centric Distributed Storage System","fork":false,"url":"https://api.github.com/repos/amplab/tachyon","forks_url":"https://api.github.com/repos/amplab/tachyon/forks","keys_url":"https://api.github.com/repos/amplab/tachyon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/amplab/tachyon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/amplab/tachyon/teams","hooks_url":"https://api.github.com/repos/amplab/tachyon/hooks","issue_events_url":"https://api.github.com/repos/amplab/tachyon/issues/events{/number}","events_url":"https://api.github.com/repos/amplab/tachyon/events","assignees_url":"https://api.github.com/repos/amplab/tachyon/assignees{/user}","branches_url":"https://api.github.com/repos/amplab/tachyon/branches{/branch}","tags_url":"https://api.github.com/repos/amplab/tachyon/tags","blobs_url":"https://api.github.com/repos/amplab/tachyon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/amplab/tachyon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/amplab/tachyon/git/refs{/sha}","trees_url":"https://api.github.com/repos/amplab/tachyon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/amplab/tachyon/statuses/{sha}","languages_url":"https://api.github.com/repos/amplab/tachyon/languages","stargazers_url":"https://api.github.com/repos/amplab/tachyon/stargazers","contributors_url":"https://api.github.com/repos/amplab/tachyon/contributors","subscribers_url":"https://api.github.com/repos/amplab/tachyon/subscribers","subscription_url":"https://api.github.com/repos/amplab/tachyon/subscription","commits_url":"https://api.github.com/repos/amplab/tachyon/commits{/sha}","git_commits_url":"https://api.github.com/repos/amplab/tachyon/git/commits{/sha}","comments_url":"https://api.github.com/repos/amplab/tachyon/comments{/number}","issue_comment_url":"https://api.github.com/repos/amplab/tachyon/issues/comments{/number}","contents_url":"https://api.github.com/repos/amplab/tachyon/contents/{+path}","compare_url":"https://api.github.com/repos/amplab/tachyon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/amplab/tachyon/merges","archive_url":"https://api.github.com/repos/amplab/tachyon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/amplab/tachyon/downloads","issues_url":"https://api.github.com/repos/amplab/tachyon/issues{/number}","pulls_url":"https://api.github.com/repos/amplab/tachyon/pulls{/number}","milestones_url":"https://api.github.com/repos/amplab/tachyon/milestones{/number}","notifications_url":"https://api.github.com/repos/amplab/tachyon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/amplab/tachyon/labels{/name}","releases_url":"https://api.github.com/repos/amplab/tachyon/releases{/id}","created_at":"2012-12-21T17:43:46Z","updated_at":"2015-07-03T04:35:21Z","pushed_at":"2015-07-03T03:11:23Z","git_url":"git://github.com/amplab/tachyon.git","ssh_url":"git@github.com:amplab/tachyon.git","clone_url":"https://github.com/amplab/tachyon.git","svn_url":"https://github.com/amplab/tachyon","homepage":"http://tachyon-project.org","size":34472,"stargazers_count":1462,"watchers_count":1462,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":539,"mirror_url":null,"open_issues_count":23,"forks":539,"open_issues":23,"watchers":1462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1031"},"html":{"href":"https://github.com/amplab/tachyon/pull/1031"},"issue":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1031"},"comments":{"href":"https://api.github.com/repos/amplab/tachyon/issues/1031/comments"},"review_comments":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1031/comments"},"review_comment":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/amplab/tachyon/pulls/1031/commits"},"statuses":{"href":"https://api.github.com/repos/amplab/tachyon/statuses/9a2568c7b9aaa4ada2b60b833b685e9819657477"}}}}