{"action":"created","comment":{"url":"https://api.github.com/repos/coreos/rocket/pulls/comments/23841774","id":23841774,"diff_hunk":"@@ -20,9 +20,12 @@ for d in networking/plugins/*; do\n \tgo install ${REPO_PATH}/$d\n done\n \n+echo \"Building rkt (stage0)...\"\n+go build -o $GOBIN/rkt ${REPO_PATH}/rkt\n+\n if [[ \"$OSTYPE\" == \"linux-gnu\" ]]; then\n \techo \"Building init (stage1)...\"\n-\tgo build -o $GOBIN/init ${REPO_PATH}/stage1/init\n+\tgo install ${REPO_PATH}/stage1/init","path":"build","position":10,"original_position":10,"commit_id":"357a12dc7d76468ba881225e87e51b0eea1d257b","original_commit_id":"151e20c2378dab6862f0f689b90d79d2a98593db","user":{"login":"jonboulle","id":2601015,"avatar_url":"https://avatars.githubusercontent.com/u/2601015?v=3","gravatar_id":"","url":"https://api.github.com/users/jonboulle","html_url":"https://github.com/jonboulle","followers_url":"https://api.github.com/users/jonboulle/followers","following_url":"https://api.github.com/users/jonboulle/following{/other_user}","gists_url":"https://api.github.com/users/jonboulle/gists{/gist_id}","starred_url":"https://api.github.com/users/jonboulle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonboulle/subscriptions","organizations_url":"https://api.github.com/users/jonboulle/orgs","repos_url":"https://api.github.com/users/jonboulle/repos","events_url":"https://api.github.com/users/jonboulle/events{/privacy}","received_events_url":"https://api.github.com/users/jonboulle/received_events","type":"User","site_admin":false},"body":"ah! great catch. Can we use go back to using go install for rkt too then?","created_at":"2015-01-30T13:26:04Z","updated_at":"2015-01-30T13:26:04Z","html_url":"https://github.com/coreos/rocket/pull/436#discussion_r23841774","pull_request_url":"https://api.github.com/repos/coreos/rocket/pulls/436","_links":{"self":{"href":"https://api.github.com/repos/coreos/rocket/pulls/comments/23841774"},"html":{"href":"https://github.com/coreos/rocket/pull/436#discussion_r23841774"},"pull_request":{"href":"https://api.github.com/repos/coreos/rocket/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/coreos/rocket/pulls/436","id":28160536,"html_url":"https://github.com/coreos/rocket/pull/436","diff_url":"https://github.com/coreos/rocket/pull/436.diff","patch_url":"https://github.com/coreos/rocket/pull/436.patch","issue_url":"https://api.github.com/repos/coreos/rocket/issues/436","number":436,"state":"open","locked":false,"title":"*: switch stage1 to aci image format","user":{"login":"vcaputo","id":1452963,"avatar_url":"https://avatars.githubusercontent.com/u/1452963?v=3","gravatar_id":"","url":"https://api.github.com/users/vcaputo","html_url":"https://github.com/vcaputo","followers_url":"https://api.github.com/users/vcaputo/followers","following_url":"https://api.github.com/users/vcaputo/following{/other_user}","gists_url":"https://api.github.com/users/vcaputo/gists{/gist_id}","starred_url":"https://api.github.com/users/vcaputo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcaputo/subscriptions","organizations_url":"https://api.github.com/users/vcaputo/orgs","repos_url":"https://api.github.com/users/vcaputo/repos","events_url":"https://api.github.com/users/vcaputo/events{/privacy}","received_events_url":"https://api.github.com/users/vcaputo/received_events","type":"User","site_admin":false},"body":"One may now specify an alternative stage1 in a style like run and fetch:\r\nrkt run --stage1-image foo.com/rocket/stage1 app\r\n\r\n--stage1-image currently defaults to \"stage1.aci\", which requires running\r\n`rkt run` from the rocket source root to use the bundled stage1.","created_at":"2015-01-28T01:15:28Z","updated_at":"2015-01-30T13:26:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58dff50a48f2d20b246e2d0dcfd66c3ce8beee22","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/coreos/rocket/pulls/436/commits","review_comments_url":"https://api.github.com/repos/coreos/rocket/pulls/436/comments","review_comment_url":"https://api.github.com/repos/coreos/rocket/pulls/comments/{number}","comments_url":"https://api.github.com/repos/coreos/rocket/issues/436/comments","statuses_url":"https://api.github.com/repos/coreos/rocket/statuses/357a12dc7d76468ba881225e87e51b0eea1d257b","head":{"label":"vcaputo:stage1_aci","ref":"stage1_aci","sha":"357a12dc7d76468ba881225e87e51b0eea1d257b","user":{"login":"vcaputo","id":1452963,"avatar_url":"https://avatars.githubusercontent.com/u/1452963?v=3","gravatar_id":"","url":"https://api.github.com/users/vcaputo","html_url":"https://github.com/vcaputo","followers_url":"https://api.github.com/users/vcaputo/followers","following_url":"https://api.github.com/users/vcaputo/following{/other_user}","gists_url":"https://api.github.com/users/vcaputo/gists{/gist_id}","starred_url":"https://api.github.com/users/vcaputo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcaputo/subscriptions","organizations_url":"https://api.github.com/users/vcaputo/orgs","repos_url":"https://api.github.com/users/vcaputo/repos","events_url":"https://api.github.com/users/vcaputo/events{/privacy}","received_events_url":"https://api.github.com/users/vcaputo/received_events","type":"User","site_admin":false},"repo":{"id":27401830,"name":"rocket","full_name":"vcaputo/rocket","owner":{"login":"vcaputo","id":1452963,"avatar_url":"https://avatars.githubusercontent.com/u/1452963?v=3","gravatar_id":"","url":"https://api.github.com/users/vcaputo","html_url":"https://github.com/vcaputo","followers_url":"https://api.github.com/users/vcaputo/followers","following_url":"https://api.github.com/users/vcaputo/following{/other_user}","gists_url":"https://api.github.com/users/vcaputo/gists{/gist_id}","starred_url":"https://api.github.com/users/vcaputo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcaputo/subscriptions","organizations_url":"https://api.github.com/users/vcaputo/orgs","repos_url":"https://api.github.com/users/vcaputo/repos","events_url":"https://api.github.com/users/vcaputo/events{/privacy}","received_events_url":"https://api.github.com/users/vcaputo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vcaputo/rocket","description":"App Container runtime","fork":true,"url":"https://api.github.com/repos/vcaputo/rocket","forks_url":"https://api.github.com/repos/vcaputo/rocket/forks","keys_url":"https://api.github.com/repos/vcaputo/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vcaputo/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vcaputo/rocket/teams","hooks_url":"https://api.github.com/repos/vcaputo/rocket/hooks","issue_events_url":"https://api.github.com/repos/vcaputo/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/vcaputo/rocket/events","assignees_url":"https://api.github.com/repos/vcaputo/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/vcaputo/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/vcaputo/rocket/tags","blobs_url":"https://api.github.com/repos/vcaputo/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vcaputo/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vcaputo/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/vcaputo/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vcaputo/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/vcaputo/rocket/languages","stargazers_url":"https://api.github.com/repos/vcaputo/rocket/stargazers","contributors_url":"https://api.github.com/repos/vcaputo/rocket/contributors","subscribers_url":"https://api.github.com/repos/vcaputo/rocket/subscribers","subscription_url":"https://api.github.com/repos/vcaputo/rocket/subscription","commits_url":"https://api.github.com/repos/vcaputo/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/vcaputo/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/vcaputo/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/vcaputo/rocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/vcaputo/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/vcaputo/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vcaputo/rocket/merges","archive_url":"https://api.github.com/repos/vcaputo/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vcaputo/rocket/downloads","issues_url":"https://api.github.com/repos/vcaputo/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/vcaputo/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/vcaputo/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/vcaputo/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vcaputo/rocket/labels{/name}","releases_url":"https://api.github.com/repos/vcaputo/rocket/releases{/id}","created_at":"2014-12-01T21:54:09Z","updated_at":"2014-12-01T21:54:10Z","pushed_at":"2015-01-30T02:24:19Z","git_url":"git://github.com/vcaputo/rocket.git","ssh_url":"git@github.com:vcaputo/rocket.git","clone_url":"https://github.com/vcaputo/rocket.git","svn_url":"https://github.com/vcaputo/rocket","homepage":"","size":1925,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"d7fd275ea42aad6090e47f58a5a3e6988f0f4e7c","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":26509369,"name":"rocket","full_name":"coreos/rocket","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars.githubusercontent.com/u/3730757?v=3","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/rocket","description":"App Container runtime","fork":false,"url":"https://api.github.com/repos/coreos/rocket","forks_url":"https://api.github.com/repos/coreos/rocket/forks","keys_url":"https://api.github.com/repos/coreos/rocket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/rocket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/rocket/teams","hooks_url":"https://api.github.com/repos/coreos/rocket/hooks","issue_events_url":"https://api.github.com/repos/coreos/rocket/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/rocket/events","assignees_url":"https://api.github.com/repos/coreos/rocket/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/rocket/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/rocket/tags","blobs_url":"https://api.github.com/repos/coreos/rocket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/rocket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/rocket/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/rocket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/rocket/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/rocket/languages","stargazers_url":"https://api.github.com/repos/coreos/rocket/stargazers","contributors_url":"https://api.github.com/repos/coreos/rocket/contributors","subscribers_url":"https://api.github.com/repos/coreos/rocket/subscribers","subscription_url":"https://api.github.com/repos/coreos/rocket/subscription","commits_url":"https://api.github.com/repos/coreos/rocket/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/rocket/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/rocket/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/rocket/issues/comments/{number}","contents_url":"https://api.github.com/repos/coreos/rocket/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/rocket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/rocket/merges","archive_url":"https://api.github.com/repos/coreos/rocket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/rocket/downloads","issues_url":"https://api.github.com/repos/coreos/rocket/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/rocket/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/rocket/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/rocket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/rocket/labels{/name}","releases_url":"https://api.github.com/repos/coreos/rocket/releases{/id}","created_at":"2014-11-11T23:13:18Z","updated_at":"2015-01-30T13:16:19Z","pushed_at":"2015-01-30T13:16:19Z","git_url":"git://github.com/coreos/rocket.git","ssh_url":"git@github.com:coreos/rocket.git","clone_url":"https://github.com/coreos/rocket.git","svn_url":"https://github.com/coreos/rocket","homepage":"","size":8508,"stargazers_count":3282,"watchers_count":3282,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":222,"mirror_url":null,"open_issues_count":61,"forks":222,"open_issues":61,"watchers":3282,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/rocket/pulls/436"},"html":{"href":"https://github.com/coreos/rocket/pull/436"},"issue":{"href":"https://api.github.com/repos/coreos/rocket/issues/436"},"comments":{"href":"https://api.github.com/repos/coreos/rocket/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/rocket/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/rocket/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/coreos/rocket/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/rocket/statuses/357a12dc7d76468ba881225e87e51b0eea1d257b"}}}}