{"action":"created","issue":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/360","labels_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/360/labels{/name}","comments_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/360/comments","events_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/360/events","html_url":"https://github.com/gemini-hlsw/ocs/pull/360","id":74185525,"number":360,"title":"OCSADV-272: GEMS AGS Strategy","user":{"login":"cquiroz","id":3615303,"avatar_url":"https://avatars.githubusercontent.com/u/3615303?v=3","gravatar_id":"","url":"https://api.github.com/users/cquiroz","html_url":"https://github.com/cquiroz","followers_url":"https://api.github.com/users/cquiroz/followers","following_url":"https://api.github.com/users/cquiroz/following{/other_user}","gists_url":"https://api.github.com/users/cquiroz/gists{/gist_id}","starred_url":"https://api.github.com/users/cquiroz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cquiroz/subscriptions","organizations_url":"https://api.github.com/users/cquiroz/orgs","repos_url":"https://api.github.com/users/cquiroz/repos","events_url":"https://api.github.com/users/cquiroz/events{/privacy}","received_events_url":"https://api.github.com/users/cquiroz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-05-08T01:23:02Z","updated_at":"2015-05-08T13:47:19Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/pulls/360","html_url":"https://github.com/gemini-hlsw/ocs/pull/360","diff_url":"https://github.com/gemini-hlsw/ocs/pull/360.diff","patch_url":"https://github.com/gemini-hlsw/ocs/pull/360.patch"},"body":"This PR contains multiple fixes to get Gems AGS to work using several bands as R-like, (including r', R and UC). The implication of the band selection change touched quite a few pieces of Gems AGS and created some regressions with a simpler implementation. Multiple tests were added to ensure the algorithm didn't fundamentally change.\r\n\r\nThis PR includes:\r\n* Fixes Gems AGS to work with R-Like magnitudes including multiple tests\r\n* Fixes bogus magnitude sorting\r\n* Fix for regressions and their respective test using UCAC3 canned data\r\n* Fixes Mascot to properly extract the appropriate R-Like magnitude\r\n* Restore proper order of cwfs targets ensuring that cwfs3 gets the brightest of the stars based on R-like magnitudes\r\n* Fix for the analyze method for Gems and proper linking to the Guiding Feedback shown in the OT\r\n* Conversion of most of the code to Scala\r\n* Replaces the control flow of interruptible `analyzeGoodEnough` using exceptions to a more proper flow using callbacks\r\n* Removes debugging when getting the catalog data\r\n\r\nThe screenshot below shows the result of a search with the feedback magnitudes properly displayed\r\n\r\n![screenshot 2015-05-07 14 14 48](https://cloud.githubusercontent.com/assets/3615303/7527456/b4ad5cce-f4f1-11e4-9190-73262a0f588e.png)\r\n\r\nSorry for the size of the PR though quite a bit is unit tests"},"comment":{"url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/comments/100238150","html_url":"https://github.com/gemini-hlsw/ocs/pull/360#issuecomment-100238150","issue_url":"https://api.github.com/repos/gemini-hlsw/ocs/issues/360","id":100238150,"user":{"login":"swalker2m","id":4906023,"avatar_url":"https://avatars.githubusercontent.com/u/4906023?v=3","gravatar_id":"","url":"https://api.github.com/users/swalker2m","html_url":"https://github.com/swalker2m","followers_url":"https://api.github.com/users/swalker2m/followers","following_url":"https://api.github.com/users/swalker2m/following{/other_user}","gists_url":"https://api.github.com/users/swalker2m/gists{/gist_id}","starred_url":"https://api.github.com/users/swalker2m/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swalker2m/subscriptions","organizations_url":"https://api.github.com/users/swalker2m/orgs","repos_url":"https://api.github.com/users/swalker2m/repos","events_url":"https://api.github.com/users/swalker2m/events{/privacy}","received_events_url":"https://api.github.com/users/swalker2m/received_events","type":"User","site_admin":false},"created_at":"2015-05-08T13:47:19Z","updated_at":"2015-05-08T13:47:19Z","body":"> Conversion of most of the code to Scala\r\n\r\nWe're better off for it, but that was quite a lot to bite off!  Was it just too overwhelming to work directly with the old implementation?  You're definitely the Mascot expert now.\r\n\r\nWe should get this merged in for the test release today.  :+1: "}}