{"action":"created","issue":{"url":"https://api.github.com/repos/google/material-design-lite/issues/1762","labels_url":"https://api.github.com/repos/google/material-design-lite/issues/1762/labels{/name}","comments_url":"https://api.github.com/repos/google/material-design-lite/issues/1762/comments","events_url":"https://api.github.com/repos/google/material-design-lite/issues/1762/events","html_url":"https://github.com/google/material-design-lite/pull/1762","id":111982391,"number":1762,"title":"Add Dialog","user":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/material-design-lite/labels/cla:%20yes","name":"cla: yes","color":"009800"},{"url":"https://api.github.com/repos/google/material-design-lite/labels/P0","name":"P0","color":"E90974"}],"state":"open","locked":false,"assignee":{"login":"samccone","id":883126,"avatar_url":"https://avatars.githubusercontent.com/u/883126?v=3","gravatar_id":"","url":"https://api.github.com/users/samccone","html_url":"https://github.com/samccone","followers_url":"https://api.github.com/users/samccone/followers","following_url":"https://api.github.com/users/samccone/following{/other_user}","gists_url":"https://api.github.com/users/samccone/gists{/gist_id}","starred_url":"https://api.github.com/users/samccone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samccone/subscriptions","organizations_url":"https://api.github.com/users/samccone/orgs","repos_url":"https://api.github.com/users/samccone/repos","events_url":"https://api.github.com/users/samccone/events{/privacy}","received_events_url":"https://api.github.com/users/samccone/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/google/material-design-lite/milestones/3","html_url":"https://github.com/google/material-design-lite/milestones/V1.1","labels_url":"https://api.github.com/repos/google/material-design-lite/milestones/3/labels","id":1202434,"number":3,"title":"V1.1","description":"First minor update!\r\n\r\nFull plans not yet set out, purely informational at the moment.","creator":{"login":"Garbee","id":868301,"avatar_url":"https://avatars.githubusercontent.com/u/868301?v=3","gravatar_id":"","url":"https://api.github.com/users/Garbee","html_url":"https://github.com/Garbee","followers_url":"https://api.github.com/users/Garbee/followers","following_url":"https://api.github.com/users/Garbee/following{/other_user}","gists_url":"https://api.github.com/users/Garbee/gists{/gist_id}","starred_url":"https://api.github.com/users/Garbee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Garbee/subscriptions","organizations_url":"https://api.github.com/users/Garbee/orgs","repos_url":"https://api.github.com/users/Garbee/repos","events_url":"https://api.github.com/users/Garbee/events{/privacy}","received_events_url":"https://api.github.com/users/Garbee/received_events","type":"User","site_admin":false},"open_issues":38,"closed_issues":44,"state":"open","created_at":"2015-07-10T12:50:28Z","updated_at":"2015-10-30T14:19:12Z","due_on":"2015-11-30T00:00:00Z","closed_at":null},"comments":10,"created_at":"2015-10-17T20:07:19Z","updated_at":"2015-10-30T17:17:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/material-design-lite/pulls/1762","html_url":"https://github.com/google/material-design-lite/pull/1762","diff_url":"https://github.com/google/material-design-lite/pull/1762.diff","patch_url":"https://github.com/google/material-design-lite/pull/1762.patch"},"body":"Basic dialog component. Implements a small shim of the [dialog element's](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dialog) API in userland. This allows developers to more easily upgrade to native dialogs when they are more widely implemented.\r\n\r\nThis component is *not* built to handle multiple dialog's stacking. This functionality is not specified in MD therefore it is not supported. Native dialog's handle this naturally if that is needed, otherwise it is up to developers to implement that on their own.\r\n\r\n### TODO\r\n\r\n* [x] Unit tests\r\n* [x] Memory tests\r\n\r\n### Known issues:\r\n* If the dialog overflows the viewport, you can't get to the actions. No MD guidance on how this should be handled at the moment. Initial action is to add `overflow-y: scroll; max-height: 100%;` to `mdl-dialog`. That will allow the dialog to scroll when this case arises, however I'm open to other suggestions as well.\r\n* On smaller screens the spacing may defer from the spec. I set the top to have 5% spacing for the dialog up to 475px screen heights where it then becomes 35% to align fairly closely to the center of screens.\r\n\r\n### After merge\r\n\r\nOnce the merge is completed, we will then setup the documentation pages to render on the microsite. This is being tracked in issue #1761.\r\n"},"comment":{"url":"https://api.github.com/repos/google/material-design-lite/issues/comments/152591597","html_url":"https://github.com/google/material-design-lite/pull/1762#issuecomment-152591597","issue_url":"https://api.github.com/repos/google/material-design-lite/issues/1762","id":152591597,"user":{"login":"lastid","id":1442947,"avatar_url":"https://avatars.githubusercontent.com/u/1442947?v=3","gravatar_id":"","url":"https://api.github.com/users/lastid","html_url":"https://github.com/lastid","followers_url":"https://api.github.com/users/lastid/followers","following_url":"https://api.github.com/users/lastid/following{/other_user}","gists_url":"https://api.github.com/users/lastid/gists{/gist_id}","starred_url":"https://api.github.com/users/lastid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lastid/subscriptions","organizations_url":"https://api.github.com/users/lastid/orgs","repos_url":"https://api.github.com/users/lastid/repos","events_url":"https://api.github.com/users/lastid/events{/privacy}","received_events_url":"https://api.github.com/users/lastid/received_events","type":"User","site_admin":false},"created_at":"2015-10-30T17:17:00Z","updated_at":"2015-10-30T17:17:00Z","body":"> Calling out the (very minor) button padding in order to say no one on the team knows MD well. That remark is very disrespectful.\r\n\r\nI dont mean to disrespect anyone. You guys are doing a great job,  mdl is still young. But this is a project about a design concept, it worries me that there is no **designers on the team**. And you confirmed that fact, even you have access to an external team.\r\n\r\nI am not a designer. If you have a designer on your team, please ask them why they use the 'caption' text color #757575 in the [original specs page](https://www.google.com/design/spec/style/typography.html) as the main text color on this project's website (**home page** and docs), the 2 websites have the same background btw. Do you think it's a minor issue? Because I spend time to read the docs, it hurts my eyes personally. And how long getmdl.io has been up and running?\r\n\r\nI understand perfectly that adding something which might change in the future is a pain, not only for the team but also to people who use the library. But adding small things that stick to common sense and already exist in existing products (origin of the concept) is reasonable.\r\n\r\nCheers!\r\n\r\n(What am I doing, try to win an argument on the internet... sigh)"}}