{"action":"opened","number":551,"pull_request":{"url":"https://api.github.com/repos/alphagov/rummager/pulls/551","id":53006090,"html_url":"https://github.com/alphagov/rummager/pull/551","diff_url":"https://github.com/alphagov/rummager/pull/551.diff","patch_url":"https://github.com/alphagov/rummager/pull/551.patch","issue_url":"https://api.github.com/repos/alphagov/rummager/issues/551","number":551,"state":"open","locked":false,"title":"Improve TaxonFinder unit test","user":{"login":"mobaig","id":519250,"avatar_url":"https://avatars.githubusercontent.com/u/519250?v=3","gravatar_id":"","url":"https://api.github.com/users/mobaig","html_url":"https://github.com/mobaig","followers_url":"https://api.github.com/users/mobaig/followers","following_url":"https://api.github.com/users/mobaig/following{/other_user}","gists_url":"https://api.github.com/users/mobaig/gists{/gist_id}","starred_url":"https://api.github.com/users/mobaig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mobaig/subscriptions","organizations_url":"https://api.github.com/users/mobaig/orgs","repos_url":"https://api.github.com/users/mobaig/repos","events_url":"https://api.github.com/users/mobaig/events{/privacy}","received_events_url":"https://api.github.com/users/mobaig/received_events","type":"User","site_admin":false},"body":"This now exercises the logic in TaxonFinder using a tempfile that contains\r\nfixture data that matches the form expected of a typical input CSV file.\r\nThis approach more completely tests the unit as a whole, including the\r\nconfig for how a CSV should be ready.","created_at":"2015-12-08T16:47:44Z","updated_at":"2015-12-08T16:47:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/rummager/pulls/551/commits","review_comments_url":"https://api.github.com/repos/alphagov/rummager/pulls/551/comments","review_comment_url":"https://api.github.com/repos/alphagov/rummager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/rummager/issues/551/comments","statuses_url":"https://api.github.com/repos/alphagov/rummager/statuses/5429667385882c59c6df656825deabd2f0cc6ca9","head":{"label":"alphagov:mb_alpha_tax_logging","ref":"mb_alpha_tax_logging","sha":"5429667385882c59c6df656825deabd2f0cc6ca9","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2686767,"name":"rummager","full_name":"alphagov/rummager","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/rummager","description":"Rummager is the internal GOV.UK API for search.","fork":false,"url":"https://api.github.com/repos/alphagov/rummager","forks_url":"https://api.github.com/repos/alphagov/rummager/forks","keys_url":"https://api.github.com/repos/alphagov/rummager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/rummager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/rummager/teams","hooks_url":"https://api.github.com/repos/alphagov/rummager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/rummager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/rummager/events","assignees_url":"https://api.github.com/repos/alphagov/rummager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/rummager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/rummager/tags","blobs_url":"https://api.github.com/repos/alphagov/rummager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/rummager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/rummager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/rummager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/rummager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/rummager/languages","stargazers_url":"https://api.github.com/repos/alphagov/rummager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/rummager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/rummager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/rummager/subscription","commits_url":"https://api.github.com/repos/alphagov/rummager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/rummager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/rummager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/rummager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/rummager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/rummager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/rummager/merges","archive_url":"https://api.github.com/repos/alphagov/rummager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/rummager/downloads","issues_url":"https://api.github.com/repos/alphagov/rummager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/rummager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/rummager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/rummager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/rummager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/rummager/releases{/id}","created_at":"2011-11-01T10:12:45Z","updated_at":"2015-11-05T15:02:01Z","pushed_at":"2015-12-08T16:47:44Z","git_url":"git://github.com/alphagov/rummager.git","ssh_url":"git@github.com:alphagov/rummager.git","clone_url":"https://github.com/alphagov/rummager.git","svn_url":"https://github.com/alphagov/rummager","homepage":"https://www.gov.uk/api/search.json?q=","size":3775,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":28,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"b9cfee840a3c80bb0088a6415472b48ff1172da6","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":2686767,"name":"rummager","full_name":"alphagov/rummager","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/rummager","description":"Rummager is the internal GOV.UK API for search.","fork":false,"url":"https://api.github.com/repos/alphagov/rummager","forks_url":"https://api.github.com/repos/alphagov/rummager/forks","keys_url":"https://api.github.com/repos/alphagov/rummager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/rummager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/rummager/teams","hooks_url":"https://api.github.com/repos/alphagov/rummager/hooks","issue_events_url":"https://api.github.com/repos/alphagov/rummager/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/rummager/events","assignees_url":"https://api.github.com/repos/alphagov/rummager/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/rummager/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/rummager/tags","blobs_url":"https://api.github.com/repos/alphagov/rummager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/rummager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/rummager/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/rummager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/rummager/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/rummager/languages","stargazers_url":"https://api.github.com/repos/alphagov/rummager/stargazers","contributors_url":"https://api.github.com/repos/alphagov/rummager/contributors","subscribers_url":"https://api.github.com/repos/alphagov/rummager/subscribers","subscription_url":"https://api.github.com/repos/alphagov/rummager/subscription","commits_url":"https://api.github.com/repos/alphagov/rummager/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/rummager/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/rummager/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/rummager/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/rummager/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/rummager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/rummager/merges","archive_url":"https://api.github.com/repos/alphagov/rummager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/rummager/downloads","issues_url":"https://api.github.com/repos/alphagov/rummager/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/rummager/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/rummager/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/rummager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/rummager/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/rummager/releases{/id}","created_at":"2011-11-01T10:12:45Z","updated_at":"2015-11-05T15:02:01Z","pushed_at":"2015-12-08T16:47:44Z","git_url":"git://github.com/alphagov/rummager.git","ssh_url":"git@github.com:alphagov/rummager.git","clone_url":"https://github.com/alphagov/rummager.git","svn_url":"https://github.com/alphagov/rummager","homepage":"https://www.gov.uk/api/search.json?q=","size":3775,"stargazers_count":28,"watchers_count":28,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":1,"forks":8,"open_issues":1,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/551"},"html":{"href":"https://github.com/alphagov/rummager/pull/551"},"issue":{"href":"https://api.github.com/repos/alphagov/rummager/issues/551"},"comments":{"href":"https://api.github.com/repos/alphagov/rummager/issues/551/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/551/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/rummager/pulls/551/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/rummager/statuses/5429667385882c59c6df656825deabd2f0cc6ca9"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":10,"deletions":4,"changed_files":1}}