{"action":"closed","number":5484,"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/5484","id":50194427,"html_url":"https://github.com/scipy/scipy/pull/5484","diff_url":"https://github.com/scipy/scipy/pull/5484.diff","patch_url":"https://github.com/scipy/scipy/pull/5484.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/5484","number":5484,"state":"closed","locked":false,"title":"BUG: fix ttest zero division handling","user":{"login":"andim","id":2394707,"avatar_url":"https://avatars.githubusercontent.com/u/2394707?v=3","gravatar_id":"","url":"https://api.github.com/users/andim","html_url":"https://github.com/andim","followers_url":"https://api.github.com/users/andim/followers","following_url":"https://api.github.com/users/andim/following{/other_user}","gists_url":"https://api.github.com/users/andim/gists{/gist_id}","starred_url":"https://api.github.com/users/andim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andim/subscriptions","organizations_url":"https://api.github.com/users/andim/orgs","repos_url":"https://api.github.com/users/andim/repos","events_url":"https://api.github.com/users/andim/events{/privacy}","received_events_url":"https://api.github.com/users/andim/received_events","type":"User","site_admin":false},"body":"The ttest function in `scipy.stats` currently do not check for zero division caused by variances being zero. The behavior of a function call thus depends on the numpy error state. Depending on this state their might either be annoying warnings or exceptions will be raised.\r\n\r\nThis PR fixes these issues by performing explicit checks before division.","created_at":"2015-11-09T23:35:56Z","updated_at":"2015-11-15T21:38:19Z","closed_at":"2015-11-15T21:38:19Z","merged_at":"2015-11-15T21:38:19Z","merge_commit_sha":"0f99b3d01263549972d691650e5c31338fa0e270","assignee":null,"milestone":{"url":"https://api.github.com/repos/scipy/scipy/milestones/26","html_url":"https://github.com/scipy/scipy/milestones/0.17.0","labels_url":"https://api.github.com/repos/scipy/scipy/milestones/26/labels","id":1096839,"number":26,"title":"0.17.0","description":"","creator":{"login":"rgommers","id":98330,"avatar_url":"https://avatars.githubusercontent.com/u/98330?v=3","gravatar_id":"","url":"https://api.github.com/users/rgommers","html_url":"https://github.com/rgommers","followers_url":"https://api.github.com/users/rgommers/followers","following_url":"https://api.github.com/users/rgommers/following{/other_user}","gists_url":"https://api.github.com/users/rgommers/gists{/gist_id}","starred_url":"https://api.github.com/users/rgommers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgommers/subscriptions","organizations_url":"https://api.github.com/users/rgommers/orgs","repos_url":"https://api.github.com/users/rgommers/repos","events_url":"https://api.github.com/users/rgommers/events{/privacy}","received_events_url":"https://api.github.com/users/rgommers/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":227,"state":"open","created_at":"2015-05-05T13:00:06Z","updated_at":"2015-11-15T21:38:19Z","due_on":"2015-11-29T23:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/5484/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/5484/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/5484/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/ffdc8d2758c3b2e803278d599b46b5e3bb51563d","head":{"label":"andim:stats-ttest-zero-division","ref":"stats-ttest-zero-division","sha":"ffdc8d2758c3b2e803278d599b46b5e3bb51563d","user":{"login":"andim","id":2394707,"avatar_url":"https://avatars.githubusercontent.com/u/2394707?v=3","gravatar_id":"","url":"https://api.github.com/users/andim","html_url":"https://github.com/andim","followers_url":"https://api.github.com/users/andim/followers","following_url":"https://api.github.com/users/andim/following{/other_user}","gists_url":"https://api.github.com/users/andim/gists{/gist_id}","starred_url":"https://api.github.com/users/andim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andim/subscriptions","organizations_url":"https://api.github.com/users/andim/orgs","repos_url":"https://api.github.com/users/andim/repos","events_url":"https://api.github.com/users/andim/events{/privacy}","received_events_url":"https://api.github.com/users/andim/received_events","type":"User","site_admin":false},"repo":{"id":29191186,"name":"scipy","full_name":"andim/scipy","owner":{"login":"andim","id":2394707,"avatar_url":"https://avatars.githubusercontent.com/u/2394707?v=3","gravatar_id":"","url":"https://api.github.com/users/andim","html_url":"https://github.com/andim","followers_url":"https://api.github.com/users/andim/followers","following_url":"https://api.github.com/users/andim/following{/other_user}","gists_url":"https://api.github.com/users/andim/gists{/gist_id}","starred_url":"https://api.github.com/users/andim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andim/subscriptions","organizations_url":"https://api.github.com/users/andim/orgs","repos_url":"https://api.github.com/users/andim/repos","events_url":"https://api.github.com/users/andim/events{/privacy}","received_events_url":"https://api.github.com/users/andim/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andim/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/andim/scipy","forks_url":"https://api.github.com/repos/andim/scipy/forks","keys_url":"https://api.github.com/repos/andim/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andim/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andim/scipy/teams","hooks_url":"https://api.github.com/repos/andim/scipy/hooks","issue_events_url":"https://api.github.com/repos/andim/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/andim/scipy/events","assignees_url":"https://api.github.com/repos/andim/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/andim/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/andim/scipy/tags","blobs_url":"https://api.github.com/repos/andim/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andim/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andim/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/andim/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andim/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/andim/scipy/languages","stargazers_url":"https://api.github.com/repos/andim/scipy/stargazers","contributors_url":"https://api.github.com/repos/andim/scipy/contributors","subscribers_url":"https://api.github.com/repos/andim/scipy/subscribers","subscription_url":"https://api.github.com/repos/andim/scipy/subscription","commits_url":"https://api.github.com/repos/andim/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/andim/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/andim/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/andim/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/andim/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/andim/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andim/scipy/merges","archive_url":"https://api.github.com/repos/andim/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andim/scipy/downloads","issues_url":"https://api.github.com/repos/andim/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/andim/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/andim/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/andim/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andim/scipy/labels{/name}","releases_url":"https://api.github.com/repos/andim/scipy/releases{/id}","created_at":"2015-01-13T13:32:16Z","updated_at":"2015-01-13T13:32:24Z","pushed_at":"2015-11-15T20:25:38Z","git_url":"git://github.com/andim/scipy.git","ssh_url":"git@github.com:andim/scipy.git","clone_url":"https://github.com/andim/scipy.git","svn_url":"https://github.com/andim/scipy","homepage":"http://scipy.org/scipylib/","size":59428,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"b68e60a8a759205c19aca0bedc7c7d7ee13829fa","user":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"avatar_url":"https://avatars.githubusercontent.com/u/288277?v=3","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","created_at":"2011-03-09T18:52:03Z","updated_at":"2015-11-15T15:36:53Z","pushed_at":"2015-11-15T21:38:19Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"http://scipy.org/scipylib/","size":96398,"stargazers_count":1936,"watchers_count":1936,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1101,"mirror_url":null,"open_issues_count":907,"forks":1101,"open_issues":907,"watchers":1936,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/5484"},"html":{"href":"https://github.com/scipy/scipy/pull/5484"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/5484"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/5484/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/5484/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/5484/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/ffdc8d2758c3b2e803278d599b46b5e3bb51563d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ev-br","id":2133832,"avatar_url":"https://avatars.githubusercontent.com/u/2133832?v=3","gravatar_id":"","url":"https://api.github.com/users/ev-br","html_url":"https://github.com/ev-br","followers_url":"https://api.github.com/users/ev-br/followers","following_url":"https://api.github.com/users/ev-br/following{/other_user}","gists_url":"https://api.github.com/users/ev-br/gists{/gist_id}","starred_url":"https://api.github.com/users/ev-br/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev-br/subscriptions","organizations_url":"https://api.github.com/users/ev-br/orgs","repos_url":"https://api.github.com/users/ev-br/repos","events_url":"https://api.github.com/users/ev-br/events{/privacy}","received_events_url":"https://api.github.com/users/ev-br/received_events","type":"User","site_admin":false},"comments":11,"review_comments":12,"commits":2,"additions":90,"deletions":44,"changed_files":4}}