{"action":"created","comment":{"url":"https://api.github.com/repos/contiv/ansible/pulls/comments/47181805","id":47181805,"diff_hunk":"@@ -64,21 +72,9 @@ start)\n     ;;\n \n stop)\n-    {% if run_as == \"worker\" -%}\n-    echo \"==> no 'stop' action for proxy\"\n-    {% else -%}\n-    #XXX: do better cleanup like remove the member from the cluster only if it was started\n-    out=`etcdctl member list | grep {{ node_name }} | awk -F ':' '{print $1}'`\n-    if [ \"$out\" != \"\" ]; then\n-        echo \"==> removing member: \" $out\n-        etcdctl member remove $out\n-    fi\n-    {% endif -%}\n     ;;\n \n post-stop)\n-    #XXX: is there a case when we should not cleanup the data dir on stop?\n-    rm -rf $ETCD_DATA_DIR","path":"roles/etcd/templates/etcd.j2","position":35,"original_position":35,"commit_id":"038b04696a5092af6e6db0866d6f42b6f0f4b27c","original_commit_id":"038b04696a5092af6e6db0866d6f42b6f0f4b27c","user":{"login":"mapuri","id":9538438,"avatar_url":"https://avatars.githubusercontent.com/u/9538438?v=3","gravatar_id":"","url":"https://api.github.com/users/mapuri","html_url":"https://github.com/mapuri","followers_url":"https://api.github.com/users/mapuri/followers","following_url":"https://api.github.com/users/mapuri/following{/other_user}","gists_url":"https://api.github.com/users/mapuri/gists{/gist_id}","starred_url":"https://api.github.com/users/mapuri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapuri/subscriptions","organizations_url":"https://api.github.com/users/mapuri/orgs","repos_url":"https://api.github.com/users/mapuri/repos","events_url":"https://api.github.com/users/mapuri/events{/privacy}","received_events_url":"https://api.github.com/users/mapuri/received_events","type":"User","site_admin":false},"body":"Is this intentional? My undersatnd was that we need to remove the data-dir on service stop, so just curious if you were seeing any issue with data dir being removed.","created_at":"2015-12-10T02:14:17Z","updated_at":"2015-12-10T02:14:17Z","html_url":"https://github.com/contiv/ansible/pull/4#discussion_r47181805","pull_request_url":"https://api.github.com/repos/contiv/ansible/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/contiv/ansible/pulls/comments/47181805"},"html":{"href":"https://github.com/contiv/ansible/pull/4#discussion_r47181805"},"pull_request":{"href":"https://api.github.com/repos/contiv/ansible/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/contiv/ansible/pulls/4","id":53201506,"html_url":"https://github.com/contiv/ansible/pull/4","diff_url":"https://github.com/contiv/ansible/pull/4.diff","patch_url":"https://github.com/contiv/ansible/pull/4.patch","issue_url":"https://api.github.com/repos/contiv/ansible/issues/4","number":4,"state":"open","locked":false,"title":"Fix etcd","user":{"login":"erikh","id":18923,"avatar_url":"https://avatars.githubusercontent.com/u/18923?v=3","gravatar_id":"","url":"https://api.github.com/users/erikh","html_url":"https://github.com/erikh","followers_url":"https://api.github.com/users/erikh/followers","following_url":"https://api.github.com/users/erikh/following{/other_user}","gists_url":"https://api.github.com/users/erikh/gists{/gist_id}","starred_url":"https://api.github.com/users/erikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erikh/subscriptions","organizations_url":"https://api.github.com/users/erikh/orgs","repos_url":"https://api.github.com/users/erikh/repos","events_url":"https://api.github.com/users/erikh/events{/privacy}","received_events_url":"https://api.github.com/users/erikh/received_events","type":"User","site_admin":false},"body":"This apparently includes the ceph-install ansible as well, I'm not entirely sure why but if we could let this slide I would appreciate it, as it needs to be in here anyways.\r\n\r\nThis upgrades etcd and makes some changes to the init script to make it more reliable over a restart. I have validated that these fixes work, but the merge here iwth the ceph-install code means I'm revalidating while you guys are reviewing.\r\n\r\nThanks, if @jojimt and @mapuri have time to review that'd be really great.","created_at":"2015-12-10T00:52:07Z","updated_at":"2015-12-10T02:14:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef1a6c544dfd96bd1179802c2c0ec951e7857efc","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/contiv/ansible/pulls/4/commits","review_comments_url":"https://api.github.com/repos/contiv/ansible/pulls/4/comments","review_comment_url":"https://api.github.com/repos/contiv/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/contiv/ansible/issues/4/comments","statuses_url":"https://api.github.com/repos/contiv/ansible/statuses/038b04696a5092af6e6db0866d6f42b6f0f4b27c","head":{"label":"contiv:fix-etcd","ref":"fix-etcd","sha":"038b04696a5092af6e6db0866d6f42b6f0f4b27c","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":46880794,"name":"ansible","full_name":"contiv/ansible","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/ansible","description":"ansible scripts for contiv cluster","fork":false,"url":"https://api.github.com/repos/contiv/ansible","forks_url":"https://api.github.com/repos/contiv/ansible/forks","keys_url":"https://api.github.com/repos/contiv/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/ansible/teams","hooks_url":"https://api.github.com/repos/contiv/ansible/hooks","issue_events_url":"https://api.github.com/repos/contiv/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/ansible/events","assignees_url":"https://api.github.com/repos/contiv/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/ansible/tags","blobs_url":"https://api.github.com/repos/contiv/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/ansible/languages","stargazers_url":"https://api.github.com/repos/contiv/ansible/stargazers","contributors_url":"https://api.github.com/repos/contiv/ansible/contributors","subscribers_url":"https://api.github.com/repos/contiv/ansible/subscribers","subscription_url":"https://api.github.com/repos/contiv/ansible/subscription","commits_url":"https://api.github.com/repos/contiv/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/ansible/merges","archive_url":"https://api.github.com/repos/contiv/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/ansible/downloads","issues_url":"https://api.github.com/repos/contiv/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/ansible/labels{/name}","releases_url":"https://api.github.com/repos/contiv/ansible/releases{/id}","created_at":"2015-11-25T19:00:58Z","updated_at":"2015-11-26T13:32:19Z","pushed_at":"2015-12-10T00:52:07Z","git_url":"git://github.com/contiv/ansible.git","ssh_url":"git@github.com:contiv/ansible.git","clone_url":"https://github.com/contiv/ansible.git","svn_url":"https://github.com/contiv/ansible","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"contiv:master","ref":"master","sha":"26dc95a15bd02ed17f72410efab8c7182be0bbaf","user":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"repo":{"id":46880794,"name":"ansible","full_name":"contiv/ansible","owner":{"login":"contiv","id":10272443,"avatar_url":"https://avatars.githubusercontent.com/u/10272443?v=3","gravatar_id":"","url":"https://api.github.com/users/contiv","html_url":"https://github.com/contiv","followers_url":"https://api.github.com/users/contiv/followers","following_url":"https://api.github.com/users/contiv/following{/other_user}","gists_url":"https://api.github.com/users/contiv/gists{/gist_id}","starred_url":"https://api.github.com/users/contiv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/contiv/subscriptions","organizations_url":"https://api.github.com/users/contiv/orgs","repos_url":"https://api.github.com/users/contiv/repos","events_url":"https://api.github.com/users/contiv/events{/privacy}","received_events_url":"https://api.github.com/users/contiv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/contiv/ansible","description":"ansible scripts for contiv cluster","fork":false,"url":"https://api.github.com/repos/contiv/ansible","forks_url":"https://api.github.com/repos/contiv/ansible/forks","keys_url":"https://api.github.com/repos/contiv/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/contiv/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/contiv/ansible/teams","hooks_url":"https://api.github.com/repos/contiv/ansible/hooks","issue_events_url":"https://api.github.com/repos/contiv/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/contiv/ansible/events","assignees_url":"https://api.github.com/repos/contiv/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/contiv/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/contiv/ansible/tags","blobs_url":"https://api.github.com/repos/contiv/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/contiv/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/contiv/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/contiv/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/contiv/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/contiv/ansible/languages","stargazers_url":"https://api.github.com/repos/contiv/ansible/stargazers","contributors_url":"https://api.github.com/repos/contiv/ansible/contributors","subscribers_url":"https://api.github.com/repos/contiv/ansible/subscribers","subscription_url":"https://api.github.com/repos/contiv/ansible/subscription","commits_url":"https://api.github.com/repos/contiv/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/contiv/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/contiv/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/contiv/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/contiv/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/contiv/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/contiv/ansible/merges","archive_url":"https://api.github.com/repos/contiv/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/contiv/ansible/downloads","issues_url":"https://api.github.com/repos/contiv/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/contiv/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/contiv/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/contiv/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/contiv/ansible/labels{/name}","releases_url":"https://api.github.com/repos/contiv/ansible/releases{/id}","created_at":"2015-11-25T19:00:58Z","updated_at":"2015-11-26T13:32:19Z","pushed_at":"2015-12-10T00:52:07Z","git_url":"git://github.com/contiv/ansible.git","ssh_url":"git@github.com:contiv/ansible.git","clone_url":"https://github.com/contiv/ansible.git","svn_url":"https://github.com/contiv/ansible","homepage":null,"size":97,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":2,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/contiv/ansible/pulls/4"},"html":{"href":"https://github.com/contiv/ansible/pull/4"},"issue":{"href":"https://api.github.com/repos/contiv/ansible/issues/4"},"comments":{"href":"https://api.github.com/repos/contiv/ansible/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/contiv/ansible/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/contiv/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/contiv/ansible/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/contiv/ansible/statuses/038b04696a5092af6e6db0866d6f42b6f0f4b27c"}}}}