{"action":"created","comment":{"url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/comments/40722362","id":40722362,"diff_hunk":"@@ -46,11 +46,13 @@ class ::Chef::Recipe\n     source \"#{dist_dir}/init.d/chef-client.erb\"\n     mode 0755\n     variables(client_bin: client_bin)\n+    not_if { node['platform_family'] == 'freebsd'}","path":"recipes/cron.rb","position":4,"original_position":4,"commit_id":"02f3beaf676bf965caf1a45081ab7099a0ee2f88","original_commit_id":"02f3beaf676bf965caf1a45081ab7099a0ee2f88","user":{"login":"lamont-granquist","id":454857,"avatar_url":"https://avatars.githubusercontent.com/u/454857?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont-granquist","html_url":"https://github.com/lamont-granquist","followers_url":"https://api.github.com/users/lamont-granquist/followers","following_url":"https://api.github.com/users/lamont-granquist/following{/other_user}","gists_url":"https://api.github.com/users/lamont-granquist/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont-granquist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont-granquist/subscriptions","organizations_url":"https://api.github.com/users/lamont-granquist/orgs","repos_url":"https://api.github.com/users/lamont-granquist/repos","events_url":"https://api.github.com/users/lamont-granquist/events{/privacy}","received_events_url":"https://api.github.com/users/lamont-granquist/received_events","type":"User","site_admin":false},"body":"that should probably not be a not_if and should wrap the template completely so it doesn't even appear as a resource on freebsd.\r\n\r\nfoodcritic might get annoyed by this, but foodcritic can kinda suck it and you can use `# ~FCXYZ` to turn it off.","created_at":"2015-09-29T20:10:34Z","updated_at":"2015-09-29T20:10:34Z","html_url":"https://github.com/chef-cookbooks/chef-client/pull/343#discussion_r40722362","pull_request_url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/comments/40722362"},"html":{"href":"https://github.com/chef-cookbooks/chef-client/pull/343#discussion_r40722362"},"pull_request":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343","id":46232397,"html_url":"https://github.com/chef-cookbooks/chef-client/pull/343","diff_url":"https://github.com/chef-cookbooks/chef-client/pull/343.diff","patch_url":"https://github.com/chef-cookbooks/chef-client/pull/343.patch","issue_url":"https://api.github.com/repos/chef-cookbooks/chef-client/issues/343","number":343,"state":"open","locked":false,"title":"fixes for freebsd cron invocation and kitchen changes required to test","user":{"login":"lamont","id":84261,"avatar_url":"https://avatars.githubusercontent.com/u/84261?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont","html_url":"https://github.com/lamont","followers_url":"https://api.github.com/users/lamont/followers","following_url":"https://api.github.com/users/lamont/following{/other_user}","gists_url":"https://api.github.com/users/lamont/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont/subscriptions","organizations_url":"https://api.github.com/users/lamont/orgs","repos_url":"https://api.github.com/users/lamont/repos","events_url":"https://api.github.com/users/lamont/events{/privacy}","received_events_url":"https://api.github.com/users/lamont/received_events","type":"User","site_admin":false},"body":"the cron recipe would not converge under freebsd, there's no init.d equiv and I thought the cleanest way would be to put a pair of not_if guards on the two unneeded templates. I also had to add the '\"/bin/sh\"' to the .kitchen.yml to get kitchen to work at all with the freebsd box files. I tested that the freebsd/cron suite works under vagrant and that my '\"/bin/sh\"' changes do not break at least the ubuntu suites.","created_at":"2015-09-29T03:09:48Z","updated_at":"2015-09-29T20:10:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83caba6d0aec30b6b4135458a2d546ed84dc1f8b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343/commits","review_comments_url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343/comments","review_comment_url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chef-cookbooks/chef-client/issues/343/comments","statuses_url":"https://api.github.com/repos/chef-cookbooks/chef-client/statuses/02f3beaf676bf965caf1a45081ab7099a0ee2f88","head":{"label":"lamont:master","ref":"master","sha":"02f3beaf676bf965caf1a45081ab7099a0ee2f88","user":{"login":"lamont","id":84261,"avatar_url":"https://avatars.githubusercontent.com/u/84261?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont","html_url":"https://github.com/lamont","followers_url":"https://api.github.com/users/lamont/followers","following_url":"https://api.github.com/users/lamont/following{/other_user}","gists_url":"https://api.github.com/users/lamont/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont/subscriptions","organizations_url":"https://api.github.com/users/lamont/orgs","repos_url":"https://api.github.com/users/lamont/repos","events_url":"https://api.github.com/users/lamont/events{/privacy}","received_events_url":"https://api.github.com/users/lamont/received_events","type":"User","site_admin":false},"repo":{"id":43338548,"name":"chef-client","full_name":"lamont/chef-client","owner":{"login":"lamont","id":84261,"avatar_url":"https://avatars.githubusercontent.com/u/84261?v=3","gravatar_id":"","url":"https://api.github.com/users/lamont","html_url":"https://github.com/lamont","followers_url":"https://api.github.com/users/lamont/followers","following_url":"https://api.github.com/users/lamont/following{/other_user}","gists_url":"https://api.github.com/users/lamont/gists{/gist_id}","starred_url":"https://api.github.com/users/lamont/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lamont/subscriptions","organizations_url":"https://api.github.com/users/lamont/orgs","repos_url":"https://api.github.com/users/lamont/repos","events_url":"https://api.github.com/users/lamont/events{/privacy}","received_events_url":"https://api.github.com/users/lamont/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lamont/chef-client","description":"Development repository for Chef Client cookbook","fork":true,"url":"https://api.github.com/repos/lamont/chef-client","forks_url":"https://api.github.com/repos/lamont/chef-client/forks","keys_url":"https://api.github.com/repos/lamont/chef-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lamont/chef-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lamont/chef-client/teams","hooks_url":"https://api.github.com/repos/lamont/chef-client/hooks","issue_events_url":"https://api.github.com/repos/lamont/chef-client/issues/events{/number}","events_url":"https://api.github.com/repos/lamont/chef-client/events","assignees_url":"https://api.github.com/repos/lamont/chef-client/assignees{/user}","branches_url":"https://api.github.com/repos/lamont/chef-client/branches{/branch}","tags_url":"https://api.github.com/repos/lamont/chef-client/tags","blobs_url":"https://api.github.com/repos/lamont/chef-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lamont/chef-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lamont/chef-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/lamont/chef-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lamont/chef-client/statuses/{sha}","languages_url":"https://api.github.com/repos/lamont/chef-client/languages","stargazers_url":"https://api.github.com/repos/lamont/chef-client/stargazers","contributors_url":"https://api.github.com/repos/lamont/chef-client/contributors","subscribers_url":"https://api.github.com/repos/lamont/chef-client/subscribers","subscription_url":"https://api.github.com/repos/lamont/chef-client/subscription","commits_url":"https://api.github.com/repos/lamont/chef-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/lamont/chef-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/lamont/chef-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/lamont/chef-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/lamont/chef-client/contents/{+path}","compare_url":"https://api.github.com/repos/lamont/chef-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lamont/chef-client/merges","archive_url":"https://api.github.com/repos/lamont/chef-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lamont/chef-client/downloads","issues_url":"https://api.github.com/repos/lamont/chef-client/issues{/number}","pulls_url":"https://api.github.com/repos/lamont/chef-client/pulls{/number}","milestones_url":"https://api.github.com/repos/lamont/chef-client/milestones{/number}","notifications_url":"https://api.github.com/repos/lamont/chef-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lamont/chef-client/labels{/name}","releases_url":"https://api.github.com/repos/lamont/chef-client/releases{/id}","created_at":"2015-09-29T01:56:07Z","updated_at":"2015-09-29T01:56:08Z","pushed_at":"2015-09-29T03:26:00Z","git_url":"git://github.com/lamont/chef-client.git","ssh_url":"git@github.com:lamont/chef-client.git","clone_url":"https://github.com/lamont/chef-client.git","svn_url":"https://github.com/lamont/chef-client","homepage":"http://supermarket.chef.io/cookbooks/chef-client","size":761,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chef-cookbooks:master","ref":"master","sha":"64a6031949870cfe2526a5b2b0e051b321454304","user":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"repo":{"id":3720567,"name":"chef-client","full_name":"chef-cookbooks/chef-client","owner":{"login":"chef-cookbooks","id":3617830,"avatar_url":"https://avatars.githubusercontent.com/u/3617830?v=3","gravatar_id":"","url":"https://api.github.com/users/chef-cookbooks","html_url":"https://github.com/chef-cookbooks","followers_url":"https://api.github.com/users/chef-cookbooks/followers","following_url":"https://api.github.com/users/chef-cookbooks/following{/other_user}","gists_url":"https://api.github.com/users/chef-cookbooks/gists{/gist_id}","starred_url":"https://api.github.com/users/chef-cookbooks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chef-cookbooks/subscriptions","organizations_url":"https://api.github.com/users/chef-cookbooks/orgs","repos_url":"https://api.github.com/users/chef-cookbooks/repos","events_url":"https://api.github.com/users/chef-cookbooks/events{/privacy}","received_events_url":"https://api.github.com/users/chef-cookbooks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/chef-cookbooks/chef-client","description":"Development repository for Chef Client cookbook","fork":false,"url":"https://api.github.com/repos/chef-cookbooks/chef-client","forks_url":"https://api.github.com/repos/chef-cookbooks/chef-client/forks","keys_url":"https://api.github.com/repos/chef-cookbooks/chef-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chef-cookbooks/chef-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chef-cookbooks/chef-client/teams","hooks_url":"https://api.github.com/repos/chef-cookbooks/chef-client/hooks","issue_events_url":"https://api.github.com/repos/chef-cookbooks/chef-client/issues/events{/number}","events_url":"https://api.github.com/repos/chef-cookbooks/chef-client/events","assignees_url":"https://api.github.com/repos/chef-cookbooks/chef-client/assignees{/user}","branches_url":"https://api.github.com/repos/chef-cookbooks/chef-client/branches{/branch}","tags_url":"https://api.github.com/repos/chef-cookbooks/chef-client/tags","blobs_url":"https://api.github.com/repos/chef-cookbooks/chef-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chef-cookbooks/chef-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chef-cookbooks/chef-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/chef-cookbooks/chef-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chef-cookbooks/chef-client/statuses/{sha}","languages_url":"https://api.github.com/repos/chef-cookbooks/chef-client/languages","stargazers_url":"https://api.github.com/repos/chef-cookbooks/chef-client/stargazers","contributors_url":"https://api.github.com/repos/chef-cookbooks/chef-client/contributors","subscribers_url":"https://api.github.com/repos/chef-cookbooks/chef-client/subscribers","subscription_url":"https://api.github.com/repos/chef-cookbooks/chef-client/subscription","commits_url":"https://api.github.com/repos/chef-cookbooks/chef-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/chef-cookbooks/chef-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/chef-cookbooks/chef-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/chef-cookbooks/chef-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/chef-cookbooks/chef-client/contents/{+path}","compare_url":"https://api.github.com/repos/chef-cookbooks/chef-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chef-cookbooks/chef-client/merges","archive_url":"https://api.github.com/repos/chef-cookbooks/chef-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chef-cookbooks/chef-client/downloads","issues_url":"https://api.github.com/repos/chef-cookbooks/chef-client/issues{/number}","pulls_url":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls{/number}","milestones_url":"https://api.github.com/repos/chef-cookbooks/chef-client/milestones{/number}","notifications_url":"https://api.github.com/repos/chef-cookbooks/chef-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chef-cookbooks/chef-client/labels{/name}","releases_url":"https://api.github.com/repos/chef-cookbooks/chef-client/releases{/id}","created_at":"2012-03-14T18:12:10Z","updated_at":"2015-09-29T13:33:41Z","pushed_at":"2015-09-29T17:02:29Z","git_url":"git://github.com/chef-cookbooks/chef-client.git","ssh_url":"git@github.com:chef-cookbooks/chef-client.git","clone_url":"https://github.com/chef-cookbooks/chef-client.git","svn_url":"https://github.com/chef-cookbooks/chef-client","homepage":"http://supermarket.chef.io/cookbooks/chef-client","size":2952,"stargazers_count":115,"watchers_count":115,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":260,"mirror_url":null,"open_issues_count":28,"forks":260,"open_issues":28,"watchers":115,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343"},"html":{"href":"https://github.com/chef-cookbooks/chef-client/pull/343"},"issue":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/issues/343"},"comments":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/chef-cookbooks/chef-client/statuses/02f3beaf676bf965caf1a45081ab7099a0ee2f88"}}}}