{"action":"closed","number":684,"pull_request":{"url":"https://api.github.com/repos/spotify/helios/pulls/684","id":47204658,"html_url":"https://github.com/spotify/helios/pull/684","diff_url":"https://github.com/spotify/helios/pull/684.diff","patch_url":"https://github.com/spotify/helios/pull/684.patch","issue_url":"https://api.github.com/repos/spotify/helios/issues/684","number":684,"state":"closed","locked":false,"title":"refactor CliConfig to remove static reference to System.getenv()","user":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"body":"Storing the result of `System.getenv()` in a non-private static\nreference causes the tests that touch `CliConfig` to need to worry about\nsetting or resetting this reference for the environment variables it\nwants to simulate as being present for it's test case.\n\nRefactoring `CliConfig.fromUserConfig()` to require the caller to pass\nalong what it thinks it's environment variables are (which is only\ncalled from one place in non-test code) removes this need for the tests\nworry about cleanup and state.","created_at":"2015-10-08T20:50:46Z","updated_at":"2015-10-09T19:01:41Z","closed_at":"2015-10-09T19:01:41Z","merged_at":"2015-10-09T19:01:41Z","merge_commit_sha":"c2499e37aa8599bd775567c25f1c56310c486aa4","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/spotify/helios/pulls/684/commits","review_comments_url":"https://api.github.com/repos/spotify/helios/pulls/684/comments","review_comment_url":"https://api.github.com/repos/spotify/helios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/helios/issues/684/comments","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/5d9b49a514340b544349894d4197097a32fce26d","head":{"label":"mattnworb:refactor-CliConfig","ref":"refactor-CliConfig","sha":"5d9b49a514340b544349894d4197097a32fce26d","user":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"repo":{"id":26554386,"name":"helios","full_name":"mattnworb/helios","owner":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mattnworb/helios","description":"Docker container orchestration platform","fork":true,"url":"https://api.github.com/repos/mattnworb/helios","forks_url":"https://api.github.com/repos/mattnworb/helios/forks","keys_url":"https://api.github.com/repos/mattnworb/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattnworb/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattnworb/helios/teams","hooks_url":"https://api.github.com/repos/mattnworb/helios/hooks","issue_events_url":"https://api.github.com/repos/mattnworb/helios/issues/events{/number}","events_url":"https://api.github.com/repos/mattnworb/helios/events","assignees_url":"https://api.github.com/repos/mattnworb/helios/assignees{/user}","branches_url":"https://api.github.com/repos/mattnworb/helios/branches{/branch}","tags_url":"https://api.github.com/repos/mattnworb/helios/tags","blobs_url":"https://api.github.com/repos/mattnworb/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattnworb/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattnworb/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattnworb/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattnworb/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/mattnworb/helios/languages","stargazers_url":"https://api.github.com/repos/mattnworb/helios/stargazers","contributors_url":"https://api.github.com/repos/mattnworb/helios/contributors","subscribers_url":"https://api.github.com/repos/mattnworb/helios/subscribers","subscription_url":"https://api.github.com/repos/mattnworb/helios/subscription","commits_url":"https://api.github.com/repos/mattnworb/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattnworb/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattnworb/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattnworb/helios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattnworb/helios/contents/{+path}","compare_url":"https://api.github.com/repos/mattnworb/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattnworb/helios/merges","archive_url":"https://api.github.com/repos/mattnworb/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattnworb/helios/downloads","issues_url":"https://api.github.com/repos/mattnworb/helios/issues{/number}","pulls_url":"https://api.github.com/repos/mattnworb/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/mattnworb/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/mattnworb/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattnworb/helios/labels{/name}","releases_url":"https://api.github.com/repos/mattnworb/helios/releases{/id}","created_at":"2014-11-12T20:17:52Z","updated_at":"2015-02-03T18:31:29Z","pushed_at":"2015-10-09T18:45:42Z","git_url":"git://github.com/mattnworb/helios.git","ssh_url":"git@github.com:mattnworb/helios.git","clone_url":"https://github.com/mattnworb/helios.git","svn_url":"https://github.com/mattnworb/helios","homepage":null,"size":4482,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"efd96f5d342a94aa5942367c0db1fb48fdbb6a86","user":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":20171642,"name":"helios","full_name":"spotify/helios","owner":{"login":"spotify","id":251374,"avatar_url":"https://avatars.githubusercontent.com/u/251374?v=3","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/helios","description":"Docker container orchestration platform","fork":false,"url":"https://api.github.com/repos/spotify/helios","forks_url":"https://api.github.com/repos/spotify/helios/forks","keys_url":"https://api.github.com/repos/spotify/helios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/helios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/helios/teams","hooks_url":"https://api.github.com/repos/spotify/helios/hooks","issue_events_url":"https://api.github.com/repos/spotify/helios/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/helios/events","assignees_url":"https://api.github.com/repos/spotify/helios/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/helios/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/helios/tags","blobs_url":"https://api.github.com/repos/spotify/helios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/helios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/helios/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/helios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/helios/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/helios/languages","stargazers_url":"https://api.github.com/repos/spotify/helios/stargazers","contributors_url":"https://api.github.com/repos/spotify/helios/contributors","subscribers_url":"https://api.github.com/repos/spotify/helios/subscribers","subscription_url":"https://api.github.com/repos/spotify/helios/subscription","commits_url":"https://api.github.com/repos/spotify/helios/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/helios/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/helios/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/helios/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/helios/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/helios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/helios/merges","archive_url":"https://api.github.com/repos/spotify/helios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/helios/downloads","issues_url":"https://api.github.com/repos/spotify/helios/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/helios/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/helios/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/helios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/helios/labels{/name}","releases_url":"https://api.github.com/repos/spotify/helios/releases{/id}","created_at":"2014-05-26T02:29:06Z","updated_at":"2015-10-08T05:59:14Z","pushed_at":"2015-10-09T19:01:41Z","git_url":"git://github.com/spotify/helios.git","ssh_url":"git@github.com:spotify/helios.git","clone_url":"https://github.com/spotify/helios.git","svn_url":"https://github.com/spotify/helios","homepage":null,"size":11716,"stargazers_count":1066,"watchers_count":1066,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"open_issues_count":28,"forks":79,"open_issues":28,"watchers":1066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/helios/pulls/684"},"html":{"href":"https://github.com/spotify/helios/pull/684"},"issue":{"href":"https://api.github.com/repos/spotify/helios/issues/684"},"comments":{"href":"https://api.github.com/repos/spotify/helios/issues/684/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/helios/pulls/684/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/helios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/helios/pulls/684/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/helios/statuses/5d9b49a514340b544349894d4197097a32fce26d"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mattnworb","id":113840,"avatar_url":"https://avatars.githubusercontent.com/u/113840?v=3","gravatar_id":"","url":"https://api.github.com/users/mattnworb","html_url":"https://github.com/mattnworb","followers_url":"https://api.github.com/users/mattnworb/followers","following_url":"https://api.github.com/users/mattnworb/following{/other_user}","gists_url":"https://api.github.com/users/mattnworb/gists{/gist_id}","starred_url":"https://api.github.com/users/mattnworb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattnworb/subscriptions","organizations_url":"https://api.github.com/users/mattnworb/orgs","repos_url":"https://api.github.com/users/mattnworb/repos","events_url":"https://api.github.com/users/mattnworb/events{/privacy}","received_events_url":"https://api.github.com/users/mattnworb/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"commits":1,"additions":26,"deletions":48,"changed_files":4}}