{"action":"created","issue":{"url":"https://api.github.com/repos/openchargemap/ocm-system/issues/35","labels_url":"https://api.github.com/repos/openchargemap/ocm-system/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/openchargemap/ocm-system/issues/35/comments","events_url":"https://api.github.com/repos/openchargemap/ocm-system/issues/35/events","html_url":"https://github.com/openchargemap/ocm-system/pull/35","id":98688133,"number":35,"title":"Translations 03, partly fixes #15","user":{"login":"solarpete","id":9208139,"avatar_url":"https://avatars.githubusercontent.com/u/9208139?v=3","gravatar_id":"","url":"https://api.github.com/users/solarpete","html_url":"https://github.com/solarpete","followers_url":"https://api.github.com/users/solarpete/followers","following_url":"https://api.github.com/users/solarpete/following{/other_user}","gists_url":"https://api.github.com/users/solarpete/gists{/gist_id}","starred_url":"https://api.github.com/users/solarpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarpete/subscriptions","organizations_url":"https://api.github.com/users/solarpete/orgs","repos_url":"https://api.github.com/users/solarpete/repos","events_url":"https://api.github.com/users/solarpete/events{/privacy}","received_events_url":"https://api.github.com/users/solarpete/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":6,"created_at":"2015-08-03T07:35:19Z","updated_at":"2015-08-06T22:33:07Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openchargemap/ocm-system/pulls/35","html_url":"https://github.com/openchargemap/ocm-system/pull/35","diff_url":"https://github.com/openchargemap/ocm-system/pull/35.diff","patch_url":"https://github.com/openchargemap/ocm-system/pull/35.patch"},"body":"Made the \"About\" page and few other terms (2 new items in menu and 1 on\r\nmain page) translatable.\r\n\r\nI have not included the following files updated by grunt in this commit (not knowing whether they should be included for website translation updates as well), but if I they are necessary I will commit them as well:\r\nAPI\\OCM.Net\\OCM.API.Web\\Widgets\\Map\\scripts\\Localisation\\languagePack.min.js\r\nApp\\js\\Localisation\\languagePack.min.js\r\n"},"comment":{"url":"https://api.github.com/repos/openchargemap/ocm-system/issues/comments/128529683","html_url":"https://github.com/openchargemap/ocm-system/pull/35#issuecomment-128529683","issue_url":"https://api.github.com/repos/openchargemap/ocm-system/issues/35","id":128529683,"user":{"login":"solarpete","id":9208139,"avatar_url":"https://avatars.githubusercontent.com/u/9208139?v=3","gravatar_id":"","url":"https://api.github.com/users/solarpete","html_url":"https://github.com/solarpete","followers_url":"https://api.github.com/users/solarpete/followers","following_url":"https://api.github.com/users/solarpete/following{/other_user}","gists_url":"https://api.github.com/users/solarpete/gists{/gist_id}","starred_url":"https://api.github.com/users/solarpete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarpete/subscriptions","organizations_url":"https://api.github.com/users/solarpete/orgs","repos_url":"https://api.github.com/users/solarpete/repos","events_url":"https://api.github.com/users/solarpete/events{/privacy}","received_events_url":"https://api.github.com/users/solarpete/received_events","type":"User","site_admin":false},"created_at":"2015-08-06T22:33:07Z","updated_at":"2015-08-06T22:33:07Z","body":"Thanks for the link. I will try to study it a bit, but I will be very busy\nnext month or two, so it will take time.\n\nUnfortunately I do not have sufficient knowledge to give any qualified\nopinion on the library (future or present). However I am thinking whether\nit is worth, as there are only 4 pages that contain a lot of text to\ntranslate. Do you think it would make the work for translators much easier?\nOr are you more concerned with the responsiveness of the site?\n\nBecause even though the splitting of the resource keys for the sentences\nwith hyperlinks is a pain, I think it should be relatively easy for the\ntranslators to figure it out. I tried to keep them grouped (e.g. by\nstarting the resource keys with the same common string) so that they can\nsee they belong together and should be translated accordingly. But the best\nway is probably to find the English originals on the page and see what it\nbelongs to...\n\nOn 4 August 2015 at 00:48, Christopher Cook <notifications@github.com>\nwrote:\n\n> The code which actually applies the translation is\n> https://github.com/openchargemap/ocm-system/blob/master/App/js/OCM_CommonUI.ts#L50\n> on both the app and the website. We bundle all the translations into one\n> data file then apply depending on markup in the html. This approach is OK\n> (a little non-standard for websites, translation would normally be applied\n> server side, for asp.net this would be normally be using a resource file).\n>\n> From a quick Google we probably need to figure out how to migrate to a\n> dedicated library such as http://i18next.com/ which has variable\n> substitution, again I need to do more research to decide the best approach.\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/openchargemap/ocm-system/pull/35#issuecomment-127509831>\n> .\n>\n"}}