{"action":"created","issue":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/199","labels_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/199/labels{/name}","comments_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/199/comments","events_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/199/events","html_url":"https://github.com/dimitar-asenov/Envision/pull/199","id":114291373,"number":199,"title":"Python wrapper gen improvements","user":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-10-30T15:24:30Z","updated_at":"2015-11-01T16:21:43Z","closed_at":"2015-10-31T09:08:37Z","pull_request":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/pulls/199","html_url":"https://github.com/dimitar-asenov/Envision/pull/199","diff_url":"https://github.com/dimitar-asenov/Envision/pull/199.diff","patch_url":"https://github.com/dimitar-asenov/Envision/pull/199.patch"},"body":"This now supports to wrap TypedList correctly.\n<a href='#crh-start'></a><a href='#crh-data-%7B%22processed%22%3A%20%5B%22https%3A//github.com/dimitar-asenov/Envision/pull/199%23discussion_r43569791%22%2C%20%22https%3A//github.com/dimitar-asenov/Envision/pull/199%23issuecomment-152716947%22%5D%2C%20%22comments%22%3A%20%7B%22General%20Comment%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/199%23issuecomment-152716947%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22I%20only%20had%20a%20brief%20look%20and%20it%27s%20looking%20good.%20It%27s%20cool%20that%20we%20can%20now%20handle%20lists.%20We%20should%20come%20up%20with%20some%20nice%20example%20refactorings%20that%20we%20can%20do%20like%20this.%20Is%20it%20easy%20to%20check/follow%20the%20targets%20of%20references%3F%22%2C%20%22created_at%22%3A%20%222015-10-31T09%3A08%3A35Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%5D%2C%20%22title%22%3A%20%22General%20Comment%22%7D%2C%20%22Pull%20c7f0b446b866345b41e1212ccc2e0e2c5fbbc9d0%20PythonWrapperGenerator/src/APIData.h%204%22%3A%20%7B%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov/Envision/pull/199%23discussion_r43569791%22%2C%20%22comments%22%3A%20%5B%7B%22body%22%3A%20%22Just%20FYI%2C%20whether%20you%20have%20a%20%60%7B%7D%60%20here%20or%20not%20makes%20no%20difference.%20I%20generally%20prefer%20not%20having%20it%20%28less%20code%29.%22%2C%20%22created_at%22%3A%20%222015-10-31T09%3A02%3A30Z%22%2C%20%22user%22%3A%20%7B%22avatar_url%22%3A%20%22https%3A//avatars.githubusercontent.com/u/1152976%3Fv%3D3%22%2C%20%22html_url%22%3A%20%22https%3A//github.com/dimitar-asenov%22%7D%7D%5D%2C%20%22title%22%3A%20%22File%3A%20PythonWrapperGenerator/src/APIData.h%3AL70-84%22%7D%7D%7D'></a>\n<a href='https://www.codereviewhub.com/'><img src='http://www.codereviewhub.com/site/github-bar.png' height=40></a>\n- [ ] <a href='#crh-comment-Pull c7f0b446b866345b41e1212ccc2e0e2c5fbbc9d0 PythonWrapperGenerator/src/APIData.h 4'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/199#discussion_r43569791'>File: PythonWrapperGenerator/src/APIData.h:L70-84</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> Just FYI, whether you have a `{}` here or not makes no difference. I generally prefer not having it (less code).\n- [ ] <a href='#crh-comment-General Comment'></a> <img src='http://www.codereviewhub.com/site/github-remaining.png' height=16 width=60>&nbsp;<b><a href='https://github.com/dimitar-asenov/Envision/pull/199#issuecomment-152716947'>General Comment</a></b>\n- <a href='https://github.com/dimitar-asenov'><img border=0 src='https://avatars.githubusercontent.com/u/1152976?v=3' height=16 width=16'></a> I only had a brief look and it's looking good. It's cool that we can now handle lists. We should come up with some nice example refactorings that we can do like this. Is it easy to check/follow the targets of references?\n\n\n<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/199?mark_as_completed=1'><img src='http://www.codereviewhub.com/site/github-mark-as-completed.png' height=26></a>&nbsp;<a href='https://www.codereviewhub.com/dimitar-asenov/Envision/pull/199?approve=1'><img src='http://www.codereviewhub.com/site/github-approve.png' height=26></a>&nbsp;<a href='https://github.com/dimitar-asenov/Envision/pull/199'><img src='http://www.codereviewhub.com/site/github-refresh.png' height=26></a>\n<a href='#crh-end'></a>"},"comment":{"url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/comments/152841382","html_url":"https://github.com/dimitar-asenov/Envision/pull/199#issuecomment-152841382","issue_url":"https://api.github.com/repos/dimitar-asenov/Envision/issues/199","id":152841382,"user":{"login":"lukedirtwalker","id":3530769,"avatar_url":"https://avatars.githubusercontent.com/u/3530769?v=3","gravatar_id":"","url":"https://api.github.com/users/lukedirtwalker","html_url":"https://github.com/lukedirtwalker","followers_url":"https://api.github.com/users/lukedirtwalker/followers","following_url":"https://api.github.com/users/lukedirtwalker/following{/other_user}","gists_url":"https://api.github.com/users/lukedirtwalker/gists{/gist_id}","starred_url":"https://api.github.com/users/lukedirtwalker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukedirtwalker/subscriptions","organizations_url":"https://api.github.com/users/lukedirtwalker/orgs","repos_url":"https://api.github.com/users/lukedirtwalker/repos","events_url":"https://api.github.com/users/lukedirtwalker/events{/privacy}","received_events_url":"https://api.github.com/users/lukedirtwalker/received_events","type":"User","site_admin":false},"created_at":"2015-11-01T16:21:43Z","updated_at":"2015-11-01T16:21:43Z","body":"I haven't tested anything references related, do you have something specific in mind?"}}