{"action":"created","issue":{"url":"https://api.github.com/repos/shazow/urllib3/issues/690","labels_url":"https://api.github.com/repos/shazow/urllib3/issues/690/labels{/name}","comments_url":"https://api.github.com/repos/shazow/urllib3/issues/690/comments","events_url":"https://api.github.com/repos/shazow/urllib3/issues/690/events","html_url":"https://github.com/shazow/urllib3/issues/690","id":99610498,"number":690,"title":"Preliminary SOCKS proxy support","user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/shazow/urllib3/labels/Bounty","name":"Bounty","color":"129e5e"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":13,"created_at":"2015-08-07T09:04:39Z","updated_at":"2015-12-03T18:32:23Z","closed_at":null,"body":"We've had some attempts to get this going over the years, this is the umbrella issue tracking these attempts and the goal is to get somekind of baseline support for SOCKS proxies into the urllib3 before we aspire towards more advanced features.\r\n\r\nRelated attempts (should be a great reference if anyone wants to tackle this):\r\n\r\n- https://github.com/shazow/urllib3/pull/68 (original attempt using socksipy; outdated code)\r\n- https://github.com/shazow/urllib3/pull/284 (another attempt using pysocks—a more up-to-date fork of socksipy; outdated code)\r\n- https://github.com/shazow/urllib3/pull/486 (most recent attempt, refactored version of pysocks attempt)\r\n- https://github.com/shazow/urllib3/pull/692 (another recent attempt, but mixes pysocks logic into the connectionpools)\r\n- https://github.com/shazow/urllib3/issues/630 (recipe for wrapping pysocks)\r\n\r\nSuggestions:\r\n\r\n- SOCKS proxy support should ideally be built into ProxyManager (or a similar manager if combining is not possible).\r\n- Should use pysocks (unless there's anything newer?). Avoid vendoring if possible, we can enable support when pysocks is installed (also include a `urllib3[socks]` install tag which will pull in the dependency).\r\n\r\nTo complete this issue, the feature needs to be documented and have full test coverage so that it can be merged into urllib3 core (or at least contrib).\r\n\r\n<bountysource-plugin>\r\n---\r\nThere is a **[$115 open bounty](https://www.bountysource.com/issues/25474088-preliminary-socks-proxy-support?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github)** on this issue. Add to the bounty at [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F192525&utm_medium=issues&utm_source=github).\r\n</bountysource-plugin>"},"comment":{"url":"https://api.github.com/repos/shazow/urllib3/issues/comments/161740804","html_url":"https://github.com/shazow/urllib3/issues/690#issuecomment-161740804","issue_url":"https://api.github.com/repos/shazow/urllib3/issues/690","id":161740804,"user":{"login":"shazow","id":6292,"avatar_url":"https://avatars.githubusercontent.com/u/6292?v=3","gravatar_id":"","url":"https://api.github.com/users/shazow","html_url":"https://github.com/shazow","followers_url":"https://api.github.com/users/shazow/followers","following_url":"https://api.github.com/users/shazow/following{/other_user}","gists_url":"https://api.github.com/users/shazow/gists{/gist_id}","starred_url":"https://api.github.com/users/shazow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shazow/subscriptions","organizations_url":"https://api.github.com/users/shazow/orgs","repos_url":"https://api.github.com/users/shazow/repos","events_url":"https://api.github.com/users/shazow/events{/privacy}","received_events_url":"https://api.github.com/users/shazow/received_events","type":"User","site_admin":false},"created_at":"2015-12-03T18:32:23Z","updated_at":"2015-12-03T18:32:23Z","body":"@AlJohri Thanks! If you'd like to get involved, pulling the code mention above and providing feedback would be most helpful. :)"}}