{"action":"opened","number":241,"pull_request":{"url":"https://api.github.com/repos/rails/sprockets-rails/pulls/241","id":34296458,"html_url":"https://github.com/rails/sprockets-rails/pull/241","diff_url":"https://github.com/rails/sprockets-rails/pull/241.diff","patch_url":"https://github.com/rails/sprockets-rails/pull/241.patch","issue_url":"https://api.github.com/repos/rails/sprockets-rails/issues/241","number":241,"state":"open","locked":false,"title":"Prevent alias logical paths passed to asset_path","user":{"login":"josh","id":137,"avatar_url":"https://avatars.githubusercontent.com/u/137?v=3","gravatar_id":"","url":"https://api.github.com/users/josh","html_url":"https://github.com/josh","followers_url":"https://api.github.com/users/josh/followers","following_url":"https://api.github.com/users/josh/following{/other_user}","gists_url":"https://api.github.com/users/josh/gists{/gist_id}","starred_url":"https://api.github.com/users/josh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh/subscriptions","organizations_url":"https://api.github.com/users/josh/orgs","repos_url":"https://api.github.com/users/josh/repos","events_url":"https://api.github.com/users/josh/events{/privacy}","received_events_url":"https://api.github.com/users/josh/received_events","type":"User","site_admin":true},"body":"Theres a few other edge cases that will slip by the `AssetNotPrecompiled` check that are both issues today on 2.x and 3.x.\r\n\r\n* `index` assets can **only** be referenced by their shorthand alias and not by the full path\r\n* bower paths must be referenced by their full path and never there shorthand\r\n\r\nThe index case is annoying and I'm looking to address it in https://github.com/rails/sprockets/pull/36.\r\n\r\nThough, I think this check is probably a good idea no matter what happens in sprockets core.\r\n\r\nWe basically assert that the input `path` which would be passed directly to `manifest.assets` in production matches the `logical_path` as it would be written out to disk.\r\n\r\nThe check only affects AV helpers, nothing within asset generation within sprockets.\r\n\r\n/cc @arthurnn @rafaelfranca @matthewd ","created_at":"2015-04-28T18:27:04Z","updated_at":"2015-04-28T18:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rails/sprockets-rails/pulls/241/commits","review_comments_url":"https://api.github.com/repos/rails/sprockets-rails/pulls/241/comments","review_comment_url":"https://api.github.com/repos/rails/sprockets-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rails/sprockets-rails/issues/241/comments","statuses_url":"https://api.github.com/repos/rails/sprockets-rails/statuses/25dd706196989e5239fc921cf5e81fc9ef8492fd","head":{"label":"rails:detect-asset-alias","ref":"detect-asset-alias","sha":"25dd706196989e5239fc921cf5e81fc9ef8492fd","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":1784628,"name":"sprockets-rails","full_name":"rails/sprockets-rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/sprockets-rails","description":"Sprockets Rails integration","fork":false,"url":"https://api.github.com/repos/rails/sprockets-rails","forks_url":"https://api.github.com/repos/rails/sprockets-rails/forks","keys_url":"https://api.github.com/repos/rails/sprockets-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/sprockets-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/sprockets-rails/teams","hooks_url":"https://api.github.com/repos/rails/sprockets-rails/hooks","issue_events_url":"https://api.github.com/repos/rails/sprockets-rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/sprockets-rails/events","assignees_url":"https://api.github.com/repos/rails/sprockets-rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/sprockets-rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/sprockets-rails/tags","blobs_url":"https://api.github.com/repos/rails/sprockets-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/sprockets-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/sprockets-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/sprockets-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/sprockets-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/sprockets-rails/languages","stargazers_url":"https://api.github.com/repos/rails/sprockets-rails/stargazers","contributors_url":"https://api.github.com/repos/rails/sprockets-rails/contributors","subscribers_url":"https://api.github.com/repos/rails/sprockets-rails/subscribers","subscription_url":"https://api.github.com/repos/rails/sprockets-rails/subscription","commits_url":"https://api.github.com/repos/rails/sprockets-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/sprockets-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/sprockets-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/sprockets-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/sprockets-rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/sprockets-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/sprockets-rails/merges","archive_url":"https://api.github.com/repos/rails/sprockets-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/sprockets-rails/downloads","issues_url":"https://api.github.com/repos/rails/sprockets-rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/sprockets-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/sprockets-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/sprockets-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/sprockets-rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/sprockets-rails/releases{/id}","created_at":"2011-05-22T17:56:05Z","updated_at":"2015-04-27T18:41:21Z","pushed_at":"2015-04-28T18:16:48Z","git_url":"git://github.com/rails/sprockets-rails.git","ssh_url":"git@github.com:rails/sprockets-rails.git","clone_url":"https://github.com/rails/sprockets-rails.git","svn_url":"https://github.com/rails/sprockets-rails","homepage":"","size":2105,"stargazers_count":217,"watchers_count":217,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":10,"forks":106,"open_issues":10,"watchers":217,"default_branch":"master"}},"base":{"label":"rails:master","ref":"master","sha":"6f5a37cfc7e5e71e2a7e1d1c002448dc374f1324","user":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"repo":{"id":1784628,"name":"sprockets-rails","full_name":"rails/sprockets-rails","owner":{"login":"rails","id":4223,"avatar_url":"https://avatars.githubusercontent.com/u/4223?v=3","gravatar_id":"","url":"https://api.github.com/users/rails","html_url":"https://github.com/rails","followers_url":"https://api.github.com/users/rails/followers","following_url":"https://api.github.com/users/rails/following{/other_user}","gists_url":"https://api.github.com/users/rails/gists{/gist_id}","starred_url":"https://api.github.com/users/rails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rails/subscriptions","organizations_url":"https://api.github.com/users/rails/orgs","repos_url":"https://api.github.com/users/rails/repos","events_url":"https://api.github.com/users/rails/events{/privacy}","received_events_url":"https://api.github.com/users/rails/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rails/sprockets-rails","description":"Sprockets Rails integration","fork":false,"url":"https://api.github.com/repos/rails/sprockets-rails","forks_url":"https://api.github.com/repos/rails/sprockets-rails/forks","keys_url":"https://api.github.com/repos/rails/sprockets-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rails/sprockets-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rails/sprockets-rails/teams","hooks_url":"https://api.github.com/repos/rails/sprockets-rails/hooks","issue_events_url":"https://api.github.com/repos/rails/sprockets-rails/issues/events{/number}","events_url":"https://api.github.com/repos/rails/sprockets-rails/events","assignees_url":"https://api.github.com/repos/rails/sprockets-rails/assignees{/user}","branches_url":"https://api.github.com/repos/rails/sprockets-rails/branches{/branch}","tags_url":"https://api.github.com/repos/rails/sprockets-rails/tags","blobs_url":"https://api.github.com/repos/rails/sprockets-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rails/sprockets-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rails/sprockets-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/rails/sprockets-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rails/sprockets-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/rails/sprockets-rails/languages","stargazers_url":"https://api.github.com/repos/rails/sprockets-rails/stargazers","contributors_url":"https://api.github.com/repos/rails/sprockets-rails/contributors","subscribers_url":"https://api.github.com/repos/rails/sprockets-rails/subscribers","subscription_url":"https://api.github.com/repos/rails/sprockets-rails/subscription","commits_url":"https://api.github.com/repos/rails/sprockets-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/rails/sprockets-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/rails/sprockets-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/rails/sprockets-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/rails/sprockets-rails/contents/{+path}","compare_url":"https://api.github.com/repos/rails/sprockets-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rails/sprockets-rails/merges","archive_url":"https://api.github.com/repos/rails/sprockets-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rails/sprockets-rails/downloads","issues_url":"https://api.github.com/repos/rails/sprockets-rails/issues{/number}","pulls_url":"https://api.github.com/repos/rails/sprockets-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/rails/sprockets-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/rails/sprockets-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rails/sprockets-rails/labels{/name}","releases_url":"https://api.github.com/repos/rails/sprockets-rails/releases{/id}","created_at":"2011-05-22T17:56:05Z","updated_at":"2015-04-27T18:41:21Z","pushed_at":"2015-04-28T18:16:48Z","git_url":"git://github.com/rails/sprockets-rails.git","ssh_url":"git@github.com:rails/sprockets-rails.git","clone_url":"https://github.com/rails/sprockets-rails.git","svn_url":"https://github.com/rails/sprockets-rails","homepage":"","size":2105,"stargazers_count":217,"watchers_count":217,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":106,"mirror_url":null,"open_issues_count":10,"forks":106,"open_issues":10,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rails/sprockets-rails/pulls/241"},"html":{"href":"https://github.com/rails/sprockets-rails/pull/241"},"issue":{"href":"https://api.github.com/repos/rails/sprockets-rails/issues/241"},"comments":{"href":"https://api.github.com/repos/rails/sprockets-rails/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/rails/sprockets-rails/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/rails/sprockets-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rails/sprockets-rails/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/rails/sprockets-rails/statuses/25dd706196989e5239fc921cf5e81fc9ef8492fd"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":39,"deletions":0,"changed_files":5}}