{"action":"created","issue":{"url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18","labels_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18/comments","events_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18/events","html_url":"https://github.com/bryanbrazil/skin.mimic/pull/18","id":107589325,"number":18,"title":"Update to utilise skinshortcuts (0.5.3) for main menu, background, widgets","user":{"login":"Ignoble61","id":12768752,"avatar_url":"https://avatars.githubusercontent.com/u/12768752?v=3","gravatar_id":"","url":"https://api.github.com/users/Ignoble61","html_url":"https://github.com/Ignoble61","followers_url":"https://api.github.com/users/Ignoble61/followers","following_url":"https://api.github.com/users/Ignoble61/following{/other_user}","gists_url":"https://api.github.com/users/Ignoble61/gists{/gist_id}","starred_url":"https://api.github.com/users/Ignoble61/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ignoble61/subscriptions","organizations_url":"https://api.github.com/users/Ignoble61/orgs","repos_url":"https://api.github.com/users/Ignoble61/repos","events_url":"https://api.github.com/users/Ignoble61/events{/privacy}","received_events_url":"https://api.github.com/users/Ignoble61/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-21T20:12:21Z","updated_at":"2015-09-21T20:16:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bryanbrazil/skin.mimic/pulls/18","html_url":"https://github.com/bryanbrazil/skin.mimic/pull/18","diff_url":"https://github.com/bryanbrazil/skin.mimic/pull/18.diff","patch_url":"https://github.com/bryanbrazil/skin.mimic/pull/18.patch"},"body":"I know you've moved on to Arctic, so if you're not interested in this that's no problem at all :)\r\n\r\nI was curious just how difficult it would be to move Mimic to fully utilise Skin Shortcuts - as it is, a lot harder than I anticipated and I can understand exactly why you didn't do it! Still, I can never resist a challenge ;)\r\n\r\nI've done it as multiple commits to try and make the changes easier to follow, but if you want to merge it (absolutely your choice, I won't be offended if you don't!) I'll happily squash the commits.\r\n\r\nA couple of things to note about it:\r\n\r\n* The only testing it's had is from me as I've been making the changes. It's one of those situations where most things should be working, but there may well be bugs.\r\n* And there's at least one known bug (I'm sure I had a second, but can't remember it now) - the description text for the skinshortcuts management dialog is completely wrong :) (You'll see what I mean when you select certain options in the management dialog)\r\n* It doesn't include any pre-defined menu/submenu items (the x1, x2 etc won't be used), so the menu items default to those included with the script (based off of Confluences defaults). It also doesn't have any default backgrounds/widgets for menu items.\r\n* The final commit removes custom dialogs I _think_ are unnecessary with the changes made, but I haven't fully checked this out.\r\n\r\nRegards."},"comment":{"url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/comments/142096907","html_url":"https://github.com/bryanbrazil/skin.mimic/pull/18#issuecomment-142096907","issue_url":"https://api.github.com/repos/bryanbrazil/skin.mimic/issues/18","id":142096907,"user":{"login":"bryanbrazil","id":7245177,"avatar_url":"https://avatars.githubusercontent.com/u/7245177?v=3","gravatar_id":"","url":"https://api.github.com/users/bryanbrazil","html_url":"https://github.com/bryanbrazil","followers_url":"https://api.github.com/users/bryanbrazil/followers","following_url":"https://api.github.com/users/bryanbrazil/following{/other_user}","gists_url":"https://api.github.com/users/bryanbrazil/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanbrazil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanbrazil/subscriptions","organizations_url":"https://api.github.com/users/bryanbrazil/orgs","repos_url":"https://api.github.com/users/bryanbrazil/repos","events_url":"https://api.github.com/users/bryanbrazil/events{/privacy}","received_events_url":"https://api.github.com/users/bryanbrazil/received_events","type":"User","site_admin":false},"created_at":"2015-09-21T20:16:49Z","updated_at":"2015-09-21T20:16:49Z","body":"Wow, thanks Bob, was not expecting this! I'm out of the country for the\nnext week, but I'll test and merge as soon as I get back. Looks like you\nalready did it, but don't worry about the cleanup. I can remove all traces\nof the dialogs/variables/etc that are no longer needed. Thanks again!\nOn Sep 21, 2015 10:12 AM, \"Ignoble61\" <notifications@github.com> wrote:\n\n> I know you've moved on to Arctic, so if you're not interested in this\n> that's no problem at all :)\n>\n> I was curious just how difficult it would be to move Mimic to fully\n> utilise Skin Shortcuts - as it is, a lot harder than I anticipated and I\n> can understand exactly why you didn't do it! Still, I can never resist a\n> challenge ;)\n>\n> I've done it as multiple commits to try and make the changes easier to\n> follow, but if you want to merge it (absolutely your choice, I won't be\n> offended if you don't!) I'll happily squash the commits.\n>\n> A couple of things to note about it:\n>\n>    - The only testing it's had is from me as I've been making the\n>    changes. It's one of those situations where most things should be working,\n>    but there may well be bugs.\n>    - And there's at least one known bug (I'm sure I had a second, but\n>    can't remember it now) - the description text for the skinshortcuts\n>    management dialog is completely wrong :) (You'll see what I mean when you\n>    select certain options in the management dialog)\n>    - The final commit removes custom dialogs I *think* are unnecessary\n>    with the changes made, but I haven't fully checked this out.\n>\n> Regards.\n> ------------------------------\n> You can view, comment on, or merge this pull request online at:\n>\n>   https://github.com/bryanbrazil/skin.mimic/pull/18\n> Commit Summary\n>\n>    - Use script.skinshortcuts for main menu\n>    - Redesign management dialog\n>    - Add skinshortcuts background support\n>    - Add skinshortcuts widget support\n>    - Use skinshortcuts to set custom InfoLine property\n>    - Delete custom dialogs that *SHOULD* now be unneccesary\n>\n> File Changes\n>\n>    - *M* 1080i/Home.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-0> (2)\n>    - *M* 1080i/IncludesHomeWidgets.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-1> (144)\n>    - *M* 1080i/Includes_Home.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-2> (1)\n>    - *M* 1080i/Includes_LiveBG.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-3> (20)\n>    - *M* 1080i/Includes_Menus.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-4> (784)\n>    - *M* 1080i/Includes_WidgetContent.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-5> (230)\n>    - *M* 1080i/SkinSettings.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-6> (545)\n>    - *D* 1080i/custom_1121_HomeMenuCustomizer.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-7> (274)\n>    - *D* 1080i/custom_1124_WidgetCustomizer.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-8> (330)\n>    - *D* 1080i/custom_1125_InfoLineCustomizer.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-9> (141)\n>    - *D* 1080i/custom_1126_MenuOrderCustomizer.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-10>\n>    (165)\n>    - *D* 1080i/custom_1132_WidgetIconDialog.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-11>\n>    (135)\n>    - *M* 1080i/includes.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-12> (4)\n>    - *M* 1080i/script-skinshortcuts.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-13>\n>    (422)\n>    - *M* 1080i/variables.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-14> (95)\n>    - *M* addon.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-15> (2)\n>    - *A* shortcuts/overrides.xml\n>    <https://github.com/bryanbrazil/skin.mimic/pull/18/files#diff-16> (36)\n>\n> Patch Links:\n>\n>    - https://github.com/bryanbrazil/skin.mimic/pull/18.patch\n>    - https://github.com/bryanbrazil/skin.mimic/pull/18.diff\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/bryanbrazil/skin.mimic/pull/18>.\n>\n"}}