{"action":"created","issue":{"url":"https://api.github.com/repos/solettaproject/soletta/issues/695","labels_url":"https://api.github.com/repos/solettaproject/soletta/issues/695/labels{/name}","comments_url":"https://api.github.com/repos/solettaproject/soletta/issues/695/comments","events_url":"https://api.github.com/repos/solettaproject/soletta/issues/695/events","html_url":"https://github.com/solettaproject/soletta/pull/695","id":105377523,"number":695,"title":"comms/http-client: destroy connection after calling cb","user":{"login":"bdilly","id":22437,"avatar_url":"https://avatars.githubusercontent.com/u/22437?v=3","gravatar_id":"","url":"https://api.github.com/users/bdilly","html_url":"https://github.com/bdilly","followers_url":"https://api.github.com/users/bdilly/followers","following_url":"https://api.github.com/users/bdilly/following{/other_user}","gists_url":"https://api.github.com/users/bdilly/gists{/gist_id}","starred_url":"https://api.github.com/users/bdilly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdilly/subscriptions","organizations_url":"https://api.github.com/users/bdilly/orgs","repos_url":"https://api.github.com/users/bdilly/repos","events_url":"https://api.github.com/users/bdilly/events{/privacy}","received_events_url":"https://api.github.com/users/bdilly/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-09-08T13:11:41Z","updated_at":"2015-09-08T13:51:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/solettaproject/soletta/pulls/695","html_url":"https://github.com/solettaproject/soletta/pull/695","diff_url":"https://github.com/solettaproject/soletta/pull/695.diff","patch_url":"https://github.com/solettaproject/soletta/pull/695.patch"},"body":"@lpereira could you please review it?\n\nSigned-off-by: Bruno Dilly <bruno.dilly@intel.com>"},"comment":{"url":"https://api.github.com/repos/solettaproject/soletta/issues/comments/138565808","html_url":"https://github.com/solettaproject/soletta/pull/695#issuecomment-138565808","issue_url":"https://api.github.com/repos/solettaproject/soletta/issues/695","id":138565808,"user":{"login":"lpereira","id":15001,"avatar_url":"https://avatars.githubusercontent.com/u/15001?v=3","gravatar_id":"","url":"https://api.github.com/users/lpereira","html_url":"https://github.com/lpereira","followers_url":"https://api.github.com/users/lpereira/followers","following_url":"https://api.github.com/users/lpereira/following{/other_user}","gists_url":"https://api.github.com/users/lpereira/gists{/gist_id}","starred_url":"https://api.github.com/users/lpereira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lpereira/subscriptions","organizations_url":"https://api.github.com/users/lpereira/orgs","repos_url":"https://api.github.com/users/lpereira/repos","events_url":"https://api.github.com/users/lpereira/events{/privacy}","received_events_url":"https://api.github.com/users/lpereira/received_events","type":"User","site_admin":false},"created_at":"2015-09-08T13:51:21Z","updated_at":"2015-09-08T13:51:21Z","body":"LGTM.\r\n\r\nIt's very unlikely there's going to be too many connections so the call to `sol_ptr_vector_remove()` doesn't bother me that much that we're exchanging a very cheap NULL pointer check with a loop.\r\n\r\nIn fact, I believe we could implement this function on top of `sol_vector` directly, by providing a `_remove()` method that takes a function pointer to compare items; I bet we can clean up a bunch of code this way (it always bothered me that, to find and and remove items in a vector, one has to traverse it in reverse)."}}