{"action":"closed","number":31,"pull_request":{"url":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31","id":45804030,"html_url":"https://github.com/gregsexton/ob-ipython/pull/31","diff_url":"https://github.com/gregsexton/ob-ipython/pull/31.diff","patch_url":"https://github.com/gregsexton/ob-ipython/pull/31.patch","issue_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31","number":31,"state":"closed","locked":false,"title":"support both IPython3 and Jupyter by conditional import","user":{"login":"smartass101","id":941907,"avatar_url":"https://avatars.githubusercontent.com/u/941907?v=3","gravatar_id":"","url":"https://api.github.com/users/smartass101","html_url":"https://github.com/smartass101","followers_url":"https://api.github.com/users/smartass101/followers","following_url":"https://api.github.com/users/smartass101/following{/other_user}","gists_url":"https://api.github.com/users/smartass101/gists{/gist_id}","starred_url":"https://api.github.com/users/smartass101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartass101/subscriptions","organizations_url":"https://api.github.com/users/smartass101/orgs","repos_url":"https://api.github.com/users/smartass101/repos","events_url":"https://api.github.com/users/smartass101/events{/privacy}","received_events_url":"https://api.github.com/users/smartass101/received_events","type":"User","site_admin":false},"body":"I would like to propose a simple change that would deal with the current IPython 3/4 dichotomy and it would simplify installation for users as they wouldn't have to deal with git at all and an MELPA installation would suffice.\r\n\r\nThe code first tries to import the Jupyter libraries, failing that\r\nthe IPython 3 libraries are imported. All that really changed are\r\nmodule names.\r\n\r\nThis simple compatibility workaround may not work\r\nin the long term if Jupyter code diverges significantly from the current state. But by that time IPython 3 will be hopefully obsolete.\r\n\r\nI haven't fully tested it yet with IPython 3, not sure if this will bring #19 back.","created_at":"2015-09-23T16:58:09Z","updated_at":"2015-09-26T14:12:10Z","closed_at":"2015-09-26T14:12:10Z","merged_at":"2015-09-26T14:12:10Z","merge_commit_sha":"eaf04846281f223748b1bdc552c419a0d52dfc7d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31/commits","review_comments_url":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31/comments","review_comment_url":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31/comments","statuses_url":"https://api.github.com/repos/gregsexton/ob-ipython/statuses/5fceb3b67efd3f4b57146252c01e94f940cc2e4e","head":{"label":"smartass101:ipython_auto-compatible","ref":"ipython_auto-compatible","sha":"5fceb3b67efd3f4b57146252c01e94f940cc2e4e","user":{"login":"smartass101","id":941907,"avatar_url":"https://avatars.githubusercontent.com/u/941907?v=3","gravatar_id":"","url":"https://api.github.com/users/smartass101","html_url":"https://github.com/smartass101","followers_url":"https://api.github.com/users/smartass101/followers","following_url":"https://api.github.com/users/smartass101/following{/other_user}","gists_url":"https://api.github.com/users/smartass101/gists{/gist_id}","starred_url":"https://api.github.com/users/smartass101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartass101/subscriptions","organizations_url":"https://api.github.com/users/smartass101/orgs","repos_url":"https://api.github.com/users/smartass101/repos","events_url":"https://api.github.com/users/smartass101/events{/privacy}","received_events_url":"https://api.github.com/users/smartass101/received_events","type":"User","site_admin":false},"repo":{"id":42886301,"name":"ob-ipython","full_name":"smartass101/ob-ipython","owner":{"login":"smartass101","id":941907,"avatar_url":"https://avatars.githubusercontent.com/u/941907?v=3","gravatar_id":"","url":"https://api.github.com/users/smartass101","html_url":"https://github.com/smartass101","followers_url":"https://api.github.com/users/smartass101/followers","following_url":"https://api.github.com/users/smartass101/following{/other_user}","gists_url":"https://api.github.com/users/smartass101/gists{/gist_id}","starred_url":"https://api.github.com/users/smartass101/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smartass101/subscriptions","organizations_url":"https://api.github.com/users/smartass101/orgs","repos_url":"https://api.github.com/users/smartass101/repos","events_url":"https://api.github.com/users/smartass101/events{/privacy}","received_events_url":"https://api.github.com/users/smartass101/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smartass101/ob-ipython","description":"org-babel integration with IPython for evaluation","fork":true,"url":"https://api.github.com/repos/smartass101/ob-ipython","forks_url":"https://api.github.com/repos/smartass101/ob-ipython/forks","keys_url":"https://api.github.com/repos/smartass101/ob-ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smartass101/ob-ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smartass101/ob-ipython/teams","hooks_url":"https://api.github.com/repos/smartass101/ob-ipython/hooks","issue_events_url":"https://api.github.com/repos/smartass101/ob-ipython/issues/events{/number}","events_url":"https://api.github.com/repos/smartass101/ob-ipython/events","assignees_url":"https://api.github.com/repos/smartass101/ob-ipython/assignees{/user}","branches_url":"https://api.github.com/repos/smartass101/ob-ipython/branches{/branch}","tags_url":"https://api.github.com/repos/smartass101/ob-ipython/tags","blobs_url":"https://api.github.com/repos/smartass101/ob-ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smartass101/ob-ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smartass101/ob-ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/smartass101/ob-ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smartass101/ob-ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/smartass101/ob-ipython/languages","stargazers_url":"https://api.github.com/repos/smartass101/ob-ipython/stargazers","contributors_url":"https://api.github.com/repos/smartass101/ob-ipython/contributors","subscribers_url":"https://api.github.com/repos/smartass101/ob-ipython/subscribers","subscription_url":"https://api.github.com/repos/smartass101/ob-ipython/subscription","commits_url":"https://api.github.com/repos/smartass101/ob-ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/smartass101/ob-ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/smartass101/ob-ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/smartass101/ob-ipython/issues/comments{/number}","contents_url":"https://api.github.com/repos/smartass101/ob-ipython/contents/{+path}","compare_url":"https://api.github.com/repos/smartass101/ob-ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smartass101/ob-ipython/merges","archive_url":"https://api.github.com/repos/smartass101/ob-ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smartass101/ob-ipython/downloads","issues_url":"https://api.github.com/repos/smartass101/ob-ipython/issues{/number}","pulls_url":"https://api.github.com/repos/smartass101/ob-ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/smartass101/ob-ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/smartass101/ob-ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smartass101/ob-ipython/labels{/name}","releases_url":"https://api.github.com/repos/smartass101/ob-ipython/releases{/id}","created_at":"2015-09-21T18:37:52Z","updated_at":"2015-09-21T18:37:52Z","pushed_at":"2015-09-23T16:52:30Z","git_url":"git://github.com/smartass101/ob-ipython.git","ssh_url":"git@github.com:smartass101/ob-ipython.git","clone_url":"https://github.com/smartass101/ob-ipython.git","svn_url":"https://github.com/smartass101/ob-ipython","homepage":"","size":663,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gregsexton:master","ref":"master","sha":"dfe1c4254c4749dba79208406510d402b8419658","user":{"login":"gregsexton","id":150883,"avatar_url":"https://avatars.githubusercontent.com/u/150883?v=3","gravatar_id":"","url":"https://api.github.com/users/gregsexton","html_url":"https://github.com/gregsexton","followers_url":"https://api.github.com/users/gregsexton/followers","following_url":"https://api.github.com/users/gregsexton/following{/other_user}","gists_url":"https://api.github.com/users/gregsexton/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsexton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsexton/subscriptions","organizations_url":"https://api.github.com/users/gregsexton/orgs","repos_url":"https://api.github.com/users/gregsexton/repos","events_url":"https://api.github.com/users/gregsexton/events{/privacy}","received_events_url":"https://api.github.com/users/gregsexton/received_events","type":"User","site_admin":false},"repo":{"id":36989545,"name":"ob-ipython","full_name":"gregsexton/ob-ipython","owner":{"login":"gregsexton","id":150883,"avatar_url":"https://avatars.githubusercontent.com/u/150883?v=3","gravatar_id":"","url":"https://api.github.com/users/gregsexton","html_url":"https://github.com/gregsexton","followers_url":"https://api.github.com/users/gregsexton/followers","following_url":"https://api.github.com/users/gregsexton/following{/other_user}","gists_url":"https://api.github.com/users/gregsexton/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsexton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsexton/subscriptions","organizations_url":"https://api.github.com/users/gregsexton/orgs","repos_url":"https://api.github.com/users/gregsexton/repos","events_url":"https://api.github.com/users/gregsexton/events{/privacy}","received_events_url":"https://api.github.com/users/gregsexton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregsexton/ob-ipython","description":"org-babel integration with IPython for evaluation","fork":false,"url":"https://api.github.com/repos/gregsexton/ob-ipython","forks_url":"https://api.github.com/repos/gregsexton/ob-ipython/forks","keys_url":"https://api.github.com/repos/gregsexton/ob-ipython/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregsexton/ob-ipython/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregsexton/ob-ipython/teams","hooks_url":"https://api.github.com/repos/gregsexton/ob-ipython/hooks","issue_events_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/events{/number}","events_url":"https://api.github.com/repos/gregsexton/ob-ipython/events","assignees_url":"https://api.github.com/repos/gregsexton/ob-ipython/assignees{/user}","branches_url":"https://api.github.com/repos/gregsexton/ob-ipython/branches{/branch}","tags_url":"https://api.github.com/repos/gregsexton/ob-ipython/tags","blobs_url":"https://api.github.com/repos/gregsexton/ob-ipython/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregsexton/ob-ipython/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregsexton/ob-ipython/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregsexton/ob-ipython/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregsexton/ob-ipython/statuses/{sha}","languages_url":"https://api.github.com/repos/gregsexton/ob-ipython/languages","stargazers_url":"https://api.github.com/repos/gregsexton/ob-ipython/stargazers","contributors_url":"https://api.github.com/repos/gregsexton/ob-ipython/contributors","subscribers_url":"https://api.github.com/repos/gregsexton/ob-ipython/subscribers","subscription_url":"https://api.github.com/repos/gregsexton/ob-ipython/subscription","commits_url":"https://api.github.com/repos/gregsexton/ob-ipython/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregsexton/ob-ipython/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregsexton/ob-ipython/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregsexton/ob-ipython/contents/{+path}","compare_url":"https://api.github.com/repos/gregsexton/ob-ipython/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregsexton/ob-ipython/merges","archive_url":"https://api.github.com/repos/gregsexton/ob-ipython/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregsexton/ob-ipython/downloads","issues_url":"https://api.github.com/repos/gregsexton/ob-ipython/issues{/number}","pulls_url":"https://api.github.com/repos/gregsexton/ob-ipython/pulls{/number}","milestones_url":"https://api.github.com/repos/gregsexton/ob-ipython/milestones{/number}","notifications_url":"https://api.github.com/repos/gregsexton/ob-ipython/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregsexton/ob-ipython/labels{/name}","releases_url":"https://api.github.com/repos/gregsexton/ob-ipython/releases{/id}","created_at":"2015-06-06T17:51:02Z","updated_at":"2015-09-25T11:00:10Z","pushed_at":"2015-09-26T14:12:10Z","git_url":"git://github.com/gregsexton/ob-ipython.git","ssh_url":"git@github.com:gregsexton/ob-ipython.git","clone_url":"https://github.com/gregsexton/ob-ipython.git","svn_url":"https://github.com/gregsexton/ob-ipython","homepage":"","size":761,"stargazers_count":187,"watchers_count":187,"language":"Emacs Lisp","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":9,"forks":18,"open_issues":9,"watchers":187,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31"},"html":{"href":"https://github.com/gregsexton/ob-ipython/pull/31"},"issue":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31"},"comments":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/gregsexton/ob-ipython/statuses/5fceb3b67efd3f4b57146252c01e94f940cc2e4e"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"gregsexton","id":150883,"avatar_url":"https://avatars.githubusercontent.com/u/150883?v=3","gravatar_id":"","url":"https://api.github.com/users/gregsexton","html_url":"https://github.com/gregsexton","followers_url":"https://api.github.com/users/gregsexton/followers","following_url":"https://api.github.com/users/gregsexton/following{/other_user}","gists_url":"https://api.github.com/users/gregsexton/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsexton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsexton/subscriptions","organizations_url":"https://api.github.com/users/gregsexton/orgs","repos_url":"https://api.github.com/users/gregsexton/repos","events_url":"https://api.github.com/users/gregsexton/events{/privacy}","received_events_url":"https://api.github.com/users/gregsexton/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":7,"deletions":2,"changed_files":1}}