{"action":"created","issue":{"url":"https://api.github.com/repos/ExtraCells/ExtraCells2/issues/274","labels_url":"https://api.github.com/repos/ExtraCells/ExtraCells2/issues/274/labels{/name}","comments_url":"https://api.github.com/repos/ExtraCells/ExtraCells2/issues/274/comments","events_url":"https://api.github.com/repos/ExtraCells/ExtraCells2/issues/274/events","html_url":"https://github.com/ExtraCells/ExtraCells2/issues/274","id":101245314,"number":274,"title":"Code Cleanup","user":{"login":"ruifung","id":1073945,"avatar_url":"https://avatars.githubusercontent.com/u/1073945?v=3","gravatar_id":"","url":"https://api.github.com/users/ruifung","html_url":"https://github.com/ruifung","followers_url":"https://api.github.com/users/ruifung/followers","following_url":"https://api.github.com/users/ruifung/following{/other_user}","gists_url":"https://api.github.com/users/ruifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifung/subscriptions","organizations_url":"https://api.github.com/users/ruifung/orgs","repos_url":"https://api.github.com/users/ruifung/repos","events_url":"https://api.github.com/users/ruifung/events{/privacy}","received_events_url":"https://api.github.com/users/ruifung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ruifung","id":1073945,"avatar_url":"https://avatars.githubusercontent.com/u/1073945?v=3","gravatar_id":"","url":"https://api.github.com/users/ruifung","html_url":"https://github.com/ruifung","followers_url":"https://api.github.com/users/ruifung/followers","following_url":"https://api.github.com/users/ruifung/following{/other_user}","gists_url":"https://api.github.com/users/ruifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifung/subscriptions","organizations_url":"https://api.github.com/users/ruifung/orgs","repos_url":"https://api.github.com/users/ruifung/repos","events_url":"https://api.github.com/users/ruifung/events{/privacy}","received_events_url":"https://api.github.com/users/ruifung/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/ExtraCells/ExtraCells2/milestones/3","html_url":"https://github.com/ExtraCells/ExtraCells2/milestones/rewrite","labels_url":"https://api.github.com/repos/ExtraCells/ExtraCells2/milestones/3/labels","id":1263849,"number":3,"title":"rewrite","description":"Stuff to be added / changed in the rewrite","creator":{"login":"ruifung","id":1073945,"avatar_url":"https://avatars.githubusercontent.com/u/1073945?v=3","gravatar_id":"","url":"https://api.github.com/users/ruifung","html_url":"https://github.com/ruifung","followers_url":"https://api.github.com/users/ruifung/followers","following_url":"https://api.github.com/users/ruifung/following{/other_user}","gists_url":"https://api.github.com/users/ruifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifung/subscriptions","organizations_url":"https://api.github.com/users/ruifung/orgs","repos_url":"https://api.github.com/users/ruifung/repos","events_url":"https://api.github.com/users/ruifung/events{/privacy}","received_events_url":"https://api.github.com/users/ruifung/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":0,"state":"open","created_at":"2015-08-20T04:20:59Z","updated_at":"2015-09-08T07:00:43Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2015-08-16T09:18:15Z","updated_at":"2015-09-15T17:06:18Z","closed_at":null,"body":"This is an issue for code cleanup in this mod.\r\n\r\nIn trying to fix some bugs, I think that this mod needs a significant cleanup of its code, a few issues I've noticed are \r\n\r\n- Containers do not close when the part / block they are for no longer exist. (Working on this, should fix some of the dupe bugs related to containers gui not being closed after part is wrenched.)\r\n- Missing localizations.\r\n- Lots and lots of bugs. (Or well.. outstanding issues.)\r\n- Code is somewhat messy and poorly commented (There are variables named with obfuscated names?! - In the scala files.)\r\n\r\n\r\n@M3gaFr3ak @DrummerMC "},"comment":{"url":"https://api.github.com/repos/ExtraCells/ExtraCells2/issues/comments/140464880","html_url":"https://github.com/ExtraCells/ExtraCells2/issues/274#issuecomment-140464880","issue_url":"https://api.github.com/repos/ExtraCells/ExtraCells2/issues/274","id":140464880,"user":{"login":"ruifung","id":1073945,"avatar_url":"https://avatars.githubusercontent.com/u/1073945?v=3","gravatar_id":"","url":"https://api.github.com/users/ruifung","html_url":"https://github.com/ruifung","followers_url":"https://api.github.com/users/ruifung/followers","following_url":"https://api.github.com/users/ruifung/following{/other_user}","gists_url":"https://api.github.com/users/ruifung/gists{/gist_id}","starred_url":"https://api.github.com/users/ruifung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruifung/subscriptions","organizations_url":"https://api.github.com/users/ruifung/orgs","repos_url":"https://api.github.com/users/ruifung/repos","events_url":"https://api.github.com/users/ruifung/events{/privacy}","received_events_url":"https://api.github.com/users/ruifung/received_events","type":"User","site_admin":false},"created_at":"2015-09-15T17:06:18Z","updated_at":"2015-09-15T17:06:18Z","body":"smaller and more manageable code base? Well... most of EC2's code is either directly or indirectly related to the fluid components. And the gas functionality is just pretty much a bolt on function to the fluid functions. So yes, it would cut down a lot of the code size, although EC would probably be left with almost nothing. Off the top of my head? All thats left without fluid functionality is the various item storage cells. Gas functionality doesn't count because I think it was never completely implemented in the first place.\r\n\r\nHowever, the current state of the code isn't even fit for merging anywhere. If AE wanted to add fluid support? They would just end up recoding everything from scratch."}}