{"action":"opened","issue":{"url":"https://api.github.com/repos/superroma/testcafe-phoenix/issues/58","labels_url":"https://api.github.com/repos/superroma/testcafe-phoenix/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/superroma/testcafe-phoenix/issues/58/comments","events_url":"https://api.github.com/repos/superroma/testcafe-phoenix/issues/58/events","html_url":"https://github.com/superroma/testcafe-phoenix/issues/58","id":104489256,"number":58,"title":"Review rules after upgrading eslint to 1.x","user":{"login":"AndreyBelym","id":4479386,"avatar_url":"https://avatars.githubusercontent.com/u/4479386?v=3","gravatar_id":"","url":"https://api.github.com/users/AndreyBelym","html_url":"https://github.com/AndreyBelym","followers_url":"https://api.github.com/users/AndreyBelym/followers","following_url":"https://api.github.com/users/AndreyBelym/following{/other_user}","gists_url":"https://api.github.com/users/AndreyBelym/gists{/gist_id}","starred_url":"https://api.github.com/users/AndreyBelym/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndreyBelym/subscriptions","organizations_url":"https://api.github.com/users/AndreyBelym/orgs","repos_url":"https://api.github.com/users/AndreyBelym/repos","events_url":"https://api.github.com/users/AndreyBelym/events{/privacy}","received_events_url":"https://api.github.com/users/AndreyBelym/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":0,"created_at":"2015-09-02T14:08:19Z","updated_at":"2015-09-02T14:08:19Z","closed_at":null,"body":"From [Migrating to 1.0.0](http://eslint.org/docs/user-guide/migrating-to-1.0.0.html):\r\nThe most important difference in v1.0.0 is that all rules are off by default. When using --init, your configuration file will automatically include the following line:\r\n```js\r\n{\r\n    \"extends\": \"eslint:recommended\"\r\n}\r\n```\r\nThis setting mimics some of the default behavior from 0.x, but not all. \r\nThese rules are no longer on by default, so you should review your settings to ensure they are still as you expect:\r\nno-alert\r\nno-array-constructor\r\nno-caller\r\nno-catch-shadow\r\nno-empty-label\r\nno-eval\r\nno-extend-native\r\nno-extra-bind\r\nno-extra-strict\r\nno-implied-eval\r\nno-iterator\r\nno-label-var\r\nno-labels\r\nno-lone-blocks\r\nno-loop-func\r\nno-multi-spaces\r\nno-multi-str\r\nno-native-reassign\r\nno-new\r\nno-new-func\r\nno-new-object\r\nno-new-wrappers\r\nno-octal-escape\r\nno-process-exit\r\nno-proto\r\nno-return-assign\r\nno-script-url\r\nno-sequences\r\nno-shadow\r\nno-shadow-restricted-names\r\nno-spaced-func\r\nno-trailing-spaces\r\nno-undef-init\r\nno-underscore-dangle\r\nno-unused-expressions\r\nno-use-before-define\r\nno-with\r\nno-wrap-func\r\ncamelcase\r\ncomma-spacing\r\nconsistent-return\r\ncurly\r\ndot-notation\r\neol-last\r\neqeqeq\r\nkey-spacing\r\nnew-cap\r\nnew-parens\r\nquotes\r\nsemi\r\nsemi-spacing\r\nspace-infix-ops\r\nspace-return-throw-case\r\nspace-unary-ops\r\nstrict\r\nyoda\r\nSee also: the [full diff](https://github.com/eslint/eslint/commit/e3e9dbd9876daf4bdeb4e15f8a76a9d5e6e03e39#diff-b01a5cfd9361ca9280a460fd6bb8edbbL1) where the defaults were changed.\r\n\r\nList of recommended rules:\r\ncomma-dangle - disallow or enforce trailing commas (recommended)\r\nno-cond-assign - disallow assignment in conditional expressions (recommended)\r\nno-console - disallow use of console in the node environment (recommended)\r\nno-constant-condition - disallow use of constant expressions in conditions (recommended)\r\nno-control-regex - disallow control characters in regular expressions (recommended)\r\nno-debugger - disallow use of debugger (recommended)\r\nno-dupe-args - disallow duplicate arguments in functions (recommended)\r\nno-dupe-keys - disallow duplicate keys when creating object literals (recommended)\r\nno-duplicate-case - disallow a duplicate case label. (recommended)\r\nno-empty-character-class - disallow the use of empty character classes in regular expressions (recommended)\r\nno-empty - disallow empty statements (recommended)\r\nno-ex-assign - disallow assigning to the exception in a catch block (recommended)\r\nno-extra-boolean-cast - disallow double-negation boolean casts in a boolean context (recommended)\r\nno-extra-semi - disallow unnecessary semicolons (recommended)\r\nno-func-assign - disallow overwriting functions written as function declarations (recommended)\r\nno-inner-declarations - disallow function or variable declarations in nested blocks (recommended)\r\nno-invalid-regexp - disallow invalid regular expression strings in the RegExp constructor (recommended)\r\nno-irregular-whitespace - disallow irregular whitespace outside of strings and comments (recommended)\r\nno-negated-in-lhs - disallow negation of the left operand of an in expression (recommended)\r\nno-obj-calls - disallow the use of object properties of the global object (Math and JSON) as functions (recommended)\r\nno-regex-spaces - disallow multiple spaces in a regular expression literal (recommended)\r\nno-sparse-arrays - disallow sparse arrays (recommended)\r\nno-unreachable - disallow unreachable statements after a return, throw, continue, or break statement (recommended)\r\nuse-isnan - disallow comparisons with the value NaN (recommended)\r\nvalid-typeof - Ensure that the results of typeof are compared against a valid string (recommended)\r\nno-fallthrough - disallow fallthrough of case statements (recommended)\r\nno-octal - disallow use of octal literals (recommended)\r\nno-redeclare - disallow declaring the same variable more than once (recommended)\r\nno-delete-var - disallow deletion of variables (recommended)\r\nno-undef - disallow use of undeclared variables unless mentioned in a /*global */ block (recommended)\r\nno-unused-vars - disallow declaration of variables that are not used in the code (recommended)\r\nno-mixed-spaces-and-tabs - disallow mixed spaces and tabs for indentation (recommended)\r\n\r\nWe need to review .eslintrc for inheriting default rules and manually adding rules that were excluded from defaults (e.g. no-undef, semi and so)."}}