{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/smashbox/pulls/comments/45602240","id":45602240,"diff_hunk":"@@ -0,0 +1,413 @@\n+__doc__ = \"\"\"\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| step  | owner           | R1             | R2                | R3          | R4              |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 2     | create dir      | create dir     | create dir        | create dir  | create dir      |\n+|       | share /test     |                |                   |             |                 |\n+|       |   -> R1 R2      |                |                   |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 3     |                 |                | reshare /test     |             |                 |\n+|       |                 |                |   -> R3           |             |                 |\n+|       |                 |                | reshare /test/sub |             |                 |\n+|       |                 |                |   -> R4           |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 4     | get etags       | get etags      | get etags         | get etags   | get etags       |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 5     | upload to       |                |                   |             |                 |\n+|       |   -> /test      |                |                   |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 6     | propagation     | propagation    | propagation       | propagation | NOT propagation |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 7     |                 |                | upload to         |             |                 |\n+|       |                 |                |   -> /test        |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 8     | propagation     | propagation    | propagation       | propagation | NOT propagation |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 9     | upload to       |                |                   |             |                 |\n+|       |   -> /test/sub  |                |                   |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 10    | propagation     | propagation    | propagation       | propagation | propagation     |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 11    |                 | upload to      |                   |             |                 |\n+|       |                 |   -> /test/sub |                   |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 12    | propagation     | propagation    | propagation       | propagation | propagation     |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 13    |                 |                |                   |             | upload to /sub  |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 14    | propagation     | propagation    | propagation       | propagation | propagation     |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 15    |                 |                | unshare           |             |                 |\n+|       |                 |                |   -> /test/sub    |             |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+| 16    | NOT propagation | NOT            | NOT propagation   | NOT         | propagation     |\n+|       |                 | propagation    |                   | propagation |                 |\n++-------+-----------------+----------------+-------------------+-------------+-----------------+\n+\n+Remove the sleep(x) once https://github.com/owncloud/client/issues/4160 has a resolution\n+\"\"\"\n+from smashbox.utilities import *\n+import itertools\n+import os.path\n+import re\n+import time\n+\n+@add_worker\n+def setup(step):\n+\n+    step(1, 'create test users')\n+    reset_owncloud_account(num_test_users=5)\n+    check_users(5)\n+\n+    reset_rundir()\n+    reset_server_log_file()\n+\n+    step(17, 'Validate server log file is clean')\n+\n+    d = make_workdir()\n+    scrape_log_file(d)\n+\n+@add_worker\n+def owner(step):\n+    user = '%s%i' % (config.oc_account_name, 1)\n+\n+    step (2, 'Create workdir')\n+    d = make_workdir()\n+\n+    mkdir(os.path.join(d, 'test'))\n+    mkdir(os.path.join(d, 'test', 'sub'))\n+    run_ocsync(d, user_num=1)\n+\n+    client = get_oc_api()\n+    client.login(user, config.oc_account_password)\n+    # make sure folder is shared\n+    user2 = '%s%i' % (config.oc_account_name, 2)\n+    share1_data = client.share_file_with_user('/test', user2, perms=31)\n+    fatal_check(share1_data, 'failed sharing a file with %s' % (user2,))\n+\n+    user3 = '%s%i' % (config.oc_account_name, 3)\n+    share1_data = client.share_file_with_user('/test', user3, perms=31)\n+    fatal_check(share1_data, 'failed sharing a file with %s' % (user3,))\n+\n+    step(4, 'get base etags to compare')\n+    root_etag = client.file_info('/').get_etag()\n+    test_etag = client.file_info('/test').get_etag()\n+\n+    step(5, 'Upload to /test')\n+    createfile(os.path.join(d, 'test', 'test2.txt'), '2', count=1000, bs=10)\n+    run_ocsync(d, user_num=1)","path":"lib/owncloud/test_sharePropagationInside.py","position":98,"original_position":98,"commit_id":"0318c96472b1c9780731f6a9373971fec04824cf","original_commit_id":"0318c96472b1c9780731f6a9373971fec04824cf","user":{"login":"icewind1991","id":1283854,"avatar_url":"https://avatars.githubusercontent.com/u/1283854?v=3","gravatar_id":"","url":"https://api.github.com/users/icewind1991","html_url":"https://github.com/icewind1991","followers_url":"https://api.github.com/users/icewind1991/followers","following_url":"https://api.github.com/users/icewind1991/following{/other_user}","gists_url":"https://api.github.com/users/icewind1991/gists{/gist_id}","starred_url":"https://api.github.com/users/icewind1991/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icewind1991/subscriptions","organizations_url":"https://api.github.com/users/icewind1991/orgs","repos_url":"https://api.github.com/users/icewind1991/repos","events_url":"https://api.github.com/users/icewind1991/events{/privacy}","received_events_url":"https://api.github.com/users/icewind1991/received_events","type":"User","site_admin":false},"body":"missing sleep","created_at":"2015-11-23T13:26:25Z","updated_at":"2015-11-23T13:26:25Z","html_url":"https://github.com/owncloud/smashbox/pull/136#discussion_r45602240","pull_request_url":"https://api.github.com/repos/owncloud/smashbox/pulls/136","_links":{"self":{"href":"https://api.github.com/repos/owncloud/smashbox/pulls/comments/45602240"},"html":{"href":"https://github.com/owncloud/smashbox/pull/136#discussion_r45602240"},"pull_request":{"href":"https://api.github.com/repos/owncloud/smashbox/pulls/136"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/smashbox/pulls/136","id":51089102,"html_url":"https://github.com/owncloud/smashbox/pull/136","diff_url":"https://github.com/owncloud/smashbox/pull/136.diff","patch_url":"https://github.com/owncloud/smashbox/pull/136.patch","issue_url":"https://api.github.com/repos/owncloud/smashbox/issues/136","number":136,"state":"open","locked":false,"title":"Sharing etag propagation tests","user":{"login":"jvillafanez","id":1477829,"avatar_url":"https://avatars.githubusercontent.com/u/1477829?v=3","gravatar_id":"","url":"https://api.github.com/users/jvillafanez","html_url":"https://github.com/jvillafanez","followers_url":"https://api.github.com/users/jvillafanez/followers","following_url":"https://api.github.com/users/jvillafanez/following{/other_user}","gists_url":"https://api.github.com/users/jvillafanez/gists{/gist_id}","starred_url":"https://api.github.com/users/jvillafanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jvillafanez/subscriptions","organizations_url":"https://api.github.com/users/jvillafanez/orgs","repos_url":"https://api.github.com/users/jvillafanez/repos","events_url":"https://api.github.com/users/jvillafanez/events{/privacy}","received_events_url":"https://api.github.com/users/jvillafanez/received_events","type":"User","site_admin":false},"body":"Only for users, includes resharing and uploads to several places\r\n\r\nBased on https://github.com/owncloud/core/pull/14764#issuecomment-78468808\r\n\r\nI have to improve the error messages. Any ideas are welcomed.\r\n\r\nThere are a couple of potential issues detected (if the tests are correct):\r\n* unsharing doesn't change the etag of the share owner\r\n* uploading a file inside a reshare doesn't propagate the etag change to the original owner. Owner shares to recip1, recip1 shares to recip2, recip2 uploads a file, owner doesn't get the change\r\n\r\n@nickvergessen @DeepDiver1975 @PVince81 ","created_at":"2015-11-18T14:16:48Z","updated_at":"2015-11-23T13:26:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e0093804482b774fc5093a9b5602973a2d616625","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/owncloud/smashbox/pulls/136/commits","review_comments_url":"https://api.github.com/repos/owncloud/smashbox/pulls/136/comments","review_comment_url":"https://api.github.com/repos/owncloud/smashbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/smashbox/issues/136/comments","statuses_url":"https://api.github.com/repos/owncloud/smashbox/statuses/0318c96472b1c9780731f6a9373971fec04824cf","head":{"label":"owncloud:share_propagation_tests","ref":"share_propagation_tests","sha":"0318c96472b1c9780731f6a9373971fec04824cf","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":29028070,"name":"smashbox","full_name":"owncloud/smashbox","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/smashbox","description":"main test suite","fork":true,"url":"https://api.github.com/repos/owncloud/smashbox","forks_url":"https://api.github.com/repos/owncloud/smashbox/forks","keys_url":"https://api.github.com/repos/owncloud/smashbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/smashbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/smashbox/teams","hooks_url":"https://api.github.com/repos/owncloud/smashbox/hooks","issue_events_url":"https://api.github.com/repos/owncloud/smashbox/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/smashbox/events","assignees_url":"https://api.github.com/repos/owncloud/smashbox/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/smashbox/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/smashbox/tags","blobs_url":"https://api.github.com/repos/owncloud/smashbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/smashbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/smashbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/smashbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/smashbox/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/smashbox/languages","stargazers_url":"https://api.github.com/repos/owncloud/smashbox/stargazers","contributors_url":"https://api.github.com/repos/owncloud/smashbox/contributors","subscribers_url":"https://api.github.com/repos/owncloud/smashbox/subscribers","subscription_url":"https://api.github.com/repos/owncloud/smashbox/subscription","commits_url":"https://api.github.com/repos/owncloud/smashbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/smashbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/smashbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/smashbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/smashbox/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/smashbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/smashbox/merges","archive_url":"https://api.github.com/repos/owncloud/smashbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/smashbox/downloads","issues_url":"https://api.github.com/repos/owncloud/smashbox/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/smashbox/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/smashbox/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/smashbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/smashbox/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/smashbox/releases{/id}","created_at":"2015-01-09T17:50:29Z","updated_at":"2015-10-11T02:33:44Z","pushed_at":"2015-11-20T14:29:37Z","git_url":"git://github.com/owncloud/smashbox.git","ssh_url":"git@github.com:owncloud/smashbox.git","clone_url":"https://github.com/owncloud/smashbox.git","svn_url":"https://github.com/owncloud/smashbox","homepage":null,"size":815,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":13,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"ee57a2b0ff870c21472b960468b95f53e7f65265","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":29028070,"name":"smashbox","full_name":"owncloud/smashbox","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/smashbox","description":"main test suite","fork":true,"url":"https://api.github.com/repos/owncloud/smashbox","forks_url":"https://api.github.com/repos/owncloud/smashbox/forks","keys_url":"https://api.github.com/repos/owncloud/smashbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/smashbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/smashbox/teams","hooks_url":"https://api.github.com/repos/owncloud/smashbox/hooks","issue_events_url":"https://api.github.com/repos/owncloud/smashbox/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/smashbox/events","assignees_url":"https://api.github.com/repos/owncloud/smashbox/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/smashbox/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/smashbox/tags","blobs_url":"https://api.github.com/repos/owncloud/smashbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/smashbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/smashbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/smashbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/smashbox/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/smashbox/languages","stargazers_url":"https://api.github.com/repos/owncloud/smashbox/stargazers","contributors_url":"https://api.github.com/repos/owncloud/smashbox/contributors","subscribers_url":"https://api.github.com/repos/owncloud/smashbox/subscribers","subscription_url":"https://api.github.com/repos/owncloud/smashbox/subscription","commits_url":"https://api.github.com/repos/owncloud/smashbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/smashbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/smashbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/smashbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/smashbox/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/smashbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/smashbox/merges","archive_url":"https://api.github.com/repos/owncloud/smashbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/smashbox/downloads","issues_url":"https://api.github.com/repos/owncloud/smashbox/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/smashbox/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/smashbox/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/smashbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/smashbox/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/smashbox/releases{/id}","created_at":"2015-01-09T17:50:29Z","updated_at":"2015-10-11T02:33:44Z","pushed_at":"2015-11-20T14:29:37Z","git_url":"git://github.com/owncloud/smashbox.git","ssh_url":"git@github.com:owncloud/smashbox.git","clone_url":"https://github.com/owncloud/smashbox.git","svn_url":"https://github.com/owncloud/smashbox","homepage":null,"size":815,"stargazers_count":13,"watchers_count":13,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":32,"forks":2,"open_issues":32,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/smashbox/pulls/136"},"html":{"href":"https://github.com/owncloud/smashbox/pull/136"},"issue":{"href":"https://api.github.com/repos/owncloud/smashbox/issues/136"},"comments":{"href":"https://api.github.com/repos/owncloud/smashbox/issues/136/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/smashbox/pulls/136/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/smashbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/smashbox/pulls/136/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/smashbox/statuses/0318c96472b1c9780731f6a9373971fec04824cf"}}}}