{"action":"created","comment":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments/46087550","id":46087550,"diff_hunk":"@@ -347,8 +347,8 @@ void ConfigOsdWidget::setCustomText()\n     const QString text = ui->le_custom_text->displayText();\n     int n_string = text.size();\n \n-    for (int i=0; i<OnScreenDisplaySettings::CUSTOMTEXT_NUMELEM; i++){\n-        if (i < n_string){\n+    for (int i = 0; i < (int)OnScreenDisplaySettings::CUSTOMTEXT_NUMELEM; ++i) {","path":"ground/gcs/src/plugins/config/configosdwidget.cpp","position":6,"original_position":6,"commit_id":"cf3c7c28ddc93b62056c94c2b663e7b9a31e9476","original_commit_id":"cf3c7c28ddc93b62056c94c2b663e7b9a31e9476","user":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars.githubusercontent.com/u/9995998?v=3","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"body":"I've changed them all the unsigned, will push soon. :-)","created_at":"2015-11-29T04:36:54Z","updated_at":"2015-11-29T04:36:54Z","html_url":"https://github.com/d-ronin/dRonin/pull/85#discussion_r46087550","pull_request_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/85","_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments/46087550"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/85#discussion_r46087550"},"pull_request":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/85"}}},"pull_request":{"url":"https://api.github.com/repos/d-ronin/dRonin/pulls/85","id":52053831,"html_url":"https://github.com/d-ronin/dRonin/pull/85","diff_url":"https://github.com/d-ronin/dRonin/pull/85.diff","patch_url":"https://github.com/d-ronin/dRonin/pull/85.patch","issue_url":"https://api.github.com/repos/d-ronin/dRonin/issues/85","number":85,"state":"open","locked":false,"title":"GCS: Fix all of the compiler warnings","user":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars.githubusercontent.com/u/9995998?v=3","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"body":"Fixes #84 \r\nAfter this:\r\n```\r\nmike@mike-desktop:~/Dev/dronin$ make all_clean\r\n[ ! -d \"/home/mike/Dev/dronin/build\" ] || rm -r \"/home/mike/Dev/dronin/build\"\r\nmike@mike-desktop:~/Dev/dronin$ make -j8 gcs 1> /dev/null\r\nProject MESSAGE: tlfw_resource.qrc not found.  Automatically firmware updates disabled.\r\n```","created_at":"2015-11-29T03:25:27Z","updated_at":"2015-11-29T04:36:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f04b18215c62a044a4a2c0e02be514886f780a63","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/85/commits","review_comments_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/85/comments","review_comment_url":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/issues/85/comments","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/cf3c7c28ddc93b62056c94c2b663e7b9a31e9476","head":{"label":"tracernz:gcs-shutup","ref":"gcs-shutup","sha":"cf3c7c28ddc93b62056c94c2b663e7b9a31e9476","user":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars.githubusercontent.com/u/9995998?v=3","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"repo":{"id":43622092,"name":"dronin","full_name":"tracernz/dronin","owner":{"login":"tracernz","id":9995998,"avatar_url":"https://avatars.githubusercontent.com/u/9995998?v=3","gravatar_id":"","url":"https://api.github.com/users/tracernz","html_url":"https://github.com/tracernz","followers_url":"https://api.github.com/users/tracernz/followers","following_url":"https://api.github.com/users/tracernz/following{/other_user}","gists_url":"https://api.github.com/users/tracernz/gists{/gist_id}","starred_url":"https://api.github.com/users/tracernz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tracernz/subscriptions","organizations_url":"https://api.github.com/users/tracernz/orgs","repos_url":"https://api.github.com/users/tracernz/repos","events_url":"https://api.github.com/users/tracernz/events{/privacy}","received_events_url":"https://api.github.com/users/tracernz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tracernz/dronin","description":"The dRonin' flight controller software.","fork":true,"url":"https://api.github.com/repos/tracernz/dronin","forks_url":"https://api.github.com/repos/tracernz/dronin/forks","keys_url":"https://api.github.com/repos/tracernz/dronin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tracernz/dronin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tracernz/dronin/teams","hooks_url":"https://api.github.com/repos/tracernz/dronin/hooks","issue_events_url":"https://api.github.com/repos/tracernz/dronin/issues/events{/number}","events_url":"https://api.github.com/repos/tracernz/dronin/events","assignees_url":"https://api.github.com/repos/tracernz/dronin/assignees{/user}","branches_url":"https://api.github.com/repos/tracernz/dronin/branches{/branch}","tags_url":"https://api.github.com/repos/tracernz/dronin/tags","blobs_url":"https://api.github.com/repos/tracernz/dronin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tracernz/dronin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tracernz/dronin/git/refs{/sha}","trees_url":"https://api.github.com/repos/tracernz/dronin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tracernz/dronin/statuses/{sha}","languages_url":"https://api.github.com/repos/tracernz/dronin/languages","stargazers_url":"https://api.github.com/repos/tracernz/dronin/stargazers","contributors_url":"https://api.github.com/repos/tracernz/dronin/contributors","subscribers_url":"https://api.github.com/repos/tracernz/dronin/subscribers","subscription_url":"https://api.github.com/repos/tracernz/dronin/subscription","commits_url":"https://api.github.com/repos/tracernz/dronin/commits{/sha}","git_commits_url":"https://api.github.com/repos/tracernz/dronin/git/commits{/sha}","comments_url":"https://api.github.com/repos/tracernz/dronin/comments{/number}","issue_comment_url":"https://api.github.com/repos/tracernz/dronin/issues/comments{/number}","contents_url":"https://api.github.com/repos/tracernz/dronin/contents/{+path}","compare_url":"https://api.github.com/repos/tracernz/dronin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tracernz/dronin/merges","archive_url":"https://api.github.com/repos/tracernz/dronin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tracernz/dronin/downloads","issues_url":"https://api.github.com/repos/tracernz/dronin/issues{/number}","pulls_url":"https://api.github.com/repos/tracernz/dronin/pulls{/number}","milestones_url":"https://api.github.com/repos/tracernz/dronin/milestones{/number}","notifications_url":"https://api.github.com/repos/tracernz/dronin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tracernz/dronin/labels{/name}","releases_url":"https://api.github.com/repos/tracernz/dronin/releases{/id}","created_at":"2015-10-04T02:16:11Z","updated_at":"2015-10-04T02:16:57Z","pushed_at":"2015-11-29T03:38:06Z","git_url":"git://github.com/tracernz/dronin.git","ssh_url":"git@github.com:tracernz/dronin.git","clone_url":"https://github.com/tracernz/dronin.git","svn_url":"https://github.com/tracernz/dronin","homepage":null,"size":211784,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"next"}},"base":{"label":"d-ronin:next","ref":"next","sha":"87f49a9db6ad7a63afc3c630e1b0b77e79c9b74e","user":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"repo":{"id":43620723,"name":"dRonin","full_name":"d-ronin/dRonin","owner":{"login":"d-ronin","id":14959302,"avatar_url":"https://avatars.githubusercontent.com/u/14959302?v=3","gravatar_id":"","url":"https://api.github.com/users/d-ronin","html_url":"https://github.com/d-ronin","followers_url":"https://api.github.com/users/d-ronin/followers","following_url":"https://api.github.com/users/d-ronin/following{/other_user}","gists_url":"https://api.github.com/users/d-ronin/gists{/gist_id}","starred_url":"https://api.github.com/users/d-ronin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-ronin/subscriptions","organizations_url":"https://api.github.com/users/d-ronin/orgs","repos_url":"https://api.github.com/users/d-ronin/repos","events_url":"https://api.github.com/users/d-ronin/events{/privacy}","received_events_url":"https://api.github.com/users/d-ronin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d-ronin/dRonin","description":"The dRonin' flight controller software.","fork":false,"url":"https://api.github.com/repos/d-ronin/dRonin","forks_url":"https://api.github.com/repos/d-ronin/dRonin/forks","keys_url":"https://api.github.com/repos/d-ronin/dRonin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-ronin/dRonin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-ronin/dRonin/teams","hooks_url":"https://api.github.com/repos/d-ronin/dRonin/hooks","issue_events_url":"https://api.github.com/repos/d-ronin/dRonin/issues/events{/number}","events_url":"https://api.github.com/repos/d-ronin/dRonin/events","assignees_url":"https://api.github.com/repos/d-ronin/dRonin/assignees{/user}","branches_url":"https://api.github.com/repos/d-ronin/dRonin/branches{/branch}","tags_url":"https://api.github.com/repos/d-ronin/dRonin/tags","blobs_url":"https://api.github.com/repos/d-ronin/dRonin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-ronin/dRonin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-ronin/dRonin/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-ronin/dRonin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-ronin/dRonin/statuses/{sha}","languages_url":"https://api.github.com/repos/d-ronin/dRonin/languages","stargazers_url":"https://api.github.com/repos/d-ronin/dRonin/stargazers","contributors_url":"https://api.github.com/repos/d-ronin/dRonin/contributors","subscribers_url":"https://api.github.com/repos/d-ronin/dRonin/subscribers","subscription_url":"https://api.github.com/repos/d-ronin/dRonin/subscription","commits_url":"https://api.github.com/repos/d-ronin/dRonin/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-ronin/dRonin/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-ronin/dRonin/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-ronin/dRonin/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-ronin/dRonin/contents/{+path}","compare_url":"https://api.github.com/repos/d-ronin/dRonin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-ronin/dRonin/merges","archive_url":"https://api.github.com/repos/d-ronin/dRonin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-ronin/dRonin/downloads","issues_url":"https://api.github.com/repos/d-ronin/dRonin/issues{/number}","pulls_url":"https://api.github.com/repos/d-ronin/dRonin/pulls{/number}","milestones_url":"https://api.github.com/repos/d-ronin/dRonin/milestones{/number}","notifications_url":"https://api.github.com/repos/d-ronin/dRonin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-ronin/dRonin/labels{/name}","releases_url":"https://api.github.com/repos/d-ronin/dRonin/releases{/id}","created_at":"2015-10-04T01:13:04Z","updated_at":"2015-11-28T16:55:44Z","pushed_at":"2015-11-29T03:52:05Z","git_url":"git://github.com/d-ronin/dRonin.git","ssh_url":"git@github.com:d-ronin/dRonin.git","clone_url":"https://github.com/d-ronin/dRonin.git","svn_url":"https://github.com/d-ronin/dRonin","homepage":null,"size":211962,"stargazers_count":18,"watchers_count":18,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"open_issues_count":47,"forks":14,"open_issues":47,"watchers":18,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/85"},"html":{"href":"https://github.com/d-ronin/dRonin/pull/85"},"issue":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/85"},"comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d-ronin/dRonin/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/d-ronin/dRonin/statuses/cf3c7c28ddc93b62056c94c2b663e7b9a31e9476"}}}}