{"action":"created","comment":{"url":"https://api.github.com/repos/iadvize/javascript/pulls/comments/32134410","id":32134410,"diff_hunk":"@@ -6,28 +6,80 @@\n - use [React](https://facebook.github.io/react/) and [JSX](https://facebook.github.io/react/docs/jsx-in-depth.html) as our view engine\n - use [Flux](https://facebook.github.io/flux/docs/overview.html) as our application architecture\n \n+### Naming conventions\n+\n+- Use `PascalCase` when naming constructors or classes (i.e. something you can instantiate with `new`)\n+  \n+    ```javascript\n+    // bad\n+    function user() {}\n+\n+    var bad = new user();\n+\n+    // good\n+    function User() {}\n+\n+    var good = new User();\n+    ```\n+  \n+- Use `CAPITAL_CASE` when naming constants\n+    \n+    ```js\n+      // bad\n+      var pi = 3.1416;\n+      \n+      // good\n+      var PI = 3.1416;\n+    ```\n+    \n+- Use `camelCase` for all the other things\n+\n ### Modules\n \n - use CommonJS style (node-like style via Browserify)\n+- the file should match the name and the case of the single export\n+    \n+    ```js\n+    // bad\n+    // filename = \"MyModule.js\"\n+    var myModule = {};\n+    module.exports = myModule;\n+    \n+    // bad\n+    // filename = \"myClass.js\"\n+    function MyClass() {}\n+    module.exports = MyClass;\n+    \n+    // good\n+    // filename = \"myModule.js\"\n+    var myModule = {};\n+    module.exports = myModule;\n+    ","path":"DESK.md","position":52,"original_position":52,"commit_id":"fe752c2d5dfdc30d161610112e5b96a3299e33e7","original_commit_id":"fe752c2d5dfdc30d161610112e5b96a3299e33e7","user":{"login":"fdeurioste","id":2890279,"avatar_url":"https://avatars.githubusercontent.com/u/2890279?v=3","gravatar_id":"","url":"https://api.github.com/users/fdeurioste","html_url":"https://github.com/fdeurioste","followers_url":"https://api.github.com/users/fdeurioste/followers","following_url":"https://api.github.com/users/fdeurioste/following{/other_user}","gists_url":"https://api.github.com/users/fdeurioste/gists{/gist_id}","starred_url":"https://api.github.com/users/fdeurioste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdeurioste/subscriptions","organizations_url":"https://api.github.com/users/fdeurioste/orgs","repos_url":"https://api.github.com/users/fdeurioste/repos","events_url":"https://api.github.com/users/fdeurioste/events{/privacy}","received_events_url":"https://api.github.com/users/fdeurioste/received_events","type":"User","site_admin":false},"body":"Mais pour le reste :+1: ","created_at":"2015-06-10T16:07:54Z","updated_at":"2015-06-10T16:07:54Z","html_url":"https://github.com/iadvize/javascript/pull/10#discussion_r32134410","pull_request_url":"https://api.github.com/repos/iadvize/javascript/pulls/10","_links":{"self":{"href":"https://api.github.com/repos/iadvize/javascript/pulls/comments/32134410"},"html":{"href":"https://github.com/iadvize/javascript/pull/10#discussion_r32134410"},"pull_request":{"href":"https://api.github.com/repos/iadvize/javascript/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/iadvize/javascript/pulls/10","id":37369969,"html_url":"https://github.com/iadvize/javascript/pull/10","diff_url":"https://github.com/iadvize/javascript/pull/10.diff","patch_url":"https://github.com/iadvize/javascript/pull/10.patch","issue_url":"https://api.github.com/repos/iadvize/javascript/issues/10","number":10,"state":"open","locked":false,"title":"Case convention without factory","user":{"login":"farnoux","id":98240,"avatar_url":"https://avatars.githubusercontent.com/u/98240?v=3","gravatar_id":"","url":"https://api.github.com/users/farnoux","html_url":"https://github.com/farnoux","followers_url":"https://api.github.com/users/farnoux/followers","following_url":"https://api.github.com/users/farnoux/following{/other_user}","gists_url":"https://api.github.com/users/farnoux/gists{/gist_id}","starred_url":"https://api.github.com/users/farnoux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/farnoux/subscriptions","organizations_url":"https://api.github.com/users/farnoux/orgs","repos_url":"https://api.github.com/users/farnoux/repos","events_url":"https://api.github.com/users/farnoux/events{/privacy}","received_events_url":"https://api.github.com/users/farnoux/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-06-10T15:16:10Z","updated_at":"2015-06-10T16:07:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b757260cad748c774c567cd192b9b47bad79b5a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/iadvize/javascript/pulls/10/commits","review_comments_url":"https://api.github.com/repos/iadvize/javascript/pulls/10/comments","review_comment_url":"https://api.github.com/repos/iadvize/javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iadvize/javascript/issues/10/comments","statuses_url":"https://api.github.com/repos/iadvize/javascript/statuses/fe752c2d5dfdc30d161610112e5b96a3299e33e7","head":{"label":"iadvize:caseConventionWithoutFactory","ref":"caseConventionWithoutFactory","sha":"fe752c2d5dfdc30d161610112e5b96a3299e33e7","user":{"login":"iadvize","id":216094,"avatar_url":"https://avatars.githubusercontent.com/u/216094?v=3","gravatar_id":"","url":"https://api.github.com/users/iadvize","html_url":"https://github.com/iadvize","followers_url":"https://api.github.com/users/iadvize/followers","following_url":"https://api.github.com/users/iadvize/following{/other_user}","gists_url":"https://api.github.com/users/iadvize/gists{/gist_id}","starred_url":"https://api.github.com/users/iadvize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iadvize/subscriptions","organizations_url":"https://api.github.com/users/iadvize/orgs","repos_url":"https://api.github.com/users/iadvize/repos","events_url":"https://api.github.com/users/iadvize/events{/privacy}","received_events_url":"https://api.github.com/users/iadvize/received_events","type":"Organization","site_admin":false},"repo":{"id":15041392,"name":"javascript","full_name":"iadvize/javascript","owner":{"login":"iadvize","id":216094,"avatar_url":"https://avatars.githubusercontent.com/u/216094?v=3","gravatar_id":"","url":"https://api.github.com/users/iadvize","html_url":"https://github.com/iadvize","followers_url":"https://api.github.com/users/iadvize/followers","following_url":"https://api.github.com/users/iadvize/following{/other_user}","gists_url":"https://api.github.com/users/iadvize/gists{/gist_id}","starred_url":"https://api.github.com/users/iadvize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iadvize/subscriptions","organizations_url":"https://api.github.com/users/iadvize/orgs","repos_url":"https://api.github.com/users/iadvize/repos","events_url":"https://api.github.com/users/iadvize/events{/privacy}","received_events_url":"https://api.github.com/users/iadvize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iadvize/javascript","description":"JavaScript Style Guide","fork":true,"url":"https://api.github.com/repos/iadvize/javascript","forks_url":"https://api.github.com/repos/iadvize/javascript/forks","keys_url":"https://api.github.com/repos/iadvize/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iadvize/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iadvize/javascript/teams","hooks_url":"https://api.github.com/repos/iadvize/javascript/hooks","issue_events_url":"https://api.github.com/repos/iadvize/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/iadvize/javascript/events","assignees_url":"https://api.github.com/repos/iadvize/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/iadvize/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/iadvize/javascript/tags","blobs_url":"https://api.github.com/repos/iadvize/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iadvize/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iadvize/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/iadvize/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iadvize/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/iadvize/javascript/languages","stargazers_url":"https://api.github.com/repos/iadvize/javascript/stargazers","contributors_url":"https://api.github.com/repos/iadvize/javascript/contributors","subscribers_url":"https://api.github.com/repos/iadvize/javascript/subscribers","subscription_url":"https://api.github.com/repos/iadvize/javascript/subscription","commits_url":"https://api.github.com/repos/iadvize/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/iadvize/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/iadvize/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/iadvize/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/iadvize/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/iadvize/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iadvize/javascript/merges","archive_url":"https://api.github.com/repos/iadvize/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iadvize/javascript/downloads","issues_url":"https://api.github.com/repos/iadvize/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/iadvize/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/iadvize/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/iadvize/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iadvize/javascript/labels{/name}","releases_url":"https://api.github.com/repos/iadvize/javascript/releases{/id}","created_at":"2013-12-09T07:56:47Z","updated_at":"2015-06-06T12:48:11Z","pushed_at":"2015-06-10T15:16:10Z","git_url":"git://github.com/iadvize/javascript.git","ssh_url":"git@github.com:iadvize/javascript.git","clone_url":"https://github.com/iadvize/javascript.git","svn_url":"https://github.com/iadvize/javascript","homepage":null,"size":826,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"iadvize:master","ref":"master","sha":"60e5549ee0f05ee937713025d1d0b700f4e6a61b","user":{"login":"iadvize","id":216094,"avatar_url":"https://avatars.githubusercontent.com/u/216094?v=3","gravatar_id":"","url":"https://api.github.com/users/iadvize","html_url":"https://github.com/iadvize","followers_url":"https://api.github.com/users/iadvize/followers","following_url":"https://api.github.com/users/iadvize/following{/other_user}","gists_url":"https://api.github.com/users/iadvize/gists{/gist_id}","starred_url":"https://api.github.com/users/iadvize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iadvize/subscriptions","organizations_url":"https://api.github.com/users/iadvize/orgs","repos_url":"https://api.github.com/users/iadvize/repos","events_url":"https://api.github.com/users/iadvize/events{/privacy}","received_events_url":"https://api.github.com/users/iadvize/received_events","type":"Organization","site_admin":false},"repo":{"id":15041392,"name":"javascript","full_name":"iadvize/javascript","owner":{"login":"iadvize","id":216094,"avatar_url":"https://avatars.githubusercontent.com/u/216094?v=3","gravatar_id":"","url":"https://api.github.com/users/iadvize","html_url":"https://github.com/iadvize","followers_url":"https://api.github.com/users/iadvize/followers","following_url":"https://api.github.com/users/iadvize/following{/other_user}","gists_url":"https://api.github.com/users/iadvize/gists{/gist_id}","starred_url":"https://api.github.com/users/iadvize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iadvize/subscriptions","organizations_url":"https://api.github.com/users/iadvize/orgs","repos_url":"https://api.github.com/users/iadvize/repos","events_url":"https://api.github.com/users/iadvize/events{/privacy}","received_events_url":"https://api.github.com/users/iadvize/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iadvize/javascript","description":"JavaScript Style Guide","fork":true,"url":"https://api.github.com/repos/iadvize/javascript","forks_url":"https://api.github.com/repos/iadvize/javascript/forks","keys_url":"https://api.github.com/repos/iadvize/javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iadvize/javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iadvize/javascript/teams","hooks_url":"https://api.github.com/repos/iadvize/javascript/hooks","issue_events_url":"https://api.github.com/repos/iadvize/javascript/issues/events{/number}","events_url":"https://api.github.com/repos/iadvize/javascript/events","assignees_url":"https://api.github.com/repos/iadvize/javascript/assignees{/user}","branches_url":"https://api.github.com/repos/iadvize/javascript/branches{/branch}","tags_url":"https://api.github.com/repos/iadvize/javascript/tags","blobs_url":"https://api.github.com/repos/iadvize/javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iadvize/javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iadvize/javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/iadvize/javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iadvize/javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/iadvize/javascript/languages","stargazers_url":"https://api.github.com/repos/iadvize/javascript/stargazers","contributors_url":"https://api.github.com/repos/iadvize/javascript/contributors","subscribers_url":"https://api.github.com/repos/iadvize/javascript/subscribers","subscription_url":"https://api.github.com/repos/iadvize/javascript/subscription","commits_url":"https://api.github.com/repos/iadvize/javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/iadvize/javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/iadvize/javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/iadvize/javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/iadvize/javascript/contents/{+path}","compare_url":"https://api.github.com/repos/iadvize/javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iadvize/javascript/merges","archive_url":"https://api.github.com/repos/iadvize/javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iadvize/javascript/downloads","issues_url":"https://api.github.com/repos/iadvize/javascript/issues{/number}","pulls_url":"https://api.github.com/repos/iadvize/javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/iadvize/javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/iadvize/javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iadvize/javascript/labels{/name}","releases_url":"https://api.github.com/repos/iadvize/javascript/releases{/id}","created_at":"2013-12-09T07:56:47Z","updated_at":"2015-06-06T12:48:11Z","pushed_at":"2015-06-10T15:16:10Z","git_url":"git://github.com/iadvize/javascript.git","ssh_url":"git@github.com:iadvize/javascript.git","clone_url":"https://github.com/iadvize/javascript.git","svn_url":"https://github.com/iadvize/javascript","homepage":null,"size":826,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iadvize/javascript/pulls/10"},"html":{"href":"https://github.com/iadvize/javascript/pull/10"},"issue":{"href":"https://api.github.com/repos/iadvize/javascript/issues/10"},"comments":{"href":"https://api.github.com/repos/iadvize/javascript/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/iadvize/javascript/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/iadvize/javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iadvize/javascript/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/iadvize/javascript/statuses/fe752c2d5dfdc30d161610112e5b96a3299e33e7"}}}}