{"action":"created","comment":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/33191370","id":33191370,"diff_hunk":"@@ -37,6 +37,10 @@ General commit rules\n    characters, separated by single blank line from the other parts (including\n    the subject).\n \n+4. Don't squash commits in your pull request. It makes it harder to","path":"contributing.rst","position":4,"original_position":4,"commit_id":"5c8064d3be34ccdcc9f20aae108a4e41be61c986","original_commit_id":"5c8064d3be34ccdcc9f20aae108a4e41be61c986","user":{"login":"reactormonk","id":49185,"avatar_url":"https://avatars.githubusercontent.com/u/49185?v=3","gravatar_id":"","url":"https://api.github.com/users/reactormonk","html_url":"https://github.com/reactormonk","followers_url":"https://api.github.com/users/reactormonk/followers","following_url":"https://api.github.com/users/reactormonk/following{/other_user}","gists_url":"https://api.github.com/users/reactormonk/gists{/gist_id}","starred_url":"https://api.github.com/users/reactormonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactormonk/subscriptions","organizations_url":"https://api.github.com/users/reactormonk/orgs","repos_url":"https://api.github.com/users/reactormonk/repos","events_url":"https://api.github.com/users/reactormonk/events{/privacy}","received_events_url":"https://api.github.com/users/reactormonk/received_events","type":"User","site_admin":false},"body":"Or via `git commit --amend`.","created_at":"2015-06-24T20:22:27Z","updated_at":"2015-06-24T20:22:27Z","html_url":"https://github.com/nim-lang/Nim/pull/2981#discussion_r33191370","pull_request_url":"https://api.github.com/repos/nim-lang/Nim/pulls/2981","_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments/33191370"},"html":{"href":"https://github.com/nim-lang/Nim/pull/2981#discussion_r33191370"},"pull_request":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2981"}}},"pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/2981","id":38456498,"html_url":"https://github.com/nim-lang/Nim/pull/2981","diff_url":"https://github.com/nim-lang/Nim/pull/2981.diff","patch_url":"https://github.com/nim-lang/Nim/pull/2981.patch","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/2981","number":2981,"state":"open","locked":false,"title":"no squashing in PRs","user":{"login":"reactormonk","id":49185,"avatar_url":"https://avatars.githubusercontent.com/u/49185?v=3","gravatar_id":"","url":"https://api.github.com/users/reactormonk","html_url":"https://github.com/reactormonk","followers_url":"https://api.github.com/users/reactormonk/followers","following_url":"https://api.github.com/users/reactormonk/following{/other_user}","gists_url":"https://api.github.com/users/reactormonk/gists{/gist_id}","starred_url":"https://api.github.com/users/reactormonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactormonk/subscriptions","organizations_url":"https://api.github.com/users/reactormonk/orgs","repos_url":"https://api.github.com/users/reactormonk/repos","events_url":"https://api.github.com/users/reactormonk/events{/privacy}","received_events_url":"https://api.github.com/users/reactormonk/received_events","type":"User","site_admin":false},"body":"Some people squash, some don't. Let's decide which one it should be, I'm for no squashing.","created_at":"2015-06-24T15:45:57Z","updated_at":"2015-06-24T20:22:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cebcd0f1d5b82b71e6f4fc4f3c256a26c409d81","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/nim-lang/Nim/pulls/2981/commits","review_comments_url":"https://api.github.com/repos/nim-lang/Nim/pulls/2981/comments","review_comment_url":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/2981/comments","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/5c8064d3be34ccdcc9f20aae108a4e41be61c986","head":{"label":"reactormonk:no-squashing","ref":"no-squashing","sha":"5c8064d3be34ccdcc9f20aae108a4e41be61c986","user":{"login":"reactormonk","id":49185,"avatar_url":"https://avatars.githubusercontent.com/u/49185?v=3","gravatar_id":"","url":"https://api.github.com/users/reactormonk","html_url":"https://github.com/reactormonk","followers_url":"https://api.github.com/users/reactormonk/followers","following_url":"https://api.github.com/users/reactormonk/following{/other_user}","gists_url":"https://api.github.com/users/reactormonk/gists{/gist_id}","starred_url":"https://api.github.com/users/reactormonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactormonk/subscriptions","organizations_url":"https://api.github.com/users/reactormonk/orgs","repos_url":"https://api.github.com/users/reactormonk/repos","events_url":"https://api.github.com/users/reactormonk/events{/privacy}","received_events_url":"https://api.github.com/users/reactormonk/received_events","type":"User","site_admin":false},"repo":{"id":1498104,"name":"nim","full_name":"reactormonk/nim","owner":{"login":"reactormonk","id":49185,"avatar_url":"https://avatars.githubusercontent.com/u/49185?v=3","gravatar_id":"","url":"https://api.github.com/users/reactormonk","html_url":"https://github.com/reactormonk","followers_url":"https://api.github.com/users/reactormonk/followers","following_url":"https://api.github.com/users/reactormonk/following{/other_user}","gists_url":"https://api.github.com/users/reactormonk/gists{/gist_id}","starred_url":"https://api.github.com/users/reactormonk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactormonk/subscriptions","organizations_url":"https://api.github.com/users/reactormonk/orgs","repos_url":"https://api.github.com/users/reactormonk/repos","events_url":"https://api.github.com/users/reactormonk/events{/privacy}","received_events_url":"https://api.github.com/users/reactormonk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/reactormonk/nim","description":"Nimrod is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nimrod's design focuses on the 3E: efficiency, expressiveness, elegance (in the order of priority). ","fork":true,"url":"https://api.github.com/repos/reactormonk/nim","forks_url":"https://api.github.com/repos/reactormonk/nim/forks","keys_url":"https://api.github.com/repos/reactormonk/nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactormonk/nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactormonk/nim/teams","hooks_url":"https://api.github.com/repos/reactormonk/nim/hooks","issue_events_url":"https://api.github.com/repos/reactormonk/nim/issues/events{/number}","events_url":"https://api.github.com/repos/reactormonk/nim/events","assignees_url":"https://api.github.com/repos/reactormonk/nim/assignees{/user}","branches_url":"https://api.github.com/repos/reactormonk/nim/branches{/branch}","tags_url":"https://api.github.com/repos/reactormonk/nim/tags","blobs_url":"https://api.github.com/repos/reactormonk/nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactormonk/nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactormonk/nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactormonk/nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactormonk/nim/statuses/{sha}","languages_url":"https://api.github.com/repos/reactormonk/nim/languages","stargazers_url":"https://api.github.com/repos/reactormonk/nim/stargazers","contributors_url":"https://api.github.com/repos/reactormonk/nim/contributors","subscribers_url":"https://api.github.com/repos/reactormonk/nim/subscribers","subscription_url":"https://api.github.com/repos/reactormonk/nim/subscription","commits_url":"https://api.github.com/repos/reactormonk/nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactormonk/nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactormonk/nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactormonk/nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactormonk/nim/contents/{+path}","compare_url":"https://api.github.com/repos/reactormonk/nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactormonk/nim/merges","archive_url":"https://api.github.com/repos/reactormonk/nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactormonk/nim/downloads","issues_url":"https://api.github.com/repos/reactormonk/nim/issues{/number}","pulls_url":"https://api.github.com/repos/reactormonk/nim/pulls{/number}","milestones_url":"https://api.github.com/repos/reactormonk/nim/milestones{/number}","notifications_url":"https://api.github.com/repos/reactormonk/nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactormonk/nim/labels{/name}","releases_url":"https://api.github.com/repos/reactormonk/nim/releases{/id}","created_at":"2011-03-18T21:34:04Z","updated_at":"2015-01-25T00:04:11Z","pushed_at":"2015-06-24T15:45:10Z","git_url":"git://github.com/reactormonk/nim.git","ssh_url":"git@github.com:reactormonk/nim.git","clone_url":"https://github.com/reactormonk/nim.git","svn_url":"https://github.com/reactormonk/nim","homepage":"http://force7.de/nimrod/","size":336690,"stargazers_count":1,"watchers_count":1,"language":"Nimrod","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"devel"}},"base":{"label":"nim-lang:devel","ref":"devel","sha":"5ee4b1bf2dc335e8830e2bae50268d39ba8e686b","user":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":842037,"name":"Nim","full_name":"nim-lang/Nim","owner":{"login":"nim-lang","id":603863,"avatar_url":"https://avatars.githubusercontent.com/u/603863?v=3","gravatar_id":"","url":"https://api.github.com/users/nim-lang","html_url":"https://github.com/nim-lang","followers_url":"https://api.github.com/users/nim-lang/followers","following_url":"https://api.github.com/users/nim-lang/following{/other_user}","gists_url":"https://api.github.com/users/nim-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/nim-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nim-lang/subscriptions","organizations_url":"https://api.github.com/users/nim-lang/orgs","repos_url":"https://api.github.com/users/nim-lang/repos","events_url":"https://api.github.com/users/nim-lang/events{/privacy}","received_events_url":"https://api.github.com/users/nim-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nim-lang/Nim","description":"Nim (formerly known as \"Nimrod\") is a compiled, garbage-collected systems programming language which has an excellent productivity/performance ratio. Nim's design focuses on efficiency, expressiveness, elegance (in the order of priority).","fork":false,"url":"https://api.github.com/repos/nim-lang/Nim","forks_url":"https://api.github.com/repos/nim-lang/Nim/forks","keys_url":"https://api.github.com/repos/nim-lang/Nim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nim-lang/Nim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nim-lang/Nim/teams","hooks_url":"https://api.github.com/repos/nim-lang/Nim/hooks","issue_events_url":"https://api.github.com/repos/nim-lang/Nim/issues/events{/number}","events_url":"https://api.github.com/repos/nim-lang/Nim/events","assignees_url":"https://api.github.com/repos/nim-lang/Nim/assignees{/user}","branches_url":"https://api.github.com/repos/nim-lang/Nim/branches{/branch}","tags_url":"https://api.github.com/repos/nim-lang/Nim/tags","blobs_url":"https://api.github.com/repos/nim-lang/Nim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nim-lang/Nim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nim-lang/Nim/git/refs{/sha}","trees_url":"https://api.github.com/repos/nim-lang/Nim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nim-lang/Nim/statuses/{sha}","languages_url":"https://api.github.com/repos/nim-lang/Nim/languages","stargazers_url":"https://api.github.com/repos/nim-lang/Nim/stargazers","contributors_url":"https://api.github.com/repos/nim-lang/Nim/contributors","subscribers_url":"https://api.github.com/repos/nim-lang/Nim/subscribers","subscription_url":"https://api.github.com/repos/nim-lang/Nim/subscription","commits_url":"https://api.github.com/repos/nim-lang/Nim/commits{/sha}","git_commits_url":"https://api.github.com/repos/nim-lang/Nim/git/commits{/sha}","comments_url":"https://api.github.com/repos/nim-lang/Nim/comments{/number}","issue_comment_url":"https://api.github.com/repos/nim-lang/Nim/issues/comments{/number}","contents_url":"https://api.github.com/repos/nim-lang/Nim/contents/{+path}","compare_url":"https://api.github.com/repos/nim-lang/Nim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nim-lang/Nim/merges","archive_url":"https://api.github.com/repos/nim-lang/Nim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nim-lang/Nim/downloads","issues_url":"https://api.github.com/repos/nim-lang/Nim/issues{/number}","pulls_url":"https://api.github.com/repos/nim-lang/Nim/pulls{/number}","milestones_url":"https://api.github.com/repos/nim-lang/Nim/milestones{/number}","notifications_url":"https://api.github.com/repos/nim-lang/Nim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nim-lang/Nim/labels{/name}","releases_url":"https://api.github.com/repos/nim-lang/Nim/releases{/id}","created_at":"2010-08-16T20:38:58Z","updated_at":"2015-06-24T01:43:39Z","pushed_at":"2015-06-24T20:17:12Z","git_url":"git://github.com/nim-lang/Nim.git","ssh_url":"git@github.com:nim-lang/Nim.git","clone_url":"https://github.com/nim-lang/Nim.git","svn_url":"https://github.com/nim-lang/Nim","homepage":"http://nim-lang.org/","size":352360,"stargazers_count":2149,"watchers_count":2149,"language":"Nimrod","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":282,"mirror_url":null,"open_issues_count":563,"forks":282,"open_issues":563,"watchers":2149,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2981"},"html":{"href":"https://github.com/nim-lang/Nim/pull/2981"},"issue":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/2981"},"comments":{"href":"https://api.github.com/repos/nim-lang/Nim/issues/2981/comments"},"review_comments":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2981/comments"},"review_comment":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nim-lang/Nim/pulls/2981/commits"},"statuses":{"href":"https://api.github.com/repos/nim-lang/Nim/statuses/5c8064d3be34ccdcc9f20aae108a4e41be61c986"}}}}