{"action":"closed","number":26,"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-demo/pulls/26","id":32764295,"html_url":"https://github.com/symfony/symfony-demo/pull/26","diff_url":"https://github.com/symfony/symfony-demo/pull/26.diff","patch_url":"https://github.com/symfony/symfony-demo/pull/26.patch","issue_url":"https://api.github.com/repos/symfony/symfony-demo/issues/26","number":26,"state":"closed","locked":false,"title":"Fix the escaping of the source code when displaying it","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"The source code of the controller cannot be considered as being safe HTML. It needs to be escaped.\r\n\r\nThis also moves the escaping of the template source code from the extension to the template rendering it, where it belongs (which also avoid using ``|raw``, which is flagged by Insight as being dangerous because it expects the escaping to happen elsewhere, see the first point about the controller source code)","created_at":"2015-04-07T13:38:14Z","updated_at":"2015-04-07T13:46:58Z","closed_at":"2015-04-07T13:46:58Z","merged_at":"2015-04-07T13:46:58Z","merge_commit_sha":"0cb90acacbd990eeab5b19dcd2c85f8346f91002","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/26/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/26/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-demo/issues/26/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-demo/statuses/2d0965ed2a41ae59bb0a839bc018b0f8af746af5","head":{"label":"stof:fix_escaping","ref":"fix_escaping","sha":"2d0965ed2a41ae59bb0a839bc018b0f8af746af5","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"repo":{"id":33544397,"name":"symfony-demo","full_name":"stof/symfony-demo","owner":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stof/symfony-demo","description":"","fork":true,"url":"https://api.github.com/repos/stof/symfony-demo","forks_url":"https://api.github.com/repos/stof/symfony-demo/forks","keys_url":"https://api.github.com/repos/stof/symfony-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stof/symfony-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stof/symfony-demo/teams","hooks_url":"https://api.github.com/repos/stof/symfony-demo/hooks","issue_events_url":"https://api.github.com/repos/stof/symfony-demo/issues/events{/number}","events_url":"https://api.github.com/repos/stof/symfony-demo/events","assignees_url":"https://api.github.com/repos/stof/symfony-demo/assignees{/user}","branches_url":"https://api.github.com/repos/stof/symfony-demo/branches{/branch}","tags_url":"https://api.github.com/repos/stof/symfony-demo/tags","blobs_url":"https://api.github.com/repos/stof/symfony-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stof/symfony-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stof/symfony-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/stof/symfony-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stof/symfony-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/stof/symfony-demo/languages","stargazers_url":"https://api.github.com/repos/stof/symfony-demo/stargazers","contributors_url":"https://api.github.com/repos/stof/symfony-demo/contributors","subscribers_url":"https://api.github.com/repos/stof/symfony-demo/subscribers","subscription_url":"https://api.github.com/repos/stof/symfony-demo/subscription","commits_url":"https://api.github.com/repos/stof/symfony-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/stof/symfony-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/stof/symfony-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/stof/symfony-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/stof/symfony-demo/contents/{+path}","compare_url":"https://api.github.com/repos/stof/symfony-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stof/symfony-demo/merges","archive_url":"https://api.github.com/repos/stof/symfony-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stof/symfony-demo/downloads","issues_url":"https://api.github.com/repos/stof/symfony-demo/issues{/number}","pulls_url":"https://api.github.com/repos/stof/symfony-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/stof/symfony-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/stof/symfony-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stof/symfony-demo/labels{/name}","releases_url":"https://api.github.com/repos/stof/symfony-demo/releases{/id}","created_at":"2015-04-07T13:21:54Z","updated_at":"2015-04-07T13:21:55Z","pushed_at":"2015-04-07T13:36:42Z","git_url":"git://github.com/stof/symfony-demo.git","ssh_url":"git@github.com:stof/symfony-demo.git","clone_url":"https://github.com/stof/symfony-demo.git","svn_url":"https://github.com/stof/symfony-demo","homepage":null,"size":1287,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"a4c538dda4221e7a018afd5807325a392ee7847a","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":32792088,"name":"symfony-demo","full_name":"symfony/symfony-demo","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-demo","description":"","fork":false,"url":"https://api.github.com/repos/symfony/symfony-demo","forks_url":"https://api.github.com/repos/symfony/symfony-demo/forks","keys_url":"https://api.github.com/repos/symfony/symfony-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-demo/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-demo/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-demo/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-demo/events","assignees_url":"https://api.github.com/repos/symfony/symfony-demo/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-demo/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-demo/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-demo/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-demo/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-demo/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-demo/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-demo/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-demo/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-demo/merges","archive_url":"https://api.github.com/repos/symfony/symfony-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-demo/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-demo/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-demo/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-demo/releases{/id}","created_at":"2015-03-24T10:37:08Z","updated_at":"2015-04-07T13:46:58Z","pushed_at":"2015-04-07T13:46:58Z","git_url":"git://github.com/symfony/symfony-demo.git","ssh_url":"git@github.com:symfony/symfony-demo.git","clone_url":"https://github.com/symfony/symfony-demo.git","svn_url":"https://github.com/symfony/symfony-demo","homepage":null,"size":1287,"stargazers_count":47,"watchers_count":47,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":5,"forks":9,"open_issues":5,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/26"},"html":{"href":"https://github.com/symfony/symfony-demo/pull/26"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-demo/issues/26"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-demo/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-demo/statuses/2d0965ed2a41ae59bb0a839bc018b0f8af746af5"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":3,"deletions":3,"changed_files":2}}