{"action":"created","issue":{"url":"https://api.github.com/repos/cinder/Cinder/issues/831","labels_url":"https://api.github.com/repos/cinder/Cinder/issues/831/labels{/name}","comments_url":"https://api.github.com/repos/cinder/Cinder/issues/831/comments","events_url":"https://api.github.com/repos/cinder/Cinder/issues/831/events","html_url":"https://github.com/cinder/Cinder/pull/831","id":69435668,"number":831,"title":"GlslProg/VboMesh Update","user":{"login":"ryanbartley","id":2651863,"avatar_url":"https://avatars.githubusercontent.com/u/2651863?v=3","gravatar_id":"","url":"https://api.github.com/users/ryanbartley","html_url":"https://github.com/ryanbartley","followers_url":"https://api.github.com/users/ryanbartley/followers","following_url":"https://api.github.com/users/ryanbartley/following{/other_user}","gists_url":"https://api.github.com/users/ryanbartley/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanbartley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanbartley/subscriptions","organizations_url":"https://api.github.com/users/ryanbartley/orgs","repos_url":"https://api.github.com/users/ryanbartley/repos","events_url":"https://api.github.com/users/ryanbartley/events{/privacy}","received_events_url":"https://api.github.com/users/ryanbartley/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cinder/Cinder/labels/glnext","name":"glnext","color":"881511"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cinder/Cinder/milestones/1","html_url":"https://github.com/cinder/Cinder/milestones/0.9.0","labels_url":"https://api.github.com/repos/cinder/Cinder/milestones/1/labels","id":874727,"number":1,"title":"0.9.0","description":"","creator":{"login":"richardeakin","id":5132127,"avatar_url":"https://avatars.githubusercontent.com/u/5132127?v=3","gravatar_id":"","url":"https://api.github.com/users/richardeakin","html_url":"https://github.com/richardeakin","followers_url":"https://api.github.com/users/richardeakin/followers","following_url":"https://api.github.com/users/richardeakin/following{/other_user}","gists_url":"https://api.github.com/users/richardeakin/gists{/gist_id}","starred_url":"https://api.github.com/users/richardeakin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardeakin/subscriptions","organizations_url":"https://api.github.com/users/richardeakin/orgs","repos_url":"https://api.github.com/users/richardeakin/repos","events_url":"https://api.github.com/users/richardeakin/events{/privacy}","received_events_url":"https://api.github.com/users/richardeakin/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":53,"state":"open","created_at":"2014-11-20T19:06:44Z","updated_at":"2015-04-29T04:18:49Z","due_on":null,"closed_at":null},"comments":56,"created_at":"2015-04-19T15:29:28Z","updated_at":"2015-04-29T19:35:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cinder/Cinder/pulls/831","html_url":"https://github.com/cinder/Cinder/pull/831","diff_url":"https://github.com/cinder/Cinder/pull/831.diff","patch_url":"https://github.com/cinder/Cinder/pull/831.patch"},"body":"This is a somewhat large update to the inner working of GlslProg and a smaller update to the inner workings of Batch and VboMesh. Much of the public facing interface hasn't changed at all.\r\n\r\nThe highlights in GlslProg are:\r\n- Clean up of caching variables. We now store Uniforms as a unified struct, same with attributes, uniform blocks, and transform feedback varyings.\r\n- Uniforms now have a CPU-side cache so as to not re-buffer uniform values that haven't changed.\r\n- We don't lazily initialize cache variables anymore. All of the above are cached during initialization so as to mitigate OpenGL get* operations.  \r\n- Using templated type checking for uniform functions.\r\n- Added multiple uniform type overloads.\r\n- Added public facing getters for all of the new structs of info. Added public facing const pointer find methods for the new structs. \r\n\r\nThe highlights in Batch and VboMesh are:\r\n- Batch - removed initVao logic to centralize Buffer/GlslProg Vao creation inside vboMesh, in buildVao function.\r\n- attribs that have a size greater than 4 now initialize a vao correctly. For instance, sending a mat4 up to the gpu. \r\n\r\nAlso changed:\r\n- Cloth Simulation sample updated. Found a bug with AMD GPUs that wasn't allowing two TFO's, which is in progress. However, I made the sample work on all platforms including AMD until by using gl::bindBufferBase until AMD fixes the problem.\r\n- Changed ConstantStrings.h/.cpp to ConstantConversions.h/.cpp to include other conversions such as size of conversions."},"comment":{"url":"https://api.github.com/repos/cinder/Cinder/issues/comments/97555048","html_url":"https://github.com/cinder/Cinder/pull/831#issuecomment-97555048","issue_url":"https://api.github.com/repos/cinder/Cinder/issues/831","id":97555048,"user":{"login":"BanTheRewind","id":954475,"avatar_url":"https://avatars.githubusercontent.com/u/954475?v=3","gravatar_id":"","url":"https://api.github.com/users/BanTheRewind","html_url":"https://github.com/BanTheRewind","followers_url":"https://api.github.com/users/BanTheRewind/followers","following_url":"https://api.github.com/users/BanTheRewind/following{/other_user}","gists_url":"https://api.github.com/users/BanTheRewind/gists{/gist_id}","starred_url":"https://api.github.com/users/BanTheRewind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BanTheRewind/subscriptions","organizations_url":"https://api.github.com/users/BanTheRewind/orgs","repos_url":"https://api.github.com/users/BanTheRewind/repos","events_url":"https://api.github.com/users/BanTheRewind/events{/privacy}","received_events_url":"https://api.github.com/users/BanTheRewind/received_events","type":"User","site_admin":false},"created_at":"2015-04-29T19:35:13Z","updated_at":"2015-04-29T19:35:13Z","body":"Woohoo! Oddly enough, I can sort of get the effect on iOS if I zoom way, way out, but I think that is related to depth precision and not actually a bug (something that would be optimized in a *real* project -- or the camera distance would be clamped).\n\nOn Wed, Apr 29, 2015 at 12:23 PM, Ryan Bartley <notifications@github.com>\nwrote:\n\n> Looks good from here. \n> ![screen shot 2015-04-29 at 3 21 50 pm](https://cloud.githubusercontent.com/assets/2651863/7399383/927219b6-ee83-11e4-8219-6d24e328dca5.png)\n> ![screen shot 2015-04-29 at 3 23 30 pm](https://cloud.githubusercontent.com/assets/2651863/7399385/95c22110-ee83-11e4-92d0-ccaaa5c0aedb.png)\n> @andrewfb do you want to try it on your mac?\n> ---\n> Reply to this email directly or view it on GitHub:\n> https://github.com/cinder/Cinder/pull/831#issuecomment-97550260"}}