{"action":"created","comment":{"url":"https://api.github.com/repos/arbisoft/edx-sga/pulls/comments/28231376","id":28231376,"diff_hunk":"@@ -534,22 +643,32 @@ def _file_storage_path(self, sha1, filename):\n         return path\n \n \n-def _get_sha1(file):\n-    BLOCK_SIZE = 2**10 * 8  # 8kb\n+def _get_sha1(_file):\n+    \"\"\"\n+    Get file sha1\n+    :param _file:\n+    \"\"\"\n+    block_size = 2**10 * 8  # 8kb","path":"edx_sga/sga.py","position":327,"original_position":327,"commit_id":"f4dc805a2f6a676822c3c2d89278593c1aace101","original_commit_id":"f4dc805a2f6a676822c3c2d89278593c1aace101","user":{"login":"afzaledx","id":9654006,"avatar_url":"https://avatars.githubusercontent.com/u/9654006?v=3","gravatar_id":"","url":"https://api.github.com/users/afzaledx","html_url":"https://github.com/afzaledx","followers_url":"https://api.github.com/users/afzaledx/followers","following_url":"https://api.github.com/users/afzaledx/following{/other_user}","gists_url":"https://api.github.com/users/afzaledx/gists{/gist_id}","starred_url":"https://api.github.com/users/afzaledx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afzaledx/subscriptions","organizations_url":"https://api.github.com/users/afzaledx/orgs","repos_url":"https://api.github.com/users/afzaledx/repos","events_url":"https://api.github.com/users/afzaledx/events{/privacy}","received_events_url":"https://api.github.com/users/afzaledx/received_events","type":"User","site_admin":false},"body":"And a chocolate for you about knowing these two. Come to me to learn one more trick.","created_at":"2015-04-13T11:44:11Z","updated_at":"2015-04-13T11:44:11Z","html_url":"https://github.com/arbisoft/edx-sga/pull/4#discussion_r28231376","pull_request_url":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/arbisoft/edx-sga/pulls/comments/28231376"},"html":{"href":"https://github.com/arbisoft/edx-sga/pull/4#discussion_r28231376"},"pull_request":{"href":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4","id":33149668,"html_url":"https://github.com/arbisoft/edx-sga/pull/4","diff_url":"https://github.com/arbisoft/edx-sga/pull/4.diff","patch_url":"https://github.com/arbisoft/edx-sga/pull/4.patch","issue_url":"https://api.github.com/repos/arbisoft/edx-sga/issues/4","number":4,"state":"open","locked":false,"title":"Fix pylint issues","user":{"login":"amir-qayyum-arbisoft","id":10431250,"avatar_url":"https://avatars.githubusercontent.com/u/10431250?v=3","gravatar_id":"","url":"https://api.github.com/users/amir-qayyum-arbisoft","html_url":"https://github.com/amir-qayyum-arbisoft","followers_url":"https://api.github.com/users/amir-qayyum-arbisoft/followers","following_url":"https://api.github.com/users/amir-qayyum-arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/amir-qayyum-arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/amir-qayyum-arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amir-qayyum-arbisoft/subscriptions","organizations_url":"https://api.github.com/users/amir-qayyum-arbisoft/orgs","repos_url":"https://api.github.com/users/amir-qayyum-arbisoft/repos","events_url":"https://api.github.com/users/amir-qayyum-arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/amir-qayyum-arbisoft/received_events","type":"User","site_admin":false},"body":"**Problem statement**\r\n\r\nThere are several pylint violations creeping in here. We should try and resolve them. Helpful command to show them in devstack: PYTHONPATH=lms:lms/djangoapps:lms/lib:common/djangoapps:common/lib pylint --msg-template=\"{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}\" edx_sga | tee /edx/app/edxapp/edx-platform/reports/lms/pylint.report\r\n\r\n**What I did**\r\nFixed all possible pylint warnings and errosr. Their are  still some warnings but these warnings are seem to be in valid  for example frame work related issue i.e request param is not used, fragment param is not use , xyx has no attribute id etc","created_at":"2015-04-13T09:58:11Z","updated_at":"2015-04-13T11:44:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e417f5ff2b706a5870ea8e57b5175d3cf09c7f1f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4/commits","review_comments_url":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4/comments","review_comment_url":"https://api.github.com/repos/arbisoft/edx-sga/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arbisoft/edx-sga/issues/4/comments","statuses_url":"https://api.github.com/repos/arbisoft/edx-sga/statuses/f4dc805a2f6a676822c3c2d89278593c1aace101","head":{"label":"arbisoft:fix_pylint_issues","ref":"fix_pylint_issues","sha":"f4dc805a2f6a676822c3c2d89278593c1aace101","user":{"login":"arbisoft","id":9364531,"avatar_url":"https://avatars.githubusercontent.com/u/9364531?v=3","gravatar_id":"","url":"https://api.github.com/users/arbisoft","html_url":"https://github.com/arbisoft","followers_url":"https://api.github.com/users/arbisoft/followers","following_url":"https://api.github.com/users/arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbisoft/subscriptions","organizations_url":"https://api.github.com/users/arbisoft/orgs","repos_url":"https://api.github.com/users/arbisoft/repos","events_url":"https://api.github.com/users/arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/arbisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":31770403,"name":"edx-sga","full_name":"arbisoft/edx-sga","owner":{"login":"arbisoft","id":9364531,"avatar_url":"https://avatars.githubusercontent.com/u/9364531?v=3","gravatar_id":"","url":"https://api.github.com/users/arbisoft","html_url":"https://github.com/arbisoft","followers_url":"https://api.github.com/users/arbisoft/followers","following_url":"https://api.github.com/users/arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbisoft/subscriptions","organizations_url":"https://api.github.com/users/arbisoft/orgs","repos_url":"https://api.github.com/users/arbisoft/repos","events_url":"https://api.github.com/users/arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/arbisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arbisoft/edx-sga","description":"Staff Graded Assignment XBlock for the edX platform","fork":true,"url":"https://api.github.com/repos/arbisoft/edx-sga","forks_url":"https://api.github.com/repos/arbisoft/edx-sga/forks","keys_url":"https://api.github.com/repos/arbisoft/edx-sga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbisoft/edx-sga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbisoft/edx-sga/teams","hooks_url":"https://api.github.com/repos/arbisoft/edx-sga/hooks","issue_events_url":"https://api.github.com/repos/arbisoft/edx-sga/issues/events{/number}","events_url":"https://api.github.com/repos/arbisoft/edx-sga/events","assignees_url":"https://api.github.com/repos/arbisoft/edx-sga/assignees{/user}","branches_url":"https://api.github.com/repos/arbisoft/edx-sga/branches{/branch}","tags_url":"https://api.github.com/repos/arbisoft/edx-sga/tags","blobs_url":"https://api.github.com/repos/arbisoft/edx-sga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbisoft/edx-sga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbisoft/edx-sga/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbisoft/edx-sga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbisoft/edx-sga/statuses/{sha}","languages_url":"https://api.github.com/repos/arbisoft/edx-sga/languages","stargazers_url":"https://api.github.com/repos/arbisoft/edx-sga/stargazers","contributors_url":"https://api.github.com/repos/arbisoft/edx-sga/contributors","subscribers_url":"https://api.github.com/repos/arbisoft/edx-sga/subscribers","subscription_url":"https://api.github.com/repos/arbisoft/edx-sga/subscription","commits_url":"https://api.github.com/repos/arbisoft/edx-sga/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbisoft/edx-sga/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbisoft/edx-sga/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbisoft/edx-sga/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbisoft/edx-sga/contents/{+path}","compare_url":"https://api.github.com/repos/arbisoft/edx-sga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbisoft/edx-sga/merges","archive_url":"https://api.github.com/repos/arbisoft/edx-sga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbisoft/edx-sga/downloads","issues_url":"https://api.github.com/repos/arbisoft/edx-sga/issues{/number}","pulls_url":"https://api.github.com/repos/arbisoft/edx-sga/pulls{/number}","milestones_url":"https://api.github.com/repos/arbisoft/edx-sga/milestones{/number}","notifications_url":"https://api.github.com/repos/arbisoft/edx-sga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbisoft/edx-sga/labels{/name}","releases_url":"https://api.github.com/repos/arbisoft/edx-sga/releases{/id}","created_at":"2015-03-06T13:27:52Z","updated_at":"2015-04-10T11:42:47Z","pushed_at":"2015-04-13T10:25:59Z","git_url":"git://github.com/arbisoft/edx-sga.git","ssh_url":"git@github.com:arbisoft/edx-sga.git","clone_url":"https://github.com/arbisoft/edx-sga.git","svn_url":"https://github.com/arbisoft/edx-sga","homepage":null,"size":2836,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"arbisoft:master","ref":"master","sha":"9c10400c0486fa387f988c7d07dfe37122809c3d","user":{"login":"arbisoft","id":9364531,"avatar_url":"https://avatars.githubusercontent.com/u/9364531?v=3","gravatar_id":"","url":"https://api.github.com/users/arbisoft","html_url":"https://github.com/arbisoft","followers_url":"https://api.github.com/users/arbisoft/followers","following_url":"https://api.github.com/users/arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbisoft/subscriptions","organizations_url":"https://api.github.com/users/arbisoft/orgs","repos_url":"https://api.github.com/users/arbisoft/repos","events_url":"https://api.github.com/users/arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/arbisoft/received_events","type":"Organization","site_admin":false},"repo":{"id":31770403,"name":"edx-sga","full_name":"arbisoft/edx-sga","owner":{"login":"arbisoft","id":9364531,"avatar_url":"https://avatars.githubusercontent.com/u/9364531?v=3","gravatar_id":"","url":"https://api.github.com/users/arbisoft","html_url":"https://github.com/arbisoft","followers_url":"https://api.github.com/users/arbisoft/followers","following_url":"https://api.github.com/users/arbisoft/following{/other_user}","gists_url":"https://api.github.com/users/arbisoft/gists{/gist_id}","starred_url":"https://api.github.com/users/arbisoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arbisoft/subscriptions","organizations_url":"https://api.github.com/users/arbisoft/orgs","repos_url":"https://api.github.com/users/arbisoft/repos","events_url":"https://api.github.com/users/arbisoft/events{/privacy}","received_events_url":"https://api.github.com/users/arbisoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/arbisoft/edx-sga","description":"Staff Graded Assignment XBlock for the edX platform","fork":true,"url":"https://api.github.com/repos/arbisoft/edx-sga","forks_url":"https://api.github.com/repos/arbisoft/edx-sga/forks","keys_url":"https://api.github.com/repos/arbisoft/edx-sga/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arbisoft/edx-sga/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arbisoft/edx-sga/teams","hooks_url":"https://api.github.com/repos/arbisoft/edx-sga/hooks","issue_events_url":"https://api.github.com/repos/arbisoft/edx-sga/issues/events{/number}","events_url":"https://api.github.com/repos/arbisoft/edx-sga/events","assignees_url":"https://api.github.com/repos/arbisoft/edx-sga/assignees{/user}","branches_url":"https://api.github.com/repos/arbisoft/edx-sga/branches{/branch}","tags_url":"https://api.github.com/repos/arbisoft/edx-sga/tags","blobs_url":"https://api.github.com/repos/arbisoft/edx-sga/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arbisoft/edx-sga/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arbisoft/edx-sga/git/refs{/sha}","trees_url":"https://api.github.com/repos/arbisoft/edx-sga/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arbisoft/edx-sga/statuses/{sha}","languages_url":"https://api.github.com/repos/arbisoft/edx-sga/languages","stargazers_url":"https://api.github.com/repos/arbisoft/edx-sga/stargazers","contributors_url":"https://api.github.com/repos/arbisoft/edx-sga/contributors","subscribers_url":"https://api.github.com/repos/arbisoft/edx-sga/subscribers","subscription_url":"https://api.github.com/repos/arbisoft/edx-sga/subscription","commits_url":"https://api.github.com/repos/arbisoft/edx-sga/commits{/sha}","git_commits_url":"https://api.github.com/repos/arbisoft/edx-sga/git/commits{/sha}","comments_url":"https://api.github.com/repos/arbisoft/edx-sga/comments{/number}","issue_comment_url":"https://api.github.com/repos/arbisoft/edx-sga/issues/comments{/number}","contents_url":"https://api.github.com/repos/arbisoft/edx-sga/contents/{+path}","compare_url":"https://api.github.com/repos/arbisoft/edx-sga/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arbisoft/edx-sga/merges","archive_url":"https://api.github.com/repos/arbisoft/edx-sga/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arbisoft/edx-sga/downloads","issues_url":"https://api.github.com/repos/arbisoft/edx-sga/issues{/number}","pulls_url":"https://api.github.com/repos/arbisoft/edx-sga/pulls{/number}","milestones_url":"https://api.github.com/repos/arbisoft/edx-sga/milestones{/number}","notifications_url":"https://api.github.com/repos/arbisoft/edx-sga/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arbisoft/edx-sga/labels{/name}","releases_url":"https://api.github.com/repos/arbisoft/edx-sga/releases{/id}","created_at":"2015-03-06T13:27:52Z","updated_at":"2015-04-10T11:42:47Z","pushed_at":"2015-04-13T10:25:59Z","git_url":"git://github.com/arbisoft/edx-sga.git","ssh_url":"git@github.com:arbisoft/edx-sga.git","clone_url":"https://github.com/arbisoft/edx-sga.git","svn_url":"https://github.com/arbisoft/edx-sga","homepage":null,"size":2836,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4"},"html":{"href":"https://github.com/arbisoft/edx-sga/pull/4"},"issue":{"href":"https://api.github.com/repos/arbisoft/edx-sga/issues/4"},"comments":{"href":"https://api.github.com/repos/arbisoft/edx-sga/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/arbisoft/edx-sga/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arbisoft/edx-sga/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/arbisoft/edx-sga/statuses/f4dc805a2f6a676822c3c2d89278593c1aace101"}}}}