{"action":"created","comment":{"url":"https://api.github.com/repos/ericmj/postgrex/pulls/comments/27989189","id":27989189,"diff_hunk":"@@ -162,10 +162,15 @@ defmodule Postgrex.Extensions.Binary do\n       bin = for digit <- digits, into: \"\", do: <<digit :: uint16>>\n       ndigits = div(byte_size(bin), 2)\n \n-      [<<ndigits :: int16, weight :: int16, sign :: uint16, scale :: int16>>, bin]","path":"lib/postgrex/extensions/binary.ex","position":13,"original_position":13,"commit_id":"4100615e66673b8e2e87f34ab9fecc074b90d6fe","original_commit_id":"4100615e66673b8e2e87f34ab9fecc074b90d6fe","user":{"login":"bernardoamc","id":428984,"avatar_url":"https://avatars.githubusercontent.com/u/428984?v=3","gravatar_id":"","url":"https://api.github.com/users/bernardoamc","html_url":"https://github.com/bernardoamc","followers_url":"https://api.github.com/users/bernardoamc/followers","following_url":"https://api.github.com/users/bernardoamc/following{/other_user}","gists_url":"https://api.github.com/users/bernardoamc/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoamc/subscriptions","organizations_url":"https://api.github.com/users/bernardoamc/orgs","repos_url":"https://api.github.com/users/bernardoamc/repos","events_url":"https://api.github.com/users/bernardoamc/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoamc/received_events","type":"User","site_admin":false},"body":"Just to keep the same style as [here](https://github.com/ericmj/postgrex/blob/master/lib/postgrex/extensions/binary.ex#L138), it was not really necessary. :)","created_at":"2015-04-08T16:53:53Z","updated_at":"2015-04-08T16:53:53Z","html_url":"https://github.com/ericmj/postgrex/pull/67#discussion_r27989189","pull_request_url":"https://api.github.com/repos/ericmj/postgrex/pulls/67","_links":{"self":{"href":"https://api.github.com/repos/ericmj/postgrex/pulls/comments/27989189"},"html":{"href":"https://github.com/ericmj/postgrex/pull/67#discussion_r27989189"},"pull_request":{"href":"https://api.github.com/repos/ericmj/postgrex/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/ericmj/postgrex/pulls/67","id":32870939,"html_url":"https://github.com/ericmj/postgrex/pull/67","diff_url":"https://github.com/ericmj/postgrex/pull/67.diff","patch_url":"https://github.com/ericmj/postgrex/pull/67.patch","issue_url":"https://api.github.com/repos/ericmj/postgrex/issues/67","number":67,"state":"open","locked":false,"title":"Fix numeric encoding for fractional numbers with less digits than numeric_base.","user":{"login":"bernardoamc","id":428984,"avatar_url":"https://avatars.githubusercontent.com/u/428984?v=3","gravatar_id":"","url":"https://api.github.com/users/bernardoamc","html_url":"https://github.com/bernardoamc","followers_url":"https://api.github.com/users/bernardoamc/followers","following_url":"https://api.github.com/users/bernardoamc/following{/other_user}","gists_url":"https://api.github.com/users/bernardoamc/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoamc/subscriptions","organizations_url":"https://api.github.com/users/bernardoamc/orgs","repos_url":"https://api.github.com/users/bernardoamc/repos","events_url":"https://api.github.com/users/bernardoamc/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoamc/received_events","type":"User","site_admin":false},"body":"Referencing this [PR](https://github.com/ericmj/postgrex/pull/66) and [elixir-lang/ecto#547](https://github.com/elixir-lang/ecto/issues/547) issue.\r\n\r\nWe've found out that the problem was related with the float's padding, but we're not sure it is the proper fix. What do you think?","created_at":"2015-04-08T15:21:33Z","updated_at":"2015-04-08T16:53:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e855ca4a28042183eebf3c3df51f0c219894b92f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ericmj/postgrex/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ericmj/postgrex/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ericmj/postgrex/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ericmj/postgrex/issues/67/comments","statuses_url":"https://api.github.com/repos/ericmj/postgrex/statuses/4100615e66673b8e2e87f34ab9fecc074b90d6fe","head":{"label":"bernardoamc:bc-fix-numeric-encoding","ref":"bc-fix-numeric-encoding","sha":"4100615e66673b8e2e87f34ab9fecc074b90d6fe","user":{"login":"bernardoamc","id":428984,"avatar_url":"https://avatars.githubusercontent.com/u/428984?v=3","gravatar_id":"","url":"https://api.github.com/users/bernardoamc","html_url":"https://github.com/bernardoamc","followers_url":"https://api.github.com/users/bernardoamc/followers","following_url":"https://api.github.com/users/bernardoamc/following{/other_user}","gists_url":"https://api.github.com/users/bernardoamc/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoamc/subscriptions","organizations_url":"https://api.github.com/users/bernardoamc/orgs","repos_url":"https://api.github.com/users/bernardoamc/repos","events_url":"https://api.github.com/users/bernardoamc/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoamc/received_events","type":"User","site_admin":false},"repo":{"id":30778242,"name":"postgrex","full_name":"bernardoamc/postgrex","owner":{"login":"bernardoamc","id":428984,"avatar_url":"https://avatars.githubusercontent.com/u/428984?v=3","gravatar_id":"","url":"https://api.github.com/users/bernardoamc","html_url":"https://github.com/bernardoamc","followers_url":"https://api.github.com/users/bernardoamc/followers","following_url":"https://api.github.com/users/bernardoamc/following{/other_user}","gists_url":"https://api.github.com/users/bernardoamc/gists{/gist_id}","starred_url":"https://api.github.com/users/bernardoamc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernardoamc/subscriptions","organizations_url":"https://api.github.com/users/bernardoamc/orgs","repos_url":"https://api.github.com/users/bernardoamc/repos","events_url":"https://api.github.com/users/bernardoamc/events{/privacy}","received_events_url":"https://api.github.com/users/bernardoamc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bernardoamc/postgrex","description":"PostgreSQL driver for Elixir","fork":true,"url":"https://api.github.com/repos/bernardoamc/postgrex","forks_url":"https://api.github.com/repos/bernardoamc/postgrex/forks","keys_url":"https://api.github.com/repos/bernardoamc/postgrex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bernardoamc/postgrex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bernardoamc/postgrex/teams","hooks_url":"https://api.github.com/repos/bernardoamc/postgrex/hooks","issue_events_url":"https://api.github.com/repos/bernardoamc/postgrex/issues/events{/number}","events_url":"https://api.github.com/repos/bernardoamc/postgrex/events","assignees_url":"https://api.github.com/repos/bernardoamc/postgrex/assignees{/user}","branches_url":"https://api.github.com/repos/bernardoamc/postgrex/branches{/branch}","tags_url":"https://api.github.com/repos/bernardoamc/postgrex/tags","blobs_url":"https://api.github.com/repos/bernardoamc/postgrex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bernardoamc/postgrex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bernardoamc/postgrex/git/refs{/sha}","trees_url":"https://api.github.com/repos/bernardoamc/postgrex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bernardoamc/postgrex/statuses/{sha}","languages_url":"https://api.github.com/repos/bernardoamc/postgrex/languages","stargazers_url":"https://api.github.com/repos/bernardoamc/postgrex/stargazers","contributors_url":"https://api.github.com/repos/bernardoamc/postgrex/contributors","subscribers_url":"https://api.github.com/repos/bernardoamc/postgrex/subscribers","subscription_url":"https://api.github.com/repos/bernardoamc/postgrex/subscription","commits_url":"https://api.github.com/repos/bernardoamc/postgrex/commits{/sha}","git_commits_url":"https://api.github.com/repos/bernardoamc/postgrex/git/commits{/sha}","comments_url":"https://api.github.com/repos/bernardoamc/postgrex/comments{/number}","issue_comment_url":"https://api.github.com/repos/bernardoamc/postgrex/issues/comments{/number}","contents_url":"https://api.github.com/repos/bernardoamc/postgrex/contents/{+path}","compare_url":"https://api.github.com/repos/bernardoamc/postgrex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bernardoamc/postgrex/merges","archive_url":"https://api.github.com/repos/bernardoamc/postgrex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bernardoamc/postgrex/downloads","issues_url":"https://api.github.com/repos/bernardoamc/postgrex/issues{/number}","pulls_url":"https://api.github.com/repos/bernardoamc/postgrex/pulls{/number}","milestones_url":"https://api.github.com/repos/bernardoamc/postgrex/milestones{/number}","notifications_url":"https://api.github.com/repos/bernardoamc/postgrex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bernardoamc/postgrex/labels{/name}","releases_url":"https://api.github.com/repos/bernardoamc/postgrex/releases{/id}","created_at":"2015-02-13T22:04:07Z","updated_at":"2015-04-07T23:34:33Z","pushed_at":"2015-04-08T15:14:25Z","git_url":"git://github.com/bernardoamc/postgrex.git","ssh_url":"git@github.com:bernardoamc/postgrex.git","clone_url":"https://github.com/bernardoamc/postgrex.git","svn_url":"https://github.com/bernardoamc/postgrex","homepage":"http://hexdocs.pm/postgrex/","size":1886,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ericmj:master","ref":"master","sha":"8e84a6c3fccfab4a6652d1b7735c7c311761fa5a","user":{"login":"ericmj","id":316890,"avatar_url":"https://avatars.githubusercontent.com/u/316890?v=3","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"repo":{"id":12682522,"name":"postgrex","full_name":"ericmj/postgrex","owner":{"login":"ericmj","id":316890,"avatar_url":"https://avatars.githubusercontent.com/u/316890?v=3","gravatar_id":"","url":"https://api.github.com/users/ericmj","html_url":"https://github.com/ericmj","followers_url":"https://api.github.com/users/ericmj/followers","following_url":"https://api.github.com/users/ericmj/following{/other_user}","gists_url":"https://api.github.com/users/ericmj/gists{/gist_id}","starred_url":"https://api.github.com/users/ericmj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericmj/subscriptions","organizations_url":"https://api.github.com/users/ericmj/orgs","repos_url":"https://api.github.com/users/ericmj/repos","events_url":"https://api.github.com/users/ericmj/events{/privacy}","received_events_url":"https://api.github.com/users/ericmj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericmj/postgrex","description":"PostgreSQL driver for Elixir","fork":false,"url":"https://api.github.com/repos/ericmj/postgrex","forks_url":"https://api.github.com/repos/ericmj/postgrex/forks","keys_url":"https://api.github.com/repos/ericmj/postgrex/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericmj/postgrex/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericmj/postgrex/teams","hooks_url":"https://api.github.com/repos/ericmj/postgrex/hooks","issue_events_url":"https://api.github.com/repos/ericmj/postgrex/issues/events{/number}","events_url":"https://api.github.com/repos/ericmj/postgrex/events","assignees_url":"https://api.github.com/repos/ericmj/postgrex/assignees{/user}","branches_url":"https://api.github.com/repos/ericmj/postgrex/branches{/branch}","tags_url":"https://api.github.com/repos/ericmj/postgrex/tags","blobs_url":"https://api.github.com/repos/ericmj/postgrex/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericmj/postgrex/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericmj/postgrex/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericmj/postgrex/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericmj/postgrex/statuses/{sha}","languages_url":"https://api.github.com/repos/ericmj/postgrex/languages","stargazers_url":"https://api.github.com/repos/ericmj/postgrex/stargazers","contributors_url":"https://api.github.com/repos/ericmj/postgrex/contributors","subscribers_url":"https://api.github.com/repos/ericmj/postgrex/subscribers","subscription_url":"https://api.github.com/repos/ericmj/postgrex/subscription","commits_url":"https://api.github.com/repos/ericmj/postgrex/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericmj/postgrex/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericmj/postgrex/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericmj/postgrex/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericmj/postgrex/contents/{+path}","compare_url":"https://api.github.com/repos/ericmj/postgrex/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericmj/postgrex/merges","archive_url":"https://api.github.com/repos/ericmj/postgrex/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericmj/postgrex/downloads","issues_url":"https://api.github.com/repos/ericmj/postgrex/issues{/number}","pulls_url":"https://api.github.com/repos/ericmj/postgrex/pulls{/number}","milestones_url":"https://api.github.com/repos/ericmj/postgrex/milestones{/number}","notifications_url":"https://api.github.com/repos/ericmj/postgrex/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericmj/postgrex/labels{/name}","releases_url":"https://api.github.com/repos/ericmj/postgrex/releases{/id}","created_at":"2013-09-08T15:10:47Z","updated_at":"2015-04-05T02:46:11Z","pushed_at":"2015-04-08T15:21:33Z","git_url":"git://github.com/ericmj/postgrex.git","ssh_url":"git@github.com:ericmj/postgrex.git","clone_url":"https://github.com/ericmj/postgrex.git","svn_url":"https://github.com/ericmj/postgrex","homepage":"http://hexdocs.pm/postgrex/","size":2027,"stargazers_count":118,"watchers_count":118,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":6,"forks":36,"open_issues":6,"watchers":118,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ericmj/postgrex/pulls/67"},"html":{"href":"https://github.com/ericmj/postgrex/pull/67"},"issue":{"href":"https://api.github.com/repos/ericmj/postgrex/issues/67"},"comments":{"href":"https://api.github.com/repos/ericmj/postgrex/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ericmj/postgrex/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ericmj/postgrex/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ericmj/postgrex/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ericmj/postgrex/statuses/4100615e66673b8e2e87f34ab9fecc074b90d6fe"}}}}