{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/30699493","id":30699493,"diff_hunk":"@@ -1028,11 +1017,20 @@ u32 Renderer::AccessEFB(EFBAccessType type, u32 x, u32 y, u32 poke_data)\n \t\t\tu32 yRect = y % EFB_CACHE_RECT_SIZE;\n \t\t\tu32 z = s_efbCache[0][cacheRectIdx][yRect * EFB_CACHE_RECT_SIZE + xRect];\n \n-\t\t\t// if Z is in 16 bit format you must return a 16 bit integer\n+\t\t\t// Scale the 32-bit value returned by glReadPixels to a 24-bit\n+\t\t\t// value (GC uses a 24-bit Z-buffer).\n+\t\t\tfloat val = z / float(0xFFFFFFFF);","path":"Source/Core/VideoBackends/OGL/Render.cpp","position":49,"original_position":49,"commit_id":"05f42f94a0442fef64c994cb78f4d621bb1fc7ff","original_commit_id":"05f42f94a0442fef64c994cb78f4d621bb1fc7ff","user":{"login":"degasus","id":2787141,"avatar_url":"https://avatars.githubusercontent.com/u/2787141?v=3","gravatar_id":"","url":"https://api.github.com/users/degasus","html_url":"https://github.com/degasus","followers_url":"https://api.github.com/users/degasus/followers","following_url":"https://api.github.com/users/degasus/following{/other_user}","gists_url":"https://api.github.com/users/degasus/gists{/gist_id}","starred_url":"https://api.github.com/users/degasus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/degasus/subscriptions","organizations_url":"https://api.github.com/users/degasus/orgs","repos_url":"https://api.github.com/users/degasus/repos","events_url":"https://api.github.com/users/degasus/events{/privacy}","received_events_url":"https://api.github.com/users/degasus/received_events","type":"User","site_admin":false},"body":"was 0x1000000 off by one?","created_at":"2015-05-20T13:15:38Z","updated_at":"2015-05-20T13:15:38Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/2425#discussion_r30699493","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/30699493"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2425#discussion_r30699493"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425","id":35826253,"html_url":"https://github.com/dolphin-emu/dolphin/pull/2425","diff_url":"https://github.com/dolphin-emu/dolphin/pull/2425.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/2425.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2425","number":2425,"state":"open","locked":false,"title":"Revert \"OGL: Switch depth buffers to GL_DEPTH_COMPONENT32F format.\"","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"body":"This is an attempt to address the depth precision issue without a floating point buffer.\r\n\r\nNot sure yet if it fixes anything, I want to see what FIFOCI says.","created_at":"2015-05-20T12:28:31Z","updated_at":"2015-05-20T13:15:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b72ab2d0d93066918aab6a0df45136f0c2e30620","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2425/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/05f42f94a0442fef64c994cb78f4d621bb1fc7ff","head":{"label":"Armada651:ogl-integer","ref":"ogl-integer","sha":"05f42f94a0442fef64c994cb78f4d621bb1fc7ff","user":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"repo":{"id":16296067,"name":"dolphin","full_name":"Armada651/dolphin","owner":{"login":"Armada651","id":2028870,"avatar_url":"https://avatars.githubusercontent.com/u/2028870?v=3","gravatar_id":"","url":"https://api.github.com/users/Armada651","html_url":"https://github.com/Armada651","followers_url":"https://api.github.com/users/Armada651/followers","following_url":"https://api.github.com/users/Armada651/following{/other_user}","gists_url":"https://api.github.com/users/Armada651/gists{/gist_id}","starred_url":"https://api.github.com/users/Armada651/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Armada651/subscriptions","organizations_url":"https://api.github.com/users/Armada651/orgs","repos_url":"https://api.github.com/users/Armada651/repos","events_url":"https://api.github.com/users/Armada651/events{/privacy}","received_events_url":"https://api.github.com/users/Armada651/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Armada651/dolphin","description":"Dolphin is a GameCube/Wii emulator, allowing you to play games for these two platforms on PC, with improvements.","fork":true,"url":"https://api.github.com/repos/Armada651/dolphin","forks_url":"https://api.github.com/repos/Armada651/dolphin/forks","keys_url":"https://api.github.com/repos/Armada651/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Armada651/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Armada651/dolphin/teams","hooks_url":"https://api.github.com/repos/Armada651/dolphin/hooks","issue_events_url":"https://api.github.com/repos/Armada651/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/Armada651/dolphin/events","assignees_url":"https://api.github.com/repos/Armada651/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/Armada651/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/Armada651/dolphin/tags","blobs_url":"https://api.github.com/repos/Armada651/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Armada651/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Armada651/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/Armada651/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Armada651/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/Armada651/dolphin/languages","stargazers_url":"https://api.github.com/repos/Armada651/dolphin/stargazers","contributors_url":"https://api.github.com/repos/Armada651/dolphin/contributors","subscribers_url":"https://api.github.com/repos/Armada651/dolphin/subscribers","subscription_url":"https://api.github.com/repos/Armada651/dolphin/subscription","commits_url":"https://api.github.com/repos/Armada651/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/Armada651/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/Armada651/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/Armada651/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/Armada651/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/Armada651/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Armada651/dolphin/merges","archive_url":"https://api.github.com/repos/Armada651/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Armada651/dolphin/downloads","issues_url":"https://api.github.com/repos/Armada651/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/Armada651/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/Armada651/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/Armada651/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Armada651/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/Armada651/dolphin/releases{/id}","created_at":"2014-01-27T23:04:02Z","updated_at":"2015-05-14T15:03:30Z","pushed_at":"2015-05-20T12:53:39Z","git_url":"git://github.com/Armada651/dolphin.git","ssh_url":"git@github.com:Armada651/dolphin.git","clone_url":"https://github.com/Armada651/dolphin.git","svn_url":"https://github.com/Armada651/dolphin","homepage":null,"size":218824,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"7b322df5300c17b2e570d02cf9b149bdba935a92","user":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"avatar_url":"https://avatars.githubusercontent.com/u/5050316?v=3","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","created_at":"2013-07-22T09:07:57Z","updated_at":"2015-05-20T08:57:53Z","pushed_at":"2015-05-20T12:53:40Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":295183,"stargazers_count":1375,"watchers_count":1375,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":414,"mirror_url":null,"open_issues_count":70,"forks":414,"open_issues":70,"watchers":1375,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/2425"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2425"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/2425/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/2425/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/05f42f94a0442fef64c994cb78f4d621bb1fc7ff"}}}}