{"comment":{"url":"https://api.github.com/repos/jenswi-linaro/optee_os/comments/10319025","html_url":"https://github.com/jenswi-linaro/optee_os/commit/5fe41b221578f403bc87663b995b83861c3eab42#commitcomment-10319025","id":10319025,"user":{"login":"jenswi-linaro","id":6150306,"avatar_url":"https://avatars.githubusercontent.com/u/6150306?v=3","gravatar_id":"","url":"https://api.github.com/users/jenswi-linaro","html_url":"https://github.com/jenswi-linaro","followers_url":"https://api.github.com/users/jenswi-linaro/followers","following_url":"https://api.github.com/users/jenswi-linaro/following{/other_user}","gists_url":"https://api.github.com/users/jenswi-linaro/gists{/gist_id}","starred_url":"https://api.github.com/users/jenswi-linaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenswi-linaro/subscriptions","organizations_url":"https://api.github.com/users/jenswi-linaro/orgs","repos_url":"https://api.github.com/users/jenswi-linaro/repos","events_url":"https://api.github.com/users/jenswi-linaro/events{/privacy}","received_events_url":"https://api.github.com/users/jenswi-linaro/received_events","type":"User","site_admin":false},"position":1,"line":1,"path":"core/arch/arm32/plat-sunxi/platform_flags.mk","commit_id":"5fe41b221578f403bc87663b995b83861c3eab42","created_at":"2015-03-20T15:54:25Z","updated_at":"2015-03-20T15:54:25Z","body":"Sure, go ahead.\r\n\r\nNow I know why we need the `-DARM32=1`. If we're using CFG_ARM32_core instead it will look a bit strange in the code, but another problem is that if something under /lib needs this we would need to write something like:\r\n```\r\n#if defined(CFG_ARM32_core) || defined(CFG_ARM32_user_ta)\r\n...\r\n#endif\r\n```\r\nwhich is even worse.\r\n\r\nWhat if we move the `-DARM32=1` into /core/core.mk and /ta/ta.mk instead? Or is it preferable to not use `-DARM32=1` at all?"}}