{"action":"created","issue":{"url":"https://api.github.com/repos/numenta/nupic/issues/1872","labels_url":"https://api.github.com/repos/numenta/nupic/issues/1872/labels{/name}","comments_url":"https://api.github.com/repos/numenta/nupic/issues/1872/comments","events_url":"https://api.github.com/repos/numenta/nupic/issues/1872/events","html_url":"https://github.com/numenta/nupic/pull/1872","id":58830501,"number":1872,"title":"Remove obsolete implementations of SP","user":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/numenta/nupic/labels/algorithms","name":"algorithms","color":"207de5"},{"url":"https://api.github.com/repos/numenta/nupic/labels/cleanup","name":"cleanup","color":"c7def8"},{"url":"https://api.github.com/repos/numenta/nupic/labels/ready","name":"ready","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"david-ragazzi","id":3386273,"avatar_url":"https://avatars.githubusercontent.com/u/3386273?v=3","gravatar_id":"","url":"https://api.github.com/users/david-ragazzi","html_url":"https://github.com/david-ragazzi","followers_url":"https://api.github.com/users/david-ragazzi/followers","following_url":"https://api.github.com/users/david-ragazzi/following{/other_user}","gists_url":"https://api.github.com/users/david-ragazzi/gists{/gist_id}","starred_url":"https://api.github.com/users/david-ragazzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-ragazzi/subscriptions","organizations_url":"https://api.github.com/users/david-ragazzi/orgs","repos_url":"https://api.github.com/users/david-ragazzi/repos","events_url":"https://api.github.com/users/david-ragazzi/events{/privacy}","received_events_url":"https://api.github.com/users/david-ragazzi/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/numenta/nupic/milestones/50","html_url":"https://github.com/numenta/nupic/milestones/0.5.0:%20Clean%20code","labels_url":"https://api.github.com/repos/numenta/nupic/milestones/50/labels","id":995925,"number":50,"title":"0.5.0: Clean code","description":"CLEAN CODE\r\n\r\n- C++ code cleanup\r\n- Python code cleanup","creator":{"login":"rhyolight","id":15566,"avatar_url":"https://avatars.githubusercontent.com/u/15566?v=3","gravatar_id":"","url":"https://api.github.com/users/rhyolight","html_url":"https://github.com/rhyolight","followers_url":"https://api.github.com/users/rhyolight/followers","following_url":"https://api.github.com/users/rhyolight/following{/other_user}","gists_url":"https://api.github.com/users/rhyolight/gists{/gist_id}","starred_url":"https://api.github.com/users/rhyolight/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhyolight/subscriptions","organizations_url":"https://api.github.com/users/rhyolight/orgs","repos_url":"https://api.github.com/users/rhyolight/repos","events_url":"https://api.github.com/users/rhyolight/events{/privacy}","received_events_url":"https://api.github.com/users/rhyolight/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":3,"state":"open","created_at":"2015-02-25T21:37:15Z","updated_at":"2015-03-15T18:30:26Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2015-02-25T00:26:11Z","updated_at":"2015-03-16T16:32:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/numenta/nupic/pulls/1872","html_url":"https://github.com/numenta/nupic/pull/1872","diff_url":"https://github.com/numenta/nupic/pull/1872.diff","patch_url":"https://github.com/numenta/nupic/pull/1872.patch"},"body":"Fixes: #1864\r\n\r\nThis PR basically removes FDRCSpatial2 and FlatSpatialPooler classes.\r\n\r\nTo we safely remove these 2 classes we have to change `spatialImp` parameter from `oldpy` to `py` and update some old field names of these examples/tests to the field names used in the current SpatialPooler class. Example:\r\n\r\n```\r\ncoincidencesShape => columnDimensions\r\ninputShape => inputDimensions\r\ncoincInputRadius => potentialRadius\r\ncoincInputPoolPct => potentialPct\r\nnumActivePerInhArea => numActiveColumnsPerInhArea\r\n```\r\n\r\nOne positive effect of this PR is that field names become more updated and uniform throughout the code.. :smiley: "},"comment":{"url":"https://api.github.com/repos/numenta/nupic/issues/comments/81779332","html_url":"https://github.com/numenta/nupic/pull/1872#issuecomment-81779332","issue_url":"https://api.github.com/repos/numenta/nupic/issues/1872","id":81779332,"user":{"login":"chetan51","id":310282,"avatar_url":"https://avatars.githubusercontent.com/u/310282?v=3","gravatar_id":"","url":"https://api.github.com/users/chetan51","html_url":"https://github.com/chetan51","followers_url":"https://api.github.com/users/chetan51/followers","following_url":"https://api.github.com/users/chetan51/following{/other_user}","gists_url":"https://api.github.com/users/chetan51/gists{/gist_id}","starred_url":"https://api.github.com/users/chetan51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chetan51/subscriptions","organizations_url":"https://api.github.com/users/chetan51/orgs","repos_url":"https://api.github.com/users/chetan51/repos","events_url":"https://api.github.com/users/chetan51/events{/privacy}","received_events_url":"https://api.github.com/users/chetan51/received_events","type":"User","site_admin":false},"created_at":"2015-03-16T16:32:43Z","updated_at":"2015-03-16T16:32:43Z","body":"@david-ragazzi I've left some comments and suggestions. Overall, great work!"}}