{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/43101501","id":43101501,"diff_hunk":"@@ -242,9 +242,15 @@ std::unique_ptr<PIDFile> daemonize() {\n \n     // Redirect standard files; we always use boost::log anyway\n \n-    stdin = freopen(\"/dev/null\", \"r\", stdin);\n-    stdout = freopen(\"/dev/null\", \"w\", stdout);\n-    stderr = freopen(\"/dev/null\", \"w\", stderr);\n+    if (freopen(\"/dev/null\", \"r\", stdin) == nullptr) {\n+        LOG_WARNING(\"Failed to redirect stdin to /dev/null; errno=%1%\", std::to_string(errno));","path":"lib/src/util/posix/daemonize.cc","position":8,"original_position":8,"commit_id":"d0b551bc3e488bd224f6c352ed176aaaadd096f3","original_commit_id":"d0b551bc3e488bd224f6c352ed176aaaadd096f3","user":{"login":"parisiale","id":7150922,"avatar_url":"https://avatars.githubusercontent.com/u/7150922?v=3","gravatar_id":"","url":"https://api.github.com/users/parisiale","html_url":"https://github.com/parisiale","followers_url":"https://api.github.com/users/parisiale/followers","following_url":"https://api.github.com/users/parisiale/following{/other_user}","gists_url":"https://api.github.com/users/parisiale/gists{/gist_id}","starred_url":"https://api.github.com/users/parisiale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/parisiale/subscriptions","organizations_url":"https://api.github.com/users/parisiale/orgs","repos_url":"https://api.github.com/users/parisiale/repos","events_url":"https://api.github.com/users/parisiale/events{/privacy}","received_events_url":"https://api.github.com/users/parisiale/received_events","type":"User","site_admin":false},"body":"Thanks @kylog , I'll take care of that in a separate PR.","created_at":"2015-10-27T10:00:58Z","updated_at":"2015-10-27T10:00:58Z","html_url":"https://github.com/puppetlabs/pxp-agent/pull/193#discussion_r43101501","pull_request_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments/43101501"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/193#discussion_r43101501"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193","id":48789543,"html_url":"https://github.com/puppetlabs/pxp-agent/pull/193","diff_url":"https://github.com/puppetlabs/pxp-agent/pull/193.diff","patch_url":"https://github.com/puppetlabs/pxp-agent/pull/193.patch","issue_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/193","number":193,"state":"open","locked":false,"title":"(maint) Fix compiling on Solaris","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Commit e0537e0289514db634dfe458075e9344f9d98f89 broke compilation on\r\nSolaris, as stdin/stdout/stderr are macros and can't be assigned to.\r\n\r\nThe original change was to avoid cppcheck warnings. Change to checking\r\nthe return value and logging if there was a failure.","created_at":"2015-10-26T20:01:51Z","updated_at":"2015-10-27T10:00:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dd11b28963a5d9262235f1a30abd38dbfef8aaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/193/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/d0b551bc3e488bd224f6c352ed176aaaadd096f3","head":{"label":"MikaelSmith:fix-solaris","ref":"fix-solaris","sha":"d0b551bc3e488bd224f6c352ed176aaaadd096f3","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"repo":{"id":44132638,"name":"pxp-agent","full_name":"MikaelSmith/pxp-agent","owner":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MikaelSmith/pxp-agent","description":"PCP eXecution Protocol Agent","fork":true,"url":"https://api.github.com/repos/MikaelSmith/pxp-agent","forks_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/forks","keys_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/teams","hooks_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/events","assignees_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/tags","blobs_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/subscription","commits_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/merges","archive_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/downloads","issues_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/MikaelSmith/pxp-agent/releases{/id}","created_at":"2015-10-12T20:33:02Z","updated_at":"2015-10-12T20:33:03Z","pushed_at":"2015-10-27T00:21:08Z","git_url":"git://github.com/MikaelSmith/pxp-agent.git","ssh_url":"git@github.com:MikaelSmith/pxp-agent.git","clone_url":"https://github.com/MikaelSmith/pxp-agent.git","svn_url":"https://github.com/MikaelSmith/pxp-agent","homepage":"","size":8632,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"c466081d8379406c7ec5fdc4c59da0739e7492da","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":23231786,"name":"pxp-agent","full_name":"puppetlabs/pxp-agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pxp-agent","description":"PCP eXecution Protocol Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/pxp-agent","forks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/pxp-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pxp-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pxp-agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pxp-agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pxp-agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pxp-agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pxp-agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pxp-agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pxp-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pxp-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pxp-agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pxp-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pxp-agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/pxp-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pxp-agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pxp-agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pxp-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pxp-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pxp-agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pxp-agent/releases{/id}","created_at":"2014-08-22T16:25:01Z","updated_at":"2015-10-19T23:27:50Z","pushed_at":"2015-10-27T00:21:09Z","git_url":"git://github.com/puppetlabs/pxp-agent.git","ssh_url":"git@github.com:puppetlabs/pxp-agent.git","clone_url":"https://github.com/puppetlabs/pxp-agent.git","svn_url":"https://github.com/puppetlabs/pxp-agent","homepage":"","size":10230,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":6,"forks":11,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193"},"html":{"href":"https://github.com/puppetlabs/pxp-agent/pull/193"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/193"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pxp-agent/statuses/d0b551bc3e488bd224f6c352ed176aaaadd096f3"}}}}