{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/43756094","id":43756094,"diff_hunk":"@@ -0,0 +1,36 @@\n+class HostAspectBase < ActiveRecord::Base\n+  self.abstract_class = true\n+\n+  def self.inherited(subclass)\n+    super\n+    subclass.class_eval do\n+      belongs_to_host\n+    end\n+  end\n+\n+  def info\n+    {}\n+  end\n+\n+  def smart_proxy_ids\n+    []\n+  end\n+\n+  def after_clone\n+  end\n+\n+  def template_filter_options(kind)\n+    {}\n+  end\n+\n+  def provisioning_template_options(base_options)\n+    base_options\n+  end\n+\n+  def self.inherited_attributes(hostgroup, aspect_attributes)\n+    aspect_attributes\n+  end\n+\n+  def self.populate_fields_from_facts(host, importer, type, proxy_id)","path":"app/models/host_aspect_base.rb","position":34,"original_position":34,"commit_id":"d120adde60c42705328fe170d0d95e15061b09c2","original_commit_id":"d120adde60c42705328fe170d0d95e15061b09c2","user":{"login":"dLobatog","id":598891,"avatar_url":"https://avatars.githubusercontent.com/u/598891?v=3","gravatar_id":"","url":"https://api.github.com/users/dLobatog","html_url":"https://github.com/dLobatog","followers_url":"https://api.github.com/users/dLobatog/followers","following_url":"https://api.github.com/users/dLobatog/following{/other_user}","gists_url":"https://api.github.com/users/dLobatog/gists{/gist_id}","starred_url":"https://api.github.com/users/dLobatog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dLobatog/subscriptions","organizations_url":"https://api.github.com/users/dLobatog/orgs","repos_url":"https://api.github.com/users/dLobatog/repos","events_url":"https://api.github.com/users/dLobatog/events{/privacy}","received_events_url":"https://api.github.com/users/dLobatog/received_events","type":"User","site_admin":false},"body":"The definition on `import_host_and_facts` on `Host::Managed` doesn't *need* a proxy, it's nil if it can't be found. Otherwise you couldn't submit facts from non-registered proxies, or from [foreman_ansible](https://github.com/dlobatog/foreman_ansible)","created_at":"2015-11-03T14:53:40Z","updated_at":"2015-11-03T14:53:40Z","html_url":"https://github.com/theforeman/foreman/pull/2665#discussion_r43756094","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2665","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/43756094"},"html":{"href":"https://github.com/theforeman/foreman/pull/2665#discussion_r43756094"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2665"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2665","id":43979267,"html_url":"https://github.com/theforeman/foreman/pull/2665","diff_url":"https://github.com/theforeman/foreman/pull/2665.diff","patch_url":"https://github.com/theforeman/foreman/pull/2665.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2665","number":2665,"state":"open","locked":false,"title":"Fixes #11155 - Added support for aspect models","user":{"login":"ShimShtein","id":10046168,"avatar_url":"https://avatars.githubusercontent.com/u/10046168?v=3","gravatar_id":"","url":"https://api.github.com/users/ShimShtein","html_url":"https://github.com/ShimShtein","followers_url":"https://api.github.com/users/ShimShtein/followers","following_url":"https://api.github.com/users/ShimShtein/following{/other_user}","gists_url":"https://api.github.com/users/ShimShtein/gists{/gist_id}","starred_url":"https://api.github.com/users/ShimShtein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShimShtein/subscriptions","organizations_url":"https://api.github.com/users/ShimShtein/orgs","repos_url":"https://api.github.com/users/ShimShtein/repos","events_url":"https://api.github.com/users/ShimShtein/events{/privacy}","received_events_url":"https://api.github.com/users/ShimShtein/received_events","type":"User","site_admin":false},"body":"This is the first part of the work - it contains all changes that are needed in the existing environment.\r\nOnce it is merged, it will be possible to move on, and create a PR that will separate aspects from the existing host.\r\n\r\nhttp://projects.theforeman.org/projects/katello/wiki/HostUnification","created_at":"2015-09-02T11:09:32Z","updated_at":"2015-11-03T14:53:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"18867e628193858d3081033aabf63b4d1af758d5","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2665/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2665/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2665/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/d120adde60c42705328fe170d0d95e15061b09c2","head":{"label":"ShimShtein:host-aspects","ref":"host-aspects","sha":"d120adde60c42705328fe170d0d95e15061b09c2","user":{"login":"ShimShtein","id":10046168,"avatar_url":"https://avatars.githubusercontent.com/u/10046168?v=3","gravatar_id":"","url":"https://api.github.com/users/ShimShtein","html_url":"https://github.com/ShimShtein","followers_url":"https://api.github.com/users/ShimShtein/followers","following_url":"https://api.github.com/users/ShimShtein/following{/other_user}","gists_url":"https://api.github.com/users/ShimShtein/gists{/gist_id}","starred_url":"https://api.github.com/users/ShimShtein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShimShtein/subscriptions","organizations_url":"https://api.github.com/users/ShimShtein/orgs","repos_url":"https://api.github.com/users/ShimShtein/repos","events_url":"https://api.github.com/users/ShimShtein/events{/privacy}","received_events_url":"https://api.github.com/users/ShimShtein/received_events","type":"User","site_admin":false},"repo":{"id":27429897,"name":"foreman","full_name":"ShimShtein/foreman","owner":{"login":"ShimShtein","id":10046168,"avatar_url":"https://avatars.githubusercontent.com/u/10046168?v=3","gravatar_id":"","url":"https://api.github.com/users/ShimShtein","html_url":"https://github.com/ShimShtein","followers_url":"https://api.github.com/users/ShimShtein/followers","following_url":"https://api.github.com/users/ShimShtein/following{/other_user}","gists_url":"https://api.github.com/users/ShimShtein/gists{/gist_id}","starred_url":"https://api.github.com/users/ShimShtein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShimShtein/subscriptions","organizations_url":"https://api.github.com/users/ShimShtein/orgs","repos_url":"https://api.github.com/users/ShimShtein/repos","events_url":"https://api.github.com/users/ShimShtein/events{/privacy}","received_events_url":"https://api.github.com/users/ShimShtein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ShimShtein/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ShimShtein/foreman","forks_url":"https://api.github.com/repos/ShimShtein/foreman/forks","keys_url":"https://api.github.com/repos/ShimShtein/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ShimShtein/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ShimShtein/foreman/teams","hooks_url":"https://api.github.com/repos/ShimShtein/foreman/hooks","issue_events_url":"https://api.github.com/repos/ShimShtein/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ShimShtein/foreman/events","assignees_url":"https://api.github.com/repos/ShimShtein/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ShimShtein/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ShimShtein/foreman/tags","blobs_url":"https://api.github.com/repos/ShimShtein/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ShimShtein/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ShimShtein/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ShimShtein/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ShimShtein/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ShimShtein/foreman/languages","stargazers_url":"https://api.github.com/repos/ShimShtein/foreman/stargazers","contributors_url":"https://api.github.com/repos/ShimShtein/foreman/contributors","subscribers_url":"https://api.github.com/repos/ShimShtein/foreman/subscribers","subscription_url":"https://api.github.com/repos/ShimShtein/foreman/subscription","commits_url":"https://api.github.com/repos/ShimShtein/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ShimShtein/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ShimShtein/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ShimShtein/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ShimShtein/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ShimShtein/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ShimShtein/foreman/merges","archive_url":"https://api.github.com/repos/ShimShtein/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ShimShtein/foreman/downloads","issues_url":"https://api.github.com/repos/ShimShtein/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ShimShtein/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ShimShtein/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ShimShtein/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ShimShtein/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ShimShtein/foreman/releases{/id}","created_at":"2014-12-02T11:40:34Z","updated_at":"2015-04-22T09:01:47Z","pushed_at":"2015-11-03T12:54:07Z","git_url":"git://github.com/ShimShtein/foreman.git","ssh_url":"git@github.com:ShimShtein/foreman.git","clone_url":"https://github.com/ShimShtein/foreman.git","svn_url":"https://github.com/ShimShtein/foreman","homepage":"http://theforeman.org","size":32876,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"91851db017953aebb117c69802fb80a84800b925","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-11-03T14:34:56Z","pushed_at":"2015-11-03T13:39:23Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":99370,"stargazers_count":881,"watchers_count":881,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":447,"mirror_url":null,"open_issues_count":81,"forks":447,"open_issues":81,"watchers":881,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2665"},"html":{"href":"https://github.com/theforeman/foreman/pull/2665"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2665"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2665/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2665/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2665/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/d120adde60c42705328fe170d0d95e15061b09c2"}}}}