{"action":"created","issue":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9234","labels_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9234/labels{/name}","comments_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9234/comments","events_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9234/events","html_url":"https://github.com/gitlabhq/gitlabhq/pull/9234","id":72292010,"number":9234,"title":"Group milestones by title in the dashboard and all other issue views","user":{"login":"dsander","id":20943,"avatar_url":"https://avatars.githubusercontent.com/u/20943?v=3","gravatar_id":"","url":"https://api.github.com/users/dsander","html_url":"https://github.com/dsander","followers_url":"https://api.github.com/users/dsander/followers","following_url":"https://api.github.com/users/dsander/following{/other_user}","gists_url":"https://api.github.com/users/dsander/gists{/gist_id}","starred_url":"https://api.github.com/users/dsander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsander/subscriptions","organizations_url":"https://api.github.com/users/dsander/orgs","repos_url":"https://api.github.com/users/dsander/repos","events_url":"https://api.github.com/users/dsander/events{/privacy}","received_events_url":"https://api.github.com/users/dsander/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/labels/Ready%20for%20Merge","name":"Ready for Merge","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-30T21:55:45Z","updated_at":"2015-05-03T11:29:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/pulls/9234","html_url":"https://github.com/gitlabhq/gitlabhq/pull/9234","diff_url":"https://github.com/gitlabhq/gitlabhq/pull/9234.diff","patch_url":"https://github.com/gitlabhq/gitlabhq/pull/9234.patch"},"body":"This groups milestones by title for issue views like it has been done for the milestone dashboard/project overview. Before milestones with the same title would show up multiple times in the filter dropdown and one could only filter per project and milestone. Now the milestone filter is based on the title of the milestone, i.e. all issues marked with the same milestone title are shown.\r\n\r\nWhile working on this I noticed that the variables assigned by `ApplicationController#set_filter_values` seem not to be used by anything anymore, so I removed the method and it's invocations. I included it in this PR because I would have to make changes to it (`milestone_id` vs `milestone_title`) whose consequences I could not test. If I missed something, please correct me, and I will revert the second commit and change it to use the `milestone_label`.\r\n\r\n~~The specs do not work very well locally for me, so I am labeling it as WIP until the CI confirms the specs pass.~~\r\n\r\nBefore:\r\n![before](https://cloud.githubusercontent.com/assets/20943/7423287/2f62ab6c-ef94-11e4-96fd-a2eeab4e1ddf.jpg)\r\nAfter:\r\n![after](https://cloud.githubusercontent.com/assets/20943/7423290/33c75e5a-ef94-11e4-93b3-22480afd56f1.jpg)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/comments/98471867","html_url":"https://github.com/gitlabhq/gitlabhq/pull/9234#issuecomment-98471867","issue_url":"https://api.github.com/repos/gitlabhq/gitlabhq/issues/9234","id":98471867,"user":{"login":"randx","id":305940,"avatar_url":"https://avatars.githubusercontent.com/u/305940?v=3","gravatar_id":"","url":"https://api.github.com/users/randx","html_url":"https://github.com/randx","followers_url":"https://api.github.com/users/randx/followers","following_url":"https://api.github.com/users/randx/following{/other_user}","gists_url":"https://api.github.com/users/randx/gists{/gist_id}","starred_url":"https://api.github.com/users/randx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randx/subscriptions","organizations_url":"https://api.github.com/users/randx/orgs","repos_url":"https://api.github.com/users/randx/repos","events_url":"https://api.github.com/users/randx/events{/privacy}","received_events_url":"https://api.github.com/users/randx/received_events","type":"User","site_admin":false},"created_at":"2015-05-03T11:29:28Z","updated_at":"2015-05-03T11:29:28Z","body":"Great! Thank you"}}