{"action":"created","issue":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/issues/31","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/issues/31/labels{/name}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/issues/31/comments","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/issues/31/events","html_url":"https://github.com/puppetlabs/puppetlabs-xinetd/pull/31","id":26753466,"number":31,"title":"Removed default values from xinetd.conf and added params for each (and tests!)","user":{"login":"solarkennedy","id":370205,"avatar_url":"https://avatars.githubusercontent.com/u/370205?v=3","gravatar_id":"","url":"https://api.github.com/users/solarkennedy","html_url":"https://github.com/solarkennedy","followers_url":"https://api.github.com/users/solarkennedy/followers","following_url":"https://api.github.com/users/solarkennedy/following{/other_user}","gists_url":"https://api.github.com/users/solarkennedy/gists{/gist_id}","starred_url":"https://api.github.com/users/solarkennedy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solarkennedy/subscriptions","organizations_url":"https://api.github.com/users/solarkennedy/orgs","repos_url":"https://api.github.com/users/solarkennedy/repos","events_url":"https://api.github.com/users/solarkennedy/events{/privacy}","received_events_url":"https://api.github.com/users/solarkennedy/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":12,"created_at":"2014-02-02T03:21:19Z","updated_at":"2015-04-06T17:58:00Z","closed_at":"2015-04-01T01:39:56Z","pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/pulls/31","html_url":"https://github.com/puppetlabs/puppetlabs-xinetd/pull/31","diff_url":"https://github.com/puppetlabs/puppetlabs-xinetd/pull/31.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-xinetd/pull/31.patch"},"body":"I believe that this puppet module providing un-changeable defaults in the xinetd.conf makes too many assumptions about the users environment. Maybe they have a version of xinetd that doesn't support some of the settings provided? Maybe they want to have specific default settings that they don't have to duplicate for each individual service?\r\n\r\nTaking these variables __out__ of the xinted.conf and adding them as parameters gives us maximum flexibility for users, and allows the __native__ xinetd to use its own system defaults. \r\n\r\nI know this is a different behavior than what it currently does, but I believe it is better than having the hard-coded default values as they are now, which I believed are copied from debian? However, admins can get the same behavior as before by providing the params, or simply not specify them to get the built-in xinetd defaults. "},"comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/issues/comments/90176038","html_url":"https://github.com/puppetlabs/puppetlabs-xinetd/pull/31#issuecomment-90176038","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-xinetd/issues/31","id":90176038,"user":{"login":"mhaskel","id":553464,"avatar_url":"https://avatars.githubusercontent.com/u/553464?v=3","gravatar_id":"","url":"https://api.github.com/users/mhaskel","html_url":"https://github.com/mhaskel","followers_url":"https://api.github.com/users/mhaskel/followers","following_url":"https://api.github.com/users/mhaskel/following{/other_user}","gists_url":"https://api.github.com/users/mhaskel/gists{/gist_id}","starred_url":"https://api.github.com/users/mhaskel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhaskel/subscriptions","organizations_url":"https://api.github.com/users/mhaskel/orgs","repos_url":"https://api.github.com/users/mhaskel/repos","events_url":"https://api.github.com/users/mhaskel/events{/privacy}","received_events_url":"https://api.github.com/users/mhaskel/received_events","type":"User","site_admin":false},"created_at":"2015-04-06T17:58:00Z","updated_at":"2015-04-06T17:58:00Z","body":"@solarkennedy apologies this took so long. I rebased/squashed it in #56. Thanks for your work on this!"}}