{"action":"created","comment":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/29142653","id":29142653,"diff_hunk":"@@ -166,6 +169,16 @@ func (w *Walker) walkAndHashFiles(fchan chan protocol.FileInfo) filepath.WalkFun\n \t\t\treturn skip\n \t\t}\n \n+\t\tif w.Pruner != nil {","path":"internal/scanner/walk.go","position":30,"original_position":30,"commit_id":"80cd7800778446c434024e869faff1bfee302780","original_commit_id":"80cd7800778446c434024e869faff1bfee302780","user":{"login":"calmh","id":125426,"avatar_url":"https://avatars.githubusercontent.com/u/125426?v=3","gravatar_id":"","url":"https://api.github.com/users/calmh","html_url":"https://github.com/calmh","followers_url":"https://api.github.com/users/calmh/followers","following_url":"https://api.github.com/users/calmh/following{/other_user}","gists_url":"https://api.github.com/users/calmh/gists{/gist_id}","starred_url":"https://api.github.com/users/calmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calmh/subscriptions","organizations_url":"https://api.github.com/users/calmh/orgs","repos_url":"https://api.github.com/users/calmh/repos","events_url":"https://api.github.com/users/calmh/events{/privacy}","received_events_url":"https://api.github.com/users/calmh/received_events","type":"User","site_admin":false},"body":"I don't think it's an anti-pattern... In this case, I think it makes sense for `f.ShouldSkip()` to be `false` when `f` is `nil` (rather than an error), much like `len(f)` is zero for nil slices.","created_at":"2015-04-27T12:46:56Z","updated_at":"2015-04-27T12:46:56Z","html_url":"https://github.com/syncthing/syncthing/pull/1712#discussion_r29142653","pull_request_url":"https://api.github.com/repos/syncthing/syncthing/pulls/1712","_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments/29142653"},"html":{"href":"https://github.com/syncthing/syncthing/pull/1712#discussion_r29142653"},"pull_request":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1712"}}},"pull_request":{"url":"https://api.github.com/repos/syncthing/syncthing/pulls/1712","id":34131384,"html_url":"https://github.com/syncthing/syncthing/pull/1712","diff_url":"https://github.com/syncthing/syncthing/pull/1712.diff","patch_url":"https://github.com/syncthing/syncthing/pull/1712.patch","issue_url":"https://api.github.com/repos/syncthing/syncthing/issues/1712","number":1712,"state":"open","locked":false,"title":"[WIP] Selective sync","user":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"body":"Basically, request for comments/help regarding this pruner business, as it looks really bad.\r\n\r\nEspecially the fact that I can't toggle stuff on or off without having to go through the config, and relying on the order the AJAX calls are made to potentially detect that the flag has been toggled.\r\n\r\nAlternatively I could rely on a nil slice to indicate it's on or off, but that's easy to mess up from the API consumer perspective.\r\n\r\n","created_at":"2015-04-26T22:34:39Z","updated_at":"2015-04-27T12:46:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f0668d6495e693e0c74f5d2f651179597fff896","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/syncthing/syncthing/pulls/1712/commits","review_comments_url":"https://api.github.com/repos/syncthing/syncthing/pulls/1712/comments","review_comment_url":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/syncthing/syncthing/issues/1712/comments","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/80cd7800778446c434024e869faff1bfee302780","head":{"label":"AudriusButkevicius:sel","ref":"sel","sha":"80cd7800778446c434024e869faff1bfee302780","user":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"repo":{"id":22119752,"name":"syncthing","full_name":"AudriusButkevicius/syncthing","owner":{"login":"AudriusButkevicius","id":1144861,"avatar_url":"https://avatars.githubusercontent.com/u/1144861?v=3","gravatar_id":"","url":"https://api.github.com/users/AudriusButkevicius","html_url":"https://github.com/AudriusButkevicius","followers_url":"https://api.github.com/users/AudriusButkevicius/followers","following_url":"https://api.github.com/users/AudriusButkevicius/following{/other_user}","gists_url":"https://api.github.com/users/AudriusButkevicius/gists{/gist_id}","starred_url":"https://api.github.com/users/AudriusButkevicius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AudriusButkevicius/subscriptions","organizations_url":"https://api.github.com/users/AudriusButkevicius/orgs","repos_url":"https://api.github.com/users/AudriusButkevicius/repos","events_url":"https://api.github.com/users/AudriusButkevicius/events{/privacy}","received_events_url":"https://api.github.com/users/AudriusButkevicius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AudriusButkevicius/syncthing","description":"Open Source Continuous File Synchronization","fork":true,"url":"https://api.github.com/repos/AudriusButkevicius/syncthing","forks_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/forks","keys_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/teams","hooks_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/hooks","issue_events_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/events","assignees_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/tags","blobs_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/languages","stargazers_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/stargazers","contributors_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/contributors","subscribers_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/subscribers","subscription_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/subscription","commits_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/merges","archive_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/downloads","issues_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/AudriusButkevicius/syncthing/releases{/id}","created_at":"2014-07-22T20:36:14Z","updated_at":"2015-03-30T20:58:54Z","pushed_at":"2015-04-27T07:51:52Z","git_url":"git://github.com/AudriusButkevicius/syncthing.git","ssh_url":"git@github.com:AudriusButkevicius/syncthing.git","clone_url":"https://github.com/AudriusButkevicius/syncthing.git","svn_url":"https://github.com/AudriusButkevicius/syncthing","homepage":"http://discourse.syncthing.net/","size":43276,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"syncthing:master","ref":"master","sha":"f5211b0697a711b5e6aa133b393698ba06111c9f","user":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"repo":{"id":14712850,"name":"syncthing","full_name":"syncthing/syncthing","owner":{"login":"syncthing","id":7628018,"avatar_url":"https://avatars.githubusercontent.com/u/7628018?v=3","gravatar_id":"","url":"https://api.github.com/users/syncthing","html_url":"https://github.com/syncthing","followers_url":"https://api.github.com/users/syncthing/followers","following_url":"https://api.github.com/users/syncthing/following{/other_user}","gists_url":"https://api.github.com/users/syncthing/gists{/gist_id}","starred_url":"https://api.github.com/users/syncthing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/syncthing/subscriptions","organizations_url":"https://api.github.com/users/syncthing/orgs","repos_url":"https://api.github.com/users/syncthing/repos","events_url":"https://api.github.com/users/syncthing/events{/privacy}","received_events_url":"https://api.github.com/users/syncthing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/syncthing/syncthing","description":"Open Source Continuous File Synchronization","fork":false,"url":"https://api.github.com/repos/syncthing/syncthing","forks_url":"https://api.github.com/repos/syncthing/syncthing/forks","keys_url":"https://api.github.com/repos/syncthing/syncthing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/syncthing/syncthing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/syncthing/syncthing/teams","hooks_url":"https://api.github.com/repos/syncthing/syncthing/hooks","issue_events_url":"https://api.github.com/repos/syncthing/syncthing/issues/events{/number}","events_url":"https://api.github.com/repos/syncthing/syncthing/events","assignees_url":"https://api.github.com/repos/syncthing/syncthing/assignees{/user}","branches_url":"https://api.github.com/repos/syncthing/syncthing/branches{/branch}","tags_url":"https://api.github.com/repos/syncthing/syncthing/tags","blobs_url":"https://api.github.com/repos/syncthing/syncthing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/syncthing/syncthing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/syncthing/syncthing/git/refs{/sha}","trees_url":"https://api.github.com/repos/syncthing/syncthing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/syncthing/syncthing/statuses/{sha}","languages_url":"https://api.github.com/repos/syncthing/syncthing/languages","stargazers_url":"https://api.github.com/repos/syncthing/syncthing/stargazers","contributors_url":"https://api.github.com/repos/syncthing/syncthing/contributors","subscribers_url":"https://api.github.com/repos/syncthing/syncthing/subscribers","subscription_url":"https://api.github.com/repos/syncthing/syncthing/subscription","commits_url":"https://api.github.com/repos/syncthing/syncthing/commits{/sha}","git_commits_url":"https://api.github.com/repos/syncthing/syncthing/git/commits{/sha}","comments_url":"https://api.github.com/repos/syncthing/syncthing/comments{/number}","issue_comment_url":"https://api.github.com/repos/syncthing/syncthing/issues/comments{/number}","contents_url":"https://api.github.com/repos/syncthing/syncthing/contents/{+path}","compare_url":"https://api.github.com/repos/syncthing/syncthing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/syncthing/syncthing/merges","archive_url":"https://api.github.com/repos/syncthing/syncthing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/syncthing/syncthing/downloads","issues_url":"https://api.github.com/repos/syncthing/syncthing/issues{/number}","pulls_url":"https://api.github.com/repos/syncthing/syncthing/pulls{/number}","milestones_url":"https://api.github.com/repos/syncthing/syncthing/milestones{/number}","notifications_url":"https://api.github.com/repos/syncthing/syncthing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/syncthing/syncthing/labels{/name}","releases_url":"https://api.github.com/repos/syncthing/syncthing/releases{/id}","created_at":"2013-11-26T09:48:21Z","updated_at":"2015-04-27T12:38:22Z","pushed_at":"2015-04-27T07:51:53Z","git_url":"git://github.com/syncthing/syncthing.git","ssh_url":"git@github.com:syncthing/syncthing.git","clone_url":"https://github.com/syncthing/syncthing.git","svn_url":"https://github.com/syncthing/syncthing","homepage":"http://forum.syncthing.net/","size":62557,"stargazers_count":8116,"watchers_count":8116,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":560,"mirror_url":null,"open_issues_count":141,"forks":560,"open_issues":141,"watchers":8116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1712"},"html":{"href":"https://github.com/syncthing/syncthing/pull/1712"},"issue":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/1712"},"comments":{"href":"https://api.github.com/repos/syncthing/syncthing/issues/1712/comments"},"review_comments":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1712/comments"},"review_comment":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/syncthing/syncthing/pulls/1712/commits"},"statuses":{"href":"https://api.github.com/repos/syncthing/syncthing/statuses/80cd7800778446c434024e869faff1bfee302780"}}}}