{"push_id":906558776,"size":12,"distinct_size":0,"ref":"refs/heads/dev","head":"167fb919a55e8dc5d12d4debe7965208029e3505","before":"d26a4ea621f36912c0a4d9bace7834512cb6fc05","commits":[{"sha":"030215bf01e2d239f8136212e261f00dcdcbdb16","author":{"email":"01b4858c232b891e1ad3edd1cd6314647466376f@fb.com","name":"Venkatesh Radhakrishnan"},"message":"Running manual compactions in parallel with other automatic or manual compactions in restricted cases\n\nSummary:\nThis diff provides a framework for doing manual\ncompactions in parallel with other compactions. We now have a deque of manual compactions. We also pass manual compactions as an argument from RunManualCompactions down to\nBackgroundCompactions, so that RunManualCompactions can be reentrant.\nParallelism is controlled by the two routines\nConflictingManualCompaction to allow/disallow new parallel/manual\ncompactions based on already existing ManualCompactions. In this diff, by default manual compactions still have to run exclusive of other compactions. However, by setting the compaction option, exclusive_manual_compaction to false, it is possible to run other compactions in parallel with a manual compaction. However, we are still restricted to one manual compaction per column family at a time. All of these restrictions will be relaxed in future diffs.\nI will be adding more tests later.\n\nTest Plan: Rocksdb regression + new tests + valgrind\n\nReviewers: igor, anthony, IslamAbdelRahman, kradhakrishnan, yhchiang, sdong\n\nReviewed By: sdong\n\nSubscribers: yoshinorim, dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D47973","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/030215bf01e2d239f8136212e261f00dcdcbdb16"},{"sha":"636cd3c714605456cbdff17d54f843c08d13ca77","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Clean up listener_test (reuse db_test_util)\n\nSummary: Reuse db_test_util in listener_test\n\nTest Plan:\nmake listener_test -j64 && ./listener_test\nUSE_CLANG=1 make listener_test -j64 && ./listener_test\n\nReviewers: yhchiang, rven, kradhakrishnan, anthony\n\nReviewed By: anthony\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D51939","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/636cd3c714605456cbdff17d54f843c08d13ca77"},{"sha":"99ae549d370e28071cf925ac097202b87ee8edaa","author":{"email":"ed234820f649e2dfdaaaf4a8b58ffef7cb61b74c@outlook.com","name":"Zhipeng Jia"},"message":"Fix typo","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/99ae549d370e28071cf925ac097202b87ee8edaa"},{"sha":"963660eb55af96aeaf6bcea89271dd6f326ff0bb","author":{"email":"c41a91592f3385ee0351a6ff99a5fed70f5190fe@gmail.com","name":"Igor Canadi"},"message":"Merge pull request #883 from zhipeng-jia/master\n\nFix typo","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/963660eb55af96aeaf6bcea89271dd6f326ff0bb"},{"sha":"b6d19adcf761a8e2ec56bb55c4a4512a03a405fc","author":{"email":"40bc6d3c318538862cbe0610c762785daf6403c0@microsoft.com","name":"Dmitri Smirnov"},"message":"Use port size_t formatting","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/b6d19adcf761a8e2ec56bb55c4a4512a03a405fc"},{"sha":"b68dc0f83e725b00e65b4c397070b67a3560390f","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Merge pull request #885 from yuslepukhin/fix_size_t_formatting\n\nUse port size_t formatting","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/b68dc0f83e725b00e65b4c397070b67a3560390f"},{"sha":"97265f5f1455238581e01b3e07bfdf3564d97bf5","author":{"email":"b683122d63d1210e5e3712f1eddfa8fb81c11c5b@fb.com","name":"Gunnar Kudrjavets"},"message":"Fix minor bugs in delete operator, snprintf, and size_t usage\n\nSummary:\nList of changes:\n\n1) Fix the snprintf() usage in cases where wrong variable was used to determine the output buffer size.\n\n2) Remove unnecessary checks before calling delete operator.\n\n3) Increase code correctness by using size_t type when getting vector's size.\n\n4) Unify the coding style by removing namespace::std usage at the top of the file to confirm to the majority usage.\n\n5) Fix various lint errors pointed out by 'arc lint'.\n\nTest Plan:\nCode review and build:\n\ngit diff\nmake clean\nmake -j 32 commit-prereq\narc lint\n\nReviewers: kradhakrishnan, sdong, rven, anthony, yhchiang, igor\n\nReviewed By: igor\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D51849","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/97265f5f1455238581e01b3e07bfdf3564d97bf5"},{"sha":"aa29cc12895eda15eb3ead0148c2015601405952","author":{"email":"c41a91592f3385ee0351a6ff99a5fed70f5190fe@gmail.com","name":"Igor Canadi"},"message":"Improve examples/README.md","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/aa29cc12895eda15eb3ead0148c2015601405952"},{"sha":"e6e505a4d922ad63ff141b419d8e8aefdb852746","author":{"email":"b74673f3c990e809b0211cc26cf8ff8cc1ef0907@fb.com","name":"Igor Canadi"},"message":"Fix examples\n\nSummary: For some reason `make librocksdb.a` is not valid anymore. Replace with `make static_lib`\n\nTest Plan: cd examples/; make all;\n\nReviewers: sdong\n\nSubscribers: dhruba, leveldb\n\nDifferential Revision: https://reviews.facebook.net/D52017","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/e6e505a4d922ad63ff141b419d8e8aefdb852746"},{"sha":"aececc209e0ceb7deb04c8e10ea2a06c2f858aa3","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Introduce ReadOptions::pin_data (support zero copy for keys)\n\nSummary:\nThis patch update the Iterator API to introduce new functions that allow users to keep the Slices returned by key() valid as long as the Iterator is not deleted\n\nReadOptions::pin_data : If true keep loaded blocks in memory as long as the iterator is not deleted\nIterator::IsKeyPinned() : If true, this mean that the Slice returned by key() is valid as long as the iterator is not deleted\n\nAlso add a new option BlockBasedTableOptions::use_delta_encoding to allow users to disable delta_encoding if needed.\n\nBenchmark results (using https://phabricator.fb.com/P20083553)\n\n```\n// $ du -h /home/tec/local/normal.4K.Snappy/db10077\n// 6.1G    /home/tec/local/normal.4K.Snappy/db10077\n\n// $ du -h /home/tec/local/zero.8K.LZ4/db10077\n// 6.4G    /home/tec/local/zero.8K.LZ4/db10077\n\n// Benchmarks for shard db10077\n// _build/opt/rocks/benchmark/rocks_copy_benchmark \\\n//      --normal_db_path=\"/home/tec/local/normal.4K.Snappy/db10077\" \\\n//      --zero_db_path=\"/home/tec/local/zero.8K.LZ4/db10077\"\n\n// First run\n// ============================================================================\n// rocks/benchmark/RocksCopyBenchmark.cpp          relative  time/iter  iters/s\n// ============================================================================\n// BM_StringCopy                                                 1.73s  576.97m\n// BM_StringPiece                                   103.74%      1.67s  598.55m\n// ============================================================================\n// Match rate : 1000000 / 1000000\n\n// Second run\n// ============================================================================\n// rocks/benchmark/RocksCopyBenchmark.cpp          relative  time/iter  iters/s\n// ============================================================================\n// BM_StringCopy                                              611.99ms     1.63\n// BM_StringPiece                                   203.76%   300.35ms     3.33\n// ============================================================================\n// Match rate : 1000000 / 1000000\n```\n\nTest Plan: Unit tests\n\nReviewers: sdong, igor, anthony, yhchiang, rven\n\nReviewed By: rven\n\nSubscribers: dhruba, lovro, adsharma\n\nDifferential Revision: https://reviews.facebook.net/D48999","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/aececc209e0ceb7deb04c8e10ea2a06c2f858aa3"},{"sha":"32ff05e97128c9c36fc4a0f9bbe04ba712dea127","author":{"email":"73f7a2f5b9bd744ab54cd1d307975868fc93a844@fb.com","name":"Islam AbdelRahman"},"message":"Bump version to 4.4\n\nSummary: Bump version to 4.4\n\nTest Plan: none\n\nReviewers: sdong, rven, yhchiang, anthony, kradhakrishnan\n\nReviewed By: kradhakrishnan\n\nSubscribers: dhruba\n\nDifferential Revision: https://reviews.facebook.net/D52035","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/32ff05e97128c9c36fc4a0f9bbe04ba712dea127"},{"sha":"167fb919a55e8dc5d12d4debe7965208029e3505","author":{"email":"485e2df9581649b6c8f873e000ad8bee4290c1b7@fb.com","name":"sdong"},"message":"ZSTD to use CompressionOptions.level\n\nSummary: Now ZSTD hard code level 1. Change it to use the compression level setting.\n\nTest Plan: Run it with hacked codes of sst_dump and show ZSTD compression sizes with different levels.\n\nReviewers: rven, anthony, yhchiang, kradhakrishnan, igor, IslamAbdelRahman\n\nReviewed By: IslamAbdelRahman\n\nSubscribers: yoshinorim, leveldb, dhruba\n\nDifferential Revision: https://reviews.facebook.net/D52041","distinct":false,"url":"https://api.github.com/repos/norton/rocksdb/commits/167fb919a55e8dc5d12d4debe7965208029e3505"}]}