{"action":"created","issue":{"url":"https://api.github.com/repos/fs-webdev/experiment/issues/11","labels_url":"https://api.github.com/repos/fs-webdev/experiment/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/fs-webdev/experiment/issues/11/comments","events_url":"https://api.github.com/repos/fs-webdev/experiment/issues/11/events","html_url":"https://github.com/fs-webdev/experiment/pull/11","id":104737727,"number":11,"title":"Setting bucket based on ID","user":{"login":"rosemariesadler","id":11645238,"avatar_url":"https://avatars.githubusercontent.com/u/11645238?v=3","gravatar_id":"","url":"https://api.github.com/users/rosemariesadler","html_url":"https://github.com/rosemariesadler","followers_url":"https://api.github.com/users/rosemariesadler/followers","following_url":"https://api.github.com/users/rosemariesadler/following{/other_user}","gists_url":"https://api.github.com/users/rosemariesadler/gists{/gist_id}","starred_url":"https://api.github.com/users/rosemariesadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosemariesadler/subscriptions","organizations_url":"https://api.github.com/users/rosemariesadler/orgs","repos_url":"https://api.github.com/users/rosemariesadler/repos","events_url":"https://api.github.com/users/rosemariesadler/events{/privacy}","received_events_url":"https://api.github.com/users/rosemariesadler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"redbugz","id":63466,"avatar_url":"https://avatars.githubusercontent.com/u/63466?v=3","gravatar_id":"","url":"https://api.github.com/users/redbugz","html_url":"https://github.com/redbugz","followers_url":"https://api.github.com/users/redbugz/followers","following_url":"https://api.github.com/users/redbugz/following{/other_user}","gists_url":"https://api.github.com/users/redbugz/gists{/gist_id}","starred_url":"https://api.github.com/users/redbugz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redbugz/subscriptions","organizations_url":"https://api.github.com/users/redbugz/orgs","repos_url":"https://api.github.com/users/redbugz/repos","events_url":"https://api.github.com/users/redbugz/events{/privacy}","received_events_url":"https://api.github.com/users/redbugz/received_events","type":"User","site_admin":false},"milestone":null,"comments":6,"created_at":"2015-09-03T16:49:43Z","updated_at":"2015-09-18T17:59:32Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fs-webdev/experiment/pulls/11","html_url":"https://github.com/fs-webdev/experiment/pull/11","diff_url":"https://github.com/fs-webdev/experiment/pull/11.diff","patch_url":"https://github.com/fs-webdev/experiment/pull/11.patch"},"body":"There were old functions commented out that normalized the ID to an integer. I uncommented those and sent the userId to the generate bucket function. \r\n\r\nI also uncommented the tests for normalizeId, though I never could get *any* of the tests to run even before adding these back in. \r\n\r\nThis will fix the bucket to the userId, which is sent in through in woodruff and snow's experiments middleware. When userId is null or is the wrong type, the old way is used as the fallback."},"comment":{"url":"https://api.github.com/repos/fs-webdev/experiment/issues/comments/141520509","html_url":"https://github.com/fs-webdev/experiment/pull/11#issuecomment-141520509","issue_url":"https://api.github.com/repos/fs-webdev/experiment/issues/11","id":141520509,"user":{"login":"rosemariesadler","id":11645238,"avatar_url":"https://avatars.githubusercontent.com/u/11645238?v=3","gravatar_id":"","url":"https://api.github.com/users/rosemariesadler","html_url":"https://github.com/rosemariesadler","followers_url":"https://api.github.com/users/rosemariesadler/followers","following_url":"https://api.github.com/users/rosemariesadler/following{/other_user}","gists_url":"https://api.github.com/users/rosemariesadler/gists{/gist_id}","starred_url":"https://api.github.com/users/rosemariesadler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosemariesadler/subscriptions","organizations_url":"https://api.github.com/users/rosemariesadler/orgs","repos_url":"https://api.github.com/users/rosemariesadler/repos","events_url":"https://api.github.com/users/rosemariesadler/events{/privacy}","received_events_url":"https://api.github.com/users/rosemariesadler/received_events","type":"User","site_admin":false},"created_at":"2015-09-18T17:59:32Z","updated_at":"2015-09-18T17:59:32Z","body":"I was told this morning that there was some uncertainty still about why they originally abandoned the hashing function. If you look at https://github.com/fs-webdev/experiment/commit/29d187dde9836c8da43eb85dacf7af990e406f8c, you can see that the normalize function stopped being used in favor of using session ids to calculate percentage buckets. They no longer needed to hash the userId in other places (adding users to groups) to keep things consistent, so they didn't. The functions got commented out in the next commit because nobody was using them anymore."}}