{"action":"opened","number":250,"pull_request":{"url":"https://api.github.com/repos/internetarchive/openlibrary/pulls/250","id":37344663,"html_url":"https://github.com/internetarchive/openlibrary/pull/250","diff_url":"https://github.com/internetarchive/openlibrary/pull/250.diff","patch_url":"https://github.com/internetarchive/openlibrary/pull/250.patch","issue_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/250","number":250,"state":"open","locked":false,"title":"Attempt to fix tests to allow Travis CI to pass","user":{"login":"hornc","id":905545,"avatar_url":"https://avatars.githubusercontent.com/u/905545?v=3","gravatar_id":"","url":"https://api.github.com/users/hornc","html_url":"https://github.com/hornc","followers_url":"https://api.github.com/users/hornc/followers","following_url":"https://api.github.com/users/hornc/following{/other_user}","gists_url":"https://api.github.com/users/hornc/gists{/gist_id}","starred_url":"https://api.github.com/users/hornc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hornc/subscriptions","organizations_url":"https://api.github.com/users/hornc/orgs","repos_url":"https://api.github.com/users/hornc/repos","events_url":"https://api.github.com/users/hornc/events{/privacy}","received_events_url":"https://api.github.com/users/hornc/received_events","type":"User","site_admin":false},"body":"I have just started playing with the Open Library codebase, and this is my attempt to get the tests passing on Travis after successfully setting up a vagrant dev instance.\r\n\r\nThis is started as an effort to solve issue https://github.com/internetarchive/openlibrary/issues/236\r\n\r\nI found 2 causes of failing tests:\r\n\r\n1. It looks like the waitinglists were moved from the local db to an external api here: https://github.com/internetarchive/openlibrary/commit/b2703037996d7947653caecd1337858aaf0823f7\r\nbut the tests were not updated to reflect this.\r\nThese waitinglist tests should either be removed or updated if this PR passes.\r\n\r\n2. The forms validate test was erroring with `AttributeError: 'site'` from \r\n```\r\n    def get_spam_domains():\r\n>       doc = web.ctx.site.store.get(\"spamwords\") or {}\r\n\r\nopenlibrary/plugins/upstream/spamcheck.py:8: \r\n```\r\nI patched the test to avoid making the request.\r\n\r\nI'm not sure if there is a further travis configuration problem with the tests, the history of failed PRs shows some that failed with the `fatal: Couldn't find remote ref refs/pull/249/merge` style errors, and others that failed on the test results. I'm hoping this PR might clear that up.\r\n\r\n","created_at":"2015-06-10T10:32:25Z","updated_at":"2015-06-10T10:32:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/internetarchive/openlibrary/pulls/250/commits","review_comments_url":"https://api.github.com/repos/internetarchive/openlibrary/pulls/250/comments","review_comment_url":"https://api.github.com/repos/internetarchive/openlibrary/pulls/comments{/number}","comments_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/250/comments","statuses_url":"https://api.github.com/repos/internetarchive/openlibrary/statuses/e215dadbe8cbfd3003eff88aad59d7b1d1335b29","head":{"label":"hornc:master","ref":"master","sha":"e215dadbe8cbfd3003eff88aad59d7b1d1335b29","user":{"login":"hornc","id":905545,"avatar_url":"https://avatars.githubusercontent.com/u/905545?v=3","gravatar_id":"","url":"https://api.github.com/users/hornc","html_url":"https://github.com/hornc","followers_url":"https://api.github.com/users/hornc/followers","following_url":"https://api.github.com/users/hornc/following{/other_user}","gists_url":"https://api.github.com/users/hornc/gists{/gist_id}","starred_url":"https://api.github.com/users/hornc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hornc/subscriptions","organizations_url":"https://api.github.com/users/hornc/orgs","repos_url":"https://api.github.com/users/hornc/repos","events_url":"https://api.github.com/users/hornc/events{/privacy}","received_events_url":"https://api.github.com/users/hornc/received_events","type":"User","site_admin":false},"repo":{"id":24747134,"name":"openlibrary-1","full_name":"hornc/openlibrary-1","owner":{"login":"hornc","id":905545,"avatar_url":"https://avatars.githubusercontent.com/u/905545?v=3","gravatar_id":"","url":"https://api.github.com/users/hornc","html_url":"https://github.com/hornc","followers_url":"https://api.github.com/users/hornc/followers","following_url":"https://api.github.com/users/hornc/following{/other_user}","gists_url":"https://api.github.com/users/hornc/gists{/gist_id}","starred_url":"https://api.github.com/users/hornc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hornc/subscriptions","organizations_url":"https://api.github.com/users/hornc/orgs","repos_url":"https://api.github.com/users/hornc/repos","events_url":"https://api.github.com/users/hornc/events{/privacy}","received_events_url":"https://api.github.com/users/hornc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hornc/openlibrary-1","description":"One webpage for every book ever published!","fork":true,"url":"https://api.github.com/repos/hornc/openlibrary-1","forks_url":"https://api.github.com/repos/hornc/openlibrary-1/forks","keys_url":"https://api.github.com/repos/hornc/openlibrary-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hornc/openlibrary-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hornc/openlibrary-1/teams","hooks_url":"https://api.github.com/repos/hornc/openlibrary-1/hooks","issue_events_url":"https://api.github.com/repos/hornc/openlibrary-1/issues/events{/number}","events_url":"https://api.github.com/repos/hornc/openlibrary-1/events","assignees_url":"https://api.github.com/repos/hornc/openlibrary-1/assignees{/user}","branches_url":"https://api.github.com/repos/hornc/openlibrary-1/branches{/branch}","tags_url":"https://api.github.com/repos/hornc/openlibrary-1/tags","blobs_url":"https://api.github.com/repos/hornc/openlibrary-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hornc/openlibrary-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hornc/openlibrary-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/hornc/openlibrary-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hornc/openlibrary-1/statuses/{sha}","languages_url":"https://api.github.com/repos/hornc/openlibrary-1/languages","stargazers_url":"https://api.github.com/repos/hornc/openlibrary-1/stargazers","contributors_url":"https://api.github.com/repos/hornc/openlibrary-1/contributors","subscribers_url":"https://api.github.com/repos/hornc/openlibrary-1/subscribers","subscription_url":"https://api.github.com/repos/hornc/openlibrary-1/subscription","commits_url":"https://api.github.com/repos/hornc/openlibrary-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/hornc/openlibrary-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/hornc/openlibrary-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/hornc/openlibrary-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/hornc/openlibrary-1/contents/{+path}","compare_url":"https://api.github.com/repos/hornc/openlibrary-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hornc/openlibrary-1/merges","archive_url":"https://api.github.com/repos/hornc/openlibrary-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hornc/openlibrary-1/downloads","issues_url":"https://api.github.com/repos/hornc/openlibrary-1/issues{/number}","pulls_url":"https://api.github.com/repos/hornc/openlibrary-1/pulls{/number}","milestones_url":"https://api.github.com/repos/hornc/openlibrary-1/milestones{/number}","notifications_url":"https://api.github.com/repos/hornc/openlibrary-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hornc/openlibrary-1/labels{/name}","releases_url":"https://api.github.com/repos/hornc/openlibrary-1/releases{/id}","created_at":"2014-10-03T04:49:32Z","updated_at":"2015-04-07T05:05:33Z","pushed_at":"2015-06-10T10:12:02Z","git_url":"git://github.com/hornc/openlibrary-1.git","ssh_url":"git@github.com:hornc/openlibrary-1.git","clone_url":"https://github.com/hornc/openlibrary-1.git","svn_url":"https://github.com/hornc/openlibrary-1","homepage":"http://openlibrary.org","size":38903,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"internetarchive:master","ref":"master","sha":"84474d21c807ab3e819384207745a776ecd6f6e4","user":{"login":"internetarchive","id":130493,"avatar_url":"https://avatars.githubusercontent.com/u/130493?v=3","gravatar_id":"","url":"https://api.github.com/users/internetarchive","html_url":"https://github.com/internetarchive","followers_url":"https://api.github.com/users/internetarchive/followers","following_url":"https://api.github.com/users/internetarchive/following{/other_user}","gists_url":"https://api.github.com/users/internetarchive/gists{/gist_id}","starred_url":"https://api.github.com/users/internetarchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/internetarchive/subscriptions","organizations_url":"https://api.github.com/users/internetarchive/orgs","repos_url":"https://api.github.com/users/internetarchive/repos","events_url":"https://api.github.com/users/internetarchive/events{/privacy}","received_events_url":"https://api.github.com/users/internetarchive/received_events","type":"Organization","site_admin":false},"repo":{"id":69609,"name":"openlibrary","full_name":"internetarchive/openlibrary","owner":{"login":"internetarchive","id":130493,"avatar_url":"https://avatars.githubusercontent.com/u/130493?v=3","gravatar_id":"","url":"https://api.github.com/users/internetarchive","html_url":"https://github.com/internetarchive","followers_url":"https://api.github.com/users/internetarchive/followers","following_url":"https://api.github.com/users/internetarchive/following{/other_user}","gists_url":"https://api.github.com/users/internetarchive/gists{/gist_id}","starred_url":"https://api.github.com/users/internetarchive/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/internetarchive/subscriptions","organizations_url":"https://api.github.com/users/internetarchive/orgs","repos_url":"https://api.github.com/users/internetarchive/repos","events_url":"https://api.github.com/users/internetarchive/events{/privacy}","received_events_url":"https://api.github.com/users/internetarchive/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/internetarchive/openlibrary","description":"One webpage for every book ever published!","fork":false,"url":"https://api.github.com/repos/internetarchive/openlibrary","forks_url":"https://api.github.com/repos/internetarchive/openlibrary/forks","keys_url":"https://api.github.com/repos/internetarchive/openlibrary/keys{/key_id}","collaborators_url":"https://api.github.com/repos/internetarchive/openlibrary/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/internetarchive/openlibrary/teams","hooks_url":"https://api.github.com/repos/internetarchive/openlibrary/hooks","issue_events_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/events{/number}","events_url":"https://api.github.com/repos/internetarchive/openlibrary/events","assignees_url":"https://api.github.com/repos/internetarchive/openlibrary/assignees{/user}","branches_url":"https://api.github.com/repos/internetarchive/openlibrary/branches{/branch}","tags_url":"https://api.github.com/repos/internetarchive/openlibrary/tags","blobs_url":"https://api.github.com/repos/internetarchive/openlibrary/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/internetarchive/openlibrary/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/internetarchive/openlibrary/git/refs{/sha}","trees_url":"https://api.github.com/repos/internetarchive/openlibrary/git/trees{/sha}","statuses_url":"https://api.github.com/repos/internetarchive/openlibrary/statuses/{sha}","languages_url":"https://api.github.com/repos/internetarchive/openlibrary/languages","stargazers_url":"https://api.github.com/repos/internetarchive/openlibrary/stargazers","contributors_url":"https://api.github.com/repos/internetarchive/openlibrary/contributors","subscribers_url":"https://api.github.com/repos/internetarchive/openlibrary/subscribers","subscription_url":"https://api.github.com/repos/internetarchive/openlibrary/subscription","commits_url":"https://api.github.com/repos/internetarchive/openlibrary/commits{/sha}","git_commits_url":"https://api.github.com/repos/internetarchive/openlibrary/git/commits{/sha}","comments_url":"https://api.github.com/repos/internetarchive/openlibrary/comments{/number}","issue_comment_url":"https://api.github.com/repos/internetarchive/openlibrary/issues/comments{/number}","contents_url":"https://api.github.com/repos/internetarchive/openlibrary/contents/{+path}","compare_url":"https://api.github.com/repos/internetarchive/openlibrary/compare/{base}...{head}","merges_url":"https://api.github.com/repos/internetarchive/openlibrary/merges","archive_url":"https://api.github.com/repos/internetarchive/openlibrary/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/internetarchive/openlibrary/downloads","issues_url":"https://api.github.com/repos/internetarchive/openlibrary/issues{/number}","pulls_url":"https://api.github.com/repos/internetarchive/openlibrary/pulls{/number}","milestones_url":"https://api.github.com/repos/internetarchive/openlibrary/milestones{/number}","notifications_url":"https://api.github.com/repos/internetarchive/openlibrary/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/internetarchive/openlibrary/labels{/name}","releases_url":"https://api.github.com/repos/internetarchive/openlibrary/releases{/id}","created_at":"2008-10-30T05:20:14Z","updated_at":"2015-06-08T21:37:54Z","pushed_at":"2015-06-10T10:32:25Z","git_url":"git://github.com/internetarchive/openlibrary.git","ssh_url":"git@github.com:internetarchive/openlibrary.git","clone_url":"https://github.com/internetarchive/openlibrary.git","svn_url":"https://github.com/internetarchive/openlibrary","homepage":"http://openlibrary.org","size":42649,"stargazers_count":203,"watchers_count":203,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"open_issues_count":110,"forks":65,"open_issues":110,"watchers":203,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/internetarchive/openlibrary/pulls/250"},"html":{"href":"https://github.com/internetarchive/openlibrary/pull/250"},"issue":{"href":"https://api.github.com/repos/internetarchive/openlibrary/issues/250"},"comments":{"href":"https://api.github.com/repos/internetarchive/openlibrary/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/internetarchive/openlibrary/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/internetarchive/openlibrary/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/internetarchive/openlibrary/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/internetarchive/openlibrary/statuses/e215dadbe8cbfd3003eff88aad59d7b1d1335b29"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":3,"additions":13,"deletions":9,"changed_files":3}}