{"action":"created","comment":{"url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/comments/35960958","id":35960958,"diff_hunk":"@@ -98,42 +98,42 @@\n   end\n \n   describe 'Default values' do\n-    it \"can work with default value\" do\n+    it 'can work with default value' do\n       Setting.defaults[:bar] = @bar\n-      Setting.bar.should == @bar\n+      expect(Setting.bar).to eq @bar\n     end\n \n-    it \"can use default value, when the setting it cached with nil value\" do\n+    it 'can use default value, when the setting it cached with nil value' do\n       Setting.has_cached_nil_key\n-      Setting.defaults[:has_cached_nil_key] = \"123\"\n-      Setting.has_cached_nil_key.should == \"123\"\n+      Setting.defaults[:has_cached_nil_key] = '123'\n+      expect(Setting.has_cached_nil_key).to eq '123'\n     end\n \n-    it \"#save_default\" do\n+    it '#save_default' do\n       Setting.test_save_default_key\n-      Setting.save_default(:test_save_default_key, \"321\")\n-      Setting.where(:var => \"test_save_default_key\").count.should == 1\n-      Setting.test_save_default_key.should == \"321\"\n-      Setting.save_default(:test_save_default_key, \"3211\")\n-      Setting.test_save_default_key.should == \"321\"\n+      Setting.save_default(:test_save_default_key, '321')\n+      expect(Setting.where(var: 'test_save_default_key').count).to eq 1\n+      expect(Setting.test_save_default_key).to eq '321'\n+      Setting.save_default(:test_save_default_key, '3211')\n+      expect(Setting.test_save_default_key).to eq '321'\n     end\n   end\n \n-  describe \"Implementation by embeds a Model\" do\n-    it \"can set values\" do\n+  describe 'Implementation by embeds a Model' do\n+    it 'can set values' do\n       @user.settings.level = 30\n       @user.settings.locked = true\n       @user.settings.last_logined_at = @tm\n       Setting.level = 20\n-      Setting.unscoped.where(:var => \"level\").count == 2\n-      Setting.where(:var => \"level\").count == 1\n-      Setting.where(:var => \"level\").first.value == 20\n+      expect(Setting.unscoped.where(var: 'level').count).to eq 2\n+      expect(Setting.where(var: 'level').count).to eq 1","path":"spec/rails-settings-cached/setting_spec.rb","position":100,"original_position":100,"commit_id":"c61d108f484bc1ce020c4cb9e3572f140df2560e","original_commit_id":"c61d108f484bc1ce020c4cb9e3572f140df2560e","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2015-07-31T10:00:04Z","updated_at":"2015-07-31T10:00:04Z","html_url":"https://github.com/huacnlee/rails-settings-cached/pull/62#discussion_r35960958","pull_request_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62","_links":{"self":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/comments/35960958"},"html":{"href":"https://github.com/huacnlee/rails-settings-cached/pull/62#discussion_r35960958"},"pull_request":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62","id":41324562,"html_url":"https://github.com/huacnlee/rails-settings-cached/pull/62","diff_url":"https://github.com/huacnlee/rails-settings-cached/pull/62.diff","patch_url":"https://github.com/huacnlee/rails-settings-cached/pull/62.patch","issue_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues/62","number":62,"state":"open","locked":false,"title":"integrate rubocop and fix his complains","user":{"login":"alexanderadam","id":372620,"avatar_url":"https://avatars.githubusercontent.com/u/372620?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderadam","html_url":"https://github.com/alexanderadam","followers_url":"https://api.github.com/users/alexanderadam/followers","following_url":"https://api.github.com/users/alexanderadam/following{/other_user}","gists_url":"https://api.github.com/users/alexanderadam/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderadam/subscriptions","organizations_url":"https://api.github.com/users/alexanderadam/orgs","repos_url":"https://api.github.com/users/alexanderadam/repos","events_url":"https://api.github.com/users/alexanderadam/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderadam/received_events","type":"User","site_admin":false},"body":"I fell in love with [rubocop](https://github.com/bbatsov/rubocop/) and think that every ruby project should use it.\r\nThis is my proposal.\r\n\r\nThank you for your work,\r\nAlex","created_at":"2015-07-31T09:59:57Z","updated_at":"2015-07-31T10:00:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c8d9a4b51e7f95c74da63d3f82a8fef6501f67b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62/commits","review_comments_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62/comments","review_comment_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/comments{/number}","comments_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues/62/comments","statuses_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/statuses/c61d108f484bc1ce020c4cb9e3572f140df2560e","head":{"label":"alexanderadam:integrate_rubocop_and_fix_his_complains","ref":"integrate_rubocop_and_fix_his_complains","sha":"c61d108f484bc1ce020c4cb9e3572f140df2560e","user":{"login":"alexanderadam","id":372620,"avatar_url":"https://avatars.githubusercontent.com/u/372620?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderadam","html_url":"https://github.com/alexanderadam","followers_url":"https://api.github.com/users/alexanderadam/followers","following_url":"https://api.github.com/users/alexanderadam/following{/other_user}","gists_url":"https://api.github.com/users/alexanderadam/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderadam/subscriptions","organizations_url":"https://api.github.com/users/alexanderadam/orgs","repos_url":"https://api.github.com/users/alexanderadam/repos","events_url":"https://api.github.com/users/alexanderadam/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderadam/received_events","type":"User","site_admin":false},"repo":{"id":39996222,"name":"rails-settings-cached","full_name":"alexanderadam/rails-settings-cached","owner":{"login":"alexanderadam","id":372620,"avatar_url":"https://avatars.githubusercontent.com/u/372620?v=3","gravatar_id":"","url":"https://api.github.com/users/alexanderadam","html_url":"https://github.com/alexanderadam","followers_url":"https://api.github.com/users/alexanderadam/followers","following_url":"https://api.github.com/users/alexanderadam/following{/other_user}","gists_url":"https://api.github.com/users/alexanderadam/gists{/gist_id}","starred_url":"https://api.github.com/users/alexanderadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexanderadam/subscriptions","organizations_url":"https://api.github.com/users/alexanderadam/orgs","repos_url":"https://api.github.com/users/alexanderadam/repos","events_url":"https://api.github.com/users/alexanderadam/events{/privacy}","received_events_url":"https://api.github.com/users/alexanderadam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexanderadam/rails-settings-cached","description":"This is improved from rails-settings, added caching for all settings","fork":true,"url":"https://api.github.com/repos/alexanderadam/rails-settings-cached","forks_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/forks","keys_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/teams","hooks_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/hooks","issue_events_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/issues/events{/number}","events_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/events","assignees_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/assignees{/user}","branches_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/branches{/branch}","tags_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/tags","blobs_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/statuses/{sha}","languages_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/languages","stargazers_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/stargazers","contributors_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/contributors","subscribers_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/subscribers","subscription_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/subscription","commits_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/contents/{+path}","compare_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/merges","archive_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/downloads","issues_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/issues{/number}","pulls_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/pulls{/number}","milestones_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/milestones{/number}","notifications_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/labels{/name}","releases_url":"https://api.github.com/repos/alexanderadam/rails-settings-cached/releases{/id}","created_at":"2015-07-31T08:52:27Z","updated_at":"2015-07-31T09:58:16Z","pushed_at":"2015-07-31T09:57:47Z","git_url":"git://github.com/alexanderadam/rails-settings-cached.git","ssh_url":"git@github.com:alexanderadam/rails-settings-cached.git","clone_url":"https://github.com/alexanderadam/rails-settings-cached.git","svn_url":"https://github.com/alexanderadam/rails-settings-cached","homepage":"http://huacnlee.com/rails-settings-cached/","size":494,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"huacnlee:master","ref":"master","sha":"6daf59e961713043578a18f95989ef43a7d568cf","user":{"login":"huacnlee","id":5518,"avatar_url":"https://avatars.githubusercontent.com/u/5518?v=3","gravatar_id":"","url":"https://api.github.com/users/huacnlee","html_url":"https://github.com/huacnlee","followers_url":"https://api.github.com/users/huacnlee/followers","following_url":"https://api.github.com/users/huacnlee/following{/other_user}","gists_url":"https://api.github.com/users/huacnlee/gists{/gist_id}","starred_url":"https://api.github.com/users/huacnlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huacnlee/subscriptions","organizations_url":"https://api.github.com/users/huacnlee/orgs","repos_url":"https://api.github.com/users/huacnlee/repos","events_url":"https://api.github.com/users/huacnlee/events{/privacy}","received_events_url":"https://api.github.com/users/huacnlee/received_events","type":"User","site_admin":false},"repo":{"id":1274040,"name":"rails-settings-cached","full_name":"huacnlee/rails-settings-cached","owner":{"login":"huacnlee","id":5518,"avatar_url":"https://avatars.githubusercontent.com/u/5518?v=3","gravatar_id":"","url":"https://api.github.com/users/huacnlee","html_url":"https://github.com/huacnlee","followers_url":"https://api.github.com/users/huacnlee/followers","following_url":"https://api.github.com/users/huacnlee/following{/other_user}","gists_url":"https://api.github.com/users/huacnlee/gists{/gist_id}","starred_url":"https://api.github.com/users/huacnlee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huacnlee/subscriptions","organizations_url":"https://api.github.com/users/huacnlee/orgs","repos_url":"https://api.github.com/users/huacnlee/repos","events_url":"https://api.github.com/users/huacnlee/events{/privacy}","received_events_url":"https://api.github.com/users/huacnlee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/huacnlee/rails-settings-cached","description":"This is imporved from rails-settings, added caching for all settings","fork":true,"url":"https://api.github.com/repos/huacnlee/rails-settings-cached","forks_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/forks","keys_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/keys{/key_id}","collaborators_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/teams","hooks_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/hooks","issue_events_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues/events{/number}","events_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/events","assignees_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/assignees{/user}","branches_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/branches{/branch}","tags_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/tags","blobs_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/git/refs{/sha}","trees_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/git/trees{/sha}","statuses_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/statuses/{sha}","languages_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/languages","stargazers_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/stargazers","contributors_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/contributors","subscribers_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/subscribers","subscription_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/subscription","commits_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/commits{/sha}","git_commits_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/git/commits{/sha}","comments_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/comments{/number}","issue_comment_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues/comments{/number}","contents_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/contents/{+path}","compare_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/compare/{base}...{head}","merges_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/merges","archive_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/downloads","issues_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues{/number}","pulls_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls{/number}","milestones_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/milestones{/number}","notifications_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/labels{/name}","releases_url":"https://api.github.com/repos/huacnlee/rails-settings-cached/releases{/id}","created_at":"2011-01-20T08:41:50Z","updated_at":"2015-07-30T20:28:14Z","pushed_at":"2015-07-31T09:59:59Z","git_url":"git://github.com/huacnlee/rails-settings-cached.git","ssh_url":"git@github.com:huacnlee/rails-settings-cached.git","clone_url":"https://github.com/huacnlee/rails-settings-cached.git","svn_url":"https://github.com/huacnlee/rails-settings-cached","homepage":"http://huacnlee.com/rails-settings-cached/","size":494,"stargazers_count":363,"watchers_count":363,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":28,"forks":71,"open_issues":28,"watchers":363,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62"},"html":{"href":"https://github.com/huacnlee/rails-settings-cached/pull/62"},"issue":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues/62"},"comments":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/huacnlee/rails-settings-cached/statuses/c61d108f484bc1ce020c4cb9e3572f140df2560e"}}}}