{"action":"closed","number":458,"pull_request":{"url":"https://api.github.com/repos/rebar/rebar/pulls/458","id":29748371,"html_url":"https://github.com/rebar/rebar/pull/458","diff_url":"https://github.com/rebar/rebar/pull/458.diff","patch_url":"https://github.com/rebar/rebar/pull/458.patch","issue_url":"https://api.github.com/repos/rebar/rebar/issues/458","number":458,"state":"closed","locked":false,"title":"Change env var delimiter to match non-word","user":{"login":"manderson26","id":253389,"avatar_url":"https://avatars.githubusercontent.com/u/253389?v=3","gravatar_id":"","url":"https://api.github.com/users/manderson26","html_url":"https://github.com/manderson26","followers_url":"https://api.github.com/users/manderson26/followers","following_url":"https://api.github.com/users/manderson26/following{/other_user}","gists_url":"https://api.github.com/users/manderson26/gists{/gist_id}","starred_url":"https://api.github.com/users/manderson26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manderson26/subscriptions","organizations_url":"https://api.github.com/users/manderson26/orgs","repos_url":"https://api.github.com/users/manderson26/repos","events_url":"https://api.github.com/users/manderson26/events{/privacy}","received_events_url":"https://api.github.com/users/manderson26/received_events","type":"User","site_admin":false},"body":"If I pass an expression like: \"$PWD/deps/local/lib\" in the port env\r\nstring, it expands to \"/deps/local/lib\", (variable is expanded to the\r\nempty string) but if I pass \"${PWD}/deps/local/lib\" it expands\r\nproperly. I found that confusing.\r\n\r\nThis was because we require environment vars to end with whitespace,\r\nwhile I think requiring a non-word character would be sufficient, since\r\nthe variables can only contain word characters.\r\n\r\nThis changes the expansion system to recognize variables that are\r\nterminated by non word characters.\r\n\r\nFixes rebar/rebar#457","created_at":"2015-02-21T03:58:57Z","updated_at":"2015-02-25T19:22:26Z","closed_at":"2015-02-25T19:22:26Z","merged_at":"2015-02-25T19:22:26Z","merge_commit_sha":"9c2d4b79523187e1e8ccee7f2586a09258a657e7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rebar/rebar/pulls/458/commits","review_comments_url":"https://api.github.com/repos/rebar/rebar/pulls/458/comments","review_comment_url":"https://api.github.com/repos/rebar/rebar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rebar/rebar/issues/458/comments","statuses_url":"https://api.github.com/repos/rebar/rebar/statuses/e211afdce6ae1f1265bc2388e5bd5171cb822d98","head":{"label":"manderson26:ma/improve_variable_expansion","ref":"ma/improve_variable_expansion","sha":"e211afdce6ae1f1265bc2388e5bd5171cb822d98","user":{"login":"manderson26","id":253389,"avatar_url":"https://avatars.githubusercontent.com/u/253389?v=3","gravatar_id":"","url":"https://api.github.com/users/manderson26","html_url":"https://github.com/manderson26","followers_url":"https://api.github.com/users/manderson26/followers","following_url":"https://api.github.com/users/manderson26/following{/other_user}","gists_url":"https://api.github.com/users/manderson26/gists{/gist_id}","starred_url":"https://api.github.com/users/manderson26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manderson26/subscriptions","organizations_url":"https://api.github.com/users/manderson26/orgs","repos_url":"https://api.github.com/users/manderson26/repos","events_url":"https://api.github.com/users/manderson26/events{/privacy}","received_events_url":"https://api.github.com/users/manderson26/received_events","type":"User","site_admin":false},"repo":{"id":31033548,"name":"rebar","full_name":"manderson26/rebar","owner":{"login":"manderson26","id":253389,"avatar_url":"https://avatars.githubusercontent.com/u/253389?v=3","gravatar_id":"","url":"https://api.github.com/users/manderson26","html_url":"https://github.com/manderson26","followers_url":"https://api.github.com/users/manderson26/followers","following_url":"https://api.github.com/users/manderson26/following{/other_user}","gists_url":"https://api.github.com/users/manderson26/gists{/gist_id}","starred_url":"https://api.github.com/users/manderson26/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manderson26/subscriptions","organizations_url":"https://api.github.com/users/manderson26/orgs","repos_url":"https://api.github.com/users/manderson26/repos","events_url":"https://api.github.com/users/manderson26/events{/privacy}","received_events_url":"https://api.github.com/users/manderson26/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manderson26/rebar","description":"Erlang build tool that makes it easy to compile and test Erlang applications, port drivers and releases.","fork":true,"url":"https://api.github.com/repos/manderson26/rebar","forks_url":"https://api.github.com/repos/manderson26/rebar/forks","keys_url":"https://api.github.com/repos/manderson26/rebar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manderson26/rebar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manderson26/rebar/teams","hooks_url":"https://api.github.com/repos/manderson26/rebar/hooks","issue_events_url":"https://api.github.com/repos/manderson26/rebar/issues/events{/number}","events_url":"https://api.github.com/repos/manderson26/rebar/events","assignees_url":"https://api.github.com/repos/manderson26/rebar/assignees{/user}","branches_url":"https://api.github.com/repos/manderson26/rebar/branches{/branch}","tags_url":"https://api.github.com/repos/manderson26/rebar/tags","blobs_url":"https://api.github.com/repos/manderson26/rebar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manderson26/rebar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manderson26/rebar/git/refs{/sha}","trees_url":"https://api.github.com/repos/manderson26/rebar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manderson26/rebar/statuses/{sha}","languages_url":"https://api.github.com/repos/manderson26/rebar/languages","stargazers_url":"https://api.github.com/repos/manderson26/rebar/stargazers","contributors_url":"https://api.github.com/repos/manderson26/rebar/contributors","subscribers_url":"https://api.github.com/repos/manderson26/rebar/subscribers","subscription_url":"https://api.github.com/repos/manderson26/rebar/subscription","commits_url":"https://api.github.com/repos/manderson26/rebar/commits{/sha}","git_commits_url":"https://api.github.com/repos/manderson26/rebar/git/commits{/sha}","comments_url":"https://api.github.com/repos/manderson26/rebar/comments{/number}","issue_comment_url":"https://api.github.com/repos/manderson26/rebar/issues/comments{/number}","contents_url":"https://api.github.com/repos/manderson26/rebar/contents/{+path}","compare_url":"https://api.github.com/repos/manderson26/rebar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manderson26/rebar/merges","archive_url":"https://api.github.com/repos/manderson26/rebar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manderson26/rebar/downloads","issues_url":"https://api.github.com/repos/manderson26/rebar/issues{/number}","pulls_url":"https://api.github.com/repos/manderson26/rebar/pulls{/number}","milestones_url":"https://api.github.com/repos/manderson26/rebar/milestones{/number}","notifications_url":"https://api.github.com/repos/manderson26/rebar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manderson26/rebar/labels{/name}","releases_url":"https://api.github.com/repos/manderson26/rebar/releases{/id}","created_at":"2015-02-19T19:50:35Z","updated_at":"2015-02-19T19:50:35Z","pushed_at":"2015-02-24T03:12:59Z","git_url":"git://github.com/manderson26/rebar.git","ssh_url":"git@github.com:manderson26/rebar.git","clone_url":"https://github.com/manderson26/rebar.git","svn_url":"https://github.com/manderson26/rebar","homepage":null,"size":3086,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rebar:master","ref":"master","sha":"f56268383a0c39fefa89c46e95925fb5f2eb238a","user":{"login":"rebar","id":2651508,"avatar_url":"https://avatars.githubusercontent.com/u/2651508?v=3","gravatar_id":"","url":"https://api.github.com/users/rebar","html_url":"https://github.com/rebar","followers_url":"https://api.github.com/users/rebar/followers","following_url":"https://api.github.com/users/rebar/following{/other_user}","gists_url":"https://api.github.com/users/rebar/gists{/gist_id}","starred_url":"https://api.github.com/users/rebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebar/subscriptions","organizations_url":"https://api.github.com/users/rebar/orgs","repos_url":"https://api.github.com/users/rebar/repos","events_url":"https://api.github.com/users/rebar/events{/privacy}","received_events_url":"https://api.github.com/users/rebar/received_events","type":"Organization","site_admin":false},"repo":{"id":6393199,"name":"rebar","full_name":"rebar/rebar","owner":{"login":"rebar","id":2651508,"avatar_url":"https://avatars.githubusercontent.com/u/2651508?v=3","gravatar_id":"","url":"https://api.github.com/users/rebar","html_url":"https://github.com/rebar","followers_url":"https://api.github.com/users/rebar/followers","following_url":"https://api.github.com/users/rebar/following{/other_user}","gists_url":"https://api.github.com/users/rebar/gists{/gist_id}","starred_url":"https://api.github.com/users/rebar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebar/subscriptions","organizations_url":"https://api.github.com/users/rebar/orgs","repos_url":"https://api.github.com/users/rebar/repos","events_url":"https://api.github.com/users/rebar/events{/privacy}","received_events_url":"https://api.github.com/users/rebar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rebar/rebar","description":"Erlang build tool that makes it easy to compile and test Erlang applications, port drivers and releases.","fork":false,"url":"https://api.github.com/repos/rebar/rebar","forks_url":"https://api.github.com/repos/rebar/rebar/forks","keys_url":"https://api.github.com/repos/rebar/rebar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rebar/rebar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rebar/rebar/teams","hooks_url":"https://api.github.com/repos/rebar/rebar/hooks","issue_events_url":"https://api.github.com/repos/rebar/rebar/issues/events{/number}","events_url":"https://api.github.com/repos/rebar/rebar/events","assignees_url":"https://api.github.com/repos/rebar/rebar/assignees{/user}","branches_url":"https://api.github.com/repos/rebar/rebar/branches{/branch}","tags_url":"https://api.github.com/repos/rebar/rebar/tags","blobs_url":"https://api.github.com/repos/rebar/rebar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rebar/rebar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rebar/rebar/git/refs{/sha}","trees_url":"https://api.github.com/repos/rebar/rebar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rebar/rebar/statuses/{sha}","languages_url":"https://api.github.com/repos/rebar/rebar/languages","stargazers_url":"https://api.github.com/repos/rebar/rebar/stargazers","contributors_url":"https://api.github.com/repos/rebar/rebar/contributors","subscribers_url":"https://api.github.com/repos/rebar/rebar/subscribers","subscription_url":"https://api.github.com/repos/rebar/rebar/subscription","commits_url":"https://api.github.com/repos/rebar/rebar/commits{/sha}","git_commits_url":"https://api.github.com/repos/rebar/rebar/git/commits{/sha}","comments_url":"https://api.github.com/repos/rebar/rebar/comments{/number}","issue_comment_url":"https://api.github.com/repos/rebar/rebar/issues/comments{/number}","contents_url":"https://api.github.com/repos/rebar/rebar/contents/{+path}","compare_url":"https://api.github.com/repos/rebar/rebar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rebar/rebar/merges","archive_url":"https://api.github.com/repos/rebar/rebar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rebar/rebar/downloads","issues_url":"https://api.github.com/repos/rebar/rebar/issues{/number}","pulls_url":"https://api.github.com/repos/rebar/rebar/pulls{/number}","milestones_url":"https://api.github.com/repos/rebar/rebar/milestones{/number}","notifications_url":"https://api.github.com/repos/rebar/rebar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rebar/rebar/labels{/name}","releases_url":"https://api.github.com/repos/rebar/rebar/releases{/id}","created_at":"2012-10-25T19:30:45Z","updated_at":"2015-02-25T15:28:02Z","pushed_at":"2015-02-25T19:22:26Z","git_url":"git://github.com/rebar/rebar.git","ssh_url":"git@github.com:rebar/rebar.git","clone_url":"https://github.com/rebar/rebar.git","svn_url":"https://github.com/rebar/rebar","homepage":null,"size":8264,"stargazers_count":567,"watchers_count":567,"language":"Erlang","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":199,"mirror_url":null,"open_issues_count":92,"forks":199,"open_issues":92,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rebar/rebar/pulls/458"},"html":{"href":"https://github.com/rebar/rebar/pull/458"},"issue":{"href":"https://api.github.com/repos/rebar/rebar/issues/458"},"comments":{"href":"https://api.github.com/repos/rebar/rebar/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/rebar/rebar/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/rebar/rebar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rebar/rebar/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/rebar/rebar/statuses/e211afdce6ae1f1265bc2388e5bd5171cb822d98"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ferd","id":111141,"avatar_url":"https://avatars.githubusercontent.com/u/111141?v=3","gravatar_id":"","url":"https://api.github.com/users/ferd","html_url":"https://github.com/ferd","followers_url":"https://api.github.com/users/ferd/followers","following_url":"https://api.github.com/users/ferd/following{/other_user}","gists_url":"https://api.github.com/users/ferd/gists{/gist_id}","starred_url":"https://api.github.com/users/ferd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferd/subscriptions","organizations_url":"https://api.github.com/users/ferd/orgs","repos_url":"https://api.github.com/users/ferd/repos","events_url":"https://api.github.com/users/ferd/events{/privacy}","received_events_url":"https://api.github.com/users/ferd/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"commits":1,"additions":53,"deletions":2,"changed_files":3}}