{"action":"opened","number":247,"pull_request":{"url":"https://api.github.com/repos/facebook/folly/pulls/247","id":40733515,"html_url":"https://github.com/facebook/folly/pull/247","diff_url":"https://github.com/facebook/folly/pull/247.diff","patch_url":"https://github.com/facebook/folly/pull/247.patch","issue_url":"https://api.github.com/repos/facebook/folly/issues/247","number":247,"state":"open","locked":false,"title":"Adjust Format-inl.h to work with MSVC","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"body":"This adjusts a format string to be sane, I don't think `'` is a valid format specifier to begin with, and MSVC2015 added a warning for invalid specifiers, which this triggers.\r\nThis also adjusts a use of `std::enable_if` to eliminate the `enable_if` entirely, because MSVC doesn't like it when you try to do a sizeof check on a type like this. (I haven't checked, but I wouldn't be surprised if MSVC were just returning `-1` for the size here, either way, the new way it's written should still have the desired effect)","created_at":"2015-07-24T00:46:59Z","updated_at":"2015-07-24T00:46:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/facebook/folly/pulls/247/commits","review_comments_url":"https://api.github.com/repos/facebook/folly/pulls/247/comments","review_comment_url":"https://api.github.com/repos/facebook/folly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/folly/issues/247/comments","statuses_url":"https://api.github.com/repos/facebook/folly/statuses/ab2c7d28d926b7419d5ca3376a96aa583e68d95e","head":{"label":"Orvid:msvc-format-inl-format-sfinae","ref":"msvc-format-inl-format-sfinae","sha":"ab2c7d28d926b7419d5ca3376a96aa583e68d95e","user":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"repo":{"id":36701771,"name":"folly","full_name":"Orvid/folly","owner":{"login":"Orvid","id":709247,"avatar_url":"https://avatars.githubusercontent.com/u/709247?v=3","gravatar_id":"","url":"https://api.github.com/users/Orvid","html_url":"https://github.com/Orvid","followers_url":"https://api.github.com/users/Orvid/followers","following_url":"https://api.github.com/users/Orvid/following{/other_user}","gists_url":"https://api.github.com/users/Orvid/gists{/gist_id}","starred_url":"https://api.github.com/users/Orvid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Orvid/subscriptions","organizations_url":"https://api.github.com/users/Orvid/orgs","repos_url":"https://api.github.com/users/Orvid/repos","events_url":"https://api.github.com/users/Orvid/events{/privacy}","received_events_url":"https://api.github.com/users/Orvid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Orvid/folly","description":"An open-source C++ library developed and used at Facebook.","fork":true,"url":"https://api.github.com/repos/Orvid/folly","forks_url":"https://api.github.com/repos/Orvid/folly/forks","keys_url":"https://api.github.com/repos/Orvid/folly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Orvid/folly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Orvid/folly/teams","hooks_url":"https://api.github.com/repos/Orvid/folly/hooks","issue_events_url":"https://api.github.com/repos/Orvid/folly/issues/events{/number}","events_url":"https://api.github.com/repos/Orvid/folly/events","assignees_url":"https://api.github.com/repos/Orvid/folly/assignees{/user}","branches_url":"https://api.github.com/repos/Orvid/folly/branches{/branch}","tags_url":"https://api.github.com/repos/Orvid/folly/tags","blobs_url":"https://api.github.com/repos/Orvid/folly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Orvid/folly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Orvid/folly/git/refs{/sha}","trees_url":"https://api.github.com/repos/Orvid/folly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Orvid/folly/statuses/{sha}","languages_url":"https://api.github.com/repos/Orvid/folly/languages","stargazers_url":"https://api.github.com/repos/Orvid/folly/stargazers","contributors_url":"https://api.github.com/repos/Orvid/folly/contributors","subscribers_url":"https://api.github.com/repos/Orvid/folly/subscribers","subscription_url":"https://api.github.com/repos/Orvid/folly/subscription","commits_url":"https://api.github.com/repos/Orvid/folly/commits{/sha}","git_commits_url":"https://api.github.com/repos/Orvid/folly/git/commits{/sha}","comments_url":"https://api.github.com/repos/Orvid/folly/comments{/number}","issue_comment_url":"https://api.github.com/repos/Orvid/folly/issues/comments{/number}","contents_url":"https://api.github.com/repos/Orvid/folly/contents/{+path}","compare_url":"https://api.github.com/repos/Orvid/folly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Orvid/folly/merges","archive_url":"https://api.github.com/repos/Orvid/folly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Orvid/folly/downloads","issues_url":"https://api.github.com/repos/Orvid/folly/issues{/number}","pulls_url":"https://api.github.com/repos/Orvid/folly/pulls{/number}","milestones_url":"https://api.github.com/repos/Orvid/folly/milestones{/number}","notifications_url":"https://api.github.com/repos/Orvid/folly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Orvid/folly/labels{/name}","releases_url":"https://api.github.com/repos/Orvid/folly/releases{/id}","created_at":"2015-06-02T02:10:56Z","updated_at":"2015-06-02T02:10:59Z","pushed_at":"2015-07-24T00:46:26Z","git_url":"git://github.com/Orvid/folly.git","ssh_url":"git@github.com:Orvid/folly.git","clone_url":"https://github.com/Orvid/folly.git","svn_url":"https://github.com/Orvid/folly","homepage":"https://groups.google.com/forum/?fromgroups#!forum/facebook-folly","size":6586,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"5532f19f7b604a9b12c79a1d0a4fe3b0ff74f3d1","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":4524181,"name":"folly","full_name":"facebook/folly","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars.githubusercontent.com/u/69631?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/folly","description":"An open-source C++ library developed and used at Facebook.","fork":false,"url":"https://api.github.com/repos/facebook/folly","forks_url":"https://api.github.com/repos/facebook/folly/forks","keys_url":"https://api.github.com/repos/facebook/folly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/folly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/folly/teams","hooks_url":"https://api.github.com/repos/facebook/folly/hooks","issue_events_url":"https://api.github.com/repos/facebook/folly/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/folly/events","assignees_url":"https://api.github.com/repos/facebook/folly/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/folly/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/folly/tags","blobs_url":"https://api.github.com/repos/facebook/folly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/folly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/folly/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/folly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/folly/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/folly/languages","stargazers_url":"https://api.github.com/repos/facebook/folly/stargazers","contributors_url":"https://api.github.com/repos/facebook/folly/contributors","subscribers_url":"https://api.github.com/repos/facebook/folly/subscribers","subscription_url":"https://api.github.com/repos/facebook/folly/subscription","commits_url":"https://api.github.com/repos/facebook/folly/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/folly/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/folly/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/folly/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/folly/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/folly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/folly/merges","archive_url":"https://api.github.com/repos/facebook/folly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/folly/downloads","issues_url":"https://api.github.com/repos/facebook/folly/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/folly/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/folly/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/folly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/folly/labels{/name}","releases_url":"https://api.github.com/repos/facebook/folly/releases{/id}","created_at":"2012-06-01T20:49:04Z","updated_at":"2015-07-23T19:19:57Z","pushed_at":"2015-07-24T00:42:31Z","git_url":"git://github.com/facebook/folly.git","ssh_url":"git@github.com:facebook/folly.git","clone_url":"https://github.com/facebook/folly.git","svn_url":"https://github.com/facebook/folly","homepage":"https://groups.google.com/forum/?fromgroups#!forum/facebook-folly","size":9462,"stargazers_count":5097,"watchers_count":5097,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1109,"mirror_url":null,"open_issues_count":26,"forks":1109,"open_issues":26,"watchers":5097,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/folly/pulls/247"},"html":{"href":"https://github.com/facebook/folly/pull/247"},"issue":{"href":"https://api.github.com/repos/facebook/folly/issues/247"},"comments":{"href":"https://api.github.com/repos/facebook/folly/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/folly/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/folly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/folly/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/folly/statuses/ab2c7d28d926b7419d5ca3376a96aa583e68d95e"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":2,"deletions":4,"changed_files":1}}