{"action":"created","comment":{"url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/comments/32787498","id":32787498,"diff_hunk":"@@ -0,0 +1,44 @@\n+require 'rails_helper'\n+\n+RSpec.feature \"UserLogin\", type: :feature do\n+\n+  describe \"A user\" do\n+    let(:user)         { create :user }\n+    let(:invalid_user) { build :invalid_user }","path":"spec/features/user_login_spec.rb","position":7,"original_position":7,"commit_id":"6bf92d421f6ce402b5d06d4bfbdfe958edfd0a7e","original_commit_id":"6bf92d421f6ce402b5d06d4bfbdfe958edfd0a7e","user":{"login":"mackermedia","id":711125,"avatar_url":"https://avatars.githubusercontent.com/u/711125?v=3","gravatar_id":"","url":"https://api.github.com/users/mackermedia","html_url":"https://github.com/mackermedia","followers_url":"https://api.github.com/users/mackermedia/followers","following_url":"https://api.github.com/users/mackermedia/following{/other_user}","gists_url":"https://api.github.com/users/mackermedia/gists{/gist_id}","starred_url":"https://api.github.com/users/mackermedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mackermedia/subscriptions","organizations_url":"https://api.github.com/users/mackermedia/orgs","repos_url":"https://api.github.com/users/mackermedia/repos","events_url":"https://api.github.com/users/mackermedia/events{/privacy}","received_events_url":"https://api.github.com/users/mackermedia/received_events","type":"User","site_admin":false},"body":"`:invalid_user` must be some other defined factory? Also minor nitpick: I kinda like to see the test setup in the same file so you could do something like: `let(:invalid_user) { build(:user, email: \"asdf\", password: \"\") }`. You could also move that into the context of `submitting invalid credentials`. No super strong feels so up to you!","created_at":"2015-06-18T22:55:18Z","updated_at":"2015-06-18T22:55:18Z","html_url":"https://github.com/connorlay/hacker-news-clone/pull/18#discussion_r32787498","pull_request_url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18","_links":{"self":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/comments/32787498"},"html":{"href":"https://github.com/connorlay/hacker-news-clone/pull/18#discussion_r32787498"},"pull_request":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18","id":38060877,"html_url":"https://github.com/connorlay/hacker-news-clone/pull/18","diff_url":"https://github.com/connorlay/hacker-news-clone/pull/18.diff","patch_url":"https://github.com/connorlay/hacker-news-clone/pull/18.patch","issue_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/18","number":18,"state":"open","locked":false,"title":"Authentication","user":{"login":"connorlay","id":6548350,"avatar_url":"https://avatars.githubusercontent.com/u/6548350?v=3","gravatar_id":"","url":"https://api.github.com/users/connorlay","html_url":"https://github.com/connorlay","followers_url":"https://api.github.com/users/connorlay/followers","following_url":"https://api.github.com/users/connorlay/following{/other_user}","gists_url":"https://api.github.com/users/connorlay/gists{/gist_id}","starred_url":"https://api.github.com/users/connorlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorlay/subscriptions","organizations_url":"https://api.github.com/users/connorlay/orgs","repos_url":"https://api.github.com/users/connorlay/repos","events_url":"https://api.github.com/users/connorlay/events{/privacy}","received_events_url":"https://api.github.com/users/connorlay/received_events","type":"User","site_admin":false},"body":"resolves #2 \r\n\r\nUsers can log in, view their own profile, and log out. Users who are not in the database are notified of an invalid email/password combination.\r\n\r\n![log in, profile, log out](https://cloud.githubusercontent.com/assets/6548350/8243826/e87ea1be-15d7-11e5-95e8-563380c5d289.gif)\r\n\r\n![invalid login attempt](https://cloud.githubusercontent.com/assets/6548350/8243859/3ad25dfc-15d8-11e5-8033-ec2d13ce330a.gif)\r\n\r\n","created_at":"2015-06-18T22:39:05Z","updated_at":"2015-06-18T22:55:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d3904715b7323e5a409cbca3b149a57e7bf6e13","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18/commits","review_comments_url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18/comments","review_comment_url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/comments{/number}","comments_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/18/comments","statuses_url":"https://api.github.com/repos/connorlay/hacker-news-clone/statuses/6bf92d421f6ce402b5d06d4bfbdfe958edfd0a7e","head":{"label":"connorlay:authentication","ref":"authentication","sha":"6bf92d421f6ce402b5d06d4bfbdfe958edfd0a7e","user":{"login":"connorlay","id":6548350,"avatar_url":"https://avatars.githubusercontent.com/u/6548350?v=3","gravatar_id":"","url":"https://api.github.com/users/connorlay","html_url":"https://github.com/connorlay","followers_url":"https://api.github.com/users/connorlay/followers","following_url":"https://api.github.com/users/connorlay/following{/other_user}","gists_url":"https://api.github.com/users/connorlay/gists{/gist_id}","starred_url":"https://api.github.com/users/connorlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorlay/subscriptions","organizations_url":"https://api.github.com/users/connorlay/orgs","repos_url":"https://api.github.com/users/connorlay/repos","events_url":"https://api.github.com/users/connorlay/events{/privacy}","received_events_url":"https://api.github.com/users/connorlay/received_events","type":"User","site_admin":false},"repo":{"id":37540166,"name":"hacker-news-clone","full_name":"connorlay/hacker-news-clone","owner":{"login":"connorlay","id":6548350,"avatar_url":"https://avatars.githubusercontent.com/u/6548350?v=3","gravatar_id":"","url":"https://api.github.com/users/connorlay","html_url":"https://github.com/connorlay","followers_url":"https://api.github.com/users/connorlay/followers","following_url":"https://api.github.com/users/connorlay/following{/other_user}","gists_url":"https://api.github.com/users/connorlay/gists{/gist_id}","starred_url":"https://api.github.com/users/connorlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorlay/subscriptions","organizations_url":"https://api.github.com/users/connorlay/orgs","repos_url":"https://api.github.com/users/connorlay/repos","events_url":"https://api.github.com/users/connorlay/events{/privacy}","received_events_url":"https://api.github.com/users/connorlay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/connorlay/hacker-news-clone","description":"A clone of Hacker News with minimal dependencies created for my summer 2015 internship at Viget.","fork":false,"url":"https://api.github.com/repos/connorlay/hacker-news-clone","forks_url":"https://api.github.com/repos/connorlay/hacker-news-clone/forks","keys_url":"https://api.github.com/repos/connorlay/hacker-news-clone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connorlay/hacker-news-clone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connorlay/hacker-news-clone/teams","hooks_url":"https://api.github.com/repos/connorlay/hacker-news-clone/hooks","issue_events_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/events{/number}","events_url":"https://api.github.com/repos/connorlay/hacker-news-clone/events","assignees_url":"https://api.github.com/repos/connorlay/hacker-news-clone/assignees{/user}","branches_url":"https://api.github.com/repos/connorlay/hacker-news-clone/branches{/branch}","tags_url":"https://api.github.com/repos/connorlay/hacker-news-clone/tags","blobs_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/refs{/sha}","trees_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connorlay/hacker-news-clone/statuses/{sha}","languages_url":"https://api.github.com/repos/connorlay/hacker-news-clone/languages","stargazers_url":"https://api.github.com/repos/connorlay/hacker-news-clone/stargazers","contributors_url":"https://api.github.com/repos/connorlay/hacker-news-clone/contributors","subscribers_url":"https://api.github.com/repos/connorlay/hacker-news-clone/subscribers","subscription_url":"https://api.github.com/repos/connorlay/hacker-news-clone/subscription","commits_url":"https://api.github.com/repos/connorlay/hacker-news-clone/commits{/sha}","git_commits_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/commits{/sha}","comments_url":"https://api.github.com/repos/connorlay/hacker-news-clone/comments{/number}","issue_comment_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/comments{/number}","contents_url":"https://api.github.com/repos/connorlay/hacker-news-clone/contents/{+path}","compare_url":"https://api.github.com/repos/connorlay/hacker-news-clone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connorlay/hacker-news-clone/merges","archive_url":"https://api.github.com/repos/connorlay/hacker-news-clone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connorlay/hacker-news-clone/downloads","issues_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues{/number}","pulls_url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls{/number}","milestones_url":"https://api.github.com/repos/connorlay/hacker-news-clone/milestones{/number}","notifications_url":"https://api.github.com/repos/connorlay/hacker-news-clone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connorlay/hacker-news-clone/labels{/name}","releases_url":"https://api.github.com/repos/connorlay/hacker-news-clone/releases{/id}","created_at":"2015-06-16T15:51:46Z","updated_at":"2015-06-16T19:46:27Z","pushed_at":"2015-06-18T22:39:05Z","git_url":"git://github.com/connorlay/hacker-news-clone.git","ssh_url":"git@github.com:connorlay/hacker-news-clone.git","clone_url":"https://github.com/connorlay/hacker-news-clone.git","svn_url":"https://github.com/connorlay/hacker-news-clone","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"connorlay:master","ref":"master","sha":"720c8608f522b52899c307755c77d1b016448c5a","user":{"login":"connorlay","id":6548350,"avatar_url":"https://avatars.githubusercontent.com/u/6548350?v=3","gravatar_id":"","url":"https://api.github.com/users/connorlay","html_url":"https://github.com/connorlay","followers_url":"https://api.github.com/users/connorlay/followers","following_url":"https://api.github.com/users/connorlay/following{/other_user}","gists_url":"https://api.github.com/users/connorlay/gists{/gist_id}","starred_url":"https://api.github.com/users/connorlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorlay/subscriptions","organizations_url":"https://api.github.com/users/connorlay/orgs","repos_url":"https://api.github.com/users/connorlay/repos","events_url":"https://api.github.com/users/connorlay/events{/privacy}","received_events_url":"https://api.github.com/users/connorlay/received_events","type":"User","site_admin":false},"repo":{"id":37540166,"name":"hacker-news-clone","full_name":"connorlay/hacker-news-clone","owner":{"login":"connorlay","id":6548350,"avatar_url":"https://avatars.githubusercontent.com/u/6548350?v=3","gravatar_id":"","url":"https://api.github.com/users/connorlay","html_url":"https://github.com/connorlay","followers_url":"https://api.github.com/users/connorlay/followers","following_url":"https://api.github.com/users/connorlay/following{/other_user}","gists_url":"https://api.github.com/users/connorlay/gists{/gist_id}","starred_url":"https://api.github.com/users/connorlay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connorlay/subscriptions","organizations_url":"https://api.github.com/users/connorlay/orgs","repos_url":"https://api.github.com/users/connorlay/repos","events_url":"https://api.github.com/users/connorlay/events{/privacy}","received_events_url":"https://api.github.com/users/connorlay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/connorlay/hacker-news-clone","description":"A clone of Hacker News with minimal dependencies created for my summer 2015 internship at Viget.","fork":false,"url":"https://api.github.com/repos/connorlay/hacker-news-clone","forks_url":"https://api.github.com/repos/connorlay/hacker-news-clone/forks","keys_url":"https://api.github.com/repos/connorlay/hacker-news-clone/keys{/key_id}","collaborators_url":"https://api.github.com/repos/connorlay/hacker-news-clone/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/connorlay/hacker-news-clone/teams","hooks_url":"https://api.github.com/repos/connorlay/hacker-news-clone/hooks","issue_events_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/events{/number}","events_url":"https://api.github.com/repos/connorlay/hacker-news-clone/events","assignees_url":"https://api.github.com/repos/connorlay/hacker-news-clone/assignees{/user}","branches_url":"https://api.github.com/repos/connorlay/hacker-news-clone/branches{/branch}","tags_url":"https://api.github.com/repos/connorlay/hacker-news-clone/tags","blobs_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/refs{/sha}","trees_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/trees{/sha}","statuses_url":"https://api.github.com/repos/connorlay/hacker-news-clone/statuses/{sha}","languages_url":"https://api.github.com/repos/connorlay/hacker-news-clone/languages","stargazers_url":"https://api.github.com/repos/connorlay/hacker-news-clone/stargazers","contributors_url":"https://api.github.com/repos/connorlay/hacker-news-clone/contributors","subscribers_url":"https://api.github.com/repos/connorlay/hacker-news-clone/subscribers","subscription_url":"https://api.github.com/repos/connorlay/hacker-news-clone/subscription","commits_url":"https://api.github.com/repos/connorlay/hacker-news-clone/commits{/sha}","git_commits_url":"https://api.github.com/repos/connorlay/hacker-news-clone/git/commits{/sha}","comments_url":"https://api.github.com/repos/connorlay/hacker-news-clone/comments{/number}","issue_comment_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/comments{/number}","contents_url":"https://api.github.com/repos/connorlay/hacker-news-clone/contents/{+path}","compare_url":"https://api.github.com/repos/connorlay/hacker-news-clone/compare/{base}...{head}","merges_url":"https://api.github.com/repos/connorlay/hacker-news-clone/merges","archive_url":"https://api.github.com/repos/connorlay/hacker-news-clone/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/connorlay/hacker-news-clone/downloads","issues_url":"https://api.github.com/repos/connorlay/hacker-news-clone/issues{/number}","pulls_url":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls{/number}","milestones_url":"https://api.github.com/repos/connorlay/hacker-news-clone/milestones{/number}","notifications_url":"https://api.github.com/repos/connorlay/hacker-news-clone/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/connorlay/hacker-news-clone/labels{/name}","releases_url":"https://api.github.com/repos/connorlay/hacker-news-clone/releases{/id}","created_at":"2015-06-16T15:51:46Z","updated_at":"2015-06-16T19:46:27Z","pushed_at":"2015-06-18T22:39:05Z","git_url":"git://github.com/connorlay/hacker-news-clone.git","ssh_url":"git@github.com:connorlay/hacker-news-clone.git","clone_url":"https://github.com/connorlay/hacker-news-clone.git","svn_url":"https://github.com/connorlay/hacker-news-clone","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":16,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18"},"html":{"href":"https://github.com/connorlay/hacker-news-clone/pull/18"},"issue":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/18"},"comments":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/connorlay/hacker-news-clone/statuses/6bf92d421f6ce402b5d06d4bfbdfe958edfd0a7e"}}}}