{"action":"created","comment":{"url":"https://api.github.com/repos/mybb/mybb/pulls/comments/42495853","id":42495853,"diff_hunk":"@@ -1186,7 +1186,20 @@\n \t\t\t}\n \t\t\telse if($type[0] == \"numeric\")\n \t\t\t{\n-\t\t\t\t$setting_code = $form->generate_numeric_field($element_name, $setting['value'], array('id' => $element_id));\n+\t\t\t\t$field_options = array('id' => $element_id);\n+\t\t\t\tif (count($type)>1)","path":"admin/modules/config/settings.php","position":6,"original_position":6,"commit_id":"6e91c637da5fa7059c17f285292a51da7fae7abd","original_commit_id":"6e91c637da5fa7059c17f285292a51da7fae7abd","user":{"login":"JN-Jones","id":1917879,"avatar_url":"https://avatars.githubusercontent.com/u/1917879?v=3","gravatar_id":"","url":"https://api.github.com/users/JN-Jones","html_url":"https://github.com/JN-Jones","followers_url":"https://api.github.com/users/JN-Jones/followers","following_url":"https://api.github.com/users/JN-Jones/following{/other_user}","gists_url":"https://api.github.com/users/JN-Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/JN-Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JN-Jones/subscriptions","organizations_url":"https://api.github.com/users/JN-Jones/orgs","repos_url":"https://api.github.com/users/JN-Jones/repos","events_url":"https://api.github.com/users/JN-Jones/events{/privacy}","received_events_url":"https://api.github.com/users/JN-Jones/received_events","type":"User","site_admin":false},"body":"As already said: it's just a copy of the old PR without any work and is still WIP...","created_at":"2015-10-20T13:41:40Z","updated_at":"2015-10-20T13:41:40Z","html_url":"https://github.com/mybb/mybb/pull/2193#discussion_r42495853","pull_request_url":"https://api.github.com/repos/mybb/mybb/pulls/2193","_links":{"self":{"href":"https://api.github.com/repos/mybb/mybb/pulls/comments/42495853"},"html":{"href":"https://github.com/mybb/mybb/pull/2193#discussion_r42495853"},"pull_request":{"href":"https://api.github.com/repos/mybb/mybb/pulls/2193"}}},"pull_request":{"url":"https://api.github.com/repos/mybb/mybb/pulls/2193","id":44681324,"html_url":"https://github.com/mybb/mybb/pull/2193","diff_url":"https://github.com/mybb/mybb/pull/2193.diff","patch_url":"https://github.com/mybb/mybb/pull/2193.patch","issue_url":"https://api.github.com/repos/mybb/mybb/issues/2193","number":2193,"state":"open","locked":false,"title":"Fixes #1959 enhanced numeric option setting","user":{"login":"JN-Jones","id":1917879,"avatar_url":"https://avatars.githubusercontent.com/u/1917879?v=3","gravatar_id":"","url":"https://api.github.com/users/JN-Jones","html_url":"https://github.com/JN-Jones","followers_url":"https://api.github.com/users/JN-Jones/followers","following_url":"https://api.github.com/users/JN-Jones/following{/other_user}","gists_url":"https://api.github.com/users/JN-Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/JN-Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JN-Jones/subscriptions","organizations_url":"https://api.github.com/users/JN-Jones/orgs","repos_url":"https://api.github.com/users/JN-Jones/repos","events_url":"https://api.github.com/users/JN-Jones/events{/privacy}","received_events_url":"https://api.github.com/users/JN-Jones/received_events","type":"User","site_admin":false},"body":"#1959 \r\n\r\nThis is just #1960 atm, however I'll fix the issues mentioned there when I've time (so hopefully tomorrow).","created_at":"2015-09-10T15:21:58Z","updated_at":"2015-10-20T13:41:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41d685e3ca6167f0a66ce1e8b08325f55b6d874f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mybb/mybb/pulls/2193/commits","review_comments_url":"https://api.github.com/repos/mybb/mybb/pulls/2193/comments","review_comment_url":"https://api.github.com/repos/mybb/mybb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mybb/mybb/issues/2193/comments","statuses_url":"https://api.github.com/repos/mybb/mybb/statuses/6e91c637da5fa7059c17f285292a51da7fae7abd","head":{"label":"JN-Jones:fix-1959-numeric_setting","ref":"fix-1959-numeric_setting","sha":"6e91c637da5fa7059c17f285292a51da7fae7abd","user":{"login":"JN-Jones","id":1917879,"avatar_url":"https://avatars.githubusercontent.com/u/1917879?v=3","gravatar_id":"","url":"https://api.github.com/users/JN-Jones","html_url":"https://github.com/JN-Jones","followers_url":"https://api.github.com/users/JN-Jones/followers","following_url":"https://api.github.com/users/JN-Jones/following{/other_user}","gists_url":"https://api.github.com/users/JN-Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/JN-Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JN-Jones/subscriptions","organizations_url":"https://api.github.com/users/JN-Jones/orgs","repos_url":"https://api.github.com/users/JN-Jones/repos","events_url":"https://api.github.com/users/JN-Jones/events{/privacy}","received_events_url":"https://api.github.com/users/JN-Jones/received_events","type":"User","site_admin":false},"repo":{"id":8176887,"name":"mybb","full_name":"JN-Jones/mybb","owner":{"login":"JN-Jones","id":1917879,"avatar_url":"https://avatars.githubusercontent.com/u/1917879?v=3","gravatar_id":"","url":"https://api.github.com/users/JN-Jones","html_url":"https://github.com/JN-Jones","followers_url":"https://api.github.com/users/JN-Jones/followers","following_url":"https://api.github.com/users/JN-Jones/following{/other_user}","gists_url":"https://api.github.com/users/JN-Jones/gists{/gist_id}","starred_url":"https://api.github.com/users/JN-Jones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JN-Jones/subscriptions","organizations_url":"https://api.github.com/users/JN-Jones/orgs","repos_url":"https://api.github.com/users/JN-Jones/repos","events_url":"https://api.github.com/users/JN-Jones/events{/privacy}","received_events_url":"https://api.github.com/users/JN-Jones/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JN-Jones/mybb","description":"","fork":true,"url":"https://api.github.com/repos/JN-Jones/mybb","forks_url":"https://api.github.com/repos/JN-Jones/mybb/forks","keys_url":"https://api.github.com/repos/JN-Jones/mybb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JN-Jones/mybb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JN-Jones/mybb/teams","hooks_url":"https://api.github.com/repos/JN-Jones/mybb/hooks","issue_events_url":"https://api.github.com/repos/JN-Jones/mybb/issues/events{/number}","events_url":"https://api.github.com/repos/JN-Jones/mybb/events","assignees_url":"https://api.github.com/repos/JN-Jones/mybb/assignees{/user}","branches_url":"https://api.github.com/repos/JN-Jones/mybb/branches{/branch}","tags_url":"https://api.github.com/repos/JN-Jones/mybb/tags","blobs_url":"https://api.github.com/repos/JN-Jones/mybb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JN-Jones/mybb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JN-Jones/mybb/git/refs{/sha}","trees_url":"https://api.github.com/repos/JN-Jones/mybb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JN-Jones/mybb/statuses/{sha}","languages_url":"https://api.github.com/repos/JN-Jones/mybb/languages","stargazers_url":"https://api.github.com/repos/JN-Jones/mybb/stargazers","contributors_url":"https://api.github.com/repos/JN-Jones/mybb/contributors","subscribers_url":"https://api.github.com/repos/JN-Jones/mybb/subscribers","subscription_url":"https://api.github.com/repos/JN-Jones/mybb/subscription","commits_url":"https://api.github.com/repos/JN-Jones/mybb/commits{/sha}","git_commits_url":"https://api.github.com/repos/JN-Jones/mybb/git/commits{/sha}","comments_url":"https://api.github.com/repos/JN-Jones/mybb/comments{/number}","issue_comment_url":"https://api.github.com/repos/JN-Jones/mybb/issues/comments{/number}","contents_url":"https://api.github.com/repos/JN-Jones/mybb/contents/{+path}","compare_url":"https://api.github.com/repos/JN-Jones/mybb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JN-Jones/mybb/merges","archive_url":"https://api.github.com/repos/JN-Jones/mybb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JN-Jones/mybb/downloads","issues_url":"https://api.github.com/repos/JN-Jones/mybb/issues{/number}","pulls_url":"https://api.github.com/repos/JN-Jones/mybb/pulls{/number}","milestones_url":"https://api.github.com/repos/JN-Jones/mybb/milestones{/number}","notifications_url":"https://api.github.com/repos/JN-Jones/mybb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JN-Jones/mybb/labels{/name}","releases_url":"https://api.github.com/repos/JN-Jones/mybb/releases{/id}","created_at":"2013-02-13T10:05:31Z","updated_at":"2015-04-02T15:05:24Z","pushed_at":"2015-09-23T08:14:19Z","git_url":"git://github.com/JN-Jones/mybb.git","ssh_url":"git@github.com:JN-Jones/mybb.git","clone_url":"https://github.com/JN-Jones/mybb.git","svn_url":"https://github.com/JN-Jones/mybb","homepage":null,"size":27502,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"feature"}},"base":{"label":"mybb:feature","ref":"feature","sha":"f6f9ed0c3b7bf170f02ef12d1fe5506e677d1237","user":{"login":"mybb","id":328641,"avatar_url":"https://avatars.githubusercontent.com/u/328641?v=3","gravatar_id":"","url":"https://api.github.com/users/mybb","html_url":"https://github.com/mybb","followers_url":"https://api.github.com/users/mybb/followers","following_url":"https://api.github.com/users/mybb/following{/other_user}","gists_url":"https://api.github.com/users/mybb/gists{/gist_id}","starred_url":"https://api.github.com/users/mybb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybb/subscriptions","organizations_url":"https://api.github.com/users/mybb/orgs","repos_url":"https://api.github.com/users/mybb/repos","events_url":"https://api.github.com/users/mybb/events{/privacy}","received_events_url":"https://api.github.com/users/mybb/received_events","type":"Organization","site_admin":false},"repo":{"id":4649599,"name":"mybb","full_name":"mybb/mybb","owner":{"login":"mybb","id":328641,"avatar_url":"https://avatars.githubusercontent.com/u/328641?v=3","gravatar_id":"","url":"https://api.github.com/users/mybb","html_url":"https://github.com/mybb","followers_url":"https://api.github.com/users/mybb/followers","following_url":"https://api.github.com/users/mybb/following{/other_user}","gists_url":"https://api.github.com/users/mybb/gists{/gist_id}","starred_url":"https://api.github.com/users/mybb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mybb/subscriptions","organizations_url":"https://api.github.com/users/mybb/orgs","repos_url":"https://api.github.com/users/mybb/repos","events_url":"https://api.github.com/users/mybb/events{/privacy}","received_events_url":"https://api.github.com/users/mybb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mybb/mybb","description":"MyBB is a free and open source forum software.","fork":false,"url":"https://api.github.com/repos/mybb/mybb","forks_url":"https://api.github.com/repos/mybb/mybb/forks","keys_url":"https://api.github.com/repos/mybb/mybb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mybb/mybb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mybb/mybb/teams","hooks_url":"https://api.github.com/repos/mybb/mybb/hooks","issue_events_url":"https://api.github.com/repos/mybb/mybb/issues/events{/number}","events_url":"https://api.github.com/repos/mybb/mybb/events","assignees_url":"https://api.github.com/repos/mybb/mybb/assignees{/user}","branches_url":"https://api.github.com/repos/mybb/mybb/branches{/branch}","tags_url":"https://api.github.com/repos/mybb/mybb/tags","blobs_url":"https://api.github.com/repos/mybb/mybb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mybb/mybb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mybb/mybb/git/refs{/sha}","trees_url":"https://api.github.com/repos/mybb/mybb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mybb/mybb/statuses/{sha}","languages_url":"https://api.github.com/repos/mybb/mybb/languages","stargazers_url":"https://api.github.com/repos/mybb/mybb/stargazers","contributors_url":"https://api.github.com/repos/mybb/mybb/contributors","subscribers_url":"https://api.github.com/repos/mybb/mybb/subscribers","subscription_url":"https://api.github.com/repos/mybb/mybb/subscription","commits_url":"https://api.github.com/repos/mybb/mybb/commits{/sha}","git_commits_url":"https://api.github.com/repos/mybb/mybb/git/commits{/sha}","comments_url":"https://api.github.com/repos/mybb/mybb/comments{/number}","issue_comment_url":"https://api.github.com/repos/mybb/mybb/issues/comments{/number}","contents_url":"https://api.github.com/repos/mybb/mybb/contents/{+path}","compare_url":"https://api.github.com/repos/mybb/mybb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mybb/mybb/merges","archive_url":"https://api.github.com/repos/mybb/mybb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mybb/mybb/downloads","issues_url":"https://api.github.com/repos/mybb/mybb/issues{/number}","pulls_url":"https://api.github.com/repos/mybb/mybb/pulls{/number}","milestones_url":"https://api.github.com/repos/mybb/mybb/milestones{/number}","notifications_url":"https://api.github.com/repos/mybb/mybb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mybb/mybb/labels{/name}","releases_url":"https://api.github.com/repos/mybb/mybb/releases{/id}","created_at":"2012-06-13T10:34:46Z","updated_at":"2015-10-17T11:10:50Z","pushed_at":"2015-10-20T09:48:04Z","git_url":"git://github.com/mybb/mybb.git","ssh_url":"git@github.com:mybb/mybb.git","clone_url":"https://github.com/mybb/mybb.git","svn_url":"https://github.com/mybb/mybb","homepage":"http://www.mybb.com","size":40377,"stargazers_count":281,"watchers_count":281,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":229,"forks":200,"open_issues":229,"watchers":281,"default_branch":"feature"}},"_links":{"self":{"href":"https://api.github.com/repos/mybb/mybb/pulls/2193"},"html":{"href":"https://github.com/mybb/mybb/pull/2193"},"issue":{"href":"https://api.github.com/repos/mybb/mybb/issues/2193"},"comments":{"href":"https://api.github.com/repos/mybb/mybb/issues/2193/comments"},"review_comments":{"href":"https://api.github.com/repos/mybb/mybb/pulls/2193/comments"},"review_comment":{"href":"https://api.github.com/repos/mybb/mybb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mybb/mybb/pulls/2193/commits"},"statuses":{"href":"https://api.github.com/repos/mybb/mybb/statuses/6e91c637da5fa7059c17f285292a51da7fae7abd"}}}}