{"action":"created","comment":{"url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/comments/44318589","id":44318589,"diff_hunk":"@@ -16,6 +16,25 @@\n       relative_pathname = real_pathname.relative_path_from(module_path_real_pathname)\n \n       context display_path do\n+        #\n+        # Methods\n+        #\n+\n+        def valid_or_log(record)\n+          expect(record).to be_valid,\n+                            ->() {\n+                              \"Expected #{record.class} to be valid, but got errors:\\n\" \\","path":"spec/support/shared/examples/metasploit/cache/module/instance/load/from_relative_path_prefix.rb","position":11,"original_position":11,"commit_id":"0ead5f1eac9b15570b56e61ea68002169768d912","original_commit_id":"0ead5f1eac9b15570b56e61ea68002169768d912","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Line is too long. [89/80]","created_at":"2015-11-09T19:27:21Z","updated_at":"2015-11-09T19:27:21Z","html_url":"https://github.com/rapid7/metasploit-cache/pull/86#discussion_r44318589","pull_request_url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86","_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/comments/44318589"},"html":{"href":"https://github.com/rapid7/metasploit-cache/pull/86#discussion_r44318589"},"pull_request":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86"}}},"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86","id":46285204,"html_url":"https://github.com/rapid7/metasploit-cache/pull/86","diff_url":"https://github.com/rapid7/metasploit-cache/pull/86.diff","patch_url":"https://github.com/rapid7/metasploit-cache/pull/86.patch","issue_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues/86","number":86,"state":"open","locked":false,"title":"Load by Metasploit::Cache::Payload::Single::Handled::Instance by reference name","user":{"login":"limhoff-r7","id":2230482,"avatar_url":"https://avatars.githubusercontent.com/u/2230482?v=3","gravatar_id":"","url":"https://api.github.com/users/limhoff-r7","html_url":"https://github.com/limhoff-r7","followers_url":"https://api.github.com/users/limhoff-r7/followers","following_url":"https://api.github.com/users/limhoff-r7/following{/other_user}","gists_url":"https://api.github.com/users/limhoff-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/limhoff-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/limhoff-r7/subscriptions","organizations_url":"https://api.github.com/users/limhoff-r7/orgs","repos_url":"https://api.github.com/users/limhoff-r7/repos","events_url":"https://api.github.com/users/limhoff-r7/events{/privacy}","received_events_url":"https://api.github.com/users/limhoff-r7/received_events","type":"User","site_admin":false},"body":"MSP-12460\r\nMS-596\r\n\r\n# Changelog\r\n* Enhancements\r\n  * `Metasploit::Cache::Module::Ancestor.reference_names(relative_file_paths:, scoping_levels:) can transform a `Array<String>` to the properly scoped reference name.\r\n  * Run `metasploit-cache use` tests for `payloads/singles`.\r\n* Bug Fix\r\n  * `Metasploit::Cache::Payload::Handler#handler_type` does not have to be unique.\r\n  * `Metasploit::Cache::Payload::Single::Handled::Class::Load#payload_single_handled_class` is not validated during loading.\r\n  * Change order of validations on `Metasploit::Cache:Payload::Single::Handled::Class::Load` so loading validations don't erase non-context-sensitive validations.\r\n  * 5 random `metasploit-cache use` tests will be run for each type directory because modules tests take too long\r\n  * Retry transactions when they fail in `metasploit-cache load`.\r\n  * Use `Metasploit::Cache::Ephemeral::AttributeSet.existing_by_attribute_value` for `Metasploit::Cache::Author::Ephemeral.by_name` and `Metasploit::Cache::EmailAddress::Ephemeral.by_full`\r\n* Incompatible Changes\r\n  * Removed `Metasploit::Cache::Module::Ancestor#reference_path`\r\n  * `Metasploit::Cache::Module::Ancestor#reference_name` is lifted to `Metasploit::Cache::Module::Ancestor.reference_name`.\r\n  * Removed `Metasploit::Cache::Author::Ephemeral.existing_by_name`\r\n  * Removed `Metasploit::Cache::EmailAddress::Ephemeral.existing_by_full`\r\n\r\n# Pre-verification Steps\r\n- [ ] Merge #85 \r\n\r\n# Verification Steps\r\n- [ ] `rm Gemfile.lock`\r\n- [ ] `bundle install --without sqlite3`\r\n- [ ] `rake db:drop db:create db:migrate`\r\n\r\n## Manual\r\n\r\n### Load\r\n- [ ] `rake app:db:test:load`\r\n- [ ] \r\n```\r\ntime metasploit-cache load ${METASPLOIT_FRAMEWORK}/modules\r\n                           --database-yaml spec/dummy/config/database.yml \\\r\n                           --environment test \\\r\n                           --include ${METASPLOIT_FRAMEWORK} ${METASPLOIT_FRAMEWORK}/app/validators \\\r\n                           --require metasploit/framework metasploit/framework/executable_path_validator metasploit/framework/file_path_validator \\\r\n                           --gem metasploit-framework \\\r\n                           --logger-severity INFO \\\r\n                           --name modules \\\r\n                           --only-type-directories payloads/singles                           \r\n```\r\n- [ ] VERIFY progress bar is printed to log\r\n\r\n### Use\r\n- [ ] \r\n```\r\ntime metasploit-cache use payload/windows/x64/meterpreter_reverse_https\r\n                          --database-yaml spec/dummy/config/database.yml \\\r\n                          --environment test \\\r\n                          --include ${METASPLOIT_FRAMEWORK} ${METASPLOIT_FRAMEWORK}/app/validators \\\r\n                          --require metasploit/framework metasploit/framework/executable_path_validator metasploit/framework/file_path_validator \\\r\n                          --logger-severity ERROR\r\n```\r\n\r\n## Postgresql\r\n- [ ] `rm Gemfile.lock`\r\n- [ ] `bundle install --without sqlite3`\r\n- [ ] `rake db:drop db:create db:migrate`\r\n\r\n### Test coverage\r\n- [ ] `rake cucumber spec coverage`\r\n- [ ] VERIFY no failures\r\n- [ ] VERIFY 100% coverage\r\n\r\n### Documentation Coverage\r\n- [ ] `rake yard:stats`\r\n- [ ] VERIFY no `[warn]`ings\r\n- [ ] VERIFY no undocumented objects\r\n\r\n## Sqlite3\r\n- [ ] `rm Gemfile.lock`\r\n- [ ] `bundle install --without postgresql`\r\n- [ ] `rake db:drop db:create db:migrate`\r\n\r\n### Test coverage\r\n- [ ] `rake cucumber spec coverage`\r\n- [ ] VERIFY no failures\r\n- [ ] VERIFY 100% coverage\r\n\r\n### Documentation coverage\r\n- [ ] `rake yard:stats`\r\n- [ ] VERIFY no `[warn]`ings\r\n- [ ] VERIFY no undocumented objects","created_at":"2015-09-29T14:35:16Z","updated_at":"2015-11-09T19:27:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"893e59b25cf1ee00d4b35bb580f141c82297ebd4","assignee":{"login":"wchen-r7","id":1170914,"avatar_url":"https://avatars.githubusercontent.com/u/1170914?v=3","gravatar_id":"","url":"https://api.github.com/users/wchen-r7","html_url":"https://github.com/wchen-r7","followers_url":"https://api.github.com/users/wchen-r7/followers","following_url":"https://api.github.com/users/wchen-r7/following{/other_user}","gists_url":"https://api.github.com/users/wchen-r7/gists{/gist_id}","starred_url":"https://api.github.com/users/wchen-r7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wchen-r7/subscriptions","organizations_url":"https://api.github.com/users/wchen-r7/orgs","repos_url":"https://api.github.com/users/wchen-r7/repos","events_url":"https://api.github.com/users/wchen-r7/events{/privacy}","received_events_url":"https://api.github.com/users/wchen-r7/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86/commits","review_comments_url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86/comments","review_comment_url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues/86/comments","statuses_url":"https://api.github.com/repos/rapid7/metasploit-cache/statuses/0ead5f1eac9b15570b56e61ea68002169768d912","head":{"label":"rapid7:feature/MSP-12460/load-by-reference-name-payload-single-class","ref":"feature/MSP-12460/load-by-reference-name-payload-single-class","sha":"0ead5f1eac9b15570b56e61ea68002169768d912","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":27936087,"name":"metasploit-cache","full_name":"rapid7/metasploit-cache","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-cache","description":"Managing Metasploit content since 2015","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-cache","forks_url":"https://api.github.com/repos/rapid7/metasploit-cache/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-cache/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-cache/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-cache/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-cache/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-cache/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-cache/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-cache/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-cache/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-cache/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-cache/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-cache/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-cache/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-cache/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-cache/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-cache/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-cache/releases{/id}","created_at":"2014-12-12T20:04:36Z","updated_at":"2015-10-14T14:16:24Z","pushed_at":"2015-11-09T19:26:12Z","git_url":"git://github.com/rapid7/metasploit-cache.git","ssh_url":"git@github.com:rapid7/metasploit-cache.git","clone_url":"https://github.com/rapid7/metasploit-cache.git","svn_url":"https://github.com/rapid7/metasploit-cache","homepage":"","size":19221,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"rapid7:master","ref":"master","sha":"ff6eb2a014b0cead9e6c8ebb25f7a6b0b9f1868c","user":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"repo":{"id":27936087,"name":"metasploit-cache","full_name":"rapid7/metasploit-cache","owner":{"login":"rapid7","id":1013671,"avatar_url":"https://avatars.githubusercontent.com/u/1013671?v=3","gravatar_id":"","url":"https://api.github.com/users/rapid7","html_url":"https://github.com/rapid7","followers_url":"https://api.github.com/users/rapid7/followers","following_url":"https://api.github.com/users/rapid7/following{/other_user}","gists_url":"https://api.github.com/users/rapid7/gists{/gist_id}","starred_url":"https://api.github.com/users/rapid7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rapid7/subscriptions","organizations_url":"https://api.github.com/users/rapid7/orgs","repos_url":"https://api.github.com/users/rapid7/repos","events_url":"https://api.github.com/users/rapid7/events{/privacy}","received_events_url":"https://api.github.com/users/rapid7/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rapid7/metasploit-cache","description":"Managing Metasploit content since 2015","fork":false,"url":"https://api.github.com/repos/rapid7/metasploit-cache","forks_url":"https://api.github.com/repos/rapid7/metasploit-cache/forks","keys_url":"https://api.github.com/repos/rapid7/metasploit-cache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rapid7/metasploit-cache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rapid7/metasploit-cache/teams","hooks_url":"https://api.github.com/repos/rapid7/metasploit-cache/hooks","issue_events_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues/events{/number}","events_url":"https://api.github.com/repos/rapid7/metasploit-cache/events","assignees_url":"https://api.github.com/repos/rapid7/metasploit-cache/assignees{/user}","branches_url":"https://api.github.com/repos/rapid7/metasploit-cache/branches{/branch}","tags_url":"https://api.github.com/repos/rapid7/metasploit-cache/tags","blobs_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/refs{/sha}","trees_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rapid7/metasploit-cache/statuses/{sha}","languages_url":"https://api.github.com/repos/rapid7/metasploit-cache/languages","stargazers_url":"https://api.github.com/repos/rapid7/metasploit-cache/stargazers","contributors_url":"https://api.github.com/repos/rapid7/metasploit-cache/contributors","subscribers_url":"https://api.github.com/repos/rapid7/metasploit-cache/subscribers","subscription_url":"https://api.github.com/repos/rapid7/metasploit-cache/subscription","commits_url":"https://api.github.com/repos/rapid7/metasploit-cache/commits{/sha}","git_commits_url":"https://api.github.com/repos/rapid7/metasploit-cache/git/commits{/sha}","comments_url":"https://api.github.com/repos/rapid7/metasploit-cache/comments{/number}","issue_comment_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues/comments{/number}","contents_url":"https://api.github.com/repos/rapid7/metasploit-cache/contents/{+path}","compare_url":"https://api.github.com/repos/rapid7/metasploit-cache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rapid7/metasploit-cache/merges","archive_url":"https://api.github.com/repos/rapid7/metasploit-cache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rapid7/metasploit-cache/downloads","issues_url":"https://api.github.com/repos/rapid7/metasploit-cache/issues{/number}","pulls_url":"https://api.github.com/repos/rapid7/metasploit-cache/pulls{/number}","milestones_url":"https://api.github.com/repos/rapid7/metasploit-cache/milestones{/number}","notifications_url":"https://api.github.com/repos/rapid7/metasploit-cache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rapid7/metasploit-cache/labels{/name}","releases_url":"https://api.github.com/repos/rapid7/metasploit-cache/releases{/id}","created_at":"2014-12-12T20:04:36Z","updated_at":"2015-10-14T14:16:24Z","pushed_at":"2015-11-09T19:26:12Z","git_url":"git://github.com/rapid7/metasploit-cache.git","ssh_url":"git@github.com:rapid7/metasploit-cache.git","clone_url":"https://github.com/rapid7/metasploit-cache.git","svn_url":"https://github.com/rapid7/metasploit-cache","homepage":"","size":19221,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86"},"html":{"href":"https://github.com/rapid7/metasploit-cache/pull/86"},"issue":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/issues/86"},"comments":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/rapid7/metasploit-cache/statuses/0ead5f1eac9b15570b56e61ea68002169768d912"}}}}