{"action":"opened","number":102,"pull_request":{"url":"https://api.github.com/repos/cdent/gabbi/pulls/102","id":47372923,"html_url":"https://github.com/cdent/gabbi/pull/102","diff_url":"https://github.com/cdent/gabbi/pull/102.diff","patch_url":"https://github.com/cdent/gabbi/pull/102.patch","issue_url":"https://api.github.com/repos/cdent/gabbi/issues/102","number":102,"state":"open","locked":false,"title":"attempted to clarify test and suite generation","user":{"login":"FND","id":3515,"avatar_url":"https://avatars.githubusercontent.com/u/3515?v=3","gravatar_id":"","url":"https://api.github.com/users/FND","html_url":"https://github.com/FND","followers_url":"https://api.github.com/users/FND/followers","following_url":"https://api.github.com/users/FND/following{/other_user}","gists_url":"https://api.github.com/users/FND/gists{/gist_id}","starred_url":"https://api.github.com/users/FND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FND/subscriptions","organizations_url":"https://api.github.com/users/FND/orgs","repos_url":"https://api.github.com/users/FND/repos","events_url":"https://api.github.com/users/FND/events{/privacy}","received_events_url":"https://api.github.com/users/FND/received_events","type":"User","site_admin":false},"body":"This is very much a light version of what I had planned [originally](https://github.com/cdent/gabbi/commit/415d76c2cfaffe04b9379bbe76af9eaff29ec6cb#commitcomment-13701857): I was considering introducing a set of intermediate classes (`GabbiTestDescriptor[Collection]`?) to encapsulate and shuffle around some of the logic in both `test_suite_from_yaml` and `TestMaker`, but I'm no longer convinced it's worth the effort (for now anyway).\r\n\r\nNevertheless, this set of changes seems to better describe what's going on, if only by grouping related aspects within the existing function.\r\n\r\nWhat still irks me is that `test_suite_from_yaml` actually doesn't have anything to do with YAML, it's merely a dictionary that once happened to originate in a YAML file. However, I couldn't figure out how to get around that without introducing new terminology (see above).","created_at":"2015-10-11T18:48:20Z","updated_at":"2015-10-11T18:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/cdent/gabbi/pulls/102/commits","review_comments_url":"https://api.github.com/repos/cdent/gabbi/pulls/102/comments","review_comment_url":"https://api.github.com/repos/cdent/gabbi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cdent/gabbi/issues/102/comments","statuses_url":"https://api.github.com/repos/cdent/gabbi/statuses/533891a0b8bcd848b8af41bd102b80c42193f2d0","head":{"label":"FND:suite-generation-tweaks","ref":"suite-generation-tweaks","sha":"533891a0b8bcd848b8af41bd102b80c42193f2d0","user":{"login":"FND","id":3515,"avatar_url":"https://avatars.githubusercontent.com/u/3515?v=3","gravatar_id":"","url":"https://api.github.com/users/FND","html_url":"https://github.com/FND","followers_url":"https://api.github.com/users/FND/followers","following_url":"https://api.github.com/users/FND/following{/other_user}","gists_url":"https://api.github.com/users/FND/gists{/gist_id}","starred_url":"https://api.github.com/users/FND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FND/subscriptions","organizations_url":"https://api.github.com/users/FND/orgs","repos_url":"https://api.github.com/users/FND/repos","events_url":"https://api.github.com/users/FND/events{/privacy}","received_events_url":"https://api.github.com/users/FND/received_events","type":"User","site_admin":false},"repo":{"id":32883700,"name":"gabbi","full_name":"FND/gabbi","owner":{"login":"FND","id":3515,"avatar_url":"https://avatars.githubusercontent.com/u/3515?v=3","gravatar_id":"","url":"https://api.github.com/users/FND","html_url":"https://github.com/FND","followers_url":"https://api.github.com/users/FND/followers","following_url":"https://api.github.com/users/FND/following{/other_user}","gists_url":"https://api.github.com/users/FND/gists{/gist_id}","starred_url":"https://api.github.com/users/FND/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FND/subscriptions","organizations_url":"https://api.github.com/users/FND/orgs","repos_url":"https://api.github.com/users/FND/repos","events_url":"https://api.github.com/users/FND/events{/privacy}","received_events_url":"https://api.github.com/users/FND/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/FND/gabbi","description":"Declarative HTTP Testing for Python","fork":true,"url":"https://api.github.com/repos/FND/gabbi","forks_url":"https://api.github.com/repos/FND/gabbi/forks","keys_url":"https://api.github.com/repos/FND/gabbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FND/gabbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FND/gabbi/teams","hooks_url":"https://api.github.com/repos/FND/gabbi/hooks","issue_events_url":"https://api.github.com/repos/FND/gabbi/issues/events{/number}","events_url":"https://api.github.com/repos/FND/gabbi/events","assignees_url":"https://api.github.com/repos/FND/gabbi/assignees{/user}","branches_url":"https://api.github.com/repos/FND/gabbi/branches{/branch}","tags_url":"https://api.github.com/repos/FND/gabbi/tags","blobs_url":"https://api.github.com/repos/FND/gabbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FND/gabbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FND/gabbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/FND/gabbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FND/gabbi/statuses/{sha}","languages_url":"https://api.github.com/repos/FND/gabbi/languages","stargazers_url":"https://api.github.com/repos/FND/gabbi/stargazers","contributors_url":"https://api.github.com/repos/FND/gabbi/contributors","subscribers_url":"https://api.github.com/repos/FND/gabbi/subscribers","subscription_url":"https://api.github.com/repos/FND/gabbi/subscription","commits_url":"https://api.github.com/repos/FND/gabbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/FND/gabbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/FND/gabbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/FND/gabbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/FND/gabbi/contents/{+path}","compare_url":"https://api.github.com/repos/FND/gabbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FND/gabbi/merges","archive_url":"https://api.github.com/repos/FND/gabbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FND/gabbi/downloads","issues_url":"https://api.github.com/repos/FND/gabbi/issues{/number}","pulls_url":"https://api.github.com/repos/FND/gabbi/pulls{/number}","milestones_url":"https://api.github.com/repos/FND/gabbi/milestones{/number}","notifications_url":"https://api.github.com/repos/FND/gabbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FND/gabbi/labels{/name}","releases_url":"https://api.github.com/repos/FND/gabbi/releases{/id}","created_at":"2015-03-25T18:38:31Z","updated_at":"2015-03-25T18:38:31Z","pushed_at":"2015-10-11T18:38:06Z","git_url":"git://github.com/FND/gabbi.git","ssh_url":"git@github.com:FND/gabbi.git","clone_url":"https://github.com/FND/gabbi.git","svn_url":"https://github.com/FND/gabbi","homepage":null,"size":477,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cdent:master","ref":"master","sha":"4a9b090df3529aa3375b0314ecd4a90ca0937073","user":{"login":"cdent","id":34498,"avatar_url":"https://avatars.githubusercontent.com/u/34498?v=3","gravatar_id":"","url":"https://api.github.com/users/cdent","html_url":"https://github.com/cdent","followers_url":"https://api.github.com/users/cdent/followers","following_url":"https://api.github.com/users/cdent/following{/other_user}","gists_url":"https://api.github.com/users/cdent/gists{/gist_id}","starred_url":"https://api.github.com/users/cdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdent/subscriptions","organizations_url":"https://api.github.com/users/cdent/orgs","repos_url":"https://api.github.com/users/cdent/repos","events_url":"https://api.github.com/users/cdent/events{/privacy}","received_events_url":"https://api.github.com/users/cdent/received_events","type":"User","site_admin":false},"repo":{"id":27924304,"name":"gabbi","full_name":"cdent/gabbi","owner":{"login":"cdent","id":34498,"avatar_url":"https://avatars.githubusercontent.com/u/34498?v=3","gravatar_id":"","url":"https://api.github.com/users/cdent","html_url":"https://github.com/cdent","followers_url":"https://api.github.com/users/cdent/followers","following_url":"https://api.github.com/users/cdent/following{/other_user}","gists_url":"https://api.github.com/users/cdent/gists{/gist_id}","starred_url":"https://api.github.com/users/cdent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdent/subscriptions","organizations_url":"https://api.github.com/users/cdent/orgs","repos_url":"https://api.github.com/users/cdent/repos","events_url":"https://api.github.com/users/cdent/events{/privacy}","received_events_url":"https://api.github.com/users/cdent/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdent/gabbi","description":"Declarative HTTP Testing","fork":false,"url":"https://api.github.com/repos/cdent/gabbi","forks_url":"https://api.github.com/repos/cdent/gabbi/forks","keys_url":"https://api.github.com/repos/cdent/gabbi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdent/gabbi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdent/gabbi/teams","hooks_url":"https://api.github.com/repos/cdent/gabbi/hooks","issue_events_url":"https://api.github.com/repos/cdent/gabbi/issues/events{/number}","events_url":"https://api.github.com/repos/cdent/gabbi/events","assignees_url":"https://api.github.com/repos/cdent/gabbi/assignees{/user}","branches_url":"https://api.github.com/repos/cdent/gabbi/branches{/branch}","tags_url":"https://api.github.com/repos/cdent/gabbi/tags","blobs_url":"https://api.github.com/repos/cdent/gabbi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdent/gabbi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdent/gabbi/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdent/gabbi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdent/gabbi/statuses/{sha}","languages_url":"https://api.github.com/repos/cdent/gabbi/languages","stargazers_url":"https://api.github.com/repos/cdent/gabbi/stargazers","contributors_url":"https://api.github.com/repos/cdent/gabbi/contributors","subscribers_url":"https://api.github.com/repos/cdent/gabbi/subscribers","subscription_url":"https://api.github.com/repos/cdent/gabbi/subscription","commits_url":"https://api.github.com/repos/cdent/gabbi/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdent/gabbi/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdent/gabbi/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdent/gabbi/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdent/gabbi/contents/{+path}","compare_url":"https://api.github.com/repos/cdent/gabbi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdent/gabbi/merges","archive_url":"https://api.github.com/repos/cdent/gabbi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdent/gabbi/downloads","issues_url":"https://api.github.com/repos/cdent/gabbi/issues{/number}","pulls_url":"https://api.github.com/repos/cdent/gabbi/pulls{/number}","milestones_url":"https://api.github.com/repos/cdent/gabbi/milestones{/number}","notifications_url":"https://api.github.com/repos/cdent/gabbi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdent/gabbi/labels{/name}","releases_url":"https://api.github.com/repos/cdent/gabbi/releases{/id}","created_at":"2014-12-12T14:46:59Z","updated_at":"2015-10-05T09:44:06Z","pushed_at":"2015-10-11T18:48:20Z","git_url":"git://github.com/cdent/gabbi.git","ssh_url":"git@github.com:cdent/gabbi.git","clone_url":"https://github.com/cdent/gabbi.git","svn_url":"https://github.com/cdent/gabbi","homepage":"http://gabbi.readthedocs.org/","size":1667,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"open_issues_count":16,"forks":10,"open_issues":16,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cdent/gabbi/pulls/102"},"html":{"href":"https://github.com/cdent/gabbi/pull/102"},"issue":{"href":"https://api.github.com/repos/cdent/gabbi/issues/102"},"comments":{"href":"https://api.github.com/repos/cdent/gabbi/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/cdent/gabbi/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/cdent/gabbi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cdent/gabbi/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/cdent/gabbi/statuses/533891a0b8bcd848b8af41bd102b80c42193f2d0"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":13,"deletions":15,"changed_files":2}}