{"action":"created","issue":{"url":"https://api.github.com/repos/SciRuby/distribution/issues/11","labels_url":"https://api.github.com/repos/SciRuby/distribution/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/SciRuby/distribution/issues/11/comments","events_url":"https://api.github.com/repos/SciRuby/distribution/issues/11/events","html_url":"https://github.com/SciRuby/distribution/pull/11","id":77220990,"number":11,"title":"Fix Ruby implementation of F distribution-related functions","user":{"login":"agarie","id":615227,"avatar_url":"https://avatars.githubusercontent.com/u/615227?v=3","gravatar_id":"","url":"https://api.github.com/users/agarie","html_url":"https://github.com/agarie","followers_url":"https://api.github.com/users/agarie/followers","following_url":"https://api.github.com/users/agarie/following{/other_user}","gists_url":"https://api.github.com/users/agarie/gists{/gist_id}","starred_url":"https://api.github.com/users/agarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarie/subscriptions","organizations_url":"https://api.github.com/users/agarie/orgs","repos_url":"https://api.github.com/users/agarie/repos","events_url":"https://api.github.com/users/agarie/events{/privacy}","received_events_url":"https://api.github.com/users/agarie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-17T05:26:14Z","updated_at":"2015-05-26T03:21:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SciRuby/distribution/pulls/11","html_url":"https://github.com/SciRuby/distribution/pull/11","diff_url":"https://github.com/SciRuby/distribution/pull/11.diff","patch_url":"https://github.com/SciRuby/distribution/pull/11.patch"},"body":"I'm still not finished, I need to make sure these changes fixes what is being tested in Statsample. This fixes the tests introduced in #9. Let's hope Travis thinks the same. :)\r\n\r\nThere's another big problem: these functions aren't documented. Most of Distribution is like that, really, but let's take one step at a time. For example, some references for the approximations in `pf`, `pfsub` and `q_f` would be helpful while debugging."},"comment":{"url":"https://api.github.com/repos/SciRuby/distribution/issues/comments/105374761","html_url":"https://github.com/SciRuby/distribution/pull/11#issuecomment-105374761","issue_url":"https://api.github.com/repos/SciRuby/distribution/issues/11","id":105374761,"user":{"login":"agarie","id":615227,"avatar_url":"https://avatars.githubusercontent.com/u/615227?v=3","gravatar_id":"","url":"https://api.github.com/users/agarie","html_url":"https://github.com/agarie","followers_url":"https://api.github.com/users/agarie/followers","following_url":"https://api.github.com/users/agarie/following{/other_user}","gists_url":"https://api.github.com/users/agarie/gists{/gist_id}","starred_url":"https://api.github.com/users/agarie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agarie/subscriptions","organizations_url":"https://api.github.com/users/agarie/orgs","repos_url":"https://api.github.com/users/agarie/repos","events_url":"https://api.github.com/users/agarie/events{/privacy}","received_events_url":"https://api.github.com/users/agarie/received_events","type":"User","site_admin":false},"created_at":"2015-05-26T03:21:49Z","updated_at":"2015-05-26T03:21:49Z","body":"After fixing the above error, i.e. removing the \r\n\r\n```ruby\r\n>> Distribution::F::Ruby_.p_value(y, n, m)\r\n# => 20.784610000000026\r\n>> GSL::Cdf.fdist_Pinv(y, n, m)\r\n# => 8.80568714984652\r\n```\r\n\r\nAlright, so there is something wrong with the implementation of `Ruby_#p_value`, `Ruby_#pf`, `Ruby#pfsub` or `Ruby_#q_f`. I just don't know why. I'll try to find a reference before starting to review what is wrong there. :("}}