{"action":"created","comment":{"url":"https://api.github.com/repos/yonadev/yona-server/pulls/comments/46722988","id":46722988,"diff_hunk":"@@ -248,6 +246,13 @@ static Link getUserSelfLinkWithTempPassword(UUID userID, String tempPassword)\n \t\treturn linkBuilder.withSelfRel();\n \t}\n \n+\tprivate static Link getConfirmMobileLink(UUID userID)\n+\t{\n+\t\tControllerLinkBuilder linkBuilder = linkTo(\n+\t\t\t\tmethodOn(UserController.class).confirmMobileNumber(Optional.empty(), userID, null));\n+\t\treturn linkBuilder.withSelfRel();","path":"appservice/src/main/java/nu/yona/server/subscriptions/rest/UserController.java","position":26,"original_position":26,"commit_id":"d424d8455b0bd6c48c6b2e2d787c198386edfc60","original_commit_id":"d424d8455b0bd6c48c6b2e2d787c198386edfc60","user":{"login":"aristotelos","id":2814758,"avatar_url":"https://avatars.githubusercontent.com/u/2814758?v=3","gravatar_id":"","url":"https://api.github.com/users/aristotelos","html_url":"https://github.com/aristotelos","followers_url":"https://api.github.com/users/aristotelos/followers","following_url":"https://api.github.com/users/aristotelos/following{/other_user}","gists_url":"https://api.github.com/users/aristotelos/gists{/gist_id}","starred_url":"https://api.github.com/users/aristotelos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aristotelos/subscriptions","organizations_url":"https://api.github.com/users/aristotelos/orgs","repos_url":"https://api.github.com/users/aristotelos/repos","events_url":"https://api.github.com/users/aristotelos/events{/privacy}","received_events_url":"https://api.github.com/users/aristotelos/received_events","type":"User","site_admin":false},"body":"This is not correct. The link is inserted in the user json object so \"self\" must refer to the user href. Suggestion: return a LinkBuilder here and use the method `.withRel(\"confirmMobileNumber\")` in the UserResourceAssembler.","created_at":"2015-12-04T19:40:01Z","updated_at":"2015-12-04T19:40:01Z","html_url":"https://github.com/yonadev/yona-server/pull/59#discussion_r46722988","pull_request_url":"https://api.github.com/repos/yonadev/yona-server/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/comments/46722988"},"html":{"href":"https://github.com/yonadev/yona-server/pull/59#discussion_r46722988"},"pull_request":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/yonadev/yona-server/pulls/59","id":52656265,"html_url":"https://github.com/yonadev/yona-server/pull/59","diff_url":"https://github.com/yonadev/yona-server/pull/59.diff","patch_url":"https://github.com/yonadev/yona-server/pull/59.patch","issue_url":"https://api.github.com/repos/yonadev/yona-server/issues/59","number":59,"state":"open","locked":false,"title":"Yd 126 add action link","user":{"login":"pgussow","id":83359,"avatar_url":"https://avatars.githubusercontent.com/u/83359?v=3","gravatar_id":"","url":"https://api.github.com/users/pgussow","html_url":"https://github.com/pgussow","followers_url":"https://api.github.com/users/pgussow/followers","following_url":"https://api.github.com/users/pgussow/following{/other_user}","gists_url":"https://api.github.com/users/pgussow/gists{/gist_id}","starred_url":"https://api.github.com/users/pgussow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pgussow/subscriptions","organizations_url":"https://api.github.com/users/pgussow/orgs","repos_url":"https://api.github.com/users/pgussow/repos","events_url":"https://api.github.com/users/pgussow/events{/privacy}","received_events_url":"https://api.github.com/users/pgussow/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-04T11:07:06Z","updated_at":"2015-12-04T19:40:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e19d8c0d230d71180eb17cc0d9f94499f615252","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yonadev/yona-server/pulls/59/commits","review_comments_url":"https://api.github.com/repos/yonadev/yona-server/pulls/59/comments","review_comment_url":"https://api.github.com/repos/yonadev/yona-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yonadev/yona-server/issues/59/comments","statuses_url":"https://api.github.com/repos/yonadev/yona-server/statuses/d424d8455b0bd6c48c6b2e2d787c198386edfc60","head":{"label":"yonadev:yd-126-add-action-link","ref":"yd-126-add-action-link","sha":"d424d8455b0bd6c48c6b2e2d787c198386edfc60","user":{"login":"yonadev","id":14901571,"avatar_url":"https://avatars.githubusercontent.com/u/14901571?v=3","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"repo":{"id":43589108,"name":"yona-server","full_name":"yonadev/yona-server","owner":{"login":"yonadev","id":14901571,"avatar_url":"https://avatars.githubusercontent.com/u/14901571?v=3","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yonadev/yona-server","description":"Yona Server","fork":false,"url":"https://api.github.com/repos/yonadev/yona-server","forks_url":"https://api.github.com/repos/yonadev/yona-server/forks","keys_url":"https://api.github.com/repos/yonadev/yona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonadev/yona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonadev/yona-server/teams","hooks_url":"https://api.github.com/repos/yonadev/yona-server/hooks","issue_events_url":"https://api.github.com/repos/yonadev/yona-server/issues/events{/number}","events_url":"https://api.github.com/repos/yonadev/yona-server/events","assignees_url":"https://api.github.com/repos/yonadev/yona-server/assignees{/user}","branches_url":"https://api.github.com/repos/yonadev/yona-server/branches{/branch}","tags_url":"https://api.github.com/repos/yonadev/yona-server/tags","blobs_url":"https://api.github.com/repos/yonadev/yona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonadev/yona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonadev/yona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonadev/yona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonadev/yona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/yonadev/yona-server/languages","stargazers_url":"https://api.github.com/repos/yonadev/yona-server/stargazers","contributors_url":"https://api.github.com/repos/yonadev/yona-server/contributors","subscribers_url":"https://api.github.com/repos/yonadev/yona-server/subscribers","subscription_url":"https://api.github.com/repos/yonadev/yona-server/subscription","commits_url":"https://api.github.com/repos/yonadev/yona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonadev/yona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonadev/yona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonadev/yona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonadev/yona-server/contents/{+path}","compare_url":"https://api.github.com/repos/yonadev/yona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonadev/yona-server/merges","archive_url":"https://api.github.com/repos/yonadev/yona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonadev/yona-server/downloads","issues_url":"https://api.github.com/repos/yonadev/yona-server/issues{/number}","pulls_url":"https://api.github.com/repos/yonadev/yona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/yonadev/yona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/yonadev/yona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonadev/yona-server/labels{/name}","releases_url":"https://api.github.com/repos/yonadev/yona-server/releases{/id}","created_at":"2015-10-03T05:33:54Z","updated_at":"2015-11-16T11:29:28Z","pushed_at":"2015-12-04T16:52:19Z","git_url":"git://github.com/yonadev/yona-server.git","ssh_url":"git@github.com:yonadev/yona-server.git","clone_url":"https://github.com/yonadev/yona-server.git","svn_url":"https://github.com/yonadev/yona-server","homepage":null,"size":1017,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"yonadev:master","ref":"master","sha":"229b7cc39e81a03e86d7089fefb4f2d41d366be6","user":{"login":"yonadev","id":14901571,"avatar_url":"https://avatars.githubusercontent.com/u/14901571?v=3","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"repo":{"id":43589108,"name":"yona-server","full_name":"yonadev/yona-server","owner":{"login":"yonadev","id":14901571,"avatar_url":"https://avatars.githubusercontent.com/u/14901571?v=3","gravatar_id":"","url":"https://api.github.com/users/yonadev","html_url":"https://github.com/yonadev","followers_url":"https://api.github.com/users/yonadev/followers","following_url":"https://api.github.com/users/yonadev/following{/other_user}","gists_url":"https://api.github.com/users/yonadev/gists{/gist_id}","starred_url":"https://api.github.com/users/yonadev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yonadev/subscriptions","organizations_url":"https://api.github.com/users/yonadev/orgs","repos_url":"https://api.github.com/users/yonadev/repos","events_url":"https://api.github.com/users/yonadev/events{/privacy}","received_events_url":"https://api.github.com/users/yonadev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yonadev/yona-server","description":"Yona Server","fork":false,"url":"https://api.github.com/repos/yonadev/yona-server","forks_url":"https://api.github.com/repos/yonadev/yona-server/forks","keys_url":"https://api.github.com/repos/yonadev/yona-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yonadev/yona-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yonadev/yona-server/teams","hooks_url":"https://api.github.com/repos/yonadev/yona-server/hooks","issue_events_url":"https://api.github.com/repos/yonadev/yona-server/issues/events{/number}","events_url":"https://api.github.com/repos/yonadev/yona-server/events","assignees_url":"https://api.github.com/repos/yonadev/yona-server/assignees{/user}","branches_url":"https://api.github.com/repos/yonadev/yona-server/branches{/branch}","tags_url":"https://api.github.com/repos/yonadev/yona-server/tags","blobs_url":"https://api.github.com/repos/yonadev/yona-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yonadev/yona-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yonadev/yona-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/yonadev/yona-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yonadev/yona-server/statuses/{sha}","languages_url":"https://api.github.com/repos/yonadev/yona-server/languages","stargazers_url":"https://api.github.com/repos/yonadev/yona-server/stargazers","contributors_url":"https://api.github.com/repos/yonadev/yona-server/contributors","subscribers_url":"https://api.github.com/repos/yonadev/yona-server/subscribers","subscription_url":"https://api.github.com/repos/yonadev/yona-server/subscription","commits_url":"https://api.github.com/repos/yonadev/yona-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/yonadev/yona-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/yonadev/yona-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/yonadev/yona-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/yonadev/yona-server/contents/{+path}","compare_url":"https://api.github.com/repos/yonadev/yona-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yonadev/yona-server/merges","archive_url":"https://api.github.com/repos/yonadev/yona-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yonadev/yona-server/downloads","issues_url":"https://api.github.com/repos/yonadev/yona-server/issues{/number}","pulls_url":"https://api.github.com/repos/yonadev/yona-server/pulls{/number}","milestones_url":"https://api.github.com/repos/yonadev/yona-server/milestones{/number}","notifications_url":"https://api.github.com/repos/yonadev/yona-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yonadev/yona-server/labels{/name}","releases_url":"https://api.github.com/repos/yonadev/yona-server/releases{/id}","created_at":"2015-10-03T05:33:54Z","updated_at":"2015-11-16T11:29:28Z","pushed_at":"2015-12-04T16:52:19Z","git_url":"git://github.com/yonadev/yona-server.git","ssh_url":"git@github.com:yonadev/yona-server.git","clone_url":"https://github.com/yonadev/yona-server.git","svn_url":"https://github.com/yonadev/yona-server","homepage":null,"size":1017,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":2,"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/59"},"html":{"href":"https://github.com/yonadev/yona-server/pull/59"},"issue":{"href":"https://api.github.com/repos/yonadev/yona-server/issues/59"},"comments":{"href":"https://api.github.com/repos/yonadev/yona-server/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yonadev/yona-server/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/yonadev/yona-server/statuses/d424d8455b0bd6c48c6b2e2d787c198386edfc60"}}}}