{"push_id":597961997,"size":15,"distinct_size":15,"ref":"refs/heads/master","head":"b15a7cbbb511ff22f577d505a9786da67e09e470","before":"6cca899554d9875babfb7a1dae77547af3f615a3","commits":[{"sha":"7cf04171511c7aa5c47a7fe2094f9abdaa066d02","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Added test that shows that nested scope inherits properly from cmdline, config, and env.\n\nTesting Done:\nI wrote this to test that https://rbcommons.com/s/twitter/r/1851/ did not break inheriting from a 'middle' scope, e.g. a config value set for 'compile' and 'DEFAULT' in  compile.java -> compile -> DEFAULT still properly inherts from 'compile' when you request a value for 'compile.java'\n\nIt pleasantly surprised me that it didn't break those cases, but then I discovered that some other scenarios that didn't work the way I expected.\n\nBugs closed: 1201\n\nReviewed at https://rbcommons.com/s/twitter/r/1865/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/7cf04171511c7aa5c47a7fe2094f9abdaa066d02"},{"sha":"7251ca00c350972c9d21b937d68a161b5a1cb388","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Update travis cache settings\n\nThe tool bootstrap dir has moved from ~/.pants.d to ~/.cache/pants\n\nTesting Done:\nI noticed a failure to download ivy in the bootstrap step on Travis-ci and thought it might be related to my change,  I think it was just a transient error.  Then I realized we shouldn't need to download ivy every time anyway.\n\nBugs closed: 1214\n\nReviewed at https://rbcommons.com/s/twitter/r/1875/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/7251ca00c350972c9d21b937d68a161b5a1cb388"},{"sha":"6099e650ba60c2a79cdfbd37cd02ed755130c3a7","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Make sure <?xml starts at the beginning of the file when creating an empty xml report\n\n- Make sure `<?xml` starts at the beginning of the file when creating an empty xml report.\n- Create the empty report under a different name to avoid confusing it with real ivy output.\n-  This change also raises an exception when the ivy report .xml file is not found.  I'm not sure why it wouldn't be there, and the\ncreation of ivy_jar_products now depends on it.\n\nTesting Done:\nCI is green at https://travis-ci.org/pantsbuild/pants/builds/53264069\n\nI don't think this code ever gets exercised, I forced it in a pdb session by setting a break point then moving the report aside.\n\n```\n ls -l /Users/zundel/.ivy2/pants/internal-f8ecb12181375ea82eee7fdf81233ebfaed4d60f-default*\n-rw-r--r--  1 zundel  zundel    409 Mar  5 17:17 /Users/zundel/.ivy2/pants/internal-f8ecb12181375ea82eee7fdf81233ebfaed4d60f-default-empty.xml\n-rw-r--r--  1 zundel  zundel  24974 Mar  5 17:14 /Users/zundel/.ivy2/pants/internal-f8ecb12181375ea82eee7fdf81233ebfaed4d60f-default.xml.old\n```\n\nwhile running ./pants idea examples/src/java:: --resove-ivy-open\n\nBefore this change, if  you do try to parse the file created by this function you get:\n\n```\n               FAILURE\n\nException message: XML or text declaration not at start of entity: line 2, column 8\n```\n\nBugs closed: 1196\n\nReviewed at https://rbcommons.com/s/twitter/r/1856/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/6099e650ba60c2a79cdfbd37cd02ed755130c3a7"},{"sha":"4bef68c53f49be3f8a7dbc310b11f1898e946f75","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Shard out OSX CI.\n\nThis manually mirrors most of the sharding in the main .travis.yml but\nkeeps ITs all in one shard to start.  If 4 shards proves stably\nschedulable the next step will be just programatically mirroring the\nmatrix env from the main .travis.yml build.\n\nAlso fix further issues this re-sharding exposed in\ntest_test_builder.py.  Force caching of just the current python\ninterpreter by restricting paths and simplify current interpreter\ncheck.\n\nFurthermore, setup a sane python for OSX CI - the stock 2.7.5 on OSX\n10.9 encounters issues with absolute imports in the coverage module.\n\nTesting Done:\nI applied this patch over on a pantsbuild/pants-for-travis-osx-ci clone\nand pushed for a manual test here:\n  https://travis-ci.org/pantsbuild/pants-for-travis-osx-ci/jobs/53298890\n\nLinux CI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/53300252\n\nBugs closed: 1212\n\nReviewed at https://rbcommons.com/s/twitter/r/1873/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/4bef68c53f49be3f8a7dbc310b11f1898e946f75"},{"sha":"6b32e545506cf5463bbdc59e5aa8dad88159b18b","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Fixup DxCompile jvm_options to be a list.\n\nThe underlying runjava call expects a list so this was always broken.\nThe issue surfaces because pants.ini defines a global jvm_options list\nthat is now seen as the default value for the option since a Config\nDEFAULT section inheritance fix went in.\n\nTesting Done:\nThis no longer fails:\n```console\n$ PANTS_DEV=1 ./pants clean-all binary examples/src/android::\n```\n\nCI away here:\n  https://travis-ci.org/pantsbuild/pants/builds/53413939\n\nBugs closed: 1217\n\nReviewed at https://rbcommons.com/s/twitter/r/1878/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/6b32e545506cf5463bbdc59e5aa8dad88159b18b"},{"sha":"7d87ef324bd935d204930c8d56546a3d55d0d3c5","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Make a nicer looking name for workunit output. Also adds the capability to access the filename. I have wanted access to this in the past.\n\n```\n src/python/pants/base/workunit.py | 13 ++++++++++++-\n 1 file changed, 12 insertions(+), 1 deletion(-)\n```\n\nTesting Done:\nThe names created for workunit output were cryptic when inspecting filenames manually.  I prepended the workunit name to the filename:\n\nNow you can quickly find the output you are interested on the command line:\n\n```\n./pants_run_2015_03_06_11_51_17_807/tool_outputs:\ntotal 240\n-rw-r--r--  1 zundel  zundel     0 Mar  6 11:51 antlr-0aa953f3-ecaf-42b9-922c-625f2c423d25.stderr\n-rw-r--r--  1 zundel  zundel     0 Mar  6 11:51 antlr-0aa953f3-ecaf-42b9-922c-625f2c423d25.stdout\n-rw-r--r--  1 zundel  zundel     0 Mar  6 11:51 antlr-9fb39976-b659-4fd3-9de8-20e24b0c1230.stderr\n-rw-r--r--  1 zundel  zundel     0 Mar  6 11:51 antlr-9fb39976-b659-4fd3-9de8-20e24b0c1230.stdout\n-rw-r--r--  1 zundel  zundel   104 Mar  6 11:51 bootstrap-antlr3-805f33b8-a85a-4d2d-8219-6294b8e4d768.stderr\n-rw-r--r--  1 zundel  zundel  1157 Mar  6 11:51 bootstrap-antlr3-805f33b8-a85a-4d2d-8219-6294b8e4d768.stdout\n```\n\nBugs closed: 1215\n\nReviewed at https://rbcommons.com/s/twitter/r/1876/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/7d87ef324bd935d204930c8d56546a3d55d0d3c5"},{"sha":"d8a8c311085bcc987d3be0b34f5bd73c2e5b2a41","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Update our requests library to something more recent\n\nI noticed that this library is way behind the current release which is 2.5.3.  See http://docs.python-requests.org/en/latest/community/updates/\n\nThere is some new support for https certficate integration with 'certifi' in 2.4.1 and beyond.\n\nTesting Done:\nCI is running at https://github.com/pantsbuild/pants/pull/1223\n\nTested locally on my mac.\n\nBugs closed: 1223\n\nReviewed at https://rbcommons.com/s/twitter/r/1884/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/d8a8c311085bcc987d3be0b34f5bd73c2e5b2a41"},{"sha":"7495668ac387e7b2a9f6223bba0cbaeeb534488b","author":{"email":"695d76d5a2f51dc9340d65ccd0d72ad7560773f9@squareup.com","name":"Eric Ayers"},"message":"Add some documentation about using the pants reporting server for troubleshooting.\n\nTesting Done:\nPublished with build-support/bin/publish_docs.sh -p -d zundel\n\nPreview: http://pantsbuild.github.io/zundel/tshoot.html\n\nBugs closed: 1225\n\nReviewed at https://rbcommons.com/s/twitter/r/1887/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/7495668ac387e7b2a9f6223bba0cbaeeb534488b"},{"sha":"490cef6860637f25ecc21891865034f6d0da299d","author":{"email":"e6790d662e1019ca6c466f6e9c1c2294cd870ba9@gmail.com","name":"Tejal Desai"},"message":"Add jar Publish integration tests to test the generated pom and ivy.xml files.\n\nAdd test to jar publish to test the contents of generated pom file and ivy.xml file\n\nThis is in preparation to change JarPublish task to publish extra products as a separate artifact with its own pom\n\nYou will seeing a patch and tests for the same soon.\n\nMore context here->\nhttps://groups.google.com/forum/#!search/Proposal$3A$20Make$20JarPublish$20task$20more$20configurable./pants-devel/S5l2_NXBtnw/Mf1pLj7P-kgJ\n\nThanks\nTejal.\n\nTesting Done:\nyes.\n\n./pants test.pytest tests/python/pants_test/tasks:jar_publish_integration is green\n\nhttps://travis-ci.org/pantsbuild/pants/builds/53424691\n\nReviewed at https://rbcommons.com/s/twitter/r/1879/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/490cef6860637f25ecc21891865034f6d0da299d"},{"sha":"540043eb103004959044a7bbc8556418e3a2b930","author":{"email":"e6790d662e1019ca6c466f6e9c1c2294cd870ba9@gmail.com","name":"Tejal Desai"},"message":"Fix new line to fix broken master build.\n\nFix new line\n\nTesting Done:\nFixing broken master build https://travis-ci.org/pantsbuild/pants/builds/53594112\n\nReviewed at https://rbcommons.com/s/twitter/r/1888/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/540043eb103004959044a7bbc8556418e3a2b930"},{"sha":"efb1112bfc0b15272fe35985884e767d48d9078f","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Kill the .saplings split.\n\nIts purpose has been fulfilled.\n\nTesting Done:\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/53506105\n\nBugs closed: 1224\n\nReviewed at https://rbcommons.com/s/twitter/r/1886/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/efb1112bfc0b15272fe35985884e767d48d9078f"},{"sha":"360f964cd475a5dcbbd192bb640d2c31be5b23e2","author":{"email":"86f39098c3d6e8fa24cceea9f4753c2782977b2d@gmail.com","name":"John Sirois"},"message":"Support local pre-commit checks.\n\nThis change adds a setup script that will install or re-install a\npre-commit hook to run pants lints.  The pre-commit script is also\nrunnable directly to support a centralized stable script developers can\nrun to execute all lints independent of performing a commit.\n\nTesting Done:\nLocal testing:\n```console\n# Install\n$ rm -f .git/hooks/pre-commit\n$ ./build-support/bin/setup.sh\nPre-commit checks installed from /home/jsirois/dev/3rdparty/jsirois-pants3/build-support/bin/pre-commit.sh to /home/jsirois/dev/3rdparty/jsirois-pants3/.git/hooks/pre-commit\n$ ./build-support/bin/setup.sh\nPre-commit checks up to date.\n\n# Unanticipated drift\n$ rm -f .git/hooks/pre-commit\n$ touch /home/jsirois/dev/3rdparty/jsirois-pants3/.git/hooks/pre-commit\n$ ./build-support/bin/setup.sh\nA pre-commit script already exists, replace with /home/jsirois/dev/3rdparty/jsirois-pants3/build-support/bin/pre-commit.sh? [Yn]n\nPre-commit checks not installed\n$ ./build-support/bin/setup.sh\nA pre-commit script already exists, replace with /home/jsirois/dev/3rdparty/jsirois-pants3/build-support/bin/pre-commit.sh? [Yn]\nPre-commit checks installed from /home/jsirois/dev/3rdparty/jsirois-pants3/build-support/bin/pre-commit.sh to /home/jsirois/dev/3rdparty/jsirois-pants3/.git/hooks/pre-commit\n$ ./build-support/bin/setup.sh\nPre-commit checks up to date.\n\n# Dogfood on this commit\n$ git commit\nChecking packages\nChecking imports\nChecking headers\nSuccess\n[jsirois/lints/commit_hooks 8458f3e] Support local pre-commit checks.\n 9 files changed, 71 insertions(+), 14 deletions(-)\n create mode 100755 build-support/bin/pre-commit.sh\n create mode 100755 build-support/bin/setup.sh\n```\n\nCI went green here:\n  https://travis-ci.org/pantsbuild/pants/builds/53506978\n\nBugs closed: 1222\n\nReviewed at https://rbcommons.com/s/twitter/r/1883/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/360f964cd475a5dcbbd192bb640d2c31be5b23e2"},{"sha":"d6c3090dc6933f4cf45e6206553b9ce3951c52a1","author":{"email":"ed026201722f54f9e918bd57c03c1b015d057bfd@po.cwru.edu","name":"Andy Reitz"},"message":"Add an example to demonstrate compiling & publishing thrift.\n\nTesting Done:\n./pants publish examples/src/java/com/pants/examples/make_it_rain --publish-local=/tmp --no-publish-dryrun --doc-javadoc-skip\n\nReviewed at https://rbcommons.com/s/twitter/r/1891/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/d6c3090dc6933f4cf45e6206553b9ce3951c52a1"},{"sha":"f9789b36bf614afbd4e03f7ddb0dea04c83a2d7c","author":{"email":"a13b1135e6f2f8530e85bc2896cd5ed89a6ed863@twopensource.com","name":"David Turner"},"message":"Prepare for release 0.0.29\n\nPrepare for release\n\nTesting Done:\n$ ./build-support/bin/release.sh -n\n\n[== 00:00 Performing a dry run release - no artifacts will be uploaded. ==]\n[== 00:29 Building package pantsbuild.pants-~/workspace/pants/build-support ~/workspace/pants\nvirtualenv-12.0.7 -> virtualenv.dist\n~/workspace/pants\nNew python executable in /Users/ity/workspace/pants/build-support/pants_dev_deps.venv/bin/python2.7\nAlso creating executable in /Users/ity/workspace/pants/build-support/pants_dev_deps.venv/bin/python\n.. ==]\n[== 00:34 Building package pantsbuild.pants.testinfra-0.0.29 with target '//src/python/pants:test_infra' ... ==]\n[== 01:19 Building package pantsbuild.pants.contrib.scrooge-0.0.29 with target '//contrib/scrooge/src/python/pants/contrib/scrooge:plugin' ... ==]\n[== 01:22 Installing and testing package pantsbuild.pants-0.0.29 ... ==]\n[== 01:48 Installing and testing package pantsbuild.pants.testinfra-0.0.29 ... ==]\n[== 02:09 Installing and testing package pantsbuild.pants.contrib.scrooge-0.0.29 ... ==]\n[== 02:31 Dry run release succeeded. ==]\n\nReviewed at https://rbcommons.com/s/twitter/r/1890/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/f9789b36bf614afbd4e03f7ddb0dea04c83a2d7c"},{"sha":"b15a7cbbb511ff22f577d505a9786da67e09e470","author":{"email":"bb1f132dcb86bfc59bf4a043a3139a9ac7c0b658@gmail.com","name":"Stu Hood"},"message":"Split out a JvmCompileStrategy interface\n\nSecond step in the implementation of https://docs.google.com/a/twitter.com/document/d/1E-eysqdKUz7IvL5snRNe7orW24A9AzcApt9q50UpwAc/edit?pli=1#\n\n+ Split JvmCompileStrategy out of JvmCompile and give it all references to:\n-- the global classpath\n-- the global analysis\n-- \"partitioning\" within chunks\n+ Add the existing JvmCompileStrategy as JvmCompileGlobalStrategy.\n+ Propagate a classes dir into analysis parsers on a case-by-case basis.\n+ Introduce compile_context, and begin passing it around in place of targets.\n+ Use a dedicated directory for the global PROCESSOR_INFO_FILE in JavaCompile.\n+ Assert that all classpath entries were contained within the working copy, to avoid the need to relativize to the ivy cache dir.\n\nThis strategy class isolates all behavior related to partitioning and the global classpath, and begins to pass targets with a CompileContext that indicates where their analysis and classes live.\n\nI'm going to begin working on the isolated strategy, and a unit test harness to allow for running tests with both strategies.\n\nTesting Done:\nFixed the last failure: was related to annotation processors. Might have a proposal for improving that situation; will post it after the next review.\nhttps://github.com/pantsbuild/pants/pull/1220\n\nReviewed at https://rbcommons.com/s/twitter/r/1885/","distinct":true,"url":"https://api.github.com/repos/benjyw/pants/commits/b15a7cbbb511ff22f577d505a9786da67e09e470"}]}