{"action":"created","comment":{"url":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments/31257537","id":31257537,"diff_hunk":"@@ -1883,6 +1883,31 @@ def get_cipher_version(self):\n             return version.decode(\"utf-8\")\n \n \n+    def get_protocol_version_name(self):\n+        \"\"\"\n+        Obtain the protocol version of the current connection.\n+\n+        :returns: The TLS version of the current connection, for example\n+            the value for TLS 1.2 would be ``TLSv1.2``or ``Unknown``\n+            for connections that were not successfully.","path":"OpenSSL/SSL.py","position":10,"original_position":10,"commit_id":"58d257327d3cee9ef8dcd03a3e47973d791ed94b","original_commit_id":"58d257327d3cee9ef8dcd03a3e47973d791ed94b","user":{"login":"hynek","id":41240,"avatar_url":"https://avatars.githubusercontent.com/u/41240?v=3","gravatar_id":"","url":"https://api.github.com/users/hynek","html_url":"https://github.com/hynek","followers_url":"https://api.github.com/users/hynek/followers","following_url":"https://api.github.com/users/hynek/following{/other_user}","gists_url":"https://api.github.com/users/hynek/gists{/gist_id}","starred_url":"https://api.github.com/users/hynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hynek/subscriptions","organizations_url":"https://api.github.com/users/hynek/orgs","repos_url":"https://api.github.com/users/hynek/repos","events_url":"https://api.github.com/users/hynek/events{/privacy}","received_events_url":"https://api.github.com/users/hynek/received_events","type":"User","site_admin":false},"body":"successfully what?","created_at":"2015-05-28T17:31:23Z","updated_at":"2015-05-28T17:31:23Z","html_url":"https://github.com/pyca/pyopenssl/pull/244#discussion_r31257537","pull_request_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/244","_links":{"self":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments/31257537"},"html":{"href":"https://github.com/pyca/pyopenssl/pull/244#discussion_r31257537"},"pull_request":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/244"}}},"pull_request":{"url":"https://api.github.com/repos/pyca/pyopenssl/pulls/244","id":34139222,"html_url":"https://github.com/pyca/pyopenssl/pull/244","diff_url":"https://github.com/pyca/pyopenssl/pull/244.diff","patch_url":"https://github.com/pyca/pyopenssl/pull/244.patch","issue_url":"https://api.github.com/repos/pyca/pyopenssl/issues/244","number":244,"state":"open","locked":false,"title":"Add support for querying the negotiated TLS version.  The Quickening","user":{"login":"elitest","id":5925087,"avatar_url":"https://avatars.githubusercontent.com/u/5925087?v=3","gravatar_id":"","url":"https://api.github.com/users/elitest","html_url":"https://github.com/elitest","followers_url":"https://api.github.com/users/elitest/followers","following_url":"https://api.github.com/users/elitest/following{/other_user}","gists_url":"https://api.github.com/users/elitest/gists{/gist_id}","starred_url":"https://api.github.com/users/elitest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elitest/subscriptions","organizations_url":"https://api.github.com/users/elitest/orgs","repos_url":"https://api.github.com/users/elitest/repos","events_url":"https://api.github.com/users/elitest/events{/privacy}","received_events_url":"https://api.github.com/users/elitest/received_events","type":"User","site_admin":false},"body":"This PR hopefully finished up the work done by @richmoore in #184.  Thanks to @alex for helping me figure out how to get SSL_get_version implemented.  This PR requires the merge that happened in pyca/cryptography#1869, so do we wait until the next release of cryptography and then bump the required version number in setup.py?\r\n\r\nI'm happy to hear feedback on whether the change to strings requires better/different testing?\r\n\r\nAlso the [OpenSSL docs](https://www.openssl.org/docs/ssl/SSL_get_version.html) have been updated since the original PR in January, and this does actually support TLS1.1 and TLS1.2 :)","created_at":"2015-04-27T04:39:01Z","updated_at":"2015-05-28T17:31:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db3eff8c2ed895fa55542eaf8b68fa9bc963e04f","assignee":null,"milestone":{"url":"https://api.github.com/repos/pyca/pyopenssl/milestones/3","html_url":"https://github.com/pyca/pyopenssl/milestones/0.16","labels_url":"https://api.github.com/repos/pyca/pyopenssl/milestones/3/labels","id":1067679,"number":3,"title":"0.16","description":"","creator":{"login":"reaperhulk","id":161495,"avatar_url":"https://avatars.githubusercontent.com/u/161495?v=3","gravatar_id":"","url":"https://api.github.com/users/reaperhulk","html_url":"https://github.com/reaperhulk","followers_url":"https://api.github.com/users/reaperhulk/followers","following_url":"https://api.github.com/users/reaperhulk/following{/other_user}","gists_url":"https://api.github.com/users/reaperhulk/gists{/gist_id}","starred_url":"https://api.github.com/users/reaperhulk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reaperhulk/subscriptions","organizations_url":"https://api.github.com/users/reaperhulk/orgs","repos_url":"https://api.github.com/users/reaperhulk/repos","events_url":"https://api.github.com/users/reaperhulk/events{/privacy}","received_events_url":"https://api.github.com/users/reaperhulk/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":14,"state":"open","created_at":"2015-04-14T20:46:02Z","updated_at":"2015-05-28T15:41:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/244/commits","review_comments_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/244/comments","review_comment_url":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pyca/pyopenssl/issues/244/comments","statuses_url":"https://api.github.com/repos/pyca/pyopenssl/statuses/58d257327d3cee9ef8dcd03a3e47973d791ed94b","head":{"label":"elitest:session-tls-version","ref":"session-tls-version","sha":"58d257327d3cee9ef8dcd03a3e47973d791ed94b","user":{"login":"elitest","id":5925087,"avatar_url":"https://avatars.githubusercontent.com/u/5925087?v=3","gravatar_id":"","url":"https://api.github.com/users/elitest","html_url":"https://github.com/elitest","followers_url":"https://api.github.com/users/elitest/followers","following_url":"https://api.github.com/users/elitest/following{/other_user}","gists_url":"https://api.github.com/users/elitest/gists{/gist_id}","starred_url":"https://api.github.com/users/elitest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elitest/subscriptions","organizations_url":"https://api.github.com/users/elitest/orgs","repos_url":"https://api.github.com/users/elitest/repos","events_url":"https://api.github.com/users/elitest/events{/privacy}","received_events_url":"https://api.github.com/users/elitest/received_events","type":"User","site_admin":false},"repo":{"id":33972856,"name":"pyopenssl","full_name":"elitest/pyopenssl","owner":{"login":"elitest","id":5925087,"avatar_url":"https://avatars.githubusercontent.com/u/5925087?v=3","gravatar_id":"","url":"https://api.github.com/users/elitest","html_url":"https://github.com/elitest","followers_url":"https://api.github.com/users/elitest/followers","following_url":"https://api.github.com/users/elitest/following{/other_user}","gists_url":"https://api.github.com/users/elitest/gists{/gist_id}","starred_url":"https://api.github.com/users/elitest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elitest/subscriptions","organizations_url":"https://api.github.com/users/elitest/orgs","repos_url":"https://api.github.com/users/elitest/repos","events_url":"https://api.github.com/users/elitest/events{/privacy}","received_events_url":"https://api.github.com/users/elitest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/elitest/pyopenssl","description":"Python interface to the OpenSSL library","fork":true,"url":"https://api.github.com/repos/elitest/pyopenssl","forks_url":"https://api.github.com/repos/elitest/pyopenssl/forks","keys_url":"https://api.github.com/repos/elitest/pyopenssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elitest/pyopenssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elitest/pyopenssl/teams","hooks_url":"https://api.github.com/repos/elitest/pyopenssl/hooks","issue_events_url":"https://api.github.com/repos/elitest/pyopenssl/issues/events{/number}","events_url":"https://api.github.com/repos/elitest/pyopenssl/events","assignees_url":"https://api.github.com/repos/elitest/pyopenssl/assignees{/user}","branches_url":"https://api.github.com/repos/elitest/pyopenssl/branches{/branch}","tags_url":"https://api.github.com/repos/elitest/pyopenssl/tags","blobs_url":"https://api.github.com/repos/elitest/pyopenssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elitest/pyopenssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elitest/pyopenssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/elitest/pyopenssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elitest/pyopenssl/statuses/{sha}","languages_url":"https://api.github.com/repos/elitest/pyopenssl/languages","stargazers_url":"https://api.github.com/repos/elitest/pyopenssl/stargazers","contributors_url":"https://api.github.com/repos/elitest/pyopenssl/contributors","subscribers_url":"https://api.github.com/repos/elitest/pyopenssl/subscribers","subscription_url":"https://api.github.com/repos/elitest/pyopenssl/subscription","commits_url":"https://api.github.com/repos/elitest/pyopenssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/elitest/pyopenssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/elitest/pyopenssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/elitest/pyopenssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/elitest/pyopenssl/contents/{+path}","compare_url":"https://api.github.com/repos/elitest/pyopenssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elitest/pyopenssl/merges","archive_url":"https://api.github.com/repos/elitest/pyopenssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elitest/pyopenssl/downloads","issues_url":"https://api.github.com/repos/elitest/pyopenssl/issues{/number}","pulls_url":"https://api.github.com/repos/elitest/pyopenssl/pulls{/number}","milestones_url":"https://api.github.com/repos/elitest/pyopenssl/milestones{/number}","notifications_url":"https://api.github.com/repos/elitest/pyopenssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elitest/pyopenssl/labels{/name}","releases_url":"https://api.github.com/repos/elitest/pyopenssl/releases{/id}","created_at":"2015-04-15T04:19:10Z","updated_at":"2015-05-06T02:01:12Z","pushed_at":"2015-05-28T15:54:30Z","git_url":"git://github.com/elitest/pyopenssl.git","ssh_url":"git@github.com:elitest/pyopenssl.git","clone_url":"https://github.com/elitest/pyopenssl.git","svn_url":"https://github.com/elitest/pyopenssl","homepage":null,"size":10097,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pyca:master","ref":"master","sha":"51dc335469f779ba1e3e356163108bb46eaca01c","user":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"repo":{"id":15778059,"name":"pyopenssl","full_name":"pyca/pyopenssl","owner":{"login":"pyca","id":5615737,"avatar_url":"https://avatars.githubusercontent.com/u/5615737?v=3","gravatar_id":"","url":"https://api.github.com/users/pyca","html_url":"https://github.com/pyca","followers_url":"https://api.github.com/users/pyca/followers","following_url":"https://api.github.com/users/pyca/following{/other_user}","gists_url":"https://api.github.com/users/pyca/gists{/gist_id}","starred_url":"https://api.github.com/users/pyca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pyca/subscriptions","organizations_url":"https://api.github.com/users/pyca/orgs","repos_url":"https://api.github.com/users/pyca/repos","events_url":"https://api.github.com/users/pyca/events{/privacy}","received_events_url":"https://api.github.com/users/pyca/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pyca/pyopenssl","description":"Python interface to the OpenSSL library","fork":false,"url":"https://api.github.com/repos/pyca/pyopenssl","forks_url":"https://api.github.com/repos/pyca/pyopenssl/forks","keys_url":"https://api.github.com/repos/pyca/pyopenssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pyca/pyopenssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pyca/pyopenssl/teams","hooks_url":"https://api.github.com/repos/pyca/pyopenssl/hooks","issue_events_url":"https://api.github.com/repos/pyca/pyopenssl/issues/events{/number}","events_url":"https://api.github.com/repos/pyca/pyopenssl/events","assignees_url":"https://api.github.com/repos/pyca/pyopenssl/assignees{/user}","branches_url":"https://api.github.com/repos/pyca/pyopenssl/branches{/branch}","tags_url":"https://api.github.com/repos/pyca/pyopenssl/tags","blobs_url":"https://api.github.com/repos/pyca/pyopenssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pyca/pyopenssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pyca/pyopenssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/pyca/pyopenssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pyca/pyopenssl/statuses/{sha}","languages_url":"https://api.github.com/repos/pyca/pyopenssl/languages","stargazers_url":"https://api.github.com/repos/pyca/pyopenssl/stargazers","contributors_url":"https://api.github.com/repos/pyca/pyopenssl/contributors","subscribers_url":"https://api.github.com/repos/pyca/pyopenssl/subscribers","subscription_url":"https://api.github.com/repos/pyca/pyopenssl/subscription","commits_url":"https://api.github.com/repos/pyca/pyopenssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/pyca/pyopenssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/pyca/pyopenssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/pyca/pyopenssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/pyca/pyopenssl/contents/{+path}","compare_url":"https://api.github.com/repos/pyca/pyopenssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pyca/pyopenssl/merges","archive_url":"https://api.github.com/repos/pyca/pyopenssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pyca/pyopenssl/downloads","issues_url":"https://api.github.com/repos/pyca/pyopenssl/issues{/number}","pulls_url":"https://api.github.com/repos/pyca/pyopenssl/pulls{/number}","milestones_url":"https://api.github.com/repos/pyca/pyopenssl/milestones{/number}","notifications_url":"https://api.github.com/repos/pyca/pyopenssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pyca/pyopenssl/labels{/name}","releases_url":"https://api.github.com/repos/pyca/pyopenssl/releases{/id}","created_at":"2014-01-09T20:10:36Z","updated_at":"2015-05-28T05:50:08Z","pushed_at":"2015-05-28T15:54:30Z","git_url":"git://github.com/pyca/pyopenssl.git","ssh_url":"git@github.com:pyca/pyopenssl.git","clone_url":"https://github.com/pyca/pyopenssl.git","svn_url":"https://github.com/pyca/pyopenssl","homepage":null,"size":11900,"stargazers_count":160,"watchers_count":160,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":120,"mirror_url":null,"open_issues_count":79,"forks":120,"open_issues":79,"watchers":160,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/244"},"html":{"href":"https://github.com/pyca/pyopenssl/pull/244"},"issue":{"href":"https://api.github.com/repos/pyca/pyopenssl/issues/244"},"comments":{"href":"https://api.github.com/repos/pyca/pyopenssl/issues/244/comments"},"review_comments":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/244/comments"},"review_comment":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pyca/pyopenssl/pulls/244/commits"},"statuses":{"href":"https://api.github.com/repos/pyca/pyopenssl/statuses/58d257327d3cee9ef8dcd03a3e47973d791ed94b"}}}}