{"action":"created","issue":{"url":"https://api.github.com/repos/pyopencl/pyopencl/issues/80","labels_url":"https://api.github.com/repos/pyopencl/pyopencl/issues/80/labels{/name}","comments_url":"https://api.github.com/repos/pyopencl/pyopencl/issues/80/comments","events_url":"https://api.github.com/repos/pyopencl/pyopencl/issues/80/events","html_url":"https://github.com/pyopencl/pyopencl/pull/80","id":95290884,"number":80,"title":"Bitonic sort","user":{"login":"inducer","id":352067,"avatar_url":"https://avatars.githubusercontent.com/u/352067?v=3","gravatar_id":"","url":"https://api.github.com/users/inducer","html_url":"https://github.com/inducer","followers_url":"https://api.github.com/users/inducer/followers","following_url":"https://api.github.com/users/inducer/following{/other_user}","gists_url":"https://api.github.com/users/inducer/gists{/gist_id}","starred_url":"https://api.github.com/users/inducer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inducer/subscriptions","organizations_url":"https://api.github.com/users/inducer/orgs","repos_url":"https://api.github.com/users/inducer/repos","events_url":"https://api.github.com/users/inducer/events{/privacy}","received_events_url":"https://api.github.com/users/inducer/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":9,"created_at":"2015-07-15T21:09:16Z","updated_at":"2015-08-17T11:04:30Z","closed_at":"2015-07-16T17:21:24Z","pull_request":{"url":"https://api.github.com/repos/pyopencl/pyopencl/pulls/80","html_url":"https://github.com/pyopencl/pyopencl/pull/80","diff_url":"https://github.com/pyopencl/pyopencl/pull/80.diff","patch_url":"https://github.com/pyopencl/pyopencl/pull/80.patch"},"body":"Get @inferrna's bitonic sort ready for inclusion."},"comment":{"url":"https://api.github.com/repos/pyopencl/pyopencl/issues/comments/131782114","html_url":"https://github.com/pyopencl/pyopencl/pull/80#issuecomment-131782114","issue_url":"https://api.github.com/repos/pyopencl/pyopencl/issues/80","id":131782114,"user":{"login":"inferrna","id":4245277,"avatar_url":"https://avatars.githubusercontent.com/u/4245277?v=3","gravatar_id":"","url":"https://api.github.com/users/inferrna","html_url":"https://github.com/inferrna","followers_url":"https://api.github.com/users/inferrna/followers","following_url":"https://api.github.com/users/inferrna/following{/other_user}","gists_url":"https://api.github.com/users/inferrna/gists{/gist_id}","starred_url":"https://api.github.com/users/inferrna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inferrna/subscriptions","organizations_url":"https://api.github.com/users/inferrna/orgs","repos_url":"https://api.github.com/users/inferrna/repos","events_url":"https://api.github.com/users/inferrna/events{/privacy}","received_events_url":"https://api.github.com/users/inferrna/received_events","type":"User","site_admin":false},"created_at":"2015-08-17T11:04:30Z","updated_at":"2015-08-17T11:04:30Z","body":"I found an (possible) bug and also unused typedef in bitonic_sort_templates.py. First, string\r\n```C\r\ntypedef ${idxtype}2 idx_t2;\r\n```\r\ncan be safely removed from bitonic_sort_templates.py.\r\n\r\nSecond:\r\nThe bug is in function dtype_to_ctype(): it converts uint32 as 'unsigned' but there isn't described unsignedn vector type at https://www.khronos.org/registry/cl/sdk/1.2/docs/man/xhtml/vectorDataTypes.html . And also dtype_to_ctype() converts other integer types non vector-friendly.\r\nIt will break any template expressions like ${dtype}n. In my case beignet fails to compile kernel with\r\n```C\r\ntypedef unsigned2 idx_t2;\r\n```\r\nas it turned out, I have planned, but never used idx_t2 in this template."}}