{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/119","labels_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/119/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/119/comments","events_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/119/events","html_url":"https://github.com/mozilla/teach.webmaker.org/issues/119","id":59740464,"number":119,"title":"Code review HTML/CSS/LESS","user":{"login":"simonwex","id":25260,"avatar_url":"https://avatars.githubusercontent.com/u/25260?v=3","gravatar_id":"","url":"https://api.github.com/users/simonwex","html_url":"https://github.com/simonwex","followers_url":"https://api.github.com/users/simonwex/followers","following_url":"https://api.github.com/users/simonwex/following{/other_user}","gists_url":"https://api.github.com/users/simonwex/gists{/gist_id}","starred_url":"https://api.github.com/users/simonwex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonwex/subscriptions","organizations_url":"https://api.github.com/users/simonwex/orgs","repos_url":"https://api.github.com/users/simonwex/repos","events_url":"https://api.github.com/users/simonwex/events{/privacy}","received_events_url":"https://api.github.com/users/simonwex/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-03-04T02:15:48Z","updated_at":"2015-03-06T23:17:51Z","closed_at":null,"body":"_From @toolness on February 26, 2015 19:3_\n\nI don't consider myself an HTML, CSS, or LESS expert, so I'd appreciate some code review (or I can rubber duck w/ someone). In particular:\r\n\r\n* I'm using LESS, but I'm not actually building Bootstrap from LESS; just importing its `variables.less` to reuse some of its variables. Not sure if that is cool or not.\r\n* Not sure how well my CSS rules follow best practices. For instance, I'm using `>` in a number of my rules, which could break as HTML changes--might be better to come up with explicit classes for such things.\r\n* Cassie's original mockups used a 16-column grid, while Bootstrap uses a 12-column grid. My code attempts to resolve this by [nesting columns](http://getbootstrap.com/css/#grid-nesting), which I'm not sure is the best approach.\r\n* I'm using CSS flex layout a *lot* but I'm not sure how smart that is; I guess it depends on what our criteria for browser compatibility is, and how bad the site looks on browsers without flex support. According to [caniuse](http://caniuse.com/#search=flex) it appears IE9 doesn't support flex layout at all, while IE10 only partially supports it. Also not sure about the stock Android browser on older versions of Android.\r\n* I suspect I'm not using the most semantically-relevant HTML tags that I could be using, so that could use some review.\r\n* I doubt my HTML works very well on screen-readers, so I should probably check that. And run the HTML through a validator, perhaps.\r\n\n\n_Copied from original issue: toolness/mozilla-learning-html#9_"},"comment":{"url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/comments/77654176","html_url":"https://github.com/mozilla/teach.webmaker.org/issues/119#issuecomment-77654176","issue_url":"https://api.github.com/repos/mozilla/teach.webmaker.org/issues/119","id":77654176,"user":{"login":"gesa","id":782056,"avatar_url":"https://avatars.githubusercontent.com/u/782056?v=3","gravatar_id":"","url":"https://api.github.com/users/gesa","html_url":"https://github.com/gesa","followers_url":"https://api.github.com/users/gesa/followers","following_url":"https://api.github.com/users/gesa/following{/other_user}","gists_url":"https://api.github.com/users/gesa/gists{/gist_id}","starred_url":"https://api.github.com/users/gesa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gesa/subscriptions","organizations_url":"https://api.github.com/users/gesa/orgs","repos_url":"https://api.github.com/users/gesa/repos","events_url":"https://api.github.com/users/gesa/events{/privacy}","received_events_url":"https://api.github.com/users/gesa/received_events","type":"User","site_admin":false},"created_at":"2015-03-06T23:17:51Z","updated_at":"2015-03-06T23:17:51Z","body":"I'm also so happy to offer some insight on this!"}}