{"action":"created","issue":{"url":"https://api.github.com/repos/cappuccino/cappuccino/issues/1892","labels_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/1892/labels{/name}","comments_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/1892/comments","events_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/1892/events","html_url":"https://github.com/cappuccino/cappuccino/pull/1892","id":12702789,"number":1892,"title":"CPTableView formatting and fixes [+1]","user":{"login":"cacaodev","id":26049,"avatar_url":"https://avatars.githubusercontent.com/u/26049?v=3","gravatar_id":"","url":"https://api.github.com/users/cacaodev","html_url":"https://github.com/cacaodev","followers_url":"https://api.github.com/users/cacaodev/followers","following_url":"https://api.github.com/users/cacaodev/following{/other_user}","gists_url":"https://api.github.com/users/cacaodev/gists{/gist_id}","starred_url":"https://api.github.com/users/cacaodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacaodev/subscriptions","organizations_url":"https://api.github.com/users/cacaodev/orgs","repos_url":"https://api.github.com/users/cacaodev/repos","events_url":"https://api.github.com/users/cacaodev/events{/privacy}","received_events_url":"https://api.github.com/users/cacaodev/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cappuccino/cappuccino/labels/%23fixed","name":"#fixed","color":"cbf49c"},{"url":"https://api.github.com/repos/cappuccino/cappuccino/labels/AppKit","name":"AppKit","color":"ededed"},{"url":"https://api.github.com/repos/cappuccino/cappuccino/labels/feature","name":"feature","color":"adcdff"}],"state":"closed","locked":false,"assignee":{"login":"aljungberg","id":154423,"avatar_url":"https://avatars.githubusercontent.com/u/154423?v=3","gravatar_id":"","url":"https://api.github.com/users/aljungberg","html_url":"https://github.com/aljungberg","followers_url":"https://api.github.com/users/aljungberg/followers","following_url":"https://api.github.com/users/aljungberg/following{/other_user}","gists_url":"https://api.github.com/users/aljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljungberg/subscriptions","organizations_url":"https://api.github.com/users/aljungberg/orgs","repos_url":"https://api.github.com/users/aljungberg/repos","events_url":"https://api.github.com/users/aljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/aljungberg/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/cappuccino/cappuccino/milestones/7","labels_url":"https://api.github.com/repos/cappuccino/cappuccino/milestones/7/labels","id":632761,"number":7,"title":"0.9.9","description":null,"creator":{"login":"aljungberg","id":154423,"avatar_url":"https://avatars.githubusercontent.com/u/154423?v=3","gravatar_id":"","url":"https://api.github.com/users/aljungberg","html_url":"https://github.com/aljungberg","followers_url":"https://api.github.com/users/aljungberg/followers","following_url":"https://api.github.com/users/aljungberg/following{/other_user}","gists_url":"https://api.github.com/users/aljungberg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljungberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljungberg/subscriptions","organizations_url":"https://api.github.com/users/aljungberg/orgs","repos_url":"https://api.github.com/users/aljungberg/repos","events_url":"https://api.github.com/users/aljungberg/events{/privacy}","received_events_url":"https://api.github.com/users/aljungberg/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":3,"state":"open","created_at":"2014-04-17T08:38:47Z","updated_at":"2015-02-06T23:52:36Z","due_on":null,"closed_at":null},"comments":48,"created_at":"2013-04-02T12:32:17Z","updated_at":"2015-02-07T17:52:16Z","closed_at":"2015-02-06T23:52:36Z","pull_request":{"url":"https://api.github.com/repos/cappuccino/cappuccino/pulls/1892","html_url":"https://github.com/cappuccino/cappuccino/pull/1892","diff_url":"https://github.com/cappuccino/cappuccino/pull/1892.diff","patch_url":"https://github.com/cappuccino/cappuccino/pull/1892.patch"},"body":"There might be a \"breaking change\" here, in commit  be7f6ae. I didn't mention it in the commit message because i wanted your input first.\r\nPreviously, -reloadData was reloading everything: the views, the data and performing various tasks needed to setup the view. Now it just fetches the data from the model and applies it to the view. Except when the number of rows changed: in this case we reload the views like we did before meaning that when calling -reloadData from the controller after a row insertion/removal, there should be no change. To be sure nothing breaks, i would like to know how you use -reloadData in your controllers and if you need the views to be reloaded even when the number of rows in the content did not change.\r\n\r\nThere is one situation I can think of where reloading the views might be useful but i don't think anyone ever tested it. It's when using view-based tables with the delegate for creating views. You may want to initiate a remote request to fetch some data (lazy loading) and then create a view in the delegate based on the content. In this case, you need to tell the table to reload one or more specific views when the data is received.\r\nIf we do this, we will need a new implementation, not the previous reloadData (renamed _reloadDataViews here) . This method was not fetching the views from the delegate, instead, we were just enqueuing the views in the cache and redistributing them with new values and new frames, which is not enough."},"comment":{"url":"https://api.github.com/repos/cappuccino/cappuccino/issues/comments/73374699","html_url":"https://github.com/cappuccino/cappuccino/pull/1892#issuecomment-73374699","issue_url":"https://api.github.com/repos/cappuccino/cappuccino/issues/1892","id":73374699,"user":{"login":"cacaodev","id":26049,"avatar_url":"https://avatars.githubusercontent.com/u/26049?v=3","gravatar_id":"","url":"https://api.github.com/users/cacaodev","html_url":"https://github.com/cacaodev","followers_url":"https://api.github.com/users/cacaodev/followers","following_url":"https://api.github.com/users/cacaodev/following{/other_user}","gists_url":"https://api.github.com/users/cacaodev/gists{/gist_id}","starred_url":"https://api.github.com/users/cacaodev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cacaodev/subscriptions","organizations_url":"https://api.github.com/users/cacaodev/orgs","repos_url":"https://api.github.com/users/cacaodev/repos","events_url":"https://api.github.com/users/cacaodev/events{/privacy}","received_events_url":"https://api.github.com/users/cacaodev/received_events","type":"User","site_admin":false},"created_at":"2015-02-07T17:52:16Z","updated_at":"2015-02-07T17:52:16Z","body":"There is a style issue with this commit. A lot of brackets are not correctly aligned. It may be because of a setting in my merging tool.\r\nSorry for that. I believe the only solution is to manually fix this (capp_lint does not detect that). I'll do it."}}