{"action":"created","comment":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/25113068","id":25113068,"diff_hunk":"@@ -11,19 +13,20 @@ Ember.Widgets.DomHelper = Ember.Mixin.create\n     UP: 38,\n     ESCAPE: 27\n \n-  # Set the selected range to the given element, with the option to collapse the selection to the\n-  # beginning or end\n+  # Set the selected range to the given element, with the option to collapse\n+  # the selection to the beginning or end\n   #   element       the element to select\n   #   collapseMode  \"none\", \"beginning\", \"end\"\n   selectElement: (document, element, collapseMode=\"end\") ->\n-    # http://stackoverflow.com/questions/1125292/how-to-move-cursor-to-end-of-contenteditable-entity\n+    # http://bit.ly/1tOBYVf","path":"app/mixins/dom-helper.coffee","position":20,"original_position":20,"commit_id":"e7e7119703c560eab51ba6392db817f1480ff2d3","original_commit_id":"e7e7119703c560eab51ba6392db817f1480ff2d3","user":{"login":"azirbel","id":498245,"avatar_url":"https://avatars.githubusercontent.com/u/498245?v=3","gravatar_id":"","url":"https://api.github.com/users/azirbel","html_url":"https://github.com/azirbel","followers_url":"https://api.github.com/users/azirbel/followers","following_url":"https://api.github.com/users/azirbel/following{/other_user}","gists_url":"https://api.github.com/users/azirbel/gists{/gist_id}","starred_url":"https://api.github.com/users/azirbel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azirbel/subscriptions","organizations_url":"https://api.github.com/users/azirbel/orgs","repos_url":"https://api.github.com/users/azirbel/repos","events_url":"https://api.github.com/users/azirbel/events{/privacy}","received_events_url":"https://api.github.com/users/azirbel/received_events","type":"User","site_admin":false},"body":"Agree","created_at":"2015-02-20T23:41:09Z","updated_at":"2015-02-20T23:41:09Z","html_url":"https://github.com/Addepar/ember-widgets/pull/167#discussion_r25113068","pull_request_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167","_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/25113068"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/167#discussion_r25113068"},"pull_request":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167"}}},"pull_request":{"url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167","id":27470224,"html_url":"https://github.com/Addepar/ember-widgets/pull/167","diff_url":"https://github.com/Addepar/ember-widgets/pull/167.diff","patch_url":"https://github.com/Addepar/ember-widgets/pull/167.patch","issue_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/167","number":167,"state":"open","locked":false,"title":"Add ember-cli support","user":{"login":"igillis","id":1626003,"avatar_url":"https://avatars.githubusercontent.com/u/1626003?v=3","gravatar_id":"","url":"https://api.github.com/users/igillis","html_url":"https://github.com/igillis","followers_url":"https://api.github.com/users/igillis/followers","following_url":"https://api.github.com/users/igillis/following{/other_user}","gists_url":"https://api.github.com/users/igillis/gists{/gist_id}","starred_url":"https://api.github.com/users/igillis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/igillis/subscriptions","organizations_url":"https://api.github.com/users/igillis/orgs","repos_url":"https://api.github.com/users/igillis/repos","events_url":"https://api.github.com/users/igillis/events{/privacy}","received_events_url":"https://api.github.com/users/igillis/received_events","type":"User","site_admin":false},"body":"This diff turns ember-widgets into an ember-cli addon. It introduces the following breaking changes:\r\n\r\n- View helpers have been dropped in favor of components.\r\n- Some components have been renamed to be consistent with ember-cli style.\r\n\r\nTests still don't work. There is a build system in `packaging/` for generating old, globals-style builds, but second breaking change above still applies to that build. \r\n\r\nI'm not really sure how we should go about reviewing this. I think you can manually look at the stuff in packaging/ and for the rest you're best off just checking this branch out and running the demo app to mess around with stuff.\r\n\r\n@ebryn @azirbel @bjcohen @cyril-sf \r\n\r\nAdded by Alex - major questions to answer\r\n\r\n- [x] How does the release & versioning process work? **Answer:** Same as it used to (grunt-release-it)\r\n- [x] How will we host the demo app? (GH pages again? Do we need another build step?) **Answer:** It's in `tests/dummy`. Thanks Ember-CLI.\r\n- [x] Should all addon code go in the addon folder?\r\n- [x] When should we update documentation? **Answer:** Now.\r\n- [x] Can we make the globals build totally backwards compatible? Might just be a matter of adding some special cases to `globals.js`/`registry.js` or changing some file names. **Answer:** No. At the very least, use of view helpers will be deprecated in favor of components syntax.\r\n\r\nIan's TODOs\r\n- [x] Try moving to `addon/` folder (failed. Issue with coffeescript and ember addons)\r\n- [x] Fix file copying derps (CHANGELOG, VERSION, etc.)\r\n- [x] Add license .hbs file\r\n- [x] Document component name changes\r\n- [x] Add comments and a README to packaging\r\n- [x] Remove .DS_Store (.gitignore?)\r\n- [x] Fix lint errors\r\n- [x] Fix fonts\r\n- [x] Add Gruntfile + release-it task\r\n- [x] Update github pages docs","created_at":"2015-01-15T22:57:15Z","updated_at":"2015-02-20T23:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b644f392315d445e5e7754d8a2f433e6a0cf2638","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167/commits","review_comments_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167/comments","review_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/{number}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/167/comments","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/e7e7119703c560eab51ba6392db817f1480ff2d3","head":{"label":"igillis/ember-cli","ref":"igillis/ember-cli","sha":"e7e7119703c560eab51ba6392db817f1480ff2d3","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments/{number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","created_at":"2013-10-23T04:39:36Z","updated_at":"2015-02-19T08:32:39Z","pushed_at":"2015-02-18T20:04:19Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":13787,"stargazers_count":235,"watchers_count":235,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":34,"forks":71,"open_issues":34,"watchers":235,"default_branch":"master"}},"base":{"label":"master","ref":"master","sha":"80466f55ee80d4dbc6d50fe3634367a32ccad3f2","user":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"repo":{"id":13793634,"name":"ember-widgets","full_name":"Addepar/ember-widgets","owner":{"login":"Addepar","id":847867,"avatar_url":"https://avatars.githubusercontent.com/u/847867?v=3","gravatar_id":"","url":"https://api.github.com/users/Addepar","html_url":"https://github.com/Addepar","followers_url":"https://api.github.com/users/Addepar/followers","following_url":"https://api.github.com/users/Addepar/following{/other_user}","gists_url":"https://api.github.com/users/Addepar/gists{/gist_id}","starred_url":"https://api.github.com/users/Addepar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Addepar/subscriptions","organizations_url":"https://api.github.com/users/Addepar/orgs","repos_url":"https://api.github.com/users/Addepar/repos","events_url":"https://api.github.com/users/Addepar/events{/privacy}","received_events_url":"https://api.github.com/users/Addepar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Addepar/ember-widgets","description":"","fork":false,"url":"https://api.github.com/repos/Addepar/ember-widgets","forks_url":"https://api.github.com/repos/Addepar/ember-widgets/forks","keys_url":"https://api.github.com/repos/Addepar/ember-widgets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Addepar/ember-widgets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Addepar/ember-widgets/teams","hooks_url":"https://api.github.com/repos/Addepar/ember-widgets/hooks","issue_events_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/events{/number}","events_url":"https://api.github.com/repos/Addepar/ember-widgets/events","assignees_url":"https://api.github.com/repos/Addepar/ember-widgets/assignees{/user}","branches_url":"https://api.github.com/repos/Addepar/ember-widgets/branches{/branch}","tags_url":"https://api.github.com/repos/Addepar/ember-widgets/tags","blobs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Addepar/ember-widgets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Addepar/ember-widgets/git/refs{/sha}","trees_url":"https://api.github.com/repos/Addepar/ember-widgets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Addepar/ember-widgets/statuses/{sha}","languages_url":"https://api.github.com/repos/Addepar/ember-widgets/languages","stargazers_url":"https://api.github.com/repos/Addepar/ember-widgets/stargazers","contributors_url":"https://api.github.com/repos/Addepar/ember-widgets/contributors","subscribers_url":"https://api.github.com/repos/Addepar/ember-widgets/subscribers","subscription_url":"https://api.github.com/repos/Addepar/ember-widgets/subscription","commits_url":"https://api.github.com/repos/Addepar/ember-widgets/commits{/sha}","git_commits_url":"https://api.github.com/repos/Addepar/ember-widgets/git/commits{/sha}","comments_url":"https://api.github.com/repos/Addepar/ember-widgets/comments{/number}","issue_comment_url":"https://api.github.com/repos/Addepar/ember-widgets/issues/comments/{number}","contents_url":"https://api.github.com/repos/Addepar/ember-widgets/contents/{+path}","compare_url":"https://api.github.com/repos/Addepar/ember-widgets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Addepar/ember-widgets/merges","archive_url":"https://api.github.com/repos/Addepar/ember-widgets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Addepar/ember-widgets/downloads","issues_url":"https://api.github.com/repos/Addepar/ember-widgets/issues{/number}","pulls_url":"https://api.github.com/repos/Addepar/ember-widgets/pulls{/number}","milestones_url":"https://api.github.com/repos/Addepar/ember-widgets/milestones{/number}","notifications_url":"https://api.github.com/repos/Addepar/ember-widgets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Addepar/ember-widgets/labels{/name}","releases_url":"https://api.github.com/repos/Addepar/ember-widgets/releases{/id}","created_at":"2013-10-23T04:39:36Z","updated_at":"2015-02-19T08:32:39Z","pushed_at":"2015-02-18T20:04:19Z","git_url":"git://github.com/Addepar/ember-widgets.git","ssh_url":"git@github.com:Addepar/ember-widgets.git","clone_url":"https://github.com/Addepar/ember-widgets.git","svn_url":"https://github.com/Addepar/ember-widgets","homepage":null,"size":13787,"stargazers_count":235,"watchers_count":235,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":34,"forks":71,"open_issues":34,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167"},"html":{"href":"https://github.com/Addepar/ember-widgets/pull/167"},"issue":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/167"},"comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/issues/167/comments"},"review_comments":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167/comments"},"review_comment":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/Addepar/ember-widgets/pulls/167/commits"},"statuses":{"href":"https://api.github.com/repos/Addepar/ember-widgets/statuses/e7e7119703c560eab51ba6392db817f1480ff2d3"}}}}