{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/io.js/issues/2283","labels_url":"https://api.github.com/repos/nodejs/io.js/issues/2283/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/io.js/issues/2283/comments","events_url":"https://api.github.com/repos/nodejs/io.js/issues/2283/events","html_url":"https://github.com/nodejs/io.js/pull/2283","id":98488769,"number":2283,"title":"build: work around VS2015 issue in ICU <56","user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/nodejs/io.js/labels/build","name":"build","color":"eb6420"},{"url":"https://api.github.com/repos/nodejs/io.js/labels/windows","name":"windows","color":"9944dd"}],"state":"open","locked":false,"assignee":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-07-31T23:33:25Z","updated_at":"2015-08-03T20:20:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/nodejs/io.js/pulls/2283","html_url":"https://github.com/nodejs/io.js/pull/2283","diff_url":"https://github.com/nodejs/io.js/pull/2283.diff","patch_url":"https://github.com/nodejs/io.js/pull/2283.patch"},"body":"fixes issue #2279 \r\nAlso, adds general mechanism for floating patches on top of ICU.\r\n\r\nThe particular ufile.c is from\r\n http://bugs.icu-project.org/trac/changeset/37704\r\nand should be OK for ICU 54 and 55.\r\n\r\nfyi @orangemocha "},"comment":{"url":"https://api.github.com/repos/nodejs/io.js/issues/comments/127396072","html_url":"https://github.com/nodejs/io.js/pull/2283#issuecomment-127396072","issue_url":"https://api.github.com/repos/nodejs/io.js/issues/2283","id":127396072,"user":{"login":"srl295","id":855219,"avatar_url":"https://avatars.githubusercontent.com/u/855219?v=3","gravatar_id":"","url":"https://api.github.com/users/srl295","html_url":"https://github.com/srl295","followers_url":"https://api.github.com/users/srl295/followers","following_url":"https://api.github.com/users/srl295/following{/other_user}","gists_url":"https://api.github.com/users/srl295/gists{/gist_id}","starred_url":"https://api.github.com/users/srl295/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srl295/subscriptions","organizations_url":"https://api.github.com/users/srl295/orgs","repos_url":"https://api.github.com/users/srl295/repos","events_url":"https://api.github.com/users/srl295/events{/privacy}","received_events_url":"https://api.github.com/users/srl295/received_events","type":"User","site_admin":false},"created_at":"2015-08-03T20:20:57Z","updated_at":"2015-08-03T20:20:57Z","body":"I can verify that my patch fixes the ICU compile breakage, but I still get stuck at:\r\n\r\n```\r\n  free-buffer-extension.cc\r\nC:\\Program Files (x86)\\Windows Kits\\8.1\\Include\\um\\dbghelp.h(1544): warning C40\r\n91: 'typedef ': ignored on left of '' when no variable is declared (compiling s\r\nource file ..\\..\\src\\execution.cc) [C:\\Users\\IBM_ADMIN\\git\\io.js\\deps\\v8\\tools\\\r\ngyp\\v8_base.vcxproj]\r\nC:\\Program Files (x86)\\Windows Kits\\8.1\\Include\\um\\dbghelp.h(3190): warning C40\r\n91: 'typedef ': ignored on left of '' when no variable is declared (compiling s\r\nource file ..\\..\\src\\execution.cc) [C:\\Users\\IBM_ADMIN\\git\\io.js\\deps\\v8\\tools\\\r\ngyp\\v8_base.vcxproj]\r\nC:\\Program Files (x86)\\Windows Kits\\8.1\\Include\\um\\dbghelp.h(1544): warning C40\r\n91: 'typedef ': ignored on left of '' when no variable is declared (compiling s\r\nource file ..\\..\\src\\extensions\\externalize-string-extension.cc) [C:\\Users\\IBM_\r\nADMIN\\git\\io.js\\deps\\v8\\tools\\gyp\\v8_base.vcxproj]\r\nC:\\Program Files (x86)\\Windows Kits\\8.1\\Include\\um\\dbghelp.h(3190): warning C40\r\n91: 'typedef ': ignored on left of '' when no variable is declared (compiling s\r\nource file ..\\..\\src\\extensions\\externalize-string-extension.cc) [C:\\Users\\IBM_\r\nADMIN\\git\\io.js\\deps\\v8\\tools\\gyp\\v8_base.vcxproj]\r\n..\\..\\src\\deoptimizer.cc(616): error C2956: sized deallocation function 'operat\r\nor delete(void*, size_t)' would be chosen as placement deallocation function. [\r\nC:\\Users\\IBM_ADMIN\\git\\io.js\\deps\\v8\\tools\\gyp\\v8_base.vcxproj]\r\n  ..\\..\\src\\deoptimizer.cc(616): note: see declaration of 'v8::internal::FrameD\r\n  escription::operator new'\r\n```"}}