{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph-deploy/issues/365","labels_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/365/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/365/comments","events_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/365/events","html_url":"https://github.com/ceph/ceph-deploy/pull/365","id":109188797,"number":365,"title":"do not udevadm trigger, ceph-disk does it","user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"liewegas","id":433031,"avatar_url":"https://avatars.githubusercontent.com/u/433031?v=3","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},"milestone":null,"comments":7,"created_at":"2015-09-30T22:03:45Z","updated_at":"2015-10-01T06:37:29Z","closed_at":"2015-10-01T00:21:05Z","pull_request":{"url":"https://api.github.com/repos/ceph/ceph-deploy/pulls/365","html_url":"https://github.com/ceph/ceph-deploy/pull/365","diff_url":"https://github.com/ceph/ceph-deploy/pull/365.diff","patch_url":"https://github.com/ceph/ceph-deploy/pull/365.patch"},"body":"There is no need for osd create to call udevadm trigger action=add. By\r\nrunning all actions associated with add for all block devices, it may\r\nalso trigger some race conditions. For instance, the following happens\r\nabout 10% of the time, when using dmcrypt:\r\n\r\n * ceph-disk prepare --dmcrypt /dev/vdb\r\n * /dev/vdb1 starts activating via udev\r\n * ceph-deploy triggers action=add\r\n * /dev/vdb2 udev chown root /dev/vdb2\r\n * /dev/vdb1 activate fails because of permission denied on /dev/vdb2\r\n * /dev/vdb2 udev action chown ceph /dev/vdb2\r\n\r\nhttp://tracker.ceph.com/issues/13299 Fixes: #13299\r\n\r\nSigned-off-by: Loic Dachary <loic@dachary.org>"},"comment":{"url":"https://api.github.com/repos/ceph/ceph-deploy/issues/comments/144634511","html_url":"https://github.com/ceph/ceph-deploy/pull/365#issuecomment-144634511","issue_url":"https://api.github.com/repos/ceph/ceph-deploy/issues/365","id":144634511,"user":{"login":"dachary","id":433594,"avatar_url":"https://avatars.githubusercontent.com/u/433594?v=3","gravatar_id":"","url":"https://api.github.com/users/dachary","html_url":"https://github.com/dachary","followers_url":"https://api.github.com/users/dachary/followers","following_url":"https://api.github.com/users/dachary/following{/other_user}","gists_url":"https://api.github.com/users/dachary/gists{/gist_id}","starred_url":"https://api.github.com/users/dachary/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dachary/subscriptions","organizations_url":"https://api.github.com/users/dachary/orgs","repos_url":"https://api.github.com/users/dachary/repos","events_url":"https://api.github.com/users/dachary/events{/privacy}","received_events_url":"https://api.github.com/users/dachary/received_events","type":"User","site_admin":false},"created_at":"2015-10-01T06:37:28Z","updated_at":"2015-10-01T06:37:28Z","body":"> Perhaps the \"fix\" is to not blindly trigger events on all devices, but only on the specific device that changes?\r\n\r\nI think that's what ceph-disk does now. "}}