{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/9122","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9122/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9122/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9122/events","html_url":"https://github.com/cms-sw/cmssw/pull/9122","id":77528141,"number":9122,"title":"correct blade order in fpix for phase1","user":{"login":"dkotlins","id":4726262,"avatar_url":"https://avatars.githubusercontent.com/u/4726262?v=3","gravatar_id":"","url":"https://api.github.com/users/dkotlins","html_url":"https://github.com/dkotlins","followers_url":"https://api.github.com/users/dkotlins/followers","following_url":"https://api.github.com/users/dkotlins/following{/other_user}","gists_url":"https://api.github.com/users/dkotlins/gists{/gist_id}","starred_url":"https://api.github.com/users/dkotlins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dkotlins/subscriptions","organizations_url":"https://api.github.com/users/dkotlins/orgs","repos_url":"https://api.github.com/users/dkotlins/repos","events_url":"https://api.github.com/users/dkotlins/events{/privacy}","received_events_url":"https://api.github.com/users/dkotlins/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-available","name":"comparison-available","color":"009800"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04"},{"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-approved","name":"tests-approved","color":"009800"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51","html_url":"https://github.com/cms-sw/cmssw/milestones/Next%20CMSSW_7_5_X","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/51/labels","id":982516,"number":51,"title":"Next CMSSW_7_5_X","description":"","creator":{"login":"nclopezo","id":1944922,"avatar_url":"https://avatars.githubusercontent.com/u/1944922?v=3","gravatar_id":"","url":"https://api.github.com/users/nclopezo","html_url":"https://github.com/nclopezo","followers_url":"https://api.github.com/users/nclopezo/followers","following_url":"https://api.github.com/users/nclopezo/following{/other_user}","gists_url":"https://api.github.com/users/nclopezo/gists{/gist_id}","starred_url":"https://api.github.com/users/nclopezo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nclopezo/subscriptions","organizations_url":"https://api.github.com/users/nclopezo/orgs","repos_url":"https://api.github.com/users/nclopezo/repos","events_url":"https://api.github.com/users/nclopezo/events{/privacy}","received_events_url":"https://api.github.com/users/nclopezo/received_events","type":"User","site_admin":false},"open_issues":78,"closed_issues":595,"state":"open","created_at":"2015-02-17T08:21:25Z","updated_at":"2015-05-18T22:35:32Z","due_on":"2015-03-02T23:00:00Z","closed_at":null},"comments":6,"created_at":"2015-05-18T06:48:10Z","updated_at":"2015-05-19T07:36:17Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/9122","html_url":"https://github.com/cms-sw/cmssw/pull/9122","diff_url":"https://github.com/cms-sw/cmssw/pull/9122.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/9122.patch"},"body":"Fix the order of ladders in phase1 pixel forward blades.\r\nThe blades now start from 1 at the top."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/103381188","html_url":"https://github.com/cms-sw/cmssw/pull/9122#issuecomment-103381188","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/9122","id":103381188,"user":{"login":"civanch","id":4955118,"avatar_url":"https://avatars.githubusercontent.com/u/4955118?v=3","gravatar_id":"","url":"https://api.github.com/users/civanch","html_url":"https://github.com/civanch","followers_url":"https://api.github.com/users/civanch/followers","following_url":"https://api.github.com/users/civanch/following{/other_user}","gists_url":"https://api.github.com/users/civanch/gists{/gist_id}","starred_url":"https://api.github.com/users/civanch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/civanch/subscriptions","organizations_url":"https://api.github.com/users/civanch/orgs","repos_url":"https://api.github.com/users/civanch/repos","events_url":"https://api.github.com/users/civanch/events{/privacy}","received_events_url":"https://api.github.com/users/civanch/received_events","type":"User","site_admin":false},"created_at":"2015-05-19T07:36:17Z","updated_at":"2015-05-19T07:36:17Z","body":"@dkotlins , the code seems to be fine, the only worry that class members thePart and theBlade do not have default values. Of course, they are defined in all class constructors. If input is correct then there is no problem. However, the safe approach is to start from some defaults as in lines 176-177 of \r\nPixelEndcapName.cc"}}