{"action":"created","comment":{"url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/comments/41656481","id":41656481,"diff_hunk":"@@ -0,0 +1,110 @@\n+package com.socrata.datacoordinator.external\n+\n+sealed class DataCoordinatorError","path":"coordinator-external/src/main/scala/com/socrata/datacoordinator/external/DataCoordinatorError.scala","position":3,"original_position":3,"commit_id":"cb53a5799163c79829026f6446e5a84a97d84354","original_commit_id":"cb53a5799163c79829026f6446e5a84a97d84354","user":{"login":"rjmac","id":753700,"avatar_url":"https://avatars.githubusercontent.com/u/753700?v=3","gravatar_id":"","url":"https://api.github.com/users/rjmac","html_url":"https://github.com/rjmac","followers_url":"https://api.github.com/users/rjmac/followers","following_url":"https://api.github.com/users/rjmac/following{/other_user}","gists_url":"https://api.github.com/users/rjmac/gists{/gist_id}","starred_url":"https://api.github.com/users/rjmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rjmac/subscriptions","organizations_url":"https://api.github.com/users/rjmac/orgs","repos_url":"https://api.github.com/users/rjmac/repos","events_url":"https://api.github.com/users/rjmac/events{/privacy}","received_events_url":"https://api.github.com/users/rjmac/received_events","type":"User","site_admin":false},"body":"We should never need to change it; it doesn't matter what normalizer we use, just that it's _some_ single one.  The point of it is just to ensure that \"á\" and \"á\" always compare equal to the less intelligent sorts of string comparators whether they come in as LATIN_SMALL_LETTER_A_WITH_ACUTE or LATIN_SMALL_LETTER_A and COMBINING_ACUTE_ACCENT.","created_at":"2015-10-09T17:33:48Z","updated_at":"2015-10-09T17:33:48Z","html_url":"https://github.com/socrata-platform/data-coordinator/pull/69#discussion_r41656481","pull_request_url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69","_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/comments/41656481"},"html":{"href":"https://github.com/socrata-platform/data-coordinator/pull/69#discussion_r41656481"},"pull_request":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69"}}},"pull_request":{"url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69","id":47279724,"html_url":"https://github.com/socrata-platform/data-coordinator/pull/69","diff_url":"https://github.com/socrata-platform/data-coordinator/pull/69.diff","patch_url":"https://github.com/socrata-platform/data-coordinator/pull/69.patch","issue_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/69","number":69,"state":"open","locked":false,"title":"Soda Error Handling and Refactoring. ","user":{"login":"AEscobarCruz","id":9326515,"avatar_url":"https://avatars.githubusercontent.com/u/9326515?v=3","gravatar_id":"","url":"https://api.github.com/users/AEscobarCruz","html_url":"https://github.com/AEscobarCruz","followers_url":"https://api.github.com/users/AEscobarCruz/followers","following_url":"https://api.github.com/users/AEscobarCruz/following{/other_user}","gists_url":"https://api.github.com/users/AEscobarCruz/gists{/gist_id}","starred_url":"https://api.github.com/users/AEscobarCruz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEscobarCruz/subscriptions","organizations_url":"https://api.github.com/users/AEscobarCruz/orgs","repos_url":"https://api.github.com/users/AEscobarCruz/repos","events_url":"https://api.github.com/users/AEscobarCruz/events{/privacy}","received_events_url":"https://api.github.com/users/AEscobarCruz/received_events","type":"User","site_admin":false},"body":"first major part of refactoring DC. Should be all we need to do for the most part, but could hold out for more suggestions.\r\n\r\nremoved uncessary dep.\r\n\r\nUpdated a few error messages that I have missed in a few resource files. Created a new error for bad request due to content type errors.\r\n\r\nadding fix to resource type and expected in router class.\r\n\r\nadding fix to resource type and expected in router class: extended to main and service class also.\r\n\r\nremoved extra space","created_at":"2015-10-09T14:41:58Z","updated_at":"2015-10-09T17:33:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c0ed806bc23acfec6d204187d84a484d9eeef42","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69/commits","review_comments_url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69/comments","review_comment_url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/69/comments","statuses_url":"https://api.github.com/repos/socrata-platform/data-coordinator/statuses/cb53a5799163c79829026f6446e5a84a97d84354","head":{"label":"socrata-platform:ae_refactor","ref":"ae_refactor","sha":"cb53a5799163c79829026f6446e5a84a97d84354","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":9108476,"name":"data-coordinator","full_name":"socrata-platform/data-coordinator","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/data-coordinator","description":"Accepts data updates and populates execution engines' copies","fork":false,"url":"https://api.github.com/repos/socrata-platform/data-coordinator","forks_url":"https://api.github.com/repos/socrata-platform/data-coordinator/forks","keys_url":"https://api.github.com/repos/socrata-platform/data-coordinator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/data-coordinator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/data-coordinator/teams","hooks_url":"https://api.github.com/repos/socrata-platform/data-coordinator/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/data-coordinator/events","assignees_url":"https://api.github.com/repos/socrata-platform/data-coordinator/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/data-coordinator/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/data-coordinator/tags","blobs_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/data-coordinator/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/data-coordinator/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/data-coordinator/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/data-coordinator/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/data-coordinator/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/data-coordinator/subscription","commits_url":"https://api.github.com/repos/socrata-platform/data-coordinator/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/data-coordinator/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/data-coordinator/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/data-coordinator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/data-coordinator/merges","archive_url":"https://api.github.com/repos/socrata-platform/data-coordinator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/data-coordinator/downloads","issues_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/data-coordinator/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/data-coordinator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/data-coordinator/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/data-coordinator/releases{/id}","created_at":"2013-03-29T23:22:28Z","updated_at":"2015-06-29T22:21:23Z","pushed_at":"2015-10-09T14:41:58Z","git_url":"git://github.com/socrata-platform/data-coordinator.git","ssh_url":"git@github.com:socrata-platform/data-coordinator.git","clone_url":"https://github.com/socrata-platform/data-coordinator.git","svn_url":"https://github.com/socrata-platform/data-coordinator","homepage":"","size":5364,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"socrata-platform:master","ref":"master","sha":"e5ede1666d1cf66c2d29a3e446573d8df2b3ed26","user":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":9108476,"name":"data-coordinator","full_name":"socrata-platform/data-coordinator","owner":{"login":"socrata-platform","id":12076358,"avatar_url":"https://avatars.githubusercontent.com/u/12076358?v=3","gravatar_id":"","url":"https://api.github.com/users/socrata-platform","html_url":"https://github.com/socrata-platform","followers_url":"https://api.github.com/users/socrata-platform/followers","following_url":"https://api.github.com/users/socrata-platform/following{/other_user}","gists_url":"https://api.github.com/users/socrata-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/socrata-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/socrata-platform/subscriptions","organizations_url":"https://api.github.com/users/socrata-platform/orgs","repos_url":"https://api.github.com/users/socrata-platform/repos","events_url":"https://api.github.com/users/socrata-platform/events{/privacy}","received_events_url":"https://api.github.com/users/socrata-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/socrata-platform/data-coordinator","description":"Accepts data updates and populates execution engines' copies","fork":false,"url":"https://api.github.com/repos/socrata-platform/data-coordinator","forks_url":"https://api.github.com/repos/socrata-platform/data-coordinator/forks","keys_url":"https://api.github.com/repos/socrata-platform/data-coordinator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/socrata-platform/data-coordinator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/socrata-platform/data-coordinator/teams","hooks_url":"https://api.github.com/repos/socrata-platform/data-coordinator/hooks","issue_events_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/events{/number}","events_url":"https://api.github.com/repos/socrata-platform/data-coordinator/events","assignees_url":"https://api.github.com/repos/socrata-platform/data-coordinator/assignees{/user}","branches_url":"https://api.github.com/repos/socrata-platform/data-coordinator/branches{/branch}","tags_url":"https://api.github.com/repos/socrata-platform/data-coordinator/tags","blobs_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/refs{/sha}","trees_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/socrata-platform/data-coordinator/statuses/{sha}","languages_url":"https://api.github.com/repos/socrata-platform/data-coordinator/languages","stargazers_url":"https://api.github.com/repos/socrata-platform/data-coordinator/stargazers","contributors_url":"https://api.github.com/repos/socrata-platform/data-coordinator/contributors","subscribers_url":"https://api.github.com/repos/socrata-platform/data-coordinator/subscribers","subscription_url":"https://api.github.com/repos/socrata-platform/data-coordinator/subscription","commits_url":"https://api.github.com/repos/socrata-platform/data-coordinator/commits{/sha}","git_commits_url":"https://api.github.com/repos/socrata-platform/data-coordinator/git/commits{/sha}","comments_url":"https://api.github.com/repos/socrata-platform/data-coordinator/comments{/number}","issue_comment_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/comments{/number}","contents_url":"https://api.github.com/repos/socrata-platform/data-coordinator/contents/{+path}","compare_url":"https://api.github.com/repos/socrata-platform/data-coordinator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/socrata-platform/data-coordinator/merges","archive_url":"https://api.github.com/repos/socrata-platform/data-coordinator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/socrata-platform/data-coordinator/downloads","issues_url":"https://api.github.com/repos/socrata-platform/data-coordinator/issues{/number}","pulls_url":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls{/number}","milestones_url":"https://api.github.com/repos/socrata-platform/data-coordinator/milestones{/number}","notifications_url":"https://api.github.com/repos/socrata-platform/data-coordinator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/socrata-platform/data-coordinator/labels{/name}","releases_url":"https://api.github.com/repos/socrata-platform/data-coordinator/releases{/id}","created_at":"2013-03-29T23:22:28Z","updated_at":"2015-06-29T22:21:23Z","pushed_at":"2015-10-09T14:41:58Z","git_url":"git://github.com/socrata-platform/data-coordinator.git","ssh_url":"git@github.com:socrata-platform/data-coordinator.git","clone_url":"https://github.com/socrata-platform/data-coordinator.git","svn_url":"https://github.com/socrata-platform/data-coordinator","homepage":"","size":5364,"stargazers_count":3,"watchers_count":3,"language":"Scala","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":1,"forks":5,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69"},"html":{"href":"https://github.com/socrata-platform/data-coordinator/pull/69"},"issue":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/69"},"comments":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/socrata-platform/data-coordinator/statuses/cb53a5799163c79829026f6446e5a84a97d84354"}}}}