{"action":"created","issue":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/184","labels_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/184/labels{/name}","comments_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/184/comments","events_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/184/events","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/184","id":98466462,"number":184,"title":"add FreeBSD support (WIP)","user":{"login":"mmoll","id":1434927,"avatar_url":"https://avatars.githubusercontent.com/u/1434927?v=3","gravatar_id":"","url":"https://api.github.com/users/mmoll","html_url":"https://github.com/mmoll","followers_url":"https://api.github.com/users/mmoll/followers","following_url":"https://api.github.com/users/mmoll/following{/other_user}","gists_url":"https://api.github.com/users/mmoll/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoll/subscriptions","organizations_url":"https://api.github.com/users/mmoll/orgs","repos_url":"https://api.github.com/users/mmoll/repos","events_url":"https://api.github.com/users/mmoll/events{/privacy}","received_events_url":"https://api.github.com/users/mmoll/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-31T20:34:29Z","updated_at":"2015-08-05T13:38:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/pulls/184","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/184","diff_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/184.diff","patch_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/184.patch"},"body":"Opening this mainly for comments, tests are not yet adjusted.\r\nI'm unsure if it's better to have all the information per osfamily in params.pp or only the differing variables but did it the first way as this is easier for me at the moment."},"comment":{"url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/comments/127999250","html_url":"https://github.com/theforeman/puppet-foreman_proxy/pull/184#issuecomment-127999250","issue_url":"https://api.github.com/repos/theforeman/puppet-foreman_proxy/issues/184","id":127999250,"user":{"login":"domcleal","id":482089,"avatar_url":"https://avatars.githubusercontent.com/u/482089?v=3","gravatar_id":"","url":"https://api.github.com/users/domcleal","html_url":"https://github.com/domcleal","followers_url":"https://api.github.com/users/domcleal/followers","following_url":"https://api.github.com/users/domcleal/following{/other_user}","gists_url":"https://api.github.com/users/domcleal/gists{/gist_id}","starred_url":"https://api.github.com/users/domcleal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/domcleal/subscriptions","organizations_url":"https://api.github.com/users/domcleal/orgs","repos_url":"https://api.github.com/users/domcleal/repos","events_url":"https://api.github.com/users/domcleal/events{/privacy}","received_events_url":"https://api.github.com/users/domcleal/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T13:38:49Z","updated_at":"2015-08-05T13:38:49Z","body":"Yeah, fine I think.  I'm not sure about rearranging params into large per-OS blocks as it splits up where parameters for each module are defined, but otherwise OK."}}