{"action":"created","comment":{"url":"https://api.github.com/repos/Yelp/YLTableView/pulls/comments/47022740","id":47022740,"diff_hunk":"@@ -16,8 +16,26 @@ NS_ASSUME_NONNULL_BEGIN\n //! If one of model's properties has changed (but it's still the same object), this will reload the visible cell for that model. Useful whenever something mutates the state of a model (i.e. image loading)\n - (void)reloadVisibleCellForModel:(id)model inTableView:(UITableView *)tableView;\n \n+/*!\n+ tableView:estimatedHeightForRowAtIndexPath can get the estimated height through the following ways:\n+ - For cells that conform to the YLTableViewCellEstimatedRowHeight protocol, the estimated height is specified via estimatedRowHeight\n+ - For cells that don't conform to this protocol, the estimated height can be specified by overriding this method: estimatedHeightForRow:inTableView\n+ - Otherwise, the iOS default of UITableViewAutomaticDimension will be used as the estimated height\n+ */\n+- (CGFloat)estimatedHeightForRow:(NSIndexPath *)row inTableView:(UITableView *)tableView;\n+\n //! Set as the parent view controller of any cells implementing YLTableViewChildViewControllerCell.\n @property (weak, nonatomic, nullable) UIViewController *parentViewController;\n \n+/*!\n+ Defaults to NO. If you would like to cache the estimated heights for rows, set this to YES.\n+\n+ Note: this is only really necessary for iOS 8. If you are using estimated row height + UITableViewAutomaticDimension in iOS 8, there's a bug","path":"Classes/YLTableViewDataSource.h","position":18,"original_position":18,"commit_id":"5bb53f95c0b8a68c0f23e4fc7b9aed43e68ef9e4","original_commit_id":"5bb53f95c0b8a68c0f23e4fc7b9aed43e68ef9e4","user":{"login":"benasher44","id":1120429,"avatar_url":"https://avatars.githubusercontent.com/u/1120429?v=3","gravatar_id":"","url":"https://api.github.com/users/benasher44","html_url":"https://github.com/benasher44","followers_url":"https://api.github.com/users/benasher44/followers","following_url":"https://api.github.com/users/benasher44/following{/other_user}","gists_url":"https://api.github.com/users/benasher44/gists{/gist_id}","starred_url":"https://api.github.com/users/benasher44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benasher44/subscriptions","organizations_url":"https://api.github.com/users/benasher44/orgs","repos_url":"https://api.github.com/users/benasher44/repos","events_url":"https://api.github.com/users/benasher44/events{/privacy}","received_events_url":"https://api.github.com/users/benasher44/received_events","type":"User","site_admin":false},"body":"nit: ```@note```","created_at":"2015-12-08T22:17:33Z","updated_at":"2015-12-08T22:17:33Z","html_url":"https://github.com/Yelp/YLTableView/pull/8#discussion_r47022740","pull_request_url":"https://api.github.com/repos/Yelp/YLTableView/pulls/8","_links":{"self":{"href":"https://api.github.com/repos/Yelp/YLTableView/pulls/comments/47022740"},"html":{"href":"https://github.com/Yelp/YLTableView/pull/8#discussion_r47022740"},"pull_request":{"href":"https://api.github.com/repos/Yelp/YLTableView/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/Yelp/YLTableView/pulls/8","id":53021477,"html_url":"https://github.com/Yelp/YLTableView/pull/8","diff_url":"https://github.com/Yelp/YLTableView/pull/8.diff","patch_url":"https://github.com/Yelp/YLTableView/pull/8.patch","issue_url":"https://api.github.com/repos/Yelp/YLTableView/issues/8","number":8,"state":"open","locked":false,"title":"Introduce YLTableViewCellEstimatedRowHeight protocol and add caching mechanism","user":{"login":"Ushhud","id":991329,"avatar_url":"https://avatars.githubusercontent.com/u/991329?v=3","gravatar_id":"","url":"https://api.github.com/users/Ushhud","html_url":"https://github.com/Ushhud","followers_url":"https://api.github.com/users/Ushhud/followers","following_url":"https://api.github.com/users/Ushhud/following{/other_user}","gists_url":"https://api.github.com/users/Ushhud/gists{/gist_id}","starred_url":"https://api.github.com/users/Ushhud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ushhud/subscriptions","organizations_url":"https://api.github.com/users/Ushhud/orgs","repos_url":"https://api.github.com/users/Ushhud/repos","events_url":"https://api.github.com/users/Ushhud/events{/privacy}","received_events_url":"https://api.github.com/users/Ushhud/received_events","type":"User","site_admin":false},"body":"Introduce YLTableViewCellEstimatedRowHeight protocol so that YLTableViewDataSource can use estimated heights provided by the cells, if the cells conform to the protocol (+ an alternative method to gather the height from a subclasses table view data source.\r\n\r\nAdd caching mechanism for estimated heights.","created_at":"2015-12-08T18:49:22Z","updated_at":"2015-12-08T22:17:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0094c3217c0ba4d45db2599583099a40241262c2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Yelp/YLTableView/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Yelp/YLTableView/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Yelp/YLTableView/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yelp/YLTableView/issues/8/comments","statuses_url":"https://api.github.com/repos/Yelp/YLTableView/statuses/5bb53f95c0b8a68c0f23e4fc7b9aed43e68ef9e4","head":{"label":"Ushhud:COREIOS-1_move_YPUITableViewCellEstimatedRowHeight_into_YLTableView","ref":"COREIOS-1_move_YPUITableViewCellEstimatedRowHeight_into_YLTableView","sha":"5bb53f95c0b8a68c0f23e4fc7b9aed43e68ef9e4","user":{"login":"Ushhud","id":991329,"avatar_url":"https://avatars.githubusercontent.com/u/991329?v=3","gravatar_id":"","url":"https://api.github.com/users/Ushhud","html_url":"https://github.com/Ushhud","followers_url":"https://api.github.com/users/Ushhud/followers","following_url":"https://api.github.com/users/Ushhud/following{/other_user}","gists_url":"https://api.github.com/users/Ushhud/gists{/gist_id}","starred_url":"https://api.github.com/users/Ushhud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ushhud/subscriptions","organizations_url":"https://api.github.com/users/Ushhud/orgs","repos_url":"https://api.github.com/users/Ushhud/repos","events_url":"https://api.github.com/users/Ushhud/events{/privacy}","received_events_url":"https://api.github.com/users/Ushhud/received_events","type":"User","site_admin":false},"repo":{"id":47641559,"name":"YLTableView","full_name":"Ushhud/YLTableView","owner":{"login":"Ushhud","id":991329,"avatar_url":"https://avatars.githubusercontent.com/u/991329?v=3","gravatar_id":"","url":"https://api.github.com/users/Ushhud","html_url":"https://github.com/Ushhud","followers_url":"https://api.github.com/users/Ushhud/followers","following_url":"https://api.github.com/users/Ushhud/following{/other_user}","gists_url":"https://api.github.com/users/Ushhud/gists{/gist_id}","starred_url":"https://api.github.com/users/Ushhud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ushhud/subscriptions","organizations_url":"https://api.github.com/users/Ushhud/orgs","repos_url":"https://api.github.com/users/Ushhud/repos","events_url":"https://api.github.com/users/Ushhud/events{/privacy}","received_events_url":"https://api.github.com/users/Ushhud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ushhud/YLTableView","description":"","fork":true,"url":"https://api.github.com/repos/Ushhud/YLTableView","forks_url":"https://api.github.com/repos/Ushhud/YLTableView/forks","keys_url":"https://api.github.com/repos/Ushhud/YLTableView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ushhud/YLTableView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ushhud/YLTableView/teams","hooks_url":"https://api.github.com/repos/Ushhud/YLTableView/hooks","issue_events_url":"https://api.github.com/repos/Ushhud/YLTableView/issues/events{/number}","events_url":"https://api.github.com/repos/Ushhud/YLTableView/events","assignees_url":"https://api.github.com/repos/Ushhud/YLTableView/assignees{/user}","branches_url":"https://api.github.com/repos/Ushhud/YLTableView/branches{/branch}","tags_url":"https://api.github.com/repos/Ushhud/YLTableView/tags","blobs_url":"https://api.github.com/repos/Ushhud/YLTableView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ushhud/YLTableView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ushhud/YLTableView/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ushhud/YLTableView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ushhud/YLTableView/statuses/{sha}","languages_url":"https://api.github.com/repos/Ushhud/YLTableView/languages","stargazers_url":"https://api.github.com/repos/Ushhud/YLTableView/stargazers","contributors_url":"https://api.github.com/repos/Ushhud/YLTableView/contributors","subscribers_url":"https://api.github.com/repos/Ushhud/YLTableView/subscribers","subscription_url":"https://api.github.com/repos/Ushhud/YLTableView/subscription","commits_url":"https://api.github.com/repos/Ushhud/YLTableView/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ushhud/YLTableView/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ushhud/YLTableView/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ushhud/YLTableView/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ushhud/YLTableView/contents/{+path}","compare_url":"https://api.github.com/repos/Ushhud/YLTableView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ushhud/YLTableView/merges","archive_url":"https://api.github.com/repos/Ushhud/YLTableView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ushhud/YLTableView/downloads","issues_url":"https://api.github.com/repos/Ushhud/YLTableView/issues{/number}","pulls_url":"https://api.github.com/repos/Ushhud/YLTableView/pulls{/number}","milestones_url":"https://api.github.com/repos/Ushhud/YLTableView/milestones{/number}","notifications_url":"https://api.github.com/repos/Ushhud/YLTableView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ushhud/YLTableView/labels{/name}","releases_url":"https://api.github.com/repos/Ushhud/YLTableView/releases{/id}","created_at":"2015-12-08T18:35:55Z","updated_at":"2015-12-08T18:35:56Z","pushed_at":"2015-12-08T22:15:18Z","git_url":"git://github.com/Ushhud/YLTableView.git","ssh_url":"git@github.com:Ushhud/YLTableView.git","clone_url":"https://github.com/Ushhud/YLTableView.git","svn_url":"https://github.com/Ushhud/YLTableView","homepage":null,"size":616,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yelp:master","ref":"master","sha":"e187663f1818870aec2f8058e07fab82e435a842","user":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"repo":{"id":36955856,"name":"YLTableView","full_name":"Yelp/YLTableView","owner":{"login":"Yelp","id":49071,"avatar_url":"https://avatars.githubusercontent.com/u/49071?v=3","gravatar_id":"","url":"https://api.github.com/users/Yelp","html_url":"https://github.com/Yelp","followers_url":"https://api.github.com/users/Yelp/followers","following_url":"https://api.github.com/users/Yelp/following{/other_user}","gists_url":"https://api.github.com/users/Yelp/gists{/gist_id}","starred_url":"https://api.github.com/users/Yelp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yelp/subscriptions","organizations_url":"https://api.github.com/users/Yelp/orgs","repos_url":"https://api.github.com/users/Yelp/repos","events_url":"https://api.github.com/users/Yelp/events{/privacy}","received_events_url":"https://api.github.com/users/Yelp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Yelp/YLTableView","description":"","fork":false,"url":"https://api.github.com/repos/Yelp/YLTableView","forks_url":"https://api.github.com/repos/Yelp/YLTableView/forks","keys_url":"https://api.github.com/repos/Yelp/YLTableView/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yelp/YLTableView/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yelp/YLTableView/teams","hooks_url":"https://api.github.com/repos/Yelp/YLTableView/hooks","issue_events_url":"https://api.github.com/repos/Yelp/YLTableView/issues/events{/number}","events_url":"https://api.github.com/repos/Yelp/YLTableView/events","assignees_url":"https://api.github.com/repos/Yelp/YLTableView/assignees{/user}","branches_url":"https://api.github.com/repos/Yelp/YLTableView/branches{/branch}","tags_url":"https://api.github.com/repos/Yelp/YLTableView/tags","blobs_url":"https://api.github.com/repos/Yelp/YLTableView/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yelp/YLTableView/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yelp/YLTableView/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yelp/YLTableView/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yelp/YLTableView/statuses/{sha}","languages_url":"https://api.github.com/repos/Yelp/YLTableView/languages","stargazers_url":"https://api.github.com/repos/Yelp/YLTableView/stargazers","contributors_url":"https://api.github.com/repos/Yelp/YLTableView/contributors","subscribers_url":"https://api.github.com/repos/Yelp/YLTableView/subscribers","subscription_url":"https://api.github.com/repos/Yelp/YLTableView/subscription","commits_url":"https://api.github.com/repos/Yelp/YLTableView/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yelp/YLTableView/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yelp/YLTableView/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yelp/YLTableView/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yelp/YLTableView/contents/{+path}","compare_url":"https://api.github.com/repos/Yelp/YLTableView/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yelp/YLTableView/merges","archive_url":"https://api.github.com/repos/Yelp/YLTableView/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yelp/YLTableView/downloads","issues_url":"https://api.github.com/repos/Yelp/YLTableView/issues{/number}","pulls_url":"https://api.github.com/repos/Yelp/YLTableView/pulls{/number}","milestones_url":"https://api.github.com/repos/Yelp/YLTableView/milestones{/number}","notifications_url":"https://api.github.com/repos/Yelp/YLTableView/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yelp/YLTableView/labels{/name}","releases_url":"https://api.github.com/repos/Yelp/YLTableView/releases{/id}","created_at":"2015-06-05T21:18:52Z","updated_at":"2015-12-06T22:34:08Z","pushed_at":"2015-12-08T22:15:18Z","git_url":"git://github.com/Yelp/YLTableView.git","ssh_url":"git@github.com:Yelp/YLTableView.git","clone_url":"https://github.com/Yelp/YLTableView.git","svn_url":"https://github.com/Yelp/YLTableView","homepage":null,"size":783,"stargazers_count":82,"watchers_count":82,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":3,"forks":13,"open_issues":3,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yelp/YLTableView/pulls/8"},"html":{"href":"https://github.com/Yelp/YLTableView/pull/8"},"issue":{"href":"https://api.github.com/repos/Yelp/YLTableView/issues/8"},"comments":{"href":"https://api.github.com/repos/Yelp/YLTableView/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Yelp/YLTableView/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Yelp/YLTableView/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yelp/YLTableView/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Yelp/YLTableView/statuses/5bb53f95c0b8a68c0f23e4fc7b9aed43e68ef9e4"}}}}