{"action":"created","comment":{"url":"https://api.github.com/repos/angular/angular/pulls/comments/34715864","id":34715864,"diff_hunk":"@@ -11,5 +11,47 @@ import {List, Map} from 'angular2/src/facade/collection';\n  */\n @CONST()\n export class RouteConfig {\n-  constructor(public configs: List<Map<any, any>>) {}\n+  constructor(public configs: List<RouteDefinition>) {}\n+}\n+\n+export interface RouteDefinition {\n+  path: string;\n+  component?: Type;\n+  loader?: Function;\n+  redirectTo?: string;\n+  as?: string;\n+}\n+\n+@CONST()","path":"modules/angular2/src/router/route_config_impl.ts","position":22,"original_position":22,"commit_id":"fdb721030215d508e8c6afbc33f91dd26b4f0493","original_commit_id":"fdb721030215d508e8c6afbc33f91dd26b4f0493","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"body":"When should I be using `@CONST()` ?","created_at":"2015-07-15T19:00:10Z","updated_at":"2015-07-15T19:00:10Z","html_url":"https://github.com/angular/angular/pull/3069#discussion_r34715864","pull_request_url":"https://api.github.com/repos/angular/angular/pulls/3069","_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/comments/34715864"},"html":{"href":"https://github.com/angular/angular/pull/3069#discussion_r34715864"},"pull_request":{"href":"https://api.github.com/repos/angular/angular/pulls/3069"}}},"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/3069","id":40057091,"html_url":"https://github.com/angular/angular/pull/3069","diff_url":"https://github.com/angular/angular/pull/3069.diff","patch_url":"https://github.com/angular/angular/pull/3069.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/3069","number":3069,"state":"open","locked":false,"title":"feat(router): add interfaces for route definitions in RouteConfig","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"body":"Still needs some work. I'd like to add a test for the JS object case, e.g.:\r\n\r\n```\r\n@RouteConfig([\r\n  { path: '/foo', component: BarCmp }\r\n])\r\n```\r\n\r\nCloses #2261 \r\n","created_at":"2015-07-15T18:59:36Z","updated_at":"2015-07-15T19:00:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d8f97cf15e462fd787f65083aa2cb6434c90280","assignee":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/angular/angular/milestones/40","html_url":"https://github.com/angular/angular/milestones/alpha-32","labels_url":"https://api.github.com/repos/angular/angular/milestones/40/labels","id":1189877,"number":40,"title":"alpha-32","description":"Current milestone.  Work on all issues to complete by Monday July 20 @ 8am PT; sync internal/external by July 23 EOD.","creator":{"login":"naomiblack","id":2286589,"avatar_url":"https://avatars.githubusercontent.com/u/2286589?v=3","gravatar_id":"","url":"https://api.github.com/users/naomiblack","html_url":"https://github.com/naomiblack","followers_url":"https://api.github.com/users/naomiblack/followers","following_url":"https://api.github.com/users/naomiblack/following{/other_user}","gists_url":"https://api.github.com/users/naomiblack/gists{/gist_id}","starred_url":"https://api.github.com/users/naomiblack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naomiblack/subscriptions","organizations_url":"https://api.github.com/users/naomiblack/orgs","repos_url":"https://api.github.com/users/naomiblack/repos","events_url":"https://api.github.com/users/naomiblack/events{/privacy}","received_events_url":"https://api.github.com/users/naomiblack/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":12,"state":"open","created_at":"2015-07-01T23:26:20Z","updated_at":"2015-07-15T18:59:36Z","due_on":"2015-07-20T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/angular/angular/pulls/3069/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/3069/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/3069/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/fdb721030215d508e8c6afbc33f91dd26b4f0493","head":{"label":"btford:fix-router-routeconfig-types","ref":"fix-router-routeconfig-types","sha":"fdb721030215d508e8c6afbc33f91dd26b4f0493","user":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"repo":{"id":28889554,"name":"angular","full_name":"btford/angular","owner":{"login":"btford","id":474988,"avatar_url":"https://avatars.githubusercontent.com/u/474988?v=3","gravatar_id":"","url":"https://api.github.com/users/btford","html_url":"https://github.com/btford","followers_url":"https://api.github.com/users/btford/followers","following_url":"https://api.github.com/users/btford/following{/other_user}","gists_url":"https://api.github.com/users/btford/gists{/gist_id}","starred_url":"https://api.github.com/users/btford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btford/subscriptions","organizations_url":"https://api.github.com/users/btford/orgs","repos_url":"https://api.github.com/users/btford/repos","events_url":"https://api.github.com/users/btford/events{/privacy}","received_events_url":"https://api.github.com/users/btford/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/btford/angular","description":"","fork":true,"url":"https://api.github.com/repos/btford/angular","forks_url":"https://api.github.com/repos/btford/angular/forks","keys_url":"https://api.github.com/repos/btford/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/btford/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/btford/angular/teams","hooks_url":"https://api.github.com/repos/btford/angular/hooks","issue_events_url":"https://api.github.com/repos/btford/angular/issues/events{/number}","events_url":"https://api.github.com/repos/btford/angular/events","assignees_url":"https://api.github.com/repos/btford/angular/assignees{/user}","branches_url":"https://api.github.com/repos/btford/angular/branches{/branch}","tags_url":"https://api.github.com/repos/btford/angular/tags","blobs_url":"https://api.github.com/repos/btford/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/btford/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/btford/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/btford/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/btford/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/btford/angular/languages","stargazers_url":"https://api.github.com/repos/btford/angular/stargazers","contributors_url":"https://api.github.com/repos/btford/angular/contributors","subscribers_url":"https://api.github.com/repos/btford/angular/subscribers","subscription_url":"https://api.github.com/repos/btford/angular/subscription","commits_url":"https://api.github.com/repos/btford/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/btford/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/btford/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/btford/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/btford/angular/contents/{+path}","compare_url":"https://api.github.com/repos/btford/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/btford/angular/merges","archive_url":"https://api.github.com/repos/btford/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/btford/angular/downloads","issues_url":"https://api.github.com/repos/btford/angular/issues{/number}","pulls_url":"https://api.github.com/repos/btford/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/btford/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/btford/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/btford/angular/labels{/name}","releases_url":"https://api.github.com/repos/btford/angular/releases{/id}","created_at":"2015-01-07T00:00:47Z","updated_at":"2015-01-07T00:00:48Z","pushed_at":"2015-07-15T18:47:10Z","git_url":"git://github.com/btford/angular.git","ssh_url":"git@github.com:btford/angular.git","clone_url":"https://github.com/btford/angular.git","svn_url":"https://github.com/btford/angular","homepage":null,"size":10473,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"33500e986b617ba1cdfca5a2d7a22af5e41308d4","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","created_at":"2014-09-18T16:12:01Z","updated_at":"2015-07-15T17:51:08Z","pushed_at":"2015-07-15T18:59:36Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":34511,"stargazers_count":4213,"watchers_count":4213,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1096,"mirror_url":null,"open_issues_count":380,"forks":1096,"open_issues":380,"watchers":4213,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/3069"},"html":{"href":"https://github.com/angular/angular/pull/3069"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/3069"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/3069/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/3069/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/3069/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/fdb721030215d508e8c6afbc33f91dd26b4f0493"}}}}