{"push_id":612051913,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"6f1930a4a76c2e44eb4e98993862376e1adf2660","before":"4328ffc8ad5b13ee3adec18c292afa0d7e2090af","commits":[{"sha":"6f1930a4a76c2e44eb4e98993862376e1adf2660","author":{"email":"9f0bf2adee05513e15363471857cce616f4c4b2c@spencerkrum.com","name":"Spencer Krum"},"message":"Lift the requirement for aligned hashrockets\n\nHashrockets have been required to be aligned for a long time. This\nhas long been attributed to readability. I wonder if there is real\ndata to support this, or if readability is a matter of preference.\n\nAt OpenStack, we find that the aligned hashrockets restriction causes\nunnecessary churn in the code base. Every time a new parameter is added\nwith a different length, the entire code bock shifts in or out.\n\nThere are two major problems from this. Removing the restriction removes\nthe problem:\n\n1) git-blame doesn't show correct information. Instead of showing the\nlast person/commit that materially changed the line in question, it shows\nthe last person/commit that tabbed the line in or out.\nThere are whitespace-ignoring options that can be used on the command\nline, but there is a lot of tooling around git and not all of it runs\nin this mode.\n\n2) Code review has more code changing. What should be a one line change\nto review now looks like several other parameters have been changed or\nadded. At OpenStack we review a lot of code, increasing the speed that\nwe can review at is the single biggest way to move our project forward\nfaster.\n\nThis came out of a discussion this review:\nhttps://review.openstack.org/#/c/164819/","distinct":true,"url":"https://api.github.com/repos/nibalizer/puppet-docs/commits/6f1930a4a76c2e44eb4e98993862376e1adf2660"}]}