{"action":"closed","number":164,"pull_request":{"url":"https://api.github.com/repos/echocat/puppet-graphite/pulls/164","id":31542771,"html_url":"https://github.com/echocat/puppet-graphite/pull/164","diff_url":"https://github.com/echocat/puppet-graphite/pull/164.diff","patch_url":"https://github.com/echocat/puppet-graphite/pull/164.patch","issue_url":"https://api.github.com/repos/echocat/puppet-graphite/issues/164","number":164,"state":"closed","locked":false,"title":"Fix init script error for Redhat and fix some bash style","user":{"login":"jordiclariana","id":657626,"avatar_url":"https://avatars.githubusercontent.com/u/657626?v=3","gravatar_id":"","url":"https://api.github.com/users/jordiclariana","html_url":"https://github.com/jordiclariana","followers_url":"https://api.github.com/users/jordiclariana/followers","following_url":"https://api.github.com/users/jordiclariana/following{/other_user}","gists_url":"https://api.github.com/users/jordiclariana/gists{/gist_id}","starred_url":"https://api.github.com/users/jordiclariana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jordiclariana/subscriptions","organizations_url":"https://api.github.com/users/jordiclariana/orgs","repos_url":"https://api.github.com/users/jordiclariana/repos","events_url":"https://api.github.com/users/jordiclariana/events{/privacy}","received_events_url":"https://api.github.com/users/jordiclariana/received_events","type":"User","site_admin":false},"body":"The fix in the Redhat scripts is when \"rh_status_q\" is used as condition of an if. Between [] is treated as literal, no function, so it's always true.\r\n\r\nStyle changed to standards. I want to change more but I didn't, because we are using \"sh\" instead of \"bash\" (even if it is the same in the system where it's running, we cannot asure that always). For instance:\r\n\r\nCNT=$(expr ${CNT} - 1)\r\n\r\nis better expressed as:\r\n\r\n((CNT--))\r\n","created_at":"2015-03-19T16:52:29Z","updated_at":"2015-03-20T06:18:00Z","closed_at":"2015-03-20T06:18:00Z","merged_at":"2015-03-20T06:18:00Z","merge_commit_sha":"a9af25b034beb6f72d82c9c8ad2f0a3e7adfb339","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/echocat/puppet-graphite/pulls/164/commits","review_comments_url":"https://api.github.com/repos/echocat/puppet-graphite/pulls/164/comments","review_comment_url":"https://api.github.com/repos/echocat/puppet-graphite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/echocat/puppet-graphite/issues/164/comments","statuses_url":"https://api.github.com/repos/echocat/puppet-graphite/statuses/d1da88fdc69b77f3a39d1dd572314b043e37a3a2","head":{"label":"trovitsys:master","ref":"master","sha":"d1da88fdc69b77f3a39d1dd572314b043e37a3a2","user":{"login":"trovitsys","id":11089155,"avatar_url":"https://avatars.githubusercontent.com/u/11089155?v=3","gravatar_id":"","url":"https://api.github.com/users/trovitsys","html_url":"https://github.com/trovitsys","followers_url":"https://api.github.com/users/trovitsys/followers","following_url":"https://api.github.com/users/trovitsys/following{/other_user}","gists_url":"https://api.github.com/users/trovitsys/gists{/gist_id}","starred_url":"https://api.github.com/users/trovitsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trovitsys/subscriptions","organizations_url":"https://api.github.com/users/trovitsys/orgs","repos_url":"https://api.github.com/users/trovitsys/repos","events_url":"https://api.github.com/users/trovitsys/events{/privacy}","received_events_url":"https://api.github.com/users/trovitsys/received_events","type":"Organization","site_admin":false},"repo":{"id":32532363,"name":"puppet-graphite","full_name":"trovitsys/puppet-graphite","owner":{"login":"trovitsys","id":11089155,"avatar_url":"https://avatars.githubusercontent.com/u/11089155?v=3","gravatar_id":"","url":"https://api.github.com/users/trovitsys","html_url":"https://github.com/trovitsys","followers_url":"https://api.github.com/users/trovitsys/followers","following_url":"https://api.github.com/users/trovitsys/following{/other_user}","gists_url":"https://api.github.com/users/trovitsys/gists{/gist_id}","starred_url":"https://api.github.com/users/trovitsys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trovitsys/subscriptions","organizations_url":"https://api.github.com/users/trovitsys/orgs","repos_url":"https://api.github.com/users/trovitsys/repos","events_url":"https://api.github.com/users/trovitsys/events{/privacy}","received_events_url":"https://api.github.com/users/trovitsys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trovitsys/puppet-graphite","description":"Puppet module for graphite monitoring tools","fork":true,"url":"https://api.github.com/repos/trovitsys/puppet-graphite","forks_url":"https://api.github.com/repos/trovitsys/puppet-graphite/forks","keys_url":"https://api.github.com/repos/trovitsys/puppet-graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trovitsys/puppet-graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trovitsys/puppet-graphite/teams","hooks_url":"https://api.github.com/repos/trovitsys/puppet-graphite/hooks","issue_events_url":"https://api.github.com/repos/trovitsys/puppet-graphite/issues/events{/number}","events_url":"https://api.github.com/repos/trovitsys/puppet-graphite/events","assignees_url":"https://api.github.com/repos/trovitsys/puppet-graphite/assignees{/user}","branches_url":"https://api.github.com/repos/trovitsys/puppet-graphite/branches{/branch}","tags_url":"https://api.github.com/repos/trovitsys/puppet-graphite/tags","blobs_url":"https://api.github.com/repos/trovitsys/puppet-graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trovitsys/puppet-graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trovitsys/puppet-graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/trovitsys/puppet-graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trovitsys/puppet-graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/trovitsys/puppet-graphite/languages","stargazers_url":"https://api.github.com/repos/trovitsys/puppet-graphite/stargazers","contributors_url":"https://api.github.com/repos/trovitsys/puppet-graphite/contributors","subscribers_url":"https://api.github.com/repos/trovitsys/puppet-graphite/subscribers","subscription_url":"https://api.github.com/repos/trovitsys/puppet-graphite/subscription","commits_url":"https://api.github.com/repos/trovitsys/puppet-graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/trovitsys/puppet-graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/trovitsys/puppet-graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/trovitsys/puppet-graphite/issues/comments{/number}","contents_url":"https://api.github.com/repos/trovitsys/puppet-graphite/contents/{+path}","compare_url":"https://api.github.com/repos/trovitsys/puppet-graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trovitsys/puppet-graphite/merges","archive_url":"https://api.github.com/repos/trovitsys/puppet-graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trovitsys/puppet-graphite/downloads","issues_url":"https://api.github.com/repos/trovitsys/puppet-graphite/issues{/number}","pulls_url":"https://api.github.com/repos/trovitsys/puppet-graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/trovitsys/puppet-graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/trovitsys/puppet-graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trovitsys/puppet-graphite/labels{/name}","releases_url":"https://api.github.com/repos/trovitsys/puppet-graphite/releases{/id}","created_at":"2015-03-19T16:13:19Z","updated_at":"2015-03-19T16:47:11Z","pushed_at":"2015-03-19T16:47:11Z","git_url":"git://github.com/trovitsys/puppet-graphite.git","ssh_url":"git@github.com:trovitsys/puppet-graphite.git","clone_url":"https://github.com/trovitsys/puppet-graphite.git","svn_url":"https://github.com/trovitsys/puppet-graphite","homepage":null,"size":1960,"stargazers_count":0,"watchers_count":0,"language":"Puppet","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"echocat:master","ref":"master","sha":"f4b869d3ed96b62ea049733e96f8e88465b3c419","user":{"login":"echocat","id":3128980,"avatar_url":"https://avatars.githubusercontent.com/u/3128980?v=3","gravatar_id":"","url":"https://api.github.com/users/echocat","html_url":"https://github.com/echocat","followers_url":"https://api.github.com/users/echocat/followers","following_url":"https://api.github.com/users/echocat/following{/other_user}","gists_url":"https://api.github.com/users/echocat/gists{/gist_id}","starred_url":"https://api.github.com/users/echocat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echocat/subscriptions","organizations_url":"https://api.github.com/users/echocat/orgs","repos_url":"https://api.github.com/users/echocat/repos","events_url":"https://api.github.com/users/echocat/events{/privacy}","received_events_url":"https://api.github.com/users/echocat/received_events","type":"Organization","site_admin":false},"repo":{"id":5362897,"name":"puppet-graphite","full_name":"echocat/puppet-graphite","owner":{"login":"echocat","id":3128980,"avatar_url":"https://avatars.githubusercontent.com/u/3128980?v=3","gravatar_id":"","url":"https://api.github.com/users/echocat","html_url":"https://github.com/echocat","followers_url":"https://api.github.com/users/echocat/followers","following_url":"https://api.github.com/users/echocat/following{/other_user}","gists_url":"https://api.github.com/users/echocat/gists{/gist_id}","starred_url":"https://api.github.com/users/echocat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/echocat/subscriptions","organizations_url":"https://api.github.com/users/echocat/orgs","repos_url":"https://api.github.com/users/echocat/repos","events_url":"https://api.github.com/users/echocat/events{/privacy}","received_events_url":"https://api.github.com/users/echocat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/echocat/puppet-graphite","description":"Puppet module for graphite monitoring tools","fork":false,"url":"https://api.github.com/repos/echocat/puppet-graphite","forks_url":"https://api.github.com/repos/echocat/puppet-graphite/forks","keys_url":"https://api.github.com/repos/echocat/puppet-graphite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/echocat/puppet-graphite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/echocat/puppet-graphite/teams","hooks_url":"https://api.github.com/repos/echocat/puppet-graphite/hooks","issue_events_url":"https://api.github.com/repos/echocat/puppet-graphite/issues/events{/number}","events_url":"https://api.github.com/repos/echocat/puppet-graphite/events","assignees_url":"https://api.github.com/repos/echocat/puppet-graphite/assignees{/user}","branches_url":"https://api.github.com/repos/echocat/puppet-graphite/branches{/branch}","tags_url":"https://api.github.com/repos/echocat/puppet-graphite/tags","blobs_url":"https://api.github.com/repos/echocat/puppet-graphite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/echocat/puppet-graphite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/echocat/puppet-graphite/git/refs{/sha}","trees_url":"https://api.github.com/repos/echocat/puppet-graphite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/echocat/puppet-graphite/statuses/{sha}","languages_url":"https://api.github.com/repos/echocat/puppet-graphite/languages","stargazers_url":"https://api.github.com/repos/echocat/puppet-graphite/stargazers","contributors_url":"https://api.github.com/repos/echocat/puppet-graphite/contributors","subscribers_url":"https://api.github.com/repos/echocat/puppet-graphite/subscribers","subscription_url":"https://api.github.com/repos/echocat/puppet-graphite/subscription","commits_url":"https://api.github.com/repos/echocat/puppet-graphite/commits{/sha}","git_commits_url":"https://api.github.com/repos/echocat/puppet-graphite/git/commits{/sha}","comments_url":"https://api.github.com/repos/echocat/puppet-graphite/comments{/number}","issue_comment_url":"https://api.github.com/repos/echocat/puppet-graphite/issues/comments{/number}","contents_url":"https://api.github.com/repos/echocat/puppet-graphite/contents/{+path}","compare_url":"https://api.github.com/repos/echocat/puppet-graphite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/echocat/puppet-graphite/merges","archive_url":"https://api.github.com/repos/echocat/puppet-graphite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/echocat/puppet-graphite/downloads","issues_url":"https://api.github.com/repos/echocat/puppet-graphite/issues{/number}","pulls_url":"https://api.github.com/repos/echocat/puppet-graphite/pulls{/number}","milestones_url":"https://api.github.com/repos/echocat/puppet-graphite/milestones{/number}","notifications_url":"https://api.github.com/repos/echocat/puppet-graphite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/echocat/puppet-graphite/labels{/name}","releases_url":"https://api.github.com/repos/echocat/puppet-graphite/releases{/id}","created_at":"2012-08-10T00:04:41Z","updated_at":"2015-03-10T17:47:26Z","pushed_at":"2015-03-20T06:18:00Z","git_url":"git://github.com/echocat/puppet-graphite.git","ssh_url":"git@github.com:echocat/puppet-graphite.git","clone_url":"https://github.com/echocat/puppet-graphite.git","svn_url":"https://github.com/echocat/puppet-graphite","homepage":null,"size":1960,"stargazers_count":46,"watchers_count":46,"language":"Puppet","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":111,"mirror_url":null,"open_issues_count":8,"forks":111,"open_issues":8,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/echocat/puppet-graphite/pulls/164"},"html":{"href":"https://github.com/echocat/puppet-graphite/pull/164"},"issue":{"href":"https://api.github.com/repos/echocat/puppet-graphite/issues/164"},"comments":{"href":"https://api.github.com/repos/echocat/puppet-graphite/issues/164/comments"},"review_comments":{"href":"https://api.github.com/repos/echocat/puppet-graphite/pulls/164/comments"},"review_comment":{"href":"https://api.github.com/repos/echocat/puppet-graphite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/echocat/puppet-graphite/pulls/164/commits"},"statuses":{"href":"https://api.github.com/repos/echocat/puppet-graphite/statuses/d1da88fdc69b77f3a39d1dd572314b043e37a3a2"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"dwerder","id":2126417,"avatar_url":"https://avatars.githubusercontent.com/u/2126417?v=3","gravatar_id":"","url":"https://api.github.com/users/dwerder","html_url":"https://github.com/dwerder","followers_url":"https://api.github.com/users/dwerder/followers","following_url":"https://api.github.com/users/dwerder/following{/other_user}","gists_url":"https://api.github.com/users/dwerder/gists{/gist_id}","starred_url":"https://api.github.com/users/dwerder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dwerder/subscriptions","organizations_url":"https://api.github.com/users/dwerder/orgs","repos_url":"https://api.github.com/users/dwerder/repos","events_url":"https://api.github.com/users/dwerder/events{/privacy}","received_events_url":"https://api.github.com/users/dwerder/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":39,"deletions":40,"changed_files":6}}