{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3235","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3235/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3235/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3235/events","html_url":"https://github.com/ManageIQ/manageiq/pull/3235","id":90258062,"number":3235,"title":"Foreman tagging now applied during provisioning ","user":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/providers/foreman","name":"providers/foreman","color":"5319e7"},{"url":"https://api.github.com/repos/ManageIQ/manageiq/labels/provisioning","name":"provisioning","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"kbrock","id":1930,"avatar_url":"https://avatars.githubusercontent.com/u/1930?v=3","gravatar_id":"","url":"https://api.github.com/users/kbrock","html_url":"https://github.com/kbrock","followers_url":"https://api.github.com/users/kbrock/followers","following_url":"https://api.github.com/users/kbrock/following{/other_user}","gists_url":"https://api.github.com/users/kbrock/gists{/gist_id}","starred_url":"https://api.github.com/users/kbrock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kbrock/subscriptions","organizations_url":"https://api.github.com/users/kbrock/orgs","repos_url":"https://api.github.com/users/kbrock/repos","events_url":"https://api.github.com/users/kbrock/events{/privacy}","received_events_url":"https://api.github.com/users/kbrock/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-06-23T01:28:55Z","updated_at":"2015-06-23T13:01:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/3235","html_url":"https://github.com/ManageIQ/manageiq/pull/3235","diff_url":"https://github.com/ManageIQ/manageiq/pull/3235.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/3235.patch"},"body":"We were able to provision a Host, but the tags were not getting applied.\r\n\r\nTurns out the key for tags varies across workflows and requests/tasks. In some places it is `:vm_tags`, while other places use `:tag_ids`. The desired behavior is to use `:tag_ids` everywhere but vm provisioning.\r\n\r\nThe foreman provisioning dialog was putting the tags into `:vm_tags`.\r\nThe foreman request was reading the tags from `:tag_ids`. since the tags were not stored there, no tags were applied to the newly configured system.\r\n\r\nThe solution is straight forward:\r\n- better state where the tags should be stored in the workflow.\r\n- update the foreman ui to store the tags in the proper place.\r\n\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1227211\r\n /cc @gmcculloug @brandondunne I am having trouble testing this."},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/114492771","html_url":"https://github.com/ManageIQ/manageiq/pull/3235#issuecomment-114492771","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/3235","id":114492771,"user":{"login":"brandondunne","id":651659,"avatar_url":"https://avatars.githubusercontent.com/u/651659?v=3","gravatar_id":"","url":"https://api.github.com/users/brandondunne","html_url":"https://github.com/brandondunne","followers_url":"https://api.github.com/users/brandondunne/followers","following_url":"https://api.github.com/users/brandondunne/following{/other_user}","gists_url":"https://api.github.com/users/brandondunne/gists{/gist_id}","starred_url":"https://api.github.com/users/brandondunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandondunne/subscriptions","organizations_url":"https://api.github.com/users/brandondunne/orgs","repos_url":"https://api.github.com/users/brandondunne/repos","events_url":"https://api.github.com/users/brandondunne/events{/privacy}","received_events_url":"https://api.github.com/users/brandondunne/received_events","type":"User","site_admin":false},"created_at":"2015-06-23T13:01:11Z","updated_at":"2015-06-23T13:01:11Z","body":"@kbrock Nice fix.  Only concern (aside from the rubocop comment) is the change to application_helper_spec.rb which doesn't seem to belong to this PR, correct?"}}