{"action":"created","issue":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/892","labels_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/892/labels{/name}","comments_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/892/comments","events_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/892/events","html_url":"https://github.com/sinkillerj/ProjectE/pull/892","id":99068863,"number":892,"title":"Grand Alchemical Guidebook","user":{"login":"Lilylicious","id":5985728,"avatar_url":"https://avatars.githubusercontent.com/u/5985728?v=3","gravatar_id":"","url":"https://api.github.com/users/Lilylicious","html_url":"https://github.com/Lilylicious","followers_url":"https://api.github.com/users/Lilylicious/followers","following_url":"https://api.github.com/users/Lilylicious/following{/other_user}","gists_url":"https://api.github.com/users/Lilylicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lilylicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lilylicious/subscriptions","organizations_url":"https://api.github.com/users/Lilylicious/orgs","repos_url":"https://api.github.com/users/Lilylicious/repos","events_url":"https://api.github.com/users/Lilylicious/events{/privacy}","received_events_url":"https://api.github.com/users/Lilylicious/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-08-04T21:44:46Z","updated_at":"2015-08-05T07:30:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/pulls/892","html_url":"https://github.com/sinkillerj/ProjectE/pull/892","diff_url":"https://github.com/sinkillerj/ProjectE/pull/892.diff","patch_url":"https://github.com/sinkillerj/ProjectE/pull/892.patch"},"body":"Here's the collected work of me and Willie for the past month.\r\n\r\nImportant note regarding pre-existing files:\r\n* ObjHandler reworked the way it registers items. Functionally the same with a few added extras related to the guidebook. \r\n\r\nRegarding the ManualFontRenderer, it's lengthy and a mess, but the most elegant way short of writing a whole new fontrenderer to adjust the private function I needed to. Would've been a cakewalk if it had been public, but nope."},"comment":{"url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/comments/127899568","html_url":"https://github.com/sinkillerj/ProjectE/pull/892#issuecomment-127899568","issue_url":"https://api.github.com/repos/sinkillerj/ProjectE/issues/892","id":127899568,"user":{"login":"Lilylicious","id":5985728,"avatar_url":"https://avatars.githubusercontent.com/u/5985728?v=3","gravatar_id":"","url":"https://api.github.com/users/Lilylicious","html_url":"https://github.com/Lilylicious","followers_url":"https://api.github.com/users/Lilylicious/followers","following_url":"https://api.github.com/users/Lilylicious/following{/other_user}","gists_url":"https://api.github.com/users/Lilylicious/gists{/gist_id}","starred_url":"https://api.github.com/users/Lilylicious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lilylicious/subscriptions","organizations_url":"https://api.github.com/users/Lilylicious/orgs","repos_url":"https://api.github.com/users/Lilylicious/repos","events_url":"https://api.github.com/users/Lilylicious/events{/privacy}","received_events_url":"https://api.github.com/users/Lilylicious/received_events","type":"User","site_admin":false},"created_at":"2015-08-05T07:30:43Z","updated_at":"2015-08-05T07:30:43Z","body":"Is there any harm in registering in a function? If not, can just remove the\npart of the function that does the .add thing and see if anything breaks.\nIf not, great.\n\nOn Wednesday, August 5, 2015, Vincent Lee <notifications@github.com> wrote:\n\n> Oh, they were there from my changes? I'm pretty sure I removed it if it\n> was me .-.\n> It was in there for a brief moment when I was toying around with\n> automatically registering everything by grabbing it off objhandler. But\n> somewhere along the line we went back to manually declaring everything in\n> ManualPageHandler. So it can be removed, I guess, if nothing else uses it\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/sinkillerj/ProjectE/pull/892#issuecomment-127899333>.\n>\n"}}