{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/46075059","id":46075059,"diff_hunk":"@@ -240,6 +240,7 @@ func LogLocation(getter ResourceGetter, connInfo client.ConnectionInfoGetter, ct\n \t}\n \n \t// Try to figure out a container\n+\t// If a container was provided, it must be valid\n \tcontainer := opts.Container\n \tif container == \"\" {","path":"pkg/registry/pod/strategy.go","position":6,"original_position":6,"commit_id":"bd90254c42508ee6c388683a51d8aa81e2b47ca8","original_commit_id":"bd90254c42508ee6c388683a51d8aa81e2b47ca8","user":{"login":"kargakis","id":3900799,"avatar_url":"https://avatars.githubusercontent.com/u/3900799?v=3","gravatar_id":"","url":"https://api.github.com/users/kargakis","html_url":"https://github.com/kargakis","followers_url":"https://api.github.com/users/kargakis/followers","following_url":"https://api.github.com/users/kargakis/following{/other_user}","gists_url":"https://api.github.com/users/kargakis/gists{/gist_id}","starred_url":"https://api.github.com/users/kargakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kargakis/subscriptions","organizations_url":"https://api.github.com/users/kargakis/orgs","repos_url":"https://api.github.com/users/kargakis/repos","events_url":"https://api.github.com/users/kargakis/events{/privacy}","received_events_url":"https://api.github.com/users/kargakis/received_events","type":"User","site_admin":false},"body":"Mind changing this to `len(container) == 0`","created_at":"2015-11-28T02:42:06Z","updated_at":"2015-11-28T02:42:06Z","html_url":"https://github.com/kubernetes/kubernetes/pull/17886#discussion_r46075059","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/46075059"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17886#discussion_r46075059"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886","id":52017785,"html_url":"https://github.com/kubernetes/kubernetes/pull/17886","diff_url":"https://github.com/kubernetes/kubernetes/pull/17886.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17886.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17886","number":17886,"state":"open","locked":false,"title":"Pod log location must validate container if provided","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"body":"When checking the log URL for a pod container we must validate the container name if provided, otherwise the method will return an URL that is actually not valid and results in an error when called, e.g. `the server could not find the requested resource ( Pod mypod)`.","created_at":"2015-11-27T18:24:10Z","updated_at":"2015-11-28T02:42:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65c68256e834b1175521ce256f90bbe63627cd69","assignee":{"login":"liggitt","id":980082,"avatar_url":"https://avatars.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17886/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/bd90254c42508ee6c388683a51d8aa81e2b47ca8","head":{"label":"fabianofranz:pod_logs_validate_container","ref":"pod_logs_validate_container","sha":"bd90254c42508ee6c388683a51d8aa81e2b47ca8","user":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"repo":{"id":26227498,"name":"kubernetes","full_name":"fabianofranz/kubernetes","owner":{"login":"fabianofranz","id":158611,"avatar_url":"https://avatars.githubusercontent.com/u/158611?v=3","gravatar_id":"","url":"https://api.github.com/users/fabianofranz","html_url":"https://github.com/fabianofranz","followers_url":"https://api.github.com/users/fabianofranz/followers","following_url":"https://api.github.com/users/fabianofranz/following{/other_user}","gists_url":"https://api.github.com/users/fabianofranz/gists{/gist_id}","starred_url":"https://api.github.com/users/fabianofranz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabianofranz/subscriptions","organizations_url":"https://api.github.com/users/fabianofranz/orgs","repos_url":"https://api.github.com/users/fabianofranz/repos","events_url":"https://api.github.com/users/fabianofranz/events{/privacy}","received_events_url":"https://api.github.com/users/fabianofranz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabianofranz/kubernetes","description":"Fork for managing OpenShift's dependencies on Kubernetes","fork":true,"url":"https://api.github.com/repos/fabianofranz/kubernetes","forks_url":"https://api.github.com/repos/fabianofranz/kubernetes/forks","keys_url":"https://api.github.com/repos/fabianofranz/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabianofranz/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabianofranz/kubernetes/teams","hooks_url":"https://api.github.com/repos/fabianofranz/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/fabianofranz/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/fabianofranz/kubernetes/events","assignees_url":"https://api.github.com/repos/fabianofranz/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/fabianofranz/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/fabianofranz/kubernetes/tags","blobs_url":"https://api.github.com/repos/fabianofranz/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabianofranz/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabianofranz/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabianofranz/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabianofranz/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/fabianofranz/kubernetes/languages","stargazers_url":"https://api.github.com/repos/fabianofranz/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/fabianofranz/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/fabianofranz/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/fabianofranz/kubernetes/subscription","commits_url":"https://api.github.com/repos/fabianofranz/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabianofranz/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabianofranz/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabianofranz/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabianofranz/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/fabianofranz/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabianofranz/kubernetes/merges","archive_url":"https://api.github.com/repos/fabianofranz/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabianofranz/kubernetes/downloads","issues_url":"https://api.github.com/repos/fabianofranz/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/fabianofranz/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/fabianofranz/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/fabianofranz/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabianofranz/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/fabianofranz/kubernetes/releases{/id}","created_at":"2014-11-05T16:05:58Z","updated_at":"2015-02-04T20:10:09Z","pushed_at":"2015-11-27T20:30:33Z","git_url":"git://github.com/fabianofranz/kubernetes.git","ssh_url":"git@github.com:fabianofranz/kubernetes.git","clone_url":"https://github.com/fabianofranz/kubernetes.git","svn_url":"https://github.com/fabianofranz/kubernetes","homepage":"https://github.com/openshift/kubernetes/wiki","size":135427,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"158fecd474711026248f13754b24c70d323a33d5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-28T02:04:39Z","pushed_at":"2015-11-28T02:30:53Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":290100,"stargazers_count":11501,"watchers_count":11501,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3082,"mirror_url":null,"open_issues_count":2432,"forks":3082,"open_issues":2432,"watchers":11501,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17886"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17886"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17886/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17886/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/bd90254c42508ee6c388683a51d8aa81e2b47ca8"}}}}