{"action":"created","comment":{"url":"https://api.github.com/repos/alphagov/policy-publisher/pulls/comments/41513369","id":41513369,"diff_hunk":"@@ -159,11 +159,19 @@ def facets\n         name: \"Document type\",\n         preposition: \"of type\",\n         type: \"text\",\n-        display_as_result_metadata: true,\n+        display_as_result_metadata: false,\n         filterable: true,\n         allowed_values: detailed_format_allowed_values,\n       },\n       {\n+        key: \"display_type\",\n+        name: \"Document type\",\n+        preposition: \"of type\",","path":"app/presenters/content_item_presenter.rb","position":12,"original_position":12,"commit_id":"4b28cde0d8a1179e7c22e5c125511fc2ca2558d7","original_commit_id":"4b28cde0d8a1179e7c22e5c125511fc2ca2558d7","user":{"login":"tommyp","id":449004,"avatar_url":"https://avatars.githubusercontent.com/u/449004?v=3","gravatar_id":"","url":"https://api.github.com/users/tommyp","html_url":"https://github.com/tommyp","followers_url":"https://api.github.com/users/tommyp/followers","following_url":"https://api.github.com/users/tommyp/following{/other_user}","gists_url":"https://api.github.com/users/tommyp/gists{/gist_id}","starred_url":"https://api.github.com/users/tommyp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tommyp/subscriptions","organizations_url":"https://api.github.com/users/tommyp/orgs","repos_url":"https://api.github.com/users/tommyp/repos","events_url":"https://api.github.com/users/tommyp/events{/privacy}","received_events_url":"https://api.github.com/users/tommyp/received_events","type":"User","site_admin":false},"body":"`is_historic` is a bit of a weird case, but either way I think you're right about `type`. I don't think it's required. ","created_at":"2015-10-08T13:41:14Z","updated_at":"2015-10-08T13:41:14Z","html_url":"https://github.com/alphagov/policy-publisher/pull/106#discussion_r41513369","pull_request_url":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106","_links":{"self":{"href":"https://api.github.com/repos/alphagov/policy-publisher/pulls/comments/41513369"},"html":{"href":"https://github.com/alphagov/policy-publisher/pull/106#discussion_r41513369"},"pull_request":{"href":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106"}}},"pull_request":{"url":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106","id":47130228,"html_url":"https://github.com/alphagov/policy-publisher/pull/106","diff_url":"https://github.com/alphagov/policy-publisher/pull/106.diff","patch_url":"https://github.com/alphagov/policy-publisher/pull/106.patch","issue_url":"https://api.github.com/repos/alphagov/policy-publisher/issues/106","number":106,"state":"open","locked":false,"title":"Use 'display_type' Rummager field in results list","user":{"login":"benilovj","id":23801,"avatar_url":"https://avatars.githubusercontent.com/u/23801?v=3","gravatar_id":"","url":"https://api.github.com/users/benilovj","html_url":"https://github.com/benilovj","followers_url":"https://api.github.com/users/benilovj/followers","following_url":"https://api.github.com/users/benilovj/following{/other_user}","gists_url":"https://api.github.com/users/benilovj/gists{/gist_id}","starred_url":"https://api.github.com/users/benilovj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benilovj/subscriptions","organizations_url":"https://api.github.com/users/benilovj/orgs","repos_url":"https://api.github.com/users/benilovj/repos","events_url":"https://api.github.com/users/benilovj/events{/privacy}","received_events_url":"https://api.github.com/users/benilovj/received_events","type":"User","site_admin":false},"body":"In the Rummager results, `detailed_format.value` and\r\n`display_type` contain the same information. Using\r\n`display_type` for the label in the search results\r\nwill allow getting rid of the `detailed_format.value`\r\nfrom Rummager.\r\n\r\n/cc @tijmenb @tommyp @rboulton ","created_at":"2015-10-08T09:31:48Z","updated_at":"2015-10-08T13:41:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"093e72f43947a5300b17bc1c21dda8a5c9e4ed3d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106/commits","review_comments_url":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106/comments","review_comment_url":"https://api.github.com/repos/alphagov/policy-publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/policy-publisher/issues/106/comments","statuses_url":"https://api.github.com/repos/alphagov/policy-publisher/statuses/4b28cde0d8a1179e7c22e5c125511fc2ca2558d7","head":{"label":"alphagov:use-display-type-instead-of-detailed_format-in-result-list","ref":"use-display-type-instead-of-detailed_format-in-result-list","sha":"4b28cde0d8a1179e7c22e5c125511fc2ca2558d7","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":30296685,"name":"policy-publisher","full_name":"alphagov/policy-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/policy-publisher","description":"Create and manage policies and policy programmes","fork":false,"url":"https://api.github.com/repos/alphagov/policy-publisher","forks_url":"https://api.github.com/repos/alphagov/policy-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/policy-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/policy-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/policy-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/policy-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/policy-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/policy-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/policy-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/policy-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/policy-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/policy-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/policy-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/policy-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/policy-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/policy-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/policy-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/policy-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/policy-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/policy-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/policy-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/policy-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/policy-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/policy-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/policy-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/policy-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/policy-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/policy-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/policy-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/policy-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/policy-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/policy-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/policy-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/policy-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/policy-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/policy-publisher/releases{/id}","created_at":"2015-02-04T11:57:35Z","updated_at":"2015-05-08T09:14:53Z","pushed_at":"2015-10-08T09:31:48Z","git_url":"git://github.com/alphagov/policy-publisher.git","ssh_url":"git@github.com:alphagov/policy-publisher.git","clone_url":"https://github.com/alphagov/policy-publisher.git","svn_url":"https://github.com/alphagov/policy-publisher","homepage":"","size":2059,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"c50215bc48a8e5894bd905e58b99a12abf2a5922","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":30296685,"name":"policy-publisher","full_name":"alphagov/policy-publisher","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/policy-publisher","description":"Create and manage policies and policy programmes","fork":false,"url":"https://api.github.com/repos/alphagov/policy-publisher","forks_url":"https://api.github.com/repos/alphagov/policy-publisher/forks","keys_url":"https://api.github.com/repos/alphagov/policy-publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/policy-publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/policy-publisher/teams","hooks_url":"https://api.github.com/repos/alphagov/policy-publisher/hooks","issue_events_url":"https://api.github.com/repos/alphagov/policy-publisher/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/policy-publisher/events","assignees_url":"https://api.github.com/repos/alphagov/policy-publisher/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/policy-publisher/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/policy-publisher/tags","blobs_url":"https://api.github.com/repos/alphagov/policy-publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/policy-publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/policy-publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/policy-publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/policy-publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/policy-publisher/languages","stargazers_url":"https://api.github.com/repos/alphagov/policy-publisher/stargazers","contributors_url":"https://api.github.com/repos/alphagov/policy-publisher/contributors","subscribers_url":"https://api.github.com/repos/alphagov/policy-publisher/subscribers","subscription_url":"https://api.github.com/repos/alphagov/policy-publisher/subscription","commits_url":"https://api.github.com/repos/alphagov/policy-publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/policy-publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/policy-publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/policy-publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/policy-publisher/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/policy-publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/policy-publisher/merges","archive_url":"https://api.github.com/repos/alphagov/policy-publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/policy-publisher/downloads","issues_url":"https://api.github.com/repos/alphagov/policy-publisher/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/policy-publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/policy-publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/policy-publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/policy-publisher/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/policy-publisher/releases{/id}","created_at":"2015-02-04T11:57:35Z","updated_at":"2015-05-08T09:14:53Z","pushed_at":"2015-10-08T09:31:48Z","git_url":"git://github.com/alphagov/policy-publisher.git","ssh_url":"git@github.com:alphagov/policy-publisher.git","clone_url":"https://github.com/alphagov/policy-publisher.git","svn_url":"https://github.com/alphagov/policy-publisher","homepage":"","size":2059,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106"},"html":{"href":"https://github.com/alphagov/policy-publisher/pull/106"},"issue":{"href":"https://api.github.com/repos/alphagov/policy-publisher/issues/106"},"comments":{"href":"https://api.github.com/repos/alphagov/policy-publisher/issues/106/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/policy-publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/policy-publisher/pulls/106/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/policy-publisher/statuses/4b28cde0d8a1179e7c22e5c125511fc2ca2558d7"}}}}