{"action":"created","comment":{"url":"https://api.github.com/repos/superdesk/superdesk/pulls/comments/34240239","id":34240239,"diff_hunk":"@@ -318,8 +318,8 @@ def publish(self, doc, updates, target_media_type=None):\n \n                 # Step 2(a)(i)\n                 subscribers = list(get_resource_service('subscribers').get(req=None, lookup=None))\n-                recipients = [s['email'] for s in subscribers]\n-                send_article_killed_email(doc, recipients, queued_items[0].get('completed_at'))\n+                recipients = [s.get('email') for s in subscribers]","path":"server/apps/publish/archive_publish.py","position":6,"original_position":6,"commit_id":"227859c04529f039b6b7edf873a6dd2935d710e6","original_commit_id":"227859c04529f039b6b7edf873a6dd2935d710e6","user":{"login":"plamut","id":1235663,"avatar_url":"https://avatars.githubusercontent.com/u/1235663?v=3","gravatar_id":"","url":"https://api.github.com/users/plamut","html_url":"https://github.com/plamut","followers_url":"https://api.github.com/users/plamut/followers","following_url":"https://api.github.com/users/plamut/following{/other_user}","gists_url":"https://api.github.com/users/plamut/gists{/gist_id}","starred_url":"https://api.github.com/users/plamut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plamut/subscriptions","organizations_url":"https://api.github.com/users/plamut/orgs","repos_url":"https://api.github.com/users/plamut/repos","events_url":"https://api.github.com/users/plamut/events{/privacy}","received_events_url":"https://api.github.com/users/plamut/received_events","type":"User","site_admin":false},"body":"We could even avoid that by adding the filtering condition to the expression itself, making the use of `filter()` unnecessary, what do you think?\r\n\r\n```py\r\nrecipients = list(s.get('email') for s in subscribers if s.get('email'))\r\n```","created_at":"2015-07-09T09:59:47Z","updated_at":"2015-07-09T09:59:47Z","html_url":"https://github.com/superdesk/superdesk/pull/813#discussion_r34240239","pull_request_url":"https://api.github.com/repos/superdesk/superdesk/pulls/813","_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk/pulls/comments/34240239"},"html":{"href":"https://github.com/superdesk/superdesk/pull/813#discussion_r34240239"},"pull_request":{"href":"https://api.github.com/repos/superdesk/superdesk/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/superdesk/superdesk/pulls/813","id":39540846,"html_url":"https://github.com/superdesk/superdesk/pull/813","diff_url":"https://github.com/superdesk/superdesk/pull/813.diff","patch_url":"https://github.com/superdesk/superdesk/pull/813.patch","issue_url":"https://api.github.com/repos/superdesk/superdesk/issues/813","number":813,"state":"open","locked":false,"title":"(fix) [SD-2269] Unclear error message when killing an item","user":{"login":"sivakuna-aap","id":8649779,"avatar_url":"https://avatars.githubusercontent.com/u/8649779?v=3","gravatar_id":"","url":"https://api.github.com/users/sivakuna-aap","html_url":"https://github.com/sivakuna-aap","followers_url":"https://api.github.com/users/sivakuna-aap/followers","following_url":"https://api.github.com/users/sivakuna-aap/following{/other_user}","gists_url":"https://api.github.com/users/sivakuna-aap/gists{/gist_id}","starred_url":"https://api.github.com/users/sivakuna-aap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivakuna-aap/subscriptions","organizations_url":"https://api.github.com/users/sivakuna-aap/orgs","repos_url":"https://api.github.com/users/sivakuna-aap/repos","events_url":"https://api.github.com/users/sivakuna-aap/events{/privacy}","received_events_url":"https://api.github.com/users/sivakuna-aap/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-07-09T01:39:44Z","updated_at":"2015-07-09T09:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1fb0dfc6445fe7b40f668bae4a47ab30cce0edeb","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/superdesk/superdesk/pulls/813/commits","review_comments_url":"https://api.github.com/repos/superdesk/superdesk/pulls/813/comments","review_comment_url":"https://api.github.com/repos/superdesk/superdesk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/superdesk/superdesk/issues/813/comments","statuses_url":"https://api.github.com/repos/superdesk/superdesk/statuses/227859c04529f039b6b7edf873a6dd2935d710e6","head":{"label":"sivakuna-aap:sd_2269","ref":"sd_2269","sha":"227859c04529f039b6b7edf873a6dd2935d710e6","user":{"login":"sivakuna-aap","id":8649779,"avatar_url":"https://avatars.githubusercontent.com/u/8649779?v=3","gravatar_id":"","url":"https://api.github.com/users/sivakuna-aap","html_url":"https://github.com/sivakuna-aap","followers_url":"https://api.github.com/users/sivakuna-aap/followers","following_url":"https://api.github.com/users/sivakuna-aap/following{/other_user}","gists_url":"https://api.github.com/users/sivakuna-aap/gists{/gist_id}","starred_url":"https://api.github.com/users/sivakuna-aap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivakuna-aap/subscriptions","organizations_url":"https://api.github.com/users/sivakuna-aap/orgs","repos_url":"https://api.github.com/users/sivakuna-aap/repos","events_url":"https://api.github.com/users/sivakuna-aap/events{/privacy}","received_events_url":"https://api.github.com/users/sivakuna-aap/received_events","type":"User","site_admin":false},"repo":{"id":30842703,"name":"superdesk","full_name":"sivakuna-aap/superdesk","owner":{"login":"sivakuna-aap","id":8649779,"avatar_url":"https://avatars.githubusercontent.com/u/8649779?v=3","gravatar_id":"","url":"https://api.github.com/users/sivakuna-aap","html_url":"https://github.com/sivakuna-aap","followers_url":"https://api.github.com/users/sivakuna-aap/followers","following_url":"https://api.github.com/users/sivakuna-aap/following{/other_user}","gists_url":"https://api.github.com/users/sivakuna-aap/gists{/gist_id}","starred_url":"https://api.github.com/users/sivakuna-aap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivakuna-aap/subscriptions","organizations_url":"https://api.github.com/users/sivakuna-aap/orgs","repos_url":"https://api.github.com/users/sivakuna-aap/repos","events_url":"https://api.github.com/users/sivakuna-aap/events{/privacy}","received_events_url":"https://api.github.com/users/sivakuna-aap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sivakuna-aap/superdesk","description":"","fork":true,"url":"https://api.github.com/repos/sivakuna-aap/superdesk","forks_url":"https://api.github.com/repos/sivakuna-aap/superdesk/forks","keys_url":"https://api.github.com/repos/sivakuna-aap/superdesk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sivakuna-aap/superdesk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sivakuna-aap/superdesk/teams","hooks_url":"https://api.github.com/repos/sivakuna-aap/superdesk/hooks","issue_events_url":"https://api.github.com/repos/sivakuna-aap/superdesk/issues/events{/number}","events_url":"https://api.github.com/repos/sivakuna-aap/superdesk/events","assignees_url":"https://api.github.com/repos/sivakuna-aap/superdesk/assignees{/user}","branches_url":"https://api.github.com/repos/sivakuna-aap/superdesk/branches{/branch}","tags_url":"https://api.github.com/repos/sivakuna-aap/superdesk/tags","blobs_url":"https://api.github.com/repos/sivakuna-aap/superdesk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sivakuna-aap/superdesk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sivakuna-aap/superdesk/git/refs{/sha}","trees_url":"https://api.github.com/repos/sivakuna-aap/superdesk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sivakuna-aap/superdesk/statuses/{sha}","languages_url":"https://api.github.com/repos/sivakuna-aap/superdesk/languages","stargazers_url":"https://api.github.com/repos/sivakuna-aap/superdesk/stargazers","contributors_url":"https://api.github.com/repos/sivakuna-aap/superdesk/contributors","subscribers_url":"https://api.github.com/repos/sivakuna-aap/superdesk/subscribers","subscription_url":"https://api.github.com/repos/sivakuna-aap/superdesk/subscription","commits_url":"https://api.github.com/repos/sivakuna-aap/superdesk/commits{/sha}","git_commits_url":"https://api.github.com/repos/sivakuna-aap/superdesk/git/commits{/sha}","comments_url":"https://api.github.com/repos/sivakuna-aap/superdesk/comments{/number}","issue_comment_url":"https://api.github.com/repos/sivakuna-aap/superdesk/issues/comments{/number}","contents_url":"https://api.github.com/repos/sivakuna-aap/superdesk/contents/{+path}","compare_url":"https://api.github.com/repos/sivakuna-aap/superdesk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sivakuna-aap/superdesk/merges","archive_url":"https://api.github.com/repos/sivakuna-aap/superdesk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sivakuna-aap/superdesk/downloads","issues_url":"https://api.github.com/repos/sivakuna-aap/superdesk/issues{/number}","pulls_url":"https://api.github.com/repos/sivakuna-aap/superdesk/pulls{/number}","milestones_url":"https://api.github.com/repos/sivakuna-aap/superdesk/milestones{/number}","notifications_url":"https://api.github.com/repos/sivakuna-aap/superdesk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sivakuna-aap/superdesk/labels{/name}","releases_url":"https://api.github.com/repos/sivakuna-aap/superdesk/releases{/id}","created_at":"2015-02-15T21:22:14Z","updated_at":"2015-05-08T10:59:33Z","pushed_at":"2015-07-09T09:01:22Z","git_url":"git://github.com/sivakuna-aap/superdesk.git","ssh_url":"git@github.com:sivakuna-aap/superdesk.git","clone_url":"https://github.com/sivakuna-aap/superdesk.git","svn_url":"https://github.com/sivakuna-aap/superdesk","homepage":null,"size":55182,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"superdesk:master","ref":"master","sha":"0e0113d06fffd9b71997e8e788874ef3979a35a9","user":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"repo":{"id":23570030,"name":"superdesk","full_name":"superdesk/superdesk","owner":{"login":"superdesk","id":5527298,"avatar_url":"https://avatars.githubusercontent.com/u/5527298?v=3","gravatar_id":"","url":"https://api.github.com/users/superdesk","html_url":"https://github.com/superdesk","followers_url":"https://api.github.com/users/superdesk/followers","following_url":"https://api.github.com/users/superdesk/following{/other_user}","gists_url":"https://api.github.com/users/superdesk/gists{/gist_id}","starred_url":"https://api.github.com/users/superdesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/superdesk/subscriptions","organizations_url":"https://api.github.com/users/superdesk/orgs","repos_url":"https://api.github.com/users/superdesk/repos","events_url":"https://api.github.com/users/superdesk/events{/privacy}","received_events_url":"https://api.github.com/users/superdesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/superdesk/superdesk","description":"The open source end-to-end news platform.","fork":false,"url":"https://api.github.com/repos/superdesk/superdesk","forks_url":"https://api.github.com/repos/superdesk/superdesk/forks","keys_url":"https://api.github.com/repos/superdesk/superdesk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/superdesk/superdesk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/superdesk/superdesk/teams","hooks_url":"https://api.github.com/repos/superdesk/superdesk/hooks","issue_events_url":"https://api.github.com/repos/superdesk/superdesk/issues/events{/number}","events_url":"https://api.github.com/repos/superdesk/superdesk/events","assignees_url":"https://api.github.com/repos/superdesk/superdesk/assignees{/user}","branches_url":"https://api.github.com/repos/superdesk/superdesk/branches{/branch}","tags_url":"https://api.github.com/repos/superdesk/superdesk/tags","blobs_url":"https://api.github.com/repos/superdesk/superdesk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/superdesk/superdesk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/superdesk/superdesk/git/refs{/sha}","trees_url":"https://api.github.com/repos/superdesk/superdesk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/superdesk/superdesk/statuses/{sha}","languages_url":"https://api.github.com/repos/superdesk/superdesk/languages","stargazers_url":"https://api.github.com/repos/superdesk/superdesk/stargazers","contributors_url":"https://api.github.com/repos/superdesk/superdesk/contributors","subscribers_url":"https://api.github.com/repos/superdesk/superdesk/subscribers","subscription_url":"https://api.github.com/repos/superdesk/superdesk/subscription","commits_url":"https://api.github.com/repos/superdesk/superdesk/commits{/sha}","git_commits_url":"https://api.github.com/repos/superdesk/superdesk/git/commits{/sha}","comments_url":"https://api.github.com/repos/superdesk/superdesk/comments{/number}","issue_comment_url":"https://api.github.com/repos/superdesk/superdesk/issues/comments{/number}","contents_url":"https://api.github.com/repos/superdesk/superdesk/contents/{+path}","compare_url":"https://api.github.com/repos/superdesk/superdesk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/superdesk/superdesk/merges","archive_url":"https://api.github.com/repos/superdesk/superdesk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/superdesk/superdesk/downloads","issues_url":"https://api.github.com/repos/superdesk/superdesk/issues{/number}","pulls_url":"https://api.github.com/repos/superdesk/superdesk/pulls{/number}","milestones_url":"https://api.github.com/repos/superdesk/superdesk/milestones{/number}","notifications_url":"https://api.github.com/repos/superdesk/superdesk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/superdesk/superdesk/labels{/name}","releases_url":"https://api.github.com/repos/superdesk/superdesk/releases{/id}","created_at":"2014-09-02T07:56:17Z","updated_at":"2015-07-05T21:26:56Z","pushed_at":"2015-07-09T09:59:40Z","git_url":"git://github.com/superdesk/superdesk.git","ssh_url":"git@github.com:superdesk/superdesk.git","clone_url":"https://github.com/superdesk/superdesk.git","svn_url":"https://github.com/superdesk/superdesk","homepage":"","size":63571,"stargazers_count":14,"watchers_count":14,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"open_issues_count":9,"forks":31,"open_issues":9,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/superdesk/superdesk/pulls/813"},"html":{"href":"https://github.com/superdesk/superdesk/pull/813"},"issue":{"href":"https://api.github.com/repos/superdesk/superdesk/issues/813"},"comments":{"href":"https://api.github.com/repos/superdesk/superdesk/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/superdesk/superdesk/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/superdesk/superdesk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/superdesk/superdesk/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/superdesk/superdesk/statuses/227859c04529f039b6b7edf873a6dd2935d710e6"}}}}