{"action":"created","issue":{"url":"https://api.github.com/repos/josdejong/mathjs/issues/259","labels_url":"https://api.github.com/repos/josdejong/mathjs/issues/259/labels{/name}","comments_url":"https://api.github.com/repos/josdejong/mathjs/issues/259/comments","events_url":"https://api.github.com/repos/josdejong/mathjs/issues/259/events","html_url":"https://github.com/josdejong/mathjs/pull/259","id":53241179,"number":259,"title":"Initial BigNumber sin support. Tests added as well.","user":{"login":"BigFav","id":2354042,"avatar_url":"https://avatars.githubusercontent.com/u/2354042?v=3","gravatar_id":"","url":"https://api.github.com/users/BigFav","html_url":"https://github.com/BigFav","followers_url":"https://api.github.com/users/BigFav/followers","following_url":"https://api.github.com/users/BigFav/following{/other_user}","gists_url":"https://api.github.com/users/BigFav/gists{/gist_id}","starred_url":"https://api.github.com/users/BigFav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigFav/subscriptions","organizations_url":"https://api.github.com/users/BigFav/orgs","repos_url":"https://api.github.com/users/BigFav/repos","events_url":"https://api.github.com/users/BigFav/events{/privacy}","received_events_url":"https://api.github.com/users/BigFav/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-02T07:40:46Z","updated_at":"2015-01-03T21:40:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/josdejong/mathjs/pulls/259","html_url":"https://github.com/josdejong/mathjs/pull/259","diff_url":"https://github.com/josdejong/mathjs/pull/259.diff","patch_url":"https://github.com/josdejong/mathjs/pull/259.patch"},"body":"It's suboptimal. However something that works, but is slow is better than nothing lol.\r\n\r\nI played with the test cases, so that they match with the BigNumber ones (which saved me typing extra functions for already slow test cases). I also moved the `arctan` into the function section; I had mistakenly put it into the constants section of the file.\r\n\r\nI try to catch both precisions of `2 * PI`, that of the `tau` elk and that of the `2*PI` elk. If you want me to only catch the `tau` ones I can remove lines 306 - 310."},"comment":{"url":"https://api.github.com/repos/josdejong/mathjs/issues/comments/68610683","html_url":"https://github.com/josdejong/mathjs/pull/259#issuecomment-68610683","issue_url":"https://api.github.com/repos/josdejong/mathjs/issues/259","id":68610683,"user":{"login":"BigFav","id":2354042,"avatar_url":"https://avatars.githubusercontent.com/u/2354042?v=3","gravatar_id":"","url":"https://api.github.com/users/BigFav","html_url":"https://github.com/BigFav","followers_url":"https://api.github.com/users/BigFav/followers","following_url":"https://api.github.com/users/BigFav/following{/other_user}","gists_url":"https://api.github.com/users/BigFav/gists{/gist_id}","starred_url":"https://api.github.com/users/BigFav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BigFav/subscriptions","organizations_url":"https://api.github.com/users/BigFav/orgs","repos_url":"https://api.github.com/users/BigFav/repos","events_url":"https://api.github.com/users/BigFav/events{/privacy}","received_events_url":"https://api.github.com/users/BigFav/received_events","type":"User","site_admin":false},"created_at":"2015-01-03T21:40:47Z","updated_at":"2015-01-03T21:40:47Z","body":"While I agree that Taylor expansion is suboptimal, I think this performs pretty well in terms of precision, and definitely well enough to keep. I will add one more test case to show you what I mean."}}