{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/25328329","id":25328329,"diff_hunk":"@@ -24,6 +24,7 @@\n #include <iostream>\n #include <sstream>\n #include <libdevcore/Common.h>\n+#include <libdevcore/SourceLocation.h>","path":"libevmcore/Assembly.h","position":4,"original_position":4,"commit_id":"9f85e14ead0126ba7b46654588553662a5d24b90","original_commit_id":"46fd746cd8473ac567131505f90959edde9f11c7","user":{"login":"chriseth","id":9073706,"avatar_url":"https://avatars.githubusercontent.com/u/9073706?v=3","gravatar_id":"","url":"https://api.github.com/users/chriseth","html_url":"https://github.com/chriseth","followers_url":"https://api.github.com/users/chriseth/followers","following_url":"https://api.github.com/users/chriseth/following{/other_user}","gists_url":"https://api.github.com/users/chriseth/gists{/gist_id}","starred_url":"https://api.github.com/users/chriseth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chriseth/subscriptions","organizations_url":"https://api.github.com/users/chriseth/orgs","repos_url":"https://api.github.com/users/chriseth/repos","events_url":"https://api.github.com/users/chriseth/events{/privacy}","received_events_url":"https://api.github.com/users/chriseth/received_events","type":"User","site_admin":false},"body":"If you put it in devcore, it basically means \"everyone needs it\", which is certainly not true.\r\nSince mix depends on solidity and solidity depends on evmcore, this is the lowest point you can put it. Furthermore, the current use-case for mix is to use SourceLocations only in connection with instructions and bytecode, whose realm is evmcore.\r\nNote that evmcore might be wrongly named: It is not concerned with the EVM itself but rather with its bytecode.","created_at":"2015-02-25T09:56:57Z","updated_at":"2015-02-25T09:56:57Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/1132#discussion_r25328329","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/25328329"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1132#discussion_r25328329"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132","id":29912793,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/1132","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/1132.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/1132.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1132","number":1132,"state":"open","locked":false,"title":"Sol location information in AssemblyItems","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"body":"This PR adds source location information to `eth::AssemblyItem`.\r\n\r\nAlso adding a small test for the proper location inserting of location in AssemblyItems.\r\n\r\nTODO: Have some better helper functions to help with locations, `AssemblyItem` and `ASTNode`. Will come in handy both in the debugger but also in these tests.","created_at":"2015-02-24T16:34:26Z","updated_at":"2015-02-25T09:56:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb7e32f9c1293172e167b117515613ab36dc1ec7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1132/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/9f85e14ead0126ba7b46654588553662a5d24b90","head":{"label":"LefterisJP:sol_DebuggingInformation","ref":"sol_DebuggingInformation","sha":"9f85e14ead0126ba7b46654588553662a5d24b90","user":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"repo":{"id":25381518,"name":"cpp-ethereum","full_name":"LefterisJP/cpp-ethereum","owner":{"login":"LefterisJP","id":1658405,"avatar_url":"https://avatars.githubusercontent.com/u/1658405?v=3","gravatar_id":"","url":"https://api.github.com/users/LefterisJP","html_url":"https://github.com/LefterisJP","followers_url":"https://api.github.com/users/LefterisJP/followers","following_url":"https://api.github.com/users/LefterisJP/following{/other_user}","gists_url":"https://api.github.com/users/LefterisJP/gists{/gist_id}","starred_url":"https://api.github.com/users/LefterisJP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LefterisJP/subscriptions","organizations_url":"https://api.github.com/users/LefterisJP/orgs","repos_url":"https://api.github.com/users/LefterisJP/repos","events_url":"https://api.github.com/users/LefterisJP/events{/privacy}","received_events_url":"https://api.github.com/users/LefterisJP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LefterisJP/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":true,"url":"https://api.github.com/repos/LefterisJP/cpp-ethereum","forks_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/LefterisJP/cpp-ethereum/releases{/id}","created_at":"2014-10-17T23:43:38Z","updated_at":"2015-02-24T16:09:50Z","pushed_at":"2015-02-25T09:41:18Z","git_url":"git://github.com/LefterisJP/cpp-ethereum.git","ssh_url":"git@github.com:LefterisJP/cpp-ethereum.git","clone_url":"https://github.com/LefterisJP/cpp-ethereum.git","svn_url":"https://github.com/LefterisJP/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":15659,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"dc3cc2db2ed89ee3af208ce26d2e5cf1b812595d","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars.githubusercontent.com/u/6250754?v=3","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Gavin Wood's C++ implementation of the Ethereum yellowpaper.","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","created_at":"2013-12-26T21:26:06Z","updated_at":"2015-02-25T08:26:46Z","pushed_at":"2015-02-25T08:26:46Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"www.gavwood.com/Paper.pdf","size":82180,"stargazers_count":407,"watchers_count":407,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"open_issues_count":123,"forks":145,"open_issues":123,"watchers":407,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/1132"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1132"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/9f85e14ead0126ba7b46654588553662a5d24b90"}}}}