{"action":"created","comment":{"url":"https://api.github.com/repos/apache/helix/pulls/comments/29550320","id":29550320,"diff_hunk":"@@ -329,8 +329,9 @@ public HelixAdmin getClusterManagementTool() {\n     return _admin;\n   }\n \n-  public void addStateModelDef(String clusterName, String stateModelDef, StateModelDefinition record) {","path":"helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java","position":13,"original_position":13,"commit_id":"69cd1f27065710f6de157b82742673ab8baf5d11","original_commit_id":"69cd1f27065710f6de157b82742673ab8baf5d11","user":{"login":"kanakb","id":1173516,"avatar_url":"https://avatars.githubusercontent.com/u/1173516?v=3","gravatar_id":"","url":"https://api.github.com/users/kanakb","html_url":"https://github.com/kanakb","followers_url":"https://api.github.com/users/kanakb/followers","following_url":"https://api.github.com/users/kanakb/following{/other_user}","gists_url":"https://api.github.com/users/kanakb/gists{/gist_id}","starred_url":"https://api.github.com/users/kanakb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanakb/subscriptions","organizations_url":"https://api.github.com/users/kanakb/orgs","repos_url":"https://api.github.com/users/kanakb/repos","events_url":"https://api.github.com/users/kanakb/events{/privacy}","received_events_url":"https://api.github.com/users/kanakb/received_events","type":"User","site_admin":false},"body":"Please do not remove public methods. Instead, call the new method from the old one with a default value.","created_at":"2015-05-02T20:15:35Z","updated_at":"2015-05-02T20:15:35Z","html_url":"https://github.com/apache/helix/pull/26#discussion_r29550320","pull_request_url":"https://api.github.com/repos/apache/helix/pulls/26","_links":{"self":{"href":"https://api.github.com/repos/apache/helix/pulls/comments/29550320"},"html":{"href":"https://github.com/apache/helix/pull/26#discussion_r29550320"},"pull_request":{"href":"https://api.github.com/repos/apache/helix/pulls/26"}}},"pull_request":{"url":"https://api.github.com/repos/apache/helix/pulls/26","id":34415567,"html_url":"https://github.com/apache/helix/pull/26","diff_url":"https://github.com/apache/helix/pull/26.diff","patch_url":"https://github.com/apache/helix/pull/26.patch","issue_url":"https://api.github.com/repos/apache/helix/issues/26","number":26,"state":"open","locked":false,"title":"[HELIX-592] addCluster should respect overwriteExisitng when adding stat...","user":{"login":"jicongrui","id":8269773,"avatar_url":"https://avatars.githubusercontent.com/u/8269773?v=3","gravatar_id":"","url":"https://api.github.com/users/jicongrui","html_url":"https://github.com/jicongrui","followers_url":"https://api.github.com/users/jicongrui/followers","following_url":"https://api.github.com/users/jicongrui/following{/other_user}","gists_url":"https://api.github.com/users/jicongrui/gists{/gist_id}","starred_url":"https://api.github.com/users/jicongrui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicongrui/subscriptions","organizations_url":"https://api.github.com/users/jicongrui/orgs","repos_url":"https://api.github.com/users/jicongrui/repos","events_url":"https://api.github.com/users/jicongrui/events{/privacy}","received_events_url":"https://api.github.com/users/jicongrui/received_events","type":"User","site_admin":false},"body":"...eModelDefinations\r\n\r\nThere are some tests expecting exceptions when creating an existing cluster and I change the result.\r\nSo the question is that the business logic of creating a exisiting cluster.\r\nIf we allow that and overwrite is false, should we throw exceptions or do nothing?","created_at":"2015-04-29T23:17:58Z","updated_at":"2015-05-02T20:15:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79032b9cf19486762960a8c1e73dabdbf09e33e2","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/helix/pulls/26/commits","review_comments_url":"https://api.github.com/repos/apache/helix/pulls/26/comments","review_comment_url":"https://api.github.com/repos/apache/helix/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/helix/issues/26/comments","statuses_url":"https://api.github.com/repos/apache/helix/statuses/69cd1f27065710f6de157b82742673ab8baf5d11","head":{"label":"jicongrui:helix-0.6.x","ref":"helix-0.6.x","sha":"69cd1f27065710f6de157b82742673ab8baf5d11","user":{"login":"jicongrui","id":8269773,"avatar_url":"https://avatars.githubusercontent.com/u/8269773?v=3","gravatar_id":"","url":"https://api.github.com/users/jicongrui","html_url":"https://github.com/jicongrui","followers_url":"https://api.github.com/users/jicongrui/followers","following_url":"https://api.github.com/users/jicongrui/following{/other_user}","gists_url":"https://api.github.com/users/jicongrui/gists{/gist_id}","starred_url":"https://api.github.com/users/jicongrui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicongrui/subscriptions","organizations_url":"https://api.github.com/users/jicongrui/orgs","repos_url":"https://api.github.com/users/jicongrui/repos","events_url":"https://api.github.com/users/jicongrui/events{/privacy}","received_events_url":"https://api.github.com/users/jicongrui/received_events","type":"User","site_admin":false},"repo":{"id":33155777,"name":"helix","full_name":"jicongrui/helix","owner":{"login":"jicongrui","id":8269773,"avatar_url":"https://avatars.githubusercontent.com/u/8269773?v=3","gravatar_id":"","url":"https://api.github.com/users/jicongrui","html_url":"https://github.com/jicongrui","followers_url":"https://api.github.com/users/jicongrui/followers","following_url":"https://api.github.com/users/jicongrui/following{/other_user}","gists_url":"https://api.github.com/users/jicongrui/gists{/gist_id}","starred_url":"https://api.github.com/users/jicongrui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jicongrui/subscriptions","organizations_url":"https://api.github.com/users/jicongrui/orgs","repos_url":"https://api.github.com/users/jicongrui/repos","events_url":"https://api.github.com/users/jicongrui/events{/privacy}","received_events_url":"https://api.github.com/users/jicongrui/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jicongrui/helix","description":"Mirror of Apache Helix","fork":true,"url":"https://api.github.com/repos/jicongrui/helix","forks_url":"https://api.github.com/repos/jicongrui/helix/forks","keys_url":"https://api.github.com/repos/jicongrui/helix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jicongrui/helix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jicongrui/helix/teams","hooks_url":"https://api.github.com/repos/jicongrui/helix/hooks","issue_events_url":"https://api.github.com/repos/jicongrui/helix/issues/events{/number}","events_url":"https://api.github.com/repos/jicongrui/helix/events","assignees_url":"https://api.github.com/repos/jicongrui/helix/assignees{/user}","branches_url":"https://api.github.com/repos/jicongrui/helix/branches{/branch}","tags_url":"https://api.github.com/repos/jicongrui/helix/tags","blobs_url":"https://api.github.com/repos/jicongrui/helix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jicongrui/helix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jicongrui/helix/git/refs{/sha}","trees_url":"https://api.github.com/repos/jicongrui/helix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jicongrui/helix/statuses/{sha}","languages_url":"https://api.github.com/repos/jicongrui/helix/languages","stargazers_url":"https://api.github.com/repos/jicongrui/helix/stargazers","contributors_url":"https://api.github.com/repos/jicongrui/helix/contributors","subscribers_url":"https://api.github.com/repos/jicongrui/helix/subscribers","subscription_url":"https://api.github.com/repos/jicongrui/helix/subscription","commits_url":"https://api.github.com/repos/jicongrui/helix/commits{/sha}","git_commits_url":"https://api.github.com/repos/jicongrui/helix/git/commits{/sha}","comments_url":"https://api.github.com/repos/jicongrui/helix/comments{/number}","issue_comment_url":"https://api.github.com/repos/jicongrui/helix/issues/comments{/number}","contents_url":"https://api.github.com/repos/jicongrui/helix/contents/{+path}","compare_url":"https://api.github.com/repos/jicongrui/helix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jicongrui/helix/merges","archive_url":"https://api.github.com/repos/jicongrui/helix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jicongrui/helix/downloads","issues_url":"https://api.github.com/repos/jicongrui/helix/issues{/number}","pulls_url":"https://api.github.com/repos/jicongrui/helix/pulls{/number}","milestones_url":"https://api.github.com/repos/jicongrui/helix/milestones{/number}","notifications_url":"https://api.github.com/repos/jicongrui/helix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jicongrui/helix/labels{/name}","releases_url":"https://api.github.com/repos/jicongrui/helix/releases{/id}","created_at":"2015-03-31T00:31:43Z","updated_at":"2015-03-31T00:31:46Z","pushed_at":"2015-04-29T23:15:51Z","git_url":"git://github.com/jicongrui/helix.git","ssh_url":"git@github.com:jicongrui/helix.git","clone_url":"https://github.com/jicongrui/helix.git","svn_url":"https://github.com/jicongrui/helix","homepage":null,"size":73666,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:helix-0.6.x","ref":"helix-0.6.x","sha":"e94a9f5f90099a248181d6dc50314aec0e8d9512","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":15861701,"name":"helix","full_name":"apache/helix","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/helix","description":"Mirror of Apache Helix","fork":false,"url":"https://api.github.com/repos/apache/helix","forks_url":"https://api.github.com/repos/apache/helix/forks","keys_url":"https://api.github.com/repos/apache/helix/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/helix/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/helix/teams","hooks_url":"https://api.github.com/repos/apache/helix/hooks","issue_events_url":"https://api.github.com/repos/apache/helix/issues/events{/number}","events_url":"https://api.github.com/repos/apache/helix/events","assignees_url":"https://api.github.com/repos/apache/helix/assignees{/user}","branches_url":"https://api.github.com/repos/apache/helix/branches{/branch}","tags_url":"https://api.github.com/repos/apache/helix/tags","blobs_url":"https://api.github.com/repos/apache/helix/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/helix/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/helix/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/helix/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/helix/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/helix/languages","stargazers_url":"https://api.github.com/repos/apache/helix/stargazers","contributors_url":"https://api.github.com/repos/apache/helix/contributors","subscribers_url":"https://api.github.com/repos/apache/helix/subscribers","subscription_url":"https://api.github.com/repos/apache/helix/subscription","commits_url":"https://api.github.com/repos/apache/helix/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/helix/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/helix/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/helix/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/helix/contents/{+path}","compare_url":"https://api.github.com/repos/apache/helix/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/helix/merges","archive_url":"https://api.github.com/repos/apache/helix/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/helix/downloads","issues_url":"https://api.github.com/repos/apache/helix/issues{/number}","pulls_url":"https://api.github.com/repos/apache/helix/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/helix/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/helix/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/helix/labels{/name}","releases_url":"https://api.github.com/repos/apache/helix/releases{/id}","created_at":"2014-01-13T08:00:06Z","updated_at":"2015-04-29T05:48:47Z","pushed_at":"2015-05-02T20:12:55Z","git_url":"git://github.com/apache/helix.git","ssh_url":"git@github.com:apache/helix.git","clone_url":"https://github.com/apache/helix.git","svn_url":"https://github.com/apache/helix","homepage":null,"size":78042,"stargazers_count":26,"watchers_count":26,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":28,"mirror_url":"git://git.apache.org/helix.git","open_issues_count":3,"forks":28,"open_issues":3,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/helix/pulls/26"},"html":{"href":"https://github.com/apache/helix/pull/26"},"issue":{"href":"https://api.github.com/repos/apache/helix/issues/26"},"comments":{"href":"https://api.github.com/repos/apache/helix/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/helix/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/helix/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/helix/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/apache/helix/statuses/69cd1f27065710f6de157b82742673ab8baf5d11"}}}}