{"action":"created","comment":{"url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/comments/23418347","id":23418347,"diff_hunk":"@@ -178,6 +178,14 @@ def test_queue_inspection\n     assert !SlowJob.enqueued?, 'no loner lock key should hae been created'\n   end\n \n+  def test_loner_job_locked_depending_on_args\n+    assert Resque.enqueue(LonelyWithArgsJob)\n+    assert Resque.enqueue(LonelyWithArgsJob), 'should enqueue if arg not given'","path":"test/lock_test.rb","position":6,"original_position":6,"commit_id":"a75365c70a263733643f0b160deaeffacac51702","original_commit_id":"a75365c70a263733643f0b160deaeffacac51702","user":{"login":"lantins","id":22917,"avatar_url":"https://avatars.githubusercontent.com/u/22917?v=3","gravatar_id":"","url":"https://api.github.com/users/lantins","html_url":"https://github.com/lantins","followers_url":"https://api.github.com/users/lantins/followers","following_url":"https://api.github.com/users/lantins/following{/other_user}","gists_url":"https://api.github.com/users/lantins/gists{/gist_id}","starred_url":"https://api.github.com/users/lantins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lantins/subscriptions","organizations_url":"https://api.github.com/users/lantins/orgs","repos_url":"https://api.github.com/users/lantins/repos","events_url":"https://api.github.com/users/lantins/events{/privacy}","received_events_url":"https://api.github.com/users/lantins/received_events","type":"User","site_admin":false},"body":"@amiryal I know its a bit to ask, because it's been a while, but I'd appreciate some input from you so we can see this addressed.\r\n\r\nFrom the \"loner\" docs it says:\r\n\r\n```Two jobs of the same class with the same parameters/arguments/workload must produce the same redis_key```\r\n\r\nDoes this not mean the 2nd enqueue should fail? and we should have 2 jobs enqueued total?","created_at":"2015-01-22T22:58:00Z","updated_at":"2015-01-22T22:58:00Z","html_url":"https://github.com/lantins/resque-lock-timeout/pull/24#discussion_r23418347","pull_request_url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24","_links":{"self":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/comments/23418347"},"html":{"href":"https://github.com/lantins/resque-lock-timeout/pull/24#discussion_r23418347"},"pull_request":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24"}}},"pull_request":{"url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24","id":22295055,"html_url":"https://github.com/lantins/resque-lock-timeout/pull/24","diff_url":"https://github.com/lantins/resque-lock-timeout/pull/24.diff","patch_url":"https://github.com/lantins/resque-lock-timeout/pull/24.patch","issue_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24","number":24,"state":"open","locked":false,"title":"Make “loner” implementation comply with its specification","user":{"login":"amiryal","id":105565,"avatar_url":"https://avatars.githubusercontent.com/u/105565?v=3","gravatar_id":"","url":"https://api.github.com/users/amiryal","html_url":"https://github.com/amiryal","followers_url":"https://api.github.com/users/amiryal/followers","following_url":"https://api.github.com/users/amiryal/following{/other_user}","gists_url":"https://api.github.com/users/amiryal/gists{/gist_id}","starred_url":"https://api.github.com/users/amiryal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amiryal/subscriptions","organizations_url":"https://api.github.com/users/amiryal/orgs","repos_url":"https://api.github.com/users/amiryal/repos","events_url":"https://api.github.com/users/amiryal/events{/privacy}","received_events_url":"https://api.github.com/users/amiryal/received_events","type":"User","site_admin":false},"body":"The default `loner()` method is accepting `*args`, but they are not passed along where this method is called.\r\n\r\nNote, this pull request includes a test case, but it only covers one code path, whereas I fixed 3 different places.","created_at":"2014-10-06T16:10:51Z","updated_at":"2015-01-22T22:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"37c781adbb051dacf5f2e7d3612a102d81e2ad83","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24/commits","review_comments_url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24/comments","review_comment_url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/comments/{number}","comments_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24/comments","statuses_url":"https://api.github.com/repos/lantins/resque-lock-timeout/statuses/a75365c70a263733643f0b160deaeffacac51702","head":{"label":"seekingalpha:loner","ref":"loner","sha":"a75365c70a263733643f0b160deaeffacac51702","user":{"login":"seekingalpha","id":6659910,"avatar_url":"https://avatars.githubusercontent.com/u/6659910?v=3","gravatar_id":"","url":"https://api.github.com/users/seekingalpha","html_url":"https://github.com/seekingalpha","followers_url":"https://api.github.com/users/seekingalpha/followers","following_url":"https://api.github.com/users/seekingalpha/following{/other_user}","gists_url":"https://api.github.com/users/seekingalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/seekingalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seekingalpha/subscriptions","organizations_url":"https://api.github.com/users/seekingalpha/orgs","repos_url":"https://api.github.com/users/seekingalpha/repos","events_url":"https://api.github.com/users/seekingalpha/events{/privacy}","received_events_url":"https://api.github.com/users/seekingalpha/received_events","type":"Organization","site_admin":false},"repo":{"id":24850694,"name":"resque-lock-timeout","full_name":"seekingalpha/resque-lock-timeout","owner":{"login":"seekingalpha","id":6659910,"avatar_url":"https://avatars.githubusercontent.com/u/6659910?v=3","gravatar_id":"","url":"https://api.github.com/users/seekingalpha","html_url":"https://github.com/seekingalpha","followers_url":"https://api.github.com/users/seekingalpha/followers","following_url":"https://api.github.com/users/seekingalpha/following{/other_user}","gists_url":"https://api.github.com/users/seekingalpha/gists{/gist_id}","starred_url":"https://api.github.com/users/seekingalpha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seekingalpha/subscriptions","organizations_url":"https://api.github.com/users/seekingalpha/orgs","repos_url":"https://api.github.com/users/seekingalpha/repos","events_url":"https://api.github.com/users/seekingalpha/events{/privacy}","received_events_url":"https://api.github.com/users/seekingalpha/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seekingalpha/resque-lock-timeout","description":"A Resque plugin; adds locking, with optional timeout/deadlock handling to resque jobs.","fork":true,"url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout","forks_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/forks","keys_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/teams","hooks_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/hooks","issue_events_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/issues/events{/number}","events_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/events","assignees_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/assignees{/user}","branches_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/branches{/branch}","tags_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/tags","blobs_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/git/refs{/sha}","trees_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/statuses/{sha}","languages_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/languages","stargazers_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/stargazers","contributors_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/contributors","subscribers_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/subscribers","subscription_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/subscription","commits_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/commits{/sha}","git_commits_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/git/commits{/sha}","comments_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/comments{/number}","issue_comment_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/issues/comments/{number}","contents_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/contents/{+path}","compare_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/merges","archive_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/downloads","issues_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/issues{/number}","pulls_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/pulls{/number}","milestones_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/milestones{/number}","notifications_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/labels{/name}","releases_url":"https://api.github.com/repos/seekingalpha/resque-lock-timeout/releases{/id}","created_at":"2014-10-06T15:05:15Z","updated_at":"2014-12-04T14:18:27Z","pushed_at":"2014-10-29T14:06:31Z","git_url":"git://github.com/seekingalpha/resque-lock-timeout.git","ssh_url":"git@github.com:seekingalpha/resque-lock-timeout.git","clone_url":"https://github.com/seekingalpha/resque-lock-timeout.git","svn_url":"https://github.com/seekingalpha/resque-lock-timeout","homepage":"","size":206,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lantins:master","ref":"master","sha":"53e4be79201580f03b87d7de81cf6f36bab97ca1","user":{"login":"lantins","id":22917,"avatar_url":"https://avatars.githubusercontent.com/u/22917?v=3","gravatar_id":"","url":"https://api.github.com/users/lantins","html_url":"https://github.com/lantins","followers_url":"https://api.github.com/users/lantins/followers","following_url":"https://api.github.com/users/lantins/following{/other_user}","gists_url":"https://api.github.com/users/lantins/gists{/gist_id}","starred_url":"https://api.github.com/users/lantins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lantins/subscriptions","organizations_url":"https://api.github.com/users/lantins/orgs","repos_url":"https://api.github.com/users/lantins/repos","events_url":"https://api.github.com/users/lantins/events{/privacy}","received_events_url":"https://api.github.com/users/lantins/received_events","type":"User","site_admin":false},"repo":{"id":627083,"name":"resque-lock-timeout","full_name":"lantins/resque-lock-timeout","owner":{"login":"lantins","id":22917,"avatar_url":"https://avatars.githubusercontent.com/u/22917?v=3","gravatar_id":"","url":"https://api.github.com/users/lantins","html_url":"https://github.com/lantins","followers_url":"https://api.github.com/users/lantins/followers","following_url":"https://api.github.com/users/lantins/following{/other_user}","gists_url":"https://api.github.com/users/lantins/gists{/gist_id}","starred_url":"https://api.github.com/users/lantins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lantins/subscriptions","organizations_url":"https://api.github.com/users/lantins/orgs","repos_url":"https://api.github.com/users/lantins/repos","events_url":"https://api.github.com/users/lantins/events{/privacy}","received_events_url":"https://api.github.com/users/lantins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lantins/resque-lock-timeout","description":"A Resque plugin; adds locking, with optional timeout/deadlock handling to resque jobs.","fork":true,"url":"https://api.github.com/repos/lantins/resque-lock-timeout","forks_url":"https://api.github.com/repos/lantins/resque-lock-timeout/forks","keys_url":"https://api.github.com/repos/lantins/resque-lock-timeout/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lantins/resque-lock-timeout/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lantins/resque-lock-timeout/teams","hooks_url":"https://api.github.com/repos/lantins/resque-lock-timeout/hooks","issue_events_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/events{/number}","events_url":"https://api.github.com/repos/lantins/resque-lock-timeout/events","assignees_url":"https://api.github.com/repos/lantins/resque-lock-timeout/assignees{/user}","branches_url":"https://api.github.com/repos/lantins/resque-lock-timeout/branches{/branch}","tags_url":"https://api.github.com/repos/lantins/resque-lock-timeout/tags","blobs_url":"https://api.github.com/repos/lantins/resque-lock-timeout/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lantins/resque-lock-timeout/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lantins/resque-lock-timeout/git/refs{/sha}","trees_url":"https://api.github.com/repos/lantins/resque-lock-timeout/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lantins/resque-lock-timeout/statuses/{sha}","languages_url":"https://api.github.com/repos/lantins/resque-lock-timeout/languages","stargazers_url":"https://api.github.com/repos/lantins/resque-lock-timeout/stargazers","contributors_url":"https://api.github.com/repos/lantins/resque-lock-timeout/contributors","subscribers_url":"https://api.github.com/repos/lantins/resque-lock-timeout/subscribers","subscription_url":"https://api.github.com/repos/lantins/resque-lock-timeout/subscription","commits_url":"https://api.github.com/repos/lantins/resque-lock-timeout/commits{/sha}","git_commits_url":"https://api.github.com/repos/lantins/resque-lock-timeout/git/commits{/sha}","comments_url":"https://api.github.com/repos/lantins/resque-lock-timeout/comments{/number}","issue_comment_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/comments/{number}","contents_url":"https://api.github.com/repos/lantins/resque-lock-timeout/contents/{+path}","compare_url":"https://api.github.com/repos/lantins/resque-lock-timeout/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lantins/resque-lock-timeout/merges","archive_url":"https://api.github.com/repos/lantins/resque-lock-timeout/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lantins/resque-lock-timeout/downloads","issues_url":"https://api.github.com/repos/lantins/resque-lock-timeout/issues{/number}","pulls_url":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls{/number}","milestones_url":"https://api.github.com/repos/lantins/resque-lock-timeout/milestones{/number}","notifications_url":"https://api.github.com/repos/lantins/resque-lock-timeout/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lantins/resque-lock-timeout/labels{/name}","releases_url":"https://api.github.com/repos/lantins/resque-lock-timeout/releases{/id}","created_at":"2010-04-24T18:50:31Z","updated_at":"2015-01-22T22:50:13Z","pushed_at":"2015-01-22T22:50:12Z","git_url":"git://github.com/lantins/resque-lock-timeout.git","ssh_url":"git@github.com:lantins/resque-lock-timeout.git","clone_url":"https://github.com/lantins/resque-lock-timeout.git","svn_url":"https://github.com/lantins/resque-lock-timeout","homepage":"","size":292,"stargazers_count":43,"watchers_count":43,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":4,"forks":19,"open_issues":4,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24"},"html":{"href":"https://github.com/lantins/resque-lock-timeout/pull/24"},"issue":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24"},"comments":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/lantins/resque-lock-timeout/statuses/a75365c70a263733643f0b160deaeffacac51702"}}}}