{"action":"created","issue":{"url":"https://api.github.com/repos/pubs/pubs/issues/46","labels_url":"https://api.github.com/repos/pubs/pubs/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/pubs/pubs/issues/46/comments","events_url":"https://api.github.com/repos/pubs/pubs/issues/46/events","html_url":"https://github.com/pubs/pubs/issues/46","id":122596882,"number":46,"title":"Wrong editor default","user":{"login":"omangin","id":1171989,"avatar_url":"https://avatars.githubusercontent.com/u/1171989?v=3","gravatar_id":"","url":"https://api.github.com/users/omangin","html_url":"https://github.com/omangin","followers_url":"https://api.github.com/users/omangin/followers","following_url":"https://api.github.com/users/omangin/following{/other_user}","gists_url":"https://api.github.com/users/omangin/gists{/gist_id}","starred_url":"https://api.github.com/users/omangin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omangin/subscriptions","organizations_url":"https://api.github.com/users/omangin/orgs","repos_url":"https://api.github.com/users/omangin/repos","events_url":"https://api.github.com/users/omangin/events{/privacy}","received_events_url":"https://api.github.com/users/omangin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"omangin","id":1171989,"avatar_url":"https://avatars.githubusercontent.com/u/1171989?v=3","gravatar_id":"","url":"https://api.github.com/users/omangin","html_url":"https://github.com/omangin","followers_url":"https://api.github.com/users/omangin/followers","following_url":"https://api.github.com/users/omangin/following{/other_user}","gists_url":"https://api.github.com/users/omangin/gists{/gist_id}","starred_url":"https://api.github.com/users/omangin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omangin/subscriptions","organizations_url":"https://api.github.com/users/omangin/orgs","repos_url":"https://api.github.com/users/omangin/repos","events_url":"https://api.github.com/users/omangin/events{/privacy}","received_events_url":"https://api.github.com/users/omangin/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-12-16T20:42:58Z","updated_at":"2015-12-17T03:33:34Z","closed_at":null,"body":"The default `edit_cmd` in the config is `'None'`. Instead of failing to open the command `None`, the value of `$EDITOR` should be used, with some sane default (*vi*). "},"comment":{"url":"https://api.github.com/repos/pubs/pubs/issues/comments/165327717","html_url":"https://github.com/pubs/pubs/issues/46#issuecomment-165327717","issue_url":"https://api.github.com/repos/pubs/pubs/issues/46","id":165327717,"user":{"login":"omangin","id":1171989,"avatar_url":"https://avatars.githubusercontent.com/u/1171989?v=3","gravatar_id":"","url":"https://api.github.com/users/omangin","html_url":"https://github.com/omangin","followers_url":"https://api.github.com/users/omangin/followers","following_url":"https://api.github.com/users/omangin/following{/other_user}","gists_url":"https://api.github.com/users/omangin/gists{/gist_id}","starred_url":"https://api.github.com/users/omangin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omangin/subscriptions","organizations_url":"https://api.github.com/users/omangin/orgs","repos_url":"https://api.github.com/users/omangin/repos","events_url":"https://api.github.com/users/omangin/events{/privacy}","received_events_url":"https://api.github.com/users/omangin/received_events","type":"User","site_admin":false},"created_at":"2015-12-17T03:33:34Z","updated_at":"2015-12-17T03:33:34Z","body":"Do we support window?\r\n\r\nActually `edit_cmd` was `'None'` on my computer from the config the updater generated. So something is at least not working.\r\n\r\nAlso, my opinion is that the user should not need to have any `edit_cmd` defined in the config for the expected thing to happen. Also if the user changes its `$editor`, why should he also change it in every application he uses that may call an editor?\r\n\r\nIt is great to try *very hard* to find a working editor, but is it necessary? Most users who care about an editor have it specified as `$EDITOR` or would set it in the config after their first edit. One could argue that newbies would be unable to get out of `vi` if used as default. Most of these users are using Ubuntu, that, if I am correct, `export EDITOR=nano` in the default `bashrc` so this won't happen. I do not know what happens on MacOS. Also the order for `[vim, nano, emacs, vi]` seems quite arbitrary.\r\n\r\nIn summary, I think we should favor convention over configuration. Which the code seems to attempt, but in my opinion in a wrong way, by hard-coding the convention in the configuration at init time. In my opinion this adds not-really-useful code to be maintained for a functionality that is already implemented  by the environment variables.\r\n\r\nSo by order of priority, I think we should support the configuration not being set. Then we may try some magic guess but in my opinion this is useless.\r\n\r\n    "}}