{"action":"created","comment":{"url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/comments/28178245","id":28178245,"diff_hunk":"@@ -0,0 +1,54 @@\n+from random import randrange\n+from pytest import raises\n+from myhdl import *\n+\n+from myhdl import Signal, Simulation, instances, now\n+\n+from myhdl._always_seq import always_seq, _AlwaysSeq, _error, AlwaysSeqError\n+\n+\n+\n+def test_clock():\n+    \"\"\" check the edge parameter \"\"\"\n+\n+    # should fail without a valid Signal\n+    clock = Signal(bool(0))\n+    reset = ResetSignal(0, active=0, async=True)\n+\n+    with raises(AlwaysSeqError) as e:\n+        @always_seq(clock, reset=reset)\n+        def logic1():\n+            pass\n+        assert e.kind == _error.EdgeType\n+\n+    # should work with a valid Signal\n+    clock = Signal(bool(0))\n+    try:\n+        @always_seq(clock.posedge, reset=reset)\n+        def logic2():\n+            pass\n+    except:\n+        pytest.fail()","path":"myhdl/test/core2/test_always_seq.py","position":31,"original_position":31,"commit_id":"01da49766ef4b97802d04b60c9b282dc144a582e","original_commit_id":"01da49766ef4b97802d04b60c9b282dc144a582e","user":{"login":"jandecaluwe","id":1984236,"avatar_url":"https://avatars.githubusercontent.com/u/1984236?v=3","gravatar_id":"","url":"https://api.github.com/users/jandecaluwe","html_url":"https://github.com/jandecaluwe","followers_url":"https://api.github.com/users/jandecaluwe/followers","following_url":"https://api.github.com/users/jandecaluwe/following{/other_user}","gists_url":"https://api.github.com/users/jandecaluwe/gists{/gist_id}","starred_url":"https://api.github.com/users/jandecaluwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandecaluwe/subscriptions","organizations_url":"https://api.github.com/users/jandecaluwe/orgs","repos_url":"https://api.github.com/users/jandecaluwe/repos","events_url":"https://api.github.com/users/jandecaluwe/events{/privacy}","received_events_url":"https://api.github.com/users/jandecaluwe/received_events","type":"User","site_admin":false},"body":"How can this line work if `pytest` is not imported? Why not `assert False` as a generic statement?","created_at":"2015-04-10T20:35:42Z","updated_at":"2015-04-10T20:35:42Z","html_url":"https://github.com/jandecaluwe/myhdl/pull/56#discussion_r28178245","pull_request_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56","_links":{"self":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/comments/28178245"},"html":{"href":"https://github.com/jandecaluwe/myhdl/pull/56#discussion_r28178245"},"pull_request":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56"}}},"pull_request":{"url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56","id":32732955,"html_url":"https://github.com/jandecaluwe/myhdl/pull/56","diff_url":"https://github.com/jandecaluwe/myhdl/pull/56.diff","patch_url":"https://github.com/jandecaluwe/myhdl/pull/56.patch","issue_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/56","number":56,"state":"open","locked":false,"title":"test_always_seq.py","user":{"login":"iamsrinivas","id":11617242,"avatar_url":"https://avatars.githubusercontent.com/u/11617242?v=3","gravatar_id":"","url":"https://api.github.com/users/iamsrinivas","html_url":"https://github.com/iamsrinivas","followers_url":"https://api.github.com/users/iamsrinivas/followers","following_url":"https://api.github.com/users/iamsrinivas/following{/other_user}","gists_url":"https://api.github.com/users/iamsrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/iamsrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamsrinivas/subscriptions","organizations_url":"https://api.github.com/users/iamsrinivas/orgs","repos_url":"https://api.github.com/users/iamsrinivas/repos","events_url":"https://api.github.com/users/iamsrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/iamsrinivas/received_events","type":"User","site_admin":false},"body":"Added new test to increase the coverage of the code. The tests do  not reach the full coverage(100%). We need to extend this test to improve the coverage hence forward using this test.","created_at":"2015-04-07T04:36:31Z","updated_at":"2015-04-10T20:35:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e721ac4453e87a16d9c736290ecb5ff3bd2d4e05","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56/commits","review_comments_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56/comments","review_comment_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/56/comments","statuses_url":"https://api.github.com/repos/jandecaluwe/myhdl/statuses/01da49766ef4b97802d04b60c9b282dc144a582e","head":{"label":"iamsrinivas:iamsrinivas-patch-2","ref":"iamsrinivas-patch-2","sha":"01da49766ef4b97802d04b60c9b282dc144a582e","user":{"login":"iamsrinivas","id":11617242,"avatar_url":"https://avatars.githubusercontent.com/u/11617242?v=3","gravatar_id":"","url":"https://api.github.com/users/iamsrinivas","html_url":"https://github.com/iamsrinivas","followers_url":"https://api.github.com/users/iamsrinivas/followers","following_url":"https://api.github.com/users/iamsrinivas/following{/other_user}","gists_url":"https://api.github.com/users/iamsrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/iamsrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamsrinivas/subscriptions","organizations_url":"https://api.github.com/users/iamsrinivas/orgs","repos_url":"https://api.github.com/users/iamsrinivas/repos","events_url":"https://api.github.com/users/iamsrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/iamsrinivas/received_events","type":"User","site_admin":false},"repo":{"id":33464617,"name":"myhdl","full_name":"iamsrinivas/myhdl","owner":{"login":"iamsrinivas","id":11617242,"avatar_url":"https://avatars.githubusercontent.com/u/11617242?v=3","gravatar_id":"","url":"https://api.github.com/users/iamsrinivas","html_url":"https://github.com/iamsrinivas","followers_url":"https://api.github.com/users/iamsrinivas/followers","following_url":"https://api.github.com/users/iamsrinivas/following{/other_user}","gists_url":"https://api.github.com/users/iamsrinivas/gists{/gist_id}","starred_url":"https://api.github.com/users/iamsrinivas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamsrinivas/subscriptions","organizations_url":"https://api.github.com/users/iamsrinivas/orgs","repos_url":"https://api.github.com/users/iamsrinivas/repos","events_url":"https://api.github.com/users/iamsrinivas/events{/privacy}","received_events_url":"https://api.github.com/users/iamsrinivas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iamsrinivas/myhdl","description":"The MyHDL development repository","fork":true,"url":"https://api.github.com/repos/iamsrinivas/myhdl","forks_url":"https://api.github.com/repos/iamsrinivas/myhdl/forks","keys_url":"https://api.github.com/repos/iamsrinivas/myhdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iamsrinivas/myhdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iamsrinivas/myhdl/teams","hooks_url":"https://api.github.com/repos/iamsrinivas/myhdl/hooks","issue_events_url":"https://api.github.com/repos/iamsrinivas/myhdl/issues/events{/number}","events_url":"https://api.github.com/repos/iamsrinivas/myhdl/events","assignees_url":"https://api.github.com/repos/iamsrinivas/myhdl/assignees{/user}","branches_url":"https://api.github.com/repos/iamsrinivas/myhdl/branches{/branch}","tags_url":"https://api.github.com/repos/iamsrinivas/myhdl/tags","blobs_url":"https://api.github.com/repos/iamsrinivas/myhdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iamsrinivas/myhdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iamsrinivas/myhdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/iamsrinivas/myhdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iamsrinivas/myhdl/statuses/{sha}","languages_url":"https://api.github.com/repos/iamsrinivas/myhdl/languages","stargazers_url":"https://api.github.com/repos/iamsrinivas/myhdl/stargazers","contributors_url":"https://api.github.com/repos/iamsrinivas/myhdl/contributors","subscribers_url":"https://api.github.com/repos/iamsrinivas/myhdl/subscribers","subscription_url":"https://api.github.com/repos/iamsrinivas/myhdl/subscription","commits_url":"https://api.github.com/repos/iamsrinivas/myhdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/iamsrinivas/myhdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/iamsrinivas/myhdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/iamsrinivas/myhdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/iamsrinivas/myhdl/contents/{+path}","compare_url":"https://api.github.com/repos/iamsrinivas/myhdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iamsrinivas/myhdl/merges","archive_url":"https://api.github.com/repos/iamsrinivas/myhdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iamsrinivas/myhdl/downloads","issues_url":"https://api.github.com/repos/iamsrinivas/myhdl/issues{/number}","pulls_url":"https://api.github.com/repos/iamsrinivas/myhdl/pulls{/number}","milestones_url":"https://api.github.com/repos/iamsrinivas/myhdl/milestones{/number}","notifications_url":"https://api.github.com/repos/iamsrinivas/myhdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iamsrinivas/myhdl/labels{/name}","releases_url":"https://api.github.com/repos/iamsrinivas/myhdl/releases{/id}","created_at":"2015-04-06T03:17:02Z","updated_at":"2015-04-06T03:17:03Z","pushed_at":"2015-04-07T03:59:58Z","git_url":"git://github.com/iamsrinivas/myhdl.git","ssh_url":"git@github.com:iamsrinivas/myhdl.git","clone_url":"https://github.com/iamsrinivas/myhdl.git","svn_url":"https://github.com/iamsrinivas/myhdl","homepage":"http://www.myhdl.org","size":13571,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jandecaluwe:master","ref":"master","sha":"d65bdbfd72468a97cc1cdb24a2c8483d1ce62c2a","user":{"login":"jandecaluwe","id":1984236,"avatar_url":"https://avatars.githubusercontent.com/u/1984236?v=3","gravatar_id":"","url":"https://api.github.com/users/jandecaluwe","html_url":"https://github.com/jandecaluwe","followers_url":"https://api.github.com/users/jandecaluwe/followers","following_url":"https://api.github.com/users/jandecaluwe/following{/other_user}","gists_url":"https://api.github.com/users/jandecaluwe/gists{/gist_id}","starred_url":"https://api.github.com/users/jandecaluwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandecaluwe/subscriptions","organizations_url":"https://api.github.com/users/jandecaluwe/orgs","repos_url":"https://api.github.com/users/jandecaluwe/repos","events_url":"https://api.github.com/users/jandecaluwe/events{/privacy}","received_events_url":"https://api.github.com/users/jandecaluwe/received_events","type":"User","site_admin":false},"repo":{"id":30467971,"name":"myhdl","full_name":"jandecaluwe/myhdl","owner":{"login":"jandecaluwe","id":1984236,"avatar_url":"https://avatars.githubusercontent.com/u/1984236?v=3","gravatar_id":"","url":"https://api.github.com/users/jandecaluwe","html_url":"https://github.com/jandecaluwe","followers_url":"https://api.github.com/users/jandecaluwe/followers","following_url":"https://api.github.com/users/jandecaluwe/following{/other_user}","gists_url":"https://api.github.com/users/jandecaluwe/gists{/gist_id}","starred_url":"https://api.github.com/users/jandecaluwe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jandecaluwe/subscriptions","organizations_url":"https://api.github.com/users/jandecaluwe/orgs","repos_url":"https://api.github.com/users/jandecaluwe/repos","events_url":"https://api.github.com/users/jandecaluwe/events{/privacy}","received_events_url":"https://api.github.com/users/jandecaluwe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jandecaluwe/myhdl","description":"The MyHDL development repository","fork":false,"url":"https://api.github.com/repos/jandecaluwe/myhdl","forks_url":"https://api.github.com/repos/jandecaluwe/myhdl/forks","keys_url":"https://api.github.com/repos/jandecaluwe/myhdl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jandecaluwe/myhdl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jandecaluwe/myhdl/teams","hooks_url":"https://api.github.com/repos/jandecaluwe/myhdl/hooks","issue_events_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/events{/number}","events_url":"https://api.github.com/repos/jandecaluwe/myhdl/events","assignees_url":"https://api.github.com/repos/jandecaluwe/myhdl/assignees{/user}","branches_url":"https://api.github.com/repos/jandecaluwe/myhdl/branches{/branch}","tags_url":"https://api.github.com/repos/jandecaluwe/myhdl/tags","blobs_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/refs{/sha}","trees_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jandecaluwe/myhdl/statuses/{sha}","languages_url":"https://api.github.com/repos/jandecaluwe/myhdl/languages","stargazers_url":"https://api.github.com/repos/jandecaluwe/myhdl/stargazers","contributors_url":"https://api.github.com/repos/jandecaluwe/myhdl/contributors","subscribers_url":"https://api.github.com/repos/jandecaluwe/myhdl/subscribers","subscription_url":"https://api.github.com/repos/jandecaluwe/myhdl/subscription","commits_url":"https://api.github.com/repos/jandecaluwe/myhdl/commits{/sha}","git_commits_url":"https://api.github.com/repos/jandecaluwe/myhdl/git/commits{/sha}","comments_url":"https://api.github.com/repos/jandecaluwe/myhdl/comments{/number}","issue_comment_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues/comments{/number}","contents_url":"https://api.github.com/repos/jandecaluwe/myhdl/contents/{+path}","compare_url":"https://api.github.com/repos/jandecaluwe/myhdl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jandecaluwe/myhdl/merges","archive_url":"https://api.github.com/repos/jandecaluwe/myhdl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jandecaluwe/myhdl/downloads","issues_url":"https://api.github.com/repos/jandecaluwe/myhdl/issues{/number}","pulls_url":"https://api.github.com/repos/jandecaluwe/myhdl/pulls{/number}","milestones_url":"https://api.github.com/repos/jandecaluwe/myhdl/milestones{/number}","notifications_url":"https://api.github.com/repos/jandecaluwe/myhdl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jandecaluwe/myhdl/labels{/name}","releases_url":"https://api.github.com/repos/jandecaluwe/myhdl/releases{/id}","created_at":"2015-02-07T19:50:27Z","updated_at":"2015-04-09T15:13:17Z","pushed_at":"2015-04-09T14:57:38Z","git_url":"git://github.com/jandecaluwe/myhdl.git","ssh_url":"git@github.com:jandecaluwe/myhdl.git","clone_url":"https://github.com/jandecaluwe/myhdl.git","svn_url":"https://github.com/jandecaluwe/myhdl","homepage":"http://www.myhdl.org","size":13571,"stargazers_count":26,"watchers_count":26,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"open_issues_count":20,"forks":21,"open_issues":20,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56"},"html":{"href":"https://github.com/jandecaluwe/myhdl/pull/56"},"issue":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/issues/56"},"comments":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/jandecaluwe/myhdl/statuses/01da49766ef4b97802d04b60c9b282dc144a582e"}}}}