{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/41045109","id":41045109,"diff_hunk":"@@ -51,6 +58,7 @@ internal AssemblyInformation(string sourceFile)\n             ErrorUtilities.VerifyThrowArgumentNull(sourceFile, \"sourceFile\");\n             _sourceFile = sourceFile;\n \n+#if FEATURE_ASSEMBLY_LOADFROM\n             if (NativeMethodsShared.IsWindows)","path":"src/XMakeTasks/AssemblyDependency/AssemblyInformation.cs","position":40,"original_position":40,"commit_id":"20d101c923fb18b10541bbb77c7a5acbd3c5b0cc","original_commit_id":"20d101c923fb18b10541bbb77c7a5acbd3c5b0cc","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"body":"@rainersigwald\r\n\r\n> Do we need this check any more, or is it superseded by `FEATURE_ASSEMBLY_LOADFROM`?\r\n\r\nI think we still need it for Mono, which supports Assembly.LoadFrom.","created_at":"2015-10-02T17:23:03Z","updated_at":"2015-10-02T17:23:03Z","html_url":"https://github.com/Microsoft/msbuild/pull/243#discussion_r41045109","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/243","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/41045109"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/243#discussion_r41045109"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/243"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/243","id":46586797,"html_url":"https://github.com/Microsoft/msbuild/pull/243","diff_url":"https://github.com/Microsoft/msbuild/pull/243.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/243.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/243","number":243,"state":"open","locked":false,"title":"Port various tasks to .NET Core","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"body":"This adds a variety of tasks to the .NET Core build.  This should be sufficient to compile basic libraries and console applications targeting the .NET Framework with the .NET Core version of MSBuild.","created_at":"2015-10-01T22:51:27Z","updated_at":"2015-10-02T17:23:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"924441a6b9eea95a77e1fd2b9cb18c694069775a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/243/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/243/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/243/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/20d101c923fb18b10541bbb77c7a5acbd3c5b0cc","head":{"label":"dsplaisted:tasks-port","ref":"tasks-port","sha":"20d101c923fb18b10541bbb77c7a5acbd3c5b0cc","user":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"repo":{"id":40565594,"name":"msbuild","full_name":"dsplaisted/msbuild","owner":{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars.githubusercontent.com/u/145043?v=3","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dsplaisted/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/dsplaisted/msbuild","forks_url":"https://api.github.com/repos/dsplaisted/msbuild/forks","keys_url":"https://api.github.com/repos/dsplaisted/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dsplaisted/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dsplaisted/msbuild/teams","hooks_url":"https://api.github.com/repos/dsplaisted/msbuild/hooks","issue_events_url":"https://api.github.com/repos/dsplaisted/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/dsplaisted/msbuild/events","assignees_url":"https://api.github.com/repos/dsplaisted/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/dsplaisted/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/dsplaisted/msbuild/tags","blobs_url":"https://api.github.com/repos/dsplaisted/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dsplaisted/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dsplaisted/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/dsplaisted/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dsplaisted/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/dsplaisted/msbuild/languages","stargazers_url":"https://api.github.com/repos/dsplaisted/msbuild/stargazers","contributors_url":"https://api.github.com/repos/dsplaisted/msbuild/contributors","subscribers_url":"https://api.github.com/repos/dsplaisted/msbuild/subscribers","subscription_url":"https://api.github.com/repos/dsplaisted/msbuild/subscription","commits_url":"https://api.github.com/repos/dsplaisted/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/dsplaisted/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/dsplaisted/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/dsplaisted/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/dsplaisted/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/dsplaisted/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dsplaisted/msbuild/merges","archive_url":"https://api.github.com/repos/dsplaisted/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dsplaisted/msbuild/downloads","issues_url":"https://api.github.com/repos/dsplaisted/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/dsplaisted/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/dsplaisted/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/dsplaisted/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dsplaisted/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/dsplaisted/msbuild/releases{/id}","created_at":"2015-08-11T21:14:50Z","updated_at":"2015-08-11T21:14:54Z","pushed_at":"2015-10-01T22:49:59Z","git_url":"git://github.com/dsplaisted/msbuild.git","ssh_url":"git@github.com:dsplaisted/msbuild.git","clone_url":"https://github.com/dsplaisted/msbuild.git","svn_url":"https://github.com/dsplaisted/msbuild","homepage":null,"size":6858,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:xplat","ref":"xplat","sha":"bd14e2ef2af1c88ac384210f8aa6ab6bb9f0d0b9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","created_at":"2015-03-12T02:04:46Z","updated_at":"2015-10-02T11:19:44Z","pushed_at":"2015-10-02T15:34:55Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":10125,"stargazers_count":2268,"watchers_count":2268,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":417,"mirror_url":null,"open_issues_count":64,"forks":417,"open_issues":64,"watchers":2268,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/243"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/243"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/243"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/243/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/243/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/243/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/20d101c923fb18b10541bbb77c7a5acbd3c5b0cc"}}}}