{"action":"created","comment":{"url":"https://api.github.com/repos/hoaproject/Database/pulls/comments/33258472","id":33258472,"diff_hunk":"@@ -75,6 +75,7 @@ public function from($source)\n      */\n     public function __toString()\n     {\n-        return 'DELETE FROM ' . $this->_from . parent::__toString();\n+        return 'DELETE FROM ' . $this->enclose($this->_from) .","path":"Query/Delete.php","position":5,"original_position":5,"commit_id":"46d2c64c6647b3b9e68123e1f921e68ac7f76e1b","original_commit_id":"46d2c64c6647b3b9e68123e1f921e68ac7f76e1b","user":{"login":"Hywan","id":946104,"avatar_url":"https://avatars.githubusercontent.com/u/946104?v=3","gravatar_id":"","url":"https://api.github.com/users/Hywan","html_url":"https://github.com/Hywan","followers_url":"https://api.github.com/users/Hywan/followers","following_url":"https://api.github.com/users/Hywan/following{/other_user}","gists_url":"https://api.github.com/users/Hywan/gists{/gist_id}","starred_url":"https://api.github.com/users/Hywan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hywan/subscriptions","organizations_url":"https://api.github.com/users/Hywan/orgs","repos_url":"https://api.github.com/users/Hywan/repos","events_url":"https://api.github.com/users/Hywan/events{/privacy}","received_events_url":"https://api.github.com/users/Hywan/received_events","type":"User","site_admin":false},"body":"CS:\r\n```php\r\nreturn\r\n    'DELETE FROM ' .\r\n    $this->_from .\r\n    parent::__toString();\r\n```\r\nWhen we have multiple concatenation, we prefer this syntax now :-). Had to be formalized though…","created_at":"2015-06-25T14:12:14Z","updated_at":"2015-06-25T14:12:14Z","html_url":"https://github.com/hoaproject/Database/pull/27#discussion_r33258472","pull_request_url":"https://api.github.com/repos/hoaproject/Database/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/hoaproject/Database/pulls/comments/33258472"},"html":{"href":"https://github.com/hoaproject/Database/pull/27#discussion_r33258472"},"pull_request":{"href":"https://api.github.com/repos/hoaproject/Database/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/hoaproject/Database/pulls/27","id":38091700,"html_url":"https://github.com/hoaproject/Database/pull/27","diff_url":"https://github.com/hoaproject/Database/pull/27.diff","patch_url":"https://github.com/hoaproject/Database/pull/27.patch","issue_url":"https://api.github.com/repos/hoaproject/Database/issues/27","number":27,"state":"open","locked":false,"title":"Introduce Enclose names feature.","user":{"login":"Metalaka","id":5406767,"avatar_url":"https://avatars.githubusercontent.com/u/5406767?v=3","gravatar_id":"","url":"https://api.github.com/users/Metalaka","html_url":"https://github.com/Metalaka","followers_url":"https://api.github.com/users/Metalaka/followers","following_url":"https://api.github.com/users/Metalaka/following{/other_user}","gists_url":"https://api.github.com/users/Metalaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Metalaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metalaka/subscriptions","organizations_url":"https://api.github.com/users/Metalaka/orgs","repos_url":"https://api.github.com/users/Metalaka/repos","events_url":"https://api.github.com/users/Metalaka/events{/privacy}","received_events_url":"https://api.github.com/users/Metalaka/received_events","type":"User","site_admin":false},"body":"Based on [#7 (New feature : enclose names)](https://github.com/hoaproject/Database/issues/7)\r\n\r\nThis PR will allow use of keywords and resolve some case sensitivity problems for `table`, `column` and `alias` names in the query builder.\r\nThe PR don't enclose columns names in `WHERE` and `HAVING` clause.\r\nThe feature is disabled by default.\r\n\r\nThe `Dml` interface have 3 new methods: enable/disable feature and set symbol.\r\nA new `EncolseNames` abstract class is used by `Where` and `Insert` classes to provide the code of this 3 methods.\r\n\r\n__________\r\nI did this PR because PostgreSQL need enclosed columns names to be case sensitive.\r\nPS: maybe a method `isEnabled` is missing ?","created_at":"2015-06-19T09:42:46Z","updated_at":"2015-06-25T14:12:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a3b8e6fb340a02ad9b68752333a1c2956332eef","assignee":{"login":"osaris","id":125797,"avatar_url":"https://avatars.githubusercontent.com/u/125797?v=3","gravatar_id":"","url":"https://api.github.com/users/osaris","html_url":"https://github.com/osaris","followers_url":"https://api.github.com/users/osaris/followers","following_url":"https://api.github.com/users/osaris/following{/other_user}","gists_url":"https://api.github.com/users/osaris/gists{/gist_id}","starred_url":"https://api.github.com/users/osaris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osaris/subscriptions","organizations_url":"https://api.github.com/users/osaris/orgs","repos_url":"https://api.github.com/users/osaris/repos","events_url":"https://api.github.com/users/osaris/events{/privacy}","received_events_url":"https://api.github.com/users/osaris/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/hoaproject/Database/pulls/27/commits","review_comments_url":"https://api.github.com/repos/hoaproject/Database/pulls/27/comments","review_comment_url":"https://api.github.com/repos/hoaproject/Database/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hoaproject/Database/issues/27/comments","statuses_url":"https://api.github.com/repos/hoaproject/Database/statuses/46d2c64c6647b3b9e68123e1f921e68ac7f76e1b","head":{"label":"Metalaka:encloseNames","ref":"encloseNames","sha":"46d2c64c6647b3b9e68123e1f921e68ac7f76e1b","user":{"login":"Metalaka","id":5406767,"avatar_url":"https://avatars.githubusercontent.com/u/5406767?v=3","gravatar_id":"","url":"https://api.github.com/users/Metalaka","html_url":"https://github.com/Metalaka","followers_url":"https://api.github.com/users/Metalaka/followers","following_url":"https://api.github.com/users/Metalaka/following{/other_user}","gists_url":"https://api.github.com/users/Metalaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Metalaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metalaka/subscriptions","organizations_url":"https://api.github.com/users/Metalaka/orgs","repos_url":"https://api.github.com/users/Metalaka/repos","events_url":"https://api.github.com/users/Metalaka/events{/privacy}","received_events_url":"https://api.github.com/users/Metalaka/received_events","type":"User","site_admin":false},"repo":{"id":15974944,"name":"Database","full_name":"Metalaka/Database","owner":{"login":"Metalaka","id":5406767,"avatar_url":"https://avatars.githubusercontent.com/u/5406767?v=3","gravatar_id":"","url":"https://api.github.com/users/Metalaka","html_url":"https://github.com/Metalaka","followers_url":"https://api.github.com/users/Metalaka/followers","following_url":"https://api.github.com/users/Metalaka/following{/other_user}","gists_url":"https://api.github.com/users/Metalaka/gists{/gist_id}","starred_url":"https://api.github.com/users/Metalaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Metalaka/subscriptions","organizations_url":"https://api.github.com/users/Metalaka/orgs","repos_url":"https://api.github.com/users/Metalaka/repos","events_url":"https://api.github.com/users/Metalaka/events{/privacy}","received_events_url":"https://api.github.com/users/Metalaka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Metalaka/Database","description":"The Hoa\\Database library.","fork":true,"url":"https://api.github.com/repos/Metalaka/Database","forks_url":"https://api.github.com/repos/Metalaka/Database/forks","keys_url":"https://api.github.com/repos/Metalaka/Database/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Metalaka/Database/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Metalaka/Database/teams","hooks_url":"https://api.github.com/repos/Metalaka/Database/hooks","issue_events_url":"https://api.github.com/repos/Metalaka/Database/issues/events{/number}","events_url":"https://api.github.com/repos/Metalaka/Database/events","assignees_url":"https://api.github.com/repos/Metalaka/Database/assignees{/user}","branches_url":"https://api.github.com/repos/Metalaka/Database/branches{/branch}","tags_url":"https://api.github.com/repos/Metalaka/Database/tags","blobs_url":"https://api.github.com/repos/Metalaka/Database/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Metalaka/Database/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Metalaka/Database/git/refs{/sha}","trees_url":"https://api.github.com/repos/Metalaka/Database/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Metalaka/Database/statuses/{sha}","languages_url":"https://api.github.com/repos/Metalaka/Database/languages","stargazers_url":"https://api.github.com/repos/Metalaka/Database/stargazers","contributors_url":"https://api.github.com/repos/Metalaka/Database/contributors","subscribers_url":"https://api.github.com/repos/Metalaka/Database/subscribers","subscription_url":"https://api.github.com/repos/Metalaka/Database/subscription","commits_url":"https://api.github.com/repos/Metalaka/Database/commits{/sha}","git_commits_url":"https://api.github.com/repos/Metalaka/Database/git/commits{/sha}","comments_url":"https://api.github.com/repos/Metalaka/Database/comments{/number}","issue_comment_url":"https://api.github.com/repos/Metalaka/Database/issues/comments{/number}","contents_url":"https://api.github.com/repos/Metalaka/Database/contents/{+path}","compare_url":"https://api.github.com/repos/Metalaka/Database/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Metalaka/Database/merges","archive_url":"https://api.github.com/repos/Metalaka/Database/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Metalaka/Database/downloads","issues_url":"https://api.github.com/repos/Metalaka/Database/issues{/number}","pulls_url":"https://api.github.com/repos/Metalaka/Database/pulls{/number}","milestones_url":"https://api.github.com/repos/Metalaka/Database/milestones{/number}","notifications_url":"https://api.github.com/repos/Metalaka/Database/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Metalaka/Database/labels{/name}","releases_url":"https://api.github.com/repos/Metalaka/Database/releases{/id}","created_at":"2014-01-16T17:19:57Z","updated_at":"2015-04-23T14:31:25Z","pushed_at":"2015-06-22T16:46:09Z","git_url":"git://github.com/Metalaka/Database.git","ssh_url":"git@github.com:Metalaka/Database.git","clone_url":"https://github.com/Metalaka/Database.git","svn_url":"https://github.com/Metalaka/Database","homepage":"http://hoa-project.net/","size":608,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hoaproject:master","ref":"master","sha":"0ec7df591bd0ccd991aea32a3917063412a829d9","user":{"login":"hoaproject","id":1519718,"avatar_url":"https://avatars.githubusercontent.com/u/1519718?v=3","gravatar_id":"","url":"https://api.github.com/users/hoaproject","html_url":"https://github.com/hoaproject","followers_url":"https://api.github.com/users/hoaproject/followers","following_url":"https://api.github.com/users/hoaproject/following{/other_user}","gists_url":"https://api.github.com/users/hoaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaproject/subscriptions","organizations_url":"https://api.github.com/users/hoaproject/orgs","repos_url":"https://api.github.com/users/hoaproject/repos","events_url":"https://api.github.com/users/hoaproject/events{/privacy}","received_events_url":"https://api.github.com/users/hoaproject/received_events","type":"Organization","site_admin":false},"repo":{"id":5538819,"name":"Database","full_name":"hoaproject/Database","owner":{"login":"hoaproject","id":1519718,"avatar_url":"https://avatars.githubusercontent.com/u/1519718?v=3","gravatar_id":"","url":"https://api.github.com/users/hoaproject","html_url":"https://github.com/hoaproject","followers_url":"https://api.github.com/users/hoaproject/followers","following_url":"https://api.github.com/users/hoaproject/following{/other_user}","gists_url":"https://api.github.com/users/hoaproject/gists{/gist_id}","starred_url":"https://api.github.com/users/hoaproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoaproject/subscriptions","organizations_url":"https://api.github.com/users/hoaproject/orgs","repos_url":"https://api.github.com/users/hoaproject/repos","events_url":"https://api.github.com/users/hoaproject/events{/privacy}","received_events_url":"https://api.github.com/users/hoaproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hoaproject/Database","description":"The Hoa\\Database library.","fork":false,"url":"https://api.github.com/repos/hoaproject/Database","forks_url":"https://api.github.com/repos/hoaproject/Database/forks","keys_url":"https://api.github.com/repos/hoaproject/Database/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hoaproject/Database/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hoaproject/Database/teams","hooks_url":"https://api.github.com/repos/hoaproject/Database/hooks","issue_events_url":"https://api.github.com/repos/hoaproject/Database/issues/events{/number}","events_url":"https://api.github.com/repos/hoaproject/Database/events","assignees_url":"https://api.github.com/repos/hoaproject/Database/assignees{/user}","branches_url":"https://api.github.com/repos/hoaproject/Database/branches{/branch}","tags_url":"https://api.github.com/repos/hoaproject/Database/tags","blobs_url":"https://api.github.com/repos/hoaproject/Database/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hoaproject/Database/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hoaproject/Database/git/refs{/sha}","trees_url":"https://api.github.com/repos/hoaproject/Database/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hoaproject/Database/statuses/{sha}","languages_url":"https://api.github.com/repos/hoaproject/Database/languages","stargazers_url":"https://api.github.com/repos/hoaproject/Database/stargazers","contributors_url":"https://api.github.com/repos/hoaproject/Database/contributors","subscribers_url":"https://api.github.com/repos/hoaproject/Database/subscribers","subscription_url":"https://api.github.com/repos/hoaproject/Database/subscription","commits_url":"https://api.github.com/repos/hoaproject/Database/commits{/sha}","git_commits_url":"https://api.github.com/repos/hoaproject/Database/git/commits{/sha}","comments_url":"https://api.github.com/repos/hoaproject/Database/comments{/number}","issue_comment_url":"https://api.github.com/repos/hoaproject/Database/issues/comments{/number}","contents_url":"https://api.github.com/repos/hoaproject/Database/contents/{+path}","compare_url":"https://api.github.com/repos/hoaproject/Database/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hoaproject/Database/merges","archive_url":"https://api.github.com/repos/hoaproject/Database/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hoaproject/Database/downloads","issues_url":"https://api.github.com/repos/hoaproject/Database/issues{/number}","pulls_url":"https://api.github.com/repos/hoaproject/Database/pulls{/number}","milestones_url":"https://api.github.com/repos/hoaproject/Database/milestones{/number}","notifications_url":"https://api.github.com/repos/hoaproject/Database/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hoaproject/Database/labels{/name}","releases_url":"https://api.github.com/repos/hoaproject/Database/releases{/id}","created_at":"2012-08-24T10:30:59Z","updated_at":"2015-04-27T17:23:29Z","pushed_at":"2015-06-22T16:46:09Z","git_url":"git://github.com/hoaproject/Database.git","ssh_url":"git@github.com:hoaproject/Database.git","clone_url":"https://github.com/hoaproject/Database.git","svn_url":"https://github.com/hoaproject/Database","homepage":"http://hoa-project.net/","size":703,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":5,"forks":12,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hoaproject/Database/pulls/27"},"html":{"href":"https://github.com/hoaproject/Database/pull/27"},"issue":{"href":"https://api.github.com/repos/hoaproject/Database/issues/27"},"comments":{"href":"https://api.github.com/repos/hoaproject/Database/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/hoaproject/Database/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/hoaproject/Database/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hoaproject/Database/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/hoaproject/Database/statuses/46d2c64c6647b3b9e68123e1f921e68ac7f76e1b"}}}}