{"action":"created","comment":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/36094620","id":36094620,"diff_hunk":"@@ -1192,9 +1166,8 @@ def SetDesktopIcon(file)\n \n       return false unless icon\n \n-      icon_path = File.join(@icon_path, icon + \".png\")","path":"library/wizard/src/modules/Wizard.rb","position":256,"original_position":256,"commit_id":"ee8fba6d8856a0429c653b000b9ed1efc6ce9459","original_commit_id":"ee8fba6d8856a0429c653b000b9ed1efc6ce9459","user":{"login":"mvidner","id":102056,"avatar_url":"https://avatars.githubusercontent.com/u/102056?v=3","gravatar_id":"","url":"https://api.github.com/users/mvidner","html_url":"https://github.com/mvidner","followers_url":"https://api.github.com/users/mvidner/followers","following_url":"https://api.github.com/users/mvidner/following{/other_user}","gists_url":"https://api.github.com/users/mvidner/gists{/gist_id}","starred_url":"https://api.github.com/users/mvidner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mvidner/subscriptions","organizations_url":"https://api.github.com/users/mvidner/orgs","repos_url":"https://api.github.com/users/mvidner/repos","events_url":"https://api.github.com/users/mvidner/events{/privacy}","received_events_url":"https://api.github.com/users/mvidner/received_events","type":"User","site_admin":false},"body":"So this @icon_path was never defined and wouldn't work. Nice catch.","created_at":"2015-08-03T15:10:29Z","updated_at":"2015-08-03T15:10:29Z","html_url":"https://github.com/yast/yast-yast2/pull/387#discussion_r36094620","pull_request_url":"https://api.github.com/repos/yast/yast-yast2/pulls/387","_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments/36094620"},"html":{"href":"https://github.com/yast/yast-yast2/pull/387#discussion_r36094620"},"pull_request":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/387"}}},"pull_request":{"url":"https://api.github.com/repos/yast/yast-yast2/pulls/387","id":41472986,"html_url":"https://github.com/yast/yast-yast2/pull/387","diff_url":"https://github.com/yast/yast-yast2/pull/387.diff","patch_url":"https://github.com/yast/yast-yast2/pull/387.patch","issue_url":"https://api.github.com/repos/yast/yast-yast2/issues/387","number":387,"state":"open","locked":false,"title":"Prevent premature call to SetApplicationIcon (bnc#940341)","user":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars.githubusercontent.com/u/3638289?v=3","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-08-03T14:34:29Z","updated_at":"2015-08-03T15:10:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00e9eb902319ff29a9640eb5bdd240e3ddee7d20","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/yast/yast-yast2/pulls/387/commits","review_comments_url":"https://api.github.com/repos/yast/yast-yast2/pulls/387/comments","review_comment_url":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/yast/yast-yast2/issues/387/comments","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/ee8fba6d8856a0429c653b000b9ed1efc6ce9459","head":{"label":"ancorgs:fix_940341","ref":"fix_940341","sha":"ee8fba6d8856a0429c653b000b9ed1efc6ce9459","user":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars.githubusercontent.com/u/3638289?v=3","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"repo":{"id":22348610,"name":"yast-yast2","full_name":"ancorgs/yast-yast2","owner":{"login":"ancorgs","id":3638289,"avatar_url":"https://avatars.githubusercontent.com/u/3638289?v=3","gravatar_id":"","url":"https://api.github.com/users/ancorgs","html_url":"https://github.com/ancorgs","followers_url":"https://api.github.com/users/ancorgs/followers","following_url":"https://api.github.com/users/ancorgs/following{/other_user}","gists_url":"https://api.github.com/users/ancorgs/gists{/gist_id}","starred_url":"https://api.github.com/users/ancorgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ancorgs/subscriptions","organizations_url":"https://api.github.com/users/ancorgs/orgs","repos_url":"https://api.github.com/users/ancorgs/repos","events_url":"https://api.github.com/users/ancorgs/events{/privacy}","received_events_url":"https://api.github.com/users/ancorgs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ancorgs/yast-yast2","description":"YaST module yast2","fork":true,"url":"https://api.github.com/repos/ancorgs/yast-yast2","forks_url":"https://api.github.com/repos/ancorgs/yast-yast2/forks","keys_url":"https://api.github.com/repos/ancorgs/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ancorgs/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ancorgs/yast-yast2/teams","hooks_url":"https://api.github.com/repos/ancorgs/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/ancorgs/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/ancorgs/yast-yast2/events","assignees_url":"https://api.github.com/repos/ancorgs/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/ancorgs/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/ancorgs/yast-yast2/tags","blobs_url":"https://api.github.com/repos/ancorgs/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ancorgs/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ancorgs/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ancorgs/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ancorgs/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/ancorgs/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/ancorgs/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/ancorgs/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/ancorgs/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/ancorgs/yast-yast2/subscription","commits_url":"https://api.github.com/repos/ancorgs/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ancorgs/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ancorgs/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ancorgs/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ancorgs/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/ancorgs/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ancorgs/yast-yast2/merges","archive_url":"https://api.github.com/repos/ancorgs/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ancorgs/yast-yast2/downloads","issues_url":"https://api.github.com/repos/ancorgs/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/ancorgs/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/ancorgs/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/ancorgs/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ancorgs/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/ancorgs/yast-yast2/releases{/id}","created_at":"2014-07-28T15:57:00Z","updated_at":"2015-02-03T12:10:26Z","pushed_at":"2015-08-03T14:33:27Z","git_url":"git://github.com/ancorgs/yast-yast2.git","ssh_url":"git@github.com:ancorgs/yast-yast2.git","clone_url":"https://github.com/ancorgs/yast-yast2.git","svn_url":"https://github.com/ancorgs/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":23414,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"yast:master","ref":"master","sha":"62a44143197466393c2d48a6c963b12be9d99179","user":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"repo":{"id":4368244,"name":"yast-yast2","full_name":"yast/yast-yast2","owner":{"login":"yast","id":909990,"avatar_url":"https://avatars.githubusercontent.com/u/909990?v=3","gravatar_id":"","url":"https://api.github.com/users/yast","html_url":"https://github.com/yast","followers_url":"https://api.github.com/users/yast/followers","following_url":"https://api.github.com/users/yast/following{/other_user}","gists_url":"https://api.github.com/users/yast/gists{/gist_id}","starred_url":"https://api.github.com/users/yast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yast/subscriptions","organizations_url":"https://api.github.com/users/yast/orgs","repos_url":"https://api.github.com/users/yast/repos","events_url":"https://api.github.com/users/yast/events{/privacy}","received_events_url":"https://api.github.com/users/yast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/yast/yast-yast2","description":"YaST module yast2","fork":false,"url":"https://api.github.com/repos/yast/yast-yast2","forks_url":"https://api.github.com/repos/yast/yast-yast2/forks","keys_url":"https://api.github.com/repos/yast/yast-yast2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yast/yast-yast2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yast/yast-yast2/teams","hooks_url":"https://api.github.com/repos/yast/yast-yast2/hooks","issue_events_url":"https://api.github.com/repos/yast/yast-yast2/issues/events{/number}","events_url":"https://api.github.com/repos/yast/yast-yast2/events","assignees_url":"https://api.github.com/repos/yast/yast-yast2/assignees{/user}","branches_url":"https://api.github.com/repos/yast/yast-yast2/branches{/branch}","tags_url":"https://api.github.com/repos/yast/yast-yast2/tags","blobs_url":"https://api.github.com/repos/yast/yast-yast2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yast/yast-yast2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yast/yast-yast2/git/refs{/sha}","trees_url":"https://api.github.com/repos/yast/yast-yast2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yast/yast-yast2/statuses/{sha}","languages_url":"https://api.github.com/repos/yast/yast-yast2/languages","stargazers_url":"https://api.github.com/repos/yast/yast-yast2/stargazers","contributors_url":"https://api.github.com/repos/yast/yast-yast2/contributors","subscribers_url":"https://api.github.com/repos/yast/yast-yast2/subscribers","subscription_url":"https://api.github.com/repos/yast/yast-yast2/subscription","commits_url":"https://api.github.com/repos/yast/yast-yast2/commits{/sha}","git_commits_url":"https://api.github.com/repos/yast/yast-yast2/git/commits{/sha}","comments_url":"https://api.github.com/repos/yast/yast-yast2/comments{/number}","issue_comment_url":"https://api.github.com/repos/yast/yast-yast2/issues/comments{/number}","contents_url":"https://api.github.com/repos/yast/yast-yast2/contents/{+path}","compare_url":"https://api.github.com/repos/yast/yast-yast2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yast/yast-yast2/merges","archive_url":"https://api.github.com/repos/yast/yast-yast2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yast/yast-yast2/downloads","issues_url":"https://api.github.com/repos/yast/yast-yast2/issues{/number}","pulls_url":"https://api.github.com/repos/yast/yast-yast2/pulls{/number}","milestones_url":"https://api.github.com/repos/yast/yast-yast2/milestones{/number}","notifications_url":"https://api.github.com/repos/yast/yast-yast2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yast/yast-yast2/labels{/name}","releases_url":"https://api.github.com/repos/yast/yast-yast2/releases{/id}","created_at":"2012-05-18T10:27:22Z","updated_at":"2015-07-14T07:27:56Z","pushed_at":"2015-08-03T14:34:29Z","git_url":"git://github.com/yast/yast-yast2.git","ssh_url":"git@github.com:yast/yast-yast2.git","clone_url":"https://github.com/yast/yast-yast2.git","svn_url":"https://github.com/yast/yast-yast2","homepage":"http://en.opensuse.org/Portal:YaST","size":26681,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":5,"forks":24,"open_issues":5,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/387"},"html":{"href":"https://github.com/yast/yast-yast2/pull/387"},"issue":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/387"},"comments":{"href":"https://api.github.com/repos/yast/yast-yast2/issues/387/comments"},"review_comments":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/387/comments"},"review_comment":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/yast/yast-yast2/pulls/387/commits"},"statuses":{"href":"https://api.github.com/repos/yast/yast-yast2/statuses/ee8fba6d8856a0429c653b000b9ed1efc6ce9459"}}}}