{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/45934352","id":45934352,"diff_hunk":"@@ -0,0 +1,77 @@\n+﻿/*\n+Project Orleans Cloud Service SDK ver. 1.0\n+ \n+Copyright (c) Microsoft Corporation\n+ \n+All rights reserved.\n+ \n+MIT License\n+\n+Permission is hereby granted, free of charge, to any person obtaining a copy of this software and \n+associated documentation files (the \"\"Software\"\"), to deal in the Software without restriction,\n+including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense,\n+and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so,\n+subject to the following conditions:\n+\n+The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.\n+\n+THE SOFTWARE IS PROVIDED *AS IS*, WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO\n+THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS\n+OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,\n+TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.\n+*/\n+\n+using System;\n+using System.Globalization;\n+using System.Threading.Tasks;\n+using Microsoft.VisualStudio.TestTools.UnitTesting;\n+using Orleans;\n+using Orleans.Runtime;\n+using Orleans.TestingHost;\n+using UnitTests.GrainInterfaces;\n+using UnitTests.Tester;\n+using System.Collections.Generic;\n+using Orleans.Serialization;\n+using TesterExternalModels;\n+using TestGrainInterfaces;\n+\n+namespace UnitTests.General\n+{\n+    /// <summary>\n+    /// Unit tests for grains implementing generic interfaces\n+    /// </summary>\n+    [TestClass]\n+    public class ExternalTypesTests : UnitTestSiloHost\n+    {\n+        public ExternalTypesTests()\n+            : base(new TestingSiloOptions { StartPrimary = true, StartSecondary = false })\n+        {\n+        }\n+\n+        [ClassCleanup]\n+        public static void MyClassCleanup()\n+        {\n+            StopAllSilos();\n+        }\n+        \n+        [Ignore, TestMethod, TestCategory(\"BVT\"), TestCategory(\"Functional\"), TestCategory(\"Serialization\")]\n+        public async Task ExternalTypesTest_GrainWithAbstractExternalTypeParam()\n+        {\n+            // This solves the problem:\n+            //SerializationManager.Register(typeof(AbstractModel));\n+\n+            var grainWitAbstractTypeParam = GrainClient.GrainFactory.GetGrain<IExternalTypeGrain>(0);\n+            await grainWitAbstractTypeParam.GetAbstractModel(new List<AbstractModel>() {new ConcreteModel()});\n+        }\n+\n+        [Ignore, TestMethod, TestCategory(\"BVT\"), TestCategory(\"Functional\"), TestCategory(\"Serialization\")]\n+        public async Task ExternalTypesTest_GrainWithEnumxternalTypeParam()","path":"src/Tester/ExternalTypesTests.cs","position":68,"original_position":68,"commit_id":"a08d7f0c0ffdc9d59d0b322d76c84d0eab31270c","original_commit_id":"a08d7f0c0ffdc9d59d0b322d76c84d0eab31270c","user":{"login":"ReubenBond","id":203839,"avatar_url":"https://avatars.githubusercontent.com/u/203839?v=3","gravatar_id":"","url":"https://api.github.com/users/ReubenBond","html_url":"https://github.com/ReubenBond","followers_url":"https://api.github.com/users/ReubenBond/followers","following_url":"https://api.github.com/users/ReubenBond/following{/other_user}","gists_url":"https://api.github.com/users/ReubenBond/gists{/gist_id}","starred_url":"https://api.github.com/users/ReubenBond/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReubenBond/subscriptions","organizations_url":"https://api.github.com/users/ReubenBond/orgs","repos_url":"https://api.github.com/users/ReubenBond/repos","events_url":"https://api.github.com/users/ReubenBond/events{/privacy}","received_events_url":"https://api.github.com/users/ReubenBond/received_events","type":"User","site_admin":false},"body":"typo in External","created_at":"2015-11-26T00:33:00Z","updated_at":"2015-11-26T00:33:00Z","html_url":"https://github.com/dotnet/orleans/pull/1077#discussion_r45934352","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/1077","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/45934352"},"html":{"href":"https://github.com/dotnet/orleans/pull/1077#discussion_r45934352"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1077"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/1077","id":51810531,"html_url":"https://github.com/dotnet/orleans/pull/1077","diff_url":"https://github.com/dotnet/orleans/pull/1077.diff","patch_url":"https://github.com/dotnet/orleans/pull/1077.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/1077","number":1077,"state":"open","locked":false,"title":"Added test for usage of abstract/enum types from external libraries","user":{"login":"randa1","id":3209338,"avatar_url":"https://avatars.githubusercontent.com/u/3209338?v=3","gravatar_id":"","url":"https://api.github.com/users/randa1","html_url":"https://github.com/randa1","followers_url":"https://api.github.com/users/randa1/followers","following_url":"https://api.github.com/users/randa1/following{/other_user}","gists_url":"https://api.github.com/users/randa1/gists{/gist_id}","starred_url":"https://api.github.com/users/randa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randa1/subscriptions","organizations_url":"https://api.github.com/users/randa1/orgs","repos_url":"https://api.github.com/users/randa1/repos","events_url":"https://api.github.com/users/randa1/events{/privacy}","received_events_url":"https://api.github.com/users/randa1/received_events","type":"User","site_admin":false},"body":"Following #1064 and #1072.\r\n\r\nIt's worth noting that the tests fail only if the types are used in generics - the serialization for DoStuff(AbstractType p1) will work but for DoStuff(IEnumerable<AbstractType> p1) will fail.\r\n\r\nCurrently the tests have the Ignore attribute as they are failing until there will be a fix from @ReubenBond.","created_at":"2015-11-25T15:47:04Z","updated_at":"2015-11-26T00:33:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d662ffea20e33eb8a0c6c2924d4d3f25aef0a2a","assignee":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars.githubusercontent.com/u/8248806?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/1077/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/1077/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/1077/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/a08d7f0c0ffdc9d59d0b322d76c84d0eab31270c","head":{"label":"randa1:add_external_types_serialization_tests","ref":"add_external_types_serialization_tests","sha":"a08d7f0c0ffdc9d59d0b322d76c84d0eab31270c","user":{"login":"randa1","id":3209338,"avatar_url":"https://avatars.githubusercontent.com/u/3209338?v=3","gravatar_id":"","url":"https://api.github.com/users/randa1","html_url":"https://github.com/randa1","followers_url":"https://api.github.com/users/randa1/followers","following_url":"https://api.github.com/users/randa1/following{/other_user}","gists_url":"https://api.github.com/users/randa1/gists{/gist_id}","starred_url":"https://api.github.com/users/randa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randa1/subscriptions","organizations_url":"https://api.github.com/users/randa1/orgs","repos_url":"https://api.github.com/users/randa1/repos","events_url":"https://api.github.com/users/randa1/events{/privacy}","received_events_url":"https://api.github.com/users/randa1/received_events","type":"User","site_admin":false},"repo":{"id":46621552,"name":"orleans","full_name":"randa1/orleans","owner":{"login":"randa1","id":3209338,"avatar_url":"https://avatars.githubusercontent.com/u/3209338?v=3","gravatar_id":"","url":"https://api.github.com/users/randa1","html_url":"https://github.com/randa1","followers_url":"https://api.github.com/users/randa1/followers","following_url":"https://api.github.com/users/randa1/following{/other_user}","gists_url":"https://api.github.com/users/randa1/gists{/gist_id}","starred_url":"https://api.github.com/users/randa1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randa1/subscriptions","organizations_url":"https://api.github.com/users/randa1/orgs","repos_url":"https://api.github.com/users/randa1/repos","events_url":"https://api.github.com/users/randa1/events{/privacy}","received_events_url":"https://api.github.com/users/randa1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/randa1/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/randa1/orleans","forks_url":"https://api.github.com/repos/randa1/orleans/forks","keys_url":"https://api.github.com/repos/randa1/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/randa1/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/randa1/orleans/teams","hooks_url":"https://api.github.com/repos/randa1/orleans/hooks","issue_events_url":"https://api.github.com/repos/randa1/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/randa1/orleans/events","assignees_url":"https://api.github.com/repos/randa1/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/randa1/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/randa1/orleans/tags","blobs_url":"https://api.github.com/repos/randa1/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/randa1/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/randa1/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/randa1/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/randa1/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/randa1/orleans/languages","stargazers_url":"https://api.github.com/repos/randa1/orleans/stargazers","contributors_url":"https://api.github.com/repos/randa1/orleans/contributors","subscribers_url":"https://api.github.com/repos/randa1/orleans/subscribers","subscription_url":"https://api.github.com/repos/randa1/orleans/subscription","commits_url":"https://api.github.com/repos/randa1/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/randa1/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/randa1/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/randa1/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/randa1/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/randa1/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/randa1/orleans/merges","archive_url":"https://api.github.com/repos/randa1/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/randa1/orleans/downloads","issues_url":"https://api.github.com/repos/randa1/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/randa1/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/randa1/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/randa1/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/randa1/orleans/labels{/name}","releases_url":"https://api.github.com/repos/randa1/orleans/releases{/id}","created_at":"2015-11-21T15:44:04Z","updated_at":"2015-11-21T15:44:07Z","pushed_at":"2015-11-25T15:46:17Z","git_url":"git://github.com/randa1/orleans.git","ssh_url":"git@github.com:randa1/orleans.git","clone_url":"https://github.com/randa1/orleans.git","svn_url":"https://github.com/randa1/orleans","homepage":"http://dotnet.github.io/orleans","size":10715,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"97fad8fa9800d31be9fd19b83fbdbeae1a52eff8","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","created_at":"2014-12-19T14:32:50Z","updated_at":"2015-11-25T15:40:26Z","pushed_at":"2015-11-25T23:09:55Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":27306,"stargazers_count":1349,"watchers_count":1349,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":313,"mirror_url":null,"open_issues_count":105,"forks":313,"open_issues":105,"watchers":1349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1077"},"html":{"href":"https://github.com/dotnet/orleans/pull/1077"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/1077"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/1077/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1077/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/1077/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/a08d7f0c0ffdc9d59d0b322d76c84d0eab31270c"}}}}