{"action":"closed","issue":{"url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4410","labels_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4410/labels{/name}","comments_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4410/comments","events_url":"https://api.github.com/repos/ember-cli/ember-cli/issues/4410/events","html_url":"https://github.com/ember-cli/ember-cli/issues/4410","id":94117208,"number":4410,"title":"Brocfile.js -> ember-cli-build.js transition improvements","user":{"login":"pixelhandler","id":17178,"avatar_url":"https://avatars.githubusercontent.com/u/17178?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelhandler","html_url":"https://github.com/pixelhandler","followers_url":"https://api.github.com/users/pixelhandler/followers","following_url":"https://api.github.com/users/pixelhandler/following{/other_user}","gists_url":"https://api.github.com/users/pixelhandler/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelhandler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelhandler/subscriptions","organizations_url":"https://api.github.com/users/pixelhandler/orgs","repos_url":"https://api.github.com/users/pixelhandler/repos","events_url":"https://api.github.com/users/pixelhandler/events{/privacy}","received_events_url":"https://api.github.com/users/pixelhandler/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-07-09T18:18:50Z","updated_at":"2015-07-09T19:11:07Z","closed_at":"2015-07-09T19:11:07Z","body":"I had to remove `Brocfile.js` and put that content into `ember-cli-build.js` Also, need to use the `defaults` when I created the `new EmberApp(defaults, {`\r\n\r\n```\r\nultimatemonty [10:52 AM] \r\nany reason I’m getting `TypeError: object is not a function` after updating to ember-cli 1.13.1?\r\nultimatemonty \r\n[10:53 AM] \r\nAdded Full Trace in #ember-cli  \r\nTypeError: object is not a function\r\n    at Class.module.exports.Task.extend.setupBroccoliBuilder (/Users/cmcculler/Projects/Pardot/pardot/web/assets/nurtureStudio/node_modules/ember-cli/lib/models/builder.js:30:19)\r\n    at Class.module.exports.Task.extend.init (/Users/cmcculler/Projects/Pardot/pardot/web/assets/nurtureStudio/node_modules/ember-cli/lib/models/builder.js:48:10)\r\n    at new Class (/Users/cmcculler/Projects/Pardot/pardot/web/assets/nurtureStudio/node_modules/ember-cli/node_modules/core-object/core-object.js:18:12)\r\n    at Class.module.exports.Task.extend.run (/Users/cmcculler/Projects/Pardot/pardot/web/assets/nurtureStudio/node_modules/ember-cli/lib/tasks/build.js:15:19)\r\n    at Class.module.exports.Command.extend.run (/Users/cmcculler/Projects/Pardot/pardot/web/assets/nurtureStudio/node_modules/ember-cli/lib/commands/build.js:25:22)\r\n    at Class.<anonymous> (/Users/cmcculler/Projects/Pardot/pardot/web/assets/nurtureStudio/node_modules/ember-cli/lib/models/command.js:136:17)\r\n+ 4 more lines...\r\n2KB JavaScript/JSON • New window • View raw • Add comment\r\n\r\nultimatemonty [10:55 AM] \r\nupgrading from 0.2.7\r\n\r\npixelhandler [11:02 AM] \r\n@ultimatemonty I think you need to use the new build file instead of Brocfile.js see my upgrade from 0.2.7 to 1.13.1 here https://github.com/pixelhandler/blog/pull/14/files (edited)\r\n\r\npixelhandler [11:02 AM]\r\nI had to remove Brocfile.js and put that content into ember-cli-build.js\r\n\r\nultimatemonty [11:05 AM] \r\nI did\r\n\r\nultimatemonty [11:05 AM]\r\n*I’m pretty sure I did\r\n\r\nultimatemonty [11:06 AM]\r\nyep I did\r\n\r\nultimatemonty [11:08 AM]\r\nmight be my environment checking\r\n\r\npixelhandler [11:08 AM] \r\nFor me it wasn’t a straight copy paste I had to use the format in the new file. well that was by best guess.\r\nultimatemonty \r\n[11:08 AM] \r\nAdded Untitled in #ember-cli  \r\nvar EmberApp = require('ember-cli/lib/broccoli/ember-app'),\r\n\tisProduction = ( process.env.EMBER_ENV || 'development' ) === 'production';\r\n137b JavaScript/JSON • New window • View raw • Add comment\r\n\r\npixelhandler [11:09 AM] \r\nI did recall seeing something like that error until I put the contents of my Brocfile inside the exported function in the new build.js file https://github.com/pixelhandler/blog/pull/14/files#diff-2fe2a7faee7de1e0d5d82e032498d84c\r\n\r\nlocks [11:09 AM] \r\nwhy don't you ignore tmp altogether\r\n\r\nlocks [11:09 AM]\r\noops\r\n\r\nultimatemonty [11:09 AM] \r\nyeah that’s what I’m doing now\r\n\r\nultimatemonty [11:09 AM]\r\nre: module,exports\r\n\r\npixelhandler [11:12 AM] \r\nhad to use the `defaults` when I created the `new EmberApp(defaults, {`\r\n\r\npixelhandler [11:13 AM]\r\nmy old build didn’t have that https://github.com/pixelhandler/blog/blob/c7addef405050856a9fcab702218daf245f85ebb/Brocfile.js#L8 vs https://github.com/pixelhandler/blog/blob/dba4ec45140cffaa35a3ad8cae943191592edfbb/ember-cli-build.js#L7 (edited)\r\n\r\nultimatemonty [11:14 AM] \r\n@pixelhandler: that did the trick thanks!\r\n\r\npixelhandler [11:15 AM] \r\nProlly need to tell @rwjblue about adding this to the release notes it’s a gotcha\r\n\r\nultimatemonty [11:15 AM] \r\nagreed\r\n```"}}