{"action":"closed","issue":{"url":"https://api.github.com/repos/t-oster/VisiCut/issues/165","labels_url":"https://api.github.com/repos/t-oster/VisiCut/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/t-oster/VisiCut/issues/165/comments","events_url":"https://api.github.com/repos/t-oster/VisiCut/issues/165/events","html_url":"https://github.com/t-oster/VisiCut/issues/165","id":16397754,"number":165,"title":"Windows installer does not detect JRE on Windows 7/8","user":{"login":"t-oster","id":1052720,"avatar_url":"https://avatars.githubusercontent.com/u/1052720?v=3","gravatar_id":"","url":"https://api.github.com/users/t-oster","html_url":"https://github.com/t-oster","followers_url":"https://api.github.com/users/t-oster/followers","following_url":"https://api.github.com/users/t-oster/following{/other_user}","gists_url":"https://api.github.com/users/t-oster/gists{/gist_id}","starred_url":"https://api.github.com/users/t-oster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-oster/subscriptions","organizations_url":"https://api.github.com/users/t-oster/orgs","repos_url":"https://api.github.com/users/t-oster/repos","events_url":"https://api.github.com/users/t-oster/events{/privacy}","received_events_url":"https://api.github.com/users/t-oster/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/t-oster/VisiCut/labels/Bug","name":"Bug","color":"e10c02"},{"url":"https://api.github.com/repos/t-oster/VisiCut/labels/Help%20wanted!","name":"Help wanted!","color":"02d7e1"}],"state":"closed","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/t-oster/VisiCut/milestones/4","html_url":"https://github.com/t-oster/VisiCut/milestones/VisiCut%201.8","labels_url":"https://api.github.com/repos/t-oster/VisiCut/milestones/4/labels","id":939040,"number":4,"title":"VisiCut 1.8","description":"The release of VisiCut 1.8. Main Pull Request: #228","creator":{"login":"t-oster","id":1052720,"avatar_url":"https://avatars.githubusercontent.com/u/1052720?v=3","gravatar_id":"","url":"https://api.github.com/users/t-oster","html_url":"https://github.com/t-oster","followers_url":"https://api.github.com/users/t-oster/followers","following_url":"https://api.github.com/users/t-oster/following{/other_user}","gists_url":"https://api.github.com/users/t-oster/gists{/gist_id}","starred_url":"https://api.github.com/users/t-oster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t-oster/subscriptions","organizations_url":"https://api.github.com/users/t-oster/orgs","repos_url":"https://api.github.com/users/t-oster/repos","events_url":"https://api.github.com/users/t-oster/events{/privacy}","received_events_url":"https://api.github.com/users/t-oster/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":1,"state":"open","created_at":"2015-01-16T19:07:38Z","updated_at":"2015-03-21T21:18:07Z","due_on":"2015-03-09T23:00:00Z","closed_at":null},"comments":0,"created_at":"2013-07-05T10:49:24Z","updated_at":"2015-03-21T21:18:07Z","closed_at":"2015-03-21T21:18:07Z","body":"Appearantly there are issues when installing on Windows 7 or 8, that the installer does not detect the installed JRE (Java Runtime Environment). It then tries to install one, which also fails and the aborts the installation in general.\r\n\r\nSince I do not have access to any Windows 7 or 8 installations and not much time, I would appreciate it very much, if someone could take a look into that issue.\r\n\r\nThe related files are in \"distribute/windows\" (https://github.com/t-oster/VisiCut/tree/develop/distribute/windows) and the installer is written using the Nullsoft Scriptable Installer System (NSIS) (http://nsis.sourceforge.net/Main_Page). \r\n\r\nTake a look at the distribute.sh script to see, how the executable is created:\r\n\r\n```\r\necho \"Creating Windows installer\"\r\n  [ -d wintmp ] && rm -rf wintmp\r\n  mkdir wintmp\r\n  cp -r windows/* wintmp/\r\n  [ -d wintmp/stream ] || mkdir wintmp/stream\r\n  cp -r visicut/* wintmp/stream/\r\n  cat windows/installer.nsi|sed s#VISICUTVERSION#\"$VERSION\"#g > wintmp/installer.nsi\r\n  cp ../tools/inkscape_extension/* wintmp/\r\n  cat ../tools/inkscape_extension/visicut_export.py|sed 's#\"visicut\"#\"visicut.exe\"#g' > wintmp/visicut_export.py\r\n  pushd wintmp\r\n  makensis installer.nsi > /dev/null || exit 1\r\n  popd\r\n  mv wintmp/setup.exe VisiCut-$VERSION-Windows-Installer.exe || exit 1\r\n  rm -rf wintmp\r\n```"}}