{"action":"created","comment":{"url":"https://api.github.com/repos/atom/atom/pulls/comments/44474173","id":44474173,"diff_hunk":"@@ -375,6 +377,27 @@ describe \"Pane\", ->\n       pane.destroyInactiveItems()\n       expect(pane.getItems()).toEqual [item2]\n \n+  describe \"::showSaveDialog()\", ->\n+    pane = null\n+    item =  null\n+\n+    beforeEach ->\n+      item = new Item(\"A\")\n+      pane = new Pane(items: [item], applicationDelegate: atom.applicationDelegate)\n+      atom.applicationDelegate.showSaveDialog = jasmine.createSpy(\"atom.showSaveDialog\")\n+\n+    describe \"when the item implements a showSaveDialog method\", ->\n+      it \"calls item.showSaveDialog and saves the item with the results of the returned promise\", ->\n+        item.showSaveDialog = jasmine.createSpy(\"item.showSaveDialog\")\n+        pane.showSaveDialog(item)\n+        expect(item.showSaveDialog).toHaveBeenCalled()\n+        expect(atom.applicationDelegate.showSaveDialog.callCount).toEqual(0)\n+\n+    describe \"when the item doesn't implement a showSaveDialog method\", ->\n+      it \"calls atom.showSaveDialog and saves the item with the results of the returned promise\", ->","path":"spec/pane-spec.coffee","position":45,"original_position":45,"commit_id":"292f8e4cc246205e84b7d6e18488623a75f9b135","original_commit_id":"292f8e4cc246205e84b7d6e18488623a75f9b135","user":{"login":"nathansobo","id":1789,"avatar_url":"https://avatars.githubusercontent.com/u/1789?v=3","gravatar_id":"","url":"https://api.github.com/users/nathansobo","html_url":"https://github.com/nathansobo","followers_url":"https://api.github.com/users/nathansobo/followers","following_url":"https://api.github.com/users/nathansobo/following{/other_user}","gists_url":"https://api.github.com/users/nathansobo/gists{/gist_id}","starred_url":"https://api.github.com/users/nathansobo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathansobo/subscriptions","organizations_url":"https://api.github.com/users/nathansobo/orgs","repos_url":"https://api.github.com/users/nathansobo/repos","events_url":"https://api.github.com/users/nathansobo/events{/privacy}","received_events_url":"https://api.github.com/users/nathansobo/received_events","type":"User","site_admin":true},"body":"You're describing more behavior than is actually tested here. Should fix one or the other.","created_at":"2015-11-10T22:19:09Z","updated_at":"2015-11-10T22:19:09Z","html_url":"https://github.com/atom/atom/pull/9070#discussion_r44474173","pull_request_url":"https://api.github.com/repos/atom/atom/pulls/9070","_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/comments/44474173"},"html":{"href":"https://github.com/atom/atom/pull/9070#discussion_r44474173"},"pull_request":{"href":"https://api.github.com/repos/atom/atom/pulls/9070"}}},"pull_request":{"url":"https://api.github.com/repos/atom/atom/pulls/9070","id":47035215,"html_url":"https://github.com/atom/atom/pull/9070","diff_url":"https://github.com/atom/atom/pull/9070.diff","patch_url":"https://github.com/atom/atom/pull/9070.patch","issue_url":"https://api.github.com/repos/atom/atom/issues/9070","number":9070,"state":"open","locked":false,"title":"Allow a panesActiveItem show a saved Dialog","user":{"login":"billybonks","id":1640136,"avatar_url":"https://avatars.githubusercontent.com/u/1640136?v=3","gravatar_id":"","url":"https://api.github.com/users/billybonks","html_url":"https://github.com/billybonks","followers_url":"https://api.github.com/users/billybonks/followers","following_url":"https://api.github.com/users/billybonks/following{/other_user}","gists_url":"https://api.github.com/users/billybonks/gists{/gist_id}","starred_url":"https://api.github.com/users/billybonks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billybonks/subscriptions","organizations_url":"https://api.github.com/users/billybonks/orgs","repos_url":"https://api.github.com/users/billybonks/repos","events_url":"https://api.github.com/users/billybonks/events{/privacy}","received_events_url":"https://api.github.com/users/billybonks/received_events","type":"User","site_admin":false},"body":"Currently if you want to create a new file type eg:\r\n- writes and reads over ssh\r\n- writes and reads to a remote server\r\n- writes and reads via ftp\r\n\r\nThis functionality can be elegantly achieved by:\r\n-inheriting from File from pathwatcher and over-riding read/write methods and nativeEvent Listeners.\r\n-making a few minor changes to an extended text-buffer.\r\n\r\nThe only way of providing saveAs functionality is by overriding the `activePane`. or shim `atom.showSaveDialogSync`, both are quite large changes to the atom for such a small requirement.","created_at":"2015-10-07T14:35:31Z","updated_at":"2015-11-10T22:19:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f94fd022cb88104ca54f5bf2a78a5a615c792e33","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/atom/atom/pulls/9070/commits","review_comments_url":"https://api.github.com/repos/atom/atom/pulls/9070/comments","review_comment_url":"https://api.github.com/repos/atom/atom/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/atom/issues/9070/comments","statuses_url":"https://api.github.com/repos/atom/atom/statuses/292f8e4cc246205e84b7d6e18488623a75f9b135","head":{"label":"billybonks:save-dialog","ref":"save-dialog","sha":"292f8e4cc246205e84b7d6e18488623a75f9b135","user":{"login":"billybonks","id":1640136,"avatar_url":"https://avatars.githubusercontent.com/u/1640136?v=3","gravatar_id":"","url":"https://api.github.com/users/billybonks","html_url":"https://github.com/billybonks","followers_url":"https://api.github.com/users/billybonks/followers","following_url":"https://api.github.com/users/billybonks/following{/other_user}","gists_url":"https://api.github.com/users/billybonks/gists{/gist_id}","starred_url":"https://api.github.com/users/billybonks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billybonks/subscriptions","organizations_url":"https://api.github.com/users/billybonks/orgs","repos_url":"https://api.github.com/users/billybonks/repos","events_url":"https://api.github.com/users/billybonks/events{/privacy}","received_events_url":"https://api.github.com/users/billybonks/received_events","type":"User","site_admin":false},"repo":{"id":43821198,"name":"atom","full_name":"billybonks/atom","owner":{"login":"billybonks","id":1640136,"avatar_url":"https://avatars.githubusercontent.com/u/1640136?v=3","gravatar_id":"","url":"https://api.github.com/users/billybonks","html_url":"https://github.com/billybonks","followers_url":"https://api.github.com/users/billybonks/followers","following_url":"https://api.github.com/users/billybonks/following{/other_user}","gists_url":"https://api.github.com/users/billybonks/gists{/gist_id}","starred_url":"https://api.github.com/users/billybonks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/billybonks/subscriptions","organizations_url":"https://api.github.com/users/billybonks/orgs","repos_url":"https://api.github.com/users/billybonks/repos","events_url":"https://api.github.com/users/billybonks/events{/privacy}","received_events_url":"https://api.github.com/users/billybonks/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/billybonks/atom","description":"The hackable text editor","fork":true,"url":"https://api.github.com/repos/billybonks/atom","forks_url":"https://api.github.com/repos/billybonks/atom/forks","keys_url":"https://api.github.com/repos/billybonks/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/billybonks/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/billybonks/atom/teams","hooks_url":"https://api.github.com/repos/billybonks/atom/hooks","issue_events_url":"https://api.github.com/repos/billybonks/atom/issues/events{/number}","events_url":"https://api.github.com/repos/billybonks/atom/events","assignees_url":"https://api.github.com/repos/billybonks/atom/assignees{/user}","branches_url":"https://api.github.com/repos/billybonks/atom/branches{/branch}","tags_url":"https://api.github.com/repos/billybonks/atom/tags","blobs_url":"https://api.github.com/repos/billybonks/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/billybonks/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/billybonks/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/billybonks/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/billybonks/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/billybonks/atom/languages","stargazers_url":"https://api.github.com/repos/billybonks/atom/stargazers","contributors_url":"https://api.github.com/repos/billybonks/atom/contributors","subscribers_url":"https://api.github.com/repos/billybonks/atom/subscribers","subscription_url":"https://api.github.com/repos/billybonks/atom/subscription","commits_url":"https://api.github.com/repos/billybonks/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/billybonks/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/billybonks/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/billybonks/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/billybonks/atom/contents/{+path}","compare_url":"https://api.github.com/repos/billybonks/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/billybonks/atom/merges","archive_url":"https://api.github.com/repos/billybonks/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/billybonks/atom/downloads","issues_url":"https://api.github.com/repos/billybonks/atom/issues{/number}","pulls_url":"https://api.github.com/repos/billybonks/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/billybonks/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/billybonks/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/billybonks/atom/labels{/name}","releases_url":"https://api.github.com/repos/billybonks/atom/releases{/id}","created_at":"2015-10-07T14:25:34Z","updated_at":"2015-10-07T14:25:53Z","pushed_at":"2015-11-08T12:54:41Z","git_url":"git://github.com/billybonks/atom.git","ssh_url":"git@github.com:billybonks/atom.git","clone_url":"https://github.com/billybonks/atom.git","svn_url":"https://github.com/billybonks/atom","homepage":"https://atom.io","size":275166,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"7bcdc9ab519af195856b0c9c0706454b52288967","user":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":3228505,"name":"atom","full_name":"atom/atom","owner":{"login":"atom","id":1089146,"avatar_url":"https://avatars.githubusercontent.com/u/1089146?v=3","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/atom","description":"The hackable text editor","fork":false,"url":"https://api.github.com/repos/atom/atom","forks_url":"https://api.github.com/repos/atom/atom/forks","keys_url":"https://api.github.com/repos/atom/atom/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/atom/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/atom/teams","hooks_url":"https://api.github.com/repos/atom/atom/hooks","issue_events_url":"https://api.github.com/repos/atom/atom/issues/events{/number}","events_url":"https://api.github.com/repos/atom/atom/events","assignees_url":"https://api.github.com/repos/atom/atom/assignees{/user}","branches_url":"https://api.github.com/repos/atom/atom/branches{/branch}","tags_url":"https://api.github.com/repos/atom/atom/tags","blobs_url":"https://api.github.com/repos/atom/atom/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/atom/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/atom/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/atom/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/atom/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/atom/languages","stargazers_url":"https://api.github.com/repos/atom/atom/stargazers","contributors_url":"https://api.github.com/repos/atom/atom/contributors","subscribers_url":"https://api.github.com/repos/atom/atom/subscribers","subscription_url":"https://api.github.com/repos/atom/atom/subscription","commits_url":"https://api.github.com/repos/atom/atom/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/atom/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/atom/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/atom/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/atom/contents/{+path}","compare_url":"https://api.github.com/repos/atom/atom/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/atom/merges","archive_url":"https://api.github.com/repos/atom/atom/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/atom/downloads","issues_url":"https://api.github.com/repos/atom/atom/issues{/number}","pulls_url":"https://api.github.com/repos/atom/atom/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/atom/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/atom/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/atom/labels{/name}","releases_url":"https://api.github.com/repos/atom/atom/releases{/id}","created_at":"2012-01-20T18:18:21Z","updated_at":"2015-11-10T21:34:52Z","pushed_at":"2015-11-10T22:00:07Z","git_url":"git://github.com/atom/atom.git","ssh_url":"git@github.com:atom/atom.git","clone_url":"https://github.com/atom/atom.git","svn_url":"https://github.com/atom/atom","homepage":"https://atom.io","size":406952,"stargazers_count":21628,"watchers_count":21628,"language":"CoffeeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3689,"mirror_url":null,"open_issues_count":1497,"forks":3689,"open_issues":1497,"watchers":21628,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/atom/pulls/9070"},"html":{"href":"https://github.com/atom/atom/pull/9070"},"issue":{"href":"https://api.github.com/repos/atom/atom/issues/9070"},"comments":{"href":"https://api.github.com/repos/atom/atom/issues/9070/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/atom/pulls/9070/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/atom/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/atom/pulls/9070/commits"},"statuses":{"href":"https://api.github.com/repos/atom/atom/statuses/292f8e4cc246205e84b7d6e18488623a75f9b135"}}}}