{"action":"reopened","number":17306,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17306","id":50768554,"html_url":"https://github.com/kubernetes/kubernetes/pull/17306","diff_url":"https://github.com/kubernetes/kubernetes/pull/17306.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/17306.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17306","number":17306,"state":"open","locked":false,"title":"Fix pod eviction time in node controller when node becomes unavailable","user":{"login":"combk8s","id":14832600,"avatar_url":"https://avatars.githubusercontent.com/u/14832600?v=3","gravatar_id":"","url":"https://api.github.com/users/combk8s","html_url":"https://github.com/combk8s","followers_url":"https://api.github.com/users/combk8s/followers","following_url":"https://api.github.com/users/combk8s/following{/other_user}","gists_url":"https://api.github.com/users/combk8s/gists{/gist_id}","starred_url":"https://api.github.com/users/combk8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combk8s/subscriptions","organizations_url":"https://api.github.com/users/combk8s/orgs","repos_url":"https://api.github.com/users/combk8s/repos","events_url":"https://api.github.com/users/combk8s/events{/privacy}","received_events_url":"https://api.github.com/users/combk8s/received_events","type":"User","site_admin":false},"body":"When a node becomes unavailable, we use this statement to determine whether evict all pod on this node:\r\n\r\nhttps://github.com/kubernetes/kubernetes/blob/master/pkg/controller/node/nodecontroller.go#L417\r\n\r\nIs this correct? I think we should use \r\n\r\n`decisionTimestamp.After(node.probeTimestamp.Add(nc.podEvictionTimeout)`\r\ninstead of \r\n`decisionTimestamp.After(node.probeTimestamp.Add(nc.podEvictionTimeout - gracePeriod)`\r\nsince we use `node.probeTimestamp`, not `node.readyTransitionTimestamp`. \r\n\r\nFor example, 8:00:00 is the last probe time when everything is in order, after 8:00:00, kubelet stop posting it's condition, node becomes unavailable, node controller ***should*** work like this when use default configuration:\r\n\r\n8:00:00  &nbsp;&nbsp; ***last probe time***, every thing is in order\r\n8:00:05  &nbsp;&nbsp; node controller observes that kubelet has stoped posting it's condition, node maybe unavailable\r\n...\r\n8:00:40  &nbsp;&nbsp; grace-period timeout, node controller update `node.condition.status` to `Unknown`, 8:00:40 is the ***readyTransitionTimestamp***\r\n8:05:00  &nbsp;&nbsp; pod-eviction-timeout, delete all pods on the node\r\n\r\nHowerve, when use `nc.podEvictionTimeout - gracePeriod`, at ***8:04:20*** pods will be evicted!  \r\n\r\nWe should use `nc.podEvictionTimeout` if we want evicted pods at 8:05:00(5m after last probe time) or `nc.podEvictionTimeout + gracePeriod` if we want evicted pods at 8:05:40(5m after transition time)","created_at":"2015-11-16T03:44:12Z","updated_at":"2015-11-18T09:18:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cd478ba7888d068fab508cd5f4df742b42d48c7","assignee":{"login":"fgrzadkowski","id":10820726,"avatar_url":"https://avatars.githubusercontent.com/u/10820726?v=3","gravatar_id":"","url":"https://api.github.com/users/fgrzadkowski","html_url":"https://github.com/fgrzadkowski","followers_url":"https://api.github.com/users/fgrzadkowski/followers","following_url":"https://api.github.com/users/fgrzadkowski/following{/other_user}","gists_url":"https://api.github.com/users/fgrzadkowski/gists{/gist_id}","starred_url":"https://api.github.com/users/fgrzadkowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgrzadkowski/subscriptions","organizations_url":"https://api.github.com/users/fgrzadkowski/orgs","repos_url":"https://api.github.com/users/fgrzadkowski/repos","events_url":"https://api.github.com/users/fgrzadkowski/events{/privacy}","received_events_url":"https://api.github.com/users/fgrzadkowski/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17306/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17306/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/17306/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b1b21ee285d5a492ac9a4368657b41e61711f108","head":{"label":"combk8s:patch-1","ref":"patch-1","sha":"b1b21ee285d5a492ac9a4368657b41e61711f108","user":{"login":"combk8s","id":14832600,"avatar_url":"https://avatars.githubusercontent.com/u/14832600?v=3","gravatar_id":"","url":"https://api.github.com/users/combk8s","html_url":"https://github.com/combk8s","followers_url":"https://api.github.com/users/combk8s/followers","following_url":"https://api.github.com/users/combk8s/following{/other_user}","gists_url":"https://api.github.com/users/combk8s/gists{/gist_id}","starred_url":"https://api.github.com/users/combk8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combk8s/subscriptions","organizations_url":"https://api.github.com/users/combk8s/orgs","repos_url":"https://api.github.com/users/combk8s/repos","events_url":"https://api.github.com/users/combk8s/events{/privacy}","received_events_url":"https://api.github.com/users/combk8s/received_events","type":"User","site_admin":false},"repo":{"id":43129732,"name":"kubernetes","full_name":"combk8s/kubernetes","owner":{"login":"combk8s","id":14832600,"avatar_url":"https://avatars.githubusercontent.com/u/14832600?v=3","gravatar_id":"","url":"https://api.github.com/users/combk8s","html_url":"https://github.com/combk8s","followers_url":"https://api.github.com/users/combk8s/followers","following_url":"https://api.github.com/users/combk8s/following{/other_user}","gists_url":"https://api.github.com/users/combk8s/gists{/gist_id}","starred_url":"https://api.github.com/users/combk8s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/combk8s/subscriptions","organizations_url":"https://api.github.com/users/combk8s/orgs","repos_url":"https://api.github.com/users/combk8s/repos","events_url":"https://api.github.com/users/combk8s/events{/privacy}","received_events_url":"https://api.github.com/users/combk8s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/combk8s/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/combk8s/kubernetes","forks_url":"https://api.github.com/repos/combk8s/kubernetes/forks","keys_url":"https://api.github.com/repos/combk8s/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/combk8s/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/combk8s/kubernetes/teams","hooks_url":"https://api.github.com/repos/combk8s/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/combk8s/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/combk8s/kubernetes/events","assignees_url":"https://api.github.com/repos/combk8s/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/combk8s/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/combk8s/kubernetes/tags","blobs_url":"https://api.github.com/repos/combk8s/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/combk8s/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/combk8s/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/combk8s/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/combk8s/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/combk8s/kubernetes/languages","stargazers_url":"https://api.github.com/repos/combk8s/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/combk8s/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/combk8s/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/combk8s/kubernetes/subscription","commits_url":"https://api.github.com/repos/combk8s/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/combk8s/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/combk8s/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/combk8s/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/combk8s/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/combk8s/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/combk8s/kubernetes/merges","archive_url":"https://api.github.com/repos/combk8s/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/combk8s/kubernetes/downloads","issues_url":"https://api.github.com/repos/combk8s/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/combk8s/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/combk8s/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/combk8s/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/combk8s/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/combk8s/kubernetes/releases{/id}","created_at":"2015-09-25T09:54:55Z","updated_at":"2015-09-25T09:55:12Z","pushed_at":"2015-11-18T08:27:40Z","git_url":"git://github.com/combk8s/kubernetes.git","ssh_url":"git@github.com:combk8s/kubernetes.git","clone_url":"https://github.com/combk8s/kubernetes.git","svn_url":"https://github.com/combk8s/kubernetes","homepage":"http://kubernetes.io","size":135029,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"96ae38c03654bb401a703209c190c60091444c54","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Container Cluster Manager from Google","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","created_at":"2014-06-06T22:56:04Z","updated_at":"2015-11-18T08:41:00Z","pushed_at":"2015-11-18T09:07:47Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":287649,"stargazers_count":11316,"watchers_count":11316,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2983,"mirror_url":null,"open_issues_count":2335,"forks":2983,"open_issues":2335,"watchers":11316,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17306"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/17306"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17306"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/17306/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17306/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/17306/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/b1b21ee285d5a492ac9a4368657b41e61711f108"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":8,"review_comments":0,"commits":1,"additions":1,"deletions":1,"changed_files":1}}