{"action":"created","comment":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/comments/33005361","id":33005361,"diff_hunk":"@@ -48,6 +48,15 @@ $ActionSendStreamDriverAuthMode x509/name # authenticate by hostname\n $ActionSendStreamDriverPermittedPeer <%= @permitted_peer %>\n <% end -%>\n \n+# File permissions\n+\n+<% if @umask %>","path":"templates/rsyslog.conf.erb","position":6,"original_position":6,"commit_id":"14b201bd345f0f1311987ef7bc15643296f0a6b0","original_commit_id":"14b201bd345f0f1311987ef7bc15643296f0a6b0","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"body":"need the `-` so that there aren't a bunch of blank lines added\r\n\r\nso \r\n\r\n``` erb\r\n<% if @umask -%>\r\n```\r\n\r\nand\r\n\r\n``` erb\r\n<% end -%>\r\n```","created_at":"2015-06-23T02:48:54Z","updated_at":"2015-06-23T02:48:54Z","html_url":"https://github.com/ghoneycutt/puppet-module-rsyslog/pull/79#discussion_r33005361","pull_request_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/comments/33005361"},"html":{"href":"https://github.com/ghoneycutt/puppet-module-rsyslog/pull/79#discussion_r33005361"},"pull_request":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79","id":38260426,"html_url":"https://github.com/ghoneycutt/puppet-module-rsyslog/pull/79","diff_url":"https://github.com/ghoneycutt/puppet-module-rsyslog/pull/79.diff","patch_url":"https://github.com/ghoneycutt/puppet-module-rsyslog/pull/79.patch","issue_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues/79","number":79,"state":"open","locked":false,"title":"Added file and dir create modes","user":{"login":"CMartinUdden","id":1866741,"avatar_url":"https://avatars.githubusercontent.com/u/1866741?v=3","gravatar_id":"","url":"https://api.github.com/users/CMartinUdden","html_url":"https://github.com/CMartinUdden","followers_url":"https://api.github.com/users/CMartinUdden/followers","following_url":"https://api.github.com/users/CMartinUdden/following{/other_user}","gists_url":"https://api.github.com/users/CMartinUdden/gists{/gist_id}","starred_url":"https://api.github.com/users/CMartinUdden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMartinUdden/subscriptions","organizations_url":"https://api.github.com/users/CMartinUdden/orgs","repos_url":"https://api.github.com/users/CMartinUdden/repos","events_url":"https://api.github.com/users/CMartinUdden/events{/privacy}","received_events_url":"https://api.github.com/users/CMartinUdden/received_events","type":"User","site_admin":false},"body":"New Topic branch, added validation and documentation per\r\n\r\nhttp://www.rsyslog.com/doc/rsconf1_umask.html\r\nhttp://www.rsyslog.com/doc/rsconf1_filecreatemode.html\r\nand\r\nhttp://www.rsyslog.com/doc/rsconf1_dircreatemode.html\r\n\r\nAlso updated spec tests, though they seem to be failing due to wrong(?) rspec version.","created_at":"2015-06-22T18:21:01Z","updated_at":"2015-06-23T02:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7a859d74eba395fdc8936d3cc8688e8fddedb66","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79/commits","review_comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79/comments","review_comment_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues/79/comments","statuses_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/statuses/14b201bd345f0f1311987ef7bc15643296f0a6b0","head":{"label":"CMartinUdden:filemodes","ref":"filemodes","sha":"14b201bd345f0f1311987ef7bc15643296f0a6b0","user":{"login":"CMartinUdden","id":1866741,"avatar_url":"https://avatars.githubusercontent.com/u/1866741?v=3","gravatar_id":"","url":"https://api.github.com/users/CMartinUdden","html_url":"https://github.com/CMartinUdden","followers_url":"https://api.github.com/users/CMartinUdden/followers","following_url":"https://api.github.com/users/CMartinUdden/following{/other_user}","gists_url":"https://api.github.com/users/CMartinUdden/gists{/gist_id}","starred_url":"https://api.github.com/users/CMartinUdden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMartinUdden/subscriptions","organizations_url":"https://api.github.com/users/CMartinUdden/orgs","repos_url":"https://api.github.com/users/CMartinUdden/repos","events_url":"https://api.github.com/users/CMartinUdden/events{/privacy}","received_events_url":"https://api.github.com/users/CMartinUdden/received_events","type":"User","site_admin":false},"repo":{"id":37522726,"name":"puppet-module-rsyslog","full_name":"CMartinUdden/puppet-module-rsyslog","owner":{"login":"CMartinUdden","id":1866741,"avatar_url":"https://avatars.githubusercontent.com/u/1866741?v=3","gravatar_id":"","url":"https://api.github.com/users/CMartinUdden","html_url":"https://github.com/CMartinUdden","followers_url":"https://api.github.com/users/CMartinUdden/followers","following_url":"https://api.github.com/users/CMartinUdden/following{/other_user}","gists_url":"https://api.github.com/users/CMartinUdden/gists{/gist_id}","starred_url":"https://api.github.com/users/CMartinUdden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CMartinUdden/subscriptions","organizations_url":"https://api.github.com/users/CMartinUdden/orgs","repos_url":"https://api.github.com/users/CMartinUdden/repos","events_url":"https://api.github.com/users/CMartinUdden/events{/privacy}","received_events_url":"https://api.github.com/users/CMartinUdden/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CMartinUdden/puppet-module-rsyslog","description":"Puppet module to manage rsyslog","fork":true,"url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog","forks_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/forks","keys_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/teams","hooks_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/hooks","issue_events_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/issues/events{/number}","events_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/events","assignees_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/assignees{/user}","branches_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/branches{/branch}","tags_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/tags","blobs_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/statuses/{sha}","languages_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/languages","stargazers_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/stargazers","contributors_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/contributors","subscribers_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/subscribers","subscription_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/subscription","commits_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/contents/{+path}","compare_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/merges","archive_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/downloads","issues_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/issues{/number}","pulls_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/pulls{/number}","milestones_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/milestones{/number}","notifications_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/labels{/name}","releases_url":"https://api.github.com/repos/CMartinUdden/puppet-module-rsyslog/releases{/id}","created_at":"2015-06-16T10:09:01Z","updated_at":"2015-06-16T10:09:02Z","pushed_at":"2015-06-23T00:25:03Z","git_url":"git://github.com/CMartinUdden/puppet-module-rsyslog.git","ssh_url":"git@github.com:CMartinUdden/puppet-module-rsyslog.git","clone_url":"https://github.com/CMartinUdden/puppet-module-rsyslog.git","svn_url":"https://github.com/CMartinUdden/puppet-module-rsyslog","homepage":null,"size":1151,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ghoneycutt:master","ref":"master","sha":"ac77e143ea603568641be1c575b8e708edcec948","user":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"repo":{"id":10195616,"name":"puppet-module-rsyslog","full_name":"ghoneycutt/puppet-module-rsyslog","owner":{"login":"ghoneycutt","id":313891,"avatar_url":"https://avatars.githubusercontent.com/u/313891?v=3","gravatar_id":"","url":"https://api.github.com/users/ghoneycutt","html_url":"https://github.com/ghoneycutt","followers_url":"https://api.github.com/users/ghoneycutt/followers","following_url":"https://api.github.com/users/ghoneycutt/following{/other_user}","gists_url":"https://api.github.com/users/ghoneycutt/gists{/gist_id}","starred_url":"https://api.github.com/users/ghoneycutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ghoneycutt/subscriptions","organizations_url":"https://api.github.com/users/ghoneycutt/orgs","repos_url":"https://api.github.com/users/ghoneycutt/repos","events_url":"https://api.github.com/users/ghoneycutt/events{/privacy}","received_events_url":"https://api.github.com/users/ghoneycutt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ghoneycutt/puppet-module-rsyslog","description":"Puppet module to manage rsyslog","fork":false,"url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog","forks_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/forks","keys_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/teams","hooks_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/hooks","issue_events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues/events{/number}","events_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/events","assignees_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/assignees{/user}","branches_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/branches{/branch}","tags_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/tags","blobs_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/git/refs{/sha}","trees_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/statuses/{sha}","languages_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/languages","stargazers_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/stargazers","contributors_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/contributors","subscribers_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/subscribers","subscription_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/subscription","commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/commits{/sha}","git_commits_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/git/commits{/sha}","comments_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/comments{/number}","issue_comment_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues/comments{/number}","contents_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/contents/{+path}","compare_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/merges","archive_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/downloads","issues_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues{/number}","pulls_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls{/number}","milestones_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/milestones{/number}","notifications_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/labels{/name}","releases_url":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/releases{/id}","created_at":"2013-05-21T13:00:18Z","updated_at":"2015-04-16T17:53:12Z","pushed_at":"2015-06-23T00:25:04Z","git_url":"git://github.com/ghoneycutt/puppet-module-rsyslog.git","ssh_url":"git@github.com:ghoneycutt/puppet-module-rsyslog.git","clone_url":"https://github.com/ghoneycutt/puppet-module-rsyslog.git","svn_url":"https://github.com/ghoneycutt/puppet-module-rsyslog","homepage":null,"size":1151,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":9,"forks":25,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79"},"html":{"href":"https://github.com/ghoneycutt/puppet-module-rsyslog/pull/79"},"issue":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues/79"},"comments":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/ghoneycutt/puppet-module-rsyslog/statuses/14b201bd345f0f1311987ef7bc15643296f0a6b0"}}}}