{"action":"created","issue":{"url":"https://api.github.com/repos/fraywing/textAngular/issues/760","labels_url":"https://api.github.com/repos/fraywing/textAngular/issues/760/labels{/name}","comments_url":"https://api.github.com/repos/fraywing/textAngular/issues/760/comments","events_url":"https://api.github.com/repos/fraywing/textAngular/issues/760/events","html_url":"https://github.com/fraywing/textAngular/pull/760","id":90522732,"number":760,"title":"feature(commonjs): add support for commonjs","user":{"login":"aaronroberson","id":440189,"avatar_url":"https://avatars.githubusercontent.com/u/440189?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronroberson","html_url":"https://github.com/aaronroberson","followers_url":"https://api.github.com/users/aaronroberson/followers","following_url":"https://api.github.com/users/aaronroberson/following{/other_user}","gists_url":"https://api.github.com/users/aaronroberson/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronroberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronroberson/subscriptions","organizations_url":"https://api.github.com/users/aaronroberson/orgs","repos_url":"https://api.github.com/users/aaronroberson/repos","events_url":"https://api.github.com/users/aaronroberson/events{/privacy}","received_events_url":"https://api.github.com/users/aaronroberson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-06-24T00:05:40Z","updated_at":"2015-07-03T00:18:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/fraywing/textAngular/pulls/760","html_url":"https://github.com/fraywing/textAngular/pull/760","diff_url":"https://github.com/fraywing/textAngular/pull/760.diff","patch_url":"https://github.com/fraywing/textAngular/pull/760.patch"},"body":"Version 1.4.1 introduced a lot of headaches for developers using Webpack and Browserify. This commit adds support for commonjs via module.exports and define.\r\n\r\nCloses #737\r\nCloses #712 \r\nCloses #713 \r\nCloses #716\r\nCloses #708 \r\nCloses #709"},"comment":{"url":"https://api.github.com/repos/fraywing/textAngular/issues/comments/118200642","html_url":"https://github.com/fraywing/textAngular/pull/760#issuecomment-118200642","issue_url":"https://api.github.com/repos/fraywing/textAngular/issues/760","id":118200642,"user":{"login":"aaronroberson","id":440189,"avatar_url":"https://avatars.githubusercontent.com/u/440189?v=3","gravatar_id":"","url":"https://api.github.com/users/aaronroberson","html_url":"https://github.com/aaronroberson","followers_url":"https://api.github.com/users/aaronroberson/followers","following_url":"https://api.github.com/users/aaronroberson/following{/other_user}","gists_url":"https://api.github.com/users/aaronroberson/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronroberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronroberson/subscriptions","organizations_url":"https://api.github.com/users/aaronroberson/orgs","repos_url":"https://api.github.com/users/aaronroberson/repos","events_url":"https://api.github.com/users/aaronroberson/events{/privacy}","received_events_url":"https://api.github.com/users/aaronroberson/received_events","type":"User","site_admin":false},"created_at":"2015-07-03T00:18:34Z","updated_at":"2015-07-03T00:18:34Z","body":"I'm using webpack and was not able to verify the AMD piece. I suspect you\ncan improve the define block.\n\nOn Thu, Jul 2, 2015, 10:46 AM nicole chung <notifications@github.com> wrote:\n\n> With this part:\n>\n> if (typeof define === 'function' && define.amd) {\n> +        // AMD. Register as an anonymous module.\n> define(function(require) {\n>    window.rangy = require('rangy');\n>    window.rangy.saveSelection = require('rangy/lib/rangy-selectionsaverestore');\n> });\n>\n> The lines window.rangy = ... never run for me. And I have a \"defined\" and\n> \"required\" as defined functions?\n>\n> —\n> Reply to this email directly or view it on GitHub\n> <https://github.com/fraywing/textAngular/pull/760#issuecomment-118108068>.\n>\n"}}