{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/41324456","id":41324456,"diff_hunk":"@@ -63,14 +64,24 @@ func (b *Layered) CreateDockerfile(config *api.Config) error {\n \t}\n \n \tbuffer.WriteString(fmt.Sprintf(\"FROM %s\\n\", b.config.BuilderImage))\n-\tbuffer.WriteString(fmt.Sprintf(\"COPY scripts %s\\n\", locations[0]))\n+\t// if -s / --scripts / --scripts-url are not specified, there will not be a scripts subdir\n+\t// off of the working dir, so don't copy here, and we'll have to tweak the scripts URL to use the env var\n+\t// STI_SCRIPTS_PATH\n+\tscriptsIncluded := len(config.ScriptsURL) > 0","path":"pkg/build/strategies/layered/layered.go","position":16,"original_position":16,"commit_id":"e84aedc17956d5dc11a3e43adf0b3ceecee4f92c","original_commit_id":"e84aedc17956d5dc11a3e43adf0b3ceecee4f92c","user":{"login":"bparees","id":4974046,"avatar_url":"https://avatars.githubusercontent.com/u/4974046?v=3","gravatar_id":"","url":"https://api.github.com/users/bparees","html_url":"https://github.com/bparees","followers_url":"https://api.github.com/users/bparees/followers","following_url":"https://api.github.com/users/bparees/following{/other_user}","gists_url":"https://api.github.com/users/bparees/gists{/gist_id}","starred_url":"https://api.github.com/users/bparees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bparees/subscriptions","organizations_url":"https://api.github.com/users/bparees/orgs","repos_url":"https://api.github.com/users/bparees/repos","events_url":"https://api.github.com/users/bparees/events{/privacy}","received_events_url":"https://api.github.com/users/bparees/received_events","type":"User","site_admin":false},"body":"actually there is also a 3) scripts are included in the image at some other path and user specified --scriptsUrl image://some/path/in/the/image\r\n\r\nwhich i suspect is also not handled by this change?\r\n","created_at":"2015-10-06T21:24:00Z","updated_at":"2015-10-06T21:24:00Z","html_url":"https://github.com/openshift/source-to-image/pull/302#discussion_r41324456","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/302","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/41324456"},"html":{"href":"https://github.com/openshift/source-to-image/pull/302#discussion_r41324456"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/302"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/302","id":46936239,"html_url":"https://github.com/openshift/source-to-image/pull/302","diff_url":"https://github.com/openshift/source-to-image/pull/302.diff","patch_url":"https://github.com/openshift/source-to-image/pull/302.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/302","number":302,"state":"open","locked":false,"title":"avoid scripts copy, fix scripts location, when no tar and no --script…","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"…s-url, update unit tests accordingly\r\n\r\n@bparees @mfojtik gentlemen, here is my PR for the no tar / no scripts specified bugzilla item test found.\r\n\r\n@bparees - quick reminder: turns out, even test was going down the layered path, so no updates to the error parsing were needed to make things work;  I left things as is, but of course, if you think we still ought to switch simply looking at the error code, I can change accordingly.\r\n\r\nthanks","created_at":"2015-10-06T18:00:16Z","updated_at":"2015-10-06T21:24:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ffbbbdc5799ac6b9368b7caacdfce9eb6251328d","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/302/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/302/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/302/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/e84aedc17956d5dc11a3e43adf0b3ceecee4f92c","head":{"label":"gabemontero:bugzilla1261117","ref":"bugzilla1261117","sha":"e84aedc17956d5dc11a3e43adf0b3ceecee4f92c","user":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":36944033,"name":"source-to-image","full_name":"gabemontero/source-to-image","owner":{"login":"gabemontero","id":3594868,"avatar_url":"https://avatars.githubusercontent.com/u/3594868?v=3","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gabemontero/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/gabemontero/source-to-image","forks_url":"https://api.github.com/repos/gabemontero/source-to-image/forks","keys_url":"https://api.github.com/repos/gabemontero/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/source-to-image/teams","hooks_url":"https://api.github.com/repos/gabemontero/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/source-to-image/events","assignees_url":"https://api.github.com/repos/gabemontero/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/source-to-image/tags","blobs_url":"https://api.github.com/repos/gabemontero/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/source-to-image/languages","stargazers_url":"https://api.github.com/repos/gabemontero/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/source-to-image/subscription","commits_url":"https://api.github.com/repos/gabemontero/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/source-to-image/merges","archive_url":"https://api.github.com/repos/gabemontero/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/source-to-image/downloads","issues_url":"https://api.github.com/repos/gabemontero/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/source-to-image/releases{/id}","created_at":"2015-06-05T16:49:12Z","updated_at":"2015-06-05T16:49:12Z","pushed_at":"2015-10-06T18:22:06Z","git_url":"git://github.com/gabemontero/source-to-image.git","ssh_url":"git@github.com:gabemontero/source-to-image.git","clone_url":"https://github.com/gabemontero/source-to-image.git","svn_url":"https://github.com/gabemontero/source-to-image","homepage":"","size":1339,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"e56d6e51ecfdb6ece880f362fa4f7a6954582230","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","created_at":"2014-01-28T19:32:40Z","updated_at":"2015-10-02T16:10:01Z","pushed_at":"2015-10-06T18:22:07Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":2597,"stargazers_count":130,"watchers_count":130,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":20,"forks":60,"open_issues":20,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/302"},"html":{"href":"https://github.com/openshift/source-to-image/pull/302"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/302"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/e84aedc17956d5dc11a3e43adf0b3ceecee4f92c"}}}}