{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/2626","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2626/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2626/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2626/events","html_url":"https://github.com/mne-tools/mne-python/pull/2626","id":117799841,"number":2626,"title":"[WIP] Test refactoring","user":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/7","html_url":"https://github.com/mne-tools/mne-python/milestones/0.11","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/7/labels","id":1288558,"number":7,"title":"0.11","description":"","creator":{"login":"dengemann","id":1908618,"avatar_url":"https://avatars.githubusercontent.com/u/1908618?v=3","gravatar_id":"","url":"https://api.github.com/users/dengemann","html_url":"https://github.com/dengemann","followers_url":"https://api.github.com/users/dengemann/followers","following_url":"https://api.github.com/users/dengemann/following{/other_user}","gists_url":"https://api.github.com/users/dengemann/gists{/gist_id}","starred_url":"https://api.github.com/users/dengemann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dengemann/subscriptions","organizations_url":"https://api.github.com/users/dengemann/orgs","repos_url":"https://api.github.com/users/dengemann/repos","events_url":"https://api.github.com/users/dengemann/events{/privacy}","received_events_url":"https://api.github.com/users/dengemann/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":16,"state":"open","created_at":"2015-09-03T15:20:08Z","updated_at":"2015-11-30T21:23:01Z","due_on":"2015-12-18T05:00:00Z","closed_at":null},"comments":51,"created_at":"2015-11-19T12:04:08Z","updated_at":"2015-12-01T15:23:14Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/2626","html_url":"https://github.com/mne-tools/mne-python/pull/2626","diff_url":"https://github.com/mne-tools/mne-python/pull/2626.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/2626.patch"},"body":"Closes https://github.com/mne-tools/mne-python/issues/2151.\r\nI made a function for testing different kind of readers. The filtering precision probably depends on the data a lot, so I'm not sure if it should be included here or tested separately for each reader. What do you think? For now it is implemented only for nicolet reader, but I will implement for others too once we have tuned this and if you think it's useful.\r\n\r\nAlso included a small optimization for ``test_epochs``."},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/160999947","html_url":"https://github.com/mne-tools/mne-python/pull/2626#issuecomment-160999947","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/2626","id":160999947,"user":{"login":"jaeilepp","id":3456414,"avatar_url":"https://avatars.githubusercontent.com/u/3456414?v=3","gravatar_id":"","url":"https://api.github.com/users/jaeilepp","html_url":"https://github.com/jaeilepp","followers_url":"https://api.github.com/users/jaeilepp/followers","following_url":"https://api.github.com/users/jaeilepp/following{/other_user}","gists_url":"https://api.github.com/users/jaeilepp/gists{/gist_id}","starred_url":"https://api.github.com/users/jaeilepp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaeilepp/subscriptions","organizations_url":"https://api.github.com/users/jaeilepp/orgs","repos_url":"https://api.github.com/users/jaeilepp/repos","events_url":"https://api.github.com/users/jaeilepp/events{/privacy}","received_events_url":"https://api.github.com/users/jaeilepp/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T15:23:14Z","updated_at":"2015-12-01T15:23:14Z","body":"I'm not sure the CTF tests are refactorable without increasing the test times considerably, since the tested data is a bit different. \r\n\r\n@Eric89GXL check out lines 89-90 in ``test_ctf``. I think there is a typo of some sort. ``use_fnames`` is reinitialised right after declaration."}}