{"action":"created","issue":{"url":"https://api.github.com/repos/mumble-voip/mumble/issues/1900","labels_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1900/labels{/name}","comments_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1900/comments","events_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1900/events","html_url":"https://github.com/mumble-voip/mumble/pull/1900","id":117461024,"number":1900,"title":"Improve OSS device closing","user":{"login":"feld","id":1686547,"avatar_url":"https://avatars.githubusercontent.com/u/1686547?v=3","gravatar_id":"","url":"https://api.github.com/users/feld","html_url":"https://github.com/feld","followers_url":"https://api.github.com/users/feld/followers","following_url":"https://api.github.com/users/feld/following{/other_user}","gists_url":"https://api.github.com/users/feld/gists{/gist_id}","starred_url":"https://api.github.com/users/feld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feld/subscriptions","organizations_url":"https://api.github.com/users/feld/orgs","repos_url":"https://api.github.com/users/feld/repos","events_url":"https://api.github.com/users/feld/events{/privacy}","received_events_url":"https://api.github.com/users/feld/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-11-17T22:00:34Z","updated_at":"2015-11-18T17:55:37Z","closed_at":"2015-11-18T17:55:37Z","pull_request":{"url":"https://api.github.com/repos/mumble-voip/mumble/pulls/1900","html_url":"https://github.com/mumble-voip/mumble/pull/1900","diff_url":"https://github.com/mumble-voip/mumble/pull/1900.diff","patch_url":"https://github.com/mumble-voip/mumble/pull/1900.patch"},"body":"FreeBSD ports has been carrying this patch for two years now. I can't\r\nlocate the specific details and my commit message failed to give details\r\non this patch, but FreeBSD is probably the primary OSS audio backend\r\nconsumer for Mumble. This fix improved interaction with the OSS devices.\r\n\r\nI think the original author *really* hated the use of goto because it could have been preserved with just the addition of the return. I can't say I hold a religious stance on it."},"comment":{"url":"https://api.github.com/repos/mumble-voip/mumble/issues/comments/157801455","html_url":"https://github.com/mumble-voip/mumble/pull/1900#issuecomment-157801455","issue_url":"https://api.github.com/repos/mumble-voip/mumble/issues/1900","id":157801455,"user":{"login":"feld","id":1686547,"avatar_url":"https://avatars.githubusercontent.com/u/1686547?v=3","gravatar_id":"","url":"https://api.github.com/users/feld","html_url":"https://github.com/feld","followers_url":"https://api.github.com/users/feld/followers","following_url":"https://api.github.com/users/feld/following{/other_user}","gists_url":"https://api.github.com/users/feld/gists{/gist_id}","starred_url":"https://api.github.com/users/feld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feld/subscriptions","organizations_url":"https://api.github.com/users/feld/orgs","repos_url":"https://api.github.com/users/feld/repos","events_url":"https://api.github.com/users/feld/events{/privacy}","received_events_url":"https://api.github.com/users/feld/received_events","type":"User","site_admin":false},"created_at":"2015-11-18T17:55:37Z","updated_at":"2015-11-18T17:55:37Z","body":"Fair enough. I'll close this. If i can find any issues without this patch I'll let you know."}}