{"action":"created","comment":{"url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/comments/38967368","id":38967368,"diff_hunk":"@@ -0,0 +1,140 @@\n+<?php\n+\n+/**\n+ * @file\n+ * Contains Drupal\\encrypt\\Form\\EncryptionConfigurationForm.\n+ */\n+\n+namespace Drupal\\encrypt\\Form;\n+\n+use Drupal\\Core\\Config\\ConfigFactoryInterface;\n+use Drupal\\Core\\Entity\\EntityForm;\n+use Drupal\\Core\\Form\\FormStateInterface;\n+use Drupal\\encrypt\\EncryptService;\n+use Drupal\\key\\KeyManager;\n+use Symfony\\Component\\DependencyInjection\\ContainerInterface;\n+\n+/**\n+ * Class EncryptionConfigurationForm.\n+ *\n+ * @package Drupal\\encrypt\\Form\n+ */\n+class EncryptionConfigurationForm extends EntityForm {\n+\n+  /**\n+   * KeyManager definition.\n+   *\n+   * @var \\Drupal\\key\\KeyManager\n+   */\n+  protected $key_manager;\n+\n+  /**\n+   * EncryptService definition.\n+   *\n+   * @var \\Drupal\\encrypt\\EncryptService\n+   */\n+  protected $encrypt_service;\n+\n+  /**\n+   * Constructs a EncryptionConfigurationForm object.\n+   *\n+   * @param \\Drupal\\Core\\Config\\ConfigFactoryInterface $config_factory\n+   *   The config factory.\n+   * @param \\Drupal\\Key\\KeyManager $key_manager\n+   *   The ConditionManager for building the visibility UI.\n+   * @param \\Drupal\\Encrypt\\EncryptService $encrypt_service\n+   *   The lazy context repository service.\n+   */\n+  public function __construct(ConfigFactoryInterface $config_factory, KeyManager $key_manager, EncryptService $encrypt_service) {","path":"src/Form/EncryptionConfigurationForm.php","position":48,"original_position":48,"commit_id":"982fb3d6f3b1f8f7846bb797bd842fe826b528a6","original_commit_id":"982fb3d6f3b1f8f7846bb797bd842fe826b528a6","user":{"login":"doylejd","id":6324307,"avatar_url":"https://avatars.githubusercontent.com/u/6324307?v=3","gravatar_id":"","url":"https://api.github.com/users/doylejd","html_url":"https://github.com/doylejd","followers_url":"https://api.github.com/users/doylejd/followers","following_url":"https://api.github.com/users/doylejd/following{/other_user}","gists_url":"https://api.github.com/users/doylejd/gists{/gist_id}","starred_url":"https://api.github.com/users/doylejd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doylejd/subscriptions","organizations_url":"https://api.github.com/users/doylejd/orgs","repos_url":"https://api.github.com/users/doylejd/repos","events_url":"https://api.github.com/users/doylejd/events{/privacy}","received_events_url":"https://api.github.com/users/doylejd/received_events","type":"User","site_admin":false},"body":"Is $config_factory being used here? If not, can we remove it?","created_at":"2015-09-08T19:14:00Z","updated_at":"2015-09-08T19:14:00Z","html_url":"https://github.com/d8-contrib-modules/encrypt/pull/48#discussion_r38967368","pull_request_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48","_links":{"self":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/comments/38967368"},"html":{"href":"https://github.com/d8-contrib-modules/encrypt/pull/48#discussion_r38967368"},"pull_request":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48","id":44293592,"html_url":"https://github.com/d8-contrib-modules/encrypt/pull/48","diff_url":"https://github.com/d8-contrib-modules/encrypt/pull/48.diff","patch_url":"https://github.com/d8-contrib-modules/encrypt/pull/48.patch","issue_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/48","number":48,"state":"open","locked":false,"title":"Instance manager","user":{"login":"nerdstein","id":966547,"avatar_url":"https://avatars.githubusercontent.com/u/966547?v=3","gravatar_id":"","url":"https://api.github.com/users/nerdstein","html_url":"https://github.com/nerdstein","followers_url":"https://api.github.com/users/nerdstein/followers","following_url":"https://api.github.com/users/nerdstein/following{/other_user}","gists_url":"https://api.github.com/users/nerdstein/gists{/gist_id}","starred_url":"https://api.github.com/users/nerdstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerdstein/subscriptions","organizations_url":"https://api.github.com/users/nerdstein/orgs","repos_url":"https://api.github.com/users/nerdstein/repos","events_url":"https://api.github.com/users/nerdstein/events{/privacy}","received_events_url":"https://api.github.com/users/nerdstein/received_events","type":"User","site_admin":false},"body":"1. Adds new config entity for \"Encryption Configuration\"\r\n2. Functionality for this entity to have \"default\" to make the service return a default\r\n3. Updates service to allow an instance to be passed","created_at":"2015-09-06T02:00:01Z","updated_at":"2015-09-08T19:14:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"630bb937587580a3a5a25e01c2a5dda0e339c563","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48/commits","review_comments_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48/comments","review_comment_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/48/comments","statuses_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/statuses/982fb3d6f3b1f8f7846bb797bd842fe826b528a6","head":{"label":"nerdstein:instance-manager","ref":"instance-manager","sha":"982fb3d6f3b1f8f7846bb797bd842fe826b528a6","user":{"login":"nerdstein","id":966547,"avatar_url":"https://avatars.githubusercontent.com/u/966547?v=3","gravatar_id":"","url":"https://api.github.com/users/nerdstein","html_url":"https://github.com/nerdstein","followers_url":"https://api.github.com/users/nerdstein/followers","following_url":"https://api.github.com/users/nerdstein/following{/other_user}","gists_url":"https://api.github.com/users/nerdstein/gists{/gist_id}","starred_url":"https://api.github.com/users/nerdstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerdstein/subscriptions","organizations_url":"https://api.github.com/users/nerdstein/orgs","repos_url":"https://api.github.com/users/nerdstein/repos","events_url":"https://api.github.com/users/nerdstein/events{/privacy}","received_events_url":"https://api.github.com/users/nerdstein/received_events","type":"User","site_admin":false},"repo":{"id":41838581,"name":"encrypt","full_name":"nerdstein/encrypt","owner":{"login":"nerdstein","id":966547,"avatar_url":"https://avatars.githubusercontent.com/u/966547?v=3","gravatar_id":"","url":"https://api.github.com/users/nerdstein","html_url":"https://github.com/nerdstein","followers_url":"https://api.github.com/users/nerdstein/followers","following_url":"https://api.github.com/users/nerdstein/following{/other_user}","gists_url":"https://api.github.com/users/nerdstein/gists{/gist_id}","starred_url":"https://api.github.com/users/nerdstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nerdstein/subscriptions","organizations_url":"https://api.github.com/users/nerdstein/orgs","repos_url":"https://api.github.com/users/nerdstein/repos","events_url":"https://api.github.com/users/nerdstein/events{/privacy}","received_events_url":"https://api.github.com/users/nerdstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nerdstein/encrypt","description":"D8 port for encrypt module","fork":true,"url":"https://api.github.com/repos/nerdstein/encrypt","forks_url":"https://api.github.com/repos/nerdstein/encrypt/forks","keys_url":"https://api.github.com/repos/nerdstein/encrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nerdstein/encrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nerdstein/encrypt/teams","hooks_url":"https://api.github.com/repos/nerdstein/encrypt/hooks","issue_events_url":"https://api.github.com/repos/nerdstein/encrypt/issues/events{/number}","events_url":"https://api.github.com/repos/nerdstein/encrypt/events","assignees_url":"https://api.github.com/repos/nerdstein/encrypt/assignees{/user}","branches_url":"https://api.github.com/repos/nerdstein/encrypt/branches{/branch}","tags_url":"https://api.github.com/repos/nerdstein/encrypt/tags","blobs_url":"https://api.github.com/repos/nerdstein/encrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nerdstein/encrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nerdstein/encrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/nerdstein/encrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nerdstein/encrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/nerdstein/encrypt/languages","stargazers_url":"https://api.github.com/repos/nerdstein/encrypt/stargazers","contributors_url":"https://api.github.com/repos/nerdstein/encrypt/contributors","subscribers_url":"https://api.github.com/repos/nerdstein/encrypt/subscribers","subscription_url":"https://api.github.com/repos/nerdstein/encrypt/subscription","commits_url":"https://api.github.com/repos/nerdstein/encrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/nerdstein/encrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/nerdstein/encrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/nerdstein/encrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/nerdstein/encrypt/contents/{+path}","compare_url":"https://api.github.com/repos/nerdstein/encrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nerdstein/encrypt/merges","archive_url":"https://api.github.com/repos/nerdstein/encrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nerdstein/encrypt/downloads","issues_url":"https://api.github.com/repos/nerdstein/encrypt/issues{/number}","pulls_url":"https://api.github.com/repos/nerdstein/encrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/nerdstein/encrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/nerdstein/encrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nerdstein/encrypt/labels{/name}","releases_url":"https://api.github.com/repos/nerdstein/encrypt/releases{/id}","created_at":"2015-09-03T02:34:33Z","updated_at":"2015-09-03T02:34:33Z","pushed_at":"2015-09-06T01:57:56Z","git_url":"git://github.com/nerdstein/encrypt.git","ssh_url":"git@github.com:nerdstein/encrypt.git","clone_url":"https://github.com/nerdstein/encrypt.git","svn_url":"https://github.com/nerdstein/encrypt","homepage":null,"size":308,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"d8-contrib-modules:master","ref":"master","sha":"de25a3acafb76b85c5981c237efe5e3e2e2c2d59","user":{"login":"d8-contrib-modules","id":13561676,"avatar_url":"https://avatars.githubusercontent.com/u/13561676?v=3","gravatar_id":"","url":"https://api.github.com/users/d8-contrib-modules","html_url":"https://github.com/d8-contrib-modules","followers_url":"https://api.github.com/users/d8-contrib-modules/followers","following_url":"https://api.github.com/users/d8-contrib-modules/following{/other_user}","gists_url":"https://api.github.com/users/d8-contrib-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/d8-contrib-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d8-contrib-modules/subscriptions","organizations_url":"https://api.github.com/users/d8-contrib-modules/orgs","repos_url":"https://api.github.com/users/d8-contrib-modules/repos","events_url":"https://api.github.com/users/d8-contrib-modules/events{/privacy}","received_events_url":"https://api.github.com/users/d8-contrib-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":38453739,"name":"encrypt","full_name":"d8-contrib-modules/encrypt","owner":{"login":"d8-contrib-modules","id":13561676,"avatar_url":"https://avatars.githubusercontent.com/u/13561676?v=3","gravatar_id":"","url":"https://api.github.com/users/d8-contrib-modules","html_url":"https://github.com/d8-contrib-modules","followers_url":"https://api.github.com/users/d8-contrib-modules/followers","following_url":"https://api.github.com/users/d8-contrib-modules/following{/other_user}","gists_url":"https://api.github.com/users/d8-contrib-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/d8-contrib-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d8-contrib-modules/subscriptions","organizations_url":"https://api.github.com/users/d8-contrib-modules/orgs","repos_url":"https://api.github.com/users/d8-contrib-modules/repos","events_url":"https://api.github.com/users/d8-contrib-modules/events{/privacy}","received_events_url":"https://api.github.com/users/d8-contrib-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d8-contrib-modules/encrypt","description":"D8 port for encrypt module","fork":false,"url":"https://api.github.com/repos/d8-contrib-modules/encrypt","forks_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/forks","keys_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/teams","hooks_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/hooks","issue_events_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/events{/number}","events_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/events","assignees_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/assignees{/user}","branches_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/branches{/branch}","tags_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/tags","blobs_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/git/refs{/sha}","trees_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/statuses/{sha}","languages_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/languages","stargazers_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/stargazers","contributors_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/contributors","subscribers_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/subscribers","subscription_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/subscription","commits_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/commits{/sha}","git_commits_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/git/commits{/sha}","comments_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/comments{/number}","issue_comment_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/comments{/number}","contents_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/contents/{+path}","compare_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/merges","archive_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/downloads","issues_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues{/number}","pulls_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls{/number}","milestones_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/milestones{/number}","notifications_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/labels{/name}","releases_url":"https://api.github.com/repos/d8-contrib-modules/encrypt/releases{/id}","created_at":"2015-07-02T19:52:14Z","updated_at":"2015-08-11T20:20:21Z","pushed_at":"2015-09-06T02:00:01Z","git_url":"git://github.com/d8-contrib-modules/encrypt.git","ssh_url":"git@github.com:d8-contrib-modules/encrypt.git","clone_url":"https://github.com/d8-contrib-modules/encrypt.git","svn_url":"https://github.com/d8-contrib-modules/encrypt","homepage":null,"size":308,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":11,"forks":6,"open_issues":11,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48"},"html":{"href":"https://github.com/d8-contrib-modules/encrypt/pull/48"},"issue":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/48"},"comments":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/d8-contrib-modules/encrypt/statuses/982fb3d6f3b1f8f7846bb797bd842fe826b528a6"}}}}