{"action":"created","comment":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/25714694","id":25714694,"diff_hunk":"@@ -71,6 +72,10 @@ public enum CarthageError {\n \t/// them.\n \tcase NoSharedSchemes(ProjectLocator)\n \n+\t/// The private cartfile contains dependencies that are already present in\n+\t/// the main cartfile.\n+\tcase DuplicateDependencies([(ProjectIdentifier, /*label*/ String)])","path":"Source/CarthageKit/Errors.swift","position":14,"original_position":14,"commit_id":"4a788b90b54f5fc9462f22c47eb83b1cda5f1195","original_commit_id":"4a788b90b54f5fc9462f22c47eb83b1cda5f1195","user":{"login":"jspahrsummers","id":432536,"avatar_url":"https://avatars.githubusercontent.com/u/432536?v=3","gravatar_id":"","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User","site_admin":true},"body":"Can we encapsulate this tuple's information in a custom `struct` type instead, to make it clearer?","created_at":"2015-03-03T18:53:49Z","updated_at":"2015-03-03T18:53:49Z","html_url":"https://github.com/Carthage/Carthage/pull/364#discussion_r25714694","pull_request_url":"https://api.github.com/repos/Carthage/Carthage/pulls/364","_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments/25714694"},"html":{"href":"https://github.com/Carthage/Carthage/pull/364#discussion_r25714694"},"pull_request":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/364"}}},"pull_request":{"url":"https://api.github.com/repos/Carthage/Carthage/pulls/364","id":30146269,"html_url":"https://github.com/Carthage/Carthage/pull/364","diff_url":"https://github.com/Carthage/Carthage/pull/364.diff","patch_url":"https://github.com/Carthage/Carthage/pull/364.patch","issue_url":"https://api.github.com/repos/Carthage/Carthage/issues/364","number":364,"state":"open","locked":false,"title":"Detect duplicate Cartfile.private dependencies","user":{"login":"bavarious","id":531537,"avatar_url":"https://avatars.githubusercontent.com/u/531537?v=3","gravatar_id":"","url":"https://api.github.com/users/bavarious","html_url":"https://github.com/bavarious","followers_url":"https://api.github.com/users/bavarious/followers","following_url":"https://api.github.com/users/bavarious/following{/other_user}","gists_url":"https://api.github.com/users/bavarious/gists{/gist_id}","starred_url":"https://api.github.com/users/bavarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bavarious/subscriptions","organizations_url":"https://api.github.com/users/bavarious/orgs","repos_url":"https://api.github.com/users/bavarious/repos","events_url":"https://api.github.com/users/bavarious/events{/privacy}","received_events_url":"https://api.github.com/users/bavarious/received_events","type":"User","site_admin":false},"body":"This PR should fix #333.\r\n\r\nAt the moment, it only lists duplicate dependencies. I would like to discuss the items below; feedback is greatly appreciated!\r\n\r\n1. ~~Should Carthage always error out when it finds duplicate dependencies or can it be a warning only? This would mean another command-line option.~~ Always error out.\r\n2. ~~How do I error out in this case? That closure returns a `Cartfile`.~~\r\n3. ~~Should I make that match O(n log n)? Note: 8 seconds with 1,000 non-matching entries in either Cartfile.~~ Use Swift 1.2 `Set`.\r\n4. ~~That `println()` should be directed to `stderr`, and the fix probably depends on 1 and 2 above.~~","created_at":"2015-02-27T07:20:05Z","updated_at":"2015-03-03T18:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee085f926508d7728164a725e6a4fa9d824184e9","assignee":{"login":"jspahrsummers","id":432536,"avatar_url":"https://avatars.githubusercontent.com/u/432536?v=3","gravatar_id":"","url":"https://api.github.com/users/jspahrsummers","html_url":"https://github.com/jspahrsummers","followers_url":"https://api.github.com/users/jspahrsummers/followers","following_url":"https://api.github.com/users/jspahrsummers/following{/other_user}","gists_url":"https://api.github.com/users/jspahrsummers/gists{/gist_id}","starred_url":"https://api.github.com/users/jspahrsummers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jspahrsummers/subscriptions","organizations_url":"https://api.github.com/users/jspahrsummers/orgs","repos_url":"https://api.github.com/users/jspahrsummers/repos","events_url":"https://api.github.com/users/jspahrsummers/events{/privacy}","received_events_url":"https://api.github.com/users/jspahrsummers/received_events","type":"User","site_admin":true},"milestone":null,"commits_url":"https://api.github.com/repos/Carthage/Carthage/pulls/364/commits","review_comments_url":"https://api.github.com/repos/Carthage/Carthage/pulls/364/comments","review_comment_url":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Carthage/Carthage/issues/364/comments","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/4a788b90b54f5fc9462f22c47eb83b1cda5f1195","head":{"label":"bavarious:duplicate-deps","ref":"duplicate-deps","sha":"4a788b90b54f5fc9462f22c47eb83b1cda5f1195","user":{"login":"bavarious","id":531537,"avatar_url":"https://avatars.githubusercontent.com/u/531537?v=3","gravatar_id":"","url":"https://api.github.com/users/bavarious","html_url":"https://github.com/bavarious","followers_url":"https://api.github.com/users/bavarious/followers","following_url":"https://api.github.com/users/bavarious/following{/other_user}","gists_url":"https://api.github.com/users/bavarious/gists{/gist_id}","starred_url":"https://api.github.com/users/bavarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bavarious/subscriptions","organizations_url":"https://api.github.com/users/bavarious/orgs","repos_url":"https://api.github.com/users/bavarious/repos","events_url":"https://api.github.com/users/bavarious/events{/privacy}","received_events_url":"https://api.github.com/users/bavarious/received_events","type":"User","site_admin":false},"repo":{"id":31272937,"name":"Carthage","full_name":"bavarious/Carthage","owner":{"login":"bavarious","id":531537,"avatar_url":"https://avatars.githubusercontent.com/u/531537?v=3","gravatar_id":"","url":"https://api.github.com/users/bavarious","html_url":"https://github.com/bavarious","followers_url":"https://api.github.com/users/bavarious/followers","following_url":"https://api.github.com/users/bavarious/following{/other_user}","gists_url":"https://api.github.com/users/bavarious/gists{/gist_id}","starred_url":"https://api.github.com/users/bavarious/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bavarious/subscriptions","organizations_url":"https://api.github.com/users/bavarious/orgs","repos_url":"https://api.github.com/users/bavarious/repos","events_url":"https://api.github.com/users/bavarious/events{/privacy}","received_events_url":"https://api.github.com/users/bavarious/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bavarious/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":true,"url":"https://api.github.com/repos/bavarious/Carthage","forks_url":"https://api.github.com/repos/bavarious/Carthage/forks","keys_url":"https://api.github.com/repos/bavarious/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bavarious/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bavarious/Carthage/teams","hooks_url":"https://api.github.com/repos/bavarious/Carthage/hooks","issue_events_url":"https://api.github.com/repos/bavarious/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/bavarious/Carthage/events","assignees_url":"https://api.github.com/repos/bavarious/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/bavarious/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/bavarious/Carthage/tags","blobs_url":"https://api.github.com/repos/bavarious/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bavarious/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bavarious/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/bavarious/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bavarious/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/bavarious/Carthage/languages","stargazers_url":"https://api.github.com/repos/bavarious/Carthage/stargazers","contributors_url":"https://api.github.com/repos/bavarious/Carthage/contributors","subscribers_url":"https://api.github.com/repos/bavarious/Carthage/subscribers","subscription_url":"https://api.github.com/repos/bavarious/Carthage/subscription","commits_url":"https://api.github.com/repos/bavarious/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/bavarious/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/bavarious/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/bavarious/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/bavarious/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/bavarious/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bavarious/Carthage/merges","archive_url":"https://api.github.com/repos/bavarious/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bavarious/Carthage/downloads","issues_url":"https://api.github.com/repos/bavarious/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/bavarious/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/bavarious/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/bavarious/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bavarious/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/bavarious/Carthage/releases{/id}","created_at":"2015-02-24T17:44:24Z","updated_at":"2015-02-26T08:05:59Z","pushed_at":"2015-03-03T06:34:17Z","git_url":"git://github.com/bavarious/Carthage.git","ssh_url":"git@github.com:bavarious/Carthage.git","clone_url":"https://github.com/bavarious/Carthage.git","svn_url":"https://github.com/bavarious/Carthage","homepage":"","size":6123,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Carthage:master","ref":"master","sha":"1ee40ca0dc982abbf88b79f35cefd5e67fa62198","user":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"repo":{"id":25050844,"name":"Carthage","full_name":"Carthage/Carthage","owner":{"login":"Carthage","id":9146792,"avatar_url":"https://avatars.githubusercontent.com/u/9146792?v=3","gravatar_id":"","url":"https://api.github.com/users/Carthage","html_url":"https://github.com/Carthage","followers_url":"https://api.github.com/users/Carthage/followers","following_url":"https://api.github.com/users/Carthage/following{/other_user}","gists_url":"https://api.github.com/users/Carthage/gists{/gist_id}","starred_url":"https://api.github.com/users/Carthage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carthage/subscriptions","organizations_url":"https://api.github.com/users/Carthage/orgs","repos_url":"https://api.github.com/users/Carthage/repos","events_url":"https://api.github.com/users/Carthage/events{/privacy}","received_events_url":"https://api.github.com/users/Carthage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Carthage/Carthage","description":"A simple, decentralized dependency manager for Cocoa","fork":false,"url":"https://api.github.com/repos/Carthage/Carthage","forks_url":"https://api.github.com/repos/Carthage/Carthage/forks","keys_url":"https://api.github.com/repos/Carthage/Carthage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carthage/Carthage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carthage/Carthage/teams","hooks_url":"https://api.github.com/repos/Carthage/Carthage/hooks","issue_events_url":"https://api.github.com/repos/Carthage/Carthage/issues/events{/number}","events_url":"https://api.github.com/repos/Carthage/Carthage/events","assignees_url":"https://api.github.com/repos/Carthage/Carthage/assignees{/user}","branches_url":"https://api.github.com/repos/Carthage/Carthage/branches{/branch}","tags_url":"https://api.github.com/repos/Carthage/Carthage/tags","blobs_url":"https://api.github.com/repos/Carthage/Carthage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carthage/Carthage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carthage/Carthage/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carthage/Carthage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carthage/Carthage/statuses/{sha}","languages_url":"https://api.github.com/repos/Carthage/Carthage/languages","stargazers_url":"https://api.github.com/repos/Carthage/Carthage/stargazers","contributors_url":"https://api.github.com/repos/Carthage/Carthage/contributors","subscribers_url":"https://api.github.com/repos/Carthage/Carthage/subscribers","subscription_url":"https://api.github.com/repos/Carthage/Carthage/subscription","commits_url":"https://api.github.com/repos/Carthage/Carthage/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carthage/Carthage/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carthage/Carthage/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carthage/Carthage/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carthage/Carthage/contents/{+path}","compare_url":"https://api.github.com/repos/Carthage/Carthage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carthage/Carthage/merges","archive_url":"https://api.github.com/repos/Carthage/Carthage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carthage/Carthage/downloads","issues_url":"https://api.github.com/repos/Carthage/Carthage/issues{/number}","pulls_url":"https://api.github.com/repos/Carthage/Carthage/pulls{/number}","milestones_url":"https://api.github.com/repos/Carthage/Carthage/milestones{/number}","notifications_url":"https://api.github.com/repos/Carthage/Carthage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carthage/Carthage/labels{/name}","releases_url":"https://api.github.com/repos/Carthage/Carthage/releases{/id}","created_at":"2014-10-10T19:54:55Z","updated_at":"2015-03-03T18:47:58Z","pushed_at":"2015-03-01T20:13:32Z","git_url":"git://github.com/Carthage/Carthage.git","ssh_url":"git@github.com:Carthage/Carthage.git","clone_url":"https://github.com/Carthage/Carthage.git","svn_url":"https://github.com/Carthage/Carthage","homepage":"","size":9171,"stargazers_count":2100,"watchers_count":2100,"language":"Swift","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"open_issues_count":49,"forks":69,"open_issues":49,"watchers":2100,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/364"},"html":{"href":"https://github.com/Carthage/Carthage/pull/364"},"issue":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/364"},"comments":{"href":"https://api.github.com/repos/Carthage/Carthage/issues/364/comments"},"review_comments":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/364/comments"},"review_comment":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Carthage/Carthage/pulls/364/commits"},"statuses":{"href":"https://api.github.com/repos/Carthage/Carthage/statuses/4a788b90b54f5fc9462f22c47eb83b1cda5f1195"}}}}