{"action":"created","comment":{"url":"https://api.github.com/repos/enovance/edeploy/pulls/comments/22419786","id":22419786,"diff_hunk":"@@ -0,0 +1,37 @@\n+#!/usr/bin/python\n+\n+import sys\n+\n+# Parse /etc/passwd file and provide\n+# put data into array\n+passwd = open( \"/etc/passwd\", \"r\" )","path":"build/verifyids.py","position":7,"original_position":7,"commit_id":"050f4ff6eb06e73ae68a46c279a9f10724db06e1","original_commit_id":"050f4ff6eb06e73ae68a46c279a9f10724db06e1","user":{"login":"EmilienM","id":1688225,"avatar_url":"https://avatars.githubusercontent.com/u/1688225?v=3","gravatar_id":"","url":"https://api.github.com/users/EmilienM","html_url":"https://github.com/EmilienM","followers_url":"https://api.github.com/users/EmilienM/followers","following_url":"https://api.github.com/users/EmilienM/following{/other_user}","gists_url":"https://api.github.com/users/EmilienM/gists{/gist_id}","starred_url":"https://api.github.com/users/EmilienM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EmilienM/subscriptions","organizations_url":"https://api.github.com/users/EmilienM/orgs","repos_url":"https://api.github.com/users/EmilienM/repos","events_url":"https://api.github.com/users/EmilienM/events{/privacy}","received_events_url":"https://api.github.com/users/EmilienM/received_events","type":"User","site_admin":false},"body":"I would use \"with_open\" which automatically close the file after usage.","created_at":"2015-01-02T19:30:11Z","updated_at":"2015-01-02T19:30:11Z","html_url":"https://github.com/enovance/edeploy/pull/176#discussion_r22419786","pull_request_url":"https://api.github.com/repos/enovance/edeploy/pulls/176","_links":{"self":{"href":"https://api.github.com/repos/enovance/edeploy/pulls/comments/22419786"},"html":{"href":"https://github.com/enovance/edeploy/pull/176#discussion_r22419786"},"pull_request":{"href":"https://api.github.com/repos/enovance/edeploy/pulls/176"}}},"pull_request":{"url":"https://api.github.com/repos/enovance/edeploy/pulls/176","id":26760729,"html_url":"https://github.com/enovance/edeploy/pull/176","diff_url":"https://github.com/enovance/edeploy/pull/176.diff","patch_url":"https://github.com/enovance/edeploy/pull/176.patch","issue_url":"https://api.github.com/repos/enovance/edeploy/issues/176","number":176,"state":"open","locked":false,"title":"[WIP] ids: Verify at the end of the build the ids are ok","user":{"login":"Spredzy","id":1191411,"avatar_url":"https://avatars.githubusercontent.com/u/1191411?v=3","gravatar_id":"","url":"https://api.github.com/users/Spredzy","html_url":"https://github.com/Spredzy","followers_url":"https://api.github.com/users/Spredzy/followers","following_url":"https://api.github.com/users/Spredzy/following{/other_user}","gists_url":"https://api.github.com/users/Spredzy/gists{/gist_id}","starred_url":"https://api.github.com/users/Spredzy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spredzy/subscriptions","organizations_url":"https://api.github.com/users/Spredzy/orgs","repos_url":"https://api.github.com/users/Spredzy/repos","events_url":"https://api.github.com/users/Spredzy/events{/privacy}","received_events_url":"https://api.github.com/users/Spredzy/received_events","type":"User","site_admin":false},"body":"With this commit, at the end of every build the entry\r\nin /etc/passwd are compared to the entries in /root/ids.tables with\r\nthe verifiedids.py script.","created_at":"2015-01-02T15:50:20Z","updated_at":"2015-01-02T19:30:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca063cf4326cc081bf8a857c9b87694b545028e6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/enovance/edeploy/pulls/176/commits","review_comments_url":"https://api.github.com/repos/enovance/edeploy/pulls/176/comments","review_comment_url":"https://api.github.com/repos/enovance/edeploy/pulls/comments/{number}","comments_url":"https://api.github.com/repos/enovance/edeploy/issues/176/comments","statuses_url":"https://api.github.com/repos/enovance/edeploy/statuses/050f4ff6eb06e73ae68a46c279a9f10724db06e1","head":{"label":"enovance:verify_ids_values","ref":"verify_ids_values","sha":"050f4ff6eb06e73ae68a46c279a9f10724db06e1","user":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=3","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"repo":{"id":9191535,"name":"edeploy","full_name":"enovance/edeploy","owner":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=3","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enovance/edeploy","description":"Linux systems provisionning and updating made easy","fork":false,"url":"https://api.github.com/repos/enovance/edeploy","forks_url":"https://api.github.com/repos/enovance/edeploy/forks","keys_url":"https://api.github.com/repos/enovance/edeploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enovance/edeploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enovance/edeploy/teams","hooks_url":"https://api.github.com/repos/enovance/edeploy/hooks","issue_events_url":"https://api.github.com/repos/enovance/edeploy/issues/events{/number}","events_url":"https://api.github.com/repos/enovance/edeploy/events","assignees_url":"https://api.github.com/repos/enovance/edeploy/assignees{/user}","branches_url":"https://api.github.com/repos/enovance/edeploy/branches{/branch}","tags_url":"https://api.github.com/repos/enovance/edeploy/tags","blobs_url":"https://api.github.com/repos/enovance/edeploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enovance/edeploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enovance/edeploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/enovance/edeploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enovance/edeploy/statuses/{sha}","languages_url":"https://api.github.com/repos/enovance/edeploy/languages","stargazers_url":"https://api.github.com/repos/enovance/edeploy/stargazers","contributors_url":"https://api.github.com/repos/enovance/edeploy/contributors","subscribers_url":"https://api.github.com/repos/enovance/edeploy/subscribers","subscription_url":"https://api.github.com/repos/enovance/edeploy/subscription","commits_url":"https://api.github.com/repos/enovance/edeploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/enovance/edeploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/enovance/edeploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/enovance/edeploy/issues/comments/{number}","contents_url":"https://api.github.com/repos/enovance/edeploy/contents/{+path}","compare_url":"https://api.github.com/repos/enovance/edeploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enovance/edeploy/merges","archive_url":"https://api.github.com/repos/enovance/edeploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enovance/edeploy/downloads","issues_url":"https://api.github.com/repos/enovance/edeploy/issues{/number}","pulls_url":"https://api.github.com/repos/enovance/edeploy/pulls{/number}","milestones_url":"https://api.github.com/repos/enovance/edeploy/milestones{/number}","notifications_url":"https://api.github.com/repos/enovance/edeploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enovance/edeploy/labels{/name}","releases_url":"https://api.github.com/repos/enovance/edeploy/releases{/id}","created_at":"2013-04-03T09:47:57Z","updated_at":"2015-01-02T18:48:17Z","pushed_at":"2015-01-02T18:48:17Z","git_url":"git://github.com/enovance/edeploy.git","ssh_url":"git@github.com:enovance/edeploy.git","clone_url":"https://github.com/enovance/edeploy.git","svn_url":"https://github.com/enovance/edeploy","homepage":"","size":16073,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":17,"forks":36,"open_issues":17,"watchers":52,"default_branch":"master"}},"base":{"label":"enovance:master","ref":"master","sha":"a447ee3979f7d212161df94468f7b302f5bd202d","user":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=3","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"repo":{"id":9191535,"name":"edeploy","full_name":"enovance/edeploy","owner":{"login":"enovance","id":1607795,"avatar_url":"https://avatars.githubusercontent.com/u/1607795?v=3","gravatar_id":"","url":"https://api.github.com/users/enovance","html_url":"https://github.com/enovance","followers_url":"https://api.github.com/users/enovance/followers","following_url":"https://api.github.com/users/enovance/following{/other_user}","gists_url":"https://api.github.com/users/enovance/gists{/gist_id}","starred_url":"https://api.github.com/users/enovance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enovance/subscriptions","organizations_url":"https://api.github.com/users/enovance/orgs","repos_url":"https://api.github.com/users/enovance/repos","events_url":"https://api.github.com/users/enovance/events{/privacy}","received_events_url":"https://api.github.com/users/enovance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/enovance/edeploy","description":"Linux systems provisionning and updating made easy","fork":false,"url":"https://api.github.com/repos/enovance/edeploy","forks_url":"https://api.github.com/repos/enovance/edeploy/forks","keys_url":"https://api.github.com/repos/enovance/edeploy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enovance/edeploy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enovance/edeploy/teams","hooks_url":"https://api.github.com/repos/enovance/edeploy/hooks","issue_events_url":"https://api.github.com/repos/enovance/edeploy/issues/events{/number}","events_url":"https://api.github.com/repos/enovance/edeploy/events","assignees_url":"https://api.github.com/repos/enovance/edeploy/assignees{/user}","branches_url":"https://api.github.com/repos/enovance/edeploy/branches{/branch}","tags_url":"https://api.github.com/repos/enovance/edeploy/tags","blobs_url":"https://api.github.com/repos/enovance/edeploy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enovance/edeploy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enovance/edeploy/git/refs{/sha}","trees_url":"https://api.github.com/repos/enovance/edeploy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enovance/edeploy/statuses/{sha}","languages_url":"https://api.github.com/repos/enovance/edeploy/languages","stargazers_url":"https://api.github.com/repos/enovance/edeploy/stargazers","contributors_url":"https://api.github.com/repos/enovance/edeploy/contributors","subscribers_url":"https://api.github.com/repos/enovance/edeploy/subscribers","subscription_url":"https://api.github.com/repos/enovance/edeploy/subscription","commits_url":"https://api.github.com/repos/enovance/edeploy/commits{/sha}","git_commits_url":"https://api.github.com/repos/enovance/edeploy/git/commits{/sha}","comments_url":"https://api.github.com/repos/enovance/edeploy/comments{/number}","issue_comment_url":"https://api.github.com/repos/enovance/edeploy/issues/comments/{number}","contents_url":"https://api.github.com/repos/enovance/edeploy/contents/{+path}","compare_url":"https://api.github.com/repos/enovance/edeploy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enovance/edeploy/merges","archive_url":"https://api.github.com/repos/enovance/edeploy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enovance/edeploy/downloads","issues_url":"https://api.github.com/repos/enovance/edeploy/issues{/number}","pulls_url":"https://api.github.com/repos/enovance/edeploy/pulls{/number}","milestones_url":"https://api.github.com/repos/enovance/edeploy/milestones{/number}","notifications_url":"https://api.github.com/repos/enovance/edeploy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enovance/edeploy/labels{/name}","releases_url":"https://api.github.com/repos/enovance/edeploy/releases{/id}","created_at":"2013-04-03T09:47:57Z","updated_at":"2015-01-02T18:48:17Z","pushed_at":"2015-01-02T18:48:17Z","git_url":"git://github.com/enovance/edeploy.git","ssh_url":"git@github.com:enovance/edeploy.git","clone_url":"https://github.com/enovance/edeploy.git","svn_url":"https://github.com/enovance/edeploy","homepage":"","size":16073,"stargazers_count":52,"watchers_count":52,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":17,"forks":36,"open_issues":17,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/enovance/edeploy/pulls/176"},"html":{"href":"https://github.com/enovance/edeploy/pull/176"},"issue":{"href":"https://api.github.com/repos/enovance/edeploy/issues/176"},"comments":{"href":"https://api.github.com/repos/enovance/edeploy/issues/176/comments"},"review_comments":{"href":"https://api.github.com/repos/enovance/edeploy/pulls/176/comments"},"review_comment":{"href":"https://api.github.com/repos/enovance/edeploy/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/enovance/edeploy/pulls/176/commits"},"statuses":{"href":"https://api.github.com/repos/enovance/edeploy/statuses/050f4ff6eb06e73ae68a46c279a9f10724db06e1"}}}}