{"action":"created","comment":{"url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/comments/41375289","id":41375289,"diff_hunk":"@@ -22,53 +23,66 @@ class DuplicateFlagColumnException < Exception; end\n   module ClassMethods\n     def has_flags(*args)\n       flag_hash, opts = parse_flag_options(*args)\n-      opts = {\n-        :named_scopes => true,\n-        :column => DEFAULT_COLUMN_NAME,\n-        :flag_query_mode => :in_list, # or :bit_operator\n-        :strict => false,\n-        :check_for_column => true\n-      }.update(opts)\n-      if !is_valid_flag_column_name(opts[:column])\n-        warn \"FlagShihTzu says: Please use a String to designate column names! I see you here: #{caller.first}\"\n+      opts =\n+        {\n+          named_scopes: true,\n+          column: DEFAULT_COLUMN_NAME,\n+          flag_query_mode: :in_list, # or :bit_operator\n+          strict: false,\n+          check_for_column: true\n+        }.update(opts)\n+      if !valid_flag_column_name?(opts[:column])\n+        warn %[FlagShihTzu says: Please use a String to designate column names! I see you here: #{caller.first}]\n         opts[:column] = opts[:column].to_s\n       end\n       colmn = opts[:column]\n-      if opts[:check_for_column] && ( is_active_record_class? && !check_flag_column(colmn) )\n-        warn \"FlagShihTzu says: Flag column #{colmn} appears to be missing!\\nTo turn off this warning set check_for_column: false in has_flags definition here: #{caller.first}\"\n+      if opts[:check_for_column] && (active_record_class? && !check_flag_column(colmn))\n+        warn(\n+          %[FlagShihTzu says: Flag column #{colmn} appears to be missing!\n+To turn off this warning set check_for_column: false in has_flags definition here: #{caller.first}]\n+        )\n         return\n       end\n \n       # options are stored in a class level hash and apply per-column\n       self.flag_options ||= {}\n-      self.flag_options[colmn] = opts\n+      flag_options[colmn] = opts\n \n       # the mappings are stored in this class level hash and apply per-column\n       self.flag_mapping ||= {}\n-      #If we already have an instance of the same column in the flag_mapping, then there is a double definition on a column\n-      raise DuplicateFlagColumnException if opts[:strict] && !self.flag_mapping[colmn].nil?\n-      self.flag_mapping[colmn] ||= {}\n+      # If we already have an instance of the same column in the flag_mapping,\n+      #   then there is a double definition on a column\n+      raise DuplicateFlagColumnException if opts[:strict] &&\n+        !self.flag_mapping[colmn].nil?","path":"lib/flag_shih_tzu.rb","position":69,"original_position":69,"commit_id":"e10af12a45defa878e3967b9a160790b24ddb7a3","original_commit_id":"e10af12a45defa878e3967b9a160790b24ddb7a3","user":{"login":"houndci","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci","html_url":"https://github.com/houndci","followers_url":"https://api.github.com/users/houndci/followers","following_url":"https://api.github.com/users/houndci/following{/other_user}","gists_url":"https://api.github.com/users/houndci/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci/subscriptions","organizations_url":"https://api.github.com/users/houndci/orgs","repos_url":"https://api.github.com/users/houndci/repos","events_url":"https://api.github.com/users/houndci/events{/privacy}","received_events_url":"https://api.github.com/users/houndci/received_events","type":"User","site_admin":false},"body":"Align the operands of a condition in an `if` statement spanning multiple lines.","created_at":"2015-10-07T10:42:59Z","updated_at":"2015-10-07T10:42:59Z","html_url":"https://github.com/pboling/flag_shih_tzu/pull/50#discussion_r41375289","pull_request_url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50","_links":{"self":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/comments/41375289"},"html":{"href":"https://github.com/pboling/flag_shih_tzu/pull/50#discussion_r41375289"},"pull_request":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50","id":46985615,"html_url":"https://github.com/pboling/flag_shih_tzu/pull/50","diff_url":"https://github.com/pboling/flag_shih_tzu/pull/50.diff","patch_url":"https://github.com/pboling/flag_shih_tzu/pull/50.patch","issue_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/50","number":50,"state":"open","locked":false,"title":"Cleaning up code","user":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"body":"Fixing Hound issues raised in PR #49 and various other things.  Update Ruby versions on travis.  Upgrade local test script.","created_at":"2015-10-07T04:17:03Z","updated_at":"2015-10-07T10:42:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"79590246d5fe2b5b8babe890b54498707c733af3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50/commits","review_comments_url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50/comments","review_comment_url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/50/comments","statuses_url":"https://api.github.com/repos/pboling/flag_shih_tzu/statuses/e10af12a45defa878e3967b9a160790b24ddb7a3","head":{"label":"pboling:code-cleanup","ref":"code-cleanup","sha":"e10af12a45defa878e3967b9a160790b24ddb7a3","user":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"repo":{"id":148333,"name":"flag_shih_tzu","full_name":"pboling/flag_shih_tzu","owner":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboling/flag_shih_tzu","description":"Bit fields for ActiveRecord","fork":false,"url":"https://api.github.com/repos/pboling/flag_shih_tzu","forks_url":"https://api.github.com/repos/pboling/flag_shih_tzu/forks","keys_url":"https://api.github.com/repos/pboling/flag_shih_tzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboling/flag_shih_tzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboling/flag_shih_tzu/teams","hooks_url":"https://api.github.com/repos/pboling/flag_shih_tzu/hooks","issue_events_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/events{/number}","events_url":"https://api.github.com/repos/pboling/flag_shih_tzu/events","assignees_url":"https://api.github.com/repos/pboling/flag_shih_tzu/assignees{/user}","branches_url":"https://api.github.com/repos/pboling/flag_shih_tzu/branches{/branch}","tags_url":"https://api.github.com/repos/pboling/flag_shih_tzu/tags","blobs_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboling/flag_shih_tzu/statuses/{sha}","languages_url":"https://api.github.com/repos/pboling/flag_shih_tzu/languages","stargazers_url":"https://api.github.com/repos/pboling/flag_shih_tzu/stargazers","contributors_url":"https://api.github.com/repos/pboling/flag_shih_tzu/contributors","subscribers_url":"https://api.github.com/repos/pboling/flag_shih_tzu/subscribers","subscription_url":"https://api.github.com/repos/pboling/flag_shih_tzu/subscription","commits_url":"https://api.github.com/repos/pboling/flag_shih_tzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboling/flag_shih_tzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/pboling/flag_shih_tzu/contents/{+path}","compare_url":"https://api.github.com/repos/pboling/flag_shih_tzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboling/flag_shih_tzu/merges","archive_url":"https://api.github.com/repos/pboling/flag_shih_tzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboling/flag_shih_tzu/downloads","issues_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues{/number}","pulls_url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls{/number}","milestones_url":"https://api.github.com/repos/pboling/flag_shih_tzu/milestones{/number}","notifications_url":"https://api.github.com/repos/pboling/flag_shih_tzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboling/flag_shih_tzu/labels{/name}","releases_url":"https://api.github.com/repos/pboling/flag_shih_tzu/releases{/id}","created_at":"2009-03-11T12:00:28Z","updated_at":"2015-09-30T18:23:01Z","pushed_at":"2015-10-07T10:42:50Z","git_url":"git://github.com/pboling/flag_shih_tzu.git","ssh_url":"git@github.com:pboling/flag_shih_tzu.git","clone_url":"https://github.com/pboling/flag_shih_tzu.git","svn_url":"https://github.com/pboling/flag_shih_tzu","homepage":"http://devblog.xing.com/ruby-on-rails/a-rails-plugin-to-store-a-collection-of-boolean-values-as-a-single-bit-field/","size":795,"stargazers_count":322,"watchers_count":322,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":1,"forks":38,"open_issues":1,"watchers":322,"default_branch":"master"}},"base":{"label":"pboling:master","ref":"master","sha":"334635939e0b9a377cb3c2efc632f26df06da387","user":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"repo":{"id":148333,"name":"flag_shih_tzu","full_name":"pboling/flag_shih_tzu","owner":{"login":"pboling","id":19505,"avatar_url":"https://avatars.githubusercontent.com/u/19505?v=3","gravatar_id":"","url":"https://api.github.com/users/pboling","html_url":"https://github.com/pboling","followers_url":"https://api.github.com/users/pboling/followers","following_url":"https://api.github.com/users/pboling/following{/other_user}","gists_url":"https://api.github.com/users/pboling/gists{/gist_id}","starred_url":"https://api.github.com/users/pboling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pboling/subscriptions","organizations_url":"https://api.github.com/users/pboling/orgs","repos_url":"https://api.github.com/users/pboling/repos","events_url":"https://api.github.com/users/pboling/events{/privacy}","received_events_url":"https://api.github.com/users/pboling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pboling/flag_shih_tzu","description":"Bit fields for ActiveRecord","fork":false,"url":"https://api.github.com/repos/pboling/flag_shih_tzu","forks_url":"https://api.github.com/repos/pboling/flag_shih_tzu/forks","keys_url":"https://api.github.com/repos/pboling/flag_shih_tzu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pboling/flag_shih_tzu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pboling/flag_shih_tzu/teams","hooks_url":"https://api.github.com/repos/pboling/flag_shih_tzu/hooks","issue_events_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/events{/number}","events_url":"https://api.github.com/repos/pboling/flag_shih_tzu/events","assignees_url":"https://api.github.com/repos/pboling/flag_shih_tzu/assignees{/user}","branches_url":"https://api.github.com/repos/pboling/flag_shih_tzu/branches{/branch}","tags_url":"https://api.github.com/repos/pboling/flag_shih_tzu/tags","blobs_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/refs{/sha}","trees_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pboling/flag_shih_tzu/statuses/{sha}","languages_url":"https://api.github.com/repos/pboling/flag_shih_tzu/languages","stargazers_url":"https://api.github.com/repos/pboling/flag_shih_tzu/stargazers","contributors_url":"https://api.github.com/repos/pboling/flag_shih_tzu/contributors","subscribers_url":"https://api.github.com/repos/pboling/flag_shih_tzu/subscribers","subscription_url":"https://api.github.com/repos/pboling/flag_shih_tzu/subscription","commits_url":"https://api.github.com/repos/pboling/flag_shih_tzu/commits{/sha}","git_commits_url":"https://api.github.com/repos/pboling/flag_shih_tzu/git/commits{/sha}","comments_url":"https://api.github.com/repos/pboling/flag_shih_tzu/comments{/number}","issue_comment_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/comments{/number}","contents_url":"https://api.github.com/repos/pboling/flag_shih_tzu/contents/{+path}","compare_url":"https://api.github.com/repos/pboling/flag_shih_tzu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pboling/flag_shih_tzu/merges","archive_url":"https://api.github.com/repos/pboling/flag_shih_tzu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pboling/flag_shih_tzu/downloads","issues_url":"https://api.github.com/repos/pboling/flag_shih_tzu/issues{/number}","pulls_url":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls{/number}","milestones_url":"https://api.github.com/repos/pboling/flag_shih_tzu/milestones{/number}","notifications_url":"https://api.github.com/repos/pboling/flag_shih_tzu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pboling/flag_shih_tzu/labels{/name}","releases_url":"https://api.github.com/repos/pboling/flag_shih_tzu/releases{/id}","created_at":"2009-03-11T12:00:28Z","updated_at":"2015-09-30T18:23:01Z","pushed_at":"2015-10-07T10:42:50Z","git_url":"git://github.com/pboling/flag_shih_tzu.git","ssh_url":"git@github.com:pboling/flag_shih_tzu.git","clone_url":"https://github.com/pboling/flag_shih_tzu.git","svn_url":"https://github.com/pboling/flag_shih_tzu","homepage":"http://devblog.xing.com/ruby-on-rails/a-rails-plugin-to-store-a-collection-of-boolean-values-as-a-single-bit-field/","size":795,"stargazers_count":322,"watchers_count":322,"language":"Ruby","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":38,"mirror_url":null,"open_issues_count":1,"forks":38,"open_issues":1,"watchers":322,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50"},"html":{"href":"https://github.com/pboling/flag_shih_tzu/pull/50"},"issue":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/50"},"comments":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/pboling/flag_shih_tzu/statuses/e10af12a45defa878e3967b9a160790b24ddb7a3"}}}}