{"action":"closed","number":119,"pull_request":{"url":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/119","id":35357919,"html_url":"https://github.com/AmpersandJS/ampersand-view/pull/119","diff_url":"https://github.com/AmpersandJS/ampersand-view/pull/119.diff","patch_url":"https://github.com/AmpersandJS/ampersand-view/pull/119.patch","issue_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues/119","number":119,"state":"closed","locked":false,"title":"bugfix/report-rendered-honestly","user":{"login":"cdaringe","id":1003261,"avatar_url":"https://avatars.githubusercontent.com/u/1003261?v=3","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"body":"# problem statement\r\n`.rendered` yields true when the view is **not** rendered\r\n http://requirebin.com/?gist=34edb359882bce0c85ae\r\n\r\n# solution\r\n- wrap user provided render/remove setters and getters to manage `rendered` state\r\n\r\nthis is an alternative implementation to https://github.com/AmpersandJS/ampersand-view/pull/115","created_at":"2015-05-13T18:46:25Z","updated_at":"2015-06-16T21:18:10Z","closed_at":"2015-06-16T21:18:10Z","merged_at":"2015-06-16T21:18:10Z","merge_commit_sha":"371f902fa4fb2b386715f40cd7fcea3d1ca985e1","assignee":null,"milestone":{"url":"https://api.github.com/repos/AmpersandJS/ampersand-view/milestones/1","html_url":"https://github.com/AmpersandJS/ampersand-view/milestones/8.0.0","labels_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/milestones/1/labels","id":1161107,"number":1,"title":"8.0.0","description":null,"creator":{"login":"kamilogorek","id":1523305,"avatar_url":"https://avatars.githubusercontent.com/u/1523305?v=3","gravatar_id":"","url":"https://api.github.com/users/kamilogorek","html_url":"https://github.com/kamilogorek","followers_url":"https://api.github.com/users/kamilogorek/followers","following_url":"https://api.github.com/users/kamilogorek/following{/other_user}","gists_url":"https://api.github.com/users/kamilogorek/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilogorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilogorek/subscriptions","organizations_url":"https://api.github.com/users/kamilogorek/orgs","repos_url":"https://api.github.com/users/kamilogorek/repos","events_url":"https://api.github.com/users/kamilogorek/events{/privacy}","received_events_url":"https://api.github.com/users/kamilogorek/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":1,"state":"open","created_at":"2015-06-11T22:43:56Z","updated_at":"2015-06-16T21:18:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/119/commits","review_comments_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/119/comments","review_comment_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues/119/comments","statuses_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/statuses/5219936ae6d315cfecf5b3f79762382cd1696950","head":{"label":"cdaringe:bugfix/rendered-invalid","ref":"bugfix/rendered-invalid","sha":"5219936ae6d315cfecf5b3f79762382cd1696950","user":{"login":"cdaringe","id":1003261,"avatar_url":"https://avatars.githubusercontent.com/u/1003261?v=3","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"repo":{"id":34308690,"name":"ampersand-view","full_name":"cdaringe/ampersand-view","owner":{"login":"cdaringe","id":1003261,"avatar_url":"https://avatars.githubusercontent.com/u/1003261?v=3","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdaringe/ampersand-view","description":"A smart base view for Backbone apps, to make it easy to bind collections and properties to the DOM.","fork":true,"url":"https://api.github.com/repos/cdaringe/ampersand-view","forks_url":"https://api.github.com/repos/cdaringe/ampersand-view/forks","keys_url":"https://api.github.com/repos/cdaringe/ampersand-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdaringe/ampersand-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdaringe/ampersand-view/teams","hooks_url":"https://api.github.com/repos/cdaringe/ampersand-view/hooks","issue_events_url":"https://api.github.com/repos/cdaringe/ampersand-view/issues/events{/number}","events_url":"https://api.github.com/repos/cdaringe/ampersand-view/events","assignees_url":"https://api.github.com/repos/cdaringe/ampersand-view/assignees{/user}","branches_url":"https://api.github.com/repos/cdaringe/ampersand-view/branches{/branch}","tags_url":"https://api.github.com/repos/cdaringe/ampersand-view/tags","blobs_url":"https://api.github.com/repos/cdaringe/ampersand-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdaringe/ampersand-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdaringe/ampersand-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdaringe/ampersand-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdaringe/ampersand-view/statuses/{sha}","languages_url":"https://api.github.com/repos/cdaringe/ampersand-view/languages","stargazers_url":"https://api.github.com/repos/cdaringe/ampersand-view/stargazers","contributors_url":"https://api.github.com/repos/cdaringe/ampersand-view/contributors","subscribers_url":"https://api.github.com/repos/cdaringe/ampersand-view/subscribers","subscription_url":"https://api.github.com/repos/cdaringe/ampersand-view/subscription","commits_url":"https://api.github.com/repos/cdaringe/ampersand-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdaringe/ampersand-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdaringe/ampersand-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdaringe/ampersand-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdaringe/ampersand-view/contents/{+path}","compare_url":"https://api.github.com/repos/cdaringe/ampersand-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdaringe/ampersand-view/merges","archive_url":"https://api.github.com/repos/cdaringe/ampersand-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdaringe/ampersand-view/downloads","issues_url":"https://api.github.com/repos/cdaringe/ampersand-view/issues{/number}","pulls_url":"https://api.github.com/repos/cdaringe/ampersand-view/pulls{/number}","milestones_url":"https://api.github.com/repos/cdaringe/ampersand-view/milestones{/number}","notifications_url":"https://api.github.com/repos/cdaringe/ampersand-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdaringe/ampersand-view/labels{/name}","releases_url":"https://api.github.com/repos/cdaringe/ampersand-view/releases{/id}","created_at":"2015-04-21T06:28:02Z","updated_at":"2015-05-01T06:03:30Z","pushed_at":"2015-06-03T00:03:37Z","git_url":"git://github.com/cdaringe/ampersand-view.git","ssh_url":"git@github.com:cdaringe/ampersand-view.git","clone_url":"https://github.com/cdaringe/ampersand-view.git","svn_url":"https://github.com/cdaringe/ampersand-view","homepage":"http://ampersandjs.com","size":656,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AmpersandJS:master","ref":"master","sha":"8498273b7795c99097cf4f671431904245480c83","user":{"login":"AmpersandJS","id":6932645,"avatar_url":"https://avatars.githubusercontent.com/u/6932645?v=3","gravatar_id":"","url":"https://api.github.com/users/AmpersandJS","html_url":"https://github.com/AmpersandJS","followers_url":"https://api.github.com/users/AmpersandJS/followers","following_url":"https://api.github.com/users/AmpersandJS/following{/other_user}","gists_url":"https://api.github.com/users/AmpersandJS/gists{/gist_id}","starred_url":"https://api.github.com/users/AmpersandJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmpersandJS/subscriptions","organizations_url":"https://api.github.com/users/AmpersandJS/orgs","repos_url":"https://api.github.com/users/AmpersandJS/repos","events_url":"https://api.github.com/users/AmpersandJS/events{/privacy}","received_events_url":"https://api.github.com/users/AmpersandJS/received_events","type":"Organization","site_admin":false},"repo":{"id":17788258,"name":"ampersand-view","full_name":"AmpersandJS/ampersand-view","owner":{"login":"AmpersandJS","id":6932645,"avatar_url":"https://avatars.githubusercontent.com/u/6932645?v=3","gravatar_id":"","url":"https://api.github.com/users/AmpersandJS","html_url":"https://github.com/AmpersandJS","followers_url":"https://api.github.com/users/AmpersandJS/followers","following_url":"https://api.github.com/users/AmpersandJS/following{/other_user}","gists_url":"https://api.github.com/users/AmpersandJS/gists{/gist_id}","starred_url":"https://api.github.com/users/AmpersandJS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmpersandJS/subscriptions","organizations_url":"https://api.github.com/users/AmpersandJS/orgs","repos_url":"https://api.github.com/users/AmpersandJS/repos","events_url":"https://api.github.com/users/AmpersandJS/events{/privacy}","received_events_url":"https://api.github.com/users/AmpersandJS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/AmpersandJS/ampersand-view","description":"A smart base view for Backbone apps, to make it easy to bind collections and properties to the DOM.","fork":false,"url":"https://api.github.com/repos/AmpersandJS/ampersand-view","forks_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/forks","keys_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/teams","hooks_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/hooks","issue_events_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues/events{/number}","events_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/events","assignees_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/assignees{/user}","branches_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/branches{/branch}","tags_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/tags","blobs_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/git/refs{/sha}","trees_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/statuses/{sha}","languages_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/languages","stargazers_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/stargazers","contributors_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/contributors","subscribers_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/subscribers","subscription_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/subscription","commits_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/commits{/sha}","git_commits_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/git/commits{/sha}","comments_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/comments{/number}","issue_comment_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues/comments{/number}","contents_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/contents/{+path}","compare_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/merges","archive_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/downloads","issues_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues{/number}","pulls_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls{/number}","milestones_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/milestones{/number}","notifications_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/labels{/name}","releases_url":"https://api.github.com/repos/AmpersandJS/ampersand-view/releases{/id}","created_at":"2014-03-15T23:50:31Z","updated_at":"2015-06-16T09:02:33Z","pushed_at":"2015-06-16T21:18:10Z","git_url":"git://github.com/AmpersandJS/ampersand-view.git","ssh_url":"git@github.com:AmpersandJS/ampersand-view.git","clone_url":"https://github.com/AmpersandJS/ampersand-view.git","svn_url":"https://github.com/AmpersandJS/ampersand-view","homepage":"http://ampersandjs.com","size":1485,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":32,"forks":33,"open_issues":32,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/119"},"html":{"href":"https://github.com/AmpersandJS/ampersand-view/pull/119"},"issue":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues/119"},"comments":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/AmpersandJS/ampersand-view/statuses/5219936ae6d315cfecf5b3f79762382cd1696950"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"cdaringe","id":1003261,"avatar_url":"https://avatars.githubusercontent.com/u/1003261?v=3","gravatar_id":"","url":"https://api.github.com/users/cdaringe","html_url":"https://github.com/cdaringe","followers_url":"https://api.github.com/users/cdaringe/followers","following_url":"https://api.github.com/users/cdaringe/following{/other_user}","gists_url":"https://api.github.com/users/cdaringe/gists{/gist_id}","starred_url":"https://api.github.com/users/cdaringe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdaringe/subscriptions","organizations_url":"https://api.github.com/users/cdaringe/orgs","repos_url":"https://api.github.com/users/cdaringe/repos","events_url":"https://api.github.com/users/cdaringe/events{/privacy}","received_events_url":"https://api.github.com/users/cdaringe/received_events","type":"User","site_admin":false},"comments":14,"review_comments":10,"commits":6,"additions":146,"deletions":19,"changed_files":4}}