{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments/47709499","id":47709499,"diff_hunk":"@@ -38,14 +40,25 @@\n       $mcodirs = [$mco_dir]\n \n       $path_separator = ':'\n+\n+      $user  = 0\n+      $group = 0\n     }\n     'windows' : {\n+      $package_name = 'puppet-agent'\n+      $service_names = ['puppet', 'mcollective']\n+\n+      $local_packages_dir = 'C:\\\\Program Files\\\\Puppet Labs\\\\Puppet Enterprise\\\\packages'","path":"manifests/params.pp","position":21,"original_position":21,"commit_id":"9b405296576f29646a0d0770baf160fac8e66ef0","original_commit_id":"9b405296576f29646a0d0770baf160fac8e66ef0","user":{"login":"joshcooper","id":737664,"avatar_url":"https://avatars.githubusercontent.com/u/737664?v=3","gravatar_id":"","url":"https://api.github.com/users/joshcooper","html_url":"https://github.com/joshcooper","followers_url":"https://api.github.com/users/joshcooper/followers","following_url":"https://api.github.com/users/joshcooper/following{/other_user}","gists_url":"https://api.github.com/users/joshcooper/gists{/gist_id}","starred_url":"https://api.github.com/users/joshcooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshcooper/subscriptions","organizations_url":"https://api.github.com/users/joshcooper/orgs","repos_url":"https://api.github.com/users/joshcooper/repos","events_url":"https://api.github.com/users/joshcooper/events{/privacy}","received_events_url":"https://api.github.com/users/joshcooper/received_events","type":"User","site_admin":false},"body":"Another thought is to use `C:\\ProgramData\\PuppetLabs` instead (I think there's a PE `common_appdata` fact for that). If you write to `C:\\Program Files` then those files will prevent puppet from uninstalling cleanly (it will leave behind the new files and any parent directories). It's not a big deal, but not ideal. Also if you are running puppet as \"non-root\", puppet may not have permission to write to `C:\\Program Files`, but it can write to `C:\\ProgramData`","created_at":"2015-12-15T22:31:12Z","updated_at":"2015-12-15T22:31:12Z","html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/66#discussion_r47709499","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments/47709499"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/66#discussion_r47709499"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66","id":46061468,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/66","diff_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/66.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/66.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/66","number":66,"state":"open","locked":false,"title":"(PE-10956) windows upgrade","user":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"body":"Adds a PE-hosted MSI option for upgrading pre-2015 agents.\r\n\r\nThis PR includes Josh's changes from https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/65 . That PR should be merged first, then this one re-based.","created_at":"2015-09-25T21:43:20Z","updated_at":"2015-12-15T22:31:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e967fbc25684e28c1f163f77b55279e792bbadc8","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/66/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/9b405296576f29646a0d0770baf160fac8e66ef0","head":{"label":"highb:master-pe-10956_windows_upgrade","ref":"master-pe-10956_windows_upgrade","sha":"9b405296576f29646a0d0770baf160fac8e66ef0","user":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"repo":{"id":42746934,"name":"puppetlabs-puppet_agent","full_name":"highb/puppetlabs-puppet_agent","owner":{"login":"highb","id":759848,"avatar_url":"https://avatars.githubusercontent.com/u/759848?v=3","gravatar_id":"","url":"https://api.github.com/users/highb","html_url":"https://github.com/highb","followers_url":"https://api.github.com/users/highb/followers","following_url":"https://api.github.com/users/highb/following{/other_user}","gists_url":"https://api.github.com/users/highb/gists{/gist_id}","starred_url":"https://api.github.com/users/highb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highb/subscriptions","organizations_url":"https://api.github.com/users/highb/orgs","repos_url":"https://api.github.com/users/highb/repos","events_url":"https://api.github.com/users/highb/events{/privacy}","received_events_url":"https://api.github.com/users/highb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/highb/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":true,"url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/highb/puppetlabs-puppet_agent/releases{/id}","created_at":"2015-09-18T21:03:46Z","updated_at":"2015-09-18T21:03:47Z","pushed_at":"2015-12-15T20:31:00Z","git_url":"git://github.com/highb/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:highb/puppetlabs-puppet_agent.git","clone_url":"https://github.com/highb/puppetlabs-puppet_agent.git","svn_url":"https://github.com/highb/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/PUP","size":208,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"075bca1b9bfa8e5dd2a42a178d24b03a20f0dab9","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":35058943,"name":"puppetlabs-puppet_agent","full_name":"puppetlabs/puppetlabs-puppet_agent","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","description":"Module for managing Puppet-Agent","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/releases{/id}","created_at":"2015-05-04T20:50:16Z","updated_at":"2015-12-15T14:01:40Z","pushed_at":"2015-12-15T20:31:00Z","git_url":"git://github.com/puppetlabs/puppetlabs-puppet_agent.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-puppet_agent.git","clone_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent.git","svn_url":"https://github.com/puppetlabs/puppetlabs-puppet_agent","homepage":"https://tickets.puppetlabs.com/browse/PUP","size":282,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":3,"forks":24,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-puppet_agent/pull/66"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/66"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-puppet_agent/statuses/9b405296576f29646a0d0770baf160fac8e66ef0"}}}}