{"action":"created","issue":{"url":"https://api.github.com/repos/erlang/otp/issues/599","labels_url":"https://api.github.com/repos/erlang/otp/issues/599/labels{/name}","comments_url":"https://api.github.com/repos/erlang/otp/issues/599/comments","events_url":"https://api.github.com/repos/erlang/otp/issues/599/events","html_url":"https://github.com/erlang/otp/pull/599","id":56008272,"number":599,"title":"OTP-11660: make eunit unicode safe","user":{"login":"vladdu","id":9707,"avatar_url":"https://avatars.githubusercontent.com/u/9707?v=3","gravatar_id":"","url":"https://api.github.com/users/vladdu","html_url":"https://github.com/vladdu","followers_url":"https://api.github.com/users/vladdu/followers","following_url":"https://api.github.com/users/vladdu/following{/other_user}","gists_url":"https://api.github.com/users/vladdu/gists{/gist_id}","starred_url":"https://api.github.com/users/vladdu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vladdu/subscriptions","organizations_url":"https://api.github.com/users/vladdu/orgs","repos_url":"https://api.github.com/users/vladdu/repos","events_url":"https://api.github.com/users/vladdu/events{/privacy}","received_events_url":"https://api.github.com/users/vladdu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":4,"created_at":"2015-01-30T08:47:47Z","updated_at":"2015-02-25T16:07:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/erlang/otp/pulls/599","html_url":"https://github.com/erlang/otp/pull/599","diff_url":"https://github.com/erlang/otp/pull/599.diff","patch_url":"https://github.com/erlang/otp/pull/599.patch"},"body":"The most critical part is eunit_surefire, because the generated XML\r\nmust be correct UTF-8, otherwise tools will refuse to work with it.\r\n\r\nThe tricky part is that the input can contain mixed encodings and we\r\ncan't know which encoding applies to each text chunk. This is because\r\ninput can be from io:format in the tests. Also, different test modules\r\nmight be encoded differently and that can't be detected at runtime. We\r\nhave to avoid outputting both bad utf-8 and doubly encoded utf-8.\r\n\r\nThe simplest solution is to let the encoder skip characters it chokes\r\non, replacing them with '?'."},"comment":{"url":"https://api.github.com/repos/erlang/otp/issues/comments/75988173","html_url":"https://github.com/erlang/otp/pull/599#issuecomment-75988173","issue_url":"https://api.github.com/repos/erlang/otp/issues/599","id":75988173,"user":{"login":"dgud","id":80937,"avatar_url":"https://avatars.githubusercontent.com/u/80937?v=3","gravatar_id":"","url":"https://api.github.com/users/dgud","html_url":"https://github.com/dgud","followers_url":"https://api.github.com/users/dgud/followers","following_url":"https://api.github.com/users/dgud/following{/other_user}","gists_url":"https://api.github.com/users/dgud/gists{/gist_id}","starred_url":"https://api.github.com/users/dgud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgud/subscriptions","organizations_url":"https://api.github.com/users/dgud/orgs","repos_url":"https://api.github.com/users/dgud/repos","events_url":"https://api.github.com/users/dgud/events{/privacy}","received_events_url":"https://api.github.com/users/dgud/received_events","type":"User","site_admin":false},"created_at":"2015-02-25T16:07:25Z","updated_at":"2015-02-25T16:07:25Z","body":"I understand that is hard but as it is I can not accept the patch."}}