{"action":"created","issue":{"url":"https://api.github.com/repos/tj/co/issues/191","labels_url":"https://api.github.com/repos/tj/co/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/tj/co/issues/191/comments","events_url":"https://api.github.com/repos/tj/co/issues/191/events","html_url":"https://github.com/tj/co/pull/191","id":54947160,"number":191,"title":"implement alternate generatorfunction test","user":{"login":"mlrawlings","id":1958812,"avatar_url":"https://avatars.githubusercontent.com/u/1958812?v=3","gravatar_id":"","url":"https://api.github.com/users/mlrawlings","html_url":"https://github.com/mlrawlings","followers_url":"https://api.github.com/users/mlrawlings/followers","following_url":"https://api.github.com/users/mlrawlings/following{/other_user}","gists_url":"https://api.github.com/users/mlrawlings/gists{/gist_id}","starred_url":"https://api.github.com/users/mlrawlings/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlrawlings/subscriptions","organizations_url":"https://api.github.com/users/mlrawlings/orgs","repos_url":"https://api.github.com/users/mlrawlings/repos","events_url":"https://api.github.com/users/mlrawlings/events{/privacy}","received_events_url":"https://api.github.com/users/mlrawlings/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":7,"created_at":"2015-01-20T22:05:49Z","updated_at":"2015-01-21T02:52:53Z","closed_at":"2015-01-21T02:03:57Z","pull_request":{"url":"https://api.github.com/repos/tj/co/pulls/191","html_url":"https://github.com/tj/co/pull/191","diff_url":"https://github.com/tj/co/pull/191.diff","patch_url":"https://github.com/tj/co/pull/191.patch"},"body":"co's `isGeneratorFunction` test requires the constructor name to equal `'GeneratorFunction'`, which although conforms to the spec, has caused issues with scripts transpiled to es5 (https://github.com/google/traceur-compiler/issues/616) (https://github.com/facebook/regenerator/issues/48).  \r\n\r\nBoth traceur and regenerator have fixed this issue by wrapping generators in their runtimes, but if either runtime is minified that  constructor name, `GeneratorFunction`, will be compressed/removed and the test will fail.\r\n\r\nTesting against the constructor of a known generator makes the constructor name irrelevant, and the code is just as straight-forward."},"comment":{"url":"https://api.github.com/repos/tj/co/issues/comments/70776235","html_url":"https://github.com/tj/co/pull/191#issuecomment-70776235","issue_url":"https://api.github.com/repos/tj/co/issues/191","id":70776235,"user":{"login":"jonathanong","id":643505,"avatar_url":"https://avatars.githubusercontent.com/u/643505?v=3","gravatar_id":"","url":"https://api.github.com/users/jonathanong","html_url":"https://github.com/jonathanong","followers_url":"https://api.github.com/users/jonathanong/followers","following_url":"https://api.github.com/users/jonathanong/following{/other_user}","gists_url":"https://api.github.com/users/jonathanong/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathanong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathanong/subscriptions","organizations_url":"https://api.github.com/users/jonathanong/orgs","repos_url":"https://api.github.com/users/jonathanong/repos","events_url":"https://api.github.com/users/jonathanong/events{/privacy}","received_events_url":"https://api.github.com/users/jonathanong/received_events","type":"User","site_admin":false},"created_at":"2015-01-21T02:52:53Z","updated_at":"2015-01-21T02:52:53Z","body":"oh fuckkkk this breaks support for versions of node without generator support. lol. "}}