{"action":"created","comment":{"url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/comments/47803723","id":47803723,"diff_hunk":"@@ -0,0 +1,27 @@\n+module.exports = PhoneNumber;\n+\n+function PhoneNumber (num) {\n+  num = num.replace(/[(]|[)]|[-]|[\\s]|[.]/g, '');\n+  this.number = function () {\n+    if (num.length === 11 && num[0] === '1') {\n+      num = num.slice(1);\n+      return num;\n+    }\n+    else if (num.length !== 10){\n+      num = '0000000000';\n+      return num;\n+    } else {","path":"javascript/phone-number.js","position":13,"original_position":13,"commit_id":"73f810c4c2137c899994859ef21dec49d522b0af","original_commit_id":"73f810c4c2137c899994859ef21dec49d522b0af","user":{"login":"dcalhoun","id":438664,"avatar_url":"https://avatars.githubusercontent.com/u/438664?v=3","gravatar_id":"","url":"https://api.github.com/users/dcalhoun","html_url":"https://github.com/dcalhoun","followers_url":"https://api.github.com/users/dcalhoun/followers","following_url":"https://api.github.com/users/dcalhoun/following{/other_user}","gists_url":"https://api.github.com/users/dcalhoun/gists{/gist_id}","starred_url":"https://api.github.com/users/dcalhoun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcalhoun/subscriptions","organizations_url":"https://api.github.com/users/dcalhoun/orgs","repos_url":"https://api.github.com/users/dcalhoun/repos","events_url":"https://api.github.com/users/dcalhoun/events{/privacy}","received_events_url":"https://api.github.com/users/dcalhoun/received_events","type":"User","site_admin":false},"body":":+1: Nice job on the short `if/else` conditional. You could potentially make it shorter by eliminating this last `else` by having your method always return `num`, with your conditional modifying `num` when necessary.","created_at":"2015-12-16T17:07:11Z","updated_at":"2015-12-16T17:07:11Z","html_url":"https://github.com/HealthTeacher/dev-exercises/pull/4#discussion_r47803723","pull_request_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4","_links":{"self":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/comments/47803723"},"html":{"href":"https://github.com/HealthTeacher/dev-exercises/pull/4#discussion_r47803723"},"pull_request":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4","id":50909903,"html_url":"https://github.com/HealthTeacher/dev-exercises/pull/4","diff_url":"https://github.com/HealthTeacher/dev-exercises/pull/4.diff","patch_url":"https://github.com/HealthTeacher/dev-exercises/pull/4.patch","issue_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues/4","number":4,"state":"open","locked":false,"title":"Finished JavaScript & CSS dev-exercises","user":{"login":"ldmcdaniel","id":11837741,"avatar_url":"https://avatars.githubusercontent.com/u/11837741?v=3","gravatar_id":"","url":"https://api.github.com/users/ldmcdaniel","html_url":"https://github.com/ldmcdaniel","followers_url":"https://api.github.com/users/ldmcdaniel/followers","following_url":"https://api.github.com/users/ldmcdaniel/following{/other_user}","gists_url":"https://api.github.com/users/ldmcdaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/ldmcdaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldmcdaniel/subscriptions","organizations_url":"https://api.github.com/users/ldmcdaniel/orgs","repos_url":"https://api.github.com/users/ldmcdaniel/repos","events_url":"https://api.github.com/users/ldmcdaniel/events{/privacy}","received_events_url":"https://api.github.com/users/ldmcdaniel/received_events","type":"User","site_admin":false},"body":"Hello:\r\n\r\nI have finished the dev-exercises for the front-end JavaScript position.  Please review my code and let me know what you think as I spent quite a bit of time on this (especially the CSS section).\r\n\r\nKind regards,\r\n\r\nLucas McDaniel","created_at":"2015-11-17T06:41:11Z","updated_at":"2015-12-16T17:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa6d0645b37397c2d8a8a2f47a9ed55c5c82639e","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4/commits","review_comments_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4/comments","review_comment_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues/4/comments","statuses_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/statuses/73f810c4c2137c899994859ef21dec49d522b0af","head":{"label":"ldmcdaniel:master","ref":"master","sha":"73f810c4c2137c899994859ef21dec49d522b0af","user":{"login":"ldmcdaniel","id":11837741,"avatar_url":"https://avatars.githubusercontent.com/u/11837741?v=3","gravatar_id":"","url":"https://api.github.com/users/ldmcdaniel","html_url":"https://github.com/ldmcdaniel","followers_url":"https://api.github.com/users/ldmcdaniel/followers","following_url":"https://api.github.com/users/ldmcdaniel/following{/other_user}","gists_url":"https://api.github.com/users/ldmcdaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/ldmcdaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldmcdaniel/subscriptions","organizations_url":"https://api.github.com/users/ldmcdaniel/orgs","repos_url":"https://api.github.com/users/ldmcdaniel/repos","events_url":"https://api.github.com/users/ldmcdaniel/events{/privacy}","received_events_url":"https://api.github.com/users/ldmcdaniel/received_events","type":"User","site_admin":false},"repo":{"id":46020790,"name":"dev-exercises","full_name":"ldmcdaniel/dev-exercises","owner":{"login":"ldmcdaniel","id":11837741,"avatar_url":"https://avatars.githubusercontent.com/u/11837741?v=3","gravatar_id":"","url":"https://api.github.com/users/ldmcdaniel","html_url":"https://github.com/ldmcdaniel","followers_url":"https://api.github.com/users/ldmcdaniel/followers","following_url":"https://api.github.com/users/ldmcdaniel/following{/other_user}","gists_url":"https://api.github.com/users/ldmcdaniel/gists{/gist_id}","starred_url":"https://api.github.com/users/ldmcdaniel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldmcdaniel/subscriptions","organizations_url":"https://api.github.com/users/ldmcdaniel/orgs","repos_url":"https://api.github.com/users/ldmcdaniel/repos","events_url":"https://api.github.com/users/ldmcdaniel/events{/privacy}","received_events_url":"https://api.github.com/users/ldmcdaniel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ldmcdaniel/dev-exercises","description":"Exercises for potential developer candidates.","fork":true,"url":"https://api.github.com/repos/ldmcdaniel/dev-exercises","forks_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/forks","keys_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/teams","hooks_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/hooks","issue_events_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/issues/events{/number}","events_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/events","assignees_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/assignees{/user}","branches_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/branches{/branch}","tags_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/tags","blobs_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/languages","stargazers_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/stargazers","contributors_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/contributors","subscribers_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/subscribers","subscription_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/subscription","commits_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/contents/{+path}","compare_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/merges","archive_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/downloads","issues_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/issues{/number}","pulls_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/labels{/name}","releases_url":"https://api.github.com/repos/ldmcdaniel/dev-exercises/releases{/id}","created_at":"2015-11-12T01:16:53Z","updated_at":"2015-11-17T04:03:12Z","pushed_at":"2015-11-17T06:35:29Z","git_url":"git://github.com/ldmcdaniel/dev-exercises.git","ssh_url":"git@github.com:ldmcdaniel/dev-exercises.git","clone_url":"https://github.com/ldmcdaniel/dev-exercises.git","svn_url":"https://github.com/ldmcdaniel/dev-exercises","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HealthTeacher:master","ref":"master","sha":"b6c2f9381268b41142051fe65eb4a328b783f448","user":{"login":"HealthTeacher","id":1416897,"avatar_url":"https://avatars.githubusercontent.com/u/1416897?v=3","gravatar_id":"","url":"https://api.github.com/users/HealthTeacher","html_url":"https://github.com/HealthTeacher","followers_url":"https://api.github.com/users/HealthTeacher/followers","following_url":"https://api.github.com/users/HealthTeacher/following{/other_user}","gists_url":"https://api.github.com/users/HealthTeacher/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthTeacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthTeacher/subscriptions","organizations_url":"https://api.github.com/users/HealthTeacher/orgs","repos_url":"https://api.github.com/users/HealthTeacher/repos","events_url":"https://api.github.com/users/HealthTeacher/events{/privacy}","received_events_url":"https://api.github.com/users/HealthTeacher/received_events","type":"Organization","site_admin":false},"repo":{"id":44995237,"name":"dev-exercises","full_name":"HealthTeacher/dev-exercises","owner":{"login":"HealthTeacher","id":1416897,"avatar_url":"https://avatars.githubusercontent.com/u/1416897?v=3","gravatar_id":"","url":"https://api.github.com/users/HealthTeacher","html_url":"https://github.com/HealthTeacher","followers_url":"https://api.github.com/users/HealthTeacher/followers","following_url":"https://api.github.com/users/HealthTeacher/following{/other_user}","gists_url":"https://api.github.com/users/HealthTeacher/gists{/gist_id}","starred_url":"https://api.github.com/users/HealthTeacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HealthTeacher/subscriptions","organizations_url":"https://api.github.com/users/HealthTeacher/orgs","repos_url":"https://api.github.com/users/HealthTeacher/repos","events_url":"https://api.github.com/users/HealthTeacher/events{/privacy}","received_events_url":"https://api.github.com/users/HealthTeacher/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HealthTeacher/dev-exercises","description":"Exercises for potential developer candidates.","fork":false,"url":"https://api.github.com/repos/HealthTeacher/dev-exercises","forks_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/forks","keys_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/teams","hooks_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/hooks","issue_events_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues/events{/number}","events_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/events","assignees_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/assignees{/user}","branches_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/branches{/branch}","tags_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/tags","blobs_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/git/refs{/sha}","trees_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/statuses/{sha}","languages_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/languages","stargazers_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/stargazers","contributors_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/contributors","subscribers_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/subscribers","subscription_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/subscription","commits_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/commits{/sha}","git_commits_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/git/commits{/sha}","comments_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/comments{/number}","issue_comment_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues/comments{/number}","contents_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/contents/{+path}","compare_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/merges","archive_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/downloads","issues_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues{/number}","pulls_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls{/number}","milestones_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/milestones{/number}","notifications_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/labels{/name}","releases_url":"https://api.github.com/repos/HealthTeacher/dev-exercises/releases{/id}","created_at":"2015-10-26T20:27:57Z","updated_at":"2015-11-11T17:29:53Z","pushed_at":"2015-11-19T23:52:55Z","git_url":"git://github.com/HealthTeacher/dev-exercises.git","ssh_url":"git@github.com:HealthTeacher/dev-exercises.git","clone_url":"https://github.com/HealthTeacher/dev-exercises.git","svn_url":"https://github.com/HealthTeacher/dev-exercises","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":1,"forks":9,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4"},"html":{"href":"https://github.com/HealthTeacher/dev-exercises/pull/4"},"issue":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues/4"},"comments":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/HealthTeacher/dev-exercises/statuses/73f810c4c2137c899994859ef21dec49d522b0af"}}}}