{"action":"created","comment":{"url":"https://api.github.com/repos/hpicgs/libzeug/pulls/comments/31578312","id":31578312,"diff_hunk":"@@ -14,15 +14,32 @@ ScopedConnection::ScopedConnection(const Connection & connection)\n {\n }\n \n+ScopedConnection::ScopedConnection(ScopedConnection && other)\n+:   m_connection(other.m_connection)\n+{\n+    other.m_connection = Connection();","path":"source/signalzeug/source/ScopedConnection.cpp","position":7,"original_position":7,"commit_id":"bab1f3dca707a30de2b498f7e902850d5517d3c3","original_commit_id":"bab1f3dca707a30de2b498f7e902850d5517d3c3","user":{"login":"scheibel","id":2247733,"avatar_url":"https://avatars.githubusercontent.com/u/2247733?v=3","gravatar_id":"","url":"https://api.github.com/users/scheibel","html_url":"https://github.com/scheibel","followers_url":"https://api.github.com/users/scheibel/followers","following_url":"https://api.github.com/users/scheibel/following{/other_user}","gists_url":"https://api.github.com/users/scheibel/gists{/gist_id}","starred_url":"https://api.github.com/users/scheibel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scheibel/subscriptions","organizations_url":"https://api.github.com/users/scheibel/orgs","repos_url":"https://api.github.com/users/scheibel/repos","events_url":"https://api.github.com/users/scheibel/events{/privacy}","received_events_url":"https://api.github.com/users/scheibel/received_events","type":"User","site_admin":false},"body":"Why not use ```std::move``` here?","created_at":"2015-06-02T22:32:41Z","updated_at":"2015-06-02T22:32:41Z","html_url":"https://github.com/hpicgs/libzeug/pull/123#discussion_r31578312","pull_request_url":"https://api.github.com/repos/hpicgs/libzeug/pulls/123","_links":{"self":{"href":"https://api.github.com/repos/hpicgs/libzeug/pulls/comments/31578312"},"html":{"href":"https://github.com/hpicgs/libzeug/pull/123#discussion_r31578312"},"pull_request":{"href":"https://api.github.com/repos/hpicgs/libzeug/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/hpicgs/libzeug/pulls/123","id":33852511,"html_url":"https://github.com/hpicgs/libzeug/pull/123","diff_url":"https://github.com/hpicgs/libzeug/pull/123.diff","patch_url":"https://github.com/hpicgs/libzeug/pull/123.patch","issue_url":"https://api.github.com/repos/hpicgs/libzeug/issues/123","number":123,"state":"open","locked":false,"title":"Disallow copying of ScopedConnection & explicitly allow moving","user":{"login":"j-o","id":5197084,"avatar_url":"https://avatars.githubusercontent.com/u/5197084?v=3","gravatar_id":"","url":"https://api.github.com/users/j-o","html_url":"https://github.com/j-o","followers_url":"https://api.github.com/users/j-o/followers","following_url":"https://api.github.com/users/j-o/following{/other_user}","gists_url":"https://api.github.com/users/j-o/gists{/gist_id}","starred_url":"https://api.github.com/users/j-o/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-o/subscriptions","organizations_url":"https://api.github.com/users/j-o/orgs","repos_url":"https://api.github.com/users/j-o/repos","events_url":"https://api.github.com/users/j-o/events{/privacy}","received_events_url":"https://api.github.com/users/j-o/received_events","type":"User","site_admin":false},"body":"Prevents accidental disconnection due to reallocation when `ScopedConnection`s are stored in a container.","created_at":"2015-04-22T12:21:37Z","updated_at":"2015-06-02T22:32:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4dbe3f09bb7232de7ecba077f1f8e8c1fcb6fc3b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/hpicgs/libzeug/pulls/123/commits","review_comments_url":"https://api.github.com/repos/hpicgs/libzeug/pulls/123/comments","review_comment_url":"https://api.github.com/repos/hpicgs/libzeug/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpicgs/libzeug/issues/123/comments","statuses_url":"https://api.github.com/repos/hpicgs/libzeug/statuses/bab1f3dca707a30de2b498f7e902850d5517d3c3","head":{"label":"hpicgs:scoped_connection_copy_move","ref":"scoped_connection_copy_move","sha":"bab1f3dca707a30de2b498f7e902850d5517d3c3","user":{"login":"hpicgs","id":5174012,"avatar_url":"https://avatars.githubusercontent.com/u/5174012?v=3","gravatar_id":"","url":"https://api.github.com/users/hpicgs","html_url":"https://github.com/hpicgs","followers_url":"https://api.github.com/users/hpicgs/followers","following_url":"https://api.github.com/users/hpicgs/following{/other_user}","gists_url":"https://api.github.com/users/hpicgs/gists{/gist_id}","starred_url":"https://api.github.com/users/hpicgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpicgs/subscriptions","organizations_url":"https://api.github.com/users/hpicgs/orgs","repos_url":"https://api.github.com/users/hpicgs/repos","events_url":"https://api.github.com/users/hpicgs/events{/privacy}","received_events_url":"https://api.github.com/users/hpicgs/received_events","type":"Organization","site_admin":false},"repo":{"id":11925159,"name":"libzeug","full_name":"hpicgs/libzeug","owner":{"login":"hpicgs","id":5174012,"avatar_url":"https://avatars.githubusercontent.com/u/5174012?v=3","gravatar_id":"","url":"https://api.github.com/users/hpicgs","html_url":"https://github.com/hpicgs","followers_url":"https://api.github.com/users/hpicgs/followers","following_url":"https://api.github.com/users/hpicgs/following{/other_user}","gists_url":"https://api.github.com/users/hpicgs/gists{/gist_id}","starred_url":"https://api.github.com/users/hpicgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpicgs/subscriptions","organizations_url":"https://api.github.com/users/hpicgs/orgs","repos_url":"https://api.github.com/users/hpicgs/repos","events_url":"https://api.github.com/users/hpicgs/events{/privacy}","received_events_url":"https://api.github.com/users/hpicgs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpicgs/libzeug","description":"C++ sanctuary for small but powerful and frequently required, stand alone features.","fork":false,"url":"https://api.github.com/repos/hpicgs/libzeug","forks_url":"https://api.github.com/repos/hpicgs/libzeug/forks","keys_url":"https://api.github.com/repos/hpicgs/libzeug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpicgs/libzeug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpicgs/libzeug/teams","hooks_url":"https://api.github.com/repos/hpicgs/libzeug/hooks","issue_events_url":"https://api.github.com/repos/hpicgs/libzeug/issues/events{/number}","events_url":"https://api.github.com/repos/hpicgs/libzeug/events","assignees_url":"https://api.github.com/repos/hpicgs/libzeug/assignees{/user}","branches_url":"https://api.github.com/repos/hpicgs/libzeug/branches{/branch}","tags_url":"https://api.github.com/repos/hpicgs/libzeug/tags","blobs_url":"https://api.github.com/repos/hpicgs/libzeug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpicgs/libzeug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpicgs/libzeug/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpicgs/libzeug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpicgs/libzeug/statuses/{sha}","languages_url":"https://api.github.com/repos/hpicgs/libzeug/languages","stargazers_url":"https://api.github.com/repos/hpicgs/libzeug/stargazers","contributors_url":"https://api.github.com/repos/hpicgs/libzeug/contributors","subscribers_url":"https://api.github.com/repos/hpicgs/libzeug/subscribers","subscription_url":"https://api.github.com/repos/hpicgs/libzeug/subscription","commits_url":"https://api.github.com/repos/hpicgs/libzeug/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpicgs/libzeug/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpicgs/libzeug/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpicgs/libzeug/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpicgs/libzeug/contents/{+path}","compare_url":"https://api.github.com/repos/hpicgs/libzeug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpicgs/libzeug/merges","archive_url":"https://api.github.com/repos/hpicgs/libzeug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpicgs/libzeug/downloads","issues_url":"https://api.github.com/repos/hpicgs/libzeug/issues{/number}","pulls_url":"https://api.github.com/repos/hpicgs/libzeug/pulls{/number}","milestones_url":"https://api.github.com/repos/hpicgs/libzeug/milestones{/number}","notifications_url":"https://api.github.com/repos/hpicgs/libzeug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpicgs/libzeug/labels{/name}","releases_url":"https://api.github.com/repos/hpicgs/libzeug/releases{/id}","created_at":"2013-08-06T13:50:07Z","updated_at":"2015-05-07T11:59:00Z","pushed_at":"2015-05-14T21:07:39Z","git_url":"git://github.com/hpicgs/libzeug.git","ssh_url":"git@github.com:hpicgs/libzeug.git","clone_url":"https://github.com/hpicgs/libzeug.git","svn_url":"https://github.com/hpicgs/libzeug","homepage":"","size":5980,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":6,"default_branch":"master"}},"base":{"label":"hpicgs:master","ref":"master","sha":"ca6901a3e3157e77a3e54efdd2b96ddceaddc39c","user":{"login":"hpicgs","id":5174012,"avatar_url":"https://avatars.githubusercontent.com/u/5174012?v=3","gravatar_id":"","url":"https://api.github.com/users/hpicgs","html_url":"https://github.com/hpicgs","followers_url":"https://api.github.com/users/hpicgs/followers","following_url":"https://api.github.com/users/hpicgs/following{/other_user}","gists_url":"https://api.github.com/users/hpicgs/gists{/gist_id}","starred_url":"https://api.github.com/users/hpicgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpicgs/subscriptions","organizations_url":"https://api.github.com/users/hpicgs/orgs","repos_url":"https://api.github.com/users/hpicgs/repos","events_url":"https://api.github.com/users/hpicgs/events{/privacy}","received_events_url":"https://api.github.com/users/hpicgs/received_events","type":"Organization","site_admin":false},"repo":{"id":11925159,"name":"libzeug","full_name":"hpicgs/libzeug","owner":{"login":"hpicgs","id":5174012,"avatar_url":"https://avatars.githubusercontent.com/u/5174012?v=3","gravatar_id":"","url":"https://api.github.com/users/hpicgs","html_url":"https://github.com/hpicgs","followers_url":"https://api.github.com/users/hpicgs/followers","following_url":"https://api.github.com/users/hpicgs/following{/other_user}","gists_url":"https://api.github.com/users/hpicgs/gists{/gist_id}","starred_url":"https://api.github.com/users/hpicgs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpicgs/subscriptions","organizations_url":"https://api.github.com/users/hpicgs/orgs","repos_url":"https://api.github.com/users/hpicgs/repos","events_url":"https://api.github.com/users/hpicgs/events{/privacy}","received_events_url":"https://api.github.com/users/hpicgs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hpicgs/libzeug","description":"C++ sanctuary for small but powerful and frequently required, stand alone features.","fork":false,"url":"https://api.github.com/repos/hpicgs/libzeug","forks_url":"https://api.github.com/repos/hpicgs/libzeug/forks","keys_url":"https://api.github.com/repos/hpicgs/libzeug/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpicgs/libzeug/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpicgs/libzeug/teams","hooks_url":"https://api.github.com/repos/hpicgs/libzeug/hooks","issue_events_url":"https://api.github.com/repos/hpicgs/libzeug/issues/events{/number}","events_url":"https://api.github.com/repos/hpicgs/libzeug/events","assignees_url":"https://api.github.com/repos/hpicgs/libzeug/assignees{/user}","branches_url":"https://api.github.com/repos/hpicgs/libzeug/branches{/branch}","tags_url":"https://api.github.com/repos/hpicgs/libzeug/tags","blobs_url":"https://api.github.com/repos/hpicgs/libzeug/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpicgs/libzeug/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpicgs/libzeug/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpicgs/libzeug/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpicgs/libzeug/statuses/{sha}","languages_url":"https://api.github.com/repos/hpicgs/libzeug/languages","stargazers_url":"https://api.github.com/repos/hpicgs/libzeug/stargazers","contributors_url":"https://api.github.com/repos/hpicgs/libzeug/contributors","subscribers_url":"https://api.github.com/repos/hpicgs/libzeug/subscribers","subscription_url":"https://api.github.com/repos/hpicgs/libzeug/subscription","commits_url":"https://api.github.com/repos/hpicgs/libzeug/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpicgs/libzeug/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpicgs/libzeug/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpicgs/libzeug/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpicgs/libzeug/contents/{+path}","compare_url":"https://api.github.com/repos/hpicgs/libzeug/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpicgs/libzeug/merges","archive_url":"https://api.github.com/repos/hpicgs/libzeug/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpicgs/libzeug/downloads","issues_url":"https://api.github.com/repos/hpicgs/libzeug/issues{/number}","pulls_url":"https://api.github.com/repos/hpicgs/libzeug/pulls{/number}","milestones_url":"https://api.github.com/repos/hpicgs/libzeug/milestones{/number}","notifications_url":"https://api.github.com/repos/hpicgs/libzeug/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpicgs/libzeug/labels{/name}","releases_url":"https://api.github.com/repos/hpicgs/libzeug/releases{/id}","created_at":"2013-08-06T13:50:07Z","updated_at":"2015-05-07T11:59:00Z","pushed_at":"2015-05-14T21:07:39Z","git_url":"git://github.com/hpicgs/libzeug.git","ssh_url":"git@github.com:hpicgs/libzeug.git","clone_url":"https://github.com/hpicgs/libzeug.git","svn_url":"https://github.com/hpicgs/libzeug","homepage":"","size":5980,"stargazers_count":6,"watchers_count":6,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":18,"forks":8,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpicgs/libzeug/pulls/123"},"html":{"href":"https://github.com/hpicgs/libzeug/pull/123"},"issue":{"href":"https://api.github.com/repos/hpicgs/libzeug/issues/123"},"comments":{"href":"https://api.github.com/repos/hpicgs/libzeug/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/hpicgs/libzeug/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/hpicgs/libzeug/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpicgs/libzeug/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/hpicgs/libzeug/statuses/bab1f3dca707a30de2b498f7e902850d5517d3c3"}}}}