{"action":"created","comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/40587729","id":40587729,"diff_hunk":"@@ -4553,6 +4553,29 @@ int item::butcher_factor() const\n     return butcher_factor;\n }\n \n+bool item::is_worn_outermost(const player &p) const\n+{\n+   auto cover = get_covered_body_parts();\n+\n+   // Worn vector has innermost item first so iterate reverse until we find\n+   // either the item or another occupying the same body part(s)\n+   for (auto it = p.worn.rbegin(); it != p.worn.rend(); ++it) {\n+      if (&(*it) == this) {\n+          return true;\n+      }\n+      if (it->get_layer() == BELTED_LAYER) {\n+          // ignore other items strapped on above this item\n+          continue;\n+      }\n+      if ((cover & it->get_covered_body_parts()).count()) {","path":"src/item.cpp","position":18,"original_position":18,"commit_id":"499a9e9cd98ab5d99764ef5a7a30f27f17a9b896","original_commit_id":"499a9e9cd98ab5d99764ef5a7a30f27f17a9b896","user":{"login":"Coolthulhu","id":1878860,"avatar_url":"https://avatars.githubusercontent.com/u/1878860?v=3","gravatar_id":"","url":"https://api.github.com/users/Coolthulhu","html_url":"https://github.com/Coolthulhu","followers_url":"https://api.github.com/users/Coolthulhu/followers","following_url":"https://api.github.com/users/Coolthulhu/following{/other_user}","gists_url":"https://api.github.com/users/Coolthulhu/gists{/gist_id}","starred_url":"https://api.github.com/users/Coolthulhu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coolthulhu/subscriptions","organizations_url":"https://api.github.com/users/Coolthulhu/orgs","repos_url":"https://api.github.com/users/Coolthulhu/repos","events_url":"https://api.github.com/users/Coolthulhu/events{/privacy}","received_events_url":"https://api.github.com/users/Coolthulhu/received_events","type":"User","site_admin":false},"body":"Use `.any()` or `.all()` when dealing with bitsets, unless you explicitly need to know the count (rather than just knowing whether it is zero or max).","created_at":"2015-09-28T18:32:02Z","updated_at":"2015-09-28T18:32:02Z","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13669#discussion_r40587729","pull_request_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669","_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments/40587729"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13669#discussion_r40587729"},"pull_request":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669"}}},"pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669","id":46190500,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13669","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13669.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13669.patch","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13669","number":13669,"state":"open","locked":false,"title":"Consider clothing layer when activating items [WIP] [CR]","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"body":"Implements ACT_OUTERMOST flag which can be applied to usable wearable items that are expected to be worn as the outermost layer (with only strapped items above them). Only when this requirement is fulfilled can the item be activated.\r\n\r\nIncludes an example of adding the flag to the mining helmet so that the integral light works correctly when helmet netting (BELTED_LAYER) covers it but not a rain hood (OUTER_LAYER).\r\n\r\nIf these changes are satisfactory I'd like to continue working on the head torch item by implementing a FRAGILE flag (high chance of breaking instead of absorbing damage) and adding a more sturdy craftable 'survivor head torch' as an alternative.\r\n\r\nPossibly some of the sheathes/holsters etc. could have the flag similarly applied?","created_at":"2015-09-28T18:25:52Z","updated_at":"2015-09-28T18:32:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b926fdcd9296311462829583a45d6a0fbb60f21f","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669/commits","review_comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669/comments","review_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13669/comments","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/499a9e9cd98ab5d99764ef5a7a30f27f17a9b896","head":{"label":"mugling:outermost","ref":"outermost","sha":"499a9e9cd98ab5d99764ef5a7a30f27f17a9b896","user":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"repo":{"id":35048130,"name":"Cataclysm-DDA","full_name":"mugling/Cataclysm-DDA","owner":{"login":"mugling","id":12238606,"avatar_url":"https://avatars.githubusercontent.com/u/12238606?v=3","gravatar_id":"","url":"https://api.github.com/users/mugling","html_url":"https://github.com/mugling","followers_url":"https://api.github.com/users/mugling/followers","following_url":"https://api.github.com/users/mugling/following{/other_user}","gists_url":"https://api.github.com/users/mugling/gists{/gist_id}","starred_url":"https://api.github.com/users/mugling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mugling/subscriptions","organizations_url":"https://api.github.com/users/mugling/orgs","repos_url":"https://api.github.com/users/mugling/repos","events_url":"https://api.github.com/users/mugling/events{/privacy}","received_events_url":"https://api.github.com/users/mugling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mugling/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":true,"url":"https://api.github.com/repos/mugling/Cataclysm-DDA","forks_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/mugling/Cataclysm-DDA/releases{/id}","created_at":"2015-05-04T17:12:42Z","updated_at":"2015-05-05T15:58:32Z","pushed_at":"2015-09-28T18:09:21Z","git_url":"git://github.com/mugling/Cataclysm-DDA.git","ssh_url":"git@github.com:mugling/Cataclysm-DDA.git","clone_url":"https://github.com/mugling/Cataclysm-DDA.git","svn_url":"https://github.com/mugling/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":535091,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CleverRaven:master","ref":"master","sha":"4a29629661a98239ce36a56ef04b3035832be981","user":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"repo":{"id":5973855,"name":"Cataclysm-DDA","full_name":"CleverRaven/Cataclysm-DDA","owner":{"login":"CleverRaven","id":4367009,"avatar_url":"https://avatars.githubusercontent.com/u/4367009?v=3","gravatar_id":"","url":"https://api.github.com/users/CleverRaven","html_url":"https://github.com/CleverRaven","followers_url":"https://api.github.com/users/CleverRaven/followers","following_url":"https://api.github.com/users/CleverRaven/following{/other_user}","gists_url":"https://api.github.com/users/CleverRaven/gists{/gist_id}","starred_url":"https://api.github.com/users/CleverRaven/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CleverRaven/subscriptions","organizations_url":"https://api.github.com/users/CleverRaven/orgs","repos_url":"https://api.github.com/users/CleverRaven/repos","events_url":"https://api.github.com/users/CleverRaven/events{/privacy}","received_events_url":"https://api.github.com/users/CleverRaven/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CleverRaven/Cataclysm-DDA","description":"Cataclysm - Dark Days Ahead. A fork/variant of Cataclysm Roguelike by Whales.","fork":false,"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","forks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/forks","keys_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/teams","hooks_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/hooks","issue_events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/events{/number}","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/events","assignees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/assignees{/user}","branches_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/branches{/branch}","tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/tags","blobs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/refs{/sha}","trees_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/{sha}","languages_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/languages","stargazers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/stargazers","contributors_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contributors","subscribers_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscribers","subscription_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/subscription","commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/commits{/sha}","git_commits_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/git/commits{/sha}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/comments{/number}","issue_comment_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments{/number}","contents_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/contents/{+path}","compare_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/merges","archive_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/downloads","issues_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues{/number}","pulls_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls{/number}","milestones_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/milestones{/number}","notifications_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/labels{/name}","releases_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/releases{/id}","created_at":"2012-09-26T22:57:43Z","updated_at":"2015-09-27T21:03:35Z","pushed_at":"2015-09-28T18:25:53Z","git_url":"git://github.com/CleverRaven/Cataclysm-DDA.git","ssh_url":"git@github.com:CleverRaven/Cataclysm-DDA.git","clone_url":"https://github.com/CleverRaven/Cataclysm-DDA.git","svn_url":"https://github.com/CleverRaven/Cataclysm-DDA","homepage":"http://en.cataclysmdda.com/","size":831882,"stargazers_count":740,"watchers_count":740,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":766,"mirror_url":null,"open_issues_count":1087,"forks":766,"open_issues":1087,"watchers":740,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669"},"html":{"href":"https://github.com/CleverRaven/Cataclysm-DDA/pull/13669"},"issue":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13669"},"comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/13669/comments"},"review_comments":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669/comments"},"review_comment":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/13669/commits"},"statuses":{"href":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/statuses/499a9e9cd98ab5d99764ef5a7a30f27f17a9b896"}}}}