{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/issues/2","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/issues/2/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/issues/2/events","html_url":"https://github.com/logstash-plugins/logstash-filter-cidr/pull/2","id":102626091,"number":2,"title":"Speedup","user":{"login":"banduri","id":13496235,"avatar_url":"https://avatars.githubusercontent.com/u/13496235?v=3","gravatar_id":"","url":"https://api.github.com/users/banduri","html_url":"https://github.com/banduri","followers_url":"https://api.github.com/users/banduri/followers","following_url":"https://api.github.com/users/banduri/following{/other_user}","gists_url":"https://api.github.com/users/banduri/gists{/gist_id}","starred_url":"https://api.github.com/users/banduri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banduri/subscriptions","organizations_url":"https://api.github.com/users/banduri/orgs","repos_url":"https://api.github.com/users/banduri/repos","events_url":"https://api.github.com/users/banduri/events{/privacy}","received_events_url":"https://api.github.com/users/banduri/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"purbon","id":68540,"avatar_url":"https://avatars.githubusercontent.com/u/68540?v=3","gravatar_id":"","url":"https://api.github.com/users/purbon","html_url":"https://github.com/purbon","followers_url":"https://api.github.com/users/purbon/followers","following_url":"https://api.github.com/users/purbon/following{/other_user}","gists_url":"https://api.github.com/users/purbon/gists{/gist_id}","starred_url":"https://api.github.com/users/purbon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purbon/subscriptions","organizations_url":"https://api.github.com/users/purbon/orgs","repos_url":"https://api.github.com/users/purbon/repos","events_url":"https://api.github.com/users/purbon/events{/privacy}","received_events_url":"https://api.github.com/users/purbon/received_events","type":"User","site_admin":false},"milestone":null,"comments":2,"created_at":"2015-08-23T14:37:53Z","updated_at":"2015-08-31T07:24:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/pulls/2","html_url":"https://github.com/logstash-plugins/logstash-filter-cidr/pull/2","diff_url":"https://github.com/logstash-plugins/logstash-filter-cidr/pull/2.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-cidr/pull/2.patch"},"body":"did some speedups for classification. Mainly use a pre initializied array for ipaddress or networkaddresses if possible. also i could not not get jruby + logstash-devutils to work on my system so i did not execute the tests i added. But it should work since the benchmark provided the expected results for classification.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/issues/comments/136286629","html_url":"https://github.com/logstash-plugins/logstash-filter-cidr/pull/2#issuecomment-136286629","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-cidr/issues/2","id":136286629,"user":{"login":"banduri","id":13496235,"avatar_url":"https://avatars.githubusercontent.com/u/13496235?v=3","gravatar_id":"","url":"https://api.github.com/users/banduri","html_url":"https://github.com/banduri","followers_url":"https://api.github.com/users/banduri/followers","following_url":"https://api.github.com/users/banduri/following{/other_user}","gists_url":"https://api.github.com/users/banduri/gists{/gist_id}","starred_url":"https://api.github.com/users/banduri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/banduri/subscriptions","organizations_url":"https://api.github.com/users/banduri/orgs","repos_url":"https://api.github.com/users/banduri/repos","events_url":"https://api.github.com/users/banduri/events{/privacy}","received_events_url":"https://api.github.com/users/banduri/received_events","type":"User","site_admin":false},"created_at":"2015-08-31T07:24:00Z","updated_at":"2015-08-31T07:24:00Z","body":"Same here not sure about putting the benchmark results at all. Better names for the four new parameters and a proper documentation of them would also do the job. But yes, I do agree ```docs/performace.md``` is a better place (moving) "}}