{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/comments/30226344","id":30226344,"diff_hunk":"@@ -0,0 +1,46 @@\n+# enable logging output inline in rails console\n+:console_inline: true\n+# colorize log including level token based on severity\n+:colorize: true\n+# adds an extra line after each log message with information from which file:line and method\n+# was this message logged\n+:log_trace: false\n+#do not log certain paths (example  /notices/get_new)\n+:ignored_paths: []\n+# configuration of all loggers used in app\n+:loggers:\n+  # this logger is parent of all other loggers, by default this is the only one having appender\n+  # which is used by all other loggers\n+  :root:\n+    # only messages with severity >= this level from all loggers will be logged\n+    :level: debug\n+    # file or syslog, for file variant you can specify other options below like filename,\n+    # pattern or rolling options\n+    :type: file\n+    # 'daily', 'weekly', 'monthly' or number as seconds\n+    :age: 'weekly'\n+    # how many old log files to keep (156 = 52 * 3 = 3 years for weekly age)\n+    :keep: 156\n+    # logger line pattern, you can use following macros\n+    #  [%c] name of the logger that generate the log event\n+    #  [%d] datestamp\n+    #  [%m] the user supplied log message\n+    #  [%p] PID of the current process\n+    #  [%r] the time in milliseconds since the program started\n+    #  [%T] the name of the thread Thread.current[:name]\n+    #  [%t] object_id of the thread\n+    #  [%F] filename where the logging request was issued\n+    #  [%L] line number where the logging request was issued\n+    #  [%M] method name where the logging request was issued\n+    #  [%X{string}] variable set using ::Logging.mdc['string'] =\n+    :pattern: \"%d [%c] [%.1l] %m\\n\"\n+    # log filename for this environment, it will be placed into #{Rails.root}/log directory\n+    :filename: \"production.log\"","path":"config/logging.yaml","position":38,"original_position":38,"commit_id":"f7884242050876ce686460b1a1b7051fbd190716","original_commit_id":"f7884242050876ce686460b1a1b7051fbd190716","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"I think this is the great chance of getting rid of log files completely and sending everything through syslog/journald. What folks think about defaulting to syslog and providing syslog configuration to file all foreman data into the correct filename?","created_at":"2015-05-13T12:44:41Z","updated_at":"2015-05-13T12:44:41Z","html_url":"https://github.com/theforeman/foreman/pull/2376#discussion_r30226344","pull_request_url":"https://api.github.com/repos/theforeman/foreman/pulls/2376","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments/30226344"},"html":{"href":"https://github.com/theforeman/foreman/pull/2376#discussion_r30226344"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2376"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman/pulls/2376","id":35257740,"html_url":"https://github.com/theforeman/foreman/pull/2376","diff_url":"https://github.com/theforeman/foreman/pull/2376.diff","patch_url":"https://github.com/theforeman/foreman/pull/2376.patch","issue_url":"https://api.github.com/repos/theforeman/foreman/issues/2376","number":2376,"state":"open","locked":false,"title":"Fixes #10487: Add custom logging support.","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"body":"This change moves away from the Rails logger to the 'logging' gem\r\nto support more configurability of logging. Further, this allows for\r\nthe creation of custom loggers that plugins can then register through\r\nsettings.\r\n\r\nFor example, the plugin katello could define within its settings file\r\n(settings.plugins.d/katello.yaml) the following:\r\n\r\n```\r\n:katello:\r\n  :loggers:\r\n    :pulp_rest:\r\n      :enabled: false\r\n    :cp_rest:\r\n      :enabled: true\r\n```\r\n\r\nWhich would define 2 loggers, pulp_rest and cp_rest where the latter\r\nis turned on be default, but the former can be enabled such that\r\nthe log file isn't continuously filled with messages from that particular\r\nlayer.","created_at":"2015-05-12T18:46:13Z","updated_at":"2015-05-13T12:44:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"60e84bbf3db5f443ac0924e6cf2d2b359b8eb171","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/theforeman/foreman/pulls/2376/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman/pulls/2376/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman/issues/2376/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/f7884242050876ce686460b1a1b7051fbd190716","head":{"label":"ehelms:fixes-10487","ref":"fixes-10487","sha":"f7884242050876ce686460b1a1b7051fbd190716","user":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"repo":{"id":11512427,"name":"foreman","full_name":"ehelms/foreman","owner":{"login":"ehelms","id":293363,"avatar_url":"https://avatars.githubusercontent.com/u/293363?v=3","gravatar_id":"","url":"https://api.github.com/users/ehelms","html_url":"https://github.com/ehelms","followers_url":"https://api.github.com/users/ehelms/followers","following_url":"https://api.github.com/users/ehelms/following{/other_user}","gists_url":"https://api.github.com/users/ehelms/gists{/gist_id}","starred_url":"https://api.github.com/users/ehelms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehelms/subscriptions","organizations_url":"https://api.github.com/users/ehelms/orgs","repos_url":"https://api.github.com/users/ehelms/repos","events_url":"https://api.github.com/users/ehelms/events{/privacy}","received_events_url":"https://api.github.com/users/ehelms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ehelms/foreman","description":"an application that automates the lifecycle of servers ","fork":true,"url":"https://api.github.com/repos/ehelms/foreman","forks_url":"https://api.github.com/repos/ehelms/foreman/forks","keys_url":"https://api.github.com/repos/ehelms/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ehelms/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ehelms/foreman/teams","hooks_url":"https://api.github.com/repos/ehelms/foreman/hooks","issue_events_url":"https://api.github.com/repos/ehelms/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/ehelms/foreman/events","assignees_url":"https://api.github.com/repos/ehelms/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/ehelms/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/ehelms/foreman/tags","blobs_url":"https://api.github.com/repos/ehelms/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ehelms/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ehelms/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/ehelms/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ehelms/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/ehelms/foreman/languages","stargazers_url":"https://api.github.com/repos/ehelms/foreman/stargazers","contributors_url":"https://api.github.com/repos/ehelms/foreman/contributors","subscribers_url":"https://api.github.com/repos/ehelms/foreman/subscribers","subscription_url":"https://api.github.com/repos/ehelms/foreman/subscription","commits_url":"https://api.github.com/repos/ehelms/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/ehelms/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/ehelms/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/ehelms/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/ehelms/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/ehelms/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ehelms/foreman/merges","archive_url":"https://api.github.com/repos/ehelms/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ehelms/foreman/downloads","issues_url":"https://api.github.com/repos/ehelms/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/ehelms/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/ehelms/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/ehelms/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ehelms/foreman/labels{/name}","releases_url":"https://api.github.com/repos/ehelms/foreman/releases{/id}","created_at":"2013-07-18T20:03:01Z","updated_at":"2014-06-24T18:53:10Z","pushed_at":"2015-05-12T18:58:06Z","git_url":"git://github.com/ehelms/foreman.git","ssh_url":"git@github.com:ehelms/foreman.git","clone_url":"https://github.com/ehelms/foreman.git","svn_url":"https://github.com/ehelms/foreman","homepage":"http://theforeman.org","size":22876,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"10f1c579e2d8ecb05ce49da3b91349cf3ae5f976","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":258750,"name":"foreman","full_name":"theforeman/foreman","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman","description":"an application that automates the lifecycle of servers ","fork":false,"url":"https://api.github.com/repos/theforeman/foreman","forks_url":"https://api.github.com/repos/theforeman/foreman/forks","keys_url":"https://api.github.com/repos/theforeman/foreman/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman/events","assignees_url":"https://api.github.com/repos/theforeman/foreman/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman/merges","archive_url":"https://api.github.com/repos/theforeman/foreman/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman/releases{/id}","created_at":"2009-07-23T15:07:00Z","updated_at":"2015-05-11T06:52:48Z","pushed_at":"2015-05-13T12:23:14Z","git_url":"git://github.com/theforeman/foreman.git","ssh_url":"git@github.com:theforeman/foreman.git","clone_url":"https://github.com/theforeman/foreman.git","svn_url":"https://github.com/theforeman/foreman","homepage":"http://theforeman.org","size":82972,"stargazers_count":756,"watchers_count":756,"language":"Ruby","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":391,"mirror_url":null,"open_issues_count":81,"forks":391,"open_issues":81,"watchers":756,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2376"},"html":{"href":"https://github.com/theforeman/foreman/pull/2376"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2376"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman/issues/2376/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2376/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman/pulls/2376/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman/statuses/f7884242050876ce686460b1a1b7051fbd190716"}}}}