{"action":"created","issue":{"url":"https://api.github.com/repos/tsgrp/hpi/issues/652","labels_url":"https://api.github.com/repos/tsgrp/hpi/issues/652/labels{/name}","comments_url":"https://api.github.com/repos/tsgrp/hpi/issues/652/comments","events_url":"https://api.github.com/repos/tsgrp/hpi/issues/652/events","html_url":"https://github.com/tsgrp/hpi/issues/652","id":69932145,"number":652,"title":"Property Integrity Check Action - Handle Blank Values Properly","user":{"login":"gsteimer","id":1377228,"avatar_url":"https://avatars.githubusercontent.com/u/1377228?v=3","gravatar_id":"","url":"https://api.github.com/users/gsteimer","html_url":"https://github.com/gsteimer","followers_url":"https://api.github.com/users/gsteimer/followers","following_url":"https://api.github.com/users/gsteimer/following{/other_user}","gists_url":"https://api.github.com/users/gsteimer/gists{/gist_id}","starred_url":"https://api.github.com/users/gsteimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsteimer/subscriptions","organizations_url":"https://api.github.com/users/gsteimer/orgs","repos_url":"https://api.github.com/users/gsteimer/repos","events_url":"https://api.github.com/users/gsteimer/events{/privacy}","received_events_url":"https://api.github.com/users/gsteimer/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/tsgrp/hpi/labels/issue","name":"issue","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"b-k-white","id":8796489,"avatar_url":"https://avatars.githubusercontent.com/u/8796489?v=3","gravatar_id":"","url":"https://api.github.com/users/b-k-white","html_url":"https://github.com/b-k-white","followers_url":"https://api.github.com/users/b-k-white/followers","following_url":"https://api.github.com/users/b-k-white/following{/other_user}","gists_url":"https://api.github.com/users/b-k-white/gists{/gist_id}","starred_url":"https://api.github.com/users/b-k-white/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-k-white/subscriptions","organizations_url":"https://api.github.com/users/b-k-white/orgs","repos_url":"https://api.github.com/users/b-k-white/repos","events_url":"https://api.github.com/users/b-k-white/events{/privacy}","received_events_url":"https://api.github.com/users/b-k-white/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/tsgrp/hpi/milestones/7","html_url":"https://github.com/tsgrp/hpi/milestones/HPI%202.4","labels_url":"https://api.github.com/repos/tsgrp/hpi/milestones/7/labels","id":931706,"number":7,"title":"HPI 2.4","description":"Items tagged with the HPI 2.4 milestone must be fixed for the HPI 2.4 release","creator":{"login":"gsteimer","id":1377228,"avatar_url":"https://avatars.githubusercontent.com/u/1377228?v=3","gravatar_id":"","url":"https://api.github.com/users/gsteimer","html_url":"https://github.com/gsteimer","followers_url":"https://api.github.com/users/gsteimer/followers","following_url":"https://api.github.com/users/gsteimer/following{/other_user}","gists_url":"https://api.github.com/users/gsteimer/gists{/gist_id}","starred_url":"https://api.github.com/users/gsteimer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsteimer/subscriptions","organizations_url":"https://api.github.com/users/gsteimer/orgs","repos_url":"https://api.github.com/users/gsteimer/repos","events_url":"https://api.github.com/users/gsteimer/events{/privacy}","received_events_url":"https://api.github.com/users/gsteimer/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":7,"state":"open","created_at":"2015-01-12T15:57:21Z","updated_at":"2015-04-21T20:09:43Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-04-21T19:35:12Z","updated_at":"2015-04-21T20:09:43Z","closed_at":"2015-04-21T20:09:43Z","body":"While configuring this action for the insurance trac on edge, I noticed some issues when properties are blank.  In all cases below, I'm checking the Policy Holder attribute\r\n\r\n- [ ] When a property is blank on the folder and blank on all of the documents, the property label doesn't show up: \r\n![image](https://cloud.githubusercontent.com/assets/1377228/7260829/afb3942a-e832-11e4-98ce-e6084540b829.png)\r\n- [ ] When the property is populated on the folder, but blank on one or more documents, the documents do not appear in the list.  In this case, the action is correctly finding one document with an inconsistent value.  But a third document with a blank value isn't even in the list: \r\n![image](https://cloud.githubusercontent.com/assets/1377228/7260921/6b04c8f2-e833-11e4-9198-e1dca5960793.png)\r\n- [ ] When the property is populated on the folder, and one document has the same value, but all others are blank, the check incorrectly shows the property as valid.  In this case, there are really two other documents that have a blank value but are not being flagged: \r\n![image](https://cloud.githubusercontent.com/assets/1377228/7260901/45e07f3a-e833-11e4-87b2-398ca5d460c1.png)\r\n\r\n@benallenallen @joehof @b-k-white\r\n"},"comment":{"url":"https://api.github.com/repos/tsgrp/hpi/issues/comments/94923403","html_url":"https://github.com/tsgrp/hpi/issues/652#issuecomment-94923403","issue_url":"https://api.github.com/repos/tsgrp/hpi/issues/652","id":94923403,"user":{"login":"b-k-white","id":8796489,"avatar_url":"https://avatars.githubusercontent.com/u/8796489?v=3","gravatar_id":"","url":"https://api.github.com/users/b-k-white","html_url":"https://github.com/b-k-white","followers_url":"https://api.github.com/users/b-k-white/followers","following_url":"https://api.github.com/users/b-k-white/following{/other_user}","gists_url":"https://api.github.com/users/b-k-white/gists{/gist_id}","starred_url":"https://api.github.com/users/b-k-white/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-k-white/subscriptions","organizations_url":"https://api.github.com/users/b-k-white/orgs","repos_url":"https://api.github.com/users/b-k-white/repos","events_url":"https://api.github.com/users/b-k-white/events{/privacy}","received_events_url":"https://api.github.com/users/b-k-white/received_events","type":"User","site_admin":false},"created_at":"2015-04-21T20:09:43Z","updated_at":"2015-04-21T20:09:43Z","body":"Fixed an if statement that was having empty strings count as not on the sub-document. Wrote two unit tests to back up this fix.\r\nCR- ZK\r\nHPI - 12110"}}