{"action":"created","comment":{"url":"https://api.github.com/repos/docker/libcompose/pulls/comments/41395113","id":41395113,"diff_hunk":"@@ -0,0 +1,148 @@\n+package project\n+\n+import \"testing\"\n+\n+type NullLookup struct {\n+}\n+\n+func (n *NullLookup) Lookup(file, relativeTo string) ([]byte, string, error) {\n+\treturn nil, \"\", nil\n+}\n+\n+func TestExtendsInheritImage(t *testing.T) {\n+\tp := NewProject(&Context{\n+\t\tConfigLookup: &NullLookup{},\n+\t})\n+\n+\tconfig, err := Merge(p, []byte(`\n+parent:\n+  image: foo\n+child:\n+  extends:\n+    service: parent\n+`))\n+\n+\tif err != nil {\n+\t\tt.Fatal(err)\n+\t}\n+\n+\tparent := config[\"parent\"]\n+\tchild := config[\"child\"]\n+\n+\tif parent.Image != \"foo\" {\n+\t\tt.Fatal(\"Invalid image\", parent.Image)\n+\t}\n+\n+\tif child.Build != \"\" {\n+\t\tt.Fatal(\"Invalid build\", child.Build)\n+\t}\n+\n+\tif child.Image != \"foo\" {\n+\t\tt.Fatal(\"Invalid image\", child.Image)\n+\t}","path":"project/merge_test.go","position":42,"original_position":42,"commit_id":"26d8c30a821b765bb33877b3781b9951194f24bf","original_commit_id":"26d8c30a821b765bb33877b3781b9951194f24bf","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"I'm not against `testify` if we already have it in our dependencies. @ibuildthecloud opinions ? :smiley_cat: ","created_at":"2015-10-07T14:16:01Z","updated_at":"2015-10-07T14:16:01Z","html_url":"https://github.com/docker/libcompose/pull/66#discussion_r41395113","pull_request_url":"https://api.github.com/repos/docker/libcompose/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/docker/libcompose/pulls/comments/41395113"},"html":{"href":"https://github.com/docker/libcompose/pull/66#discussion_r41395113"},"pull_request":{"href":"https://api.github.com/repos/docker/libcompose/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/docker/libcompose/pulls/66","id":46995410,"html_url":"https://github.com/docker/libcompose/pull/66","diff_url":"https://github.com/docker/libcompose/pull/66.diff","patch_url":"https://github.com/docker/libcompose/pull/66.patch","issue_url":"https://api.github.com/repos/docker/libcompose/issues/66","number":66,"state":"open","locked":false,"title":"Fix issue in which extending could end up with both build and image","user":{"login":"ibuildthecloud","id":1754002,"avatar_url":"https://avatars.githubusercontent.com/u/1754002?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuildthecloud","html_url":"https://github.com/ibuildthecloud","followers_url":"https://api.github.com/users/ibuildthecloud/followers","following_url":"https://api.github.com/users/ibuildthecloud/following{/other_user}","gists_url":"https://api.github.com/users/ibuildthecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuildthecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuildthecloud/subscriptions","organizations_url":"https://api.github.com/users/ibuildthecloud/orgs","repos_url":"https://api.github.com/users/ibuildthecloud/repos","events_url":"https://api.github.com/users/ibuildthecloud/events{/privacy}","received_events_url":"https://api.github.com/users/ibuildthecloud/received_events","type":"User","site_admin":false},"body":"According to Docker Compose docs\r\n\r\n> In the case of build and image, using one in the local service causes\r\n> Compose to discard the other, if it was defined in the original\r\n> service.\r\n\r\nThe above was not being respected","created_at":"2015-10-07T07:41:35Z","updated_at":"2015-10-07T14:16:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e61b65812a1efcf5dfa5e13ab21b587325daea8a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/docker/libcompose/pulls/66/commits","review_comments_url":"https://api.github.com/repos/docker/libcompose/pulls/66/comments","review_comment_url":"https://api.github.com/repos/docker/libcompose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/libcompose/issues/66/comments","statuses_url":"https://api.github.com/repos/docker/libcompose/statuses/26d8c30a821b765bb33877b3781b9951194f24bf","head":{"label":"ibuildthecloud:invalid-merge","ref":"invalid-merge","sha":"26d8c30a821b765bb33877b3781b9951194f24bf","user":{"login":"ibuildthecloud","id":1754002,"avatar_url":"https://avatars.githubusercontent.com/u/1754002?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuildthecloud","html_url":"https://github.com/ibuildthecloud","followers_url":"https://api.github.com/users/ibuildthecloud/followers","following_url":"https://api.github.com/users/ibuildthecloud/following{/other_user}","gists_url":"https://api.github.com/users/ibuildthecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuildthecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuildthecloud/subscriptions","organizations_url":"https://api.github.com/users/ibuildthecloud/orgs","repos_url":"https://api.github.com/users/ibuildthecloud/repos","events_url":"https://api.github.com/users/ibuildthecloud/events{/privacy}","received_events_url":"https://api.github.com/users/ibuildthecloud/received_events","type":"User","site_admin":false},"repo":{"id":40268218,"name":"libcompose","full_name":"ibuildthecloud/libcompose","owner":{"login":"ibuildthecloud","id":1754002,"avatar_url":"https://avatars.githubusercontent.com/u/1754002?v=3","gravatar_id":"","url":"https://api.github.com/users/ibuildthecloud","html_url":"https://github.com/ibuildthecloud","followers_url":"https://api.github.com/users/ibuildthecloud/followers","following_url":"https://api.github.com/users/ibuildthecloud/following{/other_user}","gists_url":"https://api.github.com/users/ibuildthecloud/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuildthecloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuildthecloud/subscriptions","organizations_url":"https://api.github.com/users/ibuildthecloud/orgs","repos_url":"https://api.github.com/users/ibuildthecloud/repos","events_url":"https://api.github.com/users/ibuildthecloud/events{/privacy}","received_events_url":"https://api.github.com/users/ibuildthecloud/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibuildthecloud/libcompose","description":"","fork":true,"url":"https://api.github.com/repos/ibuildthecloud/libcompose","forks_url":"https://api.github.com/repos/ibuildthecloud/libcompose/forks","keys_url":"https://api.github.com/repos/ibuildthecloud/libcompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibuildthecloud/libcompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibuildthecloud/libcompose/teams","hooks_url":"https://api.github.com/repos/ibuildthecloud/libcompose/hooks","issue_events_url":"https://api.github.com/repos/ibuildthecloud/libcompose/issues/events{/number}","events_url":"https://api.github.com/repos/ibuildthecloud/libcompose/events","assignees_url":"https://api.github.com/repos/ibuildthecloud/libcompose/assignees{/user}","branches_url":"https://api.github.com/repos/ibuildthecloud/libcompose/branches{/branch}","tags_url":"https://api.github.com/repos/ibuildthecloud/libcompose/tags","blobs_url":"https://api.github.com/repos/ibuildthecloud/libcompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibuildthecloud/libcompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibuildthecloud/libcompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibuildthecloud/libcompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibuildthecloud/libcompose/statuses/{sha}","languages_url":"https://api.github.com/repos/ibuildthecloud/libcompose/languages","stargazers_url":"https://api.github.com/repos/ibuildthecloud/libcompose/stargazers","contributors_url":"https://api.github.com/repos/ibuildthecloud/libcompose/contributors","subscribers_url":"https://api.github.com/repos/ibuildthecloud/libcompose/subscribers","subscription_url":"https://api.github.com/repos/ibuildthecloud/libcompose/subscription","commits_url":"https://api.github.com/repos/ibuildthecloud/libcompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibuildthecloud/libcompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibuildthecloud/libcompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibuildthecloud/libcompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibuildthecloud/libcompose/contents/{+path}","compare_url":"https://api.github.com/repos/ibuildthecloud/libcompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibuildthecloud/libcompose/merges","archive_url":"https://api.github.com/repos/ibuildthecloud/libcompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibuildthecloud/libcompose/downloads","issues_url":"https://api.github.com/repos/ibuildthecloud/libcompose/issues{/number}","pulls_url":"https://api.github.com/repos/ibuildthecloud/libcompose/pulls{/number}","milestones_url":"https://api.github.com/repos/ibuildthecloud/libcompose/milestones{/number}","notifications_url":"https://api.github.com/repos/ibuildthecloud/libcompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibuildthecloud/libcompose/labels{/name}","releases_url":"https://api.github.com/repos/ibuildthecloud/libcompose/releases{/id}","created_at":"2015-08-05T20:49:12Z","updated_at":"2015-08-05T20:49:13Z","pushed_at":"2015-10-07T08:32:22Z","git_url":"git://github.com/ibuildthecloud/libcompose.git","ssh_url":"git@github.com:ibuildthecloud/libcompose.git","clone_url":"https://github.com/ibuildthecloud/libcompose.git","svn_url":"https://github.com/ibuildthecloud/libcompose","homepage":null,"size":1420,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"af6860ec773cdc10c48232a530bdfea87ee6e9e4","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":35969237,"name":"libcompose","full_name":"docker/libcompose","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/libcompose","description":"","fork":false,"url":"https://api.github.com/repos/docker/libcompose","forks_url":"https://api.github.com/repos/docker/libcompose/forks","keys_url":"https://api.github.com/repos/docker/libcompose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/libcompose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/libcompose/teams","hooks_url":"https://api.github.com/repos/docker/libcompose/hooks","issue_events_url":"https://api.github.com/repos/docker/libcompose/issues/events{/number}","events_url":"https://api.github.com/repos/docker/libcompose/events","assignees_url":"https://api.github.com/repos/docker/libcompose/assignees{/user}","branches_url":"https://api.github.com/repos/docker/libcompose/branches{/branch}","tags_url":"https://api.github.com/repos/docker/libcompose/tags","blobs_url":"https://api.github.com/repos/docker/libcompose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/libcompose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/libcompose/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/libcompose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/libcompose/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/libcompose/languages","stargazers_url":"https://api.github.com/repos/docker/libcompose/stargazers","contributors_url":"https://api.github.com/repos/docker/libcompose/contributors","subscribers_url":"https://api.github.com/repos/docker/libcompose/subscribers","subscription_url":"https://api.github.com/repos/docker/libcompose/subscription","commits_url":"https://api.github.com/repos/docker/libcompose/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/libcompose/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/libcompose/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/libcompose/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/libcompose/contents/{+path}","compare_url":"https://api.github.com/repos/docker/libcompose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/libcompose/merges","archive_url":"https://api.github.com/repos/docker/libcompose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/libcompose/downloads","issues_url":"https://api.github.com/repos/docker/libcompose/issues{/number}","pulls_url":"https://api.github.com/repos/docker/libcompose/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/libcompose/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/libcompose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/libcompose/labels{/name}","releases_url":"https://api.github.com/repos/docker/libcompose/releases{/id}","created_at":"2015-05-20T19:22:20Z","updated_at":"2015-09-30T04:25:02Z","pushed_at":"2015-10-07T14:00:05Z","git_url":"git://github.com/docker/libcompose.git","ssh_url":"git@github.com:docker/libcompose.git","clone_url":"https://github.com/docker/libcompose.git","svn_url":"https://github.com/docker/libcompose","homepage":null,"size":2009,"stargazers_count":227,"watchers_count":227,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"open_issues_count":23,"forks":39,"open_issues":23,"watchers":227,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/libcompose/pulls/66"},"html":{"href":"https://github.com/docker/libcompose/pull/66"},"issue":{"href":"https://api.github.com/repos/docker/libcompose/issues/66"},"comments":{"href":"https://api.github.com/repos/docker/libcompose/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/libcompose/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/libcompose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/libcompose/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/docker/libcompose/statuses/26d8c30a821b765bb33877b3781b9951194f24bf"}}}}