{"action":"created","comment":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/comments/27248462","id":27248462,"diff_hunk":"@@ -14,6 +14,11 @@\n             \"required\" : true,\n             \"includeInList\" : false\n         },\n+        \"externalHandlerProcessConfigs\" : {","path":"resources/content/schema/base/externalHandler.json","position":4,"original_position":4,"commit_id":"b3143f7460043ba92b0b711b0bb7824e7f239b84","original_commit_id":"b3143f7460043ba92b0b711b0bb7824e7f239b84","user":{"login":"cjellick","id":2473240,"avatar_url":"https://avatars.githubusercontent.com/u/2473240?v=3","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"body":"Im just talking about the property on externalHandler. The name of the type is fine and can stay externalHandlerProcessConfigs.","created_at":"2015-03-26T19:42:23Z","updated_at":"2015-03-26T19:42:23Z","html_url":"https://github.com/rancherio/cattle/pull/327#discussion_r27248462","pull_request_url":"https://api.github.com/repos/rancherio/cattle/pulls/327","_links":{"self":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/comments/27248462"},"html":{"href":"https://github.com/rancherio/cattle/pull/327#discussion_r27248462"},"pull_request":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/327"}}},"pull_request":{"url":"https://api.github.com/repos/rancherio/cattle/pulls/327","id":31988359,"html_url":"https://github.com/rancherio/cattle/pull/327","diff_url":"https://github.com/rancherio/cattle/pull/327.diff","patch_url":"https://github.com/rancherio/cattle/pull/327.patch","issue_url":"https://api.github.com/repos/rancherio/cattle/issues/327","number":327,"state":"open","locked":false,"title":"Error handling framework for ExternalHandlers","user":{"login":"will-chan","id":10134676,"avatar_url":"https://avatars.githubusercontent.com/u/10134676?v=3","gravatar_id":"","url":"https://api.github.com/users/will-chan","html_url":"https://github.com/will-chan","followers_url":"https://api.github.com/users/will-chan/followers","following_url":"https://api.github.com/users/will-chan/following{/other_user}","gists_url":"https://api.github.com/users/will-chan/gists{/gist_id}","starred_url":"https://api.github.com/users/will-chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-chan/subscriptions","organizations_url":"https://api.github.com/users/will-chan/orgs","repos_url":"https://api.github.com/users/will-chan/repos","events_url":"https://api.github.com/users/will-chan/events{/privacy}","received_events_url":"https://api.github.com/users/will-chan/received_events","type":"User","site_admin":false},"body":"This PR introduced error handling for ExternalHandlers.  It will still require additional PR from go-machine-service and go-rancher to make it work end to end.\r\n\r\nRequires:\r\nhttps://github.com/rancherio/go-rancher/pull/7\r\n","created_at":"2015-03-26T04:19:41Z","updated_at":"2015-03-26T19:42:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"577c3bbb25eac6fc370aea69e6c5386c19db9a91","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/rancherio/cattle/pulls/327/commits","review_comments_url":"https://api.github.com/repos/rancherio/cattle/pulls/327/comments","review_comment_url":"https://api.github.com/repos/rancherio/cattle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancherio/cattle/issues/327/comments","statuses_url":"https://api.github.com/repos/rancherio/cattle/statuses/b3143f7460043ba92b0b711b0bb7824e7f239b84","head":{"label":"will-chan:errorhandling","ref":"errorhandling","sha":"b3143f7460043ba92b0b711b0bb7824e7f239b84","user":{"login":"will-chan","id":10134676,"avatar_url":"https://avatars.githubusercontent.com/u/10134676?v=3","gravatar_id":"","url":"https://api.github.com/users/will-chan","html_url":"https://github.com/will-chan","followers_url":"https://api.github.com/users/will-chan/followers","following_url":"https://api.github.com/users/will-chan/following{/other_user}","gists_url":"https://api.github.com/users/will-chan/gists{/gist_id}","starred_url":"https://api.github.com/users/will-chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-chan/subscriptions","organizations_url":"https://api.github.com/users/will-chan/orgs","repos_url":"https://api.github.com/users/will-chan/repos","events_url":"https://api.github.com/users/will-chan/events{/privacy}","received_events_url":"https://api.github.com/users/will-chan/received_events","type":"User","site_admin":false},"repo":{"id":30552979,"name":"cattle","full_name":"will-chan/cattle","owner":{"login":"will-chan","id":10134676,"avatar_url":"https://avatars.githubusercontent.com/u/10134676?v=3","gravatar_id":"","url":"https://api.github.com/users/will-chan","html_url":"https://github.com/will-chan","followers_url":"https://api.github.com/users/will-chan/followers","following_url":"https://api.github.com/users/will-chan/following{/other_user}","gists_url":"https://api.github.com/users/will-chan/gists{/gist_id}","starred_url":"https://api.github.com/users/will-chan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/will-chan/subscriptions","organizations_url":"https://api.github.com/users/will-chan/orgs","repos_url":"https://api.github.com/users/will-chan/repos","events_url":"https://api.github.com/users/will-chan/events{/privacy}","received_events_url":"https://api.github.com/users/will-chan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/will-chan/cattle","description":"Infrastructure orchestration platform","fork":true,"url":"https://api.github.com/repos/will-chan/cattle","forks_url":"https://api.github.com/repos/will-chan/cattle/forks","keys_url":"https://api.github.com/repos/will-chan/cattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/will-chan/cattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/will-chan/cattle/teams","hooks_url":"https://api.github.com/repos/will-chan/cattle/hooks","issue_events_url":"https://api.github.com/repos/will-chan/cattle/issues/events{/number}","events_url":"https://api.github.com/repos/will-chan/cattle/events","assignees_url":"https://api.github.com/repos/will-chan/cattle/assignees{/user}","branches_url":"https://api.github.com/repos/will-chan/cattle/branches{/branch}","tags_url":"https://api.github.com/repos/will-chan/cattle/tags","blobs_url":"https://api.github.com/repos/will-chan/cattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/will-chan/cattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/will-chan/cattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/will-chan/cattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/will-chan/cattle/statuses/{sha}","languages_url":"https://api.github.com/repos/will-chan/cattle/languages","stargazers_url":"https://api.github.com/repos/will-chan/cattle/stargazers","contributors_url":"https://api.github.com/repos/will-chan/cattle/contributors","subscribers_url":"https://api.github.com/repos/will-chan/cattle/subscribers","subscription_url":"https://api.github.com/repos/will-chan/cattle/subscription","commits_url":"https://api.github.com/repos/will-chan/cattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/will-chan/cattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/will-chan/cattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/will-chan/cattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/will-chan/cattle/contents/{+path}","compare_url":"https://api.github.com/repos/will-chan/cattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/will-chan/cattle/merges","archive_url":"https://api.github.com/repos/will-chan/cattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/will-chan/cattle/downloads","issues_url":"https://api.github.com/repos/will-chan/cattle/issues{/number}","pulls_url":"https://api.github.com/repos/will-chan/cattle/pulls{/number}","milestones_url":"https://api.github.com/repos/will-chan/cattle/milestones{/number}","notifications_url":"https://api.github.com/repos/will-chan/cattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/will-chan/cattle/labels{/name}","releases_url":"https://api.github.com/repos/will-chan/cattle/releases{/id}","created_at":"2015-02-09T19:08:14Z","updated_at":"2015-03-09T17:05:46Z","pushed_at":"2015-03-26T17:17:11Z","git_url":"git://github.com/will-chan/cattle.git","ssh_url":"git@github.com:will-chan/cattle.git","clone_url":"https://github.com/will-chan/cattle.git","svn_url":"https://github.com/will-chan/cattle","homepage":"","size":17039,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancherio:master","ref":"master","sha":"44a2a02fbe642620033e4cef2c51554f8e11082e","user":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"repo":{"id":18023059,"name":"cattle","full_name":"rancherio/cattle","owner":{"login":"rancherio","id":9343010,"avatar_url":"https://avatars.githubusercontent.com/u/9343010?v=3","gravatar_id":"","url":"https://api.github.com/users/rancherio","html_url":"https://github.com/rancherio","followers_url":"https://api.github.com/users/rancherio/followers","following_url":"https://api.github.com/users/rancherio/following{/other_user}","gists_url":"https://api.github.com/users/rancherio/gists{/gist_id}","starred_url":"https://api.github.com/users/rancherio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancherio/subscriptions","organizations_url":"https://api.github.com/users/rancherio/orgs","repos_url":"https://api.github.com/users/rancherio/repos","events_url":"https://api.github.com/users/rancherio/events{/privacy}","received_events_url":"https://api.github.com/users/rancherio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rancherio/cattle","description":"Infrastructure orchestration platform","fork":false,"url":"https://api.github.com/repos/rancherio/cattle","forks_url":"https://api.github.com/repos/rancherio/cattle/forks","keys_url":"https://api.github.com/repos/rancherio/cattle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancherio/cattle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancherio/cattle/teams","hooks_url":"https://api.github.com/repos/rancherio/cattle/hooks","issue_events_url":"https://api.github.com/repos/rancherio/cattle/issues/events{/number}","events_url":"https://api.github.com/repos/rancherio/cattle/events","assignees_url":"https://api.github.com/repos/rancherio/cattle/assignees{/user}","branches_url":"https://api.github.com/repos/rancherio/cattle/branches{/branch}","tags_url":"https://api.github.com/repos/rancherio/cattle/tags","blobs_url":"https://api.github.com/repos/rancherio/cattle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancherio/cattle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancherio/cattle/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancherio/cattle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancherio/cattle/statuses/{sha}","languages_url":"https://api.github.com/repos/rancherio/cattle/languages","stargazers_url":"https://api.github.com/repos/rancherio/cattle/stargazers","contributors_url":"https://api.github.com/repos/rancherio/cattle/contributors","subscribers_url":"https://api.github.com/repos/rancherio/cattle/subscribers","subscription_url":"https://api.github.com/repos/rancherio/cattle/subscription","commits_url":"https://api.github.com/repos/rancherio/cattle/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancherio/cattle/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancherio/cattle/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancherio/cattle/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancherio/cattle/contents/{+path}","compare_url":"https://api.github.com/repos/rancherio/cattle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancherio/cattle/merges","archive_url":"https://api.github.com/repos/rancherio/cattle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancherio/cattle/downloads","issues_url":"https://api.github.com/repos/rancherio/cattle/issues{/number}","pulls_url":"https://api.github.com/repos/rancherio/cattle/pulls{/number}","milestones_url":"https://api.github.com/repos/rancherio/cattle/milestones{/number}","notifications_url":"https://api.github.com/repos/rancherio/cattle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancherio/cattle/labels{/name}","releases_url":"https://api.github.com/repos/rancherio/cattle/releases{/id}","created_at":"2014-03-23T00:19:52Z","updated_at":"2015-03-26T07:26:28Z","pushed_at":"2015-03-26T17:17:12Z","git_url":"git://github.com/rancherio/cattle.git","ssh_url":"git@github.com:rancherio/cattle.git","clone_url":"https://github.com/rancherio/cattle.git","svn_url":"https://github.com/rancherio/cattle","homepage":"","size":20805,"stargazers_count":121,"watchers_count":121,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":87,"forks":22,"open_issues":87,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/327"},"html":{"href":"https://github.com/rancherio/cattle/pull/327"},"issue":{"href":"https://api.github.com/repos/rancherio/cattle/issues/327"},"comments":{"href":"https://api.github.com/repos/rancherio/cattle/issues/327/comments"},"review_comments":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/327/comments"},"review_comment":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancherio/cattle/pulls/327/commits"},"statuses":{"href":"https://api.github.com/repos/rancherio/cattle/statuses/b3143f7460043ba92b0b711b0bb7824e7f239b84"}}}}