{"action":"opened","number":4241,"pull_request":{"url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4241","id":26790087,"html_url":"https://github.com/D-Programming-Language/dmd/pull/4241","diff_url":"https://github.com/D-Programming-Language/dmd/pull/4241.diff","patch_url":"https://github.com/D-Programming-Language/dmd/pull/4241.patch","issue_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4241","number":4241,"state":"open","locked":false,"title":"[DDMD] [cleanup] Move lexer's string table into Identifier and clean up imports","user":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"body":"Part 2.\r\n\r\nThis one removes `Lexer::idPool` and `Lexer::uniqueId` in favor of the equivalent functions in `Identifier`.\r\nWith this done nothing needs to import `lexer` to generate `Identifier`s.\r\n\r\nNow we can almost isolate `lexer`/`id`/`identifier`/`tokens` + a few from `root` and build them without needing the rest of the compiler.  The remaining offenders are all in `mars.h` and will be addressed in the next pull.\r\n\r\nChanges:\r\n- Replace `Lexer::idPool` with `Identifier::idPool` and `Lexer::uniqueId` with `Identifier::generateId`\r\n- Move keywords and `Token::tochars` init into `tokens.c`\r\n- Replace direct access to `stringtable` with `Identifier::lookup` etc\r\n- Remove unnecessary `#include`s of `lexer.h`","created_at":"2015-01-04T03:05:21Z","updated_at":"2015-01-04T03:05:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4241/commits","review_comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4241/comments","review_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4241/comments","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/02ea22fa3d2ab06ccd4bac97443f6cf7944d2381","head":{"label":"yebblies:splitidtable","ref":"splitidtable","sha":"02ea22fa3d2ab06ccd4bac97443f6cf7944d2381","user":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"repo":{"id":1850344,"name":"dmd","full_name":"yebblies/dmd","owner":{"login":"yebblies","id":580100,"avatar_url":"https://avatars.githubusercontent.com/u/580100?v=3","gravatar_id":"","url":"https://api.github.com/users/yebblies","html_url":"https://github.com/yebblies","followers_url":"https://api.github.com/users/yebblies/followers","following_url":"https://api.github.com/users/yebblies/following{/other_user}","gists_url":"https://api.github.com/users/yebblies/gists{/gist_id}","starred_url":"https://api.github.com/users/yebblies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yebblies/subscriptions","organizations_url":"https://api.github.com/users/yebblies/orgs","repos_url":"https://api.github.com/users/yebblies/repos","events_url":"https://api.github.com/users/yebblies/events{/privacy}","received_events_url":"https://api.github.com/users/yebblies/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yebblies/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/yebblies/dmd","forks_url":"https://api.github.com/repos/yebblies/dmd/forks","keys_url":"https://api.github.com/repos/yebblies/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yebblies/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yebblies/dmd/teams","hooks_url":"https://api.github.com/repos/yebblies/dmd/hooks","issue_events_url":"https://api.github.com/repos/yebblies/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/yebblies/dmd/events","assignees_url":"https://api.github.com/repos/yebblies/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/yebblies/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/yebblies/dmd/tags","blobs_url":"https://api.github.com/repos/yebblies/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yebblies/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yebblies/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/yebblies/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yebblies/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/yebblies/dmd/languages","stargazers_url":"https://api.github.com/repos/yebblies/dmd/stargazers","contributors_url":"https://api.github.com/repos/yebblies/dmd/contributors","subscribers_url":"https://api.github.com/repos/yebblies/dmd/subscribers","subscription_url":"https://api.github.com/repos/yebblies/dmd/subscription","commits_url":"https://api.github.com/repos/yebblies/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/yebblies/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/yebblies/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/yebblies/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/yebblies/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/yebblies/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yebblies/dmd/merges","archive_url":"https://api.github.com/repos/yebblies/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yebblies/dmd/downloads","issues_url":"https://api.github.com/repos/yebblies/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/yebblies/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/yebblies/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/yebblies/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yebblies/dmd/labels{/name}","releases_url":"https://api.github.com/repos/yebblies/dmd/releases{/id}","created_at":"2011-06-05T13:45:33Z","updated_at":"2015-01-02T10:16:44Z","pushed_at":"2015-01-03T11:36:36Z","git_url":"git://github.com/yebblies/dmd.git","ssh_url":"git@github.com:yebblies/dmd.git","clone_url":"https://github.com/yebblies/dmd.git","svn_url":"https://github.com/yebblies/dmd","homepage":"d-programming-language.org","size":45798,"stargazers_count":5,"watchers_count":5,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":5,"default_branch":"master"}},"base":{"label":"D-Programming-Language:master","ref":"master","sha":"e129e849c85d9a6bb63dfdefd3e3cc2ddce6c9e0","user":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"D-Programming-Language/dmd","owner":{"login":"D-Programming-Language","id":565913,"avatar_url":"https://avatars.githubusercontent.com/u/565913?v=3","gravatar_id":"","url":"https://api.github.com/users/D-Programming-Language","html_url":"https://github.com/D-Programming-Language","followers_url":"https://api.github.com/users/D-Programming-Language/followers","following_url":"https://api.github.com/users/D-Programming-Language/following{/other_user}","gists_url":"https://api.github.com/users/D-Programming-Language/gists{/gist_id}","starred_url":"https://api.github.com/users/D-Programming-Language/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D-Programming-Language/subscriptions","organizations_url":"https://api.github.com/users/D-Programming-Language/orgs","repos_url":"https://api.github.com/users/D-Programming-Language/repos","events_url":"https://api.github.com/users/D-Programming-Language/events{/privacy}","received_events_url":"https://api.github.com/users/D-Programming-Language/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/D-Programming-Language/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/D-Programming-Language/dmd","forks_url":"https://api.github.com/repos/D-Programming-Language/dmd/forks","keys_url":"https://api.github.com/repos/D-Programming-Language/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D-Programming-Language/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D-Programming-Language/dmd/teams","hooks_url":"https://api.github.com/repos/D-Programming-Language/dmd/hooks","issue_events_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/D-Programming-Language/dmd/events","assignees_url":"https://api.github.com/repos/D-Programming-Language/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/D-Programming-Language/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/tags","blobs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/D-Programming-Language/dmd/languages","stargazers_url":"https://api.github.com/repos/D-Programming-Language/dmd/stargazers","contributors_url":"https://api.github.com/repos/D-Programming-Language/dmd/contributors","subscribers_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscribers","subscription_url":"https://api.github.com/repos/D-Programming-Language/dmd/subscription","commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/D-Programming-Language/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/D-Programming-Language/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues/comments/{number}","contents_url":"https://api.github.com/repos/D-Programming-Language/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/D-Programming-Language/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D-Programming-Language/dmd/merges","archive_url":"https://api.github.com/repos/D-Programming-Language/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D-Programming-Language/dmd/downloads","issues_url":"https://api.github.com/repos/D-Programming-Language/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/D-Programming-Language/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/D-Programming-Language/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/D-Programming-Language/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D-Programming-Language/dmd/labels{/name}","releases_url":"https://api.github.com/repos/D-Programming-Language/dmd/releases{/id}","created_at":"2011-01-15T06:53:53Z","updated_at":"2015-01-03T11:29:02Z","pushed_at":"2015-01-03T10:08:43Z","git_url":"git://github.com/D-Programming-Language/dmd.git","ssh_url":"git@github.com:D-Programming-Language/dmd.git","clone_url":"https://github.com/D-Programming-Language/dmd.git","svn_url":"https://github.com/D-Programming-Language/dmd","homepage":"dlang.org","size":78244,"stargazers_count":890,"watchers_count":890,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":287,"mirror_url":null,"open_issues_count":92,"forks":287,"open_issues":92,"watchers":890,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4241"},"html":{"href":"https://github.com/D-Programming-Language/dmd/pull/4241"},"issue":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4241"},"comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/issues/4241/comments"},"review_comments":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4241/comments"},"review_comment":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/pulls/4241/commits"},"statuses":{"href":"https://api.github.com/repos/D-Programming-Language/dmd/statuses/02ea22fa3d2ab06ccd4bac97443f6cf7944d2381"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"commits":1,"additions":425,"deletions":421,"changed_files":44}}