{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/22847040","id":22847040,"diff_hunk":"@@ -242,7 +247,7 @@ public void run() {\n     private void selectOwnedKeys(Iterable loadedKeys, MapServiceContext mapServiceContext) {\n \n         initialKeys.clear();\n-        int maxSizePerNode = getApproximateMaxSize(getMaxSizePerNode()) - 1;\n+        int maxSizePerNode = getApproximateMaxSize(maxSizeConfig, PER_NODE) - 1;","path":"hazelcast/src/main/java/com/hazelcast/map/impl/mapstore/BasicMapStoreContext.java","position":17,"original_position":17,"commit_id":"c76b203f0d81c083d71338fc5cea6e1e10f9f938","original_commit_id":"c76b203f0d81c083d71338fc5cea6e1e10f9f938","user":{"login":"ajermakovics","id":999984,"avatar_url":"https://avatars.githubusercontent.com/u/999984?v=3","gravatar_id":"","url":"https://api.github.com/users/ajermakovics","html_url":"https://github.com/ajermakovics","followers_url":"https://api.github.com/users/ajermakovics/followers","following_url":"https://api.github.com/users/ajermakovics/following{/other_user}","gists_url":"https://api.github.com/users/ajermakovics/gists{/gist_id}","starred_url":"https://api.github.com/users/ajermakovics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajermakovics/subscriptions","organizations_url":"https://api.github.com/users/ajermakovics/orgs","repos_url":"https://api.github.com/users/ajermakovics/repos","events_url":"https://api.github.com/users/ajermakovics/events{/privacy}","received_events_url":"https://api.github.com/users/ajermakovics/received_events","type":"User","site_admin":false},"body":"It's because eviction starts when `nodeTotalSize >= maxSize`. The -1 is not absolutely necessary but without it an entry would get evicted right away.","created_at":"2015-01-13T07:49:40Z","updated_at":"2015-01-13T07:49:40Z","html_url":"https://github.com/hazelcast/hazelcast/pull/4350#discussion_r22847040","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/22847040"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4350#discussion_r22847040"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350","id":26499993,"html_url":"https://github.com/hazelcast/hazelcast/pull/4350","diff_url":"https://github.com/hazelcast/hazelcast/pull/4350.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/4350.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4350","number":4350,"state":"open","locked":false,"title":"IMap.loadAll now triggers map loading on each node","user":{"login":"ajermakovics","id":999984,"avatar_url":"https://avatars.githubusercontent.com/u/999984?v=3","gravatar_id":"","url":"https://api.github.com/users/ajermakovics","html_url":"https://github.com/ajermakovics","followers_url":"https://api.github.com/users/ajermakovics/followers","following_url":"https://api.github.com/users/ajermakovics/following{/other_user}","gists_url":"https://api.github.com/users/ajermakovics/gists{/gist_id}","starred_url":"https://api.github.com/users/ajermakovics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajermakovics/subscriptions","organizations_url":"https://api.github.com/users/ajermakovics/orgs","repos_url":"https://api.github.com/users/ajermakovics/repos","events_url":"https://api.github.com/users/ajermakovics/events{/privacy}","received_events_url":"https://api.github.com/users/ajermakovics/received_events","type":"User","site_admin":false},"body":"`IMap.loadAll` no longer loads all keys but instead sends an LoadMapOperation to all nodes. Each node then loads keys and values the same way as it does on node startup.","created_at":"2014-12-23T08:38:48Z","updated_at":"2015-01-13T07:49:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"92adce70c53f941210ec5e44944b2bc8f3d2b07f","assignee":{"login":"gurbuzali","id":1741680,"avatar_url":"https://avatars.githubusercontent.com/u/1741680?v=3","gravatar_id":"","url":"https://api.github.com/users/gurbuzali","html_url":"https://github.com/gurbuzali","followers_url":"https://api.github.com/users/gurbuzali/followers","following_url":"https://api.github.com/users/gurbuzali/following{/other_user}","gists_url":"https://api.github.com/users/gurbuzali/gists{/gist_id}","starred_url":"https://api.github.com/users/gurbuzali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gurbuzali/subscriptions","organizations_url":"https://api.github.com/users/gurbuzali/orgs","repos_url":"https://api.github.com/users/gurbuzali/repos","events_url":"https://api.github.com/users/gurbuzali/events{/privacy}","received_events_url":"https://api.github.com/users/gurbuzali/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/55/labels","id":819785,"number":55,"title":"3.5","description":null,"creator":{"login":"sancar","id":570462,"avatar_url":"https://avatars.githubusercontent.com/u/570462?v=3","gravatar_id":"","url":"https://api.github.com/users/sancar","html_url":"https://github.com/sancar","followers_url":"https://api.github.com/users/sancar/followers","following_url":"https://api.github.com/users/sancar/following{/other_user}","gists_url":"https://api.github.com/users/sancar/gists{/gist_id}","starred_url":"https://api.github.com/users/sancar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sancar/subscriptions","organizations_url":"https://api.github.com/users/sancar/orgs","repos_url":"https://api.github.com/users/sancar/repos","events_url":"https://api.github.com/users/sancar/events{/privacy}","received_events_url":"https://api.github.com/users/sancar/received_events","type":"User","site_admin":false},"open_issues":80,"closed_issues":38,"state":"open","created_at":"2014-10-09T13:04:53Z","updated_at":"2015-01-12T15:39:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/4350/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/c76b203f0d81c083d71338fc5cea6e1e10f9f938","head":{"label":"ajermakovics:mast/imap-loadall-distributed","ref":"mast/imap-loadall-distributed","sha":"c76b203f0d81c083d71338fc5cea6e1e10f9f938","user":{"login":"ajermakovics","id":999984,"avatar_url":"https://avatars.githubusercontent.com/u/999984?v=3","gravatar_id":"","url":"https://api.github.com/users/ajermakovics","html_url":"https://github.com/ajermakovics","followers_url":"https://api.github.com/users/ajermakovics/followers","following_url":"https://api.github.com/users/ajermakovics/following{/other_user}","gists_url":"https://api.github.com/users/ajermakovics/gists{/gist_id}","starred_url":"https://api.github.com/users/ajermakovics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajermakovics/subscriptions","organizations_url":"https://api.github.com/users/ajermakovics/orgs","repos_url":"https://api.github.com/users/ajermakovics/repos","events_url":"https://api.github.com/users/ajermakovics/events{/privacy}","received_events_url":"https://api.github.com/users/ajermakovics/received_events","type":"User","site_admin":false},"repo":{"id":23573957,"name":"hazelcast","full_name":"ajermakovics/hazelcast","owner":{"login":"ajermakovics","id":999984,"avatar_url":"https://avatars.githubusercontent.com/u/999984?v=3","gravatar_id":"","url":"https://api.github.com/users/ajermakovics","html_url":"https://github.com/ajermakovics","followers_url":"https://api.github.com/users/ajermakovics/followers","following_url":"https://api.github.com/users/ajermakovics/following{/other_user}","gists_url":"https://api.github.com/users/ajermakovics/gists{/gist_id}","starred_url":"https://api.github.com/users/ajermakovics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajermakovics/subscriptions","organizations_url":"https://api.github.com/users/ajermakovics/orgs","repos_url":"https://api.github.com/users/ajermakovics/repos","events_url":"https://api.github.com/users/ajermakovics/events{/privacy}","received_events_url":"https://api.github.com/users/ajermakovics/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajermakovics/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/ajermakovics/hazelcast","forks_url":"https://api.github.com/repos/ajermakovics/hazelcast/forks","keys_url":"https://api.github.com/repos/ajermakovics/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajermakovics/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajermakovics/hazelcast/teams","hooks_url":"https://api.github.com/repos/ajermakovics/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/ajermakovics/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/ajermakovics/hazelcast/events","assignees_url":"https://api.github.com/repos/ajermakovics/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/ajermakovics/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/ajermakovics/hazelcast/tags","blobs_url":"https://api.github.com/repos/ajermakovics/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajermakovics/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajermakovics/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajermakovics/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajermakovics/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/ajermakovics/hazelcast/languages","stargazers_url":"https://api.github.com/repos/ajermakovics/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/ajermakovics/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/ajermakovics/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/ajermakovics/hazelcast/subscription","commits_url":"https://api.github.com/repos/ajermakovics/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajermakovics/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajermakovics/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajermakovics/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/ajermakovics/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/ajermakovics/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajermakovics/hazelcast/merges","archive_url":"https://api.github.com/repos/ajermakovics/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajermakovics/hazelcast/downloads","issues_url":"https://api.github.com/repos/ajermakovics/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/ajermakovics/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/ajermakovics/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/ajermakovics/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajermakovics/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/ajermakovics/hazelcast/releases{/id}","created_at":"2014-09-02T10:10:13Z","updated_at":"2015-01-06T08:45:22Z","pushed_at":"2015-01-07T12:41:44Z","git_url":"git://github.com/ajermakovics/hazelcast.git","ssh_url":"git@github.com:ajermakovics/hazelcast.git","clone_url":"https://github.com/ajermakovics/hazelcast.git","svn_url":"https://github.com/ajermakovics/hazelcast","homepage":"www.hazelcast.com","size":57039,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"ea55c4068946346174752ca7fa1d7a8513c1a28a","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars.githubusercontent.com/u/1453152?v=3","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments/{number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","created_at":"2012-03-21T12:25:18Z","updated_at":"2015-01-12T21:36:38Z","pushed_at":"2015-01-12T21:36:37Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"www.hazelcast.com","size":111038,"stargazers_count":994,"watchers_count":994,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":350,"forks":450,"open_issues":350,"watchers":994,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/4350"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4350"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/4350/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/4350/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/c76b203f0d81c083d71338fc5cea6e1e10f9f938"}}}}