{"action":"created","issue":{"url":"https://api.github.com/repos/elm-lang/core/issues/85","labels_url":"https://api.github.com/repos/elm-lang/core/issues/85/labels{/name}","comments_url":"https://api.github.com/repos/elm-lang/core/issues/85/comments","events_url":"https://api.github.com/repos/elm-lang/core/issues/85/events","html_url":"https://github.com/elm-lang/core/pull/85","id":53888286,"number":85,"title":"Add more Basics tests","user":{"login":"deadfoxygrandpa","id":4319484,"avatar_url":"https://avatars.githubusercontent.com/u/4319484?v=3","gravatar_id":"","url":"https://api.github.com/users/deadfoxygrandpa","html_url":"https://github.com/deadfoxygrandpa","followers_url":"https://api.github.com/users/deadfoxygrandpa/followers","following_url":"https://api.github.com/users/deadfoxygrandpa/following{/other_user}","gists_url":"https://api.github.com/users/deadfoxygrandpa/gists{/gist_id}","starred_url":"https://api.github.com/users/deadfoxygrandpa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deadfoxygrandpa/subscriptions","organizations_url":"https://api.github.com/users/deadfoxygrandpa/orgs","repos_url":"https://api.github.com/users/deadfoxygrandpa/repos","events_url":"https://api.github.com/users/deadfoxygrandpa/events{/privacy}","received_events_url":"https://api.github.com/users/deadfoxygrandpa/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-01-09T16:49:35Z","updated_at":"2015-01-09T17:22:57Z","closed_at":"2015-01-09T17:21:52Z","pull_request":{"url":"https://api.github.com/repos/elm-lang/core/pulls/85","html_url":"https://github.com/elm-lang/core/pull/85","diff_url":"https://github.com/elm-lang/core/pull/85.diff","patch_url":"https://github.com/elm-lang/core/pull/85.patch"},"body":"I went through and added at least one test for every function defined in Basics. I used the example cases written in the documentation where available. All of these tests currently pass.\r\n\r\nSome of these are pretty trivial tests, but I was thinking why not just add one anyway?\r\n\r\nIf this is something that you think is acceptable or worth doing, I can continue adding tests like this to other files in core."},"comment":{"url":"https://api.github.com/repos/elm-lang/core/issues/comments/69366929","html_url":"https://github.com/elm-lang/core/pull/85#issuecomment-69366929","issue_url":"https://api.github.com/repos/elm-lang/core/issues/85","id":69366929,"user":{"login":"evancz","id":1658058,"avatar_url":"https://avatars.githubusercontent.com/u/1658058?v=3","gravatar_id":"","url":"https://api.github.com/users/evancz","html_url":"https://github.com/evancz","followers_url":"https://api.github.com/users/evancz/followers","following_url":"https://api.github.com/users/evancz/following{/other_user}","gists_url":"https://api.github.com/users/evancz/gists{/gist_id}","starred_url":"https://api.github.com/users/evancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evancz/subscriptions","organizations_url":"https://api.github.com/users/evancz/orgs","repos_url":"https://api.github.com/users/evancz/repos","events_url":"https://api.github.com/users/evancz/events{/privacy}","received_events_url":"https://api.github.com/users/evancz/received_events","type":"User","site_admin":false},"created_at":"2015-01-09T17:22:57Z","updated_at":"2015-01-09T17:22:57Z","body":"I think the `Json.Decode` module is a great candidate for tests at the moment. I think @laszlopandy tried to think of some tests for `Result` and couldn't think of anything super meaningful. In any case, yeah, this is awesome!"}}