{"action":"closed","number":13,"pull_request":{"url":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13","id":50423310,"html_url":"https://github.com/SuperTux88/diaspora_federation/pull/13","diff_url":"https://github.com/SuperTux88/diaspora_federation/pull/13.diff","patch_url":"https://github.com/SuperTux88/diaspora_federation/pull/13.patch","issue_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13","number":13,"state":"closed","locked":false,"title":"Add signature computation for entities support","user":{"login":"cmrd-senya","id":10187586,"avatar_url":"https://avatars.githubusercontent.com/u/10187586?v=3","gravatar_id":"","url":"https://api.github.com/users/cmrd-senya","html_url":"https://github.com/cmrd-senya","followers_url":"https://api.github.com/users/cmrd-senya/followers","following_url":"https://api.github.com/users/cmrd-senya/following{/other_user}","gists_url":"https://api.github.com/users/cmrd-senya/gists{/gist_id}","starred_url":"https://api.github.com/users/cmrd-senya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmrd-senya/subscriptions","organizations_url":"https://api.github.com/users/cmrd-senya/orgs","repos_url":"https://api.github.com/users/cmrd-senya/repos","events_url":"https://api.github.com/users/cmrd-senya/events{/privacy}","received_events_url":"https://api.github.com/users/cmrd-senya/received_events","type":"User","site_admin":false},"body":"This is a preliminary patch that implements signatures support for entities, the functionality that in Diaspora source represented by https://github.com/diaspora/diaspora/blob/develop/lib/diaspora/encryptable.rb and friends.\r\n\r\nIt notably differs from the way it is done in Diaspora. The thing is that in [4269](https://github.com/diaspora/diaspora/pull/4269) and [4935](https://github.com/diaspora/diaspora/pull/4935) developers faced problem, that adding any new field to an entity would break backward compatibility with older diaspora implementations. That's why I moved signable_string to the XmlPayload class. There it will iterate every field in received Salmon during signature generation, no matter if an entity class aware of it or not.\r\n\r\nThis, though, forced me to move signatures update routine call to the MagicEnvelope class, because it encapsulates all the work with XmlPayload.\r\n\r\nI put it here in order to receive some feedback on the approach I picked.","created_at":"2015-11-11T19:15:03Z","updated_at":"2015-11-22T21:10:12Z","closed_at":"2015-11-22T21:10:11Z","merged_at":"2015-11-22T21:10:11Z","merge_commit_sha":"85943220726d9e521fc3fcc159f22ee05cf6f702","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13/commits","review_comments_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13/comments","review_comment_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13/comments","statuses_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/statuses/91c3753019f56e637a3b84801d05290deae16ebf","head":{"label":"cmrd-senya:entities-signatures","ref":"entities-signatures","sha":"91c3753019f56e637a3b84801d05290deae16ebf","user":{"login":"cmrd-senya","id":10187586,"avatar_url":"https://avatars.githubusercontent.com/u/10187586?v=3","gravatar_id":"","url":"https://api.github.com/users/cmrd-senya","html_url":"https://github.com/cmrd-senya","followers_url":"https://api.github.com/users/cmrd-senya/followers","following_url":"https://api.github.com/users/cmrd-senya/following{/other_user}","gists_url":"https://api.github.com/users/cmrd-senya/gists{/gist_id}","starred_url":"https://api.github.com/users/cmrd-senya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmrd-senya/subscriptions","organizations_url":"https://api.github.com/users/cmrd-senya/orgs","repos_url":"https://api.github.com/users/cmrd-senya/repos","events_url":"https://api.github.com/users/cmrd-senya/events{/privacy}","received_events_url":"https://api.github.com/users/cmrd-senya/received_events","type":"User","site_admin":false},"repo":{"id":44808020,"name":"diaspora_federation","full_name":"cmrd-senya/diaspora_federation","owner":{"login":"cmrd-senya","id":10187586,"avatar_url":"https://avatars.githubusercontent.com/u/10187586?v=3","gravatar_id":"","url":"https://api.github.com/users/cmrd-senya","html_url":"https://github.com/cmrd-senya","followers_url":"https://api.github.com/users/cmrd-senya/followers","following_url":"https://api.github.com/users/cmrd-senya/following{/other_user}","gists_url":"https://api.github.com/users/cmrd-senya/gists{/gist_id}","starred_url":"https://api.github.com/users/cmrd-senya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmrd-senya/subscriptions","organizations_url":"https://api.github.com/users/cmrd-senya/orgs","repos_url":"https://api.github.com/users/cmrd-senya/repos","events_url":"https://api.github.com/users/cmrd-senya/events{/privacy}","received_events_url":"https://api.github.com/users/cmrd-senya/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmrd-senya/diaspora_federation","description":"diaspora* federation rails engine","fork":true,"url":"https://api.github.com/repos/cmrd-senya/diaspora_federation","forks_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/forks","keys_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/teams","hooks_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/hooks","issue_events_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/issues/events{/number}","events_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/events","assignees_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/assignees{/user}","branches_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/branches{/branch}","tags_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/tags","blobs_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/statuses/{sha}","languages_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/languages","stargazers_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/stargazers","contributors_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/contributors","subscribers_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/subscribers","subscription_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/subscription","commits_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/contents/{+path}","compare_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/merges","archive_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/downloads","issues_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/issues{/number}","pulls_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/pulls{/number}","milestones_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/milestones{/number}","notifications_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/labels{/name}","releases_url":"https://api.github.com/repos/cmrd-senya/diaspora_federation/releases{/id}","created_at":"2015-10-23T11:05:28Z","updated_at":"2015-10-23T11:05:28Z","pushed_at":"2015-11-22T21:01:12Z","git_url":"git://github.com/cmrd-senya/diaspora_federation.git","ssh_url":"git@github.com:cmrd-senya/diaspora_federation.git","clone_url":"https://github.com/cmrd-senya/diaspora_federation.git","svn_url":"https://github.com/cmrd-senya/diaspora_federation","homepage":"","size":319,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SuperTux88:salmon","ref":"salmon","sha":"1b929a6bbf4bb8d4ffa588386ee9a5b9ecf1dc71","user":{"login":"SuperTux88","id":458548,"avatar_url":"https://avatars.githubusercontent.com/u/458548?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperTux88","html_url":"https://github.com/SuperTux88","followers_url":"https://api.github.com/users/SuperTux88/followers","following_url":"https://api.github.com/users/SuperTux88/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux88/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux88/subscriptions","organizations_url":"https://api.github.com/users/SuperTux88/orgs","repos_url":"https://api.github.com/users/SuperTux88/repos","events_url":"https://api.github.com/users/SuperTux88/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux88/received_events","type":"User","site_admin":false},"repo":{"id":37167642,"name":"diaspora_federation","full_name":"SuperTux88/diaspora_federation","owner":{"login":"SuperTux88","id":458548,"avatar_url":"https://avatars.githubusercontent.com/u/458548?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperTux88","html_url":"https://github.com/SuperTux88","followers_url":"https://api.github.com/users/SuperTux88/followers","following_url":"https://api.github.com/users/SuperTux88/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux88/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux88/subscriptions","organizations_url":"https://api.github.com/users/SuperTux88/orgs","repos_url":"https://api.github.com/users/SuperTux88/repos","events_url":"https://api.github.com/users/SuperTux88/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/SuperTux88/diaspora_federation","description":"diaspora* federation rails engine","fork":false,"url":"https://api.github.com/repos/SuperTux88/diaspora_federation","forks_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/forks","keys_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/teams","hooks_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/hooks","issue_events_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/events{/number}","events_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/events","assignees_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/assignees{/user}","branches_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/branches{/branch}","tags_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/tags","blobs_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/languages","stargazers_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/stargazers","contributors_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/contributors","subscribers_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/subscribers","subscription_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/subscription","commits_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/contents/{+path}","compare_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/merges","archive_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/downloads","issues_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues{/number}","pulls_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/labels{/name}","releases_url":"https://api.github.com/repos/SuperTux88/diaspora_federation/releases{/id}","created_at":"2015-06-10T01:08:15Z","updated_at":"2015-10-21T11:32:48Z","pushed_at":"2015-11-22T21:10:12Z","git_url":"git://github.com/SuperTux88/diaspora_federation.git","ssh_url":"git@github.com:SuperTux88/diaspora_federation.git","clone_url":"https://github.com/SuperTux88/diaspora_federation.git","svn_url":"https://github.com/SuperTux88/diaspora_federation","homepage":"","size":332,"stargazers_count":6,"watchers_count":6,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13"},"html":{"href":"https://github.com/SuperTux88/diaspora_federation/pull/13"},"issue":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13"},"comments":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/SuperTux88/diaspora_federation/statuses/91c3753019f56e637a3b84801d05290deae16ebf"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"SuperTux88","id":458548,"avatar_url":"https://avatars.githubusercontent.com/u/458548?v=3","gravatar_id":"","url":"https://api.github.com/users/SuperTux88","html_url":"https://github.com/SuperTux88","followers_url":"https://api.github.com/users/SuperTux88/followers","following_url":"https://api.github.com/users/SuperTux88/following{/other_user}","gists_url":"https://api.github.com/users/SuperTux88/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperTux88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperTux88/subscriptions","organizations_url":"https://api.github.com/users/SuperTux88/orgs","repos_url":"https://api.github.com/users/SuperTux88/repos","events_url":"https://api.github.com/users/SuperTux88/events{/privacy}","received_events_url":"https://api.github.com/users/SuperTux88/received_events","type":"User","site_admin":false},"comments":10,"review_comments":72,"commits":1,"additions":444,"deletions":32,"changed_files":18}}