{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/scenery-phet/issues/196","labels_url":"https://api.github.com/repos/phetsims/scenery-phet/issues/196/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/scenery-phet/issues/196/comments","events_url":"https://api.github.com/repos/phetsims/scenery-phet/issues/196/events","html_url":"https://github.com/phetsims/scenery-phet/issues/196","id":113666235,"number":196,"title":"problem with specular highlight on ProbeNode","user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/phetsims/scenery-phet/labels/Summer%202015%20redeploy","name":"Summer 2015 redeploy","color":"5319e7"}],"state":"open","locked":false,"assignee":{"login":"ariel-phet","id":4051174,"avatar_url":"https://avatars.githubusercontent.com/u/4051174?v=3","gravatar_id":"","url":"https://api.github.com/users/ariel-phet","html_url":"https://github.com/ariel-phet","followers_url":"https://api.github.com/users/ariel-phet/followers","following_url":"https://api.github.com/users/ariel-phet/following{/other_user}","gists_url":"https://api.github.com/users/ariel-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/ariel-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariel-phet/subscriptions","organizations_url":"https://api.github.com/users/ariel-phet/orgs","repos_url":"https://api.github.com/users/ariel-phet/repos","events_url":"https://api.github.com/users/ariel-phet/events{/privacy}","received_events_url":"https://api.github.com/users/ariel-phet/received_events","type":"User","site_admin":false},"milestone":null,"comments":31,"created_at":"2015-10-27T19:44:15Z","updated_at":"2015-12-04T17:12:54Z","closed_at":null,"body":"Discovered while integrating ProbeNode into ph-scale (https://github.com/phetsims/ph-scale/issues/61).\r\n\r\nThere's a problem with the lightAngle option in ProbeNode.  It seems to assume that the specular highlight is applied to some part of the rounded section of the probe, and that's definitely not the case. \r\n\r\nHere's an example, from ph-scale.MacroPHMeterNode, line 245:\r\n\r\n```js\r\n    ProbeNode.call( thisNode, {\r\n      sensorType: ProbeNode.crosshairs( {\r\n        intersectionRadius: 6\r\n      } ),\r\n      radius: 34,\r\n      innerRadius: 26,\r\n      handleWidth: 30,\r\n      handleHeight: 25,\r\n      handleCornerRadius: 12,\r\n      lightAngle: 0.85 * Math.PI,\r\n      color: 'rgb( 35, 129, 0 )',\r\n      rotation: Math.PI / 2,\r\n      cursor: 'pointer'\r\n    } );\r\n```\r\n\r\nHere's what it looks like if you scale the probe up up by 2x (so that you can see it better):\r\n\r\n![screenshot_37](https://cloud.githubusercontent.com/assets/3046552/10770338/601cf632-7cb0-11e5-95dc-bb7004fa38fc.png)\r\n\r\nNote how the highlight looks mangled where the probe handle starts. Looks like the specular highlight has a problem if the light shines on the handle."},"comment":{"url":"https://api.github.com/repos/phetsims/scenery-phet/issues/comments/162024577","html_url":"https://github.com/phetsims/scenery-phet/issues/196#issuecomment-162024577","issue_url":"https://api.github.com/repos/phetsims/scenery-phet/issues/196","id":162024577,"user":{"login":"pixelzoom","id":3046552,"avatar_url":"https://avatars.githubusercontent.com/u/3046552?v=3","gravatar_id":"","url":"https://api.github.com/users/pixelzoom","html_url":"https://github.com/pixelzoom","followers_url":"https://api.github.com/users/pixelzoom/followers","following_url":"https://api.github.com/users/pixelzoom/following{/other_user}","gists_url":"https://api.github.com/users/pixelzoom/gists{/gist_id}","starred_url":"https://api.github.com/users/pixelzoom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pixelzoom/subscriptions","organizations_url":"https://api.github.com/users/pixelzoom/orgs","repos_url":"https://api.github.com/users/pixelzoom/repos","events_url":"https://api.github.com/users/pixelzoom/events{/privacy}","received_events_url":"https://api.github.com/users/pixelzoom/received_events","type":"User","site_admin":false},"created_at":"2015-12-04T17:12:54Z","updated_at":"2015-12-04T17:12:54Z","body":"In https://github.com/phetsims/scenery-phet/issues/196#issuecomment-161890131 @samreid wrote:\r\n> After the change, here is how it looks in the sim:\r\n\r\nClearly not pH Scale (unless you changed the background color), which has been \"the sim\" discussed so far. Which sim is this?"}}