{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/27068650","id":27068650,"diff_hunk":"@@ -8,11 +8,16 @@ private let BorderColor = UIColor(rgb: 0xeeeeee)\n private let LabelFont = UIFont(name: \"FiraSans-Regular\", size: 11)\n private let LabelColor = UIAccessibilityDarkerSystemColorsEnabled() ? UIColor.blackColor() : UIColor.darkGrayColor()\n private let CellInsets = UIEdgeInsetsMake(8, 8, 8, 8)\n-private let TextMargin = 5\n+\n+private let PlaceholderImage = UIImage(named: \"defaultFavicon\")\n+\n+struct ThumbnailCellUX {\n+    static let ImageAspectRatio: Float = 1.5","path":"Client/Frontend/Widgets/ThumbnailCell.swift","position":9,"original_position":9,"commit_id":"ce6f8772fab67b1b576ea3713db41641ec5301ba","original_commit_id":"ce6f8772fab67b1b576ea3713db41641ec5301ba","user":{"login":"wesj","id":1117644,"avatar_url":"https://avatars.githubusercontent.com/u/1117644?v=3","gravatar_id":"","url":"https://api.github.com/users/wesj","html_url":"https://github.com/wesj","followers_url":"https://api.github.com/users/wesj/followers","following_url":"https://api.github.com/users/wesj/following{/other_user}","gists_url":"https://api.github.com/users/wesj/gists{/gist_id}","starred_url":"https://api.github.com/users/wesj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wesj/subscriptions","organizations_url":"https://api.github.com/users/wesj/orgs","repos_url":"https://api.github.com/users/wesj/repos","events_url":"https://api.github.com/users/wesj/events{/privacy}","received_events_url":"https://api.github.com/users/wesj/received_events","type":"User","site_admin":false},"body":"I'm confused about the difference between the aspect ratio and the one used in TopSitesPanel. Are they different? Just by the label height on the bottom of the thumbnail?","created_at":"2015-03-24T20:20:55Z","updated_at":"2015-03-24T20:20:55Z","html_url":"https://github.com/mozilla/firefox-ios/pull/261#discussion_r27068650","pull_request_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261","_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments/27068650"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/261#discussion_r27068650"},"pull_request":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261","id":31803544,"html_url":"https://github.com/mozilla/firefox-ios/pull/261","diff_url":"https://github.com/mozilla/firefox-ios/pull/261.diff","patch_url":"https://github.com/mozilla/firefox-ios/pull/261.patch","issue_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/261","number":261,"state":"open","locked":false,"title":"Bug 1144350 - Show thumbnails on top sites panel","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-03-24T07:50:06Z","updated_at":"2015-03-24T20:20:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db1032a0f06859919e1e8098b687b5d3f06bbcb6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261/commits","review_comments_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261/comments","review_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/261/comments","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/ce6f8772fab67b1b576ea3713db41641ec5301ba","head":{"label":"thebnich:thumbnails","ref":"thumbnails","sha":"ce6f8772fab67b1b576ea3713db41641ec5301ba","user":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"repo":{"id":27744299,"name":"firefox-ios","full_name":"thebnich/firefox-ios","owner":{"login":"thebnich","id":1093266,"avatar_url":"https://avatars.githubusercontent.com/u/1093266?v=3","gravatar_id":"","url":"https://api.github.com/users/thebnich","html_url":"https://github.com/thebnich","followers_url":"https://api.github.com/users/thebnich/followers","following_url":"https://api.github.com/users/thebnich/following{/other_user}","gists_url":"https://api.github.com/users/thebnich/gists{/gist_id}","starred_url":"https://api.github.com/users/thebnich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thebnich/subscriptions","organizations_url":"https://api.github.com/users/thebnich/orgs","repos_url":"https://api.github.com/users/thebnich/repos","events_url":"https://api.github.com/users/thebnich/events{/privacy}","received_events_url":"https://api.github.com/users/thebnich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thebnich/firefox-ios","description":"Firefox for iOS","fork":true,"url":"https://api.github.com/repos/thebnich/firefox-ios","forks_url":"https://api.github.com/repos/thebnich/firefox-ios/forks","keys_url":"https://api.github.com/repos/thebnich/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thebnich/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thebnich/firefox-ios/teams","hooks_url":"https://api.github.com/repos/thebnich/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/thebnich/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/thebnich/firefox-ios/events","assignees_url":"https://api.github.com/repos/thebnich/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/thebnich/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/thebnich/firefox-ios/tags","blobs_url":"https://api.github.com/repos/thebnich/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thebnich/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thebnich/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/thebnich/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thebnich/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/thebnich/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/thebnich/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/thebnich/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/thebnich/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/thebnich/firefox-ios/subscription","commits_url":"https://api.github.com/repos/thebnich/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/thebnich/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/thebnich/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/thebnich/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/thebnich/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/thebnich/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thebnich/firefox-ios/merges","archive_url":"https://api.github.com/repos/thebnich/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thebnich/firefox-ios/downloads","issues_url":"https://api.github.com/repos/thebnich/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/thebnich/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/thebnich/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/thebnich/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thebnich/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/thebnich/firefox-ios/releases{/id}","created_at":"2014-12-09T01:43:28Z","updated_at":"2015-02-20T01:57:25Z","pushed_at":"2015-03-24T20:12:01Z","git_url":"git://github.com/thebnich/firefox-ios.git","ssh_url":"git@github.com:thebnich/firefox-ios.git","clone_url":"https://github.com/thebnich/firefox-ios.git","svn_url":"https://github.com/thebnich/firefox-ios","homepage":"","size":15577,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"ac549231856bc5a6bb128099e2c5e4d9a68140b2","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":26133979,"name":"firefox-ios","full_name":"mozilla/firefox-ios","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/firefox-ios","description":"Firefox for iOS","fork":false,"url":"https://api.github.com/repos/mozilla/firefox-ios","forks_url":"https://api.github.com/repos/mozilla/firefox-ios/forks","keys_url":"https://api.github.com/repos/mozilla/firefox-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/firefox-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/firefox-ios/teams","hooks_url":"https://api.github.com/repos/mozilla/firefox-ios/hooks","issue_events_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/firefox-ios/events","assignees_url":"https://api.github.com/repos/mozilla/firefox-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/firefox-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/firefox-ios/tags","blobs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/firefox-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/firefox-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/firefox-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/firefox-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/firefox-ios/languages","stargazers_url":"https://api.github.com/repos/mozilla/firefox-ios/stargazers","contributors_url":"https://api.github.com/repos/mozilla/firefox-ios/contributors","subscribers_url":"https://api.github.com/repos/mozilla/firefox-ios/subscribers","subscription_url":"https://api.github.com/repos/mozilla/firefox-ios/subscription","commits_url":"https://api.github.com/repos/mozilla/firefox-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/firefox-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/firefox-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/firefox-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/firefox-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/firefox-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/firefox-ios/merges","archive_url":"https://api.github.com/repos/mozilla/firefox-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/firefox-ios/downloads","issues_url":"https://api.github.com/repos/mozilla/firefox-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/firefox-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/firefox-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/firefox-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/firefox-ios/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/firefox-ios/releases{/id}","created_at":"2014-11-03T19:07:02Z","updated_at":"2015-03-24T20:13:18Z","pushed_at":"2015-03-24T20:13:18Z","git_url":"git://github.com/mozilla/firefox-ios.git","ssh_url":"git@github.com:mozilla/firefox-ios.git","clone_url":"https://github.com/mozilla/firefox-ios.git","svn_url":"https://github.com/mozilla/firefox-ios","homepage":"","size":24576,"stargazers_count":3036,"watchers_count":3036,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":491,"mirror_url":null,"open_issues_count":16,"forks":491,"open_issues":16,"watchers":3036,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261"},"html":{"href":"https://github.com/mozilla/firefox-ios/pull/261"},"issue":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/261"},"comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/firefox-ios/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/firefox-ios/statuses/ce6f8772fab67b1b576ea3713db41641ec5301ba"}}}}