{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corert/pulls/comments/48206660","id":48206660,"diff_hunk":"@@ -60,14 +60,37 @@\n             <ILCompilerSdkFiles Include=\"bootstrappercpp\" />\n             <ILCompilerSdkFiles Include=\"System.Private.CoreLib.Native\" Condition=\"'$(OsEnvironment)'!='Windows_NT'\" />\n \n+            <!-- ILCompiler.SDK Cpp Codegen support files -->\n+            <ILCompilerSdkCppCodegenFiles Include=\"Native/gc/env/etmdummy.h\" />\n+            <ILCompilerSdkCppCodegenFiles Include=\"Native/gc/env/gcenv.base.h\" />","path":"src/packaging/packages.targets","position":15,"original_position":15,"commit_id":"8265b9c871a9162028f5db6e7c522bcdba1d34ea","original_commit_id":"203dbfcef990fa288f680d4aa216905d58a79d8b","user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"body":"The headers from GC won't be needed in the SDK post my PR. They will be only needed to compile the runtime, not the auto-generated .cpp files.\r\n\r\n(Eventually, we should not need even sal.h/gcenv.structs.h/gcenv.base.h in the SDK ... but there is a bit more cleanup required for that.)","created_at":"2015-12-21T23:50:11Z","updated_at":"2015-12-21T23:50:11Z","html_url":"https://github.com/dotnet/corert/pull/556#discussion_r48206660","pull_request_url":"https://api.github.com/repos/dotnet/corert/pulls/556","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments/48206660"},"html":{"href":"https://github.com/dotnet/corert/pull/556#discussion_r48206660"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corert/pulls/556"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/556","id":54220719,"html_url":"https://github.com/dotnet/corert/pull/556","diff_url":"https://github.com/dotnet/corert/pull/556.diff","patch_url":"https://github.com/dotnet/corert/pull/556.patch","issue_url":"https://api.github.com/repos/dotnet/corert/issues/556","number":556,"state":"closed","locked":false,"title":"Refactor AppDep and ILCompiler.SDK packages","user":{"login":"gkhanna79","id":9451457,"avatar_url":"https://avatars.githubusercontent.com/u/9451457?v=3","gravatar_id":"","url":"https://api.github.com/users/gkhanna79","html_url":"https://github.com/gkhanna79","followers_url":"https://api.github.com/users/gkhanna79/followers","following_url":"https://api.github.com/users/gkhanna79/following{/other_user}","gists_url":"https://api.github.com/users/gkhanna79/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhanna79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhanna79/subscriptions","organizations_url":"https://api.github.com/users/gkhanna79/orgs","repos_url":"https://api.github.com/users/gkhanna79/repos","events_url":"https://api.github.com/users/gkhanna79/events{/privacy}","received_events_url":"https://api.github.com/users/gkhanna79/received_events","type":"User","site_admin":false},"body":"This change does the following:\r\n\r\n1) Moves headers from AppDep to native\\sdk\\inc and native\\sdk\\inc\\common folders in ILCompiler.SDK\r\n2) Update ILCompiler.SDK nuget package authoring for the same\r\n3) Move the stub code (from lxstubs.cpp and osxstubs.cpp) into bootstrapper\r\n4) Add support to the build and test scripts for consuming CLI from a custom location. This is enabling me to test the corresponding change in CLI repo alongwith this one.\r\n\r\nStill to do:\r\n\r\n1) Validate and test for Unix builds\r\n\r\nCorresponding CLI PR is https://github.com/dotnet/cli/pull/632.\r\n\r\n@schellap @jkotas PTAL.","created_at":"2015-12-21T04:55:56Z","updated_at":"2015-12-21T23:50:11Z","closed_at":"2015-12-21T23:41:26Z","merged_at":"2015-12-21T23:41:26Z","merge_commit_sha":"4b9274357b4ba56c1ae41f1598f8f69ad8b7dda3","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corert/pulls/556/commits","review_comments_url":"https://api.github.com/repos/dotnet/corert/pulls/556/comments","review_comment_url":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/556/comments","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/8265b9c871a9162028f5db6e7c522bcdba1d34ea","head":{"label":"gkhanna79:FixILCSDK","ref":"FixILCSDK","sha":"8265b9c871a9162028f5db6e7c522bcdba1d34ea","user":{"login":"gkhanna79","id":9451457,"avatar_url":"https://avatars.githubusercontent.com/u/9451457?v=3","gravatar_id":"","url":"https://api.github.com/users/gkhanna79","html_url":"https://github.com/gkhanna79","followers_url":"https://api.github.com/users/gkhanna79/followers","following_url":"https://api.github.com/users/gkhanna79/following{/other_user}","gists_url":"https://api.github.com/users/gkhanna79/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhanna79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhanna79/subscriptions","organizations_url":"https://api.github.com/users/gkhanna79/orgs","repos_url":"https://api.github.com/users/gkhanna79/repos","events_url":"https://api.github.com/users/gkhanna79/events{/privacy}","received_events_url":"https://api.github.com/users/gkhanna79/received_events","type":"User","site_admin":false},"repo":{"id":46435478,"name":"corert","full_name":"gkhanna79/corert","owner":{"login":"gkhanna79","id":9451457,"avatar_url":"https://avatars.githubusercontent.com/u/9451457?v=3","gravatar_id":"","url":"https://api.github.com/users/gkhanna79","html_url":"https://github.com/gkhanna79","followers_url":"https://api.github.com/users/gkhanna79/followers","following_url":"https://api.github.com/users/gkhanna79/following{/other_user}","gists_url":"https://api.github.com/users/gkhanna79/gists{/gist_id}","starred_url":"https://api.github.com/users/gkhanna79/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gkhanna79/subscriptions","organizations_url":"https://api.github.com/users/gkhanna79/orgs","repos_url":"https://api.github.com/users/gkhanna79/repos","events_url":"https://api.github.com/users/gkhanna79/events{/privacy}","received_events_url":"https://api.github.com/users/gkhanna79/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gkhanna79/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":true,"url":"https://api.github.com/repos/gkhanna79/corert","forks_url":"https://api.github.com/repos/gkhanna79/corert/forks","keys_url":"https://api.github.com/repos/gkhanna79/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gkhanna79/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gkhanna79/corert/teams","hooks_url":"https://api.github.com/repos/gkhanna79/corert/hooks","issue_events_url":"https://api.github.com/repos/gkhanna79/corert/issues/events{/number}","events_url":"https://api.github.com/repos/gkhanna79/corert/events","assignees_url":"https://api.github.com/repos/gkhanna79/corert/assignees{/user}","branches_url":"https://api.github.com/repos/gkhanna79/corert/branches{/branch}","tags_url":"https://api.github.com/repos/gkhanna79/corert/tags","blobs_url":"https://api.github.com/repos/gkhanna79/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gkhanna79/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gkhanna79/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/gkhanna79/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gkhanna79/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/gkhanna79/corert/languages","stargazers_url":"https://api.github.com/repos/gkhanna79/corert/stargazers","contributors_url":"https://api.github.com/repos/gkhanna79/corert/contributors","subscribers_url":"https://api.github.com/repos/gkhanna79/corert/subscribers","subscription_url":"https://api.github.com/repos/gkhanna79/corert/subscription","commits_url":"https://api.github.com/repos/gkhanna79/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/gkhanna79/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/gkhanna79/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/gkhanna79/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/gkhanna79/corert/contents/{+path}","compare_url":"https://api.github.com/repos/gkhanna79/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gkhanna79/corert/merges","archive_url":"https://api.github.com/repos/gkhanna79/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gkhanna79/corert/downloads","issues_url":"https://api.github.com/repos/gkhanna79/corert/issues{/number}","pulls_url":"https://api.github.com/repos/gkhanna79/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/gkhanna79/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/gkhanna79/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gkhanna79/corert/labels{/name}","releases_url":"https://api.github.com/repos/gkhanna79/corert/releases{/id}","created_at":"2015-11-18T17:28:56Z","updated_at":"2015-11-18T17:28:59Z","pushed_at":"2015-12-21T23:04:37Z","git_url":"git://github.com/gkhanna79/corert.git","ssh_url":"git@github.com:gkhanna79/corert.git","clone_url":"https://github.com/gkhanna79/corert.git","svn_url":"https://github.com/gkhanna79/corert","homepage":"http://dotnet.github.io/","size":4910,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"cb28e8bde147cd1f396604be1103a0141117ceb1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42552143,"name":"corert","full_name":"dotnet/corert","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corert","description":"This repo contains CoreRT, a .NET Core runtime optimized for AOT (ahead of time compilation) scenarios, with the accompanying .NET Native compiler toolchain.","fork":false,"url":"https://api.github.com/repos/dotnet/corert","forks_url":"https://api.github.com/repos/dotnet/corert/forks","keys_url":"https://api.github.com/repos/dotnet/corert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corert/teams","hooks_url":"https://api.github.com/repos/dotnet/corert/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corert/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corert/events","assignees_url":"https://api.github.com/repos/dotnet/corert/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corert/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corert/tags","blobs_url":"https://api.github.com/repos/dotnet/corert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corert/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corert/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corert/languages","stargazers_url":"https://api.github.com/repos/dotnet/corert/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corert/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corert/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corert/subscription","commits_url":"https://api.github.com/repos/dotnet/corert/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corert/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corert/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corert/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corert/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corert/merges","archive_url":"https://api.github.com/repos/dotnet/corert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corert/downloads","issues_url":"https://api.github.com/repos/dotnet/corert/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corert/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corert/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corert/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corert/releases{/id}","created_at":"2015-09-15T23:10:53Z","updated_at":"2015-12-21T18:52:11Z","pushed_at":"2015-12-21T23:41:26Z","git_url":"git://github.com/dotnet/corert.git","ssh_url":"git@github.com:dotnet/corert.git","clone_url":"https://github.com/dotnet/corert.git","svn_url":"https://github.com/dotnet/corert","homepage":"http://dotnet.github.io/","size":5326,"stargazers_count":148,"watchers_count":148,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":99,"forks":49,"open_issues":99,"watchers":148,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corert/pulls/556"},"html":{"href":"https://github.com/dotnet/corert/pull/556"},"issue":{"href":"https://api.github.com/repos/dotnet/corert/issues/556"},"comments":{"href":"https://api.github.com/repos/dotnet/corert/issues/556/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corert/pulls/556/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corert/pulls/556/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corert/statuses/8265b9c871a9162028f5db6e7c522bcdba1d34ea"}}}}