{"action":"created","issue":{"url":"https://api.github.com/repos/google/closure-compiler/issues/1094","labels_url":"https://api.github.com/repos/google/closure-compiler/issues/1094/labels{/name}","comments_url":"https://api.github.com/repos/google/closure-compiler/issues/1094/comments","events_url":"https://api.github.com/repos/google/closure-compiler/issues/1094/events","html_url":"https://github.com/google/closure-compiler/pull/1094","id":102365359,"number":1094,"title":"New pass WhitespaceWrapGoogModules in specialist \"always pre-check\" phase (fixes #611)","user":{"login":"supersteves","id":10280734,"avatar_url":"https://avatars.githubusercontent.com/u/10280734?v=3","gravatar_id":"","url":"https://api.github.com/users/supersteves","html_url":"https://github.com/supersteves","followers_url":"https://api.github.com/users/supersteves/followers","following_url":"https://api.github.com/users/supersteves/following{/other_user}","gists_url":"https://api.github.com/users/supersteves/gists{/gist_id}","starred_url":"https://api.github.com/users/supersteves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supersteves/subscriptions","organizations_url":"https://api.github.com/users/supersteves/orgs","repos_url":"https://api.github.com/users/supersteves/repos","events_url":"https://api.github.com/users/supersteves/events{/privacy}","received_events_url":"https://api.github.com/users/supersteves/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/google/closure-compiler/labels/cla:%20yes","name":"cla: yes","color":"009800"}],"state":"open","locked":false,"assignee":{"login":"concavelenz","id":1245994,"avatar_url":"https://avatars.githubusercontent.com/u/1245994?v=3","gravatar_id":"","url":"https://api.github.com/users/concavelenz","html_url":"https://github.com/concavelenz","followers_url":"https://api.github.com/users/concavelenz/followers","following_url":"https://api.github.com/users/concavelenz/following{/other_user}","gists_url":"https://api.github.com/users/concavelenz/gists{/gist_id}","starred_url":"https://api.github.com/users/concavelenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concavelenz/subscriptions","organizations_url":"https://api.github.com/users/concavelenz/orgs","repos_url":"https://api.github.com/users/concavelenz/repos","events_url":"https://api.github.com/users/concavelenz/events{/privacy}","received_events_url":"https://api.github.com/users/concavelenz/received_events","type":"User","site_admin":false},"milestone":null,"comments":10,"created_at":"2015-08-21T12:11:35Z","updated_at":"2015-08-26T15:19:28Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/google/closure-compiler/pulls/1094","html_url":"https://github.com/google/closure-compiler/pull/1094","diff_url":"https://github.com/google/closure-compiler/pull/1094.diff","patch_url":"https://github.com/google/closure-compiler/pull/1094.patch"},"body":"I predict this will be rejected since it is arguable that the ```WHITESPACE_ONLY``` mode should mean just that.  However my argument is that goog.modules are unusable without this (#611), therefore it is forgiveable.\r\n\r\nFor a large codebase, you need to be able to develop rapidly without waiting for the ~ 40 second compile time we're currently seeing. Whitespace only mode drops this to ~2 seconds.\r\n\r\nAlso I'm adding a new pass phase \"always pre-check\" (which happens always, even in whitespace only mode) immediately prior to the \"checks\" phase (which only happens in simple or advanced mode). Even more debatable! I first tried using a custom pass in the options (see reverted commits), but I don't have the Compiler instance yet (needed for ```compiler.reportCodeChange()```) when I build the options in my external Java compiler front-end.  If you don't like this, I could find a way to do it using custom passes, but that's not going to help other users as much.\r\n\r\nCurrently WhitespaceWrapGoogModules is opt-in, but should be made default in WHITESPACE_ONLY once approved. \r\n\r\nI expect this to fail Travis, since the parent commit is already failing (@blickly). If you reject because of Travis failures, how should I proceed?"},"comment":{"url":"https://api.github.com/repos/google/closure-compiler/issues/comments/135059198","html_url":"https://github.com/google/closure-compiler/pull/1094#issuecomment-135059198","issue_url":"https://api.github.com/repos/google/closure-compiler/issues/1094","id":135059198,"user":{"login":"concavelenz","id":1245994,"avatar_url":"https://avatars.githubusercontent.com/u/1245994?v=3","gravatar_id":"","url":"https://api.github.com/users/concavelenz","html_url":"https://github.com/concavelenz","followers_url":"https://api.github.com/users/concavelenz/followers","following_url":"https://api.github.com/users/concavelenz/following{/other_user}","gists_url":"https://api.github.com/users/concavelenz/gists{/gist_id}","starred_url":"https://api.github.com/users/concavelenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concavelenz/subscriptions","organizations_url":"https://api.github.com/users/concavelenz/orgs","repos_url":"https://api.github.com/users/concavelenz/repos","events_url":"https://api.github.com/users/concavelenz/events{/privacy}","received_events_url":"https://api.github.com/users/concavelenz/received_events","type":"User","site_admin":false},"created_at":"2015-08-26T15:19:28Z","updated_at":"2015-08-26T15:19:28Z","body":"@blickly Ben if you want to review this for consistency with the ES6->ES5 transpilation support in \"whitespace\" mode, I'll review it the bundling logic."}}