{"action":"closed","number":3526,"pull_request":{"url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3526","id":26841725,"html_url":"https://github.com/openframeworks/openFrameworks/pull/3526","diff_url":"https://github.com/openframeworks/openFrameworks/pull/3526.diff","patch_url":"https://github.com/openframeworks/openFrameworks/pull/3526.patch","issue_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3526","number":3526,"state":"closed","locked":false,"title":"Fix for Direct State Access on Windows","user":{"login":"tgfrerer","id":423509,"avatar_url":"https://avatars.githubusercontent.com/u/423509?v=3","gravatar_id":"","url":"https://api.github.com/users/tgfrerer","html_url":"https://github.com/tgfrerer","followers_url":"https://api.github.com/users/tgfrerer/followers","following_url":"https://api.github.com/users/tgfrerer/following{/other_user}","gists_url":"https://api.github.com/users/tgfrerer/gists{/gist_id}","starred_url":"https://api.github.com/users/tgfrerer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgfrerer/subscriptions","organizations_url":"https://api.github.com/users/tgfrerer/orgs","repos_url":"https://api.github.com/users/tgfrerer/repos","events_url":"https://api.github.com/users/tgfrerer/events{/privacy}","received_events_url":"https://api.github.com/users/tgfrerer/received_events","type":"User","site_admin":false},"body":"fixes #3523\r\n\r\n* uses `glCreateBuffers` instead of `glGenBuffers` if direct state access (OpenGL 4.5+) is available.\r\n\r\nglGenBuffers does not actually create a buffer, it just returns the next available name, and only a subsequent\r\ncall to bind() will actualy initialize the buffer in memory.\r\n\r\nThis is why, for direct state access, we need to call glCreateBuffers(), so that the buffer is initialized when we pin data to it using setData()\r\n\r\nBefore this change, OpenGL 4.5 enabled cards would not draw any VBO based graphics.\r\n\r\nThis might also be related to #3514\r\n\r\nSee also: https://www.opengl.org/registry/specs/ARB/direct_state_access.txt","created_at":"2015-01-05T18:35:38Z","updated_at":"2015-01-05T18:38:56Z","closed_at":"2015-01-05T18:38:56Z","merged_at":"2015-01-05T18:38:56Z","merge_commit_sha":"2a4525633dd671375d37f359ed895c5f4842c905","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3526/commits","review_comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3526/comments","review_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments/{number}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3526/comments","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/6370ffda1040845e102efec07ad95bf11773eb82","head":{"label":"openframeworks:fix-DSA","ref":"fix-DSA","sha":"6370ffda1040845e102efec07ad95bf11773eb82","user":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments/{number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2015-01-05T18:37:33Z","pushed_at":"2015-01-05T18:38:56Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1343576,"stargazers_count":3250,"watchers_count":3250,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1138,"mirror_url":null,"open_issues_count":552,"forks":1138,"open_issues":552,"watchers":3250,"default_branch":"master"}},"base":{"label":"openframeworks:master","ref":"master","sha":"2f90e5c9fb41c7ff711af5ea0e3b3ac64fca51b0","user":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"repo":{"id":345337,"name":"openFrameworks","full_name":"openframeworks/openFrameworks","owner":{"login":"openframeworks","id":142866,"avatar_url":"https://avatars.githubusercontent.com/u/142866?v=3","gravatar_id":"","url":"https://api.github.com/users/openframeworks","html_url":"https://github.com/openframeworks","followers_url":"https://api.github.com/users/openframeworks/followers","following_url":"https://api.github.com/users/openframeworks/following{/other_user}","gists_url":"https://api.github.com/users/openframeworks/gists{/gist_id}","starred_url":"https://api.github.com/users/openframeworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openframeworks/subscriptions","organizations_url":"https://api.github.com/users/openframeworks/orgs","repos_url":"https://api.github.com/users/openframeworks/repos","events_url":"https://api.github.com/users/openframeworks/events{/privacy}","received_events_url":"https://api.github.com/users/openframeworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openframeworks/openFrameworks","description":"OpenFrameworks is a cross platform open source toolkit for creative coding in C++.","fork":false,"url":"https://api.github.com/repos/openframeworks/openFrameworks","forks_url":"https://api.github.com/repos/openframeworks/openFrameworks/forks","keys_url":"https://api.github.com/repos/openframeworks/openFrameworks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openframeworks/openFrameworks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openframeworks/openFrameworks/teams","hooks_url":"https://api.github.com/repos/openframeworks/openFrameworks/hooks","issue_events_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/events{/number}","events_url":"https://api.github.com/repos/openframeworks/openFrameworks/events","assignees_url":"https://api.github.com/repos/openframeworks/openFrameworks/assignees{/user}","branches_url":"https://api.github.com/repos/openframeworks/openFrameworks/branches{/branch}","tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/tags","blobs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/refs{/sha}","trees_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/{sha}","languages_url":"https://api.github.com/repos/openframeworks/openFrameworks/languages","stargazers_url":"https://api.github.com/repos/openframeworks/openFrameworks/stargazers","contributors_url":"https://api.github.com/repos/openframeworks/openFrameworks/contributors","subscribers_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscribers","subscription_url":"https://api.github.com/repos/openframeworks/openFrameworks/subscription","commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/commits{/sha}","git_commits_url":"https://api.github.com/repos/openframeworks/openFrameworks/git/commits{/sha}","comments_url":"https://api.github.com/repos/openframeworks/openFrameworks/comments{/number}","issue_comment_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues/comments/{number}","contents_url":"https://api.github.com/repos/openframeworks/openFrameworks/contents/{+path}","compare_url":"https://api.github.com/repos/openframeworks/openFrameworks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openframeworks/openFrameworks/merges","archive_url":"https://api.github.com/repos/openframeworks/openFrameworks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openframeworks/openFrameworks/downloads","issues_url":"https://api.github.com/repos/openframeworks/openFrameworks/issues{/number}","pulls_url":"https://api.github.com/repos/openframeworks/openFrameworks/pulls{/number}","milestones_url":"https://api.github.com/repos/openframeworks/openFrameworks/milestones{/number}","notifications_url":"https://api.github.com/repos/openframeworks/openFrameworks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openframeworks/openFrameworks/labels{/name}","releases_url":"https://api.github.com/repos/openframeworks/openFrameworks/releases{/id}","created_at":"2009-10-21T21:55:54Z","updated_at":"2015-01-05T18:37:33Z","pushed_at":"2015-01-05T18:38:56Z","git_url":"git://github.com/openframeworks/openFrameworks.git","ssh_url":"git@github.com:openframeworks/openFrameworks.git","clone_url":"https://github.com/openframeworks/openFrameworks.git","svn_url":"https://github.com/openframeworks/openFrameworks","homepage":"http://openframeworks.cc","size":1343576,"stargazers_count":3250,"watchers_count":3250,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1138,"mirror_url":null,"open_issues_count":552,"forks":1138,"open_issues":552,"watchers":3250,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3526"},"html":{"href":"https://github.com/openframeworks/openFrameworks/pull/3526"},"issue":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3526"},"comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/issues/3526/comments"},"review_comments":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3526/comments"},"review_comment":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/pulls/3526/commits"},"statuses":{"href":"https://api.github.com/repos/openframeworks/openFrameworks/statuses/6370ffda1040845e102efec07ad95bf11773eb82"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"arturoc","id":48240,"avatar_url":"https://avatars.githubusercontent.com/u/48240?v=3","gravatar_id":"","url":"https://api.github.com/users/arturoc","html_url":"https://github.com/arturoc","followers_url":"https://api.github.com/users/arturoc/followers","following_url":"https://api.github.com/users/arturoc/following{/other_user}","gists_url":"https://api.github.com/users/arturoc/gists{/gist_id}","starred_url":"https://api.github.com/users/arturoc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arturoc/subscriptions","organizations_url":"https://api.github.com/users/arturoc/orgs","repos_url":"https://api.github.com/users/arturoc/repos","events_url":"https://api.github.com/users/arturoc/events{/privacy}","received_events_url":"https://api.github.com/users/arturoc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":42,"deletions":16,"changed_files":1}}