{"action":"created","issue":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/46","labels_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/46/comments","events_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/46/events","html_url":"https://github.com/JoinMarket-Org/joinmarket/issues/46","id":119792201,"number":46,"title":"Maker recoded to use MessageChannel fails at encryption","user":{"login":"AdamISZ","id":4278257,"avatar_url":"https://avatars.githubusercontent.com/u/4278257?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamISZ","html_url":"https://github.com/AdamISZ","followers_url":"https://api.github.com/users/AdamISZ/followers","following_url":"https://api.github.com/users/AdamISZ/following{/other_user}","gists_url":"https://api.github.com/users/AdamISZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamISZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamISZ/subscriptions","organizations_url":"https://api.github.com/users/AdamISZ/orgs","repos_url":"https://api.github.com/users/AdamISZ/repos","events_url":"https://api.github.com/users/AdamISZ/events{/privacy}","received_events_url":"https://api.github.com/users/AdamISZ/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/labels/help%20wanted","name":"help wanted","color":"159818"},{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/labels/imported","name":"imported","color":"ededed"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-12-01T19:43:51Z","updated_at":"2015-12-01T19:44:00Z","closed_at":null,"body":"<a href=\"https://github.com/chris-belcher\"><img src=\"https://avatars.githubusercontent.com/u/8398185?v=3\" align=\"left\" width=\"96\" height=\"96\" hspace=\"10\"></img></a> **Issue by [chris-belcher](https://github.com/chris-belcher)**\n_Sunday Feb 15, 2015 at 18:19 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT_\n_Originally opened as https://github.com/chris-belcher/joinmarket/issues/46_\n\n----\n\nIn commit https://github.com/chris-belcher/joinmarket/commit/46c85479ce4034d12289e3df4a8441ffe837fce6\r\n\r\nI've recoded the classes to use the MessageChannel base class. All I did was move the IRC specific code into irc.py and replace it with functions and callbacks in the Maker and Taker classes.\r\nIt was successful with Taker and OrderbookWatch, but for Maker and yield generator it appears to get the encryption wrong. The taker on the other side fails to decrypt the !ioauth command and crashes. Before that, the !auth command is correctly received by the maker and decrypted.\r\n\r\nI have tested the old and new (which uses MessageChannel) takers on the old kind of makers and it works.\r\nI've tried a few things but no longer know what to do to try to debug this.\n"},"comment":{"url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/comments/161074625","html_url":"https://github.com/JoinMarket-Org/joinmarket/issues/46#issuecomment-161074625","issue_url":"https://api.github.com/repos/JoinMarket-Org/joinmarket/issues/46","id":161074625,"user":{"login":"AdamISZ","id":4278257,"avatar_url":"https://avatars.githubusercontent.com/u/4278257?v=3","gravatar_id":"","url":"https://api.github.com/users/AdamISZ","html_url":"https://github.com/AdamISZ","followers_url":"https://api.github.com/users/AdamISZ/followers","following_url":"https://api.github.com/users/AdamISZ/following{/other_user}","gists_url":"https://api.github.com/users/AdamISZ/gists{/gist_id}","starred_url":"https://api.github.com/users/AdamISZ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AdamISZ/subscriptions","organizations_url":"https://api.github.com/users/AdamISZ/orgs","repos_url":"https://api.github.com/users/AdamISZ/repos","events_url":"https://api.github.com/users/AdamISZ/events{/privacy}","received_events_url":"https://api.github.com/users/AdamISZ/received_events","type":"User","site_admin":false},"created_at":"2015-12-01T19:44:00Z","updated_at":"2015-12-01T19:44:00Z","body":"<a href=\"https://github.com/AdamISZ\"><img src=\"https://avatars.githubusercontent.com/u/4278257?v=3\" align=\"left\" width=\"48\" height=\"48\" hspace=\"10\"></img></a> **Comment by [AdamISZ](https://github.com/AdamISZ)**\n_Monday Feb 16, 2015 at 12:21 GMT # Sample: Friday Sep 13, 2013 at 22:58 GMT_\n\n----\n\n>I just tried an example, it went through except it seems push_tx didn't complete (got complete raw tx but didn't see on network; will look into it).\r\n\r\nForget that, the push command had been commented out. The complete transaction went through fine.\n"}}