{"action":"created","issue":{"url":"https://api.github.com/repos/BobKnothe/autoNumeric/issues/135","labels_url":"https://api.github.com/repos/BobKnothe/autoNumeric/issues/135/labels{/name}","comments_url":"https://api.github.com/repos/BobKnothe/autoNumeric/issues/135/comments","events_url":"https://api.github.com/repos/BobKnothe/autoNumeric/issues/135/events","html_url":"https://github.com/BobKnothe/autoNumeric/issues/135","id":72313632,"number":135,"title":"altDec when comma is not the separator","user":{"login":"jVmw","id":1265907,"avatar_url":"https://avatars.githubusercontent.com/u/1265907?v=3","gravatar_id":"","url":"https://api.github.com/users/jVmw","html_url":"https://github.com/jVmw","followers_url":"https://api.github.com/users/jVmw/followers","following_url":"https://api.github.com/users/jVmw/following{/other_user}","gists_url":"https://api.github.com/users/jVmw/gists{/gist_id}","starred_url":"https://api.github.com/users/jVmw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jVmw/subscriptions","organizations_url":"https://api.github.com/users/jVmw/orgs","repos_url":"https://api.github.com/users/jVmw/repos","events_url":"https://api.github.com/users/jVmw/events{/privacy}","received_events_url":"https://api.github.com/users/jVmw/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-04-30T23:53:50Z","updated_at":"2015-05-01T17:12:55Z","closed_at":null,"body":"I'm not sure what the intent is with the altDec code below:\r\n/** set alternative decimal separator key */\r\n        if (settings.altDec === null && settings.mDec > 0) {\r\n            if (settings.aDec === '.' && settings.aSep !== ',') {\r\n                settings.altDec = ',';\r\n            } else if (settings.aDec === ',' && settings.aSep !== '.') {\r\n                settings.altDec = '.';\r\n            }\r\n        }\r\n\r\nWhen the aDec is '.' and the aSep is not ',', the second if condition sets ',' as the altDec. Some of our amount fields don't need the comma or any separator. When we set aSep:'', the comma is entering '.' when pushed. Of course our testers are complaining.\r\n\r\nIs the assignment altDec = ',' needed?'"},"comment":{"url":"https://api.github.com/repos/BobKnothe/autoNumeric/issues/comments/98179867","html_url":"https://github.com/BobKnothe/autoNumeric/issues/135#issuecomment-98179867","issue_url":"https://api.github.com/repos/BobKnothe/autoNumeric/issues/135","id":98179867,"user":{"login":"BobKnothe","id":467351,"avatar_url":"https://avatars.githubusercontent.com/u/467351?v=3","gravatar_id":"","url":"https://api.github.com/users/BobKnothe","html_url":"https://github.com/BobKnothe","followers_url":"https://api.github.com/users/BobKnothe/followers","following_url":"https://api.github.com/users/BobKnothe/following{/other_user}","gists_url":"https://api.github.com/users/BobKnothe/gists{/gist_id}","starred_url":"https://api.github.com/users/BobKnothe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BobKnothe/subscriptions","organizations_url":"https://api.github.com/users/BobKnothe/orgs","repos_url":"https://api.github.com/users/BobKnothe/repos","events_url":"https://api.github.com/users/BobKnothe/events{/privacy}","received_events_url":"https://api.github.com/users/BobKnothe/received_events","type":"User","site_admin":false},"created_at":"2015-05-01T17:12:55Z","updated_at":"2015-05-01T17:12:55Z","body":"Josh,\n \nI did a quick check and you should be able to change altDec: ''.\n \nChange and let me know if you run into any issues and I can dig deeper.\n \nThanks for using AN.\n \nBob \n \n--------- Original Message --------- Subject: [autoNumeric] altDec when comma is not the separator (#135)\nFrom: \"Josh\" <notifications@github.com>\nDate: 4/30/15 4:53 pm\nTo: \"BobKnothe/autoNumeric\" <autoNumeric@noreply.github.com>\n\n I'm not sure what the intent is with the altDec code below:\n /** set alternative decimal separator key */\n if (settings.altDec === null && settings.mDec > 0) {\n if (settings.aDec === '.' && settings.aSep !== ',') {\n settings.altDec = ',';\n } else if (settings.aDec === ',' && settings.aSep !== '.') {\n settings.altDec = '.';\n }\n }\n When the aDec is '.' and the aSep is not ',', the second if condition sets ',' as the altDec. Some of our amount fields don't need the comma or any separator. When we set aSep:'', the comma is entering '.' when pushed. Of course our testers are complaining.\n Is the assignment altDec = ',' needed?'\n -\nReply to this email directly or view it on GitHub.\n"}}