{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/581","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/581/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/581/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/581/events","html_url":"https://github.com/callemall/material-ui/pull/581","id":70911603,"number":581,"title":"Use either one of click / tap handlers in menus","user":{"login":"pomerantsev","id":3888965,"avatar_url":"https://avatars.githubusercontent.com/u/3888965?v=3","gravatar_id":"","url":"https://api.github.com/users/pomerantsev","html_url":"https://github.com/pomerantsev","followers_url":"https://api.github.com/users/pomerantsev/followers","following_url":"https://api.github.com/users/pomerantsev/following{/other_user}","gists_url":"https://api.github.com/users/pomerantsev/gists{/gist_id}","starred_url":"https://api.github.com/users/pomerantsev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pomerantsev/subscriptions","organizations_url":"https://api.github.com/users/pomerantsev/orgs","repos_url":"https://api.github.com/users/pomerantsev/repos","events_url":"https://api.github.com/users/pomerantsev/events{/privacy}","received_events_url":"https://api.github.com/users/pomerantsev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":8,"created_at":"2015-04-25T13:40:13Z","updated_at":"2015-06-03T23:22:15Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/581","html_url":"https://github.com/callemall/material-ui/pull/581","diff_url":"https://github.com/callemall/material-ui/pull/581.diff","patch_url":"https://github.com/callemall/material-ui/pull/581.patch"},"body":"Fixes #366.\r\n\r\nThis PR fixes a real issue, but even if @hai-cea and @mmrtnz don't like the implementation, I'd like to discuss whether it's a good idea to consistently use either onClick or onTouchTap in the API.\r\nI'm not sure if it makes any sense to use both onClick and onTouchTap on the same element. onClick does the same thing as onTouchTap, only 300ms later on some devices.\r\nSo my proposal is to only use onTouchTap on native elements (since the project depends on react-tap-event-plugin anyway), and to use the Click idiom for all material-ui components, just because everyone's used to it.\r\nAlthough using onClick directly on a component which internally transforms it into an onTouchTap is a bit confusing, so instead, I would prefer to have a property called onItemClick or something (see PR).\r\n\r\nIf you're happy with this approach, you could merge it, and I could proceed with the rest of the codebase."},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/108644309","html_url":"https://github.com/callemall/material-ui/pull/581#issuecomment-108644309","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/581","id":108644309,"user":{"login":"hai-cea","id":2007468,"avatar_url":"https://avatars.githubusercontent.com/u/2007468?v=3","gravatar_id":"","url":"https://api.github.com/users/hai-cea","html_url":"https://github.com/hai-cea","followers_url":"https://api.github.com/users/hai-cea/followers","following_url":"https://api.github.com/users/hai-cea/following{/other_user}","gists_url":"https://api.github.com/users/hai-cea/gists{/gist_id}","starred_url":"https://api.github.com/users/hai-cea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hai-cea/subscriptions","organizations_url":"https://api.github.com/users/hai-cea/orgs","repos_url":"https://api.github.com/users/hai-cea/repos","events_url":"https://api.github.com/users/hai-cea/events{/privacy}","received_events_url":"https://api.github.com/users/hai-cea/received_events","type":"User","site_admin":false},"created_at":"2015-06-03T23:22:15Z","updated_at":"2015-06-03T23:22:15Z","body":"Thanks @pomerantsev - It was my fault for taking so long to get my thoughts together on this.\r\n\r\nI think some more research will definitely be helpful. The examples you have given so far are definitely short comings of the current components and I think we can address them on a case by case basis?\r\n\r\nAlso, is your preference for the 2nd approach because of simplicity for developers?\r\n\r\n"}}