{"action":"created","comment":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments/47880302","id":47880302,"diff_hunk":"@@ -397,6 +397,10 @@ TYPO3:\n             authenticationProviderName: '${entity.authenticationProviderName}'\n             name: '${entity.party.name.fullName}'\n \n+    login:\n+      styles:\n+        'resource://TYPO3.Neos/Public/Styles/Login.css': TRUE","path":"TYPO3.Neos/Configuration/Settings.yaml","position":6,"original_position":6,"commit_id":"3376c062465cffd4bf0272e7a4b20f03c7f0df1d","original_commit_id":"1aad6afa7c0dfc7cbdf054d0271b55a1a54b3682","user":{"login":"bwaidelich","id":307571,"avatar_url":"https://avatars.githubusercontent.com/u/307571?v=3","gravatar_id":"","url":"https://api.github.com/users/bwaidelich","html_url":"https://github.com/bwaidelich","followers_url":"https://api.github.com/users/bwaidelich/followers","following_url":"https://api.github.com/users/bwaidelich/following{/other_user}","gists_url":"https://api.github.com/users/bwaidelich/gists{/gist_id}","starred_url":"https://api.github.com/users/bwaidelich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwaidelich/subscriptions","organizations_url":"https://api.github.com/users/bwaidelich/orgs","repos_url":"https://api.github.com/users/bwaidelich/repos","events_url":"https://api.github.com/users/bwaidelich/events{/privacy}","received_events_url":"https://api.github.com/users/bwaidelich/received_events","type":"User","site_admin":false},"body":"This creates a coupling to the file path/name. It's probably not really an issue in practice, but if the path changes for some reason, a different setting that overwrites it would be appended instead of replaced.\r\nAgain, more a theoretical problem, but something like this could work as well:\r\n```\r\n'TYPO3.Neos:DefaultStyles': 'resource://TYPO3.Neos/Public/Styles/Login.css'\r\n```","created_at":"2015-12-17T08:34:39Z","updated_at":"2015-12-17T08:34:39Z","html_url":"https://github.com/neos/neos-development-collection/pull/284#discussion_r47880302","pull_request_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/284","_links":{"self":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments/47880302"},"html":{"href":"https://github.com/neos/neos-development-collection/pull/284#discussion_r47880302"},"pull_request":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/284"}}},"pull_request":{"url":"https://api.github.com/repos/neos/neos-development-collection/pulls/284","id":53946598,"html_url":"https://github.com/neos/neos-development-collection/pull/284","diff_url":"https://github.com/neos/neos-development-collection/pull/284.diff","patch_url":"https://github.com/neos/neos-development-collection/pull/284.patch","issue_url":"https://api.github.com/repos/neos/neos-development-collection/issues/284","number":284,"state":"open","locked":false,"title":"FEATURE: Add settings to customize login screen stylesheets","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-12-17T08:23:33Z","updated_at":"2015-12-17T08:34:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53fa6614cbfd4161b632ef1cf2702216b99ff832","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/284/commits","review_comments_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/284/comments","review_comment_url":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/issues/284/comments","statuses_url":"https://api.github.com/repos/neos/neos-development-collection/statuses/3376c062465cffd4bf0272e7a4b20f03c7f0df1d","head":{"label":"dfeyer:feature-custom-login-screen","ref":"feature-custom-login-screen","sha":"3376c062465cffd4bf0272e7a4b20f03c7f0df1d","user":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"repo":{"id":41052872,"name":"neos-development-collection","full_name":"dfeyer/neos-development-collection","owner":{"login":"dfeyer","id":221173,"avatar_url":"https://avatars.githubusercontent.com/u/221173?v=3","gravatar_id":"","url":"https://api.github.com/users/dfeyer","html_url":"https://github.com/dfeyer","followers_url":"https://api.github.com/users/dfeyer/followers","following_url":"https://api.github.com/users/dfeyer/following{/other_user}","gists_url":"https://api.github.com/users/dfeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dfeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfeyer/subscriptions","organizations_url":"https://api.github.com/users/dfeyer/orgs","repos_url":"https://api.github.com/users/dfeyer/repos","events_url":"https://api.github.com/users/dfeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dfeyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfeyer/neos-development-collection","description":"The unified repository containing the Neos core packages, used for Neos development.","fork":true,"url":"https://api.github.com/repos/dfeyer/neos-development-collection","forks_url":"https://api.github.com/repos/dfeyer/neos-development-collection/forks","keys_url":"https://api.github.com/repos/dfeyer/neos-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfeyer/neos-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfeyer/neos-development-collection/teams","hooks_url":"https://api.github.com/repos/dfeyer/neos-development-collection/hooks","issue_events_url":"https://api.github.com/repos/dfeyer/neos-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/dfeyer/neos-development-collection/events","assignees_url":"https://api.github.com/repos/dfeyer/neos-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/dfeyer/neos-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/dfeyer/neos-development-collection/tags","blobs_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfeyer/neos-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/dfeyer/neos-development-collection/languages","stargazers_url":"https://api.github.com/repos/dfeyer/neos-development-collection/stargazers","contributors_url":"https://api.github.com/repos/dfeyer/neos-development-collection/contributors","subscribers_url":"https://api.github.com/repos/dfeyer/neos-development-collection/subscribers","subscription_url":"https://api.github.com/repos/dfeyer/neos-development-collection/subscription","commits_url":"https://api.github.com/repos/dfeyer/neos-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfeyer/neos-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfeyer/neos-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfeyer/neos-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfeyer/neos-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/dfeyer/neos-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfeyer/neos-development-collection/merges","archive_url":"https://api.github.com/repos/dfeyer/neos-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfeyer/neos-development-collection/downloads","issues_url":"https://api.github.com/repos/dfeyer/neos-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/dfeyer/neos-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/dfeyer/neos-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/dfeyer/neos-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfeyer/neos-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/dfeyer/neos-development-collection/releases{/id}","created_at":"2015-08-19T18:37:11Z","updated_at":"2015-08-19T18:37:17Z","pushed_at":"2015-12-17T08:34:07Z","git_url":"git://github.com/dfeyer/neos-development-collection.git","ssh_url":"git@github.com:dfeyer/neos-development-collection.git","clone_url":"https://github.com/dfeyer/neos-development-collection.git","svn_url":"https://github.com/dfeyer/neos-development-collection","homepage":null,"size":49353,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"neos:2.1","ref":"2.1","sha":"186d528d01aa950e605aef4247df94f0af75a302","user":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"repo":{"id":40964014,"name":"neos-development-collection","full_name":"neos/neos-development-collection","owner":{"login":"neos","id":11575267,"avatar_url":"https://avatars.githubusercontent.com/u/11575267?v=3","gravatar_id":"","url":"https://api.github.com/users/neos","html_url":"https://github.com/neos","followers_url":"https://api.github.com/users/neos/followers","following_url":"https://api.github.com/users/neos/following{/other_user}","gists_url":"https://api.github.com/users/neos/gists{/gist_id}","starred_url":"https://api.github.com/users/neos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neos/subscriptions","organizations_url":"https://api.github.com/users/neos/orgs","repos_url":"https://api.github.com/users/neos/repos","events_url":"https://api.github.com/users/neos/events{/privacy}","received_events_url":"https://api.github.com/users/neos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neos/neos-development-collection","description":"The unified repository containing the Neos core packages, used for Neos development.","fork":false,"url":"https://api.github.com/repos/neos/neos-development-collection","forks_url":"https://api.github.com/repos/neos/neos-development-collection/forks","keys_url":"https://api.github.com/repos/neos/neos-development-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neos/neos-development-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neos/neos-development-collection/teams","hooks_url":"https://api.github.com/repos/neos/neos-development-collection/hooks","issue_events_url":"https://api.github.com/repos/neos/neos-development-collection/issues/events{/number}","events_url":"https://api.github.com/repos/neos/neos-development-collection/events","assignees_url":"https://api.github.com/repos/neos/neos-development-collection/assignees{/user}","branches_url":"https://api.github.com/repos/neos/neos-development-collection/branches{/branch}","tags_url":"https://api.github.com/repos/neos/neos-development-collection/tags","blobs_url":"https://api.github.com/repos/neos/neos-development-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neos/neos-development-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neos/neos-development-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/neos/neos-development-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neos/neos-development-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/neos/neos-development-collection/languages","stargazers_url":"https://api.github.com/repos/neos/neos-development-collection/stargazers","contributors_url":"https://api.github.com/repos/neos/neos-development-collection/contributors","subscribers_url":"https://api.github.com/repos/neos/neos-development-collection/subscribers","subscription_url":"https://api.github.com/repos/neos/neos-development-collection/subscription","commits_url":"https://api.github.com/repos/neos/neos-development-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/neos/neos-development-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/neos/neos-development-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/neos/neos-development-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/neos/neos-development-collection/contents/{+path}","compare_url":"https://api.github.com/repos/neos/neos-development-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neos/neos-development-collection/merges","archive_url":"https://api.github.com/repos/neos/neos-development-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neos/neos-development-collection/downloads","issues_url":"https://api.github.com/repos/neos/neos-development-collection/issues{/number}","pulls_url":"https://api.github.com/repos/neos/neos-development-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/neos/neos-development-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/neos/neos-development-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neos/neos-development-collection/labels{/name}","releases_url":"https://api.github.com/repos/neos/neos-development-collection/releases{/id}","created_at":"2015-08-18T09:48:35Z","updated_at":"2015-12-03T22:05:00Z","pushed_at":"2015-12-17T08:34:07Z","git_url":"git://github.com/neos/neos-development-collection.git","ssh_url":"git@github.com:neos/neos-development-collection.git","clone_url":"https://github.com/neos/neos-development-collection.git","svn_url":"https://github.com/neos/neos-development-collection","homepage":"https://www.neos.io/","size":54490,"stargazers_count":58,"watchers_count":58,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":41,"mirror_url":null,"open_issues_count":32,"forks":41,"open_issues":32,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/284"},"html":{"href":"https://github.com/neos/neos-development-collection/pull/284"},"issue":{"href":"https://api.github.com/repos/neos/neos-development-collection/issues/284"},"comments":{"href":"https://api.github.com/repos/neos/neos-development-collection/issues/284/comments"},"review_comments":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/284/comments"},"review_comment":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neos/neos-development-collection/pulls/284/commits"},"statuses":{"href":"https://api.github.com/repos/neos/neos-development-collection/statuses/3376c062465cffd4bf0272e7a4b20f03c7f0df1d"}}}}