{"action":"created","issue":{"url":"https://api.github.com/repos/google/shaka-player/issues/226","labels_url":"https://api.github.com/repos/google/shaka-player/issues/226/labels{/name}","comments_url":"https://api.github.com/repos/google/shaka-player/issues/226/comments","events_url":"https://api.github.com/repos/google/shaka-player/issues/226/events","html_url":"https://github.com/google/shaka-player/pull/226","id":115199236,"number":226,"title":"drm_info isCompatible \"properly\" compares callbacks","user":{"login":"baconz","id":1123782,"avatar_url":"https://avatars.githubusercontent.com/u/1123782?v=3","gravatar_id":"","url":"https://api.github.com/users/baconz","html_url":"https://github.com/baconz","followers_url":"https://api.github.com/users/baconz/followers","following_url":"https://api.github.com/users/baconz/following{/other_user}","gists_url":"https://api.github.com/users/baconz/gists{/gist_id}","starred_url":"https://api.github.com/users/baconz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/baconz/subscriptions","organizations_url":"https://api.github.com/users/baconz/orgs","repos_url":"https://api.github.com/users/baconz/repos","events_url":"https://api.github.com/users/baconz/events{/privacy}","received_events_url":"https://api.github.com/users/baconz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"milestone":null,"comments":1,"created_at":"2015-11-05T03:00:50Z","updated_at":"2015-11-05T18:30:42Z","closed_at":"2015-11-05T18:30:42Z","pull_request":{"url":"https://api.github.com/repos/google/shaka-player/pulls/226","html_url":"https://github.com/google/shaka-player/pull/226","diff_url":"https://github.com/google/shaka-player/pull/226.diff","patch_url":"https://github.com/google/shaka-player/pull/226.patch"},"body":"Without this fix there can only be one valid representation for each adaptation set if there is DRM with a pre/post license fetch callback.\r\n\r\nYuck.\r\n\r\nIn plain english: multiple bitrates don't work if you use DRM + callbacks. `createStreamSetInfo` will kick out all but the first representation.\r\n\r\nNot sure if you guys want to explore a more robust way to compare those callbacks. Obviously this will blow up if somebody passed different closures to identical drm configs."},"comment":{"url":"https://api.github.com/repos/google/shaka-player/issues/comments/154146026","html_url":"https://github.com/google/shaka-player/pull/226#issuecomment-154146026","issue_url":"https://api.github.com/repos/google/shaka-player/issues/226","id":154146026,"user":{"login":"joeyparrish","id":6843156,"avatar_url":"https://avatars.githubusercontent.com/u/6843156?v=3","gravatar_id":"","url":"https://api.github.com/users/joeyparrish","html_url":"https://github.com/joeyparrish","followers_url":"https://api.github.com/users/joeyparrish/followers","following_url":"https://api.github.com/users/joeyparrish/following{/other_user}","gists_url":"https://api.github.com/users/joeyparrish/gists{/gist_id}","starred_url":"https://api.github.com/users/joeyparrish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joeyparrish/subscriptions","organizations_url":"https://api.github.com/users/joeyparrish/orgs","repos_url":"https://api.github.com/users/joeyparrish/repos","events_url":"https://api.github.com/users/joeyparrish/events{/privacy}","received_events_url":"https://api.github.com/users/joeyparrish/received_events","type":"User","site_admin":false},"created_at":"2015-11-05T18:30:42Z","updated_at":"2015-11-05T18:30:42Z","body":"Hi @baconz,\r\n\r\nThanks for the PR.  We actually ran into this same issue ourselves, in which two DrmInfos had two different bound versions of the same callback.  We had a change in review internally that fixed this in a different way, and it was just approved and released.  Please see 6263e1f and #227."}}