{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/36054669","id":36054669,"diff_hunk":"@@ -385,6 +385,10 @@ def run_sparkr_tests():\n \n     if which(\"R\"):\n         run_cmd([os.path.join(SPARK_HOME, \"R\", \"install-dev.sh\")])\n+        # R style check should be executed after `install-dev.sh`.\n+        # Since warnings about `no visible global function definition` appear\n+        # without the installation. SEE ALSO: SPARK-9121.\n+        run_cmd([os.path.join(SPARK_HOME, \"dev\", \"lint-r\")])","path":"dev/run-tests.py","position":7,"original_position":7,"commit_id":"d654fc836f3a81133354ea470b4cb5feb49ff07b","original_commit_id":"d654fc836f3a81133354ea470b4cb5feb49ff07b","user":{"login":"JoshRosen","id":50748,"avatar_url":"https://avatars.githubusercontent.com/u/50748?v=3","gravatar_id":"","url":"https://api.github.com/users/JoshRosen","html_url":"https://github.com/JoshRosen","followers_url":"https://api.github.com/users/JoshRosen/followers","following_url":"https://api.github.com/users/JoshRosen/following{/other_user}","gists_url":"https://api.github.com/users/JoshRosen/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshRosen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshRosen/subscriptions","organizations_url":"https://api.github.com/users/JoshRosen/orgs","repos_url":"https://api.github.com/users/JoshRosen/repos","events_url":"https://api.github.com/users/JoshRosen/events{/privacy}","received_events_url":"https://api.github.com/users/JoshRosen/received_events","type":"User","site_admin":false},"body":"If we place the lint check in `run_sparkr_tests` then this may result in us running those lint checks after running other tests, which will make it take longer to discover R style failures in scenarios where non-R tests had to be run.  As a result, I wonder if we should place this linting check near line 488, by the existing `run_python_style_checks()` call.","created_at":"2015-08-03T03:58:08Z","updated_at":"2015-08-03T03:58:08Z","html_url":"https://github.com/apache/spark/pull/7883#discussion_r36054669","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/7883","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/36054669"},"html":{"href":"https://github.com/apache/spark/pull/7883#discussion_r36054669"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/7883"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/7883","id":41432398,"html_url":"https://github.com/apache/spark/pull/7883","diff_url":"https://github.com/apache/spark/pull/7883.diff","patch_url":"https://github.com/apache/spark/pull/7883.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/7883","number":7883,"state":"open","locked":false,"title":"[SPARK-8505][SparkR] Add settings to kick `lint-r` from `./dev/run-test.py`","user":{"login":"yu-iskw","id":1523515,"avatar_url":"https://avatars.githubusercontent.com/u/1523515?v=3","gravatar_id":"","url":"https://api.github.com/users/yu-iskw","html_url":"https://github.com/yu-iskw","followers_url":"https://api.github.com/users/yu-iskw/followers","following_url":"https://api.github.com/users/yu-iskw/following{/other_user}","gists_url":"https://api.github.com/users/yu-iskw/gists{/gist_id}","starred_url":"https://api.github.com/users/yu-iskw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yu-iskw/subscriptions","organizations_url":"https://api.github.com/users/yu-iskw/orgs","repos_url":"https://api.github.com/users/yu-iskw/repos","events_url":"https://api.github.com/users/yu-iskw/events{/privacy}","received_events_url":"https://api.github.com/users/yu-iskw/received_events","type":"User","site_admin":false},"body":"@JoshRosen we'd like to check the SparkR source code with the `dev/lint-r` script on the Jenkins. I tried to incorporate the script into `dev/run-test.py`. Could you review it when you have time?\r\n\r\n@shivaram I modified `dev/lint-r` and `dev/lint-r.R` to install lintr package into a local directory(`R/lib/`) and to exit with a lint status. Could you review it?\r\n\r\n- [[SPARK-8505] Add settings to kick `lint-r` from `./dev/run-test.py` - ASF JIRA](https://issues.apache.org/jira/browse/SPARK-8505)","created_at":"2015-08-03T03:24:03Z","updated_at":"2015-08-03T03:58:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"483f0cc45024da66e960234616a6072a6d094a65","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/7883/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/7883/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/7883/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/d654fc836f3a81133354ea470b4cb5feb49ff07b","head":{"label":"yu-iskw:SPARK-8505","ref":"SPARK-8505","sha":"d654fc836f3a81133354ea470b4cb5feb49ff07b","user":{"login":"yu-iskw","id":1523515,"avatar_url":"https://avatars.githubusercontent.com/u/1523515?v=3","gravatar_id":"","url":"https://api.github.com/users/yu-iskw","html_url":"https://github.com/yu-iskw","followers_url":"https://api.github.com/users/yu-iskw/followers","following_url":"https://api.github.com/users/yu-iskw/following{/other_user}","gists_url":"https://api.github.com/users/yu-iskw/gists{/gist_id}","starred_url":"https://api.github.com/users/yu-iskw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yu-iskw/subscriptions","organizations_url":"https://api.github.com/users/yu-iskw/orgs","repos_url":"https://api.github.com/users/yu-iskw/repos","events_url":"https://api.github.com/users/yu-iskw/events{/privacy}","received_events_url":"https://api.github.com/users/yu-iskw/received_events","type":"User","site_admin":false},"repo":{"id":20396045,"name":"spark","full_name":"yu-iskw/spark","owner":{"login":"yu-iskw","id":1523515,"avatar_url":"https://avatars.githubusercontent.com/u/1523515?v=3","gravatar_id":"","url":"https://api.github.com/users/yu-iskw","html_url":"https://github.com/yu-iskw","followers_url":"https://api.github.com/users/yu-iskw/followers","following_url":"https://api.github.com/users/yu-iskw/following{/other_user}","gists_url":"https://api.github.com/users/yu-iskw/gists{/gist_id}","starred_url":"https://api.github.com/users/yu-iskw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yu-iskw/subscriptions","organizations_url":"https://api.github.com/users/yu-iskw/orgs","repos_url":"https://api.github.com/users/yu-iskw/repos","events_url":"https://api.github.com/users/yu-iskw/events{/privacy}","received_events_url":"https://api.github.com/users/yu-iskw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yu-iskw/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/yu-iskw/spark","forks_url":"https://api.github.com/repos/yu-iskw/spark/forks","keys_url":"https://api.github.com/repos/yu-iskw/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yu-iskw/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yu-iskw/spark/teams","hooks_url":"https://api.github.com/repos/yu-iskw/spark/hooks","issue_events_url":"https://api.github.com/repos/yu-iskw/spark/issues/events{/number}","events_url":"https://api.github.com/repos/yu-iskw/spark/events","assignees_url":"https://api.github.com/repos/yu-iskw/spark/assignees{/user}","branches_url":"https://api.github.com/repos/yu-iskw/spark/branches{/branch}","tags_url":"https://api.github.com/repos/yu-iskw/spark/tags","blobs_url":"https://api.github.com/repos/yu-iskw/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yu-iskw/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yu-iskw/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/yu-iskw/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yu-iskw/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/yu-iskw/spark/languages","stargazers_url":"https://api.github.com/repos/yu-iskw/spark/stargazers","contributors_url":"https://api.github.com/repos/yu-iskw/spark/contributors","subscribers_url":"https://api.github.com/repos/yu-iskw/spark/subscribers","subscription_url":"https://api.github.com/repos/yu-iskw/spark/subscription","commits_url":"https://api.github.com/repos/yu-iskw/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/yu-iskw/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/yu-iskw/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/yu-iskw/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/yu-iskw/spark/contents/{+path}","compare_url":"https://api.github.com/repos/yu-iskw/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yu-iskw/spark/merges","archive_url":"https://api.github.com/repos/yu-iskw/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yu-iskw/spark/downloads","issues_url":"https://api.github.com/repos/yu-iskw/spark/issues{/number}","pulls_url":"https://api.github.com/repos/yu-iskw/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/yu-iskw/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/yu-iskw/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yu-iskw/spark/labels{/name}","releases_url":"https://api.github.com/repos/yu-iskw/spark/releases{/id}","created_at":"2014-06-02T07:24:57Z","updated_at":"2014-07-25T08:42:00Z","pushed_at":"2015-08-03T03:16:27Z","git_url":"git://github.com/yu-iskw/spark.git","ssh_url":"git@github.com:yu-iskw/spark.git","clone_url":"https://github.com/yu-iskw/spark.git","svn_url":"https://github.com/yu-iskw/spark","homepage":null,"size":111112,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"30e89111d673776a6b59b11cdb29ab8713ba6f7c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","created_at":"2014-02-25T08:00:08Z","updated_at":"2015-08-03T02:55:23Z","pushed_at":"2015-08-03T03:49:44Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":1642747,"stargazers_count":4944,"watchers_count":4944,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4483,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":327,"forks":4483,"open_issues":327,"watchers":4944,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/7883"},"html":{"href":"https://github.com/apache/spark/pull/7883"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/7883"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/7883/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/7883/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/7883/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/d654fc836f3a81133354ea470b4cb5feb49ff07b"}}}}