{"action":"created","issue":{"url":"https://api.github.com/repos/intel-iot-devkit/mraa/issues/86","labels_url":"https://api.github.com/repos/intel-iot-devkit/mraa/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/intel-iot-devkit/mraa/issues/86/comments","events_url":"https://api.github.com/repos/intel-iot-devkit/mraa/issues/86/events","html_url":"https://github.com/intel-iot-devkit/mraa/issues/86","id":53457410,"number":86,"title":"break missing in mraa.c - mraa_pin_mode_test","user":{"login":"michael-ring","id":6280531,"avatar_url":"https://avatars.githubusercontent.com/u/6280531?v=3","gravatar_id":"","url":"https://api.github.com/users/michael-ring","html_url":"https://github.com/michael-ring","followers_url":"https://api.github.com/users/michael-ring/followers","following_url":"https://api.github.com/users/michael-ring/following{/other_user}","gists_url":"https://api.github.com/users/michael-ring/gists{/gist_id}","starred_url":"https://api.github.com/users/michael-ring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michael-ring/subscriptions","organizations_url":"https://api.github.com/users/michael-ring/orgs","repos_url":"https://api.github.com/users/michael-ring/repos","events_url":"https://api.github.com/users/michael-ring/events{/privacy}","received_events_url":"https://api.github.com/users/michael-ring/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/intel-iot-devkit/mraa/labels/bug","name":"bug","color":"fc2929"}],"state":"closed","locked":false,"assignee":{"login":"arfoll","id":514406,"avatar_url":"https://avatars.githubusercontent.com/u/514406?v=3","gravatar_id":"","url":"https://api.github.com/users/arfoll","html_url":"https://github.com/arfoll","followers_url":"https://api.github.com/users/arfoll/followers","following_url":"https://api.github.com/users/arfoll/following{/other_user}","gists_url":"https://api.github.com/users/arfoll/gists{/gist_id}","starred_url":"https://api.github.com/users/arfoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfoll/subscriptions","organizations_url":"https://api.github.com/users/arfoll/orgs","repos_url":"https://api.github.com/users/arfoll/repos","events_url":"https://api.github.com/users/arfoll/events{/privacy}","received_events_url":"https://api.github.com/users/arfoll/received_events","type":"User","site_admin":false},"milestone":{"url":"https://api.github.com/repos/intel-iot-devkit/mraa/milestones/5","labels_url":"https://api.github.com/repos/intel-iot-devkit/mraa/milestones/5/labels","id":875514,"number":5,"title":"0.6.0","description":null,"creator":{"login":"arfoll","id":514406,"avatar_url":"https://avatars.githubusercontent.com/u/514406?v=3","gravatar_id":"","url":"https://api.github.com/users/arfoll","html_url":"https://github.com/arfoll","followers_url":"https://api.github.com/users/arfoll/followers","following_url":"https://api.github.com/users/arfoll/following{/other_user}","gists_url":"https://api.github.com/users/arfoll/gists{/gist_id}","starred_url":"https://api.github.com/users/arfoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfoll/subscriptions","organizations_url":"https://api.github.com/users/arfoll/orgs","repos_url":"https://api.github.com/users/arfoll/repos","events_url":"https://api.github.com/users/arfoll/events{/privacy}","received_events_url":"https://api.github.com/users/arfoll/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":3,"state":"open","created_at":"2014-11-21T11:08:31Z","updated_at":"2015-01-05T23:06:17Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-01-05T22:39:49Z","updated_at":"2015-01-05T23:06:32Z","closed_at":"2015-01-05T23:06:17Z","body":"I found out that a break before the default case is missing in mraa_pin_mode_test.\r\n\r\nThe result of this bug is that I get a log entry in syslog even though all is OK:\r\n\r\nJan  5 23:22:36 beaglebone libmraa[2380]: requested pinmode invalid\r\n\r\nadding a break statement fixes that:\r\n\r\nring@beaglebone:~/devel/mraa/src$ git diff mraa.c\r\ndiff --git a/src/mraa.c b/src/mraa.c\r\nindex 70be118..3b4bc34 100644\r\n--- a/src/mraa.c\r\n+++ b/src/mraa.c\r\n@@ -263,6 +263,7 @@ mraa_pin_mode_test(int pin, mraa_pinmodes_t mode)\r\n         case MRAA_PIN_UART:\r\n             if (plat->pins[pin].capabilites.uart == 1)\r\n                 return 1;\r\n+            break;\r\n         default:\r\n             syslog(LOG_NOTICE, \"requested pinmode invalid\");\r\n             break;\r\n"},"comment":{"url":"https://api.github.com/repos/intel-iot-devkit/mraa/issues/comments/68798691","html_url":"https://github.com/intel-iot-devkit/mraa/issues/86#issuecomment-68798691","issue_url":"https://api.github.com/repos/intel-iot-devkit/mraa/issues/86","id":68798691,"user":{"login":"arfoll","id":514406,"avatar_url":"https://avatars.githubusercontent.com/u/514406?v=3","gravatar_id":"","url":"https://api.github.com/users/arfoll","html_url":"https://github.com/arfoll","followers_url":"https://api.github.com/users/arfoll/followers","following_url":"https://api.github.com/users/arfoll/following{/other_user}","gists_url":"https://api.github.com/users/arfoll/gists{/gist_id}","starred_url":"https://api.github.com/users/arfoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arfoll/subscriptions","organizations_url":"https://api.github.com/users/arfoll/orgs","repos_url":"https://api.github.com/users/arfoll/repos","events_url":"https://api.github.com/users/arfoll/events{/privacy}","received_events_url":"https://api.github.com/users/arfoll/received_events","type":"User","site_admin":false},"created_at":"2015-01-05T23:06:32Z","updated_at":"2015-01-05T23:06:32Z","body":"Thanks alot for reporting @michael-ring!"}}