{"action":"created","issue":{"url":"https://api.github.com/repos/uutils/coreutils/issues/570","labels_url":"https://api.github.com/repos/uutils/coreutils/issues/570/labels{/name}","comments_url":"https://api.github.com/repos/uutils/coreutils/issues/570/comments","events_url":"https://api.github.com/repos/uutils/coreutils/issues/570/events","html_url":"https://github.com/uutils/coreutils/pull/570","id":73464259,"number":570,"title":"Fix failing test for sort.","user":{"login":"jbcrail","id":6038,"avatar_url":"https://avatars.githubusercontent.com/u/6038?v=3","gravatar_id":"","url":"https://api.github.com/users/jbcrail","html_url":"https://github.com/jbcrail","followers_url":"https://api.github.com/users/jbcrail/followers","following_url":"https://api.github.com/users/jbcrail/following{/other_user}","gists_url":"https://api.github.com/users/jbcrail/gists{/gist_id}","starred_url":"https://api.github.com/users/jbcrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbcrail/subscriptions","organizations_url":"https://api.github.com/users/jbcrail/orgs","repos_url":"https://api.github.com/users/jbcrail/repos","events_url":"https://api.github.com/users/jbcrail/events{/privacy}","received_events_url":"https://api.github.com/users/jbcrail/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":2,"created_at":"2015-05-05T23:41:08Z","updated_at":"2015-05-06T16:11:34Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/uutils/coreutils/pulls/570","html_url":"https://github.com/uutils/coreutils/pull/570","diff_url":"https://github.com/uutils/coreutils/pull/570.diff","patch_url":"https://github.com/uutils/coreutils/pull/570.patch"},"body":"The sorted values were not outputted using a newline."},"comment":{"url":"https://api.github.com/repos/uutils/coreutils/issues/comments/99525698","html_url":"https://github.com/uutils/coreutils/pull/570#issuecomment-99525698","issue_url":"https://api.github.com/repos/uutils/coreutils/issues/570","id":99525698,"user":{"login":"jbcrail","id":6038,"avatar_url":"https://avatars.githubusercontent.com/u/6038?v=3","gravatar_id":"","url":"https://api.github.com/users/jbcrail","html_url":"https://github.com/jbcrail","followers_url":"https://api.github.com/users/jbcrail/followers","following_url":"https://api.github.com/users/jbcrail/following{/other_user}","gists_url":"https://api.github.com/users/jbcrail/gists{/gist_id}","starred_url":"https://api.github.com/users/jbcrail/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbcrail/subscriptions","organizations_url":"https://api.github.com/users/jbcrail/orgs","repos_url":"https://api.github.com/users/jbcrail/repos","events_url":"https://api.github.com/users/jbcrail/events{/privacy}","received_events_url":"https://api.github.com/users/jbcrail/received_events","type":"User","site_admin":false},"created_at":"2015-05-06T16:11:34Z","updated_at":"2015-05-06T16:11:34Z","body":"Due to a API change with `read_to_end()`, I had to verify the read in two parts: 1) the file opens successfully (lines 41-44), and 2) the data reads successfully (line 46). I used `unwrap_or_else()` to replace the previous `match`. This achieves the same effect, but in fewer lines.\r\n\r\nAfter looking at the code, I realize I didn't check the return value from the file read. To be completely safe, line 46 should probably be replaced with:\r\n\r\n```\r\nmatch f.read_to_end(&mut answer) {\r\n    Ok(_) => {},\r\n    Err(err) => panic!(\"{}\", err)\r\n}\r\n```\r\n\r\nDoes it seem reasonable to check line 46's return value?"}}