{"action":"created","issue":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/404","labels_url":"https://api.github.com/repos/rstudio/rstudio/issues/404/labels{/name}","comments_url":"https://api.github.com/repos/rstudio/rstudio/issues/404/comments","events_url":"https://api.github.com/repos/rstudio/rstudio/issues/404/events","html_url":"https://github.com/rstudio/rstudio/pull/404","id":72151747,"number":404,"title":"handle encoding correctly for run all chunks","user":{"login":"jjallaire","id":104391,"avatar_url":"https://avatars.githubusercontent.com/u/104391?v=3","gravatar_id":"","url":"https://api.github.com/users/jjallaire","html_url":"https://github.com/jjallaire","followers_url":"https://api.github.com/users/jjallaire/followers","following_url":"https://api.github.com/users/jjallaire/following{/other_user}","gists_url":"https://api.github.com/users/jjallaire/gists{/gist_id}","starred_url":"https://api.github.com/users/jjallaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjallaire/subscriptions","organizations_url":"https://api.github.com/users/jjallaire/orgs","repos_url":"https://api.github.com/users/jjallaire/repos","events_url":"https://api.github.com/users/jjallaire/events{/privacy}","received_events_url":"https://api.github.com/users/jjallaire/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/rstudio/rstudio/milestones/1","html_url":"https://github.com/rstudio/rstudio/milestones/v0.99","labels_url":"https://api.github.com/repos/rstudio/rstudio/milestones/1/labels","id":1089687,"number":1,"title":"v0.99","description":"","creator":{"login":"jjallaire","id":104391,"avatar_url":"https://avatars.githubusercontent.com/u/104391?v=3","gravatar_id":"","url":"https://api.github.com/users/jjallaire","html_url":"https://github.com/jjallaire","followers_url":"https://api.github.com/users/jjallaire/followers","following_url":"https://api.github.com/users/jjallaire/following{/other_user}","gists_url":"https://api.github.com/users/jjallaire/gists{/gist_id}","starred_url":"https://api.github.com/users/jjallaire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjallaire/subscriptions","organizations_url":"https://api.github.com/users/jjallaire/orgs","repos_url":"https://api.github.com/users/jjallaire/repos","events_url":"https://api.github.com/users/jjallaire/events{/privacy}","received_events_url":"https://api.github.com/users/jjallaire/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":1,"state":"open","created_at":"2015-04-29T17:40:51Z","updated_at":"2015-04-30T13:07:08Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2015-04-30T13:06:48Z","updated_at":"2015-04-30T18:30:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rstudio/rstudio/pulls/404","html_url":"https://github.com/rstudio/rstudio/pull/404","diff_url":"https://github.com/rstudio/rstudio/pull/404.diff","patch_url":"https://github.com/rstudio/rstudio/pull/404.patch"},"body":"This passes the encoding through to knitr::purl and Utils::Stangle when we do a Run All Chunks in the IDE. It's intended to address issues @yihui has seen in doing Run All Chunks with Chinese characters however as of yet I haven't been able to repro his error or confirm that this addresses the error.\r\n\r\n@jmcphers Could you review as a sanity check and lend whatever perspective you have. @yihui Could you provide a more detailed repro (including sessionInfo, etc.) so I can see whether this fixes the issue.\r\n"},"comment":{"url":"https://api.github.com/repos/rstudio/rstudio/issues/comments/97910177","html_url":"https://github.com/rstudio/rstudio/pull/404#issuecomment-97910177","issue_url":"https://api.github.com/repos/rstudio/rstudio/issues/404","id":97910177,"user":{"login":"jmcphers","id":470418,"avatar_url":"https://avatars.githubusercontent.com/u/470418?v=3","gravatar_id":"","url":"https://api.github.com/users/jmcphers","html_url":"https://github.com/jmcphers","followers_url":"https://api.github.com/users/jmcphers/followers","following_url":"https://api.github.com/users/jmcphers/following{/other_user}","gists_url":"https://api.github.com/users/jmcphers/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcphers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcphers/subscriptions","organizations_url":"https://api.github.com/users/jmcphers/orgs","repos_url":"https://api.github.com/users/jmcphers/repos","events_url":"https://api.github.com/users/jmcphers/events{/privacy}","received_events_url":"https://api.github.com/users/jmcphers/received_events","type":"User","site_admin":false},"created_at":"2015-04-30T18:30:50Z","updated_at":"2015-04-30T18:30:50Z","body":"I'm not especially familiar with Sweave, but this change looks fine to me. \r\n\r\nAt first glance it looks like we only tangle `~/.active-rstudio-document` -- is that correct? Another common gotcha is encoding on the filename itself--right now we don't mark string encodings when passing arguments to R function calls."}}