{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/104","id":47409487,"html_url":"https://github.com/alphagov/tsuru-terraform/pull/104","diff_url":"https://github.com/alphagov/tsuru-terraform/pull/104.diff","patch_url":"https://github.com/alphagov/tsuru-terraform/pull/104.patch","issue_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/104","number":104,"state":"closed","locked":false,"title":"[#103903920] New terraform syntax for GCE account file","user":{"login":"saliceti","id":8416694,"avatar_url":"https://avatars.githubusercontent.com/u/8416694?v=3","gravatar_id":"","url":"https://api.github.com/users/saliceti","html_url":"https://github.com/saliceti","followers_url":"https://api.github.com/users/saliceti/followers","following_url":"https://api.github.com/users/saliceti/following{/other_user}","gists_url":"https://api.github.com/users/saliceti/gists{/gist_id}","starred_url":"https://api.github.com/users/saliceti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saliceti/subscriptions","organizations_url":"https://api.github.com/users/saliceti/orgs","repos_url":"https://api.github.com/users/saliceti/repos","events_url":"https://api.github.com/users/saliceti/events{/privacy}","received_events_url":"https://api.github.com/users/saliceti/received_events","type":"User","site_admin":false},"body":"# What\r\n\r\nThe old syntax was deprecated in Terraform 0.6.2. The terraform upgrade was required because cloud foundry already uses the new version, where the new syntax is necessary.\r\n\r\n# How to review\r\n\r\n* Run `terraform plan` with master show the deprecation warning\r\n* Run `terraform plan` with master will not show the deprecation warning\r\n\r\n# Who can review\r\n\r\nAnyone but @Jonty or @saliceti","created_at":"2015-10-12T11:32:01Z","updated_at":"2015-10-12T12:22:22Z","closed_at":"2015-10-12T12:22:22Z","merged_at":"2015-10-12T12:22:22Z","merge_commit_sha":"11063c5d0939ebf97ff4781d928f12b541ae3f77","assignee":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/104/commits","review_comments_url":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/104/comments","review_comment_url":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/104/comments","statuses_url":"https://api.github.com/repos/alphagov/tsuru-terraform/statuses/a50110a1ca162438a6a3ddaf57073d48e1912cf3","head":{"label":"alphagov:terraform_update","ref":"terraform_update","sha":"a50110a1ca162438a6a3ddaf57073d48e1912cf3","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":33175984,"name":"tsuru-terraform","full_name":"alphagov/tsuru-terraform","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/tsuru-terraform","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/tsuru-terraform","forks_url":"https://api.github.com/repos/alphagov/tsuru-terraform/forks","keys_url":"https://api.github.com/repos/alphagov/tsuru-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/tsuru-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/tsuru-terraform/teams","hooks_url":"https://api.github.com/repos/alphagov/tsuru-terraform/hooks","issue_events_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/tsuru-terraform/events","assignees_url":"https://api.github.com/repos/alphagov/tsuru-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/tsuru-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/tsuru-terraform/tags","blobs_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/tsuru-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/tsuru-terraform/languages","stargazers_url":"https://api.github.com/repos/alphagov/tsuru-terraform/stargazers","contributors_url":"https://api.github.com/repos/alphagov/tsuru-terraform/contributors","subscribers_url":"https://api.github.com/repos/alphagov/tsuru-terraform/subscribers","subscription_url":"https://api.github.com/repos/alphagov/tsuru-terraform/subscription","commits_url":"https://api.github.com/repos/alphagov/tsuru-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/tsuru-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/tsuru-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/tsuru-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/tsuru-terraform/merges","archive_url":"https://api.github.com/repos/alphagov/tsuru-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/tsuru-terraform/downloads","issues_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/tsuru-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/tsuru-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/tsuru-terraform/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/tsuru-terraform/releases{/id}","created_at":"2015-03-31T09:11:47Z","updated_at":"2015-09-19T07:29:45Z","pushed_at":"2015-10-12T12:22:22Z","git_url":"git://github.com/alphagov/tsuru-terraform.git","ssh_url":"git@github.com:alphagov/tsuru-terraform.git","clone_url":"https://github.com/alphagov/tsuru-terraform.git","svn_url":"https://github.com/alphagov/tsuru-terraform","homepage":null,"size":1175,"stargazers_count":16,"watchers_count":16,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":16,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"54aec51f9ad628a75d29a01eee89380c5a6ae2f8","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":33175984,"name":"tsuru-terraform","full_name":"alphagov/tsuru-terraform","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/tsuru-terraform","description":"","fork":false,"url":"https://api.github.com/repos/alphagov/tsuru-terraform","forks_url":"https://api.github.com/repos/alphagov/tsuru-terraform/forks","keys_url":"https://api.github.com/repos/alphagov/tsuru-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/tsuru-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/tsuru-terraform/teams","hooks_url":"https://api.github.com/repos/alphagov/tsuru-terraform/hooks","issue_events_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/tsuru-terraform/events","assignees_url":"https://api.github.com/repos/alphagov/tsuru-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/tsuru-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/tsuru-terraform/tags","blobs_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/tsuru-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/tsuru-terraform/languages","stargazers_url":"https://api.github.com/repos/alphagov/tsuru-terraform/stargazers","contributors_url":"https://api.github.com/repos/alphagov/tsuru-terraform/contributors","subscribers_url":"https://api.github.com/repos/alphagov/tsuru-terraform/subscribers","subscription_url":"https://api.github.com/repos/alphagov/tsuru-terraform/subscription","commits_url":"https://api.github.com/repos/alphagov/tsuru-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/tsuru-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/tsuru-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/tsuru-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/tsuru-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/tsuru-terraform/merges","archive_url":"https://api.github.com/repos/alphagov/tsuru-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/tsuru-terraform/downloads","issues_url":"https://api.github.com/repos/alphagov/tsuru-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/tsuru-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/tsuru-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/tsuru-terraform/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/tsuru-terraform/releases{/id}","created_at":"2015-03-31T09:11:47Z","updated_at":"2015-09-19T07:29:45Z","pushed_at":"2015-10-12T12:22:22Z","git_url":"git://github.com/alphagov/tsuru-terraform.git","ssh_url":"git@github.com:alphagov/tsuru-terraform.git","clone_url":"https://github.com/alphagov/tsuru-terraform.git","svn_url":"https://github.com/alphagov/tsuru-terraform","homepage":null,"size":1175,"stargazers_count":16,"watchers_count":16,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":0,"forks":3,"open_issues":0,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/104"},"html":{"href":"https://github.com/alphagov/tsuru-terraform/pull/104"},"issue":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/104"},"comments":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/tsuru-terraform/statuses/a50110a1ca162438a6a3ddaf57073d48e1912cf3"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"keymon","id":280032,"avatar_url":"https://avatars.githubusercontent.com/u/280032?v=3","gravatar_id":"","url":"https://api.github.com/users/keymon","html_url":"https://github.com/keymon","followers_url":"https://api.github.com/users/keymon/followers","following_url":"https://api.github.com/users/keymon/following{/other_user}","gists_url":"https://api.github.com/users/keymon/gists{/gist_id}","starred_url":"https://api.github.com/users/keymon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keymon/subscriptions","organizations_url":"https://api.github.com/users/keymon/orgs","repos_url":"https://api.github.com/users/keymon/repos","events_url":"https://api.github.com/users/keymon/events{/privacy}","received_events_url":"https://api.github.com/users/keymon/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"commits":1,"additions":1,"deletions":6,"changed_files":2}}