{"action":"created","comment":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/27461310","id":27461310,"diff_hunk":"@@ -1,7 +1,8 @@\n-#ifndef PYTHONIC_BUILTIN_ABS_HPP\n-#define PYTHONIC_BUILTIN_ABS_HPP\n+#ifndef PYTHONIC_BUILTIN_ABS_IMPL_HPP\n+#define PYTHONIC_BUILTIN_ABS_IMPL_HPP","path":"pythran/pythonic/__builtin__/abs.hpp","position":4,"original_position":4,"commit_id":"a6d7496fce38308f3c71ce79ca1789e83fa56f16","original_commit_id":"a6d7496fce38308f3c71ce79ca1789e83fa56f16","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"body":"that's the first file where you rename the include guard. Why?","created_at":"2015-03-31T08:39:50Z","updated_at":"2015-03-31T08:39:50Z","html_url":"https://github.com/serge-sans-paille/pythran/pull/407#discussion_r27461310","pull_request_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407","_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments/27461310"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/407#discussion_r27461310"},"pull_request":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407"}}},"pull_request":{"url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407","id":31530934,"html_url":"https://github.com/serge-sans-paille/pythran/pull/407","diff_url":"https://github.com/serge-sans-paille/pythran/pull/407.diff","patch_url":"https://github.com/serge-sans-paille/pythran/pull/407.patch","issue_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/407","number":407,"state":"open","locked":false,"title":"Decl impl","user":{"login":"pbrunet","id":1872390,"avatar_url":"https://avatars.githubusercontent.com/u/1872390?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrunet","html_url":"https://github.com/pbrunet","followers_url":"https://api.github.com/users/pbrunet/followers","following_url":"https://api.github.com/users/pbrunet/following{/other_user}","gists_url":"https://api.github.com/users/pbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunet/subscriptions","organizations_url":"https://api.github.com/users/pbrunet/orgs","repos_url":"https://api.github.com/users/pbrunet/repos","events_url":"https://api.github.com/users/pbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunet/received_events","type":"User","site_admin":false},"body":"I create this PR even if the full conversion is not done because it touch almost all pythonic files in a not mergeable way. I would like to be approved on this before continuing. (Integration will have to be done before the full rework is done except if no other development happen before the end of this PR)","created_at":"2015-03-19T14:57:44Z","updated_at":"2015-03-31T08:39:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a99eb2d368d48778abd635a8b3373dd99d7fff67","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407/commits","review_comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407/comments","review_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/407/comments","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/a6d7496fce38308f3c71ce79ca1789e83fa56f16","head":{"label":"pbrunet:decl_impl","ref":"decl_impl","sha":"a6d7496fce38308f3c71ce79ca1789e83fa56f16","user":{"login":"pbrunet","id":1872390,"avatar_url":"https://avatars.githubusercontent.com/u/1872390?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrunet","html_url":"https://github.com/pbrunet","followers_url":"https://api.github.com/users/pbrunet/followers","following_url":"https://api.github.com/users/pbrunet/following{/other_user}","gists_url":"https://api.github.com/users/pbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunet/subscriptions","organizations_url":"https://api.github.com/users/pbrunet/orgs","repos_url":"https://api.github.com/users/pbrunet/repos","events_url":"https://api.github.com/users/pbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunet/received_events","type":"User","site_admin":false},"repo":{"id":4726605,"name":"pythran","full_name":"pbrunet/pythran","owner":{"login":"pbrunet","id":1872390,"avatar_url":"https://avatars.githubusercontent.com/u/1872390?v=3","gravatar_id":"","url":"https://api.github.com/users/pbrunet","html_url":"https://github.com/pbrunet","followers_url":"https://api.github.com/users/pbrunet/followers","following_url":"https://api.github.com/users/pbrunet/following{/other_user}","gists_url":"https://api.github.com/users/pbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/pbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pbrunet/subscriptions","organizations_url":"https://api.github.com/users/pbrunet/orgs","repos_url":"https://api.github.com/users/pbrunet/repos","events_url":"https://api.github.com/users/pbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/pbrunet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pbrunet/pythran","description":"a claimless python to c++ converter","fork":true,"url":"https://api.github.com/repos/pbrunet/pythran","forks_url":"https://api.github.com/repos/pbrunet/pythran/forks","keys_url":"https://api.github.com/repos/pbrunet/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pbrunet/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pbrunet/pythran/teams","hooks_url":"https://api.github.com/repos/pbrunet/pythran/hooks","issue_events_url":"https://api.github.com/repos/pbrunet/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/pbrunet/pythran/events","assignees_url":"https://api.github.com/repos/pbrunet/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/pbrunet/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/pbrunet/pythran/tags","blobs_url":"https://api.github.com/repos/pbrunet/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pbrunet/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pbrunet/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/pbrunet/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pbrunet/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/pbrunet/pythran/languages","stargazers_url":"https://api.github.com/repos/pbrunet/pythran/stargazers","contributors_url":"https://api.github.com/repos/pbrunet/pythran/contributors","subscribers_url":"https://api.github.com/repos/pbrunet/pythran/subscribers","subscription_url":"https://api.github.com/repos/pbrunet/pythran/subscription","commits_url":"https://api.github.com/repos/pbrunet/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/pbrunet/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/pbrunet/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/pbrunet/pythran/issues/comments{/number}","contents_url":"https://api.github.com/repos/pbrunet/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/pbrunet/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pbrunet/pythran/merges","archive_url":"https://api.github.com/repos/pbrunet/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pbrunet/pythran/downloads","issues_url":"https://api.github.com/repos/pbrunet/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/pbrunet/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/pbrunet/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/pbrunet/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pbrunet/pythran/labels{/name}","releases_url":"https://api.github.com/repos/pbrunet/pythran/releases{/id}","created_at":"2012-06-20T13:34:37Z","updated_at":"2015-02-10T19:34:26Z","pushed_at":"2015-03-30T17:38:04Z","git_url":"git://github.com/pbrunet/pythran.git","ssh_url":"git@github.com:pbrunet/pythran.git","clone_url":"https://github.com/pbrunet/pythran.git","svn_url":"https://github.com/pbrunet/pythran","homepage":null,"size":9217,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"serge-sans-paille:master","ref":"master","sha":"d86c61dbdfa2a918811a61e07df5f00a10631458","user":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"repo":{"id":4479494,"name":"pythran","full_name":"serge-sans-paille/pythran","owner":{"login":"serge-sans-paille","id":863807,"avatar_url":"https://avatars.githubusercontent.com/u/863807?v=3","gravatar_id":"","url":"https://api.github.com/users/serge-sans-paille","html_url":"https://github.com/serge-sans-paille","followers_url":"https://api.github.com/users/serge-sans-paille/followers","following_url":"https://api.github.com/users/serge-sans-paille/following{/other_user}","gists_url":"https://api.github.com/users/serge-sans-paille/gists{/gist_id}","starred_url":"https://api.github.com/users/serge-sans-paille/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serge-sans-paille/subscriptions","organizations_url":"https://api.github.com/users/serge-sans-paille/orgs","repos_url":"https://api.github.com/users/serge-sans-paille/repos","events_url":"https://api.github.com/users/serge-sans-paille/events{/privacy}","received_events_url":"https://api.github.com/users/serge-sans-paille/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/serge-sans-paille/pythran","description":"a claimless python to c++ converter","fork":false,"url":"https://api.github.com/repos/serge-sans-paille/pythran","forks_url":"https://api.github.com/repos/serge-sans-paille/pythran/forks","keys_url":"https://api.github.com/repos/serge-sans-paille/pythran/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serge-sans-paille/pythran/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serge-sans-paille/pythran/teams","hooks_url":"https://api.github.com/repos/serge-sans-paille/pythran/hooks","issue_events_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/events{/number}","events_url":"https://api.github.com/repos/serge-sans-paille/pythran/events","assignees_url":"https://api.github.com/repos/serge-sans-paille/pythran/assignees{/user}","branches_url":"https://api.github.com/repos/serge-sans-paille/pythran/branches{/branch}","tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/tags","blobs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/refs{/sha}","trees_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/{sha}","languages_url":"https://api.github.com/repos/serge-sans-paille/pythran/languages","stargazers_url":"https://api.github.com/repos/serge-sans-paille/pythran/stargazers","contributors_url":"https://api.github.com/repos/serge-sans-paille/pythran/contributors","subscribers_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscribers","subscription_url":"https://api.github.com/repos/serge-sans-paille/pythran/subscription","commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/commits{/sha}","git_commits_url":"https://api.github.com/repos/serge-sans-paille/pythran/git/commits{/sha}","comments_url":"https://api.github.com/repos/serge-sans-paille/pythran/comments{/number}","issue_comment_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues/comments{/number}","contents_url":"https://api.github.com/repos/serge-sans-paille/pythran/contents/{+path}","compare_url":"https://api.github.com/repos/serge-sans-paille/pythran/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serge-sans-paille/pythran/merges","archive_url":"https://api.github.com/repos/serge-sans-paille/pythran/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serge-sans-paille/pythran/downloads","issues_url":"https://api.github.com/repos/serge-sans-paille/pythran/issues{/number}","pulls_url":"https://api.github.com/repos/serge-sans-paille/pythran/pulls{/number}","milestones_url":"https://api.github.com/repos/serge-sans-paille/pythran/milestones{/number}","notifications_url":"https://api.github.com/repos/serge-sans-paille/pythran/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serge-sans-paille/pythran/labels{/name}","releases_url":"https://api.github.com/repos/serge-sans-paille/pythran/releases{/id}","created_at":"2012-05-29T08:02:14Z","updated_at":"2015-03-27T09:12:45Z","pushed_at":"2015-03-30T17:38:04Z","git_url":"git://github.com/serge-sans-paille/pythran.git","ssh_url":"git@github.com:serge-sans-paille/pythran.git","clone_url":"https://github.com/serge-sans-paille/pythran.git","svn_url":"https://github.com/serge-sans-paille/pythran","homepage":null,"size":18710,"stargazers_count":217,"watchers_count":217,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":33,"mirror_url":null,"open_issues_count":60,"forks":33,"open_issues":60,"watchers":217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407"},"html":{"href":"https://github.com/serge-sans-paille/pythran/pull/407"},"issue":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/407"},"comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/issues/407/comments"},"review_comments":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407/comments"},"review_comment":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/pulls/407/commits"},"statuses":{"href":"https://api.github.com/repos/serge-sans-paille/pythran/statuses/a6d7496fce38308f3c71ce79ca1789e83fa56f16"}}}}