{"action":"closed","number":1233,"pull_request":{"url":"https://api.github.com/repos/dCache/dcache/pulls/1233","id":27364337,"html_url":"https://github.com/dCache/dcache/pull/1233","diff_url":"https://github.com/dCache/dcache/pull/1233.diff","patch_url":"https://github.com/dCache/dcache/pull/1233.patch","issue_url":"https://api.github.com/repos/dCache/dcache/issues/1233","number":1233,"state":"closed","locked":false,"title":"check-config: fix warning for deprecated properties","user":{"login":"gbehrmann","id":1125766,"avatar_url":"https://avatars.githubusercontent.com/u/1125766?v=3","gravatar_id":"","url":"https://api.github.com/users/gbehrmann","html_url":"https://github.com/gbehrmann","followers_url":"https://api.github.com/users/gbehrmann/followers","following_url":"https://api.github.com/users/gbehrmann/following{/other_user}","gists_url":"https://api.github.com/users/gbehrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gbehrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbehrmann/subscriptions","organizations_url":"https://api.github.com/users/gbehrmann/orgs","repos_url":"https://api.github.com/users/gbehrmann/repos","events_url":"https://api.github.com/users/gbehrmann/events{/privacy}","received_events_url":"https://api.github.com/users/gbehrmann/received_events","type":"User","site_admin":false},"body":"check-config attempts to find a synonym for deprecated properties but fails to\ntake chains of deprecated properties into account. Thus it may end up\nsuggesting other deprecated properties instead.\n\nThe patch addresses this by resolving the synonym recursively. The patch\nremoves one direction of chaining in the analysis: Previously it would consider\nthe value of a property to identify a synonym if it is a simple reference to\nanother property. This type of chaining isn't the proper way to implement\ndeprecated properties (the new name should have precedence and thus the new\nproperty needs to be defined from the old, not the other way arround). There is\nalso the risk of introducing false positives as a deprecated property could be\ndefined in terms of some other, broader, property that isn't actually a\nsynonym. E.g. a service specific property could have been defined in terms of a\ngeneric dcache.x property, but the dcache.x property isn't a synonym for the\nservice specific property.\n\nSpecifically, this patch resolves problems with the\nSpaceManagerReserveSpaceForNonSRMTransfers property.\n\nTarget: trunk\nRequire-notes: yes\nRequire-book: no\nRequest: 2.11\nRequest: 2.10\nAcked-by: Paul Millar <paul.millar@desy.de>\nPatch: https://rb.dcache.org/r/7639/\n(cherry picked from commit d8182a50d31db2112c17fce96be4baa981ef8a0e)","created_at":"2015-01-14T16:51:54Z","updated_at":"2015-01-16T13:36:44Z","closed_at":"2015-01-16T13:36:44Z","merged_at":"2015-01-16T13:36:44Z","merge_commit_sha":"9221ae291180813b52f95d1fe69c4eb2db38baaa","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/dCache/dcache/pulls/1233/commits","review_comments_url":"https://api.github.com/repos/dCache/dcache/pulls/1233/comments","review_comment_url":"https://api.github.com/repos/dCache/dcache/pulls/comments/{number}","comments_url":"https://api.github.com/repos/dCache/dcache/issues/1233/comments","statuses_url":"https://api.github.com/repos/dCache/dcache/statuses/0ebd0af10a103c9bd68d6589fb27b1425c3a259f","head":{"label":"gbehrmann:fix/2.10/rb7639","ref":"fix/2.10/rb7639","sha":"0ebd0af10a103c9bd68d6589fb27b1425c3a259f","user":{"login":"gbehrmann","id":1125766,"avatar_url":"https://avatars.githubusercontent.com/u/1125766?v=3","gravatar_id":"","url":"https://api.github.com/users/gbehrmann","html_url":"https://github.com/gbehrmann","followers_url":"https://api.github.com/users/gbehrmann/followers","following_url":"https://api.github.com/users/gbehrmann/following{/other_user}","gists_url":"https://api.github.com/users/gbehrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gbehrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbehrmann/subscriptions","organizations_url":"https://api.github.com/users/gbehrmann/orgs","repos_url":"https://api.github.com/users/gbehrmann/repos","events_url":"https://api.github.com/users/gbehrmann/events{/privacy}","received_events_url":"https://api.github.com/users/gbehrmann/received_events","type":"User","site_admin":false},"repo":{"id":9749748,"name":"dcache","full_name":"gbehrmann/dcache","owner":{"login":"gbehrmann","id":1125766,"avatar_url":"https://avatars.githubusercontent.com/u/1125766?v=3","gravatar_id":"","url":"https://api.github.com/users/gbehrmann","html_url":"https://github.com/gbehrmann","followers_url":"https://api.github.com/users/gbehrmann/followers","following_url":"https://api.github.com/users/gbehrmann/following{/other_user}","gists_url":"https://api.github.com/users/gbehrmann/gists{/gist_id}","starred_url":"https://api.github.com/users/gbehrmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbehrmann/subscriptions","organizations_url":"https://api.github.com/users/gbehrmann/orgs","repos_url":"https://api.github.com/users/gbehrmann/repos","events_url":"https://api.github.com/users/gbehrmann/events{/privacy}","received_events_url":"https://api.github.com/users/gbehrmann/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbehrmann/dcache","description":"dCache source code","fork":true,"url":"https://api.github.com/repos/gbehrmann/dcache","forks_url":"https://api.github.com/repos/gbehrmann/dcache/forks","keys_url":"https://api.github.com/repos/gbehrmann/dcache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbehrmann/dcache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbehrmann/dcache/teams","hooks_url":"https://api.github.com/repos/gbehrmann/dcache/hooks","issue_events_url":"https://api.github.com/repos/gbehrmann/dcache/issues/events{/number}","events_url":"https://api.github.com/repos/gbehrmann/dcache/events","assignees_url":"https://api.github.com/repos/gbehrmann/dcache/assignees{/user}","branches_url":"https://api.github.com/repos/gbehrmann/dcache/branches{/branch}","tags_url":"https://api.github.com/repos/gbehrmann/dcache/tags","blobs_url":"https://api.github.com/repos/gbehrmann/dcache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbehrmann/dcache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbehrmann/dcache/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbehrmann/dcache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbehrmann/dcache/statuses/{sha}","languages_url":"https://api.github.com/repos/gbehrmann/dcache/languages","stargazers_url":"https://api.github.com/repos/gbehrmann/dcache/stargazers","contributors_url":"https://api.github.com/repos/gbehrmann/dcache/contributors","subscribers_url":"https://api.github.com/repos/gbehrmann/dcache/subscribers","subscription_url":"https://api.github.com/repos/gbehrmann/dcache/subscription","commits_url":"https://api.github.com/repos/gbehrmann/dcache/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbehrmann/dcache/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbehrmann/dcache/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbehrmann/dcache/issues/comments/{number}","contents_url":"https://api.github.com/repos/gbehrmann/dcache/contents/{+path}","compare_url":"https://api.github.com/repos/gbehrmann/dcache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbehrmann/dcache/merges","archive_url":"https://api.github.com/repos/gbehrmann/dcache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbehrmann/dcache/downloads","issues_url":"https://api.github.com/repos/gbehrmann/dcache/issues{/number}","pulls_url":"https://api.github.com/repos/gbehrmann/dcache/pulls{/number}","milestones_url":"https://api.github.com/repos/gbehrmann/dcache/milestones{/number}","notifications_url":"https://api.github.com/repos/gbehrmann/dcache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbehrmann/dcache/labels{/name}","releases_url":"https://api.github.com/repos/gbehrmann/dcache/releases{/id}","created_at":"2013-04-29T14:20:03Z","updated_at":"2014-12-11T08:42:13Z","pushed_at":"2015-01-14T17:45:45Z","git_url":"git://github.com/gbehrmann/dcache.git","ssh_url":"git@github.com:gbehrmann/dcache.git","clone_url":"https://github.com/gbehrmann/dcache.git","svn_url":"https://github.com/gbehrmann/dcache","homepage":null,"size":334528,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dCache:2.10","ref":"2.10","sha":"4d9b1c5ba34df8d8b344bb76c3c999a5bd091088","user":{"login":"dCache","id":1384620,"avatar_url":"https://avatars.githubusercontent.com/u/1384620?v=3","gravatar_id":"","url":"https://api.github.com/users/dCache","html_url":"https://github.com/dCache","followers_url":"https://api.github.com/users/dCache/followers","following_url":"https://api.github.com/users/dCache/following{/other_user}","gists_url":"https://api.github.com/users/dCache/gists{/gist_id}","starred_url":"https://api.github.com/users/dCache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dCache/subscriptions","organizations_url":"https://api.github.com/users/dCache/orgs","repos_url":"https://api.github.com/users/dCache/repos","events_url":"https://api.github.com/users/dCache/events{/privacy}","received_events_url":"https://api.github.com/users/dCache/received_events","type":"Organization","site_admin":false},"repo":{"id":9113580,"name":"dcache","full_name":"dCache/dcache","owner":{"login":"dCache","id":1384620,"avatar_url":"https://avatars.githubusercontent.com/u/1384620?v=3","gravatar_id":"","url":"https://api.github.com/users/dCache","html_url":"https://github.com/dCache","followers_url":"https://api.github.com/users/dCache/followers","following_url":"https://api.github.com/users/dCache/following{/other_user}","gists_url":"https://api.github.com/users/dCache/gists{/gist_id}","starred_url":"https://api.github.com/users/dCache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dCache/subscriptions","organizations_url":"https://api.github.com/users/dCache/orgs","repos_url":"https://api.github.com/users/dCache/repos","events_url":"https://api.github.com/users/dCache/events{/privacy}","received_events_url":"https://api.github.com/users/dCache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dCache/dcache","description":"dCache - a system for storing and retrieving huge amounts of data, distributed among a large number of heterogenous server nodes, under a single virtual filesystem tree with a variety of standard access methods","fork":false,"url":"https://api.github.com/repos/dCache/dcache","forks_url":"https://api.github.com/repos/dCache/dcache/forks","keys_url":"https://api.github.com/repos/dCache/dcache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dCache/dcache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dCache/dcache/teams","hooks_url":"https://api.github.com/repos/dCache/dcache/hooks","issue_events_url":"https://api.github.com/repos/dCache/dcache/issues/events{/number}","events_url":"https://api.github.com/repos/dCache/dcache/events","assignees_url":"https://api.github.com/repos/dCache/dcache/assignees{/user}","branches_url":"https://api.github.com/repos/dCache/dcache/branches{/branch}","tags_url":"https://api.github.com/repos/dCache/dcache/tags","blobs_url":"https://api.github.com/repos/dCache/dcache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dCache/dcache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dCache/dcache/git/refs{/sha}","trees_url":"https://api.github.com/repos/dCache/dcache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dCache/dcache/statuses/{sha}","languages_url":"https://api.github.com/repos/dCache/dcache/languages","stargazers_url":"https://api.github.com/repos/dCache/dcache/stargazers","contributors_url":"https://api.github.com/repos/dCache/dcache/contributors","subscribers_url":"https://api.github.com/repos/dCache/dcache/subscribers","subscription_url":"https://api.github.com/repos/dCache/dcache/subscription","commits_url":"https://api.github.com/repos/dCache/dcache/commits{/sha}","git_commits_url":"https://api.github.com/repos/dCache/dcache/git/commits{/sha}","comments_url":"https://api.github.com/repos/dCache/dcache/comments{/number}","issue_comment_url":"https://api.github.com/repos/dCache/dcache/issues/comments/{number}","contents_url":"https://api.github.com/repos/dCache/dcache/contents/{+path}","compare_url":"https://api.github.com/repos/dCache/dcache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dCache/dcache/merges","archive_url":"https://api.github.com/repos/dCache/dcache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dCache/dcache/downloads","issues_url":"https://api.github.com/repos/dCache/dcache/issues{/number}","pulls_url":"https://api.github.com/repos/dCache/dcache/pulls{/number}","milestones_url":"https://api.github.com/repos/dCache/dcache/milestones{/number}","notifications_url":"https://api.github.com/repos/dCache/dcache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dCache/dcache/labels{/name}","releases_url":"https://api.github.com/repos/dCache/dcache/releases{/id}","created_at":"2013-03-30T08:58:49Z","updated_at":"2015-01-16T12:41:34Z","pushed_at":"2015-01-16T13:36:44Z","git_url":"git://github.com/dCache/dcache.git","ssh_url":"git@github.com:dCache/dcache.git","clone_url":"https://github.com/dCache/dcache.git","svn_url":"https://github.com/dCache/dcache","homepage":"http://www.dcache.org","size":458270,"stargazers_count":15,"watchers_count":15,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":10,"forks":17,"open_issues":10,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dCache/dcache/pulls/1233"},"html":{"href":"https://github.com/dCache/dcache/pull/1233"},"issue":{"href":"https://api.github.com/repos/dCache/dcache/issues/1233"},"comments":{"href":"https://api.github.com/repos/dCache/dcache/issues/1233/comments"},"review_comments":{"href":"https://api.github.com/repos/dCache/dcache/pulls/1233/comments"},"review_comment":{"href":"https://api.github.com/repos/dCache/dcache/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/dCache/dcache/pulls/1233/commits"},"statuses":{"href":"https://api.github.com/repos/dCache/dcache/statuses/0ebd0af10a103c9bd68d6589fb27b1425c3a259f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"paulmillar","id":533081,"avatar_url":"https://avatars.githubusercontent.com/u/533081?v=3","gravatar_id":"","url":"https://api.github.com/users/paulmillar","html_url":"https://github.com/paulmillar","followers_url":"https://api.github.com/users/paulmillar/followers","following_url":"https://api.github.com/users/paulmillar/following{/other_user}","gists_url":"https://api.github.com/users/paulmillar/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmillar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmillar/subscriptions","organizations_url":"https://api.github.com/users/paulmillar/orgs","repos_url":"https://api.github.com/users/paulmillar/repos","events_url":"https://api.github.com/users/paulmillar/events{/privacy}","received_events_url":"https://api.github.com/users/paulmillar/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"commits":1,"additions":16,"deletions":26,"changed_files":2}}