{"action":"created","comment":{"url":"https://api.github.com/repos/doctrine/data-fixtures/pulls/comments/36173507","id":36173507,"diff_hunk":"@@ -101,13 +102,16 @@ protected function getIdentifier($reference, $uow)\n     public function setReference($name, $reference)\n     {\n         $this->references[$name] = $reference;\n-        // in case if reference is set after flush, store its identity\n-        $uow = $this->manager->getUnitOfWork();\n-        if ($uow->isInIdentityMap($reference)) {\n+\n+        if ($this->hasIdentifier($reference)) {\n+            // in case if reference is set after flush, store its identity\n+            $uow = $this->manager->getUnitOfWork();\n             $this->identities[$name] = $this->getIdentifier($reference, $uow);\n         }\n     }\n \n+\n+","path":"lib/Doctrine/Common/DataFixtures/ReferenceRepository.php","position":33,"original_position":33,"commit_id":"6f7839ede86d51048b984cda64fc092a48435059","original_commit_id":"6f7839ede86d51048b984cda64fc092a48435059","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"should be reverted","created_at":"2015-08-04T10:04:48Z","updated_at":"2015-08-04T10:04:48Z","html_url":"https://github.com/doctrine/data-fixtures/pull/201#discussion_r36173507","pull_request_url":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201","_links":{"self":{"href":"https://api.github.com/repos/doctrine/data-fixtures/pulls/comments/36173507"},"html":{"href":"https://github.com/doctrine/data-fixtures/pull/201#discussion_r36173507"},"pull_request":{"href":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201"}}},"pull_request":{"url":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201","id":41541599,"html_url":"https://github.com/doctrine/data-fixtures/pull/201","diff_url":"https://github.com/doctrine/data-fixtures/pull/201.diff","patch_url":"https://github.com/doctrine/data-fixtures/pull/201.patch","issue_url":"https://api.github.com/repos/doctrine/data-fixtures/issues/201","number":201,"state":"open","locked":false,"title":"Use UnitOfWork->contains() instead of isInIdentityMap when Phpcr document","user":{"login":"aramalipoor","id":1164589,"avatar_url":"https://avatars.githubusercontent.com/u/1164589?v=3","gravatar_id":"","url":"https://api.github.com/users/aramalipoor","html_url":"https://github.com/aramalipoor","followers_url":"https://api.github.com/users/aramalipoor/followers","following_url":"https://api.github.com/users/aramalipoor/following{/other_user}","gists_url":"https://api.github.com/users/aramalipoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aramalipoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aramalipoor/subscriptions","organizations_url":"https://api.github.com/users/aramalipoor/orgs","repos_url":"https://api.github.com/users/aramalipoor/repos","events_url":"https://api.github.com/users/aramalipoor/events{/privacy}","received_events_url":"https://api.github.com/users/aramalipoor/received_events","type":"User","site_admin":false},"body":"Unfortunately `isInIdentityMap` does not exist in Phpcr's DocumentManager which is raising issues when for example we're trying to `setReference` a document.\r\n\r\nI'm not an expert in Doctrine stuff so I'm not sure if this is the right way to do it.\r\n\r\nRelated issue https://github.com/doctrine/phpcr-odm/issues/492","created_at":"2015-08-04T07:33:39Z","updated_at":"2015-08-04T10:04:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c759f051ab1e3b7364cd0ec4a8ba0811e91c836","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201/commits","review_comments_url":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201/comments","review_comment_url":"https://api.github.com/repos/doctrine/data-fixtures/pulls/comments{/number}","comments_url":"https://api.github.com/repos/doctrine/data-fixtures/issues/201/comments","statuses_url":"https://api.github.com/repos/doctrine/data-fixtures/statuses/6f7839ede86d51048b984cda64fc092a48435059","head":{"label":"aramalipoor:patch-1","ref":"patch-1","sha":"6f7839ede86d51048b984cda64fc092a48435059","user":{"login":"aramalipoor","id":1164589,"avatar_url":"https://avatars.githubusercontent.com/u/1164589?v=3","gravatar_id":"","url":"https://api.github.com/users/aramalipoor","html_url":"https://github.com/aramalipoor","followers_url":"https://api.github.com/users/aramalipoor/followers","following_url":"https://api.github.com/users/aramalipoor/following{/other_user}","gists_url":"https://api.github.com/users/aramalipoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aramalipoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aramalipoor/subscriptions","organizations_url":"https://api.github.com/users/aramalipoor/orgs","repos_url":"https://api.github.com/users/aramalipoor/repos","events_url":"https://api.github.com/users/aramalipoor/events{/privacy}","received_events_url":"https://api.github.com/users/aramalipoor/received_events","type":"User","site_admin":false},"repo":{"id":40169912,"name":"data-fixtures","full_name":"aramalipoor/data-fixtures","owner":{"login":"aramalipoor","id":1164589,"avatar_url":"https://avatars.githubusercontent.com/u/1164589?v=3","gravatar_id":"","url":"https://api.github.com/users/aramalipoor","html_url":"https://github.com/aramalipoor","followers_url":"https://api.github.com/users/aramalipoor/followers","following_url":"https://api.github.com/users/aramalipoor/following{/other_user}","gists_url":"https://api.github.com/users/aramalipoor/gists{/gist_id}","starred_url":"https://api.github.com/users/aramalipoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aramalipoor/subscriptions","organizations_url":"https://api.github.com/users/aramalipoor/orgs","repos_url":"https://api.github.com/users/aramalipoor/repos","events_url":"https://api.github.com/users/aramalipoor/events{/privacy}","received_events_url":"https://api.github.com/users/aramalipoor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aramalipoor/data-fixtures","description":"Doctrine2 ORM Data Fixtures Extensions","fork":true,"url":"https://api.github.com/repos/aramalipoor/data-fixtures","forks_url":"https://api.github.com/repos/aramalipoor/data-fixtures/forks","keys_url":"https://api.github.com/repos/aramalipoor/data-fixtures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aramalipoor/data-fixtures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aramalipoor/data-fixtures/teams","hooks_url":"https://api.github.com/repos/aramalipoor/data-fixtures/hooks","issue_events_url":"https://api.github.com/repos/aramalipoor/data-fixtures/issues/events{/number}","events_url":"https://api.github.com/repos/aramalipoor/data-fixtures/events","assignees_url":"https://api.github.com/repos/aramalipoor/data-fixtures/assignees{/user}","branches_url":"https://api.github.com/repos/aramalipoor/data-fixtures/branches{/branch}","tags_url":"https://api.github.com/repos/aramalipoor/data-fixtures/tags","blobs_url":"https://api.github.com/repos/aramalipoor/data-fixtures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aramalipoor/data-fixtures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aramalipoor/data-fixtures/git/refs{/sha}","trees_url":"https://api.github.com/repos/aramalipoor/data-fixtures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aramalipoor/data-fixtures/statuses/{sha}","languages_url":"https://api.github.com/repos/aramalipoor/data-fixtures/languages","stargazers_url":"https://api.github.com/repos/aramalipoor/data-fixtures/stargazers","contributors_url":"https://api.github.com/repos/aramalipoor/data-fixtures/contributors","subscribers_url":"https://api.github.com/repos/aramalipoor/data-fixtures/subscribers","subscription_url":"https://api.github.com/repos/aramalipoor/data-fixtures/subscription","commits_url":"https://api.github.com/repos/aramalipoor/data-fixtures/commits{/sha}","git_commits_url":"https://api.github.com/repos/aramalipoor/data-fixtures/git/commits{/sha}","comments_url":"https://api.github.com/repos/aramalipoor/data-fixtures/comments{/number}","issue_comment_url":"https://api.github.com/repos/aramalipoor/data-fixtures/issues/comments{/number}","contents_url":"https://api.github.com/repos/aramalipoor/data-fixtures/contents/{+path}","compare_url":"https://api.github.com/repos/aramalipoor/data-fixtures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aramalipoor/data-fixtures/merges","archive_url":"https://api.github.com/repos/aramalipoor/data-fixtures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aramalipoor/data-fixtures/downloads","issues_url":"https://api.github.com/repos/aramalipoor/data-fixtures/issues{/number}","pulls_url":"https://api.github.com/repos/aramalipoor/data-fixtures/pulls{/number}","milestones_url":"https://api.github.com/repos/aramalipoor/data-fixtures/milestones{/number}","notifications_url":"https://api.github.com/repos/aramalipoor/data-fixtures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aramalipoor/data-fixtures/labels{/name}","releases_url":"https://api.github.com/repos/aramalipoor/data-fixtures/releases{/id}","created_at":"2015-08-04T07:29:52Z","updated_at":"2015-08-04T07:29:52Z","pushed_at":"2015-08-04T09:26:30Z","git_url":"git://github.com/aramalipoor/data-fixtures.git","ssh_url":"git@github.com:aramalipoor/data-fixtures.git","clone_url":"https://github.com/aramalipoor/data-fixtures.git","svn_url":"https://github.com/aramalipoor/data-fixtures","homepage":"http://www.doctrine-project.org","size":430,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"doctrine:master","ref":"master","sha":"bd44f6b6e40247b6530bc8abe802e4e4d914976a","user":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"repo":{"id":926120,"name":"data-fixtures","full_name":"doctrine/data-fixtures","owner":{"login":"doctrine","id":209254,"avatar_url":"https://avatars.githubusercontent.com/u/209254?v=3","gravatar_id":"","url":"https://api.github.com/users/doctrine","html_url":"https://github.com/doctrine","followers_url":"https://api.github.com/users/doctrine/followers","following_url":"https://api.github.com/users/doctrine/following{/other_user}","gists_url":"https://api.github.com/users/doctrine/gists{/gist_id}","starred_url":"https://api.github.com/users/doctrine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doctrine/subscriptions","organizations_url":"https://api.github.com/users/doctrine/orgs","repos_url":"https://api.github.com/users/doctrine/repos","events_url":"https://api.github.com/users/doctrine/events{/privacy}","received_events_url":"https://api.github.com/users/doctrine/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/doctrine/data-fixtures","description":"Doctrine2 ORM Data Fixtures Extensions","fork":false,"url":"https://api.github.com/repos/doctrine/data-fixtures","forks_url":"https://api.github.com/repos/doctrine/data-fixtures/forks","keys_url":"https://api.github.com/repos/doctrine/data-fixtures/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doctrine/data-fixtures/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doctrine/data-fixtures/teams","hooks_url":"https://api.github.com/repos/doctrine/data-fixtures/hooks","issue_events_url":"https://api.github.com/repos/doctrine/data-fixtures/issues/events{/number}","events_url":"https://api.github.com/repos/doctrine/data-fixtures/events","assignees_url":"https://api.github.com/repos/doctrine/data-fixtures/assignees{/user}","branches_url":"https://api.github.com/repos/doctrine/data-fixtures/branches{/branch}","tags_url":"https://api.github.com/repos/doctrine/data-fixtures/tags","blobs_url":"https://api.github.com/repos/doctrine/data-fixtures/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doctrine/data-fixtures/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doctrine/data-fixtures/git/refs{/sha}","trees_url":"https://api.github.com/repos/doctrine/data-fixtures/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doctrine/data-fixtures/statuses/{sha}","languages_url":"https://api.github.com/repos/doctrine/data-fixtures/languages","stargazers_url":"https://api.github.com/repos/doctrine/data-fixtures/stargazers","contributors_url":"https://api.github.com/repos/doctrine/data-fixtures/contributors","subscribers_url":"https://api.github.com/repos/doctrine/data-fixtures/subscribers","subscription_url":"https://api.github.com/repos/doctrine/data-fixtures/subscription","commits_url":"https://api.github.com/repos/doctrine/data-fixtures/commits{/sha}","git_commits_url":"https://api.github.com/repos/doctrine/data-fixtures/git/commits{/sha}","comments_url":"https://api.github.com/repos/doctrine/data-fixtures/comments{/number}","issue_comment_url":"https://api.github.com/repos/doctrine/data-fixtures/issues/comments{/number}","contents_url":"https://api.github.com/repos/doctrine/data-fixtures/contents/{+path}","compare_url":"https://api.github.com/repos/doctrine/data-fixtures/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doctrine/data-fixtures/merges","archive_url":"https://api.github.com/repos/doctrine/data-fixtures/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doctrine/data-fixtures/downloads","issues_url":"https://api.github.com/repos/doctrine/data-fixtures/issues{/number}","pulls_url":"https://api.github.com/repos/doctrine/data-fixtures/pulls{/number}","milestones_url":"https://api.github.com/repos/doctrine/data-fixtures/milestones{/number}","notifications_url":"https://api.github.com/repos/doctrine/data-fixtures/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doctrine/data-fixtures/labels{/name}","releases_url":"https://api.github.com/repos/doctrine/data-fixtures/releases{/id}","created_at":"2010-09-20T21:28:26Z","updated_at":"2015-07-16T19:27:42Z","pushed_at":"2015-08-04T09:26:31Z","git_url":"git://github.com/doctrine/data-fixtures.git","ssh_url":"git@github.com:doctrine/data-fixtures.git","clone_url":"https://github.com/doctrine/data-fixtures.git","svn_url":"https://github.com/doctrine/data-fixtures","homepage":"http://www.doctrine-project.org","size":1395,"stargazers_count":285,"watchers_count":285,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":146,"mirror_url":null,"open_issues_count":35,"forks":146,"open_issues":35,"watchers":285,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201"},"html":{"href":"https://github.com/doctrine/data-fixtures/pull/201"},"issue":{"href":"https://api.github.com/repos/doctrine/data-fixtures/issues/201"},"comments":{"href":"https://api.github.com/repos/doctrine/data-fixtures/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/doctrine/data-fixtures/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/doctrine/data-fixtures/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/doctrine/data-fixtures/statuses/6f7839ede86d51048b984cda64fc092a48435059"}}}}