{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/40211420","id":40211420,"diff_hunk":"@@ -74,24 +78,16 @@ public StoreNodeRelationshipCursor init( boolean isDense,\n             int... relTypes )\n     {\n         this.isDense = isDense;\n-        relationshipId = firstRelId;\n-\n+        this.relationshipId = firstRelId;\n         this.fromNodeId = fromNodeId;\n         this.direction = direction;\n         this.relTypes = relTypes;\n+        this.end = false;\n \n-        if ( isDense && firstRelId != Record.NO_NEXT_RELATIONSHIP.intValue())\n+        if ( isDense )\n         {\n-            try\n-            {\n-                groupRecord = relationshipGroupStore.getRecord( firstRelId, groupRecordInstance );\n-                relationshipId = nextChainStart();\n-            }\n-            catch ( InvalidRecordException e )\n-            {\n-                relationshipId = Record.NO_NEXT_RELATIONSHIP.intValue();\n-            }\n-\n+            groupStore.forceGetRecord( relationshipId, groupRecord );\n+            relationshipId = nextChainStart();","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/api/store/StoreNodeRelationshipCursor.java","position":74,"original_position":74,"commit_id":"845a074b37b351b60d8b2b6a053036d8357ed1ba","original_commit_id":"845a074b37b351b60d8b2b6a053036d8357ed1ba","user":{"login":"chrisvest","id":7993,"avatar_url":"https://avatars.githubusercontent.com/u/7993?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisvest","html_url":"https://github.com/chrisvest","followers_url":"https://api.github.com/users/chrisvest/followers","following_url":"https://api.github.com/users/chrisvest/following{/other_user}","gists_url":"https://api.github.com/users/chrisvest/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisvest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisvest/subscriptions","organizations_url":"https://api.github.com/users/chrisvest/orgs","repos_url":"https://api.github.com/users/chrisvest/repos","events_url":"https://api.github.com/users/chrisvest/events{/privacy}","received_events_url":"https://api.github.com/users/chrisvest/received_events","type":"User","site_admin":false},"body":"If the `RelationshipGroupRecord` is not in use, then the `RelationshipGroupStore.forceGetRecord` won't actually read it. Instead it'll just return an empty dummy record, where the pointers have no connection to reality. Will that be a problem for this code?","created_at":"2015-09-23T14:43:41Z","updated_at":"2015-09-23T14:43:41Z","html_url":"https://github.com/neo4j/neo4j/pull/5382#discussion_r40211420","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5382","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/40211420"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5382#discussion_r40211420"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5382"}}},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/5382","id":45283835,"html_url":"https://github.com/neo4j/neo4j/pull/5382","diff_url":"https://github.com/neo4j/neo4j/pull/5382.diff","patch_url":"https://github.com/neo4j/neo4j/pull/5382.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/5382","number":5382,"state":"open","locked":false,"title":"Isolation improvements","user":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"body":"","created_at":"2015-09-17T12:25:00Z","updated_at":"2015-09-23T14:43:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20c27a732efadf400b2c1d8bf328f03604a57c3a","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5382/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/5382/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/5382/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/845a074b37b351b60d8b2b6a053036d8357ed1ba","head":{"label":"tinwelint:2.3-isolation-improvements","ref":"2.3-isolation-improvements","sha":"845a074b37b351b60d8b2b6a053036d8357ed1ba","user":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"repo":{"id":6666980,"name":"neo4j","full_name":"tinwelint/neo4j","owner":{"login":"tinwelint","id":187292,"avatar_url":"https://avatars.githubusercontent.com/u/187292?v=3","gravatar_id":"","url":"https://api.github.com/users/tinwelint","html_url":"https://github.com/tinwelint","followers_url":"https://api.github.com/users/tinwelint/followers","following_url":"https://api.github.com/users/tinwelint/following{/other_user}","gists_url":"https://api.github.com/users/tinwelint/gists{/gist_id}","starred_url":"https://api.github.com/users/tinwelint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinwelint/subscriptions","organizations_url":"https://api.github.com/users/tinwelint/orgs","repos_url":"https://api.github.com/users/tinwelint/repos","events_url":"https://api.github.com/users/tinwelint/events{/privacy}","received_events_url":"https://api.github.com/users/tinwelint/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tinwelint/neo4j","description":"","fork":true,"url":"https://api.github.com/repos/tinwelint/neo4j","forks_url":"https://api.github.com/repos/tinwelint/neo4j/forks","keys_url":"https://api.github.com/repos/tinwelint/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tinwelint/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tinwelint/neo4j/teams","hooks_url":"https://api.github.com/repos/tinwelint/neo4j/hooks","issue_events_url":"https://api.github.com/repos/tinwelint/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/tinwelint/neo4j/events","assignees_url":"https://api.github.com/repos/tinwelint/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/tinwelint/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/tinwelint/neo4j/tags","blobs_url":"https://api.github.com/repos/tinwelint/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tinwelint/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tinwelint/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/tinwelint/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tinwelint/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/tinwelint/neo4j/languages","stargazers_url":"https://api.github.com/repos/tinwelint/neo4j/stargazers","contributors_url":"https://api.github.com/repos/tinwelint/neo4j/contributors","subscribers_url":"https://api.github.com/repos/tinwelint/neo4j/subscribers","subscription_url":"https://api.github.com/repos/tinwelint/neo4j/subscription","commits_url":"https://api.github.com/repos/tinwelint/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/tinwelint/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/tinwelint/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/tinwelint/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/tinwelint/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/tinwelint/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tinwelint/neo4j/merges","archive_url":"https://api.github.com/repos/tinwelint/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tinwelint/neo4j/downloads","issues_url":"https://api.github.com/repos/tinwelint/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/tinwelint/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/tinwelint/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/tinwelint/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tinwelint/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/tinwelint/neo4j/releases{/id}","created_at":"2012-11-13T07:24:49Z","updated_at":"2014-12-16T07:20:14Z","pushed_at":"2015-09-23T08:37:35Z","git_url":"git://github.com/tinwelint/neo4j.git","ssh_url":"git@github.com:tinwelint/neo4j.git","clone_url":"https://github.com/tinwelint/neo4j.git","svn_url":"https://github.com/tinwelint/neo4j","homepage":null,"size":210361,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"neo4j:2.3","ref":"2.3","sha":"c973f2beb1c62354c1201d157fdcb33347f6b773","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars.githubusercontent.com/u/201120?v=3","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","created_at":"2012-11-12T08:46:15Z","updated_at":"2015-09-23T13:51:15Z","pushed_at":"2015-09-23T14:19:20Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":518802,"stargazers_count":1967,"watchers_count":1967,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":749,"mirror_url":null,"open_issues_count":482,"forks":749,"open_issues":482,"watchers":1967,"default_branch":"2.3"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5382"},"html":{"href":"https://github.com/neo4j/neo4j/pull/5382"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5382"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/5382/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5382/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/5382/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/845a074b37b351b60d8b2b6a053036d8357ed1ba"}}}}