{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/38978551","id":38978551,"diff_hunk":"@@ -283,6 +293,18 @@ logViewerApp.controller('LogviewerCtrl', [\n             });\n         }\n \n+        function drawSelectedLines(data) {\n+            if (data.length === 0) {\n+                return;\n+            }\n+            //TODO: Test $scope.selectedBegin and $scope.selectedEnd\n+            var i = $scope.selectedBegin;\n+            var end = $scope.selectedEnd;\n+            for (i ; i <= end ; i++) {","path":"ui/js/controllers/logviewer.js","position":37,"original_position":37,"commit_id":"c35908f49b5bf4b7e68dbdff95b086012e29229e","original_commit_id":"c35908f49b5bf4b7e68dbdff95b086012e29229e","user":{"login":"tojonmz","id":3660661,"avatar_url":"https://avatars.githubusercontent.com/u/3660661?v=3","gravatar_id":"","url":"https://api.github.com/users/tojonmz","html_url":"https://github.com/tojonmz","followers_url":"https://api.github.com/users/tojonmz/followers","following_url":"https://api.github.com/users/tojonmz/following{/other_user}","gists_url":"https://api.github.com/users/tojonmz/gists{/gist_id}","starred_url":"https://api.github.com/users/tojonmz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tojonmz/subscriptions","organizations_url":"https://api.github.com/users/tojonmz/orgs","repos_url":"https://api.github.com/users/tojonmz/repos","events_url":"https://api.github.com/users/tojonmz/events{/privacy}","received_events_url":"https://api.github.com/users/tojonmz/received_events","type":"User","site_admin":false},"body":"There shouldn't be a space between the `i` and `end` vars, and their semicolons.","created_at":"2015-09-08T20:52:11Z","updated_at":"2015-09-08T20:52:11Z","html_url":"https://github.com/mozilla/treeherder/pull/948#discussion_r38978551","pull_request_url":"https://api.github.com/repos/mozilla/treeherder/pulls/948","_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments/38978551"},"html":{"href":"https://github.com/mozilla/treeherder/pull/948#discussion_r38978551"},"pull_request":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/948"}}},"pull_request":{"url":"https://api.github.com/repos/mozilla/treeherder/pulls/948","id":44462828,"html_url":"https://github.com/mozilla/treeherder/pull/948","diff_url":"https://github.com/mozilla/treeherder/pull/948.diff","patch_url":"https://github.com/mozilla/treeherder/pull/948.patch","issue_url":"https://api.github.com/repos/mozilla/treeherder/issues/948","number":948,"state":"open","locked":false,"title":"Bug 1108764 - Allow easy sharing of links to a specific log line in the log viewer","user":{"login":"gbrmachado","id":81703,"avatar_url":"https://avatars.githubusercontent.com/u/81703?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrmachado","html_url":"https://github.com/gbrmachado","followers_url":"https://api.github.com/users/gbrmachado/followers","following_url":"https://api.github.com/users/gbrmachado/following{/other_user}","gists_url":"https://api.github.com/users/gbrmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrmachado/subscriptions","organizations_url":"https://api.github.com/users/gbrmachado/orgs","repos_url":"https://api.github.com/users/gbrmachado/repos","events_url":"https://api.github.com/users/gbrmachado/events{/privacy}","received_events_url":"https://api.github.com/users/gbrmachado/received_events","type":"User","site_admin":false},"body":"This is the first draft.\r\nI still have to change some stuffs(lot of stuffs), but I'd like to have some feedback, to see if I'm doing everything right, or if something can be changed.\n\n<!-- Reviewable:start -->\n[<img src=\"https://reviewable.io/review_button.png\" height=40 alt=\"Review on Reviewable\"/>](https://reviewable.io/reviews/mozilla/treeherder/948)\n<!-- Reviewable:end -->\n","created_at":"2015-09-08T17:56:37Z","updated_at":"2015-09-08T20:52:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db5524b56ae12e3f26b4fdc45a5d57164e091aa6","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/treeherder/pulls/948/commits","review_comments_url":"https://api.github.com/repos/mozilla/treeherder/pulls/948/comments","review_comment_url":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/treeherder/issues/948/comments","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/c35908f49b5bf4b7e68dbdff95b086012e29229e","head":{"label":"gbrmachado:Bug1108764","ref":"Bug1108764","sha":"c35908f49b5bf4b7e68dbdff95b086012e29229e","user":{"login":"gbrmachado","id":81703,"avatar_url":"https://avatars.githubusercontent.com/u/81703?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrmachado","html_url":"https://github.com/gbrmachado","followers_url":"https://api.github.com/users/gbrmachado/followers","following_url":"https://api.github.com/users/gbrmachado/following{/other_user}","gists_url":"https://api.github.com/users/gbrmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrmachado/subscriptions","organizations_url":"https://api.github.com/users/gbrmachado/orgs","repos_url":"https://api.github.com/users/gbrmachado/repos","events_url":"https://api.github.com/users/gbrmachado/events{/privacy}","received_events_url":"https://api.github.com/users/gbrmachado/received_events","type":"User","site_admin":false},"repo":{"id":38535862,"name":"treeherder","full_name":"gbrmachado/treeherder","owner":{"login":"gbrmachado","id":81703,"avatar_url":"https://avatars.githubusercontent.com/u/81703?v=3","gravatar_id":"","url":"https://api.github.com/users/gbrmachado","html_url":"https://github.com/gbrmachado","followers_url":"https://api.github.com/users/gbrmachado/followers","following_url":"https://api.github.com/users/gbrmachado/following{/other_user}","gists_url":"https://api.github.com/users/gbrmachado/gists{/gist_id}","starred_url":"https://api.github.com/users/gbrmachado/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbrmachado/subscriptions","organizations_url":"https://api.github.com/users/gbrmachado/orgs","repos_url":"https://api.github.com/users/gbrmachado/repos","events_url":"https://api.github.com/users/gbrmachado/events{/privacy}","received_events_url":"https://api.github.com/users/gbrmachado/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gbrmachado/treeherder","description":"A reporting dashboard & service for managing CI data for commits to Mozilla projects","fork":true,"url":"https://api.github.com/repos/gbrmachado/treeherder","forks_url":"https://api.github.com/repos/gbrmachado/treeherder/forks","keys_url":"https://api.github.com/repos/gbrmachado/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gbrmachado/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gbrmachado/treeherder/teams","hooks_url":"https://api.github.com/repos/gbrmachado/treeherder/hooks","issue_events_url":"https://api.github.com/repos/gbrmachado/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/gbrmachado/treeherder/events","assignees_url":"https://api.github.com/repos/gbrmachado/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/gbrmachado/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/gbrmachado/treeherder/tags","blobs_url":"https://api.github.com/repos/gbrmachado/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gbrmachado/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gbrmachado/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/gbrmachado/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gbrmachado/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/gbrmachado/treeherder/languages","stargazers_url":"https://api.github.com/repos/gbrmachado/treeherder/stargazers","contributors_url":"https://api.github.com/repos/gbrmachado/treeherder/contributors","subscribers_url":"https://api.github.com/repos/gbrmachado/treeherder/subscribers","subscription_url":"https://api.github.com/repos/gbrmachado/treeherder/subscription","commits_url":"https://api.github.com/repos/gbrmachado/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/gbrmachado/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/gbrmachado/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/gbrmachado/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/gbrmachado/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/gbrmachado/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gbrmachado/treeherder/merges","archive_url":"https://api.github.com/repos/gbrmachado/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gbrmachado/treeherder/downloads","issues_url":"https://api.github.com/repos/gbrmachado/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/gbrmachado/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/gbrmachado/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/gbrmachado/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gbrmachado/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/gbrmachado/treeherder/releases{/id}","created_at":"2015-07-04T14:08:41Z","updated_at":"2015-08-19T14:49:25Z","pushed_at":"2015-09-08T17:52:52Z","git_url":"git://github.com/gbrmachado/treeherder.git","ssh_url":"git@github.com:gbrmachado/treeherder.git","clone_url":"https://github.com/gbrmachado/treeherder.git","svn_url":"https://github.com/gbrmachado/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":37290,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"1bd312341fdb80ffeb7b9250ab0924fe6026aa23","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":8463294,"name":"treeherder","full_name":"mozilla/treeherder","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars.githubusercontent.com/u/131524?v=3","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/treeherder","description":"A reporting dashboard & service for managing CI data for commits to Mozilla projects","fork":false,"url":"https://api.github.com/repos/mozilla/treeherder","forks_url":"https://api.github.com/repos/mozilla/treeherder/forks","keys_url":"https://api.github.com/repos/mozilla/treeherder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/treeherder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/treeherder/teams","hooks_url":"https://api.github.com/repos/mozilla/treeherder/hooks","issue_events_url":"https://api.github.com/repos/mozilla/treeherder/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/treeherder/events","assignees_url":"https://api.github.com/repos/mozilla/treeherder/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/treeherder/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/treeherder/tags","blobs_url":"https://api.github.com/repos/mozilla/treeherder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/treeherder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/treeherder/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/treeherder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/treeherder/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/treeherder/languages","stargazers_url":"https://api.github.com/repos/mozilla/treeherder/stargazers","contributors_url":"https://api.github.com/repos/mozilla/treeherder/contributors","subscribers_url":"https://api.github.com/repos/mozilla/treeherder/subscribers","subscription_url":"https://api.github.com/repos/mozilla/treeherder/subscription","commits_url":"https://api.github.com/repos/mozilla/treeherder/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/treeherder/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/treeherder/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/treeherder/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/treeherder/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/treeherder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/treeherder/merges","archive_url":"https://api.github.com/repos/mozilla/treeherder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/treeherder/downloads","issues_url":"https://api.github.com/repos/mozilla/treeherder/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/treeherder/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/treeherder/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/treeherder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/treeherder/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/treeherder/releases{/id}","created_at":"2013-02-27T19:17:37Z","updated_at":"2015-08-26T11:11:22Z","pushed_at":"2015-09-08T19:35:47Z","git_url":"git://github.com/mozilla/treeherder.git","ssh_url":"git@github.com:mozilla/treeherder.git","clone_url":"https://github.com/mozilla/treeherder.git","svn_url":"https://github.com/mozilla/treeherder","homepage":"https://wiki.mozilla.org/Auto-tools/Projects/Treeherder","size":403633,"stargazers_count":27,"watchers_count":27,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67,"mirror_url":null,"open_issues_count":24,"forks":67,"open_issues":24,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/948"},"html":{"href":"https://github.com/mozilla/treeherder/pull/948"},"issue":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/948"},"comments":{"href":"https://api.github.com/repos/mozilla/treeherder/issues/948/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/948/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/treeherder/pulls/948/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/treeherder/statuses/c35908f49b5bf4b7e68dbdff95b086012e29229e"}}}}