{"action":"created","issue":{"url":"https://api.github.com/repos/mikepenz/LollipopShowcase/issues/8","labels_url":"https://api.github.com/repos/mikepenz/LollipopShowcase/issues/8/labels{/name}","comments_url":"https://api.github.com/repos/mikepenz/LollipopShowcase/issues/8/comments","events_url":"https://api.github.com/repos/mikepenz/LollipopShowcase/issues/8/events","html_url":"https://github.com/mikepenz/LollipopShowcase/issues/8","id":53307355,"number":8,"title":"Please follow Google's Material design guidelines","user":{"login":"AndroidDeveloperLB","id":5357526,"avatar_url":"https://avatars.githubusercontent.com/u/5357526?v=3","gravatar_id":"","url":"https://api.github.com/users/AndroidDeveloperLB","html_url":"https://github.com/AndroidDeveloperLB","followers_url":"https://api.github.com/users/AndroidDeveloperLB/followers","following_url":"https://api.github.com/users/AndroidDeveloperLB/following{/other_user}","gists_url":"https://api.github.com/users/AndroidDeveloperLB/gists{/gist_id}","starred_url":"https://api.github.com/users/AndroidDeveloperLB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndroidDeveloperLB/subscriptions","organizations_url":"https://api.github.com/users/AndroidDeveloperLB/orgs","repos_url":"https://api.github.com/users/AndroidDeveloperLB/repos","events_url":"https://api.github.com/users/AndroidDeveloperLB/events{/privacy}","received_events_url":"https://api.github.com/users/AndroidDeveloperLB/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/mikepenz/LollipopShowcase/labels/bug","name":"bug","color":"fc2929"},{"url":"https://api.github.com/repos/mikepenz/LollipopShowcase/labels/enhancement","name":"enhancement","color":"84b6eb"}],"state":"open","locked":false,"assignee":null,"milestone":null,"comments":5,"created_at":"2015-01-03T15:55:00Z","updated_at":"2015-01-03T16:48:24Z","closed_at":null,"body":"look at this link:\r\nhttp://www.google.com/design/spec/components/buttons.html#buttons-floating-action-button\r\nscroll down till you see the text :\r\n\r\n\"A floating action button shouldn’t float in a random location. Take care when attaching floating action buttons to a toolbar, where it might overlap with or cover other touch targets.\" .\r\n\r\nAccording to the screenshots of the library, I see that the sample doesn't match the guidelines.\r\nThe reason: the floating button is positioned on a place that can easily cover the action items.\r\nIt should never be located on the toolbar/actionbar, since there could be items there (plus if you wanted to put there a button, you could simply put an action item instead).\r\n\r\nAlso, when testing the sample app, and choosing an item, the floating button gets covered by another view, which is also against the guidelines (how would you press the button when it's covered) ...\r\nThis is covered on the same page, when you scroll to this text:\r\n\r\n\"Don’t block floating action buttons with snackbars or toasts.\""},"comment":{"url":"https://api.github.com/repos/mikepenz/LollipopShowcase/issues/comments/68601121","html_url":"https://github.com/mikepenz/LollipopShowcase/issues/8#issuecomment-68601121","issue_url":"https://api.github.com/repos/mikepenz/LollipopShowcase/issues/8","id":68601121,"user":{"login":"mikepenz","id":1476232,"avatar_url":"https://avatars.githubusercontent.com/u/1476232?v=3","gravatar_id":"","url":"https://api.github.com/users/mikepenz","html_url":"https://github.com/mikepenz","followers_url":"https://api.github.com/users/mikepenz/followers","following_url":"https://api.github.com/users/mikepenz/following{/other_user}","gists_url":"https://api.github.com/users/mikepenz/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepenz/subscriptions","organizations_url":"https://api.github.com/users/mikepenz/orgs","repos_url":"https://api.github.com/users/mikepenz/repos","events_url":"https://api.github.com/users/mikepenz/events{/privacy}","received_events_url":"https://api.github.com/users/mikepenz/received_events","type":"User","site_admin":false},"created_at":"2015-01-03T16:48:24Z","updated_at":"2015-01-03T16:48:24Z","body":"@AndroidDeveloperLB it could be an action item that's true, but for this simply purpose and to showcase the new animation framework and to make this button visually more appealing it makes sense. in a real life application you probably wouldn't place it like this. \r\n\r\nif you got another idea how to showcase the animation framework of Android L you can open a pull request. \r\n\r\nthanks for your thoughts on this :)"}}