{"action":"closed","number":97,"pull_request":{"url":"https://api.github.com/repos/traject/traject/pulls/97","id":30180065,"html_url":"https://github.com/traject/traject/pull/97","diff_url":"https://github.com/traject/traject/pull/97.diff","patch_url":"https://github.com/traject/traject/pull/97.patch","issue_url":"https://api.github.com/repos/traject/traject/issues/97","number":97,"state":"closed","locked":false,"title":"DRY source_record_id in Context where it belongs","user":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"body":"Tell don't ask, it belongs in Context, and now it's DRY between\r\nindexer and writer (and future needs).\r\n\r\nThis did require me to rearrange Indexer a bit, creating\r\nthe context outside the thread, so it would be available\r\nwhen I needed it for batch logging. (Alternately batch\r\nlogging could have been moved inside the thread?). I think\r\nthis is just fine, and even makes the code cleaner, but now\r\nI'm getting paranoid that every change might be a perf regression.\r\nI think it's fine though.","created_at":"2015-02-27T16:36:42Z","updated_at":"2015-03-04T14:14:08Z","closed_at":"2015-03-04T14:14:08Z","merged_at":"2015-03-04T14:14:08Z","merge_commit_sha":"f693adbd2a35b4cff79eb8ec9e8c9e5751d4c4b7","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/traject/traject/pulls/97/commits","review_comments_url":"https://api.github.com/repos/traject/traject/pulls/97/comments","review_comment_url":"https://api.github.com/repos/traject/traject/pulls/comments{/number}","comments_url":"https://api.github.com/repos/traject/traject/issues/97/comments","statuses_url":"https://api.github.com/repos/traject/traject/statuses/b130c38607d5afde23f0d7c95e256ab7b6c80203","head":{"label":"traject:dry_record_id","ref":"dry_record_id","sha":"b130c38607d5afde23f0d7c95e256ab7b6c80203","user":{"login":"traject","id":5656228,"avatar_url":"https://avatars.githubusercontent.com/u/5656228?v=3","gravatar_id":"","url":"https://api.github.com/users/traject","html_url":"https://github.com/traject","followers_url":"https://api.github.com/users/traject/followers","following_url":"https://api.github.com/users/traject/following{/other_user}","gists_url":"https://api.github.com/users/traject/gists{/gist_id}","starred_url":"https://api.github.com/users/traject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traject/subscriptions","organizations_url":"https://api.github.com/users/traject/orgs","repos_url":"https://api.github.com/users/traject/repos","events_url":"https://api.github.com/users/traject/events{/privacy}","received_events_url":"https://api.github.com/users/traject/received_events","type":"Organization","site_admin":false},"repo":{"id":11256250,"name":"traject","full_name":"traject/traject","owner":{"login":"traject","id":5656228,"avatar_url":"https://avatars.githubusercontent.com/u/5656228?v=3","gravatar_id":"","url":"https://api.github.com/users/traject","html_url":"https://github.com/traject","followers_url":"https://api.github.com/users/traject/followers","following_url":"https://api.github.com/users/traject/following{/other_user}","gists_url":"https://api.github.com/users/traject/gists{/gist_id}","starred_url":"https://api.github.com/users/traject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traject/subscriptions","organizations_url":"https://api.github.com/users/traject/orgs","repos_url":"https://api.github.com/users/traject/repos","events_url":"https://api.github.com/users/traject/events{/privacy}","received_events_url":"https://api.github.com/users/traject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/traject/traject","description":"An easy to use, high-performance, flexible and extensible MARC to Solr indexer.","fork":false,"url":"https://api.github.com/repos/traject/traject","forks_url":"https://api.github.com/repos/traject/traject/forks","keys_url":"https://api.github.com/repos/traject/traject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traject/traject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traject/traject/teams","hooks_url":"https://api.github.com/repos/traject/traject/hooks","issue_events_url":"https://api.github.com/repos/traject/traject/issues/events{/number}","events_url":"https://api.github.com/repos/traject/traject/events","assignees_url":"https://api.github.com/repos/traject/traject/assignees{/user}","branches_url":"https://api.github.com/repos/traject/traject/branches{/branch}","tags_url":"https://api.github.com/repos/traject/traject/tags","blobs_url":"https://api.github.com/repos/traject/traject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traject/traject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traject/traject/git/refs{/sha}","trees_url":"https://api.github.com/repos/traject/traject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traject/traject/statuses/{sha}","languages_url":"https://api.github.com/repos/traject/traject/languages","stargazers_url":"https://api.github.com/repos/traject/traject/stargazers","contributors_url":"https://api.github.com/repos/traject/traject/contributors","subscribers_url":"https://api.github.com/repos/traject/traject/subscribers","subscription_url":"https://api.github.com/repos/traject/traject/subscription","commits_url":"https://api.github.com/repos/traject/traject/commits{/sha}","git_commits_url":"https://api.github.com/repos/traject/traject/git/commits{/sha}","comments_url":"https://api.github.com/repos/traject/traject/comments{/number}","issue_comment_url":"https://api.github.com/repos/traject/traject/issues/comments{/number}","contents_url":"https://api.github.com/repos/traject/traject/contents/{+path}","compare_url":"https://api.github.com/repos/traject/traject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traject/traject/merges","archive_url":"https://api.github.com/repos/traject/traject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traject/traject/downloads","issues_url":"https://api.github.com/repos/traject/traject/issues{/number}","pulls_url":"https://api.github.com/repos/traject/traject/pulls{/number}","milestones_url":"https://api.github.com/repos/traject/traject/milestones{/number}","notifications_url":"https://api.github.com/repos/traject/traject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traject/traject/labels{/name}","releases_url":"https://api.github.com/repos/traject/traject/releases{/id}","created_at":"2013-07-08T14:26:58Z","updated_at":"2015-03-03T16:02:03Z","pushed_at":"2015-03-04T14:14:08Z","git_url":"git://github.com/traject/traject.git","ssh_url":"git@github.com:traject/traject.git","clone_url":"https://github.com/traject/traject.git","svn_url":"https://github.com/traject/traject","homepage":"","size":24139,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":33,"default_branch":"master"}},"base":{"label":"traject:master","ref":"master","sha":"1bb3dd9586f1550ca619e99fb3013457cbc0b88e","user":{"login":"traject","id":5656228,"avatar_url":"https://avatars.githubusercontent.com/u/5656228?v=3","gravatar_id":"","url":"https://api.github.com/users/traject","html_url":"https://github.com/traject","followers_url":"https://api.github.com/users/traject/followers","following_url":"https://api.github.com/users/traject/following{/other_user}","gists_url":"https://api.github.com/users/traject/gists{/gist_id}","starred_url":"https://api.github.com/users/traject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traject/subscriptions","organizations_url":"https://api.github.com/users/traject/orgs","repos_url":"https://api.github.com/users/traject/repos","events_url":"https://api.github.com/users/traject/events{/privacy}","received_events_url":"https://api.github.com/users/traject/received_events","type":"Organization","site_admin":false},"repo":{"id":11256250,"name":"traject","full_name":"traject/traject","owner":{"login":"traject","id":5656228,"avatar_url":"https://avatars.githubusercontent.com/u/5656228?v=3","gravatar_id":"","url":"https://api.github.com/users/traject","html_url":"https://github.com/traject","followers_url":"https://api.github.com/users/traject/followers","following_url":"https://api.github.com/users/traject/following{/other_user}","gists_url":"https://api.github.com/users/traject/gists{/gist_id}","starred_url":"https://api.github.com/users/traject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/traject/subscriptions","organizations_url":"https://api.github.com/users/traject/orgs","repos_url":"https://api.github.com/users/traject/repos","events_url":"https://api.github.com/users/traject/events{/privacy}","received_events_url":"https://api.github.com/users/traject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/traject/traject","description":"An easy to use, high-performance, flexible and extensible MARC to Solr indexer.","fork":false,"url":"https://api.github.com/repos/traject/traject","forks_url":"https://api.github.com/repos/traject/traject/forks","keys_url":"https://api.github.com/repos/traject/traject/keys{/key_id}","collaborators_url":"https://api.github.com/repos/traject/traject/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/traject/traject/teams","hooks_url":"https://api.github.com/repos/traject/traject/hooks","issue_events_url":"https://api.github.com/repos/traject/traject/issues/events{/number}","events_url":"https://api.github.com/repos/traject/traject/events","assignees_url":"https://api.github.com/repos/traject/traject/assignees{/user}","branches_url":"https://api.github.com/repos/traject/traject/branches{/branch}","tags_url":"https://api.github.com/repos/traject/traject/tags","blobs_url":"https://api.github.com/repos/traject/traject/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/traject/traject/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/traject/traject/git/refs{/sha}","trees_url":"https://api.github.com/repos/traject/traject/git/trees{/sha}","statuses_url":"https://api.github.com/repos/traject/traject/statuses/{sha}","languages_url":"https://api.github.com/repos/traject/traject/languages","stargazers_url":"https://api.github.com/repos/traject/traject/stargazers","contributors_url":"https://api.github.com/repos/traject/traject/contributors","subscribers_url":"https://api.github.com/repos/traject/traject/subscribers","subscription_url":"https://api.github.com/repos/traject/traject/subscription","commits_url":"https://api.github.com/repos/traject/traject/commits{/sha}","git_commits_url":"https://api.github.com/repos/traject/traject/git/commits{/sha}","comments_url":"https://api.github.com/repos/traject/traject/comments{/number}","issue_comment_url":"https://api.github.com/repos/traject/traject/issues/comments{/number}","contents_url":"https://api.github.com/repos/traject/traject/contents/{+path}","compare_url":"https://api.github.com/repos/traject/traject/compare/{base}...{head}","merges_url":"https://api.github.com/repos/traject/traject/merges","archive_url":"https://api.github.com/repos/traject/traject/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/traject/traject/downloads","issues_url":"https://api.github.com/repos/traject/traject/issues{/number}","pulls_url":"https://api.github.com/repos/traject/traject/pulls{/number}","milestones_url":"https://api.github.com/repos/traject/traject/milestones{/number}","notifications_url":"https://api.github.com/repos/traject/traject/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/traject/traject/labels{/name}","releases_url":"https://api.github.com/repos/traject/traject/releases{/id}","created_at":"2013-07-08T14:26:58Z","updated_at":"2015-03-03T16:02:03Z","pushed_at":"2015-03-04T14:14:08Z","git_url":"git://github.com/traject/traject.git","ssh_url":"git@github.com:traject/traject.git","clone_url":"https://github.com/traject/traject.git","svn_url":"https://github.com/traject/traject","homepage":"","size":24139,"stargazers_count":33,"watchers_count":33,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":7,"forks":6,"open_issues":7,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/traject/traject/pulls/97"},"html":{"href":"https://github.com/traject/traject/pull/97"},"issue":{"href":"https://api.github.com/repos/traject/traject/issues/97"},"comments":{"href":"https://api.github.com/repos/traject/traject/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/traject/traject/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/traject/traject/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/traject/traject/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/traject/traject/statuses/b130c38607d5afde23f0d7c95e256ab7b6c80203"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"jrochkind","id":149304,"avatar_url":"https://avatars.githubusercontent.com/u/149304?v=3","gravatar_id":"","url":"https://api.github.com/users/jrochkind","html_url":"https://github.com/jrochkind","followers_url":"https://api.github.com/users/jrochkind/followers","following_url":"https://api.github.com/users/jrochkind/following{/other_user}","gists_url":"https://api.github.com/users/jrochkind/gists{/gist_id}","starred_url":"https://api.github.com/users/jrochkind/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrochkind/subscriptions","organizations_url":"https://api.github.com/users/jrochkind/orgs","repos_url":"https://api.github.com/users/jrochkind/repos","events_url":"https://api.github.com/users/jrochkind/events{/privacy}","received_events_url":"https://api.github.com/users/jrochkind/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"commits":1,"additions":69,"deletions":58,"changed_files":4}}