{"action":"created","comment":{"url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/comments/31117078","id":31117078,"diff_hunk":"@@ -17,7 +17,10 @@ def queue_reboot\n   end\n \n   def setReboot\n-    old.becomes(Host::Discovered).reboot\n+    old.becomes(Host::Discovered).reboot if errors.empty?","path":"app/models/host/managed_extensions.rb","position":5,"original_position":5,"commit_id":"d14b6c3aea7994daf8dd08c55234676e4c1b18fb","original_commit_id":"d14b6c3aea7994daf8dd08c55234676e4c1b18fb","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"Stacktrace is:\r\n\r\n```\r\n \"/home/lzap/work/foreman_discovery/app/models/host/managed_extensions.rb:20:in `setReboot'\",\r\n \"/home/lzap/work/foreman/app/models/concerns/orchestration.rb:141:in `execute'\",\r\n \"/home/lzap/work/foreman/app/models/concerns/orchestration.rb:86:in `block in process'\",\r\n \"/home/lzap/work/foreman/app/models/concerns/orchestration.rb:78:in `each'\",\r\n \"/home/lzap/work/foreman/app/models/concerns/orchestration.rb:78:in `process'\",\r\n \"/home/lzap/work/foreman/app/models/concerns/orchestration.rb:23:in `post_commit'\",\r\n...\r\n \"/home/lzap/work/foreman/app/models/host.rb:15:in `method_missing'\",\r\n \"/home/lzap/work/foreman_discovery/app/controllers/discovered_hosts_controller.rb:69:in `update'\",\r\n```","created_at":"2015-05-27T09:36:18Z","updated_at":"2015-05-27T09:36:18Z","html_url":"https://github.com/theforeman/foreman_discovery/pull/188#discussion_r31117078","pull_request_url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188","_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/comments/31117078"},"html":{"href":"https://github.com/theforeman/foreman_discovery/pull/188#discussion_r31117078"},"pull_request":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188"}}},"pull_request":{"url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188","id":35822598,"html_url":"https://github.com/theforeman/foreman_discovery/pull/188","diff_url":"https://github.com/theforeman/foreman_discovery/pull/188.diff","patch_url":"https://github.com/theforeman/foreman_discovery/pull/188.patch","issue_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/188","number":188,"state":"open","locked":false,"title":"Fixes #10195 - discovered node is no longer rebooted on error","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"body":"Also made sure that failure during reboot does not rollback. In future, we can\ninform the user to initiate the reboot manually (in case there was a connection\nissue or something).","created_at":"2015-05-20T11:36:59Z","updated_at":"2015-05-27T09:36:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f0e6c1bf3de7686098f9d476512b20f134a9b929","assignee":null,"milestone":{"url":"https://api.github.com/repos/theforeman/foreman_discovery/milestones/5","html_url":"https://github.com/theforeman/foreman_discovery/milestones/3.0.1","labels_url":"https://api.github.com/repos/theforeman/foreman_discovery/milestones/5/labels","id":1050361,"number":5,"title":"3.0.1","description":"","creator":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":1,"state":"open","created_at":"2015-04-02T13:43:31Z","updated_at":"2015-05-20T11:38:10Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188/commits","review_comments_url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188/comments","review_comment_url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/188/comments","statuses_url":"https://api.github.com/repos/theforeman/foreman_discovery/statuses/d14b6c3aea7994daf8dd08c55234676e4c1b18fb","head":{"label":"lzap:rebooting-10195","ref":"rebooting-10195","sha":"d14b6c3aea7994daf8dd08c55234676e4c1b18fb","user":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"repo":{"id":11420293,"name":"foreman_discovery","full_name":"lzap/foreman_discovery","owner":{"login":"lzap","id":49752,"avatar_url":"https://avatars.githubusercontent.com/u/49752?v=3","gravatar_id":"","url":"https://api.github.com/users/lzap","html_url":"https://github.com/lzap","followers_url":"https://api.github.com/users/lzap/followers","following_url":"https://api.github.com/users/lzap/following{/other_user}","gists_url":"https://api.github.com/users/lzap/gists{/gist_id}","starred_url":"https://api.github.com/users/lzap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lzap/subscriptions","organizations_url":"https://api.github.com/users/lzap/orgs","repos_url":"https://api.github.com/users/lzap/repos","events_url":"https://api.github.com/users/lzap/events{/privacy}","received_events_url":"https://api.github.com/users/lzap/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lzap/foreman_discovery","description":"A plugin to enable Metal-as-a-Service discovery functionality in foreman","fork":true,"url":"https://api.github.com/repos/lzap/foreman_discovery","forks_url":"https://api.github.com/repos/lzap/foreman_discovery/forks","keys_url":"https://api.github.com/repos/lzap/foreman_discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lzap/foreman_discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lzap/foreman_discovery/teams","hooks_url":"https://api.github.com/repos/lzap/foreman_discovery/hooks","issue_events_url":"https://api.github.com/repos/lzap/foreman_discovery/issues/events{/number}","events_url":"https://api.github.com/repos/lzap/foreman_discovery/events","assignees_url":"https://api.github.com/repos/lzap/foreman_discovery/assignees{/user}","branches_url":"https://api.github.com/repos/lzap/foreman_discovery/branches{/branch}","tags_url":"https://api.github.com/repos/lzap/foreman_discovery/tags","blobs_url":"https://api.github.com/repos/lzap/foreman_discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lzap/foreman_discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lzap/foreman_discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/lzap/foreman_discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lzap/foreman_discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/lzap/foreman_discovery/languages","stargazers_url":"https://api.github.com/repos/lzap/foreman_discovery/stargazers","contributors_url":"https://api.github.com/repos/lzap/foreman_discovery/contributors","subscribers_url":"https://api.github.com/repos/lzap/foreman_discovery/subscribers","subscription_url":"https://api.github.com/repos/lzap/foreman_discovery/subscription","commits_url":"https://api.github.com/repos/lzap/foreman_discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/lzap/foreman_discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/lzap/foreman_discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/lzap/foreman_discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/lzap/foreman_discovery/contents/{+path}","compare_url":"https://api.github.com/repos/lzap/foreman_discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lzap/foreman_discovery/merges","archive_url":"https://api.github.com/repos/lzap/foreman_discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lzap/foreman_discovery/downloads","issues_url":"https://api.github.com/repos/lzap/foreman_discovery/issues{/number}","pulls_url":"https://api.github.com/repos/lzap/foreman_discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/lzap/foreman_discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/lzap/foreman_discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lzap/foreman_discovery/labels{/name}","releases_url":"https://api.github.com/repos/lzap/foreman_discovery/releases{/id}","created_at":"2013-07-15T10:06:41Z","updated_at":"2014-11-26T16:17:53Z","pushed_at":"2015-05-20T11:39:32Z","git_url":"git://github.com/lzap/foreman_discovery.git","ssh_url":"git@github.com:lzap/foreman_discovery.git","clone_url":"https://github.com/lzap/foreman_discovery.git","svn_url":"https://github.com/lzap/foreman_discovery","homepage":null,"size":1179,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"theforeman:develop","ref":"develop","sha":"009bb13e093bef968461ca4121e97fbfa1d2d370","user":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"repo":{"id":8454019,"name":"foreman_discovery","full_name":"theforeman/foreman_discovery","owner":{"login":"theforeman","id":1439844,"avatar_url":"https://avatars.githubusercontent.com/u/1439844?v=3","gravatar_id":"","url":"https://api.github.com/users/theforeman","html_url":"https://github.com/theforeman","followers_url":"https://api.github.com/users/theforeman/followers","following_url":"https://api.github.com/users/theforeman/following{/other_user}","gists_url":"https://api.github.com/users/theforeman/gists{/gist_id}","starred_url":"https://api.github.com/users/theforeman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theforeman/subscriptions","organizations_url":"https://api.github.com/users/theforeman/orgs","repos_url":"https://api.github.com/users/theforeman/repos","events_url":"https://api.github.com/users/theforeman/events{/privacy}","received_events_url":"https://api.github.com/users/theforeman/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theforeman/foreman_discovery","description":"A plugin to enable Metal-as-a-Service discovery functionality in foreman","fork":false,"url":"https://api.github.com/repos/theforeman/foreman_discovery","forks_url":"https://api.github.com/repos/theforeman/foreman_discovery/forks","keys_url":"https://api.github.com/repos/theforeman/foreman_discovery/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theforeman/foreman_discovery/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theforeman/foreman_discovery/teams","hooks_url":"https://api.github.com/repos/theforeman/foreman_discovery/hooks","issue_events_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/events{/number}","events_url":"https://api.github.com/repos/theforeman/foreman_discovery/events","assignees_url":"https://api.github.com/repos/theforeman/foreman_discovery/assignees{/user}","branches_url":"https://api.github.com/repos/theforeman/foreman_discovery/branches{/branch}","tags_url":"https://api.github.com/repos/theforeman/foreman_discovery/tags","blobs_url":"https://api.github.com/repos/theforeman/foreman_discovery/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theforeman/foreman_discovery/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theforeman/foreman_discovery/git/refs{/sha}","trees_url":"https://api.github.com/repos/theforeman/foreman_discovery/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theforeman/foreman_discovery/statuses/{sha}","languages_url":"https://api.github.com/repos/theforeman/foreman_discovery/languages","stargazers_url":"https://api.github.com/repos/theforeman/foreman_discovery/stargazers","contributors_url":"https://api.github.com/repos/theforeman/foreman_discovery/contributors","subscribers_url":"https://api.github.com/repos/theforeman/foreman_discovery/subscribers","subscription_url":"https://api.github.com/repos/theforeman/foreman_discovery/subscription","commits_url":"https://api.github.com/repos/theforeman/foreman_discovery/commits{/sha}","git_commits_url":"https://api.github.com/repos/theforeman/foreman_discovery/git/commits{/sha}","comments_url":"https://api.github.com/repos/theforeman/foreman_discovery/comments{/number}","issue_comment_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues/comments{/number}","contents_url":"https://api.github.com/repos/theforeman/foreman_discovery/contents/{+path}","compare_url":"https://api.github.com/repos/theforeman/foreman_discovery/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theforeman/foreman_discovery/merges","archive_url":"https://api.github.com/repos/theforeman/foreman_discovery/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theforeman/foreman_discovery/downloads","issues_url":"https://api.github.com/repos/theforeman/foreman_discovery/issues{/number}","pulls_url":"https://api.github.com/repos/theforeman/foreman_discovery/pulls{/number}","milestones_url":"https://api.github.com/repos/theforeman/foreman_discovery/milestones{/number}","notifications_url":"https://api.github.com/repos/theforeman/foreman_discovery/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theforeman/foreman_discovery/labels{/name}","releases_url":"https://api.github.com/repos/theforeman/foreman_discovery/releases{/id}","created_at":"2013-02-27T10:45:55Z","updated_at":"2015-05-05T08:54:00Z","pushed_at":"2015-05-20T11:39:32Z","git_url":"git://github.com/theforeman/foreman_discovery.git","ssh_url":"git@github.com:theforeman/foreman_discovery.git","clone_url":"https://github.com/theforeman/foreman_discovery.git","svn_url":"https://github.com/theforeman/foreman_discovery","homepage":null,"size":3270,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":14,"forks":30,"open_issues":14,"watchers":23,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188"},"html":{"href":"https://github.com/theforeman/foreman_discovery/pull/188"},"issue":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/issues/188"},"comments":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/issues/188/comments"},"review_comments":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188/comments"},"review_comment":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/pulls/188/commits"},"statuses":{"href":"https://api.github.com/repos/theforeman/foreman_discovery/statuses/d14b6c3aea7994daf8dd08c55234676e4c1b18fb"}}}}