{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/22503760","id":22503760,"diff_hunk":"@@ -72,6 +72,9 @@ public function finishView(FormView $view, FormInterface $form, array $options);\n      * Sets the default options for this type.\n      *\n      * @param OptionsResolverInterface $resolver The resolver for the options.\n+     *\n+     * @deprecated Deprecated since Symfony 2.7, to be removed in Symfony 3.0.\n+     *             Use {@link FormTypeInterface::configureOptions()} instead.","path":"src/Symfony/Component/Form/FormTypeInterface.php","position":6,"original_position":6,"commit_id":"41079cfdfec1c92218b608d6c50de63878243688","original_commit_id":"41079cfdfec1c92218b608d6c50de63878243688","user":{"login":"stof","id":439401,"avatar_url":"https://avatars.githubusercontent.com/u/439401?v=3","gravatar_id":"","url":"https://api.github.com/users/stof","html_url":"https://github.com/stof","followers_url":"https://api.github.com/users/stof/followers","following_url":"https://api.github.com/users/stof/following{/other_user}","gists_url":"https://api.github.com/users/stof/gists{/gist_id}","starred_url":"https://api.github.com/users/stof/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stof/subscriptions","organizations_url":"https://api.github.com/users/stof/orgs","repos_url":"https://api.github.com/users/stof/repos","events_url":"https://api.github.com/users/stof/events{/privacy}","received_events_url":"https://api.github.com/users/stof/received_events","type":"User","site_admin":false},"body":"the method is not in the interface yet","created_at":"2015-01-06T01:42:11Z","updated_at":"2015-01-06T01:42:11Z","html_url":"https://github.com/symfony/symfony/pull/12891#discussion_r22503760","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/12891","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/22503760"},"html":{"href":"https://github.com/symfony/symfony/pull/12891#discussion_r22503760"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12891"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/12891","id":25649075,"html_url":"https://github.com/symfony/symfony/pull/12891","diff_url":"https://github.com/symfony/symfony/pull/12891.diff","patch_url":"https://github.com/symfony/symfony/pull/12891.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/12891","number":12891,"state":"open","locked":false,"title":"[Form] Deprecated setDefaultOptions() in favor of configureOptions()","user":{"login":"peterrehm","id":2010989,"avatar_url":"https://avatars.githubusercontent.com/u/2010989?v=3","gravatar_id":"","url":"https://api.github.com/users/peterrehm","html_url":"https://github.com/peterrehm","followers_url":"https://api.github.com/users/peterrehm/followers","following_url":"https://api.github.com/users/peterrehm/following{/other_user}","gists_url":"https://api.github.com/users/peterrehm/gists{/gist_id}","starred_url":"https://api.github.com/users/peterrehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterrehm/subscriptions","organizations_url":"https://api.github.com/users/peterrehm/orgs","repos_url":"https://api.github.com/users/peterrehm/repos","events_url":"https://api.github.com/users/peterrehm/events{/privacy}","received_events_url":"https://api.github.com/users/peterrehm/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      | no\r\n| New feature?  | no\r\n| BC breaks?    | no\r\n| Deprecations? | yes\r\n| Tests pass?   |  \r\n| Fixed tickets | #12782\r\n| License       | MIT\r\n| Doc PR        | will be provided after approval\r\n\r\nThis tries to provide a compatible API with the depreciation of the OptionResolverInterface. I would like to have this in 2.6.2 but I think that might not be possible? To me I think we should always provide an API where you do not need to use deprecated classes.\r\n\r\nAlso can you think of any way to trigger errors on the use of the deprecated setDefaultOptions() method? Since it is usually overwritten without calling the parent class this might be tricky. Maybe only in the resolver if we can check if actual options has been resolved in a call to setDefaultOptions.","created_at":"2014-12-08T07:12:08Z","updated_at":"2015-01-06T01:42:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61bd479ff3759c25e872a13f7a7dc5d33fcc666b","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/12891/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/12891/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/12891/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/41079cfdfec1c92218b608d6c50de63878243688","head":{"label":"peterrehm:abstract-type","ref":"abstract-type","sha":"41079cfdfec1c92218b608d6c50de63878243688","user":{"login":"peterrehm","id":2010989,"avatar_url":"https://avatars.githubusercontent.com/u/2010989?v=3","gravatar_id":"","url":"https://api.github.com/users/peterrehm","html_url":"https://github.com/peterrehm","followers_url":"https://api.github.com/users/peterrehm/followers","following_url":"https://api.github.com/users/peterrehm/following{/other_user}","gists_url":"https://api.github.com/users/peterrehm/gists{/gist_id}","starred_url":"https://api.github.com/users/peterrehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterrehm/subscriptions","organizations_url":"https://api.github.com/users/peterrehm/orgs","repos_url":"https://api.github.com/users/peterrehm/repos","events_url":"https://api.github.com/users/peterrehm/events{/privacy}","received_events_url":"https://api.github.com/users/peterrehm/received_events","type":"User","site_admin":false},"repo":{"id":11863265,"name":"symfony","full_name":"peterrehm/symfony","owner":{"login":"peterrehm","id":2010989,"avatar_url":"https://avatars.githubusercontent.com/u/2010989?v=3","gravatar_id":"","url":"https://api.github.com/users/peterrehm","html_url":"https://github.com/peterrehm","followers_url":"https://api.github.com/users/peterrehm/followers","following_url":"https://api.github.com/users/peterrehm/following{/other_user}","gists_url":"https://api.github.com/users/peterrehm/gists{/gist_id}","starred_url":"https://api.github.com/users/peterrehm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterrehm/subscriptions","organizations_url":"https://api.github.com/users/peterrehm/orgs","repos_url":"https://api.github.com/users/peterrehm/repos","events_url":"https://api.github.com/users/peterrehm/events{/privacy}","received_events_url":"https://api.github.com/users/peterrehm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/peterrehm/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/peterrehm/symfony","forks_url":"https://api.github.com/repos/peterrehm/symfony/forks","keys_url":"https://api.github.com/repos/peterrehm/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/peterrehm/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/peterrehm/symfony/teams","hooks_url":"https://api.github.com/repos/peterrehm/symfony/hooks","issue_events_url":"https://api.github.com/repos/peterrehm/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/peterrehm/symfony/events","assignees_url":"https://api.github.com/repos/peterrehm/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/peterrehm/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/peterrehm/symfony/tags","blobs_url":"https://api.github.com/repos/peterrehm/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/peterrehm/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/peterrehm/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/peterrehm/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/peterrehm/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/peterrehm/symfony/languages","stargazers_url":"https://api.github.com/repos/peterrehm/symfony/stargazers","contributors_url":"https://api.github.com/repos/peterrehm/symfony/contributors","subscribers_url":"https://api.github.com/repos/peterrehm/symfony/subscribers","subscription_url":"https://api.github.com/repos/peterrehm/symfony/subscription","commits_url":"https://api.github.com/repos/peterrehm/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/peterrehm/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/peterrehm/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/peterrehm/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/peterrehm/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/peterrehm/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/peterrehm/symfony/merges","archive_url":"https://api.github.com/repos/peterrehm/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/peterrehm/symfony/downloads","issues_url":"https://api.github.com/repos/peterrehm/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/peterrehm/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/peterrehm/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/peterrehm/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/peterrehm/symfony/labels{/name}","releases_url":"https://api.github.com/repos/peterrehm/symfony/releases{/id}","created_at":"2013-08-03T13:10:09Z","updated_at":"2014-11-24T08:07:06Z","pushed_at":"2015-01-04T12:46:26Z","git_url":"git://github.com/peterrehm/symfony.git","ssh_url":"git@github.com:peterrehm/symfony.git","clone_url":"https://github.com/peterrehm/symfony.git","svn_url":"https://github.com/peterrehm/symfony","homepage":"symfony.com","size":48795,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:2.7","ref":"2.7","sha":"f8fb8a98b2f9d797483a020cee3ec6ad2e82c366","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments/{number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","created_at":"2010-01-04T14:21:21Z","updated_at":"2015-01-06T00:07:19Z","pushed_at":"2015-01-05T21:00:18Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"symfony.com","size":184240,"stargazers_count":9468,"watchers_count":9468,"language":"PHP","has_issues":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":3691,"mirror_url":null,"open_issues_count":789,"forks":3691,"open_issues":789,"watchers":9468,"default_branch":"2.7"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12891"},"html":{"href":"https://github.com/symfony/symfony/pull/12891"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/12891"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/12891/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12891/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/{number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/12891/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/41079cfdfec1c92218b608d6c50de63878243688"}}}}