{"action":"created","comment":{"url":"https://api.github.com/repos/idaholab/moose/pulls/comments/35770290","id":35770290,"diff_hunk":"@@ -102,7 +102,6 @@ class MultiAppTransfer : public Transfer\n    */\n   NumericVector<Real> & getTransferVector(unsigned int i_local, std::string var_name);\n \n-private:\n   // Given local app index, returns global app index.\n   std::vector<unsigned int> _local2global_map;","path":"framework/include/transfers/MultiAppTransfer.h","position":6,"original_position":6,"commit_id":"8811c31ef41cceeaccfd9a6baf551312cdf1adf8","original_commit_id":"8811c31ef41cceeaccfd9a6baf551312cdf1adf8","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"body":"I think it needs to become protected.  I've used it now in two derived classes (`MultiAppMeshFunctionTransfer` and `MultiAppProjectionTransfer`)","created_at":"2015-07-29T15:06:24Z","updated_at":"2015-07-29T15:06:24Z","html_url":"https://github.com/idaholab/moose/pull/5461#discussion_r35770290","pull_request_url":"https://api.github.com/repos/idaholab/moose/pulls/5461","_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments/35770290"},"html":{"href":"https://github.com/idaholab/moose/pull/5461#discussion_r35770290"},"pull_request":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5461"}}},"pull_request":{"url":"https://api.github.com/repos/idaholab/moose/pulls/5461","id":41067857,"html_url":"https://github.com/idaholab/moose/pull/5461","diff_url":"https://github.com/idaholab/moose/pull/5461.diff","patch_url":"https://github.com/idaholab/moose/pull/5461.patch","issue_url":"https://api.github.com/repos/idaholab/moose/issues/5461","number":5461,"state":"open","locked":false,"title":"Refactor MultiAppMeshFunctionTransfer","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"body":"`MultiAppMeshFunctionTransfer` is the latest on the chopping block.  It no longer requires solution serialization and it works with parallel mesh.  I'm getting all passes with any number of procs between 1 and 12 (inclusive).  See:\r\n\r\n```\r\nfor i in `seq 1 12`; do ./run_tests --re \"multiapp_mesh_function\" -p $i --cli-args=\"--parallel-mesh\"; echo $i; done\r\n```\r\n\r\nLarge sections of this are copy-pasted from `NearestNodeTransfer` and the #5425 version of `MultiAppProjectionTransfer` so I think there is some room for consolidating functionality into a base class.  That said, I would rather leave such consolidation out of this PR because I expect it to take a non-trivial amount of time to design, and it'll be more useful after #5425 is merged in anyway.\r\n\r\nCloses #2145.","created_at":"2015-07-28T22:21:52Z","updated_at":"2015-07-29T15:06:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"84a7ef70f1231a207c6487c8539e66d599082993","assignee":null,"milestone":null,"commits_url":"https://api.github.com/repos/idaholab/moose/pulls/5461/commits","review_comments_url":"https://api.github.com/repos/idaholab/moose/pulls/5461/comments","review_comment_url":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}","comments_url":"https://api.github.com/repos/idaholab/moose/issues/5461/comments","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/8811c31ef41cceeaccfd9a6baf551312cdf1adf8","head":{"label":"smharper:meshfuntransfer_refactor","ref":"meshfuntransfer_refactor","sha":"8811c31ef41cceeaccfd9a6baf551312cdf1adf8","user":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"repo":{"id":36745057,"name":"moose","full_name":"smharper/moose","owner":{"login":"smharper","id":4622797,"avatar_url":"https://avatars.githubusercontent.com/u/4622797?v=3","gravatar_id":"","url":"https://api.github.com/users/smharper","html_url":"https://github.com/smharper","followers_url":"https://api.github.com/users/smharper/followers","following_url":"https://api.github.com/users/smharper/following{/other_user}","gists_url":"https://api.github.com/users/smharper/gists{/gist_id}","starred_url":"https://api.github.com/users/smharper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smharper/subscriptions","organizations_url":"https://api.github.com/users/smharper/orgs","repos_url":"https://api.github.com/users/smharper/repos","events_url":"https://api.github.com/users/smharper/events{/privacy}","received_events_url":"https://api.github.com/users/smharper/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smharper/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":true,"url":"https://api.github.com/repos/smharper/moose","forks_url":"https://api.github.com/repos/smharper/moose/forks","keys_url":"https://api.github.com/repos/smharper/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smharper/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smharper/moose/teams","hooks_url":"https://api.github.com/repos/smharper/moose/hooks","issue_events_url":"https://api.github.com/repos/smharper/moose/issues/events{/number}","events_url":"https://api.github.com/repos/smharper/moose/events","assignees_url":"https://api.github.com/repos/smharper/moose/assignees{/user}","branches_url":"https://api.github.com/repos/smharper/moose/branches{/branch}","tags_url":"https://api.github.com/repos/smharper/moose/tags","blobs_url":"https://api.github.com/repos/smharper/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smharper/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smharper/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/smharper/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smharper/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/smharper/moose/languages","stargazers_url":"https://api.github.com/repos/smharper/moose/stargazers","contributors_url":"https://api.github.com/repos/smharper/moose/contributors","subscribers_url":"https://api.github.com/repos/smharper/moose/subscribers","subscription_url":"https://api.github.com/repos/smharper/moose/subscription","commits_url":"https://api.github.com/repos/smharper/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/smharper/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/smharper/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/smharper/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/smharper/moose/contents/{+path}","compare_url":"https://api.github.com/repos/smharper/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smharper/moose/merges","archive_url":"https://api.github.com/repos/smharper/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smharper/moose/downloads","issues_url":"https://api.github.com/repos/smharper/moose/issues{/number}","pulls_url":"https://api.github.com/repos/smharper/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/smharper/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/smharper/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smharper/moose/labels{/name}","releases_url":"https://api.github.com/repos/smharper/moose/releases{/id}","created_at":"2015-06-02T16:07:42Z","updated_at":"2015-06-12T23:15:28Z","pushed_at":"2015-07-29T15:00:32Z","git_url":"git://github.com/smharper/moose.git","ssh_url":"git@github.com:smharper/moose.git","clone_url":"https://github.com/smharper/moose.git","svn_url":"https://github.com/smharper/moose","homepage":"http://www.mooseframework.org","size":111162,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"devel"}},"base":{"label":"idaholab:devel","ref":"devel","sha":"0d4c63a1e732a4272fa847a83b00164cf3a6aa37","user":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"repo":{"id":16851223,"name":"moose","full_name":"idaholab/moose","owner":{"login":"idaholab","id":3855370,"avatar_url":"https://avatars.githubusercontent.com/u/3855370?v=3","gravatar_id":"","url":"https://api.github.com/users/idaholab","html_url":"https://github.com/idaholab","followers_url":"https://api.github.com/users/idaholab/followers","following_url":"https://api.github.com/users/idaholab/following{/other_user}","gists_url":"https://api.github.com/users/idaholab/gists{/gist_id}","starred_url":"https://api.github.com/users/idaholab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idaholab/subscriptions","organizations_url":"https://api.github.com/users/idaholab/orgs","repos_url":"https://api.github.com/users/idaholab/repos","events_url":"https://api.github.com/users/idaholab/events{/privacy}","received_events_url":"https://api.github.com/users/idaholab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/idaholab/moose","description":"Multiphysics Object Oriented Simulation Environment","fork":false,"url":"https://api.github.com/repos/idaholab/moose","forks_url":"https://api.github.com/repos/idaholab/moose/forks","keys_url":"https://api.github.com/repos/idaholab/moose/keys{/key_id}","collaborators_url":"https://api.github.com/repos/idaholab/moose/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/idaholab/moose/teams","hooks_url":"https://api.github.com/repos/idaholab/moose/hooks","issue_events_url":"https://api.github.com/repos/idaholab/moose/issues/events{/number}","events_url":"https://api.github.com/repos/idaholab/moose/events","assignees_url":"https://api.github.com/repos/idaholab/moose/assignees{/user}","branches_url":"https://api.github.com/repos/idaholab/moose/branches{/branch}","tags_url":"https://api.github.com/repos/idaholab/moose/tags","blobs_url":"https://api.github.com/repos/idaholab/moose/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/idaholab/moose/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/idaholab/moose/git/refs{/sha}","trees_url":"https://api.github.com/repos/idaholab/moose/git/trees{/sha}","statuses_url":"https://api.github.com/repos/idaholab/moose/statuses/{sha}","languages_url":"https://api.github.com/repos/idaholab/moose/languages","stargazers_url":"https://api.github.com/repos/idaholab/moose/stargazers","contributors_url":"https://api.github.com/repos/idaholab/moose/contributors","subscribers_url":"https://api.github.com/repos/idaholab/moose/subscribers","subscription_url":"https://api.github.com/repos/idaholab/moose/subscription","commits_url":"https://api.github.com/repos/idaholab/moose/commits{/sha}","git_commits_url":"https://api.github.com/repos/idaholab/moose/git/commits{/sha}","comments_url":"https://api.github.com/repos/idaholab/moose/comments{/number}","issue_comment_url":"https://api.github.com/repos/idaholab/moose/issues/comments{/number}","contents_url":"https://api.github.com/repos/idaholab/moose/contents/{+path}","compare_url":"https://api.github.com/repos/idaholab/moose/compare/{base}...{head}","merges_url":"https://api.github.com/repos/idaholab/moose/merges","archive_url":"https://api.github.com/repos/idaholab/moose/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/idaholab/moose/downloads","issues_url":"https://api.github.com/repos/idaholab/moose/issues{/number}","pulls_url":"https://api.github.com/repos/idaholab/moose/pulls{/number}","milestones_url":"https://api.github.com/repos/idaholab/moose/milestones{/number}","notifications_url":"https://api.github.com/repos/idaholab/moose/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/idaholab/moose/labels{/name}","releases_url":"https://api.github.com/repos/idaholab/moose/releases{/id}","created_at":"2014-02-14T22:26:15Z","updated_at":"2015-07-25T05:04:33Z","pushed_at":"2015-07-29T15:00:33Z","git_url":"git://github.com/idaholab/moose.git","ssh_url":"git@github.com:idaholab/moose.git","clone_url":"https://github.com/idaholab/moose.git","svn_url":"https://github.com/idaholab/moose","homepage":"http://www.mooseframework.org","size":130836,"stargazers_count":91,"watchers_count":91,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":145,"mirror_url":null,"open_issues_count":489,"forks":145,"open_issues":489,"watchers":91,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5461"},"html":{"href":"https://github.com/idaholab/moose/pull/5461"},"issue":{"href":"https://api.github.com/repos/idaholab/moose/issues/5461"},"comments":{"href":"https://api.github.com/repos/idaholab/moose/issues/5461/comments"},"review_comments":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5461/comments"},"review_comment":{"href":"https://api.github.com/repos/idaholab/moose/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/idaholab/moose/pulls/5461/commits"},"statuses":{"href":"https://api.github.com/repos/idaholab/moose/statuses/8811c31ef41cceeaccfd9a6baf551312cdf1adf8"}}}}