{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/files_texteditor/pulls/comments/31945938","id":31945938,"diff_hunk":"@@ -1,14 +1,39 @@\n <?php\n /**\n- * Copyright (c) 2014 Robin Appelman <icewind@owncloud.com>\n- * This file is licensed under the Affero General Public License version 3 or\n- * later.\n- * See the COPYING-README file.\n+ * @author Björn Schießle <schiessle@owncloud.com>\n+ *\n+ * @copyright Copyright (c) 2015, ownCloud, Inc.\n+ * @license AGPL-3.0\n+ *\n+ * This code is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Affero General Public License, version 3,\n+ * as published by the Free Software Foundation.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the\n+ * GNU Affero General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU Affero General Public License, version 3,\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>\n+ *\n  */\n \n-/** @var $this OC\\Route\\Router */\n \n-$this->create('files_texteditor_load', '/ajax/loadfile.php')\n-\t->actionInclude('files_texteditor/ajax/loadfile.php');\n-$this->create('files_texteditor_save', 'ajax/savefile.php')\n-\t->actionInclude('files_texteditor/ajax/savefile.php');\n+namespace OCA\\Files_Texteditor\\AppInfo;\n+\n+$app = new Application();\n+\n+$app->registerRoutes($this, array('routes' => array(\n+\n+\t[\n+\t\t'name' => 'FileHandling#load',\n+\t\t'url' => '/ajax/loadfile',\n+\t\t'verb' => 'POST'\n+\t],\n+\t[\n+\t\t'name' => 'FileHandling#save',\n+\t\t'url' => '/ajax/savefile',\n+\t\t'verb' => 'POST'","path":"appinfo/routes.php","position":46,"original_position":46,"commit_id":"3564603c52cefa927948d1aedec7300beff835df","original_commit_id":"3564603c52cefa927948d1aedec7300beff835df","user":{"login":"DeepDiver1975","id":1005065,"avatar_url":"https://avatars.githubusercontent.com/u/1005065?v=3","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"body":"generally speaking PUT should fit better - but might require to much changes","created_at":"2015-06-08T18:44:42Z","updated_at":"2015-06-08T18:44:42Z","html_url":"https://github.com/owncloud/files_texteditor/pull/79#discussion_r31945938","pull_request_url":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79","_links":{"self":{"href":"https://api.github.com/repos/owncloud/files_texteditor/pulls/comments/31945938"},"html":{"href":"https://github.com/owncloud/files_texteditor/pull/79#discussion_r31945938"},"pull_request":{"href":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79","id":37180306,"html_url":"https://github.com/owncloud/files_texteditor/pull/79","diff_url":"https://github.com/owncloud/files_texteditor/pull/79.diff","patch_url":"https://github.com/owncloud/files_texteditor/pull/79.patch","issue_url":"https://api.github.com/repos/owncloud/files_texteditor/issues/79","number":79,"state":"open","locked":false,"title":"move load/save file to a controller","user":{"login":"schiesbn","id":1589737,"avatar_url":"https://avatars.githubusercontent.com/u/1589737?v=3","gravatar_id":"","url":"https://api.github.com/users/schiesbn","html_url":"https://github.com/schiesbn","followers_url":"https://api.github.com/users/schiesbn/followers","following_url":"https://api.github.com/users/schiesbn/following{/other_user}","gists_url":"https://api.github.com/users/schiesbn/gists{/gist_id}","starred_url":"https://api.github.com/users/schiesbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schiesbn/subscriptions","organizations_url":"https://api.github.com/users/schiesbn/orgs","repos_url":"https://api.github.com/users/schiesbn/repos","events_url":"https://api.github.com/users/schiesbn/events{/privacy}","received_events_url":"https://api.github.com/users/schiesbn/received_events","type":"User","site_admin":false},"body":" this fix the error response on failed load operation, introduced by this changes: https://github.com/owncloud/files_texteditor/pull/77/files\r\n\r\nWorks and is ready for review... I will add some unit tests for the controller tomorrow.","created_at":"2015-06-08T18:11:02Z","updated_at":"2015-06-08T18:44:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e70fd75b4463e0925cef5aa9cf970fcf9fec0720","assignee":null,"milestone":{"url":"https://api.github.com/repos/owncloud/files_texteditor/milestones/13","html_url":"https://github.com/owncloud/files_texteditor/milestones/8.1-current","labels_url":"https://api.github.com/repos/owncloud/files_texteditor/milestones/13/labels","id":922758,"number":13,"title":"8.1-current","description":"","creator":{"login":"MorrisJobke","id":245432,"avatar_url":"https://avatars.githubusercontent.com/u/245432?v=3","gravatar_id":"","url":"https://api.github.com/users/MorrisJobke","html_url":"https://github.com/MorrisJobke","followers_url":"https://api.github.com/users/MorrisJobke/followers","following_url":"https://api.github.com/users/MorrisJobke/following{/other_user}","gists_url":"https://api.github.com/users/MorrisJobke/gists{/gist_id}","starred_url":"https://api.github.com/users/MorrisJobke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MorrisJobke/subscriptions","organizations_url":"https://api.github.com/users/MorrisJobke/orgs","repos_url":"https://api.github.com/users/MorrisJobke/repos","events_url":"https://api.github.com/users/MorrisJobke/events{/privacy}","received_events_url":"https://api.github.com/users/MorrisJobke/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":8,"state":"open","created_at":"2015-01-05T20:14:10Z","updated_at":"2015-06-08T18:11:11Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79/commits","review_comments_url":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79/comments","review_comment_url":"https://api.github.com/repos/owncloud/files_texteditor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/files_texteditor/issues/79/comments","statuses_url":"https://api.github.com/repos/owncloud/files_texteditor/statuses/3564603c52cefa927948d1aedec7300beff835df","head":{"label":"owncloud:fix_load_save_file","ref":"fix_load_save_file","sha":"3564603c52cefa927948d1aedec7300beff835df","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16583250,"name":"files_texteditor","full_name":"owncloud/files_texteditor","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/files_texteditor","description":"","fork":false,"url":"https://api.github.com/repos/owncloud/files_texteditor","forks_url":"https://api.github.com/repos/owncloud/files_texteditor/forks","keys_url":"https://api.github.com/repos/owncloud/files_texteditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/files_texteditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/files_texteditor/teams","hooks_url":"https://api.github.com/repos/owncloud/files_texteditor/hooks","issue_events_url":"https://api.github.com/repos/owncloud/files_texteditor/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/files_texteditor/events","assignees_url":"https://api.github.com/repos/owncloud/files_texteditor/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/files_texteditor/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/files_texteditor/tags","blobs_url":"https://api.github.com/repos/owncloud/files_texteditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/files_texteditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/files_texteditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/files_texteditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/files_texteditor/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/files_texteditor/languages","stargazers_url":"https://api.github.com/repos/owncloud/files_texteditor/stargazers","contributors_url":"https://api.github.com/repos/owncloud/files_texteditor/contributors","subscribers_url":"https://api.github.com/repos/owncloud/files_texteditor/subscribers","subscription_url":"https://api.github.com/repos/owncloud/files_texteditor/subscription","commits_url":"https://api.github.com/repos/owncloud/files_texteditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/files_texteditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/files_texteditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/files_texteditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/files_texteditor/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/files_texteditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/files_texteditor/merges","archive_url":"https://api.github.com/repos/owncloud/files_texteditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/files_texteditor/downloads","issues_url":"https://api.github.com/repos/owncloud/files_texteditor/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/files_texteditor/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/files_texteditor/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/files_texteditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/files_texteditor/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/files_texteditor/releases{/id}","created_at":"2014-02-06T15:22:42Z","updated_at":"2015-05-04T06:11:16Z","pushed_at":"2015-06-08T18:11:02Z","git_url":"git://github.com/owncloud/files_texteditor.git","ssh_url":"git@github.com:owncloud/files_texteditor.git","clone_url":"https://github.com/owncloud/files_texteditor.git","svn_url":"https://github.com/owncloud/files_texteditor","homepage":null,"size":6936,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":29,"forks":12,"open_issues":29,"watchers":2,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"8748910bf5f44a2687835bf4dd2be9782a8e4ce8","user":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":16583250,"name":"files_texteditor","full_name":"owncloud/files_texteditor","owner":{"login":"owncloud","id":1645051,"avatar_url":"https://avatars.githubusercontent.com/u/1645051?v=3","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/owncloud/files_texteditor","description":"","fork":false,"url":"https://api.github.com/repos/owncloud/files_texteditor","forks_url":"https://api.github.com/repos/owncloud/files_texteditor/forks","keys_url":"https://api.github.com/repos/owncloud/files_texteditor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/files_texteditor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/files_texteditor/teams","hooks_url":"https://api.github.com/repos/owncloud/files_texteditor/hooks","issue_events_url":"https://api.github.com/repos/owncloud/files_texteditor/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/files_texteditor/events","assignees_url":"https://api.github.com/repos/owncloud/files_texteditor/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/files_texteditor/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/files_texteditor/tags","blobs_url":"https://api.github.com/repos/owncloud/files_texteditor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/files_texteditor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/files_texteditor/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/files_texteditor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/files_texteditor/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/files_texteditor/languages","stargazers_url":"https://api.github.com/repos/owncloud/files_texteditor/stargazers","contributors_url":"https://api.github.com/repos/owncloud/files_texteditor/contributors","subscribers_url":"https://api.github.com/repos/owncloud/files_texteditor/subscribers","subscription_url":"https://api.github.com/repos/owncloud/files_texteditor/subscription","commits_url":"https://api.github.com/repos/owncloud/files_texteditor/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/files_texteditor/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/files_texteditor/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/files_texteditor/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/files_texteditor/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/files_texteditor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/files_texteditor/merges","archive_url":"https://api.github.com/repos/owncloud/files_texteditor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/files_texteditor/downloads","issues_url":"https://api.github.com/repos/owncloud/files_texteditor/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/files_texteditor/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/files_texteditor/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/files_texteditor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/files_texteditor/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/files_texteditor/releases{/id}","created_at":"2014-02-06T15:22:42Z","updated_at":"2015-05-04T06:11:16Z","pushed_at":"2015-06-08T18:11:02Z","git_url":"git://github.com/owncloud/files_texteditor.git","ssh_url":"git@github.com:owncloud/files_texteditor.git","clone_url":"https://github.com/owncloud/files_texteditor.git","svn_url":"https://github.com/owncloud/files_texteditor","homepage":null,"size":6936,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"open_issues_count":29,"forks":12,"open_issues":29,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79"},"html":{"href":"https://github.com/owncloud/files_texteditor/pull/79"},"issue":{"href":"https://api.github.com/repos/owncloud/files_texteditor/issues/79"},"comments":{"href":"https://api.github.com/repos/owncloud/files_texteditor/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/files_texteditor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/files_texteditor/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/files_texteditor/statuses/3564603c52cefa927948d1aedec7300beff835df"}}}}