{"action":"created","issue":{"url":"https://api.github.com/repos/ccshiro/cc-buglist/issues/1418","labels_url":"https://api.github.com/repos/ccshiro/cc-buglist/issues/1418/labels{/name}","comments_url":"https://api.github.com/repos/ccshiro/cc-buglist/issues/1418/comments","events_url":"https://api.github.com/repos/ccshiro/cc-buglist/issues/1418/events","html_url":"https://github.com/ccshiro/cc-buglist/issues/1418","id":101529893,"number":1418,"title":"UNIT_SPELLCAST_SUCCEEDED","user":{"login":"ccshiro","id":8135895,"avatar_url":"https://avatars.githubusercontent.com/u/8135895?v=3","gravatar_id":"","url":"https://api.github.com/users/ccshiro","html_url":"https://github.com/ccshiro","followers_url":"https://api.github.com/users/ccshiro/followers","following_url":"https://api.github.com/users/ccshiro/following{/other_user}","gists_url":"https://api.github.com/users/ccshiro/gists{/gist_id}","starred_url":"https://api.github.com/users/ccshiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccshiro/subscriptions","organizations_url":"https://api.github.com/users/ccshiro/orgs","repos_url":"https://api.github.com/users/ccshiro/repos","events_url":"https://api.github.com/users/ccshiro/events{/privacy}","received_events_url":"https://api.github.com/users/ccshiro/received_events","type":"User","site_admin":false},"labels":[{"url":"https://api.github.com/repos/ccshiro/cc-buglist/labels/bug","name":"bug","color":"fc2929"}],"state":"open","locked":false,"assignee":null,"milestone":{"url":"https://api.github.com/repos/ccshiro/cc-buglist/milestones/17","html_url":"https://github.com/ccshiro/cc-buglist/milestones/August%206%20Test","labels_url":"https://api.github.com/repos/ccshiro/cc-buglist/milestones/17/labels","id":1243465,"number":17,"title":"August 6 Test","description":"Issues reported during the test started on August 6.","creator":{"login":"ccnim","id":10582080,"avatar_url":"https://avatars.githubusercontent.com/u/10582080?v=3","gravatar_id":"","url":"https://api.github.com/users/ccnim","html_url":"https://github.com/ccnim","followers_url":"https://api.github.com/users/ccnim/followers","following_url":"https://api.github.com/users/ccnim/following{/other_user}","gists_url":"https://api.github.com/users/ccnim/gists{/gist_id}","starred_url":"https://api.github.com/users/ccnim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccnim/subscriptions","organizations_url":"https://api.github.com/users/ccnim/orgs","repos_url":"https://api.github.com/users/ccnim/repos","events_url":"https://api.github.com/users/ccnim/events{/privacy}","received_events_url":"https://api.github.com/users/ccnim/received_events","type":"User","site_admin":false},"open_issues":196,"closed_issues":88,"state":"open","created_at":"2015-08-06T08:18:00Z","updated_at":"2015-08-18T16:27:18Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2015-08-17T23:23:25Z","updated_at":"2015-08-18T17:06:27Z","closed_at":null,"body":"### Bug\r\nYour target's cast bar can continue despite cast having finished server side, this is especially noticeable on interrupts that happen just as the cast finishes. The caster sees the cast bar update correctly (turns green to indicate success), but the target does not (it continues for a split second despite the interrupt, creating the strange looking visual effect where it appears as if your interrupt had no effect and the cast just continues).\r\n\r\n### Data\r\nOn casting frostbolt the following events trigger:\r\n\r\nServer | Caster | Target\r\n---------| ----------|---------\r\nStart cast | UNIT_SPELLCAST_START | UNIT_SPELLCAST_START\r\nRelease spell* | UNIT_SPELLCAST_SUCCEEDED | Nothing\r\n\r\n\\* This is when your cast bar turns green to indicate a successful cast, and the spell leaves your hands.\r\n\r\nUNIT_SPELLCAST_START is noticeably missing, most likely being the culprit as it is what lets the caster know the cast is done. However, the packet is sent to the target, and indeed it has a noticeable effect (without it the target never stops playing the visual hands glowing and waving cast animation). We believe this event should trigger for the target (see links below) and is a likely culprit to this bug, but we currently do not know how to fix it.\r\n\r\n### Finding info\r\nTo figure out how to fix it we'd need a packet dump from retail TBC, or reversing the client. The latter takes time, but is probably the only option, as we've exhausted other avenues. This seems to work in TrinityCore, but the packet has changed from TBC to WotLK, and there seems to be nothing different about the components that are the same. It's possible the error is unrelated to the packet itself, however, and happens earlier for some reason?\r\n\r\n### Links\r\nThis describes that UNIT_SPELLCAST_START should not be present on instant spells (incorrect atm):\r\nhttp://wow.gamepedia.com/index.php?title=Detecting_an_instant_cast_spell&oldid=1545585\r\n\r\nWe believe UNIT_SPELLCAST_SUCCEEDED should trigger for the target because:\r\n* The above gamepedia would indicate it, since instants apparently don't use start events.\r\n* The UNIT_SPELLCAST_SUCCEEDED API has a target parameter.\r\n* Code using it seems to check the target: https://gist.github.com/tekkub/30085\r\n* Code using it seems to check the target: http://www.arenajunkies.com/topic/34778-msbt-pet-cooldown-notifications/\r\n* Code using it seems to check the target: http://www.wowinterface.com/forums/showpost.php?p=90118&postcount=1\r\n* Discussion about how some addons use it for cooldown tracking (presumably not only for self): http://maintankadin.failsafedesign.com/forum/viewtopic.php?f=9&t=30183&start=15#p628030\r\n\r\n### Addon\r\nHere's the code of the addon I used for testing, in case anyone's interested to try it themselves: https://gist.github.com/ccshiro/612281b4201e93dbb313\r\n"},"comment":{"url":"https://api.github.com/repos/ccshiro/cc-buglist/issues/comments/132281549","html_url":"https://github.com/ccshiro/cc-buglist/issues/1418#issuecomment-132281549","issue_url":"https://api.github.com/repos/ccshiro/cc-buglist/issues/1418","id":132281549,"user":{"login":"opzor","id":13710937,"avatar_url":"https://avatars.githubusercontent.com/u/13710937?v=3","gravatar_id":"","url":"https://api.github.com/users/opzor","html_url":"https://github.com/opzor","followers_url":"https://api.github.com/users/opzor/followers","following_url":"https://api.github.com/users/opzor/following{/other_user}","gists_url":"https://api.github.com/users/opzor/gists{/gist_id}","starred_url":"https://api.github.com/users/opzor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opzor/subscriptions","organizations_url":"https://api.github.com/users/opzor/orgs","repos_url":"https://api.github.com/users/opzor/repos","events_url":"https://api.github.com/users/opzor/events{/privacy}","received_events_url":"https://api.github.com/users/opzor/received_events","type":"User","site_admin":false},"created_at":"2015-08-18T17:06:26Z","updated_at":"2015-08-18T17:06:26Z","body":"DBM starts to use UNIT_SPELLCAST_SUCCEEDED from\r\n\r\nDeadly Boss Mods 4.41-beta-r3466\t[wow3.3.0]\r\nhttp://wow.curseforge.com/addons/deadly-boss-mods/files/?page=2&sort=date"}}